Re: [Libosinfo] [osinfo-db PATCH 0/6] Add "unknown" entries for Enterprise distros

2018-11-15 Thread Fabiano Fidêncio
On Mon, 2018-11-05 at 10:05 +0100, Fabiano Fidêncio wrote: > Although new releases are always patched downstream to support > themselves, upstream is always behind as the new (or in development) > releases will only be part of osinfo-db after they are released. > > One way to s

Re: [Libosinfo] [osinfo-db-tools PATCH 1/1] import: Introduce "--latest" option

2018-11-15 Thread Fabiano Fidêncio
Daniel, On Tue, 2018-10-09 at 16:34 +0200, Fabiano Fidêncio wrote: > --latest option checks whether there's a new osinfo-db available from > the official libosinfo's release website, downloads and install it. > > The download and installation is only then when the versi

Re: [Libosinfo] [PATCH] NetBSD: add NetBSD 7.2 data

2018-11-15 Thread Fabiano Fidêncio
uot;/> Shouldn't 7.2 upgrade and derive-from 7.1.2? [snip] For both patches: Reviewed-by: Fabiano Fidêncio Thanks for the contributions, -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo

[Libosinfo] [osinfo-db, libosinfo PATCH 0/4] Add "maximum" resources

2018-11-14 Thread Fabiano Fidêncio
Please, see the patches osinfo-db: Fabiano Fidêncio (1): schema: Add "maximum" resources data/schema/osinfo.rng.in | 5 + 1 file changed, 5 insertions(+) libosinfo: Fabiano Fidêncio (3): os: Deal with "maximum" resources tes

[Libosinfo] [libosinfo PATCH 2/4] os: Deal with "maximum" resources

2018-11-14 Thread Fabiano Fidêncio
In the samw way OSes have minimum and recommended resources, let's add support for "maximum" resources. https://gitlab.com/libosinfo/osinfo-db/issues/11 Signed-off-by: Fabiano Fidêncio --- osinfo/libosinfo.syms | 3 +++ osinfo/osinfo_loader.c | 8 osinfo/osinfo_os.

[Libosinfo] [libosinfo PATCH 4/4] test-os-resources: Cover maximum resources in tests

2018-11-14 Thread Fabiano Fidêncio
https://gitlab.com/libosinfo/osinfo-db/issues/11 Signed-off-by: Fabiano Fidêncio --- tests/test-os-resources.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c index fa9df6a..6526680 100644

[Libosinfo] [osinfo-db PATCH 1/4] schema: Add "maximum" resources

2018-11-14 Thread Fabiano Fidêncio
In the same way OSes have minimum and recommended resources, let's add support for "maximum" resources. https://gitlab.com/libosinfo/osinfo-db/issues/11 Signed-off-by: Fabiano Fidêncio --- data/schema/osinfo.rng.in | 5 + 1 file changed, 5 insertions(+) diff --git a/d

[Libosinfo] [libosinfo PATCH 3/4] test-os-resources: Make test_minimum_recommended_resources generic

2018-11-14 Thread Fabiano Fidêncio
https://gitlab.com/libosinfo/osinfo-db/issues/11 Signed-off-by: Fabiano Fidêncio --- tests/test-os-resources.c | 136 -- 1 file changed, 72 insertions(+), 64 deletions(-) diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c index fe16b72

[Libosinfo] [libosinfo PATCH v3 05/10] os: Introduce APIs to deal with images

2018-11-14 Thread Fabiano Fidêncio
Let's introduce the needed APIs on os side to deal will the images. For now, there's no info being loaded as the loader part depends on one of these APIs. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- osinfo/libosinfo.syms | 3 +++ osinfo/osinfo_os.c

[Libosinfo] [osinfo-db PATCH v3 01/10] schema: Add support for pre-installed images

2018-11-14 Thread Fabiano Fidêncio
https://download/foo/bar.img Mind that the "variant" is an optional element. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- data/schema/osinfo.rng.in | 36 1 file changed, 36 insertions(+)

[Libosinfo] [libosinfo PATCH v3 04/10] Introduce OsinfoImageList object

2018-11-14 Thread Fabiano Fidêncio
OsinfoImageList object represents has been created to easily deal with OsinfoImage objects. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- osinfo/Makefile.am| 2 + osinfo/libosinfo.syms | 3 ++ osinfo/osinfo.h | 1 + osinfo

[Libosinfo] [osinfo-db PATCH v3 02/10] schema: Add cloud-init attribute to images

2018-11-14 Thread Fabiano Fidêncio
As images may or may support cloud init customization, let's have an optional attribute to the image element that specifies it. It's similar to the "live" attribute we have for ISOs. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- data/schema/osi

[Libosinfo] [libosinfo PATCH v3 03/10] Introduce OsinfoImage object

2018-11-14 Thread Fabiano Fidêncio
for that as they already do a quite good job on this field. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- osinfo/Makefile.am| 2 + osinfo/libosinfo.syms | 7 ++ osinfo/osinfo.h | 1 + osinfo/osinfo_image.c | 268

[Libosinfo] [libosinfo PATCH v3 08/10] tests: Add test-imagelist

2018-11-14 Thread Fabiano Fidêncio
test-imagelist is totally based on test-devicelist. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 + tests/test-imagelist.c | 228 + 2 files changed, 233 insertions(+) create mode

[Libosinfo] [libosinfo PATCH v3 09/10] tests: Add test-imageuris

2018-11-14 Thread Fabiano Fidêncio
In a quite similar way than test-mediauris and test-treeuris, let's have a test for the imageuris. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 ++ tests/test-imageuris.c | 150 + 2

[Libosinfo] [libosinfo PATCH v3 07/10] tests: Add test-image

2018-11-14 Thread Fabiano Fidêncio
test-image tests the basic functionally of OsImage APIs. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 tests/test-image.c | 66 ++ 2 files changed, 71 insertions(+) create mode

[Libosinfo] [libosinfo PATCH v3 00/10] Add support to images

2018-11-14 Thread Fabiano Fidêncio
y has been dropped. - osinfo-db: Fabiano Fidêncio (2): schema: Add support for pre-installed images schema: Add cloud-init attribute to images data/schema/osinfo.rng.in | 41 +++ 1 file changed, 41 insertions(+) - libosinfo: Fabiano F

Re: [Libosinfo] [libosinfo PATCH 0/3] Add tests for OsinfoImage

2018-11-14 Thread Fabiano Fidêncio
Due to some discussions that happened in the gitlab, I'll submit a new version of this series soon, together with the v3 of the Image work. *: https://gitlab.com/libosinfo/osinfo-db/issues/10#note_117164082 **: https://gitlab.com/libosinfo/osinfo-db/issues/10#note_117164148 [snip]

Re: [Libosinfo] [osinfo-db/libosinfo PATCH v2 0/5] Add support to images

2018-11-14 Thread Fabiano Fidêncio
Due to some discussions that happened in the gitlab, I'll submit a v3 of this series soon. *: https://gitlab.com/libosinfo/osinfo-db/issues/10#note_117164082 **: https://gitlab.com/libosinfo/osinfo-db/issues/10#note_117164148 [snip] ___ Libosinfo

[Libosinfo] [libosinfo PATCH v2 5/6] os: Support inherited resources

2018-11-14 Thread Fabiano Fidêncio
https://gitlab.com/libosinfo/osinfo-db/issues/15 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_os.c | 106 - 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_os.c b/osinfo/osinfo_os.c index 4246069..1990ede 100644

[Libosinfo] [libosinfo PATCH v2 3/6] loader: Set "inherit" accordingly to the resources

2018-11-14 Thread Fabiano Fidêncio
the current behaviour. https://gitlab.com/libosinfo/osinfo-db/issues/15 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_loader.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c index d1bf61d..21a20fe 100644 --- a/osinf

[Libosinfo] [osinfo-db PATCH v2 1/6] schema: Add 'inherit' attribute to resources element

2018-11-14 Thread Fabiano Fidêncio
/issues/15 Signed-off-by: Fabiano Fidêncio --- data/schema/osinfo.rng.in | 5 + 1 file changed, 5 insertions(+) diff --git a/data/schema/osinfo.rng.in b/data/schema/osinfo.rng.in index 6693391..fef7d01 100644 --- a/data/schema/osinfo.rng.in +++ b/data/schema/osinfo.rng.in @@ -287

[Libosinfo] [libosinfo PATCH v2 6/6] test-os: Add test_resources_inheritance()

2018-11-14 Thread Fabiano Fidêncio
Now that resources are inherited between OSes that derives-from/clone some other OS, let's have a test case to ensure it's not going to break in the future. https://gitlab.com/libosinfo/osinfo-db/issues/15 Signed-off-by: Fabiano Fidêncio --- .../test-os-resources-inheritance-1.xml | 25

[Libosinfo] [libosinfo PATCH v2 2/6] resources: Add osinfo_resources_{get, set}_inherit()

2018-11-14 Thread Fabiano Fidêncio
Those two private functions will help to keep track whether the resources should be inherited or not. https://gitlab.com/libosinfo/osinfo-db/issues/15 Signed-off-by: Fabiano Fidêncio --- osinfo/Makefile.am| 1 + osinfo/osinfo_resources.c | 33

Re: [Libosinfo] [libosinfo PATCH 0/2] test-os-resources: Fix typo + move tests to test-os

2018-11-13 Thread Fabiano Fidêncio
On Tue, 2018-11-13 at 12:18 +0100, Fabiano Fidêncio wrote: > Please, see commit messages. > > Fabiano Fidêncio (2): > test-os-resources: Fix typo in test_minimum_recommended_resources() > test-os: move test-os-resources tests > > tests/Makefile.am |

[Libosinfo] [libosinfo PATCH] test-os: Add test_resources_uniqueness()

2018-11-13 Thread Fabiano Fidêncio
This test enforces that we'll never have more than one resources entry for the very same architecture in an OS entry. Signed-off-by: Fabiano Fidêncio --- This patch's been written atop of https://www.redhat.com/archives/libosinfo/2018-November/msg00108.html --- tests/test-os.c | 72

[Libosinfo] [libosinfo PATCH v2 0/2] test-os-resources: Fix typo + move tests to test-os

2018-11-13 Thread Fabiano Fidêncio
Please, see commit messages. - Changes since v1: https://www.redhat.com/archives/libosinfo/2018-November/msg00104.html - Actually remove test-os-resources; - Call osinfo_resources{,list}_get_type() in test-os main(); Fabiano Fidêncio (2): test-os-resources: Fix typo

[Libosinfo] [libosinfo PATCH v2 1/2] test-os-resources: Fix typo in test_minimum_recommended_resources()

2018-11-13 Thread Fabiano Fidêncio
Thanks to this typo the test was iterating over a single OS, always. Signed-off-by: Fabiano Fidêncio --- tests/test-os-resources.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c index fe16b72..a8a9018 100644 --- a/tests

[Libosinfo] [libosinfo PATCH v2 2/2] test-os: move test-os-resources tests

2018-11-13 Thread Fabiano Fidêncio
Let's have all OS related tests grouped together. Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 -- tests/test-os-resources.c | 183 -- tests/test-os.c | 128 ++ 3 files changed, 128 insertions(+), 188

[Libosinfo] [osinfo-db PATCH] rhel7.5/rhel7.6: Fix typo in recommended CPU for PPC

2018-11-13 Thread Fabiano Fidêncio
Recommended CPU has to be a bigger value than the minimum one. Signed-off-by: Fabiano Fidêncio --- Issues were caught after having test-os-resources fixed* *: https://www.redhat.com/archives/libosinfo/2018-November/msg00104.html A problem for another day is to actually check the minimum

[Libosinfo] [libosinfo PATCH 0/2] test-os-resources: Fix typo + move tests to test-os

2018-11-13 Thread Fabiano Fidêncio
Please, see commit messages. Fabiano Fidêncio (2): test-os-resources: Fix typo in test_minimum_recommended_resources() test-os: move test-os-resources tests tests/Makefile.am | 5 -- tests/test-os-resources.c | 2 +- tests/test-os.c | 126

[Libosinfo] [libosinfo PATCH 1/2] test-os-resources: Fix typo in test_minimum_recommended_resources()

2018-11-13 Thread Fabiano Fidêncio
Thanks to this typo the test was iterating over a single OS, always. Signed-off-by: Fabiano Fidêncio --- tests/test-os-resources.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c index fe16b72..a8a9018 100644 --- a/tests

[Libosinfo] [libosinfo PATCH 2/2] test-os: move test-os-resources tests

2018-11-13 Thread Fabiano Fidêncio
Let's have all OS related tests grouped together. Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 -- tests/test-os.c | 126 ++ 2 files changed, 126 insertions(+), 5 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index

Re: [Libosinfo] Resources inheritance for OSes, I need some help/feedback!

2018-11-13 Thread Fabiano Fidêncio
On Tue, 2018-11-13 at 09:58 +, Daniel P. Berrangé wrote: > On Tue, Nov 13, 2018 at 10:10:17AM +0100, Fabiano Fidêncio wrote: > > People, > > > > I'm working on making OsinfoResources inherited for OSes that > > derives- > > from/clones another OSes. The i

[Libosinfo] Resources inheritance for OSes, I need some help/feedback!

2018-11-13 Thread Fabiano Fidêncio
-November/msg00078.html Best Regards, -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo

Re: [Libosinfo] [libosinfo PATCH 0/3] Add support for resources' inheritance

2018-11-12 Thread Fabiano Fidêncio
On Mon, 2018-11-12 at 15:07 +0100, Fabiano Fidêncio wrote: > This patch set introduces resources' inheritance for OSes that > derive-from/clone a device that already has its resources set. > > While this patch doesn't cause any harm per si, from the moment we > start > removin

[Libosinfo] [libosinfo PATCH 1/3] os: Add _get_.*_resources_without_inheritance()

2018-11-12 Thread Fabiano Fidêncio
Those two private methods have been added and those are part of the field preparation for having Resources inherited in the same way we do inherit devices. https://gitlab.com/libosinfo/osinfo-db/issues/15 Signed-off-by: Fabiano Fidêncio --- osinfo/Makefile.am | 1 + osinfo/osinfo_os.c

[Libosinfo] [libosinfo PATCH 2/3] os: Add support for Resources inheritance

2018-11-12 Thread Fabiano Fidêncio
In the same way that devices can be inherited between OSes that derive-from/clone another OS, the resources should do the same. https://gitlab.com/libosinfo/osinfo-db/issues/15 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_os.c | 48 -- 1 file

[Libosinfo] [libosinfo PATCH 0/3] Add support for resources' inheritance

2018-11-12 Thread Fabiano Fidêncio
://gitlab.com/libosinfo/osinfo-db/issues/15 Fabiano Fidêncio (3): os: Add _get_.*_resources_without_inheritance() os: Add support for Resources inheritance test-os: Add test_resources_inheritance() osinfo/Makefile.am| 1 + osinfo/osinfo_os.c

[Libosinfo] [libosinfo PATCH v2 11/15] os: Use get_devices_internal in _get_all callback

2018-11-12 Thread Fabiano Fidêncio
y'll be filtered out later. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_os.c b/osinfo/osinfo_os.c index 687e3ed..62d19f8 100644 --- a/osinfo/osin

[Libosinfo] [libosinfo PATCH v2 04/15] test-devicelinklist: Add _get_devices() test

2018-11-12 Thread Fabiano Fidêncio
https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- tests/test-devicelinklist.c | 62 + 1 file changed, 62 insertions(+) diff --git a/tests/test-devicelinklist.c b/tests/test-devicelinklist.c index fd2531b..f13f0b8 100644

[Libosinfo] [libosinfo PATCH v2 03/15] tests: Add basic tests for devicelinklist

2018-11-12 Thread Fabiano Fidêncio
https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 + tests/test-devicelinklist.c | 251 2 files changed, 256 insertions(+) create mode 100644 tests/test-devicelinklist.c diff --git

[Libosinfo] [libosinfo PATCH v2 14/15] os: Deal with "removed" devices

2018-11-12 Thread Fabiano Fidêncio
This commit introduces some logic to deal with "removed" devices and the way chosen to do so was to filter out the "removed" devices from the full list of devices (for both DeviceLinks and Device lists). https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-

[Libosinfo] [libosinfo PATCH v2 08/15] os: Add osinfo_os_get_devices_internal()

2018-11-12 Thread Fabiano Fidêncio
The addition of this new function is basically preparing the ground for the changes that are coming in the next commits where osinfo_os_get_devices() will have to deal with "removed" devices. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio -

[Libosinfo] [osinfo-db PATCH v2 01/15] schema: Add "removed" attribute to devices element

2018-11-12 Thread Fabiano Fidêncio
As devices are inherited whenever a new entry "derives-from" or "clones" an existing entry, we have to have a way to express that the device from the previous entry is now removed in the current one. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano

[Libosinfo] [libosinfo PATCH v2 05/15] tests-os: Add test_devices_inheritance_basic()

2018-11-12 Thread Fabiano Fidêncio
Devices are inherited from OSes that derives-from/clones some other OS. Let's have a test case to ensure it's not going to break in the future. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- .../device/libosinfo.org/test-device-one.xml | 7

[Libosinfo] [libosinfo PATCH v2 10/15] os: Add osinfo_os_get_all_device_links_internal()

2018-11-12 Thread Fabiano Fidêncio
The addition of this new function is basically preparing the ground for the changes that are coming in the next commits where osinfo_os_get_all_device_links() will have to deal with "removed" devices. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio -

[Libosinfo] [libosinfo PATCH v2 02/15] devicelinklist: Fix _get_devices()

2018-11-12 Thread Fabiano Fidêncio
struct to the list, instead of getting the devices associated to it. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_devicelinklist.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_devicelinklist.c b

[Libosinfo] [libosinfo PATCH v2 13/15] os: Add add_entity_to_list_check()

2018-11-12 Thread Fabiano Fidêncio
function that can be used in both methods. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_os.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_os.c b/osinfo/osinfo_os.c index cbc4459

[Libosinfo] [libosinfo PATCH v2 00/15] Deal with "removed" devices

2018-11-12 Thread Fabiano Fidêncio
with the osinfo_os_get_all_devices() However, it could to Changes since v1: https://www.redhat.com/archives/libosinfo/2018-November/msg00038.html - Dropped the patches dealing with "deprecated" devices; * osinfo-db: Fabiano Fidêncio (1): schema: Add "removed"

[Libosinfo] [libosinfo PATCH v2 09/15] os: Add osinfo_os_get_device_links_internal()

2018-11-12 Thread Fabiano Fidêncio
The addition of this new function is basically preparing the ground for the changes that are coming in the next commits where osinfo_os_get_device_links() will have to deal with "removed" devices. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio -

[Libosinfo] [libosinfo PATCH v2 12/15] os: Use get_device_links_internal in _get_all callback

2018-11-12 Thread Fabiano Fidêncio
they'll be filtered out later. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_os.c b/osinfo/osinfo_os.c index 62d19f8..cbc4459 100644 --- a/osinfo/osin

[Libosinfo] [libosinfo PATCH v2 15/15] test-os: Add test_devices_inheritance_removal()

2018-11-12 Thread Fabiano Fidêncio
Now that OsinfoOs can deal with the concept of a "removed" device, let's add some tests covering the possible situations we may face and ensure we won't regress here. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- .../test-os-devices-rem

[Libosinfo] [libosinfo PATCH v2 06/15] loader: Deal with "removed" devices for an OS

2018-11-12 Thread Fabiano Fidêncio
Let's make the loader aware of the "removed" attribute that can be set for a device linked from an OS entry. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_devicelink.h | 1 + osinfo/osinfo_loader.c | 9 + 2 files c

Re: [Libosinfo] [osinfo-db/libosinfo PATCH 00/18] Deal with "deprecated" and "removed" devices

2018-11-12 Thread Fabiano Fidêncio
On Mon, 2018-11-12 at 09:31 +, Daniel P. Berrangé wrote: > On Thu, Nov 08, 2018 at 07:55:19AM +0100, Fabiano Fidêncio wrote: > > This patchseries aim to have OSes properly dealing with deprecated > > and > > removed devices. The path I've taken is: > > The notion

Re: [Libosinfo] [Patch] tests: continue after failure in mediauris & treeuris

2018-11-09 Thread Fabiano Fidêncio
al_assertions(); > > g_test_add_func("/treeuris/uris", test_uris); > Reviewed-by: Fabiano Fidêncio I'll add the reference for the bugzilla we have for this in the commit message before pushing and also close the bugzilla. One thing that I'd like to hear from you Věra,

[Libosinfo] [osinfo-db PATCH 04/10] freebsd11.1: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
freebsd11.1 "derives-from" freebsd11.0, which already adds: - "virtio-net" - "virtio-block" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-11.1.xml.in | 5 - 1 file changed, 5 dele

[Libosinfo] [osinfo-db PATCH 06/10] freebsd10.4: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
freebsd10.4 "derives-from" freebsd10.3, which already adds: - "virtio-net" - "virtio-block" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-10.4.xml.in | 5 - 1 file changed, 5 dele

[Libosinfo] [osinfo-db PATCH 07/10] freebsd10.3: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
freebsd10.3 "derives-from" freebsd10.2, which already adds: - "virtio-net" - "virtio-block" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-10.3.xml.in | 5 - 1 file changed, 5 dele

[Libosinfo] [osinfo-db PATCH 01/10] mageia1: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
mageia1 "derives-from" madriva2010.0, which already adds: - "virtio-block" - "virtio-net" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/mageia.org/mageia-1.xml.in | 2 -- 1 file changed, 2 deletions(-) diff --git

[Libosinfo] [libosinfo PATCH 10/10] test-os: Add test_devices_duplication()

2018-11-08 Thread Fabiano Fidêncio
i?id=1634807 Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 2 +- tests/test-os.c | 144 ++ 2 files changed, 145 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 06f81bf..4612f69 100644 --- a/tests/Mak

[Libosinfo] [osinfo-db PATCH 05/10] freebsd11.0: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
freebsd11.0 "derives-from" freebsd10.3, which already adds: - "virtio-net" - "virtio-block" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-11.0.xml.in | 5 - 1 file changed, 5 dele

[Libosinfo] [osinfo-db PATCH 03/10] freebsd11.2: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
freebsd11.2 "derives-from" freebsd11.1, which already adds: - "virtio-net" - "virtio-block" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-11.2.xml.in | 5 - 1 file changed, 5 dele

[Libosinfo] [osinfo-db PATCH 08/10] freebsd10.2: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
freebsd10.2 "derives-from" freebsd10.1, which already adds: - "virtio-net" - "virtio-block" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-10.2.xml.in | 5 - 1 file changed, 5 dele

[Libosinfo] [osinfo-db PATCH 09/10] freebsd10.1: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
freebsd10.1 "derives-from" freebsd10.0, which already adds: - "virtio-net" - "virtio-block" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-10.1.xml.in | 5 - 1 file changed, 5 dele

[Libosinfo] [osinfo-db PATCH 02/10] win2k: Remove duplicated devices

2018-11-08 Thread Fabiano Fidêncio
win2k "derives-from" winme, which "derives-from" win98, which "derives-from" win95, which already adds: - "qxl" - "tablet" - "ac97" - "vga" https://bugzilla.redhat.com/show_bug.cgi?id=1634807 Signed-off-by: Fabiano Fidêncio

Re: [Libosinfo] [osinfo-db PATCH 0/1] Move USB support from Windows 2000 to 2003 and XP

2018-11-08 Thread Fabiano Fidêncio
On Thu, 2018-11-08 at 08:44 +0100, Fabiano Fidêncio wrote: > Windows 2000 only supports USB devices on its SP4 and never during > the > installation. :-/ > > A proper fix would be to actually expand libosinfo devices' API in > order > to differentiate what's fully supp

[Libosinfo] [PATCH] win: Move USB support from win2k to 2k3 and XP

2018-11-07 Thread Fabiano Fidêncio
Although Windows 2000 has USB support, it's only provided as part of SP4 and never during the installation time. https://gitlab.gnome.org/GNOME/gnome-boxes/issues/272 Signed-off-by: Fabiano Fidêncio --- data/os/microsoft.com/win-2k.xml.in | 1 - data/os/microsoft.com/win-2k3.xml.in | 1

[Libosinfo] [osinfo-db PATCH 0/1] Move USB support from Windows 2000 to 2003 and XP

2018-11-07 Thread Fabiano Fidêncio
this issue with a system that haven't reached it's EOL. https://gitlab.gnome.org/GNOME/gnome-boxes/issues/272 Fabiano Fidêncio (1): win: Move USB support from win2k to 2k3 and XP data/os/microsoft.com/win-2k.xml.in | 1 - data/os/microsoft.com/win-2k3.xml.in | 1 + data/os/microsoft.com/win

[Libosinfo] [libosinfo PATCH 09/18] test-os: Add test_devices_inheritance_deprecation()

2018-11-07 Thread Fabiano Fidêncio
Now that OsinfoOs can deal with the concept of a "deprecated" device, let's add some tests covering the possible situations we may face and ensure we won't regress here. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- .../test-os-devices-deprec

[Libosinfo] [libosinfo PATCH 17/18] os: Deal with "removed" devices

2018-11-07 Thread Fabiano Fidêncio
This commit introduces some logic to deal with "removed" devices and the way chosen to do so was to filter out the "removed" devices from the full list of devices (for both DeviceLinks and Device lists). https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-

[Libosinfo] [libosinfo PATCH 08/18] os: Add osinfo_os_get_all_device_links()

2018-11-07 Thread Fabiano Fidêncio
This function is a helper for the commits that are about to come related to properly dealing with "deprecated" devices. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/libosinfo.syms | 4 ++ osinfo/osinfo_os

[Libosinfo] [libosinfo PATCH 14/18] os: Use get_devices_internal in _get_all callback

2018-11-07 Thread Fabiano Fidêncio
y'll be filtered out later. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_os.c b/osinfo/osinfo_os.c index e5fe729..4fdbbe2 100644 --- a/osinfo/osin

[Libosinfo] [libosinfo PATCH 18/18] test-os: Add test_devices_inheritance_removal()

2018-11-07 Thread Fabiano Fidêncio
Now that OsinfoOs can deal with the concept of a "remoced" device, let's add some tests covering the possible situations we may face and ensure we won't regress here. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- .../test-os-devices-rem

[Libosinfo] [libosinfo PATCH 03/18] devicelinklist: Fix _get_devices()

2018-11-07 Thread Fabiano Fidêncio
struct to the list, instead of getting the devices associated to it. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_devicelinklist.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/osinfo/osinfo_devicelinklist.c b

[Libosinfo] [libosinfo PATCH 12/18] os: Add osinfo_os_get_device_links_internal()

2018-11-07 Thread Fabiano Fidêncio
The addition of this new function is basically preparing the ground for the changes that are coming in the next commits where osinfo_os_get_device_links() will have to deal with "removed" devices. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio -

[Libosinfo] [libosinfo PATCH 06/18] tests-os: Add test_devices_inheritance_basic()

2018-11-07 Thread Fabiano Fidêncio
Devices are inherited from OSes that derives-from/clones some other OS. Let's have a test case to ensure it's not going to break in the future. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- .../device/libosinfo.org/test-device-one.xml | 7

[Libosinfo] [osinfo-db PATCH 01/18] schema: Add "deprecated" attribute to device element

2018-11-07 Thread Fabiano Fidêncio
not be used). https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- data/schema/osinfo.rng.in | 5 + 1 file changed, 5 insertions(+) diff --git a/data/schema/osinfo.rng.in b/data/schema/osinfo.rng.in index 6693391..214c195 100644 --- a/data/schema/osinfo.rng.

[Libosinfo] [osinfo-db PATCH 02/18] schema: Add "removed" attribute to devices element

2018-11-07 Thread Fabiano Fidêncio
As devices are inherited whenever a new entry "derives-from" or "clones" an existing entry, we have to have a way to express that the device from the previous entry is now removed in the current one. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano

[Libosinfo] [libosinfo PATCH 13/18] os: Add osinfo_os_get_all_device_links_internal()

2018-11-07 Thread Fabiano Fidêncio
The addition of this new function is basically preparing the ground for the changes that are coming in the next commits where osinfo_os_get_all_device_links() will have to deal with "removed" devices. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio -

[Libosinfo] [libosinfo PATCH 10/18] loader: Deal with "removed" devices for an OS

2018-11-07 Thread Fabiano Fidêncio
Let's make the loader aware of the "removed" attribute that can be set for a device linked from an OS entry. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_devicelink.h | 1 + osinfo/osinfo_loader.c | 9 + 2 files c

[Libosinfo] [libosinfo PATCH 05/18] test-devicelinklist: Add _get_devices() test

2018-11-07 Thread Fabiano Fidêncio
https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- tests/test-devicelinklist.c | 62 + 1 file changed, 62 insertions(+) diff --git a/tests/test-devicelinklist.c b/tests/test-devicelinklist.c index fd2531b..f13f0b8 100644

[Libosinfo] [libosinfo PATCH 07/18] loader: Deal with "deprecated" devices for an OS

2018-11-07 Thread Fabiano Fidêncio
Let's make the loader aware of the "deprecated" attribute that can set for a device linked from an OS entry. https://gitlab.com/libosinfo/osinfo-db/issues/13 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_devicelink.h | 1 + osinfo/osinfo_loader.c | 9 + 2 files c

[Libosinfo] [osinfo-db/libosinfo PATCH 00/18] Deal with "deprecated" and "removed" devices

2018-11-07 Thread Fabiano Fidêncio
and exposed osinfo_os_get_all_device_links(), and the rationale for exposing it is basically for coherence with the osinfo_os_get_all_devices() However, it could totally be a private method. What's the preference here? *osinfo-db: Fabiano Fidêncio (2): schema: Add "deprecated"

[Libosinfo] [libosinfo PATCH] os: Don't leak scripts list

2018-11-07 Thread Fabiano Fidêncio
osinfo_list_get_elements() calls g_hash_table_get_values() which returns a GList that must be freed after used. For more info, please, refer to: https://developer.gnome.org/glib/unstable/glib-Hash-Tables.html#g-hash-table-get-values Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_os.c | 11

[Libosinfo] [osinfo-db PATCH 5/6] suse: Add SLE-15-unknown info

2018-11-05 Thread Fabiano Fidêncio
In a similar way of what's done on openSUSE and Fedora, let's have an "unknown" entry for SLE-15 that would cover any possible future release while the proper release is not added to our db. Signed-off-by: Fabiano Fidêncio --- data/os/suse.com/sle-15-unknown.x

[Libosinfo] [osinfo-db PATCH 3/6] rhel: Add RHEL unknown info

2018-11-05 Thread Fabiano Fidêncio
From: Fabiano Fidêncio In a similar way of what's done on openSUSE and Fedora, let's have an "unknown" entry for RHEL that would cover any possible future releases while the proper release is not added to our db. Signed-off-by: Fabiano Fidêncio --- data/os/redhat.com/rhel-unknown.x

[Libosinfo] [osinfo-db PATCH 0/6] Add "unknown" entries for Enterprise distros

2018-11-05 Thread Fabiano Fidêncio
ay we have for Fedora and openSUSE, and make the new (or in development) release be at least recoginzed and have the proper devices loaded for those who are using them in any distro. Fabiano Fidêncio (6): rhel: Add RHEL-6 unknown info rhel: Add RHEL-7 unknown info rhel: Add RHEL unknown info suse:

[Libosinfo] [osinfo-db PATCH 6/6] suse: Add SLE unknwon info

2018-11-05 Thread Fabiano Fidêncio
In a similar way of what's done on openSUSE and Fedora, let's have an "unknown" entry for SLE that would cover any possible future releases while the proper release is not added to our db. Signed-off-by: Fabiano Fidêncio --- data/os/suse.com/sle-unknown.x

[Libosinfo] [osinfo-db PATCH 1/6] rhel: Add RHEL-6 unknown info

2018-11-05 Thread Fabiano Fidêncio
From: Fabiano Fidêncio In a similar way of what's done on openSUSE and Fedora, let's have an "unknown" entry for RHEL-6 that would cover any possible future release while the proper release is not added to our db. Signed-off-by: Fabiano Fidêncio --- data/os/redhat.com/rhel-6-unkn

[Libosinfo] [osinfo-db PATCH 2/6] rhel: Add RHEL-7 unknown info

2018-11-05 Thread Fabiano Fidêncio
From: Fabiano Fidêncio In a similar way of what's done on openSUSE and Fedora, let's have an "unknown" entry for RHEL-7 that would cover any possible future release while the proper release is not added to our db. Signed-off-by: Fabiano Fidêncio --- data/os/redhat.com/rhel-7-unkn

[Libosinfo] [osinfo-db PATCH] fedora29: Fix variant-id name

2018-11-01 Thread Fabiano Fidêncio
server-netinst -> everything-netinst Signed-off-by: Fabiano Fidêncio --- data/os/fedoraproject.org/fedora-29.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/fedoraproject.org/fedora-29.xml.in b/data/os/fedoraproject.org/fedora-29.xml.in index dba6da2..49ce

Re: [Libosinfo] [PATCH] rhel: Add rhel7.6 isodata

2018-11-01 Thread Fabiano Fidêncio
On Thu, 2018-11-01 at 14:17 +0100, Felipe Borges wrote: > From: Felipe Borges > > Signed-off-by: Felipe Borges Reviewed-by: Fabiano Fidêncio (And it's already merged!) [snip] ___ Libosinfo mailing list Libosinfo@redhat.

[Libosinfo] [libosinfo PATCH 2/3] tests: Add test-imagelist

2018-11-01 Thread Fabiano Fidêncio
test-imagelist is totally based on test-devicelist. Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 + tests/test-imagelist.c | 228 + 2 files changed, 233 insertions(+) create mode 100644 tests/test-imagelist.c diff --git a/tests

[Libosinfo] [libosinfo PATCH 1/3] tests: Add test-image

2018-11-01 Thread Fabiano Fidêncio
test-image tests the basic functionally of OsImage APIs. Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 tests/test-image.c | 64 ++ 2 files changed, 69 insertions(+) create mode 100644 tests/test-image.c diff --git a/tests

[Libosinfo] [libosinfo PATCH 0/3] Add tests for OsinfoImage

2018-11-01 Thread Fabiano Fidêncio
This patchset introduces a bunch of tests for the following series: https://www.redhat.com/archives/libosinfo/2018-November/msg9.html Fabiano Fidêncio (3): tests: Add test-image tests: Add test-imagelist tests: Add test-imageuris tests/Makefile.am | 15 +++ tests/test-image.c

[Libosinfo] [libosinfo PATCH 3/3] tests: Add test-imageuris

2018-11-01 Thread Fabiano Fidêncio
In a quite similar way than test-mediauris and test-treeuris, let's have a test for the imageuris. Signed-off-by: Fabiano Fidêncio --- tests/Makefile.am | 5 ++ tests/test-imageuris.c | 150 + 2 files changed, 155 insertions(+) create mode 100644

Re: [Libosinfo] [libosinfo PATCH v2 4/5] os: Introduce APIs to deal with images

2018-11-01 Thread Fabiano Fidêncio
On Thu, Nov 1, 2018 at 1:45 PM Fabiano Fidêncio wrote: > > Let's introduce the needed APIs on os side to deal will the images. > For now, there's no info being loaded as the loader part depends on one > of these APIs. > > https://gitlab.com/libosinfo/osinfo-db/issues/10 > >

[Libosinfo] [libosinfo PATCH v2 5/5] loader: Load Images information

2018-11-01 Thread Fabiano Fidêncio
Now that we've OsinfoImage and OsinfoImageList objects in place and OsinfoOs already provides us an API to add an OsinfoImage to an OsinfoOS, let's properly load the images' information present in osinfo-db. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio

[Libosinfo] [libosinfo PATCH v2 2/5] Introduce OsinfoImage object

2018-11-01 Thread Fabiano Fidêncio
for that as they already do a quite good job on this field. https://gitlab.com/libosinfo/osinfo-db/issues/10 Signed-off-by: Fabiano Fidêncio --- osinfo/Makefile.am| 2 + osinfo/libosinfo.syms | 6 ++ osinfo/osinfo.h | 1 + osinfo/osinfo_image.c | 225

<    7   8   9   10   11   12   13   14   15   16   >