[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2010-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Igor Kovalyov iv_koval...@mail.ru changed: What|Removed |Added Depends on||31820 --- Comment

Re: [Libreoffice] BOOL conflict

2010-12-09 Thread Norbert Thiebaud
On Thu, Dec 9, 2010 at 1:50 AM, Thomas Klausner w...@netbsd.org wrote: On Wed, Dec 08, 2010 at 10:49:27AM +, Michael Meeks wrote:       Urk; another reason not to use BOOL I guess :-)       What does your iodbcunix.h include ? I guess we might need to do some hideous #define magic for the

Re: [Libreoffice] Different x86 ABI on BSDs and MaxOSX

2010-12-09 Thread Caolán McNamara
On Wed, 2010-12-08 at 21:15 +, Michael Meeks wrote: Do we enable / run the bridgetests ? We always build and run the cpp bridge test, yes. Well except for MacOSX PPC. That particular bridge is broken somewhere. C. ___ LibreOffice mailing

Re: [Libreoffice] BOOL conflict

2010-12-09 Thread Michael Meeks
On Thu, 2010-12-09 at 02:31 -0600, Norbert Thiebaud wrote: so yes, getting rid of BOOL would solve the problem, but it is not a quick fix... Quite - and you'd need to fix the entire cascade of headers for the module that includes that piece - which is (perhaps) not easy. Then

Re: [Libreoffice] Different x86 ABI on BSDs and MaxOSX

2010-12-09 Thread Caolán McNamara
On Thu, 2010-12-09 at 01:42 +0100, Jan Holesovsky wrote: http://agner.org./optimize/calling_conventions.pdf and from what I see on page 19, it seems to me that *BSD defaults to the 'fastcall' variant, right? We're looking at Table 7. Methods for returning structure, class and union objects

Re: [Libreoffice] Different x86 ABI on BSDs and MaxOSX

2010-12-09 Thread Jan Holesovsky
Hi Caolan, On 2010-12-09 at 09:43 +, Caolán McNamara wrote: and from what I see on page 19, it seems to me that *BSD defaults to the 'fastcall' variant, right? We're looking at Table 7. Methods for returning structure, class and union objects right ? The table suggests that

Re: [Libreoffice] Removal of DECLARE_LIST() from Calc

2010-12-09 Thread Norbert Thiebaud
On Thu, Dec 9, 2010 at 12:55 AM, Joseph Powers jpower...@cox.net wrote: I'm converting ScRangeList from DECLARE_LIST( ScRangeListBase, ScRange* ) to ::STD::vector ScRange* ScRangeListBase The most of the code boring and unlikely to cause issues; however, some areas need further review:

[Libreoffice] Build environment MacOSX - autoconf / automake version problems

2010-12-09 Thread Alexander Thurgood
Hi all, I've been following the extremely well written documentation from here : http://wiki.documentfoundation.org/Development/Install_Mac_OS_10.6.4_Dependencies to getting the build environment up and running on my Mac OSX Snow Leopard, but I've hit a snag with automake. When I go to

Re: [Libreoffice] [LibreOffice] [PUSHED] [Patch] Fix for i#108228: Bool has negative sign when used in Writer formula expression

2010-12-09 Thread Noel Power
On 08/12/10 16:22, Noel Power wrote: For this patch I am not familiar with the writer bits involved, so I am not sure if there would be some side-affects. Personally I'd like to understand why the explict check in the output doesn't get applied in this case, I'll at least try and see where

[Libreoffice] v2 of the configure.in/scp2 patch to allow selecting themes

2010-12-09 Thread Sebastian Spaeth
This 2nd version also uses defines in the form of -DTHEME_CRYSTAL that are being used in the scp2 module. Untested, perhaps someone with a faster compile time than mine can see if the --enable-theme=crystal tango or --enable-theme= or --enable-theme= (the latter 2 options should enable all

Re: [Libreoffice] v2 of the configure.in/scp2 patch to allow selecting themes

2010-12-09 Thread Christian Lohmaier
Hi Sebastian, *, On Thu, Dec 9, 2010 at 1:14 PM, Sebastian Spaeth sebast...@sspaeth.de wrote: This 2nd version also uses defines in the form of -DTHEME_CRYSTAL that are being used in the scp2 module. Untested, perhaps someone with a faster compile time than mine can see if the I'd prefer if

Re: [Libreoffice] v2 of the configure.in/scp2 patch to allow selecting themes

2010-12-09 Thread Sebastian Spaeth
On Thu, 9 Dec 2010 13:20:08 +0100, Christian Lohmaier wrote: I'd prefer if those would only be set in scp2 module when those are actually used, and not globally. Sorry, for this my build system foo of LibO is too limited and *I* am not capable of just creating defines in a single module. This

Re: [Libreoffice] v2 of the configure.in/scp2 patch to allow selecting themes

2010-12-09 Thread Christian Lohmaier
Hi Sebastian, *, On Thu, Dec 9, 2010 at 1:35 PM, Sebastian Spaeth sebast...@sspaeth.de wrote: On Thu, 9 Dec 2010 13:20:08 +0100, Christian Lohmaier wrote: I'd prefer if those would only be set in scp2 module when those are actually used, and not globally. Sorry, for this my build system foo

[Libreoffice] [Pushed] v3 of the configure.in/scp2 patch to allow selecting themes

2010-12-09 Thread Michael Meeks
Hi Sebastian, Hackers: you need to re-source LinuxIntelEnv.Set.sh if you're building manually in scp2 after this change ... ;-) On Thu, 2010-12-09 at 13:20 +0100, Christian Lohmaier wrote: On Thu, Dec 9, 2010 at 1:14 PM, Sebastian Spaeth sebast...@sspaeth.de wrote: This 2nd version

[Libreoffice] Review of fdo#32172 for 3.3 inclusion

2010-12-09 Thread Cedric Bosdonnat
Hi caolan, all, Could you please review the commit for this bug? https://bugs.freedesktop.org/show_bug.cgi?id=32172 It could be nice to have it in 3.3 as well... Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer

Re: [Libreoffice] Removal of DECLARE_LIST() from Calc

2010-12-09 Thread Joseph Powers
Ok, the shadow on P is mine and is harmless. I've modified the code to remove the warning: void ScViewFunc::MarkAndJumpToRanges(const ScRangeList rRanges) { ScViewData* pView = GetViewData(); ScDocShell* pDocSh = pView-GetDocShell(); ScRangeList aRanges(rRanges); ScRange* p =

Re: [Libreoffice] Review of fdo#32172 for 3.3 inclusion

2010-12-09 Thread Caolán McNamara
On Thu, 2010-12-09 at 14:17 +0100, Cedric Bosdonnat wrote: Hi caolan, all, Could you please review the commit for this bug? Looks good to me anyway. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] En Uygun Fiyat Garantili Termal Oteller Burada

2010-12-09 Thread TatilVitrini
Untitled Document TERMAL OTELLERİMİZ GRAND MARDEN THERMAL

[Libreoffice] Win32 size shrink ...

2010-12-09 Thread Michael Meeks
Hi guys, I'd appreciate someone who is fresh to the task reviewing the licensing duplication, and .otp duplication fixes, currently in the (libreoffice-3-3) branch feature/winshrink. With these two we get a 70Mb saving on the installer; down to ~270Mb; and I'd like to get them

Re: [Libreoffice] Win32 size shrink ...

2010-12-09 Thread Sophie Gautier
Hi Michael, all, On 09/12/2010 19:05, Michael Meeks wrote: Hi guys, I'd appreciate someone who is fresh to the task reviewing the licensing duplication, and .otp duplication fixes, currently in the (libreoffice-3-3) branch feature/winshrink. With these two we get a 70Mb saving

[Libreoffice] [PATCH] remove unused variables

2010-12-09 Thread Kevin Hunter
Hullo List, Simple patch to remove unused variables in: vcl/win/source/gdi/winlayout.cxx Cheers, Kevin 0001-Remove-unused-variables.patch.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [LibreOffice] [Patch] Fix for i#108228: Bool has negative sign when used in Writer formula expression

2010-12-09 Thread Joe Smith
Mattias Johnsson m.t.johns...@... writes: Fix for http://qa.openoffice.org/issues/show_bug.cgi?id=108228. ... It turns out the reason for this is buried in sbxdef.hxx, where we have // The numeric values of TRUE and FALSE enum SbxBOOL { SbxFALSE = 0, SbxTRUE = -1 }; ... Hey, that's

[Libreoffice] Base - sqlite - licence grief

2010-12-09 Thread Wols Lists
I've downloaded the old sqlite driver, which is copyright Sun LGPL 2.1. I was going to try and get that working, and teach myself C++ in the process, but on trying to commit it to my local repo the first thing I get is you are adding tabs to these files (no I'm not but never mind :-) So I fix

[Libreoffice] [Pushed] Remove duplicate placeholder icons

2010-12-09 Thread Michael Meeks
Hi Joachim, On Wed, 2010-12-08 at 19:34 +0100, Joachim wrote: The attached patch implements in the ImageList class a fallback to load a default icon if no one is found. Wonderful - patch looks lovely I removed the extra braces for single line statements (seems right from a context or

Re: [Libreoffice] Win32 size shrink ...

2010-12-09 Thread Michael Meeks
On Thu, 2010-12-09 at 19:49 +0300, Sophie Gautier wrote: Thanks a lot for your great work on this! Au contraire :-) thank you for your praise - which somehow makes it that much more fun worthwhile to fix this. Good stuff, Michael (out tomorrow, but back on it

Re: [Libreoffice] Base - sqlite - licence grief

2010-12-09 Thread Michael Meeks
Hi Wols, On Thu, 2010-12-09 at 19:07 +, Wols Lists wrote: I've downloaded the old sqlite driver, which is copyright Sun LGPL 2.1. Oh - shame :-) I wonder if there is a newer copy of it in the repos. I was going to try and get that working, and teach myself C++ in the process, but

[Libreoffice] Review of fdo# 31770 - help content BrOffice branding

2010-12-09 Thread Petr Mladek
Hi Michael, could you please review the diff at https://bugs.freedesktop.org/attachment.cgi?id=40959 See https://bugs.freedesktop.org/show_bug.cgi?id=31770#c14 for explanation of the changes. Best Regards, Petr ___ LibreOffice mailing list

[Libreoffice] new Win32 size analysis ...

2010-12-09 Thread Michael Meeks
Hi guys, Soo ... it seems the next obvious joy in terms of huge .cab size and download size is the wizards/templates - and we still have license problems - despite loosing hundreds of per-language duplicates we still have 4 copies of the (english) license per language in there ;-)

Re: [Libreoffice] [Pushed] Remove duplicate placeholder icons

2010-12-09 Thread Joachim Trémouroux
Andrew, Should I do the actual removal of the duplicate icons? I guess these are the green cross on blue background images. Regards, Joachim. 2010/12/9 Michael Meeks michael.me...@novell.com Hi Joachim, On Wed, 2010-12-08 at 19:34 +0100, Joachim wrote: The attached patch implements in

Re: [Libreoffice] minutes of tech steering call ...

2010-12-09 Thread Caolán McNamara
On Thu, 2010-12-09 at 18:18 +, Michael Meeks wrote: AA: + write tooling to retain history across repo moves (Kendy) I suppose its silly to look into rewriting our existing history by tracking back through the various old svn and cvs workspace branch systems to determine who

Re: [Libreoffice] patches for Remove unhelpful File.hxx macros

2010-12-09 Thread Caolán McNamara
On Thu, 2010-12-09 at 12:39 +, Andy Holder wrote: Hi I'm new here and to start I've done 3 patches to start the Remove unhelpful File.hxx macros task in the Easy hacks. Yes, looks good. These are now pushed. Thanks for the help. C. ___

[Libreoffice] Code review for some threadlocking in webdav

2010-12-09 Thread Caolán McNamara
I'd like to cherry-pick the attached to 3.3 It should fix https://bugzilla.redhat.com/show_bug.cgi?id=661809 This is a long story, but see the backtrace attachment at the above url there thread 1 and thread 8 both end up mangling libgcrypt which neon is using.

[Libreoffice] [PUSHED] Re: [PATCH] remove unused variables

2010-12-09 Thread Caolán McNamara
On Thu, 2010-12-09 at 12:40 -0500, Kevin Hunter wrote: Hullo List, Simple patch to remove unused variables in: vcl/win/source/gdi/winlayout.cxx Looks good, GetScriptCache has no side effects. So even though I can't build it as its windows-only code, I'm confident enough to push it ;-)

[Libreoffice] [PATCH] sw: cppcheck cleanup and comment removal.

2010-12-09 Thread Joachim Trémouroux
Hi, The attached patch removes some unnecessary comments and fixes some cppcheck cleanup. Regards, Joachim. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Error compilation on sc

2010-12-09 Thread Julien Nabet
Hello, Since today when i compile, i've got this in sc module : Entering /home/serval/libreoffice-source/libo/sc/source/ui/unoobj `../../../unxlngi6.pro/slo/chart2uno.obj' is up to date Entering /home/serval/libreoffice-source/libo/sc/util Making:scalc3c.lib Making:libscli.so : ERROR:

Re: [Libreoffice] LO status bar annoyances

2010-12-09 Thread Friedrich Strohmaier
Hi Sebastian, *, Sorry for late answer - I'm scanning the dev list occasionally only.. Sebastian Spaeth schrieb: Am I the only one finding the current status bar pretty much useless? Shure not, but that is not the question in matter. About the only thing I actually use there, is the zoom

Re: [Libreoffice] Comments on RC1

2010-12-09 Thread Marc Paré
Le 2010-12-09 08:20, Sophie Gautier a écrit : If you would like, I can introduce Pierre-Yves to you, he is from Framasoft and taking care currently to package the FramaKey described here: http://framakey.org/Pack/Framakey-Ubuntu (FR) http://framakey.org/En/Details (EN). Kind regards Sophie

[Libreoffice] [Patch] call-catcher / bloat removal

2010-12-09 Thread Julien Nabet
Hello, First try to remove call-catcher / bloat removal with sc/source/core/tool/chgtrack.cxx and sc/inc/chgtrack.hxx I made a ./g grep AppendContent * on the whole project, i found it only on sc module I made a build and this file compiled ok but i had an error after so... I made a ./g

Re: [Libreoffice] LO status bar annoyances

2010-12-09 Thread Sebastian Spaeth
On Thu, 9 Dec 2010 22:59:37 +0100, Friedrich Strohmaier damokles4-lis...@bits-fritz.de wrote: What You as an individual do use or don't *must not* be a criterium for UI and feature changes. Even and especially not because You are a software developer! Hi Friedrich, this thread already became

Re: [Libreoffice] Removal of DECLARE_LIST() from Calc

2010-12-09 Thread Kohei Yoshida
Hi Joseph, Thanks for looking into this. I've done my review of the patch, and here are my comments. The big ones first. With this patch, we are now inheriting directly from std::vector, which itself does not break anything, but is not considered a good practice. The reason is that it exposes

[Libreoffice] [Base] Unable to open form (design, control) toolbar - form navigator opens w/out buttons XCfe only

2010-12-09 Thread drew
Hi, A user reported a problem using Base Form design toolbars using Arch Linux - Checked with, and no problems found using, Ubuntu 10.10 (64bit), OpenSuse 11.2 (32bit) [gnome KDE], Windows XP Using a build of OpenSUSE 11.3, XCfe and LibreOffice RC1 the problems show up. Using the same system,

Re: [Libreoffice] Comments on RC1

2010-12-09 Thread Wols Lists
On 09/12/10 22:21, Marc Paré wrote: I can see how a USB stick would be a more elegant way of distributing the distro. The price would seem to be the only problem that I can see. Framakey (Framasoft) is offering a 4gig stick for 19Euro and 4Eu shipping. A smaller and less expensive stick could

Re: [Libreoffice] new Win32 size analysis ...

2010-12-09 Thread Kohei Yoshida
On Thu, 2010-12-09 at 19:47 +, Michael Meeks wrote: the new export-OLE-PDF feature This is cool! Awesome work Gart. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] [Base] Unable to open form (design, control) toolbar - form navigator opens w/out buttons XCfe only

2010-12-09 Thread drew
On Thu, 2010-12-09 at 19:34 -0500, drew wrote: Using a build of OpenSUSE 11.3, XCfe and LibreOffice RC1 the problems show up. oops - little mix-up there..the actual test machine is: OpenSUSE 11.3, iceWM, LibO RC1 The entire package is from the SUSE Studio build service - which is very nice

Re: [Libreoffice] Comments on RC1

2010-12-09 Thread Marc Paré
Le 2010-12-09 19:50, Wols Lists a écrit : On 09/12/10 22:21, Marc Paré wrote: I can see how a USB stick would be a more elegant way of distributing the distro. The price would seem to be the only problem that I can see. Framakey (Framasoft) is offering a 4gig stick for 19Euro and 4Eu shipping.

Re: [Libreoffice] Comments on RC1

2010-12-09 Thread Sophie Gautier
On 10/12/2010 03:50, Wols Lists wrote: On 09/12/10 22:21, Marc Paré wrote: I can see how a USB stick would be a more elegant way of distributing the distro. The price would seem to be the only problem that I can see. Framakey (Framasoft) is offering a 4gig stick for 19Euro and 4Eu shipping. A

[Libreoffice] Fwd: Inclusion of a distro in the code

2010-12-09 Thread sophie
Hi Anke, I'm forwarding your mail to the developer's list, you should have more answers there Kind regards Sophie Original Message Subject:Inclusion of a distro in the code Date: Thu, 9 Dec 2010 16:50:01 + From: Anke Boersma veritasf...@gmail.com To:

Re: [Libreoffice] [PATCH] sw: cppcheck cleanup and comment removal.

2010-12-09 Thread Joachim Trémouroux
Oups, better with the patch attached... Joachim. Le 10 décembre 2010 04:13, Kohei Yoshida kyosh...@novell.com a écrit : Hi Joachim, On Thu, 2010-12-09 at 22:28 +0100, Joachim Trémouroux wrote: Hi, The attached patch removes some unnecessary comments and fixes some cppcheck