Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-07 Thread Maciej Rumianowski
2011/10/6 Stephan Bergmann sberg...@redhat.com Btw, v[0] (as well as v.front()) are only valid if !v.empty() -- but (without checking it in detail right now) I guess the patch already takes account of that, Maciej? Yes it does. Mostly it is one function that takes also the size of data.

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-06 Thread Stephan Bergmann
On 10/05/2011 10:11 PM, Michael Stahl wrote: On 05.10.2011 22:02, Maciej Rumianowski wrote: Dnia 2011-10-05, śro o godzinie 17:35 +0200, Lubos Lunak pisze: On Wednesday 05 of October 2011, Jan Holesovsky wrote: That would allow you to convert the pO-GetData() to something like po-data(),

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-05 Thread Jan Holesovsky
Hi Maciej, On 2011-10-05 at 10:39 +0200, Maciej Rumianowski wrote: There was a lot of WW8Bytes( SV_DECL_VARARR ) which was partly replaced with ww::bytes. This set of patches totally migrates code to ww::bytes. Very nice, thank you! :-) Before pushing, I wonder - ww::bytes is

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-05 Thread Lubos Lunak
On Wednesday 05 of October 2011, Jan Holesovsky wrote: Hi Maciej, On 2011-10-05 at 10:39 +0200, Maciej Rumianowski wrote: There was a lot of WW8Bytes( SV_DECL_VARARR ) which was partly replaced with ww::bytes. This set of patches totally migrates code to ww::bytes. Very nice, thank you!

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-05 Thread Maciej Rumianowski
Dnia 2011-10-05, śro o godzinie 17:35 +0200, Lubos Lunak pisze: On Wednesday 05 of October 2011, Jan Holesovsky wrote: Hi Maciej, On 2011-10-05 at 10:39 +0200, Maciej Rumianowski wrote: There was a lot of WW8Bytes( SV_DECL_VARARR ) which was partly replaced with ww::bytes. This set of

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-05 Thread Michael Stahl
On 05.10.2011 22:02, Maciej Rumianowski wrote: Dnia 2011-10-05, śro o godzinie 17:35 +0200, Lubos Lunak pisze: On Wednesday 05 of October 2011, Jan Holesovsky wrote: That would allow you to convert the pO-GetData() to something like po-data(), instead of (*pO)[0] (and similar) used on many