anshu khare kirjoitti 10.11.2020 klo 16.27:
Hi
Please review my patch
https://gerrit.libreoffice.org/c/core/+/105501
I have tested it. It's working fine.
Please merge it.
You did not address Jim's comment:
"Please see
Hi
Please review my patch
https://gerrit.libreoffice.org/c/core/+/105501
I have tested it. It's working fine.
Please merge it.
Thanks in advance
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi,
Could you please review my patch :
https://gerrit.libreoffice.org/c/core/+/103632
Thanks and Regards
Anshu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi,
I have worked on Bug 134779 - Entering a table with too many columns
causing Writer to lock up.
Please review my patch.
https://gerrit.libreoffice.org/c/core/+/101561
Regards
Anshu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi mentors,
Please check https://gerrit.libreoffice.org/c/core/+/101242
I have worked on the Bug 87963
Thank you
Regards
Anshu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Hello all!
I'm in a confusion if my submitted patch is somehow wrong,
https://gerrit.libreoffice.org/#/c/23661/ , or the developers are busy
because it's been about 5 days and there is neither any review nor any
comment. I don't know if it's wrong because I tested it myself and the
transition is
Hello everyone,
I have submitted my updated patch for fdo#62957.. I had used a global
public variable :P and i was suppose to change that.. Since i am new to the
community with very less knowledge of the api ( though have learnt a lot
after solving two easy hacks ) it was really hard for me to
Hi Markus,
Markus Mohrhard wrote (20-09-13 05:11)
https://gerrit.libreoffice.org/#/c/5985/1
Thanks for asking. I say yes!
(It's for https://bugs.freedesktop.org/show_bug.cgi?id=67159
Danny didn't mention the bug number in the commit message.)
Cheers,
--
- Cor Nouws
-
Hey guys,
there is a patch in gerrit that changes the behavior of a shortcut. Could
one of you please review the patch and decide if the patch makes sense.
https://gerrit.libreoffice.org/#/c/5985/1
Regards,
Markus
___
Libreoffice-ux-advise mailing
Hi Ricardo,
Ricardo Montania (via Code Review) píše v Út 09. 10. 2012 v 20:31 +:
https://gerrit.libreoffice.org/851
Thank you a lot for the patch! :-) Having seen it pushed, I've done a
small follow-up tweak:
Yes, no problem.
Thanks :)
On Mon, Oct 15, 2012 at 4:06 PM, Jan Holesovsky ke...@suse.cz wrote:
Hi Ricardo,
Ricardo Montania (via Code Review) píše v Út 09. 10. 2012 v 20:31 +:
https://gerrit.libreoffice.org/851
Thank you a lot for the patch! :-) Having seen it pushed, I've
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/851
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/851/1
Review corrections in basctl/.../basobj3.cxx
Change-Id: I905e85ce9d754047ad287c9dd3caa92427b25b0d
---
M
Hi Ivan,
Ivan Timofeev píše v So 29. 09. 2012 v 21:52 +0400:
this patch fixes bug 52268:
https://bugs.freedesktop.org/show_bug.cgi?id=52268
Splash Screen: Messages on first start displayed in wrong colour in
the wrong place
Thanks f or that! :-) Pushed that both to master and
Hi Ivan,
Marking it pushed; and want to ask you to cherry-pick the following
addition to the libreoffice-3-6 branch :-)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9097843e6b2935dcab9f038b80e5a51bc5cfc94
Thank you,
Kendy
Jan Holesovsky píše v Út 02. 10. 2012 v 15:46 +0200:
Hi
Hi Kendy,
On 02.10.2012 18:03, Jan Holesovsky wrote:
Marking it pushed; and want to ask you to cherry-pick the following
addition to the libreoffice-3-6 branch :-)
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9097843e6b2935dcab9f038b80e5a51bc5cfc94
oh, right, I forgot about
On Thu, 2012-08-16 at 18:52 +0200, Jan Holesovsky wrote:
Attached is a patch that I know you are not too happy about ;-) - change
the default of creating the desktop icon on Windows back to 'yes'.
Patch itself seems reasonable; the ux-advise mail I saw seemed like
we'd got confused
Hi Kendy, Michael,
sure, go ahead. You've disproved the only somewhat weighty argument I
had (the password requirement – sorry for not researching that before).
What remains is a purely philosophical argument (the desktop is the
user's space) which everyone has different opinions about.
So, I
Hi Astron,
Attached is a patch that I know you are not too happy about ;-) - change
the default of creating the desktop icon on Windows back to 'yes'.
My reasons for insisting are several; I think I've written most of them
in another mail, but to summarize:
- it is easier to remove the icon
On Thu, 2012-08-16 at 18:52 +0200, Jan Holesovsky wrote:
Attached is a patch that I know you are not too happy about ;-) - change
the default of creating the desktop icon on Windows back to 'yes'.
Patch itself seems reasonable; the ux-advise mail I saw seemed like
we'd got confused
On Wed, Jul 18, 2012 at 10:10:38PM +0200, David Ostrovsky wrote:
https://gerrit.libreoffice.org/#/c/328/
The gitweb link on that page says 404 no such project.
--
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi,
On Wed, Jul 18, 2012 at 07:11:53PM +0200, Jan Holesovsky wrote:
Luckily, the Qt guys apparently had the same problem, and
have a solution (the entire diff on one page, without abandoning the
inline commenting):
Hi Kendy,
On 18.07.2012 19:11, Jan Holesovsky wrote:
Another thing are the mail templates - can you please commit the current
mail templates that we are using on gerrit.libreoffice.org to
dev-tools/gerrit/gerrit_site/etc/mail, so that we can tweak them [eg. to
get rid of the . line], in a
Hi Bjoern,
On 2012-07-02 at 18:44 +0200, Bjoern Michaelsen wrote:
When I click Diff All Side-by-Side (or Diff All Unified), it shows
me only the first file with a link to the (diff) of the next file. I
expected to see the diff for *all* files on one page. That is much
more convenient to
On Tue, Jul 17, 2012 at 12:10:05AM +0200, Lionel Elie Mamane wrote:
Please cherry-pick 0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
(http://cgit.freedesktop.org/libreoffice/core/commit/?id=0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
and patch also attached)
to libreoffice-3-6 in time for rc2.
I'll
Please cherry-pick 0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
(http://cgit.freedesktop.org/libreoffice/core/commit/?id=0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
and patch also attached)
to libreoffice-3-6 in time for rc2. This would allow me to get some
Base testers in 3.6 before release (as it is,
\ Now I went to https://gerrit.libreoffice.org/#/c/267/; there are at
this time three patchsets, but it seems there is no easy / convenient
way to see the differences (interdiff) between them.
QT have patched their gerrit to do the 'right thing'
See
On 09.07.2012 08:53, Norbert Thiebaud wrote:
QT have patched their gerrit to do the 'right thing'
we too and we are even better: we pushed it upstream ;-)
https://gerrit-review.googlesource.com/#/c/36640/
Regards
David
___
LibreOffice mailing list
On Mon, Jul 02, 2012 at 06:13:50PM +0200, Lionel Elie Mamane wrote:
On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
gerrit is documented and ready to go. Please use it for code review
as much as possible now as it simplifies things a lot over manual
patch fiddling on
On Sun, Jul 08, 2012 at 10:56:55PM +0200, Lionel Elie Mamane wrote:
Now I went to https://gerrit.libreoffice.org/#/c/267/; there are at
this time three patchsets, but it seems there is no easy / convenient
way to see the differences (interdiff) between them.
Find the text Old Version History:
On Sun, Jul 08, 2012 at 11:17:31PM +0200, Bjoern Michaelsen wrote:
On Sun, Jul 08, 2012 at 10:56:55PM +0200, Lionel Elie Mamane wrote:
Now I went to https://gerrit.libreoffice.org/#/c/267/; there are at
this time three patchsets, but it seems there is no easy / convenient
way to see the
Hi Lionel,
On Tue, Jul 03, 2012 at 08:33:13PM +0200, Lionel Elie Mamane lio...@mamane.lu
wrote:
The alternative would be to introduce an UI element
compress/cleanup/defrag database, but:
1) It would necessarily be specific to sdbc(x) direct drivers as AFAIK
odbc / jdbc / ... don't have
On Wed, Jul 04, 2012 at 09:30:20AM +0200, Miklos Vajna wrote:
On Tue, Jul 03, 2012 at 08:33:13PM +0200, Lionel Elie Mamane
lio...@mamane.lu wrote:
The alternative would be to introduce an UI element
compress/cleanup/defrag database, but:
1) It would necessarily be specific to sdbc(x)
On Wed, Jul 04, 2012 at 10:34:36AM +0200, Lionel Elie Mamane lio...@mamane.lu
wrote:
Yes, but *which* statement that is depends on the underlying database
engine. For example:
* HSQLDB: CHECKOPOINT DEFRAG; will do it on the whole database
* MySQL: OPTIMIZE TABLE foo, bar, qux; will do
Hi Lionel,
On Tue, 2012-07-03 at 20:33 +0200, Lionel Elie Mamane wrote:
I'm unsure whether I should apply this to libreoffice-3-6 or maybe
even libreoffice-3-5; I'd be glad of your opinions.
Sounds reasonable for -3-6 to me (but doesn't require approval there as
a bug fix:-).
This
Le 04/07/12 10:34, Lionel Elie Mamane a écrit :
Hi Lionel,
A big thumbs up from me. With a bit of luck, it might make hsqldb
embedded dbs a bit less corruption prone...
Alex
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
I'm unsure whether I should apply this to libreoffice-3-6 or maybe
even libreoffice-3-5; I'd be glad of your opinions.
The issue is that embedded HSQLDB does not reclaim space occupied by
deleted rows; it only overwrites them with new rows. So basically this
means that the data portion of an .odb
hsqldb fails to properly escape column names it generates
automatically from an expression in the script file it uses to
recreate the database (in memory) on load/connect.
The net effect is that any .odb file where such a view has been
defined cannot be reopened, unless one manually fiddles with
On 02/07/12 15:33, Lionel Elie Mamane wrote:
The fix to fdo#47473 exposed (the underlying reason for) fdo#51619
which could not be triggered before. So from the point of view of the
user, this is a regression in 3.5.5 wrt to 3.5.4: 3.5.4 did not crash
and 3.5.5 does.
Attached patch fixes
On Mon, Jul 02, 2012 at 03:33:21PM +0200, Lionel Elie Mamane wrote:
diff --git a/connectivity/source/commontools/dbtools.cxx
b/connectivity/source/commontools/dbtools.cxx
index 755fe9e..9286efd 100644
--- a/connectivity/source/commontools/dbtools.cxx
+++
On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
gerrit is documented and ready to go. Please use it for code review
as much as possible now as it simplifies things a lot over manual
patch fiddling on mailing lists.
So, I went to https://gerrit.libreoffice.org/#/c/255/
Then
On 02.07.2012 18:44, Bjoern Michaelsen wrote:
On Mon, Jul 02, 2012 at 06:13:50PM +0200, Lionel Elie Mamane wrote:
When I click Diff All Side-by-Side (or Diff All Unified), it shows
me only the first file with a link to the (diff) of the next file. I
expected to see the diff for*all* files on
On Thu, Jun 21, 2012 at 07:08:46PM +0200, Pierre-André Jacquod wrote:
Just to say, I basically just really do not like the fact of having
to use openId, would prefer to have an account at fd.o. I did it
really for the LibO, a kind of forced to. And NO, I do NOT have any
google, flickr,
On 19/06/12 14:44, Jan Holesovsky wrote:
Hi Norbert,
On 2012-06-19 at 07:23 -0500, Norbert Thiebaud wrote:
Thanks Robert for doing that! Please - is there any chance to use cgit
instead, so that it is compatible / familiar with the freedesktop
browsing?
in theory it is... but gitweb
On Thu, Jun 21, 2012 at 10:06:28AM +0200, Bjoern Michaelsen wrote:
On Thu, Jun 21, 2012 at 07:53:42AM +0200, Lionel Elie Mamane wrote:
As I review very few patches, keeping me happy in this respect is
probably not high priority, except maybe as a long tail argument (if
we have 100 committers
On Fri, Jun 22, 2012 at 01:13:50PM +0200, Lionel Elie Mamane wrote:
No. When I have some free / floating time, I hunt for low-hanging
fruit in the review queue (patches I can review without understanding
the area), so that the big reviewers can focus on the more
complicated reviews. So
On Wed, Jun 20, 2012 at 02:34:13PM +0200, Bjoern Michaelsen wrote:
On Wed, Jun 20, 2012 at 02:11:31PM +0200, Stephan Bergmann wrote:
Still, this removes the comments from many people's (potential)
sight. The IMO big advantage of the everything on a single mailing
list approach is that
On Wed, Jun 20, 2012 at 11:57 PM, David Ostrovsky
david.ostrov...@gmx.de wrote:
While claiming other people's work to be your own may be not a problem in
other contries,
here in gemany it is: in fact minister of defence and other politicians
stepped down for doing exactly that (copy/paste
Still, this removes the comments from many people's (potential) sight.
The IMO big advantage of the everything on a single mailing list
approach is that everybody is forced ;) to see everything (modulo
information overload)
So, IMHO that advantage not only has its drawbacks (information
On 06/20/2012 10:27 PM, David Ostrovsky wrote:
On 20.06.2012 14:11, Stephan Bergmann wrote:
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
I got one question with gerrit so far:
how can other people contribute code snippet into foreign gerrit patch
(so called extend it)?
During my work on
On 06/21/2012 08:08 AM, Norbert Thiebaud wrote:
On Wed, Jun 20, 2012 at 11:57 PM, David Ostrovsky
david.ostrov...@gmx.de wrote:
[...]
As I explained on IRC: someone that _is_ a Committer can do some
modification and still push the patch with you as author and him as
commiter (git allow that,
On Thu, Jun 21, 2012 at 02:10:05AM -0500, Norbert Thiebaud wrote:
On Thu, Jun 21, 2012 at 12:53 AM, Lionel Elie Mamane lio...@mamane.lu wrote:
What I fear the most in that is that I have no way to mark a patch as
I won't review it, not my area / I don't know / don't understand /
No
On Thu, Jun 21, 2012 at 07:09:15AM +0200, Lionel Elie Mamane wrote:
But frankly, why should Google, AOL, Wordpress or another person be
able to impersonate me at the TDF systems?
If you created an account at one of those, you are trusting them. The trust
issue is with account creation, not with
On Thu, Jun 21, 2012 at 07:53:42AM +0200, Lionel Elie Mamane wrote:
What I fear the most in that is that I have no way to mark a patch as
I won't review it, not my area / I don't know / don't understand /
With publish-to-ML, I just mark the post / whole thread as
read. With gerrit, I fear
Hi,
On Thu, Jun 21, 2012 at 07:31:15AM +0200, Lionel Elie Mamane wrote:
I understand gerrit is not able to understand such policies and we
will continue to enforce them manually by giving only codereview+1
unless there are already two other codereview+1.
But a bot using:
On Thu, Jun 21, 2012 at 09:46:54AM +0200, Bjoern Michaelsen wrote:
On Thu, Jun 21, 2012 at 07:09:15AM +0200, Lionel Elie Mamane wrote:
But frankly, why should Google, AOL, Wordpress or another person be
able to impersonate me at the TDF systems?
If you created an account at one of those, you
Hi Winfried!
On Thu, Jun 21, 2012 at 08:26:09AM +0200, Winfried Donkers wrote:
Not wanting to interfere, just to provide some feedback:
being a volunteer and being on the brink of newcomer and not-quite newcomer,
the mailing list gives me a lot of information. Comments on submitted patches
Zitat von Bjoern Michaelsen bjoern.michael...@canonical.com:
Something like:
- a short dialy digest of changes to keep reviewers in the loop
- _one_ mail once a change goes in with all the comments/revisions and
back-and-forth for this change in context in it
or something completely
On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
we vaguely considered running a TDF OpenID provider in the distant future,
but so shied away from that for the nontrivial cost (security is hard to
get right)
I imagine if Lionel wanted to re-open that decision, and has done
Hi Kendy,
On Thu, Jun 21, 2012 at 11:25:18AM +0200, Jan Holesovsky wrote:
I believe this way we might keep both camps (everything into ML like
me, and only discussions on the ML like Bjoern) happy - because the
people who want to have only discussions on the ML would be able to
filter out
On Thu, Jun 21, 2012 at 10:13:38AM +0100, Michael Meeks wrote:
On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
we vaguely considered running a TDF OpenID provider in the distant future,
but so shied away from that for the nontrivial cost (security is hard to
get right)
I
On Thu, Jun 21, 2012 at 08:07:45AM -0400, Terrence Enger wrote:
On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
My point is basically that it is too much of an investment for a
casual contributor... If we could
On Wed, 2012-06-20 at 22:46 +0200, Bjoern Michaelsen wrote:
Hi,
On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
My point is basically that it is too much of an investment for a
casual contributor... If we could make that easier by allowing plain
username+password
Hello,
well as free time contributor with commit access to current repository,
I followed this gerrit story. So not kind of surprise, but yeah, until
THIS mail and posts, was me very unclear what it would mean.
To say it, first I had a lot of doubt. Reading mails, entry in the wiki,
looking
Hi Pierre-André!
On Thu, Jun 21, 2012 at 07:08:46PM +0200, Pierre-André Jacquod wrote:
I push to gerrit and let tinderbox run. In case of success I get ? a
+1 of each tinderbox ? How do I know it passes with success.
a tinderbox would give you a +1verified, which means that it builds (and
On Thu, Jun 21, 2012 at 12:08 PM, Pierre-André Jacquod
pjacq...@alumni.ethz.ch wrote:
I push to gerrit and let tinderbox run. In case of success I get ? a +1 of
each tinderbox ?
Right now we don;t have tinderbox doing that yet... but when we do,
you'll need to asd a Review +1 to get the
On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go.
It refuses to take patches (commits) whose author field is not an
email address registered in my account.
How do I submit for review a patch
fdo#51243 caused by error in fix to fdo#48932, which introduced
infinite loop, and thus from the user's POV a freeze of the whole LibO
process.
Not visible in the patch, here's the code affected:
void SwFrameControlsManager::SetReadonlyControls( bool bReadonly )
{
map FrameControlType,
On Wed, Jun 20, 2012 at 4:21 AM, Lionel Elie Mamane lio...@mamane.lu wrote:
On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go.
It refuses to take patches (commits) whose author field is not
On Wed, Jun 20, 2012 at 11:27:25AM +0200, Lionel Elie Mamane wrote:
fdo#51243 caused by error in fix to fdo#48932, which introduced
infinite loop, and thus from the user's POV a freeze of the whole LibO
process.
Interestingly, the error is in the backport to libreoffice-3-5; the
original
to be *yet* *another* method.
Me personally, as a vested LibreOffice contributor, OK, I make efforts
for the common good so that we can have a better patch review /
handling mechanism (although I *do* *not* understand *at* *all* why we
have to require an OpenID, instead of offering it as an
alternative
On Wed, Jun 20, 2012 at 12:26:23PM +0200, Lionel Elie Mamane wrote:
Ah, I understand. When the gerrit repos are the true one source and
gerrit will do the push automatically once someone validates the
patch in the web interface, what will Committer be? The one that
uploaded the patch or the
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
On 19.06.2012 19:24, Petr Mladek wrote:
Sounds good but how many people would know about the comments? How hard
would be to find them?
https://gerrit.libreoffice.org/#/c/179/4/
(may be you need to login into gerrit with your openId)
You can see it
On Wed, Jun 20, 2012 at 02:11:31PM +0200, Stephan Bergmann wrote:
Still, this removes the comments from many people's (potential)
sight. The IMO big advantage of the everything on a single mailing
list approach is that everybody is forced ;) to see everything
(modulo information overload)
I
big blocks of commands, that was not the
case. And even if I had noticed, with the info I did (not) have, it's a
question what conclusion I would have drawn from it. As far as I was
concerned, it was a mail about getting accounts for some optional patch
review tool.
If you don't want people
On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote:
If you don't want people to miss important information, you need to announce
it properly and not as some offhand remark.
A mail with ACTION REQUIRED in the subject is not an offhand remark.
Having called it out with vigor in the
On Wed, Jun 20, 2012 at 5:26 AM, Lionel Elie Mamane lio...@mamane.lu wrote:
Ah, I understand. When the gerrit repos are the true one source and
gerrit will do the push automatically once someone validates the
patch in the web interface, what will Committer be? The one that
uploaded the patch
On Wednesday 20 of June 2012, Bjoern Michaelsen wrote:
On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote:
If you don't want people to miss important information, you need to
announce it properly and not as some offhand remark.
A mail with ACTION REQUIRED in the subject is not an
On Wed, Jun 20, 2012 at 8:52 AM, Lubos Lunak l.lu...@suse.cz wrote:
Besides, is every committer required to study ESC minutes?
That is the _one_ message a week that, yes, every committer should
read, or loose the right to complain about not being informed.
Norbert
On Wed, Jun 20, 2012 at 03:52:11PM +0200, Lubos Lunak wrote:
Besides, is every committer required to study ESC minutes?
Good question. IMHO not in general. But this is one of the rare occations,
where I think making a difference between volunteers and full-time paid
developers is sensible. I
On Tue, Jun 19, 2012 at 04:46:26PM +0100, Michael Meeks wrote:
On Tue, 2012-06-19 at 17:04 +0200, Lubos Lunak wrote:
My hope is that by encouraging the use of gerrit in parallel with the
mailing list, the benefits will become sufficiently obvious over time
that the old way of merging
On 20.06.2012 14:11, Stephan Bergmann wrote:
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
On 19.06.2012 19:24, Petr Mladek wrote:
Sounds good but how many people would know about the comments? How hard
would be to find them?
https://gerrit.libreoffice.org/#/c/179/4/
(may be you need to
Hi,
On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
However, our current setup *requires* an OpenID; is it an option to
make that optional (and allow people to e.g. use a classic
username+password for the web interface)?
no.
People like that (yes, I'm one of them) will
foreword: please trim the quotation when you reply...
On Wed, Jun 20, 2012 at 3:27 PM, David Ostrovsky david.ostrov...@gmx.de wrote:
May be I'm missing something obvious here, but how would it change the
things if you would use command line instead of web UI?
Choice is a great thing.
On 20.06.2012 22:47, Norbert Thiebaud wrote:
On Wed, Jun 20, 2012 at 3:27 PM, David Ostrovskydavid.ostrov...@gmx.de wrote:
AFAIKs it can not be solved with gerrit: only i can change my gerrit
patch/change.
really ?
I just did exactly that onhttps://gerrit.libreoffice.org/#/c/229/
Wow! no bad,
On Wed, Jun 20, 2012 at 10:46:24PM +0200, Bjoern Michaelsen wrote:
On Wed, Jun 20, 2012 at 09:47:48PM +0200, Lionel Elie Mamane wrote:
However, our current setup *requires* an OpenID; is it an option to
make that optional (and allow people to e.g. use a classic
username+password for the web
On Wed, Jun 20, 2012 at 01:43:26PM +0200, Bjoern Michaelsen wrote:
On Wed, Jun 20, 2012 at 12:26:23PM +0200, Lionel Elie Mamane wrote:
When the gerrit repos are the true one source and gerrit will do
the push automatically once someone validates the patch in the
web interface, what will
On Mon, Jun 18, 2012 at 09:14:09PM +0100, Caolán McNamara caol...@redhat.com
wrote:
On Mon, 2012-06-18 at 16:54 +0200, Lionel Elie Mamane wrote:
Legacy reports (not Sun/Oracle Report Builder ones) wizard show date
columns as an integer days-since-epoch instead of e.g. nicely
formatted
On 06/18/2012 10:14 PM, Caolán McNamara wrote:
On Mon, 2012-06-18 at 16:54 +0200, Lionel Elie Mamane wrote:
Legacy reports (not Sun/Oracle Report Builder ones) wizard show date
columns as an integer days-since-epoch instead of e.g. nicely
formatted DD-MM-YY (day-month-year) in *newly* *created*
On Mon, 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
gerrit is documented and ready to go.
Can I get superquick overview of why gerrit?. e.g. the problems we
have that gerrit fixes. My biggest concern has always been that patches
go into gerrit and disappear in an out of sight out of
Hi Bjoern,
On 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go. Please use it for code review as much as
possible now as it simplifies things a lot over manual patch fiddling on
mailing lists.
Can you
Bjoern Michaelsen píše v Po 18. 06. 2012 v 12:09 +0200:
Hi all,
with:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go.
Ah, there are several strange and long commands.
Also I miss the cooperation with the mailing list. I remember that the
main request
On Tue, Jun 19, 2012 at 08:57:28AM +0100, Caolán McNamara wrote:
Can I get superquick overview of why gerrit?. e.g. the problems we
have that gerrit fixes.
Gerrit will prevent exactly what you describe below, that is people having to
harvest across the mailing list for patches and never being
On Tue, Jun 19, 2012 at 10:31:08AM +0200, Jan Holesovsky wrote:
Hi Bjoern,
On 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go. Please use it for code review as much
as
possible now as it
So,
On Mon, 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go. Please use it for code review
as much as
Personally I'd like to see where we're at with gerrit, how it works,
get people trained up in
Hi Bjoern,
On 2012-06-19 at 11:30 +0200, Bjoern Michaelsen wrote:
http://sweetshark.livejournal.com/13298.html
gerrit is documented and ready to go. Please use it for code review as
much as
possible now as it simplifies things a lot over manual patch fiddling on
mailing
On Tue, Jun 19, 2012 at 11:54:25AM +0200, Jan Holesovsky wrote:
Maybe the command line interface will be easier to use, but
https://wiki.documentfoundation.org/Development/gerrit/PatchReview
did not convince me that it simplifies things a lot over manual patch
fiddling - described in my
On Tue, Jun 19, 2012 at 08:57:28AM +0100, Caolán McNamara wrote:
On Mon, 2012-06-18 at 12:09 +0200, Bjoern Michaelsen wrote:
gerrit is documented and ready to go.
Can I get superquick overview of why gerrit?. e.g. the problems we
have that gerrit fixes. My biggest concern has always been
On Tue, Jun 19, 2012 at 11:54:25AM +0200, Jan Holesovsky wrote:
If you answer was that the new workflow would be:
- click a link in a mail from gerrit
- that will open the syntax-highlighted cgit-like patch in the
browser, on a page with a big [Push it!] button + space to write the
On Tue, Jun 19, 2012 at 11:13:45AM +0200, Petr Mladek wrote:
It means that gerrit should be able to detect patches for review on the
mailing list, integrate them, and make them ready for review.
My expectation would be that it sends a replay to the mailing list with
a link to diff, link to
On Tue, Jun 19, 2012 at 4:54 AM, Jan Holesovsky ke...@suse.cz wrote:
I would be happy. But is it going to be so? So far the best I've got
from gerrit was clicking [Diff all unified], that opened one browser
window per file (ugh!), with more clicking to actually do the review.
We added gitweb
1 - 100 of 310 matches
Mail list logo
