Re: help request on proposed VCL code patch

2015-12-14 Thread Joel Madero
On 12/14/2015 06:46 AM, Lionel Elie Mamane wrote: > Was Caolan's commit, you said you would test "not before this weekend" > (a month ago), and to please poke you again "by Sunday" but nobody > poked you. (The poke fell through the list of things *I* have to do.) > >

Re: help request on proposed VCL code patch

2015-12-14 Thread Lionel Elie Mamane
On Mon, Dec 14, 2015 at 07:13:43AM -0800, Joel Madero wrote: > On 12/14/2015 06:46 AM, Lionel Elie Mamane wrote: >> Was Caolan's commit, you said you would test "not before this weekend" >> (a month ago), and to please poke you again "by Sunday" but nobody >> poked you. (The poke fell through the

Re: help request on proposed VCL code patch

2015-12-14 Thread Lionel Elie Mamane
On Mon, Dec 14, 2015 at 08:37:55PM +, Caolán McNamara wrote: > On Mon, 2015-12-14 at 15:13 +0100, Lionel Elie Mamane wrote: >> Well, you did, but apparently we didn't catch up on it and now we are >> about to ship 5.0.4 with a significant regression compared to 5.0.3 >> :-( >> See

Re: help request on proposed VCL code patch

2015-12-14 Thread Lionel Elie Mamane
On Wed, Nov 11, 2015 at 10:59:46AM +, Caolán McNamara wrote: > On Fri, 2015-10-30 at 11:31 +0100, Lionel Elie Mamane wrote: >> There is patch attached to tdf#94069, nominally a rather annoying >> Base UI bug (crash!), but which touches the VCL event loop (not >> specific to Base) in a way

Re: help request on proposed VCL code patch

2015-12-14 Thread Joel Madero
On 12/14/2015 06:13 AM, Lionel Elie Mamane wrote: > Do you think you can take a look at it "fast" or should we revert? I don't remember why/how I was involved with this? Did I say I would test it and somehow it fell through the list of things that I have to do? What should I "look at"? Was it

Re: help request on proposed VCL code patch

2015-12-14 Thread Lionel Elie Mamane
On Mon, Dec 14, 2015 at 06:37:36AM -0800, Joel Madero wrote: > On 12/14/2015 06:13 AM, Lionel Elie Mamane wrote: >> Do you think you can take a look at it "fast" or should we revert? > I don't remember why/how I was involved with this? Did I say I would > test it and somehow it fell through the

Re: help request on proposed VCL code patch

2015-12-14 Thread Lionel Elie Mamane
On Mon, Dec 14, 2015 at 06:59:27PM +0100, Alexander Thurgood wrote: > Le 14/12/2015 16:56, Lionel Elie Mamane a écrit : >> Regression is there. We are about to release 5.0.4.2 as final with >> that regression. > Looked at tdf#94069 and tested on master 5.2 alpha - I get no crash when > moving

Re: help request on proposed VCL code patch

2015-12-14 Thread Alexander Thurgood
Le 14/12/2015 16:56, Lionel Elie Mamane a écrit : Hi all, > Regression is there. We are about to release 5.0.4.2 as final with > that regression. > Looked at tdf#94069 and tested on master 5.2 alpha - I get no crash when moving the grid control around in a form in form design mode. What

Re: help request on proposed VCL code patch

2015-12-14 Thread Caolán McNamara
On Mon, 2015-12-14 at 15:13 +0100, Lionel Elie Mamane wrote: > Well, you did, but apparently we didn't catch up on it and now we are > about to ship 5.0.4 with a significant regression compared to 5.0.3 > :-( > > See https://bugs.documentfoundation.org/96482 > > Do you think you can take a look

Re: help request on proposed VCL code patch

2015-11-11 Thread Caolán McNamara
On Fri, 2015-10-30 at 11:31 +0100, Lionel Elie Mamane wrote: > Hi, > > There is patch attached to tdf#94069, nominally a rather annoying > Base UI bug (crash!), but which touches the VCL event loop (not > specific to Base) in a way that I don't understand the consequences > of If I look at