Re: Running unit test by make

2017-11-22 Thread Michael Stahl
On 12.11.2017 21:03, Bjoern Michaelsen wrote: > Hi, > > On Sun, Nov 12, 2017 at 07:00:33PM +0100, Zolnai Tamás wrote: >> Independently from the actual question, which is still unanswered, > > If the question is "why do we have this status quo?" the answer is "because it > is result of some

Re: Running unit test by make

2017-11-13 Thread Zolnai Tamás
Hi Bjoern, OK, thanks for the info. Not a real problem. I have a headache mostly because of the sd module, but now sd tests are moved to slowcheck, so something improved here at least. I guess if this fast tests (run by "make") are not usefull in general, in long term they will be moved all to

Re: Running unit test by make

2017-11-12 Thread Bjoern Michaelsen
Hi, On Sun, Nov 12, 2017 at 07:00:33PM +0100, Zolnai Tamás wrote: > Independently from the actual question, which is still unanswered, If the question is "why do we have this status quo?" the answer is "because it is result of some dozen discussions between developers (mostly on the ESC).".

Re: Running unit test by make

2017-11-12 Thread Zolnai Tamás
Oh, I just see that in sw module all tests are moved to slowcheck. I guess somebody already have this issue. So I do the same for sd model which has more and more tests nowdays.: https://gerrit.libreoffice.org/#/c/44656/ 2017-11-12 19:00 GMT+01:00 Zolnai Tamás : >

Re: Running unit test by make

2017-11-12 Thread Zolnai Tamás
Independently from the actual question, which is still unanswered, it's always a pleasure to see how "old" developers - living in a symbiosis with the code - are worrying about the status quo. 2017-11-12 18:39 GMT+01:00 Zolnai Tamás : > > As others have pointed out,

Re: Running unit test by make

2017-11-12 Thread Zolnai Tamás
> As others have pointed out, the targets you are looking for are available. >> If >> you dont like how they are named, please just create yourself some >> function or >> alias in your local ~/.bashrc, but do not force this on the rest of the >> world[1]. >> > Anyway adding an optional configure

Re: Running unit test by make

2017-11-12 Thread Zolnai Tamás
When I said I'll solve it locally, I mean I'll solve it on my machine only. 2017-11-12 18:29 GMT+01:00 Bjoern Michaelsen < bjoern.michael...@libreoffice.org>: > Hi, > > On Sat, Nov 11, 2017 at 09:40:41PM +0100, Zolnai Tamás wrote: > > I meant a configure option what you can add to autogen.input

Re: Running unit test by make

2017-11-12 Thread Bjoern Michaelsen
Hi, On Sat, Nov 11, 2017 at 09:40:41PM +0100, Zolnai Tamás wrote: > I meant a configure option what you can add to autogen.input and so you > don't need to type make .build or make build-nocheck, but use the > simple "make" for building and make check for run a build with tests, but > never mind

Re: Running unit test by make

2017-11-11 Thread Zolnai Tamás
I meant a configure option what you can add to autogen.input and so you don't need to type make .build or make build-nocheck, but use the simple "make" for building and make check for run a build with tests, but never mind I solve it locally. 2017-11-11 20:59 GMT+01:00 Jaskaran Singh

Re: Running unit test by make

2017-11-11 Thread Jaskaran Singh
Its actually make build-nocheck On Sun, Nov 12, 2017 at 1:16 AM, Noel Grandin wrote: > make build.nocheck​ > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org >

Re: Running unit test by make

2017-11-11 Thread Noel Grandin
make build.nocheck​ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Running unit test by make

2017-11-11 Thread Zolnai Tamás
Anyway, I guess it's OK if I add a config option which avoids running unit tests by simple make. It does not make too much sense to me to run only some of the tests on a module or on the full source. These tests are different only in the run time, so I can't imagine when it's usefull to run only

Re: Running unit test by make

2017-11-10 Thread Miklos Vajna
Hi, On Fri, Nov 10, 2017 at 08:03:18AM +0100, Zolnai Tamás wrote: > > make .build > > Great, but then what is simple make for? Similar to plain 'make' (which runs a subset of all tests: unit and slowchecks, but not subsequentchecks), 'make ' also runs only a

Re: Running unit test by make

2017-11-09 Thread Zolnai Tamás
2017-11-10 7:44 GMT+01:00 Noel Grandin : > if you don't want to run the tests you can do > > make .build > ​ > Great, but then what is simple make for? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Running unit test by make

2017-11-09 Thread Noel Grandin
if you don't want to run the tests you can do make .build ​ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Running unit test by make

2017-11-09 Thread Zolnai Tamás
Hi all, I wonder what the reason of running some of the unit tests by calling simple make on a module (e.g. make sd). I used to use simple make while doing the intensive hacking of the code, when I don't need to run unit tests at all. After I finished with the codewriting, I can run the unit