Re: concat of OUStringBuffer

2016-10-14 Thread Eike Rathke
Hi Stephan, On Wednesday, 2016-10-12 16:13:02 +0200, Stephan Bergmann wrote: > > "Don't allow O[U]StringBuffer in string concatenation" Thanks :-) Eike -- LibreOffice Calc developer. Number f

Re: concat of OUStringBuffer

2016-10-12 Thread Stephan Bergmann
On 10/11/2016 09:48 AM, Stephan Bergmann wrote: On 10/10/2016 10:24 PM, Eike Rathke wrote: I'd rather say it's a bug when assigning the involved OUStringBuffer (here aLCIDString) to itself again.. so for clarification: https://gerrit.libreoffice.org/#/c/28666/5 had aLCIDString = "[$-" + aL

Re: concat of OUStringBuffer

2016-10-11 Thread Stephan Bergmann
On 10/10/2016 10:24 PM, Eike Rathke wrote: I'd rather say it's a bug when assigning the involved OUStringBuffer (here aLCIDString) to itself again.. so for clarification: https://gerrit.libreoffice.org/#/c/28666/5 had aLCIDString = "[$-" + aLCIDString + "]"; aFormatStr.insert( nPosInser

Re: concat of OUStringBuffer

2016-10-10 Thread Eike Rathke
Hi, On Sunday, 2016-10-09 01:42:34 -0700, Laurent BP wrote: > Something changed recently in master with OUStringBuffer concatenation > > aLCIDString does not contain anymore "[$-some string]" but something like > "[$-[$-[$-0]". Is it a new feature? I'd rather say it's a bug when assigning the i

Re: concat of OUStringBuffer

2016-10-10 Thread Stephan Bergmann
On 10/09/2016 10:42 AM, Laurent BP wrote: aLCIDString does not contain anymore "[$-some string]" but something like "[$-[$-[$-0]". Is it a new feature? If you want an answer, give meaningful information: What code are you talking about? What exactly do you observe ("calling function X with

concat of OUStringBuffer

2016-10-09 Thread Laurent BP
Something changed recently in master with OUStringBuffer concatenation aLCIDString does not contain anymore "[$-some string]" but something like "[$-[$-[$-0]". Is it a new feature? - LibreOffice 5.1.4.1 -- View this message in context: http://nabble.documentfoun