Re: [Libreoffice] [REVIEW] fix for incorrect cell attribute import from xls

2011-01-21 Thread Tor Lillqvist
I would like to cherry-pick the following from master to libreoffice-3-3. Looks fine to me, approved. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

2011-01-21 Thread David Tardon
On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote: On Sat, Jan 15, 2011 at 08:00:05PM +, Caolán McNamara wrote: On Sat, 2011-01-15 at 05:59 +0100, Lionel Elie Mamane wrote: Does not fit release blocker criteria, but would still be *very* nice to have for the release, as

Re: [Libreoffice] 2 questions

2011-01-21 Thread David Tardon
On Fri, Jan 21, 2011 at 08:18:45AM +0100, Julien Nabet wrote: I try to debug the problem of the Alt key for Linux (when Alt key is released, it opens the file menu) I think (I'm not sure) the problem is in vcl in the unx part (since it impacts only Linux not Windows and I don't know for Macs).

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread Michael Meeks
On Thu, 2011-01-20 at 17:32 -0800, plino wrote: Wow. It took 12 hours for my post to show up... I'm really looking forward to a real Forum... It did ? can you substantiate that ? I read your post in the morning, and Tor (after doing some real research work on it) replied only three

Re: [Libreoffice] NEW [PATCH] Unix 64 bits property type / default value mismatch

2011-01-21 Thread Noel Power
On 21/01/11 06:59, Lionel Elie Mamane wrote: On Mon, Jan 17, 2011 at 04:58:28PM +, Caolán McNamara wrote: On Mon, 2011-01-17 at 15:18 +0100, Lionel Elie Mamane wrote: (...) we have to make these three places agree. As to whether it is in the direction of C/C++ long everywhere or in the

Re: [Libreoffice] 2 questions

2011-01-21 Thread Michael Meeks
Hi Julien, On Fri, 2011-01-21 at 08:18 +0100, Julien Nabet wrote: After a make, make dev-install. If I found a problem with LO, can I just do this : - source Linux... - go to the module I suppose there's the pb - make the change - build deliver 'deliver' should not be necessary;

[Libreoffice] [PUSHED] repo base and filters: removal of extra newlines

2011-01-21 Thread Michael Meeks
Hi Michael, On Fri, 2011-01-21 at 03:39 +0100, Michael Koch wrote: Attached you will find my first (but not last ;-) ) two patches. Great ! :-) good to have you on board. I wrote a Perl script to recursively search repos for suspicious files. (Files with a lot of empty line, code

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread Tor Lillqvist
Anyhow - if there is a lag, the solution to mail delivery problems is not (IMHO) forcing everyone to use yet-another awful web forum thing :-) Agree 100%. it would be wonderful if you could have a dig into the setup_native/ code, and/or the solenv/bin/make_installer.pl MSI creation to see if

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread plino
Hi Michael I did receive the email by Tor at the time. But I checked the Nabble site and my message was listed as pending until 1 AM, i.e 12 hours later... (and I have subscribed to this mailing list) This is the first time I'm using a mailing list that converts to a Forum and honestly I hate

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks [RESOLVED]

2011-01-21 Thread Michael Meeks
On Thu, 2011-01-20 at 20:27 +0100, Bircher Florian wrote: Seems like M.Meeks did make some changes and PUSHED it to master: cope with change of path, and broken absolute links this generates SHA1 ID: 52dc7cfbcdd2b71d789ec1068bebcde44235dcdc :-) Hope I didn't break anything too badly.

Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

2011-01-21 Thread Lionel Elie Mamane
On Fri, Jan 21, 2011 at 09:39:07AM +0100, David Tardon wrote: On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote: FYI, the OpenOffice.org side fixed this in a way that seems more robust to eventual future changes; you might want to push that way into at least master (IMHO

Re: [Libreoffice] [REVIEW] (Offensive Word Found In Message)

2011-01-21 Thread Noel Power
On 14/01/11 12:17, Caolán McNamara wrote: On Wed, 2011-01-12 at 12:25 +, Michael Meeks wrote: On Wed, 2011-01-12 at 06:17 -0600, Norbert Thiebaud wrote: is available for cherrypick/signoff It looks fine to me. Merged to libreoffice-3-3 and libreoffice-3-3-0, and re-working in

[Libreoffice] [PATCH] ure/sal/inc/rtl/ustring.hxx - new method isEmpty()

2011-01-21 Thread Thomas Arnhold
Hi folks, what do you think about this idea: New method: isEmpty() - Checks if a string is empty. This could simplify logics in the source. Now this test is done like 'if (aStr.getLength() != 0) {...}' or 'if (!aStr.getLength()) {...}'. With isEmpty() this looks like: if (aStr.isEmpty()) {...}

[Libreoffice] [PUSHED] (Reworked) some translations of comments in sw/inc

2011-01-21 Thread Michael Meeks
Hi Christoph, On Thu, 2011-01-20 at 23:39 +0100, Christoph Herzog wrote: Sending the patch attached to this mail. I was not aware that I did not sent it as an attachment in my previous post. I thought I did but obviously something went wrong. Hey :-) easily done. Looks

Re: [Libreoffice] [PATCH] impress - remove doubled copyright notice

2011-01-21 Thread Michael Meeks
Hi Thomas, On Fri, 2011-01-21 at 14:54 +0100, Thomas Arnhold wrote: won't do this without your approval. Looks fine to me - no point in duplicating license headers. Michael K was writing a nice lint tool, that may be able to find if this problem (duplicated license headers)

Re: [Libreoffice] [REVIEW] (Offensive Word Found In Message)

2011-01-21 Thread Caolán McNamara
On Fri, 2011-01-21 at 12:48 +, Noel Power wrote: Hmm missed this message in the email forest. Interesting, do you have more info on that? it seems lately I have stumbled into this code by accident a couple of time, if you have a bug # I might look further then next time.

Re: [Libreoffice] [PATCH] impress - remove doubled copyright notice

2011-01-21 Thread Thomas Arnhold
On 01/21/2011 03:08 PM, Michael Meeks wrote: Hi Thomas, On Fri, 2011-01-21 at 14:54 +0100, Thomas Arnhold wrote: won't do this without your approval. Looks fine to me - no point in duplicating license headers. Michael K was writing a nice lint tool, that may be able to find

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread Kevin Hunter
At 6:22am -0500 Fri, 21 Jan 2011, Plino wrote: I did receive the email by Tor at the time. But I checked the Nabble site and my message was listed as pending until 1 AM, i.e 12 hours later... (and I have subscribed to this mailing list) No, your message came through the list to me just over 30

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread Kevin Hunter
At 5:49am -0500 Fri, 21 Jan 2011, Michael Meeks wrote: Anyhow - if there is a lag, the solution to mail delivery problems is not (IMHO) forcing everyone to use yet-another awful web forum thing :-) FWIW, I 100% agree. This list archives all emails already, so they're already easily

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread plino
Thanks for clarifying that, Kevin. I still prefer a good ol' forum any day :) I agree with you that devs should not waste time with forums. But on the other hand, even an ignorant like me ;) who can't write a like of code, could contribute on such site as a Moderator or a Forum Helper...

[Libreoffice] PATCH Removal of Extra white space lines

2011-01-21 Thread Jonathan Aquilina
Attached please find my amended patch for the removal of extra white space lines in filter/source/xmlfilteradaptor/genericfilter.cxx MMeeks let me know how this looks if its good feel free to push From 744c48dd358a743118ba8cb1bf2162ca7d243df3 Mon Sep 17 00:00:00 2001 From: jonathan aquilina

Re: [Libreoffice] [PUSHED] repo base and filters: removal of extra newlines

2011-01-21 Thread Jonathan Aquilina
On 01/21/2011 12:16 PM, Michael Meeks wrote: Hi Michael, On Fri, 2011-01-21 at 03:39 +0100, Michael Koch wrote: Attached you will find my first (but not last ;-) ) two patches. Great ! :-) good to have you on board. I wrote a Perl script to recursively search repos for suspicious

[Libreoffice] [PUSHED] Re: NEW [PATCH] Unix 64 bits property type / default value mismatch

2011-01-21 Thread Caolán McNamara
On Fri, 2011-01-21 at 11:01 +, Noel Power wrote: On 21/01/11 06:59, Lionel Elie Mamane wrote: On Mon, Jan 17, 2011 at 04:58:28PM +, Caolán McNamara wrote: On Mon, 2011-01-17 at 15:18 +0100, Lionel Elie Mamane wrote: (...) we have to make these three places agree. As to whether it

[Libreoffice] [PUSHED] Re: [PATCH] sw: numbering misbehaviour

2011-01-21 Thread Caolán McNamara
On Wed, 2011-01-19 at 10:40 -0800, Octavio Alvarez wrote: Would this patch help? Ah yes, another dangling reference to the long removed right-arrow trick. Pushed, thanks for this. I had found and fixed another like this some time ago. There's still a pending patch in this thread IIRC. So what

[Libreoffice] RC4 / Windows size analysis ...

2011-01-21 Thread Michael Meeks
Hi guys, So - I re-ran the analysis on RC4 which is here: http://users.freedesktop.org/~michael/sizes3.ods (2.2Mb) Apart from a minor cockup (leaving tons of themes in there - when we only really want tango + hicontrast) - the next major source of bloat is code, and the

[Libreoffice] Break Failure with Application::ShowHelpStatusText()

2011-01-21 Thread Joseph Powers
It looks like this wasn't removed from some of the test code in bootstrap/automation/util. I need to go to work and wont be back home until late Saturday so, so I don't have time to fix. Just wanted to give someone a heads up. I tried rm -rf unmacxi.pro in the automations directory but that

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread plino
This might not be a Dev problem but since it's still related to the Windows installer... The RC4 installer correctly identified my location (once) and modified the installer language accordingly (I would prefer to choose it myself even if the installer provides a suggestion) The text on the

Re: [Libreoffice] [PATCH] ure/sal/inc/rtl/ustring.hxx - new method isEmpty()

2011-01-21 Thread Michael Meeks
Hi Thomas, On Fri, 2011-01-21 at 13:52 +0100, Thomas Arnhold wrote: New method: isEmpty() - Checks if a string is empty. I like it. There are lots of use-cases that we need to get into sal: that we sadly don't have at the moment: to make writing code easier and less

[Libreoffice] Wikihelp: Uploaded translations

2011-01-21 Thread Jan Holesovsky
Hi all, Yesterday I have uploaded the wikihelp translations to http://help.libreoffice.org , so far for the following languages: en, ca, cs, de, es, fr, hu, it, ja, pt, pt-BR, ru, sl, vi Please let me know if your language's help is translated, and you want to see it in wikihelp :-) From now

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-21 Thread Michael Meeks
Hi there, On Fri, 2011-01-21 at 08:34 -0800, plino wrote: This might not be a Dev problem but since it's still related to the Windows installer... Nice :-) The text on the first screen says in Portuguese something like Sun Microsystems thanks you for downloading LibreOffice 3.3 :)

Re: [Libreoffice] PATCH Removal of Extra white space lines

2011-01-21 Thread Michael Meeks
Hi there, On Fri, 2011-01-21 at 15:59 +0100, Jonathan Aquilina wrote: Attached please find my amended patch for the removal of extra white space lines in Amending the patch is not a great idea when the previous version is committed :-) MMeeks let me know how this looks if its good

[Libreoffice] [PATCH] Get rid of --noinhibit-exec

2011-01-21 Thread Lubos Lunak
Hello, I want to apply the attached bootstrap patch. It disables the very interesting feature of creating unusable binaries when one gets unlucky. From 'man ld': --noinhibit-exec Retain the executable output file whenever it is still usable. Normally, the linker will not produce an

[Libreoffice] [REVIEW] Fix KDE3 support (fdo#32797)

2011-01-21 Thread Lubos Lunak
(Yes, there are still people using that, go figure.) Could somebody please ACK these two commits for backport? Thanks. http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=b13f9e3374f8f605e6bf6f7be8819142060c37e9

Re: [Libreoffice] [PATCH] Fix configure check for BerkleyDB where db_create is macro

2011-01-21 Thread Petr Mladek
Hi, first, I am sorry that I committed the older proposed fix and caused Bernhard troubles. Unfortunately, the problem went somehow out of my radar until I saw Bernhard's bug https://bugs.freedesktop.org/show_bug.cgi?id=33230 Gökçen Eraslan píše v Po 10. 01. 2011 v 10:16 +: Perşembe 06

[Libreoffice] Windows Building with subst fails (already for a longer time)

2011-01-21 Thread Bircher Florian
Building on Windows is not easy as on Linux Due to sometimes longe paths I used subst to create new drives directly pointing to the libo source directory. For the first Beta it did work. After a break I had to get used to the new warper (g instead of bin/g). And got a lot of errors. (dmake 127?)

Re: [Libreoffice] Windows Building with subst fails (already for a longer time)

2011-01-21 Thread Fridrich Strba
It is funny. I run all release builds of libreoffice in a substed drive. I don't get dmake 127 errors though. The only errors I get time to time is dmake 126 error typically when processing xml (xcu) files. If you can debug dmake and find where your problem actually is, I would be a happy man.

[Libreoffice] make errors installing dependencies at libIDL - mac osx

2011-01-21 Thread David Dumaresq
Hi, I'm trying to get started contributing to libreoffice by setting up my Mac. I'm following the steps to prepare my system for dependencies and I'm using this document: http://wiki.documentfoundation.org/Development/Install_Mac_OS_10.6.4_Dependencies I'm getting make errors about

Re: [Libreoffice] RC4 / Windows size analysis ...

2011-01-21 Thread Kálmán „KAMI” Szalai
Title: Szalai Kálmán Hi! It seems we ship makefile.mk in libreoffice/basis3.3/share/template/layout That is not necessary. KAMI 2011-01-21 17:26 keltezéssel, Michael Meeks írta: Hi guys, So - I re-ran the analysis on RC4 which is

Re: [Libreoffice] [PATCH] [UX] Rename Default Formatting -- Clear Direct Formatting

2011-01-21 Thread Octavio Alvarez
Hi Christoph. Thanks for the comments. I'll do my best to address them one by one. On Fri, 21 Jan 2011 15:40:26 -0800, Christoph Noack christ...@dogmatux.com wrote: First, thanks for the in-depth analysis and the patches, but I am not that convinced that this will work as expected - at least

Re: [Libreoffice] make errors installing dependencies at libIDL - mac osx

2011-01-21 Thread Norbert Thiebaud
On Fri, Jan 21, 2011 at 6:59 PM, David Dumaresq dfdumar...@gmail.com wrote: Hi, I'm trying to get started contributing to libreoffice by setting up my Mac. I'm following the steps to prepare my system for dependencies and I'm using this document:        

[Libreoffice] Named range in DataPilot

2011-01-21 Thread Kohei Yoshida
Hi there, I just merged the feature/dp-named-range-source branch into master. With this merge, you can now use a named range to specify the data source of a data pilot table. The name of the range can be entered into the 'Selection From' field where you normally enter the data source range.

Re: [Libreoffice] מבצע פרסום בחינם באינטרנ

2011-01-21 Thread חגי סמולניק
קבלתי בתודה את פרסומכם אודה לקבלת פרטים נוספים היכן ניתן לראות את הפרסומים שלכם . חגי 054-9090423 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice