Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in tools/source/generic/poly.cxx

On 02/16/2012 09:43 PM, julien2412 wrote: /home/julien/compile-libreoffice/libo/tools/source/generic/poly.cxx:91:9: warning: Null pointer passed as an argument to a 'nonnull' parameter memset( mpPointAry, 0, nInitSize ); ^ ~~ 1 warning generated. Here are the line

[PATCH] [REVIEW:3-5] SQL parser bugs

Attached patches fix two SQL parser bugs: fdo#46206 - SQL: INSERT accepts only VALUES, not arbitrary SELECT query fdo#46198 - SQL: NULL not accepted in place of column name in SELECT statement (And might gain us a LibO user as a "transferee" from OpenOffice, see http://stackoverflow.com/question

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

On 17.02.2012 00:20, Kohei Yoshida wrote: As far as I know those STL methods that return its element are guaranteed to return a reference to the stored instance, not its copy. Ah, great, I was not sure of that. On 17.02.2012 01:01, Michael Meeks wrote: I guess :-) I imagine the real p

Re: feature/gbuild_java is finished

On Thu, Feb 16, 2012 at 03:29:59PM +0100, Matúš Kukan wrote: > On 16 February 2012 13:29, David Tardon wrote: > > The generated UNO classes must be present in ridl.jar . They are (or > > should be) added into the jar by > > > > $(eval $(call gb_Jar_add_packagedirs,ridl,\ > >    $(WORKDIR)/CustomTa

Re: Adding Extension for Experimental Thai Spelling

On Tue, 14 Feb 2012 16:19:17 + Caolán McNamara wrote: > I think this change: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=475d0c59c66fb7752d230f76130b17145aad0c12 > should improve matters a lot. It's a vast improvement - it gives LibreOffice a real Thai spell-checker. Thank you

[PATCH] Remove various unused Perl functions from installer

These patches remove some unused functions from installer::worker and installer::download. The unpack_all_targzfiles_in_directory sub only becomes unused after copy_install_sets_to_ship is removed. Kind regards, -- Tim Retout From 6929246241ca9ee034bc36ad98e9c1b7f60ef492 Mon Sep 17 00:00:00 20

[PATCH] Initial cleanup of installer::logger

Hi, This patch series removes some unused functions from installer::logger, and merges two very similar functions. Plus general cleanup. Kind regards, -- Tim Retout From 35b6a2c9ae816cbb99dbe4e79cae7115fdd26137 Mon Sep 17 00:00:00 2001 From: Tim Retout Date: Thu, 16 Feb 2012 19:46:12 + S

Re: Building LibreOffice on Windows

Hi Gareth, Tor Lillqvist píše v Čt 16. 02. 2012 v 17:13 +0200: > This is a short summary, and I might be missing something. For more > detail, there should be stuff in the wiki. Don't hesitate to ask more > on this list! And as you read the wiki, please fix inconsistencies you > notice, that is w

[REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

Hello, By keeping on reading the logs cclang compilation, I noticed this : /home/julien/compile-libreoffice/libo/vcl/unx/generic/app/i18n_wrp.cxx:250:9: warning: Null pointer passed as an argument to a 'nonnull' parameter dlclose(g_dlmodule); ^ ~~ 1 warning generated.

[PUSHED] Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in tools/source/generic/poly.cxx

On 16/02/2012 22:28, Michael Meeks wrote: ... So if I just follow the "pattern", here's an obvious patch : Looks great; and it's welcome on libreoffice-3-5 with my sign-off :-) Commit and pushed on master and 3.5 branch Thank you Michael for your review Julien. ___

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in tools/source/generic/poly.cxx

Hi Julien, On Thu, 2012-02-16 at 12:43 -0800, julien2412 wrote: > Advancing on the cclang compilation, I noticed this : Good catch ! :-) > So if I just follow the "pattern", here's an obvious patch : Looks great; and it's welcome on libreoffice-3-5 with my sign-off :-)

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

On Thu, Feb 16, 2012 at 4:01 PM, Michael Meeks wrote: > > On Thu, 2012-02-16 at 15:20 -0500, Kohei Yoshida wrote: >> > Is it a safe code? >> > >> >      pForbiddenCharacters = &maMap[ nLanguage ]; >> >      return pForbiddenCharacters; > ... >> So, in theory, taking the address of a returned objec

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

On Thu, 2012-02-16 at 15:20 -0500, Kohei Yoshida wrote: > > Is it a safe code? > > > > pForbiddenCharacters = &maMap[ nLanguage ]; > > return pForbiddenCharacters; ... > So, in theory, taking the address of a returned object which itself is a > reference to the instance stored in the co

Re: 3.5.0 - postgresql files missing in file-list/*.txt files

Hi, On Thu, Feb 16, 2012 at 06:23:15PM +0100, Andreas Radke wrote: > My ArchLinux installation makes use of the file-list/*.txt files to > split our packages. That way the postgresql-sdbc stuff is missing in > our installation. I guess they should be added to the base or common > file list. base.

[REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in tools/source/generic/poly.cxx

Hello, Advancing on the cclang compilation, I noticed this : /home/julien/compile-libreoffice/libo/tools/source/generic/poly.cxx:91:9: warning: Null pointer passed as an argument to a 'nonnull' parameter memset( mpPointAry, 0, nInitSize ); ^ ~~ 1 warning generated. H

Re: R: R: Building LibreOffice on Windows

Hi Walter, On Thu, 2012-02-16 at 18:50 +0100, walter wrote: > A few weeks ago I spoke by telephone with Italo Vignoli (The Document > Foundation) explaining my needs and the work that I hope to do. Sure, but unless you clearly explain your needs, it's hard for everyone else to know what y

Re: Building LibreOffice on Windows

On Thu, 2012-02-16 at 20:34 +0200, Tor Lillqvist wrote: > > That would be great but I don't think it would be very legal to distribute > > it :) > > Not to the general public, but surely to specfic customers that can > prove they have the required licenses themselves already? But IANAL...

[PATCH] Remove unused code in SvxSearchDialog

This patch removes unused code as listed in unusedcode.easy From 1f104bbd9a45535235677a01f770c5297ba23cf1 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Thu, 16 Feb 2012 21:34:44 +0100 Subject: [PATCH] Remove unused code in SvxSearchDialog --- svx/inc/svx/srchdlg.hxx |4 --- sv

Re: [PUSHED][PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

On Thu, 2012-02-16 at 10:48 +0400, Ivan Timofeev wrote: > Whoa, I seem to be too naive for patch-reviewing... > > Is it a safe code? > > pForbiddenCharacters = &maMap[ nLanguage ]; > return pForbiddenCharacters; Yeah I don't see anything wrong with it. > Will pForbiddenCharacters poin

Re: [PUSHED] Remove unused methods from PDFI

Hi On 15 February 2012 13:38, Michael Meeks wrote: > > On Mon, 2012-02-13 at 19:48 +, Kate Goss wrote: > > I'm also contemplating tackling bugs in bugzilla assistant, if that > > would be helpful. > > Oh ! cool :-) yes very much so, Rainer has a number of tweaks and > issues in there

[PATCH] Inline and remove installer::sorter

Hi, I didn't expect my previous patch series to be merged so quickly! This follow-up patch removes the installer::sorter module altogether - the Schwartzian transform was not appropriate, as the overhead of map-sort-map is greater than just looking up the hash values for most workloads. So this a

Re: [PUSHED] Refactor installer::sorter

On 16 February 2012 17:46, Markus Mohrhard wrote: > Lovely. It is always a great pleasure to see more tests in our code base ;) > > Do you see a benefit for us if we execute the test regularly? If so we > can search for a nice place where we can integrate the test into our > build system and execu

Re: dbaccess_macros_test: no orderly shutdown

On 02/15/2012 08:12 PM, Stephan Bergmann wrote: * Thread 4 is executing a comphelper::AsyncEventNotifier. That class is mentioned only in a few places (dbaccess/source/core/dataaccess/documenteventnotifier.cxx, extensions/source/propctrl/browserlistbox.cxx, and forms/source/component/ListBox.{hxx

Re: Building LibreOffice on Windows

> That would be great but I don't think it would be very legal to distribute it > :) Not to the general public, but surely to specfic customers that can prove they have the required licenses themselves already? But IANAL... --tml ___ LibreOffice mailin

Re: [REVIEWED] Remove unused (hopefully!) methods from l10ntools Export

Hi Michael, On 16 February 2012 11:00, Michael Meeks wrote: > > On Wed, 2012-02-15 at 20:34 +, Kate Goss wrote: > > Another patch to remove methods listed as unused in unusedcode.easy > > Gosh; sorry about this one too ! Caolan seemed to remove those > yesterday himself. It looks li

R: R: Building LibreOffice on Windows

A few weeks ago I spoke by telephone with Italo Vignoli (The Document Foundation) explaining my needs and the work that I hope to do. Regards walter ___ On Thu, 2012-02-16 at 18:24 +0100, walter

Re: [PUSHED] Refactor installer::sorter

Hello tim, >> I added a unit test for the remaining sort function, but I haven't >> tried to plug it in to the build system or anything.  I tried to adapt >> the standard license header template to Perl comments. > >        Oh - interesting. So I think this might be our first perl unit test > ever

Re: R: Building LibreOffice on Windows

On Thu, 2012-02-16 at 18:24 +0100, walter wrote: > My only problem is knowing whether to invest my time in 'cygwin' or Linux. > I need to build a customized version, and the new code will be returned to > the community It depends what you want to achieve. If you want to get a bug fixed th

R: Building LibreOffice on Windows

>In other words, you are doing this commercially, as part of your job, for business purposes? [walter] YES >So you are instead demanding that the "community" (which consists of volunteers spending their own personal resources, and paid developers working for >companies that might even be your co

3.5.0 - postgresql files missing in file-list/*.txt files

My ArchLinux installation makes use of the file-list/*.txt files to split our packages. That way the postgresql-sdbc stuff is missing in our installation. I guess they should be added to the base or common file list. -Andy ___ LibreOffice mailing list Li

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

On 02/16/2012 05:12 PM, Stephan Bergmann wrote: On 02/16/2012 04:50 PM, Stephan Bergmann wrote: On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As per "Importing uno bindings in pytho

Re: Building LibreOffice on Windows

Hi Tor, > > Or you could contract out the effort of setting up a working build > environment on a machine... For instance provide a Windows virtual > machine image with everything set up. That would be great but I don't think it would be very legal to distribute it :) -- Jesús Corrius

Re: feature/gbuild_java is finished

On 16 February 2012 15:29, Matúš Kukan wrote: > -       $(foreach root,$(PACKAGEDIRS),&& $(gb_Jar_JARCOMMAND) uf $(2) > -C $(dir $(root)) $(notdir $(root))) \ > +       $(foreach root,$(PACKAGEDIRS),&& cd $(dir $(root)) && > $(gb_Jar_JARCOMMAND) uf $(2) $(notdir $(root))) \ > > helps solve the pro

Re: Building LibreOffice on Windows

> I am a windows developer and I need to integrate LibreOffice in our windows > business application. In other words, you are doing this commercially, as part of your job, for business purposes? > I would have a hard time switching to develop using Linux. We don't have any immediate plans to dro

minutes of ESC call ...

* Present + Rainer, Stephan, Eike, David, Mitch, Michael, Lionel Kendy, Bjoern, Cedric, Caolan, Michael S, Thorsten, Petr, Kohei * Completed Action Items + branch 'build', 'bootstrap' as libreoffice-3-5 or sim., and wipe master with a helpful link (Mic

Re: R: Building LibreOffice on Windows

On Thu, 2012-02-16 at 18:02 +0100, walter wrote: > It would be interesting that a core developer uses Cygwin :) I do when I'm on Windows. It's not like we have any other choices anyway. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffic

Re: Building LibreOffice on Windows

> It would be interesting that a core developer uses Cygwin :) The build on Windows using cygwin is more complicated than on Linux. But once you have the beast built, the development should be exactly the same. -- Jesús Corrius ___ LibreOffice mailing

R: Building LibreOffice on Windows

It would be interesting that a core developer uses Cygwin :) > But the real problem is that if the community does not want or can not > support then development on the windows platform is good for me to say > this very clearly. > I can not go and play around and waste time in this way. What d

Re: windows / cygwin - unable to start build

On Thu, 2012-02-16 at 11:42 +0100, walter wrote: > I have installed the last version of Cygwin: OK ? > CYGWIN_NT-6.1-WOW64 LAZY 1.7.10(0.259/5/3) 2012-02-05 12:36 i686 > Cygwin ... > Now I can not start the build. And it used to work with an older version of Cygwin ? if so, I'd

Re: windows / cygwin - unable to start build

Hi Walter, 2012/2/16 walter : > I have installed the last version of Cygwin: > > CYGWIN_NT-6.1-WOW64 LAZY 1.7.10(0.259/5/3) 2012-02-05 12:36 i686 Cygwin > > > > Now I can not start the build. > > Please see logs AT http://pastebin.com/u/walterLO Do you have process.h in /usr/include? Cheers, And

Re: [PUSHED] Turn on strictures for some installer Perl modules

Hi Tim, On Thu, 2012-02-16 at 11:08 +, Tim Retout wrote: > Ah, thanks for pointing me to that. There's some nice cleanup > possible in installer::parameter. :-) > >make cmd cmd="solenv/bin/ooinstall ..." > > Running this under Devel::NYTProf, I found that a good deal of the

Re: Building LibreOffice on Windows

> But the real problem is that if the community does not want or can not > support then development on the windows platform is good for me to say this > very clearly. > I can not go and play around and waste time in this way. What do you mean by supported? -- Jesús Corrius _

R: Building LibreOffice on Windows

I am a windows developer and I need to integrate LibreOffice in our windows business application. I would have a hard time switching to develop using Linux. But the real problem is that if the community does not want or can not support then development on the windows platform is good for me to say

Re: Building LibreOffice on Windows

Hi guys, > If at all possible, rather run Ubuntu (or some other Linux distro) inside a > VMWare virtual machine on your Windows desktop. We should encourage Windows developers to join the project to have a better Windows version. Telling them to use Linux will not improve the situation. -- Jesú

RE: qa-build errros on clean code

Markus Mohrhard wrote (15 februari 2012 19:05) >I don't like this solution but well the other option is to debug ucalc >and find why it fails ( it does not for me ). Since you now disabled >the test can you at least check after a full build that if you start >calc insert a note in B2 and then inser

Re: Building LibreOffice on Windows

On 16/02/12 16:17, Noel Grandin wrote: > Hi > > If at all possible, rather run Ubuntu (or some other Linux distro) > inside a VMWare virtual machine on your Windows desktop. > > It's much easier, speaking as someone who does just that, after spending > too long fighting with building under Window

Re: Building LibreOffice on Windows

On Thu, 2012-02-16 at 17:17 +0200, Noel Grandin wrote: > Hi > > If at all possible, rather run Ubuntu (or some other Linux distro) > inside a VMWare virtual machine on your Windows desktop. Don't forget openSUSE and Fedora. We have quite a number of core developers from both of these distros, so

[PATCH] Removed unused code from vcl module

Hi! I removed unused code from vcl module (used unusedcode.easy) Removed methods: vcl::LazyDeletor::is_less(Menu*, Menu*) vcl::PDFExtOutDevData::EndGroup() vcl::PDFExtOutDevData::GetFormsFormat() const vcl::PDFExtOutDevData::SetAutoAdvanceTime(unsigned int, int) vcl::PDFExtOutDevData::S

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

On 02/16/2012 04:50 PM, Stephan Bergmann wrote: On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As per "Importing uno bindings in python causes crash" the master commit

R: Building LibreOffice on Windows

In the long run the best choice is definitely to abandon cygwin and develop using Linux. I used cygwin for a little while and I've seen that is not well supported L Which version of Linux is better to use? There are big differences between using Ubuntu and CentOS? Regards, walter

Re: Building LibreOffice on Windows

Hi If at all possible, rather run Ubuntu (or some other Linux distro) inside a VMWare virtual machine on your Windows desktop. It's much easier, speaking as someone who does just that, after spending too long fighting with building under Windows. Regards, Noel. On 2012-02-16 16:54, Gareth

Re: [PATCH] Translate German comments

On 16 February 2012 13:37, Lionel Elie Mamane wrote: > Thank you very much. Radek beat me to it to commit that, but there > seems to be an untranslated word that is left; "Geschachtelte" in > > -    // MIB 25.6.98: Geschachtelte Formulare abfangen ... oder muesste > -    // man sie submitten? > +

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44143, which changed state. Bug 44143 Summary: formula's that use data from pivot table don't update with the pivot table https://bugs.freedesktop.org/show_bug.cgi?id=44143 What|Old Value

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As per "Importing uno bindings in python causes crash" the master commit

Re: Configure LO for Python 3?

On 02/16/2012 01:46 PM, Rene Engelhard wrote: On Thu, Feb 16, 2012 at 01:29:59PM +0100, Rene Engelhard wrote: On Thu, Feb 16, 2012 at 01:08:48PM +0100, Stephan Bergmann wrote: With "Port PyUno to s

[PATCH] fdo#46166: EasyHack: remove obsolete MSFilterTracer

Hi! I removed the MSFilterTracer class as suggested by Caolán McNamara. Hope it's ok. Szabolcs From 3f02b8043d86341572727b772c934ab7ccb496ec Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi Date: Thu, 16 Feb 2012 16:11:52 +0100 Subject: [PATCH] Removed ob

Re: Building LibreOffice on Windows

> New to open source and attracted to LibreOffice and I want to start > contributing. Great! Welcome! > But how does the whole build process work on Windows? This is a short summary, and I might be missing something. For more detail, there should be stuff in the wiki. Don't hesitate to ask more

Building LibreOffice on Windows

Hi, New to open source and attracted to LibreOffice and I want to start contributing. But how does the whole build process work on Windows? Gareth ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

[PATCH]fdo#44516 improved label and business card document creation (2/3)

Attached a first fix for the problems that showed after my first patch for fdo44516. Labels documents are now created with proper gaps between the labels. The fix is not yet complete, but covers approx. 95% percent of the labels. My next fix will be for the remaining 5%. That is for labels where

Re: feature/gbuild_java is finished

On 16 February 2012 13:29, David Tardon wrote: > The generated UNO classes must be present in ridl.jar . They are (or > should be) added into the jar by > > $(eval $(call gb_Jar_add_packagedirs,ridl,\ >    $(WORKDIR)/CustomTarget/ridljar/javamaker/class/com \ > )) Ok, so they were present but in

Re: [REVIEWED][REVIEW-3-5] Fix for fdo#45177 - crash in Impress outline view

Caolan McNamara wrote: > Meh, pushed, can't make it worse I guess. > Yeah, that was somehow my take there. ;) Thanks, -- Thorsten pgpWOPDwCUrpo.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

On 02/16/2012 12:18 PM, Matteo Casalin wrote: I personally find 'if' more legible than ?: and definitely expressions like b = x==y || x==z; I am not sure if WindowAlign will always have only these 4 members and possibly the author of the original version wasn't either (thus final else). Since

[PUSHED] Refactor installer::sorter

Hi Tim, On Wed, 2012-02-15 at 21:58 +, Tim Retout wrote: > Here are a few patches related to installer::sorter. I've tried to > keep them low-risk, because much of the code is called during Windows > builds, which I'm not yet testing. Thanks ! :-) One thing I do when I hack this stuf

Re: [PUSHED][PATCH] Removed unused code from MSFilterTracer

On Thu, 2012-02-16 at 12:42 +, Caolán McNamara wrote: > Its all out of date, it was an effort to sort of log what MSWord > features we *didn't* import/export got used in documents in order to > target what we'd implement next but I know I found it more of an effort > to log the details of what

Re: [ANN] Referencing bugs in commits

Hi Lionel, On 2012-02-16 at 14:11 +0100, Lionel Elie Mamane wrote: > It seems to set "target:3.6" for commits to master. As per > http://wiki.documentfoundation.org/BugReport_Details, this should be > "3.6.0". Fixed :-) Regards, Kendy ___ LibreOffic

Re: [ANN] Referencing bugs in commits

On Tue, Feb 14, 2012 at 07:49:04PM +0100, Jan Holesovsky wrote: > Ivan Timofeev píše v Út 14. 02. 2012 v 20:33 +0400: >> Is it possible somehow include the information about a target version? > Oh - great idea :-) Added that to the script; it does some best-effort > guess, (...) > Please test t

[PATCH] Removed unused code from svl, svtools and sfx2

Hi! I removed some unused code from modules svl, svltools and sfx2 according to unusedcode.easy. Removed functions: SfxAppMenuControl_Impl::RegisterControl(unsigned short, SfxModule*) SfxApplication::Main() SfxBrushItemLink::Set(SfxBrushItemLink*) SfxHintPoster::RegisterEvent() SfxProg

[PATCH] [REVIEW:3-5] fdo#46163 database form listbox only for VARCHAR

Just reported and fixed fdo#46163. A list box is a control that is supposed to match two sets of data: An entry in the "list content" property is matched to the corresponding entry in the "list entries" property (yeah, that's rather confusing naming...). The "list entries" entry is shown to the

Re: Configure LO for Python 3?

Hi, On Thu, Feb 16, 2012 at 01:29:59PM +0100, Rene Engelhard wrote: > On Thu, Feb 16, 2012 at 01:08:48PM +0100, Stephan Bergmann wrote: > > With > > > > "Port PyUno to support Python 3," is there an

[REVIEW:3-5] bin bogus JRE warnings on first-start ...

Hi there, This is not really my sphere of expertise, so review appreciated. Rather than clobber the DesktopContext with some out-of band magic (which creates the JavaInteractionHandler that in the end complains). I thought I'd just give this guy a nil context - which seems to work reasonab

Re: [PUSHED][PATCH] Removed unused code from MSFilterTracer

On Thu, 2012-02-16 at 11:18 +0100, Dézsi Szabolcs wrote: > Hi! > > sry didn't attach file :$ > This is my first patch, I hope everything's correct. > Removed functions: (used unusedcode.easy) Looks good to me, pushed now, thanks for this. IMO the whole MSFilterTracer thing can/should go if you

Re: [PATCH] Translate German comments

On Wed, Feb 15, 2012 a-t 03:36:25PM +0100, Philipp Weissenbacher wrote: > Here are the files you mentioned earlier. Thank you very much. Radek beat me to it to commit that, but there seems to be an untranslated word that is left; "Geschachtelte" in -// MIB 25.6.98: Geschachtelte Formulare ab

Re: Configure LO for Python 3?

Hi, On Thu, Feb 16, 2012 at 01:08:48PM +0100, Stephan Bergmann wrote: > With > > "Port PyUno to support Python 3," is there any way to configure a LO > build so that it actually uses Python 3 instea

Re: feature/gbuild_java is finished

On Thu, Feb 16, 2012 at 11:38:07AM +0100, Matúš Kukan wrote: > On 16 February 2012 00:52, Matúš Kukan wrote: > > I had a look but couldn't build jurt: > > So, if we don't want to use $(OUTDIR)/class, adding > > +$(eval $(call gb_Jar_add_jars,jurt,\ > +$(WORKDIR)/CustomTarget/ridljar/javamake

Re: [PUSHED][PATCH] [core/linguistic/source/dlistimp.*:*]: (performance) Possible inefficient checking for 'aDicList' emptiness.

looks perfectly sane, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: [PATCH] Translate German comments

Hi Philipp, looks good. Pushed. Thanks! Happy to not have to translate these comments when run into them :-) Cheers Radek On Wed, 2012-02-15 at 15:36 +0100, Philipp Weissenbacher wrote: > Hi all, Lionel, > > Here are the files you mentioned earlier. > Hope quality didn't suffer with this quick

Configure LO for Python 3?

With "Port PyUno to support Python 3," is there any way to configure a LO build so that it actually uses Python 3 instead of 2, on a Fedora 16 machine that has both installed? Stephan __

Re: [PATCH] Removed unused functions from MultiLineEdit in svtools module

2012/2/16 Caolán McNamara : > On Thu, 2012-02-16 at 11:54 +0100, Dézsi Szabolcs wrote: >> Hi! >> >> I removed 4 unused functions from class MultiLineEdit. (based on >> unusedcode.easy) > > Looks good, pushed now, thanks for this. Can you add yourself to > http://wiki.documentfoundation.org/Developm

Re: [REVIEWED][REVIEW] fdo#45553 fix RTF import of space-before/after tokens

On Thu, Feb 16, 2012 at 11:54:17AM +, Caolán McNamara wrote: > Done. I won't pretend I understand the commit, but nothing screams > wrong. Just for the reference - the rtf tokenizer generates a parse tree, which is then accessed by the domain mapper. In this case the problem was that these p

[REVIEWED][REVIEW-3-5] Fix for fdo#45177 - crash in Impress outline view

On Wed, 2012-02-15 at 17:21 +0100, Thorsten Behrens wrote: > Hi, > > couldl someone please review > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=57e6f04066cfddfa79eb2b79cf5c45653c79eff3 > > and cherry-pick to -3-5? It's not a final solution, since we're > loosing some convenienc

Re: [REVIEWED][REVIEW] fdo#45553 fix RTF import of space-before/after tokens

On Wed, 2012-02-15 at 12:10 +0100, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c32b9cd2139249f0c680f664a0ceac3702dd0e73 > > Could someone review and cherry-pick to -3-5, please? Done. I won't pretend I understand the commit, but nothing screams wro

[PUSHED] Re: [PATCH] Remove unused code

Hi Björgvin, looks good to me. Pushed. Thanks! Cheers Radek On Wed, 2012-02-15 at 01:10 +, Björgvin Ragnarsson wrote: > Hi, > > Attached is a patch for removal of unused code in files > core/basegfx/source/polygon/b3dpolygontools.cxx and > core/basegfx/inc/basegfx/polygon/b3dpolygontools.hx

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

Hi all, -- Mariusz Dykierek wrote: (16/02/2012 11:46) > On 2012-02-16 10:02, Stephan Bergmann wrote: > > On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote: > >> Otherwise you can simplify it even more: > >> > >> sal_Bool bLeft = (meAlign == WIND

Re: [REVIEWED][REVIEW-3-5] Fix some apparent misuses of RTL_CONSTASCII_USTRINGPARAM

On Wed, 2012-02-15 at 23:32 +0100, Stephan Bergmann wrote: > The attached > core-0001-Fix-some-apparent-misuses-of-RTL_CONSTASCII_USTRINGP.patch and > binfilter-0001-Fix-some-apparent-misuses-of-RTL_CONSTASCII_USTRINGP.patch damnit, yeah, pushed now. C.

Re: [PATCH] Removed unused functions from MultiLineEdit in svtools module

On Thu, 2012-02-16 at 11:54 +0100, Dézsi Szabolcs wrote: > Hi! > > I removed 4 unused functions from class MultiLineEdit. (based on > unusedcode.easy) Looks good, pushed now, thanks for this. Can you add yourself to http://wiki.documentfoundation.org/Development/Developers and send a mail to the

Re: [REVIEWED][REVIEW-3-4] Ctrl+Alt type shortcuts don't work on Windows

On Thu, 2012-02-16 at 12:10 +0100, Andras Timar wrote: > default shortcut for .uno:SearchDialog should be Ctrl+H > Ctrl+Alt+F was not good, because on some keyboard layouts it enters a > character. Ctrl+Alt (=AltGr on Windows) should be avoided, if > possible. Seems reasonable, done. C.

Re: [PATCH] Remove unused code from gtkframe

On Wed, 2012-02-15 at 22:55 +0100, Michael Stahl wrote: > On 15/02/12 21:31, Kate Goss wrote: > > Hi Michael, Caolan, > > > > How accurate/ up to date is unusedcode.easy? Is there a way to make sure > > the methods I'm removing are genuinely unused? Its generally up to date, but it always require

[REVIEW-3-4] Ctrl+Alt type shortcuts don't work on Windows

Hi, A friend of mine asked me, if it was possible backport the following fix to 3.4, too. http://cgit.freedesktop.org/libreoffice/core/commit/?id=a75cb232c41b9f895e27dd85532ff624f85181de default shortcut for .uno:SearchDialog should be Ctrl+H Ctrl+Alt+F was not good, because on some keyboard lay

Re: [PUSHED] Turn on strictures for some installer Perl modules

On 15 February 2012 11:58, Michael Meeks wrote: >        Also the 'make_installer.pl' takes about 20 options, AFAIR there are > however only a few legitimate parameters / configurations that are > possible in the LibreOffice world. > >        So - digging out the call sites (luckily the ooinstall

Re: [Libreoffice-commits] .: "enable XDatabaseRangeTest again"

Fixed now. Sorry for that. 2012/2/16 Stephan Bergmann : > On 02/16/2012 12:58 AM, Markus Mohrhard wrote: >> >>  dbaccess/Module_dbaccess.mk            |    6 +- >>  sc/Module_sc.mk                        |    1 + >>  sc/qa/extras/scdatabaserangeobj.cxx    |    6 -- >>  sc/qa/unit/filters-t

Re: dbaccess_macros_test: no orderly shutdown

Hi Stephan, On Wed, 2012-02-15 at 20:12 +0100, Stephan Bergmann wrote: > Just experienced a spurious crash of cppunittester when executing > Cppunit_dbaccess_macros_test, see backtraces below: Good :-) I was getting an apparently unrelated memory corruption destroying some vector of tool

[REVIEWED] Remove unused (hopefully!) methods from l10ntools Export

On Wed, 2012-02-15 at 20:34 +, Kate Goss wrote: > Another patch to remove methods listed as unused in unusedcode.easy Gosh; sorry about this one too ! Caolan seemed to remove those yesterday himself. It looks like he re-generated the unusedcode.easy list too (from a compilation with g

[PATCH] Removed unused functions from MultiLineEdit in svtools module

Hi! I removed 4 unused functions from class MultiLineEdit. (based on unusedcode.easy) Functions removed: MultiLineEdit::GetHScrollBar() const MultiLineEdit::GetLeftMargin() const MultiLineEdit::GetTextLines() const MultiLineEdit::IsFocusSelectionHideEnabled() const Files modified: svt

Re: [PATCH] Refactor installer::sorter

On 15 February 2012 21:58, Tim Retout wrote: > subroutines, and replaced the third with a Schwartzian Transform > (which might be overkill for this case, but I need to check the > callers). Yeah, I've woken up and benchmarked this, and the complexity just makes it slower compared to just doing th

Re: Master fails to compile with cclan in moz module

Hi Julien, On Wed, 2012-02-15 at 14:51 -0800, julien2412 wrote: > I'm still trying to compile with llvm/cclang. I disabled mozilla compilation > and it compiled until cairo. Nice :-) > If someone has an idea about this cairo problem cairo-mutex-impl-private.h:262:3: error: #error "XXX:

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else.

On 2012-02-16 10:02, Stephan Bergmann wrote: > On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote: >> Otherwise you can simplify it even more: >> >> sal_Bool bLeft = (meAlign == WINDOWALIGN_TOP || meAlign == >> WINDOWALIGN_LEFT) ? sal_False : sal_True; > > ... which of course reduces to > >> bool

windows / cygwin - unable to start build

I have installed the last version of Cygwin: CYGWIN_NT-6.1-WOW64 LAZY 1.7.10(0.259/5/3) 2012-02-05 12:36 i686 Cygwin Now I can not start the build. Please see logs AT http://pastebin.com/u/walterLO Regards walter ___ LibreOffice mailing lis

Re: [Libreoffice-commits] .: "enable XDatabaseRangeTest again"

On 02/16/2012 12:58 AM, Markus Mohrhard wrote: dbaccess/Module_dbaccess.mk|6 +- sc/Module_sc.mk|1 + sc/qa/extras/scdatabaserangeobj.cxx|6 -- sc/qa/unit/filters-test.cxx|2 +- test/inc/test/sheet/xdatabaserange.hx

Re: Mail Merge Functionality

Hi Jerry, On Wed, 2012-02-15 at 18:17 -0800, J B wrote: > I like to say the LibreOffice just keeps getting better and better, > keep up the good work. Thank you - it's great to encourage other developers as you get involved yourself :-) > One item I would like to see improved is the Mai

Re: feature/gbuild_java is finished

On 16 February 2012 00:52, Matúš Kukan wrote: > I had a look but couldn't build jurt: So, if we don't want to use $(OUTDIR)/class, adding +$(eval $(call gb_Jar_add_jars,jurt,\ +$(WORKDIR)/CustomTarget/ridljar/javamaker/class \ +)) in Jar_jurt.mk seems to help. I wonder how this works on oth

  1   2   >