Re: [PUSHED] PATCH: Remove unused code from editing

2012-04-24 Thread Vicente Rafael Estévez Vacas
Thanks Caolan, I have not used a development environment and I have not noticed the lapse. I'm usually spoiled by working with Eclipse and automatically notify me of these errors. Did I correct it and send it back to? Yeah right, I will confirm the terms of license LGPLv3 + / MPL + combination.

Re: [PUSHED][PATCH] Remove unused code in dpitemdata

2012-04-24 Thread Caolán McNamara
On Mon, 2012-04-23 at 19:27 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Tor Lillqvist
I am once again pretty confused. From a high-level point of view, what is the intent: - Should a new, naïve contributor be able to run just ./autogen.sh without any options and, assuming his platform is a reasonably well supported one, get a working, perhaps minimal (i.e. quicker/easier to

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added CC||jumbo4...@yahoo.fr ---

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Stephan Bergmann
On 04/23/2012 06:17 PM, Petr Mladek wrote: I am not sure but I think that strip reduces size of binaries even when you build without -g. It just removes something less important. strip removes the table of internal symbols. The effect is that backtrace information (whether produced by LO's

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 10:24 +0300, Tor Lillqvist wrote: I am once again pretty confused. From a high-level point of view, what is the intent: - Should a new, naïve contributor be able to run just ./autogen.sh without any options and, assuming his platform is a reasonably well supported

Re: [PUSHED][PATCH] Remove unused code

2012-04-24 Thread Caolán McNamara
On Sun, 2012-04-22 at 20:48 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed. Thanks for this. It bothers me a little that there was a addListener and a removeListener where the addListener is used while removeListener is unused. It

Re: Weird runtime error

2012-04-24 Thread Jean-Baptiste Faure
Hi, Le 23/04/2012 15:12, Tomáš Chvátal a écrit : Hi all, after finally making my tinderbox build and install lo I get this error when I try to launch any of the apps. scarabeus@arcarius: ~ $ lowriter terminate called after throwing an instance of

[PATCH] Removed unused code from editeng

2012-04-24 Thread Vicente Vendrell
0001-Removed-unused-code-from-editeng.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Bjoern Michaelsen
On Tue, Apr 24, 2012 at 10:24:33AM +0300, Tor Lillqvist wrote: From a high-level point of view, what is the intent: Provocative reply: Keep backwards compatibility with libreoffice-build/go-oo concepts. They were migrated over from there. - Should a new, naïve contributor be able to run just

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Tomáš Chvátal
2012/4/24 Bjoern Michaelsen bjoern.michael...@canonical.com: In theory yes, in practice you will risk an endless bikeshedding fight over some enable/disable switch defaults. Having these .conf files might help a bit there. To avoid bikeshed here we could do automagic approach. All switches

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Petr Mladek
Stephan Bergmann píše v Út 24. 04. 2012 v 09:00 +0200: On 04/23/2012 06:17 PM, Petr Mladek wrote: I am not sure but I think that strip reduces size of binaries even when you build without -g. It just removes something less important. strip removes the table of internal symbols. The effect

Re: patch dociter.cxx

2012-04-24 Thread Jesús Corrius
Hola, On Mon, Apr 23, 2012 at 7:09 PM, Jose Manuel Recarey Quintans jmreca...@gmail.com wrote: Hi. i send a patch for libreoffice (fich dociter.cxx) thanks Lo que has enviado aquí no es más que el contenido entero del fichero. Debes utilizar el git format-patch para generar el parche.

Re: patch dociter.cxx

2012-04-24 Thread Jesús Corrius
Hi. i send a patch for libreoffice (fich dociter.cxx) thanks Please ignore this patch as it is obviously wrong. -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED][PATCH] Remove unused code (sc)

2012-04-24 Thread Caolán McNamara
On Mon, 2012-04-23 at 19:39 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available

2012-04-24 Thread Petr Mladek
klaus-jürgen weghorn ol píše v So 21. 04. 2012 v 10:49 +0200: Hi Fridrich, *, this mail never reached the l10n@ and projects@ but only the LibO-QA. Is there a problem with the mail-system or something else? It is by purpose. We should probably update the subject to make it more clear. What

Re: Problem with configure checks for gcc options that clang does not support

2012-04-24 Thread Lubos Lunak
On Monday 23 of April 2012, Tor Lillqvist wrote: Unfortunately, at least the Apple Clang doesn't generate any compilation error or *proper* warning for command-line options it doesn't understand, like -fno-enforce-eh-specs. It just prints out clang: warning: argument unused during

Re: Weird runtime error

2012-04-24 Thread Stephan Bergmann
On 04/23/2012 03:35 PM, Jean-Baptiste Faure wrote: I had the same problem during the WE and this morning. Removing profile directory did not solve the issue. This afternoon I updated my copy of the master up to

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Stephan Bergmann wrote: On 04/23/2012 06:17 PM, Petr Mladek wrote: I am not sure but I think that strip reduces size of binaries even when you build without -g. It just removes something less important. strip removes the table of internal symbols. The effect is

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 10:18 +0200, Bjoern Michaelsen wrote: possibly we could also add something like: FedoraDev.conf ... Personally I wouldn't bother. ./autogen.sh should give a generic configuration out of the box while something like a FedoraDev would map to the set of configure options

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 10:31 +0200, Tomáš Chvátal wrote: All switches are by default on enable state and we check for the deps. If the damn deps are not present on the system we switch the feature off. Some packages do this, and it leads to the nightmare situation that you silently get a

Re: How to get text attributes on Writer?

2012-04-24 Thread Cedric Bosdonnat
Hi Rodolfo, On Mon, 2012-04-23 at 15:41 -0300, Rodolfo wrote: Given a certain cursor (or PaM) position on Writer, how can I get the current font height? Or check if two PaM have the same height/style? I can't understand the pool model... Your question forced me to have a look at it more

Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available

2012-04-24 Thread Rainer Bielefeld
Petr Mladek schrieb: It is by purpose. We should probably update the subject to make it more clear. What about the following? [ANN] LibreOffice 3.5.3 RC1 builds available for pre-testing Hi, I believe that's a good Idea, subject for these first announcements should be amended as

Re: [PATCH] fdo#39643: Remove --disable-strip-solver configure option

2012-04-24 Thread d . ostrovsky
Zitat von Lubos Lunak l.lu...@suse.cz: On Tuesday 24 of April 2012, Stephan Bergmann wrote: On 04/23/2012 06:17 PM, Petr Mladek wrote: I am not sure but I think that strip reduces size of binaries even when you build without -g. It just removes something less important. strip removes the

Re: [Libreoffice-commits] .: 26 commits - avmedia/source basctl/source basic/source configure.in connectivity/source cppu/inc dbaccess/source distro-configs/LibreOfficeMacOSX.conf distro-configs/Libre

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Tor Lillqvist wrote: Hardcode cairo canvas off for Mac OS X and Windows Do not depend on a distro-configs file to disable it. It is supposed to be optional to pass a --with-distro option. Running a bare ./autogen.sh is supposed to produce a

Re: [Libreoffice-commits] .: 26 commits - avmedia/source basctl/source basic/source configure.in connectivity/source cppu/inc dbaccess/source distro-configs/LibreOfficeMacOSX.conf distro-configs/Libre

2012-04-24 Thread Tor Lillqvist
 Why is AC_MSG_ERROR not here? Yeah, AC_MSG_ERROR is probably better. Will change. (The code does not compile if you try to use the cairo canvas on Windows or Mac; in canvas/source/cairo/cairo_services.cxx there is an explicit #error The cairo canvas should not be enabled on Windows or Mac cf

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Caolán McNamara wrote: On Tue, 2012-04-24 at 10:31 +0200, Tomáš Chvátal wrote: All switches are by default on enable state and we check for the deps. If the damn deps are not present on the system we switch the feature off. Some packages do this, Isn't that

Re: Help about Calc Functions

2012-04-24 Thread Michael Meeks
Hi Italo, On Mon, 2012-04-23 at 19:13 +0200, Italo Vignoli wrote: No, I do not want to write documentation, I am trying to figure out how to hack the help to improve it, because most users still refer to the help when they do not know how to do something. :-) I have already started

Re: Help about Calc Functions

2012-04-24 Thread Andras Timar
2012/4/24 Michael Meeks michael.me...@suse.com:        Of course, large changes to the help such as re-ordering may hurt translators - but no idea. Re-ordering is not necessarily a problem, but English alphabetical order is. Function names are localizable, and localized names need a different

Re: [Libreoffice][GSoC2012] Enhancing Impress svg export filter

2012-04-24 Thread Thorsten Behrens
Marco Cecchetti wrote: my GSoC proposal has been accepted! Hi Marco, welcome back as a GSoC student - really happy to see you continuing last year's excellent work! :) About this last point I'd like to know if there is interest in performing test on IE 10 that at present is supported only by

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jean-Baptiste Faure jbf.fa...@orange.fr changed: What|Removed |Added Depends on||38176 ---

[REVIEW-3-5 3-5-3] default to Office 2007/2010 filters for export to ooxml

2012-04-24 Thread Markus Mohrhard
Hey, [1] changes the order of our export filters so that by default the Office 2007/2010 export filters will be used for xlsx, docx and pptx export. Office 2007 can't deal with standard conform ooxml documents so we should not default to them when exporting. This is a regression in 3-5 related to

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Tor Lillqvist
I wonder, by the way, if we really need to have all the configurability we currently have... To keep bringing up the cairo canvas as an example: if it works, why wouldn't it be enabled all the time on Unix? --tml ___ LibreOffice mailing list

Re: Problem with configure checks for gcc options that clang does not support

2012-04-24 Thread Tor Lillqvist
 That does not quite work, e.g. the message can be translated. Ah.  But the bug seems to exists only with Clang 3.1, The current Apple Clang is 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn). --tml ___ LibreOffice mailing list

Re: Problem with configure checks for gcc options that clang does not support

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Tor Lillqvist wrote:  That does not quite work, e.g. the message can be translated. Ah.  But the bug seems to exists only with Clang 3.1, The current Apple Clang is 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn). The fix is dated Tue Mar 13

Re: [PUSHED][PATCH] Removed unused code from editeng

2012-04-24 Thread Caolán McNamara
Looks good, pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Problem with configure checks for gcc options that clang does not support

2012-04-24 Thread Michael Stahl
On 24/04/12 12:26, Lubos Lunak wrote: On Tuesday 24 of April 2012, Tor Lillqvist wrote: But the bug seems to exists only with Clang 3.1, The current Apple Clang is 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn). The fix is dated Tue Mar 13 20:09:56 2012 +. that doesn't

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 38176, which changed state. Bug 38176 Summary: FILESAVE as RTF adds normal space after each non-breaking space https://bugs.freedesktop.org/show_bug.cgi?id=38176 What|Old Value |New

[REVIEW 3-5] idle-callbacks in writer don't end early, so your responsiveness sucks rocks

2012-04-24 Thread Caolán McNamara
This one has nearly killed me trying to track down because its *so* variable, but unusably slow with large documents https://bugs.freedesktop.org/show_bug.cgi?id=48011 I believe is fixed by http://cgit.freedesktop.org/libreoffice/core/commit/?id=658954e8b50fc264428402dc5a95b0d6f690d191 or at

Base: Slow search in form

2012-04-24 Thread Egon
Hello everybody We have installed libreoffice 3.5.2 in an ubuntu 10.10 with java 1.6.30 environment. We are in a production model with about 200 users. We have seen that if you do a search over a form in base, the speed of the search in the form goes very slow in the second search once you

[PUSHED][3-5] Re: [REVIEW-3-5 3-5-3] default to Office 2007/2010 filters for export to ooxml

2012-04-24 Thread Michael Stahl
On 24/04/12 12:14, Markus Mohrhard wrote: Hey, [1] changes the order of our export filters so that by default the Office 2007/2010 export filters will be used for xlsx, docx and pptx export. Office 2007 can't deal with standard conform ooxml documents so we should not default to them when

Re: [Libreoffice] Mac OSX daily build 26/10/2011 - Base Report Builder, Beanshell, and Javascript extensions disabled

2012-04-24 Thread Kálmán „KAMI” Szalai
Hi Stephan, On 04/23/2012 05:13 PM, Stephan Bergmann wrote: On 04/08/2012 11:38 AM, Kálmán „KAMI” Szalai wrote: Finally I get managed to release a new bugfix/feature version. Now it is working under LibO 3.4 and 3.5. Can you test it then cherry-pick it to 3.4 and3.5 branches? Version 1.3.5

Re: [PUSHED][3-5] Re: [REVIEW-3-5 3-5-3] default to Office 2007/2010 filters for export to ooxml

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Michael Stahl wrote: On 24/04/12 12:14, Markus Mohrhard wrote: Hey, [1] changes the order of our export filters so that by default the Office 2007/2010 export filters will be used for xlsx, docx and pptx export. Office 2007 can't deal with standard conform

Re: [PUSHED][3-5] Re: [REVIEW-3-5 3-5-3] default to Office 2007/2010 filters for export to ooxml

2012-04-24 Thread Petr Mladek
Lubos Lunak píše v Út 24. 04. 2012 v 14:04 +0200: On Tuesday 24 of April 2012, Michael Stahl wrote: The patch should be safe and will only change the position in the dialog and the order for the TypeDetection during export. [1]

Re: [PUSHED:3-5,3-5-3] default to Office 2007/2010 filters for export to ooxml

2012-04-24 Thread Petr Mladek
Petr Mladek píše v Út 24. 04. 2012 v 14:17 +0200: Lubos Lunak píše v Út 24. 04. 2012 v 14:04 +0200: On Tuesday 24 of April 2012, Michael Stahl wrote: The patch should be safe and will only change the position in the dialog and the order for the TypeDetection during export. [1]

Re: [PUSHED: 3-5, 3-5-3] fdo#47717, fdo#45562 sw: yet more border painting regressions

2012-04-24 Thread Petr Mladek
Caolán McNamara píše v Pá 20. 04. 2012 v 14:28 +0100: On Fri, 2012-04-20 at 14:42 +0200, Michael Stahl wrote: On 20/04/12 14:21, Caolán McNamara wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5913506b2193e93ca2767ab7365ab2e76ed7848f ah yes, it requires the patch from the

Re: [GSoC] Introducing myself

2012-04-24 Thread Michael Meeks
On Tue, 2012-04-24 at 02:45 -0700, Brennan Vincent wrote: I look forward to being a part of the LibreOffice team! :) Welcome ! :-) really great to have you funded for the summer, looking forward to a world of publishing goodness :-) All the best, Michael. --

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Bjoern Michaelsen
On Tue, Apr 24, 2012 at 09:57:37AM +0100, Caolán McNamara wrote: Some packages do this, and it leads to the nightmare situation that you silently get a different result depending on what packages you happen to install. Agree, that indeed is a nightmare. What could still work is: ./autogen.sh

Re: [PUSHED][3-5] Re: [REVIEW-3-5 3-5-3] default to Office 2007/2010 filters for export to ooxml

2012-04-24 Thread Miklos Vajna
On Tue, Apr 24, 2012 at 01:38:09PM +0200, Michael Stahl mst...@redhat.com wrote: so Office 2007 and Open XML actually do different things? i have always wondered why the heck we have 2 of these but forgot to ask... Not two separate filters, it only makes GetExport().GetFilter().getVersion()

italic display of regular fonts in menu

2012-04-24 Thread Steve White
Hi! Can anybody tell me why the names of a few font families, which have regular, italic, bold, and oblique styles, appears in the Writer's font list in italics? The affected fonts include Century Schoolbook L, TLWGMono, URW Palladio L LibreOffice 3.4.4 OOO340m1 (Build:402) Ubuntu 11.10

[REVIEW:3-5] fdo#48023 fix RTF import of Russian characters without an encoding specified

2012-04-24 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=f8bda24 Regression from 3.4; backported patch attached. (Requesting -3-5 only, not critical enough to mess ith -3-5-3.) Thanks, Miklos From 3951b63724f5a965903de522361926d190e9bcf8 Mon Sep 17 00:00:00 2001 From: Miklos Vajna

Re: Proposal: move pre-onegit repos into libreoffice-obsolete as 3.4 is EOL

2012-04-24 Thread Thorsten Behrens
Bjoern Michaelsen wrote: just a short note (maybe to be discussed in the ESC call): http://cgit.freedesktop.org/libreoffice/ is overloaded with obsolete repositories, making it hard for a curious newcomer to find his way around and be dragged in. Hi Björn, is that really so much of a

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Thorsten Behrens
Tor Lillqvist wrote: I wonder, by the way, if we really need to have all the configurability we currently have... As generic as the question is: probably not. To keep bringing up the cairo canvas as an example: if it works, why wouldn't it be enabled all the time on Unix? Why not? The work

[Libreoffice][GSoC2012] Introduction

2012-04-24 Thread Iain Billett
Hi everyone, My GSoC proposal has been accepted and I'm excited to be working on LibreOffice this summer. I'll be working with Tor Lillqvist, and others I'm sure, on LibreOffice for Android. To introduce myself, I'm a final year computer engineering student at Trinity College Dublin. Next year I

Re: [Libreoffice-commits] .: extension libs should have no RPATH

2012-04-24 Thread David Tardon
On Fri, Apr 20, 2012 at 09:53:22AM +0200, Stephan Bergmann wrote: On Mac OS X, LINKFLAGSRUNPATH_xxx is a misnomer. It does not specify any RPATH, but rather a special install name token (those @___...___xxx) that is in turn used by solenv/bin/macosx-changes-install-names.pl to determine how

Re: [REVIEW:3-5] fdo#48023 fix RTF import of Russian characters without an encoding specified

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 14:49 +0200, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=f8bda24 Can you merge that with (the equally horrible equivalent and partial hack) in ww8par.cxx (search for LANGUAGE_RUSSIAN) and put it someplace shared ? C.

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 11:49 +0200, Lubos Lunak wrote: On Tuesday 24 of April 2012, Caolán McNamara wrote: On Tue, 2012-04-24 at 10:31 +0200, Tomáš Chvátal wrote: All switches are by default on enable state and we check for the deps. If the damn deps are not present on the system we switch

Re: Base: Slow search in form

2012-04-24 Thread drew
On Tue, 2012-04-24 at 13:51 +0100, Mark Stanton wrote: We have seen that if you do a search over a form in base, the speed of the search in the form goes very slow in the second search once you have reached the last register of the table. We have a Base with HSQL. Hi Egon,

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-24 Thread Caolán McNamara
On Wed, 2012-04-18 at 18:15 +0200, Lubos Lunak wrote: On Wednesday 18 of April 2012, Caolán McNamara wrote: We moved to using the compiler stl on windows as well. The compiler provided list header on msvc 2008 itself triggers a warning, which is a real pain for WaE. What warning would

patch for libreoffice (fich dociter.cxx)

2012-04-24 Thread Jose Manuel Recarey Quintans
Hi. i send a patch for libreoffice (fich dociter.cxx) thanks From f06ff5d955df6ea445490cf502b3720c2d361991 Mon Sep 17 00:00:00 2001 From: Jose Manuel jmreca...@gmail.com Date: Tue, 24 Apr 2012 16:50:30 +0200 Subject: [PATCH] dociter.cxx --- core/sc/source/core/data/dociter.cxx |5 - 1

Re: Proposal: move pre-onegit repos into libreoffice-obsolete as 3.4 is EOL

2012-04-24 Thread Bjoern Michaelsen
On Tue, Apr 24, 2012 at 03:19:51PM +0200, Thorsten Behrens wrote: Bjoern Michaelsen wrote: just a short note (maybe to be discussed in the ESC call): http://cgit.freedesktop.org/libreoffice/ is overloaded with obsolete repositories, making it hard for a curious newcomer to find

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Bjoern Michaelsen
On Tue, Apr 24, 2012 at 03:45:38PM +0200, Thorsten Behrens wrote: Tor Lillqvist wrote: I wonder, by the way, if we really need to have all the configurability we currently have... As generic as the question is: probably not. As someone who does releases on a fixed schedule, I find quite a

[ANNOUNCE] libreoffice-3.5.3.2 tag created (3.5.3-rc2)

2012-04-24 Thread Petr Mladek
Hi, there have been created the libreoffice-3.5.3.2 tag for 3.5.3-rc2 release. The corresponding official builds will be available within next few days. It will be used as final if no blocker is found. See the attached list of changes against 3.5.3-rc1. Now, you might switch your current 3-5

Re: [PUSHED][PATCH] Remove unused method UnoControlBase::UnoControlBase()

2012-04-24 Thread Caolán McNamara
On Sun, 2012-04-22 at 18:29 +0200, Xavi Escriche Galindo wrote: Basically ok, pushed. You missed to remove it from the header as well. Though this turns out to be one of the tricky edge cases and not so easy after all :-). All fixed up and pushed. Can you confirm this is under our preferred

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Caolán McNamara wrote: On Tue, 2012-04-24 at 11:49 +0200, Lubos Lunak wrote: Right now all those 100 developers have to have a long list of options, half of them because they are needed, other half because they'd prefer not to build repeatedly stuff they already

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-24 Thread Lubos Lunak
On Tuesday 24 of April 2012, Caolán McNamara wrote: On Wed, 2012-04-18 at 18:15 +0200, Lubos Lunak wrote: On Wednesday 18 of April 2012, Caolán McNamara wrote: We moved to using the compiler stl on windows as well. The compiler provided list header on msvc 2008 itself triggers a warning,

Re: [REVIEW:3-5] fdo#48023 fix RTF import of Russian characters without an encoding specified

2012-04-24 Thread Miklos Vajna
On Tue, Apr 24, 2012 at 02:15:53PM +0100, Caolán McNamara caol...@redhat.com wrote: Can you merge that with (the equally horrible equivalent and partial hack) in ww8par.cxx (search for LANGUAGE_RUSSIAN) and put it someplace shared ? Sure - does the attached patch looks sane? It definitely

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Enrico Weigelt
Running ./autogen.sh --with-system-libs fails as soon as it finds one external library that does not exist system-wide (and there's pretty much bound to be one, given what all kinds of libs we use). build as an user which does not have additional (local) libraries installed ? So one has to

Re: Your GSoC project - first step

2012-04-24 Thread Markus Mohrhard
Hey Daniel, welcome to this years GSoC. I'm looking forward to work with you on calc. I talked with Markus briefly, and we think that as a starter, we should stay on the xlsx import code and make a few more improvements there before moving on to other areas.  We have already covered the

Re: [PUSHED][REVIEW:3-5] fdo#48023 fix RTF import of Russian characters without an encoding specified

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 17:40 +0200, Miklos Vajna wrote: On Tue, Apr 24, 2012 at 02:15:53PM +0100, Caolán McNamara caol...@redhat.com wrote: Can you merge that with (the equally horrible equivalent and partial hack) in ww8par.cxx (search for LANGUAGE_RUSSIAN) and put it someplace shared ?

[PUSHED 3-5] idle-callbacks in writer don't end early, so your responsiveness sucks rocks

2012-04-24 Thread Michael Meeks
On Tue, 2012-04-24 at 12:27 +0100, Caolán McNamara wrote: This one has nearly killed me trying to track down because its *so* variable, but unusably slow with large documents https://bugs.freedesktop.org/show_bug.cgi?id=48011 First - thanks for nearly laying down your life here ! :-)

Re: [PATCH] convert SV*PTRARR stuff in SW module

2012-04-24 Thread Michael Stahl
On 24/04/12 08:56, Noel Grandin wrote: Hi This series of patches converts various datastructures in the SW module from SV*PTRARR to std::vector, std::set, and boost::ptr_set variously. so the first patch, which Caolan already pushed, causes a segfault in dbaccess_complex, because of a

Missing index 0 in SvxShapeCollection::getSupportedServiceNames_Static()?

2012-04-24 Thread Takeshi Abe
Hi all, I found an unusually overwriting assignment at index 1 in SvxShapeCollection::getSupportedServiceNames_Static() as follows: --- diff --git a/svx/source/unodraw/unoshcol.cxx b/svx/source/unodraw/unoshcol.cxx index 1e02c9c..1c45081 100644 --- a/svx/source/unodraw/unoshcol.cxx +++

inline-unused-ctor-needed-by-MSVC-at-compile-time

2012-04-24 Thread José Santiago Jiménez Sarmiento
-- __ José Santiago Jiménez Sarmiento *-- AVISO --* Mensaje confidencial. Queda terminantemente prohibido la publicación de su contenido a terceros sin mi autorización, según obliga la Ley Orgánica de Protección de Datos (LOPD) del 15/1999 y posterior R.D.

Re: [PATCH] convert SV*PTRARR stuff in SW module

2012-04-24 Thread Noel Grandin
On Tue, Apr 24, 2012 at 19:03, Michael Stahl mst...@redhat.com wrote: so the first patch, which Caolan already pushed, causes a segfault in dbaccess_complex, because of a double free in SwXTextView::removeSelectionChangeListener: the boost::ptr_vector::erase() actually deletes the element.

Re: [PUSHED 3-5] idle-callbacks in writer don't end early, so your responsiveness sucks rocks

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 17:58 +0100, Michael Meeks wrote: On Tue, 2012-04-24 at 12:27 +0100, Caolán McNamara wrote: maybe the proposed gtk3 one is sufficient for gtk3, definitely the alternative impl *seems* ok for gtk2 is I enable it locally experimentally. Really ? I recall reading

Re: Weird runtime error

2012-04-24 Thread Stephan Bergmann
On 04/24/2012 10:18 AM, Stephan Bergmann wrote: But there is one more known problem remaining (duplicate implementation name='com.sun.star.comp.Draw.framework.PresenterScreenJob' that Miklos and Arnaud ran into) that I have not yet fixed. The cause for this should now be fixed with

[PATCH] gbuild: do partial build in tail_build for make foo.all

2012-04-24 Thread Bjoern Michaelsen
Hi all, I am looking for comments on: https://gerrit.libreoffice.org/#/c/103/ which I assume will make partial builds in tail_build quite a bit faster. Opinions most welcome. Best, Bjoern ___ LibreOffice mailing list

Re: [Libreoffice-commits] .: Bump extension versions after changing to passive registration

2012-04-24 Thread Stephan Bergmann
Hi all, When doing changes to code that can end up as extensions, esp. bundled ones, it is important to increment the corresponding extension version number. This is not always obvious. Stephan On 04/24/2012 08:23 PM, Stephan Bergmann wrote: commit de562138eabd3ee3ecab28e5d1348a3fee7301e0

[PATCH] Removed unused methods from psp::PrinterGfx

2012-04-24 Thread Christina Roßmanith
Hi, an easyhack, to get a feeling of success while trying to understand import of SVGs. Christina From 5b90ab4c0053c09bbd49f1bf3024d70cfb32af6e Mon Sep 17 00:00:00 2001 From: Chr. Rossmanith chr.rossman...@gmx.de Date: Tue, 24 Apr 2012 20:09:33 +0200 Subject: [PATCH] Removed unused methods

Re: [PATCH] convert SV*PTRARR stuff in SW module

2012-04-24 Thread Stephan Bergmann
On 04/24/2012 07:03 PM, Michael Stahl wrote: it would of course be nice if the f..ine documentation would mention that erase() will delete the element, but i can't find that fact mentioned here: http://www.boost.org/doc/libs/1_49_0/libs/ptr_container/doc/ptr_sequence_adapter.html It kind of

Re: distro-configs files, autogen.sh options, defaults etc

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 17:16 +0200, Lubos Lunak wrote: Running ./autogen.sh --with-system-libs fails as soon as it finds one external library that does not exist system-wide (and there's pretty much bound to be one, given what all kinds of libs we use) Aha, so I suspect this boils down to

Re: unused code

2012-04-24 Thread Caolán McNamara
On Tue, 2012-04-24 at 19:03 +0100, José Santiago Jiménez Sarmiento What bothers me about the unused GetNextVisPortion in editeng is that GetPrevVisPortion is not unused, and in EditView::SetSelection I wonder if the *second* GetPrevVisPortion should have been GetNextVisPortion all along.

Re: support for repeating format code in calc

2012-04-24 Thread Eike Rathke
Hi Noel, Sorry, this took too long.. On Wednesday, 2012-04-18 21:01:41 +0100, Noel Power wrote: I've been looking at providing support for the repeating character in number formats. I've been playing abit with the code and what I have sofar seems to work reasonably well ( no doubt there are

Re: [PATCH] gbuild: do partial build in tail_build for make foo.all

2012-04-24 Thread Noel Grandin
You mean other than Nice work! :-) On Tue, Apr 24, 2012 at 20:32, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Hi all, I am looking for comments on:  https://gerrit.libreoffice.org/#/c/103/ which I assume will make partial builds in tail_build quite a bit faster. Opinions most

[PATCH] fdo#31005: Table Autoformats does not save/apply all properties

2012-04-24 Thread Muhammad Haggag
Hello. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=31005 Patch: = https://bugs.freedesktop.org/attachment.cgi?id=60462 Patch review: === https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=31005attachment=60462 Summary: = Extended the number of properties

Re: unused code

2012-04-24 Thread Kohei Yoshida
Hi Caolan, On Tue, Apr 24, 2012 at 3:22 PM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2012-04-24 at 19:03 +0100, José Santiago Jiménez Sarmiento What bothers me about the unused GetNextVisPortion in editeng is that GetPrevVisPortion is not unused, and in EditView::SetSelection I

Re: [Libreoffice][GSoC2012] Enhancing Impress svg export filter

2012-04-24 Thread Marco Cecchetti
On Tue, 24 Apr 2012 12:05:39 +0200, Thorsten Behrens t...@documentfoundation.org wrote: Marco Cecchetti wrote: About this last point I'd like to know if there is interest in performing test on IE 10 that at present is supported only by Windows 8. If you have the means to do so - greatly

PATCH: made available under the MPL/LPGLv3+

2012-04-24 Thread Javier Silva
Hi: I send you a patch in order to erase the unused code: formula::FormulaTokenArray::AddBad(unsigned short const*). Best Regards Javier patch_token Description: Binary data patch_token2 Description: Binary data patch_token3 Description: Binary data

Re: [Libreoffice][GSoC2012] Enhancing Impress svg export filter

2012-04-24 Thread Thorsten Behrens
Marco Cecchetti wrote: Btw, what is LibreOffice policy for rebasing a feature branch ? I'd defer to Kendy here. :) Cheers, -- Thorsten pgp3Yvr3oKGDe.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Need help: SVG import

2012-04-24 Thread Noel Grandin
Most of the code looks to be in svgreader.cxx. It walks the DOM tree, starting with the writeShapes method, and it looks like it processes text nodes at around line 1471. On Tue, Apr 24, 2012 at 22:15, Christina Roßmanith chrrossman...@gmx.de wrote: Hi, I'm still trying to understand how SVG

Re: [PUSHED] Some fixes for Clang warnings

2012-04-24 Thread Catalin Iacob
On Mon, Apr 23, 2012 at 2:39 PM, Stephan Bergmann sberg...@redhat.com wrote: Only 0002-WaE-Clang-unused-variable.patch and 0003-WaE-Clang-unused-variable.patch I did not push.  Can you change them as I suggested above (or just let me know if you want me to do that)? I attached updated patches

[PATCH] Remove unused code (ImpSvtData)

2012-04-24 Thread Javier Catala
Hi everyone, this patch removes the unused destructor in the ImpSvtData class, as listed in unusedcode.easy From bdfc550685d238a62602a4f93da0ab804d77b2f6 Mon Sep 17 00:00:00 2001 From: Javier Catala j_cat...@yahoo.com Date: Tue, 24 Apr 2012 20:24:17 +0200 Subject: [PATCH] Remove unused

0001-Delete-unused-code-CertificateExtension_XmlSecImpl-s.patch

2012-04-24 Thread José Santiago Jiménez Sarmiento
Hello! I am begginer in software libre colaboration. I hope I can enter fully into this world and in the future be a good collaborator. Thanks. -- __ José Santiago Jiménez Sarmiento *-- AVISO --* Mensaje confidencial. Queda terminantemente prohibido la

Delete-unused-code-ImpSvtData-ImpSvtData

2012-04-24 Thread José Santiago Jiménez Sarmiento
-- __ José Santiago Jiménez Sarmiento *-- AVISO --* Mensaje confidencial. Queda terminantemente prohibido la publicación de su contenido a terceros sin mi autorización, según obliga la Ley Orgánica de Protección de Datos (LOPD) del 15/1999 y posterior R.D.

Delete-unused-code-TypeDescriptor_Init_Impl.patch

2012-04-24 Thread José Santiago Jiménez Sarmiento
-- __ José Santiago Jiménez Sarmiento *-- AVISO --* Mensaje confidencial. Queda terminantemente prohibido la publicación de su contenido a terceros sin mi autorización, según obliga la Ley Orgánica de Protección de Datos (LOPD) del 15/1999 y posterior R.D.

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 4, which changed state. Bug 4 Summary: Print to File creates faulty pdf https://bugs.freedesktop.org/show_bug.cgi?id=4 What|Old Value |New Value

[PATCH] EasyHack #32621 - More robust ExternalMailer support

2012-04-24 Thread Dave Steele
Proposed patch attached to use the gnome-open/xdg-open URI handler, with a mailto link, when the currently configured mailer is not recognized. 0001-Fall-back-to-using-the-GNOME-mailto-URI-handler-if-n.patch Description: Binary data ___ LibreOffice

[Libreoffice-commits] .: 2 commits - clucene/Module_clucene.mk config_host.mk.in configure.in Makefile smoketest/CppunitTest_smoketest.mk solenv/bin solenv/gbuild solenv/inc

2012-04-24 Thread Lubos Lunak
Makefile | 11 ++- clucene/Module_clucene.mk |4 config_host.mk.in |1 + configure.in |5 + smoketest/CppunitTest_smoketest.mk |4 ++-- solenv/bin/install-gdb-printers|2 +-

[Libreoffice-commits] .: sc/inc sc/source unusedcode.easy

2012-04-24 Thread Caolán McNamara
sc/inc/dpitemdata.hxx |2 -- sc/source/core/data/dpitemdata.cxx |9 - unusedcode.easy|2 -- 3 files changed, 13 deletions(-) New commits: commit 858646a5eb5eae8703cfb64cd1cdbc553699a224 Author: Santiago Martinez smvar...@gmail.com Date: Mon

  1   2   3   >