date:20160623

Re: Collabora Online 1.0 Roadmap and Questions

2016-06-23 Thread Andrew McGlashan

Hi Michael,

On 23/06/2016 3:13 AM, Michael Meeks wrote:
> On Wed, 2016-06-22 at 11:38 -0400, Adam Saunders wrote:
>> I'm in the midst of writing a news article about the Collabora Online
>> 1.0 release. I had a couple questions for you:
> 
>   Let me get to those privately - some of the answers don't really belong
> on this list.

WHY?  Please share to the list too.

Thanks
A.



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/svx svx/AllLangResTarget_svx.mk svx/Library_svxcore.mk svx/source sw/sdi sw/source sw/uiconfig

2016-06-23 Thread Susobhan Ghosh

 include/svx/SvxNumOptionsTabPageHelper.hxx   |   52 ++
 include/svx/dialogs.hrc  |3 
 include/svx/pagenumberlistbox.hxx|   36 +
 svx/AllLangResTarget_svx.mk  |1 
 svx/Library_svxcore.mk   |2 
 svx/source/dialog/SvxNumOptionsTabPageHelper.cxx |   91 
 svx/source/dialog/pagenumbering.src  |   31 +
 svx/source/dialog/pagenumberlistbox.cxx  |   69 +++
 sw/sdi/_viewsh.sdi   |   25 +
 sw/source/uibase/sidebar/PageStylesPanel.cxx |  504 ++-
 sw/source/uibase/sidebar/PageStylesPanel.hxx |   57 ++
 sw/source/uibase/sidebar/SwPanelFactory.cxx  |2 
 sw/source/uibase/uiview/viewtab.cxx  |  124 +
 sw/uiconfig/swriter/ui/pagestylespanel.ui|  153 ++
 14 files changed, 1119 insertions(+), 31 deletions(-)

New commits:
commit 3881fffe4233ce3aa02051b205c114c1cb520d67
Author: Susobhan Ghosh 
Date:   Tue Jun 7 19:20:22 2016 +0530

tdf#83830: Page Styles Panel

Added new helper class to svx for numbering

Change-Id: Ie7db4059568024e9bed460fcf7c9215bd2ef788f
Reviewed-on: https://gerrit.libreoffice.org/26020
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 

diff --git a/include/svx/SvxNumOptionsTabPageHelper.hxx 
b/include/svx/SvxNumOptionsTabPageHelper.hxx
new file mode 100644
index 000..89fd68d
--- /dev/null
+++ b/include/svx/SvxNumOptionsTabPageHelper.hxx
@@ -0,0 +1,52 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#ifndef INCLUDED_SVX_SVXNUMOPTIONSTABPAGEHELPER_HXX
+#define INCLUDED_SVX_SVXNUMOPTIONSTABPAGEHELPER_HXX
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+using namespace css::uno;
+using namespace css::text;
+
+class SVX_DLLPUBLIC SvxNumOptionsTabPageHelper
+{
+public:
+static Reference GetNumberingProvider();
+
+/** Get the numberings provided by the i18n framework (CTL, Asian, ...) and
+add them to the listbox. Extended numbering schemes present in the
+resource and already in the listbox but not offered by the i18n
+framework per configuration are removed.
+
+@param nDoNotRemove
+A value that shall not be removed, i.e. the ugly 0x88
+(SVX_NUM_BITMAP|0x80)
+Pass ::std::numeric_limits::max() if there is no such
+restriction.
+*/
+static void GetI18nNumbering( ListBox& rFmtLB, sal_uInt16 nDoNotRemove );
+};
+
+#endif
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svx/dialogs.hrc b/include/svx/dialogs.hrc
index 45ac305..c2af3bc 100644
--- a/include/svx/dialogs.hrc
+++ b/include/svx/dialogs.hrc
@@ -1075,9 +1075,10 @@
 #define RID_SVXIMG_WIDTH_CUSTOM_GRAY (RID_SVX_START + 1394)
 #define RID_SVXSTRARY_PAPERSIZE_STD  (RID_SVX_START + 1395)
 #define RID_SVXSTRARY_PAPERSIZE_DRAW (RID_SVX_START + 1396)
+#define RID_SVXSTRARY_PAGE_NUMBERING (RID_SVX_START + 1397)
 
 // !!! IMPORTANT: consider and update RID_SVXSTR_NEXTFREE when introducing new 
RIDs for Strings !!!
-#define RID_SVXSTR_NEXTFREE  (RID_SVX_START + 1397)
+#define RID_SVXSTR_NEXTFREE  (RID_SVX_START + 1398)
 
 // if we have _a_lot_ time, we should group the resource ids by type, instead
 // of grouping them by semantics. The reason is that resource ids have to be
diff --git a/include/svx/pagenumberlistbox.hxx 
b/include/svx/pagenumberlistbox.hxx
new file mode 100644
index 000..872a3f2
--- /dev/null
+++ b/include/svx/pagenumberlistbox.hxx
@@ -0,0 +1,36 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software

[Libreoffice-ux-advise] [Bug 94551] All-in-one Area tab for modifying object fill

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94551

--- Comment #10 from Yousuf (Jay) Philips  ---
I choose option 3 and we can represent it similar to the 'Recent' section in
the color drop down widget and title it 'Custom Colors' or something like that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: compilerplugins/clang

2016-06-23 Thread Noel Grandin

 compilerplugins/clang/singlevalfields.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 2fe32490f097ac107603ba5b1fa15599d720b8f6
Author: Noel Grandin 
Date:   Thu Jun 23 15:13:58 2016 +0200

loplugin singlevalfields, need to check default constructor code too

Change-Id: Idcc8de6f1d403a57c59e84774bd7a97e2f3fc224

diff --git a/compilerplugins/clang/singlevalfields.cxx 
b/compilerplugins/clang/singlevalfields.cxx
index 1a511ab..6d94ef7 100644
--- a/compilerplugins/clang/singlevalfields.cxx
+++ b/compilerplugins/clang/singlevalfields.cxx
@@ -90,6 +90,8 @@ public:
 }
 
 bool shouldVisitTemplateInstantiations () const { return true; }
+// to catch compiler-generated constructors
+bool shouldVisitImplicitCode() const { return true; }
 
 bool VisitFieldDecl( const FieldDecl* );
 bool VisitMemberExpr( const MemberExpr* );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 91483] Writer freezes when removing sections with subsection and sub-subsection

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91483

--- Comment #9 from Andrey Skvortsov  ---
The issue still present in LO 5.1.4 (Linux amd64). 
I uploaded a simple almost empty document to test the issue. Only 2.5 pages of
sections (~60 sections) and no text at all. The document is not complex.

The issue appears only if top section with more than one levels of subsections
is removed and if there are some (>50) sections after removed section. And time
seems to growth exponentially with number of sections after.

Steps to reproduces the issue:
1. Open minimized document to test the issue
2. open dialog Format->Sections
3. remove last top section (Section54). 
   deleting doesn't take any time. There is no issue here.
4. remove first top section (Section1)
   deleting takes on my machine 26 seconds.

If you add/delete sections after first top section delete time will
increase/decrease.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

2016-06-23 Thread Stephan Bergmann

 connectivity/source/drivers/postgresql/pq_tools.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 7de0439fe25d3d2b133253db76df6515bb272389
Author: Stephan Bergmann 
Date:   Thu Jun 23 15:08:26 2016 +0200

loplugin:unusedvariablecheck

Change-Id: Ia9c5ea707990d03dd4042c2e0a791976cc1b5f74

diff --git a/connectivity/source/drivers/postgresql/pq_tools.cxx 
b/connectivity/source/drivers/postgresql/pq_tools.cxx
index 0312dde..2d0bc57e 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.cxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.cxx
@@ -465,7 +465,6 @@ void splitSQL( const OString & sql, OStringVector  )
 
 void splitDoubleQuoteEscapedIdentifiers( const OUString & source, OUString 
*first, OUString *second)
 {
-OStringVector vec;
 int a = source.indexOf("\".\"");
 OString tempstring = OUStringToOString(source , RTL_TEXTENCODING_UTF8);
 if(a > 0)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97391] [META] Tracker bug for OpenCL and "Software Interpreter" issues in Calc

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97391

Tor Lillqvist  changed:

   What|Removed |Added

Summary|[META] Tracker bug for  |[META] Tracker bug for
   |OpenCL issues in Calc   |OpenCL and "Software
   ||Interpreter" issues in Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang

2016-06-23 Thread Stephan Bergmann

 compilerplugins/clang/singlevalfields.cxx |   27 ---
 1 file changed, 27 deletions(-)

New commits:
commit b498cf62624b842b81a26872a14fa62f8fe3a12e
Author: Stephan Bergmann 
Date:   Thu Jun 23 15:03:04 2016 +0200

-Werror=unused-function

Change-Id: Ib579e8896a751383d31c1dbf7e6ebf5c0774a976

diff --git a/compilerplugins/clang/singlevalfields.cxx 
b/compilerplugins/clang/singlevalfields.cxx
index 368b767..1a511ab 100644
--- a/compilerplugins/clang/singlevalfields.cxx
+++ b/compilerplugins/clang/singlevalfields.cxx
@@ -96,7 +96,6 @@ public:
 bool VisitCXXConstructorDecl( const CXXConstructorDecl* );
 private:
 void niceName(const FieldDecl*, MyFieldInfo&);
-std::string fullyQualifiedName(const FunctionDecl*);
 std::string getExprValue(const Expr*);
 bool isInterestingType(const QualType&);
 const FunctionDecl* get_top_FunctionDecl_from_Stmt(const Stmt&);
@@ -112,32 +111,6 @@ void SingleValFields::niceName(const FieldDecl* fieldDecl, 
MyFieldInfo& aInfo)
 aInfo.sourceLocation = std::string(name.substr(strlen(SRCDIR)+1)) + ":" + 
std::to_string(compiler.getSourceManager().getSpellingLineNumber(expansionLoc));
 }
 
-std::string SingleValFields::fullyQualifiedName(const FunctionDecl* 
functionDecl)
-{
-std::string ret = 
compat::getReturnType(*functionDecl).getCanonicalType().getAsString();
-ret += " ";
-if (isa(functionDecl)) {
-const CXXRecordDecl* recordDecl = 
dyn_cast(functionDecl)->getParent();
-ret += recordDecl->getQualifiedNameAsString();
-ret += "::";
-}
-ret += functionDecl->getNameAsString() + "(";
-bool bFirst = true;
-for (const ParmVarDecl *pParmVarDecl : functionDecl->params()) {
-if (bFirst)
-bFirst = false;
-else
-ret += ",";
-ret += pParmVarDecl->getType().getCanonicalType().getAsString();
-}
-ret += ")";
-if (isa(functionDecl) && 
dyn_cast(functionDecl)->isConst()) {
-ret += " const";
-}
-
-return ret;
-}
-
 bool SingleValFields::VisitFieldDecl( const FieldDecl* fieldDecl )
 {
 fieldDecl = fieldDecl->getCanonicalDecl();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99053] Software interpreter: Absolute and relative cell references produce unexpected results when using summation function

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99053

Tor Lillqvist  changed:

   What|Removed |Added

Summary|OPENCL: Absolute and|Software interpreter:
   |relative cell references|Absolute and relative cell
   |produce unexpected results  |references produce
   |when using summation|unexpected results when
   |function|using summation function

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang

2016-06-23 Thread Stephan Bergmann

 compilerplugins/clang/singlevalfields.cxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 20f58e790441bf62bd9e3ed575a1d97f7144e85c
Author: Stephan Bergmann 
Date:   Thu Jun 23 15:02:01 2016 +0200

-Werror=unused-but-set-variable

Change-Id: I0b3586bb3acca4075b26790a8dfe3f97d6921feb

diff --git a/compilerplugins/clang/singlevalfields.cxx 
b/compilerplugins/clang/singlevalfields.cxx
index b1c7cc8..368b767 100644
--- a/compilerplugins/clang/singlevalfields.cxx
+++ b/compilerplugins/clang/singlevalfields.cxx
@@ -278,7 +278,6 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* 
memberExpr )
 if (!functionDecl) {
 break;
 }
-bool bFound = false;
 for (unsigned i = 0; i < callExpr->getNumArgs(); ++i) {
 if (i >= functionDecl->getNumParams()) // can happen in 
template code
 break;
@@ -289,7 +288,6 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* 
memberExpr )
 assignValue = "?";
 bPotentiallyAssignedTo = true;
 }
-bFound = true;
 break;
 }
 }
@@ -299,7 +297,6 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* 
memberExpr )
 {
 const CXXConstructExpr* consExpr = 
dyn_cast(parent);
 const CXXConstructorDecl* consDecl = consExpr->getConstructor();
-bool bFound = false;
 for (unsigned i = 0; i < consExpr->getNumArgs(); ++i) {
 if (i >= consDecl->getNumParams()) // can happen in template 
code
 break;
@@ -310,7 +307,6 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr* 
memberExpr )
 assignValue = "?";
 bPotentiallyAssignedTo = true;
 }
-bFound = true;
 break;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 87643] SIDEBAR: New Shapes Tab and content panels

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87643

--- Comment #18 from Yousuf (Jay) Philips  ---
(In reply to Susobhan Ghosh from comment #17)
> 1. The sidebar layout - talked to bubli and she suggested that accordion
> would take up too much time to code (rest of the summer). So any decision on
> which layout to be finally used would be appreciated.

The file & folder layout similar to the gallery.

> 2. Does this involve adding new native shapes to Draw? (not talking about
> user defined ones)

No new natives shapes.

> 3. As for user adding shapes, does it involve drag & drop or just the Add
> button on the top right?

Drag and drop would be good, its works for the gallery, and would allow users
to create something in LO and easily export it to the shapes deck.

> More question to follow as I progress.

Look forward to them at the design meetings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 91483] Writer freezes when removing sections with subsection and sub-subsection

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91483

--- Comment #8 from Andrey Skvortsov  ---
Created attachment 125857
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125857=edit
minimized document to test the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 95674, which changed state.

Bug 95674 Summary: Slow scrolling and rendering glitch while scrolling when 
OpenGL enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=95674

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95674] Slow scrolling and rendering glitch while scrolling when OpenGL enabled

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95674

Michael Meeks  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #32 from Michael Meeks  ---
Bit of a franken-bug this one =) Tomaz fixed a number of crash on exit issues
in bug#100814, bug#96920 etc. - Tomaz has also done a chunk of work to
accelerate rendering for an increasing number of corner cases.

Re-testing 5.1.4.2 or better a 5.2 build and opening a new & more focused bug
if problems recur would be much appreciated =)

Thanks for filing !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64372] Section Breaks in .DOCX not handled similarly between LibO and Word

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=64372

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0474

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Makefile.in

2016-06-23 Thread Michael Stahl

 Makefile.in |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 496cba2e8b3fdf72812d67602306d1d4700a8d60
Author: Michael Stahl 
Date:   Thu Jun 23 14:34:15 2016 +0200

Makefile: move check-if-root earlier

Somebody who might invoke make as root might also invoke make with -j,
so don't start building in that case.

Change-Id: I0c87aba948cd78a23ad4c49f880700f65684424c

diff --git a/Makefile.in b/Makefile.in
index 23ccc95..6997756 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -50,7 +50,7 @@ $(BUILDDIR)/config_host.mk : $(wildcard \
 
 else # MAKE_RESTARTS
 
-all: check-if-root build
+all: build
 
 check-if-root:
@if test `id -u` = 0; then \
@@ -240,9 +240,9 @@ fetch:
 endif
 
 #
-# Bootstap
+# Bootstrap
 #
-bootstrap: compilerplugins
+bootstrap: check-if-root compilerplugins
 
 #
 # Build
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 83830] SIDEBAR: Proposal for the creation of a page tab

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83830

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|

--- Comment #34 from Yousuf (Jay) Philips  ---
(In reply to V Stuart Foote from comment #33)
> Not at all, requirement for the Sidebar Deck's Page related Content Panels
> are to supplement the settings widgets found for all modules on the Page
> Setup/Style dialog -- and as still reached in the Sidebar from the "More
> options" button being added to each content panel.

It is possible that writer's page deck could also be used in calc (of course
with some minor adjustments), but the content panels dont translate for impress
and draw which doesnt have page styles, headers or footers.

> But, adjusting margins in each module is such a frequent requirement, the
> Sidebar GUI needs to be well reasoned and consistent.  Adding a "None/0.00"
> for the dropdown lists of predefined margins is appropriate--having margins
> of 0.00 show as custom, and only set through the "More options", "Page
> setup" or "Page Style" dialogs of various labelings is not consistent UI.

0.00 margins in impress and draw makes sense as presentation slides arent
printed on regular paper and digital drawing dont need margins. But if
consistency is wanted in the margins drop down menu, then I dont have a problem
for it to be included.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 75387] String results become upcased when using OpenCL interpreter.

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75387

Tor Lillqvist  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #15 from Tor Lillqvist  ---
Can the original problem really be reproduced? (With more than 100 copies of
the rows.) If not, surely this should be resolved, instead of being kept open
without any clear description of what the actual bug is.

The intent has definitely been for quite some time that nothing using strings
should go through OpenCL at all any longer. The OpenCL implementation of string
stuff was indeed fairly broken, one thing indeed being that strings were
uppercased at some stage.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100563] New: DOCUMENT CONVERTER: icon "create new folder" is missing.

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100563

Bug ID: 100563
   Summary: DOCUMENT CONVERTER:  icon "create new folder" is
missing.
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lorenzo.mo...@studiostorti.com

Created attachment 125856
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125856=edit
Screenshot of the problem

Description: in a writer document, open the document converter function, choose
something to go to the next step. Now in the select path you can see that the
"create new folder" icon is missing.

Step:
-Create a new writer document.
-Go to file > Wizard > Document converter.
-In the document converter choose something and click next.
-Open the select path (the button with three dots).
-Check that the icon is missing.


Version: 5.3.0.0.alpha0+
Build ID: 29e91d5eedd2bf20504ce9ada625d33fec19dc9e
CPU Threads: 2; OS Version: Linux 4.1; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-06-16_23:05:06
Locale: it-IT (it_IT.UTF-8)
OS: openSUSE Leap 42.1 (x86_64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99854] Copy contents from cells massively sets capitalized text

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99854

--- Comment #7 from Tor Lillqvist  ---
There is nothing called "OpenCL Software Interpreter". The "Software
Interpreter" is used *instead* of OpenCL in some cases, as far as I understand
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73989] UI: Graphic missing from 'Similarity search' button

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=73989

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #8 from Adolfo Jayme  ---
This report no longer applies to recent versions of LO, where the offending
button has got a proper label, “Similarities”. For the record, it never bore a
graphic, it was just called “...”.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99706] General input/output error when open xlx file

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99706

--- Comment #13 from Tor Lillqvist  ---
Those who can reproduce this, please try what is described in
https://bugs.documentfoundation.org/show_bug.cgi?id=100279#c13 , except that
instead of:

set SAL_LOG=+INFO.vcl.opengl+WARN

do:

set SAL_LOG=+INFO.opencl+INFO.sc.opencl+WARN

before starting soffice.exe, and opening the problematic document.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99626] Crash a LibreOffice when close main window with Wizard dialog

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99626

baffclan  changed:

   What|Removed |Added

Crash report or||["SwModule::GetRedlineMarkP
crash signature||os()+0x4:"]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99310] Data validity cell range dropdown list not working

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99310

--- Comment #24 from Niklas Johansson  ---
(In reply to Caolán McNamara from comment #22)
...
> Is there a remaining problem with keyboard focus or anything like that ?,
> where windows is differing from Linux. If so I'd appreciate a new bug to
> track that

No more focus issue in 5.2 rc1 on Windows. So no new bug needed. 

Thank you for the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96215] LibreOffice hangs/won' t start if some mounted shares are inaccessible

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96215

--- Comment #6 from Saren Tasciyan  ---
Regarding the unmounting shares: I am currently using this as a work around. I
unmount the shares, then LO works fine. Sometimes, I forget to unmount, then LO
hangs again. For that, I need to connect VPN again, let all the IO finish then
unmount.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes25' - 3 commits -

2016-06-23 Thread László Németh

 0 files changed

New commits:
commit 9eebe5dcbcea1e7481c988816ff5cbdb05847082
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Thu Jun 23 13:55:30 2016 +0200

empty commit (repeat)

Change-Id: I538d6acc978219fedbd067caa8150a5c0f7a6e65
commit faecb12969873aea9dcf18b075ba3b8858319f68
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Thu Jun 23 13:55:21 2016 +0200

empty commit (repeat)

Change-Id: Ib551a128ba1e8f03280afb96b172057d3a62df36
commit 7f71a7915bb5f22142f6a203875aab0cdb9fb9cb
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Thu Jun 23 13:53:33 2016 +0200

empty commit (setPosSize without proc. idle, text typing more proc. idle)

Change-Id: I801982b99f80cc6033228b5ab1fb42c902548803
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97630] LibreOffice uses wrong attribute for feature "shrink-to-fit"

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97630

Michael Stahl  changed:

   What|Removed |Added

 CC||mst...@redhat.com,
   ||t...@libreoffice.org
 Whiteboard||odf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96215] LibreOffice hangs/won' t start if some mounted shares are inaccessible

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96215

--- Comment #5 from Florian  ---
sorry, in description of Action two the correct line would be:

Action 2: _Now_ the Action is resulting in unwanted result:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99706] General input/output error when open xlx file

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99706

--- Comment #12 from Tor Lillqvist  ---
(And yeah, can not reproduce... Tried the TDF builds of 5.1.3.2 and 5.1.4.1 in
addition to my local master and 5.1 builds.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96215] LibreOffice hangs/won' t start if some mounted shares are inaccessible

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96215

--- Comment #4 from Florian  ---
I have quite similiar behavior, I hope my description helps:

User Action:

Action 1: This Action is only mentioned to show that normally everything works
fine: Laptop Connected to LAN, Starting up a VPN connection, mounting cifs
Share by shellscript. Opening a LOCAL LO file (e.g. LibreOffice Calc
Spreadsheet). Everything works fine. Closing LO.

Action 2: No the Action is resulting in unwanted result:
Closing down the VPN connection, NOT unmounting the shares. 
Starting LO without any document:

Result: LO hangs. 

Expected Resulted: LO works normally, (of course would be allowed to run in a
timeout when trying to access the mounted but not connected shares).

Workaround:
Unmounting the shares -> LO start up normally. 
Sometimes it also helps to clear the "Recent Files".


My Guess:
LO tries to access the files of "Recent Files" - and this hangs when the share
is not valid any more.

---
Version: 5.1.3.2,  Build ID: 1:5.1.3-0ubuntu1
Ubuntu 16.04 LTS   64bit  english

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - svtools/source

2016-06-23 Thread Caolán McNamara

 svtools/source/misc/ehdl.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 401dfdc7f25cb112face662c3fa8aff7ec9c6ef1
Author: CaolÃ¡n McNamara 
Date:   Thu Jun 23 09:41:40 2016 +0100

VclPtr: svtools error message dialog doesn't dispose

Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2
(cherry picked from commit d531743ca34232aedc0b437a9ff5807dea8d51ed)
Reviewed-on: https://gerrit.libreoffice.org/26588
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/svtools/source/misc/ehdl.cxx b/svtools/source/misc/ehdl.cxx
index c724871..876e992 100644
--- a/svtools/source/misc/ehdl.cxx
+++ b/svtools/source/misc/ehdl.cxx
@@ -137,6 +137,7 @@ static sal_uInt16 aWndFunc(
 SAL_WARN( "svtools.misc", "Unknown MessBox return value" );
 break;
 }
+pBox.disposeAndClear();
 return nRet;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - svtools/source

2016-06-23 Thread Caolán McNamara

 svtools/source/misc/ehdl.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0effc85942dcfc1b2f96a5671e0acc8f05d47db3
Author: CaolÃ¡n McNamara 
Date:   Thu Jun 23 09:41:40 2016 +0100

VclPtr: svtools error message dialog doesn't dispose

Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2
(cherry picked from commit d531743ca34232aedc0b437a9ff5807dea8d51ed)
Reviewed-on: https://gerrit.libreoffice.org/26587
Tested-by: Jenkins 
Reviewed-by: David Tardon 

diff --git a/svtools/source/misc/ehdl.cxx b/svtools/source/misc/ehdl.cxx
index 4579966..6f0864d 100644
--- a/svtools/source/misc/ehdl.cxx
+++ b/svtools/source/misc/ehdl.cxx
@@ -137,6 +137,7 @@ static sal_uInt16 aWndFunc(
 SAL_WARN( "svtools.misc", "Unknown MessBox return value" );
 break;
 }
+pBox.disposeAndClear();
 return nRet;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99933] add a function to save the current document with an increasing number in the document name.

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99933

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||samuel.mehrbr...@cib.de
 Resolution|--- |WONTFIX

--- Comment #3 from Samuel Mehrbrodt (CIB)  ---
I agree with Buovjaga that this should not be a core feature as it is fitted
for one very special use case.
You really can accomplish that with a few lines of basic in a macro. That's why
we have macros.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

--- Comment #14 from Michael Stahl  ---
with the fix from comment #12 we don't get an infinite loop any more and
temporary files are cleaned up when exceptions are thrown,
but the error handling is still suboptimal, the SaveAs pops up
a "General I/O error" dialog which is good but then proceeds to write
the corrupted file anyway, which it probably should not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

--- Comment #13 from Buovjaga  ---
dz: a corruption issue, bug 94212, was also fixed.
Could you please test with a fresh master build, after this buildbox comes up
with one (the date should be newer than June 23 to include the crash fix):
http://dev-builds.libreoffice.org/daily/master/MacOSX-x86_64@49-TDF/current/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100549] Reorganizing “Borders” menu on “Formatting Toolbar” in Calc

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100549

--- Comment #5 from hakan  ---
(Excuse me, I forgot English translations)
Or it may be as Image-3 wherein. This menu is somehow need to be improved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100549] Reorganizing “Borders” menu on “Formatting Toolbar” in Calc

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100549

--- Comment #5 from hakan  ---
(Excuse me, I forgot English translations)
Or it may be as Image-3 wherein. This menu is somehow need to be improved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100549] Reorganizing “Borders” menu on “Formatting Toolbar” in Calc

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100549

--- Comment #4 from hakan  ---
Created attachment 125855
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125855=edit
Image-3

Ya da Image-3'deki gibi olabilir. Bu menünün bir şekilde iyileştirilmesi lazım.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100549] Reorganizing “Borders” menu on “Formatting Toolbar” in Calc

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100549

--- Comment #4 from hakan  ---
Created attachment 125855
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125855=edit
Image-3

Ya da Image-3'deki gibi olabilir. Bu menünün bir şekilde iyileştirilmesi lazım.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99706] General input/output error when open xlx file

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99706

Tor Lillqvist  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #11 from Tor Lillqvist  ---
Please check if it can be reproduced in 5.1.4.1. If not, it probably was fixed
by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3d8391ee12d235e103f9ec1fbf455999c373703a
(the cherry-pick to the 5.1 branch of the commit mentioned by Tomaz in
https://bugs.documentfoundation.org/show_bug.cgi?id=100104#c12 ) On the other
hand, I think the problem that was fixed by that would have caused a crash, not
just a "General Error".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100458] Data loss on loading Calc document with hidden 0

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100458

--- Comment #7 from Jan-Marek Glogowski  ---
So my latest Gerrit patch @ https://gerrit.libreoffice.org/#/c/26435/ simply
removes this line. At the end I still don't know the expected behaviour.

Commit 61c39eae570d6d6040b65bfe93127b30e6080cc8 introduced the overwriting cell
type as a workaround.

// If a matrix formula has a matrix reference cell that is intended to have
// a blank text result, the matrix reference cell is actually saved(export)
// as a float cell with 0 as the value and empty .

This is the same in my document AKA 
 
   ... annotation
   
  

And strangely this overwriting was just done exactly for this case, with the
quoted comment in front of the code:

+if( rStr.isEmpty() )
+{
+rnCellType = util::NumberFormat::TEXT;

The current code expands the overwriting to a broader range of cases
(sc/source/filter/xml/xmlcelli.cxx:1511), and this might also be wrong.
Actually my document works correctly _without_ any special handling of cell
number type, just by resetting the text, and breaks _with_ the overwrite.

// Import works around this by setting these cells as text cells so that
// the blank text is used for display instead of the number 0.

This reads as we already fix the import problem with a workaround, and if the
comment is correct, it's not needed any more, which is proved by my error case.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100562] New: DB() function, period and lifetime parameter

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100562

Bug ID: 100562
   Summary: DB() function, period and lifetime parameter
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: r...@post.cz

ODF specification:  6.12.13 DB
Summary: Compute the depreciation allowance of an asset.
Syntax: DB( Number cost ; Number salvage ; Integer lifeTime ; Number period [ ;
Number month = 12 ] )
Returns: Currency
Constraints: cost > 0, salvage >= 0, lifetime >0; period > 0; 0 < month < 13

=DB(25000;1000;0;1;6)
=DB(25000;1000;36;0;6)
=DB(25000;1000;36;-1;6)

period parameter specified as "period > 0". Lifetime as "lifetime> 0". These
formulas should throws error.

Checked in excel and excel return error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang

2016-06-23 Thread Noel Grandin

 compilerplugins/clang/constantparam.cxx   |3 
 compilerplugins/clang/singlevalfields.cxx |  411 ++
 compilerplugins/clang/singlevalfields.py  |   69 +
 3 files changed, 481 insertions(+), 2 deletions(-)

New commits:
commit 8d861bd7028a6ac3cf21ca9758d1f72eef2ac05c
Author: Noel Grandin 
Date:   Thu Jun 23 13:12:53 2016 +0200

new loplugin: singlevalfields

look for fields that only have a single constant value assigned to them

Change-Id: Iafcd37fdb8a8119bbc00f92981a1a01badf9c5a2

diff --git a/compilerplugins/clang/constantparam.cxx 
b/compilerplugins/clang/constantparam.cxx
index 99db545..54fe00c 100644
--- a/compilerplugins/clang/constantparam.cxx
+++ b/compilerplugins/clang/constantparam.cxx
@@ -16,8 +16,7 @@
 #include "compat.hxx"
 
 /*
- Find methods with default params, where the callers never specify the default 
param i.e.
- might as well remove it.
+  Find params on methods where the param is only ever passed as a single 
constant value.
 
  The process goes something like this:
   $ make check
diff --git a/compilerplugins/clang/singlevalfields.cxx 
b/compilerplugins/clang/singlevalfields.cxx
new file mode 100644
index 000..b1c7cc8
--- /dev/null
+++ b/compilerplugins/clang/singlevalfields.cxx
@@ -0,0 +1,411 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "plugin.hxx"
+#include "compat.hxx"
+
+/**
+Look for fields that are only ever assigned a single constant value.
+
+We dmp a list of values assigned to fields, and a list of field definitions.
+Then we will post-process the 2 lists and find the set of interesting fields.
+
+Be warned that it produces around 5G of log file.
+
+The process goes something like this:
+  $ make check
+  $ make FORCE_COMPILE_ALL=1 COMPILER_PLUGIN_TOOL='singlevalfields' check
+  $ ./compilerplugins/clang/singlevalfields.py
+
+Note that the actual process may involve a fair amount of undoing, hand 
editing, and general messing around
+to get it to work :-)
+
+@TODO we don't spot fields that have been zero-initialised via calloc or 
rtl_allocateZeroMemory
+
+*/
+
+namespace {
+
+struct MyFieldInfo
+{
+std::string parentClass;
+std::string fieldName;
+std::string sourceLocation;
+};
+bool operator < (const MyFieldInfo , const MyFieldInfo )
+{
+return std::tie(lhs.parentClass, lhs.fieldName)
+ < std::tie(rhs.parentClass, rhs.fieldName);
+}
+
+struct MyFieldAssignmentInfo : public MyFieldInfo
+{
+std::string value;
+};
+
+bool operator < (const MyFieldAssignmentInfo , const MyFieldAssignmentInfo 
)
+{
+return std::tie(lhs.parentClass, lhs.fieldName, lhs.value)
+ < std::tie(rhs.parentClass, rhs.fieldName, rhs.value);
+}
+
+
+// try to limit the voluminous output a little
+static std::set assignedSet;
+static std::set definitionSet;
+
+
+class SingleValFields:
+public RecursiveASTVisitor, public loplugin::Plugin
+{
+public:
+explicit SingleValFields(InstantiationData const & data): Plugin(data) {}
+
+virtual void run() override
+{
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+
+// dump all our output in one write call - this is to try and limit IO 
"crosstalk" between multiple processes
+// writing to the same logfile
+std::string output;
+for (const MyFieldAssignmentInfo & s : assignedSet)
+output += "asgn:\t" + s.parentClass + "\t" + s.fieldName + "\t" + 
s.value + "\n";
+for (const MyFieldInfo & s : definitionSet)
+output += "defn:\t" + s.parentClass + "\t" + s.fieldName + "\t" + 
s.sourceLocation + "\n";
+ofstream myfile;
+myfile.open( SRCDIR "/singlevalfields.log", ios::app | ios::out);
+myfile << output;
+myfile.close();
+}
+
+bool shouldVisitTemplateInstantiations () const { return true; }
+
+bool VisitFieldDecl( const FieldDecl* );
+bool VisitMemberExpr( const MemberExpr* );
+bool VisitCXXConstructorDecl( const CXXConstructorDecl* );
+private:
+void niceName(const FieldDecl*, MyFieldInfo&);
+std::string fullyQualifiedName(const FunctionDecl*);
+std::string getExprValue(const Expr*);
+bool isInterestingType(const QualType&);
+const FunctionDecl* get_top_FunctionDecl_from_Stmt(const Stmt&);
+};
+
+void SingleValFields::niceName(const FieldDecl* fieldDecl, MyFieldInfo& aInfo)
+{
+aInfo.parentClass = fieldDecl->getParent()->getQualifiedNameAsString();
+aInfo.fieldName = fieldDecl->getNameAsString();
+
+SourceLocation expansionLoc = compiler.getSourceManager().getExpansionLoc( 
fieldDecl->getLocation() );

[Libreoffice-commits] core.git: hwpfilter/source

2016-06-23 Thread Stephan Bergmann

 hwpfilter/source/hwpeq.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1f1f26bf0fcd695fcfb4b034bca001631646674e
Author: Stephan Bergmann 
Date:   Thu Jun 23 13:08:11 2016 +0200

loplugin:implicitboolconversion

Change-Id: I21aeb9504be38e4a6b55892730131a878234ced3

diff --git a/hwpfilter/source/hwpeq.cxx b/hwpfilter/source/hwpeq.cxx
index b87574c..e7afd60 100644
--- a/hwpfilter/source/hwpeq.cxx
+++ b/hwpfilter/source/hwpeq.cxx
@@ -421,7 +421,7 @@ void make_keyword( char *keyword, const char *token)
 if( (token[0] & 0x80) || rtl::isAsciiLowerCase(token[0]) || strlen(token) 
< 2 )
 return;
 
-int capital = rtl::isAsciiUpperCase(keyword[1]);
+bool capital = rtl::isAsciiUpperCase(keyword[1]);
 for( ptr = keyword + 2; *ptr && result; ptr++ )
 {
 if( (*ptr & 0x80) ||
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 70500] EDITING: Selecting with Shift+PageUp/PageDown is not working

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=70500

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||679
 Resolution|--- |DUPLICATE

--- Comment #9 from Justin L  ---
fixed in 4.4.6 / 5.0.4 / 5.1

*** This bug has been marked as a duplicate of bug 94679 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ucbhelper/source ucb/source xmlhelp/source

2016-06-23 Thread Noel Grandin

 ucb/source/ucp/file/bc.cxx|   12 -
 ucb/source/ucp/file/bc.hxx|   27 +---
 ucb/source/ucp/file/filcmd.cxx|   12 -
 ucb/source/ucp/file/filcmd.hxx|   24 +--
 ucb/source/ucp/file/filid.cxx |   18 --
 ucb/source/ucp/file/filid.hxx |   21 +--
 ucb/source/ucp/file/filinpstr.cxx |   27 +---
 ucb/source/ucp/file/filinpstr.hxx |   27 +---
 ucb/source/ucp/file/filprp.cxx|9 -
 ucb/source/ucp/file/filprp.hxx|6 
 ucb/source/ucp/file/filrow.cxx|3 
 ucb/source/ucp/file/filrow.hxx|   54 ++--
 ucb/source/ucp/file/filrset.cxx   |   69 +++---
 ucb/source/ucp/file/filrset.hxx   |  138 ++--
 ucb/source/ucp/file/filstr.cxx|   24 +--
 ucb/source/ucp/file/filstr.hxx|   28 +---
 ucb/source/ucp/file/prov.cxx  |   33 +---
 ucb/source/ucp/file/prov.hxx  |9 -
 ucb/source/ucp/ftp/ftpcontentidentifier.cxx   |3 
 ucb/source/ucp/ftp/ftpresultsetbase.cxx   |   80 +++-
 ucb/source/ucp/ftp/ftpresultsetbase.hxx   |   78 +++
 ucbhelper/source/provider/fd_inputstream.cxx  |   10 -
 xmlhelp/source/cxxhelp/inc/tvfactory.hxx  |9 -
 xmlhelp/source/cxxhelp/provider/inputstream.cxx   |   24 +--
 xmlhelp/source/cxxhelp/provider/inputstream.hxx   |   24 +--
 xmlhelp/source/cxxhelp/provider/resultsetbase.cxx |   75 +++
 xmlhelp/source/cxxhelp/provider/resultsetbase.hxx |  146 +++---
 27 files changed, 330 insertions(+), 660 deletions(-)

New commits:
commit 5bd5baff3f2a55bc2d84e1e352a00dd6969394e3
Author: Noel Grandin 
Date:   Thu Jun 23 11:37:33 2016 +0200

remove some more (void) style function definitions/declarations

found with
git grep -nP '^\s*void\s*\)'

Change-Id: I1206031cf957cb6f957cae64ec5cae1280bda694
Reviewed-on: https://gerrit.libreoffice.org/26590
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx
index f3e37a5..d7b6db8 100644
--- a/ucb/source/ucp/file/bc.cxx
+++ b/ucb/source/ucp/file/bc.cxx
@@ -577,8 +577,7 @@ BaseContent::addProperty(
 
 
 void SAL_CALL
-BaseContent::removeProperty(
-const OUString& Name )
+BaseContent::removeProperty( const OUString& Name )
 throw( beans::UnknownPropertyException,
beans::NotRemoveableException,
RuntimeException, std::exception)
@@ -595,8 +594,7 @@ BaseContent::removeProperty(
 
 
 Sequence< ContentInfo > SAL_CALL
-BaseContent::queryCreatableContentsInfo(
-void )
+BaseContent::queryCreatableContentsInfo()
 throw( RuntimeException, std::exception )
 {
 return m_pMyShell->queryCreatableContentsInfo();
@@ -604,8 +602,7 @@ BaseContent::queryCreatableContentsInfo(
 
 
 Reference< XContent > SAL_CALL
-BaseContent::createNewContent(
-const ContentInfo& Info )
+BaseContent::createNewContent( const ContentInfo& Info )
 throw( RuntimeException, std::exception )
 {
 // Check type.
@@ -695,8 +692,7 @@ BaseContent::removePropertySetInfoChangeListener(
 
 
 Reference< XInterface > SAL_CALL
-BaseContent::getParent(
-void )
+BaseContent::getParent()
 throw( RuntimeException, std::exception )
 {
 OUString ParentUnq = getParentName( m_aUncPath );
diff --git a/ucb/source/ucp/file/bc.hxx b/ucb/source/ucp/file/bc.hxx
index b798cae..c071f61 100644
--- a/ucb/source/ucp/file/bc.hxx
+++ b/ucb/source/ucp/file/bc.hxx
@@ -88,25 +88,21 @@ namespace fileaccess {
 
 // XInterface
 virtual css::uno::Any SAL_CALL
-queryInterface(
-const css::uno::Type& aType )
+queryInterface( const css::uno::Type& aType )
 throw( css::uno::RuntimeException, std::exception) override;
 
 virtual void SAL_CALL
-acquire(
-void )
+acquire()
 throw() override;
 
 virtual void SAL_CALL
-release(
-void )
+release()
 throw() override;
 
 
 // XComponent
 virtual void SAL_CALL
-dispose(
-void )
+dispose()
 throw( css::uno::RuntimeException, std::exception ) override;
 
 virtual void SAL_CALL
@@ -156,8 +152,7 @@ namespace fileaccess {
css::uno::RuntimeException, std::exception ) override;
 
 virtual void SAL_CALL
-abort(
-sal_Int32 CommandId )
+abort( sal_Int32 CommandId )
 throw( css::uno::RuntimeException, std::exception ) override;
 
 
@@ -206,8 +201,7 @@ namespace fileaccess {
css::uno::RuntimeException, std::exception) override;
 
 virtual void

[Libreoffice-bugs] [Bug 58407] Call inserted images Figure rather than Illustration by default in caption

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=58407

Dave Barton  changed:

   What|Removed |Added

 CC||libreoffice...@tasit.net

--- Comment #4 from Dave Barton  ---
I have made this same comment on bug 88148. Rather than debating which should
be the default option, according to this or that academic style, my view is
that the default category should be made a user definable option (ie. an
existing category, user defined string, or none). At the very least there needs
to be a user defined default category, or an option to disable category
additions to the caption.
Maybe this could even be extended into a fully user definable list of
categories, but that's a different RFE.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88148] Image caption management forces to insert a category and numbering even if you do not need it

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88148

Dave Barton  changed:

   What|Removed |Added

 CC||libreoffice...@tasit.net

--- Comment #3 from Dave Barton  ---
I am not sure if I should be commenting on this, or bug 58407 which debates
what the default category should be. My view is that the default category
should be made a user definable option (ie. an existing category, user defined
string, or none). At the very least there needs to be a user defined default
category, or an options to disable category additions to the caption.
Maybe this could even be extended into a fully user definable list of
categories, but that's a different RFE.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59918] FILESAVE: FILEOPEN: save document as docx and reopen result in an freeze/endless loop

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=59918

--- Comment #20 from Andrey Skvortsov  ---
The issue doesn't exist in LO 5.1.3 (Win amd64) and LO 5.1.4 (Linux amd64). In
both cases new saved document is loaded. Loading is slow, but successful.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100243] System freezes when attempting to print while OpenGL is enabled

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100243

--- Comment #11 from Tor Lillqvist  ---
Are you sure you disabled OpenCL? That is not the same as OpenGL. (Yes,
confusingly similar names, even if they are used for different things. But
sure, they are related in the sense that both are (nowadays) implemented on the
GPU.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59918] FILESAVE: FILEOPEN: save document as docx and reopen result in an freeze/endless loop

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=59918

Andrey Skvortsov  changed:

   What|Removed |Added

 CC||andrej.skvort...@gmail.com

--- Comment #19 from Andrey Skvortsov  ---
The issue doesn't exist in LO 5.1.3 (Win amd64) and LO 5.1.4 (Linux amd64). In
both cases new saved document is loaded, but it took time. 
I'd set status to resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100561] New: Adding graphics from gallery to cells in column overwrites graphic above

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100561

Bug ID: 100561
   Summary: Adding graphics from gallery to cells in column
overwrites graphic above
   Product: LibreOffice
   Version: 5.0.6.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m...@willpom.com

Regression.

One of my worksheets contains a column that I add graphics to each cell from
the gallery. If I add a graphic to a cell then select the cell below to add
another graphic rather than adding it to the selected cell it overwrites the
graphic in the cell above.

I tend to work through the worksheet adding all the graphics from one theme,
then again from theme 2, theme 3, etc. 

There are 2 solutions
1. Add graphic to a cell away from added graphics then cut and paste into place
= inefficient.
2. Work from the bottom up swapping between themes constantly = inefficient.

This is the same with custom and in built graphics. If a graphic is larger than
the cell then the overwrite occurs as long as the cell for insertion lies under
or next to the image and its lower border.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

2016-06-23 Thread Prashant

 connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx |4 ++
 connectivity/source/drivers/postgresql/pq_tools.cxx |   15 
++
 connectivity/source/drivers/postgresql/pq_tools.hxx |1 
 connectivity/source/drivers/postgresql/pq_xtable.cxx|5 ++-
 connectivity/source/drivers/postgresql/pq_xtables.cxx   |6 ++--
 connectivity/source/drivers/postgresql/pq_xtables.hxx   |2 -
 connectivity/source/drivers/postgresql/pq_xview.cxx |5 ++-
 connectivity/source/drivers/postgresql/pq_xviews.cxx|6 ++--
 8 files changed, 34 insertions(+), 10 deletions(-)

New commits:
commit d43f4390e006716ca538ad92d09bd012179efd66
Author: Prashant 
Date:   Tue May 17 17:04:40 2016 +

tdf#67302 Resolving tablesSupplier name clash for postgresql

Change-Id: Ic9bedc678699e136c09a51575f1d27131c5ffd29
Reviewed-on: https://gerrit.libreoffice.org/25069
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx 
b/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
index c2e64df..cec6070 100644
--- a/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx
@@ -212,7 +212,9 @@ void ResultSetMetaData::checkTable()
 {
 const OUString name   (getTableName ( 1 ));
 const OUString schema (getSchemaName( 1 ));
-const OUString composedName( schema.isEmpty() ? name : (schema 
+ "." + name) );
+const OUString EscapedName (name.replaceAll("\"","\"\"" ));
+const OUString EscapedSchema ( schema.replaceAll("\"","\"\""));
+const OUString composedName( schema.isEmpty() ? name : ("\"" + 
EscapedSchema + "\".\"" + EscapedName + "\"") );
 tables->getByName( composedName ) >>= m_table;
 }
 }
diff --git a/connectivity/source/drivers/postgresql/pq_tools.cxx 
b/connectivity/source/drivers/postgresql/pq_tools.cxx
index 4e6df8b..0312dde 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.cxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.cxx
@@ -463,6 +463,21 @@ void splitSQL( const OString & sql, OStringVector  )
 
 }
 
+void splitDoubleQuoteEscapedIdentifiers( const OUString & source, OUString 
*first, OUString *second)
+{
+OStringVector vec;
+int a = source.indexOf("\".\"");
+OString tempstring = OUStringToOString(source , RTL_TEXTENCODING_UTF8);
+if(a > 0)
+{
+//remove start and end double quote as well as escaped double quotes
+*first =OStringToOUString(OString(()[1],a-2) , 
RTL_TEXTENCODING_UTF8);
+*first=first->replaceAll("\"\"","\"");
+*second 
=OStringToOUString(OString(()[a+2],source.getLength()-a-2) , 
RTL_TEXTENCODING_UTF8);
+*second=second->replaceAll("\"\"","\"");
+}
+}
+
 void tokenizeSQL( const OString & sql, OStringVector   )
 {
 int length = sql.getLength();
diff --git a/connectivity/source/drivers/postgresql/pq_tools.hxx 
b/connectivity/source/drivers/postgresql/pq_tools.hxx
index 6ab147c..8c17c28 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.hxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.hxx
@@ -111,6 +111,7 @@ OUString array2String( const css::uno::Sequence< 
css::uno::Any >  );
 css::uno::Reference< css::sdbc::XConnection > extractConnectionFromStatement(
 const css::uno::Reference< css::uno::XInterface > & stmt );
 
+void splitDoubleQuoteEscapedIdentifiers( const OUString & source, OUString 
*first, OUString *second);
 void splitConcatenatedIdentifier( const OUString & source, OUString *first, 
OUString *second);
 
 
diff --git a/connectivity/source/drivers/postgresql/pq_xtable.cxx 
b/connectivity/source/drivers/postgresql/pq_xtable.cxx
index 4b8d451..8e0ae92 100644
--- a/connectivity/source/drivers/postgresql/pq_xtable.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xtable.cxx
@@ -154,12 +154,13 @@ void Table::rename( const OUString& newName )
 
 OUString newTableName;
 OUString newSchemaName;
+//changing schema + dot + table-name to "schema"."table-name"
 // OOo2.0 passes schema + dot + new-table-name while
 // OO1.1.x passes new Name without schema
 // in case name contains a dot, it is interpreted as schema.tablename
-if( newName.indexOf( '.' ) >= 0 )
+if( newName.indexOf( "\".\"" ) >= 0 )
 {
-splitConcatenatedIdentifier( newName, ,  );
+splitDoubleQuoteEscapedIdentifiers( newName, , 
 );
 }
 else
 {
diff --git a/connectivity/source/drivers/postgresql/pq_xtables.cxx 
b/connectivity/source/drivers/postgresql/pq_xtables.cxx
index 97a9b7f..9ec5c02 100644
--- a/connectivity/source/drivers/postgresql/pq_xtables.cxx
+++

[Libreoffice-bugs] [Bug 100560] New: Custon gallery theme order

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100560

Bug ID: 100560
   Summary: Custon gallery theme order
   Product: LibreOffice
   Version: 5.0.6.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m...@willpom.com

When importing graphics into a new gallery theme they sort in reverse order to
file name with no way to sort other than manually moving each individual
graphic. I have many graphics in different themes that I use that were created
(& named) according to frequency of use.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/source

2016-06-23 Thread anwilli5

 framework/source/services/autorecovery.cxx |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit 9e28b2f9ac3f205db223352cb88eb3546a8e1c0e
Author: anwilli5 
Date:   Sun Jun 5 23:06:05 2016 -0400

tdf#96607 'Save as' doesn't update global auto-recovery state

The auto-recovery service maintains a list of structures (one for each open
document) containing information needed to carry out the auto-save
functionality. One such piece of information is the location of the backup
file, stored in a struct member named 'OldTempURL'.  At every auto-save
interval, this list is iterated through and a function (implts_saveOneDoc)
is called during each iteration to save the current state of the associated
document.

The algorithm works as follows:
 1. A new backup file URL is chosen so as not to conflict with any already
existing backup files in the backup directory.  This URL is based on the
file name and incorporates a number (starting at 0) that is incremented
until a name is chosen that doesn't conflict.

 2. The document is saved to this new backup file URL

 3. The previous backup file (indicated by its structure's 'OldTempURL') is
deleted

 4. The new backup file URL is stored (in its structure's 'OldTempURL') for 
the
next time the file needs to be saved.

Assuming you start with a new Writer doc and then make some changes, when 
it is
time to auto-save, the backup file name 'untitled_0.odt' (excluding path) 
will
be selected, the latest state of the open file will be written to that 
backup
file, and the full URL for the backup file will be saved into the struct
'OldTempURL' member.

The next time changes are made and an auto-save occurs, this algorithm will
result in the name 'untitled_1.odt' being selected, the file contents saved
into this new file, 'untitled_0.odt' being deleted, and the full URL for the
new backup file being saved in 'OldTempURL'.

The third time through results in 'untitled_0.odt' being selected (since 
this
file doesn't exist on disk), and subsequent iterations of auto-saving cause
the backup file name to alternate between the two aforementioned.

The problem occurs during a 'Save as' operation. When this happens, the 
backup
file is deleted (which is fine - it was just saved, and the next auto-save 
will
back it up) but 'OldTempURL' is not properly reset (see below for more 
info.)
During the next auto-save, 'untitled_0.odt' will be selected for the new 
backup
file name (since no file exists by this name), and one of two things will
happen (based on how many auto-saves have occurred):

 1. 'OldTempURL' points to 'untitled_1.odt', and the algorithm above 
continues
to work correctly (at least in that it continues to backup file 
contents.)

 2. 'OldTempURL' points to 'untitled_0.odt', the name chosen for the new 
backup
file.  In this case, the document contents will be saved to this file
(step 2) but then the file will be deleted (step 3).  'OldTempURL' will
maintain this URL from then on out, causing this case to be hit for all
future auto-save intervals.

So, 50% of the time (30 minutes out of every hour) auto-save will stop 
backing
up file contents on a 'Save as'.

The function that handles the 'Save as' case (implts_markDocumentAsSaved)
clears 'OldTempURL' and sets other relavent struct members for a local 
variable
copy of the global struct, but doesn't copy them back. :(  These changes are
effectively lost when the function returns.

There are several other cases where this appears to be happening as well, 
but
more work is needed to determine whether this is actually the case:
 - implts_prepareSessionShutdown
 - implts_saveDocs, handling the 'dangerousDocs' and in a few other places
 - implts_openDocs
 - implts_resetHandleStates

Also, there is some JUnitTest code for auto-save, but it is currently 
disabled
(and fails to run successfully.) It'd be great to get these working again, 
or
to just write python equivalents. Implementing this would like take me a 
while,
though, so for now I just tested manually to ensure that this fixes the 
issue.

When I have some more time I'd like to work more on this, but I wanted to 
send
this patch in for now to address bug #96607.

This may also address bug #99890, since some of the struct members that 
don't
make it into the global state relate to the file name.  I haven't explicitly
tested this case, though.

Change-Id: Ic702d6f78e60c7cf828a1564ccca118dd45d152b
Reviewed-on: https://gerrit.libreoffice.org/25948
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git

[Libreoffice-bugs] [Bug 87643] SIDEBAR: New Shapes Tab and content panels

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87643

Susobhan Ghosh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |susobhan...@gmail.com
   |desktop.org |

--- Comment #17 from Susobhan Ghosh  ---
I've started to work on this, and would like a few more details.

1. The sidebar layout - talked to bubli and she suggested that accordion would
take up too much time to code (rest of the summer). So any decision on which
layout to be finally used would be appreciated.

2. Does this involve adding new native shapes to Draw? (not talking about user
defined ones)

3. As for user adding shapes, does it involve drag & drop or just the Add
button on the top right?

More question to follow as I progress.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 87643] SIDEBAR: New Shapes Tab and content panels

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87643

Susobhan Ghosh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |susobhan...@gmail.com
   |desktop.org |

--- Comment #17 from Susobhan Ghosh  ---
I've started to work on this, and would like a few more details.

1. The sidebar layout - talked to bubli and she suggested that accordion would
take up too much time to code (rest of the summer). So any decision on which
layout to be finally used would be appreciated.

2. Does this involve adding new native shapes to Draw? (not talking about user
defined ones)

3. As for user adding shapes, does it involve drag & drop or just the Add
button on the top right?

More question to follow as I progress.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: oox/source

2016-06-23 Thread Zhengqiang Wang

 oox/source/drawingml/customshapeproperties.cxx   |6 +++---
 oox/source/drawingml/customshapes/oox-drawingml-cs-presets   |2 +-
 oox/source/drawingml/customshapes/presetShapeDefinitions.xml |4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 45909a8e7ec2c4ef366836ab6bf975a6c2fdd007
Author: Zhengqiang Wang 
Date:   Thu Jun 2 11:35:24 2016 +0800

tdf#100153 modify noSmoking shape

*modify customshapeproperties.cxx
 fix compile error : make oox dbglevel=2
 The define of dumpCode() has been removed by 
c714b43b0137ad253f51e1c65417c9874b8509e5
*modify presetShapeDefinitions.xml
 fix noSmoking shape
*modfiy oox-drawingml-cs-presets
 this file is generated by presetShapeDefinitions.xml

Change-Id: I383d6b6961b546585035afd8c1a4398385a11914
Reviewed-on: https://gerrit.libreoffice.org/25801
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/oox/source/drawingml/customshapeproperties.cxx 
b/oox/source/drawingml/customshapeproperties.cxx
index 0182102..daf178d 100644
--- a/oox/source/drawingml/customshapeproperties.cxx
+++ b/oox/source/drawingml/customshapeproperties.cxx
@@ -147,7 +147,7 @@ void CustomShapeProperties::pushToPropSet( const 
::oox::core::FilterBase& /* rFi
 
 aPropertyMap = maPresetDataMap[mnShapePresetType];
 #ifdef DEBUG
-aPropertyMap.dumpCode();
+aPropertyMap.dumpCode( aPropertyMap.makePropertySet() );
 #endif
 }
 
@@ -373,10 +373,10 @@ void CustomShapeProperties::pushToPropSet( const 
::oox::core::FilterBase& /* rFi
 
 #ifdef DEBUG
 SAL_INFO("oox.cscode", "==cscode== begin");
-aPropertyMap.dumpCode();
+aPropertyMap.dumpCode( aPropertyMap.makePropertySet() );
 SAL_INFO("oox.cscode", "==cscode== end");
 SAL_INFO("oox.csdata", "==csdata== begin");
-aPropertyMap.dumpData();
+aPropertyMap.dumpData( aPropertyMap.makePropertySet() );
 SAL_INFO("oox.csdata", "==csdata== end");
 #endif
 // converting the vector to a sequence
diff --git a/oox/source/drawingml/customshapes/oox-drawingml-cs-presets 
b/oox/source/drawingml/customshapes/oox-drawingml-cs-presets
index e03f33d..c4f7a34 100644
--- a/oox/source/drawingml/customshapes/oox-drawingml-cs-presets
+++ b/oox/source/drawingml/customshapes/oox-drawingml-cs-presets
@@ -2195,7 +2195,7 @@ ViewBox
 AdjustmentValues
 ([]com.sun.star.drawing.EnhancedCustomShapeAdjustmentValue) { { Value = (any) 
{ (long) 18750 }, State = (com.sun.star.beans.PropertyState) DIRECT_VALUE, Name 
= "adj" } }
 Equations
-([]string) { "if(0-$0 ,0,if(5-$0 ,$0 ,5))", "min(logwidth,logheight)", 
"?1 *?0 /10", "logwidth/2", "?3 +0-?2 ", "logheight/2", "?5 +0-?2 ", 
"(1080*atan2(logheight,logwidth))/pi", "?6 *cos(pi*(?7 )/1080)", "?4 
*sin(pi*(?7 )/1080)", "sqrt(?8 *?8 +?9 *?9 +0*0)", "?4 *?6 /?10 ", "?2 
*1/2", "(1080*atan2(?12 ,?11 ))/pi", "?13 *2/1", "-1080+2-0", 
"(1080*atan2(logheight,logwidth))/pi", "?16 +0-?13 ", "?17 +0-1080", 
"?6 *cos(pi*(?17 )/1080)", "?4 *sin(pi*(?17 )/1080)", "sqrt(?19 *?19 
+?20 *?20 +0*0)", "?4 *?6 /?21 ", "?22 *cos(pi*(?17 )/1080)", "?22 
*sin(pi*(?17 )/1080)", "logwidth/2", "?25 +?23 -0", "logheight/2", "?27 
+?24 -0", "?25 +0-?23 ", "?27 +0-?24 ", "?3 *cos(pi*(270)/1080)", "?5 
*sin(pi*(270)/1080)", "?25 +0-?31 ", "?25 +?31 -0", "?27 +0-?32 ", "?27 
+?32 -0", "logheight", "logwidth", "(1080)/6.0", "(540)/6.0", 
"(1620)/6.0", "(540)/6.0", "(0)/6.0", "(540)/6.0", 
"(54000
 00)/6.0", "(540)/6.0", "(?17 )/6.0", "(?15 )/6.0", "(?18 
)/6.0", "(?15 )/6.0" }
+([]string) { "if(0-$0 ,0,if(5-$0 ,$0 ,5))", "min(logwidth,logheight)", 
"?1 *?0 /10", "logwidth/2", "?3 +0-?2 ", "logheight/2", "?5 +0-?2 ", 
"(1080*atan2(logheight,logwidth))/pi", "?6 *cos(pi*(?7 )/1080)", "?4 
*sin(pi*(?7 )/1080)", "sqrt(?8 *?8 +?9 *?9 +0*0)", "?4 *?6 /?10 ", "?2 
*1/2", "(1080*atan2(?12 ,?11 ))/pi", "?13 *2/1", "-1080+?14 -0", 
"(1080*atan2(logheight,logwidth))/pi", "?16 +0-?13 ", "?17 +0-1080", 
"?6 *cos(pi*(?17 )/1080)", "?4 *sin(pi*(?17 )/1080)", "sqrt(?19 *?19 
+?20 *?20 +0*0)", "?4 *?6 /?21 ", "?22 *cos(pi*(?17 )/1080)", "?22 
*sin(pi*(?17 )/1080)", "logwidth/2", "?25 +?23 -0", "logheight/2", "?27 
+?24 -0", "?25 +0-?23 ", "?27 +0-?24 ", "?3 *cos(pi*(270)/1080)", "?5 
*sin(pi*(270)/1080)", "?25 +0-?31 ", "?25 +?31 -0", "?27 +0-?32 ", "?27 
+?32 -0", "logheight", "logwidth", "(1080)/6.0", "(540)/6.0", 
"(1620)/6.0", "(540)/6.0", "(0)/6.0", "(540)/6.0", 
"(54
 0)/6.0", "(540)/6.0", "(?17 )/6.0", "(?15 )/6.0", 
"(?18 )/6.0", "(?15 )/6.0" }
 Handles
 ([][]com.sun.star.beans.PropertyValue) { { { Name =

[Libreoffice-commits] core.git: editeng/source idl/source rsc/source writerfilter/source

2016-06-23 Thread Gökhan Gurbetoğlu

 editeng/source/misc/svxacorr.cxx|3 ++-
 idl/source/cmptools/hash.cxx|4 +++-
 rsc/source/tools/rscchar.cxx|3 ++-
 writerfilter/source/rtftok/rtftokenizer.cxx |3 ++-
 4 files changed, 9 insertions(+), 4 deletions(-)

New commits:
commit ea5a5b1dbb669415586520c2b0c526b133aa07e4
Author: GÃ¶khan GurbetoÄlu 
Date:   Tue Jun 21 11:45:30 2016 +0300

tdf#99589 - tolower / toupper - dangerous to Turks ...

Change-Id: Id3b9abd557f2b8dfc942589362452cbdb0232da9
Reviewed-on: https://gerrit.libreoffice.org/26546
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index 8658967..d736d94 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -66,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star::ucb;
 using namespace ::com::sun::star::uno;
@@ -1374,7 +1375,7 @@ void SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc& rDoc, 
const OUString& rTxt,
 
 if( ( IsAutoCorrFlag( ChgOrdinalNumber ) &&
 (nInsPos >= 2 ) &&   // fdo#69762 avoid autocorrect for 
2e-3
-( '-' != cChar || 'E' != toupper(rTxt[nInsPos-1]) || '0' > 
rTxt[nInsPos-2] || '9' < rTxt[nInsPos-2] ) &&
+( '-' != cChar || 'E' != 
rtl::toAsciiUpperCase(rTxt[nInsPos-1]) || '0' > rTxt[nInsPos-2] || '9' < 
rTxt[nInsPos-2] ) &&
 FnChgOrdinalNumber( rDoc, rTxt, nCapLttrPos, nInsPos, eLang ) 
) ||
 ( IsAutoCorrFlag( SetINetAttr ) &&
 ( ' ' == cChar || '\t' == cChar || 0x0a == cChar || !cChar ) &&
diff --git a/idl/source/cmptools/hash.cxx b/idl/source/cmptools/hash.cxx
index 22faf38..fc63730 100644
--- a/idl/source/cmptools/hash.cxx
+++ b/idl/source/cmptools/hash.cxx
@@ -26,6 +26,8 @@
 #include 
 #include 
 
+#include 
+
 SvStringHashEntry::~SvStringHashEntry() { };
 
 SvHashTable::SvHashTable( sal_uInt32 nMaxEntries )
@@ -121,7 +123,7 @@ sal_uInt32 SvStringHashTable::HashFunc( const OString& 
rElement ) const
 int nShift = 0;
 while( *pStr )
 {
-if( isupper( *pStr ) )
+if( rtl::isAsciiUpperCase( *pStr ) )
 nHash ^= sal_uInt32(*pStr - 'A' + 26) << nShift;
 else
 nHash ^= sal_uInt32(*pStr - 'a') << nShift;
diff --git a/rsc/source/tools/rscchar.cxx b/rsc/source/tools/rscchar.cxx
index b00d61f..dbe096e 100644
--- a/rsc/source/tools/rscchar.cxx
+++ b/rsc/source/tools/rscchar.cxx
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 
 char * RscChar::MakeUTF8( char * pStr, sal_uInt16 nTextEncoding )
 {
@@ -109,7 +110,7 @@ char * RscChar::MakeUTF8( char * pStr, sal_uInt16 
nTextEncoding )
 {
 if( isdigit( *pStr ) )
 nChar = nChar * 16 + (sal_uInt8)*pStr - 
(sal_uInt8)'0';
-else if( isupper( *pStr ) )
+else if( rtl::isAsciiUpperCase( *pStr ) )
 nChar = nChar * 16 + (sal_uInt8)*pStr - 
(sal_uInt8)'A' +10;
 else
 nChar = nChar * 16 + (sal_uInt8)*pStr - 
(sal_uInt8)'a' +10;
diff --git a/writerfilter/source/rtftok/rtftokenizer.cxx 
b/writerfilter/source/rtftok/rtftokenizer.cxx
index 2dab789..83ecf69 100644
--- a/writerfilter/source/rtftok/rtftokenizer.cxx
+++ b/writerfilter/source/rtftok/rtftokenizer.cxx
@@ -12,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 using namespace com::sun::star;
@@ -169,7 +170,7 @@ int RTFTokenizer::asHex(char ch)
 ret = ch - '0';
 else
 {
-if (islower(ch))
+if (rtl::isAsciiLowerCase(ch))
 {
 if (ch < 'a' || ch > 'f')
 return -1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100536] FORMATTING: Correcting numbering with a number erase numbers at last pages

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100536

Daniël van Vuuren  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Daniël van Vuuren  ---
Hello Pineau,

Sorry for confirming before checking for a duplicate.

But thanks for reporting the bug. This issue has previously been reported, so
this bug will be resolved as a duplicate of the earlier report. You will
automatically be added to the CC list of the other bug.

Greetings,
Daniël

*** This bug has been marked as a duplicate of bug 35694 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source filter/source helpcompiler/inc hwpfilter/source l10ntools/source sal/osl sdext/source soltools/mkdepend tools/source

2016-06-23 Thread Gökhan Gurbetoğlu

 basic/source/sbx/sbxvar.cxx|3 ++-
 filter/source/t602/t602filter.cxx  |9 +
 helpcompiler/inc/HelpCompiler.hxx  |3 ++-
 hwpfilter/source/hbox.cxx  |6 --
 hwpfilter/source/hwpeq.cxx |   18 ++
 l10ntools/source/gL10nMem.cxx  |4 ++--
 sal/osl/w32/file_dirvol.cxx|3 ++-
 sdext/source/pdfimport/wrapper/wrapper.cxx |6 --
 soltools/mkdepend/collectdircontent.cxx|5 +++--
 tools/source/ref/globname.cxx  |9 +
 10 files changed, 39 insertions(+), 27 deletions(-)

New commits:
commit 9b9e5cfd2fa629b2e1dc4a193e48a4a4e8d34126
Author: GÃ¶khan GurbetoÄlu 
Date:   Mon Jun 20 17:40:13 2016 +0300

tdf#99589 - tolower / toupper - dangerous to Turks ...

Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683
Reviewed-on: https://gerrit.libreoffice.org/26537
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/basic/source/sbx/sbxvar.cxx b/basic/source/sbx/sbxvar.cxx
index 0977c74..8ed87ae 100644
--- a/basic/source/sbx/sbxvar.cxx
+++ b/basic/source/sbx/sbxvar.cxx
@@ -30,6 +30,7 @@
 #include "sbunoobj.hxx"
 #include 
 #include 
+#include 
 
 #include 
 using namespace com::sun::star::uno;
@@ -350,7 +351,7 @@ sal_uInt16 SbxVariable::MakeHashCode( const OUString& rName 
)
 {
 return 0;
 }
-n = sal::static_int_cast< sal_uInt16 >( ( n << 3 ) + toupper( c ) );
+n = sal::static_int_cast< sal_uInt16 >( ( n << 3 ) + 
rtl::toAsciiUpperCase( c ) );
 }
 return n;
 }
diff --git a/filter/source/t602/t602filter.cxx 
b/filter/source/t602/t602filter.cxx
index 3a4b3ea..ade1e60 100644
--- a/filter/source/t602/t602filter.cxx
+++ b/filter/source/t602/t602filter.cxx
@@ -38,6 +38,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::cppu;
 using namespace ::osl;
@@ -679,14 +680,14 @@ tnode T602ImportFilter::PointCmd602(unsigned char *ch)
 char pcmd[2];
 
 // warning: uChar -> char
-pcmd[0] = (char) toupper(*ch); inschr(*ch);
+pcmd[0] = (char) rtl::toAsciiUpperCase(*ch); inschr(*ch);
 *ch = Readchar602();
 if (!*ch) return tnode::EEND;
 if (*ch=='\n') return tnode::EOL;
 if (!isalpha(*ch)) return (*ch<32) ? tnode::SETCH : tnode::WRITE;
 
 // warning: uChar -> char
-pcmd[1] = (char) toupper(*ch); inschr(*ch);
+pcmd[1] = (char) rtl::toAsciiUpperCase(*ch); inschr(*ch);
 
  if (pcmd[0]=='P' && pcmd[1]=='A') { if (pst.pars) pst.willbeeop = 
true; }
 else if (pcmd[0]=='C' && pcmd[1]=='P') { if (pst.pars) pst.willbeeop = 
true; }
@@ -761,12 +762,12 @@ void T602ImportFilter::Read602()
 
 case tnode::EXPCMD: ch = Readchar602();
 if(ch == 0) {inschr('@'); node = tnode::EEND; }
-else if(isupper(ch)) {
+else if(rtl::isAsciiUpperCase(ch)) {
 cmd602[0] = ch;
 ch = Readchar602();
 cmd602[1] = ch;
 cmd602[2] = '\0';
-if(isupper(ch))
+if(rtl::isAsciiUpperCase(ch))
 node = tnode::SETCMD;   //nedodelano
 else {
 inschr('@');
diff --git a/helpcompiler/inc/HelpCompiler.hxx 
b/helpcompiler/inc/HelpCompiler.hxx
index 78f98a2..1acce8f 100644
--- a/helpcompiler/inc/HelpCompiler.hxx
+++ b/helpcompiler/inc/HelpCompiler.hxx
@@ -39,6 +39,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -249,7 +250,7 @@ private:
 
 inline char tocharlower(char c)
 {
-return static_cast(tolower(c));
+return static_cast(rtl::toAsciiLowerCase(c));
 }
 
 #endif
diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index e501949..bd30edc 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -31,6 +31,8 @@
 #include "drawdef.h"
 #include "hcode.h"
 
+#include 
+
 int HBox::boxCount = 0;
 
 HBox::HBox(hchar hch)
@@ -586,7 +588,7 @@ static void getOutlineNumStr(int style, int level, int num, 
hchar * hstr)
 ptr = buf;
 while (*ptr)
 {
-*ptr = sal::static_int_cast(toupper(*ptr));
+*ptr = sal::static_int_cast(rtl::toAsciiUpperCase(*ptr));
 ptr++;
 }
 }
@@ -688,7 +690,7 @@ hchar_string Outline::GetUnicode() const
 char *ptr = dest;
 while( *ptr )
 {
-*ptr = 
sal::static_int_cast(toupper(*ptr));
+*ptr = 
sal::static_int_cast(rtl::toAsciiUpperCase(*ptr));
 ptr++;
 }
 }
diff --git a/hwpfilter/source/hwpeq.cxx b/hwpfilter/source/hwpeq.cxx
index dd46110..b87574c 100644
---

[Libreoffice-bugs] [Bug 97872] File association in windows registry

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97872

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97872] File association in windows registry

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97872

--- Comment #3 from Commit Notification 
 ---
skswales committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8ab7db320ff158949d2eadaa6e654115201ddf61

tdf#97872 File association in Windows registry

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: scp2/inc

2016-06-23 Thread skswales

 scp2/inc/macros.inc |   28 
 1 file changed, 20 insertions(+), 8 deletions(-)

New commits:
commit 8ab7db320ff158949d2eadaa6e654115201ddf61
Author: skswales 
Date:   Thu Jun 2 23:58:50 2016 +0100

tdf#97872 File association in Windows registry

Fix for double backslashes in paths to programs in shell/open etc.
registry entries for all non-native file types such as .doc that are
mapped by installer to use scalc.exe/swriter.exe etc.

Change-Id: Ice8033d4fee079c0fb6d8f84e00ebd784e85d135
Reviewed-on: https://gerrit.libreoffice.org/25849
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/scp2/inc/macros.inc b/scp2/inc/macros.inc
index 7b895b6..30f6760 100644
--- a/scp2/inc/macros.inc
+++ b/scp2/inc/macros.inc
@@ -298,7 +298,7 @@ End
 Value = STRING(default); \
 End
 
-#define REGISTRY_ENTRY_NEW_CMD(name,modid,app) \
+#define REGISTRY_ENTRY_NEW_CMD_PPA(name,modid,progpath_program_app) \
 RegistryItem CONCAT3(gid_Regitem_Openoffice_,name,_Shell_New) \
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT; \
 ModuleID = modid; \
@@ -309,33 +309,45 @@ End
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT; \
 ModuleID = modid; \
 Subkey = STRING(CONCAT3(LibreOffice.,name,\shell\new\command)); \
-Value = "\"\program\\" STRING(app) "\" -n \"%1\""; \
+Value = "\"" STRING(progpath_program_app) "\" -n \"%1\""; \
 End
 
-#define REGISTRY_ENTRY_OPEN_CMD(name,modid,app) \
+#define REGISTRY_ENTRY_NEW_CMD(name,modid,app) \
+   REGISTRY_ENTRY_NEW_CMD_PPA(name,modid,\program\app)
+
+#define REGISTRY_ENTRY_OPEN_CMD_PPA(name,modid,progpath_program_app) \
 RegistryItem CONCAT3(gid_Regitem_Openoffice_,name,_Shell_Open_Command) \
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT; \
 ModuleID = modid; \
 Subkey = STRING(CONCAT3(LibreOffice.,name,\shell\open\command)); \
-Value = "\"\program\\" STRING(app) "\" -o \"%1\""; \
+Value = "\"" STRING(progpath_program_app) "\" -o \"%1\""; \
 End
 
-#define REGISTRY_ENTRY_PRINT_CMD(name,modid,app) \
+#define REGISTRY_ENTRY_OPEN_CMD(name,modid,app) \
+   REGISTRY_ENTRY_OPEN_CMD_PPA(name,modid,\program\app)
+
+#define REGISTRY_ENTRY_PRINT_CMD_PPA(name,modid,progpath_program_app) \
 RegistryItem CONCAT3(gid_Regitem_Openoffice_,name,_Shell_Print_Command) \
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT; \
 ModuleID = modid; \
 Subkey = STRING(CONCAT3(LibreOffice.,name,\shell\print\command)); \
-Value = "\"\program\\" STRING(app) "\" -p \"%1\""; \
+Value = "\"" STRING(progpath_program_app) "\" -p \"%1\""; \
 End
 
-#define REGISTRY_ENTRY_PRINTTO_CMD(name,modid,app) \
+#define REGISTRY_ENTRY_PRINT_CMD(name,modid,app) \
+   REGISTRY_ENTRY_PRINT_CMD_PPA(name,modid,\program\app)
+
+#define REGISTRY_ENTRY_PRINTTO_CMD_PPA(name,modid,progpath_program_app) \
 RegistryItem CONCAT3(gid_Regitem_Openoffice_,name,_Shell_Printto_Command) \
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT; \
 ModuleID = modid; \
 Subkey = STRING(CONCAT3(LibreOffice.,name,\shell\printto\command)); \
-Value = "\"\program\\" STRING(app) "\" -pt \"%2\" \"%1\""; \
+Value = "\"" STRING(progpath_program_app) "\" -pt \"%2\" \"%1\""; \
 End
 
+#define REGISTRY_ENTRY_PRINTTO_CMD(name,modid,app) \
+   REGISTRY_ENTRY_PRINTTO_CMD_PPA(name,modid,\program\app)
+
 #define REGISTRY_ENTRY_CAPABILITIES(name,modid,key,doc_type) \
 RegistryItem 
CONCAT2(gid_Regitem_Software_Manufacturer_Productname_Productversion_Capabilities_FileAssociations_,name)
 \
 ParentID = PREDEFINED_HKEY_LOCAL_MACHINE; \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 93224] The left page header and footer is not displayed for a file created using Word 2007 , using normal section breaks

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93224

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||640
 Resolution|--- |DUPLICATE

--- Comment #9 from Justin L  ---
fixed in 5.1.4
bibisected (linux daily) and assume the fix came from
   author   Luke Deller  2016-01-03 12:12:56 (GMT)
   tdf#93640Fix import of linked left page header/footer

*** This bug has been marked as a duplicate of bug 93640 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38639] DOCX: section change with different header/ footer settings not regarded

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=38639

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||640
 Resolution|--- |DUPLICATE

--- Comment #10 from Justin L  ---
fixed in 5.1.4 - Duplicate of bug 93640

bibisected (linux daily) and assume the fix came from
   author   Luke Deller  2016-01-03 12:12:56 (GMT)
   tdf#93640Fix import of linked left page header/footer

*** This bug has been marked as a duplicate of bug 93640 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

--- Comment #12 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d8b9b80b114b94b20b0bf1438d80e925b49e3bf

package: fix exception handling in DeflateThread (related tdf#91807)

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100451] 4-bit image in WMF inserted into document is mishandled in PDF export when OpenGL is used

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100451

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.2.0.1 |target:5.3.0 target:5.2.0.1
   ||target:5.1.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100451] 4-bit image in WMF inserted into document is mishandled in PDF export when OpenGL is used

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100451

--- Comment #5 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebad0ff6da52d3f3bf9ca026ed2699df0673ce76=libreoffice-5-1

tdf#100451 convert texture buffer to 1-bit and 4-bit palette buffer

It will be available in 5.1.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|odf |odf target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - package/inc package/source vcl/headless

2016-06-23 Thread Michael Stahl

 package/inc/ZipOutputStream.hxx|1 +
 package/source/zipapi/ZipOutputStream.cxx  |   12 +++-
 package/source/zippackage/ZipPackageStream.cxx |   11 +++
 vcl/headless/svpbmp.cxx|   12 +++-
 4 files changed, 34 insertions(+), 2 deletions(-)

New commits:
commit 8d8b9b80b114b94b20b0bf1438d80e925b49e3bf
Author: Michael Stahl 
Date:   Thu Jun 23 11:24:55 2016 +0200

package: fix exception handling in DeflateThread (related tdf#91807)

In the bugdoc of tdf#91807 there are at least 49 corrupt zip streams
that raise exceptions in the DeflateThreads.  Because the maximum
allowed number of threads happens to be 48, this results in an infinite
loop in ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess().

(regression from 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14)

In case an exception is thrown, don't re-throw it immediately, which
might cause trouble such as leaking all of the ZipOutputEntry instances
in m_aEntries.

Change-Id: Ia74ab8e46fa1349c049d05dbec3454bfbe7d61d9

diff --git a/package/inc/ZipOutputStream.hxx b/package/inc/ZipOutputStream.hxx
index 26d7715..136bc72 100644
--- a/package/inc/ZipOutputStream.hxx
+++ b/package/inc/ZipOutputStream.hxx
@@ -40,6 +40,7 @@ class ZipOutputStream
 ZipEntry*m_pCurrentEntry;
 comphelper::ThreadPool _rSharedThreadPool;
 std::vector< ZipOutputEntry* > m_aEntries;
+::css::uno::Any m_aDeflateException;
 
 public:
 ZipOutputStream(
diff --git a/package/source/zipapi/ZipOutputStream.cxx 
b/package/source/zipapi/ZipOutputStream.cxx
index 9213ed7..2daff01 100644
--- a/package/source/zipapi/ZipOutputStream.cxx
+++ b/package/source/zipapi/ZipOutputStream.cxx
@@ -98,7 +98,12 @@ void 
ZipOutputStream::consumeScheduledThreadEntry(ZipOutputEntry* pCandidate)
 //Any exceptions thrown in the threads were caught and stored for now
 ::css::uno::Any 
aCaughtException(pCandidate->getParallelDeflateException());
 if (aCaughtException.hasValue())
-::cppu::throwException(aCaughtException);
+{
+m_aDeflateException = aCaughtException; // store it for later throwing
+// the exception handler in DeflateThread should have cleaned temp file
+delete pCandidate;
+return;
+}
 
 writeLOC(pCandidate->getZipEntry(), pCandidate->isEncrypt());
 
@@ -178,6 +183,11 @@ void ZipOutputStream::finish()
 // consume all processed entries
 consumeAllScheduledThreadEntries();
 
+if (m_aDeflateException.hasValue())
+{   // throw once all threads are finished and m_aEntries can be released
+::cppu::throwException(m_aDeflateException);
+}
+
 sal_Int32 nOffset= static_cast < sal_Int32 > (m_aChucker.GetPosition());
 for (ZipEntry* p : m_aZipList)
 {
diff --git a/package/source/zippackage/ZipPackageStream.cxx 
b/package/source/zippackage/ZipPackageStream.cxx
index 43a9b85..5efb145 100644
--- a/package/source/zippackage/ZipPackageStream.cxx
+++ b/package/source/zippackage/ZipPackageStream.cxx
@@ -486,6 +486,17 @@ private:
 catch (const uno::Exception&)
 {
 mpEntry->setParallelDeflateException(::cppu::getCaughtException());
+try
+{
+if (mpEntry->m_xOutStream.is())
+mpEntry->closeBufferFile();
+if (!mpEntry->m_aTempURL.isEmpty())
+mpEntry->deleteBufferFile();
+}
+catch (uno::Exception const&)
+{
+}
+mpEntry->setFinished();
 }
 }
 };
commit cd292ba17c62a90f3530326f7fc87036da16a353
Author: Michael Stahl 
Date:   Wed Jun 22 15:41:11 2016 +0200

vcl: avoid vcl_filters_test crash with ASAN 32-bit

ASAN usually aborts on operator new[] allocation failure but with
allocator_may_return_null=1 in ASAN_OPTIONS it returns null instead; it
doesn't throw std::bad_alloc though.

Change-Id: I28d67a787e90604c12ad06fd97d265664bd62ef2

diff --git a/vcl/headless/svpbmp.cxx b/vcl/headless/svpbmp.cxx
index cb8c771..f5dabae 100644
--- a/vcl/headless/svpbmp.cxx
+++ b/vcl/headless/svpbmp.cxx
@@ -125,7 +125,17 @@ BitmapBuffer* ImplCreateDIB(
 {
 size_t size = pDIB->mnScanlineSize * pDIB->mnHeight;
 pDIB->mpBits = new sal_uInt8[size];
-std::memset(pDIB->mpBits, 0, size);
+#ifdef __SANITIZE_ADDRESS__
+if (!pDIB->mpBits)
+{   // can only happen with ASAN allocator_may_return_null=1
+delete pDIB;
+pDIB = nullptr;
+}
+else
+#endif
+{
+std::memset(pDIB->mpBits, 0, size);
+}
 }
 catch (const std::bad_alloc&)
 {
___
Libreoffice-commits mailing

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/opengl

2016-06-23 Thread Tomaž Vajngerl

 vcl/opengl/salbmp.cxx |   92 +++---
 1 file changed, 66 insertions(+), 26 deletions(-)

New commits:
commit ebad0ff6da52d3f3bf9ca026ed2699df0673ce76
Author: TomaÅ¾ Vajngerl 
Date:   Tue Jun 21 14:34:45 2016 +0800

tdf#100451 convert texture buffer to 1-bit and 4-bit palette buffer

OpenGL doesn't support palettes so when the texture is created,
the bitmap buffer is converted to 24-bit RGB. This works nice for
showing the bitmaps on screen. The problem arises when we want to
read the bitmap buffer back (like in a PDF export) as we have to
convert that back to 1-bit or 4-bit palette bitmap buffer. For 4-bit
this was not implemented yet, on the other hand for 1-bit it was
implemented but it didn't take palette into account so the bitmap
was not correct (inverted).

This commit introduces a ScanlineWriter which handles writing
RGB colors to 1-bit and 4-bit palette scanlines. The class sets
up the masks and shifts needed to place the color information
at the correct place in a byte. It also automatically converts a
RGB to palette index.

Change-Id: Ie66ca8cecff40c1252072ba95196ef65ba787f4c
Reviewed-on: https://gerrit.libreoffice.org/26532
Reviewed-by: TomaÅ¾ Vajngerl 
Tested-by: TomaÅ¾ Vajngerl 
Reviewed-on: https://gerrit.libreoffice.org/26534
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/vcl/opengl/salbmp.cxx b/vcl/opengl/salbmp.cxx
index 87fc542..58909b4 100644
--- a/vcl/opengl/salbmp.cxx
+++ b/vcl/opengl/salbmp.cxx
@@ -412,7 +412,48 @@ void lclInstantiateTexture(OpenGLTexture& rTexture, const 
int nWidth, const int
 rTexture = OpenGLTexture (nWidth, nHeight, nFormat, nType, pData);
 }
 
-}
+// Write color information for 1 and 4 bit palette bitmap scanlines.
+class ScanlineWriter
+{
+BitmapPalette& maPalette;
+sal_uInt8 mnColorsPerByte; // number of colors that are stored in one byte
+sal_uInt8 mnColorBitSize;  // number of bits a color takes
+sal_uInt8 mnColorBitMask;  // bit mask used to isolate the color
+sal_uInt8* mpCurrentScanline;
+long mnX;
+
+public:
+ScanlineWriter(BitmapPalette& aPalette, sal_Int8 nColorsPerByte)
+: maPalette(aPalette)
+, mnColorsPerByte(nColorsPerByte)
+, mnColorBitSize(8 / mnColorsPerByte) // bit size is number of bit in 
a byte divided by number of colors per byte (8 / 2 = 4 for 4-bit)
+, mnColorBitMask((1 << mnColorBitSize) - 1) // calculate the bit mask 
from the bit size
+, mpCurrentScanline(nullptr)
+, mnX(0)
+{}
+
+inline void writeRGB(sal_uInt8 nR, sal_uInt8 nG, sal_uInt8 nB)
+{
+// calculate to which index we will write
+long nScanlineIndex = mnX / mnColorsPerByte;
+
+// calculate the number of shifts to get the color information to the 
right place
+long nShift = (8 - mnColorBitSize) - ((mnX % mnColorsPerByte) * 
mnColorBitSize);
+
+sal_uInt16 nColorIndex = maPalette.GetBestIndex(BitmapColor(nR, nG, 
nB));
+mpCurrentScanline[nScanlineIndex] &= ~(mnColorBitMask << nShift); // 
clear
+mpCurrentScanline[nScanlineIndex] |= (nColorIndex & mnColorBitMask) << 
nShift; // set
+mnX++;
+}
+
+inline void nextLine(sal_uInt8* pScanline)
+{
+mnX = 0;
+mpCurrentScanline = pScanline;
+}
+};
+
+} // end anonymous namespace
 
 Size OpenGLSalBitmap::GetSize() const
 {
@@ -559,43 +600,43 @@ bool OpenGLSalBitmap::ReadTexture()
 #endif
 return true;
 }
-else if (mnBits == 1)
-{   // convert buffers from 24-bit RGB to 1-bit Mask
+else if (mnBits == 1 || mnBits == 4)
+{   // convert buffers from 24-bit RGB to 1 or 4-bit buffer
 std::vector aBuffer(mnWidth * mnHeight * 3);
 
 sal_uInt8* pBuffer = aBuffer.data();
 determineTextureFormat(24, nFormat, nType);
 maTexture.Read(nFormat, nType, pBuffer);
+sal_uInt16 nSourceBytesPerRow = lclBytesPerRow(24, mnWidth);
 
-int nShift = 7;
-size_t nIndex = 0;
-
-sal_uInt8* pCurrent = pBuffer;
+std::unique_ptr pWriter;
+switch(mnBits)
+{
+case 1:
+pWriter.reset(new ScanlineWriter(maPalette, 8));
+break;
+case 4:
+default:
+pWriter.reset(new ScanlineWriter(maPalette, 2));
+break;
+}
 
 for (int y = 0; y < mnHeight; ++y)
 {
+sal_uInt8* pSource = [y * nSourceBytesPerRow];
+sal_uInt8* pDestination = [y * mnBytesPerRow];
+
+pWriter->nextLine(pDestination);
+
 for (int x = 0; x < mnWidth; ++x)
 {
-if (nShift < 0)
-{
-nShift = 7;
-nIndex++;
-

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - framework/source

2016-06-23 Thread Thorsten Behrens

 framework/source/dispatch/interceptionhelper.cxx |   21 ++---
 1 file changed, 14 insertions(+), 7 deletions(-)

New commits:
commit e2cc303ee8bbb0029dd095833ae93d84ec9d73c0
Author: Thorsten Behrens 
Date:   Wed Mar 2 15:28:36 2016 +0100

framework: avoid excessive queryDispatch calls

Make better use of the css::frame::XInterceptorInfo interface, to avoid
calling queryDispatch() pointlessly on interfaces that have explicitely
opted out. Since that already broadcasts which urls we're interested in
- so just don't bother calling entries who are not matching.

Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae
Reviewed-on: https://gerrit.libreoffice.org/25214
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9)
Reviewed-on: https://gerrit.libreoffice.org/26358
Reviewed-by: Katarina Behrens 

diff --git a/framework/source/dispatch/interceptionhelper.cxx 
b/framework/source/dispatch/interceptionhelper.cxx
index ad707f3..fc3db65 100644
--- a/framework/source/dispatch/interceptionhelper.cxx
+++ b/framework/source/dispatch/interceptionhelper.cxx
@@ -54,16 +54,23 @@ css::uno::Reference< css::frame::XDispatch > SAL_CALL 
InterceptionHelper::queryD
 xInterceptor = pIt->xInterceptor;
 
 // b) No match by registration - but a valid interceptor list.
-//Use first interceptor everytimes.
-//Note: it doesn't matter, which direction this helper implementation 
use to ask interceptor objects.
-//Using of member m_aInterceptorList will starts at the beginning 
everytimes.
-//It depends from the filling operation, in which direction it works 
really!
+//Find first interceptor w/o pattern, so we need to query it
 if (!xInterceptor.is() && m_lInterceptionRegs.size()>0)
 {
-pIt  = m_lInterceptionRegs.begin();
-xInterceptor = pIt->xInterceptor;
+InterceptorList::const_iterator pIt2;
+for (pIt2=m_lInterceptionRegs.begin(); 
pIt2!=m_lInterceptionRegs.end(); ++pIt2)
+{
+if (!pIt2->lURLPattern.getLength())
+{
+// no pattern -> need to ask this guy!
+xInterceptor = pIt2->xInterceptor;
+break;
+}
+}
+// if we didn't find any non-pattern interceptor, there's no-one
+// registered for this command url (we already searched for matching
+// patterns above)
 }
-
 // c) No registered interceptor => use our direct slave.
 //This helper exist by design and must be valid everytimes ...
 //But to be more feature proof - we should check that .-)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 79964] "New document" icon is sometimes colored in flat-icon theme Sifr

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=79964

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from Adolfo Jayme  ---
This bug is no longer valid in recent versions of LO. Comment 2’s duplicate
resolution was correct, but whatever,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100460] Can not query sheet cells with annotations

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100460

Caolán McNamara  changed:

   What|Removed |Added

  Component|sdk |Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100460] Can not query sheet cells with annotations

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100460

Caolán McNamara  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected

--- Comment #5 from Caolán McNamara  ---
while I can't bibisect this the change has to be...

commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094
Author: Markus Mohrhard 
Date:   Thu Feb 23 23:36:49 2012 +0100

remove mpNote from ScBaseCell

which removed the sheet::CellFlags::ANNOTATION check

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Pushing to LibO-5-2

2016-06-23 Thread Stephan Bergmann


On 06/21/2016 10:07 PM, Laurent BP wrote:

sberg wrote

All three of the mentioned https://gerrit.libreoffice.org/26117;,
https://gerrit.libreoffice.org/26118;,
https://gerrit.libreoffice.org/26119; refer to
https://bugs.documentfoundation.org/show_bug.cgi?id=94004;


The history of the resolution of this bug is not complete. A first commit
fix it only for polynomial equation, because I wanted to have the smaller
commit (as I thought it was easier for review). This commit was merged to
master before 5-2 branch.
https://bugs.documentfoundation.org/show_bug.cgi?id=94004#c6
Then it takes some time before the 3 other commits for other equation types
were reviewed, and 5-2 was branched. I thought it would not have been a good
idea to have an incomplete feature (wrapping equations if they are too long,
not for all equation types) in LibO 5.2, and I proposed to backport them in
LibO 5.2 beta.

Was I wrong?


Of course, my remarks were of a generic nature, and there may well be 
good reason to do otherwise for specific cases.  I personally have no 
idea about this specific case, though.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/sal include/sfx2 sc/source sd/source sfx2/source sw/inc sw/source

2016-06-23 Thread Miklos Vajna

 include/sal/log-areas.dox  |1 -
 include/sfx2/objsh.hxx |7 ---
 sc/source/ui/docshell/docsh.cxx|4 
 sc/source/ui/inc/docsh.hxx |2 --
 sd/source/ui/docshell/docshell.cxx |4 
 sd/source/ui/inc/DrawDocShell.hxx  |2 --
 sfx2/source/doc/objcont.cxx|5 -
 sw/inc/docsh.hxx   |2 --
 sw/source/uibase/app/docsh.cxx |4 
 9 files changed, 31 deletions(-)

New commits:
commit ed2d342e97e43ff25f450ab6a5752baded6813e4
Author: Miklos Vajna 
Date:   Thu Jun 23 08:47:05 2016 +0200

Remove unused SfxObjectShell::libreOfficeKitCallback()

All clients have been converted to use
SfxViewShell::libreOfficeKitViewCallback() instead.

Change-Id: I793dad5194769f331037b12a1b1afba96ddea4ba
Reviewed-on: https://gerrit.libreoffice.org/26584
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index dd32631..8a6fbdd 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -316,7 +316,6 @@ certain functionality.
 @li @c sfx.doc
 @li @c sfx.notify
 @li @c sfx.sidebar
-@li @c sfx.tiledrendering
 @li @c sfx.view
 
 @section slideshow
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index ee86c34..fd8e710 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -722,13 +722,6 @@ public:
 SAL_DLLPRIVATE void CancelCheckOut( );
 SAL_DLLPRIVATE void CheckIn( );
 SAL_DLLPRIVATE css::uno::Sequence< css::document::CmisVersion > 
GetCmisVersions();
-
-/**
- * Interface shared by document shell. Allow LOK calls from sfx.
- * Default behavior doesn't do anything. relevant SfxObjectShells should 
override
- * the default behavior and implements LOK calls.
- */
-virtual void libreOfficeKitCallback(int nType, const char* pPayload) const;
 };
 
 #define SFX_GLOBAL_CLASSID \
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 12f8b5d..79cb8c8 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -3220,8 +3220,4 @@ bool ScDocShell::GetProtectionHash( /*out*/ 
css::uno::Sequence< sal_Int8 > 
 return bRes;
 }
 
-void ScDocShell::libreOfficeKitCallback(int /*nType*/, const char* 
/*pPayload*/) const
-{
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx
index 84346fb..107c2dc 100644
--- a/sc/source/ui/inc/docsh.hxx
+++ b/sc/source/ui/inc/docsh.hxx
@@ -422,8 +422,6 @@ public:
 virtual boolGetProtectionHash( /*out*/ css::uno::Sequence< sal_Int8 > 
 ) override;
 
 void SnapVisArea( Rectangle& rRect ) const;
-
-virtual void libreOfficeKitCallback(int nType, const char* pPayload) const 
override;
 };
 
 void UpdateAcceptChangesDialog();
diff --git a/sd/source/ui/docshell/docshell.cxx 
b/sd/source/ui/docshell/docshell.cxx
index b948bd9..ccf257c 100644
--- a/sd/source/ui/docshell/docshell.cxx
+++ b/sd/source/ui/docshell/docshell.cxx
@@ -478,10 +478,6 @@ void DrawDocShell::ClearUndoBuffer()
 pUndoManager->Clear();
 }
 
-void DrawDocShell::libreOfficeKitCallback(int /*nType*/, const char* 
/*pPayload*/) const
-{
-}
-
 } // end of namespace sd
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/inc/DrawDocShell.hxx 
b/sd/source/ui/inc/DrawDocShell.hxx
index cc5a8c0..d377abf 100644
--- a/sd/source/ui/inc/DrawDocShell.hxx
+++ b/sd/source/ui/inc/DrawDocShell.hxx
@@ -201,8 +201,6 @@ public:
 
 voidClearUndoBuffer();
 
-virtual void libreOfficeKitCallback(int nType, const char* pPayload) const 
override;
-
 protected:
 
 SdDrawDocument* mpDoc;
diff --git a/sfx2/source/doc/objcont.cxx b/sfx2/source/doc/objcont.cxx
index e5681b8..5192e9e 100644
--- a/sfx2/source/doc/objcont.cxx
+++ b/sfx2/source/doc/objcont.cxx
@@ -651,9 +651,4 @@ bool SfxObjectShell::IsModifyPasswordEntered()
 return pImpl->m_bModifyPasswordEntered;
 }
 
-void SfxObjectShell::libreOfficeKitCallback(int /*nType*/, const char* 
/*pPayload*/) const
-{
-SAL_INFO("sfx.tiledrendering", "SfxObjectShell::libreOfficeKitCallback 
interface not overridden for SfxObjectShell subclass typeId: " << 
typeid(*this).name());
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/inc/docsh.hxx b/sw/inc/docsh.hxx
index cce1600..50ac3c9 100644
--- a/sw/inc/docsh.hxx
+++ b/sw/inc/docsh.hxx
@@ -307,8 +307,6 @@ public:
 virtual voidSetChangeRecording( bool bActivate ) override;
 virtual voidSetProtectionPassword( const OUString  ) 
override;
 virtual boolGetProtectionHash( /*out*/ css::uno::Sequence< sal_Int8 > 
 ) override;
-
-virtual void libreOfficeKitCallback(int nType, const char* pPayload) const 
override;
 };
 
 /** Find the right DocShell and create a new one:
diff --git

[Libreoffice-bugs] [Bug 100559] CUMPRINC function, type parameter

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100559

Winfried Donkers  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |winfrieddonkers@libreoffice
   |desktop.org |.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100542] CUMIPMT function, type parameter

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100542

Winfried Donkers  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |winfrieddonkers@libreoffice
   |desktop.org |.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98675] Template Management is missing

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98675

--- Comment #8 from Ulrich Windl  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #7)
> What do you mean with "printing style properties"? Can you post a screenshot
> of the former functionality?

I'd wish my brain had perfect image memory and I could make digital copies of
those; unfortunately I cannot provide a screenshot when I last used the
feature.
"printing style properties" is the feature to display all the properties set
for all the styles being defined or used in the current document. Preferrably
you can print that document then. Clear now?

(Almost 30 years ago a product named "Ventura Publisher" (running with DOS/GEM)
had that feature, too. And some older OpenOffice had a limited version of that,
too...)

> What should be the output?

A structured document showing (in a preferrably clever way) all the formatting
properties of all styles being defined or used for a document).

> And what is the usecase?

The use case is:
1) Documenting the formatting styles
2) Check the formatting styles for consistency
3) Help product support (=you) with style issues

(In reply to Cor Nouws from comment #1)
The link
https://bugs.documentfoundation.org/buglist.cgi?cmdtype=runnamed_id=598334=TemplateManager
still does not work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97744] OTS open if open another ODS OTS crash

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97744

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Caolán McNamara  ---
Opened an ots, then opened a ods from recently used list, no crash for me.
Maybe this crash only occurs with particular documents or in some particular
sequence, but the steps to reproduce are not sufficient to reproduce for me.

If it still occurs for you try and attach the offending documents and give the
exact steps to reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/xmloff xmloff/source

2016-06-23 Thread Jan Holesovsky

 include/xmloff/SchXMLImportHelper.hxx |3 ++
 xmloff/source/chart/SchXMLAxisContext.cxx |   28 ++--
 xmloff/source/chart/SchXMLChartContext.cxx|   30 +++---
 xmloff/source/chart/SchXMLImport.cxx  |   18 ++-
 xmloff/source/chart/SchXMLLegendContext.cxx   |   10 
 xmloff/source/chart/SchXMLPlotAreaContext.cxx |   27 ++-
 6 files changed, 35 insertions(+), 81 deletions(-)

New commits:
commit 4d1118e5cc9f2a4dc20ea73fba4cb09d9e2a3ce5
Author: Jan Holesovsky 
Date:   Thu Jun 23 10:22:34 2016 +0200

Simplify dynamic_cast followed by a static_cast.

Change-Id: Ia8b1145d43828a40611e5f59651d9dc6ff7d5360

diff --git a/xmloff/source/chart/SchXMLAxisContext.cxx 
b/xmloff/source/chart/SchXMLAxisContext.cxx
index 652e223..41fad4d7 100644
--- a/xmloff/source/chart/SchXMLAxisContext.cxx
+++ b/xmloff/source/chart/SchXMLAxisContext.cxx
@@ -465,17 +465,13 @@ void SchXMLAxisContext::CreateAxis()
 if( !m_aAutoStyleName.isEmpty())
 {
 const SvXMLStylesContext* pStylesCtxt = 
m_rImportHelper.GetAutoStylesContext();
-if( pStylesCtxt )
+if (pStylesCtxt)
 {
-const SvXMLStyleContext* pStyle = 
pStylesCtxt->FindStyleChildContext(
-SchXMLImportHelper::GetChartFamilyID(), m_aAutoStyleName );
+SvXMLStyleContext* pStyle = 
const_cast(pStylesCtxt->FindStyleChildContext(SchXMLImportHelper::GetChartFamilyID(),
 m_aAutoStyleName));
 
-if( pStyle && dynamic_cast( 
pStyle) !=  nullptr)
+if (XMLPropStyleContext * pPropStyleContext = 
dynamic_cast(pStyle))
 {
-// note: SvXMLStyleContext::FillPropertySet is not const
-XMLPropStyleContext * pPropStyleContext = const_cast< 
XMLPropStyleContext * >( dynamic_cast< const XMLPropStyleContext * >( pStyle ));
-if( pPropStyleContext )
-pPropStyleContext->FillPropertySet( m_xAxisProps );
+pPropStyleContext->FillPropertySet(m_xAxisProps);
 
 if( m_bAdaptWrongPercentScaleValues && 
m_aCurrentAxis.eDimension==SCH_XML_AXIS_Y )
 {
@@ -498,7 +494,7 @@ void SchXMLAxisContext::CreateAxis()
 if( xAxisSuppl.is() )
 {
 Reference< beans::XPropertySet > xXAxisProp( 
xAxisSuppl->getAxis(0), uno::UNO_QUERY );
-const_cast( static_cast< 
const XMLPropStyleContext* >( pStyle ))->FillPropertySet( xXAxisProp );
+pPropStyleContext->FillPropertySet(xXAxisProp);
 }
 
 //set scale data of added x axis back to default
commit a07a69850acddae631d6bd9496ace0c35accdda5
Author: Jan Holesovsky 
Date:   Thu Jun 23 10:18:35 2016 +0200

Introduce FillAutoStyle() method to reduce copy'n'paste.

Change-Id: Ibdb6ae15790cc117d3d8c41c57924f9b22e85cba

diff --git a/include/xmloff/SchXMLImportHelper.hxx 
b/include/xmloff/SchXMLImportHelper.hxx
index 415a9a0..765a960 100644
--- a/include/xmloff/SchXMLImportHelper.hxx
+++ b/include/xmloff/SchXMLImportHelper.hxx
@@ -100,6 +100,9 @@ public:
 void SetAutoStylesContext( SvXMLStylesContext* pAutoStyles ) { 
mpAutoStyles = pAutoStyles; }
 SvXMLStylesContext* GetAutoStylesContext() const { return mpAutoStyles; }
 
+/// Fill in the autostyle.
+void FillAutoStyle(const OUString& rAutoStyleName, const 
css::uno::Reference& rProp);
+
 const css::uno::Reference< css::chart::XChartDocument >& GetChartDocument()
 { return mxChartDoc; }
 
diff --git a/xmloff/source/chart/SchXMLAxisContext.cxx 
b/xmloff/source/chart/SchXMLAxisContext.cxx
index 9feded2..652e223 100644
--- a/xmloff/source/chart/SchXMLAxisContext.cxx
+++ b/xmloff/source/chart/SchXMLAxisContext.cxx
@@ -219,18 +219,8 @@ void SchXMLAxisContext::CreateGrid( const OUString& 
sAutoStyleName, bool bIsMajo
 // the line color is black as default, in the model it is a light gray
 xGridProp->setPropertyValue("LineColor",
  uno::makeAny( COL_BLACK ));
-if( !sAutoStyleName.isEmpty())
-{
-const SvXMLStylesContext* pStylesCtxt = 
m_rImportHelper.GetAutoStylesContext();
-if( pStylesCtxt )
-{
-const SvXMLStyleContext* pStyle = 
pStylesCtxt->FindStyleChildContext(
-SchXMLImportHelper::GetChartFamilyID(), sAutoStyleName );
-
-if( pStyle && dynamic_cast( 
pStyle) !=  nullptr)
-const_cast( static_cast< const 
XMLPropStyleContext* >( pStyle ))->FillPropertySet( xGridProp );
-}
-}
+if (!sAutoStyleName.isEmpty())

[Libreoffice-commits] core.git: sd/qa

2016-06-23 Thread Vasily Melenchuk

 sd/qa/unit/sdmodeltestbase.hxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 535ac37c5ff9b9dc60f6f56e4cfd518eff764975
Author: Vasily Melenchuk 
Date:   Mon Jun 20 16:30:58 2016 +0300

support for ms binary format validation in sd module export tests

Change-Id: Ie03b0485bbe8ecaa452f19fbcbfe3bf5829aff68
Reviewed-on: https://gerrit.libreoffice.org/26515
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sd/qa/unit/sdmodeltestbase.hxx b/sd/qa/unit/sdmodeltestbase.hxx
index edf11f9..0b7e3be 100644
--- a/sd/qa/unit/sdmodeltestbase.hxx
+++ b/sd/qa/unit/sdmodeltestbase.hxx
@@ -204,6 +204,10 @@ protected:
 {
 BootstrapFixture::validate(pTempFile->GetFileName(), test::OOXML);
 }
+else if(nExportType == PPT)
+{
+BootstrapFixture::validate(pTempFile->GetFileName(), 
test::MSBINARY);
+}
 pTempFile->EnableKillingFile();
 return loadURL(pTempFile->GetURL(), nExportType);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

GSoC Week 4 : Area Fill

2016-06-23 Thread Rishabh Kumar

Hi,

Last week I completed the following tasks -

1. Created a new pattern tab - http://imgur.com/Jjmuc35

2. Moved bitmap controls from Area tab - http://imgur.com/CWaK5pP

3. Multiple color palettes in color dialog - http://imgur.com/ZPsy9zO

Work planned for this week -

1. Make changes and merge the commits https://gerrit.libreoffice.org/26015 and
https://gerrit.libreoffice.org/26402 to master.

2. Move all the fill style tabs inside the area tab

Warm Regards
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 63994] Calc Multiline Input: Allow creating new line with Shift-Return

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=63994

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #19 from Samuel Mehrbrodt (CIB)  ---
Closing now, please create a new bug and cc me if any issues arise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 99706] General input/output error when open xlx file

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99706

--- Comment #10 from Aron Budea  ---
I dug up the comments I thought of, and based my suggestion on.
Same bisect results as here:
https://bugs.documentfoundation.org/show_bug.cgi?id=100104#c9

Tomaz's response:
https://bugs.documentfoundation.org/show_bug.cgi?id=100104#c12

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66896] FILEOPEN: Recent_Documents doesn't know the ODC-files.

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=66896

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||samuel.mehrbr...@cib.de
 Resolution|--- |WORKSFORME

--- Comment #4 from Samuel Mehrbrodt (CIB)  ---
Seems to be fixed (tried in 5.0.7).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svtools/source

2016-06-23 Thread Caolán McNamara

 svtools/source/misc/ehdl.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit d531743ca34232aedc0b437a9ff5807dea8d51ed
Author: CaolÃ¡n McNamara 
Date:   Thu Jun 23 09:41:40 2016 +0100

VclPtr: svtools error message dialog doesn't dispose

Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2

diff --git a/svtools/source/misc/ehdl.cxx b/svtools/source/misc/ehdl.cxx
index 09fa9c4..3534f50 100644
--- a/svtools/source/misc/ehdl.cxx
+++ b/svtools/source/misc/ehdl.cxx
@@ -137,6 +137,7 @@ static sal_uInt16 aWndFunc(
 SAL_WARN( "svtools.misc", "Unknown MessBox return value" );
 break;
 }
+pBox.disposeAndClear();
 return nRet;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 100550] Adding standard colours to “Font Colour” and “Background Colour” menus

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100550

--- Comment #4 from hakan  ---
Created attachment 125854
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125854=edit
Google Docs - Colour Palette

Google Docs are the same color bar also there. See image 3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100550] Adding standard colours to “Font Colour” and “Background Colour” menus

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100550

--- Comment #4 from hakan  ---
Created attachment 125854
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125854=edit
Google Docs - Colour Palette

Google Docs are the same color bar also there. See image 3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

--- Comment #11 from Caolán McNamara  ---
Created attachment 125853
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125853=edit
this fixes the hang and brings us back to corrupting the output

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99706] General input/output error when open xlx file

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99706

--- Comment #9 from Michael Meeks  ---
Tomaz - can you have a quick look ? looks v. unlikely to be CL related - but -
perhaps there is some nasty at this commit that fools the bisection (?).

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91807] Writer crashes when saving (OS X) or gives "write error" then saves corrupt file (Win 8)

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91807

--- Comment #10 from Caolán McNamara  ---
The hang started with

7e2ea27e5d56f5cf767a6718a0f5edc28e24af14

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100559] New: CUMPRINC function, type parameter

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100559

Bug ID: 100559
   Summary: CUMPRINC function, type parameter
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: r...@post.cz

ODF specification: 6.12.12 CUMPRINC
Summary: Calculates a cumulative principal payment.
Syntax: CUMPRINC( Number rate ; Number periods ; Number value ; Integer start ;
Integer end ; Integer type )
Returns: Currency
Constraints: type is one of the following values: 0, 1


=CUMPRINC(0,055/12;24;5000;4;6;-1)
=CUMPRINC(0,055/12;24;5000;4;6;)
should return error. Last parameter is mandatory and allowed 0 or 1.

Checked in excel and excel return in both cases error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSoC Week 4: Redesigning the Template Manager

2016-06-23 Thread Akshay Deep

Hello,
I'm working with on the Template Manager as my GSoC project.
(Mentors: Samuel
Mehrbrodt and Yousuf Philips)

Last week, I fixed some bugs and enhancement requests in start center. I
worked on few remaining parts of my project. I am also working on a writer
enhancement (GotoPage Dialog),

Patches :
https://gerrit.libreoffice.org/#/q/owner:akshaydeepiitr%2540gmail.com

This week, I'll provide the documentation team with the list of changes
I've done to template manager and will continue with the other tasks.

Regards,
Akshay
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 100550] Adding standard colours to “Font Colour” and “Background Colour” menus

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100550

--- Comment #3 from hakan  ---
Created attachment 125852
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125852=edit
MS Office - Colour Palette

MS Office has said exactly what I mean. See the attached picture.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100550] Adding standard colours to “Font Colour” and “Background Colour” menus

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100550

--- Comment #3 from hakan  ---
Created attachment 125852
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125852=edit
MS Office - Colour Palette

MS Office has said exactly what I mean. See the attached picture.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 95292] Mail merge does not print the last record when having odd records

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95292

Buovjaga  changed:

   What|Removed |Added

   Keywords|regression  |
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME
 Whiteboard|target:5.2.0|backportRequest:5.1

--- Comment #26 from Buovjaga  ---
Closing and adding backport request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98491] Split hsqldb Base application will not start under OSX10.11.x causes LO to freeze requiring force kill

2016-06-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98491

Alex Thurgood  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

< 1 2 3 4 >

201 - 300 of 324 matches

Mail list logo