[Libreoffice-bugs] [Bug 105982] Print Preview: Cells are intertwined.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105982

--- Comment #5 from Gülşah Köse  ---
Created attachment 131201
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131201=edit
Thats is last problematic file.

The first problematic file was wrong file, sorry. All cells must be optimal
height. I've add last problematic file.

By the way user profile reseted. Problem is going on. Lang: tr-TR

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105996] some german menu entries although user interface language is set to english

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105996

dieterp  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from dieterp  ---
I can't conform this problem in Win10 x64.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/tools rsc/inc rsc/source tools/source

[Noel Grandin]

 include/tools/rcid.h|   14 +++---
 include/tools/resid.hxx |   16 +---
 include/tools/resmgr.hxx|2 +-
 rsc/inc/rscarray.hxx|4 ++--
 rsc/inc/rscclass.hxx|6 +++---
 rsc/inc/rscconst.hxx|5 +++--
 rsc/inc/rsccont.hxx |8 
 rsc/inc/rscflag.hxx |4 ++--
 rsc/inc/rscmgr.hxx  |2 +-
 rsc/inc/rscrange.hxx|   10 +-
 rsc/inc/rscstr.hxx  |2 +-
 rsc/inc/rsctop.hxx  |3 ++-
 rsc/source/parser/rscdb.cxx |8 
 rsc/source/res/rscarray.cxx |4 ++--
 rsc/source/res/rscclass.cxx |6 +++---
 rsc/source/res/rscconst.cxx |4 ++--
 rsc/source/res/rsccont.cxx  |8 
 rsc/source/res/rscflag.cxx  |4 ++--
 rsc/source/res/rscmgr.cxx   |2 +-
 rsc/source/res/rscrange.cxx |   10 +-
 rsc/source/res/rscstr.cxx   |2 +-
 rsc/source/res/rsctop.cxx   |2 +-
 tools/source/rc/resmgr.cxx  |   10 +-
 23 files changed, 70 insertions(+), 66 deletions(-)

New commits:
commit 2b70fb58be039fbd05ea833a40b1b3e9f922e45c
Author: Noel Grandin 
Date:   Mon Feb 13 19:09:17 2017 +0200

Use o3tl::strong_int on RESOURCE_TYPE

Change-Id: I42690c07a611e031963ff41942f530af4a5c672a
Reviewed-on: https://gerrit.libreoffice.org/34220
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/include/tools/rcid.h b/include/tools/rcid.h
index 8a58f66..6c6cbf4f 100644
--- a/include/tools/rcid.h
+++ b/include/tools/rcid.h
@@ -30,15 +30,15 @@
 // Resource types
 // Minimum is 0x100 due to MS-Windows resource types
 // (RSC_NOTYPE=0x100) is defined in resid.hxx
-#define RSC_VERSIONCONTROL  (RSC_NOTYPE + 0x02) // Version control
+#define RSC_VERSIONCONTROL  (RSC_NOTYPE + RESOURCE_TYPE(0x02)) // Version 
control
 
-#define RSC_RESOURCE(RSC_NOTYPE + 0x10)
-#define RSC_STRING  (RSC_NOTYPE + 0x11)
-#define RSC_BITMAP  (RSC_NOTYPE + 0x13)
-#define RSC_MENU(RSC_NOTYPE + 0x1c)
-#define RSC_MENUITEM(RSC_NOTYPE + 0x1d) // only used internally
+#define RSC_RESOURCE(RSC_NOTYPE + RESOURCE_TYPE(0x10))
+#define RSC_STRING  (RSC_NOTYPE + RESOURCE_TYPE(0x11))
+#define RSC_BITMAP  (RSC_NOTYPE + RESOURCE_TYPE(0x13))
+#define RSC_MENU(RSC_NOTYPE + RESOURCE_TYPE(0x1c))
+#define RSC_MENUITEM(RSC_NOTYPE + RESOURCE_TYPE(0x1d)) // only 
used internally
 
-#define RSC_STRINGARRAY (RSC_NOTYPE + 0x79)
+#define RSC_STRINGARRAY (RSC_NOTYPE + RESOURCE_TYPE(0x79))
 
 // (RSC_NOTYPE + 0x200) - (RSC_NOTYPE + 0x300) reserved for Sfx
 
diff --git a/include/tools/resid.hxx b/include/tools/resid.hxx
index 480f5b7..53a229b 100644
--- a/include/tools/resid.hxx
+++ b/include/tools/resid.hxx
@@ -24,10 +24,12 @@
 #include 
 #include 
 #include 
+#include 
 
 struct RSHEADER_TYPE;
-typedef sal_uInt32 RESOURCE_TYPE;
-#define RSC_NOTYPE  0x100
+struct RESOURCE_TYPE_Tag {};
+typedef o3tl::strong_int RESOURCE_TYPE;
+#define RSC_NOTYPE  RESOURCE_TYPE(0x100)
 #define RSC_DONTRELEASE (sal_uInt32(1U << 31))
 
 class ResMgr;
@@ -45,11 +47,11 @@ class SAL_WARN_UNUSED ResId
 release the Resource context after loading this id.
 */
 RSHEADER_TYPE*  m_pResource;
-mutable sal_uInt32  m_nResId;  // Resource Identifier
+mutable RESOURCE_TYPE   m_nResId;  // Resource Identifier
 mutable RESOURCE_TYPE   m_nRT; // type for loading (mutable to be 
set later)
 mutable ResMgr *m_pResMgr; // load from this ResMgr (mutable 
for setting on demand)
 
-void ImplInit( sal_uInt32 nId, ResMgr& rMgr, RSHEADER_TYPE* pRes )
+void ImplInit( RESOURCE_TYPE nId, ResMgr& rMgr, RSHEADER_TYPE* pRes )
 {
 m_pResource = pRes; m_nResId = nId; m_nRT = RSC_NOTYPE; m_pResMgr = 

 OSL_ENSURE( m_pResMgr != nullptr, "ResId without ResMgr created" );
@@ -60,7 +62,7 @@ public:
 {
 ImplInit( 0, rMgr, pRc );
 }
-ResId( sal_uInt32 nId, ResMgr& rMgr )
+ResId( RESOURCE_TYPE nId, ResMgr& rMgr )
 {
 ImplInit( nId, rMgr, nullptr );
 }
@@ -87,9 +89,9 @@ public:
 ResMgr *GetResMgr() const { return m_pResMgr; }
 voidClearResMgr() const { m_pResMgr = nullptr; }
 
-boolIsAutoRelease()  const { return !(m_nResId & 
RSC_DONTRELEASE); }
+boolIsAutoRelease()  const { return !(sal_uInt32(m_nResId) & 
RSC_DONTRELEASE); }
 
-sal_uInt32  GetId()  const { return m_nResId & 
~RSC_DONTRELEASE; }
+sal_uInt32  GetId()  const { return sal_uInt32(m_nResId) & 
~RSC_DONTRELEASE; }
 RSHEADER_TYPE*  GetpResource()   const { return m_pResource; }
 
 TOOLS_DLLPUBLIC OUString toString() const;
diff --git 

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang include/svx svx/source

[Noel Grandin]

 compilerplugins/clang/unusedenumconstants.py |1 +
 include/svx/sidebar/SelectionAnalyzer.hxx|1 -
 include/svx/svdview.hxx  |1 -
 svx/source/sidebar/SelectionAnalyzer.cxx |5 -
 svx/source/svdraw/svdview.cxx|1 -
 5 files changed, 1 insertion(+), 8 deletions(-)

New commits:
commit ed8773a201bc4954050b87f6d2952525831d3499
Author: Noel Grandin 
Date:   Mon Feb 13 14:52:42 2017 +0200

remove unused Outline enumerator from SelectionAnalyzer::ViewType enum

Change-Id: I256318046b10f6a75542d5cbf4560bb99a6dfff6
Reviewed-on: https://gerrit.libreoffice.org/34239
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/sidebar/SelectionAnalyzer.hxx 
b/include/svx/sidebar/SelectionAnalyzer.hxx
index c4ed2fa..d1aebbc 100644
--- a/include/svx/sidebar/SelectionAnalyzer.hxx
+++ b/include/svx/sidebar/SelectionAnalyzer.hxx
@@ -45,7 +45,6 @@ public:
 Master,
 Handout,
 Notes,
-Outline
 };
 static vcl::EnumContext::Context GetContextForSelection_SD (
 const SdrMarkList& rMarkList,
diff --git a/svx/source/sidebar/SelectionAnalyzer.cxx 
b/svx/source/sidebar/SelectionAnalyzer.cxx
index 7ee232f..4598667 100644
--- a/svx/source/sidebar/SelectionAnalyzer.cxx
+++ b/svx/source/sidebar/SelectionAnalyzer.cxx
@@ -117,9 +117,6 @@ EnumContext::Context 
SelectionAnalyzer::GetContextForSelection_SD (
 case ViewType::Notes:
 eContext = EnumContext::Context::NotesPage;
 break;
-case ViewType::Outline:
-eContext = EnumContext::Context::OutlineText;
-break;
 }
 break;
 
@@ -297,8 +294,6 @@ EnumContext::Context 
SelectionAnalyzer::GetContextForObjectId_SD (
 return EnumContext::Context::HandoutPage;
 case ViewType::Notes:
 return EnumContext::Context::NotesPage;
-case ViewType::Outline:
-return EnumContext::Context::OutlineText;
 default:
 return EnumContext::Context::Unknown;
 }
commit 251decd3205af54772780240849b828984e16a6a
Author: Noel Grandin 
Date:   Mon Feb 13 11:51:28 2017 +0200

remove unused BrkAction enumerator from SdrEventKind

Change-Id: I46c50bbbad5d269b7f15e041db115fa7f37a8168
Reviewed-on: https://gerrit.libreoffice.org/34205
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.py 
b/compilerplugins/clang/unusedenumconstants.py
index e706c18..856a84e 100755
--- a/compilerplugins/clang/unusedenumconstants.py
+++ b/compilerplugins/clang/unusedenumconstants.py
@@ -139,6 +139,7 @@ for d in definitionSet:
  "include/vcl/print.hxx", # NupOrderType, from UI combobox
  "sw/source/uibase/inc/swcont.hxx", # RegionMode, from UI; 
ContentTypeId, from UI(registry)
  "sw/inc/toxe.hxx", # ToxAuthorityType (from UI)
+ "include/svx/sxekitm.hxx", # SdrEdgeKind (from UI)
 # represents constants from an external API
  "opencl/inc/opencl_device_selection.h",
  "vcl/inc/sft.hxx",
diff --git a/include/svx/svdview.hxx b/include/svx/svdview.hxx
index a161157..3caee8e 100644
--- a/include/svx/svdview.hxx
+++ b/include/svx/svdview.hxx
@@ -66,7 +66,6 @@ enum class SdrEventKind {
 MoveAction,
 EndAction,
 BackAction,
-BrkAction,
 EndCreate,
 EndDrag,
 MarkObj,
diff --git a/svx/source/svdraw/svdview.cxx b/svx/source/svdraw/svdview.cxx
index 3b602c5..2ee34fc 100644
--- a/svx/source/svdraw/svdview.cxx
+++ b/svx/source/svdraw/svdview.cxx
@@ -789,7 +789,6 @@ bool SdrView::DoMouseEvent(const SdrViewEvent& rVEvt)
 case SdrEventKind::MoveAction: MovAction(aLogicPos); bRet=true; break;
 case SdrEventKind::EndAction: EndAction(); bRet=true; break;
 case SdrEventKind::BackAction: BckAction(); bRet=true; break;
-case SdrEventKind::BrkAction: BrkAction(); bRet=true; break;
 case SdrEventKind::EndMark  : EndAction(); bRet=true; break;
 case SdrEventKind::BrkMark  : {
 BrkAction();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105979] Glyph outlines are corrupted in exported PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105979

Pavel  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Pavel  ---
The issue is present regardless of OpenGL and hardware acceleration settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103967] DOC import: Empty table cell has wrong font size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103967

--- Comment #7 from Justin L  ---
Created attachment 131200
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131200=edit
tdf103967_minimal.doc: minimal version of doc from Comment 5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105996] New: some german menu entries although user interface language is set to english

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105996

Bug ID: 105996
   Summary: some german menu entries although user interface
language is set to english
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bordfe...@web.de

Description:
some german menu entries although user interface language is set to english
(locale setting is german)

Steps to Reproduce:
1. open LO
2. open the file menu
3. see some german entries

Actual Results:  
some german menu entries although user interface language is set to english

Expected Results:
all menu entries should be in the selected user interface language


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103967] DOC import: Empty table cell has wrong font size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103967

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4616

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104616] FILEOPEN DOC: Text which should be above the floating tables isn't properly located

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104616

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3967

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105761] it takes longer time to open documents from file explorer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105761

--- Comment #3 from Ljiljan  ---
In my case, I discovered that libreoffice-gtk3 when removed the problem does
not exist. So I believe this problem is only Gnome-specific issue. People using
other Linux distributions or Windows users should not experience this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105712] With NVDA active launching Special Character dialog using Insert -> Special Character, or via F7 Spell check causes a fatal error. With using Standard Toolbar button it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105712

V Stuart Foote  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||fdb...@neosheffield.co.uk,
   ||mst...@redhat.com,
   ||noelgran...@gmail.com,
   ||sleeping.pil...@gmail.com
Version|5.0.6.3 release |5.0.0.5 release

--- Comment #19 from V Stuart Foote  ---
from builds on hand, bisected the LO crash on launch of Special Character
dialog down to between 2015-05-10 and 2015-05-15 so between 5.0.0.0alpha1+ and
5.0.0.0beta1

Simple STR of running NVDA and creating a new Writer document. Type anything so
not a blank line, and then Insert -> Special Character to launch the dialog.

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=2796bc31e90c87cee10d832a67b1fd9dcab6e51f..9d0c51daea67104349cac26de9839afa8baeb099

could still use a tighter bibisect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx svx/source

[Noel Grandin]

 include/svx/sidebar/ValueSetWithTextControl.hxx  |   13 -
 svx/source/sidebar/tools/ValueSetWithTextControl.cxx |   46 +++
 2 files changed, 8 insertions(+), 51 deletions(-)

New commits:
commit 8593cd238cd049ecf9036833d5c83aad23082e26
Author: Noel Grandin 
Date:   Mon Feb 13 14:38:41 2017 +0200

remove unused ValueSetWithTextControl::ControlType enum

since we only ever use the TextText enumerator

Change-Id: Idfb96ad6ea3461e886439df33695be2d8dcebef9
Reviewed-on: https://gerrit.libreoffice.org/34211
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/sidebar/ValueSetWithTextControl.hxx 
b/include/svx/sidebar/ValueSetWithTextControl.hxx
index 619c77a..d21ccce 100644
--- a/include/svx/sidebar/ValueSetWithTextControl.hxx
+++ b/include/svx/sidebar/ValueSetWithTextControl.hxx
@@ -38,19 +38,8 @@ namespace svx { namespace sidebar {
 class SVX_DLLPUBLIC ValueSetWithTextControl : public ValueSet
 {
 public:
-// control type of specialized :
-// - image + text
-// - text + text
-enum class ControlType
-{
-ImageText,
-TextText
-};
-
 ValueSetWithTextControl(Window* pParent, WinBits nBits);
 
-// add item for control type TEXT_TEXT
-// if control type does not match TEXT_TEXT no item is added.
 void AddItem(
 const OUString& rItemText,
 const OUString& rItemText2 );
@@ -67,8 +56,6 @@ private:
 };
 
 typedef ::std::vector< ValueSetWithTextItem > tItemList;
-
-const ControlType meControlType;
 tItemList maItems;
 };
 
diff --git a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx 
b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
index 1d8f887..7f18341 100644
--- a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
+++ b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
@@ -32,7 +32,6 @@ namespace svx { namespace sidebar {
 
 ValueSetWithTextControl::ValueSetWithTextControl(Window* pParent, WinBits 
nBits)
 : ValueSet( pParent, nBits )
-, meControlType( 
svx::sidebar::ValueSetWithTextControl::ControlType::TextText )
 {
 SetColCount();
 }
@@ -42,11 +41,6 @@ void ValueSetWithTextControl::AddItem(
 const OUString& rItemText,
 const OUString& rItemText2 )
 {
-if ( meControlType != ControlType::TextText )
-{
-return;
-}
-
 ValueSetWithTextItem aItem;
 aItem.maItemText = rItemText;
 aItem.maItemText2 = rItemText2;
@@ -65,7 +59,6 @@ void ValueSetWithTextControl::UserDraw( const UserDrawEvent& 
rUDEvt )
 const sal_uInt16 nItemId = rUDEvt.GetItemId();
 
 const long nRectHeight = aRect.GetHeight();
-const Point aBLPos = aRect.TopLeft();
 
 vcl::Font aFont(OutputDevice::GetDefaultFont(DefaultFontType::UI_SANS, 
MsLangId::getSystemLanguage(), GetDefaultFontFlags::OnlyOne));
 {
@@ -90,50 +83,27 @@ void ValueSetWithTextControl::UserDraw( const 
UserDrawEvent& rUDEvt )
 pDev->DrawRect(aRect);
 }
 
-//draw image + text resp. text + text
-Image* pImage = nullptr;
 if ( GetSelectItemId() == nItemId )
 {
 aFont.SetColor( sfx2::sidebar::Theme::GetColor( 
sfx2::sidebar::Theme::Color_HighlightText ) );
-pImage = [nItemId-1].maSelectedItemImage;
 }
 else
 {
 aFont.SetColor( 
GetSettings().GetStyleSettings().GetFieldTextColor() );
-pImage = [nItemId-1].maItemImage;
 }
 
 Rectangle aStrRect = aRect;
 aStrRect.Top() += nRectHeight/4;
 aStrRect.Bottom() -= nRectHeight/4;
 
-switch ( meControlType )
-{
-case ControlType::ImageText:
-{
-Point aImgStart(
-aBLPos.X() + 4,
-aBLPos.Y() + ( ( nRectHeight - 
pImage->GetSizePixel().Height() ) / 2 ) );
-pDev->DrawImage( aImgStart, *pImage );
-
-aStrRect.Left() += pImage->GetSizePixel().Width() + 12;
-pDev->SetFont(aFont);
-pDev->DrawText(aStrRect, maItems[nItemId-1].maItemText, 
DrawTextFlags::EndEllipsis);
-}
-break;
-case ControlType::TextText:
-{
-const long nRectWidth = aRect.GetWidth();
-aStrRect.Left() += 8;
-aStrRect.Right() -= (nRectWidth*2)/3;
-pDev->SetFont(aFont);
-pDev->DrawText(aStrRect, maItems[nItemId-1].maItemText, 
DrawTextFlags::EndEllipsis);
-aStrRect.Left() += nRectWidth/3;
-aStrRect.Right() += (nRectWidth*2)/3;
-pDev->DrawText(aStrRect, maItems[nItemId-1].maItemText2, 
DrawTextFlags::EndEllipsis);
-}
-break;
-}
+const long nRectWidth = aRect.GetWidth();
+aStrRect.Left() += 8;
+aStrRect.Right() -= (nRectWidth*2)/3;
+

[Libreoffice-commits] core.git: 5 commits - include/svx svx/source

[Noel Grandin]

 include/svx/svdhdl.hxx |1 -
 include/svx/svdmodel.hxx   |1 -
 include/svx/svdoashp.hxx   |1 -
 include/svx/svdobj.hxx |1 -
 include/svx/svdpage.hxx|1 -
 include/svx/svdtypes.hxx   |1 -
 svx/source/engine3d/view3d.cxx |1 -
 svx/source/form/fmpage.cxx |2 +-
 svx/source/svdraw/svddrgv.cxx  |4 ++--
 svx/source/svdraw/svdedxv.cxx  |6 --
 svx/source/svdraw/svdhdl.cxx   |   11 ++-
 svx/source/svdraw/svdoashp.cxx |   29 -
 svx/source/svdraw/svdobj.cxx   |4 
 svx/source/svdraw/svdview.cxx  |2 +-
 14 files changed, 6 insertions(+), 59 deletions(-)

New commits:
commit 93837254b7085c6632d76244d9ac466503ef47e0
Author: Noel Grandin 
Date:   Mon Feb 13 14:11:10 2017 +0200

remove unused GlueDeselected enumerator from SdrHdlKind enum

Change-Id: Ie55ca0fd04bd7cc9c781faca6ebbf642518b2194
Reviewed-on: https://gerrit.libreoffice.org/34210
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx
index 5725be1..413164c 100644
--- a/include/svx/svdhdl.hxx
+++ b/include/svx/svdhdl.hxx
@@ -67,7 +67,6 @@ enum class SdrHdlKind
 Ref2,   // Reference point 2, e.g. endpoint of mirror axis
 MirrorAxis, // Mirror axis
 Glue,   // GluePoint
-GlueDeselected, // GluePoint
 Anchor, // Anchor symbol (SD, SW)
 Transparence,   // Interactive transparence
 Gradient,   // Interactive gradient
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index c8e89cb..174b964 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -507,11 +507,6 @@ void SdrHdl::CreateB2dIAObject()
 eKindOfMarker = BitmapMarkerKind::Glue;
 break;
 }
-case SdrHdlKind::GlueDeselected:
-{
-eKindOfMarker = BitmapMarkerKind::Glue_Deselected;
-break;
-}
 case SdrHdlKind::Anchor:
 {
 eKindOfMarker = BitmapMarkerKind::Anchor;
@@ -1018,7 +1013,6 @@ Pointer SdrHdl::GetPointer() const
 case SdrHdlKind::Ref2 : ePtr=PointerStyle::RefHand;   break;
 case SdrHdlKind::BezierWeight : 
ePtr=PointerStyle::MoveBezierWeight; break;
 case SdrHdlKind::Glue : ePtr=PointerStyle::MovePoint; break;
-case SdrHdlKind::GlueDeselected : 
ePtr=PointerStyle::MovePoint; break;
 case SdrHdlKind::CustomShape1 : ePtr=PointerStyle::Hand; break;
 default:
 break;
@@ -1055,7 +1049,6 @@ bool SdrHdl::IsFocusHdl() const
 case SdrHdlKind::Ref1:  // reference point 1, e. g. center of 
rotation
 case SdrHdlKind::Ref2:  // reference point 2, e. g. endpoint of 
reflection axis
 case SdrHdlKind::Glue:  // glue point
-case SdrHdlKind::GlueDeselected:  // deselected glue point, used 
to be a little blue cross
 
 // for SJ and the CustomShapeHandles:
 case SdrHdlKind::CustomShape1:
@@ -1836,11 +1829,11 @@ static bool ImpSdrHdlListSorter(SdrHdl* const& lhs, 
SdrHdl* const& rhs)
 if (eKind1!=eKind2)
 {
 if (eKind1==SdrHdlKind::Ref1 || eKind1==SdrHdlKind::Ref2 || 
eKind1==SdrHdlKind::MirrorAxis) n1=5;
-else if (eKind1==SdrHdlKind::Glue || 
eKind1==SdrHdlKind::GlueDeselected) n1=2;
+else if (eKind1==SdrHdlKind::Glue) n1=2;
 else if (eKind1==SdrHdlKind::User) n1=3;
 else if (eKind1==SdrHdlKind::SmartTag) n1=0;
 if (eKind2==SdrHdlKind::Ref1 || eKind2==SdrHdlKind::Ref2 || 
eKind2==SdrHdlKind::MirrorAxis) n2=5;
-else if (eKind2==SdrHdlKind::Glue || 
eKind2==SdrHdlKind::GlueDeselected) n2=2;
+else if (eKind2==SdrHdlKind::Glue) n2=2;
 else if (eKind2==SdrHdlKind::User) n2=3;
 else if (eKind2==SdrHdlKind::SmartTag) n2=0;
 }
commit df49f966fad67992ceedc755993c560eaf3148d6
Author: Noel Grandin 
Date:   Mon Feb 13 13:43:09 2017 +0200

remove unused ModelSaved enumerator from SdrHintKind enum

Change-Id: I0a236705efdcbc5f44cad8517f7f8f80d326934d
Reviewed-on: https://gerrit.libreoffice.org/34209
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index d2b4ef8..e53a422 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -114,7 +114,6 @@ enum class SdrHintKind
 RefDeviceChange,  // RefDevice changed
 DefaultTabChange, // Default tabulator width changed
 DefaultFontHeightChange,   // Default FontHeight changed
-ModelSaved,// Document was saved
 SwitchToPage,  // #94278# UNDO/REDO at an object evtl. on 

[Libreoffice-bugs] [Bug 105960] Can not select properly a custom page size for printing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105960

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #11 from Buovjaga  ---
Yep, let's close.

*** This bug has been marked as a duplicate of bug 94343 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94343] UI: Move "Use only paper size from printer preferences" from tab Options to printer properties dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94343

Buovjaga  changed:

   What|Removed |Added

 CC||franciscoadriansanchez@gmai
   ||l.com

--- Comment #17 from Buovjaga  ---
*** Bug 105960 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104813] FILEOPEN: DOC: performance regression at import time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104813

Buovjaga  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104813] FILEOPEN: DOC: performance regression at import time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104813

--- Comment #13 from Buovjaga  ---
Created attachment 131199
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131199=edit
Callgrind output from 5.4

Thanks to the auto-closing option, I now got a useful callgrind.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: ac8197327d3ef4f3c94fb0746393863404df086b
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on February 11th 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105995] New: Base problem with editing a form and Control panel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105995

Bug ID: 105995
   Summary: Base problem with editing a form and Control panel
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rongraham1...@rogers.com

Created attachment 131198
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131198=edit
2 .jpgs of the Control panel showing missing options

EDITING

Problem came up when I downloaded LO 5.3.0.3 on my new Dell PC with Windows 10.
I started to design a database on my old PC using LO 5.2.5.1 Win 7 and
transferred the Base files to my Dell. 

I was editing a form in 5.3.0.3 and I noticed that some options were missing in
the Control panel. One being the Background color after Vert. Alignment and
Border color after Border. Unless these options are somewhere less, I did not
find them. I had to uninstall 5.3 and reinstall 5.2 on my new Dell. 

I have attached a PDF (2 pages) showing the difference. Many thanks for looking
at this. LibreOffice is a great product. 

Sincerely
Ron Graham
Ontario, Canaada

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp

[Ashod Nakashian]

 net/loolnb.cpp |  210 +++--
 1 file changed, 117 insertions(+), 93 deletions(-)

New commits:
commit b9f4bed8ea75138ed04a66ffc6ccfd76396cc832
Author: Ashod Nakashian 
Date:   Mon Feb 13 21:49:59 2017 -0500

nb: separate Socket into ClientSocket and ServerSocket

Change-Id: I1aafd6192b955e51b8f1e74c1aad5fc3603f71d6
Reviewed-on: https://gerrit.libreoffice.org/34237
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/loolnb.cpp b/net/loolnb.cpp
index 07c5c82..0ca4faf 100644
--- a/net/loolnb.cpp
+++ b/net/loolnb.cpp
@@ -127,87 +127,6 @@ public:
 return rc;
 }
 
-/// Connect to a server address.
-/// Does not retry on error.
-/// timeoutMs can be 0 to avoid waiting, or -1 to wait forever.
-/// Returns true on success only.
-/// Note: when succceeds, caller must check for
-/// EINPROGRESS and poll for write, then getError(),
-/// only when the latter returns 0 we are connected.
-bool connect(const SocketAddress& address, const int timeoutMs = 0)
-{
-const int rc = ::connect(_fd, address.addr(), address.length());
-if (rc == 0)
-{
-return true;
-}
-
-if (errno != EINPROGRESS)
-{
-return false;
-}
-
-// Wait for writable, then check again.
-pollWrite(timeoutMs);
-
-// Now check if we connected, not, or not yet.
-return (getError() == 0 || errno == EINPROGRESS);
-}
-
-/// Binds to a local address (Servers only).
-/// Does not retry on error.
-/// Returns true on success only.
-bool bind(const SocketAddress& address)
-{
-// Enable address reuse to avoid stalling after
-// recycling, when previous socket is TIME_WAIT.
-//TODO: Might be worth refactoring out.
-const int reuseAddress = 1;
-constexpr unsigned int len = sizeof(reuseAddress);
-::setsockopt(_fd, SOL_SOCKET, SO_REUSEADDR, , len);
-
-const int rc = ::bind(_fd, address.addr(), address.length());
-return (rc == 0);
-}
-
-/// Listen to incoming connections (Servers only).
-/// Does not retry on error.
-/// Returns true on success only.
-bool listen(const int backlog = 64)
-{
-const int rc = ::listen(_fd, backlog);
-return (rc == 0);
-}
-
-/// Accepts an incoming connection (Servers only).
-/// Does not retry on error.
-/// Returns a valid Socket shared_ptr on success only.
-std::shared_ptr accept()
-{
-// Accept a connection (if any) and set it to non-blocking.
-// We don't care about the client's address, so ignored.
-const int rc = ::accept4(_fd, nullptr, nullptr, SOCK_NONBLOCK);
-return std::shared_ptr(rc != -1 ? new Socket(rc) : nullptr);
-}
-
-/// Send data to our peer.
-/// Returns the number of bytes sent, -1 on error.
-int send(const void* buf, const size_t len)
-{
-// Don't SIGPIPE when the other end closes.
-const int rc = ::send(_fd, buf, len, MSG_NOSIGNAL);
-return rc;
-}
-
-/// Receive data from our peer.
-/// Returns the number of bytes received, -1 on error,
-/// and 0 when the peer has performed an orderly shutdown.
-int recv(void* buf, const size_t len)
-{
-const int rc = ::recv(_fd, buf, len, 0);
-return rc;
-}
-
 /// Poll the socket for either read, write, or both.
 /// Returns -1 on failure/error (query socket error), 0 for timeout,
 /// otherwise, depending on events, the respective bits set.
@@ -219,7 +138,7 @@ public:
 pollfd poll;
 memset(, 0, sizeof(poll));
 
-poll.fd = _fd;
+poll.fd = fd();
 poll.events |= events;
 
 int rc;
@@ -277,7 +196,7 @@ public:
 return (rc > 0 && (rc & POLLOUT));
 }
 
-private:
+protected:
 
 /// Construct based on an existing socket fd.
 /// Used by accept() only.
@@ -290,6 +209,111 @@ private:
 const int _fd;
 };
 
+/// A non-blocking, client socket.
+class ClientSocket : public Socket
+{
+public:
+ClientSocket() :
+Socket()
+{
+}
+
+/// Connect to a server address.
+/// Does not retry on error.
+/// timeoutMs can be 0 to avoid waiting, or -1 to wait forever.
+/// Returns true on success only.
+/// Note: when succceeds, caller must check for
+/// EINPROGRESS and poll for write, then getError(),
+/// only when the latter returns 0 we are connected.
+bool connect(const SocketAddress& address, const int timeoutMs = 0)
+{
+const int rc = ::connect(fd(), address.addr(), address.length());
+if (rc == 0)
+{
+return true;
+}
+
+if (errno != EINPROGRESS)
+{
+return false;
+}
+
+// Wait for 

[Libreoffice-bugs] [Bug 105927] Crash during Find and Replace of a Single Character Across Multiple Pages in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105927

--- Comment #11 from Vince Wilyard  ---
Thank you to everyone for your help so far.

Here is what I am doing to get LibreDraw to do what I want it to do.

1. Open File.
2. Perform a Find and Replace edit.
3. Let it complete without touching the mouse in any application. The Replace
All 
   remains pushed down on the screen.
4. Save the file with a desired new name. 
5. Close the file.
6. Close LibreOffice.
7. Repeat.

If I click anywhere in any application during the Replace All edit, then
LibreOffice stops responding, and then I have to kill the operation / task. So
I follow the above steps.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp

[Ashod Nakashian]

 net/loolnb.cpp |  134 -
 1 file changed, 68 insertions(+), 66 deletions(-)

New commits:
commit 38cf105826925b6bd3fbf1fc98eef2cba32e4972
Author: Ashod Nakashian 
Date:   Mon Feb 13 21:25:54 2017 -0500

nb: refactor the client code into own function

Change-Id: I23735785cc4a66589fd81c7cb0f08476829ba7e8
Reviewed-on: https://gerrit.libreoffice.org/34236
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/loolnb.cpp b/net/loolnb.cpp
index 36898fa..07c5c82 100644
--- a/net/loolnb.cpp
+++ b/net/loolnb.cpp
@@ -402,7 +402,6 @@ private:
 void createPollFds()
 {
 const size_t size = _pollSockets.size();
-std::cout << "creating poll fds " << size << std::endl;
 
 _pollFds.resize(size + 1); // + wakeup pipe
 
@@ -467,7 +466,7 @@ private:
 
 SocketAddress addr("127.0.0.1", PortNumber);
 
-std::shared_ptr connectClient(const int timeoutMs)
+void client(const int timeoutMs)
 {
 const auto client = std::make_shared();
 if (!client->connect(addr, timeoutMs) && errno != EINPROGRESS)
@@ -478,7 +477,25 @@ std::shared_ptr connectClient(const int timeoutMs)
 
 std::cout << "Connected " << client->fd() << std::endl;
 
-return client;
+client->send("1", 1);
+int sent = 1;
+while (sent > 0 && client->pollRead(5000))
+{
+char buf[1024];
+const int recv = client->recv(buf, sizeof(buf));
+if (recv <= 0)
+{
+perror("recv");
+break;
+}
+else
+{
+const std::string msg = std::string(buf, recv);
+const int num = stoi(msg);
+const std::string new_msg = std::to_string(num + 1);
+sent = client->send(new_msg.data(), new_msg.size());
+}
+}
 }
 
 void server(SocketPoll& poller)
@@ -515,34 +532,58 @@ void server(SocketPoll& poller)
 }
 }
 
-int main(int argc, const char**)
+/// Poll client sockets and do IO.
+void pollAndComm(SocketPoll& poller, std::atomic& stop)
 {
-SocketAddress addr("127.0.0.1", PortNumber);
-
-if (argc > 1)
+while (!stop)
 {
-// Client.
-auto client = connectClient(0);
-client->send("1", 1);
-int sent = 1;
-while (sent > 0 && client->pollRead(5000))
+poller.poll(5000, [](const std::shared_ptr& socket, const int 
events)
 {
-char buf[1024];
-const int recv = client->recv(buf, sizeof(buf));
-if (recv <= 0)
+if (events & POLLIN)
 {
-perror("recv");
-break;
-}
-else
-{
-const std::string msg = std::string(buf, recv);
-const int num = stoi(msg);
-const std::string new_msg = std::to_string(num + 1);
-sent = client->send(new_msg.data(), new_msg.size());
+char buf[1024];
+const int recv = socket->recv(buf, sizeof(buf));
+if (recv <= 0)
+{
+perror("recv");
+return false;
+}
+
+if (events & POLLOUT)
+{
+const std::string msg = std::string(buf, recv);
+const int num = stoi(msg);
+if ((num % (1<<16)) == 1)
+{
+std::cout << "Client #" << socket->fd() << ": " << msg 
<< std::endl;
+}
+const std::string new_msg = std::to_string(num + 1);
+const int sent = socket->send(new_msg.data(), 
new_msg.size());
+if (sent != static_cast(new_msg.size()))
+{
+perror("send");
+return false;
+}
+}
+else
+{
+// Normally we'd buffer the response, but for now...
+std::cerr << "Client #" << socket->fd()
+<< ": ERROR - socket not ready for write." << 
std::endl;
+}
 }
-}
 
+return true;
+});
+}
+}
+
+int main(int argc, const char**)
+{
+if (argc > 1)
+{
+// We are now the client application.
+client(0);
 return 0;
 }
 
@@ -552,49 +593,10 @@ int main(int argc, const char**)
 // Start the client polling thread.
 Thread threadPoll([](std::atomic& stop)
 {
-while (!stop)
-{
-poller.poll(5000, [](const std::shared_ptr& socket, const 
int events)
-{
-if (events & POLLIN)
-{
-char buf[1024];
-const int recv = socket->recv(buf, sizeof(buf));
-if (recv <= 0)
-   

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp

[Ashod Nakashian]

 net/loolnb.cpp |   69 ++---
 1 file changed, 37 insertions(+), 32 deletions(-)

New commits:
commit 9bae6652d60ae636eba392dbe0c0401739fdb027
Author: Ashod Nakashian 
Date:   Mon Feb 13 20:55:01 2017 -0500

nb: refactor server code into own function

Change-Id: Iba7363df7452da271fcf9afb54ad1f6177260ddd
Reviewed-on: https://gerrit.libreoffice.org/34235
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/loolnb.cpp b/net/loolnb.cpp
index cd197cf..36898fa 100644
--- a/net/loolnb.cpp
+++ b/net/loolnb.cpp
@@ -465,10 +465,10 @@ private:
 std::thread _thread;
 };
 
+SocketAddress addr("127.0.0.1", PortNumber);
+
 std::shared_ptr connectClient(const int timeoutMs)
 {
-SocketAddress addr("127.0.0.1", PortNumber);
-
 const auto client = std::make_shared();
 if (!client->connect(addr, timeoutMs) && errno != EINPROGRESS)
 {
@@ -481,6 +481,40 @@ std::shared_ptr connectClient(const int timeoutMs)
 return client;
 }
 
+void server(SocketPoll& poller)
+{
+// Start server.
+auto server = std::make_shared();
+if (!server->bind(addr))
+{
+const std::string msg = "Failed to bind. (errno: ";
+throw std::runtime_error(msg + std::strerror(errno) + ")");
+}
+
+if (!server->listen())
+{
+const std::string msg = "Failed to listen. (errno: ";
+throw std::runtime_error(msg + std::strerror(errno) + ")");
+}
+
+std::cout << "Listening." << std::endl;
+for (;;)
+{
+if (server->pollRead(3))
+{
+std::shared_ptr clientSocket = server->accept();
+if (!clientSocket)
+{
+const std::string msg = "Failed to accept. (errno: ";
+throw std::runtime_error(msg + std::strerror(errno) + ")");
+}
+
+std::cout << "Accepted client #" << clientSocket->fd() << 
std::endl;
+poller.insertNewSocket(clientSocket);
+}
+}
+}
+
 int main(int argc, const char**)
 {
 SocketAddress addr("127.0.0.1", PortNumber);
@@ -561,36 +595,7 @@ int main(int argc, const char**)
 }
 });
 
-// Start server.
-auto server = std::make_shared();
-if (!server->bind(addr))
-{
-const std::string msg = "Failed to bind. (errno: ";
-throw std::runtime_error(msg + std::strerror(errno) + ")");
-}
-
-if (!server->listen())
-{
-const std::string msg = "Failed to listen. (errno: ";
-throw std::runtime_error(msg + std::strerror(errno) + ")");
-}
-
-std::cout << "Listening." << std::endl;
-for (;;)
-{
-if (server->pollRead(3))
-{
-std::shared_ptr clientSocket = server->accept();
-if (!clientSocket)
-{
-const std::string msg = "Failed to accept. (errno: ";
-throw std::runtime_error(msg + std::strerror(errno) + ")");
-}
-
-std::cout << "Accepted client #" << clientSocket->fd() << 
std::endl;
-poller.insertNewSocket(clientSocket);
-}
-}
+server(poller);
 
 std::cout << "Shutting down server." << std::endl;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp

[Ashod Nakashian]

 net/loolnb.cpp |   67 +++--
 1 file changed, 47 insertions(+), 20 deletions(-)

New commits:
commit 59a481fd9d4f9a49c8de30ff72cc66b574f127a7
Author: Ashod Nakashian 
Date:   Mon Feb 13 20:41:46 2017 -0500

nb: recreate the poll fds only when needed

Change-Id: I17accfb0339c590b7e155e8fd804e3e32c57e3ed
Reviewed-on: https://gerrit.libreoffice.org/34234
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/loolnb.cpp b/net/loolnb.cpp
index 78e61b1..cd197cf 100644
--- a/net/loolnb.cpp
+++ b/net/loolnb.cpp
@@ -313,51 +313,51 @@ public:
 _wakeup[0] = -1;
 _wakeup[1] = -1;
 }
+
+createPollFds();
+}
+
+~SocketPoll()
+{
+::close(_wakeup[0]);
+::close(_wakeup[1]);
 }
 
 /// Poll the sockets for available data to read or buffer to write.
 void poll(const int timeoutMs, const std::function& handler)
 {
 const size_t size = _pollSockets.size();
-std::vector pollFds(size + 1); // + wakeup fd
-
-for (size_t i = 0; i < size; ++i)
-{
-pollFds[i].fd = _pollSockets[i]->fd();
-pollFds[i].events = POLLIN | POLLOUT; //TODO: Get from the socket.
-pollFds[i].revents = 0;
-}
-
-// Add the read-end of the wake pipe.
-pollFds[size].fd = _wakeup[0];
-pollFds[size].events = POLLIN;
-pollFds[size].revents = 0;
 
 int rc;
 do
 {
-rc = ::poll([0], pollFds.size(), timeoutMs);
+rc = ::poll(&_pollFds[0], size + 1, timeoutMs);
 }
 while (rc < 0 && errno == EINTR);
 
 // Fire the callback and remove dead fds.
 for (int i = static_cast(size) - 1; i >= 0; --i)
 {
-if (pollFds[i].revents)
+if (_pollFds[i].revents)
 {
-if (!handler(_pollSockets[i], pollFds[i].revents))
+if (!handler(_pollSockets[i], _pollFds[i].revents))
 {
-std::cout << "Removing: " << pollFds[i].fd << std::endl;
+std::cout << "Removing: " << _pollFds[i].fd << std::endl;
 _pollSockets.erase(_pollSockets.begin() + i);
+// Don't remove from pollFds; we'll recreate below.
 }
 }
 }
 
-if (pollFds[size].revents)
+// Process the wakeup pipe (always the last entry).
+if (_pollFds[size].revents)
 {
-// Process new sockets first.
+// Add new sockets first.
 addNewSocketsToPoll();
 
+// Recreate the poll fds array.
+createPollFds();
+
 // Clear the data.
 int dump;
 if (::read(_wakeup[0], , sizeof(4)) == -1)
@@ -365,6 +365,10 @@ public:
 // Nothing to do.
 }
 }
+else if (_pollFds.size() != (_pollSockets.size() + 1))
+{
+createPollFds();
+}
 }
 
 /// Insert a new socket to be polled.
@@ -394,6 +398,27 @@ private:
 _newSockets.clear();
 }
 
+/// Create the poll fds array.
+void createPollFds()
+{
+const size_t size = _pollSockets.size();
+std::cout << "creating poll fds " << size << std::endl;
+
+_pollFds.resize(size + 1); // + wakeup pipe
+
+for (size_t i = 0; i < size; ++i)
+{
+_pollFds[i].fd = _pollSockets[i]->fd();
+_pollFds[i].events = POLLIN | POLLOUT; //TODO: Get from the socket.
+_pollFds[i].revents = 0;
+}
+
+// Add the read-end of the wake pipe.
+_pollFds[size].fd = _wakeup[0];
+_pollFds[size].events = POLLIN;
+_pollFds[size].revents = 0;
+}
+
 private:
 /// main-loop wakeup pipe
 int _wakeup[2];
@@ -402,6 +427,8 @@ private:
 /// Protects _newSockets
 std::mutex _mutex;
 std::vector _newSockets;
+/// The fds to poll.
+std::vector _pollFds;
 };
 
 /// Generic thread class.
@@ -509,7 +536,7 @@ int main(int argc, const char**)
 {
 const std::string msg = std::string(buf, recv);
 const int num = stoi(msg);
-if ((num % (1<<14)) == 1)
+if ((num % (1<<16)) == 1)
 {
 std::cout << "Client #" << socket->fd() << ": " << 
msg << std::endl;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp

[Ashod Nakashian]

 net/loolnb.cpp |  129 ++---
 1 file changed, 70 insertions(+), 59 deletions(-)

New commits:
commit 404c1fab379650bf9cde78ae1398c5800bb232e9
Author: Ashod Nakashian 
Date:   Mon Feb 13 19:40:41 2017 -0500

nb: poll wakeup pipe and simplified polling

Change-Id: I2e688b985d4a9bf7cbe8eef5df10f67bfc96f91c
Reviewed-on: https://gerrit.libreoffice.org/34233
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/loolnb.cpp b/net/loolnb.cpp
index e7ce4f0..78e61b1 100644
--- a/net/loolnb.cpp
+++ b/net/loolnb.cpp
@@ -306,91 +306,102 @@ class SocketPoll
 public:
 SocketPoll()
 {
+// Create the wakeup fd.
+if (::pipe2(_wakeup, O_CLOEXEC | O_NONBLOCK) == -1)
+{
+//FIXME: Can't have wakeup pipe, should we exit?
+_wakeup[0] = -1;
+_wakeup[1] = -1;
+}
 }
 
-void add(const std::shared_ptr& socket)
-{
-const int fd = socket->fd();
-pollfd poll;
-memset(, 0, sizeof(pollfd));
-poll.fd = fd;
-poll.events = (POLLIN | POLLOUT);
-
-std::lock_guard lock(_mutex);
-
-_sockets.emplace(fd, socket);
-_pollDesc.emplace_back(poll);
-}
-
-void remove(const std::shared_ptr& socket)
+/// Poll the sockets for available data to read or buffer to write.
+void poll(const int timeoutMs, const std::function& handler)
 {
-const int fd = socket->fd();
+const size_t size = _pollSockets.size();
+std::vector pollFds(size + 1); // + wakeup fd
 
-std::lock_guard lock(_mutex);
+for (size_t i = 0; i < size; ++i)
+{
+pollFds[i].fd = _pollSockets[i]->fd();
+pollFds[i].events = POLLIN | POLLOUT; //TODO: Get from the socket.
+pollFds[i].revents = 0;
+}
 
-// Hold reference to socket so it doesn't
-// close while we are in poll(2).
-_socketsDead.emplace(fd, socket);
-_sockets.erase(fd);
-}
+// Add the read-end of the wake pipe.
+pollFds[size].fd = _wakeup[0];
+pollFds[size].events = POLLIN;
+pollFds[size].revents = 0;
 
-/// Poll the sockets for available data to read or buffer to write.
-void poll(const std::function& 
handler)
-{
 int rc;
 do
 {
-// See note in class doc.
-rc = ::poll(&_pollDesc[0], _pollDesc.size(), 0);
+rc = ::poll([0], pollFds.size(), timeoutMs);
 }
 while (rc < 0 && errno == EINTR);
 
-for (const pollfd& poll : _pollDesc)
+// Fire the callback and remove dead fds.
+for (int i = static_cast(size) - 1; i >= 0; --i)
 {
-if (poll.revents)
+if (pollFds[i].revents)
 {
-std::lock_guard lock(_mutex);
-const auto it = _sockets.find(poll.fd);
-if (it != _sockets.end() && it->second)
+if (!handler(_pollSockets[i], pollFds[i].revents))
 {
-if (!handler(it->second, poll.revents))
-{
-std::cout << "Removing: " << poll.fd << std::endl;
-_socketsDead.emplace(poll.fd, it->second);
-_sockets.erase(poll.fd);
-}
+std::cout << "Removing: " << pollFds[i].fd << std::endl;
+_pollSockets.erase(_pollSockets.begin() + i);
 }
 }
 }
 
-// Now clear the dead sockets to close/free them.
-std::lock_guard lock(_mutex);
-
-// Remove the pollfd of these sockets as well.
-size_t size = 0;
-for (size_t i = 0; i < _pollDesc.size(); ++i)
+if (pollFds[size].revents)
 {
-const auto it = _socketsDead.find(_pollDesc[i].fd);
-if (it != _socketsDead.end())
-{
-// Move to the end.
-std::swap(_pollDesc[i], _pollDesc[_pollDesc.size() - 1]);
-}
-else
+// Process new sockets first.
+addNewSocketsToPoll();
+
+// Clear the data.
+int dump;
+if (::read(_wakeup[0], , sizeof(4)) == -1)
 {
-++size;
+// Nothing to do.
 }
 }
+}
+
+/// Insert a new socket to be polled.
+/// Sockets are removed only when the handler return false.
+void insertNewSocket(const std::shared_ptr& newSocket)
+{
+std::lock_guard lock(_mutex);
+
+_newSockets.emplace_back(newSocket);
+
+// wakeup the main-loop.
+if (::write(_wakeup[1], "w", 1) == -1)
+{
+// No wake up 

[Libreoffice-bugs] [Bug 101646] UI option "Scaling" was removed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

brucehohl  changed:

   What|Removed |Added

 CC||bruceh...@gmail.com

--- Comment #16 from brucehohl  ---
Just thought I might chime-in on this as I actually use this feature.

I think that the UI scaling feature remains relevant with the types of monitors
in use today.  According to
http://www.eizo.com/library/basics/pixel_density_4k/ HiDPI displays for
computers have been offered since 2014 so even if such displays render this
feature obsolete it will years before such displays are in the majority.  

With the average monitor in service today the various screen magnifying tools
can produce mixed results where some things improve but others degrade.  On the
other hand, the LO UI scaling feature and zoom feature work very well.  I even
reported  bug 101371 related to this mainly because I think this is a quality
feature worthy of continuation and maintenance at least until the next
generation of display technology becomes common.

Also, ironically, 5.3 has added an scaling option for the sidebar icons. 
Surely, if scaling for that UI component is important than it must also be
important for the text menus. Text menus are important as they provide a level
of program explore-ability "in plain English (or other language)" not possible
with unfamiliar icons.  I beg for a reprieve for this feature :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 101646] UI option "Scaling" was removed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

brucehohl  changed:

   What|Removed |Added

 CC||bruceh...@gmail.com

--- Comment #16 from brucehohl  ---
Just thought I might chime-in on this as I actually use this feature.

I think that the UI scaling feature remains relevant with the types of monitors
in use today.  According to
http://www.eizo.com/library/basics/pixel_density_4k/ HiDPI displays for
computers have been offered since 2014 so even if such displays render this
feature obsolete it will years before such displays are in the majority.  

With the average monitor in service today the various screen magnifying tools
can produce mixed results where some things improve but others degrade.  On the
other hand, the LO UI scaling feature and zoom feature work very well.  I even
reported  bug 101371 related to this mainly because I think this is a quality
feature worthy of continuation and maintenance at least until the next
generation of display technology becomes common.

Also, ironically, 5.3 has added an scaling option for the sidebar icons. 
Surely, if scaling for that UI component is important than it must also be
important for the text menus. Text menus are important as they provide a level
of program explore-ability "in plain English (or other language)" not possible
with unfamiliar icons.  I beg for a reprieve for this feature :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101646] UI option "Scaling" was removed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

--- Comment #15 from LibreTraining  ---
I was using this to increase the font size to make screenshots easier to read.
Try documenting the navigator with any clarity with that tiny type.

Upscaling a screenshot is not an option as it even further reduces the quality
(which is already bad enough).

My vote is bring it back.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 101646] UI option "Scaling" was removed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

--- Comment #15 from LibreTraining  ---
I was using this to increase the font size to make screenshots easier to read.
Try documenting the navigator with any clarity with that tiny type.

Upscaling a screenshot is not an option as it even further reduces the quality
(which is already bad enough).

My vote is bring it back.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

5.3.0.3 firebird race condition

[Chris Willing]

Building 5.3.0.3 using the supplied firebird
(external/tarballs/Firebird-3.0.0.32483-0.tar.bz2) results in
intermittent failure. It seems to be a known problem
(https://www.mail-archive.com/firebird-devel@lists.sourceforge.net/msg13374.html),
possibly fixed in a later version.

In the meantime if I build with --disable-firebird-sdbc (and without a
system firebird), what functionality will be lost?

chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: starmath/source

[Takeshi Abe]

 starmath/source/rect.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 3bec0fd8cd191c47ab94602470193ef56a05f444
Author: Takeshi Abe 
Date:   Mon Feb 13 23:23:11 2017 +0900

starmath: This condition always holds

Change-Id: I6d47676dc71644766fdaea7033c53efa0bf9b549
Reviewed-on: https://gerrit.libreoffice.org/34212
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/source/rect.cxx b/starmath/source/rect.cxx
index 54ceb6e..511f4f6 100644
--- a/starmath/source/rect.cxx
+++ b/starmath/source/rect.cxx
@@ -480,11 +480,12 @@ SmRect & SmRect::ExtendBy(const SmRect , 
RectCopyMBL eCopyMode)
 if (!HasAlignInfo())
 CopyAlignInfo(rRect);
 else if (rRect.HasAlignInfo())
-{   nAlignT = std::min(GetAlignT(), rRect.GetAlignT());
+{
+assert(HasAlignInfo());
+nAlignT = std::min(GetAlignT(), rRect.GetAlignT());
 nAlignB = std::max(GetAlignB(), rRect.GetAlignB());
 nHiAttrFence = std::min(GetHiAttrFence(), rRect.GetHiAttrFence());
 nLoAttrFence = std::max(GetLoAttrFence(), rRect.GetLoAttrFence());
-OSL_ENSURE(HasAlignInfo(), "Sm: ooops...");
 
 switch (eCopyMode)
 {   case RectCopyMBL::This:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94129] LibO not in foreground when double-clicking file in Windows explorer ( and LibO wasn't opened before since booting)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94129

--- Comment #12 from Alan Rouse  ---
I have a slightly different variant (using Windows 10):

1) Open Windows Explorer in full screen mode and navigate to a folder
containing spreadsheet documents
2} Double-click on a document and Calc opens the document in focus. Note that
the Windows taskbar shows the Calc icon underlined to indicate that a document
is open
3) Switch back to Windows Explorer and double-click another document. Nothing
appears to happen.  However, in the Windows taskbar a new LibreOffice icon
briefly opens then closes, and the Calc icon shows a double underline to
indicate that more than one document is open.
4) Hover over the Calc icon in the taskbar and Windows shows two documents
open. Click on the new one and it will come into focus.

The problem is worse if you then try to open a CSV file through Windows
Explorer.  There is no indication at all that anything has happened.  If you
hover over the Calc icon it still shows only the documents that were previously
opened.  However, if you click on the last document that was opened you will
see that it has a "Text import" dialog box open that allows you to open the CSV
file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sc/qa sc/source

[Justin Luth]

 sc/qa/unit/data/xlsx/tdf105840_allRowsHidden.xlsx |binary
 sc/qa/unit/subsequent_export-test.cxx |   14 +++
 sc/source/filter/excel/xetable.cxx|   26 ++
 sc/source/filter/inc/xetable.hxx  |2 +
 4 files changed, 33 insertions(+), 9 deletions(-)

New commits:
commit 1cde2eb9d128c9b1b658b1380074461429ab2214
Author: Justin Luth 
Date:   Fri Feb 10 12:44:47 2017 +0300

tdf#105840 EXCEL export: fixes for hidden defaultRow

second attempt at fixing hidden rows without creating
a million repeated rows. (related to tdf#98106)
This affects both .xls and .xlsx.  XLSX previously had
NO support for default-hidden(zeroHeight), but XLS already did.

Change-Id: I804e3f2ba21e595a1c2b2ebb355f0995868dd289
Reviewed-on: https://gerrit.libreoffice.org/34128
Tested-by: Jenkins 
Reviewed-by: Bartosz Kosiorek 

diff --git a/sc/qa/unit/data/xlsx/tdf105840_allRowsHidden.xlsx 
b/sc/qa/unit/data/xlsx/tdf105840_allRowsHidden.xlsx
new file mode 100644
index 000..e2c22cd
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf105840_allRowsHidden.xlsx 
differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 6413db8..fbb16cd 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -116,6 +116,7 @@ public:
 void testColumnWidthExportFromODStoXLSX();
 void testOutlineExportXLSX();
 void testHiddenEmptyRowsXLSX();
+void testAllRowsHiddenXLSX();
 void testLandscapeOrientationXLSX();
 
 void testInlineArrayXLS();
@@ -217,6 +218,7 @@ public:
 CPPUNIT_TEST(testColumnWidthExportFromODStoXLSX);
 CPPUNIT_TEST(testOutlineExportXLSX);
 CPPUNIT_TEST(testHiddenEmptyRowsXLSX);
+CPPUNIT_TEST(testAllRowsHiddenXLSX);
 CPPUNIT_TEST(testLandscapeOrientationXLSX);
 CPPUNIT_TEST(testInlineArrayXLS);
 CPPUNIT_TEST(testEmbeddedChartXLS);
@@ -891,6 +893,17 @@ void ScExportTest::testOutlineExportXLSX()
 assertXPath(pSheet, "/x:worksheet/x:sheetData/x:row", 30);
 }
 
+void ScExportTest::testAllRowsHiddenXLSX()
+{
+ScDocShellRef xOrigDocSh = loadDoc("tdf105840_allRowsHidden.", 
FORMAT_XLSX);
+CPPUNIT_ASSERT(xOrigDocSh.is());
+
+std::shared_ptr pXPathFile = 
ScBootstrapFixture::exportTo(&(*xOrigDocSh), FORMAT_XLSX);
+xmlDocPtr pSheet = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/worksheets/sheet1.xml");
+CPPUNIT_ASSERT(pSheet);
+assertXPath(pSheet, "/x:worksheet/x:sheetFormatPr", "zeroHeight", "true" );
+assertXPath(pSheet, "/x:worksheet/x:sheetData/x:row", 0);
+}
 
 void ScExportTest::testHiddenEmptyRowsXLSX()
 {
@@ -902,6 +915,7 @@ void ScExportTest::testHiddenEmptyRowsXLSX()
 xmlDocPtr pSheet = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/worksheets/sheet1.xml");
 CPPUNIT_ASSERT(pSheet);
 
+assertXPath(pSheet, "/x:worksheet/x:sheetFormatPr",  "zeroHeight", "false" 
);
 assertXPath(pSheet, "/x:worksheet/x:sheetData/x:row[1]", "hidden", "true");
 assertXPath(pSheet, "/x:worksheet/x:sheetData/x:row[2]", "hidden", "true");
 assertXPath(pSheet, "/x:worksheet/x:sheetData/x:row[3]", "hidden", "true");
diff --git a/sc/source/filter/excel/xetable.cxx 
b/sc/source/filter/excel/xetable.cxx
index ee16f16..9ec23a1 100644
--- a/sc/source/filter/excel/xetable.cxx
+++ b/sc/source/filter/excel/xetable.cxx
@@ -2047,7 +2047,7 @@ sal_uInt16 XclExpRow::GetFirstFreeXclCol() const
 
 bool XclExpRow::IsDefaultable() const
 {
-const sal_uInt16 nFlagsAlwaysMarkedAsDefault = EXC_ROW_DEFAULTFLAGS | 
EXC_ROW_UNSYNCED;
+const sal_uInt16 nFlagsAlwaysMarkedAsDefault = EXC_ROW_DEFAULTFLAGS | 
EXC_ROW_HIDDEN | EXC_ROW_UNSYNCED;
 return !::get_flag( mnFlags, static_cast< sal_uInt16 >( 
~nFlagsAlwaysMarkedAsDefault ) ) &&
IsEmpty();
 }
@@ -2056,6 +2056,7 @@ void XclExpRow::DisableIfDefault( const 
XclExpDefaultRowData& rDefRowData )
 {
 mbEnabled = !IsDefaultable() ||
 (mnHeight != rDefRowData.mnHeight) ||
+(IsHidden() != rDefRowData.IsHidden()) ||
 (IsUnsynced() != rDefRowData.IsUnsynced());
 }
 
@@ -2275,12 +2276,15 @@ void XclExpRowBuffer::Finalize( XclExpDefaultRowData& 
rDefRowData, const ScfUInt
 // return the default row format to caller
 rDefRowData = aMaxDefData;
 
-// now disable repeating extra (empty) rows that are equal to
-// default row height
+// now disable repeating extra (empty) rows that are equal to the default 
row
 for ( XclRepeatedRows::iterator it = aRepeated.begin(), it_end = 
aRepeated.end(); it != it_end; ++it)
 {
-if ( (*it)->GetXclRowRpt() > 1 && (*it)->GetHeight() == 
rDefRowData.mnHeight )
+if ( (*it)->GetXclRowRpt() > 1
+ && (*it)->GetHeight() == rDefRowData.mnHeight
+ && (*it)->IsHidden() == rDefRowData.IsHidden() )
+{
 

[Libreoffice-commits] core.git: writerperfect/qa

[Markus Mohrhard]

 writerperfect/qa/unit/wpftimport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4f4edde01364881be483eca9449a32a14093250f
Author: Markus Mohrhard 
Date:   Tue Feb 14 01:25:47 2017 +0100

more windows build fixes

Change-Id: I57b361dea1ee6a5bfdc95ec3632bb42a5941b900
Reviewed-on: https://gerrit.libreoffice.org/34232
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/writerperfect/qa/unit/wpftimport.cxx 
b/writerperfect/qa/unit/wpftimport.cxx
index 27b566c..427cb2c 100644
--- a/writerperfect/qa/unit/wpftimport.cxx
+++ b/writerperfect/qa/unit/wpftimport.cxx
@@ -19,7 +19,7 @@
 
 css::uno::Reference createDummyInput()
 {
-rtl::Reference xDummyInput{new 
comphelper::SequenceInputStream({})};
+rtl::Reference xDummyInput(new 
comphelper::SequenceInputStream(css::uno::Sequence()));
 return xDummyInput.get();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105971] Format issue with a .doc file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105971

--- Comment #5 from David Chambers  ---
Expanding on the format problem. The signature on the left appears amongst
other text higher up the document in Libre office Writer also the Text written
names move. Needs to be opened in Libre Writer and MS Word to see the
difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105971] Format issue with a .doc file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105971

--- Comment #4 from David Chambers  ---
Created attachment 131197
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131197=edit
Example of format issue opening a word.doc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105994] New: Visio file opens with Writer instead of Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105994

Bug ID: 105994
   Summary: Visio file opens with Writer instead of Draw
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jason.dr...@ada.com.au

Bug: Libre office incorrectly opens visio *.vdx file with Writer instead of
Draw.

Expected behaviour: Double-clicking a visio vdx file from Windows Explorer, or
using the File->Open menu item from within LibreOffice Draw should open the
diagram in Draw 

Observed Behaviour: Double-clicking a visio vdx file from Windows Explorer, or
using the File->Open menuitem from within LibreOffice Draw instead opens the
file in Writer, displaying the raw xml as ASCII.

The error occurs also from the Windows Command Prompt when run as follows:

   cd C:\Program Files (x86)\LibreOffice 5\program
   .\sdraw.exe -v D:\Downloads\test-visio.vdx

And using the equivalent command under cygwin:

   cd /cygdrive/c/Program Files (x86)/LibreOffice 5/program
   ./sdraw.exe /cygdrive/D/Downloads/test-visio.vdx

In all cases no error message is produced, just the odd observed behaviour.


In cygwin the file type is reported as: 
   XML 1.0 document, ASCII text, with very long lines. 

Windows Explorer properties reports filetype: 
   "Microsoft Visio 2000/XP/2003 Document (.vdx)"

Also Windows Explorer file association i.e. "opens with" is "Unknown
Application" despite having previously been set to "LibreOffice Draw"


Additional info: This bug occurs on Windows 10 pro 64bit, and on the latest
release of LibreOffice as well (version of 5.2.5.1)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105712] With NVDA active launching Special Character dialog using Insert -> Special Character, or via F7 Spell check causes a fatal error. With using Standard Toolbar button it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105712

--- Comment #18 from James Teh  ---
NVDA is nowhere in the call stack here, so this is almost certainly not related
to NVDA code. Most likely, it's a bug in the accessibility code (which doesn't
run while NVDA isn't running, hence the lack of crash when NVDA isn't running).

Debugging this is painful because LO catches unhandled C++ exceptions and
displays a fatal error dialog, but in WinDBG, we lose the exception that was
caught (or at least, I don't know how to get to it). Catching first chance C++
exceptions helps, but there are quite a lot of them, so knowing which one
triggered the fatal error is tricky. Any advice on this?

I *think* the following is the exception in question and it is indeed related
to accessibility code. Here's the stack trace:

 # ChildEBP RetAddr  
WARNING: Stack unwind information not available. Following frames may be wrong.
00 0171e968 662b9339 KERNELBASE!RaiseException+0x62
01 0171e9a8 639231c2 msvcr120!_CxxThrowException(void * pExceptionObject =
0x0171e9c4, struct _s__ThrowInfo * pThrowInfo = 0x654eeb58)+0x5b
[f:\dd\vctools\crt\crtw32\eh\throw.cpp @ 152]
02 0171e9e4 61cf637b
mergedlo!svx::SvxShowCharSetVirtualAcc::getAccessibleChild(long i = 0n0)+0x172
[c:\cygwin64\home\buildslave\source\libo-core\svx\source\accessibility\charmapacc.cxx
@ 131]
03 0171ea28 61cf63b0
winaccessibility!AccTopWindowListener::AddAllListeners(class
com::sun::star::accessibility::XAccessible * pAccessible = 0x093741cc, class
com::sun::star::accessibility::XAccessible * pParentXAcc = 0x09373c64, struct
HWND__ * pWND = 0x000b0652)+0xfb
[c:\cygwin64\home\buildslave\source\libo-core\winaccessibility\source\service\acctopwindowlistener.cxx
@ 174]
04 0171ea6c 61cf63b0
winaccessibility!AccTopWindowListener::AddAllListeners(class
com::sun::star::accessibility::XAccessible * pAccessible = 0x09373c64, class
com::sun::star::accessibility::XAccessible * pParentXAcc = 0x093741cc, struct
HWND__ * pWND = 0x000b0652)+0x130
[c:\cygwin64\home\buildslave\source\libo-core\winaccessibility\source\service\acctopwindowlistener.cxx
@ 183]
05 0171eab0 61cf63b0
winaccessibility!AccTopWindowListener::AddAllListeners(class
com::sun::star::accessibility::XAccessible * pAccessible = 0x09373c04, class
com::sun::star::accessibility::XAccessible * pParentXAcc = 0x09373c64, struct
HWND__ * pWND = 0x000b0652)+0x130
[c:\cygwin64\home\buildslave\source\libo-core\winaccessibility\source\service\acctopwindowlistener.cxx
@ 183]
06 0171eaf4 61cf6529
winaccessibility!AccTopWindowListener::AddAllListeners(class
com::sun::star::accessibility::XAccessible * pAccessible = 0x08d47320, class
com::sun::star::accessibility::XAccessible * pParentXAcc = 0x09373c04, struct
HWND__ * pWND = 0x000b0652)+0x130
[c:\cygwin64\home\buildslave\source\libo-core\winaccessibility\source\service\acctopwindowlistener.cxx
@ 183]
07 0171eb38 61cf75ba
winaccessibility!AccTopWindowListener::HandleWindowOpened(class
com::sun::star::accessibility::XAccessible * pAccessible = 0x083998f8)+0xe9
[c:\cygwin64\home\buildslave\source\libo-core\winaccessibility\source\service\acctopwindowlistener.cxx
@ 79]
08 0171eb64 63e4cebe winaccessibility!AccTopWindowListener::windowOpened(struct
com::sun::star::lang::EventObject * e = 0x0171eba0)+0x6a
[c:\cygwin64\home\buildslave\source\libo-core\winaccessibility\source\service\acctopwindowlistener.cxx
@ 127]
09 0171ebb4 63e4e339 mergedlo!`anonymous
namespace'::VCLXToolkit::callTopWindowListeners(class VclSimpleEvent * pEvent =
0x1402a090,  * pFn = 0x63e492a6)+0xde
[c:\cygwin64\home\buildslave\source\libo-core\toolkit\source\awt\vclxtoolkit.cxx
@ 1828]
0a 0171ebc4 63e4c08e mergedlo!`anonymous
namespace'::VCLXToolkit::eventListenerHandler(class VclSimpleEvent * rEvent =
0x0171ec40)+0x29
[c:\cygwin64\home\buildslave\source\libo-core\toolkit\source\awt\vclxtoolkit.cxx
@ 1793]
0b 0171ebd0 643d0090 mergedlo!`anonymous
namespace'::VCLXToolkit::LinkStubeventListenerHandler(void * instance =
0x09f6ec08, class VclSimpleEvent * data = 0x0171ec40)+0xe
[c:\cygwin64\home\buildslave\source\libo-core\toolkit\source\awt\vclxtoolkit.cxx
@ 1754]
0c 0171ec10 643c80a7 mergedlo!VclEventListeners::Call(class VclSimpleEvent *
rEvent = 0x0171ec40)+0xd0
[c:\cygwin64\home\buildslave\source\libo-core\vcl\source\app\vclevent.cxx @ 61]
0d 0171ec1c 64138d53 mergedlo!Application::ImplCallEventListeners(class
VclSimpleEvent * rEvent = 0x0171ec40)+0x17
[c:\cygwin64\home\buildslave\source\libo-core\vcl\source\app\svapp.cxx @ 839]
0e 0171ec98 641b2071 mergedlo!vcl::Window::CallEventListeners(unsigned long
nEvent = 0x3eb, void * pData = 0x13f44258)+0x63
[c:\cygwin64\home\buildslave\source\libo-core\vcl\source\window\event.cxx @
214]
0f 0171ecac 641b3dec mergedlo!vcl::Window::ImplSetReallyVisible(void)+0x61
[c:\cygwin64\home\buildslave\source\libo-core\vcl\source\window\window.cxx @
1307]
10 0171ed08 64127122 mergedlo!vcl::Window::Show(bool bVisible = true, ShowFlags
nFlags = NONE (0n0))+0x3ec

[Libreoffice-commits] core.git: writerperfect/qa

[Markus Mohrhard]

 writerperfect/qa/unit/TextImportTest.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 33dbfed46d95720c26699e0289ecacd87cd6e0a7
Author: Markus Mohrhard 
Date:   Tue Feb 14 01:21:16 2017 +0100

more build fixes, loplugin:staticmethods

Change-Id: I710182dfe2082b9782076faa27c8bd78e899a7cb

diff --git a/writerperfect/qa/unit/TextImportTest.cxx 
b/writerperfect/qa/unit/TextImportTest.cxx
index 2cb16b6..ba464c6 100644
--- a/writerperfect/qa/unit/TextImportTest.cxx
+++ b/writerperfect/qa/unit/TextImportTest.cxx
@@ -43,12 +43,12 @@ private:
 virtual bool doDetectFormat(librevenge::RVNGInputStream , 
rtl::OUString ) override;
 virtual bool doImportDocument(librevenge::RVNGInputStream , 
OdtGenerator , utl::MediaDescriptor ) override;
 
-void generate(librevenge::RVNGTextInterface ) const;
+static void generate(librevenge::RVNGTextInterface );
 };
 
 bool TextImportFilter::doImportDocument(librevenge::RVNGInputStream &, 
OdtGenerator , utl::MediaDescriptor &)
 {
-generate(rGenerator);
+TextImportFilter::generate(rGenerator);
 return true;
 }
 
@@ -74,7 +74,7 @@ uno::Sequence< rtl::OUString > SAL_CALL 
TextImportFilter::getSupportedServiceNam
 return {"com.sun.star.document.ImportFilter", 
"com.sun.star.document.ExtendedTypeDetection"};
 }
 
-void TextImportFilter::generate(librevenge::RVNGTextInterface ) const
+void TextImportFilter::generate(librevenge::RVNGTextInterface )
 {
 using namespace librevenge;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: writerperfect/qa

[Markus Mohrhard]

 writerperfect/qa/unit/TextImportTest.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1a4934eae26d5ec21e21fb6f0a85fd08ad9fd9f3
Author: Markus Mohrhard 
Date:   Tue Feb 14 01:09:34 2017 +0100

fix build

Change-Id: I7b27d5e5b47eb91cfe87918ae335cd228845be17

diff --git a/writerperfect/qa/unit/TextImportTest.cxx 
b/writerperfect/qa/unit/TextImportTest.cxx
index fdd17c1..2cb16b6 100644
--- a/writerperfect/qa/unit/TextImportTest.cxx
+++ b/writerperfect/qa/unit/TextImportTest.cxx
@@ -61,7 +61,7 @@ bool 
TextImportFilter::doDetectFormat(librevenge::RVNGInputStream &, rtl::OUStri
 // XServiceInfo
 rtl::OUString SAL_CALL TextImportFilter::getImplementationName()
 {
-return "org.libreoffice.comp.Wpft.QA.TextImportFilter";
+return OUString("org.libreoffice.comp.Wpft.QA.TextImportFilter");
 }
 
 sal_Bool SAL_CALL TextImportFilter::supportsService(const rtl::OUString 
)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105993] Snap package: LO doesn't see the printer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105993

Aron Budea  changed:

   What|Removed |Added

 Whiteboard||snap

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105979] Glyph outlines are corrupted in exported PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105979

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105979] Glyph outlines are corrupted in exported PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105979

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Is OpenGL rendering enabled?

Disable OpenGL and do the export, any affect?

Is "Hardware acceleration" enabled? Disable it and allow CPU only processing,
any affect?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105993] New: Snap package: LO doesn't see the printer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105993

Bug ID: 105993
   Summary: Snap package: LO doesn't see the printer
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: p...@jzimm.net

Snap-packaged LibreOffice doesn't see the configured printers, it only shows a
"Generic printer". Consequently it is impossible to print a document from LO.

On the same machine, LO installed using .deb packages works correctly in this
regard.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105992] FORMATTING: Writer doesn' t use kerning information of Times New Roman anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105992

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Blocks||102985


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102985
[Bug 102985] [META] Font bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102985

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||105992


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105992
[Bug 105992] FORMATTING: Writer doesn't use kerning information of Times New
Roman anymore
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98259

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||105990


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105990
[Bug 105990] Can't type special characters using CRTL+ALT under Windows 7 Home
Premium 64bit
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105990] Can' t type special characters using CRTL+ALT under Windows 7 Home Premium 64bit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105990

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Blocks||98259
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 100908 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100908] Typing with Ctrl+Alt+? for ALTGR toggle does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100908

V Stuart Foote  changed:

   What|Removed |Added

 CC||ab1...@gmx.de

--- Comment #7 from V Stuart Foote  ---
*** Bug 105990 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
Bug 98259 depends on bug 105990, which changed state.

Bug 105990 Summary: Can't type special characters using CRTL+ALT under Windows 
7 Home Premium 64bit
https://bugs.documentfoundation.org/show_bug.cgi?id=105990

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105956] Changing chart type from pie chart to column chart brokes chart coloring

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105956

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Version|5.4.0.0.alpha0+ Master  |Inherited From OOo

--- Comment #4 from Aron Budea  ---
Already in 3.3.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105957] [META] Bugs and enhancements related to Scrollbars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105957

Volga  changed:

   What|Removed |Added

  Component|LibreOffice |UI

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105650] Wrong text alignment with strikethrough within vertical writing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105650

Volga  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |4828|

--- Comment #17 from Volga  ---
*** Bug 104828 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 104828, which changed state.

Bug 104828 Summary: Several proportional characters shifted to the left within 
vertical text when they are upright
https://bugs.documentfoundation.org/show_bug.cgi?id=104828

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83066] [META] Tracking bug for CJK issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
Bug 83066 depends on bug 104828, which changed state.

Bug 104828 Summary: Several proportional characters shifted to the left within 
vertical text when they are upright
https://bugs.documentfoundation.org/show_bug.cgi?id=104828

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104828] Several proportional characters shifted to the left within vertical text when they are upright

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104828

Volga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |5650|
 Resolution|--- |DUPLICATE

--- Comment #19 from Volga  ---
(In reply to Khaled Hosny from comment #8)
> No idea, want to find out? May be they are doing something more clever than
> us.
Now I think bug 105650 has more detailed information for this, so close this
bug.

*** This bug has been marked as a duplicate of bug 105650 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Khaled Hosny  changed:

   What|Removed |Added

Version|5.2.2.2 release |Inherited From OOo

--- Comment #3 from Khaled Hosny  ---
The underlying issue is as old as this code base, it started showing up on Mac
because we no longer use Core Text (which uses floats for glyph positions) and
share the same code on all platforms.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105992] FORMATTING: Writer doesn' t use kerning information of Times New Roman anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105992

--- Comment #1 from tob...@schula.org ---
Created attachment 131196
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131196=edit
difference between 5.2 and 5.3

Screenshot shows difference in rendering of Times New Roman between Libreoffice
5.2 and 5.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105992] New: FORMATTING: Writer doesn' t use kerning information of Times New Roman anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105992

Bug ID: 105992
   Summary: FORMATTING: Writer doesn't use kerning information of
Times New Roman anymore
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: x86 (IA32)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tob...@schula.org

Description:
Starting in Version 5.3, Writer doesn't use the kerning information of Times
New Roman anymore. So opening old documents results in changed line breaks,
changed paragraph breaks and changed page breaks. I'm on Linux and are using
the font from the MS Core Fonts for the Web, hence version 2.82 from 2000, so
they're quite old. Is this a side effect of the new layout engine? 
It used to work in versions prior to 5.3, it's also showing this behavior when
running the windows version of 5.3 in wine. Furthermore the font is no longer
metrically compatible to Liberation Serif and Tinos anymore, but only in
Libreoffice. Other programs like Firefox still show all the kerning pairs.



Steps to Reproduce:
1. Install LibreOffice 5.3
2. Install MS Core Fonts
3. Type Text in Writer

Actual Results:  
There is no kerning in pairs like Vo, Te, Av, etc.

Expected Results:
Kerning should be used like in versions prior to 5.3


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105991] Changing legend's font changes also the legend position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105991

--- Comment #1 from Tamás Zolnai  ---
Created attachment 131195
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131195=edit
Test document with a chart

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105991] New: Changing legend's font changes also the legend position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105991

Bug ID: 105991
   Summary: Changing legend's font changes also the legend
position
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Chart
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zolnaitamas2...@gmail.com

Description:
When I open the test document and try to change the legend font properties (in
chart edit mode) the legend position is also changes when closing Legend dialog
(legend is repositioned to the left side of the chart area).

Steps to Reproduce:
1. Open attached test document
2. Double click on chart -> enter into edit mode
3. Double click on legend -> Legend dialog is opened
4. Change font type on Font tab page
-> Font type changes, but Legend also moves to the left.

Actual Results:  
Legend position changes when I set a new font type.

Expected Results:
Legend position should not change.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/56.0.2924.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105657] Option 'Precision as shown' working absurdly with formats from the 'Fraction' category..

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105657

Laurent BP  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr
   |desktop.org |

--- Comment #5 from Laurent BP  ---
(In reply to Laurent BP from comment #4)
> If numerator length is larger than denominator length, there is no bug. To
> avoid extra blank, replace numerator with many #
> # /? or # /?? or # /???
Actually, Precision is taken from NumFor[0].nCntPost
http://opengrok.libreoffice.org/xref/core/sc/source/core/data/documen4.cxx#RoundValueAsShown
 which is not correct for fraction. It should be nCntExp like here:
http://opengrok.libreoffice.org/xref/core/svl/source/numbers/zformat.cxx#GetNumForInfo

However, I noticed another bug for "Precision as shown": it takes precision
from the first sub-format, which may be wrong with such (strange) format:
0.00;-0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

docker image

[Pierre Ozoux]

Hi,

and thanks to release the docker image on the hub, to help us host libre
office online!

I have 2 questions:
 - where is the Dockerfile
 - are you interested in having this image "official" on the dockerhub?

Have a nice evening!

Pierre

-- 
I use PGP to protect our privacy, if you want to know more, you can
follow this
https://emailselfdefense.fsf.org/en/

If you have further questions, please do not hesitate to ask.
You can verify my public key here: https://keybase.io/pierreozoux



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: writerperfect/CppunitTest_writerperfect_wpftimport.mk writerperfect/Module_writerperfect.mk writerperfect/qa

[David Tardon]

 writerperfect/CppunitTest_writerperfect_wpftimport.mk |   52 ++
 writerperfect/Module_writerperfect.mk |1 
 writerperfect/qa/unit/TextImportTest.cxx  |  142 ++
 writerperfect/qa/unit/WpftLoader.cxx  |   40 -
 writerperfect/qa/unit/WpftLoader.hxx  |   12 +
 writerperfect/qa/unit/wpftimport.cxx  |   28 +++
 writerperfect/qa/unit/wpftimport.hxx  |   33 
 7 files changed, 301 insertions(+), 7 deletions(-)

New commits:
commit 1f7441211a5aa3c6ef379ae10b192a162ea6bdc8
Author: David Tardon 
Date:   Mon Feb 13 22:51:31 2017 +0100

test result of text document import

Change-Id: I6830da0c6692f0be212e0d45597fa563917b5fb2

diff --git a/writerperfect/CppunitTest_writerperfect_wpftimport.mk 
b/writerperfect/CppunitTest_writerperfect_wpftimport.mk
new file mode 100644
index 000..529f953
--- /dev/null
+++ b/writerperfect/CppunitTest_writerperfect_wpftimport.mk
@@ -0,0 +1,52 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,writerperfect_wpftimport))
+
+$(eval $(call gb_CppunitTest_set_include,writerperfect_wpftimport,\
+   -I$(SRCDIR)/writerperfect/inc \
+   -I$(SRCDIR)/writerperfect/source/writer \
+   $$(INCLUDE) \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,writerperfect_wpftimport,\
+   odfgen \
+   revenge \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,writerperfect_wpftimport))
+
+$(eval $(call gb_CppunitTest_use_libraries,writerperfect_wpftimport,\
+   comphelper \
+   cppu \
+   cppuhelper \
+   sal \
+   test \
+   unotest \
+   utl \
+   wpftqahelper \
+   writerperfect \
+   $(gb_UWINAPI) \
+))
+
+$(eval $(call gb_CppunitTest_use_ure,writerperfect_wpftimport))
+$(eval $(call gb_CppunitTest_use_vcl,writerperfect_wpftimport))
+
+$(eval $(call gb_CppunitTest_use_rdbs,writerperfect_wpftimport,\
+   services \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,writerperfect_wpftimport))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,writerperfect_wpftimport,\
+   writerperfect/qa/unit/TextImportTest \
+   writerperfect/qa/unit/wpftimport \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/writerperfect/Module_writerperfect.mk 
b/writerperfect/Module_writerperfect.mk
index 3c6168e..0b86208 100644
--- a/writerperfect/Module_writerperfect.mk
+++ b/writerperfect/Module_writerperfect.mk
@@ -34,6 +34,7 @@ $(eval $(call gb_Module_add_l10n_targets,writerperfect,\
 
 $(eval $(call gb_Module_add_check_targets,writerperfect,\
CppunitTest_writerperfect_stream \
+   CppunitTest_writerperfect_wpftimport \
 ))
 
 $(eval $(call gb_Module_add_slowcheck_targets,writerperfect,\
diff --git a/writerperfect/qa/unit/TextImportTest.cxx 
b/writerperfect/qa/unit/TextImportTest.cxx
new file mode 100644
index 000..fdd17c1
--- /dev/null
+++ b/writerperfect/qa/unit/TextImportTest.cxx
@@ -0,0 +1,142 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include 
+
+#include "DocumentHandlerForOdt.hxx"
+#include "ImportFilter.hxx"
+#include "WpftFilterFixture.hxx"
+#include "WpftLoader.hxx"
+#include "wpftimport.hxx"
+
+namespace
+{
+
+namespace uno = css::uno;
+
+class TextImportFilter : public writerperfect::ImportFilter
+{
+public:
+explicit TextImportFilter(const uno::Reference< uno::XComponentContext > 
)
+: writerperfect::ImportFilter(rxContext) {}
+
+// XServiceInfo
+virtual rtl::OUString SAL_CALL getImplementationName() override;
+virtual sal_Bool SAL_CALL supportsService(const rtl::OUString 
) override;
+virtual uno::Sequence< rtl::OUString > SAL_CALL getSupportedServiceNames() 
override;
+
+private:
+virtual bool doDetectFormat(librevenge::RVNGInputStream , 
rtl::OUString ) override;
+virtual bool doImportDocument(librevenge::RVNGInputStream , 
OdtGenerator , utl::MediaDescriptor ) override;
+
+void generate(librevenge::RVNGTextInterface ) const;
+};
+
+bool TextImportFilter::doImportDocument(librevenge::RVNGInputStream &, 
OdtGenerator , utl::MediaDescriptor &)
+{
+generate(rGenerator);
+return true;
+}
+
+bool TextImportFilter::doDetectFormat(librevenge::RVNGInputStream &, 
rtl::OUString )
+{
+rTypeName = "WpftDummyText";
+return true;

[Libreoffice-bugs] [Bug 105990] Can' t type special characters using CRTL+ALT under Windows 7 Home Premium 64bit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105990

ab1...@gmx.de changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105990] New: Can' t type special characters using CRTL+ALT under Windows 7 Home Premium 64bit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105990

Bug ID: 105990
   Summary: Can't type special characters using CRTL+ALT under
Windows 7 Home Premium 64bit
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ab1...@gmx.de

I use LibreOffice 5.6.2.1 under Windows 7 Home Premium 64bit (German language).
When I try to type special characters like brackets via pressing CTRL + ALT +
one of the number keys (German keyboard layout), nothing happens. The problem
does not occur in Calc, Impress, nor the Windows text editor. It also does not
occur under Ubuntu 14.04 nor 16.04, so I think it is a problem of LibreOffice
unter Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/mathematical/fods/rawsubtract.fods | 4776 +
 sc/qa/unit/data/functions/statistical/fods/t.inv.2t.fods | 5355 +++
 2 files changed, 10131 insertions(+)

New commits:
commit d9b6edc0981c3f064d580df53e35dec11809afc5
Author: Zdeněk Crhonek 
Date:   Mon Feb 13 18:34:40 2017 +0100

add RAWSUBTRACT test case

Change-Id: I338823f626d16dbc435a7b7efe0e5f1e30bf3497
Reviewed-on: https://gerrit.libreoffice.org/34221
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/mathematical/fods/rawsubtract.fods 
b/sc/qa/unit/data/functions/mathematical/fods/rawsubtract.fods
new file mode 100644
index 000..588c8f1
--- /dev/null
+++ b/sc/qa/unit/data/functions/mathematical/fods/rawsubtract.fods
@@ -0,0 +1,4776 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2017-02-13T17:55:32.263157328P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/2aea0d0148ea0940da2b32387c330f9aa590294c
+ 
+  
+   0
+   0
+   42024
+   6896
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+  
+   2
+   12
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 100
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -

[Libreoffice-commits] core.git: sc/qa sc/source

[Mike Kaganski]

 sc/qa/extras/anchor.cxx   |   37 +
 sc/source/ui/docshell/docfunc.cxx |3 +++
 sc/source/ui/docshell/docsh5.cxx  |5 +
 sc/source/ui/undo/undobase.cxx|   11 ++-
 sc/source/ui/undo/undoblk.cxx |2 ++
 sc/source/ui/undo/undoblk3.cxx|6 +-
 sc/source/ui/view/viewfun2.cxx|7 +++
 7 files changed, 69 insertions(+), 2 deletions(-)

New commits:
commit 36ef9f8d077afe2c605e9d22588dc3f698440d89
Author: Mike Kaganski 
Date:   Sun Feb 12 01:58:23 2017 +0300

tdf#76183: refresh objects' positions on optimal height recalc

Since commit b10833d4db6046f2d32ea44a60cb19a626d80447, it's required
to detect when objects' placement should be adjusted, and call
SetDrawPageSize manually.
Unit test included

Change-Id: I933ba4802b212400cc47ed0fb7e1f8f44049bb81
Reviewed-on: https://gerrit.libreoffice.org/34165
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sc/qa/extras/anchor.cxx b/sc/qa/extras/anchor.cxx
index b5310ab..04e06cb 100644
--- a/sc/qa/extras/anchor.cxx
+++ b/sc/qa/extras/anchor.cxx
@@ -13,10 +13,15 @@
 #include 
 
 #include 
+#include 
+#include 
+#include 
 #include 
 
 #include "tabvwsh.hxx"
 #include "docsh.hxx"
+#include "svx/svdocirc.hxx"
+#include "scitems.hxx"
 
 #include "sc.hrc"
 
@@ -32,9 +37,11 @@ public:
 virtual void tearDown() override;
 
 void testUndoAnchor();
+void testTdf76183();
 
 CPPUNIT_TEST_SUITE(ScAnchorTest);
 CPPUNIT_TEST(testUndoAnchor);
+CPPUNIT_TEST(testTdf76183);
 CPPUNIT_TEST_SUITE_END();
 private:
 
@@ -148,6 +155,36 @@ void ScAnchorTest::testUndoAnchor()
 xComponent->dispose();
 }
 
+void ScAnchorTest::testTdf76183()
+{
+uno::Reference< lang::XComponent > xComponent = 
loadFromDesktop("private:factory/scalc");
+SfxObjectShell* pFoundShell = 
SfxObjectShell::GetShellFromComponent(xComponent);
+ScDocShell* pDocSh = dynamic_cast(pFoundShell);
+ScDocument& rDoc = pDocSh->GetDocument();
+ScDrawLayer* pDrawLayer = rDoc.GetDrawLayer();
+SdrPage *pPage = pDrawLayer->GetPage(0);
+
+// Add a circle somewhere below first row.
+const Rectangle aOrigRect = Rectangle(1000, 1000, 1200, 1200);
+SdrCircObj* pObj = new SdrCircObj(OBJ_CIRC, aOrigRect);
+pPage->InsertObject(pObj);
+// Anchor to cell
+ScDrawLayer::SetCellAnchoredFromPosition(*pObj, rDoc, 0);
+const Rectangle& rNewRect = pObj->GetLogicRect();
+
+// Set word wrap to true
+rDoc.ApplyAttr(0, 0, 0, SfxBoolItem(ATTR_LINEBREAK, true));
+// Add multi-line text to cell to initiate optimal height change
+uno::Reference xDoc(xComponent, 
uno::UNO_QUERY_THROW);
+uno::Reference xIA(xDoc->getSheets(), 
uno::UNO_QUERY_THROW);
+uno::Reference xSheet(xIA->getByIndex(0), 
uno::UNO_QUERY_THROW);
+uno::Reference xText(xSheet->getCellByPosition(0, 0), 
uno::UNO_QUERY_THROW);
+xText->setString("first\nsecond\nthird");
+
+// The resize of first row must have moved the object down after its 
anchor cell
+CPPUNIT_ASSERT(aOrigRect.Top() < rNewRect.Top());
+}
+
 void ScAnchorTest::tearDown()
 {
 if (mxComponent.is())
diff --git a/sc/source/ui/docshell/docfunc.cxx 
b/sc/source/ui/docshell/docfunc.cxx
index 4677738..671b400 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -151,6 +151,9 @@ bool ScDocFunc::AdjustRowHeight( const ScRange& rRange, 
bool bPaint )
 
 sc::RowHeightContext aCxt(aProv.GetPPTX(), aProv.GetPPTY(), aOne, aOne, 
aProv.GetDevice());
 bool bChanged = rDoc.SetOptimalHeight(aCxt, nStartRow, nEndRow, nTab);
+// tdf#76183: recalculate objects' positions
+if (bChanged)
+rDoc.SetDrawPageSize(nTab);
 
 if ( bPaint && bChanged )
 rDocShell.PostPaint(ScRange(0, nStartRow, nTab, MAXCOL, MAXROW, nTab),
diff --git a/sc/source/ui/docshell/docsh5.cxx b/sc/source/ui/docshell/docsh5.cxx
index 8313311..9322a38 100644
--- a/sc/source/ui/docshell/docsh5.cxx
+++ b/sc/source/ui/docshell/docsh5.cxx
@@ -394,7 +394,12 @@ bool ScDocShell::AdjustRowHeight( SCROW nStartRow, SCROW 
nEndRow, SCTAB nTab )
 bool bChange = aDocument.SetOptimalHeight(aCxt, nStartRow,nEndRow, nTab);
 
 if (bChange)
+{
+// tdf#76183: recalculate objects' positions
+aDocument.SetDrawPageSize(nTab);
+
 PostPaint( 0,nStartRow,nTab, MAXCOL,MAXROW,nTab, 
PaintPartFlags::Grid|PaintPartFlags::Left );
+}
 
 return bChange;
 }
diff --git a/sc/source/ui/undo/undobase.cxx b/sc/source/ui/undo/undobase.cxx
index c2b4b69..036cdd9 100644
--- a/sc/source/ui/undo/undobase.cxx
+++ b/sc/source/ui/undo/undobase.cxx
@@ -313,10 +313,14 @@ bool ScBlockUndo::AdjustHeight()
 aCxt, aBlockRange.aStart.Row(), aBlockRange.aEnd.Row(), 
aBlockRange.aStart.Tab());
 
 if (bRet)
+{
+// tdf#76183: recalculate objects' 

[Libreoffice-commits] core.git: Makefile.in Repository.mk vcl/Executable_pcxfuzzer.mk vcl/Module_vcl.mk vcl/workben

[Caolán McNamara]

 Makefile.in |2 -
 Repository.mk   |1 
 vcl/Executable_pcxfuzzer.mk |   47 
 vcl/Module_vcl.mk   |1 
 vcl/workben/pcxfuzzer.cxx   |   24 ++
 5 files changed, 74 insertions(+), 1 deletion(-)

New commits:
commit f9ead4c6612b3e36b56f2cb83602f019ccaf1dc4
Author: Caolán McNamara 
Date:   Mon Feb 13 09:42:41 2017 +

add pcx fuzzer

Change-Id: I861a64938a73f625ae190d18aee15dc57ac4d97d

diff --git a/Makefile.in b/Makefile.in
index 1f204c3..6beef0e 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -438,7 +438,7 @@ $(foreach ide,\
 eclipsecdt,\
 $(eval $(call gb_Top_GbuildToIdeIntegrationNS,$(ide
 
-fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg 
StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi 
Library_clew Library_gie Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer 
Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer
+fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg 
StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi 
Library_clew Library_gie Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer 
Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer 
Executable_pcxfuzzer
 
 endif # MAKE_RESTARTS
 
diff --git a/Repository.mk b/Repository.mk
index 988a218..e612fc7 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -108,6 +108,7 @@ $(eval $(call 
gb_Helper_register_executables_for_install,OOO,brand, \
$(call gb_Helper_optional,FUZZERS,psdfuzzer) \
$(call gb_Helper_optional,FUZZERS,epsfuzzer) \
$(call gb_Helper_optional,FUZZERS,pctfuzzer) \
+   $(call gb_Helper_optional,FUZZERS,pcxfuzzer) \
$(if $(filter-out ANDROID IOS MACOSX WNT,$(OS)),oosplash) \
soffice_bin \
$(if $(filter DESKTOP,$(BUILD_TYPE)),unopkg_bin) \
diff --git a/vcl/Executable_pcxfuzzer.mk b/vcl/Executable_pcxfuzzer.mk
new file mode 100644
index 000..ef89945
--- /dev/null
+++ b/vcl/Executable_pcxfuzzer.mk
@@ -0,0 +1,47 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+include $(SRCDIR)/vcl/commonfuzzer.mk
+
+$(eval $(call gb_Executable_Executable,pcxfuzzer))
+
+$(eval $(call gb_Executable_use_api,pcxfuzzer,\
+offapi \
+udkapi \
+))
+
+$(eval $(call gb_Executable_use_externals,pcxfuzzer,\
+   $(fuzzer_externals) \
+))
+
+$(eval $(call gb_Executable_set_include,pcxfuzzer,\
+$$(INCLUDE) \
+-I$(SRCDIR)/vcl/inc \
+))
+
+$(eval $(call gb_Executable_use_libraries,pcxfuzzer,\
+   $(fuzzer_libraries) \
+))
+
+$(eval $(call gb_Executable_use_static_libraries,pcxfuzzer,\
+findsofficepath \
+ulingu \
+fuzzer \
+))
+
+$(eval $(call gb_Executable_add_exception_objects,pcxfuzzer,\
+   vcl/workben/pcxfuzzer \
+))
+
+$(eval $(call gb_Executable_add_libs,pcxfuzzer,\
+   -lFuzzingEngine \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 3cd29db..ccdac69 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -121,6 +121,7 @@ $(eval $(call gb_Module_add_targets,vcl,\
 Executable_psdfuzzer \
 Executable_epsfuzzer \
 Executable_pctfuzzer \
+Executable_pcxfuzzer \
 ))
 endif
 
diff --git a/vcl/workben/pcxfuzzer.cxx b/vcl/workben/pcxfuzzer.cxx
new file mode 100644
index 000..3e11bef
--- /dev/null
+++ b/vcl/workben/pcxfuzzer.cxx
@@ -0,0 +1,24 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * 

[Libreoffice-bugs] [Bug 105960] Can not select properly a custom page size for printing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105960

--- Comment #10 from Francisco  ---
(In reply to Buovjaga from comment #9)
> Ok, what about bug 94343 ?

Good! So there's a workaround for the bug there: one has to manually check "Use
only paper size from printer preferences."

However, I found it difficult to figure out how one could realize that the
option "paper size" is deactivated because a configuration in the Options tab.
It was active in LibO 3.5 and 4.1 (though not working properly in the last
one).

Probably, solving bug 94343 would solve this one, as it could make easier to
figure it out how to reactivate the Page size dropdown.

So, duplicate?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: embeddedobj/source

[Stephan Bergmann]

 embeddedobj/source/commonembedding/persistence.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ea5fffddcfc6d8741c5492b227daddae1874f100
Author: Stephan Bergmann 
Date:   Mon Feb 13 22:13:42 2017 +0100

Remove misguided comment

...introduced with 7757a18cfd77996f4ce8aef2cbb8c70425ae92da "INTEGRATION: 
CWS
oj14", but for one !xDoc.is() is explicitly handled below, and for another
xLoadable is only used if !xDoc.is().  So the requirement is apparently 
that not
both are null, indeed.

Change-Id: I1b59e99c86c88c5266b33e9ff782054fa40dd34d

diff --git a/embeddedobj/source/commonembedding/persistence.cxx 
b/embeddedobj/source/commonembedding/persistence.cxx
index 6acde54..26faa84 100644
--- a/embeddedobj/source/commonembedding/persistence.cxx
+++ b/embeddedobj/source/commonembedding/persistence.cxx
@@ -498,7 +498,7 @@ uno::Reference< util::XCloseable > 
OCommonEmbeddedObject::LoadDocumentFromStorag
 
 uno::Reference< frame::XLoadable > xLoadable( xDocument, uno::UNO_QUERY );
 uno::Reference< document::XStorageBasedDocument > xDoc( xDocument, 
uno::UNO_QUERY );
-if ( !xDoc.is() && !xLoadable.is() ) ///BUG: This should be || instead of 
&& ?
+if ( !xDoc.is() && !xLoadable.is() )
 throw uno::RuntimeException();
 
 ::comphelper::NamedValueCollection aLoadArgs;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - sw/qa

[Mike Kaganski]

 sw/qa/extras/uiwriter/uiwriter.cxx |   17 +
 1 file changed, 5 insertions(+), 12 deletions(-)

New commits:
commit a1bd94fc01641989e83ea177ac57ccdbacf43c8b
Author: Mike Kaganski 
Date:   Tue Feb 14 00:04:16 2017 +1000

fix unit test

Change-Id: Id7ed11ae03da5e28a4c40fb4fa3019dd6fae89bf
Reviewed-on: https://gerrit.libreoffice.org/34224
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index c50e26a..f159d03 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -93,6 +93,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 static const char* DATA_DIRECTORY = "/sw/qa/extras/uiwriter/data/";
@@ -2628,21 +2629,18 @@ void SwUiWriterTest::testTdf88899()
 
 void SwUiWriterTest::testTdf90362()
 {
+// First check if the end of the second paragraph is indeed protected.
 SwDoc* pDoc = createDoc("tdf90362.fodt");
 SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
-uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
-// Ensure correct initial setting
-comphelper::ConfigurationHelper::writeDirectKey(xComponentContext, 
"org.openoffice.Office.Writer/", "Cursor/Option", "IgnoreProtectedArea", 
css::uno::Any(false), comphelper::EConfigurationModes::Standard);
-// First check if the end of the second paragraph is indeed protected.
 pWrtShell->EndPara();
 pWrtShell->Down(/*bSelect=*/false);
 CPPUNIT_ASSERT_EQUAL(true, pWrtShell->HasReadonlySel());
 
 // Then enable ignoring of protected areas and make sure that this time 
the cursor is read-write.
-comphelper::ConfigurationHelper::writeDirectKey(xComponentContext, 
"org.openoffice.Office.Writer/", "Cursor/Option", "IgnoreProtectedArea", 
css::uno::Any(true), comphelper::EConfigurationModes::Standard);
+SwViewOption aViewOptions(*pWrtShell->GetViewOptions());
+aViewOptions.SetIgnoreProtectedArea(true);
+pWrtShell->ApplyViewOptions(aViewOptions);
 CPPUNIT_ASSERT_EQUAL(false, pWrtShell->HasReadonlySel());
-// Clean up, otherwise following tests will have that option set
-comphelper::ConfigurationHelper::writeDirectKey(xComponentContext, 
"org.openoffice.Office.Writer/", "Cursor/Option", "IgnoreProtectedArea", 
css::uno::Any(false), comphelper::EConfigurationModes::Standard);
 }
 
 void SwUiWriterTest::testUndoCharAttribute()
@@ -3564,11 +3562,6 @@ void SwUiWriterTest::testTdf105625()
 {
 SwDoc* pDoc = createDoc("tdf105625.fodt");
 SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
-uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
-// Ensure correct initial setting
-comphelper::ConfigurationHelper::writeDirectKey(xComponentContext,
-"org.openoffice.Office.Writer/", "Cursor/Option", 
"IgnoreProtectedArea",
-css::uno::Any(false), comphelper::EConfigurationModes::Standard);
 // We should be able to edit at positions adjacent to fields.
 // Check if the start and the end of the 1st paragraph are not protected
 // (they are adjacent to FORMCHECKBOX)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105989] New: Sound file starts automatically

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105989

Bug ID: 105989
   Summary: Sound file starts automatically
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sebastian.jentsc...@gmail.com

I am (desperately) trying to embed two sound files on one Impress slide.
Expected behaviour is that the file starts when it is clicked.
However, there is no way to do so.

What I tried:

[1] Insert -> Audio or Video (first file starts automatically, second file is
not played when clicked on)

[2] Create an graphic object (box), right click -> Interaction - Play sound
(does not work, goes onwards to the next slide when in Presentation mode;
strangely, when not in Presentation mode, it works)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: offapi/com

[Tomaž Vajngerl]

 offapi/com/sun/star/chart2/data/XDataReceiver.idl |2 ++
 offapi/com/sun/star/chart2/data/XPopupRequest.idl |3 +++
 2 files changed, 5 insertions(+)

New commits:
commit 7704b2f0a89fe04d089cd66e9e7ca91a64e1bacf
Author: Tomaž Vajngerl 
Date:   Sun Feb 12 22:32:30 2017 +0100

comment XPopupRequest API

Change-Id: I7a539bce74bba7b299ae75a2525a2c0d1249894a
Reviewed-on: https://gerrit.libreoffice.org/34189
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/offapi/com/sun/star/chart2/data/XDataReceiver.idl 
b/offapi/com/sun/star/chart2/data/XDataReceiver.idl
index 2ff7427..9238bba 100644
--- a/offapi/com/sun/star/chart2/data/XDataReceiver.idl
+++ b/offapi/com/sun/star/chart2/data/XDataReceiver.idl
@@ -88,6 +88,8 @@ interface XDataReceiver : ::com::sun::star::uno::XInterface
  */
 XRangeHighlighter getRangeHighlighter();
 
+/** A callback object to execute a foreign popup menu window.
+*/
 XPopupRequest getPopupRequest();
 };
 
diff --git a/offapi/com/sun/star/chart2/data/XPopupRequest.idl 
b/offapi/com/sun/star/chart2/data/XPopupRequest.idl
index e329465..0711678 100644
--- a/offapi/com/sun/star/chart2/data/XPopupRequest.idl
+++ b/offapi/com/sun/star/chart2/data/XPopupRequest.idl
@@ -24,6 +24,9 @@ module chart2
 module data
 {
 
+/**
+@since LibreOffice 5.4
+ */
 interface XPopupRequest : com::sun::star::awt::XRequestCallback
 {
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105689] Emoji not available

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105689

--- Comment #10 from dieterp  ---
It's not only a problem in Writer but also in Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - chart2/source sc/source

[Tomaž Vajngerl]

 chart2/source/controller/dialogs/RangeSelectionHelper.cxx |   11 ---
 sc/source/ui/inc/dbfunc.hxx   |1 
 sc/source/ui/inc/gridwin.hxx  |7 +-
 sc/source/ui/inc/tabview.hxx  |1 
 sc/source/ui/view/dbfunc3.cxx |   22 +--
 sc/source/ui/view/gridwin2.cxx|   42 +-
 sc/source/ui/view/tabview3.cxx|   23 +++
 sc/source/ui/view/tabvwshb.cxx|   33 ++-
 8 files changed, 108 insertions(+), 32 deletions(-)

New commits:
commit 8faff1ee9cbf5d9dd23360bb87b30eaa620c48b5
Author: Tomaž Vajngerl 
Date:   Sat Feb 11 13:30:18 2017 +0100

chart2: remove unneeded includes

Change-Id: I49e15f57e8eddb53dbf4d1b7ddbf6d33fed116f2
Reviewed-on: https://gerrit.libreoffice.org/34172
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/chart2/source/controller/dialogs/RangeSelectionHelper.cxx 
b/chart2/source/controller/dialogs/RangeSelectionHelper.cxx
index addc52a..48db808 100644
--- a/chart2/source/controller/dialogs/RangeSelectionHelper.cxx
+++ b/chart2/source/controller/dialogs/RangeSelectionHelper.cxx
@@ -20,18 +20,7 @@
 #include "RangeSelectionHelper.hxx"
 #include "RangeSelectionListener.hxx"
 #include "macros.hxx"
-#include "ControllerLockGuard.hxx"
-#include 
 #include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
 
 using namespace ::com::sun::star;
 
commit a423ed8a474e114d21b81b84b2900099a6527481
Author: Tomaž Vajngerl 
Date:   Tue Feb 7 17:03:26 2017 +0100

base work to trigger pivot table filter popup with a callback

Change-Id: I5b85a760eb1f3f9090fbbd02f5510878ad3c51c2
Reviewed-on: https://gerrit.libreoffice.org/34007
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/sc/source/ui/inc/dbfunc.hxx b/sc/source/ui/inc/dbfunc.hxx
index ad71348..e407580 100644
--- a/sc/source/ui/inc/dbfunc.hxx
+++ b/sc/source/ui/inc/dbfunc.hxx
@@ -86,6 +86,7 @@ public:
 void DataPilotInput( const ScAddress& rPos, const OUString& rString );
 
 voidDataPilotSort( const ScAddress& rPos, bool bAscending, 
sal_uInt16* pUserListId = nullptr );
+voidDataPilotSort(ScDPObject* pDPObject, long nDimIndex, bool 
bAscending, sal_uInt16* pUserListId = nullptr);
 boolDataPilotMove( const ScRange& rSource, const ScAddress& 
rDest );
 
 bool HasSelectionForDrillDown( sal_uInt16& rOrientation );
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index 709b388..dff2da7 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -213,8 +213,8 @@ class ScGridWindow : public vcl::Window, public 
DropTargetHelper, public DragSou
  * mouse event handling is necessary, false otherwise.
  */
 bool DPTestFieldPopupArrow(const MouseEvent& rMEvt, const ScAddress& rPos, 
const ScAddress& rDimPos, ScDPObject* pDPObj);
-voidDPLaunchFieldPopupMenu(
-const Point& rScrPos, const Size& rScrSize, const ScAddress& rPos, 
ScDPObject* pDPObj);
+
+void DPLaunchFieldPopupMenu(const Point& rScrPos, const Size& rScrSize, 
const ScAddress& rPos, ScDPObject* pDPObj);
 
 voidRFMouseMove( const MouseEvent& rMEvt, bool bUp );
 
@@ -364,6 +364,9 @@ public:
 
 css::sheet::DataPilotFieldOrientation GetDPFieldOrientation( SCCOL nCol, 
SCROW nRow ) const;
 
+void DPLaunchFieldPopupMenu(const Point& rScrPos, const Size& rScrSize,
+long nDimIndex, ScDPObject* pDPObj);
+
 void DrawButtons(SCCOL nX1, SCCOL nX2, const ScTableInfo& rTabInfo, 
OutputDevice* pContentDev);
 
 using Window::Draw;
diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index 5afc3d3..d7c659e 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -482,6 +482,7 @@ public:
 voidClearHighlightRanges();
 
 voidDoChartSelection( const css::uno::Sequence< 
css::chart2::data::HighlightedRange > & rHilightRanges );
+voidDoDPFieldPopup(Point aPoint, Size aSize);
 
 longGetGridWidth( ScHSplitPos eWhich );
 longGetGridHeight( ScVSplitPos eWhich );
diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx
index 1a35636..d298d39 100644
--- a/sc/source/ui/view/dbfunc3.cxx
+++ b/sc/source/ui/view/dbfunc3.cxx
@@ -1610,10 +1610,8 @@ struct ScOUStringCollate
 }
 };
 
-void ScDBFunc::DataPilotSort( const ScAddress& rPos, bool bAscending, 
sal_uInt16* pUserListId )
+void ScDBFunc::DataPilotSort(ScDPObject* pDPObj, long nDimIndex, bool 
bAscending, sal_uInt16* pUserListId)
 {
-ScDocument* pDoc 

[Libreoffice-bugs] [Bug 105712] With NVDA active launching Special Character dialog using Insert -> Special Character, or via F7 Spell check causes a fatal error. With using Standard Toolbar button it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105712

V Stuart Foote  changed:

   What|Removed |Added

   Keywords|wantBacktrace   |bibisectRequest,
   ||haveBacktrace
 CC||ja...@nvaccess.org,
   ||marcoz...@fastmail.fm
Version|5.3.0.3 release |5.0.6.3 release
Summary|Launching Special Character |With NVDA active launching
   |dialog button,  Insert ->   |Special Character dialog
   |Special Character or via F7 |using  Insert -> Special
   |Spell check causes a fatal  |Character, or via F7 Spell
   |error   |check causes a fatal error.
   ||With using Standard Toolbar
   ||button it also hangs but
   ||without crash.

--- Comment #17 from V Stuart Foote  ---
Issue of hanging the LO UI opening the Special Character dialog are present
"with NVDA running" on earlier builds of 5.x, no crash noted on a 4.4 install.

Setting bibisect request.

@Jamie - reluctant to NOB this, but any thoughts on why this would only happen
with NVDA active and sounding?

=-Tested-=

LO hangs with NVDA 2016.4 with Windows 8.1 Ent 64-bit with these builds.

Version: 5.3.0.0.beta2+ (x64)
Build ID: 371f0f6770add78ae81e0f769d0490874bca353c
CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; Layout Engine: new; 
TinderBox: Win-x86_64@62-TDF, Branch:libreoffice-5-3, Time: 2016-12-22_13:59:31
Locale: en-US (en_US); Calc: CL

9 Jun 2016
Version: 5.3.0.0.beta2 (x64)
Build ID: a7e30712ad6d8bc9286007b37aa581983e0caba3
CPU Threads: 8; OS Version: Windows 6.29; UI Render: default; Layout Engine:
new; 
Locale: en-US (en_US); Calc: CL

31 Oct 2016
Version: 5.2.3.3 (x64)
Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf
CPU Threads: 8; OS Version: Windows 6.29; UI Render: default; 
Locale: en-US (en_US); Calc: CL

5 May 2016
Version: 5.0.6.3 (x64)
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: en-US (en_US)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105689] Emoji not available

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105689

dieterp  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
Version|unspecified |5.3.0.3 release

--- Comment #9 from dieterp  ---
I confirm the problem with LO 5.3.0 Win 10 x64

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66874] FORMATTING: When paragraphs with and without bullets/ numbering are selected together, there is no tab TAB in dialog Format Paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66874

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #14 from Aron Budea  ---
Still in 5.3.0.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105932] Footnotes should have a space after the number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105932

Heiko Tietze  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---
 Ever confirmed|0   |1

--- Comment #9 from Heiko Tietze  ---
(In reply to Marco A.G.Pinto from comment #5)
> Anyway, this is the last time I will annoy you guys with this subject as
> there are things a lot more important than this.

Please don't stop. Would be a pleasure if more of the tickets are that easy to
solve. But actually you may encounter a round-trip issue. What happens when a
Word document with footnotes is loaded into LibreOffice and saved back again?
If Word handles footnotes incorrectly with need to cover this. QA, please
double check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 105932] Footnotes should have a space after the number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105932

Heiko Tietze  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---
 Ever confirmed|0   |1

--- Comment #9 from Heiko Tietze  ---
(In reply to Marco A.G.Pinto from comment #5)
> Anyway, this is the last time I will annoy you guys with this subject as
> there are things a lot more important than this.

Please don't stop. Would be a pleasure if more of the tickets are that easy to
solve. But actually you may encounter a round-trip issue. What happens when a
Word document with footnotes is loaded into LibreOffice and saved back again?
If Word handles footnotes incorrectly with need to cover this. QA, please
double check.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42982] improve UNO API error reporting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42982

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42982] improve UNO API error reporting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42982

--- Comment #29 from Commit Notification 
 ---
Saurav Sachidanand committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2bcefa7aab176bf18b45e7038e91dd07ced6edf7

tdf#42982 Make UNO error reporting more descriptive

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source

[Saurav Sachidanand]

 basic/source/uno/dlgcont.cxx|8 
 basic/source/uno/namecont.cxx   |   20 
 basic/source/uno/scriptcont.cxx |   22 +++---
 3 files changed, 23 insertions(+), 27 deletions(-)

New commits:
commit 2bcefa7aab176bf18b45e7038e91dd07ced6edf7
Author: Saurav Sachidanand 
Date:   Tue Jan 17 22:16:28 2017 +0530

tdf#42982 Make UNO error reporting more descriptive

Change-Id: I0fae43ca1ab23f35e75fd6b88215940596aae09f
Reviewed-on: https://gerrit.libreoffice.org/33227
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/basic/source/uno/dlgcont.cxx b/basic/source/uno/dlgcont.cxx
index a1a1f05..4bc0380 100644
--- a/basic/source/uno/dlgcont.cxx
+++ b/basic/source/uno/dlgcont.cxx
@@ -369,12 +369,12 @@ Reference< css::resource::XStringResourcePersistence >
 xLibrariesStor = mxStorage->openStorageElement( maLibrariesDir, 
embed::ElementModes::READ );
 // TODO: Should be READWRITE with new storage concept using 
store() instead of storeTo()
 if ( !xLibrariesStor.is() )
-throw uno::RuntimeException();
+throw uno::RuntimeException("null returned from 
openStorageElement");
 
 xLibraryStor = xLibrariesStor->openStorageElement( aLibName, 
embed::ElementModes::READ );
 // TODO: Should be READWRITE with new storage concept using 
store() instead of storeTo()
 if ( !xLibraryStor.is() )
-throw uno::RuntimeException();
+throw uno::RuntimeException("null returned from 
openStorageElement");
 }
 catch(const uno::Exception& )
 {
@@ -422,12 +422,12 @@ void SfxDialogLibraryContainer::onNewRootStorage()
 try {
 xLibrariesStor = mxStorage->openStorageElement( 
maLibrariesDir, embed::ElementModes::READWRITE );
 if ( !xLibrariesStor.is() )
-throw uno::RuntimeException();
+throw uno::RuntimeException("null returned from 
openStorageElement");
 
 OUString aLibName = pDialogLibrary->getName();
 xLibraryStor = xLibrariesStor->openStorageElement( aLibName, 
embed::ElementModes::READWRITE );
 if ( !xLibraryStor.is() )
-throw uno::RuntimeException();
+throw uno::RuntimeException("null returned from 
openStorageElement");
 
 Reference< resource::XStringResourceWithStorage >
 xStringResourceWithStorage( xStringResourcePersistence, 
UNO_QUERY );
diff --git a/basic/source/uno/namecont.cxx b/basic/source/uno/namecont.cxx
index 4cf0c9d..ae83e5a 100644
--- a/basic/source/uno/namecont.cxx
+++ b/basic/source/uno/namecont.cxx
@@ -293,8 +293,7 @@ void SAL_CALL NameContainer::addContainerListener( const 
Reference< XContainerLi
 {
 if( !xListener.is() )
 {
-throw RuntimeException("addContainerListener called with null 
xListener",
-static_cast< cppu::OWeakObject * >(this));
+throw RuntimeException("addContainerListener called with null 
xListener");
 }
 maContainerListeners.addInterface( Reference(xListener, 
UNO_QUERY) );
 }
@@ -303,8 +302,7 @@ void SAL_CALL NameContainer::removeContainerListener( const 
Reference< XContaine
 {
 if( !xListener.is() )
 {
-throw RuntimeException("removeContainerListener called with null 
xListener",
-static_cast< cppu::OWeakObject * >(this));
+throw RuntimeException("removeContainerListener called with null 
xListener");
 }
 maContainerListeners.removeInterface( Reference(xListener, 
UNO_QUERY) );
 }
@@ -314,8 +312,7 @@ void SAL_CALL NameContainer::addChangesListener( const 
Reference< XChangesListen
 {
 if( !xListener.is() )
 {
-throw RuntimeException("addChangesListener called with null xListener",
-static_cast< cppu::OWeakObject * >(this));
+throw RuntimeException("addChangesListener called with null 
xListener");
 }
 maChangesListeners.addInterface( Reference(xListener, 
UNO_QUERY) );
 }
@@ -324,8 +321,7 @@ void SAL_CALL NameContainer::removeChangesListener( const 
Reference< XChangesLis
 {
 if( !xListener.is() )
 {
-throw RuntimeException("removeChangesListener called with null 
xListener",
-static_cast< cppu::OWeakObject * >(this));
+throw RuntimeException("removeChangesListener called with null 
xListener");
 }
 maChangesListeners.removeInterface( Reference(xListener, 
UNO_QUERY) );
 }
@@ -2086,7 +2082,7 @@ void SfxLibraryContainer::storeLibraries_Impl( const 
uno::Reference< embed::XSto
 "The stream must implement XPropertySet!");
 if ( !xProps.is() )
 {
-throw uno::RuntimeException();
+   

[Libreoffice-bugs] [Bug 105712] Launching Special Character dialog button, Insert -> Special Character or via F7 Spell check causes a fatal error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105712

V Stuart Foote  changed:

   What|Removed |Added

Version|5.4.0.0.alpha0+ Master  |5.3.0.3 release
Summary|Pressing the Special|Launching Special Character
   |Character button in the |dialog button,  Insert ->
   |Spell Check dialog causes a |Special Character or via F7
   |fatal error dialog to   |Spell check causes a fatal
   |appear and the program to   |error
   |crash.  |
 OS|All |Windows (All)

--- Comment #16 from V Stuart Foote  ---
This is Windows only while the NVDA screen reader 2016.4 (or 2016.3) is enabled
and sounding.

Launching Special Character dialog button,  Insert -> Special Character, or via
F7 Spell check causes a fatal error.  While using the Standard toolbar "Special
Character" button hangs the UI but without the error popup although the
Breakpad Exception Handler is kicked off.

Any chance of the Python instances coliding?

=-WinDbg 64 while using Standard TB button-=

0:000> !analyze -v
***
* *
*Exception Analysis   *
* *
***


FAULTING_IP: 
+8920be9660
` ??  ???

EXCEPTION_RECORD:   -- (.exr 0x)
ExceptionAddress: 
   ExceptionCode: 8003 (Break instruction exception)
  ExceptionFlags: 
NumberParameters: 0

CONTEXT:   -- (.cxr 0x0;r)
rax=7ff8f582f720 rbx=008060b5f440 rcx=
rdx= rsi=0001 rdi=
rip=7ff91bad26ba rsp=008060b5f3d8 rbp=
 r8=008060b5f3d8  r9= r10=
r11=0246 r12= r13=0001
r14= r15=1244
iopl=0 nv up ei pl zr na po nc
cs=0033  ss=002b  ds=002b  es=002b  fs=0053  gs=002b efl=0246
user32!NtUserGetMessage+0xa:
7ff9`1bad26ba c3  ret

FAULTING_THREAD:  1244

DEFAULT_BUCKET_ID:  STATUS_BREAKPOINT

PROCESS_NAME:  _socket.pyd

ERROR_CODE: (NTSTATUS) 0x8003 - {EXCEPTION}  Breakpoint  A breakpoint has
been reached.

EXCEPTION_CODE: (HRESULT) 0x8003 (2147483651) - One or more arguments are
invalid

NTGLOBALFLAG:  0

APPLICATION_VERIFIER_FLAGS:  0

APP:  _socket.pyd

ANALYSIS_VERSION: 6.3.9600.17336 (debuggers(dbg).150226-1500) amd64fre

PRIMARY_PROBLEM_CLASS:  STATUS_BREAKPOINT

BUGCHECK_STR:  APPLICATION_FAULT_STATUS_BREAKPOINT

LAST_CONTROL_TRANSFER:  from 7ff91bad2685 to 7ff91bad26ba

STACK_TEXT:  
0080`60b5f3d8 7ff9`1bad2685 : ` 7ff9`18e4155c
`fffe 7ff8`f2f0f42c : user32!NtUserGetMessage+0xa
0080`60b5f3e0 7ff8`f2fddf89 : ` `
`0001 ` : user32!GetMessageW+0x25
0080`60b5f410 7ff8`f2fddcf1 : `0001 `0001
`0206 7ff8`f2fddc1f : mergedlo!ImplSalYield+0xc9
0080`60b5f480 7ff8`f2f0a126 : 0080`60d752f0 7ff8`f582f720
` 0080`60cd1ba0 : mergedlo!WinSalInstance::DoYield+0xf1
0080`60b5f4e0 7ff8`f2f0871d : 0080`66885400 0080`6aec0420
7ff9`09053750 0080`60d75440 : mergedlo!ImplYield+0x86
0080`60b5f540 7ff8`f1f74c99 : 0080` 0080`64a29718
` ` : mergedlo!Application::Execute+0x13d
0080`60b5f5a0 7ff8`f2f1062e : 0080`635312b0 `
`0001 7ff8`f582f720 : mergedlo!desktop::Desktop::Main+0x10f9
0080`60b5f820 7ff8`f2f109d2 : ` `
`0001 ` : mergedlo!ImplSVMain+0x6e
0080`60b5f860 7ff8`f1f92cfd : ` `0001
0080`60f35328 ` : mergedlo!SVMain+0x32
0080`60b5f890 7ff7`4151102e : 0080`60cf4350 7ff9`1bc557d0
0080`60cd37c5 `0001 : mergedlo!soffice_main+0x11d
0080`60b5fae0 7ff7`4151139d : 0080`60cd37c3 `0001
`0001 ` : soffice+0x102e
0080`60b5fb10 7ff9`193a13d2 : 7ff7`41511240 7ff7`406ef000
` ` : soffice!main+0x35d
0080`60b5fb50 7ff9`1bc654e4 : 7ff9`193a13b0 `
` ` : kernel32!BaseThreadInitThunk+0x22

[Libreoffice-bugs] [Bug 99617] FILEOPEN pptx animation "rotate" is wrongly converted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99617

--- Comment #3 from Regina Henschel  ---
"from" and "to" need the same converting. A suitable place for adding a common
converting function is in include/oox/drawingml/drawingmltypes.hxx.
[I do not assign the issue to me, because I do not know, whether I will have
enough time in the near future to write and test the code.]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Tool for converting PowerPoint angle to degree

[Regina Henschel]

Hi Tomaž,

Tomaž Vajngerl schrieb:


Seems like there is a good place in
include/oox/drawingml/drawingmltypes.hxx (where EMU to 100th
conversion is) and as far as I see PER_DEGREE constant is what you are
searching for. If you'll add a conversion method I think it is best to
add it into this header too.



I'll add it there. It looks indeed suitable.

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105988] New: Improve help for "Eliminate Points" in section " Edit Points Bar"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105988

Bug ID: 105988
   Summary: Improve help for "Eliminate Points" in section "Edit
Points Bar"
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Draw a polygon with a lot of points in Draw or Impress. Switch to point edit
mode. You should get the "Edit Points Bar", if not you can enable it in menu
View.

This toolbar has on the right side an icon for the command
.uno:BezierEliminatePoints with tooltip "Eliminate Points".

Open the help text for it, e.g. by search for "Eliminate Points".
The text is totally wrong and does not describe the feature.

Especially these parts in the help are nonsense:
"Marks the current point or the selected points for deletion."
 --> The tool does not "mark" anything.
 --> The tool does not work on selected points (plural!)

"If you convert a curve or a polygon with the Convert to Curve icon into a
straight line or ..., it is removed."
 --> The tool "Convert to Curve" is unrelated.

The help text is identical to the text in StarOffice 5.2, beside the
inaccuracies, which slipped in by translations from German to English.

Actually this tool enables a mode where you can interactively delete a point in
a polyline or polygon by dragging the point with the mouse. Look video
https://www.youtube.com/watch?v=QuQSZSCOtAY, around 13:03

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/qa sc/inc sc/source

[Marco Cecchetti]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |   76 +--
 sc/inc/address.hxx  |2 
 sc/source/ui/view/tabview.cxx   |  290 +++-
 3 files changed, 300 insertions(+), 68 deletions(-)

New commits:
commit eb399d69aa5ad0c04affb830a522c5c1f130813f
Author: Marco Cecchetti 
Date:   Wed Nov 30 14:13:15 2016 +0100

LOK - Calc: Increase the row limit to 10.000 rows.

Change-Id: Ie91e4caf33d3b31df4c3de8dc6e78e223dc1e4b3
Reviewed-on: https://gerrit.libreoffice.org/34216
Tested-by: Jenkins 
Reviewed-by: Marco Cecchetti 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 5ea5632..0574fec 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -592,46 +592,79 @@ void DesktopLOKTest::testRowColumnHeaders()
 
 pDocument->pClass->initializeForRendering(pDocument, nullptr);
 
+long nWidth = 0;
+long nHeight = 0;
+pDocument->m_pDocumentClass->getDocumentSize(pDocument, , );
+long nX = rtl::math::round(nWidth / 4.0);
+long nY = rtl::math::round(nHeight / 4.0);
+nWidth = rtl::math::round(nWidth / 2.0);
+nHeight = rtl::math::round(nHeight / 2.0);
+
+std::stringstream aPayload;
+aPayload << ".uno:ViewRowColumnHeaders?x=" << nX << "=" << nY << 
"=" << nWidth << "=" << nHeight;
+
 boost::property_tree::ptree aTree;
-char* pJSON = pDocument->m_pDocumentClass->getCommandValues(pDocument, 
".uno:ViewRowColumnHeaders");
+char* pJSON = pDocument->m_pDocumentClass->getCommandValues(pDocument, 
aPayload.str().c_str());
 std::stringstream aStream(pJSON);
 free(pJSON);
+
 CPPUNIT_ASSERT(!aStream.str().empty());
 
 boost::property_tree::read_json(aStream, aTree);
 sal_Int32 nPrevious = 0;
+bool bFirstHeader = true;
+bool bNotEnoughHeaders = true;
 for (boost::property_tree::ptree::value_type& rValue : 
aTree.get_child("rows"))
 {
 sal_Int32 nSize = 
OString(rValue.second.get("size").c_str()).toInt32();
-CPPUNIT_ASSERT(nSize > 0);
 OString aText(rValue.second.get("text").c_str());
-if (!nPrevious)
-// This failed, as the first item did not contain the text of the 
first row.
-CPPUNIT_ASSERT_EQUAL(OString("1"), aText);
+
+if (bFirstHeader)
+{
+CPPUNIT_ASSERT(nSize <= nY);
+CPPUNIT_ASSERT_EQUAL(OString("11"), aText);
+bFirstHeader = false;
+}
 else
 {
-// Make sure that size is absolute: the first two items have the 
same relative size.
+CPPUNIT_ASSERT(nSize > 0);
 CPPUNIT_ASSERT(nPrevious < nSize);
-break;
+if (nSize > nY + nHeight)
+{
+bNotEnoughHeaders = false;
+break;
+}
 }
 nPrevious = nSize;
 }
+CPPUNIT_ASSERT(!bNotEnoughHeaders);
 
 nPrevious = 0;
+bFirstHeader = true;
+bNotEnoughHeaders = true;
 for (boost::property_tree::ptree::value_type& rValue : 
aTree.get_child("columns"))
 {
 sal_Int32 nSize = 
OString(rValue.second.get("size").c_str()).toInt32();
-CPPUNIT_ASSERT(nSize > 0);
 OString aText(rValue.second.get("text").c_str());
-if (!nPrevious)
-CPPUNIT_ASSERT_EQUAL(OString("A"), aText);
+if (bFirstHeader)
+{
+CPPUNIT_ASSERT(nSize <= nX);
+CPPUNIT_ASSERT_EQUAL(OString("4"), aText);
+bFirstHeader = false;
+}
 else
 {
+CPPUNIT_ASSERT(nSize > 0);
 CPPUNIT_ASSERT(nPrevious < nSize);
-break;
+if (nSize > nX + nWidth)
+{
+bNotEnoughHeaders = false;
+break;
+}
 }
 nPrevious = nSize;
 }
+CPPUNIT_ASSERT(!bNotEnoughHeaders);
 }
 
 void DesktopLOKTest::testHiddenRowHeaders()
@@ -640,29 +673,34 @@ void DesktopLOKTest::testHiddenRowHeaders()
 
 pDocument->pClass->initializeForRendering(pDocument, nullptr);
 
+long nX = 0;
+long nY = 0;
+long nWidth = 0;
+long nHeight = 0;
+pDocument->m_pDocumentClass->getDocumentSize(pDocument, , );
+
+std::stringstream aPayload;
+aPayload << ".uno:ViewRowColumnHeaders?x=" << nX << "=" << nY << 
"=" << nWidth << "=" << nHeight;
+
 boost::property_tree::ptree aTree;
-char* pJSON = pDocument->m_pDocumentClass->getCommandValues(pDocument, 
".uno:ViewRowColumnHeaders");
+char* pJSON = pDocument->m_pDocumentClass->getCommandValues(pDocument, 
aPayload.str().c_str());
 std::stringstream aStream(pJSON);
 free(pJSON);
 CPPUNIT_ASSERT(!aStream.str().empty());
 
 boost::property_tree::read_json(aStream, aTree);
 sal_Int32 nPrevious = 0;
-bool bFirst = true;
+

[Libreoffice-bugs] [Bug 105973] Writer - Line Spacing dropped from Context Menu - Replaced by links to other Menus ?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105973

--- Comment #4 from Thomas Lendo  ---
(In reply to Xisco Faulí from comment #3)
> Hi,
> The decision of removing it from the context menu was made by the UX team.
> You can
> customize the context menu as explained in comment 2.
> Closing as RESOLVED NOTABUG

Are such UX decisions documented in a way that other people can understand it
and to avoid recurring bugs? E.g. a wiki or discussion board ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105932] Footnotes should have a space after the number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105932

--- Comment #8 from Cor Nouws  ---
(In reply to Cor Nouws from comment #7)
> This just confirms what Heiko explains. Please look at the footnote
> paragraph style!

And obviously it's the same in older LibreOffice versions.
Please compare with a footer paragraph style in a new ODT file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 105712] Pressing the Special Character button in the Spell Check dialog causes a fatal error dialog to appear and the program to crash.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105712

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #15 from V Stuart Foote  ---
Created attachment 131194
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131194=edit
WinDbg 64-bit w symbols StackTrace of DMP taken via Taskmanager

Confirming on Windows 8.1 Ent 64-bit en-US with AT NVDA 2016.4 screen reader
active and
Version: 5.3.0.3 (x64)
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
CPU Threads: 8; OS Version: Windows 6.29; UI Render: default; Layout Engine:
new; 
Locale: en-US (en_US); Calc: group

STR as reported. 

1. NVDA a11y screen reader enabled and sounding
2. New Writer document with a few typos.
3. F7 to launch spell check dialog
4. select first mispelling, the "Special Character" button activates
5. select the "Special Character" button action
6. immediate message dialog "LibreOffice 5.3 - Fatal Error"
7. use Taskmanager to "Create dump file"
8. OK to close LibreOffice
9. Open the DMP file in WinDbg and pull StackTrace with "~* kp"
10. run "analyze -v" against the DMP.

Attaching StackTrace (here) and next the DMP file, below is WinDbg analyze -v
of the DMP file. Look to be hitting a breakpoint. For some reason, with NVDA
running the google_breakpad::ExceptionHandler::ExceptionHandlerThreadMain does
not run.

Disabling NVDA 2016.4 and repeating a new document with spelling errors, F7 and
the Special Character dialog immediately pops-open and can be selected.

=-WinDbg analyze -v of crash dump-=

Microsoft (R) Windows Debugger Version 6.3.9600.17336 AMD64
Copyright (c) Microsoft Corporation. All rights reserved.


Loading Dump File [C:\Users\gof509\AppData\Local\Temp\soffice (3).DMP]
User Mini Dump File with Full Memory: Only application data is available

0:000> !analyze -v
***
* *
*Exception Analysis   *
* *
***


FAULTING_IP: 
+8bcad30650
` ??  ???

EXCEPTION_RECORD:   -- (.exr 0x)
ExceptionAddress: 
   ExceptionCode: 8003 (Break instruction exception)
  ExceptionFlags: 
NumberParameters: 0

CONTEXT:   -- (.cxr 0x0;r)
rax=0040 rbx= rcx=7ff8f2fde51b
rdx=7ff8f112 rsi=0001 rdi=002e09e6
rip=7ff91bad104a rsp=004c92d9b918 rbp=004c936ae9e0
 r8=  r9= r10=004c92d9b680
r11=004c92d88000 r12= r13=
r14=0001 r15=
iopl=0 nv up ei pl zr na po nc
cs=0033  ss=002b  ds=002b  es=002b  fs=0053  gs=002b efl=0246
user32!NtUserWaitMessage+0xa:
7ff9`1bad104a c3  ret

FAULTING_THREAD:  0b24

DEFAULT_BUCKET_ID:  STATUS_BREAKPOINT

PROCESS_NAME:  _socket.pyd

ERROR_CODE: (NTSTATUS) 0x8003 - {EXCEPTION}  Breakpoint  A breakpoint has
been reached.

EXCEPTION_CODE: (HRESULT) 0x8003 (2147483651) - One or more arguments are
invalid

NTGLOBALFLAG:  0

APPLICATION_VERIFIER_FLAGS:  0

APP:  _socket.pyd

ANALYSIS_VERSION: 6.3.9600.17336 (debuggers(dbg).150226-1500) amd64fre

PRIMARY_PROBLEM_CLASS:  STATUS_BREAKPOINT

BUGCHECK_STR:  APPLICATION_FAULT_STATUS_BREAKPOINT

LAST_CONTROL_TRANSFER:  from 7ff91bb05b77 to 7ff91bad104a

STACK_TEXT:  
004c`92d9b918 7ff9`1bb05b77 : ` 004c`936ae9e0
`0001 `0001 : user32!NtUserWaitMessage+0xa
004c`92d9b920 7ff9`1bb076e2 : ` 7ff9`1bb08b10
` 7ff9`1badb7cd : user32!DialogBox2+0x212
004c`92d9b9b0 7ff9`1bb099a2 : `00010005 004c`92d9bae9
004c`92d9bd20 ` : user32!InternalDialogBox+0x132
004c`92d9ba10 7ff9`1bb0913d : 7ff9`00c4 7ff9`0103
004c`a4156590 `0001 : user32!SoftModalMessageBox+0xee1
004c`92d9bb50 7ff9`1bb581ba : 7ff9`0904e188 `
004c`9d39c6d0 7ff9`0902c018 : user32!MessageBoxWorker+0x2eb
004c`92d9bd00 7ff9`1bb5822e : 7ff8`f2c0c70a 7ff8`f2fd995e
004c`9d39c6d0 004c`9d34b870 : user32!MessageBoxTimeoutW+0xba
004c`92d9be00 7ff8`f1f71ce4 : 004c`92d9e450 `
004c`92d9e450 004c`92fc99a0 : user32!MessageBoxW+0x4e
004c`92d9be40 7ff8`f3cb88dc : ` 004c`9d34b868
004c`9d39c6c8 7ff9`0f4e3403 : 

[Libreoffice-bugs] [Bug 105932] Footnotes should have a space after the number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105932

--- Comment #8 from Cor Nouws  ---
(In reply to Cor Nouws from comment #7)
> This just confirms what Heiko explains. Please look at the footnote
> paragraph style!

And obviously it's the same in older LibreOffice versions.
Please compare with a footer paragraph style in a new ODT file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105932] Footnotes should have a space after the number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105932

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #7 from Cor Nouws  ---
(In reply to Marco A.G.Pinto from comment #6)

> Just open the .docx and select to insert a footnote.

This just confirms what Heiko explains. Please look at the footnote paragraph
style!
Cheers - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105932] Footnotes should have a space after the number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105932

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #7 from Cor Nouws  ---
(In reply to Marco A.G.Pinto from comment #6)

> Just open the .docx and select to insert a footnote.

This just confirms what Heiko explains. Please look at the footnote paragraph
style!
Cheers - Cor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 105987] OSX 10.11 & LO 5.3: Initials (drop caps) don't work anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105987

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #5 from Aron Budea  ---
At first I thought this might be related to bug 101664, but that started
earlier. Nevertheless, it might be worth to check if its fix had an impact
here.
5.3.1.1 RC build should be out in a few days.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104813] FILEOPEN: DOC: performance regression at import time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104813

--- Comment #12 from Matúš Kukan  ---
(In reply to Buovjaga from comment #11)
> (In reply to Matúš Kukan from comment #10)
> > You need to run 'soffice.bin' directly with valgrind. (not 'soffice' script)
> 
> Yeah, my bad. Now I tried again and let it run for the night. The file had
> opened, but was somehow frozen. When I killed LibO, the callgrind file
> remained 0 bytes.

Yeah, I also sometimes had empty file after killing :(. But last time pressing
Ctrl+C in terminal worked fine.
Have you followed
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_callgrind_trace
?
Oh, now I see it's not mentioned there.. If you also do 'export
OOO_EXIT_POST_STARTUP=1' LibreOffice will quit after opening the file, so you
don't have to exit it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99286] Cropped image disappear after compress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99286

Gérald Maruccia  changed:

   What|Removed |Added

Version|5.2.0.0.alpha0+ |5.1.1.2 rc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99784] EXTENSION MANAGER - freeze / hang when attempting to install extensions on OSX 10.11 and macOS 10.12 by double-click on oxt file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99784

Uwe Altmann  changed:

   What|Removed |Added

Version|4.4.5.2 release |4.3.7.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105987] OSX 10.11 & LO 5.3: Initials (drop caps) don't work anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105987

--- Comment #4 from DeepFlight5  ---
Created attachment 131193
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131193=edit
5.3 printed as PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105987] OSX 10.11 & LO 5.3: Initials (drop caps) don't work anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105987

--- Comment #3 from DeepFlight5  ---
Created attachment 131192
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131192=edit
LO 5.3 no drop caps

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs