[Libreoffice-bugs] [Bug 117849] New: XGridSelectionListener is not working in python

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117849

Bug ID: 117849
   Summary: XGridSelectionListener is not working in python
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: apiuano-lob...@yahoo.gr

Based on
https://ask.libreoffice.org/en/question/67644/looking-to-create-grid-not-table-control-on-base-form/
created a grid inside a dialog.

Tried to convert it to python but XGridSelectionListener is not triggered.

https://bugs.documentfoundation.org/attachment.cgi?id=142334 contains an
example. The grid in dialog works perfect, but selecting any row in grid does
not trigger the required function.

The "Companies" form contains a button with label "Test Dialog Grid" that will
"poke" the value of the first column of the selected row (if OK is pressed).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109269] very slow loading of user-defined dictionary word list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109269

--- Comment #5 from Michael Meeks  ---
Sure - a callgrind would be useful, as you say that is far too slow to load
anything but a gigantic document - there must be somet horrible N^3 or N^2 in
there that we don't need.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107948] Spellchecking language not updated for text element in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107948

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from Buovjaga  ---
Cheers, let's close.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38948] FILESAVE - Calc does not save the solver's model to files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38948

--- Comment #12 from Andrea Ferrari  ---
This bug is still present in Libreoffice 6.0.4.2 (x64)
Regards
Andrea

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107948] Spellchecking language not updated for text element in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107948

--- Comment #8 from f...@foramnagaidhlig.net ---
Yes, that was set to the wrong language, and changing that fixed it.

Since I have been using LibreOffice for a long time now, I can't remember if I
ever touched that setting - it should match the chosen interface language on
first run? But I guess that's an installer bug then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs on Debian 9

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117601

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #17 from Caolán McNamara  ---
what I can reproduce appears to be fixed by the above, backports in gerrit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108320] [META] Calc cells merging and splitting bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108320
Bug 108320 depends on bug 117601, which changed state.

Bug 117601 Summary: Crash in: libstdc++.so.6.0.22 on merge cells in writer with 
TDF .debs on Debian 9
https://bugs.documentfoundation.org/show_bug.cgi?id=117601

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx svx/source sw/inc

[Noel Grandin]

 include/svx/unopage.hxx|3 ++-
 svx/source/unodraw/unopage.cxx |6 +-
 sw/inc/unodraw.hxx |2 +-
 3 files changed, 4 insertions(+), 7 deletions(-)

New commits:
commit 26b27c23d42247695d72167be7729e36a473f644
Author: Noel Grandin 
Date:   Fri May 18 09:47:03 2018 +0200

loplugin:useuniqueptr in SvxDrawPage

Change-Id: Ic0ca03d419cb7124d5076130163de113b29bac9d
Reviewed-on: https://gerrit.libreoffice.org/54848
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/unopage.hxx b/include/svx/unopage.hxx
index eefc11c61b2b..1ca099d797eb 100644
--- a/include/svx/unopage.hxx
+++ b/include/svx/unopage.hxx
@@ -40,6 +40,7 @@
 #include 
 
 #include 
+#include 
 
 class SdrPage;
 class SdrModel;
@@ -70,7 +71,7 @@ class SVX_DLLPUBLIC SvxDrawPage : public 
::cppu::WeakAggImplHelper6< css::drawin
 
 SdrPage*mpPage; //  should be reference
 SdrModel*   mpModel;//  probably not needed -> use from SdrPage
-SdrView*mpView;
+std::unique_ptr mpView;
 
 voidSelectObjectsInView( const css::uno::Reference< 
css::drawing::XShapes >& aShapes, SdrPageView*   pPageView ) throw ();
 voidSelectObjectInView( const css::uno::Reference< 
css::drawing::XShape >& xShape, SdrPageView*  pPageView ) throw();
diff --git a/svx/source/unodraw/unopage.cxx b/svx/source/unodraw/unopage.cxx
index 8f252456b107..15a3b01c5635 100644
--- a/svx/source/unodraw/unopage.cxx
+++ b/svx/source/unodraw/unopage.cxx
@@ -94,11 +94,7 @@ void SvxDrawPage::disposing() throw()
 mpModel = nullptr;
 }
 
-if( mpView )
-{
-delete mpView;
-mpView = nullptr;
-}
+mpView.reset();
 mpPage = nullptr;
 }
 
diff --git a/sw/inc/unodraw.hxx b/sw/inc/unodraw.hxx
index aea0b64ce67c..3612db0b7755 100644
--- a/sw/inc/unodraw.hxx
+++ b/sw/inc/unodraw.hxx
@@ -47,7 +47,7 @@ public:
 const SdrMarkList&  PreGroup(const css::uno::Reference< 
css::drawing::XShapes >& rShapes);
 voidPreUnGroup(const css::uno::Reference< 
css::drawing::XShapeGroup >& rShapeGroup);
 
-SdrView*GetDrawView() {return mpView;}
+SdrView*GetDrawView() {return mpView.get();}
 SdrPageView*GetPageView();
 voidRemovePageView();
 static css::uno::Reference< css::uno::XInterface >   GetInterface( 
SdrObject* pObj );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 63087] Detective "Trace Precedents" or "Trace Dependents" pointing to a different tab does not provide reference cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63087

--- Comment #26 from Andrea Ferrari  ---
Issue still present in Libreoffice Calc 6.0.4.2 (x64)
BR
Andrea

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117848] New: moveToInsertRow does nothing from python

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117848

Bug ID: 117848
   Summary: moveToInsertRow does nothing from python
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: apiuano-lob...@yahoo.gr

Created attachment 142334
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142334=edit
an odb with python and BASIC macro

Based on
https://ask.libreoffice.org/en/question/116286/base-macro-that-opens-a-newclean-record-in-another-form/
I created a macro that opens a form in a add new mode.

After that I tried to convert the macro for python. That never worked. I
include an .odb file that has a Companies form with two buttons, one uses the
BASIC macro and opens the form "correctly" and the other uses the python macro
but never goes to "new record".

moveToInsertRow :does nothing
moveToInsertRow() :gives SQLException
moveToInsertRow(False) :gives error for incorrect number of parameters

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs on Debian 9

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117601

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs on Debian 9

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117601

--- Comment #16 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c12bfe9296b5db66ae7326f1dd99b1aa8fb9d2bb

tdf#117601 a11y crash after merging cells

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

[Caolán McNamara]

 sw/inc/accmap.hxx|3 +++
 sw/source/core/access/acccontext.cxx |6 +-
 sw/source/core/access/accmap.cxx |   11 ---
 3 files changed, 16 insertions(+), 4 deletions(-)

New commits:
commit c12bfe9296b5db66ae7326f1dd99b1aa8fb9d2bb
Author: Caolán McNamara 
Date:   Fri May 25 14:37:03 2018 +0100

tdf#117601 a11y crash after merging cells

this is similar to tdf#87199, in this case the accessibiles for the merged
cells are not visible so not removed when their frame is deleted, but remain
in the cache pointing to invalid frames.

Change-Id: Ibc5b9f27541683b8f3604839fa3d1431380a4039
Reviewed-on: https://gerrit.libreoffice.org/54808
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/inc/accmap.hxx b/sw/inc/accmap.hxx
index fc7f665da383..c78bea3e0e51 100644
--- a/sw/inc/accmap.hxx
+++ b/sw/inc/accmap.hxx
@@ -277,6 +277,9 @@ public:
 Point PixelToCore (const Point& rPoint) const;
 tools::Rectangle CoreToPixel (const tools::Rectangle& rRect) const;
 
+// is there a known accessibility impl cached for the frame
+bool Contains(const SwFrame *pFrame) const;
+
 private:
 /** get mapping mode for LogicToPixel and PixelToLogic conversions
 
diff --git a/sw/source/core/access/acccontext.cxx 
b/sw/source/core/access/acccontext.cxx
index 628ad727dc47..efb6b415d372 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -402,8 +402,12 @@ void SwAccessibleContext::DisposeChildren(const SwFrame 
*pFrame,
 if( pLower )
 {
 ::rtl::Reference< SwAccessibleContext > xAccImpl;
-if( rLower.IsAccessible( GetShell()->IsPreview() ) )
+if (rLower.IsAccessible(GetShell()->IsPreview())
+   // tdf#117601 dispose the darn thing if it ever was 
accessible
+|| GetMap()->Contains(pLower))
+{
 xAccImpl = GetMap()->GetContextImpl( pLower, false );
+}
 if( xAccImpl.is() )
 xAccImpl->Dispose( bRecursive );
 else
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 712b70873507..43cc0974625e 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -2158,6 +2158,11 @@ void SwAccessibleMap::RemoveContext( const SdrObject 
*pObj )
 }
 }
 
+bool SwAccessibleMap::Contains(const SwFrame *pFrame) const
+{
+return (pFrame && mpFrameMap && mpFrameMap->find(pFrame) != 
mpFrameMap->end());
+}
+
 void SwAccessibleMap::A11yDispose( const SwFrame *pFrame,
const SdrObject *pObj,
vcl::Window* pWindow,
@@ -2173,9 +2178,9 @@ void SwAccessibleMap::A11yDispose( const SwFrame *pFrame,
 OSL_ENSURE( !aFrameOrObj.GetSwFrame() || 
aFrameOrObj.GetSwFrame()->IsAccessibleFrame(),
 "non accessible frame should be disposed" );
 
-if (aFrameOrObj.IsAccessible( GetShell()->IsPreview() )
-// fdo#87199 dispose the darn thing if it ever was accessible
-|| (pFrame && mpFrameMap && mpFrameMap->find(pFrame) != 
mpFrameMap->end()))
+if (aFrameOrObj.IsAccessible(GetShell()->IsPreview())
+   // fdo#87199 dispose the darn thing if it ever was accessible
+|| Contains(pFrame))
 {
 ::rtl::Reference< SwAccessibleContext > xAccImpl;
 ::rtl::Reference< SwAccessibleContext > xParentAccImpl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117843] FILEOPEN Image in header in DOCX is shifted downwards

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117843

impreza233  changed:

   What|Removed |Added

 CC||impreza...@gmail.com

--- Comment #4 from impreza233  ---
Created attachment 142333
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142333=edit
Bad alignment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117843] FILEOPEN Image in header in DOCX is shifted downwards

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117843

impreza233  changed:

   What|Removed |Added

Version|6.2.0.0.alpha0+ Master  |6.0.2.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: New Defects reported by Coverity Scan for LibreOffice

[Caolán McNamara]

On Sun, 2018-05-27 at 22:28 +, scan-ad...@coverity.com wrote:
> *** CID 1078573:  Null pointer dereferences  (FORWARD_NULL)
> /sw/source/core/docnode/swbaslnk.cxx

Since 7581730b2795a58d4fe6868e2f61572a91fde293 lcl_CallModify ends
up as...

bool bUpdate = false;
SwGrfNode* pSwGrfNode = nullptr;
if (m_pContentNode->IsGrfNode())
...
else if( m_pContentNode->IsOLENode() )
bUpdate = true;

if (bUpdate)
...
SetGrfFlySize(aGrfSz, pSwGrfNode, aOldSz)

so on the face of it, if its an ole node and not a graphic
SetGrfFlySize now derefs null pSwGrfNode.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 117843] FILEOPEN Image in header in DOCX is shifted downwards

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117843

--- Comment #3 from impreza233  ---
Reproduced it on: 

Versión: 6.0.2.1
Id. de compilación: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: GL; 
Configuración regional: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117847] EDITING: Impress: After changing alignment, previous alignment remains checked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117847

impreza233  changed:

   What|Removed |Added

 Attachment #142331|Three alignments|Two alignments
description||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117847] EDITING: Impress: After changing alignment, previous alignment remains checked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117847

--- Comment #2 from impreza233  ---
Created attachment 142331
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142331=edit
Three alignments

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117847] EDITING: Impress: After changing alignment, previous alignment remains checked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117847

--- Comment #3 from impreza233  ---
Created attachment 142332
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142332=edit
Three alignments on other case

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117847] EDITING: Impress: After changing alignment, previous alignment remains checked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117847

impreza233  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from impreza233  ---
Yes, I can reproduce it, even with three alignements, in LibreOffice 6.0.2.1 on
Windows and in Libreoffice 6.1.0.0.beta1 on Linux Mint. I attach two images
showing the issue. 

Versión: 6.0.2.1
Id. de compilación: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: GL; 
Configuración regional: es-ES (es_ES); Calc: group


Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 3; OS: Linux 4.10; UI render: default; VCL: gtk2; 
Locale: es-ES (es_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117847] EDITING: Impress: After changing alignment, previous alignment remains checked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117847

impreza233  changed:

   What|Removed |Added

Version|unspecified |6.0.2.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106260] EDITING: Cannot copy URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106260

--- Comment #12 from Noel Grandin  ---
I can confirm that the following commit is at fault, I built LO at that version
and the version before it.


https://cgit.freedesktop.org/libreoffice/core/commit/?id=139ca8f26419d4b3e4f478ef8ff7536176c54f1c
author  matteocam  2014-05-31 01:09:50
-0400
committer   Fridrich Štrba   2014-06-30
22:54:39 +0200

Added EE_CHAR_BKGCOLOR

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107948] Spellchecking language not updated for text element in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107948

--- Comment #7 from Buovjaga  ---
(In reply to fios from comment #6)
> Tionndadh: 6.0.3.2 (x64)
> Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
> Snàithleanan an CPU: 4; OS: Windows 10.0; Reandaradh an UI: A’
> bhun-roghainn; 
> Sgeama ionadail: en-US (gd_GB); Calc: group
> 
> The behavior is improved now. When setting the language to my desired
> language "for the whole text", all existing slides are now updated. However,
> the choice is not remembered so all new slides default to English again.

Can you test by going to Tools - Options - Lang. settings - Languages: Default
languages for documents and making sure "For current document only" is not
checked?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna]

 sw/source/filter/xml/xmltbli.cxx |  128 +++
 1 file changed, 64 insertions(+), 64 deletions(-)

New commits:
commit e7fe9094831036c295bf448737869a47f1873e3f
Author: Miklos Vajna 
Date:   Mon May 28 09:08:36 2018 +0200

sw: prefix members of SwXMLTableCellContext_Impl

Change-Id: Ifb10b563e90c79469652af95133301f3909f8393
Reviewed-on: https://gerrit.libreoffice.org/54897
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/sw/source/filter/xml/xmltbli.cxx b/sw/source/filter/xml/xmltbli.cxx
index 98ddb181baf1..6f75cf0ea7d7 100644
--- a/sw/source/filter/xml/xmltbli.cxx
+++ b/sw/source/filter/xml/xmltbli.cxx
@@ -391,30 +391,30 @@ void SwXMLTableRow_Impl::Dispose()
 
 class SwXMLTableCellContext_Impl : public SvXMLImportContext
 {
-OUString aStyleName;
-OUString sFormula;
-OUString sSaveParaDefault;
+OUString m_aStyleName;
+OUString m_sFormula;
+OUString m_sSaveParaDefault;
 OUString mXmlId;
 OUString m_StringValue;
 
-SvXMLImportContextRef   xMyTable;
+SvXMLImportContextRef   m_xMyTable;
 
-double fValue;
-bool bHasValue;
+double m_fValue;
+bool m_bHasValue;
 bool m_bHasStringValue;
 bool m_bValueTypeIsString;
-bool bProtect;
+bool m_bProtect;
 
-sal_uInt32  nRowSpan;
-sal_uInt32  nColSpan;
-sal_uInt32  nColRepeat;
+sal_uInt32  m_nRowSpan;
+sal_uInt32  m_nColSpan;
+sal_uInt32  m_nColRepeat;
 
-boolbHasTextContent : 1;
-boolbHasTableContent : 1;
+boolm_bHasTextContent : 1;
+boolm_bHasTableContent : 1;
 
-SwXMLTableContext *GetTable() { return static_cast(xMyTable.get()); }
+SwXMLTableContext *GetTable() { return static_cast(m_xMyTable.get()); }
 
-bool HasContent() const { return bHasTextContent || bHasTableContent; }
+bool HasContent() const { return m_bHasTextContent || m_bHasTableContent; }
 inline void InsertContent_();
 inline void InsertContent();
 inline void InsertContent( SwXMLTableContext *pTable );
@@ -439,20 +439,20 @@ SwXMLTableCellContext_Impl::SwXMLTableCellContext_Impl(
 const Reference< xml::sax::XAttributeList > & xAttrList,
 SwXMLTableContext *pTable ) :
 SvXMLImportContext( rImport, nPrfx, rLName ),
-sFormula(),
-xMyTable( pTable ),
-fValue( 0.0 ),
-bHasValue( false ),
+m_sFormula(),
+m_xMyTable( pTable ),
+m_fValue( 0.0 ),
+m_bHasValue( false ),
 m_bHasStringValue(false),
 m_bValueTypeIsString(false),
-bProtect( false ),
-nRowSpan( 1 ),
-nColSpan( 1 ),
-nColRepeat( 1 ),
-bHasTextContent( false ),
-bHasTableContent( false )
-{
-sSaveParaDefault = GetImport().GetTextImport()->GetCellParaStyleDefault();
+m_bProtect( false ),
+m_nRowSpan( 1 ),
+m_nColSpan( 1 ),
+m_nColRepeat( 1 ),
+m_bHasTextContent( false ),
+m_bHasTableContent( false )
+{
+m_sSaveParaDefault = 
GetImport().GetTextImport()->GetCellParaStyleDefault();
 sal_Int16 nAttrCount = xAttrList.is() ? xAttrList->getLength() : 0;
 for( sal_Int16 i=0; i < nAttrCount; i++ )
 {
@@ -471,31 +471,31 @@ SwXMLTableCellContext_Impl::SwXMLTableCellContext_Impl(
 mXmlId = rValue;
 break;
 case XML_TOK_TABLE_STYLE_NAME:
-aStyleName = rValue;
+m_aStyleName = rValue;
 GetImport().GetTextImport()->SetCellParaStyleDefault(rValue);
 break;
 case XML_TOK_TABLE_NUM_COLS_SPANNED:
-nColSpan = static_cast(std::max(1, 
rValue.toInt32()));
-if (nColSpan > 256)
+m_nColSpan = static_cast(std::max(1, 
rValue.toInt32()));
+if (m_nColSpan > 256)
 {
-SAL_INFO("sw.xml", "ignoring huge table:number-columns-spanned 
" << nColSpan);
-nColSpan = 1;
+SAL_INFO("sw.xml", "ignoring huge table:number-columns-spanned 
" << m_nColSpan);
+m_nColSpan = 1;
 }
 break;
 case XML_TOK_TABLE_NUM_ROWS_SPANNED:
-nRowSpan = static_cast(std::max(1, 
rValue.toInt32()));
-if (nRowSpan > 8192 || (nRowSpan > 256 && 
utl::ConfigManager::IsFuzzing()))
+m_nRowSpan = static_cast(std::max(1, 
rValue.toInt32()));
+if (m_nRowSpan > 8192 || (m_nRowSpan > 256 && 
utl::ConfigManager::IsFuzzing()))
 {
-SAL_INFO("sw.xml", "ignoring huge table:number-rows-spanned " 
<< nRowSpan);
-nRowSpan = 1;
+SAL_INFO("sw.xml", "ignoring huge table:number-rows-spanned " 
<< m_nRowSpan);
+m_nRowSpan = 1;
 }
 break;
 case 

[Libreoffice-bugs] [Bug 88006] Libreoffice calc uses all memory until operating system freezes, when using external references to websites

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88006

--- Comment #30 from Adeel Raza Azeemi  ---
Just to add; the problem is not only limited to file with external references. 
Recreation:

Open but any excel file.
simple make changes in the file like , adding filter etc.
then leave it for some time and do some other work in another application.
when you refocus on the libreoffice calc file again. it would have by then
consumed all the available memory space.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117481] no images in buttons in Database pane in main database window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117481

--- Comment #18 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ba5b318fd04d056d5301fba43bd3953e7c8c181f=libreoffice-6-1

tdf#117481 Karasa Jaga: Add dbaccess icons for base sidebar

It will be available in 6.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117481] no images in buttons in Database pane in main database window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117481

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0 target:6.2.0   |target:6.1.0 target:6.2.0
   ||target:6.1.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - icon-themes/karasa_jaga

[Rizal Muttaqin]

 dev/null  |binary
 icon-themes/karasa_jaga/COPYING   |  224 ++
 icon-themes/karasa_jaga/cmd/32/addtable.png   |binary
 icon-themes/karasa_jaga/cmd/32/dbformdelete.png   |binary
 icon-themes/karasa_jaga/cmd/32/dbquerydelete.png  |binary
 icon-themes/karasa_jaga/cmd/32/dbreportdelete.png |binary
 icon-themes/karasa_jaga/cmd/32/dbtabledelete.png  |binary
 icon-themes/karasa_jaga/cmd/32/dbtableedit.png|binary
 icon-themes/karasa_jaga/cmd/32/dbtablerename.png  |binary
 icon-themes/karasa_jaga/cmd/32/deleteannotation.png   |binary
 icon-themes/karasa_jaga/cmd/32/deletecolumns.png  |binary
 icon-themes/karasa_jaga/cmd/32/deletecomment.png  |binary
 icon-themes/karasa_jaga/cmd/32/deletemasterpage.png   |binary
 icon-themes/karasa_jaga/cmd/32/deletepage.png |binary
 icon-themes/karasa_jaga/cmd/32/deleterecord.png   |binary
 icon-themes/karasa_jaga/cmd/32/deleterows.png |binary
 icon-themes/karasa_jaga/cmd/32/deleteslide.png|binary
 icon-themes/karasa_jaga/cmd/32/deletetable.png|binary
 icon-themes/karasa_jaga/cmd/32/exportdirecttoepub.png |binary
 icon-themes/karasa_jaga/cmd/32/exporttoepub.png   |binary
 icon-themes/karasa_jaga/cmd/32/exporttopdf.png|binary
 icon-themes/karasa_jaga/cmd/lc_dbformdelete.png   |binary
 icon-themes/karasa_jaga/cmd/lc_dbreportdelete.png |binary
 icon-themes/karasa_jaga/cmd/lc_dbtabledelete.png  |binary
 icon-themes/karasa_jaga/cmd/lc_deleteannotation.png   |binary
 icon-themes/karasa_jaga/cmd/lc_deletemasterpage.png   |binary
 icon-themes/karasa_jaga/cmd/lc_deletepage.png |binary
 icon-themes/karasa_jaga/cmd/lc_deleteslide.png|binary
 icon-themes/karasa_jaga/cmd/lc_deletetable.png|binary
 icon-themes/karasa_jaga/cmd/lc_exportdirecttoepub.png |binary
 icon-themes/karasa_jaga/cmd/lc_exportdirecttopdf.png  |binary
 icon-themes/karasa_jaga/cmd/lc_exporttoepub.png   |binary
 icon-themes/karasa_jaga/cmd/lc_greatestwidth.png  |binary
 icon-themes/karasa_jaga/cmd/lc_insertslide.png|binary
 icon-themes/karasa_jaga/cmd/sc_dbreportdelete.png |binary
 icon-themes/karasa_jaga/cmd/sc_deletemasterpage.png   |binary
 icon-themes/karasa_jaga/cmd/sc_deletepage.png |binary
 icon-themes/karasa_jaga/cmd/sc_deleteslide.png|binary
 icon-themes/karasa_jaga/cmd/sc_exportdirecttoepub.png |binary
 icon-themes/karasa_jaga/cmd/sc_exportdirecttopdf.png  |binary
 icon-themes/karasa_jaga/cmd/sc_exporttoepub.png   |binary
 icon-themes/karasa_jaga/cmd/sc_greatestheight.png |binary
 icon-themes/karasa_jaga/cmd/sc_greatestwidth.png  |binary
 icon-themes/karasa_jaga/dbaccess/res/all_left.png |binary
 icon-themes/karasa_jaga/dbaccess/res/all_right.png|binary
 icon-themes/karasa_jaga/dbaccess/res/form_16.png  |binary
 icon-themes/karasa_jaga/dbaccess/res/reports_32.png   |binary
 icon-themes/karasa_jaga/dbaccess/res/sc021.png|binary
 icon-themes/karasa_jaga/dbaccess/res/sc023.png|binary
 icon-themes/karasa_jaga/dbaccess/res/sortdown.png |binary
 icon-themes/karasa_jaga/dbaccess/res/sortup.png   |binary
 icon-themes/karasa_jaga/dbaccess/res/tables_32.png|binary
 icon-themes/karasa_jaga/links.txt |   13 -
 icon-themes/karasa_jaga/res/lx03126.png   |binary
 icon-themes/karasa_jaga/res/lx03188.png   |binary
 icon-themes/karasa_jaga/res/sx03126.png   |binary
 icon-themes/karasa_jaga/res/sx03127.png   |binary
 icon-themes/karasa_jaga/res/sx03132.png   |binary
 icon-themes/karasa_jaga/res/sx03188.png   |binary
 icon-themes/karasa_jaga/res/tables_32.png |binary
 icon-themes/karasa_jaga/sfx2/res/startcenter-logo.svg |   91 ---
 61 files changed, 224 insertions(+), 104 deletions(-)

New commits:
commit ba5b318fd04d056d5301fba43bd3953e7c8c181f
Author: Rizal Muttaqin 
Date:   Fri May 25 10:14:41 2018 +0700

tdf#117481 Karasa Jaga: Add dbaccess icons for base sidebar

Change-Id: I5174261484c64a6f223c4a2e197d0e042c3581e4
Reviewed-on: https://gerrit.libreoffice.org/54787
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 
(cherry picked from commit 18c85f770bca04f71b03c4ca06da1a0488842512)
Reviewed-on: https://gerrit.libreoffice.org/54898
Tested-by: andreas_kainz 

diff --git a/icon-themes/karasa_jaga/COPYING b/icon-themes/karasa_jaga/COPYING
new file mode 100644
index ..5938d6c1cd38
--- /dev/null
+++ b/icon-themes/karasa_jaga/COPYING
@@ -0,0 +1,224 @@
+Karasa Jaga Icon Theme for Sundara OS 
+Copyright (c) 2014 Rizal Muttaqin 
+
+Karasa Jaga icon theme is derived heavily from Oxygen icon theme, used 
+for Sundara OS branding. LibreOffice Style Karasa Jaga is part of Karasa 
+Jaga 

[Libreoffice-bugs] [Bug 107948] Spellchecking language not updated for text element in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107948

--- Comment #6 from f...@foramnagaidhlig.net ---
Tionndadh: 6.0.3.2 (x64)
Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
Snàithleanan an CPU: 4; OS: Windows 10.0; Reandaradh an UI: A’ bhun-roghainn; 
Sgeama ionadail: en-US (gd_GB); Calc: group

The behavior is improved now. When setting the language to my desired language
"for the whole text", all existing slides are now updated. However, the choice
is not remembered so all new slides default to English again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42949] accelerating compile times by removing unnecessary header #include

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42949

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0 target:5.3.0  | target:5.2.0 target:5.3.0
   |target:5.4.0 target:6.1.0   |target:5.4.0 target:6.1.0
   ||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42949] accelerating compile times by removing unnecessary header #include

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42949

--- Comment #82 from Commit Notification 
 ---
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f50eb2d12e3b80ff75b6d1a89753efcef0cd6f27

tdf#42949 Fix IWYU warnings in chart2/source/model/inc/

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/IwyuFilter_chart2.yaml chart2/source

[Gabor Kelemen]

 chart2/IwyuFilter_chart2.yaml  |   47 -
 chart2/source/model/inc/BaseCoordinateSystem.hxx   |1 
 chart2/source/model/inc/ChartTypeManager.hxx   |6 --
 chart2/source/model/inc/DataSeries.hxx |5 -
 chart2/source/model/inc/Diagram.hxx|8 +-
 chart2/source/model/inc/XMLFilter.hxx  |7 +-
 chart2/source/model/main/CartesianCoordinateSystem.cxx |1 
 chart2/source/model/main/DataSeries.cxx|1 
 chart2/source/model/main/PolarCoordinateSystem.cxx |1 
 9 files changed, 61 insertions(+), 16 deletions(-)

New commits:
commit f50eb2d12e3b80ff75b6d1a89753efcef0cd6f27
Author: Gabor Kelemen 
Date:   Mon May 21 18:34:40 2018 +0200

tdf#42949 Fix IWYU warnings in chart2/source/model/inc/

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and a bit of fallout management.

Change-Id: I2833ac36c359df76f46e7aa973c012a4d7cedc84
Reviewed-on: https://gerrit.libreoffice.org/54872
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/chart2/IwyuFilter_chart2.yaml b/chart2/IwyuFilter_chart2.yaml
index 4951d1b1ae46..f826ca6128ac 100644
--- a/chart2/IwyuFilter_chart2.yaml
+++ b/chart2/IwyuFilter_chart2.yaml
@@ -185,4 +185,49 @@ blacklist:
 - com/sun/star/beans/XPropertySet.hpp
 - cppuhelper/propshlp.hxx
 - com/sun/star/beans/XPropertyState.hpp
-
+chart2/source/model/inc/BaseCoordinateSystem.hxx:
+# base class has to be a complete type
+- com/sun/star/chart2/XChartTypeContainer.hpp
+- com/sun/star/chart2/XCoordinateSystem.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/util/XCloneable.hpp
+- com/sun/star/util/XModifyBroadcaster.hpp
+- com/sun/star/util/XModifyListener.hpp
+chart2/source/model/inc/ChartTypeManager.hxx:
+# base class has to be a complete type
+- com/sun/star/chart2/XChartTypeManager.hpp
+- com/sun/star/lang/XMultiServiceFactory.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+chart2/source/model/inc/DataSeries.hxx:
+# base class has to be a complete type
+- com/sun/star/chart2/XDataSeries.hpp
+- com/sun/star/chart2/XRegressionCurveContainer.hpp
+- com/sun/star/chart2/data/XDataSink.hpp
+- com/sun/star/chart2/data/XDataSource.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/util/XCloneable.hpp
+- com/sun/star/util/XModifyBroadcaster.hpp
+- com/sun/star/util/XModifyListener.hpp
+chart2/source/model/inc/Diagram.hxx:
+# base class has to be a complete type
+- com/sun/star/chart/X3DDefaultSetter.hpp
+- com/sun/star/chart2/XCoordinateSystemContainer.hpp
+- com/sun/star/chart2/XDiagram.hpp
+- com/sun/star/chart2/XTitled.hpp
+- com/sun/star/lang/XServiceInfo.hpp
+- com/sun/star/util/XCloneable.hpp
+- com/sun/star/util/XModifyBroadcaster.hpp
+- com/sun/star/util/XModifyListener.hpp
+chart2/source/model/inc/StockBar.hxx:
+# base class has to be a complete type
+- com/sun/star/util/XCloneable.hpp
+- com/sun/star/util/XModifyBroadcaster.hpp
+- com/sun/star/util/XModifyListener.hpp
+chart2/source/model/inc/XMLFilter.hxx:
+# base class has to be a complete type
+- com/sun/star/document/XExporter.hpp
+- com/sun/star/document/XFilter.hpp
+- com/sun/star/document/XImporter.hpp
+- com/sun/star/io/XActiveDataSource.hpp
+- com/sun/star/lang/XMultiServiceFactory.hpp
+- com/sun/star/lang/XServiceInfo.hpp
diff --git a/chart2/source/model/inc/BaseCoordinateSystem.hxx 
b/chart2/source/model/inc/BaseCoordinateSystem.hxx
index 76ad85aa597f..1f20e83a02dc 100644
--- a/chart2/source/model/inc/BaseCoordinateSystem.hxx
+++ b/chart2/source/model/inc/BaseCoordinateSystem.hxx
@@ -24,7 +24,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/chart2/source/model/inc/ChartTypeManager.hxx 
b/chart2/source/model/inc/ChartTypeManager.hxx
index 7b09b1a16b7e..dc764ad86c53 100644
--- a/chart2/source/model/inc/ChartTypeManager.hxx
+++ b/chart2/source/model/inc/ChartTypeManager.hxx
@@ -19,15 +19,13 @@
 #ifndef INCLUDED_CHART2_SOURCE_MODEL_INC_CHARTTYPEMANAGER_HXX
 #define INCLUDED_CHART2_SOURCE_MODEL_INC_CHARTTYPEMANAGER_HXX
 
-#include 
-#include 
 #include 
-#include 
 #include 
 #include 
-
 #include 
 
+namespace com { namespace sun { namespace star { namespace uno { class 
XComponentContext; } } } }
+
 namespace chart
 {
 
diff --git a/chart2/source/model/inc/DataSeries.hxx 
b/chart2/source/model/inc/DataSeries.hxx
index ee45f584d7b9..aefab3406606 100644
--- a/chart2/source/model/inc/DataSeries.hxx
+++ b/chart2/source/model/inc/DataSeries.hxx
@@ -27,10 +27,7 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
-#include 
 
 // helper classes
 #include 
@@ -43,6 +40,8 @@
 #include 
 #include 
 
+namespace 

[Libreoffice-bugs] [Bug 117847] New: EDITING: Impress: After changing alignment, previous alignment remains checked

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117847

Bug ID: 117847
   Summary: EDITING: Impress: After changing alignment, previous
alignment remains checked
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ilhanye...@gmx.de

Select textbox.
Goto menu Format->Align, then select another alignment (if Centre is selected,
select Left as example).
Goto menu Format->Align, at least two alignments are selected (Centre and Left)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81720] EDITING: setting cross-reference still active after closing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81720

--- Comment #8 from Juang Dse  ---
bug still there, but modified.

inserting the cross-reference now leads to the text

"foonew textfoonew textfoonew text"

Version: 6.0.4.2
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group


With the current 6.1 dev version I get

" fooname"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113582] Export as PDF reduces arrow line width compared to display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113582

--- Comment #6 from Buovjaga  ---
(In reply to Buovjaga from comment #5)
> bug 67923 may also affect PDF line width (if page scaling factor is changed)

Bah, that is Calc-only, no such option in Impress.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113582] Export as PDF reduces arrow line width compared to display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113582

--- Comment #5 from Buovjaga  ---
bug 67923 may also affect PDF line width (if page scaling factor is changed)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96099] Reduce number of typedefs used for trivial container types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96099

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.3.0   |target:5.2.0 target:5.3.0
   |target:5.4.0 target:6.0.0   |target:5.4.0 target:6.0.0
   |target:6.1.0|target:6.1.0 target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source connectivity/source dbaccess/source desktop/source

[Arkadiy Illarionov]

 basic/source/inc/parser.hxx|5 ++---
 connectivity/source/drivers/firebird/Util.hxx  |3 ---
 dbaccess/source/ui/inc/commontypes.hxx |2 --
 desktop/source/deployment/registry/package/dp_extbackenddb.hxx |2 --
 4 files changed, 2 insertions(+), 10 deletions(-)

New commits:
commit f62243c7bb620d821ae84366235111c47a99bae0
Author: Arkadiy Illarionov 
Date:   Sat May 26 11:58:26 2018 +0300

tdf#96099 Remove some trivial typedef std::vector

Change-Id: I41fff78c10d46bde50063536d8cf1a3942dbf6af
Reviewed-on: https://gerrit.libreoffice.org/54834
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/basic/source/inc/parser.hxx b/basic/source/inc/parser.hxx
index 4ff5baf83518..bee2a188c1fc 100644
--- a/basic/source/inc/parser.hxx
+++ b/basic/source/inc/parser.hxx
@@ -26,7 +26,6 @@
 
 
 #include 
-typedef std::vector< OUString > StringVector;
 
 struct SbiParseStack;
 
@@ -72,8 +71,8 @@ public:
 short nBase;// OPTION BASE-value
 bool  bExplicit;// true: OPTION EXPLICIT
 bool  bClassModule; // true: OPTION ClassModule
-StringVector  aIfaceVector; // Holds all interfaces implemented by a 
class module
-StringVector  aRequiredTypes;   // Types used in Dim As New  outside 
subs
+std::vector aIfaceVector; // Holds all interfaces 
implemented by a class module
+std::vector aRequiredTypes;   // Types used in Dim As New  
outside subs
 #   define N_DEF_TYPES 26
 SbxDataType   eDefTypes[N_DEF_TYPES];// DEFxxx data types
 
diff --git a/connectivity/source/drivers/firebird/Util.hxx 
b/connectivity/source/drivers/firebird/Util.hxx
index 0b06e3c18fb8..dbff25356205 100644
--- a/connectivity/source/drivers/firebird/Util.hxx
+++ b/connectivity/source/drivers/firebird/Util.hxx
@@ -18,13 +18,10 @@
 #include 
 #include 
 
-#include 
-
 namespace connectivity
 {
 namespace firebird
 {
-typedef std::vector< OString > OStringVector;
 // Type Blob has 2 subtypes values
 // 0 for BLOB, 1 for CLOB
 // see http://www.firebirdfaq.org/faq48/
diff --git a/dbaccess/source/ui/inc/commontypes.hxx 
b/dbaccess/source/ui/inc/commontypes.hxx
index 18ba066f816a..74402d59bcd7 100644
--- a/dbaccess/source/ui/inc/commontypes.hxx
+++ b/dbaccess/source/ui/inc/commontypes.hxx
@@ -23,7 +23,6 @@
 #include 
 
 #include 
-#include 
 
 #include 
 
@@ -37,7 +36,6 @@ namespace dbaui
 {
 
 typedef std::set StringBag;
-typedef std::vector StringArray;
 
 typedef ::utl::SharedUNOComponent< css::sdbc::XConnection > 
SharedConnection;
 
diff --git a/desktop/source/deployment/registry/package/dp_extbackenddb.hxx 
b/desktop/source/deployment/registry/package/dp_extbackenddb.hxx
index 1c220ff91485..ac91a62e9252 100644
--- a/desktop/source/deployment/registry/package/dp_extbackenddb.hxx
+++ b/desktop/source/deployment/registry/package/dp_extbackenddb.hxx
@@ -55,8 +55,6 @@ public:
and the media type
  */
 std::vector< std::pair< OUString, OUString> > items;
-typedef std::vector<
-std::pair< OUString, OUString> >::const_iterator ITC_ITEMS;
 };
 
 public:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96099] Reduce number of typedefs used for trivial container types

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96099

--- Comment #53 from Commit Notification 
 ---
Arkadiy Illarionov committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f62243c7bb620d821ae84366235111c47a99bae0

tdf#96099 Remove some trivial typedef std::vector

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: WebServer behind LOOL?

[Miklos Vajna]

Hi,

On Wed, May 23, 2018 at 09:14:58AM +, Renato Ribeiro 
 wrote:
> This is a basic question but I can't understand yet. What is the web
> server running behind the LibreOffice Online? The websocket is the
> protocol used to change messages, right? What's other protocols are
> used in this application? Where does WOPI come in here?

Poco has a built-in library to serve static files over HTTP(S), that's
used in loolwsd.  Websocket is used to update the JS client once the
page is loaded. The JS itself is served as static content. The only
non-websocket and non-static part is the convert-to functionality at the
moment, I think. Regarding WOPI, see here:

https://speakerdeck.com/kendy/integrating-libreoffice-online-via-wopi

It's the protocol between auth/storage and the stateless Online
instance.

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 117819] error displaying integers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117819

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Jean-Baptiste Faure  ---
Not sure if I understand what you mean correctly. What I do:
1/ paste 123456789012345 in the formula bar then validate => I get
1.23456789012345E+14 (correct)
2/ go back in the formula bar, it shows 123456789012345, then paste
 at the end of the number the validate => I get
1.23456789012345E+34 (correct)

Tested in Version: 6.1.0.0.beta1+
Build ID: d238a5e47b8cf9a484c8f881c3c01da10b340603
Threads CPU : 4; OS : Linux 4.4; UI Render : par défaut; VCL: gtk3; 
Ubuntu_16.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); Calc: threaded

Idem in Version: 6.0.4.2
Build ID: 1:6.0.4~rc2-0ubuntu0.16.04.1
Threads CPU : 4; OS : Linux 4.4; UI Render : par défaut; VCL: gtk3; 
Locale : fr-FR (fr_FR.UTF-8); Calc: 

Please, could you explain with more detail what you do to obtain your result?

Status set to NEEDINFO, please set it back to UNCONFIRMED once requested
informations are provided.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113582] Export as PDF reduces arrow line width compared to display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113582

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Buovjaga  ---
(In reply to mattreecebentley from comment #3)
> Still occurs here to an extent:
> if line width is set to 0.00 cm, libreoffice displays as if it's larger.
> Exporting to PDF is correct width (none)

What you are describing now is something completely different and I think it is
done on purpose. Maybe it depends on your PDF reader, but I cannot export a PDF
with the line being invisible (width 0).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: kit/Kit.cpp

[Miklos Vajna]

 kit/Kit.cpp |   18 ++
 1 file changed, 10 insertions(+), 8 deletions(-)

New commits:
commit d718b1c0545fe77b0552269057bff707f8bee347
Author: Miklos Vajna 
Date:   Mon May 28 09:11:06 2018 +0200

kit: let alphaBlend() take an std::vector instead of raw pointer

So that it's more obvious that the two for loops don't read past the end
of the vector.

Change-Id: I49752c1bc316b6d73568ab334b07727ef60bdce5

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 25b03f2af..8ef9840bd 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -600,19 +600,19 @@ public:
 offsetX += (tileWidth - maxX) / 2;
 offsetY += (tileHeight - maxY) / 2;
 
-alphaBlend(pixmap->data(), _width, _height, offsetX, offsetY, 
tilePixmap, tilesPixmapWidth, tilesPixmapHeight);
+alphaBlend(*pixmap, _width, _height, offsetX, offsetY, tilePixmap, 
tilesPixmapWidth, tilesPixmapHeight);
 }
 }
 
 private:
 /// Alpha blend pixels from 'from' over the 'to'.
-void alphaBlend(const unsigned char* from, int from_width, int 
from_height, int from_offset_x, int from_offset_y,
+void alphaBlend(const std::vector& from, int from_width, 
int from_height, int from_offset_x, int from_offset_y,
 unsigned char* to, int to_width, int to_height)
 {
 for (int to_y = from_offset_y, from_y = 0; (to_y < to_height) && 
(from_y < from_height) ; ++to_y, ++from_y)
 for (int to_x = from_offset_x, from_x = 0; (to_x < to_width) && 
(from_x < from_width); ++to_x, ++from_x)
 {
-const unsigned char* f = from + 4 * (from_y * from_width + 
from_x);
+const unsigned char* f = from.data() + 4 * (from_y * 
from_width + from_x);
 double src_r = f[0];
 double src_g = f[1];
 double src_b = f[2];
@@ -657,14 +657,19 @@ private:
 // are always set to 0 (black) and the alpha level is 0 everywhere
 // except on the text area; the alpha level take into account of
 // performing anti-aliasing over the text edges.
-unsigned char* text = _loKitDoc->renderFont(_font.c_str(), 
_text.c_str(), &_width, &_height);
+unsigned char* textPixels = _loKitDoc->renderFont(_font.c_str(), 
_text.c_str(), &_width, &_height);
 
-if (!text)
+if (!textPixels)
 {
 LOG_ERR("Watermark: rendering failed.");
 }
 
 const unsigned int pixel_count = width * height * 4;
+
+std::vector text(textPixels, textPixels + pixel_count);
+// No longer needed.
+std::free(textPixels);
+
 _pixmap.reserve(pixel_count);
 
 // Create the white blurred background
@@ -703,9 +708,6 @@ private:
 // Now copy the (black) text over the (white) blur
 alphaBlend(text, _width, _height, 0, 0, _pixmap.data(), _width, 
_height);
 
-// No longer needed.
-std::free(text);
-
 // Make the resulting pixmap semi-transparent
 for (unsigned char* p = _pixmap.data(); p < _pixmap.data() + 
pixel_count; p++)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117846] New: Update Icons for HiDPI Screens under KDE Plasma with fractional scaling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117846

Bug ID: 117846
   Summary: Update Icons for HiDPI Screens under KDE Plasma with
fractional scaling
   Product: LibreOffice
   Version: 6.0.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tobias-wies...@gmx.de

Description:
I have blurry Icons under KDE Plasma 5 when I use fractional scaling (1.3 in my
case) which is equivalent to a font dpi of 125. Can you add some form of
automatic dpi-detection not only for 192dpi (your HiDPI Setup), so that the
icons are always createt in the right size from your svg-Iconset. I use the
Breeze-Dark Icons but the problem exists for all Iconsets.

Cause of the size of my display (1080p 14") I have to use this size of scaling.

Steps to Reproduce:
1. Turn the scaling in KDE Plasma to a factor between 1 and 2
2. Open any program from the libreoffice-Suite
3.

Actual Results:  
All Icons are blurry

Expected Results:
Scale the icons for the actual dpi from the desktop


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.0.4.2
Build-ID: 6.0.4-1
CPU-Threads: 4; BS: Linux 4.14; UI-Render: Standard; VCL: kde4; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sd/source

[Noel Grandin]

 sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx |   18 +++---
 sd/source/ui/animations/motionpathtag.cxx |   14 +++---
 sd/source/ui/animations/motionpathtag.hxx |2 -
 sd/source/ui/inc/AccessibleDrawDocumentView.hxx   |2 -
 4 files changed, 11 insertions(+), 25 deletions(-)

New commits:
commit 326c094ecfb496555b02234a751ab525cea6db55
Author: Noel Grandin 
Date:   Mon May 21 16:42:53 2018 +0200

loplugin:useuniqueptr in MotionPathTag

Change-Id: I1f63cf02a99018fbac1bf07b9afe6d7347a973d9
Reviewed-on: https://gerrit.libreoffice.org/54861
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/source/ui/animations/motionpathtag.cxx 
b/sd/source/ui/animations/motionpathtag.cxx
index 64b22607ef38..ab24218ce38e 100644
--- a/sd/source/ui/animations/motionpathtag.cxx
+++ b/sd/source/ui/animations/motionpathtag.cxx
@@ -341,7 +341,7 @@ MotionPathTag::MotionPathTag( CustomAnimationPane& rPane, 
::sd::View& rView, con
 
 mpPathObj->SetMergedItem(XLineTransparenceItem(50));
 
-mpMark = new SdrMark( mpPathObj, mrView.GetSdrPageView() );
+mpMark.reset(new SdrMark( mpPathObj, mrView.GetSdrPageView() ));
 
 mpPathObj->AddListener( *this );
 
@@ -778,7 +778,7 @@ bool MotionPathTag::MarkPoint(SdrHdl& rHdl, bool bUnmark )
 SmartHdl* pSmartHdl = dynamic_cast< SmartHdl* >(  );
 if( pSmartHdl && pSmartHdl->getTag().get() == this )
 {
-if (mrView.MarkPointHelper(,mpMark,bUnmark))
+if (mrView.MarkPointHelper(,mpMark.get(),bUnmark))
 {
 mrView.MarkListHasChanged();
 bRet=true;
@@ -807,7 +807,7 @@ bool MotionPathTag::MarkPoints(const ::tools::Rectangle* 
pRect, bool bUnmark )
 Point aPos(pHdl->GetPos());
 if( pRect==nullptr || pRect->IsInside(aPos))
 {
-if( mrView.MarkPointHelper(pHdl,mpMark,bUnmark) )
+if( mrView.MarkPointHelper(pHdl,mpMark.get(),bUnmark) )
 bChgd=true;
 }
 }
@@ -854,7 +854,7 @@ void MotionPathTag::CheckPossibilities()
 bool bSegmFuz(false);
 basegfx::B2VectorContinuity eSmooth = 
basegfx::B2VectorContinuity::NONE;
 
-mrView.CheckPolyPossibilitiesHelper( mpMark, b1stSmooth, 
b1stSegm, bCurve, bSmoothFuz, bSegmFuz, eSmooth );
+mrView.CheckPolyPossibilitiesHelper( mpMark.get(), b1stSmooth, 
b1stSegm, bCurve, bSmoothFuz, bSegmFuz, eSmooth );
 }
 }
 }
@@ -987,11 +987,7 @@ void MotionPathTag::disposing()
 SdrObject::Free(pTemp);
 }
 
-if( mpMark )
-{
-delete mpMark;
-mpMark = nullptr;
-}
+mpMark.reset();
 
 SmartTag::disposing();
 }
diff --git a/sd/source/ui/animations/motionpathtag.hxx 
b/sd/source/ui/animations/motionpathtag.hxx
index 0e785cece1e2..3158f95c2d8b 100644
--- a/sd/source/ui/animations/motionpathtag.hxx
+++ b/sd/source/ui/animations/motionpathtag.hxx
@@ -106,7 +106,7 @@ private:
 css::uno::Reference< css::drawing::XShape > mxOrigin;
 SdrPathObj* mpPathObj;
 css::awt::Point maOriginPos;
-SdrMark* mpMark;
+std::unique_ptr mpMark;
 OUString msLastPath;
 bool mbInUpdatePath;
 };
commit 7f664b591fb9b82569885f8f243e2822fde3a0ae
Author: Noel Grandin 
Date:   Mon May 21 16:38:13 2018 +0200

loplugin:useuniqueptr in AccessibleDrawDocumentView

Change-Id: Ibec6b19e83a3c29299382c398ca6a40b92377ede
Reviewed-on: https://gerrit.libreoffice.org/54860
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx 
b/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx
index 7899d7e03fa1..355c579d96ce 100644
--- a/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx
+++ b/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx
@@ -106,7 +106,7 @@ void AccessibleDrawDocumentView::Init()
 xShapeList.set( xView->getCurrentPage(), uno::UNO_QUERY);
 
 // Create the children manager.
-mpChildrenManager = new ChildrenManager(this, xShapeList, maShapeTreeInfo, 
*this);
+mpChildrenManager.reset(new ChildrenManager(this, xShapeList, 
maShapeTreeInfo, *this));
 
 rtl::Reference xPage(CreateDrawPageShape());
 if (xPage.is())
@@ -214,7 +214,7 @@ uno::Reference SAL_CALL
 
 // Create a copy of the pointer to the children manager and release the
 // mutex before calling any of its methods.
-ChildrenManager* pChildrenManager = mpChildrenManager;
+ChildrenManager* pChildrenManager = mpChildrenManager.get();
 aGuard.clear();
 
 // Forward request to children manager.
@@ -730,12 +730,7 @@ void AccessibleDrawDocumentView::Deactivated()

[Libreoffice-commits] core.git: dbaccess/source

[Noel Grandin]

 dbaccess/source/ui/control/marktree.cxx |6 +++---
 dbaccess/source/ui/inc/marktree.hxx |2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 7f3c2ee6c135773c98ded063bdf10ec8900bf00f
Author: Noel Grandin 
Date:   Fri May 18 13:41:19 2018 +0200

loplugin:useuniqueptr in OMarkableTreeListBox

Change-Id: Ifd3ea7fa32e9b254ff901a014f559ab211948929
Reviewed-on: https://gerrit.libreoffice.org/54849
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/control/marktree.cxx 
b/dbaccess/source/ui/control/marktree.cxx
index cf8e16f4e3de..1893985aa6fa 100644
--- a/dbaccess/source/ui/control/marktree.cxx
+++ b/dbaccess/source/ui/control/marktree.cxx
@@ -41,7 +41,7 @@ OMarkableTreeListBox::~OMarkableTreeListBox()
 
 void OMarkableTreeListBox::dispose()
 {
-delete m_pCheckButton;
+m_pCheckButton.reset();
 DBTreeListBox::dispose();
 }
 
@@ -65,8 +65,8 @@ void OMarkableTreeListBox::Paint(vcl::RenderContext& 
rRenderContext, const tools
 
 void OMarkableTreeListBox::InitButtonData()
 {
-m_pCheckButton = new SvLBoxButtonData( this );
-EnableCheckButton( m_pCheckButton );
+m_pCheckButton.reset( new SvLBoxButtonData( this ) );
+EnableCheckButton( m_pCheckButton.get() );
 }
 
 void OMarkableTreeListBox::KeyInput( const KeyEvent& rKEvt )
diff --git a/dbaccess/source/ui/inc/marktree.hxx 
b/dbaccess/source/ui/inc/marktree.hxx
index 721af1a31cbb..a8bd8b2a70db 100644
--- a/dbaccess/source/ui/inc/marktree.hxx
+++ b/dbaccess/source/ui/inc/marktree.hxx
@@ -34,7 +34,7 @@ namespace dbaui
 */
 class OMarkableTreeListBox : public DBTreeListBox
 {
-SvLBoxButtonData*   m_pCheckButton;
+std::unique_ptr m_pCheckButton;
 Linkm_aCheckButtonHandler;
 
 public:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/inc sd/source

[Noel Grandin]

 sd/inc/textapi.hxx  |2 +-
 sd/source/core/text/textapi.cxx |3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit f59d33a5302f20f98b0596c284116d1e30a17bd6
Author: Noel Grandin 
Date:   Mon May 21 16:37:56 2018 +0200

loplugin:useuniqueptr in TextApiObject

Change-Id: I418f18a1e090dab2923395963b2a003df58890ae
Reviewed-on: https://gerrit.libreoffice.org/54859
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/inc/textapi.hxx b/sd/inc/textapi.hxx
index df771dc55e50..d81ecf4b4ce2 100644
--- a/sd/inc/textapi.hxx
+++ b/sd/inc/textapi.hxx
@@ -47,7 +47,7 @@ public:
 static TextApiObject* getImplementation( const css::uno::Reference< 
css::text::XText >& );
 
 private:
-TextAPIEditSource*  mpSource;
+std::unique_ptr  mpSource;
 TextApiObject( TextAPIEditSource* pEditSource );
 };
 
diff --git a/sd/source/core/text/textapi.cxx b/sd/source/core/text/textapi.cxx
index a4bdb23e46bc..69462124ce27 100644
--- a/sd/source/core/text/textapi.cxx
+++ b/sd/source/core/text/textapi.cxx
@@ -144,8 +144,7 @@ void TextApiObject::dispose()
 if( mpSource )
 {
 mpSource->Dispose();
-delete mpSource;
-mpSource = nullptr;
+mpSource.reset();
 }
 
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - dbaccess/source svgio/source

[Noel Grandin]

 dbaccess/source/ui/inc/querycontroller.hxx |4 ++--
 dbaccess/source/ui/querydesign/querycontroller.cxx |   10 --
 svgio/source/svgreader/svgtextpathnode.cxx |   12 
 3 files changed, 10 insertions(+), 16 deletions(-)

New commits:
commit c269761290866b1634779dab89e2d5e2626caaa8
Author: Noel Grandin 
Date:   Mon May 21 15:49:30 2018 +0200

loplugin:useuniqueptr in pathTextBreakupHelper

Change-Id: Ie8c28403bd6280a733949493bfe693cbfee5e4f5
Reviewed-on: https://gerrit.libreoffice.org/54858
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/svgio/source/svgreader/svgtextpathnode.cxx 
b/svgio/source/svgreader/svgtextpathnode.cxx
index dae7f4e47bd8..288782cfbcff 100644
--- a/svgio/source/svgreader/svgtextpathnode.cxx
+++ b/svgio/source/svgreader/svgtextpathnode.cxx
@@ -44,7 +44,7 @@ namespace svgio
 const sal_uInt32mnMaxIndex;
 sal_uInt32  mnIndex;
 basegfx::B2DCubicBezier maCurrentSegment;
-basegfx::B2DCubicBezierHelper*  mpB2DCubicBezierHelper;
+std::unique_ptr 
mpB2DCubicBezierHelper;
 double  mfCurrentSegmentLength;
 double  mfSegmentStartPosition;
 
@@ -72,21 +72,17 @@ namespace svgio
 
 void pathTextBreakupHelper::freeB2DCubicBezierHelper()
 {
-if(mpB2DCubicBezierHelper)
-{
-delete mpB2DCubicBezierHelper;
-mpB2DCubicBezierHelper = nullptr;
-}
+mpB2DCubicBezierHelper.reset();
 }
 
 basegfx::B2DCubicBezierHelper* 
pathTextBreakupHelper::getB2DCubicBezierHelper()
 {
 if(!mpB2DCubicBezierHelper && maCurrentSegment.isBezier())
 {
-mpB2DCubicBezierHelper = new 
basegfx::B2DCubicBezierHelper(maCurrentSegment);
+mpB2DCubicBezierHelper.reset(new 
basegfx::B2DCubicBezierHelper(maCurrentSegment));
 }
 
-return mpB2DCubicBezierHelper;
+return mpB2DCubicBezierHelper.get();
 }
 
 void pathTextBreakupHelper::advanceToPosition(double fNewPosition)
commit 9aff9f22adf20aa0c00663648d1875e325b24d42
Author: Noel Grandin 
Date:   Mon May 21 15:48:23 2018 +0200

loplugin:useuniqueptr in OQueryController

Change-Id: I13ca3ea6c27d4572274b70b0481a8479852b569a
Reviewed-on: https://gerrit.libreoffice.org/54857
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/inc/querycontroller.hxx 
b/dbaccess/source/ui/inc/querycontroller.hxx
index 6e99796fc474..3f6df60719e8 100644
--- a/dbaccess/source/ui/inc/querycontroller.hxx
+++ b/dbaccess/source/ui/inc/querycontroller.hxx
@@ -61,9 +61,9 @@ namespace dbaui
 
 css::uno::Sequence< css::beans::PropertyValue >   
m_aFieldInformation;
 
-::svxform::OSystemParseContext* m_pParseContext;
+std::unique_ptr<::svxform::OSystemParseContext>   m_pParseContext;
 ::connectivity::OSQLParser  m_aSqlParser;
-::connectivity::OSQLParseTreeIterator*  m_pSqlIterator;
+std::unique_ptr<::connectivity::OSQLParseTreeIterator> m_pSqlIterator;
 
 css::uno::Reference< css::sdb::XSQLQueryComposer >m_xComposer;
 /// if we're editing an existing view, this is non-NULL
diff --git a/dbaccess/source/ui/querydesign/querycontroller.cxx 
b/dbaccess/source/ui/querydesign/querycontroller.cxx
index f60e1a76f7b7..8f065adb3a43 100644
--- a/dbaccess/source/ui/querydesign/querycontroller.cxx
+++ b/dbaccess/source/ui/querydesign/querycontroller.cxx
@@ -239,8 +239,7 @@ OQueryController::OQueryController(const Reference< 
XComponentContext >& _rM)
 :OJoinController(_rM)
 ,OQueryController_PBase( getBroadcastHelper() )
 ,m_pParseContext( new svxform::OSystemParseContext )
-,m_aSqlParser( _rM, m_pParseContext )
-,m_pSqlIterator(nullptr)
+,m_aSqlParser( _rM, m_pParseContext.get() )
 ,m_nLimit(-1)
 ,m_nVisibleRows(0x400)
 ,m_nSplitPos(-1)
@@ -343,8 +342,7 @@ void OQueryController::deleteIterator()
 {
 delete m_pSqlIterator->getParseTree();
 m_pSqlIterator->dispose();
-delete m_pSqlIterator;
-m_pSqlIterator = nullptr;
+m_pSqlIterator.reset();
 }
 }
 
@@ -354,7 +352,7 @@ void OQueryController::disposing()
 
 deleteIterator();
 
-delete m_pParseContext;
+m_pParseContext.reset();
 
 clearFields();
 OTableFields().swap(m_vUnUsedFieldsDesc);
@@ -942,7 +940,7 @@ void OQueryController::setQueryComposer()
 OSL_ENSURE(m_xComposer.is(),"No querycomposer available!");
 Reference xTablesSup(getConnection(), UNO_QUERY);
 deleteIterator();
-   

[Libreoffice-commits] core.git: 2 commits - dbaccess/source

[Noel Grandin]

 dbaccess/source/ui/inc/TableConnection.hxx  |4 ++--
 dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx |1 +
 dbaccess/source/ui/querydesign/JoinTableView.cxx|8 
 dbaccess/source/ui/querydesign/TableConnection.cxx  |   10 --
 dbaccess/source/ui/querydesign/querydlg.cxx |4 ++--
 dbaccess/source/ui/querydesign/querydlg.hxx |2 +-
 dbaccess/source/ui/relationdesign/RTableConnection.cxx  |4 ++--
 7 files changed, 16 insertions(+), 17 deletions(-)

New commits:
commit dc8e63784687292ffa178ff29f6fe2f9fd100eea
Author: Noel Grandin 
Date:   Mon May 21 15:32:02 2018 +0200

loplugin:useuniqueptr in DlgQryJoin

Change-Id: Ia9a5534b6d69dde163fae54fbd2764dc9b279a5d
Reviewed-on: https://gerrit.libreoffice.org/54855
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/querydesign/querydlg.cxx 
b/dbaccess/source/ui/querydesign/querydlg.cxx
index 2bf06735b947..fc5108442506 100644
--- a/dbaccess/source/ui/querydesign/querydlg.cxx
+++ b/dbaccess/source/ui/querydesign/querydlg.cxx
@@ -67,7 +67,7 @@ DlgQryJoin::DlgQryJoin( OQueryTableView * pParent,
 m_pConnData.reset(_pData->NewInstance());
 m_pConnData->CopyFrom(*_pData);
 
-m_pTableControl = new OTableListBoxControl(this, _pTableMap, this);
+m_pTableControl.reset(new OTableListBoxControl(this, _pTableMap, this));
 
 
m_pCBNatural->Check(static_cast(m_pConnData.get())->isNatural());
 
@@ -143,7 +143,7 @@ DlgQryJoin::~DlgQryJoin()
 
 void DlgQryJoin::dispose()
 {
-delete m_pTableControl;
+m_pTableControl.reset();
 m_pML_HelpText.clear();
 m_pPB_OK.clear();
 m_pLB_JoinType.clear();
diff --git a/dbaccess/source/ui/querydesign/querydlg.hxx 
b/dbaccess/source/ui/querydesign/querydlg.hxx
index 93a8d53e54f8..004afdc4fc32 100644
--- a/dbaccess/source/ui/querydesign/querydlg.hxx
+++ b/dbaccess/source/ui/querydesign/querydlg.hxx
@@ -43,7 +43,7 @@ namespace dbaui
 VclPtrm_pLB_JoinType;
 VclPtr   m_pCBNatural;
 
-OTableListBoxControl*   m_pTableControl;
+std::unique_ptr m_pTableControl;
 
 EJoinType   eJoinType;
 TTableConnectionData::value_typem_pConnData; // contains left and 
right table
commit 39d19a88bd4f0bd22aa843b630ab50f9b2708d87
Author: Noel Grandin 
Date:   Mon May 21 10:33:18 2018 +0200

loplugin:useuniqueptr in OTableConnection

Change-Id: I4fe5c706d0aec4b2b81bdbe9e9a59e771af4a02e
Reviewed-on: https://gerrit.libreoffice.org/54854
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/inc/TableConnection.hxx 
b/dbaccess/source/ui/inc/TableConnection.hxx
index 7b6725772796..04759077eff8 100644
--- a/dbaccess/source/ui/inc/TableConnection.hxx
+++ b/dbaccess/source/ui/inc/TableConnection.hxx
@@ -36,7 +36,7 @@ namespace dbaui
 
 class OTableConnection : public vcl::Window
 {
-std::vector m_vConnLine;
+std::vector m_vConnLine;
 TTableConnectionData::value_type
 m_pData;
 VclPtr  m_pParent;
@@ -88,7 +88,7 @@ namespace dbaui
 tools::Rectangle   GetBoundingRect() const;
 
 const TTableConnectionData::value_type& GetData() const { return 
m_pData; }
-const std::vector&  GetConnLineList() const { return 
m_vConnLine; }
+const std::vector&  
GetConnLineList() const { return m_vConnLine; }
 OJoinTableView*  GetParent() const { return m_pParent; 
}
 virtual void Draw(vcl::RenderContext& rRenderContext, const 
tools::Rectangle& rRect);
 using Window::Draw;
diff --git a/dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx 
b/dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
index 04a9da583b56..bd90d9688490 100644
--- a/dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
+++ b/dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
@@ -18,6 +18,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/dbaccess/source/ui/querydesign/JoinTableView.cxx 
b/dbaccess/source/ui/querydesign/JoinTableView.cxx
index f361ca0b125d..dda98512cb77 100644
--- a/dbaccess/source/ui/querydesign/JoinTableView.cxx
+++ b/dbaccess/source/ui/querydesign/JoinTableView.cxx
@@ -892,8 +892,8 @@ void OJoinTableView::SelectConn(OTableConnection* pConn)
 SvTreeListEntry* pFirstSourceVisible = 
pSourceBox->GetFirstEntryInView();
 SvTreeListEntry* pFirstDestVisible = 
pDestBox->GetFirstEntryInView();
 
-const std::vector& rLines = 
pConn->GetConnLineList();
-

[Libreoffice-commits] core.git: 2 commits - basctl/source

[Noel Grandin]

 basctl/source/basicide/baside2.cxx|4 -
 basctl/source/basicide/baside2b.cxx   |   12 ++---
 basctl/source/basicide/breakpoint.cxx |   77 +-
 basctl/source/basicide/breakpoint.hxx |   19 
 basctl/source/basicide/brkdlg.cxx |   70 +-
 basctl/source/basicide/brkdlg.hxx |6 +-
 basctl/source/basicide/moduldl2.cxx   |9 +--
 basctl/source/basicide/moduldlg.hxx   |2 
 8 files changed, 95 insertions(+), 104 deletions(-)

New commits:
commit 7fd67ca9361cc15732c505004ab4471bd2cf7f99
Author: Noel Grandin 
Date:   Thu May 17 15:32:38 2018 +0200

loplugin:useuniqueptr in basctl::CheckBox

Change-Id: Iec9a0f39b3853108bdb5218e7480a09b261198ec
Reviewed-on: https://gerrit.libreoffice.org/54846
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basctl/source/basicide/moduldl2.cxx 
b/basctl/source/basicide/moduldl2.cxx
index 020e2f4488cf..b446588a6b93 100644
--- a/basctl/source/basicide/moduldl2.cxx
+++ b/basctl/source/basicide/moduldl2.cxx
@@ -166,8 +166,7 @@ CheckBox::~CheckBox()
 
 void CheckBox::dispose()
 {
-delete pCheckButton;
-pCheckButton = nullptr;
+pCheckButton.reset();
 
 // delete user data
 SvTreeListEntry* pEntry = First();
@@ -182,10 +181,10 @@ void CheckBox::dispose()
 
 void CheckBox::Init()
 {
-pCheckButton = new SvLBoxButtonData(this);
+pCheckButton.reset(new SvLBoxButtonData(this));
 
 if (eMode == ObjectMode::Library)
-EnableCheckButton( pCheckButton );
+EnableCheckButton( pCheckButton.get() );
 else
 EnableCheckButton( nullptr );
 
@@ -197,7 +196,7 @@ void CheckBox::SetMode (ObjectMode e)
 eMode = e;
 
 if (eMode == ObjectMode::Library)
-EnableCheckButton( pCheckButton );
+EnableCheckButton( pCheckButton.get() );
 else
 EnableCheckButton( nullptr );
 }
diff --git a/basctl/source/basicide/moduldlg.hxx 
b/basctl/source/basicide/moduldlg.hxx
index adb1e661cd0a..cbd8b5c171f5 100644
--- a/basctl/source/basicide/moduldlg.hxx
+++ b/basctl/source/basicide/moduldlg.hxx
@@ -111,7 +111,7 @@ class CheckBox : public SvTabListBox
 {
 private:
 ObjectMode  eMode;
-SvLBoxButtonData*   pCheckButton;
+std::unique_ptr pCheckButton;
 ScriptDocument  m_aDocument;
 voidInit();
 
commit 4b5699bff586dd923123fbfd949c9bf03e491ed7
Author: Noel Grandin 
Date:   Thu May 17 15:31:21 2018 +0200

loplugin:useuniqueptr in BreakPointList

and simplify the surrounding code

Change-Id: Ie4b24008a1c7d30d43ba562d14ddc14d1a4569b6
Reviewed-on: https://gerrit.libreoffice.org/54845
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basctl/source/basicide/baside2.cxx 
b/basctl/source/basicide/baside2.cxx
index d85eac5a1b39..217075194460 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -510,13 +510,13 @@ void ModulWindow::ToggleBreakPoint( sal_uLong nLine )
 if ( pBrk ) // remove
 {
 m_xModule->ClearBP( static_cast(nLine) );
-delete GetBreakPoints().remove( pBrk );
+GetBreakPoints().remove( pBrk );
 }
 else // create one
 {
 if ( m_xModule->SetBP( static_cast(nLine)) )
 {
-GetBreakPoints().InsertSorted( new BreakPoint( nLine ) );
+GetBreakPoints().InsertSorted( BreakPoint( nLine ) );
 if ( StarBASIC::IsRunning() )
 {
 for ( sal_uInt16 nMethod = 0; nMethod < 
m_xModule->GetMethods()->Count(); nMethod++ )
diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index 27da2dc9d828..6b97f30409e7 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -1358,8 +1358,8 @@ void BreakPointWindow::Paint(vcl::RenderContext& 
rRenderContext, const tools::Re
 
 for (size_t i = 0, n = GetBreakPoints().size(); i < n; ++i)
 {
-BreakPoint& rBrk = *GetBreakPoints().at(i);
-size_t const nLine = rBrk.nLine - 1;
+BreakPoint& rBrk = GetBreakPoints().at(i);
+sal_uInt16 const nLine = rBrk.nLine - 1;
 size_t const nY = nLine*nLineHeight - nCurYOffset;
 rRenderContext.DrawImage(Point(0, nY) + aBmpOff, aBrk[rBrk.bEnabled]);
 }
@@ -1419,11 +1419,11 @@ BreakPoint* BreakPointWindow::FindBreakPoint( const 
Point& rMousePos )
 
 for ( size_t i = 0, n = GetBreakPoints().size(); i < n ; ++i )
 {
-BreakPoint* pBrk = GetBreakPoints().at( i );
-size_t nLine = pBrk->nLine-1;
+BreakPoint& rBrk = GetBreakPoints().at( i );
+sal_uInt16 nLine = rBrk.nLine-1;
 size_t nY = nLine*nLineHeight;
 if ( ( nYPos > nY ) 

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang extensions/source

[Noel Grandin]

 compilerplugins/clang/useuniqueptr.cxx |3 +++
 extensions/source/abpilot/abpfinalpage.cxx |6 +++---
 extensions/source/abpilot/abpfinalpage.hxx |2 +-
 extensions/source/scanner/grid.cxx |   12 ++--
 4 files changed, 13 insertions(+), 10 deletions(-)

New commits:
commit 0f30c9a1ef185a76c353349f497e576cfce0cd13
Author: Noel Grandin 
Date:   Thu May 17 14:51:04 2018 +0200

loplugin:useuniqueptr in GridWindow

Change-Id: I9fd6d8ac159994c894739afbb3dccb72576dccfb
Reviewed-on: https://gerrit.libreoffice.org/54844
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/useuniqueptr.cxx 
b/compilerplugins/clang/useuniqueptr.cxx
index f09701c03ca6..4dc5b85dbf3b 100644
--- a/compilerplugins/clang/useuniqueptr.cxx
+++ b/compilerplugins/clang/useuniqueptr.cxx
@@ -56,6 +56,9 @@ public:
 // can't use std::set> until C++14
 if (fn == SRCDIR "/editeng/source/misc/svxacorr.cxx")
 return;
+// horrible horrible spawn of evil ownership and deletion here
+if (fn == SRCDIR "/sfx2/source/view/ipclient.cxx")
+return;
 
 TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
 }
diff --git a/extensions/source/scanner/grid.cxx 
b/extensions/source/scanner/grid.cxx
index 30a325bd3ac0..b6be058570e9 100644
--- a/extensions/source/scanner/grid.cxx
+++ b/extensions/source/scanner/grid.cxx
@@ -80,7 +80,7 @@ class GridWindow : public vcl::Window
 double* m_pXValues;
 double* m_pOrigYValues;
 int m_nValues;
-double* m_pNewYValues;
+std::unique_ptr m_pNewYValues;
 
 sal_uInt16  m_BmOffX;
 sal_uInt16  m_BmOffY;
@@ -128,7 +128,7 @@ public:
 
 void setBoundings( double fMinX, double fMinY, double fMaxX, double fMaxY 
);
 
-double* getNewYValues() { return m_pNewYValues; }
+double* getNewYValues() { return m_pNewYValues.get(); }
 
 void ChangeMode(ResetType nType);
 
@@ -172,8 +172,8 @@ void GridWindow::Init(double* pXValues, double* pYValues, 
int nValues, bool bCut
 
 if (m_pOrigYValues && m_nValues)
 {
-m_pNewYValues = new double[ m_nValues ];
-memcpy( m_pNewYValues, m_pOrigYValues, sizeof( double ) * m_nValues );
+m_pNewYValues.reset(new double[ m_nValues ]);
+memcpy( m_pNewYValues.get(), m_pOrigYValues, sizeof( double ) * 
m_nValues );
 }
 
 setBoundings( 0, 0, 1023, 1023 );
@@ -238,7 +238,7 @@ GridWindow::~GridWindow()
 
 void GridWindow::dispose()
 {
-delete [] m_pNewYValues;
+m_pNewYValues.reset();
 vcl::Window::dispose();
 }
 
@@ -657,7 +657,7 @@ void GridWindow::ChangeMode(ResetType nType)
 case ResetType::RESET:
 {
 if( m_pOrigYValues && m_pNewYValues && m_nValues )
-memcpy( m_pNewYValues, m_pOrigYValues, 
m_nValues*sizeof(double) );
+memcpy( m_pNewYValues.get(), m_pOrigYValues, 
m_nValues*sizeof(double) );
 }
 break;
 case ResetType::EXPONENTIAL:
commit 34652fc397757ddb2cc9f1a3646bed2d031998c1
Author: Noel Grandin 
Date:   Thu May 17 14:50:37 2018 +0200

loplugin:useuniqueptr in abp::FinalPage

Change-Id: I718d5c886f9406a8b86e268993cb298808537cbc
Reviewed-on: https://gerrit.libreoffice.org/54843
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/extensions/source/abpilot/abpfinalpage.cxx 
b/extensions/source/abpilot/abpfinalpage.cxx
index 73d0cdfe58a6..7bd03896f0c3 100644
--- a/extensions/source/abpilot/abpfinalpage.cxx
+++ b/extensions/source/abpilot/abpfinalpage.cxx
@@ -53,8 +53,8 @@ namespace abp
 get(m_pLocationLabel, "locationft");
 get(m_pName, "name");
 get(m_pDuplicateNameError, "warning");
-m_pLocationController = new 
svx::DatabaseLocationInputController(_pParent->getORB(),
-*m_pLocation, *m_pBrowse);
+m_pLocationController.reset( new 
svx::DatabaseLocationInputController(_pParent->getORB(),
+*m_pLocation, *m_pBrowse) );
 
 m_pName->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
 m_pLocation->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
@@ -72,7 +72,7 @@ namespace abp
 
 void FinalPage::dispose()
 {
-delete m_pLocationController;
+m_pLocationController.reset();
 m_pLocation.clear();
 m_pBrowse.clear();
 m_pRegisterName.clear();
diff --git a/extensions/source/abpilot/abpfinalpage.hxx 
b/extensions/source/abpilot/abpfinalpage.hxx
index 0c92487ed29a..595806a77570 100644
--- a/extensions/source/abpilot/abpfinalpage.hxx
+++ b/extensions/source/abpilot/abpfinalpage.hxx
@@ -43,7 +43,7 @@ namespace abp
 VclPtr m_pName;
 VclPtr

[Libreoffice-commits] core.git: 2 commits - cui/source include/sfx2 include/svx include/unotools sal/rtl sc/source sd/source sfx2/source svx/source unotools/source vcl/inc vcl/source writerperfect/sou

[Noel Grandin]

 cui/source/tabpages/textattr.cxx |2 
 include/sfx2/docfile.hxx |1 
 include/svx/dlgctrl.hxx  |8 
 include/unotools/historyoptions.hxx  |   10 -
 sal/rtl/alloc_arena.hxx  |3 
 sal/rtl/alloc_cache.cxx  |   18 --
 sc/source/ui/inc/sortkeydlg.hxx  |2 
 sd/source/ui/table/TableDesignPane.cxx   |6 
 sd/source/ui/table/TableDesignPane.hxx   |3 
 sfx2/source/doc/docfile.cxx  |6 
 svx/source/dialog/dlgctrl.cxx|  227 +++
 unotools/source/config/historyoptions.cxx|7 
 vcl/inc/messagedialog.hxx|1 
 vcl/inc/salwtype.hxx |1 
 vcl/source/gdi/pdfwriter_impl.cxx|   11 -
 vcl/source/gdi/pdfwriter_impl.hxx|1 
 vcl/source/window/layout.cxx |   13 -
 writerperfect/source/writer/exp/txtstyli.cxx |5 
 writerperfect/source/writer/exp/txtstyli.hxx |1 
 19 files changed, 101 insertions(+), 225 deletions(-)

New commits:
commit 96d7c67d98527b1ccc1cfba3ca817238e582d63b
Author: Noel Grandin 
Date:   Fri May 25 16:34:11 2018 +0200

loplugin:unusedfields

Change-Id: I625b73152c0c277c6e0ce3e24e4704094fc4e8ff
Reviewed-on: https://gerrit.libreoffice.org/54822
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/cui/source/tabpages/textattr.cxx b/cui/source/tabpages/textattr.cxx
index 3013bd6038d7..9cb423211176 100644
--- a/cui/source/tabpages/textattr.cxx
+++ b/cui/source/tabpages/textattr.cxx
@@ -81,7 +81,7 @@ SvxTextAttrPage::SvxTextAttrPage(TabPageParent pPage, const 
SfxItemSet& rInAttrs
 , m_xCtlPosition(new weld::CustomWeld(*m_xBuilder, "CTL_POSITION", 
m_aCtlPosition))
 , m_xTsbFullWidth(m_xBuilder->weld_check_button("TSB_FULL_WIDTH"))
 {
-m_aCtlPosition.SetControlSettings(RectPoint::MM, 240, 100);
+m_aCtlPosition.SetControlSettings(RectPoint::MM, 240);
 
 FieldUnit eFUnit = GetModuleFieldUnit( rInAttrs );
 SetFieldUnit( *m_xMtrFldLeft, eFUnit );
diff --git a/include/svx/dlgctrl.hxx b/include/svx/dlgctrl.hxx
index c14761bd8017..c7a1e1087765 100644
--- a/include/svx/dlgctrl.hxx
+++ b/include/svx/dlgctrl.hxx
@@ -100,7 +100,6 @@ protected:
 BitmapEx* pBitmap;
 CTL_STATE m_nState;
 
-bool mbCompleteDisable : 1;
 bool mbUpdateForeground : 1;
 bool mbUpdateBackground : 1;
 
@@ -143,8 +142,6 @@ public:
 virtual css::uno::Reference< css::accessibility::XAccessible > 
CreateAccessible() override;
 
 RectPoint  GetApproxRPFromPixPt( const css::awt::Point& 
rPixelPoint ) const;
-
-bool IsCompletelyDisabled() const { return mbCompleteDisable; }
 };
 
 class SAL_WARN_UNUSED SVX_DLLPUBLIC RectCtl : public 
weld::CustomWidgetController
@@ -163,7 +160,6 @@ private:
 protected:
 rtl::Reference pAccContext;
 sal_uInt16 nBorderWidth;
-sal_uInt16 nRadius;
 Point aPtLT, aPtMT, aPtRT;
 Point aPtLM, aPtMM, aPtRM;
 Point aPtLB, aPtMB, aPtRB;
@@ -180,8 +176,8 @@ protected:
 
 Point   GetApproxLogPtFromPixPt( const Point& rRoughPixelPoint 
) const;
 public:
-RectCtl(SvxTabPage* pPage, RectPoint eRpt = RectPoint::MM, sal_uInt16 
nBorder = 200, sal_uInt16 nCircle = 80);
-void SetControlSettings(RectPoint eRpt, sal_uInt16 nBorder, sal_uInt16 
nCircl);
+RectCtl(SvxTabPage* pPage, RectPoint eRpt = RectPoint::MM, sal_uInt16 
nBorder = 200);
+void SetControlSettings(RectPoint eRpt, sal_uInt16 nBorder);
 virtual ~RectCtl() override;
 
 virtual void Paint(vcl::RenderContext& rRenderContext, const 
tools::Rectangle&) override;
diff --git a/sal/rtl/alloc_arena.hxx b/sal/rtl/alloc_arena.hxx
index 8bc419e33090..7da1c532e30e 100644
--- a/sal/rtl/alloc_arena.hxx
+++ b/sal/rtl/alloc_arena.hxx
@@ -100,8 +100,6 @@ struct rtl_arena_st
 rtl_arena_segment_type *  m_hash_table_0[RTL_ARENA_HASH_SIZE];
 sal_Size  m_hash_size;  /* m_hash_mask + 1   */
 sal_Size  m_hash_shift; /* log2(m_hash_size) */
-
-rtl_cache_type ** m_qcache_ptr;
 };
 
 /** gp_default_arena
diff --git a/sd/source/ui/table/TableDesignPane.cxx 
b/sd/source/ui/table/TableDesignPane.cxx
index 1a61bf6f100e..23a8dd2499e4 100644
--- a/sd/source/ui/table/TableDesignPane.cxx
+++ b/sd/source/ui/table/TableDesignPane.cxx
@@ -86,8 +86,6 @@ static const OUStringLiteral gPropNames[CB_COUNT] =
 
 TableDesignWidget::TableDesignWidget( VclBuilderContainer* pParent, 
ViewShellBase& rBase )
 : mrBase(rBase)
-, mbStyleSelected(false)
-, mbOptionsChanged(false)
 {
 pParent->get(m_pValueSet, "previews");
 m_pValueSet->SetStyle(m_pValueSet->GetStyle() | WB_NO_DIRECTSELECT | 
WB_FLATVALUESET | WB_ITEMBORDER);
@@ -146,7 +144,6 @@ static SfxDispatcher* getDispatcher( ViewShellBase const & 
rBase )
 
 

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90796

Aron Budea  changed:

   What|Removed |Added

 Depends on||117702


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117702
[Bug 117702] Screen resolution problems with HDPi using LO 6.0.4.2
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117702] Screen resolution problems with HDPi using LO 6.0.4.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117702

Aron Budea  changed:

   What|Removed |Added

 Blocks||90796


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117789] Sidebar: New Shapes deck isn't scrollable with touchpad ( and maybe mouse wheel)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117789

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
Version|unspecified |6.1.0.0.alpha1+
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Confirmed using LO 6.1 beta1 / Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117481] no images in buttons in Database pane in main database window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117481

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117481] no images in buttons in Database pane in main database window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117481

--- Comment #17 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=18c85f770bca04f71b03c4ca06da1a0488842512

tdf#117481 Karasa Jaga: Add dbaccess icons for base sidebar

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/karasa_jaga

[Rizal Muttaqin]

 dev/null  |binary
 icon-themes/karasa_jaga/COPYING   |  224 ++
 icon-themes/karasa_jaga/cmd/32/addtable.png   |binary
 icon-themes/karasa_jaga/cmd/32/dbformdelete.png   |binary
 icon-themes/karasa_jaga/cmd/32/dbquerydelete.png  |binary
 icon-themes/karasa_jaga/cmd/32/dbreportdelete.png |binary
 icon-themes/karasa_jaga/cmd/32/dbtabledelete.png  |binary
 icon-themes/karasa_jaga/cmd/32/dbtableedit.png|binary
 icon-themes/karasa_jaga/cmd/32/dbtablerename.png  |binary
 icon-themes/karasa_jaga/cmd/32/deleteannotation.png   |binary
 icon-themes/karasa_jaga/cmd/32/deletecolumns.png  |binary
 icon-themes/karasa_jaga/cmd/32/deletecomment.png  |binary
 icon-themes/karasa_jaga/cmd/32/deletemasterpage.png   |binary
 icon-themes/karasa_jaga/cmd/32/deletepage.png |binary
 icon-themes/karasa_jaga/cmd/32/deleterecord.png   |binary
 icon-themes/karasa_jaga/cmd/32/deleterows.png |binary
 icon-themes/karasa_jaga/cmd/32/deleteslide.png|binary
 icon-themes/karasa_jaga/cmd/32/deletetable.png|binary
 icon-themes/karasa_jaga/cmd/32/exportdirecttoepub.png |binary
 icon-themes/karasa_jaga/cmd/32/exporttoepub.png   |binary
 icon-themes/karasa_jaga/cmd/32/exporttopdf.png|binary
 icon-themes/karasa_jaga/cmd/lc_dbformdelete.png   |binary
 icon-themes/karasa_jaga/cmd/lc_dbreportdelete.png |binary
 icon-themes/karasa_jaga/cmd/lc_dbtabledelete.png  |binary
 icon-themes/karasa_jaga/cmd/lc_deleteannotation.png   |binary
 icon-themes/karasa_jaga/cmd/lc_deletemasterpage.png   |binary
 icon-themes/karasa_jaga/cmd/lc_deletepage.png |binary
 icon-themes/karasa_jaga/cmd/lc_deleteslide.png|binary
 icon-themes/karasa_jaga/cmd/lc_deletetable.png|binary
 icon-themes/karasa_jaga/cmd/lc_exportdirecttoepub.png |binary
 icon-themes/karasa_jaga/cmd/lc_exportdirecttopdf.png  |binary
 icon-themes/karasa_jaga/cmd/lc_exporttoepub.png   |binary
 icon-themes/karasa_jaga/cmd/lc_greatestwidth.png  |binary
 icon-themes/karasa_jaga/cmd/lc_insertslide.png|binary
 icon-themes/karasa_jaga/cmd/sc_dbreportdelete.png |binary
 icon-themes/karasa_jaga/cmd/sc_deletemasterpage.png   |binary
 icon-themes/karasa_jaga/cmd/sc_deletepage.png |binary
 icon-themes/karasa_jaga/cmd/sc_deleteslide.png|binary
 icon-themes/karasa_jaga/cmd/sc_exportdirecttoepub.png |binary
 icon-themes/karasa_jaga/cmd/sc_exportdirecttopdf.png  |binary
 icon-themes/karasa_jaga/cmd/sc_exporttoepub.png   |binary
 icon-themes/karasa_jaga/cmd/sc_greatestheight.png |binary
 icon-themes/karasa_jaga/cmd/sc_greatestwidth.png  |binary
 icon-themes/karasa_jaga/dbaccess/res/all_left.png |binary
 icon-themes/karasa_jaga/dbaccess/res/all_right.png|binary
 icon-themes/karasa_jaga/dbaccess/res/form_16.png  |binary
 icon-themes/karasa_jaga/dbaccess/res/reports_32.png   |binary
 icon-themes/karasa_jaga/dbaccess/res/sc021.png|binary
 icon-themes/karasa_jaga/dbaccess/res/sc023.png|binary
 icon-themes/karasa_jaga/dbaccess/res/sortdown.png |binary
 icon-themes/karasa_jaga/dbaccess/res/sortup.png   |binary
 icon-themes/karasa_jaga/dbaccess/res/tables_32.png|binary
 icon-themes/karasa_jaga/links.txt |   13 -
 icon-themes/karasa_jaga/res/lx03126.png   |binary
 icon-themes/karasa_jaga/res/lx03188.png   |binary
 icon-themes/karasa_jaga/res/sx03126.png   |binary
 icon-themes/karasa_jaga/res/sx03127.png   |binary
 icon-themes/karasa_jaga/res/sx03132.png   |binary
 icon-themes/karasa_jaga/res/sx03188.png   |binary
 icon-themes/karasa_jaga/res/tables_32.png |binary
 icon-themes/karasa_jaga/sfx2/res/startcenter-logo.svg |   91 ---
 61 files changed, 224 insertions(+), 104 deletions(-)

New commits:
commit 18c85f770bca04f71b03c4ca06da1a0488842512
Author: Rizal Muttaqin 
Date:   Fri May 25 10:14:41 2018 +0700

tdf#117481 Karasa Jaga: Add dbaccess icons for base sidebar

Change-Id: I5174261484c64a6f223c4a2e197d0e042c3581e4
Reviewed-on: https://gerrit.libreoffice.org/54787
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/karasa_jaga/COPYING b/icon-themes/karasa_jaga/COPYING
new file mode 100644
index ..5938d6c1cd38
--- /dev/null
+++ b/icon-themes/karasa_jaga/COPYING
@@ -0,0 +1,224 @@
+Karasa Jaga Icon Theme for Sundara OS 
+Copyright (c) 2014 Rizal Muttaqin 
+
+Karasa Jaga icon theme is derived heavily from Oxygen icon theme, used 
+for Sundara OS branding. LibreOffice Style Karasa Jaga is part of Karasa 
+Jaga icon theme. For further information see at 
+https://github.com/rizmut/libreoffice-style-karasa-jaga.
+
+The Oxygen Icon Theme
+Copyright (C) 2007 Nuno Pinheiro 

[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source

[Bjoern Michaelsen]

 sw/inc/fmtmeta.hxx  |1 
 sw/inc/unochart.hxx |7 ---
 sw/source/core/txtnode/fmtatr2.cxx  |6 +--
 sw/source/core/unocore/unochart.cxx |6 ---
 sw/source/core/unocore/unorefmk.cxx |   70 
 5 files changed, 38 insertions(+), 52 deletions(-)

New commits:
commit 538c6219a2a347f9f601288a2dd345bf7d3c3209
Author: Bjoern Michaelsen 
Date:   Thu May 10 10:51:42 2018 +0200

dont use SwClient/SwModify in unocore: Meta

Change-Id: Icde1f5b9af599ca8b1ef52863c2772670659a39b
Reviewed-on: https://gerrit.libreoffice.org/54648
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/inc/fmtmeta.hxx b/sw/inc/fmtmeta.hxx
index 9fe0fce07656..bcc93b107e77 100644
--- a/sw/inc/fmtmeta.hxx
+++ b/sw/inc/fmtmeta.hxx
@@ -127,6 +127,7 @@ namespace sw {
 class Meta
 : public ::sfx2::Metadatable
 , public SwModify
+, public sw::BroadcasterMixin
 {
 protected:
 friend class ::SwFormatMeta; ///< SetFormatMeta, NotifyChangeTextNode
diff --git a/sw/source/core/txtnode/fmtatr2.cxx 
b/sw/source/core/txtnode/fmtatr2.cxx
index 374326f40eb6..f74696687558 100644
--- a/sw/source/core/txtnode/fmtatr2.cxx
+++ b/sw/source/core/txtnode/fmtatr2.cxx
@@ -664,9 +664,7 @@ void Meta::NotifyChangeTextNode(SwTextNode *const pTextNode)
 }
 if (!pTextNode) // text node gone? invalidate UNO object!
 {
-SwPtrMsgPoolItem aMsgHint( RES_REMOVE_UNO_OBJECT,
-_cast(*this) ); // cast to base class!
-Modify(, );
+GetNotifier().Broadcast(SfxHint(SfxHintId::Deinitializing));
 }
 }
 
@@ -674,9 +672,11 @@ void Meta::NotifyChangeTextNode(SwTextNode *const 
pTextNode)
 void Meta::Modify( const SfxPoolItem *pOld, const SfxPoolItem *pNew )
 {
 NotifyClients(pOld, pNew);
+GetNotifier().Broadcast(SfxHint(SfxHintId::DataChanged));
 if (pOld && (RES_REMOVE_UNO_OBJECT == pOld->Which()))
 {   // invalidate cached uno object
 SetXMeta(uno::Reference(nullptr));
+GetNotifier().Broadcast(SfxHint(SfxHintId::Deinitializing));
 }
 }
 
diff --git a/sw/source/core/unocore/unorefmk.cxx 
b/sw/source/core/unocore/unorefmk.cxx
index b989ad8a28fe..41793c482bbe 100644
--- a/sw/source/core/unocore/unorefmk.cxx
+++ b/sw/source/core/unocore/unorefmk.cxx
@@ -607,8 +607,7 @@ SwXMetaText::createTextCursorByRange(
 // the Meta has a cached list of text portions for its contents
 // this list is created by SwXTextPortionEnumeration
 // the Meta listens at the SwTextNode and throws away the cache when it changes
-class SwXMeta::Impl
-: public SwClient
+class SwXMeta::Impl : public SvtListener
 {
 private:
 ::osl::Mutex m_Mutex; // just for OInterfaceContainerHelper2
@@ -622,56 +621,53 @@ public:
 bool m_bIsDescriptor;
 uno::Reference m_xParentText;
 rtl::Reference m_xText;
+sw::Meta* m_pMeta;
 
-Impl(   SwXMeta & rThis, SwDoc & rDoc,
-::sw::Meta * const pMeta,
+Impl(SwXMeta& rThis, SwDoc& rDoc,
+::sw::Meta* const pMeta,
 uno::Reference const& xParentText,
 TextRangeList_t const * const pPortions)
-: SwClient(pMeta)
-, m_EventListeners(m_Mutex)
-, m_pTextPortions( pPortions )
-, m_bIsDisposed( false )
+: m_EventListeners(m_Mutex)
+, m_pTextPortions(pPortions)
+, m_bIsDisposed(false)
 , m_bIsDescriptor(nullptr == pMeta)
 , m_xParentText(xParentText)
 , m_xText(new SwXMetaText(rDoc, rThis))
+, m_pMeta(pMeta)
 {
+!m_bIsDescriptor && StartListening(m_pMeta->GetNotifier());
 }
 
-inline const ::sw::Meta * GetMeta() const;
+inline const ::sw::Meta* GetMeta() const;
 // only for SwXMetaField!
-inline const ::sw::MetaField * GetMetaField() const;
+inline const ::sw::MetaField* GetMetaField() const;
 protected:
-// SwClient
-virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) 
override;
+virtual void Notify(const SfxHint& rHint) override;
 
 };
 
-inline const ::sw::Meta * SwXMeta::Impl::GetMeta() const
+inline const ::sw::Meta* SwXMeta::Impl::GetMeta() const
 {
-return static_cast< const ::sw::Meta * >(GetRegisteredIn());
+return m_pMeta;
 }
 
 // SwModify
-void SwXMeta::Impl::Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew )
+void SwXMeta::Impl::Notify(const SfxHint& rHint)
 {
 m_pTextPortions.reset(); // throw away cache (SwTextNode changed)
-
-ClientModify(this, pOld, pNew);
-
-if (GetRegisteredIn())
+if(rHint.GetId() == SfxHintId::Dying || rHint.GetId() == 
SfxHintId::Deinitializing)
 {
-return; // core object still alive
-}
-
-m_bIsDisposed = true;
-m_xText->Invalidate();
-uno::Reference const xThis(m_wThis);
-if (!xThis.is())
-{   // fdo#72695: if UNO object is already dead, don't revive it 

[Libreoffice-bugs] [Bug 117806] Support =IFERROR(1/0)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117806

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu,
   ||er...@redhat.com

--- Comment #1 from Aron Budea  ---
Eike, what's your opinion on this enhancement?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117606] Problem opening excelfile edited with Libreoffice calc in MS excel 2010 - warning /Damaged file...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117606

--- Comment #10 from sverre48  ---
Created attachment 142330
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142330=edit
The file damaged - warning - in Norwegian [4]

I experienced a similar conflict with a document edited in Libreoffice 6.0.4.2
and may have found out at least missing information (repaired in MS office). 

I think the problem is that Libreoffice allows too long sheet names. This limit
should/must be compatible with MS office

PS I do not want to share the office docmt due to that it is private/privacy.
You should just test it yourself. The problem is to me proved (I know the sheet
name is longer than attmt 4 shows (MS off. 2010, repaired...)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117606] Problem opening excelfile edited with Libreoffice calc in MS excel 2010 - warning /Damaged file...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117606

--- Comment #9 from sverre48  ---
Created attachment 142329
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142329=edit
The file damaged - warning - in Norwegian [3]

I experienced a similar conflict with a document edited in Libreoffice 6.0.4.2
and may have found out at least missing information (repaired in MS office).
See attmt 4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117759] Create new odt file containing formula leaves temporary file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117759

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisected, bisected

--- Comment #3 from Aron Budea  ---
Originates from the same commit as mentioned in bug 117225 comment 3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117606] Problem opening excelfile edited with Libreoffice calc in MS excel 2010 - warning /Damaged file...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117606

--- Comment #8 from sverre48  ---
Created attachment 142328
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142328=edit
The file damaged - warning - in Norwegian step 2 [2]

I experienced a similar conflict with a document edited in Libreoffice 6.0.4.2
and may have found out at least missing information (repaired in MS office).
See attmt 4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117606] Problem opening excelfile edited with Libreoffice calc in MS excel 2010 - warning /Damaged file...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117606

--- Comment #7 from sverre48  ---
Created attachment 142327
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142327=edit
The file damaged - warning - in Norwegian

I experienced a similar conflict with a document edited in Libreoffice 6.0.4.2
and may have found out at least missing information (repaired in MS office).
See attmt 4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs