[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)
https://bugs.documentfoundation.org/show_bug.cgi?id=143148 --- Comment #109 from Commit Notification --- Taichi Haradaguchi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a688f401980646577d353e96d271499b9b720667 tdf#143148: Use pragma once instead of include guards in vcl/osx It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/a11yactionwrapper.h |5 + vcl/osx/a11ycomponentwrapper.h |5 + vcl/osx/a11yrolehelper.h|5 + vcl/osx/a11yselectionwrapper.h |5 + vcl/osx/a11ytablewrapper.h |4 +--- vcl/osx/a11ytextattributeswrapper.h |4 +--- vcl/osx/a11ytextwrapper.h |5 + vcl/osx/a11yutil.h |4 +--- vcl/osx/a11yvaluewrapper.h |5 + vcl/osx/a11ywrapperbutton.h |5 + vcl/osx/a11ywrappercheckbox.h |5 + vcl/osx/a11ywrappercombobox.h |5 + vcl/osx/a11ywrappergroup.h |5 + vcl/osx/a11ywrapperlist.h |5 + vcl/osx/a11ywrapperradiobutton.h|5 + vcl/osx/a11ywrapperradiogroup.h |5 + vcl/osx/a11ywrapperrow.h|5 + vcl/osx/a11ywrapperscrollarea.h |5 + vcl/osx/a11ywrapperscrollbar.h |5 + vcl/osx/a11ywrappersplitter.h |5 + vcl/osx/a11ywrapperstatictext.h |5 + vcl/osx/a11ywrappertabgroup.h |5 + vcl/osx/a11ywrappertextarea.h |5 + vcl/osx/a11ywrappertoolbar.h|5 + 24 files changed, 24 insertions(+), 93 deletions(-) New commits: commit a688f401980646577d353e96d271499b9b720667 Author: Taichi Haradaguchi <20001...@ymail.ne.jp> AuthorDate: Sun Nov 19 10:58:51 2023 +0900 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Sun Nov 19 06:42:30 2023 +0100 tdf#143148: Use pragma once instead of include guards in vcl/osx Change-Id: I0f6edb1f4ed5310bf0bb7d051852a4c86205431f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159647 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/vcl/osx/a11yactionwrapper.h b/vcl/osx/a11yactionwrapper.h index 9afc08b6b970..eb0141c805d1 100644 --- a/vcl/osx/a11yactionwrapper.h +++ b/vcl/osx/a11yactionwrapper.h @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_OSX_A11YACTIONWRAPPER_H -#define INCLUDED_VCL_OSX_A11YACTIONWRAPPER_H +#pragma once #include #include @@ -31,6 +30,4 @@ + (NSAccessibilityActionName)actionNameForSelector:(SEL)aSelector; @end -#endif // INCLUDED_VCL_OSX_A11YACTIONWRAPPER_H - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/osx/a11ycomponentwrapper.h b/vcl/osx/a11ycomponentwrapper.h index 3d8b16929279..a63f327e43bb 100644 --- a/vcl/osx/a11ycomponentwrapper.h +++ b/vcl/osx/a11ycomponentwrapper.h @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_OSX_A11YCOMPONENTWRAPPER_H -#define INCLUDED_VCL_OSX_A11YCOMPONENTWRAPPER_H +#pragma once #include #include @@ -34,6 +33,4 @@ + (void)setFocusedAttributeForElement:(AquaA11yWrapper*)wrapper to:(id)value; @end -#endif // INCLUDED_VCL_OSX_A11YCOMPONENTWRAPPER_H - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/osx/a11yrolehelper.h b/vcl/osx/a11yrolehelper.h index 7a4df6dbe967..db349ad38ddd 100644 --- a/vcl/osx/a11yrolehelper.h +++ b/vcl/osx/a11yrolehelper.h @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_OSX_A11YROLEHELPER_H -#define INCLUDED_VCL_OSX_A11YROLEHELPER_H +#pragma once #include @@ -30,6 +29,4 @@ +(id)getRoleDescriptionFrom: (NSString *) role with: (NSString *) subRole; @end -#endif // INCLUDED_VCL_OSX_A11YROLEHELPER_H - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/osx/a11yselectionwrapper.h b/vcl/osx/a11yselectionwrapper.h index 880281a114ed..3b62fbd903a8 100644 --- a/vcl/osx/a11yselectionwrapper.h +++ b/vcl/osx/a11yselectionwrapper.h @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_OSX_A11YSELECTIONWRAPPER_H -#define INCLUDED_VCL_OSX_A11YSELECTIONWRAPPER_H +#pragma once #include #include @@ -32,6 +31,4 @@ + (void)setSelectedChildrenAttributeForElement:(AquaA11yWrapper*)wrapper to:(id)value; @end -#endif // INCLUDED_VCL_OSX_A11YSELECTIONWRAPPER_H - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/osx/a11ytablewrapper.h b/vcl/osx/a11ytablewrapper.h index ae2c454a81f0..bc8ce4f39ff1 100644 --- a/vcl/osx/a11ytablewrapper.h +++ b/vcl/osx/a11ytablewrapper.h @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_OSX_A11YTABLEWRAPPER_H -#define INCLUDED_VCL_OSX_A11YTABLEWRAPPER_H +#pragma once #include @@ -33,6 +32,5 @@ - (id)rowsAttribute; - (id)columnsAttribute; @end -#endif // INCLUDED_VCL_OSX_A11YTABLEWRAPPER_H /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/osx/a11ytextattributeswrapper.h b/vcl/osx/a11ytextattributeswrapper.h index 4170f5f8a8cc..7df60a93833a 100644 --- a/vcl/osx/a11ytextattributeswrapper.h +++ b/vcl/osx/a11ytextattributeswrapper.h @@
[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)
https://bugs.documentfoundation.org/show_bug.cgi?id=143148 --- Comment #108 from Commit Notification --- Taichi Haradaguchi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9beb65b258f5e3e95ad4b86f2682c15ea1dac1af tdf#143148: Use pragma once instead of include guards in vcl/source It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/jpeg/jpeg.h |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit 9beb65b258f5e3e95ad4b86f2682c15ea1dac1af
Author: Taichi Haradaguchi <20001...@ymail.ne.jp>
AuthorDate: Sun Nov 19 10:49:53 2023 +0900
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Sun Nov 19 06:41:07 2023 +0100
tdf#143148: Use pragma once instead of include guards in vcl/source
Change-Id: Ie19a3e16861946434342c7e07482ae649a4afb4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159646
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
diff --git a/vcl/source/filter/jpeg/jpeg.h b/vcl/source/filter/jpeg/jpeg.h
index a7ddcffa6ece..2cf600bb6de4 100644
--- a/vcl/source/filter/jpeg/jpeg.h
+++ b/vcl/source/filter/jpeg/jpeg.h
@@ -17,8 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef INCLUDED_VCL_SOURCE_FILTER_JPEG_JPEG_H
-#define INCLUDED_VCL_SOURCE_FILTER_JPEG_JPEG_H
+#pragma once
#include
@@ -62,6 +61,4 @@ struct SourceManagerStruct {
int no_data_available_failures;
};
-#endif
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-ux-advise] [Bug 41119] Copy SVG Code Directly into LibreOffice to Render Pictures
https://bugs.documentfoundation.org/show_bug.cgi?id=41119 --- Comment #21 from Tomaz Vajngerl --- I don't see any blockers - we just need to detect if the text is a valid SVG. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 41119] Copy SVG Code Directly into LibreOffice to Render Pictures
https://bugs.documentfoundation.org/show_bug.cgi?id=41119 --- Comment #21 from Tomaz Vajngerl --- I don't see any blockers - we just need to detect if the text is a valid SVG. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158196] Add 'shuffle' or 'random' option to 'Sort' dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=158196 Tomaz Vajngerl changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #15 from Tomaz Vajngerl --- I found the code and updated the https://gerrit.libreoffice.org/c/core/+/22963 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 158196] Add 'shuffle' or 'random' option to 'Sort' dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=158196 Tomaz Vajngerl changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #15 from Tomaz Vajngerl --- I found the code and updated the https://gerrit.libreoffice.org/c/core/+/22963 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 --- Comment #9 from Gurnam Rahi --- Media Playback bug is a common bug now a days. There are many methods and technique available online to solve this. I tried an app https://reminimodproapk.com/ that solves this bug with few clicks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158270] New: LibreOffice.app crashes upon attempted start in Sonoma
https://bugs.documentfoundation.org/show_bug.cgi?id=158270 Bug ID: 158270 Summary: LibreOffice.app crashes upon attempted start in Sonoma Product: LibreOffice Version: 7.6.2.1 release Hardware: ARM OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@arrl.net Description: LibreOffice.app crashes upon attempted start in Sonoma (currently 14.2 Beta (23C5047e)) Double-click LibreOffice.app, it appears briefly in Dock, then crashes off. Downloaded fresh (but identical) copy of LibreOffice_7.6.2_MacOS_aarch64.dmg, reinstalled. Same thing. Steps to Reproduce: 1.Double-click LibreOffice.app 2.App crashes Actual Results: as above Expected Results: worked fine in Monterey, Ventura, earlier ... Reproducible: Always User Profile Reset: No Additional Info: start and offer choice of function -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154948] The color gradation in objects does not function.
https://bugs.documentfoundation.org/show_bug.cgi?id=154948 --- Comment #3 from QA Administrators --- Dear Ito, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154944] [ feature request ] please improve the tabbed interface
https://bugs.documentfoundation.org/show_bug.cgi?id=154944 --- Comment #6 from QA Administrators --- Dear yogilok, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151304] Cursor position error.
https://bugs.documentfoundation.org/show_bug.cgi?id=151304 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151304] Cursor position error.
https://bugs.documentfoundation.org/show_bug.cgi?id=151304 --- Comment #16 from QA Administrators --- Dear Frants, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155435] Duplicating sheet containing COUNTIF references to ranges in external files damages formula
https://bugs.documentfoundation.org/show_bug.cgi?id=155435 --- Comment #3 from QA Administrators --- Dear brodders, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143333] FILEOPEN XLSX Workbook structure protection password not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=14 --- Comment #3 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155432] text printing in wrong cell
https://bugs.documentfoundation.org/show_bug.cgi?id=155432 --- Comment #5 from QA Administrators --- Dear Stuart Gillies, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125552] PPTX: FILESAVE: Smartart font type changes after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=125552 --- Comment #8 from QA Administrators --- Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142789] Memory usage around 1000 MB for 70 page document with file size of 27 MB (images); 360 MB with 6.4
https://bugs.documentfoundation.org/show_bug.cgi?id=142789 --- Comment #8 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124784] Replace messagebox on file load with user prompt for recalculation by an infobar
https://bugs.documentfoundation.org/show_bug.cgi?id=124784 --- Comment #12 from QA Administrators --- Dear b., To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106503] Text Position in Writer And Calc Shapes is Inconsistent / Should Use the old defaults(Center Align)
https://bugs.documentfoundation.org/show_bug.cgi?id=106503 --- Comment #11 from QA Administrators --- Dear Luke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158269] Writer's PNG export produces corrupt file
https://bugs.documentfoundation.org/show_bug.cgi?id=158269 --- Comment #5 from m.a.riosv --- On Windows, got Add/remove, and select repair for LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/text.cxx | 97
1 file changed, 97 insertions(+)
New commits:
commit 4a1fac7c703068a49df897bb635ff98bf22c0468
Author: Chris Sherlock
AuthorDate: Wed Nov 8 14:21:47 2023 +1100
Commit: Tomaž Vajngerl
CommitDate: Sun Nov 19 02:24:59 2023 +0100
vcl: add unit tests for simple text 'AV' with kerning and no-kerning enabled
Change-Id: I72812c9fd83730daf62aeb4a300c548f153ee8a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159091
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/qa/cppunit/text.cxx b/vcl/qa/cppunit/text.cxx
index 59e079c963ce..b2e837a32c40 100644
--- a/vcl/qa/cppunit/text.cxx
+++ b/vcl/qa/cppunit/text.cxx
@@ -224,6 +224,103 @@ CPPUNIT_TEST_FIXTURE(VclTextTest, testSimpleText)
CPPUNIT_ASSERT_DOUBLES_EQUAL(width36 / 2, width36pct50, 2);
}
+CPPUNIT_TEST_FIXTURE(VclTextTest, testSimpleTextFontSpecificKerning)
+{
+OUString aAV(u"AV"_ustr);
+
+vcl::Font aFont("DejaVu Sans", "Book", Size(0, 2048));
+
+ScopedVclPtrInstance pOutDev;
+pOutDev->SetFont(aFont);
+
+// absolute character widths AKA text array.
+tools::Long nRefTextWidth = 2671;
+std::vector aRefCharWidths = { 1270, 2671 };
+KernArray aCharWidths;
+tools::Long nTextWidth = pOutDev->GetTextArray(aAV, );
+
+CPPUNIT_ASSERT_EQUAL(aRefCharWidths[0],
aCharWidths.get_subunit_array()[0]);
+CPPUNIT_ASSERT_EQUAL(aRefCharWidths[1],
aCharWidths.get_subunit_array()[1]);
+// this sporadically returns 75 or 74 on some of the windows tinderboxes
eg. tb73
+CPPUNIT_ASSERT_EQUAL(nRefTextWidth, nTextWidth);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(nTextWidth), aCharWidths.back());
+
+// text advance width and line height
+CPPUNIT_ASSERT_EQUAL(nRefTextWidth, pOutDev->GetTextWidth(aAV));
+CPPUNIT_ASSERT_EQUAL(tools::Long(2384), pOutDev->GetTextHeight());
+
+// exact bounding rectangle, not essentially the same as text width/height
+tools::Rectangle aBoundRect;
+pOutDev->GetTextBoundRect(aBoundRect, aAV);
+CPPUNIT_ASSERT_EQUAL(tools::Long(16), aBoundRect.Left());
+CPPUNIT_ASSERT_EQUAL(tools::Long(408), aBoundRect.Top());
+CPPUNIT_ASSERT_EQUAL(tools::Long(2639), aBoundRect.GetWidth());
+CPPUNIT_ASSERT_EQUAL(tools::Long(1493), aBoundRect.getOpenHeight());
+
+// normal orientation
+tools::Rectangle aInput;
+tools::Rectangle aRect = pOutDev->GetTextRect(aInput, aAV);
+
+// now rotate 270 degrees
+vcl::Font aRotated(aFont);
+aRotated.SetOrientation(2700_deg10);
+pOutDev->SetFont(aRotated);
+tools::Rectangle aRectRot = pOutDev->GetTextRect(aInput, aAV);
+
+// Check that we did do the rotation...
+CPPUNIT_ASSERT_EQUAL(aRectRot.GetWidth(), aRect.GetHeight());
+CPPUNIT_ASSERT_EQUAL(aRectRot.GetHeight(), aRect.GetWidth());
+}
+
+CPPUNIT_TEST_FIXTURE(VclTextTest, testSimpleTextNoKerning)
+{
+OUString aAV(u"AV"_ustr);
+
+vcl::Font aFont("DejaVu Sans", "Book", Size(0, 2048));
+aFont.SetKerning(FontKerning::NONE);
+
+ScopedVclPtrInstance pOutDev;
+pOutDev->SetFont(aFont);
+
+// absolute character widths AKA text array.
+tools::Long nRefTextWidth = 2802;
+std::vector aRefCharWidths = { 1401, 2802 };
+KernArray aCharWidths;
+tools::Long nTextWidth = pOutDev->GetTextArray(aAV, );
+
+CPPUNIT_ASSERT_EQUAL(aRefCharWidths[0],
aCharWidths.get_subunit_array()[0]);
+CPPUNIT_ASSERT_EQUAL(aRefCharWidths[1],
aCharWidths.get_subunit_array()[1]);
+// this sporadically returns 75 or 74 on some of the windows tinderboxes
eg. tb73
+CPPUNIT_ASSERT_EQUAL(nRefTextWidth, nTextWidth);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(nTextWidth), aCharWidths.back());
+
+// text advance width and line height
+CPPUNIT_ASSERT_EQUAL(nRefTextWidth, pOutDev->GetTextWidth(aAV));
+CPPUNIT_ASSERT_EQUAL(tools::Long(2384), pOutDev->GetTextHeight());
+
+// exact bounding rectangle, not essentially the same as text width/height
+tools::Rectangle aBoundRect;
+pOutDev->GetTextBoundRect(aBoundRect, aAV);
+CPPUNIT_ASSERT_EQUAL(tools::Long(16), aBoundRect.Left());
+CPPUNIT_ASSERT_EQUAL(tools::Long(408), aBoundRect.Top());
+CPPUNIT_ASSERT_EQUAL(tools::Long(2770), aBoundRect.GetWidth());
+CPPUNIT_ASSERT_EQUAL(tools::Long(1493), aBoundRect.getOpenHeight());
+
+// normal orientation
+tools::Rectangle aInput;
+tools::Rectangle aRect = pOutDev->GetTextRect(aInput, aAV);
+
+// now rotate 270 degrees
+vcl::Font aRotated(aFont);
+aRotated.SetOrientation(2700_deg10);
+pOutDev->SetFont(aRotated);
+tools::Rectangle aRectRot = pOutDev->GetTextRect(aInput, aAV);
+
+// Check that we did do the rotation...
+CPPUNIT_ASSERT_EQUAL(aRectRot.GetWidth(), aRect.GetHeight());
+CPPUNIT_ASSERT_EQUAL(aRectRot.GetHeight(), aRect.GetWidth());
+}
+
CPPUNIT_TEST_FIXTURE(VclTextTest, testTextLayoutCache)
{
OUString sTestString = u"The quick brown fox\n
[Libreoffice-bugs] [Bug 158269] Writer's PNG export produces corrupt file
https://bugs.documentfoundation.org/show_bug.cgi?id=158269 --- Comment #4 from linus.sturm.git...@hotmail.com --- @m.a.riosv Interesting... Either the problem only affects my version, or there's a problem with my machine... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/text/textlayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2195d87e62dae3465554be5a20a45b0a377845d2 Author: Chris Sherlock AuthorDate: Tue Oct 17 18:54:26 2023 +1100 Commit: Tomaž Vajngerl CommitDate: Sun Nov 19 02:23:09 2023 +0100 vcl: simplify warning message Change-Id: Ie8ccf8bc5ba493987bebf38d8b1227c30bcd6e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158077 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/source/text/textlayout.cxx b/vcl/source/text/textlayout.cxx index a9e219099191..33232b6f0999 100644 --- a/vcl/source/text/textlayout.cxx +++ b/vcl/source/text/textlayout.cxx @@ -254,7 +254,7 @@ namespace vcl css::i18n::Boundary aBoundary = xBI->getWordBoundary( rStr, nBreakPos, rDefLocale, css::i18n::WordType::DICTIONARY_WORD, true ); sal_Int32 nWordStart = nPos; sal_Int32 nWordEnd = aBoundary.endPos; -SAL_WARN_IF( nWordEnd <= nWordStart, "vcl", "ImpBreakLine: Start >= End?" ); +SAL_WARN_IF(nWordEnd <= nWordStart, "vcl", "Start >= End?"); sal_Int32 nWordLen = nWordEnd - nWordStart; if ( ( nWordEnd < nSoftBreak ) || ( nWordLen <= 3 ) )
[Libreoffice-commits] core.git: vcl/source
vcl/source/text/textlayout.cxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 72eaff7b6af01f3b6d9754660ce231e74d501466
Author: Chris Sherlock
AuthorDate: Tue Oct 17 18:39:01 2023 +1100
Commit: Tomaž Vajngerl
CommitDate: Sun Nov 19 02:21:38 2023 +0100
vcl: ImplIsCharIn() -> lcl_IsCharIn()
Change-Id: I61b24783e39e9f904c48c0726024cd5fa122b724
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158076
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/text/textlayout.cxx b/vcl/source/text/textlayout.cxx
index dd05d57f77c3..a9e219099191 100644
--- a/vcl/source/text/textlayout.cxx
+++ b/vcl/source/text/textlayout.cxx
@@ -30,7 +30,7 @@
#include
#include
-static bool ImplIsCharIn(sal_Unicode c, const char* pStr)
+static bool lcl_IsCharIn(sal_Unicode c, const char* pStr)
{
while ( *pStr )
{
@@ -124,11 +124,11 @@ namespace vcl
{
nLastContent--;
-if (ImplIsCharIn(aStr[nLastContent], pSepChars))
+if (lcl_IsCharIn(aStr[nLastContent], pSepChars))
break;
}
-while (nLastContent && ImplIsCharIn(aStr[nLastContent-1], pSepChars))
+while (nLastContent && lcl_IsCharIn(aStr[nLastContent-1], pSepChars))
{
nLastContent--;
}
@@ -143,11 +143,11 @@ namespace vcl
while (nFirstContent < nLastContent)
{
nFirstContent++;
-if (ImplIsCharIn(aStr[nFirstContent], pSepChars))
+if (lcl_IsCharIn(aStr[nFirstContent], pSepChars))
break;
}
-while ((nFirstContent < nLastContent) &&
ImplIsCharIn(aStr[nFirstContent], pSepChars))
+while ((nFirstContent < nLastContent) &&
lcl_IsCharIn(aStr[nFirstContent], pSepChars))
{
nFirstContent++;
}
@@ -174,12 +174,12 @@ namespace vcl
while (nFirstContent < nLastContent)
{
nLastContent--;
-if (ImplIsCharIn(aStr[nLastContent], pSepChars))
+if (lcl_IsCharIn(aStr[nLastContent], pSepChars))
break;
}
-while ((nFirstContent < nLastContent) &&
ImplIsCharIn(aStr[nLastContent-1], pSepChars))
+while ((nFirstContent < nLastContent) &&
lcl_IsCharIn(aStr[nLastContent-1], pSepChars))
{
nLastContent--;
}
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0 target:7.0.0 |target:6.5.0 target:7.0.0 |target:7.1.0 target:7.2.0 |target:7.1.0 target:7.2.0 |target:7.3.0|target:7.3.0 target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/textlayout.hxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit c0aacb30b73405f6d0213fcb85b53b6d0f0854d7 Author: Chris Sherlock AuthorDate: Tue Oct 17 18:36:36 2023 +1100 Commit: Tomaž Vajngerl CommitDate: Sun Nov 19 02:19:59 2023 +0100 tdf#124176 vcl: Use pragma once instead of include guards in inc/textlayout.hxx Change-Id: Ie51fbc687002a6139dc98309cb7e1c39bb4de4a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158075 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/inc/textlayout.hxx b/vcl/inc/textlayout.hxx index b5402cc63177..53462d0cc1a2 100644 --- a/vcl/inc/textlayout.hxx +++ b/vcl/inc/textlayout.hxx @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_INC_TEXTLAYOUT_HXX -#define INCLUDED_VCL_INC_TEXTLAYOUT_HXX +#pragma once #include #include @@ -141,6 +140,4 @@ namespace vcl } // namespace vcl -#endif // INCLUDED_VCL_INC_TEXTLAYOUT_HXX - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: vcl/source
vcl/source/text/textlayout.cxx |6 --
1 file changed, 6 deletions(-)
New commits:
commit 696644462e1f3e43608319068db2bbc167e7b8f8
Author: Chris Sherlock
AuthorDate: Tue Oct 17 18:34:46 2023 +1100
Commit: Tomaž Vajngerl
CommitDate: Sun Nov 19 02:19:35 2023 +0100
vcl: remove unnecessary includes from textlayout.cxx
Change-Id: I4cef4b61c15cde5682b65590bebdc9981d38908c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158074
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/text/textlayout.cxx b/vcl/source/text/textlayout.cxx
index 3b084a03115f..dd05d57f77c3 100644
--- a/vcl/source/text/textlayout.cxx
+++ b/vcl/source/text/textlayout.cxx
@@ -20,22 +20,16 @@
#include
#include
#include
-#include
#include
#include
#include
-#include
-#include
#include
#include
#include
#include
-#include
-#include
-
static bool ImplIsCharIn(sal_Unicode c, const char* pStr)
{
while ( *pStr )
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sc/source
sc/source/ui/inc/viewfunc.hxx |3 -
sc/source/ui/undo/undoblk3.cxx |3 -
sc/source/ui/view/cellsh3.cxx |8 ---
sc/source/ui/view/viewfun2.cxx | 96 +++--
4 files changed, 60 insertions(+), 50 deletions(-)
New commits:
commit 5c77b34a2004a2f6e7cab7a81b111ba22c2b96ba
Author: Michael Meeks
AuthorDate: Thu Nov 16 19:28:21 2023 +
Commit: Tomaž Vajngerl
CommitDate: Sun Nov 19 02:18:27 2023 +0100
lok: async calc merge-cells popup dialog.
Change-Id: I6f7d1e8de4ac36f546706f7702157cc7e49c80b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159520
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/source/ui/inc/viewfunc.hxx b/sc/source/ui/inc/viewfunc.hxx
index 0d8d7515441a..a62406020de5 100644
--- a/sc/source/ui/inc/viewfunc.hxx
+++ b/sc/source/ui/inc/viewfunc.hxx
@@ -236,7 +236,8 @@ public:
boolTestMergeCells();
boolTestRemoveMerge();
-boolMergeCells( bool bApi, bool& rDoContents, bool bCenter );
+voidMergeCells( bool bApi, bool bDoContents, bool bCenter,
+const sal_uInt16 nSlot );
boolRemoveMerge();
SC_DLLPUBLIC void
diff --git a/sc/source/ui/undo/undoblk3.cxx b/sc/source/ui/undo/undoblk3.cxx
index f614e0ff0b4a..43363fd6722c 100644
--- a/sc/source/ui/undo/undoblk3.cxx
+++ b/sc/source/ui/undo/undoblk3.cxx
@@ -755,8 +755,7 @@ void ScUndoMerge::Repeat(SfxRepeatTarget& rTarget)
if (auto pViewTarget = dynamic_cast( ))
{
ScTabViewShell& rViewShell = *pViewTarget->GetViewShell();
-bool bCont = false;
-rViewShell.MergeCells( false, bCont, false );
+rViewShell.MergeCells( false, false, false, 0 );
}
}
diff --git a/sc/source/ui/view/cellsh3.cxx b/sc/source/ui/view/cellsh3.cxx
index 72c7d94ff625..dab2ee7b6a3f 100644
--- a/sc/source/ui/view/cellsh3.cxx
+++ b/sc/source/ui/view/cellsh3.cxx
@@ -944,13 +944,7 @@ void ScCellShell::Execute( SfxRequest& rReq )
bMoveContents = static_cast(pItem)->GetValue();
}
-if (pTabViewShell->MergeCells( bApi, bMoveContents,
bCenter ))
-{
-if (!bApi && bMoveContents) // "yes"
clicked in dialog
-rReq.AppendItem( SfxBoolItem( nSlot, bMoveContents
) );
-rBindings.Invalidate( nSlot );
-rReq.Done();
-}
+pTabViewShell->MergeCells( bApi, bMoveContents, bCenter,
nSlot );
}
else
{
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index 884722204f0a..45aeb2a3cdce 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -20,6 +20,7 @@
#include
#include
+#include
#include
#include
#include
@@ -1178,7 +1179,8 @@ bool ScViewFunc::TestMergeCells() // pre-test
(for menu)
return false;
}
-bool ScViewFunc::MergeCells( bool bApi, bool& rDoContents, bool bCenter )
+void ScViewFunc::MergeCells( bool bApi, bool bDoContents, bool bCenter,
+ const sal_uInt16 nSlot )
{
// Editable- and Being-Nested- test must be at the beginning (in DocFunc
too),
// so that the Contents-QueryBox won't appear
@@ -1186,7 +1188,7 @@ bool ScViewFunc::MergeCells( bool bApi, bool&
rDoContents, bool bCenter )
if (!aTester.IsEditable())
{
ErrorMessage(aTester.GetMessageId());
-return false;
+return;
}
ScMarkData& rMark = GetViewData().GetMarkData();
@@ -1194,7 +1196,7 @@ bool ScViewFunc::MergeCells( bool bApi, bool&
rDoContents, bool bCenter )
if (!rMark.IsMarked())
{
ErrorMessage(STR_NOMULTISELECT);
-return false;
+return;
}
ScDocShell* pDocSh = GetViewData().GetDocShell();
@@ -1210,14 +1212,14 @@ bool ScViewFunc::MergeCells( bool bApi, bool&
rDoContents, bool bCenter )
if ( nStartCol == nEndCol && nStartRow == nEndRow )
{
// nothing to do
-return true;
+return;
}
if ( rDoc.HasAttrib( nStartCol, nStartRow, nStartTab, nEndCol, nEndRow,
nEndTab,
HasAttrFlags::Merged | HasAttrFlags::Overlapped ) )
{ // "Don't nest merging !"
ErrorMessage(STR_MSSG_MERGECELLS_0);
-return false;
+return;
}
// Check for the contents of all selected tables.
@@ -1240,7 +1242,7 @@ bool ScViewFunc::MergeCells( bool bApi, bool&
rDoContents, bool bCenter )
{
// this range contains only one data cell.
if (nStartCol != aState.mnCol1 || nStartRow != aState.mnRow1)
-rDoContents = true; // move the value to the top-left.
+bDoContents = true; // move the
[Libreoffice-bugs] [Bug 157392] Cannot input full-width commas and periods
https://bugs.documentfoundation.org/show_bug.cgi?id=157392 stevewan...@163.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from stevewan...@163.com --- I can't provide the document because it happens randomly while typing these passages and it won't happen after closing LibreOffice and opening the document again. I've used both FCITX4 and FCITX5 and both ran into this issue (not always) and I never used any other input method. It seems that LibreOffice performs the last action that can be performed with the menu bar. The last time this issue occurred, the last action was "Find", so the "Find" window popped out instead. (In reply to Dieter from comment #1) > Thank you for reporting the bug. Could you perhaps provide a test document > with "a ong passage in Chinese"? Can you specify the "input method"? > => NEEDINFO (In reply to Dieter from comment #1) > Thank you for reporting the bug. Could you perhaps provide a test document > with "a ong passage in Chinese"? Can you specify the "input method"? > => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158269] Writer's PNG export produces corrupt file
https://bugs.documentfoundation.org/show_bug.cgi?id=158269 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- Created attachment 190907 --> https://bugs.documentfoundation.org/attachment.cgi?id=190907=edit PNG generated from your sample Looks fine for me: Version: 7.6.3.1 (X86_64) / LibreOffice Community Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)
https://bugs.documentfoundation.org/show_bug.cgi?id=143148 --- Comment #107 from Commit Notification --- Cristina Mustatea committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5682e1d4145c26fc8021879df0543d5aeacf9c83 tdf#143148 Use pragma once instead of include guards It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/unx/desktops.hxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 5682e1d4145c26fc8021879df0543d5aeacf9c83 Author: Cristina Mustatea AuthorDate: Thu Sep 21 17:40:52 2023 +0300 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Sun Nov 19 01:54:09 2023 +0100 tdf#143148 Use pragma once instead of include guards Change-Id: I5da0bf7d780f5336ecfd17882e5bfd1ac7fb4a3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157156 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/vcl/inc/unx/desktops.hxx b/vcl/inc/unx/desktops.hxx index 2056c2c37928..b40004230f91 100644 --- a/vcl/inc/unx/desktops.hxx +++ b/vcl/inc/unx/desktops.hxx @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_INC_UNX_DESKTOPS_HXX -#define INCLUDED_VCL_INC_UNX_DESKTOPS_HXX +#pragma once #include @@ -37,6 +36,4 @@ enum SAL_DLLPUBLIC_RTTI DesktopType DESKTOP_LXQT }; // keep in sync with desktop_strings[] in salplug.cxx -#endif // INCLUDED_VCL_INC_UNX_DESKTOPS_HXX - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-bugs] [Bug 158258] Rank Function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=158258 ady changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO|RESOLVED --- Comment #7 from ady --- To simplify the problem... You are searching the RANK() of the numeric value 647 within the data: 682 657 654 645 636 632 612 559 533 500 from higher to lower values. Until LO 7.5.3, the result would be indeed 4, which is incorrect; the value 647 is not really included in the data. That's incorrect according to the ODFF definition of RANK(), so the function was corrected for LO 7.5.3. I would suggest searching for an alternative way (i.e. modified formula) that would correctly calculate the result you want. Or perhaps the corrected RANK() result is what you actually need? Maybe someone at the users mailing list or at https://ask.libreoffice.org might be able to help with that. Either way, this report is Not A Bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158254] Can not apply any cell styles right of used area
https://bugs.documentfoundation.org/show_bug.cgi?id=158254 ady changed: What|Removed |Added Ever confirmed|1 |0 Status|REOPENED|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input
https://bugs.documentfoundation.org/show_bug.cgi?id=158112 --- Comment #6 from ady --- (In reply to V Stuart Foote from comment #5) > are we really obliged to > support MS ASCII/OEM "AltCode" [2] handling? Please be aware that users that need to insert characters that are not included in their keyboard layout might be using these type of shortcuts. One typical scenario is users inserting characters of other/multiple languages (such as accented letters/vowels while using a US keyboard). When such needs are sporadic, other methods of inserting foreign characters are available. OTOH, when such needs are (very) frequent, users might even remember/memorize such keyboard shortcuts. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input
https://bugs.documentfoundation.org/show_bug.cgi?id=158112 --- Comment #6 from ady --- (In reply to V Stuart Foote from comment #5) > are we really obliged to > support MS ASCII/OEM "AltCode" [2] handling? Please be aware that users that need to insert characters that are not included in their keyboard layout might be using these type of shortcuts. One typical scenario is users inserting characters of other/multiple languages (such as accented letters/vowels while using a US keyboard). When such needs are sporadic, other methods of inserting foreign characters are available. OTOH, when such needs are (very) frequent, users might even remember/memorize such keyboard shortcuts. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158258] Rank Function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=158258 --- Comment #6 from GyleMc --- Don't see the note so I'll try again: The formula in question is on page "24 SREC" Cell G20 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158258] Rank Function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=158258 --- Comment #5 from GyleMc --- Created attachment 190906 --> https://bugs.documentfoundation.org/attachment.cgi?id=190906=edit Worksheet in question The formula is on page "24 SREC" cell g20 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158269] Writer's PNG export produces corrupt file
https://bugs.documentfoundation.org/show_bug.cgi?id=158269 --- Comment #2 from linus.sturm.git...@hotmail.com --- Created attachment 190905 --> https://bugs.documentfoundation.org/attachment.cgi?id=190905=edit ZIP with the suspectedly corrupt image (see comment) ZIP file of the suspectedly corrupt PNG file, as I couldn't attach it directly. I suspect the PNG file is actually empty (as Bugzilla told me the file is "either ... or empty"). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158258] Rank Function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=158258 --- Comment #4 from GyleMc --- (In reply to ady from comment #1) > The RANK() function was indeed corrected for LO 7.5.3. > > Please use the "Add an attachment" link to add a sample file. Please be > aware that it will be publicly available, so you might want to read > > https://wiki.documentfoundation.org/QA/Bugzilla/ > Sanitizing_Files_Before_Submission > > before attaching it. I will attach the file. The formula in question was cleaned up (simplified) thanks to Werner Tietz, but still does not work in the newer version. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158269] Writer's PNG export produces corrupt file
https://bugs.documentfoundation.org/show_bug.cgi?id=158269 --- Comment #1 from linus.sturm.git...@hotmail.com --- Created attachment 190904 --> https://bugs.documentfoundation.org/attachment.cgi?id=190904=edit Document I have tried this with This is the document I've tried it with (but I've had the issue before). Btw, JPEG export works without a problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158269] New: Writer's PNG export produces corrupt file
https://bugs.documentfoundation.org/show_bug.cgi?id=158269 Bug ID: 158269 Summary: Writer's PNG export produces corrupt file Product: LibreOffice Version: 7.5.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: linus.sturm.git...@hotmail.com Description: When exporting a document from Writer to PNG, it creates a corrupt file. Steps to Reproduce: 1. Create a document and type some text 2. Hit File->Export... 3. Choose PNG as file type and hit 'Save' 4. Hit 'Export' Actual Results: The created image cannot be opened with either Windows Photos or IrfanView, both show an error message hinting to a corrupt file. Expected Results: Exporting creates a PNG file that can be opened and used. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158267] Freeze/hang if I open the Options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=158267 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Please can you paste the information in Menu/Help/About LibreOffice, there is an icon to copy. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153969] Text hidden when importing PDF document with RTL text and using he-IL locale
https://bugs.documentfoundation.org/show_bug.cgi?id=153969 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7589 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157589] PDF: Conversion pdf to docx, collapsing to one page
https://bugs.documentfoundation.org/show_bug.cgi?id=157589 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||stephane.guillou@libreoffic ||e.org, suokunl...@126.com Component|Writer |filters and storage See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3969 Version|7.5.0.3 release |7.4.4.2 release --- Comment #5 from Stéphane Guillou (stragu) --- The resulting DOCX is impossibly slow to open in LO and hangs for me. But even opening the original PDF with Writer's PDF filter results in LO hanging (document displayed but impossible to work on it). Tested recent trunk build and 6.0.0.3. In any case, even with the long loading times in both LO and MSO, I can see the collapsed contents in MSO, which I bibisected with linux-64-7.4 to first bad build commit [b77a5408177cf0db37ca5aa3d9cf106c0157ab9b] which points to core commit 588e59cc36475ded243ce4fd9062473cddd2c016 which is a cherrypick of: commit fc2fb95fdb4262792e94afe61b784c8ae71d171e author Kevin Suo Sun Oct 23 19:10:29 2022 +0800 committer Kevin Suo Sun Oct 23 20:10:18 2022 +0800 sdext.pdfimport Writer: Do not visit DrawElement twice in WriterXmlEmitter https://gerrit.libreoffice.org/c/core/+/142313 Kevin, can you please have a look? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158268] General input/output error on LO draw with .cdr file (CorelDraw file) FILEOPEN
https://bugs.documentfoundation.org/show_bug.cgi?id=158268 --- Comment #1 from k...@klvdorner.de --- Created attachment 190903 --> https://bugs.documentfoundation.org/attachment.cgi?id=190903=edit Affected cdr file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158268] New: General input/output error on LO draw with .cdr file (CorelDraw file) FILEOPEN
https://bugs.documentfoundation.org/show_bug.cgi?id=158268 Bug ID: 158268 Summary: General input/output error on LO draw with .cdr file (CorelDraw file) FILEOPEN Product: LibreOffice Version: 7.6.2.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: k...@klvdorner.de Description: When opening the file, the error window comes up. Please see the attached file. (I tested on windows and linux) Steps to Reproduce: 1. Open the .cdr file 2. The draw window comes up 3. The I/O error is displayed Actual Results: File cannot be opened/imported Expected Results: File can be opened/imported Reproducible: Always User Profile Reset: No Additional Info: Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 60(Build:1) CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US 7.6.2-3 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d940c06078c6db581daa411a38ce264578b6aad1 Author: Stanislav Horacek AuthorDate: Sat Nov 18 22:09:58 2023 +0100 Commit: Gerrit Code Review CommitDate: Sat Nov 18 22:09:58 2023 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 579bf8dd91ebc66108f8710452ea2280c81c1223 - use "export" instead of "print" at PDF export options page Change-Id: I1c1bfcfab57b74129c5bb60fad89376c88e64dfd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159638 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 7137f1de0c22..579bf8dd91eb 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 7137f1de0c227bb33997436ec5e64bea05d1b6b5 +Subproject commit 579bf8dd91ebc66108f8710452ea2280c81c1223
[Libreoffice-commits] help.git: source/text
source/text/shared/guide/pdf_params.xhp |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 579bf8dd91ebc66108f8710452ea2280c81c1223 Author: Stanislav Horacek AuthorDate: Sat Nov 18 20:54:15 2023 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Sat Nov 18 22:09:57 2023 +0100 use "export" instead of "print" at PDF export options page Change-Id: I1c1bfcfab57b74129c5bb60fad89376c88e64dfd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159638 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/shared/guide/pdf_params.xhp b/source/text/shared/guide/pdf_params.xhp index 0dd3c5b071..54819807b0 100644 --- a/source/text/shared/guide/pdf_params.xhp +++ b/source/text/shared/guide/pdf_params.xhp @@ -70,15 +70,15 @@ PageRange - If this property is set, it indicates the range of pages to be printed. -To print all the pages, leave this property unset. + If this property is set, it indicates the range of pages to be exported. +To export all the pages, leave this property unset. To export a selection, leave this property unset and set only the property Selection. string -Empty (all pages are printed) +Empty (all pages are exported)
[Libreoffice-bugs] [Bug 158258] Rank Function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=158258 --- Comment #3 from GyleMc --- Thanks, that is a much cleaner formula. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158189] Hidden page break with multiple columns and table at the page beginning
https://bugs.documentfoundation.org/show_bug.cgi?id=158189 BogdanB changed: What|Removed |Added Blocks||108519 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108519 [Bug 108519] [META] Page break bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108519] [META] Page break bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108519 BogdanB changed: What|Removed |Added Depends on||158189 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158189 [Bug 158189] Hidden page break with multiple columns and table at the page beginning -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 BogdanB changed: What|Removed |Added Depends on||158186 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158186 [Bug 158186] Mismatching config key name and property name in UI code -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158186] Mismatching config key name and property name in UI code
https://bugs.documentfoundation.org/show_bug.cgi?id=158186 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||103341 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158013] Resetting font in Options menu changes font of existing text in document
https://bugs.documentfoundation.org/show_bug.cgi?id=158013 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||102985 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102985 [Bug 102985] [META] Font bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102985 BogdanB changed: What|Removed |Added Depends on||158013 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158013 [Bug 158013] Resetting font in Options menu changes font of existing text in document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: canvas/source cppu/source
canvas/source/tools/page.cxx|5 +
canvas/source/tools/spriteredrawmanager.cxx |2 +-
cppu/source/threadpool/threadpool.cxx |2 +-
cppu/source/typelib/typelib.cxx |3 +--
4 files changed, 4 insertions(+), 8 deletions(-)
New commits:
commit d0b0908e62fd6e4901061b43deeb8ae4cf2ed799
Author: Julien Nabet
AuthorDate: Sat Nov 18 12:55:53 2023 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 18 20:27:47 2023 +0100
c++20: use std::erase instead of std::removed followed by erase (part 2)
Change-Id: I0222f0f53f387dd57bd674b1e137b53487f4e1d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159611
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/canvas/source/tools/page.cxx b/canvas/source/tools/page.cxx
index ddf516a926f6..32eedb71b29f 100644
--- a/canvas/source/tools/page.cxx
+++ b/canvas/source/tools/page.cxx
@@ -76,10 +76,7 @@ namespace canvas
// be relocated to some other page or it will
// currently be deleted. in either case, simply
// remove the reference from our internal storage.
-FragmentContainer_t::iterator it(
-std::remove(
-mpFragments.begin(),mpFragments.end(),pFragment));
-mpFragments.erase(it,mpFragments.end());
+std::erase(mpFragments, pFragment);
}
bool Page::insert( SurfaceRect& r )
diff --git a/canvas/source/tools/spriteredrawmanager.cxx
b/canvas/source/tools/spriteredrawmanager.cxx
index e67fca6cce1c..06eb6d1de594 100644
--- a/canvas/source/tools/spriteredrawmanager.cxx
+++ b/canvas/source/tools/spriteredrawmanager.cxx
@@ -455,7 +455,7 @@ namespace canvas
void SpriteRedrawManager::hideSprite( const Sprite::Reference& rSprite )
{
-maSprites.erase(std::remove(maSprites.begin(), maSprites.end(),
rSprite), maSprites.end());
+std::erase(maSprites, rSprite);
}
void SpriteRedrawManager::moveSprite( const Sprite::Reference&
rSprite,
diff --git a/cppu/source/threadpool/threadpool.cxx
b/cppu/source/threadpool/threadpool.cxx
index a65bdcfaf625..a74d8678d986 100644
--- a/cppu/source/threadpool/threadpool.cxx
+++ b/cppu/source/threadpool/threadpool.cxx
@@ -62,7 +62,7 @@ namespace cppu_threadpool
void DisposedCallerAdmin::destroy( void const * nDisposeId )
{
std::scoped_lock guard( m_mutex );
-m_vector.erase(std::remove(m_vector.begin(), m_vector.end(),
nDisposeId), m_vector.end());
+std::erase(m_vector, nDisposeId);
}
bool DisposedCallerAdmin::isDisposed( void const * nDisposeId )
diff --git a/cppu/source/typelib/typelib.cxx b/cppu/source/typelib/typelib.cxx
index e2e87b03ff10..e665b2b4273e 100644
--- a/cppu/source/typelib/typelib.cxx
+++ b/cppu/source/typelib/typelib.cxx
@@ -293,8 +293,7 @@ extern "C" void SAL_CALL
typelib_typedescription_revokeCallback(
// todo mt safe: guard is no solution, can not acquire while calling
callback!
// OslGuard aGuard( rInit.getMutex() );
CallbackEntry aEntry( pContext, pCallback );
-rInit.maCallbacks.erase(std::remove(rInit.maCallbacks.begin(),
rInit.maCallbacks.end(), aEntry),
-rInit.maCallbacks.end());
+std::erase(rInit.maCallbacks, aEntry);
}
}
[Libreoffice-bugs] [Bug 145450] Update function sometimes returns % as Message
https://bugs.documentfoundation.org/show_bug.cgi?id=145450 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Whiteboard| QA:needsComment| --- Comment #1 from BogdanB --- Don't repro with Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Could someone with Windows to test this? Maybe just a Windows problem? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157885] help png images could use indexed colours
https://bugs.documentfoundation.org/show_bug.cgi?id=157885 --- Comment #8 from Jérôme --- The palette uses a minimum size inside the png file. Maybe we could use indexed colours only for non indexed png files which are larger than a given size (400 bytes ?). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - include/docmodel reportdesign/source sal/qa
include/docmodel/color/ComplexColor.hxx|8 +++-
reportdesign/source/core/sdr/UndoEnv.cxx |3 +--
reportdesign/source/ui/report/ReportControllerObserver.cxx |3 +--
sal/qa/osl/process/osl_process.cxx | 12
4 files changed, 9 insertions(+), 17 deletions(-)
New commits:
commit e08efe99cdb8d2159b2714d0f23e62678348eaed
Author: Julien Nabet
AuthorDate: Sat Nov 18 15:13:57 2023 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 18 18:39:25 2023 +0100
c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 7)
Change-Id: I2a72422a6c8185d17876daac41a86137048b034c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159627
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/reportdesign/source/core/sdr/UndoEnv.cxx
b/reportdesign/source/core/sdr/UndoEnv.cxx
index b64e5451b566..bba8d5ae91f1 100644
--- a/reportdesign/source/core/sdr/UndoEnv.cxx
+++ b/reportdesign/source/core/sdr/UndoEnv.cxx
@@ -498,8 +498,7 @@ void OXUndoEnvironment::RemoveSection(const Reference<
report::XSection > & _xSe
try
{
uno::Reference xChild(_xSection);
-
m_pImpl->m_aSections.erase(::std::remove(m_pImpl->m_aSections.begin(),m_pImpl->m_aSections.end(),
-xChild), m_pImpl->m_aSections.end());
+std::erase(m_pImpl->m_aSections, xChild);
Reference< XInterface > xInt(_xSection);
RemoveElement(xInt);
}
diff --git a/reportdesign/source/ui/report/ReportControllerObserver.cxx
b/reportdesign/source/ui/report/ReportControllerObserver.cxx
index b05d3b3d1359..d693c1787116 100644
--- a/reportdesign/source/ui/report/ReportControllerObserver.cxx
+++ b/reportdesign/source/ui/report/ReportControllerObserver.cxx
@@ -166,8 +166,7 @@ void OXReportControllerObserver::RemoveSection(const
uno::Reference< report::XSe
try
{
uno::Reference xChild(_xSection);
-m_aSections.erase(::std::remove(m_aSections.begin(), m_aSections.end(),
-xChild), m_aSections.end());
+std::erase(m_aSections, xChild);
uno::Reference< uno::XInterface > xInt(_xSection);
RemoveElement(xInt);
}
diff --git a/sal/qa/osl/process/osl_process.cxx
b/sal/qa/osl/process/osl_process.cxx
index e648d2467984..cab3bffd2d17 100644
--- a/sal/qa/osl/process/osl_process.cxx
+++ b/sal/qa/osl/process/osl_process.cxx
@@ -116,13 +116,11 @@ private:
std::sort(env_container.begin(), env_container.end());
if (RUNNING_ON_VALGRIND)
{
-env_container.erase(
-std::remove_if(
-env_container.begin(), env_container.end(),
+std::erase_if(
+env_container,
[](OString const & s) {
return s.startsWith("LD_PRELOAD=")
-|| s.startsWith("VALGRIND_LIB="); }),
-env_container.end());
+|| s.startsWith("VALGRIND_LIB="); });
}
}
}
@@ -245,9 +243,7 @@ public:
//remove the environment variables that we have changed
//in the child environment from the read parent environment
-parent_env.erase(
-std::remove_if(parent_env.begin(), parent_env.end(),
exclude(different_env_vars)),
-parent_env.end());
+std::erase_if(parent_env, exclude(different_env_vars));
for (auto& env : parent_env)
std::cout << "stripped parent env: " << env << "\n";
commit 4aa5e93a802af2228e4418aceec29d2aafa9b5de
Author: Julien Nabet
AuthorDate: Sat Nov 18 13:16:31 2023 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 18 18:39:14 2023 +0100
c++20: use std::erase(_if) instead of std::remove(_if)+erase (include part)
Change-Id: I32ac73e1ada08bfaa29e654f26fc89257733cd79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159614
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/include/docmodel/color/ComplexColor.hxx
b/include/docmodel/color/ComplexColor.hxx
index b12db79411c5..01709b12f0a3 100644
--- a/include/docmodel/color/ComplexColor.hxx
+++ b/include/docmodel/color/ComplexColor.hxx
@@ -136,11 +136,9 @@ public:
void removeTransformations(TransformationType eType)
{
-maTransformations.erase(std::remove_if(maTransformations.begin(),
maTransformations.end(),
- [eType](Transformation const&
rTransform) {
- return rTransform.meType ==
eType;
- }),
-maTransformations.end());
+std::erase_if(maTransformations, [eType](Transformation const&
rTransform) {
+return rTransform.meType == eType;
+});
}
void clearTransformations() { maTransformations.clear(); }
[Libreoffice-commits] core.git: 2 commits - oox/source package/source
oox/source/drawingml/diagram/diagram.cxx|5 ++---
oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 14 ++
package/source/manifest/ManifestImport.cxx |3 +--
package/source/xstor/ohierarchyholder.cxx |5 ++---
package/source/xstor/owriteablestream.cxx |2 +-
package/source/xstor/xstorage.cxx | 11 +--
6 files changed, 17 insertions(+), 23 deletions(-)
New commits:
commit 06e469623307821e8a1c4b0a3a2aa6f3dd202da6
Author: Julien Nabet
AuthorDate: Sat Nov 18 15:09:20 2023 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 18 18:38:56 2023 +0100
c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 6)
Change-Id: Ic073d7444e968e90068aa60847bc9211167f6278
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159626
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/package/source/manifest/ManifestImport.cxx
b/package/source/manifest/ManifestImport.cxx
index 2c55bcf87fe9..195324fdbe2a 100644
--- a/package/source/manifest/ManifestImport.cxx
+++ b/package/source/manifest/ManifestImport.cxx
@@ -401,8 +401,7 @@ void SAL_CALL ManifestImport::endElement( const OUString&
aName )
aSequence[PKG_SIZE_NOENCR_MNFST].Name = "KeyInfo";
aSequence[PKG_SIZE_NOENCR_MNFST].Value <<=
comphelper::containerToSequence(aKeys);
}
-aSequence.erase(std::remove_if(aSequence.begin(), aSequence.end(),
- isEmpty), aSequence.end());
+std::erase_if(aSequence, isEmpty);
bIgnoreEncryptData = false;
rManVector.push_back ( comphelper::containerToSequence(aSequence) );
diff --git a/package/source/xstor/ohierarchyholder.cxx
b/package/source/xstor/ohierarchyholder.cxx
index eafdf4a567f4..d9b5b137434d 100644
--- a/package/source/xstor/ohierarchyholder.cxx
+++ b/package/source/xstor/ohierarchyholder.cxx
@@ -262,10 +262,9 @@ void SAL_CALL OHierarchyElement_Impl::disposing( const
lang::EventObject& Source
std::unique_lock aGuard(m_aMutex);
uno::Reference< embed::XExtendedStorageStream >
xStream(Source.Source, uno::UNO_QUERY);
-m_aOpenStreams.erase(std::remove_if(m_aOpenStreams.begin(),
m_aOpenStreams.end(),
+std::erase_if(m_aOpenStreams,
[](const OWeakStorRefVector_Impl::value_type&
rxStorage) {
-return !rxStorage.get().is() || rxStorage.get() == xStream; }),
-m_aOpenStreams.end());
+return !rxStorage.get().is() || rxStorage.get() == xStream; });
}
TestForClosing();
diff --git a/package/source/xstor/owriteablestream.cxx
b/package/source/xstor/owriteablestream.cxx
index bd58f579a326..59e5e94316a3 100644
--- a/package/source/xstor/owriteablestream.cxx
+++ b/package/source/xstor/owriteablestream.cxx
@@ -1292,7 +1292,7 @@ uno::Reference< io::XInputStream >
OWriteStream_Impl::GetRawInStream()
void OWriteStream_Impl::InputStreamDisposed( OInputCompStream* pStream )
{
::osl::MutexGuard aGuard( m_xMutex->GetMutex() );
-m_aInputStreamsVector.erase(std::remove(m_aInputStreamsVector.begin(),
m_aInputStreamsVector.end(), pStream ), m_aInputStreamsVector.end());
+std::erase(m_aInputStreamsVector, pStream);
}
void OWriteStream_Impl::CreateReadonlyCopyBasedOnData( const uno::Reference<
io::XInputStream >& xDataToCopy, const uno::Sequence< beans::PropertyValue >&
aProps, uno::Reference< io::XStream >& xTargetStream )
diff --git a/package/source/xstor/xstorage.cxx
b/package/source/xstor/xstorage.cxx
index e2c0207a1553..05150a48f988 100644
--- a/package/source/xstor/xstorage.cxx
+++ b/package/source/xstor/xstorage.cxx
@@ -1398,7 +1398,7 @@ SotElement_Impl* OStorage_Impl::InsertElement( const
OUString& aName, bool bIsSt
OpenSubStream( pDeletedElm );
auto & rVec = m_aChildrenMap[aName];
-rVec.erase(std::remove(rVec.begin(), rVec.end(), pDeletedElm),
rVec.end());
+std::erase(rVec, pDeletedElm);
if (rVec.empty())
m_aChildrenMap.erase(aName);
m_aDeletedVector.push_back( pDeletedElm );
@@ -1493,7 +1493,7 @@ void OStorage_Impl::RemoveElement( OUString const &
rName, SotElement_Impl* pEle
if ( pElement->m_bIsInserted )
{
delete pElement;
-mapIt->second.erase(std::remove(mapIt->second.begin(),
mapIt->second.end(), pElement), mapIt->second.end());
+std::erase(mapIt->second, pElement);
if (mapIt->second.empty())
m_aChildrenMap.erase(mapIt);
}
@@ -1868,11 +1868,10 @@ void OStorage::ChildIsDisposed( const uno::Reference<
uno::XInterface >& xChild
// the locking is done in the listener
auto& rVec = m_aOpenSubComponentsVector;
-rVec.erase(std::remove_if(rVec.begin(), rVec.end(),
+std::erase_if(rVec,
[](const uno::Reference& xTmp) {
[Libreoffice-commits] core.git: 2 commits - dbaccess/source desktop/source editeng/source filter/source fpicker/source framework/source
dbaccess/source/ui/browser/genericcontroller.cxx | 10 +
dbaccess/source/ui/dlg/adtabdlg.cxx |5 +-
dbaccess/source/ui/querydesign/JoinController.cxx |2 -
dbaccess/source/ui/querydesign/QueryTableView.cxx |6 +--
dbaccess/source/ui/relationdesign/RelationTableView.cxx |4 +-
desktop/source/deployment/gui/dp_gui_extlistbox.cxx |5 +-
desktop/source/deployment/registry/component/dp_component.cxx |2 -
desktop/source/lib/init.cxx | 19 --
desktop/source/lib/lokclipboard.cxx |3 -
editeng/source/editeng/editdoc.cxx|2 -
filter/source/config/cache/filterfactory.cxx |6 +--
fpicker/source/office/fileview.cxx|5 +-
framework/source/services/desktop.cxx |4 --
framework/source/services/pathsettings.cxx|5 +-
14 files changed, 30 insertions(+), 48 deletions(-)
New commits:
commit 4bbd9853afde9456c1c5bc16eca3b775e53a01fe
Author: Julien Nabet
AuthorDate: Sat Nov 18 13:15:01 2023 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 18 18:38:36 2023 +0100
c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 4)
Change-Id: I6af5501e3fde07024dcc74f00c8fd69bd369d8d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159613
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index 9841d7854c32..7a5d70b34567 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -3009,7 +3009,7 @@ public:
void CharAttribList::DeleteEmptyAttribs( SfxItemPool& rItemPool )
{
std::for_each(aAttribs.begin(), aAttribs.end(),
RemoveEmptyAttrItem(rItemPool));
-aAttribs.erase( std::remove_if(aAttribs.begin(), aAttribs.end(), [](const
std::unique_ptr& aAttrib) { return aAttrib->IsEmpty(); } ),
aAttribs.end() );
+std::erase_if(aAttribs, [](const std::unique_ptr& aAttrib)
{ return aAttrib->IsEmpty(); } );
bHasEmptyAttribs = false;
}
diff --git a/filter/source/config/cache/filterfactory.cxx
b/filter/source/config/cache/filterfactory.cxx
index 481dac67a7c3..1c6fadca6c86 100644
--- a/filter/source/config/cache/filterfactory.cxx
+++ b/filter/source/config/cache/filterfactory.cxx
@@ -443,13 +443,11 @@ std::vector
FilterFactory::impl_getSortedFilterListForModule(const OUS
// remove all filters from this merged list, which does not fit the flag
specification
if (nIFlags != -1)
{
-auto pItToErase = ::std::remove_if(lMergedFilters.begin(),
lMergedFilters.end(), stlcomp_removeIfMatchFlags(pCache, nIFlags, true));
-lMergedFilters.erase(pItToErase, lMergedFilters.end());
+std::erase_if(lMergedFilters, stlcomp_removeIfMatchFlags(pCache,
nIFlags, true));
}
if (nEFlags != -1)
{
-auto pItToErase = ::std::remove_if(lMergedFilters.begin(),
lMergedFilters.end(), stlcomp_removeIfMatchFlags(pCache, nEFlags, false));
-lMergedFilters.erase(pItToErase, lMergedFilters.end());
+std::erase_if(lMergedFilters, stlcomp_removeIfMatchFlags(pCache,
nEFlags, false));
}
// sort the default filter to the front of this list
diff --git a/fpicker/source/office/fileview.cxx
b/fpicker/source/office/fileview.cxx
index ebc3ee3b8b18..1fa1c4dafcd3 100644
--- a/fpicker/source/office/fileview.cxx
+++ b/fpicker/source/office/fileview.cxx
@@ -1304,7 +1304,7 @@ void SvtFileView_Impl::FilterFolderContent_Impl(
std::u16string_view rFilter )
// do the filtering
-maContent.erase(std::remove_if(maContent.begin(), maContent.end(),
+std::erase_if(maContent,
[](const std::unique_ptr& rxContent) {
if (rxContent->mbIsFolder)
return false;
@@ -1312,8 +1312,7 @@ void SvtFileView_Impl::FilterFolderContent_Impl(
std::u16string_view rFilter )
// 91872 - 11.09.2001 - frank.schoenh...@sun.com
OUString sCompareString = rxContent->GetFileName(); // filter
works on file name, not on title!
return std::none_of(aFilters.begin(), aFilters.end(),
FilterMatch(sCompareString));
-}),
-maContent.end());
+});
}
IMPL_LINK_NOARG(SvtFileView_Impl, ChangedHdl, weld::TreeView&, void)
diff --git a/framework/source/services/desktop.cxx
b/framework/source/services/desktop.cxx
index 35dfcd2e21eb..237d35afc6a5 100644
--- a/framework/source/services/desktop.cxx
+++ b/framework/source/services/desktop.cxx
@@ -443,9 +443,7 @@ void SAL_CALL Desktop::removeTerminateListener( const
css::uno::Reference< css::
}
else if (sImplementationName ==
"com.sun.star.comp.ComponentDLLListener")
{
-m_xComponentDllListeners.erase(
-
[Libreoffice-commits] core.git: basctl/source basic/source binaryurp/source
basctl/source/dlged/dlgedobj.cxx |2 +-
basic/source/classes/sb.cxx|2 +-
binaryurp/source/bridgefactory.cxx |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit c05595d2420b92a428b45cfaf65a3adf88fd8bed
Author: Julien Nabet
AuthorDate: Sat Nov 18 12:41:05 2023 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 18 18:38:01 2023 +0100
c++20: use std::erase instead of std::removed followed by erase (part 1)
Change-Id: I8d038fc37a4de25bdeff2e2cc55775e3981240b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159610
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/basctl/source/dlged/dlgedobj.cxx b/basctl/source/dlged/dlgedobj.cxx
index a3c2b396f791..5b87393e51bc 100644
--- a/basctl/source/dlged/dlgedobj.cxx
+++ b/basctl/source/dlged/dlgedobj.cxx
@@ -1288,7 +1288,7 @@ void DlgEdForm::AddChild( DlgEdObj* pDlgEdObj )
void DlgEdForm::RemoveChild( DlgEdObj* pDlgEdObj )
{
-pChildren.erase( std::remove( pChildren.begin() , pChildren.end() ,
pDlgEdObj ) );
+std::erase(pChildren, pDlgEdObj);
}
void DlgEdForm::PositionAndSizeChange( const beans::PropertyChangeEvent& evt )
diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx
index eeef54222647..8187e6126651 100644
--- a/basic/source/classes/sb.cxx
+++ b/basic/source/classes/sb.cxx
@@ -1074,7 +1074,7 @@ void StarBASIC::Remove( SbxVariable* pVar )
{
// #87540 Can be last reference!
SbModuleRef xVar = pModule;
-pModules.erase(std::remove(pModules.begin(), pModules.end(), xVar));
+std::erase(pModules, xVar);
pVar->SetParent( nullptr );
EndListening( pVar->GetBroadcaster() );
}
diff --git a/binaryurp/source/bridgefactory.cxx
b/binaryurp/source/bridgefactory.cxx
index 835c264a9d92..cd43fe592b0e 100644
--- a/binaryurp/source/bridgefactory.cxx
+++ b/binaryurp/source/bridgefactory.cxx
@@ -49,7 +49,7 @@ void BridgeFactory::removeBridge(
osl::MutexGuard g(m_aMutex);
if (n.isEmpty())
{
-unnamed_.erase(std::remove(unnamed_.begin(), unnamed_.end(), bridge),
unnamed_.end());
+std::erase(unnamed_, bridge);
}
else
{
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/dbdata.cxx |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
New commits:
commit 79d9195b954f7a815ddae9562c59fce4dd7c4351
Author: Julien Nabet
AuthorDate: Sat Nov 18 15:18:49 2023 +0100
Commit: Julien Nabet
CommitDate: Sat Nov 18 18:37:46 2023 +0100
Remove useless using + once use of replace pair by std::pair
Change-Id: Id283ac7909f19dabb98886caa1f2960d9098ddbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159628
Reviewed-by: Julien Nabet
Tested-by: Jenkins
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx
index 4b24110658c3..69e28ca62876 100644
--- a/sc/source/core/tool/dbdata.cxx
+++ b/sc/source/core/tool/dbdata.cxx
@@ -42,12 +42,6 @@
#include
#include
-using ::std::unique_ptr;
-using ::std::for_each;
-using ::std::find_if;
-using ::std::remove_if;
-using ::std::pair;
-
bool ScDBData::less::operator() (const std::unique_ptr& left, const
std::unique_ptr& right) const
{
return ScGlobal::GetTransliteration().compareString(left->GetUpperName(),
right->GetUpperName()) < 0;
@@ -1260,7 +1254,7 @@ bool
ScDBCollection::NamedDBs::insert(std::unique_ptr pData)
if (!pData->GetIndex())
pData->SetIndex(mrParent.nEntryIndex++);
-pair r = m_DBs.insert(std::move(pData));
+std::pair r = m_DBs.insert(std::move(pData));
if (r.second)
{
[Libreoffice-bugs] [Bug 157885] help png images could use indexed colours
https://bugs.documentfoundation.org/show_bug.cgi?id=157885
--- Comment #7 from Jérôme ---
Created attachment 190902
--> https://bugs.documentfoundation.org/attachment.cgi?id=190902=edit
coulours indexed on 8 bits saves ~562kB in help from main MSI package
>From the LibreOffice_7.6.2_Win_x86-64.msi archive file, I converted all png
files in "help" folder with ImageMagik with this command :
find . -type f -iname '*.png' -exec convert "{}" -type Palette -define
png:format=png8 -define png:compression-level=9 "{}8" \;
The attachment compares the orignal png files with the new indexed png on 8 bit
with 24 bit colours.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158264] Cannot delete formulas from Writer table
https://bugs.documentfoundation.org/show_bug.cgi?id=158264
nutka changed:
What|Removed |Added
CC||czeslaw.wolan...@gmail.com
--- Comment #2 from nutka ---
@freew...@poczta.fm :
Could you please take a look at Bug 72100?
("EDITING: Deleting contents of cells with formulas in TABLE gives 0 in some
cells, and doesn't change other cells in multiple selection").
Comment No. 1 therein provides a possible workaround.
It seems your report could be classified as as duplicate of Bug 72100.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158267] New: Freeze/hang if I open the Options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=158267 Bug ID: 158267 Summary: Freeze/hang if I open the Options dialog Product: LibreOffice Version: 7.5.7.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: unun...@yandex.com Description: LibreOffice freezes or hangs when I try to access the options (I think they're called that in English, but for the sake of searchability I'll mention Settings and Preferences too). Other dialogs are work fine. Steps to Reproduce: 1. Open any LO Application 2. Click Tools->Options or hit Alt+12 Actual Results: LibreOffice is unresponsive and after a while my OS opens a dialog that tells me that it has detected that as well, giving me the option to wait or force quit the program. Even after 5 minutes it doesn't go back to normal. Expected Results: It should open the options/settings/preferences dialog. Reproducible: Always User Profile Reset: Yes Additional Info: OS: Fedora 38 Kernel: 6.2.14-200 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153131] Copy causes Calc to Freeze on Windows 11 with Speech Recognition
https://bugs.documentfoundation.org/show_bug.cgi?id=153131 --- Comment #66 from ericbressle...@gmail.com --- (In reply to Barry L. Kramer from comment #64) > That is a strange automated change of the status of this issue. > > That aside, did anyone who worked on this reproduce my observation that the > problem did not occur if Calc was launched from the command line? For me, > it only happened when run from the windows shortcut. Maybe this is just > something simple like the command line invoke didn't run the Speech feature > at all, but I did want to mention it because e.g. if that feature were still > launched but it got started up in a different way such that > CMAccessible::get_accChildCount doesn't return 2147483648 but rather > something meaningful, maybe that could lead somewhere. > > I will test it again but need to restart... LO won't launch at all Your command line workaround worked well for me. Of course now that the program is working properly after toggling on and off the speech recognition, I'm no longer using the workaround. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158266] New: Writer: problem opening a .docx file (normal text, no video or audio involved)
https://bugs.documentfoundation.org/show_bug.cgi?id=158266 Bug ID: 158266 Summary: Writer: problem opening a .docx file (normal text, no video or audio involved) Product: LibreOffice Version: 7.6.3.1 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robd...@gmail.com Just installed your latest Libre Office. Trying to open a .docx file in Writer, I get this message from Windows 10: "The lock file could not be created for exclusive access by LibreOffice, due to missing permission to create a lock file on that file location or lack of free disk space. Select Notify to open read-only and get notified when the document becomes editable." Also I get a notice from Windows: "App or process blocked: soffice.bin Protected folder: %userprofile%\Documents I am running a 64 bit processor, in guest mode, not administrator mode, Windows 10, and no problem with hard disk space. I did not have this problem with previous versions of Writer. How do I fix this? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158265] New: Cell Format Date changes cell value in case of high resolution date/time values
https://bugs.documentfoundation.org/show_bug.cgi?id=158265 Bug ID: 158265 Summary: Cell Format Date changes cell value in case of high resolution date/time values Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zipj...@gmail.com Steps to reproduce: 1. Open a calc document 2. Enter an OLE time value with a resolution > 10 ms like 45000.473994479200 3. Format Cell.., select Category Date, set Format Code to '-MM-DD HH:MM:SS.000'. The date will be shown as '2023-03-15 11:22:33.123' 4. close and save the document 5. reopen the document 6. The time value has changed to '2023-03-15 11:22:33.120' = 45000.47399400 Expected behaviour: Selecting a Date format should not change the value of the cell Root Cause: In case of cell format category Date the value is stored with a resoution of 10 ms only. Compare 'office:date-value="2023-03-15T11:22:33.12"' and '2023-03-15 11:22:33.123' Extract of content.xml after step 4 'close and save' 2023-03-15 11:22:33.123 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157716] Rename "Language settings" to "Language and Locale"
https://bugs.documentfoundation.org/show_bug.cgi?id=157716 --- Comment #7 from Buovjaga --- After the rename, Help files referencing this option path also need to be updated. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157885] help png images could use indexed colours
https://bugs.documentfoundation.org/show_bug.cgi?id=157885
--- Comment #6 from Jérôme ---
Created attachment 190901
--> https://bugs.documentfoundation.org/attachment.cgi?id=190901=edit
colours indexed on 8 bits saves 325 kB in french localized help
Into the LibreOffice_7.6.2_Win_x86-64_helppack_fr.msi archive file.
I converted all png files with ImageMagick with this command :
find . -type f -iname '*.png' -exec convert "{}" -type Palette -define
png:format=png8 -define png:compression-level=9 "{}8" \;
The attachment compares the orignal png files with the new indexed png on 8 bit
with 24 bit colours.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/inc cui/source cui/uiconfig editeng/source filter/source filter/uiconfig include/jvmfwk include/svl officecfg/registry readlicense_oo/docs reportbuilder/Package_tem
cui/inc/tipoftheday.hrc|8 +++---
cui/inc/treeopt.hrc|4 +--
cui/source/inc/treeopt.hxx |2 -
cui/source/tabpages/numfmt.cxx |2 -
cui/uiconfig/ui/numberingformatpage.ui |2 -
cui/uiconfig/ui/opthtmlpage.ui |2 -
editeng/source/editeng/editview.cxx|8 +++---
filter/source/msfilter/svdfppt.cxx |2 -
filter/uiconfig/ui/pdfviewpage.ui |2 -
include/jvmfwk/framework.hxx |2 -
include/svl/zforlist.hxx |2 -
officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs |2 -
officecfg/registry/schema/org/openoffice/Setup.xcs |6 ++--
readlicense_oo/docs/readme.xrm |2 -
reportbuilder/Package_templates.mk |2 -
sc/source/filter/excel/xestyle.cxx |2 -
scaddins/source/analysis/analysishelper.hxx|4 +--
sd/source/ui/docshell/docshel3.cxx |2 -
setup_native/source/mac/macinstall.ulf |2 -
svtools/uiconfig/ui/restartdialog.ui |2 -
svx/inc/svxerr.hrc |2 -
sw/qa/uitest/findReplace/tdf118208.py | 13
+-
sw/source/core/access/AccessibilityIssue.cxx |2 -
sw/source/filter/ww8/wrtw8sty.cxx |2 -
sw/source/uibase/shells/langhelper.cxx |2 -
sw/source/uibase/shells/textsh1.cxx|2 -
sw/uiconfig/swriter/ui/textgridpage.ui |2 -
27 files changed, 43 insertions(+), 42 deletions(-)
New commits:
commit 0264999bb3746a9c68938edd1a6fc05a8e40b406
Author: t-aswath
AuthorDate: Sat Nov 11 14:19:08 2023 +0530
Commit: Eike Rathke
CommitDate: Sat Nov 18 16:01:33 2023 +0100
tdf#157716 - Rename "Language settings" to "Languages and Locales"
Change-Id: Idd31b18c87998b03d884e7aa17197c459241abf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159315
Tested-by: Jenkins
Reviewed-by: Eike Rathke
diff --git a/cui/inc/tipoftheday.hrc b/cui/inc/tipoftheday.hrc
index 7f1dca4441d9..ed4b7b72eb3d 100644
--- a/cui/inc/tipoftheday.hrc
+++ b/cui/inc/tipoftheday.hrc
@@ -135,7 +135,7 @@ const std::tuple TIPOFTHEDAY_STRINGA
{ NC_("RID_CUI_TIPOFTHEDAY", "In %PRODUCTNAME Impress, use Insert ▸ Media
▸ Photo Album to create a slideshow from a series of pictures with the “Photo
Album” feature."), "", "", simpress},
{ NC_("RID_CUI_TIPOFTHEDAY", "You can show formulas instead of results
with View ▸ Show Formula (or Tools ▸ Options ▸ %PRODUCTNAME Calc ▸ View ▸
Display ▸ Formulas)."), "", "", scalc},
{ NC_("RID_CUI_TIPOFTHEDAY", "%PRODUCTNAME is developed by a friendly
community, made up of hundreds of contributors around the world. Join us with
your skills beyond coding."),
"https://www.libreoffice.org/community/get-involved/;, "", soffice},
- { NC_("RID_CUI_TIPOFTHEDAY", "Left-handed? Enable Tools ▸ Options ▸
Language Settings ▸ Languages ▸ Asian and check Tools ▸ Options ▸ %PRODUCTNAME
Writer ▸ View ▸ Ruler ▸ Right-aligned, which displays the scrollbar to the
left."), "", "", swriter},
+ { NC_("RID_CUI_TIPOFTHEDAY", "Left-handed? Enable Tools ▸ Options ▸
Languages and Locales ▸ General ▸ Asian and check Tools ▸ Options ▸
%PRODUCTNAME Writer ▸ View ▸ Ruler ▸ Right-aligned, which displays the
scrollbar to the left."), "", "", swriter},
{ NC_("RID_CUI_TIPOFTHEDAY", "Want headings to always begin a page? Edit
the paragraph style applied to the headings. Check “Insert” on the “Text Flow”
tab, with Type “Page” and Position “Before”."),
"cui/ui/textflowpage/checkInsert", "", swriter},
{ NC_("RID_CUI_TIPOFTHEDAY", "Date/time value is just a number of days
since a chosen day zero; in the number, integer part represents date, and
fractional part is time (elapsed part of a day), with 0.5 representing noon."),
"", "", scalc},
{ NC_("RID_CUI_TIPOFTHEDAY", "Shift+%MOD1+Del deletes from cursor to the
end of the current sentence."), "", "", swriter},
@@ -185,7 +185,7 @@ const std::tuple TIPOFTHEDAY_STRINGA
{ NC_("RID_CUI_TIPOFTHEDAY", "Your donations support our worldwide
community."), "https://www.libreoffice.org/donate/;, "", soffice},
{ NC_("RID_CUI_TIPOFTHEDAY", "You want to add x months to a date? Use
=EDATE(date;months)."),
"https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/scalc/01/func_edate.html;,
"", scalc}, //local help missing
{ NC_("RID_CUI_TIPOFTHEDAY", "To select a
[Libreoffice-bugs] [Bug 157716] Rename "Language settings" to "Language and Locale"
https://bugs.documentfoundation.org/show_bug.cgi?id=157716 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158264] Cannot delete formulas from Writer table
https://bugs.documentfoundation.org/show_bug.cgi?id=158264 --- Comment #1 from freew...@poczta.fm --- Created attachment 190900 --> https://bugs.documentfoundation.org/attachment.cgi?id=190900=edit cannot delete formulas from writer table -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158264] New: Cannot delete formulas from Writer table
https://bugs.documentfoundation.org/show_bug.cgi?id=158264 Bug ID: 158264 Summary: Cannot delete formulas from Writer table Product: LibreOffice Version: 7.6.2.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: freew...@poczta.fm Description: If you select table cells containing formulas and attempt to delete them by hitting DELETE key, Writer removes some of them, but mostly it leaves some zero values (or broken formulas giving zero as a result) leftovers. You have to repeat "select and delete" multiple times to actually remove all of the formulas, alternatively you have to remove entire row or column, but that's not an optimal solution to say the least. Steps to Reproduce: 1. Add formulas to multiple cells in a table 2. Select said cells and hit DELETE Actual Results: Selected formulas are NOT deleted correctly. Most often than not only first selected cell gets deleted, the rest of them are left broken. Expected Results: Content of every selected cells should be deleted. Reproducible: Always User Profile Reset: Yes Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158249] Document with one landscape page doesn't switch back to portrait when PRINTING.
https://bugs.documentfoundation.org/show_bug.cgi?id=158249 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||108800 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108800 [Bug 108800] [META] Print related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108800] [META] Print related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108800 BogdanB changed: What|Removed |Added Depends on||158249 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158249 [Bug 158249] Document with one landscape page doesn't switch back to portrait when PRINTING. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107332] [META] Calc cell and page styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107332 BogdanB changed: What|Removed |Added Depends on||158254 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158254 [Bug 158254] Can not apply any cell styles right of used area -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158254] Can not apply any cell styles right of used area
https://bugs.documentfoundation.org/show_bug.cgi?id=158254 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||107332 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107332 [Bug 107332] [META] Calc cell and page styles bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151759] Writer 7.4.x ignores Win10 Dell printer driver tray settings
https://bugs.documentfoundation.org/show_bug.cgi?id=151759 Stéphane Guillou (stragu) changed: What|Removed |Added Whiteboard||needsDellPrinter --- Comment #5 from Stéphane Guillou (stragu) --- Thank you. (In reply to fluidstates from comment #3) > corrected by selecting printer Properties from within LO's printer > dialog and manually (re)selecting Manual Paper. Do you mean it that it fails the first time, but it does work when choosing that setting again the next time you print? Do you still have this issue with LibreOffice 7.6? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158218] Document is not saved if solely text is pasted since last save
https://bugs.documentfoundation.org/show_bug.cgi?id=158218 --- Comment #6 from jasperh --- When I close the file and reopen it (instead of using another program to view the contents of the file) the pasted text is also missing. The meta data of the document is however updated (I see a new "recently edited" date). The other program also refreshes when I save the document. I only used the other program to show the problem a bit easier I also noticed that it makes a difference if the pasted text is "another cell" or if it's plain text from outside of libreoffice calc If the content of another cell is copied, the document is saved correctly -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158263] LibreOffice Calc can not calculate
https://bugs.documentfoundation.org/show_bug.cgi?id=158263 Werner Tietz changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Werner Tietz --- nice picture! But it tells nothing, please attach a Example.ods which shows the Data inclusive your Formula wich returns wrong calculations. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158258] Rank Function not working
https://bugs.documentfoundation.org/show_bug.cgi?id=158258 --- Comment #2 from Werner Tietz --- Hallo off topic: Why not: =RANK(F20,INDEX($O$4:$X$15;MATCH(EOMONTH(A20,0)-C20+1;$A$4:$A$15;0)) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input
https://bugs.documentfoundation.org/show_bug.cgi?id=158112 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8257 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input
https://bugs.documentfoundation.org/show_bug.cgi?id=158112 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8257 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 158257] ^{ opens the accessibility check
https://bugs.documentfoundation.org/show_bug.cgi?id=158257
V Stuart Foote changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDINFO
Ever confirmed|0 |1
CC||vsfo...@libreoffice.org
See Also||https://bugs.documentfounda
||tion.org/show_bug.cgi?id=15
||1059,
||https://bugs.documentfounda
||tion.org/show_bug.cgi?id=15
||8112
--- Comment #1 from V Stuart Foote ---
Can't confirm with en-US keyboard -- the "^{" can be entered.
Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
But isn't this the same issue as bug 151059, already changed for 24.2.0
and the 7.6.3 releases where the Sidebar deck shortcuts have been changed to
simple +[1-9]--but now causing bug 158112 for Windows use of the
+Numpad character input.
Please retest on 7.6.3 rc1, or on a nightly against 24.2.0 -- or when 7.6.3 is
released in a week.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153131] Copy causes Calc to Freeze on Windows 11 with Speech Recognition
https://bugs.documentfoundation.org/show_bug.cgi?id=153131 --- Comment #65 from Barry L. Kramer --- I was having problems with LO 7.6.2 Calc and Writer not starting at all (the splash screen came up but then went away, not launching) so I uninstalled. On reinstall of 7.5.0 and then 7.5.4.2, I can no longer reproduce the original problem even when the windows speech recognition is enabled. Strange. current OS: Edition Windows 11 Home Version 22H2 Installed on2/22/2023 OS build22621.2428 Experience Windows Feature Experience Pack 1000.22674.1000.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156200] Writer: Bad font rendering with anti-aliasing disabled (hinting enabled!) in Linux KDE system settings after update to LO 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=156200 --- Comment #22 from kde-user --- [This part in the angular bracket was updated on November 18, 2023: Currently I have been able to reproduce the problem on three different systems (main machine, laptop and newly set up virtual machine, all runing with KDE systems, mostly Arch based like EndeavourOS, Manjaro, CachyOS and Debian Testing) as follows: LO, official repositories: Arch: Versions up to and including 7.3.7-3 -> NOT affected; from 7.4.x -> affected Debian: Until the current version (and versions below) 7.4.7.2 -> NOT affected LO, Flatpak: Arch: Versions up to and including 7.6.2.1, Commit Code 7a83544cc21d1380efb3eeeb9f10adb26d125bc8db4936e82312a96e357e9abf from October 23, 2023 -> NOT affected; Versions from and including 7.6.2.1 (there are two different buids of this version!), Commit Code 1aa14038cbe7408fab115258b431132b7c0d1e9e257ba194c187a96df5e5be95 from November 08, 2023 -> affected Debian: Dito/Same LO, Appimage: Arch: Versions up to and including 7.3.7.2 -> NOT affected; from 7.4.0.2 -> affected Debian: Until the current version 7.6.2.1 -> NOT affected] -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156200] Writer: Bad font rendering with anti-aliasing disabled (hinting enabled!) in Linux KDE system settings after update to LO 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=156200 kde-user changed: What|Removed |Added Version|7.4.5.1 release |7.4.0.3 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156200] Writer: Bad font rendering with anti-aliasing disabled (hinting enabled!) in Linux KDE system settings after update to LO 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=156200 kde-user changed: What|Removed |Added Summary|Writer: Bad font rendering |Writer: Bad font rendering |with anti-aliasing disabled |with anti-aliasing disabled |(hinting enabled!) in |(hinting enabled!) in Linux |(probably just arch based) |KDE system settings after |Linux KDE system settings |update to LO 7.4.x |after update to LO 7.4.5-1 | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158218] Document is not saved if solely text is pasted since last save
https://bugs.documentfoundation.org/show_bug.cgi?id=158218 --- Comment #5 from m.a.riosv --- It works fine for me if after save I use Menu/File/Reload. Maybe if after the file is saved, and not closed, it is not modified in the system, and the other program can see it was change. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 154057] Cell focus when creating a URL link button may be inconsistent
https://bugs.documentfoundation.org/show_bug.cgi?id=154057 --- Comment #3 from Colin --- Being a little more destructive I have created another link button in the "same space" by sidling into the cell. The default button size is about half the cell height and remains accessible whilst it remains in focus. However, the focus "corners" re-size as though they are attached to the original button and the original button layers itself on top and will not respond to the arrange functions either to force it down one layer or force it to the back. This is an illusion. It is only the focal corners that have "re-sized" to the "dominant" button the smaller concealed button is still in focus and will respond to simple "drag" actions and as it is already below the orginal button then it can of course not be forced further down. The original button will always "retain focus" (Hovering over it produces the correct target URL) whilst it is placed on top of the newer button but all the dragging will still only impact the newer "concealed" button. I can't really imagine any use for 3 dimensional URL Buttons but I can envisage confusion if a user has inadvertently created multiple buttons in the same cell and "lost track" of what they are hoping to achieve. NOW 7.5.7.1 Win 10 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 154057] Cell focus when creating a URL link button may be inconsistent
https://bugs.documentfoundation.org/show_bug.cgi?id=154057 --- Comment #3 from Colin --- Being a little more destructive I have created another link button in the "same space" by sidling into the cell. The default button size is about half the cell height and remains accessible whilst it remains in focus. However, the focus "corners" re-size as though they are attached to the original button and the original button layers itself on top and will not respond to the arrange functions either to force it down one layer or force it to the back. This is an illusion. It is only the focal corners that have "re-sized" to the "dominant" button the smaller concealed button is still in focus and will respond to simple "drag" actions and as it is already below the orginal button then it can of course not be forced further down. The original button will always "retain focus" (Hovering over it produces the correct target URL) whilst it is placed on top of the newer button but all the dragging will still only impact the newer "concealed" button. I can't really imagine any use for 3 dimensional URL Buttons but I can envisage confusion if a user has inadvertently created multiple buttons in the same cell and "lost track" of what they are hoping to achieve. NOW 7.5.7.1 Win 10 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 158259] Manage Fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=158259 افشین changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from افشین --- *** This bug has been marked as a duplicate of bug 67200 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67200] Ability to "bookmark" my favourite fonts for easy access
https://bugs.documentfoundation.org/show_bug.cgi?id=67200 --- Comment #10 from افشین --- *** Bug 158259 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67200] Ability to "bookmark" my favourite fonts for easy access
https://bugs.documentfoundation.org/show_bug.cgi?id=67200 --- Comment #9 from افشین --- (In reply to Barry from comment #0) > It is great to be able to access a large font library for creative purposes, > but for more basic use they can get in the way when you need to switch > between common office fonts. it would be great to have somethign like > "bookmarks" in browser, so I could bookmark most common use office fonts, > for easy use but still have the big font library loaded for when I want just > the right font for more creative purposes. This is a good idea. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67200] Ability to "bookmark" my favourite fonts for easy access
https://bugs.documentfoundation.org/show_bug.cgi?id=67200 افشین changed: What|Removed |Added CC||afs...@libreoffice.org --- Comment #8 from افشین --- (In reply to Barry from comment #0) > It is great to be able to access a large font library for creative purposes, > but for more basic use they can get in the way when you need to switch > between common office fonts. it would be great to have somethign like > "bookmarks" in browser, so I could bookmark most common use office fonts, > for easy use but still have the big font library loaded for when I want just > the right font for more creative purposes. -- You are receiving this mail because: You are the assignee for the bug.
