Re: [Libreoffice] [PATCH] Replace List with std::vector
On Thu, Jun 30, 2011 at 09:14:02PM +0200, Thorsten Behrens wrote: Radek Doulík wrote: It looks like libs-gui/uui/source/services.cxx registers the component and sets up the factory for generating the dialogs. Because it's a component system, I'm not sure how to unplug it and/or verify how it would be used. the code looks dead to me as well, but I am also not sure. It was imported in 2000 and no real changes were done to it later - I mean the cookiedlg.cxx. Yep, unused - for those, just follow the implementation backwards. CookiesDialog only gets inst'ed in iahndl-cookies.cxx's executeCookieDialog(), which turn is only called in handleCookiesRequest_(), which only gets called from UUIInteractionHelper::handleCookiesRequest() - and there, only if the request has a ucb::HandleCookiesRequest set. The catch is - this code is part of the published API (look at offapi/com/sun/star/ucb/HandleCookiesRequest.idl), so strictly speaking, there may be extensions out there using it (though I doubt it, for this case). Some related files in this directory also use OS/2-era low-level functions and a specific implementation of file open dialogs. So far I've not been able to find proof they are unused but the suspicion is high. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Replace List with std::vector
On Sun, Jun 19, 2011 at 09:48:39PM -0700, Joseph Powers wrote: I'm sending the patch for review; not because it needs a lot but just to have someone verify that the memory was leaking and needs to be fixed. It has been pushed already, so adding PUSHED to summary. Current fixes: 1. XPropertyList::Clear() looks like it has a memory leek; so I fixed it. Yes, it has, but it does not matter as the function is not used anywhere. Nitpick: if you fixed it, why did you not use it in the destructor? Another (sligtly bigger) nitpick: why did you not use boost::ptr_vector? 2. I thinking that once pBmpList is a vector I should cleanup the constructors that pass initial size and resize values. Definitely. 3. I'm noticing that several methods have extra parameters that aren't used. Should I include a patch to clean them up also? Why not... Just be careful with virtual functions. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] LibreOffice does not produce valid DOC documents
Hi Cedric, all, https://bugs.freedesktop.org/show_bug.cgi?id=37516 So this one was a particularly nasty one; the only thing I had was a black box (in the form of MSO 2010) answering yes/no about the document validity :-) Long story short, it was SPRM SDxtCharSpace that had wrong value. The attached patch reverts the simplified computation of its value that produces wrong results when nPitch is smaller than nPageCharSize. Maybe it could be simplified in another way, but I think the safest ATM is to return to the algorithm that was there before (see commit e5693d5e14f8a53070b86ea1682201f5f2149b82). Review appreciated, targeting libreoffice-3-4 branch. Thank you, Kendy From 7941d9a4716c1579e81857abab0922701b319c9a Mon Sep 17 00:00:00 2001 From: Jan Holesovsky ke...@suse.cz Date: Fri, 1 Jul 2011 10:04:37 +0200 Subject: [PATCH] Fix the computation of grid character pitch, fdo#37516. --- sw/source/filter/ww8/attributeoutputbase.hxx |3 ++ sw/source/filter/ww8/docxattributeoutput.cxx | 17 +- sw/source/filter/ww8/ww8atr.cxx | 47 + 3 files changed, 36 insertions(+), 31 deletions(-) diff --git a/sw/source/filter/ww8/attributeoutputbase.hxx b/sw/source/filter/ww8/attributeoutputbase.hxx index 25fc965..84e58f7 100644 --- a/sw/source/filter/ww8/attributeoutputbase.hxx +++ b/sw/source/filter/ww8/attributeoutputbase.hxx @@ -539,6 +539,9 @@ protected: /// Sfx item RES_KEEP virtual void FormatKeep( const SvxFmtKeepItem ) = 0; +/// Compute the grid character pitch +sal_uInt32 GridCharacterPitch( const SwTextGridItem rGrid ) const; + /// Sfx item RES_TEXTGRID virtual void FormatTextGrid( const SwTextGridItem ) = 0; diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 9fd3150..693549c 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -4041,23 +4041,8 @@ void DocxAttributeOutput::FormatTextGrid( const SwTextGridItem rGrid ) pGridAttrList-add( FSNS( XML_w, XML_linePitch ), OString::valueOf( sal_Int32( nHeight ) ).getStr( ) ); -MSWordStyles * pStyles = m_rExport.pStyles; -SwFmt * pSwFmt = pStyles-GetSwFmt(); - -sal_uInt32 nPageCharSize = 0; - -if (pSwFmt != NULL) -{ -nPageCharSize = ItemGetSvxFontHeightItem -(*pSwFmt, RES_CHRATR_FONTSIZE).GetHeight(); -} - -sal_uInt16 nPitch = rGrid.IsSquaredMode() ? rGrid.GetBaseHeight() : -rGrid.GetBaseWidth( ); -sal_Int32 nCharSpace = ( nPitch - nPageCharSize ) * 4096 / 20; - pGridAttrList-add( FSNS( XML_w, XML_charSpace ), -OString::valueOf( sal_Int32( nCharSpace ) ).getStr( ) ); +OString::valueOf( sal_Int32( GridCharacterPitch( rGrid ) ) ).getStr( ) ); m_pSerializer-singleElementNS( XML_w, XML_docGrid, pGridAttrList ); } diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx index 63ee393..6e61641 100644 --- a/sw/source/filter/ww8/ww8atr.cxx +++ b/sw/source/filter/ww8/ww8atr.cxx @@ -3641,6 +3641,37 @@ void WW8AttributeOutput::SectionBreak( sal_uInt8 nC, const WW8_SepInfo* /*pSecti m_rWW8Export.ReplaceCr( nC ); } +sal_uInt32 AttributeOutputBase::GridCharacterPitch( const SwTextGridItem rGrid ) const +{ +MSWordStyles * pStyles = GetExport().pStyles; +SwFmt * pSwFmt = pStyles-GetSwFmt(); + +sal_uInt32 nPageCharSize = 0; + +if (pSwFmt != NULL) +{ +nPageCharSize = ItemGetSvxFontHeightItem +(*pSwFmt, RES_CHRATR_FONTSIZE).GetHeight(); +} +sal_uInt16 nPitch = rGrid.IsSquaredMode() ? rGrid.GetBaseHeight() : +rGrid.GetBaseWidth( ); + +sal_Int32 nCharWidth = nPitch - nPageCharSize; +sal_Int32 nFraction = nCharWidth % 20; +if ( nCharWidth 0 ) +nFraction = 20 + nFraction; +nFraction = ( nFraction * 0xFFF ) / 20; +nFraction = ( nFraction 0x0FFF ); + +sal_Int32 nMain = nCharWidth / 20; +if ( nCharWidth 0 ) +nMain -= 1; +nMain = nMain * 0x1000; +nMain = ( nMain 0xF000 ); + +return sal_uInt32( nFraction + nMain ); +} + void WW8AttributeOutput::FormatTextGrid( const SwTextGridItem rGrid ) { if ( m_rWW8Export.bOutPageDescs m_rWW8Export.bWrtWW8 ) @@ -3670,22 +3701,8 @@ void WW8AttributeOutput::FormatTextGrid( const SwTextGridItem rGrid ) m_rWW8Export.InsUInt16( NS_sprm::LN_SDyaLinePitch ); m_rWW8Export.InsUInt16( nHeight ); -MSWordStyles * pStyles = m_rWW8Export.pStyles; -SwFmt * pSwFmt = pStyles-GetSwFmt(); - -sal_uInt32 nPageCharSize = 0; - -if (pSwFmt != NULL) -{ -nPageCharSize = ItemGetSvxFontHeightItem -(*pSwFmt, RES_CHRATR_FONTSIZE).GetHeight(); -} -sal_uInt16 nPitch = rGrid.IsSquaredMode() ? rGrid.GetBaseHeight() : -rGrid.GetBaseWidth( ); -sal_Int32 nCharSpace = ( nPitch - nPageCharSize ) * 4096 /
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37516, which changed state. Bug 37516 Summary: FILESAVE LibreOffice does not produce valid DOC documents https://bugs.freedesktop.org/show_bug.cgi?id=37516 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Do not use path that depend on the repo layout!!!
On Thu, 2011-06-30 at 13:19 -0500, Norbert Thiebaud wrote: +#include ../../../../../libs-core/sfx2/inc/sfx2/childwin.hxx + does not resolve to a valid location anymore. IIRC the document load tests use absolute links to the clone/foo dirs as some hack for windows as well. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Do not use path that depend on the repo layout!!!
you're talking about stuff like this: http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/onegit/patches /0009-do-not-use-clone-in-path-fro-test-in-sw.patch right ? I think it was I who expanded the symlinks in that test case. Attempting to use the symlinks in LO test code will break on Windows. So yeah, when we go to OneGit, that needs to be fixed. Luckily, I don't think we have many of these? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Fix crash when selecting target after inserting hyperlink to database document
Hi all, https://bugs.freedesktop.org/show_bug.cgi?id=36545 This one is a trivial one, please see the attachment. All in all, just check for validity of a pointer we are going to dereference... Please check, sign-off, and push to libreoffice-3-4 Regards, Kendy From 02c0c09f0a8cb22b876b25ff670127cc85df1ddd Mon Sep 17 00:00:00 2001 From: Jan Holesovsky ke...@suse.cz Date: Fri, 1 Jul 2011 11:06:15 +0200 Subject: [PATCH] Don't crash when selecting target to db document, fdo#36545. --- dbaccess/source/ui/app/AppController.cxx |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dbaccess/source/ui/app/AppController.cxx b/dbaccess/source/ui/app/AppController.cxx index 7545e73..ba65284 100644 --- a/dbaccess/source/ui/app/AppController.cxx +++ b/dbaccess/source/ui/app/AppController.cxx @@ -1936,7 +1936,8 @@ Reference XComponent OApplicationController::openElementWithArguments( const IMPL_LINK( OApplicationController, OnSelectContainer, void*, _pType ) { ElementType eType = (ElementType)reinterpret_cast sal_IntPtr ( _pType ); -getContainer()-selectContainer(eType); +if (getContainer()) +getContainer()-selectContainer(eType); return 0L; } // - -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36545, which changed state. Bug 36545 Summary: Crash when selecting target after inserting hyperlink to database document (.odb) https://bugs.freedesktop.org/show_bug.cgi?id=36545 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] development summary: year 2011, week 24
Hi John, Petr, John LeMoyne Castle wrote (24-06-11 11:38) The intention is to make as few changes as possible in lo-commit-stat while getting to where a Weekly Development Summary wiki page is generated easily. For 'external use' it would be most helpful if there is a output comparing subsequent releases. But if In understood the information correctly, that can be easily accomplished with giving the right parameters? I generated two wiki pages: http://wiki.documentfoundation.org/Development/2010/MasterWeek39 -- and A page like that would be really useful information for those wanting to know about special bugs/fixes. Kind regards, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Do not use path that depend on the repo layout!!!
On Fri, Jul 1, 2011 at 4:10 AM, Tor Lillqvist tlillqv...@novell.com wrote: you're talking about stuff like this: http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/onegit/patches /0009-do-not-use-clone-in-path-fro-test-in-sw.patch right ? I think it was I who expanded the symlinks in that test case. Attempting to use the symlinks in LO test code will break on Windows. So yeah, when we go to OneGit, that needs to be fixed. Luckily, I don't think we have many of these? so far I found some of these in sw, hwpfilter, sc and lotuswordpro. but I only test-built on Linux. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] One Git v2.0
On Thu, 2011-06-30 at 15:37 -0500, Norbert Thiebaud wrote: So, plan B, I tried to use git fast-export/import instead of git filter-branch. That plan proved successful and now the conversion itself takes about 30 _minutes_ (add another 15 for a final git gc of the resulting core.git and a couple of hours to upload it all) Wow - lovely work ! :-) great speedup. So we're on for deploying this in another month; looking forward to it. Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Problem with socket timeout and regular freezing when using UNO and NOA
On 06/30/2011 02:20 PM, vikt...@gmail.com wrote: On 06/30/2011 10:27 AM, Tor Lillqvist wrote: For example, is it possible to build just the module that is causing a problem with the debug flags set, and replace just that .dll in LibreOffice, rather than building the whole source? You also need to build the modules that it depends on. Depending on how high in the dependency hierarchy the module you are interested in is located, that might be a large or small part of the code. OK - I have tried - but I cannot seems to figure how to build single modules - could anyone give me a pointer on that? I need to build the URE dll's - particularly urp_uno.dll as I think that's where the issue seems to be happening. Managed to get there *almost*. I have built most of the modules that ure is dependant on, but am stuck here: SmoketestCommandEnvironment.java:34: package com.sun.star.ucb does not exist import com.sun.star.ucb.XCommandEnvironment; I have build ucb - but I seem to have missed a module. Anyone know which module provides this package? Thanks Vik ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Problem with socket timeout and regular freezing when using UNO and NOA
SmoketestCommandEnvironment.java:34: package com.sun.star.ucb does not exist import com.sun.star.ucb.XCommandEnvironment; I have build ucb - but I seem to have missed a module. Anyone know which module provides this package? Ah, found it in unoil! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSoC] removing preload library
Hi there, On 27 June 2011 13:20, Michael Meeks michael.me...@novell.com wrote: But sometimes there also exist things like in: http://opengrok.libreoffice.org/xref/components/extensions/source/preload/services.cxx#59 That doesn't seem interesting to me, but I don't know, maybe it actually does something relevant. Ooh - you discovered some more junk code - nice. It would be wonderful if you could hunt down and kill any uses of this 'preload' code - we don't do OEM preloads, similarly we don't have product registration either so killing both of these components and their related scp2/ would be nice: STD_LIB_FILE( gid_File_Lib_Preload, preload) SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Productregistration, productregistration.uno ) would help to shrink the codebase, distributed binary size and compile time. Well, I had a look at preload. It's used just in desktop/source/so_comp/socomp.component and that component is used just in: - desktop for http://opengrok.libreoffice.org/xref/libs-core/desktop/source/app/app.cxx#1675 - maybe CheckInstallation should be now always true? - desktop, sfx2, similar checkOEM methods - http://opengrok.libreoffice.org/xref/libs-core/desktop/source/app/app.cxx#CheckOEM - I'm not sure about this one. Whether that should be always true or false or not removed. - the same with http://opengrok.libreoffice.org/xref/libs-core/sfx2/source/appl/shutdowniconw32.cxx#445 So, if it's possible to get rid of checkOEM and CheckInstallation methods we could remove preload.component and also socomp.component and related source files, libraries, ... Is it possible? I mean, both should be always true? Thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSoC] about removing productregistration.uno.component
Hi again, On 27 June 2011 13:20, Michael Meeks michael.me...@novell.com wrote: Ooh - you discovered some more junk code - nice. It would be wonderful if you could hunt down and kill any uses of this 'preload' code - we don't do OEM preloads, similarly we don't have product registration either so killing both of these components and their related scp2/ would be nice: STD_LIB_FILE( gid_File_Lib_Preload, preload) SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Productregistration, productregistration.uno ) I have looked also at productregistration.uno. It's more complicated with this one. - It is probably somehow related to published service ProductRegistration.idl in offapi. - sfx2 http://opengrok.libreoffice.org/xref/libs-core/sfx2/source/appl/appserv.cxx#994 - framework http://opengrok.libreoffice.org/xref/libs-core/framework/source/services/backingwindow.cxx#908 - desktop, but here seems to be done some great job with http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=b1766315d62b509af5ee2da5760c4e8535a5f3f7 and restored with merge http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=f9c53ad052cb31b8ff2727526651a79f333e3bf6 Maybe is it possible to re-apply kendy's patch? And there is also productregistration.jar.component in desktop. It seems to be unused but It's java and I'm not sure about that. Thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37622, which changed state. Bug 37622 Summary: xls file loses formatting https://bugs.freedesktop.org/show_bug.cgi?id=37622 What|Old Value |New Value Resolution|FIXED | Status|RESOLVED|REOPENED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] RTF support
On Thu, Jun 30, 2011 at 04:42:30AM -0700, tracey002 wp...@gte.net wrote: How can I obtain this exporter (direct web link)? I look at the developer pages, but reading the words and understanding the meaning are 2 separate issues. http://wiki.documentfoundation.org/Development/Native_Build Just FYI, RTF allows customization as long as they formatted so a reader that opens the document: 1) Does not crash. 2) retains block/group intact when it saves the document. This is not the correct definition of what customization is allowed. :) But sure, I'm aware of what an rtf reader should ignore, that's clearly stated in the spec. (See the \* control word.) pgpSnDL3h78Hz.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC] about removing productregistration.uno.component
Hi Matus, On Fri, 2011-07-01 at 13:53 +0200, Matúš Kukan wrote: - It is probably somehow related to published service ProductRegistration.idl in offapi. Well - we'd have to leave the IDL interface - and add it as a thing to remove in the wiki page: http://wiki.documentfoundation.org/Development/LibreOffice4 And there is also productregistration.jar.component in desktop. It seems to be unused but It's java and I'm not sure about that. Lets kill it all :-) re-apply Kendy's accidentally reverted patch, and hack all that registration code out, along with the various #defines SID_foo etc. that goes along with it [ and not to forget the scp2 too ]. Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] RTF exporter for Libre Office
From Miklos Vajna: If you can write a script that extracts keywords from the exporter and looks them up in the spec... Can anyone tell me (where/how) I can get the RTF exporter for Libre Office (it's download link)? Please advise. Thanks, Tracey No virus found in this outgoing message. Checked by AVG - www.avg.com Version: 9.0.901 / Virus Database: 271.1.1/3736 - Release Date: 06/30/11 13:34:00 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEWED] Fix crash when selecting target after inserting hyperlink to database document
On Fri, 2011-07-01 at 11:11 +0200, Jan Holesovsky wrote: This one is a trivial one, please see the attachment. All in all, just check for validity of a pointer we are going to dereference... Pushed to libreoffice-3-4. Thanks :-) Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] syntax error in ./configure
Hi there, On Thu, 2011-06-30 at 19:58 +, Martijn van Duren wrote: Heh - I committed something to autogen.sh that (hopefully) will make this at least a tad more intuitive (while no doubt breaking a number of platforms .. I'm tinkering around, just to see how far I'm getting at the Haiku platform. Although I have pkg-config installed I get the same error. Ah :-) what error exactly ? On Haiku the pkg.m4 is located at /boot/common/share/aclocal/pkg.m4. Do I need to point to that file from anywhere in the source tree Well, if you run aclocal (as we do in autogen.sh) it should import that macro into the local directory, and use it in the configure script - is it in your aclocal.m4 file ? Have you tried ./autogen.sh --clean ? ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] RTF support
I did not find what I anything that looked applicable. However I did download the source code from the download page contained in tar.bz2 files. I assume these are zip files. Can you tell me what file name for which I am looking and the containing zip file name? Please advise. Thanks, Tracey 06/27/2011 04:05a 13,542,278 libreoffice-artwork-3.4.1.3.tar.bz2 06/27/2011 04:05a 2,068,353 libreoffice-base-3.4.1.3.tar.bz2 06/27/2011 04:05a 2,707,154 libreoffice-bootstrap-3.4.1.3.tar.bz2 06/27/2011 04:05a 9,521,156 libreoffice-calc-3.4.1.3.tar.bz2 06/27/2011 04:05a 5,094,752 libreoffice-components-3.4.1.3.tar.bz2 06/27/2011 04:05a 4,215,501 libreoffice-extensions-3.4.1.3.tar.bz2 06/27/2011 04:05a 38,642,506 libreoffice-extras-3.4.1.3.tar.bz2 06/27/2011 04:05a 11,774,356 libreoffice-filters-3.4.1.3.tar.bz2 06/27/2011 04:05a 1,846,148 libreoffice-help-3.4.1.3.tar.bz2 06/27/2011 04:05a 2,651,815 libreoffice-impress-3.4.1.3.tar.bz2 06/27/2011 04:05a 15,601,815 libreoffice-libs-core-3.4.1.3.tar.bz2 06/27/2011 04:05a 637,815 libreoffice-libs-extern-3.4.1.3.tar.bz2 06/27/2011 04:05a 40,003,280 libreoffice-libs-extern-sys-3.4.1.3.tar.bz2 06/27/2011 04:05a 10,852,777 libreoffice-libs-gui-3.4.1.3.tar.bz2 06/27/2011 04:05a 50,867 libreoffice-postprocess-3.4.1.3.tar.bz2 06/27/2011 04:05a 1,721,006 libreoffice-sdk-3.4.1.3.tar.bz2 06/27/2011 04:05a 50,845,728 libreoffice-testing-3.4.1.3.tar.bz2 06/27/2011 04:06a 6,213,303 libreoffice-ure-3.4.1.3.tar.bz2 06/27/2011 04:06a 7,309,213 libreoffice-writer-3.4.1.3.tar.bz2 Miklos Vajna [via Document Foundation Mail Archive] wrote: On Thu, Jun 30, 2011 at 04:42:30AM -0700, tracey002 [hidden email] /user/SendEmail.jtp?type=nodenode=3129083i=0 wrote: How can I obtain this exporter (direct web link)? I look at the developer pages, but reading the words and understanding the meaning are 2 separate issues. http://wiki.documentfoundation.org/Development/Native_Build Just FYI, RTF allows customization as long as they formatted so a reader that opens the document: 1) Does not crash. 2) retains block/group intact when it saves the document. This is not the correct definition of what customization is allowed. :) But sure, I'm aware of what an rtf reader should ignore, that's clearly stated in the spec. (See the \* control word.) ___ LibreOffice mailing list [hidden email] /user/SendEmail.jtp?type=nodenode=3129083i=1 http://lists.freedesktop.org/mailman/listinfo/libreoffice *attachment0* (205 bytes) Download Attachment /attachment/3129083/0/attachment0 If you reply to this email, your message will be added to the discussion below: http://nabble.documentfoundation.org/RTF-support-tp3114982p3129083.html To unsubscribe from RTF support, click here http://nabble.documentfoundation.org/template/NamlServlet.jtp?macro=unsubscribe_by_codenode=3114982code=d3BpaXNAZ3RlLm5ldHwzMTE0OTgyfDg1NDMxMTYz. No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.901 / Virus Database: 271.1.1/3736 - Release Date: 06/30/11 13:34:00 No virus found in this outgoing message. Checked by AVG - www.avg.com Version: 9.0.901 / Virus Database: 271.1.1/3736 - Release Date: 06/30/11 13:34:00 -- View this message in context: http://nabble.documentfoundation.org/RTF-support-tp3114982p3129381.html Sent from the Dev mailing list archive at Nabble.com.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] RTF exporter for Libre Office
On Fri, 2011-07-01 at 08:38 -0500, Tracey wrote: From Miklos Vajna: If you can write a script that extracts keywords from the exporter and looks them up in the spec... Can anyone tell me (where/how) I can get the RTF exporter for Libre Office (it's download link)? It's embedded in it... so http://libreoffice.org ;) -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fw: Re: [tdf-discuss] LibreOffice 3.3.3 binaries for Solaris SPARC and Solaris X86
Hi Karl, On Thu, 2011-06-30 at 16:47 +0200, Karl Behler wrote: So you convinced me to give it a trial, but it fails after a few minutes. :-) good stuff. Looking for gcc and gld on my system shows both are available but in different locations. (In fact I would prefer to build with Solaris Compilers and Solaris tools.) so - of course, we're happy to merge patches, help out so on; but in the past there has been a certain amount of cruft and pain in the project to make it build with the oddish Solaris compilers. Personally, I'd strongly prefer a future where we built only with free compilers on Mac/cross-compile-to-windows/Linux and other places. Following files have been created by autogen up to the error. I include config.log for your information. I would have a read of configure.in to see what it is doing in this regard; this is an under-tested code-path. Next trial from tar ball .. ** I wouldn't bother with that. There'll be enough problems that it is best to fix them on master and get your patches merged there quickly I thinkg. cd ./bin ; ./unpack ./unpack: syntax error at line 184: `(' unexpected *** Error code 2 make: Fatal error: Command failed for target `/afs/ipp/home/k/kcb/ftp/LibreOffice/3331/libreoffice-build-3.3.3.1/build/libreoffice-3.3.3.1/unpack' 0.66user 3.51sys 0:10.22 40.9% Again this error syntax error at line 184: `(' unexpected Odd :-) this is most likely a /bin/sh vs. /bin/bash shell compatibility problem. Having said all that, personally I'd concentrate on getting 3.4.x building if you're desperate for a stable version, 3.4.2 will be out in a month, freeze in 2 weeks and can have your fixes in it by then; but I'd go for building on master and back-porting those myself :-) HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC] Report #5. Wizards
2011/6/30 Michael Meeks michael.me...@novell.com Hi Xisco, On Thu, 2011-06-30 at 18:28 +0200, Xisco Faulí wrote: Correct me if i'm wrong but as i've seen in the fax wizard,each kind of template has its own template so I believe it's the same for the letter templates and every localize has a different template, right ? Um ;-) in theory yes, but in reality no - having a duplicated ODF file for each and every translation (duplicating all the XML, all embedded images etc. etc.) bloated our install sets to some huge size for no good reason :-) In that case, the templates are the ones that should be changed, right ? Weelll - so you're both right; but really we need to grub about inside the templates themselves to add some improved translation scheme I think; now we have fast native XSLTs - I guess we could use the native XSLT filters to allow the templates to be self-standing, and yet adapt to the locale nicely. But - your task is primarily the Java - python conversion I guess :-) Yes, you're right but if I have some time before gsoc finishes (or even after) I'd like to take a look to it. Who should I get in contact with in order to get my feet wet ? All the best, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Java screws el reg ...
Hi guys, So: http://www.theregister.co.uk/2011/07/01/mac_os_x_10_point_7_preview/page2.html Java has been dropped, too, but there is slightly more hope for Java users: the first time you try to run a Java app, the OS will offer to download and install one for you. This is helpful but not ideal – so, for instance, to offer an entirely hypothetical scenario, if you had just installed LibreOffice and written a few hundred words of copy, you wouldn't be able to save your work if no JVM had been installed when the program was launched. Apparently the file-saving functionality is one of the Java bits and LibreOffice needs a restart for saving to work. Who knew? Looks bad; it seems we screwed over Liam; hopefully he could copy/paste out of it, but ... Is this really so ? it'd be great to isolate and kill whatever Java is required to save anything on Mac ? Thoughts ? Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC] Report #5. Wizards
Hi michael In that case, the templates are the ones that should be changed, right ? Weelll - so you're both right; but really we need to grub about inside the templates themselves to add some improved translation scheme I think; now we have fast native XSLTs - I guess we could use the native XSLT filters to allow the templates to be self-standing, and yet adapt to the locale nicely. IIRC, templates can be deployed with extension mechanism so why not use this and package language based extension when building the installer ? so, you may find more easily maintainers of these files i think your proposal is intellectually the good one, but seems overkill to me regarding the efforts needed when the files will have to be updated thanks anyway for your leading :-) Laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for screen resizing problems
On Wed, 2011-06-29 at 12:36 +0200, Lubos Lunak wrote: These are always nightmarish and some window manager or other does something odd. Do compiz, metacity and kwin all continue to work correctly with and without multihead ? It is a very reasonable change for any decent window manager (which here means one that reasonably supports the EWMH fullscreen state), as they'll Probably irrelevant, but I was just reading the nightmare that the gtk+ plugin has become [ packed full of un-pleasant direct X calls avoiding gdk ], and I saw this nugget: https://bugzilla.redhat.com/show_bug.cgi?id=623191#c8 I wouldn't be surprised if this was really the result of some of the horrible things we try to do to gtk+ when it is not looking rather than an underlying gtk+ bug but ... ;-) the testing does look pretty intense around there. HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Fix losing changes in a table in writer
Hi, https://bugs.freedesktop.org/show_bug.cgi?id=38374 In the document attached to the bug, when you copy the described table, do edits there, and save it as .doc, the changes are lost. These are in fact 2 bugs, but I fixed the more serious one. One is that when you copy/paste a fieldmark, the essential attributes are not preserved; later, when saving, the fieldmark is of unknown type, and ignored. We should save even the unknown fieldmarks I think, but here I fixed the root cause - that the attributes are not copied. Patch attached, please sign-off, and push to libreoffice-3-4. Thank you, Kendy From f1eaef6ec0f701cf3dfb223fdbc97c3eb17d1f9c Mon Sep 17 00:00:00 2001 From: Jan Holesovsky ke...@suse.cz Date: Fri, 1 Jul 2011 16:35:39 +0200 Subject: [PATCH] Copy fieldmark properties when copying/pasting, fdo#38374. --- sw/source/core/docnode/ndcopy.cxx | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/sw/source/core/docnode/ndcopy.cxx b/sw/source/core/docnode/ndcopy.cxx index acdb9a9..0176ada 100644 --- a/sw/source/core/docnode/ndcopy.cxx +++ b/sw/source/core/docnode/ndcopy.cxx @@ -186,14 +186,25 @@ namespace // Explicitly try to get exactly the same name as in the source // because NavigatorReminders, DdeBookmarks etc. ignore the proposed name pDestDoc-getIDocumentMarkAccess()-renameMark(pNewMark, pMark-GetName()); + +// copying additional attributes for bookmarks or fieldmarks ::sw::mark::IBookmark* const pNewBookmark = dynamic_cast ::sw::mark::IBookmark* const (pNewMark); -if(pNewBookmark) /* copying additional attributes for bookmarks */ +if(pNewBookmark) { const ::sw::mark::IBookmark* const pOldBookmark = dynamic_cast const ::sw::mark::IBookmark* (pMark); pNewBookmark-SetKeyCode(pOldBookmark-GetKeyCode()); pNewBookmark-SetShortName(pOldBookmark-GetShortName()); } +::sw::mark::IFieldmark* const pNewFieldmark = +dynamic_cast ::sw::mark::IFieldmark* const (pNewMark); +if(pNewFieldmark) +{ +const ::sw::mark::IFieldmark* const pOldFieldmark = dynamic_cast const ::sw::mark::IFieldmark* (pMark); +pNewFieldmark-SetFieldname(pOldFieldmark-GetFieldname()); +pNewFieldmark-SetFieldHelptext(pOldFieldmark-GetFieldHelptext()); +} + ::sfx2::Metadatable const*const pMetadatable( dynamic_cast ::sfx2::Metadatable const* (pMark)); ::sfx2::Metadatable *const pNewMetadatable( -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 38374, which changed state. Bug 38374 Summary: writer: changes made to table are lost https://bugs.freedesktop.org/show_bug.cgi?id=38374 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] LibreOffice does not produce valid DOC documents
On Fri, 2011-07-01 at 10:18 +0200, Jan Holesovsky wrote: Hi Cedric, all, https://bugs.freedesktop.org/show_bug.cgi?id=37516 So this one was a particularly nasty one; the only thing I had was a black box (in the form of MSO 2010) answering yes/no about the document validity :-) Long story short, it was SPRM SDxtCharSpace that had wrong value. The attached patch reverts the simplified computation of its value that produces wrong results when nPitch is smaller than nPageCharSize. Maybe it could be simplified in another way, but I think the safest ATM is to return to the algorithm that was there before (see commit e5693d5e14f8a53070b86ea1682201f5f2149b82). Review appreciated, targeting libreoffice-3-4 branch. Thanks for your help and patch for that bug... I though I would become mad ;) patch looks good to me... just pushed it. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for screen resizing problems
On Fri, 2011-07-01 at 15:33 +0100, Michael Meeks wrote: I saw this nugget: https://bugzilla.redhat.com/show_bug.cgi?id=623191#c8 I wouldn't be surprised if this was really the result of some of the horrible things we try to do to gtk+ when it is not looking rather than an underlying gtk+ bug but ... https://bugzilla.redhat.com/show_bug.cgi?id=623191#c1 has a demo, which reproduced apparently for no-one except me with that, which consists of only gtk/gdk calls. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] java 7
I got an email form oracle that java 7 is due out in july Is that goign to affect anything in regards to LO? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Copy Header/Footer from one Writer document to another
Hi Grover, Grover Blue wrote (01-07-11 17:03) Thanks for getting back to me Cor. I did copy the page style by creating a new style on document 1 with a random name, copying over the page style props from document 2, then applying the page style to page for which the document was inserted. That sounds fine, I would think. I asked this similar question here: http://user.services.openoffice.org/en/forum/viewtopic.php?f=25t=38739p=180951 http://user.services.openoffice.org/en/forum/viewtopic.php?f=25t=38739p=180951 ... I mostly got it working, except for the copying of the actually header/footer text. Whenever I read in a new document, the header and footer text is always applied to the first page (or Default page style), instead of the newly created page style. OK, at the first paragraph of a new page, you have to add both manual break, and set the property new page style to xxx You can see that in the UI ... I've included all the relevant code below. Please note that I had to leave the PAGE BREAK code as is, otherwise the insertion of a new document would not occur on a new page. I may be able to leave out the Section Break, but I for now it shouldn't be a problem. As written, breaks are essential, but maybe you need some additional property there. Thanks for the code, but that will take more time for me to understand then I can spent. Sorry for that. Cheers, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] syntax error in ./configure
Michael Meeks michael.meeks@... writes: Hi there, On Thu, 2011-06-30 at 19:58 +, Martijn van Duren wrote: Heh - I committed something to autogen.sh that (hopefully) will make this at least a tad more intuitive (while no doubt breaking a number of platforms .. I'm tinkering around, just to see how far I'm getting at the Haiku platform. Although I have pkg-config installed I get the same error. Ah what error exactly ? On Haiku the pkg.m4 is located at /boot/common/share/aclocal/pkg.m4. Do I need to point to that file from anywhere in the source tree Well, if you run aclocal (as we do in autogen.sh) it should import that macro into the local directory, and use it in the configure script - is it in your aclocal.m4 file ? Have you tried ./autogen.sh --clean ? ATB, Michael. Sorry, I thought the error was clear considering the thread I was responding to. The error I get is: checking whether to enable native cups support... no checking whether we need fontconfig... ./configure: line 7608: syntax error near unexpected token `FONTCONFIG,' ./configure: line 7608: ` PKG_CHECK_MODULES(FONTCONFIG, fontconfig = 2.2.0)' When doing ./autogen.sh --clean it removes install-sh and after replacing it with with either the system's install-sh or reverting the usual install-sh from the git-tree it returns to the prior error. To get to the configure-process I added the following to configure.in: haiku*) build_gstreamer=no test_cups=no test_fontconfig=no test_freetype=no test_gtk=no test_kde=no test_kde4=no test_randr=no test_unix_quickstarter=no _os=Haiku ;; Haiku is recognized by config.guess and I turned every setting I could find from every other OS off, to test with the most minimal of build. ps. I use Haiku alpha 3 with haikuports installed from haikuware.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] rtl::O[U]StringBuffer now has a remove method
On Thursday 30 of June 2011, Caolán McNamara wrote: On Thu, 2011-06-30 at 13:46 +0200, Lubos Lunak wrote: O[U]StringBuffer don't have any other range function, but O[U]String uses start+len for such cases (copy, replaceAt), so this seems inconsistent. hmm, yeah, that's true. java doesn't have a replaceAt sort of thing, nor a copy method, though its ctors have a startindex + length option while it has a substring which does take [startindex, endindex) Do we have a preference ?, I'm easy either way. Since nobody seems to have a preference, I'd like to point out that also std::string uses start+len (even though there one could expect start,end to match the iterator variants) and Qt uses start+len. IMO we should not try to be consistent with Java just because the idea for the class comes from Java. Ok to push the attached patch? Also, am I correct that you haven't used these anywhere yet? -- Lubos Lunak l.lu...@suse.cz diff --git a/sal/inc/rtl/strbuf.h b/sal/inc/rtl/strbuf.h index 1c076cf..9543b9a 100644 --- a/sal/inc/rtl/strbuf.h +++ b/sal/inc/rtl/strbuf.h @@ -116,19 +116,16 @@ void SAL_CALL rtl_stringbuffer_insert( /*inout*/rtl_String ** This, Removes the characters in a substring of this sequence. The substring begins at the specified codestart/code and -extends to the character at index codeend - 1/code or to -the end of the sequence if no such character exists. If -codestart/code is equal to codeend/code, no changes -are made. +is codelen/code characters long. -start must be = 0 = This-length = end +start must be = 0 = This-length @param start The beginning index, inclusive -@param end The ending index, exclusive +@param len The substring length */ void SAL_CALL rtl_stringbuffer_remove( /*inout*/rtl_String ** This, sal_Int32 start, - sal_Int32 end ); + sal_Int32 len ); #ifdef __cplusplus } diff --git a/sal/inc/rtl/strbuf.hxx b/sal/inc/rtl/strbuf.hxx index 7e52b21..3a26c1b 100644 --- a/sal/inc/rtl/strbuf.hxx +++ b/sal/inc/rtl/strbuf.hxx @@ -675,25 +675,17 @@ public: Removes the characters in a substring of this sequence. The substring begins at the specified codestart/code and -extends to the character at index codeend - 1/code or to -the end of the sequence if no such character exists. If -codestart/code is equal to codeend/code, no changes -are made. +is codelen/code characters long. start must be = 0 = getLength() = end -As is usual for the rtl string classes, this is based -on an analogous Java StringBuffer member. In this -case codedelete/code, but because that's a reserved -keyword in C++, this is named coderemove/code. - -@param start The beginning index, inclusive -@param end The ending index, exclusive +@param start The beginning index, inclusive +@param len The substring length @return this string buffer. */ -OStringBuffer remove( sal_Int32 start, sal_Int32 end ) +OStringBuffer remove( sal_Int32 start, sal_Int32 len ) { -rtl_stringbuffer_remove( pData, start, end ); +rtl_stringbuffer_remove( pData, start, len ); return *this; } diff --git a/sal/inc/rtl/ustrbuf.h b/sal/inc/rtl/ustrbuf.h index d2d2ed4..260db4f 100644 --- a/sal/inc/rtl/ustrbuf.h +++ b/sal/inc/rtl/ustrbuf.h @@ -163,19 +163,16 @@ void SAL_CALL rtl_uStringbuffer_insert_ascii( /*inout*/rtl_uString ** This, Removes the characters in a substring of this sequence. The substring begins at the specified codestart/code and -extends to the character at index codeend - 1/code or to -the end of the sequence if no such character exists. If -codestart/code is equal to codeend/code, no changes -are made. +is codelen/code characters long. -start must be = 0 = This-length = end +start must be = 0 = This-length @param start The beginning index, inclusive -@param end The ending index, exclusive +@param len The substring length */ void SAL_CALL rtl_uStringbuffer_remove( /*inout*/rtl_uString ** This, sal_Int32 start, - sal_Int32 end ); + sal_Int32 len ); #ifdef __cplusplus } diff --git a/sal/inc/rtl/ustrbuf.hxx b/sal/inc/rtl/ustrbuf.hxx index d48c5c7..7569597 100644 --- a/sal/inc/rtl/ustrbuf.hxx +++ b/sal/inc/rtl/ustrbuf.hxx @@ -742,25 +742,17 @@ public: Removes the characters in a substring of this sequence. The substring begins at the specified codestart/code and -extends to the character at index codeend - 1/code or to -the end of the sequence if no such character exists.
Re: [Libreoffice] syntax error in ./configure
Hi Martijn, *, On Fri, Jul 1, 2011 at 5:52 PM, Martijn van Duren martijn...@gmail.com wrote: Michael Meeks michael.meeks@... writes: On Thu, 2011-06-30 at 19:58 +, Martijn van Duren wrote: On Haiku the pkg.m4 is located at /boot/common/share/aclocal/pkg.m4. Do I need to point to that file from anywhere in the source tree As apparently this is not the default location for autoconf on your system: Yes. checking whether we need fontconfig... ./configure: line 7608: syntax error near unexpected token `FONTCONFIG,' ./configure: line 7608: ` PKG_CHECK_MODULES(FONTCONFIG, fontconfig = 2.2.0)' PKG_CHECK_MODULES is to be replaced by the pkg.m4, so it was not used. set ACLOCAL_FLAGS to -I /boot/common/share/aclocal or copy the pkg.m4 to one of your aclocal's default search paths. If this is a default haiku-install, i.e. every user using this OS will have the problem, feel free to add it to the autogen.sh script ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java screws el reg ...
Hi Michael, On Fri, Jul 01, 2011 at 03:30:37PM +0100, Michael Meeks wrote: http://www.theregister.co.uk/2011/07/01/mac_os_x_10_point_7_preview/page2.html hypothetical scenario, if you had just installed LibreOffice and written a few hundred words of copy, you wouldn't be able to save your work if no JVM had been installed when the program was launched. Apparently the file-saving functionality is one of the Java bits and LibreOffice needs a restart for saving to work. Who knew? [...] Is this really so ? it'd be great to isolate and kill whatever Java is required to save anything on Mac ? I'm not running MacOS X, but all my LibreOffice builds are done without Java and the only obvious broken feature is the Contributor Credits link accessible from the help/about menu. Java can be safely disabled from all builds (and the saving code fixed if it really needs it on MacOS X) IMHO. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSoC] [helpfiles] commit
Hello everybody, this is what I have done in the meantime. I implemented a program that converts an xml to chm and docbook. Here is the draft.* Also here is the installer that installs HTML Help Compiler on wine. Because the native install file doesnt work on wine, this program does the installation. In the future I will extend the usage of convert.py so that it is possible to enter in- and output as a parameter. Also I like to make sure that OSX and Yelp create their indexes. This is probably neccessary for the next step. Combine the help and LibreOffice so that the help file opens correctly and at the correct place on each platform. Best wishes, Timo * see attachment From 3df28aaa3c414d06e3283479f9f1f8fc0cca9f9d Mon Sep 17 00:00:00 2001 From: timo t...@pc1.org Date: Fri, 1 Jul 2011 16:56:18 +0200 Subject: [PATCH] Committer: timo t...@iera.de new file: wiki-to-help/HHC/htmlhelp.reg new file: wiki-to-help/HHC/install_hhc.sh new file: wiki-to-help/convert.py new file: wiki-to-help/test2.xml My files contain a list of its dependencies in their heads. HHC/install_hhc.sh should be run first. convert.py converts test2.xml into several formats to test/ --- helpcontent2/wiki-to-help/HHC/htmlhelp.reg | 12 + helpcontent2/wiki-to-help/HHC/install_hhc.sh | 60 helpcontent2/wiki-to-help/convert.py | 133 + helpcontent2/wiki-to-help/test2.xml | 381 ++ 4 files changed, 586 insertions(+), 0 deletions(-) create mode 100644 helpcontent2/wiki-to-help/HHC/htmlhelp.reg create mode 100755 helpcontent2/wiki-to-help/HHC/install_hhc.sh create mode 100755 helpcontent2/wiki-to-help/convert.py create mode 100644 helpcontent2/wiki-to-help/test2.xml diff --git a/helpcontent2/wiki-to-help/HHC/htmlhelp.reg b/helpcontent2/wiki-to-help/HHC/htmlhelp.reg new file mode 100644 index 000..e38e0ef --- /dev/null +++ b/helpcontent2/wiki-to-help/HHC/htmlhelp.reg @@ -0,0 +1,12 @@ +REGEDIT4 + +[HKEY_CURRENT_USER\Software\Wine] +Version=win2k + +[HKEY_CURRENT_USER\Software\Wine\AppDefaults\hhc.exe\DllOverrides] +itircl=native +itss=native + +[HKEY_CURRENT_USER\Software\Wine\AppDefaults\hhw.exe\DllOverrides] +itircl=native +itss=native diff --git a/helpcontent2/wiki-to-help/HHC/install_hhc.sh b/helpcontent2/wiki-to-help/HHC/install_hhc.sh new file mode 100755 index 000..ba93c78 --- /dev/null +++ b/helpcontent2/wiki-to-help/HHC/install_hhc.sh @@ -0,0 +1,60 @@ +#!/bin/bash -e +# -e Exit immediately if a command exits with a non-zero status. + +# This installs Microsofts HHC (HTML Help Compiler) +# Copyright 2011 Timo Richter and others. +# Licensed under GNU GPLv3 +# Depends on: wine, wget, cabextract +# +# Usage of HHC: wine c:\\htmlhelp\\hhc.exe c:\\test\\htmlhelp.hhp +# +# Changes: Set installation directory to c:\htmlhelp +# Copy also itcc.dll, this is neccessary +# No execution of htmlhelp.exe installer needed +# Abortion of install if anything fails, e.g. the download of HHC. +# + +echo Please wait + +cd $(dirname $0) # cd to path of this script + + +WINEPREFIX=${WINEPREFIX:=$HOME/.wine} +test -d $WINEPREFIX || wineprefixcreate 2 /dev/null +HHDIR=${WINEPREFIX}/dosdevices/c:/htmlhelp +mkdir $HHDIR + +# Setup the registry +# Set Wine's Windows version to Windows 2000 (or above), and add an override to use the native itss.dll, both via winecfg. +wine regedit htmlhelp.reg + +cd $HHDIR + +# Install HTML Help Workshop +wget -O htmlhelp.exe 'http://go.microsoft.com/fwlink/?LinkId=14188' +cabextract -F hhc.exe htmlhelp.exe +cabextract -F HHA.dll htmlhelp.exe + +# Install ITSS.DLL +cabextract -F hhupd.exe htmlhelp.exe +cabextract -F itircl.dll hhupd.exe +cabextract -F itss.dll hhupd.exe +cabextract -F itcc.dll htmlhelp.exe +cp -a itircl.dll $WINEPREFIX/drive_c/windows/system32/ +cp -a itcc.dll $WINEPREFIX/drive_c/windows/system32/ +cp -a itss.dll $WINEPREFIX/drive_c/windows/system32/ +wine regsvr32 'C:\WINDOWS\SYSTEM32\itcc.dll' +wine regsvr32 'C:\WINDOWS\SYSTEM32\itircl.dll' +wine regsvr32 'C:\WINDOWS\SYSTEM32\itss.dll' + +# Install MFC40.DLL +wget -N http://activex.microsoft.com/controls/vc/mfc40.cab +cabextract -F mfc40.exe mfc40.cab +cabextract -F mfc40.dll mfc40.exe +cp -a mfc40.dll $WINEPREFIX/drive_c/windows/system32/ + +echo +echo Done. + +exit 0 + diff --git a/helpcontent2/wiki-to-help/convert.py b/helpcontent2/wiki-to-help/convert.py new file mode 100755 index 000..5e3e400 --- /dev/null +++ b/helpcontent2/wiki-to-help/convert.py @@ -0,0 +1,133 @@ +#!/usr/bin/env python + +Convert an XML-Dump to platformspecific help files. +Copyright 2011 Timo Richter +Licensed under GNU GPLv3 + +This program depends on: +mwlib +python +python-lxml +xsltproc +Microsoft HHC: http://go.microsoft.com/fwlink/?LinkId=14188 + + + + +import xml.dom.minidom as minidom +import subprocess, tempfile, os, shutil + +class Wine(object): +#driveletter=j: #final + +def __init__(self,workingDir,driveletter): + Setup the wine
Re: [Libreoffice] Fw: Re: [tdf-discuss] LibreOffice 3.3.3 binaries for Solaris SPARC and Solaris X86
On Fri, Jul 01, 2011 at 03:02:35PM +0100, Michael Meeks wrote: so - of course, we're happy to merge patches, help out so on; but in the past there has been a certain amount of cruft and pain in the project to make it build with the oddish Solaris compilers. Personally, I'd strongly prefer a future where we built only with free compilers on Mac/cross-compile-to-windows/Linux and other places. From what I've heard from *Solaris application developers/packagers, the old Sun compilers are beeing dropped left and right. It seems Oracle has also borked this product line... Having said all that, personally I'd concentrate on getting 3.4.x building if you're desperate for a stable version, 3.4.2 will be out in a month, freeze in 2 weeks and can have your fixes in it by then; but I'd go for building on master and back-porting those myself :-) Master is also reasonably okay for day-to day work; I have been using snapshots without trouble with small .odt or .ods documents for the last two month or so... -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix losing changes in a table in writer
Hi Kendy, On Fri, 2011-07-01 at 16:43 +0200, Jan Holesovsky wrote: In the document attached to the bug, when you copy the described table, do edits there, and save it as .doc, the changes are lost. These are in fact 2 bugs, but I fixed the more serious one. One is that when you copy/paste a fieldmark, the essential attributes are not preserved; later, when saving, the fieldmark is of unknown type, and ignored. We should save even the unknown fieldmarks I think, but here I fixed the root cause - that the attributes are not copied. The patch is ok to me, but for completeness we should copy the GetParameters map too. Could you please review my changes for this? Patch attached, please sign-off, and push to libreoffice-3-4. I pushed it... but forgot to sign it off. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr From 01fb7a1648a74d3171c30b57fb4e185d92187160 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Bosdonnat?= cedric.bosdonnat@free.fr Date: Fri, 1 Jul 2011 18:23:07 +0200 Subject: [PATCH] copied the IFieldMark::GetParameters too --- sw/source/core/docnode/ndcopy.cxx |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/sw/source/core/docnode/ndcopy.cxx b/sw/source/core/docnode/ndcopy.cxx index 0176ada..6272576 100644 --- a/sw/source/core/docnode/ndcopy.cxx +++ b/sw/source/core/docnode/ndcopy.cxx @@ -203,6 +203,14 @@ namespace const ::sw::mark::IFieldmark* const pOldFieldmark = dynamic_cast const ::sw::mark::IFieldmark* (pMark); pNewFieldmark-SetFieldname(pOldFieldmark-GetFieldname()); pNewFieldmark-SetFieldHelptext(pOldFieldmark-GetFieldHelptext()); +::sw::mark::IFieldmark::parameter_map_t* pNewParams = pNewFieldmark-GetParameters(); +const ::sw::mark::IFieldmark::parameter_map_t* pOldParams = pOldFieldmark-GetParameters(); +::sw::mark::IFieldmark::parameter_map_t::const_iterator pIt = pOldParams-begin(); +while ( pIt != pOldParams-end() ) +{ +pNewParams-insert( *pIt ); +pIt++; +} } ::sfx2::Metadatable const*const pMetadatable( -- 1.7.3.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] One Git v2.0
Hi Norbert, On 2011-06-30 at 15:37 -0500, Norbert Thiebaud wrote: So, plan B, I tried to use git fast-export/import instead of git filter-branch. That plan proved successful and now the conversion itself takes about 30 _minutes_ (add another 15 for a final git gc of the resulting core.git and a couple of hours to upload it all) This is really great! :-) - so in fact, we might be able to do even a transition without outage / without closing the 'old' repos, right? If we do the conversion to master of the new onegit repo, and then consequent exports to onegit's branch few times a day, we would be able to merge from there to master, if somebody manages to commit to the old repositories, right? ;-) Unfortunately I was unable to have a look at your code, and will be on vacations the next week - so hopefully other reviewers will step in in the meantime? All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Problem with make on fedora 15
Hi, We are group of 3 students from Vietnam. We are trying to build Libreoffice on Fedora 15 Build environment: Fedora 15, default installation, yum up to date. [tatung@tatung-laptop ~]$ gcc --version | grep gcc gcc (GCC) 4.6.0 20110530 (Red Hat 4.6.0-9) [tatung@tatung-laptop ~]$ rpm -qa | grep glibc glibc-common-2.14-3.i686 glibc-devel-2.14-3.i686 glibc-headers-2.14-3.i686 glibc-2.14-3.i686 [tatung@tatung-laptop ~]$ uname -a Linux tatung-laptop 2.6.38.8-32.fc15.i686 #1 SMP Mon Jun 13 20:01:50 UTC 2011 i686 i686 i386 GNU/Linux We've followed this link http://www.documentfoundation.org/develop/ In addition, before running autogen.sh, I've installed gnome-vfs2-devel. autogen.sh was OK but when I tried to run make (not make dev-install yet), an error appeared http://pastebin.com/S3J1DxBu I've tried to follow the instructions rm -Rf /home/tatung/mhst2011/git/libo/tail_build/unxlngi6.pro # optional module 'clean' /bin/sh cd /home/tatung/mhst2011/git/libo source ./LinuxX86Env.Set.sh cd tail_build make -r However, the error is still there. So please help :) Thanks and Best Regards, tatung ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix losing changes in a table in writer
Hi Cedric, On 2011-07-01 at 18:26 +0200, Cedric Bosdonnat wrote: The patch is ok to me, but for completeness we should copy the GetParameters map too. Could you please review my changes for this? Looks good to me - but to be safe, what about to push this one to master only? This is not needed to fix the initial bug... Thank you a lot, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Litmus testcase structure improvement.
Hi Yifan Yifan Jiang wrote (30-06-11 12:51) That would be great :) Thanks! I commited some words (untested) here today for Litmus admin: http://wiki.documentfoundation.org/Litmus#Litmus_for_Libreoffice_Admin_Guide Please also let me know if something is confusing. For the moment - and the few spare minutes I found, I start to understand it. I will - again - mail to the Dutch list to see if others step in. btw. would you do the changes in 'Master Regression TC' branches, where all the latest test cases should be tracked:) Yes, that is clear and makes much sense. But - noticing my current 'activity' here - you can imagine that much work is not likely to be done by me. Sorry, but hey, don't let that be discouraging. Anyone can stand up at any moment to help too :-) ATM for me most important is to understand it, so that I can point others (Dutch NL group) to it, and give some guidance. (For the rest, I try to keep on track with different releases, rc's, sometimes nightly builds, etc and work in that and try to find/file bugs when I come across something strange.) In addition, maybe the step by step working practice section 'Use case - Adding a new regression test case' would be helpful: http://wiki.documentfoundation.org/Litmus#Working_practices http://wiki.documentfoundation.org/Litmus#Step_by_Step_Working_practices Will look to that next days! Regards, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] One Git v2.0
On Fri, Jul 1, 2011 at 11:32 AM, Jan Holesovsky ke...@novell.com wrote: Hi Norbert, On 2011-06-30 at 15:37 -0500, Norbert Thiebaud wrote: So, plan B, I tried to use git fast-export/import instead of git filter-branch. That plan proved successful and now the conversion itself takes about 30 _minutes_ (add another 15 for a final git gc of the resulting core.git and a couple of hours to upload it all) This is really great! :-) - so in fact, we might be able to do even a transition without outage / without closing the 'old' repos, right? If we do the conversion to master of the new onegit repo, and then consequent exports to onegit's branch few times a day, we would be able to merge from there to master, if somebody manages to commit to the old repositories, right? ;-) I'm sorry but I'm not sure I'm following what you envision. That being said, it looks now that the 'outage' would be just about 3 hours... and based on pass experience if we pick sunday 01:00 UTC - 04:00 UTC, it is likely that no-one will notice the outage ever occurred. The sequence of event would be to put a 'End-of-time' label on all our current repos, and then to add the following in the server-side pre-commit hook: #!/bin/bash if `git symbolic-ref HEAD` == refs/heads/master then echo Due to the OneGit migration, You cannot commit in this master anymore! exit 1 fi That would block commit to master, but leave the possibility to work on the branches. Anybody that get caught we dangling local commit to master can easily git format-patch them and git am them on top of core.git I will try to send an email to every-one that has a freedesktop.org account that allow to push to our git repos well in advance of the migration, using : getent group | grep ooo-build to get the list of ids and id@kemper.fdo as email. (btw: that is 82 committers to date) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Attention to all with push privilege
Hi all, We are gearing-up to a migration of our git repos, to consolidate most of them into one. This will impact everybody, but particularly people with push privilege. I intend to, in addition to posting to the ML, to send you email, directly, to inform you of planned event and deadline you need to be aware of. I anticipate that this would be 5 emails total. 1 two weeks before the scheduled migration, another one 1 week before the migration, one on the day of the migration, one when the current 'master' is taken offline and one when the new master is online. This can in theory be done by using the forwarding mechanism in place at freedesktop connecting you fdo id to the email-of-record at freedesktop for that id. Still, I would like to encourage all of you to update http://wiki.documentfoundation.org/Development/Developers with the relevant information. I would also ask that you try to send an email to yourid@kemper.freedesktop.org and verify that you do receive that test message (and make sure that it is not filtered out by any spam filter you may have) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Problem with make on fedora 15
On Fri, Jul 01, 2011 at 11:33:25PM +0700, Ta Duc Tung tatung2...@gmail.com wrote: We are group of 3 students from Vietnam. We are trying to build Libreoffice on Fedora 15 Build environment: Fedora 15, default installation, yum up to date. [tatung@tatung-laptop ~]$ gcc --version | grep gcc gcc (GCC) 4.6.0 20110530 (Red Hat 4.6.0-9) [tatung@tatung-laptop ~]$ rpm -qa | grep glibc glibc-common-2.14-3.i686 glibc-devel-2.14-3.i686 glibc-headers-2.14-3.i686 glibc-2.14-3.i686 [tatung@tatung-laptop ~]$ uname -a Linux tatung-laptop 2.6.38.8-32.fc15.i686 #1 SMP Mon Jun 13 20:01:50 UTC 2011 i686 i686 i386 GNU/Linux We've followed this link http://www.documentfoundation.org/develop/ In addition, before running autogen.sh, I've installed gnome-vfs2-devel. autogen.sh was OK but when I tried to run make (not make dev-install yet), an error appeared http://pastebin.com/S3J1DxBu That's a known problem with gcc-4.6 - have you tried applying this[1] patch? [1] http://pkgs.fedoraproject.org/gitweb/?p=libreoffice.git;a=blob_plain;f=vbahelper.visibility.patch;hb=HEAD pgpfSKoaxoTaR.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice