[Libreoffice-commits] .: ooo_custom_images/tango
ooo_custom_images/tango/framework/res/addtemplate_32.png |binary ooo_custom_images/tango/framework/res/arrow.png |binary ooo_custom_images/tango/framework/res/extension.png |binary ooo_custom_images/tango/framework/res/folder_32.png |binary ooo_custom_images/tango/framework/res/info_26.svg| 148 +++ ooo_custom_images/tango/framework/res/templates_32.png |binary 6 files changed, 148 insertions(+) New commits: commit a76b594329ecae98c14662aac74f6a13882c4c41 Author: Stefan Knorr (astron) heinzless...@gmail.com Date: Thu Dec 15 11:29:14 2011 +0100 New Tango Start Center artwork By Alexander Wilms/Stefan Knorr (astron) diff --git a/ooo_custom_images/tango/framework/res/addtemplate_32.png b/ooo_custom_images/tango/framework/res/addtemplate_32.png new file mode 100644 index 000..6ac0ce2 Binary files /dev/null and b/ooo_custom_images/tango/framework/res/addtemplate_32.png differ diff --git a/ooo_custom_images/tango/framework/res/arrow.png b/ooo_custom_images/tango/framework/res/arrow.png new file mode 100644 index 000..8c817cc Binary files /dev/null and b/ooo_custom_images/tango/framework/res/arrow.png differ diff --git a/ooo_custom_images/tango/framework/res/extension.png b/ooo_custom_images/tango/framework/res/extension.png new file mode 100644 index 000..ee7cd39 Binary files /dev/null and b/ooo_custom_images/tango/framework/res/extension.png differ diff --git a/ooo_custom_images/tango/framework/res/folder_32.png b/ooo_custom_images/tango/framework/res/folder_32.png new file mode 100644 index 000..7d80314 Binary files /dev/null and b/ooo_custom_images/tango/framework/res/folder_32.png differ diff --git a/ooo_custom_images/tango/framework/res/info_26.svg b/ooo_custom_images/tango/framework/res/info_26.svg new file mode 100644 index 000..0b41cb5 --- /dev/null +++ b/ooo_custom_images/tango/framework/res/info_26.svg @@ -0,0 +1,148 @@ +?xml version=1.0 encoding=UTF-8 standalone=no? +!-- Created with Inkscape (http://www.inkscape.org/) -- + +svg + xmlns:dc=http://purl.org/dc/elements/1.1/; + xmlns:cc=http://creativecommons.org/ns#; + xmlns:rdf=http://www.w3.org/1999/02/22-rdf-syntax-ns#; + xmlns:svg=http://www.w3.org/2000/svg; + xmlns=http://www.w3.org/2000/svg; + xmlns:xlink=http://www.w3.org/1999/xlink; + xmlns:sodipodi=http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd; + xmlns:inkscape=http://www.inkscape.org/namespaces/inkscape; + width=24 + height=24 + id=svg6455 + version=1.1 + inkscape:version=0.48.2 r9819 + sodipodi:docname=Info.svg + defs + id=defs6457 +linearGradient + inkscape:collect=always + xlink:href=#linearGradient7068 + id=linearGradient6148 + gradientUnits=userSpaceOnUse + x1=-207.56598 + y1=1449.8578 + x2=-168.14899 + y2=1489.3698 / +linearGradient + id=linearGradient7068 + stop + id=stop7070 + offset=0 + style=stop-color:#729fcf;stop-opacity:1; / + stop + id=stop7072 + offset=1 + style=stop-color:#3465a4;stop-opacity:1; / +/linearGradient +linearGradient + id=linearGradient7805-2-15 + stop + style=stop-color:#91adcf;stop-opacity:1; + offset=0 + id=stop7807-7-4 / + stop + style=stop-color:#729fcf;stop-opacity:1; + offset=1 + id=stop7809-5-0 / +/linearGradient +linearGradient + y2=1430.0388 + x2=-229.48209 + y1=1499.8662 + x1=-157.48567 + gradientUnits=userSpaceOnUse + id=linearGradient8142 + xlink:href=#linearGradient7805-2-15 + inkscape:collect=always / + /defs + sodipodi:namedview + id=base + pagecolor=#ff + bordercolor=#66 + borderopacity=1.0 + inkscape:pageopacity=0.0 + inkscape:pageshadow=2 + inkscape:zoom=30 + inkscape:cx=6.9533846 + inkscape:cy=11.270852 + inkscape:current-layer=g5992 + showgrid=false + inkscape:grid-bbox=true + inkscape:document-units=px + inkscape:snap-grids=false + inkscape:window-width=1440 + inkscape:window-height=844 + inkscape:window-x=0 + inkscape:window-y=26 + inkscape:window-maximized=1 +inkscape:grid + type=xygrid + id=grid6625 + empspacing=5 + visible=true + enabled=true + snapvisiblegridlinesonly=true / + /sodipodi:namedview + metadata + id=metadata6460 +rdf:RDF + cc:Work + rdf:about= +dc:formatimage/svg+xml/dc:format +dc:type + rdf:resource=http://purl.org/dc/dcmitype/StillImage; / +dc:title / + /cc:Work +/rdf:RDF + /metadata + g + id=layer1 + inkscape:label=Layer 1 + inkscape:groupmode=layer + transform=translate(0,-8) +g + transform=matrix(3.99002,0,0,3.99002,-1047.28,-2177.63) + id=g5992 + path +
[Libreoffice-commits] .: ooo_custom_images/tango
ooo_custom_images/tango/framework/res/info_26.png |binary ooo_custom_images/tango/framework/res/info_26.svg | 148 -- 2 files changed, 148 deletions(-) New commits: commit aee15f3f1cc5fa0ee23ac5f1344a193ed72f84f3 Author: Stefan Knorr (astron) heinzless...@gmail.com Date: Thu Dec 15 11:40:47 2011 +0100 SVG slipped through, should have been a PNG Icon by Alexander Wilms diff --git a/ooo_custom_images/tango/framework/res/info_26.png b/ooo_custom_images/tango/framework/res/info_26.png new file mode 100644 index 000..c63d0f4 Binary files /dev/null and b/ooo_custom_images/tango/framework/res/info_26.png differ diff --git a/ooo_custom_images/tango/framework/res/info_26.svg b/ooo_custom_images/tango/framework/res/info_26.svg deleted file mode 100644 index 0b41cb5..000 --- a/ooo_custom_images/tango/framework/res/info_26.svg +++ /dev/null @@ -1,148 +0,0 @@ -?xml version=1.0 encoding=UTF-8 standalone=no? -!-- Created with Inkscape (http://www.inkscape.org/) -- - -svg - xmlns:dc=http://purl.org/dc/elements/1.1/; - xmlns:cc=http://creativecommons.org/ns#; - xmlns:rdf=http://www.w3.org/1999/02/22-rdf-syntax-ns#; - xmlns:svg=http://www.w3.org/2000/svg; - xmlns=http://www.w3.org/2000/svg; - xmlns:xlink=http://www.w3.org/1999/xlink; - xmlns:sodipodi=http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd; - xmlns:inkscape=http://www.inkscape.org/namespaces/inkscape; - width=24 - height=24 - id=svg6455 - version=1.1 - inkscape:version=0.48.2 r9819 - sodipodi:docname=Info.svg - defs - id=defs6457 -linearGradient - inkscape:collect=always - xlink:href=#linearGradient7068 - id=linearGradient6148 - gradientUnits=userSpaceOnUse - x1=-207.56598 - y1=1449.8578 - x2=-168.14899 - y2=1489.3698 / -linearGradient - id=linearGradient7068 - stop - id=stop7070 - offset=0 - style=stop-color:#729fcf;stop-opacity:1; / - stop - id=stop7072 - offset=1 - style=stop-color:#3465a4;stop-opacity:1; / -/linearGradient -linearGradient - id=linearGradient7805-2-15 - stop - style=stop-color:#91adcf;stop-opacity:1; - offset=0 - id=stop7807-7-4 / - stop - style=stop-color:#729fcf;stop-opacity:1; - offset=1 - id=stop7809-5-0 / -/linearGradient -linearGradient - y2=1430.0388 - x2=-229.48209 - y1=1499.8662 - x1=-157.48567 - gradientUnits=userSpaceOnUse - id=linearGradient8142 - xlink:href=#linearGradient7805-2-15 - inkscape:collect=always / - /defs - sodipodi:namedview - id=base - pagecolor=#ff - bordercolor=#66 - borderopacity=1.0 - inkscape:pageopacity=0.0 - inkscape:pageshadow=2 - inkscape:zoom=30 - inkscape:cx=6.9533846 - inkscape:cy=11.270852 - inkscape:current-layer=g5992 - showgrid=false - inkscape:grid-bbox=true - inkscape:document-units=px - inkscape:snap-grids=false - inkscape:window-width=1440 - inkscape:window-height=844 - inkscape:window-x=0 - inkscape:window-y=26 - inkscape:window-maximized=1 -inkscape:grid - type=xygrid - id=grid6625 - empspacing=5 - visible=true - enabled=true - snapvisiblegridlinesonly=true / - /sodipodi:namedview - metadata - id=metadata6460 -rdf:RDF - cc:Work - rdf:about= -dc:formatimage/svg+xml/dc:format -dc:type - rdf:resource=http://purl.org/dc/dcmitype/StillImage; / -dc:title / - /cc:Work -/rdf:RDF - /metadata - g - id=layer1 - inkscape:label=Layer 1 - inkscape:groupmode=layer - transform=translate(0,-8) -g - transform=matrix(3.99002,0,0,3.99002,-1047.28,-2177.63) - id=g5992 - path - transform=matrix(0.06715897,0,0,0.06715897,278.37153,452.29962) - d=m -156.33689,1465.8986 a 35.079124,35.079124 0 1 1 -70.15825,0 35.079124,35.079124 0 1 1 70.15825,0 z - sodipodi:ry=35.079124 - sodipodi:rx=35.079124 - sodipodi:cy=1465.8986 - sodipodi:cx=-191.41602 - id=path6618 - style=fill:url(#linearGradient6148);fill-opacity:1;stroke:#36567c;stroke-width:4.47818613;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;display:inline - sodipodi:type=arc - inkscape:export-filename=/home/alexander/Dokumente/LibreOffice/Icons.png - inkscape:export-xdpi=90 - inkscape:export-ydpi=90 / - g - style=font-size:3.4565661px;font-style:italic;font-weight:normal;line-height:125%;letter-spacing:0px;word-spacing:0px;fill:#ff;fill-opacity:1;stroke:none;display:inline;font-family:Sans;-inkscape-font-specification:Sans Italic - id=text6628 -path - d=m 265.8376,550.2211 -0.23967,1.12406 c -0.0135,0.063
[Libreoffice-commits] .: sc/source
sc/source/filter/excel/impop.cxx |4 1 file changed, 4 insertions(+) New commits: commit 9dab9a26aeaeeaabcef3f4900597ca57e7411a2d Author: Muthu Subramanian sumu...@suse.com Date: Thu Dec 15 16:49:52 2011 +0530 fdo#33747: Row Height is unnecessarily large. diff --git a/sc/source/filter/excel/impop.cxx b/sc/source/filter/excel/impop.cxx index 3c96481..533bbb9 100644 --- a/sc/source/filter/excel/impop.cxx +++ b/sc/source/filter/excel/impop.cxx @@ -937,6 +937,10 @@ void ImportExcel::Row34( void ) aIn nRowHeight; // direkt in Twips angegeben aIn.Ignore( 4 ); +nRowHeight = nRowHeight 0x7FFF; // Bit 15: Row Height not changed manually +if( !nRowHeight ) +nRowHeight = (GetBiff() == EXC_BIFF2) ? 0x25 : 0x225; + aIn nGrbit nXF; sal_uInt8 nLevel = ::extract_value sal_uInt8 ( nGrbit, 0, 3 ); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - bridges/source officecfg/registry RepositoryModule_ooo.mk salhelper/inc salhelper/Library_salhelper.mk salhelper/Makefile salhelper/Module_salhelper.mk salhelper/P
RepositoryModule_ooo.mk |1 bridges/source/cpp_uno/shared/vtablefactory.cxx | 10 ++ officecfg/registry/cppheader.xsl | 66 - salhelper/Library_salhelper.mk| 81 ++ salhelper/Makefile| 41 +++ salhelper/Module_salhelper.mk | 35 + salhelper/Package_inc.mk | 43 +++ salhelper/inc/salhelper/condition.hxx | 20 ++--- salhelper/inc/salhelper/dynload.hxx |3 salhelper/inc/salhelper/salhelperdllapi.h | 16 salhelper/inc/salhelper/simplereferenceobject.hxx |7 + salhelper/inc/salhelper/timer.hxx |7 + salhelper/prj/build.lst |3 salhelper/prj/d.lst | 24 -- salhelper/prj/makefile.mk |1 salhelper/source/gcc3.map |9 ++ salhelper/source/makefile.mk | 81 -- salhelper/source/msci.map | 50 - salhelper/source/mscx.map | 50 - salhelper/source/sols.map | 76 salhelper/version.mk | 44 --- solenv/gbuild/platform/macosx.mk |4 - 22 files changed, 290 insertions(+), 382 deletions(-) New commits: commit d24bd093602da47349e4b48a7e5082592dcded48 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Dec 15 11:58:10 2011 +0100 Correctly handle set directly within component. diff --git a/officecfg/registry/cppheader.xsl b/officecfg/registry/cppheader.xsl index 5071fba..df891c2 100644 --- a/officecfg/registry/cppheader.xsl +++ b/officecfg/registry/cppheader.xsl @@ -94,49 +94,47 @@ xsl:text#xA;/xsl:text xsl:text#include sal/config.h#xA;/xsl:text xsl:text#xA;/xsl:text -xsl:if test=.//prop/@oor:nillable = 'true' - xsl:text#include boost/optional.hpp#xA;/xsl:text -/xsl:if -xsl:if test=.//prop/@oor:type = 'oor:any' - xsl:text#include com/sun/star/uno/Any.hxx#xA;/xsl:text -/xsl:if -xsl:if test=.//prop/@oor:type = 'xs:hexBinary' or .//prop/@oor:type = 'oor:boolean-list' or .//prop/@oor:type = 'oor:short-list' or .//prop/@oor:type = 'oor:int-list' or .//prop/@oor:type = 'oor:long-list' or .//prop/@oor:type = 'oor:double-list' or .//prop/@oor:type = 'oor:string-list' - xsl:text#include com/sun/star/uno/Sequence.hxx#xA;/xsl:text -/xsl:if xsl:if test=.//prop or .//set + xsl:if test=.//prop/@oor:nillable = 'true' +xsl:text#include boost/optional.hpp#xA;/xsl:text + /xsl:if + xsl:if test=.//prop/@oor:type = 'oor:any' +xsl:text#include com/sun/star/uno/Any.hxx#xA;/xsl:text + /xsl:if + xsl:if test=.//prop/@oor:type = 'xs:hexBinary' or .//prop/@oor:type = 'oor:boolean-list' or .//prop/@oor:type = 'oor:short-list' or .//prop/@oor:type = 'oor:int-list' or .//prop/@oor:type = 'oor:long-list' or .//prop/@oor:type = 'oor:double-list' or .//prop/@oor:type = 'oor:string-list' +xsl:text#include com/sun/star/uno/Sequence.hxx#xA;/xsl:text + /xsl:if xsl:text#include rtl/ustring.h#xA;/xsl:text xsl:text#include rtl/ustring.hxx#xA;/xsl:text -/xsl:if -xsl:if test=.//prop/@oor:type = 'xs:short' or .//prop/@oor:type = 'xs:int' or .//prop/@oor:type = 'xs:long' or .//prop/@oor:type = 'xs:hexBinary' - xsl:text#include sal/types.h#xA;/xsl:text -/xsl:if -xsl:if test=.//prop or .//set + xsl:if test=.//prop/@oor:type = 'xs:short' or .//prop/@oor:type = 'xs:int' or .//prop/@oor:type = 'xs:long' or .//prop/@oor:type = 'xs:hexBinary' +xsl:text#include sal/types.h#xA;/xsl:text + /xsl:if xsl:text#include unotools/configuration.hxx#xA;/xsl:text -/xsl:if -xsl:text#xA;/xsl:text -xsl:textnamespace officecfg { namespace /xsl:text -xsl:value-of select=$ns1/ -xsl:if test=$ns2 - xsl:text { namespace /xsl:text - xsl:value-of select=$ns2/ - xsl:if test=$ns3 + xsl:text#xA;/xsl:text + xsl:textnamespace officecfg { namespace /xsl:text + xsl:value-of select=$ns1/ + xsl:if test=$ns2 xsl:text { namespace /xsl:text -xsl:value-of select=$ns3/ +xsl:value-of select=$ns2/ +xsl:if test=$ns3 + xsl:text { namespace /xsl:text + xsl:value-of select=$ns3/ +/xsl:if /xsl:if -/xsl:if -xsl:text {#xA;/xsl:text -xsl:text#xA;/xsl:text -xsl:apply-templates select=group - xsl:with-param name=path select=$path/ -/xsl:apply-templates -xsl:if test=$ns2 - xsl:text} /xsl:text - xsl:if test=$ns3 + xsl:text {#xA;/xsl:text + xsl:text#xA;/xsl:text + xsl:apply-templates select=group|set|prop +xsl:with-param name=path
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - lingucomponent/source
lingucomponent/source/languageguessing/exports.dxp |1 + lingucomponent/source/languageguessing/makefile.mk | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) New commits: commit c8fc44a4468ad27655a778d51c8877d0f036e996 Author: Caolán McNamara caol...@redhat.com Date: Thu Dec 15 11:52:42 2011 + Resolves: fdo#43422 component_getFactory is missing this is already converted to gbuild in head, so presumably visibility woes are gone there now. diff --git a/lingucomponent/source/languageguessing/exports.dxp b/lingucomponent/source/languageguessing/exports.dxp new file mode 100644 index 000..7003307 --- /dev/null +++ b/lingucomponent/source/languageguessing/exports.dxp @@ -0,0 +1 @@ +component_getFactory diff --git a/lingucomponent/source/languageguessing/makefile.mk b/lingucomponent/source/languageguessing/makefile.mk index 5fe1945..a99e1f4 100644 --- a/lingucomponent/source/languageguessing/makefile.mk +++ b/lingucomponent/source/languageguessing/makefile.mk @@ -1,4 +1,4 @@ -#* + # # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # @@ -27,11 +27,9 @@ PRJ=..$/.. PRJNAME=lingucomponent - TARGET=guesslang - ENABLE_EXCEPTIONS=TRUE -VISIBILITY_HIDDEN=TRUE +USE_DEFFILE=TRUE #- Settings - @@ -72,14 +70,16 @@ SHL1STDLIBS= \ $(UNOTOOLSLIB) # build DLL -SHL1USE_EXPORTS = name SHL1LIBS= $(SLB)$/$(TARGET).lib SHL1IMPLIB= i$(TARGET) SHL1DEPN= $(SHL1LIBS) SHL1DEF=$(MISC)$/$(SHL1TARGET).def +SHL1VERSIONMAP=$(SOLARENV)/src/component.map + # build DEF file DEF1NAME=$(SHL1TARGET) +DEF1EXPORTFILE= exports.dxp # --- Targets -- ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sysui/desktop
sysui/desktop/share/launcher_comment.ulf | 169 --- sysui/desktop/share/launcher_genericname.ulf | 167 -- 2 files changed, 336 deletions(-) New commits: commit 4d9293660776b6d97289cf7a1bf8f6be7ad05649 Author: David Tardon dtar...@redhat.com Date: Thu Dec 15 12:49:36 2011 +0100 these translations do already exist in translations repo diff --git a/sysui/desktop/share/launcher_comment.ulf b/sysui/desktop/share/launcher_comment.ulf index c9cd594..71c82e2 100755 --- a/sysui/desktop/share/launcher_comment.ulf +++ b/sysui/desktop/share/launcher_comment.ulf @@ -1,190 +1,21 @@ [writer] en-US = Create and edit text and graphics in letters, reports, documents and Web pages by using Writer. -ast = Escribi y edita testos y gráficos en cartes, informes, documentos y páxines web. -ca = Creeu i editeu text i grà fics a cartes, informes, documents i pà gines web. -da = Opret og redigér tekst og grafik i breve, rapporter, dokumenter og hjemmesider. -de = Texte und Grafiken in Briefen, Berichten, Dokumenten und Webseiten erstellen und bearbeiten. -es = Cree y edite textos y gráficos en cartas, informes, documentos y páginas web. -fi = Luo ja muokkaa tekstejä ja grafiikkaa kirjeisiin, raportteihin, asiakirjoihin ja WWW-sivuille. -fr = Créer et modifier des textes et graphiques pour lettres, rapports, documents ou pages Web. -gl = Cree e modifique textos e gráficos en cartas, informes, documentos e páxinas web. -he = ×צ××¨× ×ער××× ×©× ××§×¡× ××רפ××§× ×××ת×××, ××××ת, ×ס×××× ×××ª×¨× ××× ××¨× ×. -hr = Stvorite i uredite tekstualna i grafiÄka pisma, izvjeÅ¡taje, dokumente i web stranice. -hu = Levelek, jelentések, dokumentumok és weboldalak szövegének és grafikájának létrehozása és szerkesztése -it = Crea e modifica testo e grafica in lettere, rapporti, documenti e pagine Web. -is = Búa til og sýsla með texta og myndefni à bréfum, skýrslum, ýmsum textaskjölum og vefsÃðum. -ja = æç´ãã¬ãã¼ããææ¸ãWebãã¼ã¸åãã®æç« ãç»åãä½æã»ç·¨éãã¾ãã -ku = Nivîs û grafîkên di name, rapor, belge û rûpelên torê de çêbike û sererast bike. -nl = Tekst en afbeeldingen bewerken in brieven, rapporten, documenten en webpagina's. -pt_BR = Crie e edite seus textos e gráficos em cartas, relatórios, documentos ou páginas da web. -ro = CreaÈi Èi editaÈi documente text Èi grafice sub formÄ de scrisori, rapoarte, articole sau pagini web. -ru = Создание и ÑедакÑиÑование ÑекÑÑов и изобÑажений в пиÑÑÐ¼Ð°Ñ , оÑÑÑÑÐ°Ñ , докÑменÑÐ°Ñ Ð¸ на веб-ÑÑÑаниÑÐ°Ñ . -sl = Ustvarjajte in urejajte besedilo in grafiko v pismih, poroÄilih, dokumentih in spletnih straneh. -te = పతà±à°°à°¾à°²à±, నివà±à°¦à°¿à°à°²à± మరియౠవà±à°¬à± à°ªà±à°à±à°²à°²à± పాఠà±à°¯à° మరియౠà°à±à°°à°¾à°«à°¿à°à±à°¸à± à°¸à±à°·à±à°à°¿ మరియౠసవరణ -vi = Tạo và soạn vÄn bản và hình trong thÆ°, báo cáo, tà i liá»u và trang web. -zh_CN = å建ç¼è¾ææ¡£ãæ¥åã信件åç½é¡µä¸çææ¬åå¾å½¢ã -zh_TW = 建ç«è編輯æ¸ä¿¡ãå ±åãæ件è網é ä¸çæåååå½¢ã [impress] en-US = Create and edit presentations for slideshows, meeting and Web pages by using Impress. -ast = Fai y edita presentaciones pa pases de diapositives, reuniones y páxines web. -ca = Creeu i editeu presentacions per a diapositives, conferències i pà gines web. -da = Opret og rediger præsentationer til diasshows, møder og hjemmesider. -de = Präsentationen für Vorführungen, Besprechungen und Web-Auftritte erstellen und bearbeiten. -el = ÎÎ·Î¼Î¹Î¿Ï Ïγία και εÏεξεÏγαÏία ÏαÏÎ¿Ï ÏιάÏεÏν για ÏÏοβολÎÏ Î´Î¹Î±ÏανειÏν, ÏÏ ÏκÎÏÎµÎ¹Ï ÎºÎ±Î¹ ιÏÏοÏÎµÎ»Î¯Î´ÎµÏ -es = Cree y edite presentaciones para pases de diapositivas, reuniones y páginas web. -fi = Luo ja muokkaa esityksiä esitelmiin, tapaamisiin ja WWW-sivuille. -fr = Créer et modifier des présentations pour des diaporamas, des conférences et pour le Web. -gl = Cree e modifique presentacións para diaporamas, conferencias e páxinas web. -he = ×צ××¨× ×ער××× ×©× ×צ××ת ×¢××ר שק×פ××ת, פ××ש×ת ×××ª×¨× ××× ××¨× ×. -hr = Stvorite i uredite prezentacije za sastanke i web stranice. -hu = Bemutatók készÃtése és szerkesztése diavetÃtésekhez vagy a webre -it = Crea e modifica presentazioni per proiezioni, meeting e pagine Web. -is = Búa til og breyta kynningum fyrir ráðstefnur, fyrirlestra og fyrir birtingu á vef. -ja = ã¹ã©ã¤ãã·ã§ã¼ãä¼è°ãWebãã¼ã¸åãã®ãã¬ã¼ã³ãã¼ã·ã§ã³ãä½æã»ç·¨éãã¾ãã -nl = Presentaties maken voor diavoorstellingen, vergaderingen en webpagina's. -pt_BR = Crie e edite apresentações para reuniões ou páginas da
[Libreoffice-commits] .: package/source
package/source/zipapi/ZipFile.cxx |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) New commits: commit 82b71e04a1594755d345d227181642c491518e18 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Dec 15 12:30:13 2011 +0100 Revert Fix n#653688 This reverts commit 309f56174aca6adca879f70958892492361dac6e. It caused password-protected documents to no longer work and made sc_subsequent_filters_test's testPassword fail. diff --git a/package/source/zipapi/ZipFile.cxx b/package/source/zipapi/ZipFile.cxx index 8317745..ef801f2 100644 --- a/package/source/zipapi/ZipFile.cxx +++ b/package/source/zipapi/ZipFile.cxx @@ -688,7 +688,7 @@ sal_Bool ZipFile::readLOC( ZipEntry rEntry ) // check basic local file header / entry consistency bBroken = rEntry.nVersion != nVersion -|| rEntry.nMethod != nHow +|| rEntry.nFlag != nFlag || rEntry.nTime != nTime || rEntry.nPathLen != nPathLen || !rEntry.sPath.equals( sLOCPath ); @@ -698,12 +698,6 @@ sal_Bool ZipFile::readLOC( ZipEntry rEntry ) bBroken = sal_True; } -// ignore bits 1 2 for normal deflate algo - they're purely informative -if( nHow != 8 nHow != 9 ) -bBroken = bBroken || rEntry.nFlag != nFlag; -else if( (rEntry.nFlag ~6L) != (nFlag ~6L) ) -bBroken = true; - if ( bBroken !bRecoveryMode ) throw ZipIOException( OUString( RTL_CONSTASCII_USTRINGPARAM( The stream seems to be broken! ) ), uno::Reference XInterface () ); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: l10ntools/prj l10ntools/scripts
l10ntools/prj/d.lst |1 l10ntools/scripts/propex|2 + l10ntools/scripts/propmerge | 86 3 files changed, 89 insertions(+) New commits: commit ec4f2f1d81884a1b4ddc1e1f9981636c5e443aab Author: Andras Timar ati...@suse.com Date: Thu Dec 15 14:02:57 2011 +0100 propmerge tool to merge strings back to localized .properties files diff --git a/l10ntools/prj/d.lst b/l10ntools/prj/d.lst index 0d39719..ee088ff 100644 --- a/l10ntools/prj/d.lst +++ b/l10ntools/prj/d.lst @@ -39,6 +39,7 @@ mkdir: %_DEST%\bin\help\com\sun\star\help ..\scripts\addkeyid2pot.pl %_DEST%\bin\addkeyid2pot.pl ..\scripts\po2lo %_DEST%\bin\po2lo ..\scripts\propex %_DEST%\bin\propex +..\scripts\propmerge %_DEST%\bin\propmerge ..\inc\export.hxx %_DEST%\inc\l10ntools\export.hxx ..\inc\l10ntools\directory.hxx %_DEST%\inc\l10ntools\directory.hxx ..\inc\l10ntools\file.hxx %_DEST%\inc\l10ntools\file.hxx diff --git a/l10ntools/scripts/propex b/l10ntools/scripts/propex index e7ee7e9..ba7a49d 100755 --- a/l10ntools/scripts/propex +++ b/l10ntools/scripts/propex @@ -50,6 +50,8 @@ while (INFILE) { chomp; if (/=/) { my ($id, $value) = split /=/; +$id=~ s/^\s+//; #remove leading spaces +$id=~ s/\s+$//; #remove trailing spaces $value =~ s/^\s+//; #remove leading spaces $value =~ s/\s+$//; #remove trailing spaces $value =~ s/(\\u([0-9a-fA-F]{4}))/pack(C0U1,hex($2))/ge; #convert ascii escaped unicode to utf-8 diff --git a/l10ntools/scripts/propmerge b/l10ntools/scripts/propmerge new file mode 100755 index 000..1e0e8a7 --- /dev/null +++ b/l10ntools/scripts/propmerge @@ -0,0 +1,86 @@ +: +eval 'exec perl -S $0 ${1+$@}' +if 0; +# Version: MPL 1.1 / GPLv3+ / LGPLv3+ +# +# The contents of this file are subject to the Mozilla Public License Version +# 1.1 (the License); you may not use this file except in compliance with +# the License or as specified alternatively below. You may obtain a copy of +# the License at http://www.mozilla.org/MPL/ +# +# Software distributed under the License is distributed on an AS IS basis, +# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License +# for the specific language governing rights and limitations under the +# License. +# +# The Initial Developer of the Original Code is +# Andras Timar ati...@suse.com +# Portions created by the Initial Developer are Copyright (C) 2011 the +# Initial Developer. All Rights Reserved. +# +# Major Contributor(s): +# +# For minor contributions see the git repository. +# +# Alternatively, the contents of this file may be used under the terms of +# either the GNU General Public License Version 3 or later (the GPLv3+), or +# the GNU Lesser General Public License Version 3 or later (the LGPLv3+), +# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable +# instead of those above. +# +# merges strings from SDF file to properties files +# + +use strict; +use Getopt::Std; + +my %options=(); +getopts(i:m:, \%options); + +my %translations = (); +my %languages = (); + #( leftpart )( rightpart ) + # prj file dummy type gidlid helpid pform width lang text helptext qhelptext title +my $sdf_regex = ((([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t])*\t([^\t]*)\t([^\t]*))\t([^\t]*)\t(([^\t]*)\t([^\t]*)\t([^\t]*)\t([^\t]*))); + +open (SDFFILE, $options{m}) || die propmerge: cannot open sdf file: $options{m}; + +while (SDFFILE) { +chomp; +if( /$sdf_regex/ ) { + my $gid = defined $7 ? $7 : ''; + my $lang = defined $12 ? $12 : ''; + my $text = defined $14 ? $14 : ''; + my $key = $lang . $gid; +$languages{$lang} = 1; + utf8::decode($text); + $text =~ s/([^\x{20}-\x{7E}])/sprintf(\\u%04X,ord($1))/ge; + $translations{$key} = $text; +} +} + +close (SDFFILE); + +foreach my $lang (keys %languages) { +my $locfilename = $options{i}; +$locfilename =~ s/en_US\.properties/$lang.properties/; +open (INFILE, $options{i}) || die propmerge: cannot open source file: $options{i}; +open (OUTFILE, $locfilename) || die propmerge: cannot open output file: $locfilename; +while (INFILE) { +if (/=/) { + chomp; +my ($id, $value) = split /=/; +$id =~ s/^\s+//; #remove leading spaces +$id =~ s/\s+$//; #remove trailing spaces + my $key = $lang . $id; +print OUTFILE $id=$translations{$key}\n; + } + else { + print OUTFILE $_; + } +} +close (INFILE); +close (OUTFILE); +} + +exit 0; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/platform/WNT_INTEL_GCC.mk |2 +- solenv/gbuild/platform/unxgcc.mk|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 039fd52b968349da8687dae1aeb5b42e2830dfa2 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Dec 15 14:23:48 2011 +0100 fix one -ggdb3 that got in in a merge after 0b5b56be4df609d diff --git a/solenv/gbuild/platform/WNT_INTEL_GCC.mk b/solenv/gbuild/platform/WNT_INTEL_GCC.mk index 40027a1..5b49bff 100644 --- a/solenv/gbuild/platform/WNT_INTEL_GCC.mk +++ b/solenv/gbuild/platform/WNT_INTEL_GCC.mk @@ -97,7 +97,7 @@ ifeq ($(MINGW_GCCLIB_EH),YES) gb_LinkTarget_LDFLAGS += -shared-libgcc endif -gb_DEBUG_CFLAGS := -ggdb3 -finline-limit=0 -fno-inline -fno-default-inline +gb_DEBUG_CFLAGS := -ggdb2 -finline-limit=0 -fno-inline -fno-default-inline ifeq ($(HAVE_GCC_DWARF_4),TRUE) gb_DEBUG_CFLAGS += -gdwarf-4 endif diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk index 37c203f..851e020 100644 --- a/solenv/gbuild/platform/unxgcc.mk +++ b/solenv/gbuild/platform/unxgcc.mk @@ -161,7 +161,7 @@ gb_COMPILEROPTFLAGS := $(gb_COMPILERDEFAULTOPTFLAGS) gb_LINKEROPTFLAGS := -Wl,-O1 endif -gb_DEBUG_CFLAGS := -ggdb3 -finline-limit=0 -fno-inline -fno-default-inline +gb_DEBUG_CFLAGS := -ggdb2 -finline-limit=0 -fno-inline -fno-default-inline ifeq ($(HAVE_GCC_DWARF_4),TRUE) gb_DEBUG_CFLAGS += -gdwarf-4 endif ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: scp2/source
scp2/source/ooo/ure.scp |4 1 file changed, 4 insertions(+) New commits: commit 35c6f50eab69968fb02512fe0e89800f52702efd Author: Stephan Bergmann sberg...@redhat.com Date: Thu Dec 15 15:08:33 2011 +0100 Potential fix for gbuild salhelper on MinGW problem. diff --git a/scp2/source/ooo/ure.scp b/scp2/source/ooo/ure.scp index aece726..18df366 100644 --- a/scp2/source/ooo/ure.scp +++ b/scp2/source/ooo/ure.scp @@ -252,7 +252,11 @@ End File gid_File_Dl_Salhelper LIB_FILE_BODY; Dir = SCP2_URE_DL_DIR; +#if defined WNT !defined _MSC // Hack for gbuild'ified salhelper on MinGW: +Name = uno_salhelpergcc3.dll +#else Name = SCP2_URE_DL_UNO_COMID_VER(salhelper, 3); +#endif Styles = (PACKED, VERSION_INDEPENDENT_COMP_ID); // CompID = 879B80E0-F6E1-4931-8EE6-7CF867CB6AA5; End ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - connectivity/source download
connectivity/source/drivers/postgresql/makefile.mk | 11 ++- download |3 ++- 2 files changed, 4 insertions(+), 10 deletions(-) New commits: commit 968dee3f4e392753d1663d8a5fc2f73e696003e1 Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Thu Dec 15 15:36:30 2011 +0100 -Wl,-dead_strip_dylibs is not supported with XCode 2.5, align with master diff --git a/connectivity/source/drivers/postgresql/makefile.mk b/connectivity/source/drivers/postgresql/makefile.mk index c99deae..cc6a4df 100644 --- a/connectivity/source/drivers/postgresql/makefile.mk +++ b/connectivity/source/drivers/postgresql/makefile.mk @@ -91,16 +91,9 @@ LIBPQ_DEP_LIBS+=\ .ENDIF .ELSE LIBPQ_LINK=$(OUTDIR)/lib/libpq.a -.IF $(OS)==MACOSX -LIBPQ_DEP_LIBS += -Wl,-dead_strip_dylibs -.ELSE -LIBPQ_DEP_LIBS += -Wl,--as-needed -.ENDIF +LIBPQ_DEP_LIBS+=$(eq,$(OS),MACOSX $(NULL) -Wl,--as-needed) .INCLUDE : $(OUTDIR_FOR_BUILD)/inc/postgresql/libpq-flags.mk -.IF $(OS)==MACOSX -.ELSE -LIBPQ_DEP_LIBS += -Wl,--no-as-needed -.ENDIF +LIBPQ_DEP_LIBS+=$(eq,$(OS),MACOSX $(NULL) -Wl,--no-as-needed) .ENDIF POSTGRESQL_INC=-I$(OUTDIR)/inc/postgresql POSTGRESQL_LIB= commit c3add9d8919a8d10a695cb69c513d94aa1a8f757 Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Thu Dec 15 14:18:19 2011 +0100 when using linked git, use the same branch as the main repo diff --git a/download b/download index c889a46..cf9f8c1 100755 --- a/download +++ b/download @@ -52,8 +52,9 @@ if [ -d .git ] ; then else # space-saving clone from another local workdir mkdir clone +branch=$(git symbolic-ref HEAD | cut -d/ -f 3) for i in $GIT_REPO_NAMES ; do -bin/git-new-workdir $GIT_LINK_SRC/$i clone/$i +bin/git-new-workdir $GIT_LINK_SRC/$i clone/$i $branch for d in clone/$i/* ; do if [ ${d} != clone/$i/git-hooks ]; then ln -sfn ${d} $(basename ${d}) ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/filter/excel/impop.cxx |4 1 file changed, 4 insertions(+) New commits: commit cb010c378dfb60fa82a3dfbcd1bcd20e5b26df48 Author: Muthu Subramanian sumu...@suse.com Date: Thu Dec 15 16:49:52 2011 +0530 fdo#33747: Row Height is unnecessarily large. diff --git a/sc/source/filter/excel/impop.cxx b/sc/source/filter/excel/impop.cxx index 3c96481..533bbb9 100644 --- a/sc/source/filter/excel/impop.cxx +++ b/sc/source/filter/excel/impop.cxx @@ -937,6 +937,10 @@ void ImportExcel::Row34( void ) aIn nRowHeight; // direkt in Twips angegeben aIn.Ignore( 4 ); +nRowHeight = nRowHeight 0x7FFF; // Bit 15: Row Height not changed manually +if( !nRowHeight ) +nRowHeight = (GetBiff() == EXC_BIFF2) ? 0x25 : 0x225; + aIn nGrbit nXF; sal_uInt8 nLevel = ::extract_value sal_uInt8 ( nGrbit, 0, 3 ); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/XMLStylesExportHelper.cxx | 85 + 1 file changed, 72 insertions(+), 13 deletions(-) New commits: commit 6198fcd7064180a0bf8a6d67f63f784610aa9ba8 Author: Eike Rathke er...@redhat.com Date: Thu Dec 15 16:08:52 2011 +0100 Resolves fdo#43725 crash on saving a file + Checks out-of-bounds accesses in ScFormatRangeStyles::GetStyleNameIndex() and ScRowFormatRanges::AddRange() and prevents crashes. - The real cause seems to be some style row/repeat miscalculation elsewhere, further investigation would be necessary. diff --git a/sc/source/filter/xml/XMLStylesExportHelper.cxx b/sc/source/filter/xml/XMLStylesExportHelper.cxx index 83a3fca..1c7897f 100644 --- a/sc/source/filter/xml/XMLStylesExportHelper.cxx +++ b/sc/source/filter/xml/XMLStylesExportHelper.cxx @@ -677,10 +677,35 @@ void ScRowFormatRanges::AddRange(ScMyRowFormatRange rFormatRange, const sal_Int32 nRow) { OSL_ENSURE(pRowDefaults, no row defaults); +if (!pRowDefaults) +return; OSL_ENSURE(pColDefaults, no column defaults); +if (!pColDefaults) +return; +sal_Int32 nPrevIndex; +bool bPrevAutoStyle; +OSL_ENSURE( static_castsize_t(nRow) pRowDefaults-size(), nRow out of bounds); +if (!(static_castsize_t(nRow) pRowDefaults-size())) +{ +/* This is only to prevent out-of-bounds accesses, once reached here + * there's something else going wrong, so FIXME there! */ +if (pRowDefaults-empty()) +{ +nPrevIndex = -1; +bPrevAutoStyle = false; +} +else +{ +nPrevIndex = (*pRowDefaults)[pRowDefaults-size()-1].nIndex; +bPrevAutoStyle = (*pRowDefaults)[pRowDefaults-size()-1].bIsAutoStyle; +} +} +else +{ +nPrevIndex = (*pRowDefaults)[nRow].nIndex; +bPrevAutoStyle = (*pRowDefaults)[nRow].bIsAutoStyle; +} sal_uInt32 nEnd (rFormatRange.nRepeatRows + nRow - 1); -sal_Int32 nPrevIndex((*pRowDefaults)[nRow].nIndex); -bool bPrevAutoStyle((*pRowDefaults)[nRow].bIsAutoStyle); sal_uInt32 i(nRow + 1); bool bReady(false); while ((i nEnd) !bReady (i pRowDefaults-size())) @@ -697,12 +722,34 @@ void ScRowFormatRanges::AddRange(ScMyRowFormatRange rFormatRange, rFormatRange.nRepeatRows = i - nRow + 1; if (nPrevIndex == -1) { -nPrevIndex = (*pColDefaults)[rFormatRange.nStartColumn].nIndex; -bPrevAutoStyle = (*pColDefaults)[rFormatRange.nStartColumn].bIsAutoStyle; sal_uInt32 nPrevStartCol(rFormatRange.nStartColumn); -sal_uInt32 nRepeat((*pColDefaults)[rFormatRange.nStartColumn].nRepeat); -nEnd = rFormatRange.nStartColumn + rFormatRange.nRepeatColumns; -for(i = nPrevStartCol + nRepeat; i nEnd; i += (*pColDefaults)[i].nRepeat) +OSL_ENSURE( static_castsize_t(nPrevStartCol) pColDefaults-size(), nPrevStartCol out of bounds); +sal_uInt32 nRepeat; +if (static_castsize_t(nPrevStartCol) pColDefaults-size()) +{ +nRepeat = (*pColDefaults)[nPrevStartCol].nRepeat; +nPrevIndex = (*pColDefaults)[nPrevStartCol].nIndex; +bPrevAutoStyle = (*pColDefaults)[nPrevStartCol].bIsAutoStyle; +} +else +{ +/* Again, this is to prevent out-of-bounds accesses, so FIXME + * elsewhere! */ +if (pColDefaults-empty()) +{ +nRepeat = 1; +nPrevIndex = -1; +bPrevAutoStyle = false; +} +else +{ +nRepeat = (*pColDefaults)[pColDefaults-size()-1].nRepeat; +nPrevIndex = (*pColDefaults)[pColDefaults-size()-1].nIndex; +bPrevAutoStyle = (*pColDefaults)[pColDefaults-size()-1].bIsAutoStyle; +} +} +nEnd = nPrevStartCol + rFormatRange.nRepeatColumns; +for(i = nPrevStartCol + nRepeat; i nEnd i pColDefaults-size(); i += (*pColDefaults)[i].nRepeat) { OSL_ENSURE(sal_uInt32(nPrevStartCol + nRepeat) = nEnd, something wents wrong); if ((nPrevIndex != (*pColDefaults)[i].nIndex) || @@ -923,6 +970,8 @@ sal_Int32 ScFormatRangeStyles::GetStyleNameIndex(const sal_Int32 nTable, const sal_Int32 nColumn, const sal_Int32 nRow, bool bIsAutoStyle) const { OSL_ENSURE(static_castsize_t(nTable) aTables.size(), wrong table); +if (!(static_castsize_t(nTable) aTables.size())) +return -1; ScMyFormatRangeAddresses* pFormatRanges(aTables[nTable]); ScMyFormatRangeAddresses::iterator aItr(pFormatRanges-begin()); ScMyFormatRangeAddresses::iterator aEndItr(pFormatRanges-end()); @@ -946,6 +995,8 @@ sal_Int32 ScFormatRangeStyles::GetStyleNameIndex(const sal_Int32 nTable, const s bool bIsAutoStyle, sal_Int32 nValidationIndex, sal_Int32 nNumberFormat, const sal_Int32 nRemoveBeforeRow) {
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/filter/xml/XMLStylesExportHelper.cxx | 85 + 1 file changed, 72 insertions(+), 13 deletions(-) New commits: commit 4362f16588dd5937dedd4922af1714aa949ecdba Author: Eike Rathke er...@redhat.com Date: Thu Dec 15 16:09:30 2011 +0100 Resolves fdo#43725 crash on saving a file + Checks out-of-bounds accesses in ScFormatRangeStyles::GetStyleNameIndex() and ScRowFormatRanges::AddRange() and prevents crashes. - The real cause seems to be some style row/repeat miscalculation elsewhere, further investigation would be necessary. diff --git a/sc/source/filter/xml/XMLStylesExportHelper.cxx b/sc/source/filter/xml/XMLStylesExportHelper.cxx index 83a3fca..1c7897f 100644 --- a/sc/source/filter/xml/XMLStylesExportHelper.cxx +++ b/sc/source/filter/xml/XMLStylesExportHelper.cxx @@ -677,10 +677,35 @@ void ScRowFormatRanges::AddRange(ScMyRowFormatRange rFormatRange, const sal_Int32 nRow) { OSL_ENSURE(pRowDefaults, no row defaults); +if (!pRowDefaults) +return; OSL_ENSURE(pColDefaults, no column defaults); +if (!pColDefaults) +return; +sal_Int32 nPrevIndex; +bool bPrevAutoStyle; +OSL_ENSURE( static_castsize_t(nRow) pRowDefaults-size(), nRow out of bounds); +if (!(static_castsize_t(nRow) pRowDefaults-size())) +{ +/* This is only to prevent out-of-bounds accesses, once reached here + * there's something else going wrong, so FIXME there! */ +if (pRowDefaults-empty()) +{ +nPrevIndex = -1; +bPrevAutoStyle = false; +} +else +{ +nPrevIndex = (*pRowDefaults)[pRowDefaults-size()-1].nIndex; +bPrevAutoStyle = (*pRowDefaults)[pRowDefaults-size()-1].bIsAutoStyle; +} +} +else +{ +nPrevIndex = (*pRowDefaults)[nRow].nIndex; +bPrevAutoStyle = (*pRowDefaults)[nRow].bIsAutoStyle; +} sal_uInt32 nEnd (rFormatRange.nRepeatRows + nRow - 1); -sal_Int32 nPrevIndex((*pRowDefaults)[nRow].nIndex); -bool bPrevAutoStyle((*pRowDefaults)[nRow].bIsAutoStyle); sal_uInt32 i(nRow + 1); bool bReady(false); while ((i nEnd) !bReady (i pRowDefaults-size())) @@ -697,12 +722,34 @@ void ScRowFormatRanges::AddRange(ScMyRowFormatRange rFormatRange, rFormatRange.nRepeatRows = i - nRow + 1; if (nPrevIndex == -1) { -nPrevIndex = (*pColDefaults)[rFormatRange.nStartColumn].nIndex; -bPrevAutoStyle = (*pColDefaults)[rFormatRange.nStartColumn].bIsAutoStyle; sal_uInt32 nPrevStartCol(rFormatRange.nStartColumn); -sal_uInt32 nRepeat((*pColDefaults)[rFormatRange.nStartColumn].nRepeat); -nEnd = rFormatRange.nStartColumn + rFormatRange.nRepeatColumns; -for(i = nPrevStartCol + nRepeat; i nEnd; i += (*pColDefaults)[i].nRepeat) +OSL_ENSURE( static_castsize_t(nPrevStartCol) pColDefaults-size(), nPrevStartCol out of bounds); +sal_uInt32 nRepeat; +if (static_castsize_t(nPrevStartCol) pColDefaults-size()) +{ +nRepeat = (*pColDefaults)[nPrevStartCol].nRepeat; +nPrevIndex = (*pColDefaults)[nPrevStartCol].nIndex; +bPrevAutoStyle = (*pColDefaults)[nPrevStartCol].bIsAutoStyle; +} +else +{ +/* Again, this is to prevent out-of-bounds accesses, so FIXME + * elsewhere! */ +if (pColDefaults-empty()) +{ +nRepeat = 1; +nPrevIndex = -1; +bPrevAutoStyle = false; +} +else +{ +nRepeat = (*pColDefaults)[pColDefaults-size()-1].nRepeat; +nPrevIndex = (*pColDefaults)[pColDefaults-size()-1].nIndex; +bPrevAutoStyle = (*pColDefaults)[pColDefaults-size()-1].bIsAutoStyle; +} +} +nEnd = nPrevStartCol + rFormatRange.nRepeatColumns; +for(i = nPrevStartCol + nRepeat; i nEnd i pColDefaults-size(); i += (*pColDefaults)[i].nRepeat) { OSL_ENSURE(sal_uInt32(nPrevStartCol + nRepeat) = nEnd, something wents wrong); if ((nPrevIndex != (*pColDefaults)[i].nIndex) || @@ -923,6 +970,8 @@ sal_Int32 ScFormatRangeStyles::GetStyleNameIndex(const sal_Int32 nTable, const sal_Int32 nColumn, const sal_Int32 nRow, bool bIsAutoStyle) const { OSL_ENSURE(static_castsize_t(nTable) aTables.size(), wrong table); +if (!(static_castsize_t(nTable) aTables.size())) +return -1; ScMyFormatRangeAddresses* pFormatRanges(aTables[nTable]); ScMyFormatRangeAddresses::iterator aItr(pFormatRanges-begin()); ScMyFormatRangeAddresses::iterator aEndItr(pFormatRanges-end()); @@ -946,6 +995,8 @@ sal_Int32 ScFormatRangeStyles::GetStyleNameIndex(const sal_Int32 nTable, const s bool bIsAutoStyle, sal_Int32 nValidationIndex, sal_Int32 nNumberFormat, const sal_Int32 nRemoveBeforeRow) {
[Libreoffice-commits] .: basctl/source
basctl/source/basicide/scriptdocument.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f269629d1b0182d89b2f5a769fbb0f8dcb815ec3 Author: Noel Power noel.po...@novell.com Date: Thu Dec 15 15:13:04 2011 + fix mistaken String::CreateFromInt32 - OUString::valueOf conversion diff --git a/basctl/source/basicide/scriptdocument.cxx b/basctl/source/basicide/scriptdocument.cxx index e75affa..a194029 100644 --- a/basctl/source/basicide/scriptdocument.cxx +++ b/basctl/source/basicide/scriptdocument.cxx @@ -1311,7 +1311,7 @@ namespace basctl ::std::insert_iterator ::std::set ::rtl::OUString ( aUsedNamesCheck, aUsedNamesCheck.begin() ) ); bool bValid = false; -sal_uInt16 i = 1; +sal_Int32 i = 1; while ( !bValid ) { aObjectName = aBaseName; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in set_soenv.in solenv/gbuild
configure.in| 18 -- set_soenv.in|1 - solenv/gbuild/platform/WNT_INTEL_GCC.mk |7 --- solenv/gbuild/platform/unxgcc.mk|7 --- 4 files changed, 33 deletions(-) New commits: commit e87fc0bfde8bd48b449e123c1bdd28e1359e8c77 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu Dec 15 16:59:17 2011 +0100 Revert enable -gdwarf-4 by default if possible It turns out even quite recent gdb (7.1) reportedly does not support DWARF4, moreover while the produced binaries are smaller, faster and make gdb initially use less memory, this quickly ceases to the case as soon as one actually does anything in gdb. Presumably the DWARF4 handling in current gdb is very inefficient (http://sourceware.org/bugzilla/show_bug.cgi?id=13498). This reverts commit 5214f7843ca48f2207945fbfe32ba164afe7b3aa. Conflicts: solenv/gbuild/platform/WNT_INTEL_GCC.mk solenv/gbuild/platform/unxgcc.mk diff --git a/configure.in b/configure.in index 59cb7fb..354fa52 100644 --- a/configure.in +++ b/configure.in @@ -3824,24 +3824,6 @@ AC_SUBST(HAVE_GCC_VISIBILITY_FEATURE) AC_SUBST(HAVE_GCC_VISIBILITY_BROKEN) dnl === -dnl gcc DWARF-4 support (smaller debug info) -dnl === -if test $GCC = yes; then -AC_MSG_CHECKING([whether $CC supports -gdwarf-4]) -save_CFLAGS=$CFLAGS -CFLAGS=$CFLAGS -Werror -gdwarf-4 -AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],[ HAVE_GCC_DWARF_4=TRUE ],[]) -CFLAGS=$save_CFLAGS -if test $HAVE_GCC_DWARF_4 = TRUE; then -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi -fi - -AC_SUBST(HAVE_GCC_DWARF_4) - -dnl === dnl allocator dnl === AC_MSG_CHECKING([which memory allocator to use]) diff --git a/set_soenv.in b/set_soenv.in index 2150be5..1506366 100755 --- a/set_soenv.in +++ b/set_soenv.in @@ -1700,7 +1700,6 @@ ToFile( HAVE_GCC_VISIBILITY_FEATURE, @HAVE_GCC_VISIBILITY_FEATURE@, e ); ToFile( HAVE_GCC_VISIBILITY_BROKEN, @HAVE_GCC_VISIBILITY_BROKEN@, e ); -ToFile( HAVE_GCC_DWARF_4,@HAVE_GCC_DWARF_4@,e ); ToFile( HAVE_LD_HASH_STYLE,@HAVE_LD_HASH_STYLE@,e ); ToFile( WITH_LINKER_HASH_STYLE,@WITH_LINKER_HASH_STYLE@,e ); ToFile( HAVE_LD_BSYMBOLIC_FUNCTIONS, diff --git a/solenv/gbuild/platform/WNT_INTEL_GCC.mk b/solenv/gbuild/platform/WNT_INTEL_GCC.mk index 5b49bff..c7387e9 100644 --- a/solenv/gbuild/platform/WNT_INTEL_GCC.mk +++ b/solenv/gbuild/platform/WNT_INTEL_GCC.mk @@ -98,9 +98,6 @@ gb_LinkTarget_LDFLAGS += -shared-libgcc endif gb_DEBUG_CFLAGS := -ggdb2 -finline-limit=0 -fno-inline -fno-default-inline -ifeq ($(HAVE_GCC_DWARF_4),TRUE) -gb_DEBUG_CFLAGS += -gdwarf-4 -endif gb_STDLIBS := \ mingwthrd \ @@ -154,10 +151,6 @@ gb_LinkTarget_CXXFLAGS := $(gb_CXXFLAGS) $(gb_CXXFLAGS_WERROR) ifeq ($(gb_SYMBOL),$(true)) gb_LinkTarget_CXXFLAGS += -ggdb2 gb_LinkTarget_CFLAGS += -ggdb2 -ifeq ($(HAVE_GCC_DWARF_4),TRUE) -gb_LinkTarget_CXXFLAGS += -gdwarf-4 -gb_LinkTarget_CFLAGS += -gdwarf-4 -endif endif gb_LinkTarget_INCLUDE +=\ diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk index 851e020..4b80cee 100644 --- a/solenv/gbuild/platform/unxgcc.mk +++ b/solenv/gbuild/platform/unxgcc.mk @@ -162,9 +162,6 @@ gb_LINKEROPTFLAGS := -Wl,-O1 endif gb_DEBUG_CFLAGS := -ggdb2 -finline-limit=0 -fno-inline -fno-default-inline -ifeq ($(HAVE_GCC_DWARF_4),TRUE) -gb_DEBUG_CFLAGS += -gdwarf-4 -endif gb_COMPILERNOOPTFLAGS := -O0 @@ -209,10 +206,6 @@ gb_LinkTarget_CXXFLAGS := $(gb_CXXFLAGS) $(gb_CXXFLAGS_WERROR) ifeq ($(gb_SYMBOL),$(true)) gb_LinkTarget_CXXFLAGS += -ggdb2 gb_LinkTarget_CFLAGS += -ggdb2 -ifeq ($(HAVE_GCC_DWARF_4),TRUE) -gb_LinkTarget_CXXFLAGS += -gdwarf-4 -gb_LinkTarget_CFLAGS += -gdwarf-4 -endif endif # note that `cat $(extraobjectlist)` is needed to build with older gcc versions, e.g. 4.1.2 on SLED10 ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - connectivity/source lingucomponent/source sdext/source ucb/source
connectivity/source/drivers/mozab/makefile.mk |8 connectivity/source/drivers/mozab/mozabdrv.map |8 lingucomponent/source/languageguessing/makefile.mk |7 +-- sdext/source/pdfimport/makefile.mk |4 sdext/source/presenter/makefile.mk |4 ucb/source/ucp/cmis/makefile.mk|4 6 files changed, 33 insertions(+), 2 deletions(-) New commits: commit deb6451f3bbc44afe4a798e0fd28ab395bea840a Author: Michael Stahl mst...@redhat.com Date: Thu Dec 15 15:44:24 2011 +0100 fdo#43707: tweak workarounds for fdo#42865: Apparently on Windows the SAL_DLLPUBLIC_EXPORT does not work for unknown reasons, so use the old mapfiles on that platform. Should fix regressions from 5f1799f5. diff --git a/lingucomponent/source/languageguessing/makefile.mk b/lingucomponent/source/languageguessing/makefile.mk index a99e1f4..2e2e22e 100644 --- a/lingucomponent/source/languageguessing/makefile.mk +++ b/lingucomponent/source/languageguessing/makefile.mk @@ -70,13 +70,16 @@ SHL1STDLIBS= \ $(UNOTOOLSLIB) # build DLL +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/component.map +.ELSE # just a quick hack for GCC fdo#42865 +SHL1USE_EXPORTS = name +.ENDIF SHL1LIBS= $(SLB)$/$(TARGET).lib SHL1IMPLIB= i$(TARGET) SHL1DEPN= $(SHL1LIBS) SHL1DEF=$(MISC)$/$(SHL1TARGET).def -SHL1VERSIONMAP=$(SOLARENV)/src/component.map - # build DEF file DEF1NAME=$(SHL1TARGET) DEF1EXPORTFILE= exports.dxp commit 7eaf07eea371fadbc48c4d59c8b49bf8daf2eb6a Author: Michael Stahl mst...@redhat.com Date: Thu Dec 15 14:32:40 2011 +0100 fdo#43707: tweak workarounds for fdo#42865: Apparently on Windows the SAL_DLLPUBLIC_EXPORT does not work for unknown reasons, so use the old mapfiles on that platform. Should fix regressions from 1fb5eb21, 48dbaa51, a9da5a0b. (cherry picked from commit 5bb7eea39420c79ee72b7559f4e3d90d1abb4994) diff --git a/connectivity/source/drivers/mozab/makefile.mk b/connectivity/source/drivers/mozab/makefile.mk index 07e6dcc..d1d4873 100755 --- a/connectivity/source/drivers/mozab/makefile.mk +++ b/connectivity/source/drivers/mozab/makefile.mk @@ -85,7 +85,11 @@ SLOFILES=\ # --- MOZAB BASE Library --- +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1TARGET=$(TARGET)$(DLLPOSTFIX) SHL1OBJS=$(SLOFILES) SHL1STDLIBS=\ @@ -145,7 +149,11 @@ DEPOBJFILES=$(SLO2FILES) # --- MOZAB BASE Library --- +.IF $(GUI)==WNT +SHL2VERSIONMAP=$(TARGET2).map +.ELSE # just a quick hack for GCC fdo#42865 SHL2USE_EXPORTS = name +.ENDIF SHL2NOCHECK=TRUE SHL2TARGET=$(TARGET2)$(DLLPOSTFIX) SHL2OBJS=$(SLO2FILES) diff --git a/connectivity/source/drivers/mozab/mozabdrv.map b/connectivity/source/drivers/mozab/mozabdrv.map new file mode 100644 index 000..a431a07 --- /dev/null +++ b/connectivity/source/drivers/mozab/mozabdrv.map @@ -0,0 +1,8 @@ +UDK_3_0_0 { +global: +OMozabConnection_CreateInstance; +OMozillaBootstrap_CreateInstance; +setMozabServiceFactory; +local: +*; +}; diff --git a/sdext/source/pdfimport/makefile.mk b/sdext/source/pdfimport/makefile.mk index 9262ef6..641e90f 100644 --- a/sdext/source/pdfimport/makefile.mk +++ b/sdext/source/pdfimport/makefile.mk @@ -91,7 +91,11 @@ SHL1STDLIBS=\ SHL1DEPN= SHL1IMPLIB=i$(SHL1TARGET) SHL1DEF= $(MISC)$/$(SHL1TARGET).def +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/reg-component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1RPATH=OXT DEF1NAME=$(SHL1TARGET) diff --git a/sdext/source/presenter/makefile.mk b/sdext/source/presenter/makefile.mk index a0d8d0f..5606c42 100644 --- a/sdext/source/presenter/makefile.mk +++ b/sdext/source/presenter/makefile.mk @@ -109,7 +109,11 @@ SHL1DEPN= SHL1IMPLIB=i$(SHL1TARGET) SHL1LIBS= $(SLB)$/$(TARGET).lib SHL1DEF= $(MISC)$/$(SHL1TARGET).def +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/reg-component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1RPATH= OXT DEF1NAME= $(SHL1TARGET) diff --git a/ucb/source/ucp/cmis/makefile.mk b/ucb/source/ucp/cmis/makefile.mk index be4a36c..1af7c20 100644 --- a/ucb/source/ucp/cmis/makefile.mk +++ b/ucb/source/ucp/cmis/makefile.mk @@ -71,7 +71,11 @@ SHL1STDLIBS = \ SHL1TARGET = $(TARGET) +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1DEPN = SHL1IMPLIB = i$(TARGET) SHL1LIBS = $(SLB)$/$(TARGET).lib ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org
[Libreoffice-commits] .: connectivity/source sdext/source ucb/source
connectivity/source/drivers/mozab/makefile.mk |8 connectivity/source/drivers/mozab/mozabdrv.map |8 sdext/source/pdfimport/makefile.mk |4 sdext/source/presenter/makefile.mk |4 ucb/source/ucp/cmis/makefile.mk|4 5 files changed, 28 insertions(+) New commits: commit 6fd2d815174df8274153ddb7e99eab26ab7e563c Author: Michael Stahl mst...@redhat.com Date: Thu Dec 15 14:32:40 2011 +0100 fdo#43707: tweak workarounds for fdo#42865: Apparently on Windows the SAL_DLLPUBLIC_EXPORT does not work for unknown reasons, so use the old mapfiles on that platform. Should fix regressions from 1fb5eb21, 48dbaa51, a9da5a0b. diff --git a/connectivity/source/drivers/mozab/makefile.mk b/connectivity/source/drivers/mozab/makefile.mk index 07e6dcc..d1d4873 100755 --- a/connectivity/source/drivers/mozab/makefile.mk +++ b/connectivity/source/drivers/mozab/makefile.mk @@ -85,7 +85,11 @@ SLOFILES=\ # --- MOZAB BASE Library --- +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1TARGET=$(TARGET)$(DLLPOSTFIX) SHL1OBJS=$(SLOFILES) SHL1STDLIBS=\ @@ -145,7 +149,11 @@ DEPOBJFILES=$(SLO2FILES) # --- MOZAB BASE Library --- +.IF $(GUI)==WNT +SHL2VERSIONMAP=$(TARGET2).map +.ELSE # just a quick hack for GCC fdo#42865 SHL2USE_EXPORTS = name +.ENDIF SHL2NOCHECK=TRUE SHL2TARGET=$(TARGET2)$(DLLPOSTFIX) SHL2OBJS=$(SLO2FILES) diff --git a/connectivity/source/drivers/mozab/mozabdrv.map b/connectivity/source/drivers/mozab/mozabdrv.map new file mode 100644 index 000..a431a07 --- /dev/null +++ b/connectivity/source/drivers/mozab/mozabdrv.map @@ -0,0 +1,8 @@ +UDK_3_0_0 { +global: +OMozabConnection_CreateInstance; +OMozillaBootstrap_CreateInstance; +setMozabServiceFactory; +local: +*; +}; diff --git a/sdext/source/pdfimport/makefile.mk b/sdext/source/pdfimport/makefile.mk index 9262ef6..641e90f 100644 --- a/sdext/source/pdfimport/makefile.mk +++ b/sdext/source/pdfimport/makefile.mk @@ -91,7 +91,11 @@ SHL1STDLIBS=\ SHL1DEPN= SHL1IMPLIB=i$(SHL1TARGET) SHL1DEF= $(MISC)$/$(SHL1TARGET).def +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/reg-component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1RPATH=OXT DEF1NAME=$(SHL1TARGET) diff --git a/sdext/source/presenter/makefile.mk b/sdext/source/presenter/makefile.mk index 6d9e5bb..7d74d96 100644 --- a/sdext/source/presenter/makefile.mk +++ b/sdext/source/presenter/makefile.mk @@ -108,7 +108,11 @@ SHL1DEPN= SHL1IMPLIB=i$(SHL1TARGET) SHL1LIBS= $(SLB)$/$(TARGET).lib SHL1DEF= $(MISC)$/$(SHL1TARGET).def +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/reg-component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1RPATH= OXT DEF1NAME= $(SHL1TARGET) diff --git a/ucb/source/ucp/cmis/makefile.mk b/ucb/source/ucp/cmis/makefile.mk index a99d638..4170bba 100644 --- a/ucb/source/ucp/cmis/makefile.mk +++ b/ucb/source/ucp/cmis/makefile.mk @@ -70,7 +70,11 @@ SHL1STDLIBS = \ SHL1TARGET = $(TARGET) +.IF $(GUI)==WNT +SHL1VERSIONMAP=$(SOLARENV)/src/component.map +.ELSE # just a quick hack for GCC fdo#42865 SHL1USE_EXPORTS = name +.ENDIF SHL1DEPN = SHL1IMPLIB = i$(TARGET) SHL1LIBS = $(SLB)$/$(TARGET).lib ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source unusedcode.easy
sc/source/ui/app/inputwin.cxx |7 --- sc/source/ui/inc/inputwin.hxx |1 - unusedcode.easy |1 - 3 files changed, 9 deletions(-) New commits: commit 63a817d2fb00f248053566c8b8364667432fa8b3 Author: Noel Power noel.po...@novell.com Date: Wed Dec 14 14:02:29 2011 + remove unused ScInputBarGroup::GainFocus diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx index 2588cae..1793fae 100644 --- a/sc/source/ui/app/inputwin.cxx +++ b/sc/source/ui/app/inputwin.cxx @@ -987,13 +987,6 @@ void ScInputBarGroup::Resize() Invalidate(); } - -void ScInputBarGroup::GainFocus() -{ -aMultiTextWnd.GrabFocus(); -} - - void ScInputBarGroup::StopEditEngine( sal_Bool bAll ) { aMultiTextWnd.StopEditEngine( bAll ); diff --git a/sc/source/ui/inc/inputwin.hxx b/sc/source/ui/inc/inputwin.hxx index 1f200c1..7b5bc28 100644 --- a/sc/source/ui/inc/inputwin.hxx +++ b/sc/source/ui/inc/inputwin.hxx @@ -223,7 +223,6 @@ public: virtual const String GetTextString() const; virtual voidStopEditEngine( sal_Bool bAll ); voidInitEditEngine(SfxObjectShell* pObjSh); -voidGainFocus(); voidSetFormulaMode( sal_Bool bSet ); boolIsFocus(); voidMakeDialogEditView(); diff --git a/unusedcode.easy b/unusedcode.easy index 47b983a..7b36792 100644 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -349,7 +349,6 @@ ScHTMLColOffset_SAR::Replace(unsigned long const, unsigned short) ScHTMLColOffset_SAR::Replace(unsigned long const*, unsigned short, unsigned short) ScHTMLColOffset_SAR::_ForEach(unsigned short, unsigned short, unsigned char (*)(unsigned long const, void*), void*) ScHorizontalValueIterator::GetCurNumFmtInfo(short, unsigned long) -ScInputBarGroup::GainFocus() ScJobSetup::ScJobSetup(SfxPrinter*) ScLeftFooterEditPage::GetRanges() ScLeftHeaderEditPage::GetRanges() ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - sc/source unusedcode.easy
sc/source/ui/app/inputwin.cxx | 10 +++--- sc/source/ui/inc/inputwin.hxx |1 - unusedcode.easy |1 - 3 files changed, 3 insertions(+), 9 deletions(-) New commits: commit 9cd03b7a91c63066cb061966b474ee736ceddbdd Author: Noel Power noel.po...@novell.com Date: Wed Dec 14 14:02:29 2011 + remove unused ScInputBarGroup::GainFocus diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx index 2588cae..1793fae 100644 --- a/sc/source/ui/app/inputwin.cxx +++ b/sc/source/ui/app/inputwin.cxx @@ -987,13 +987,6 @@ void ScInputBarGroup::Resize() Invalidate(); } - -void ScInputBarGroup::GainFocus() -{ -aMultiTextWnd.GrabFocus(); -} - - void ScInputBarGroup::StopEditEngine( sal_Bool bAll ) { aMultiTextWnd.StopEditEngine( bAll ); diff --git a/sc/source/ui/inc/inputwin.hxx b/sc/source/ui/inc/inputwin.hxx index 1f200c1..7b5bc28 100644 --- a/sc/source/ui/inc/inputwin.hxx +++ b/sc/source/ui/inc/inputwin.hxx @@ -223,7 +223,6 @@ public: virtual const String GetTextString() const; virtual voidStopEditEngine( sal_Bool bAll ); voidInitEditEngine(SfxObjectShell* pObjSh); -voidGainFocus(); voidSetFormulaMode( sal_Bool bSet ); boolIsFocus(); voidMakeDialogEditView(); diff --git a/unusedcode.easy b/unusedcode.easy index b6db194..7ef3336 100644 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -392,7 +392,6 @@ ScHTMLColOffset_SAR::Replace(unsigned long const, unsigned short) ScHTMLColOffset_SAR::Replace(unsigned long const*, unsigned short, unsigned short) ScHTMLColOffset_SAR::_ForEach(unsigned short, unsigned short, unsigned char (*)(unsigned long const, void*), void*) ScHorizontalValueIterator::GetCurNumFmtInfo(short, unsigned long) -ScInputBarGroup::GainFocus() ScJobSetup::ScJobSetup(SfxPrinter*) ScLeftFooterEditPage::GetRanges() ScLeftHeaderEditPage::GetRanges() commit ea925e2415bb751488f510ca48b96d5702fa87f9 Author: Noel Power noel.po...@novell.com Date: Wed Dec 14 12:49:28 2011 + if editing in formulabar restore focus to inputline after expand/collapse diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx index b9ab412..2588cae 100644 --- a/sc/source/ui/app/inputwin.cxx +++ b/sc/source/ui/app/inputwin.cxx @@ -1061,6 +1061,9 @@ IMPL_LINK( ScInputBarGroup, ClickHdl, PushButton*, EMPTYARG ) aMultiTextWnd.SetNumLines( aMultiTextWnd.GetLastNumExpandedLines() ); } TriggerToolboxLayout(); +// Restore focus to input line(s) if necessary +if ( SC_MOD()-GetInputHdl()-IsTopMode() ) +aMultiTextWnd.GrabFocus(); return 0; } ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/Module_sc.mk
sc/Module_sc.mk |4 1 file changed, 4 deletions(-) New commits: commit c01ed69703a41e94f553ede40487407a0ad1da4e Author: Michael Meeks michael.me...@suse.com Date: Thu Dec 15 17:39:01 2011 + revert erroneous move of subsequenttests into normal unit tests diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk index fecc4a4..9c8696b 100644 --- a/sc/Module_sc.mk +++ b/sc/Module_sc.mk @@ -37,10 +37,6 @@ $(eval $(call gb_Module_add_targets,sc,\ $(eval $(call gb_Module_add_check_targets,sc,\ CppunitTest_sc_filters_test \ CppunitTest_sc_ucalc \ -CppunitTest_sc_macros_test \ -CppunitTest_sc_cellrangesbase \ -CppunitTest_sc_subsequent_filters_test \ -CppunitTest_sc_tableautoformatfield \ )) $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in postgresql/makefile.mk set_soenv.in
configure.in | 62 - postgresql/makefile.mk | 12 - set_soenv.in |2 + 3 files changed, 74 insertions(+), 2 deletions(-) New commits: commit 227350eb5a9881f795e9ae499c732f0148e4ac38 Author: Lionel Elie Mamane lio...@mamane.lu Date: Thu Dec 15 18:40:59 2011 +0100 Introduce optional krb5gssapi support for internal PostgreSQL Enable it by default on MacOS X diff --git a/configure.in b/configure.in index 354fa52..3dbbc4b 100644 --- a/configure.in +++ b/configure.in @@ -1592,6 +1592,25 @@ AC_ARG_WITH(lang, ], ,) +# Kerberos and GSSAPI used only by PostgreSQL as of LibO 3.5 +AC_ARG_WITH(krb5, +AS_HELP_STRING([--with-krb5], +[Enable MIT Kerberos 5 support in modules that support it. + By default automatically enabled on platforms + where a good system Kerberos 5 is available.]), +,) +#AC_ARG_WITH(system-redland, +#AS_HELP_STRING([--with-system-redland], +#[Use redland library already on system.]),, +#[with_system_redland=$with_system_libs]) + +AC_ARG_WITH(gssapi, +AS_HELP_STRING([--with-gssapi], +[Enable GSSAPI support in modules that support it. + By default automatically enabled on platforms + where a good system GSSAPI is available.]), +,) + dnl === dnl Branding dnl === @@ -5413,12 +5432,51 @@ fi dnl === dnl Check for PostgreSQL stuff dnl === - if test x$enable_ext_postgresql_sdbc = xyes; then if test x$enable_extension_integration = xyes; then SCPDEFS=$SCPDEFS -DWITH_EXTENSION_POSTGRESQL fi +# if/when anything else than PostgreSQL uses Kerberos, +# move this out of `test x$enable_ext_postgresql_sdbc = xyes' +WITH_KRB5=NO +WITH_GSSAPI=no +case $_os in + Darwin) +# MacOS X has system MIT Kerberos 5 since 10.4 +if test $with_krb5 != no; then + WITH_KRB5=YES + AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' com_err 'com_err -lssl -lcrypto'], [], +[AC_MSG_ERROR([could not find function 'com_err' required for Kerberos 5])]) + AC_SEARCH_LIBS(krb5_sendauth, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken'], [], +[AC_MSG_ERROR([could not find function 'krb5_sendauth' required for Kerberos 5])]) +fi +if test $with_gssapi != no; then + WITH_GSSAPI=YES + AC_SEARCH_LIBS(gss_init_sec_context, [gssapi_krb5 gss 'gssapi -lkrb5 -lcrypto'], [], + [AC_MSG_ERROR([could not find function 'gss_init_sec_context' required for GSSAPI])]) +fi + ;; + WINNT) + if test $with_krb5 = yes || $with_gssapi = yes; then + AC_MSG_ERROR([Refusing to enable MIT Kerberos 5 or GSSAPI on Microsoft Windows.]) + fi + ;; + *) +if test $with_krb5 = yes; then + WITH_KRB5=YES + AC_SEARCH_LIBS(com_err, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken' com_err 'com_err -lssl -lcrypto'], [], +[AC_MSG_ERROR([could not find function 'com_err' required for Kerberos 5])]) + AC_SEARCH_LIBS(krb5_sendauth, [krb5 'krb5 -lcrypto -ldes -lasn1 -lroken'], [], +[AC_MSG_ERROR([could not find function 'krb5_sendauth' required for Kerberos 5])]) +fi +if test $with_gssapi = yes; then + WITH_GSSAPI=YES + AC_SEARCH_LIBS(gss_init_sec_context, [gssapi_krb5 gss 'gssapi -lkrb5 -lcrypto'], [], + [AC_MSG_ERROR([could not find function 'gss_init_sec_context' required for GSSAPI])]) +fi +esac + AC_MSG_CHECKING([PostgreSQL C interface]) if test $with_system_postgresql = yes; then AC_MSG_RESULT([external PostgreSQL]) @@ -5465,6 +5523,8 @@ if test x$enable_ext_postgresql_sdbc = xyes; then fi BUILD_POSTGRESQL_SDBC=YES fi +AC_SUBST(WITH_KRB5) +AC_SUBST(WITH_GSSAPI) AC_SUBST(BUILD_POSTGRESQL_SDBC) AC_SUBST(SYSTEM_POSTGRESQL) AC_SUBST(POSTGRESQL_INC) diff --git a/postgresql/makefile.mk b/postgresql/makefile.mk index e4e3969..1e1c4f4 100644 --- a/postgresql/makefile.mk +++ b/postgresql/makefile.mk @@ -60,15 +60,25 @@ CONFIGURE_DIR=. BUILD_DIR=src/interfaces/libpq CONFIGURE_ACTION = CPPFLAGS=$(SOLARINC) LDFLAGS=$(SOLARLIB) ./configure --without-readline --disable-shared --with-openssl + .IF $(WITH_LDAP) == YES CONFIGURE_ACTION += --with-ldap .IF $(WITH_OPENLDAP) != YES CONFIGURE_ACTION += --with-includes='$(SOLARVER)$/$(INPATH)$/inc$/mozilla$/ldap' --with-mozldap .ENDIF +.ENDIF # $(WITH_LDAP) == YES + +.IF $(WITH_KRB5) == YES +CONFIGURE_ACTION += --with-krb5 .ENDIF -BUILD_ACTION = make -j$(GMAKE_MODULE_PARALLELISM) all-static-lib libpq-flags.mk +.IF $(WITH_GSSAPI) == YES +CONFIGURE_ACTION += --with-gssapi .ENDIF +BUILD_ACTION = make
[Libreoffice-commits] .: registry/inc sw/inc
registry/inc/registry/registry.hxx |2 +- sw/inc/modcfg.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 5032e7b0cb95879716e34115cfa5ad040288729d Author: Gustavo Buzzatti Pacheco gbpach...@gmail.com Date: Thu Dec 15 11:44:28 2011 -0200 Additional fix for EasyHack FDO43058, remove extra semicolons diff --git a/registry/inc/registry/registry.hxx b/registry/inc/registry/registry.hxx index 0ae9136..37f8aa4 100644 --- a/registry/inc/registry/registry.hxx +++ b/registry/inc/registry/registry.hxx @@ -843,7 +843,7 @@ inline ::rtl::OUString RegistryKey::getName() ::rtl::OUString sRet; if (m_registry.isValid()) m_registry.m_pApi-getKeyName(m_hImpl, sRet.pData); -return sRet;; +return sRet; } inline RegError RegistryKey::createKey(const ::rtl::OUString keyName, diff --git a/sw/inc/modcfg.hxx b/sw/inc/modcfg.hxx index e45a3e3..14a3b2a 100644 --- a/sw/inc/modcfg.hxx +++ b/sw/inc/modcfg.hxx @@ -247,7 +247,7 @@ public: { return bHTML ? aWebTableConfig.bInsTblAlignNum : aTableConfig.bInsTblAlignNum; } voidSetInsTblAlignNum( sal_Bool bHTML, sal_Bool b ) { bHTML ? (aWebTableConfig.bInsTblAlignNum = b) : (aTableConfig.bInsTblAlignNum = b); -bHTML ? aWebTableConfig.SetModified() : aTableConfig.SetModified();;} +bHTML ? aWebTableConfig.SetModified() : aTableConfig.SetModified();} SwInsertTableOptions GetInsTblFlags(sal_Bool bHTML) const { return bHTML ? aWebInsertConfig.aInsTblOpts : aInsertConfig.aInsTblOpts;} ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/core/data/table3.cxx | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) New commits: commit cad074d663cc6034b73a485a151420287a38d7f9 Author: Eike Rathke er...@redhat.com Date: Thu Dec 15 21:23:09 2011 +0100 Resolved fdo#43831 Advanced FILTER incompatible with 3.4.4 documents * Reintroduced logic in PrepareQueryItem::operator() that got lost during rework of ScQueryEntry. * ScQueryParamBase::FillInExcelSyntax() and the calling lcl_createExcelQuery() create query entries always as ByString, that needs to be converted to ByValue if appropriate. diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index b0d261f..e47d88e 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -1683,15 +1683,26 @@ public: void operator() (ScQueryEntry::Item rItem) { -// Double-check if the query by date is really appropriate. - -if (rItem.meType != ScQueryEntry::ByDate) +if (rItem.meType != ScQueryEntry::ByString rItem.meType != ScQueryEntry::ByDate) return; sal_uInt32 nIndex = 0; bool bNumber = mrDoc.GetFormatTable()- IsNumberFormat(rItem.maString, nIndex, rItem.mfVal); +// Advanced Filter creates only ByString queries that need to be +// converted to ByValue if appropriate. rItem.mfVal now holds the value +// if bNumber==true. + +if (rItem.meType == ScQueryEntry::ByString) +{ +if (bNumber) +rItem.meType = ScQueryEntry::ByValue; +return; +} + +// Double-check if the query by date is really appropriate. + if (bNumber ((nIndex % SV_COUNTRY_LANGUAGE_OFFSET) != 0)) { const SvNumberformat* pEntry = mrDoc.GetFormatTable()-GetEntry(nIndex); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/core/data/table3.cxx | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) New commits: commit 2eba7687745b8103f6bc8f07988dab83bcf4c336 Author: Eike Rathke er...@redhat.com Date: Thu Dec 15 21:22:41 2011 +0100 Resolved fdo#43831 Advanced FILTER incompatible with 3.4.4 documents * Reintroduced logic in PrepareQueryItem::operator() that got lost during rework of ScQueryEntry. * ScQueryParamBase::FillInExcelSyntax() and the calling lcl_createExcelQuery() create query entries always as ByString, that needs to be converted to ByValue if appropriate. diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index b0d261f..e47d88e 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -1683,15 +1683,26 @@ public: void operator() (ScQueryEntry::Item rItem) { -// Double-check if the query by date is really appropriate. - -if (rItem.meType != ScQueryEntry::ByDate) +if (rItem.meType != ScQueryEntry::ByString rItem.meType != ScQueryEntry::ByDate) return; sal_uInt32 nIndex = 0; bool bNumber = mrDoc.GetFormatTable()- IsNumberFormat(rItem.maString, nIndex, rItem.mfVal); +// Advanced Filter creates only ByString queries that need to be +// converted to ByValue if appropriate. rItem.mfVal now holds the value +// if bNumber==true. + +if (rItem.meType == ScQueryEntry::ByString) +{ +if (bNumber) +rItem.meType = ScQueryEntry::ByValue; +return; +} + +// Double-check if the query by date is really appropriate. + if (bNumber ((nIndex % SV_COUNTRY_LANGUAGE_OFFSET) != 0)) { const SvNumberformat* pEntry = mrDoc.GetFormatTable()-GetEntry(nIndex); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - i18npool/source
i18npool/source/localedata/data/sl_SI.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 83cdf418f942567ea5239e715afdfe9c89db0c83 Author: Martin Srebotnjak mi...@filmsi.net Date: Thu Dec 15 21:50:03 2011 +0100 more corrections to date formats diff --git a/i18npool/source/localedata/data/sl_SI.xml b/i18npool/source/localedata/data/sl_SI.xml index 675a3fb..e61ce24 100644 --- a/i18npool/source/localedata/data/sl_SI.xml +++ b/i18npool/source/localedata/data/sl_SI.xml @@ -84,13 +84,13 @@ FormatCode#.##0,-- [CURRENCY];[RED]-#.##0,-- [CURRENCY]/FormatCode /FormatElement FormatElement msgid=DateFormatskey1 default=true type=short usage=DATE formatindex=18 - FormatCodeDD.MM.YY/FormatCode + FormatCodeD.M.YY/FormatCode /FormatElement FormatElement msgid=DateFormatskey9 default=true type=long usage=DATE formatindex=19 FormatCodeD. /FormatCode /FormatElement FormatElement msgid=DateFormatskey8 default=true type=medium usage=DATE formatindex=20 - FormatCodeDD. MM. YY/FormatCode + FormatCodeDD.MM.YY/FormatCode /FormatElement FormatElement msgid=DateFormatskey7 default=false type=medium usage=DATE formatindex=21 FormatCodeDD. MM. /FormatCode ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/sl_SI.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit dc6878ac4a5913483bae22e338f3efbb19be7d05 Author: Martin Srebotnjak mi...@filmsi.net Date: Thu Dec 15 21:49:44 2011 +0100 more corrections to date formats diff --git a/i18npool/source/localedata/data/sl_SI.xml b/i18npool/source/localedata/data/sl_SI.xml index 675a3fb..e61ce24 100644 --- a/i18npool/source/localedata/data/sl_SI.xml +++ b/i18npool/source/localedata/data/sl_SI.xml @@ -84,13 +84,13 @@ FormatCode#.##0,-- [CURRENCY];[RED]-#.##0,-- [CURRENCY]/FormatCode /FormatElement FormatElement msgid=DateFormatskey1 default=true type=short usage=DATE formatindex=18 - FormatCodeDD.MM.YY/FormatCode + FormatCodeD.M.YY/FormatCode /FormatElement FormatElement msgid=DateFormatskey9 default=true type=long usage=DATE formatindex=19 FormatCodeD. /FormatCode /FormatElement FormatElement msgid=DateFormatskey8 default=true type=medium usage=DATE formatindex=20 - FormatCodeDD. MM. YY/FormatCode + FormatCodeDD.MM.YY/FormatCode /FormatElement FormatElement msgid=DateFormatskey7 default=false type=medium usage=DATE formatindex=21 FormatCodeDD. MM. /FormatCode ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - salhelper/Library_salhelper.mk solenv/gbuild
salhelper/Library_salhelper.mk | 26 +- solenv/gbuild/Deliver.mk|4 ++-- solenv/gbuild/Library.mk| 14 ++ solenv/gbuild/platform/OPENBSD_INTEL_GCC.mk |5 - solenv/gbuild/platform/macosx.mk|6 -- solenv/gbuild/platform/solaris.mk |4 +++- solenv/gbuild/platform/unxgcc.mk|5 - 7 files changed, 32 insertions(+), 32 deletions(-) New commits: commit f3b7bfcef472ed31b341c008793d96ed2bafae4b Author: Michael Stahl mst...@redhat.com Date: Thu Dec 15 22:11:59 2011 +0100 salhelper: s/hack/gb_Library_set_soversion_script/ diff --git a/salhelper/Library_salhelper.mk b/salhelper/Library_salhelper.mk index c77d1f0..d98cd22 100644 --- a/salhelper/Library_salhelper.mk +++ b/salhelper/Library_salhelper.mk @@ -52,30 +52,6 @@ $(eval $(call gb_Library_add_exception_objects,salhelper,\ # Solaris would need something like this, too. Its backwards compatibility is # broken for now: -ifeq ($(OS),LINUX) - -$(eval $(call gb_Library_add_ldflags,salhelper, \ --Wl$(COMMA)--soname=libuno_salhelpergcc3.so.3 \ --Wl$(COMMA)--version-script=$(SRCDIR)/salhelper/source/gcc3.map \ -)) - -$(call gb_LinkTarget_get_target,$(call \ -gb_Library_get_linktargetname,salhelper)): $(SRCDIR)/salhelper/source/gcc3.map - -endif - -# A hack to generate the soname symlink in the solver: - -ifneq ($(OS),WNT) - -$(call gb_Library_get_target,salhelper): | \ -$(call gb_Library_get_target,salhelper).3 - -$(call gb_Library_get_target,salhelper).3: - $(call gb_Helper_abbreviate_dirs,rm -f $@) - $(call gb_Helper_abbreviate_dirs, \ -ln -s $(notdir $(call gb_Library_get_target,salhelper)) $@) - -endif +$(eval $(call gb_Library_set_soversion_script,salhelper,3,$(SRCDIR)/salhelper/source/gcc3.map)) # vim: set noet sw=4 ts=4: commit 039cdb19e69b59b95609025c2d23cdb84f5c73c0 Author: Michael Stahl mst...@redhat.com Date: Thu Dec 15 22:09:51 2011 +0100 gbuild: add gb_Library_set_soversion_script: This allows for setting a SONAME and version script, which is required for UNO runtime libraries where we want to maintain a stable ABI. The old build system did apparently not set an SONAME on MacOSX or Solaris, so don't do that here either. diff --git a/solenv/gbuild/Library.mk b/solenv/gbuild/Library.mk index 82daae1..d491dd2 100644 --- a/solenv/gbuild/Library.mk +++ b/solenv/gbuild/Library.mk @@ -77,6 +77,20 @@ $(call gb_Deliver_add_deliverable,$(call gb_Library_get_target,$(1)),$(call gb_L endef +define gb_Library_set_soversion_script +$(if $(2),,$(call gb_Output_error,gb_Library_set_soversion_script: no version)) +$(if $(3),,$(call gb_Output_error,gb_Library_set_soversion_script: no script)) +$(call gb_LinkTarget_get_target,$(call gb_Library_get_linktargetname,$(1))) : \ + $(3) +$(call gb_Library_get_target,$(1)) : SOVERSION := $(2) +$(call gb_Library_get_target,$(1)) : SOVERSIONSCRIPT := $(3) +$(call gb_Library_get_target,$(1)) \ +$(call gb_Library_get_clean_target,$(1)) : \ + AUXTARGETS += $(call gb_Library_get_target,$(1)).$(2) +$(call gb_LinkTarget_set_auxtargets,$(call gb_Library_get_linktargetname,$(1)),\ + $(call gb_LinkTarget_get_target,$(call gb_Library_get_linktargetname,$(1))).$(2)) +endef + define gb_Library_set_componentfile $(call gb_ComponentTarget_ComponentTarget,$(2),$(call gb_Library__get_componentprefix,$(1)),\ $(call gb_Library_get_runtime_filename,$(if $(MERGELIBS),$(if $(filter $(gb_MERGED_LIBS),$(1)),merged,$(1)),$(1 diff --git a/solenv/gbuild/platform/OPENBSD_INTEL_GCC.mk b/solenv/gbuild/platform/OPENBSD_INTEL_GCC.mk index 17b2715..b9a47da 100644 --- a/solenv/gbuild/platform/OPENBSD_INTEL_GCC.mk +++ b/solenv/gbuild/platform/OPENBSD_INTEL_GCC.mk @@ -40,6 +40,8 @@ $(call gb_Helper_abbreviate_dirs,\ mkdir -p $(dir $(1)) \ $(gb_CXX) \ $(if $(filter Library CppunitTest,$(TARGETTYPE)),$(gb_Library_TARGETTYPEFLAGS)) \ + $(if $(SOVERSION),-Wl$(COMMA)--soname=$(notdir $(1)).$(SOVERSION)) \ + $(if $(SOVERSIONSCRIPT),-Wl$(COMMA)--version-script=$(SOVERSIONSCRIPT))\ $(subst \d,$$,$(RPATH)) \ $(T_LDFLAGS) \ $(foreach object,$(COBJECTS),$(call gb_CObject_get_target,$(object))) \ @@ -50,7 +52,8 @@ mkdir -p $(dir $(1)) \ -Wl$(COMMA)--start-group $(foreach lib,$(LINKED_STATIC_LIBS),$(call gb_StaticLibrary_get_target,$(lib))) -Wl$(COMMA)--end-group \ $(LIBS) \ $(subst -lpthread,$(PTHREAD_LIBS),$(patsubst lib%.a,-l%,$(patsubst lib%.so,-l%,$(foreach lib,$(LINKED_LIBS),$(call gb_Library_get_filename,$(lib)) \ - -o $(1)) + -o $(if $(SOVERSION),$(1).$(SOVERSION),$(1))) + $(if $(SOVERSION),ln -sf $(notdir $(1)).$(SOVERSION) $(1)) endef # vim: set noet sw=4: diff --git
[Libreoffice-commits] .: 4 commits - configure.in README.cross set_soenv.in
README.cross | 23 ++- configure.in |2 +- set_soenv.in | 11 +-- 3 files changed, 32 insertions(+), 4 deletions(-) New commits: commit 9a6beed05243189bf6106a70def7e3817b6363f3 Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Dec 15 23:54:31 2011 +0200 Add autogen.lastrun sample for cross-compiling to Android from Mac OS X diff --git a/README.cross b/README.cross index cdcb37c..eb3bed7 100644 --- a/README.cross +++ b/README.cross @@ -323,7 +323,28 @@ particular) and Mac OS X. The Android cross-buld tool-chain (the Windows. (Trying to cross-compile from Windows will probably drive you insane.) -Here is my autogen.lastrun for Android: +Here is my autogen.lastrun for Android, when cross-compiling from Mac OS X: +SYSBASE=/Users/tml/android-ndk-r7/platforms/android-9/arch-arm +CC=ccache /Users/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/darwin-x86/bin/arm-linux-androideabi-gcc -march=armv7-a -mfloat-abi=softfp -mthumb -mfpu=neon -Wl,--fix-cortex-a8 --sysroot /Users/tml/android-ndk-r7/platforms/android-9/arch-arm -L/Users/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/libs/armeabi-v7a +CXX=ccache /Users/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/darwin-x86/bin/arm-linux-androideabi-g++ -march=armv7-a -mfloat-abi=softfp -mthumb -mfpu=neon -Wl,--fix-cortex-a8 --sysroot /Users/tml/android-ndk-r7/platforms/android-9/arch-arm -I /Users/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/include -I/Users/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/libs/armeabi-v7a/include -L/Users/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/libs/armeabi-v7a -fexceptions -frtti +AR=/Users/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/darwin-x86/bin/arm-linux-androideabi-ar +NM=/Users/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/darwin-x86/bin/arm-linux-androideabi-nm +OBJDUMP=/Users/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/darwin-x86/bin/arm-linux-androideabi-objdump +RANLIB=/Users/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/darwin-x86/bin/arm-linux-androideabi-ranlib +STRIP=/Users/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/darwin-x86/bin/arm-linux-androideabi-strip +CC_FOR_BUILD=ccache /Xcode3/usr/bin/gcc-4.0 -mmacosx-version-min=10.4 +CXX_FOR_BUILD=ccache /Xcode3/usr/bin/g++-4.0 -mmacosx-version-min=10.4 +--build=x86_64-apple-darwin11 +--disable-zenity +--enable-werror +--with-distro=LibreOfficeAndroid +--with-external-tar=/Volumes/ooo/git/master/src +--disable-python +--without-helppack-integration +--without-myspell-dicts +--with-java + +And here is the autogen.lastrun for Android when cross-compiling from Linux: SYSBASE=/home/tml/android-ndk-r7/platforms/android-9/arch-arm CC=ccache /home/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86/bin/arm-linux-androideabi-gcc -march=armv7-a -mfloat-abi=softfp -mthumb -mfpu=neon -Wl,--fix-cortex-a8 --sysroot /home/tml/android-ndk-r7/platforms/android-9/arch-arm -L/home/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/libs/armeabi-v7a CXX=ccache /home/tml/android-ndk-r7/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86/bin/arm-linux-androideabi-g++ -march=armv7-a -mfloat-abi=softfp -mthumb -mfpu=neon -Wl,--fix-cortex-a8 --sysroot /home/tml/android-ndk-r7/platforms/android-9/arch-arm -I /home/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/include -I/home/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/libs/armeabi-v7a/include -L/home/tml/android-ndk-r7/sources/cxx-stl/gnu-libstdc++/libs/armeabi-v7a -fexceptions -frtti commit a20a2fda1f7c39dafcc0ea56d8cf713f8502853d Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Dec 15 23:52:39 2011 +0200 Save the config.log for the build platform as config.Build.log diff --git a/configure.in b/configure.in index 7f366cf..44a5af3 100644 --- a/configure.in +++ b/configure.in @@ -2280,6 +2280,7 @@ if test $cross_compiling = yes; then 21 | sed -e 's/^//' test -f ./Env.Host.sh 2/dev/null || exit cp Env.Host.sh ../Env.Build.sh +cp config.log ../config.Build.log . ./Env.Host.sh for V in COM GUI GUIBASE OS CPU CPUNAME CC CXX GXX_INCLUDE_PATH MACOSX_DEPLOYMENT_TARGET INPATH OUTPATH \ SYSTEM_LIBXSLT; do commit ad87a4747c1ba7bdb73e9e748fa20d275b85d670 Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Dec 15 23:50:00 2011 +0200 No Makefile.in any more diff --git a/configure.in b/configure.in index 3dbbc4b..7f366cf 100644 --- a/configure.in +++ b/configure.in @@ -2245,7 +2245,6 @@ if test $cross_compiling = yes; then rm -rf CONF-FOR-BUILD Env.Build.sh mkdir CONF-FOR-BUILD tar cf - \ -Makefile.in \ bin/repo-list.in \ build_env.in \ config.guess \ commit e38c7440223281fc66e8726fcc7ef79a7a879e1e Author: Tor Lillqvist tlillqv...@suse.com Date: Thu Dec 15 23:42:54
[Libreoffice-commits] .: 2 commits - solenv/gbuild
solenv/gbuild/platform/macosx.mk |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 883b12a76d038755992999fa74f69560a8eee1d1 Author: Michael Stahl mst...@redhat.com Date: Thu Dec 15 22:57:51 2011 +0100 gbuild: macosx.mk: tinderbox fails on version script diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk index 2ffe0f0..2b0d167 100644 --- a/solenv/gbuild/platform/macosx.mk +++ b/solenv/gbuild/platform/macosx.mk @@ -195,7 +195,6 @@ $(call gb_Helper_abbreviate_dirs,\ $(if $(filter Executable,$(TARGETTYPE)),$(gb_Executable_TARGETTYPEFLAGS)) \ $(if $(filter Library CppunitTest,$(TARGETTYPE)),$(gb_Library_TARGETTYPEFLAGS)) \ $(if $(filter Library,$(TARGETTYPE)),$(gb_Library_LTOFLAGS)) \ - $(if $(SOVERSIONSCRIPT),-Wl$(COMMA)-exported_symbols_list$(COMMA)$(SOVERSIONSCRIPT)) \ $(subst \d,$$,$(RPATH)) \ $(T_LDFLAGS) \ $(call gb_LinkTarget__get_liblinkflags,$(LINKED_LIBS)) \ commit 1d90f180cd263d7f99039bada57b3655d6f399df Author: Michael Stahl mst...@redhat.com Date: Thu Dec 15 22:41:46 2011 +0100 gbuild: macosx.mk: remove salhelper hack diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk index ea576f3..2ffe0f0 100644 --- a/solenv/gbuild/platform/macosx.mk +++ b/solenv/gbuild/platform/macosx.mk @@ -149,10 +149,8 @@ gb_LinkTarget__RPATHS := \ SDKBIN: \ NONE:@__VIA_LIBRARY_PATH__@ \ -# The below contains a bad hack to set the correct install name for -# libuno_salhepergcc3.dylib.3, with a trailing .3: define gb_LinkTarget__get_installname -$(if $(2),-install_name '$(2)$(1)$(if $(filter $(1),libuno_salhelpergcc3.dylib),.3)',$(error +$(if $(2),-install_name '$(2)$(1)',$(error cannot determine -install_name for $(2))) endef ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: distro-configs/LibreOfficeAndroid.conf
distro-configs/LibreOfficeAndroid.conf |1 - 1 file changed, 1 deletion(-) New commits: commit 838bf0ecda01de652f0f8c08221a0b12e4667615 Author: Tor Lillqvist tlillqv...@suse.com Date: Fri Dec 16 00:20:24 2011 +0200 There is no --disable-nss-module option any more diff --git a/distro-configs/LibreOfficeAndroid.conf b/distro-configs/LibreOfficeAndroid.conf index da6ede9..c9bc5ab 100644 --- a/distro-configs/LibreOfficeAndroid.conf +++ b/distro-configs/LibreOfficeAndroid.conf @@ -9,7 +9,6 @@ --disable-gstreamer --disable-lockdown --disable-mozilla ---disable-nss-module --disable-odk --disable-opengl --disable-python ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: dictionaries/en dictionaries/hu_HU dictionaries/ru_RU
dictionaries/en/Lightproof.py | 17 dictionaries/en/dialog/OptionsDialog.xcu |1 dictionaries/en/pythonpath/lightproof_en.py |1 dictionaries/hu_HU/Lightproof.py | 19 dictionaries/hu_HU/pythonpath/lightproof_hu_HU.py |1 dictionaries/ru_RU/Lightproof.py | 322 ++ dictionaries/ru_RU/Linguistic.xcu | 17 dictionaries/ru_RU/README_Lightproof_ru_RU.txt|7 dictionaries/ru_RU/dialog/OptionsDialog.xcs | 58 ++ dictionaries/ru_RU/dialog/OptionsDialog.xcu | 33 + dictionaries/ru_RU/dialog/ru_RU.xdl | 21 dictionaries/ru_RU/dialog/ru_RU_en_US.properties | 15 dictionaries/ru_RU/dialog/ru_RU_ru_RU.properties | 15 dictionaries/ru_RU/makefile.mk| 15 dictionaries/ru_RU/manifest.xml |9 dictionaries/ru_RU/pythonpath/lightproof_handler_ru_RU.py | 121 + dictionaries/ru_RU/pythonpath/lightproof_impl_ru_RU.py|6 dictionaries/ru_RU/pythonpath/lightproof_opts_ru_RU.py|4 dictionaries/ru_RU/pythonpath/lightproof_ru_RU.py |1 19 files changed, 672 insertions(+), 11 deletions(-) New commits: commit c9cdf3fb4752e8b0c641a3aff15d554135beb0e7 Author: László Németh nem...@numbertext.org Date: Thu Dec 15 23:24:58 2011 +0100 Add Russian grammar checking + update English and Hungarian diff --git a/dictionaries/en/Lightproof.py b/dictionaries/en/Lightproof.py index 45a0446..0897e75 100644 --- a/dictionaries/en/Lightproof.py +++ b/dictionaries/en/Lightproof.py @@ -16,6 +16,7 @@ from com.sun.star.linguistic2 import ProofreadingResult, SingleProofreadingError from com.sun.star.lang import XServiceInfo, XServiceName, XServiceDisplayName from com.sun.star.lang import Locale from com.sun.star.text.TextMarkupType import PROOFREADING +from com.sun.star.beans import PropertyValue # loaded rules langrule = {} @@ -166,9 +167,16 @@ def proofread( nDocId, TEXT, LOCALE, nStartOfSentencePos, nSuggestedSentenceEndP comment = i[2] if comment[0:1] == =: comment = eval(comment[1:]) -aErr.aShortComment = comment.split(\n)[0] -aErr.aFullComment = comment.split(\n)[-1] -aErr.aProperties= () +aErr.aShortComment = comment.split(\\n)[0].strip() +aErr.aFullComment = comment.split(\\n)[-1].strip() +if :// in aErr.aFullComment: +p = PropertyValue() +p.Name = FullCommentURL +p.Value = aErr.aFullComment +aErr.aFullComment = aErr.aShortComment +aErr.aProperties= (p,) +else: +aErr.aProperties= () aErrs = aErrs + [aErr] return tuple(aErrs) @@ -315,6 +323,9 @@ g_ImplementationHelper.addImplementation( lightproof_handler_en.LightproofOption # pattern matching for common English abbreviations abbrev = re.compile((?i)\\b([a-z]|acct|approx|appt|apr|apt|assoc|asst|aug|ave|avg|co(nt|rp)?|ct|dec|defn|dept|dr|eg|equip|esp|est|etc|excl|ext|feb|fri|ft|govt?|hrs?|ib(id)?|ie|in(c|t)?|jan|jr|jul|lit|ln|mar|max|mi(n|sc)?|mon|Mrs?|mun|natl?|neg?|no(rm|s|v)?|nw|obj|oct|org|orig|pl|pos|prev|proj|psi|qty|rd|rec|rel|reqd?|resp|rev|sat|sci|se(p|pt)?|spec(if)?|sq|sr|st|subj|sun|sw|temp|thurs|tot|tues|univ|var|vs)\\.) +# pattern for paragraph checking +paralcap = re.compile(u(?u)^[a-z].*[.?!] [A-Z].*[.?!][)\u201d]?$) + punct = { ?: question mark, !: exclamation mark, ,: comma, :: colon, ;: semicolon, diff --git a/dictionaries/en/dialog/OptionsDialog.xcu b/dictionaries/en/dialog/OptionsDialog.xcu index 2ccb6db..07f24cf 100644 --- a/dictionaries/en/dialog/OptionsDialog.xcu +++ b/dictionaries/en/dialog/OptionsDialog.xcu @@ -5,7 +5,6 @@ node oor:name=org.openoffice.lightproof oor:op=fuse prop oor:name=Label value xml:lang=enDictionaries/value -value xml:lang=huSzótárak/value /prop node oor:name=Leaves diff --git a/dictionaries/en/pythonpath/lightproof_en.py b/dictionaries/en/pythonpath/lightproof_en.py index d0e48b5..a437797 100644 --- a/dictionaries/en/pythonpath/lightproof_en.py +++ b/dictionaries/en/pythonpath/lightproof_en.py @@ -1 +1 @@ -dic = [[u'(?u)(?![-\\w\u2013.,\xad])and and(?![-\\w\u2013\xad])', u'and', u'Did you mean:', False], [u'(?u)(?![-\\w\u2013.,\xad])or or(?![-\\w\u2013\xad])', u'or', u'Did you mean:', False], [u'(?u)(?![-\\w\u2013.,\xad])for for(?![-\\w\u2013\xad])', u'for', u'Did you mean:', False],
[Libreoffice-commits] .: 3 commits - package/source sfx2/source
package/source/zipapi/ZipFile.cxx | 10 +++-- package/source/zippackage/ZipPackageFolder.cxx | 12 +-- sfx2/source/appl/appuno.cxx| 26 + 3 files changed, 16 insertions(+), 32 deletions(-) New commits: commit d0ac36dd4e3d6953de8b3bdd79eeed8d2e70 Author: Thorsten Behrens tbehr...@suse.com Date: Fri Dec 16 01:32:43 2011 +0100 Better fix for over-zealous Zip package consistency. Turns out our encrypted zip package code writes out mismatching compression methods in central directory and local file headers - so not only be lenient towards the apple bug (n#653688), but also ours (i.e. keep not comparing nMethod with nHow). diff --git a/package/source/zipapi/ZipFile.cxx b/package/source/zipapi/ZipFile.cxx index ef801f2..16d5a00 100644 --- a/package/source/zipapi/ZipFile.cxx +++ b/package/source/zipapi/ZipFile.cxx @@ -686,9 +686,15 @@ sal_Bool ZipFile::readLOC( ZipEntry rEntry ) rEntry.sPath = sLOCPath; } -// check basic local file header / entry consistency +// check basic local file header / entry consistency, just +// plain ignore bits 1 2 of the flag field - they are either +// purely informative, or even fully undefined (depending on +// nMethod) +// Do *not* compare nMethod / nHow, older versions with +// encrypted streams write mismatching DEFLATE/STORE pairs +// there. bBroken = rEntry.nVersion != nVersion -|| rEntry.nFlag != nFlag +|| (rEntry.nFlag ~6L) != (nFlag ~6L) || rEntry.nTime != nTime || rEntry.nPathLen != nPathLen || !rEntry.sPath.equals( sLOCPath ); commit f9128f9848de25d80bb032b872f03839f6a3b467 Author: Thorsten Behrens tbehr...@suse.com Date: Fri Dec 16 01:30:22 2011 +0100 Fix inconsistent compression method for encrypted ZIP packages. While fixing n#653688, turned out we write method=STORED into local file headers, and method=DEFLATED into central directory structure for encrypted ODF. Damn side-effects - fixed as hopefully intended here. diff --git a/package/source/zippackage/ZipPackageFolder.cxx b/package/source/zippackage/ZipPackageFolder.cxx index 60f5cd1..daee0f4 100644 --- a/package/source/zippackage/ZipPackageFolder.cxx +++ b/package/source/zippackage/ZipPackageFolder.cxx @@ -657,16 +657,16 @@ bool ZipPackageFolder::saveChild( const ::rtl::OUString rShortName, const Conte rInfo.pStream-SetToBeEncrypted( sal_True ); } +// Then copy it back afterwards... +ZipPackageFolder::copyZipEntry ( rInfo.pStream-aEntry, *pTempEntry ); + // Remove hacky bit from entry flags -if ( pTempEntry-nFlag ( 1 4 ) ) +if ( rInfo.pStream-aEntry.nFlag ( 1 4 ) ) { -pTempEntry-nFlag = ~( 1 4 ); -pTempEntry-nMethod = STORED; +rInfo.pStream-aEntry.nFlag = ~( 1 4 ); +rInfo.pStream-aEntry.nMethod = STORED; } -// Then copy it back afterwards... -ZipPackageFolder::copyZipEntry ( rInfo.pStream-aEntry, *pTempEntry ); - // TODO/LATER: get rid of this hack ( the encrypted stream size property is changed during saving ) if ( rInfo.pStream-IsEncrypted() ) rInfo.pStream-setSize( nOwnStreamOrigSize ); commit e0436514c3be513fcb0f02fd45be76f88569515b Author: Thorsten Behrens tbehr...@suse.com Date: Wed Dec 14 19:35:01 2011 +0100 Removed unused code. Clearly this iteration and reading of the referer, that is then subsequently not used at all by the method, can go. diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx index 93b0e41..5e44bbf 100644 --- a/sfx2/source/appl/appuno.cxx +++ b/sfx2/source/appl/appuno.cxx @@ -1701,23 +1701,12 @@ SfxObjectShell* SfxMacroLoader::GetObjectShell_Impl() // --- void SAL_CALL SfxMacroLoader::dispatchWithNotification( const ::com::sun::star::util::URL aURL , -const ::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue lArgs , +const ::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue /*lArgs*/ , const ::com::sun::star::uno::Reference ::com::sun::star::frame::XDispatchResultListener xListener ) throw (::com::sun::star::uno::RuntimeException) { SolarMutexGuard aGuard; -sal_uInt32 nPropertyCount = lArgs.getLength(); -::rtl::OUString aReferer; -
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/qa
sc/qa/unoapi/sc.sce |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 3745d6c48e75d31b79d37fc7c0634fc4f47215cf Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Dec 16 02:31:56 2011 +0100 disable scs' subsequenttests that use binfilter formats diff --git a/sc/qa/unoapi/sc.sce b/sc/qa/unoapi/sc.sce index 3e4dfcb..b35fdd0 100644 --- a/sc/qa/unoapi/sc.sce +++ b/sc/qa/unoapi/sc.sce @@ -37,8 +37,8 @@ -o sc.ScChartObj -o sc.ScChartsObj -o sc.ScConsolidationDescriptor --o sc.ScDDELinkObj --o sc.ScDDELinksObj +# fdo43376 -o sc.ScDDELinkObj +# fdo43376 -o sc.ScDDELinksObj -o sc.ScDataPilotFieldGroupItemObj -o sc.ScDataPilotFieldGroupObj -o sc.ScDataPilotFieldGroupsObj ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - sc/CppunitTest_sc_namedrangeobj.mk sc/qa
sc/CppunitTest_sc_namedrangeobj.mk|3 sc/qa/extras/testdocuments/rangenames.ods |binary sc/qa/extras/xnamedrange.cxx | 201 ++ sc/qa/extras/xnamedranges.cxx | 259 + sc/qa/extras/xrangename.cxx | 265 -- sc/qa/unoapi/sc.sce |4 6 files changed, 464 insertions(+), 268 deletions(-) New commits: commit d75042329e7dd9bcc6d355ca19f556f144e93492 Author: Laurent Godard lgodard.li...@laposte.net Date: Thu Dec 15 15:56:57 2011 +0100 c++ subsequent tests XRangeName and XRangeNames renaming previous test to XRangeNames new test for XRangeName diff --git a/sc/CppunitTest_sc_namedrangeobj.mk b/sc/CppunitTest_sc_namedrangeobj.mk index de25f26..cb01294 100644 --- a/sc/CppunitTest_sc_namedrangeobj.mk +++ b/sc/CppunitTest_sc_namedrangeobj.mk @@ -32,6 +32,7 @@ $(eval $(call gb_CppunitTest_CppunitTest,sc_namedrangeobj)) $(eval $(call gb_CppunitTest_add_exception_objects,sc_namedrangeobj, \ sc/qa/extras/xnamedranges \ +sc/qa/extras/xnamedrange \ )) $(eval $(call gb_CppunitTest_add_linked_libs,sc_namedrangeobj, \ diff --git a/sc/qa/extras/testdocuments/rangenames.ods b/sc/qa/extras/testdocuments/rangenames.ods index 7a743d7..1b101fd 100644 Binary files a/sc/qa/extras/testdocuments/rangenames.ods and b/sc/qa/extras/testdocuments/rangenames.ods differ diff --git a/sc/qa/extras/xnamedrange.cxx b/sc/qa/extras/xnamedrange.cxx new file mode 100644 index 000..616c835 --- /dev/null +++ b/sc/qa/extras/xnamedrange.cxx @@ -0,0 +1,201 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * Version: MPL 1.1 / GPLv3+ / LGPLv3+ + * + * The contents of this file are subject to the Mozilla Public License Version + * 1.1 (the License); you may not use this file except in compliance with + * the License or as specified alternatively below. You may obtain a copy of + * the License at http://www.mozilla.org/MPL/ + * + * Software distributed under the License is distributed on an AS IS basis, + * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License + * for the specific language governing rights and limitations under the + * License. + * + * Major Contributor(s): + * Copyright (C) 2011 Laurent Godard lgodard.li...@laposte.net (initial developer) + * + * All Rights Reserved. + * + * For minor contributions see the git repository. + * + * Alternatively, the contents of this file may be used under the terms of + * either the GNU General Public License Version 3 or later (the GPLv3+), or + * the GNU Lesser General Public License Version 3 or later (the LGPLv3+), + * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable + * instead of those above. + */ + +#include test/unoapi_test.hxx + +#include com/sun/star/beans/XPropertySet.hpp +#include com/sun/star/sheet/XSpreadsheetDocument.hpp +#include com/sun/star/sheet/XSpreadsheet.hpp +#include com/sun/star/table/XCellRange.hpp +#include com/sun/star/sheet/XCellRangeAddressable.hpp +#include com/sun/star/sheet/XCellRangeReferrer.hpp +#include com/sun/star/sheet/XNamedRanges.hpp +#include com/sun/star/sheet/XNamedRange.hpp +#include com/sun/star/table/XCell.hpp +#include com/sun/star/text/XTextRange.hpp + +#include com/sun/star/table/CellAddress.hpp +#include com/sun/star/table/CellRangeAddress.hpp +#include com/sun/star/sheet/Border.hpp +#include com/sun/star/sheet/NamedRangeFlag.hpp + +#include rtl/oustringostreaminserter.hxx + +namespace ScNamedRangeObj { + +class ScXNamedRange : public UnoApiTest +{ +uno::Reference sheet::XSpreadsheetDocument init(); +uno::Reference sheet::XNamedRange getTestedNamedRange(const rtl::OUString); + +// XNamedRange +void testGetContent(); +void testSetContent(); +void testGetType(); +void testSetType(); +void testGetReferencePosition(); +void testSetReferencePosition(); + +CPPUNIT_TEST_SUITE(ScXNamedRange); +CPPUNIT_TEST(testGetContent); +CPPUNIT_TEST(testSetContent); +CPPUNIT_TEST(testGetType); +CPPUNIT_TEST(testSetType); +CPPUNIT_TEST(testGetReferencePosition); +CPPUNIT_TEST(testSetReferencePosition); +CPPUNIT_TEST_SUITE_END(); +}; + + +void ScXNamedRange::testGetContent() +{ +rtl::OUString aTestedNamedRangeString(RTL_CONSTASCII_USTRINGPARAM(initial1)); +uno::Reference sheet::XNamedRange xNamedRange = getTestedNamedRange(aTestedNamedRangeString); + +rtl::OUString aExpectedContent(RTL_CONSTASCII_USTRINGPARAM($Sheet1.$B$1)); +CPPUNIT_ASSERT_MESSAGE(Wrong expected content for initial1 on GetContent, xNamedRange-getContent().equals(aExpectedContent)); +} + +void ScXNamedRange::testSetContent() +{ +rtl::OUString aTestedNamedRangeString(RTL_CONSTASCII_USTRINGPARAM(initial1)); +uno::Reference sheet::XNamedRange xNamedRange = getTestedNamedRange(aTestedNamedRangeString); + +rtl::OUString
[Libreoffice-commits] .: 2 commits - wizards/com
wizards/com/sun/star/wizards/common/PropertySetHelper.py | 23 --- 1 file changed, 7 insertions(+), 16 deletions(-) New commits: commit 0e7ac37f00ded5db953aed60ec67fafcfe28f21c Author: David Tardon dtar...@redhat.com Date: Fri Dec 16 06:53:23 2011 +0100 fix syntactic error diff --git a/wizards/com/sun/star/wizards/common/PropertySetHelper.py b/wizards/com/sun/star/wizards/common/PropertySetHelper.py index 8ce949e..970e453 100644 --- a/wizards/com/sun/star/wizards/common/PropertySetHelper.py +++ b/wizards/com/sun/star/wizards/common/PropertySetHelper.py @@ -225,10 +225,7 @@ class PropertySetHelper(object): def showProperties(self): sName = if self.m_xPropertySet != None: -XServiceInfo xServiceInfo = (XServiceInfo) -UnoRuntime.queryInterface(XServiceInfo.class, self.m_xPropertySet) -if xServiceInfo != None: -sName = xServiceInfo.getImplementationName() +sName = self.m_xPropertySet.getImplementationName() xInfo = self.m_xPropertySet.getPropertySetInfo() aAllProperties = xInfo.getProperties() commit c57fcf8d8873638b8ea9eb33c527e03939aaf80a Author: David Tardon dtar...@redhat.com Date: Fri Dec 16 06:44:18 2011 +0100 fix syntactic error diff --git a/wizards/com/sun/star/wizards/common/PropertySetHelper.py b/wizards/com/sun/star/wizards/common/PropertySetHelper.py index fbb31d8..8ce949e 100644 --- a/wizards/com/sun/star/wizards/common/PropertySetHelper.py +++ b/wizards/com/sun/star/wizards/common/PropertySetHelper.py @@ -4,16 +4,8 @@ class PropertySetHelper(object): @classmethod def __init__(self, _aObj): -if not _aObj: - return - self.m_xPropertySet = _aObj - -def getHashMap(self): -if self.m_aHashMap == None: -self.m_aHashMap = HashMap String, Object .Object() - -return self.m_aHashMap +self.m_aHashMap = {} ''' set a property, don't throw any exceptions, @@ -55,7 +47,7 @@ class PropertySetHelper(object): DebugHelper.exception(e) else: -getHashMap().put(_sName, _aValue) +self.m_aHashMap[_sName] = _aValue ''' get a property and convert it to a int value @@ -128,9 +120,11 @@ class PropertySetHelper(object): except com.sun.star.lang.WrappedTargetException, e: DebugHelper.writeInfo(e.getMessage()) +# TODO: I wonder why the same thing is not done in the rest of the +# getPropertyValueAs* functions... if aObject == None: -if getHashMap().containsKey(_sName): -aObject = getHashMap().get(_sName) +if _sName in self.m_aHashMap: +aObject = self.m_aHashMap[_sName] if aObject != None: try: ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: fontconfig/prj
fontconfig/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5bd8284c9db5486b0824e94592ed1e8c9df6af4e Author: Tor Lillqvist t...@iki.fi Date: Fri Dec 16 08:41:30 2011 +0200 Mark fontconfig as depending on expat diff --git a/fontconfig/prj/build.lst b/fontconfig/prj/build.lst index 635abf4..43891b4 100644 --- a/fontconfig/prj/build.lst +++ b/fontconfig/prj/build.lst @@ -1,3 +1,3 @@ -fc libfontconfig : FREETYPE:freetype NULL +fc libfontconfig : FREETYPE:freetype EXPAT:expat NULL fc libfontconfig usr1- u fc_mkout NULL fc libfontconfig nmake - u fc_libfontconfig NULL ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice] Simpler logging using a string format function
On 12/13/2011 07:56 PM, Lubos Lunak wrote: On Monday 12 of December 2011, Stephan Bergmann wrote: Shrug. Neither nor something printf-like is particularly sexy, IMO. And trading for +, when it requires you to wrap non-string arguments in rtl::OUString::valueOf, doesn't look too exciting to me, either. But it might the moment you realize you're trading away things like SAL_INFO( foo, 1 2 ) or SAL_INFO( foo, bar baz ). Trading away the former, having to parenthesize (1 2) instead, is a std C++ trade-off. Granted, omission of the leading ostream in the macro call makes this somewhat non-obvious. What is traded away in the latter case? Anyway, bikeshedding about surface syntax is rather pointless. Some seem to prefer a printf-style syntax, while others are fine with a C++ -based one. - Artificially limited to 9 arguments. You can sure always extend that, but it's more work than not having to worry about it. Hmm. How often is that going to be needed? With creative uses of SAL_WARN/INFO, I wouldn't be too sure. ;) (And as I already said, none of those are critical shortcomings, only indicators to me that swapping implementations were not worth it if the only benefit were a different syntax.) - No check that there are neither more nor fewer arguments than %Ns (or that the set of %Ns spans a range 1--M without holes). There's a todo note, not that I think it matters that much if whoever does that runs the code at least once. Note that at least SAL_WARNs will typically *not* be run by the code authors. (Who goes to the pains of crafting a scenario to make each new SAL_WARN actually trigger, by temporarily modifying the code around it or creating an appropriate runtime environment?) Well, that's another advantage of the format approach then. It's an inconvenience to have to explicitly say the format string is utf-8 (and arguments probably as well), but then this conversion can be again limited just to logging and not to every std::ostream operation. Yes, having the message in UTF-16 is an advantage here. For the ostream-based approach, we need to wait for general availability of C++11's char16_t. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Simpler logging using a string format function
On 12/13/2011 10:21 PM, Michael Meeks wrote: On Mon, 2011-12-12 at 22:59 +0100, Stephan Bergmann wrote: To be honest, I don't think the stated benefits (a different syntax) are worth a switch. Well; the syntax that makes translation possible is a nice thing; but Again, translation is a non-issue with conceivable uses of this in LO, right? to me - having something efficient - that does not turn into some huge sequence of calls is what I'm interested in. We have quite enough bloat size-wise as it is, and infrastructure that makes it easy to create small, efficient code is much to be praised I feel. rtl::OUString x = a + 4 + c; turns into: x = new OUStringBuffer().append(a).append(4).append(c) .makeStringAndClear() Which looks (to me) like a lot of back-to-back calls (in place of one); and presumably some chunk of exception unwind table too. [ speaking of But that's not related to the code in question. Rather, at the call site, the printf-style approach amounts to a call to logfunction, while the -style approach amounts to one call to ostringstream ctor and one or more calls to the appropriate operators. Granted, the greater flexibility of the latter results in larger call-site code. Sure, none of those are critical shortcomings, though. (And its late already, and maybe I'm just missing an obvious benefit completely.) Heh. Wrt. the panicing about now-or-never-again changes to these SAL_INFO style macros, that seems a bit over-done to me. Late in the evening, not late for changes was what I meant. If there is any uncertainty about what we want to do with SAL_INFO and friends, I suggest we just add a -DSAL_INTERNAL parameter (or alike) to our build environment, and have some pieces of sal which are only for internal use. Then we can improve this at our leisure without panicing about sal's precious ABI :-) No need for -DSAL_INTERNAL, I think. The relevant symbols in sal.map are already in a PRIVATE_1.2 section, so clients that don't use sal/log.hxx would not be affected by incompatible changes. And if we think so, we can mark the client-facing functionality in sal/log.hxx as for LO internal use only, for now (we already do so in some other places). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.99.1 tag created (3.5.0-beta1)
2011/12/14 Andreas Radke a.ra...@arcor.de: any suggestions welcome. the only difference to beta0 is the changed internal libvisio src bump. tried autoconf/autoreconf and make -j1 install without luck :( -Andy It is not failure during build, but during install, so configure and make can have any parallelism. Anyway gentoo bug for this issue is here [1]. The problem as I managed to hit it once is that NO subdirs are created in sdk directory - all copying fails because it does not have the place where it wants to put the files. Cheers Tom [1] https://bugs.gentoo.org/show_bug.cgi?id=394599 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Tests on release build
Hello guys, as again there is new series of lo it means more tests were added to the list of those that are run during the make phase (where normal software do only build). For developers it helps to identify issues quickly because your build crashes if you try to compile your changes but for users that try to build the lo just for themselves the crashes can get really annoying. Even that is not much of a problem as distributions usually provide binaries that were once build so they do not run the tests for each various hw/cflags/march/etc etc, sadly I am working on Gentoo, which means I do get bazilion of bugs for failing tests that are not reproducable on most machines. Small list of bugs from experimental branch after two days (meaning not much people using it and those errors will just grow as it moves to stable): https://bugs.gentoo.org/show_bug.cgi?id=394659 https://bugs.gentoo.org/show_bug.cgi?id=394615 https://bugs.gentoo.org/show_bug.cgi?id=394767 So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you guys to rethink running the tests for release build during the make phase and just allow me to run them in designated test phase where it is allowed to fail and wont stop user from installing the office suite. (Yes those errors are logged, yes I will provide them, and yes user will be able to use his office suite and not wait on some test fixes) This is quite critical issue for packaging in Gentoo and I would love to fix it some other way than implementing cppunit hack that would return true on each test so users will be able to install their package... Cheers Tom ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SDK installation problem was: libreoffice-3.4.99.1 tag created (3.5.0-beta1)
Andreas Radke píše v St 14. 12. 2011 v 22:48 +0100: build is done in a clean chroot each time. shouldn't be a problem. the beta0 built fine here. the only difference to beta0 is the changed internal libvisio src bump. tried autoconf/autoreconf and make -j1 install without luck :( It is really strange. Tomas have problems to reproduce it as well. It happened him when he did a clean build. It did not happen when he tried to reproduce it as root. Could you please try to run installation twice in the chroot as a normal user? Could you please try to do it as root? Also you might try to pass -log and --debug options to the make_installer.pl call. Just edit solenv/bin/ooinstall in the ODK/SDK part. It will produce many logs in instsetoo_native/unxlng??.pro. You might try to search them for anything interesting. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
On 12/15/2011 10:58 AM, Tomáš Chvátal wrote: So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you Hard to tell without a backtrace. guys to rethink running the tests for release build during the make phase and just allow me to run them in designated test phase where it is allowed to fail and wont stop user from installing the office suite. (Yes those errors are logged, yes I will provide them, and yes user will be able to use his office suite and not wait on some test fixes) IIUC, make build will omit the checks (and make unitcheck will execute them). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Candidate patch for integration?
Hi, I had written this patch quite some time back: https://issues.apache.org/ooo/attachment.cgi?id=68593action=diff Related to https://bugs.freedesktop.org/show_bug.cgi?id=33602 I assumed this was in go-oo.org and also made it to libreoffice, but I guess I was wrong. If the code is fine, shall I push it? I vaguely remember, Eike had a better idea to manage all the dialog box preferences - I don't exactly remember the details. Thanks! Muthu Subramanian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] split links, word import issue?
Hi all, I created a document xx.odt with a link. Then I saved the link as xx.doc. Then opened xx.doc and found that the single original link was split into several links, each link for one word or space from the original link label (see xx3.odt). It looks like the algorithm for word import should collapse text nodes (ranges) that have the same link attribute. This issue was already in OpenOffice 3.1.1, same behaviour in LibreOffice 3.3.2 (split links only sometimes) but LibreOffice 3.4.4 makes this problem really apparent. Anybody seen this issue? Thank you, Tomas xx.odt Description: application/vnd.oasis.opendocument.text xx2.odt Description: application/vnd.oasis.opendocument.text ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
Hi Julien, On Wed, Dec 14, 2011 at 11:03:15PM -0800, julien2412 wrote: Hello, This morning I'm still angry about this tracker. I read it yesterday and spoke my mind on IRC dev channel. I was glad I wasn't alone to think this easyhack is nonsense. I put a quick comment on this tracker but guys, I'd like to know your opinion about this even it's not a dev subject. Though I can't care less about LibreOffice having a picture of dog or not, I'm really offended by your Islamophobic remarks, so please save us this nonsense. This is a software project, if you have some political, cultural or religious agenda, please take it somewhere else. Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] split links, word import issue?
[ forwarded to qa-list ] Tomas Hlavaty wrote (15-12-11 12:06) Hi all, I created a document xx.odt with a link. Then I saved the link as [...] Anybody seen this issue? -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] dog jokes ...
Hi Julien, On Wed, 2011-12-14 at 23:03 -0800, julien2412 wrote: This morning I'm still angry about this tracker. It is an easy hack :-) it is a somewhat light-hearted one designed to attract and amuse volunteers - so yes it is partly a joke - but it's not designed to make you angry. Its also an easy-to-do one. Personally I rather like dogs too, and find it hard to understand why others would not - then again, I don't quite get why you're angry - it'd be good to understand that in more detail. I read it yesterday and spoke my mind on IRC dev channel. I was glad I wasn't alone to think this easyhack is nonsense. ... I put a quick comment on this tracker but guys, I'd like to know your opinion about this even it's not a dev subject. You actively want to stop someone else from replacing an image that people almost never see (that may cause offence to some of our users), with another image that people almost never see (that is far less likely to offend anyone) :-) ? Other examples of this sort of gut-wrenching problem comes around flags and/or maps. As soon as you put a map anywhere with borders on it - you offend someone ;-) this is why airlines flying over Asia tend to have no borders maps[2] on their flights. Does that mean by removing them we are not backing A.B.C democracy's claim over D.E.F totalitarian state's claim to G.H.I chunks of strategically important land ? you just can't win here really. How about flags - do we, or do we not recognise Taiwan as a nation worthy of a flag: whatever the choice is you get to offend someone. In these cases, mostly people don't ship flags, or don't put borders on etc. it's a bit of a lame-ass cop-out, for sure - but it helps us work together. Anyhow, the easy-hack is more trivial to fix than to discuss at length :-) Hopefully this helps convince you that I'm not some sort of illiberal ogre suggesting an easy easy hack like that ? :-) ATB, Michael. [1] - http://en.wikipedia.org/wiki/Swastika is rather interesting. [2] - not just sitting on the fence: there is no fence ! :-) -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] gbuild'ified salhelper
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4312af08cbd8c69ba4bead9608f3bf549caf7a0 converts salhelper to gbuild directly on master (rather than on feature/gbuild branch, should help us find out faster if it breaks on some platform). Technically its the earliest feature/gbuild-changeset cherry-picked, plus additional modifications to keep salhelper backwards compatible. See the commit message for details. I tried this on Linux and Mac OS X, and I *think* it should not break anything on Windows (fingers crossed). At least on Mac, the resulting salhelper library is substantially larger than the old dmake-based one, I'm investigating that. Björn, Michael, some of those changes are rather bad hacks, maybe one of you can add some gbuild magic to improve them to something acceptable. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
2011/12/15 Stephan Bergmann sberg...@redhat.com: On 12/15/2011 10:58 AM, Tomáš Chvátal wrote: So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you Hard to tell without a backtrace. Thats the problem these things do not crash when run in the submodule attached to gdb. IIUC, make build will omit the checks (and make unitcheck will execute them). Stephan That would be awesome to see implemented. Tom ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 43422, which changed state. Bug 43422 Summary: Spell check: Crash Runtime Error with AutoSpellcheck https://bugs.freedesktop.org/show_bug.cgi?id=43422 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
On Thu, 2011-12-15 at 13:14 +0200, Khaled Hosny wrote: I'm really offended by ... This is a software project, if you have some political, cultural or religious agenda, please take it somewhere else. I'm sorry you're offended Khaled; this is (I suspect) a consequence of our growth - that we have a diverse and healthy project: so we can now start the infighting ! :-) I'm well aware that many people will not like many of the things that I stand for, and be offended by some of my opinions :-) personally I'd like to hope that I can still air them from time to time, and people will put up with me: IMHO having some secularness and blandness censorship filter of discourse on IRC will only create other channels that people will migrate to. Endless discussion on these topics tends only to divert people from the hard business of learning about others trying to understand, love them (not their opinions), and work together to do something good we all agree on. Anyhow - both you and Julien do fantastic work on LibreOffice which I (for one) value immensely. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
On Thu, Dec 15, 2011 at 12:49:41PM +0100, Tomáš Chvátal wrote: IIUC, make build will omit the checks (and make unitcheck will execute them). (for gbuildified modules, build.pl modules will still run tests) Stephan That would be awesome to see implemented. It is (unless I broke it with the last major gbuild -- it should be easy to fix then). That said, I really have a bad feeling about letting end users compile distro builds without running these tests -- the last thing we need is additional bugzilla workload by builds that should never have finished/installed. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] gbuild conversion module status
hi all, if you consider converting a module to gbuild, please first take a look at this brand new Wiki page, and add your name to the remarks column, so we don't end up with 3 people doing the same thing: http://wiki.documentfoundation.org/Development/Build_System/Module_status people who have already converted modules in feature branches, please add that info to the page! thanks, michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
Hi, On Thu, Dec 15, 2011 at 11:58:52AM +, Michael Meeks wrote: I'm well aware that many people will not like many of the things that I stand for, and be offended by some of my opinions :-) personally I'd like to hope that I can still air them from time to time, and people will put up with me: IMHO having some secularness and blandness censorship filter of discourse on IRC will only create other channels that people will migrate to. I am having a quite different mindset as Michael on the topic of religion, but I fully agree here. As for the original topic: Have you actually seen that dog? Its rather ugly and seems to be used as a placeholder where a dog is indeed inappropriate regardless of religion. As for the censorship: Lets keep some wellnatured teasing on IRC, it would not be fun without it. But lets also try to not offend others intentionally. Best, Bjoern -- I disapprove of what you say, but I will defend to the death your right to say it. -- Evelyn Beatrice Hall ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
Hi Julien, if you find the current explanation why the dog should go unconvincing, let's look at it from a different angle: how does it fare as a preview image? I'd say: okay-ish, but it's not great, a more conventional image would definitely work better. So, even if the bug was started for the wrong reason (I don't really think it was), there are other justifications for going through with it. Also, please note that the vast, vast, vast majority of Muslims aren't Taliban, I think it should be obvious why such a comment when said in earnest would be offensive to any Muslim contributor. As Khaled said: please keep your politics at home, especially if they're so uninformed by facts. Astron. (Arügh... sent that to Khaled only, not to the list at first...) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] symbol visibility, windows, 3-5
Looking at fdo#43422 and now looking at fdo#43707 I see that for some reason we are not exporting component_getFactory symbols under windows from some dmake-built uno libs. Anyone know when these last worked ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
On Thu, Dec 15, 2011 at 11:58:52AM +, Michael Meeks wrote: On Thu, 2011-12-15 at 13:14 +0200, Khaled Hosny wrote: I'm really offended by ... This is a software project, if you have some political, cultural or religious agenda, please take it somewhere else. I'm sorry you're offended Khaled; this is (I suspect) a consequence of our growth - that we have a diverse and healthy project: so we can now start the infighting ! :-) May be offended was a strong word, it should read concerned about the attitude, it is a little hypocritical to ask others to respect your culture while you are showing no respect to theirs, after all LibreOffice users are not French immigrants who have to either accept the French ideals or return back to their homes. I'm well aware that many people will not like many of the things that I stand for, and be offended by some of my opinions :-) personally I'd like to hope that I can still air them from time to time, and people will put up with me: IMHO having some secularness and blandness censorship filter of discourse on IRC will only create other channels that people will migrate to. It is not about personal opinion, everyone is free to say whatever he likes, but suggesting that it should be a project policy to accept only culture X values and implying it is inherently superior than culture Y values is no longer a personal opinion. Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
2011/12/15 Bjoern Michaelsen bjoern.michael...@canonical.com: It is (unless I broke it with the last major gbuild -- it should be easy to fix then). That said, I really have a bad feeling about letting end users compile distro builds without running these tests -- the last thing we need is additional bugzilla workload by builds that should never have finished/installed. Looks like it is broken then :) As the crashes are in tail-build so gbuildified and i run this in the package: 458 src_compile() { 459 # this is not a proper make script and the jobs are passed during configure 460 make build || die 461 } 462 463 src_test() { 464 make check || die 465 } ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] gbuild conversion module status
On 15 December 2011 13:11, Michael Stahl mst...@redhat.com wrote: http://wiki.documentfoundation.org/Development/Build_System/Module_status people who have already converted modules in feature branches, please add that info to the page! done thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] symbol visibility, windows, 3-5
On Thu, 2011-12-15 at 12:43 +, Caolán McNamara wrote: Looking at fdo#43422 and now looking at fdo#43707 I see that for some reason we are not exporting component_getFactory symbols under windows from some dmake-built uno libs. Anyone know when these last worked ? Alright, tracked down the offending commits. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] unit-test dependencies (Re: Tests on release build)
On 15/12/11 11:34, Stephan Bergmann wrote: On 12/15/2011 10:58 AM, Tomáš Chvátal wrote: So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you Hard to tell without a backtrace. our new so-called unit tests are not as reliable as i would like: i have seen this in build from scratch myself, sometimes the hwpfilter test crashes, and it never happens when building only that module. i guess the reason is probably that it needs some library loaded via UNO, and concurrently with the test another process overwrites that library (have seen exactly that with a test in sw and fixed it), making the test very unhappy. the problem i see is that most of our CppUnit test are not really unit tests but system level tests, and really need most of a full office with UNO stuff and configuration to run. figuring out which UNO components are needed to run the test is a real pain and so of course lots of dependencies are missing. we wouldn't have this problem if these were subsequenttests; it would even be possible to run them when rebuilding a single module with something like make build make subsequenttests (perhaps make check in a module should do that?), just not on the build from scratch. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)
On 12/15/2011 01:56 PM, Michael Stahl wrote: we wouldn't have this problem if these were subsequenttests; it would even be possible to run them when rebuilding a single module with something like make build make subsequenttests (perhaps make check in a module should do that?), just not on the build from scratch. If the build from scratch were done as make check (and who doesn't do that, anyway?), they would be included even then. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
Hi again, I answered to Mike and Khaled personally, i should have cc the forum too. Just to sum up what I told them : first : it's not a personal attack against anyone, all of you guys do a great job and brought me friendly help when i needed. Then : of course the vast majority of muslims, like christians, jews, ... are moderate. But I would'nt like LO to lose its independance because of a simple image of dog. (ok the image should be changed to a better one :-) ). If some want a Hallah/Casher/Christian OK LO, I don't care, they can use automatic scripts to remove what they consider to be offending for them. But LO original should stay independant. I know that some of you have struggled really hard to be independant from Oracle with this fork and it's great, but everyone must struggle harder to stay independant. I don't know if it's a French ideal, it's just the fact that an image of dog should'nt possibly offend anyone. Julien. -- View this message in context: http://nabble.documentfoundation.org/Tell-me-Easy-Hack-42782-remove-a-dog-is-a-joke-tp3587827p3588492.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Mozldap switch
On Tue, Dec 13, 2011 at 10:40:25AM +0100, Tomáš Chvátal wrogte: I tried to implement simple mozldap system switch to update from the older-than-sun bundled firefox [1]. You seem to remove support for OpenLDAP; any reason for that? -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANN] LibreOffice 3.4.5 RC1 test builds available
Hi *, for 3.4.5 RC1, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases-3-4/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs vs. 3.4.4 is available here http://dev-builds.libreoffice.org/pre-releases-3-4/src/bugfixes-libreoffice-3-4-release-3.4.5.1.log , it would be nice to verify they're really fixed in the build. Thanks so much for your help, -- Thorsten pgp00USbQEg15.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)
On Thu, 2011-12-15 at 13:56 +0100, Michael Stahl wrote: we wouldn't have this problem if these were subsequenttests but then no one would run them :-), I still feel its far better to try and track down and fix the dependency or parallel test problem, whatever it is, then move things into a subsequenttest because if the immediacy of make to pass/failure isn't there I just have no faith that people as lazy as me will run them :-( C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Mozldap switch
Dne 15. prosince 2011 14:13 Lionel Elie Mamane lio...@mamane.lu napsal(a): On Tue, Dec 13, 2011 at 10:40:25AM +0100, Tomáš Chvátal wrog te: I tried to implement simple mozldap system switch to update from the older-than-sun bundled firefox [1]. You seem to remove support for OpenLDAP; any reason for that? Yep, because even if that thing did build with openldap backend I was unable to make it work. It is also not working in SUSE so I just expected it to be uttery broken and rather drop it completely. Tom ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
On Thu, Dec 15, 2011 at 05:05:34AM -0800, julien2412 wrote: I don't know if it's a French ideal, it's just the fact that an image of dog should'nt possibly offend anyone. True, if you consider only one culture, the fact is that the world is vastly different and what can't possibly offend anyone in one culture can be highly offensive in another. LO should not dictate that that a certain culture is superior to others, and if we can remove a possibly offending item to certain people, what harm can be caused by that? Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] postresql-sdbc bits out of minutes of tech. steering call
On Mon, Dec 12, 2011 at 10:32:26AM +0100, Lionel Elie Mamane wrote: On Mon, Dec 12, 2011 at 09:46:37AM +0100, Fridrich Strba wrote: On 12/12/11 08:14, Lionel Elie Mamane wrote: This also means that by our we have to build everything we ship rule, we have to internalise, according to my first quick survey: - MIT Kerberos: - Kerberos for Windows: that's not part of the OS - internalise (http://web.mit.edu/kerberos/dist/index.html#kfw-3.2) Do we really really need this on Windows? It depends what value we give to really. So, I asked on the PostgreSQL devs mailing list. Briefly the answer is that MIT Kerberos on Windows is bitrotten, unmaintained and a pain in the backside: open security bugs will likely not be fixed soon, etc. Other software in the PostgreSQL ecosystem have stopped linking against it. As to what feature is lost: - On Windows XP, any kind of decent crypto in the context of Kerberos authentication. - On Windows 7, the system Kerberos is actually quite OK. So, all in all, we better *not* link against MIT Kerberos on Microsoft Windows. That is our current situation, no change needed, just for your information ( vindication). -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
Hi all I don't know if it's a French ideal, it's just the fact that an image of dog should'nt possibly offend anyone. as a newbye, with ideals too, and most important I'm french, i would highly prefer that we speak about cats ! a highly cultural matter concerning Lovecraft lovers please guys, stop this ... Laurent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Simpler logging using a string format function
On Thursday 15 of December 2011, Stephan Bergmann wrote: On 12/13/2011 07:56 PM, Lubos Lunak wrote: But it might the moment you realize you're trading away things like SAL_INFO( foo, 1 2 ) or SAL_INFO( foo, bar baz ). Trading away the former, having to parenthesize (1 2) instead, is a std C++ trade-off. Granted, omission of the leading ostream in the macro call makes this somewhat non-obvious. What is traded away in the latter case? The bar baz, which, at first glance, is nonsense. Code is not only written, it is also read, and many more times. Anyway, bikeshedding about surface syntax is rather pointless. Well, I did say that longer exposure to this codebase makes people oblivious to bad API, didn't I? This is not bikesheding. This is adding yet one more case of ugly API to the codebase, and while it's not tragically fugly and neither are most of the other, it simply all adds up and the result is a fugly codebase where even adding two strings together is an exercise. And it will not get better if such stuff will keep getting added because surface syntax, the thing developers deal with most of the time, is supposedly rather pointless. - Artificially limited to 9 arguments. You can sure always extend that, but it's more work than not having to worry about it. Hmm. How often is that going to be needed? With creative uses of SAL_WARN/INFO, I wouldn't be too sure. ;) (And as I already said, none of those are critical shortcomings, only indicators to me that swapping implementations were not worth it if the only benefit were a different syntax.) It's not a big deal to add letters too for creative uses and 37 arguments to a log call is as implausible to be next to unrealistic. - No check that there are neither more nor fewer arguments than %Ns (or that the set of %Ns spans a range 1--M without holes). There's a todo note, not that I think it matters that much if whoever does that runs the code at least once. Note that at least SAL_WARNs will typically *not* be run by the code authors. (Who goes to the pains of crafting a scenario to make each new SAL_WARN actually trigger, by temporarily modifying the code around it or creating an appropriate runtime environment?) Hmm, right. Ok, forget the format. I can make it SAL_INFO( foo, string , s, of length , n ) and that solves most of your objections I believe, while still keeping most of the advantages compared to the ostream approach. Well, that's another advantage of the format approach then. It's an inconvenience to have to explicitly say the format string is utf-8 (and arguments probably as well), but then this conversion can be again limited just to logging and not to every std::ostream operation. Yes, having the message in UTF-16 is an advantage here. For the ostream-based approach, we need to wait for general availability of C++11's char16_t. They are log messages. They are written in English. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] please pick those two build-related commits for libreoffice-3.5 (XCode 2.5 build breaker download → use same branch for the clones)
Hi *, please pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a845f988e6b5ec50ddda123cf761d8541c005fa (change to download, so that when using linked git repos, git-new-workdir will checkout the same branch as the core repo) and http://cgit.freedesktop.org/libreoffice/core/commit/?id=f56780576fa8c28cd212ddfffc554cee40698009 (build fix for Mac OSX 10.4 / XCode 2.5 where -dead_strip_dylibs is not supported - the makefile in libreoffice-3.5 uses .IF .ELSE construct instead of $(eq,...), but the idea is the same, just remove the flag - on Mac there is not much cruft linked to begin with) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Simpler logging using a string format function
On 12/15/2011 02:57 PM, Lubos Lunak wrote: On Thursday 15 of December 2011, Stephan Bergmann wrote: On 12/13/2011 07:56 PM, Lubos Lunak wrote: But it might the moment you realize you're trading away things like SAL_INFO( foo, 1 2 ) or SAL_INFO( foo, bar baz ). Trading away the former, having to parenthesize (1 2) instead, is a std C++ trade-off. Granted, omission of the leading ostream in the macro call makes this somewhat non-obvious. What is traded away in the latter case? The bar baz, which, at first glance, is nonsense. Code is not only written, it is also read, and many more times. Still don't get what you mean. You mean, bar baz should be forbidden by the compiler, making sure one writes barbaz instead? Anyway, bikeshedding about surface syntax is rather pointless. Well, I did say that longer exposure to this codebase makes people oblivious to bad API, didn't I? This is not bikesheding. This is adding yet one more case of ugly API to the codebase, and while it's not tragically fugly and neither are most of the other, it simply all adds up and the result is a fugly codebase where even adding two strings together is an exercise. And it will not get better if such stuff will keep getting added because surface syntax, the thing developers deal with most of the time, is supposedly rather pointless. I still think neither approach is more beautiful than the other. But that's subjective, of course. Well, that's another advantage of the format approach then. It's an inconvenience to have to explicitly say the format string is utf-8 (and arguments probably as well), but then this conversion can be again limited just to logging and not to every std::ostream operation. Yes, having the message in UTF-16 is an advantage here. For the ostream-based approach, we need to wait for general availability of C++11's char16_t. They are log messages. They are written in English. Erm, are we talking past each other here? The fully composed log message, with string arguments placed into it, somehow needs to handle the UTF-16 string arguments placed into it. All I wanted to say is that your approach, building up the fully composed message as rtl::OUStringBuffer, shields client code from having to specify how to translate any rtl::OUString arguments into the proper format. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] please pick those two build-related commits for libreoffice-3.5 (XCode 2.5 build breaker download → use same branch for the clones)
Hi *, was told that there is no sign-off needed yet for the branch, so pushed myself :-) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Simpler logging using a string format function
On Thursday 15 of December 2011, Stephan Bergmann wrote: On 12/15/2011 02:57 PM, Lubos Lunak wrote: The bar baz, which, at first glance, is nonsense. Code is not only written, it is also read, and many more times. Still don't get what you mean. You mean, bar baz should be forbidden by the compiler, making sure one writes barbaz instead? No. I mean that 'foo( bar baz )' is incorrect C++, unless foo is a macro that does some hidden magic behind the scenes that changes the meaning. And not only it's incorrect, it's also not obvious. Of course, one can learn this case, and add it to the hundreds of other cases that we already have where one either knows it or bumps into it and has to start digging around. When was the last time somebody has run e.g. into UNO's = operator (and that one actually is somewhat more obvious that this)? Well, that's another advantage of the format approach then. It's an inconvenience to have to explicitly say the format string is utf-8 (and arguments probably as well), but then this conversion can be again limited just to logging and not to every std::ostream operation. Yes, having the message in UTF-16 is an advantage here. For the ostream-based approach, we need to wait for general availability of C++11's char16_t. They are log messages. They are written in English. Erm, are we talking past each other here? The fully composed log message, with string arguments placed into it, somehow needs to handle the UTF-16 string arguments placed into it. All I wanted to say is that your approach, building up the fully composed message as rtl::OUStringBuffer, shields client code from having to specify how to translate any rtl::OUString arguments into the proper format. I was talking about the strings on the input of the log call. If the syntax is SAL_INFO( area, File , file, not found. ), then File and not found. can be converted automatically using utf-8, because it's just a log message, so it's very likely only English anyway, and it's a perfectly fine way of avoiding the truly horrible SAL_INFO( area, RTL_CONSTASCII_USTRINGPARAM( File ), file, RTL_CONSTASCII_USTRINGPARAM( not found. )). At the same time, it does not introduce this automatic conversion anywhere else, as the ostream-based operator can. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
It is quite easy to get the dog image displayed and it shows up in the Picture dialog replacing the missing image... That can be offending in any culture, especially if the image replaced is of a person and the image replacing it is an offense for your culture (imagine your picture replaced by a pig or an ass (the animal, obviously :) ) In any case the picture is not particularly helpful or useful. The problem is: what do you replace it with? You can't use what would be more helpful (a plain image with text saying Image not found) because that would require to have an image in every language supported by LO, which IMO is a waste of time and resources. Can't this image be replaced by a Text message in the GUI language? Peace! ;) -- View this message in context: http://nabble.documentfoundation.org/Tell-me-Easy-Hack-42782-remove-a-dog-is-a-joke-tp3587827p3588920.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] assertion in SwIndexReg::~SwIndexReg
On Thu, 2011-12-15 at 08:56 +0100, Stephan Bergmann wrote: On 12/15/2011 12:59 AM, Terrence Enger wrote: [snip] How on earh can soffice.bin know that I did anything in gnome-terminal? Due to the clipboard being a resource shared across all applications. aside audience=self Calm down, Terry. Stop sputtering. This *is* a GUI environment, so you have to expect notifications of things to be flying around everywhere, even between applications, and even if you do not understand why LibreOffice should care about the clipboard when it is doing neither a copy nor a paste. Just accept it. Nowhere is it written that you will understand everything. /aside Stephan, So, I take it, the helpful question to investigate is the reason why the state of the object violates the expectation--the expectation that the container is empty-- that the destructor asserts. Or, coming from the opposite side of the question, why should the destructor expect the container to be empty by that time? With luck, I shall be able to progress a little bit in that direction before I have to ask for help again. Thank you for your help. Terry. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Hi ! We are new on libo!
Hi Michael Fernand ! The preview feature isn't in the scope of what we would like to do for the moment, but if we've got the occasion, we'll have a look at it. Thank you for the hint about FTP connections, we'll see what we can do to deal with this issue. We looked at this project on Elveos, but Julien and I believe we aren't yet experienced enough with the codebase to fulfill the mission. Cheers, Martin 2011/12/14 Fernand Vanrie s...@pmgroup.be Martin, I am a Belgium user of OO en LO, and have sometimes contact with your mentor Cédric. As you will working at the filepicker, please have also a look at the preview when choosing pictures it simply never has worked. When working at the FTP site, there is also a problem, on some servers it works to have a ftp-url to store ad some servers the connection is refused, i think we need some extra parameters for FTP connections (as passive-active) I hopes this comments can inspire your project Greetz Fernand ps. please have also a look at our Elveos projecthttps://elveos.org/en/features/1185/description?title=add-print-intentions-to-a-libre-open-office-documentit is Funded but no candidates to do the work, maybe you or one of your friends is interested ? Hi all, I am Martin Richard, a French student in CS. As a school project, a friend and I have the luck to be able to work on Libre Office Writer, mentored by Cédric Bosdonnat. We will work on the libre-office file picker in order to add some new interesting features, such as a list of highlighted places, allowing direct access to recently used files, favorites directories and FTP servers. At last, we would like to contribute to Cedric's library libcmis and continue his work of integration of repositories implementing CMIS (sharepoint, alfresco, etc). I'll probably be active on IRC under the nickname martius during the next weeks. My friend Julien will probably come forward soon. Cheers, Martin ___ LibreOffice mailing listLibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice -- Martin http://www.martiusweb.net Richard www.martiusweb.net http://www.martiuweb.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
In the same way, we should remove all the drawing tools too because someone could use a personal photo and change it to make the person ridiculous... We should also add some autocorrect to prevent the writing of rude words... The pb is not the tool, it's what you do with it (think about all these things you use in everyday life : knives, hammers, a stick of wood, almost everything could be a weapon...) Salam/Shalom/peace/pax/paix/... ;-) -- View this message in context: http://nabble.documentfoundation.org/Tell-me-Easy-Hack-42782-remove-a-dog-is-a-joke-tp3587827p3589062.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use -gdwarf-4 by default if possible (was Re: Even more debugging info)
On Thursday 08 of December 2011, Lubos Lunak wrote: On Wednesday 07 of December 2011, Michael Meeks wrote: On Thu, 2011-12-01 at 17:35 +0100, Lubos Lunak wrote: So -gdwarf-4 looks like a sensible default to me. Even if not, I'm going to use it (quick hack: modify your LO make script to add it to $CXXFLAGS). So, how about the attached patch? If it's ok, I will still wait until 3.5 has been branched off, just in case. I also have no idea if this should be enabled for the WNT_INTEL_GCC target too, but it and unxgcc were the only two to use -ggdbX flags. Sounds lovely to me :-) if it makes building with symbols smaller and faster it sounds ideal. Pushed, now that 3.5 has been branched. If there are any problems with this, yell. Just for the record, I've reverted this. Reportedly even gdb 7.1 is not new enough for this, and moreover while this in theory is supposed to make gdb faster and use less memory, in practice the handling in gdb seems to have problems that actually make gdb slower and use more memory. The flag may be still useful for people who want smaller binaries and don't use gdb for much more than backtraces, but it's apparently not a good default for the time being. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Make gbuild output [build CXX] filename also with the .cxx extension
On Wednesday 14 of December 2011, Bjoern Michaelsen wrote: Hi Lubos, On Wed, Dec 14, 2011 at 04:45:29PM +0100, Lubos Lunak wrote: I find it mildly annoying that gbuild outputs [ build CXX ] starmath/source/types, without the .cxx extension, i.e. a non-existent file. Especially since other target types like LNK do output [ build LNK ] Library/libsmlo.so. Any objections to the attached patch? Just some pedantic academics: If anything, the target you are building (and announcing) is foo.o, not foo.cxx. But I wont waste more keypresses on this, if you insist to make that on .cxx. It appears to be the common practice with other build systems (dmake, cmake) in non-verbose mode to print the .cxx source file name when compiling and .so file name when linking, as those are the ones that matter in that process. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)
On Thu, 2011-12-15 at 13:18 +, Caolán McNamara wrote: On Thu, 2011-12-15 at 13:56 +0100, Michael Stahl wrote: we wouldn't have this problem if these were subsequenttests but then no one would run them :-), I still feel its far better to try and track down and fix the dependency or parallel test problem, whatever it is, then move things into a subsequenttest because if the immediacy of make to pass/failure isn't there I just have no faith that people as lazy as me will run them :-( I tend to agree. If we have obscure crashers for our unit tests during make - then we should fix them :-) Oddly hwpfilter (two of the three reports) is included into tail_build, and thus it's prj/build.lst dependencies are irrelevant, it should be in the new, pristine world of gnumake-ness. Which makes this distinctly odd. Those files should not be moving around after creation - surely ? and make is all a single process, so it'll wait until the file creation rule is complete before relying on it rather than statting and finding a 1/2 done file. Seemingly tail_build depends on fpicker which depends on ucb - so the ucb1, ucbfile1 components should be in-place. Like Michael S, I too have seen this intermittently fail too - which is deadly annoying. I guess we could add a '--disable-unit-tests' configure option for Gentoo-ers. Odd, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 43707, which changed state. Bug 43707 Summary: FILEOPEN PDF brings up (ASCII) filter selector instead of opening document https://bugs.freedesktop.org/show_bug.cgi?id=43707 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Mozldap switch
On Thu, Dec 15, 2011 at 02:19:50PM +0100, Tomáš Chvátal wrote: Dne 15. prosince 2011 14:13 Lionel Elie Mamane lio...@mamane.lu napsal(a): On Tue, Dec 13, 2011 at 10:40:25AM +0100, Tomáš Chvátal wrog te: I tried to implement simple mozldap system switch to update from the older-than-sun bundled firefox [1]. You seem to remove support for OpenLDAP; any reason for that? Yep, because even if that thing did build with openldap backend I was unable to make it work. It is also not working in SUSE so I just expected it to be uttery broken and rather drop it completely. The Debian packages are built against OpenLDAP. I guess that if it were utterly broken (in 3.4), some Debian user would have noticed? I'd be glad to explicitly check it out if you give me a LibO/LDAP-noob proof test script. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)
On 15/12/11 17:37, Michael Meeks wrote: On Thu, 2011-12-15 at 13:18 +, Caolán McNamara wrote: On Thu, 2011-12-15 at 13:56 +0100, Michael Stahl wrote: we wouldn't have this problem if these were subsequenttests but then no one would run them :-), I still feel its far better to try and track down and fix the dependency or parallel test problem, whatever it is, then move things into a subsequenttest because if the immediacy of make to pass/failure isn't there I just have no faith that people as lazy as me will run them :-( I tend to agree. If we have obscure crashers for our unit tests during make - then we should fix them :-) Oddly hwpfilter (two of the three reports) is included into tail_build, and thus it's prj/build.lst dependencies are irrelevant, it should be in the new, pristine world of gnumake-ness. Which makes this distinctly odd. Those files should not be moving around after creation - surely ? and make is all a single process, so it'll wait until the file creation rule is complete before relying on it rather than statting and finding a 1/2 done file. well that of course would be the case if the dependencies in the test makefile were complete. which they apparently are not. which is in no way obvious. which is my point. Seemingly tail_build depends on fpicker which depends on ucb - so the ucb1, ucbfile1 components should be in-place. and i have already wasted half an hour looking at the libraries the darn thing loads and couldn't find anything obvious that was missing... Like Michael S, I too have seen this intermittently fail too - which is deadly annoying. I guess we could add a '--disable-unit-tests' configure option for Gentoo-ers. cultural_stereotype hmm, presumably Gentooers don't care that much whether the stuff they build actually works as long as it's fast :-P /cultural_stereotype ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Em 15-12-2011 13:22, Pedro escreveu: (snip useless references) In any case the picture is not particularly helpful or useful. The problem is: what do you replace it with? A big question mark ?, a traffic danger sign (yellow triangle with an exclamation mark)?, a ripped sheet of paper? a broken glass of water? You can't use what would be more helpful (a plain image with text saying Image not found) because that would require to have an image in every language supported by LO, which IMO is a waste of time and resources. Can't this image be replaced by a Text message in the GUI language? good as well. Fact is: the icon is used and should not be removed, but can be enhanced. Kind Regards and seasons greetings. - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO6ijKAAoJEJp3R7nH3vLxQZMH/iPPWz355mrYw7z7ArTZM30r tYxOSzaVbLCYrB6TYcrble7cE1Sysd+g8P1lGRGU++bbRXtxzZkU3oZIHERwicqh KumBOoDJrdpzx4Gpd8tEXv14rv6/cNQeZ7yh5nR9LvANYU2JyODjdVVKLd9Pu2CY fbMqqr+yrOX2zmr/8FLZIL7q0CPsoDj4IoroCDE5zMOoKhNrVCWjKAfDFHft6iE6 14Nc+rC2ClXFpoqyqWOqBYA2V1FtvKzwPZd2wmpKhImcogczdBpgLzT1Mtz1F0aH 5vpY9CCqy6LpxzUbOV6X/UYdRzIHBisht7Q4VT+CJpvemQgryyYsXoD9u2ueaP0= =hzRk -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] minutes of tech. steering call ...
* Present: + Rainer, Michael Stahl, Christian, Norbert, Cor Nouws, Bjoern, Lionel, Stephan, Eike, Kendy, Caolan, Cedric, Petr, Lubos * Completed Action Items + create 'lightproof' git repo on freedesktop for Laszlo (Michael) + review pending labels patch if possible (Bjoern) + cherry-pick lightproof to Beta2 (post Beta1) (Andras) + disable gtk3 except in experimental mode (Michael) + add this layout feature into a product build (Cedric) + make it dependent on a getenv() to avoid callcatcher + need to download install libpostgresql for Mac/Windows (Fridrich) + enable Java 7 in 3.4.5, suck and see in RC1 (Stephan) + add fixing bugassistant to top #10 easy tasks page (Petr) * Pending Action Items + [slow progress] extract 64bit build hardware from firewall (Kendy / Admins) + [in progress] come up with a list of QA heros (Rainer) + add tinderbox name to build-id (Norbert) + cleanup old test build server directories (Thorsten) + setup linux build system to build gtk3 support by default for this (Michael) + rename VCL API to make it GetBeamerFoo fix (Michael) + get Rainer setup with git commit access (Michael) + forward access details to Thorsten (Rainer) * Action Items * Sexy new type-safe small printf / format logic (Lubos) AA: + make it clear the SAL_INFO etc. macros are internal only for 3.5 (Stephan) + delay changes strings until LibO 4 ? (Stephan) + not necessarily the printf format; faster without it (Lubos) + just fixing the '+' operator can help too (Lubos) + consensus for inclusion of printf style in master if Lubos wants to do it * Release Engineering update (Petr) + 3.5.0 B1 is out + first feedback from pre-release: good. + much better than Beta 0 / a promising start + thanks to all that helped + 3.5.0 B2 + tag / deadline on Monday + 3.4.5 - tag delayed by two days + builds already on pre-release ftp site, synching to mirrors for announce soon, delay not that large in the end. + branch libreoffice-3-4-5 for this release + most-annoying bugs important for release * QA - bug hunting sessions (Cor) + not easy to get lots of people involved + bug hunting planned for Wed 28 / Thur 29th of December + another one planned for RC1 Jan Fri 20th / Sat 21th of Jan + promotion on TDF blog / twitter etc. + litmus and random testing * QA update (Rainer) + spreadsheet advanced filters problems, cf. mail on list + regressions discussions + component_getFactory issue is dominant (Caolan) + presenter console, language crash on popups, etc. + re-asses with fixes in master + planning to publish document + please track that query ... + http://tinyurl.com/7z9ozoc + bug hunting sessions on IRC - joining in with Cor + bugzilla submission assistant - lots of work currently + pending integration of link in the help menu for 3.5 AA: + get a permanant re-direction link for bug assistent (Thorsten) AA: + hack up the Help-File bug menu item QA awesome git bibi fun (Bjoern) + lots of binaries compressed into one git repo + allows bisection to find when it first appeared + 50+ installs into ~750Mb + built every 64th commit on master - 50% succeeded + having bisected - only a ~200 commit range + maybe visible from the git log + is it a universal install (Kendy) + built on a recent Ubuntu, but with internal libs (Bjoern) + tinderbox integration might be good + is there a script to add a package to git ? (Norbert) + script is in dev-tools (Bjoern) + could automate a once-per-day git repo creation + some of the magic is in the re-pack 4Gb - 750Mb. + Norbert to investigate it working on Mac, will it bloat up + have to copy images, not DMGs * Mitch / MSI building update (sends his regrets) * cairo / Fedora 16 etc. version nasty (Michael) + prolly specific to some (non-default) theme AA: + upgrade the internal cairo to latest stable to fix (Fridrich) + could we break things vs. an old system cairo (Petr) * postgresql bits AA: + add postgresql to 3.5 feature page (Lionel) AA: + checking pg baseline on windows (Fridrich) * Robust subsequenttests to a third category: tail_build tests (Michael/Stephan) + discuss next time: * Next time: + skip 22nd and 29th TSC calls unless an emergency strikes
[Libreoffice] postgresql bits in minutes of tech. steering call
On Thu, Dec 15, 2011 at 05:40:27PM +, Michael Meeks wrote: * postgresql bits AA: + checking pg baseline on windows (Fridrich) I had understood this as: Check Kerberos/GSSAPI on our GNU/Linux baseline, to see if we can use it as a system library. So nothing on Windows. On this, someone said on the talk we use only libc (and I implicitly understood: in the binaries we distribute). This made me feel rather bad for proposing adding MIT Kerberos to that list, but I found that a rather suspicious claim, since to my knowledge we do not internalise any of GDK, GTK, QT,/std gstreamer, gconf, fontconfig or freetype, so I checked, from our .deb packages for 3.4.4 for 64 bits (amd64 architecture). soffice.bin uses also X11 stuff (OK, I'll let that one slide as as low-level as libc as far as an X11 program is concerned...) and libfreetype. The various .so files use a non-trivial list, among which for example libgpg-error, libgtk-x11-2.0, libjpeg, libqt-mt, libpcre, libgnomevfs-2, ... So maybe I misunderstood what was being said? -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||43862 --- Comment #48 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-12-15 10:12:31 PST --- Nominate Bug 43862 - Page FORMATTING: Margin settings information not compatible with 3.4.4, breaking version interoperability is a potential blocker. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)
Hi there, On Thu, 2011-12-15 at 18:01 +0100, Michael Stahl wrote: well that of course would be the case if the dependencies in the test makefile were complete. which they apparently are not. which is in no way obvious. which is my point. Hah :-) so - one thing that I wondered about ... is - is it possible that our gnumake dependencies on .component files do not include dependencies to the libraries they are for ? such that we can build and install the .component file - without having the library already installed alongside it ? that would seem to be suggested by the need to add this explicit dep on the hwp library in the .mk file - which can't scale across modules. Do we need to have that added to gb_Library_set_componentfile ? [1] Another thing that interests me is whether there could be a race between the workdir and solver instances of various things; presumably we depend on the solver versions though. Wrt. the non-uno pieces I took a look at the ucb/ucp d.lst and it certainly installs the dll/.so stuff before the .component files in the list - which look hopeful on that account (same for configmgr). Seemingly tail_build depends on fpicker which depends on ucb - so the ucb1, ucbfile1 components should be in-place. and i have already wasted half an hour looking at the libraries the darn thing loads and couldn't find anything obvious that was missing... Right :-) I had a go too - nothing too obvious for the specific hwp case; annoying really. HTH, Michael. [1] - I'm just a gnumake newbie of course :-) -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] postgresql bits in minutes of tech. steering call
On Thu, 2011-12-15 at 19:11 +0100, Lionel Elie Mamane wrote: On this, someone said on the talk we use only libc (and I implicitly understood: in the binaries we distribute). You have to be quite careful with claims from Fridrich, they are often exaggerated for comic effect :-) Sorry for fluffing the system up though, ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Candidate patch for integration?
Hi Muthu, On Thu, 2011-12-15 at 17:03 +0530, Muthu Subramanian K wrote: I had written this patch quite some time back: https://issues.apache.org/ooo/attachment.cgi?id=68593action=diff Related to https://bugs.freedesktop.org/show_bug.cgi?id=33602 I assumed this was in go-oo.org and also made it to libreoffice, but I guess I was wrong. Looks rather non-controversial to me; IIRC we're storing similar stuff for the CSV import in the settings. I'd be happy to have it in libreoffice-3-5 if you can get another couple of 'acks' but the sooner the better if it goes in there :-) HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] License statement: Gustavo Buzzatti Pacheco
All my contributions to LibreOffice are licensed under the MPL/LGPLv3+ dual license. Gustavo Buzzatti Pacheco. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix for fdo43460 Part X getLength() to isEmpty()
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please find attached a partial fix for Easy Hack FDO43460 Part X Module cppu cppuhelper cpputools - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO6kwGAAoJEJp3R7nH3vLx3iEH/RbmYWDFir8eFwucl/tAoMFE dy00/adJQeE6Fhn4JfUtYiG4VTl4uLwBHN0MhoAcaxIXQ/Zr4vwMqWGCVYbxqLS4 0xlApf+yWZqx87NKAkpKvELkP4v37jJFtX0i81xFQCUtyaHM2tA7pWJjnHIW1kVK sL+UxoOFNFdxfn5g6fJkd89cPKMUGRwPfPGEe0IzGyqmiQr8eF8q6u/6aBr0z25L BMVcESBOI31HXI6mLWKNylvB4y5nAkZjpapWuQdMyo57+wgfrjj7QNEIdNGuDcXQ eJjrWq6+WhXGTsbuvXHyx9ffXuSK7Ml9hS4a7YW2nhm60sZ+TQRtp+PmBLaFHWE= =vOfW -END PGP SIGNATURE- From 336a40c2fa4dbac7160722e82f97ed481f42a67b Mon Sep 17 00:00:00 2001 From: Olivier Hallot olivier.hal...@alta.org.br Date: Thu, 15 Dec 2011 17:29:53 -0200 Subject: [PATCH] Fix for fdo43460 Part X getLength() to isEmpty() Part X Module cppu cppuhelper cpputools --- cppu/source/uno/EnvStack.cxx |2 +- cppu/source/uno/lbenv.cxx |4 ++-- cppu/source/uno/lbmap.cxx |6 +++--- cppuhelper/source/bootstrap.cxx|8 cppuhelper/source/component_context.cxx|2 +- cppuhelper/source/factory.cxx |2 +- cppuhelper/source/propertysetmixin.cxx |2 +- cppuhelper/source/propshlp.cxx |8 cppuhelper/source/servicefactory.cxx | 14 +++--- cppuhelper/source/shlib.cxx|4 ++-- .../source/registercomponent/registercomponent.cxx | 16 cpputools/source/regsingleton/regsingleton.cxx |2 +- cpputools/source/unoexe/unoexe.cxx | 18 +- 13 files changed, 44 insertions(+), 44 deletions(-) diff --git a/cppu/source/uno/EnvStack.cxx b/cppu/source/uno/EnvStack.cxx index d1ff292..9542440 100644 --- a/cppu/source/uno/EnvStack.cxx +++ b/cppu/source/uno/EnvStack.cxx @@ -203,7 +203,7 @@ static int s_getNextEnv(uno_Environment ** ppEnv, uno_Environment * pCurrEnv, un res = 1; } -if (nextPurpose.getLength()) +if (!nextPurpose.isEmpty()) { rtl::OUString next_envDcp(s_uno_envDcp); next_envDcp += nextPurpose; diff --git a/cppu/source/uno/lbenv.cxx b/cppu/source/uno/lbenv.cxx index 08e7035..ba3465c 100644 --- a/cppu/source/uno/lbenv.cxx +++ b/cppu/source/uno/lbenv.cxx @@ -1031,7 +1031,7 @@ inline void EnvironmentsData::getRegisteredEnvironments( iPos != aName2EnvMap.end(); ++iPos ) { uno_Environment * pWeak = iPos-second; -if (!rEnvDcp.getLength() || +if (rEnvDcp.isEmpty() || rEnvDcp.equals( pWeak-pTypeName )) { ppFound[nSize] = 0; @@ -1116,7 +1116,7 @@ static uno_Environment * initDefaultEnvironment( that-releaseInterface = unoenv_releaseInterface; OUString envPurpose = cppu::EnvDcp::getPurpose(rEnvDcp); -if (envPurpose.getLength()) +if (!envPurpose.isEmpty()) { rtl::OUString libStem = envPurpose.copy(envPurpose.lastIndexOf(':') + 1); libStem += rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(_uno_uno) ); diff --git a/cppu/source/uno/lbmap.cxx b/cppu/source/uno/lbmap.cxx index ec56c05..84e2cc7 100644 --- a/cppu/source/uno/lbmap.cxx +++ b/cppu/source/uno/lbmap.cxx @@ -312,7 +312,7 @@ static inline OUString getBridgeName( SAL_THROW( () ) { OUStringBuffer aBridgeName( 16 ); -if (rAddPurpose.getLength()) +if (!rAddPurpose.isEmpty()) { aBridgeName.append( rAddPurpose ); aBridgeName.append( (sal_Unicode)'_' ); @@ -469,7 +469,7 @@ static Mapping getMediateMapping( } // connect to uno -if (rAddPurpose.getLength()) // insert purpose mapping between new ano_uno - uno +if (!rAddPurpose.isEmpty()) // insert purpose mapping between new ano_uno - uno { // create anonymous uno env Environment aAnUno; @@ -540,7 +540,7 @@ void SAL_CALL uno_getMapping( } // See if an identity mapping does fit. -if (!aRet.is() pFrom == pTo !aAddPurpose.getLength()) +if (!aRet.is() pFrom == pTo aAddPurpose.isEmpty()) aRet = createIdentityMapping(pFrom); if (!aRet.is()) diff --git a/cppuhelper/source/bootstrap.cxx b/cppuhelper/source/bootstrap.cxx index 399af07..2fb8ccd 100644 --- a/cppuhelper/source/bootstrap.cxx +++ b/cppuhelper/source/bootstrap.cxx @@ -81,13 +81,13 @@ namespace cppu OUString const get_this_libpath() { static OUString s_path; -if (0 == s_path.getLength()) +if (s_path.isEmpty()) { OUString path; Module::getUrlFromAddress(
Re: [Libreoffice] minutes of tech. steering call ...
Hi *, On Thu, Dec 15, 2011 at 6:40 PM, Michael Meeks michael.me...@suse.com wrote: QA awesome git bibi fun (Bjoern) [...] + Norbert to investigate it working on Mac, will it bloat up + have to copy images, not DMGs nitpickDMGs are the images (disk images, similar to a iso, i.e. an in-file filesystem) - so one has to use the extracted version / the version before it gets packed. /nitpick Smoketests already creates such a flat tree, but it is also easy to mount the image and copy the files from the mounted image. (Installation on Mac works by simply copying the files from the dmg to any folder on your harddisk) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
On Thu, Dec 15, 2011 at 1:46 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: Hi *, On Thu, Dec 15, 2011 at 6:40 PM, Michael Meeks michael.me...@suse.com wrote: QA awesome git bibi fun (Bjoern) [...] + Norbert to investigate it working on Mac, will it bloat up + have to copy images, not DMGs nitpickDMGs are the images (disk images, similar to a iso, i.e. an in-file filesystem) - so one has to use the extracted version / the version before it gets packed. /nitpick Smoketests already creates such a flat tree, but it is also easy to mount the image and copy the files from the mounted image. (Installation on Mac works by simply copying the files from the dmg to any folder on your harddisk) yes that is what I meant during the call... we may get better git compression by using the content of the mounted dmg rather than committing the dmg itself (*)... but then... number will talk ultimately... I'll experiment with both and compare :-) Norbert (*) git should have a easier time to find redundancies across build that way. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 43831, which changed state. Bug 43831 Summary: Advanced FILTER incompatible with 3.4.4 documents https://bugs.freedesktop.org/show_bug.cgi?id=43831 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] minutes of tech. steering call ...
Michael Meeks wrote: + cleanup old test build server directories (Thorsten) This is done - there were beta0 builds from the Linux/Windows Release config still around, but since beta0 was not so nice anyway ... ;) + 3.4.5 - tag delayed by two days + builds already on pre-release ftp site, synching to mirrors for announce soon, delay not that large in the end. Might take a day longer, system is still syncing 3.5 + bugzilla submission assistant - lots of work currently + pending integration of link in the help menu for 3.5 AA: + get a permanant re-direction link for bug assistent (Thorsten) AA: + hack up the Help-File bug menu item https://www.libreoffice.org/get-help/bug/ is not what we want? Cheers, -- Thorsten pgpuoUs8DiFCZ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #49 from Regina Henschel rb.hensc...@t-online.de 2011-12-15 13:15:22 PST --- Nominate Bug 43837 - Impress crashes on custom animation of presentation objects Please try it out, it is not confirmed yet. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice