Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread David Tardon
On Wed, Apr 18, 2012 at 08:23:18AM +0300, Tor Lillqvist wrote: > > MacOSX is one of the few platform that has consistently been built > > with --enable-werror. > > removing the benefit of it just for a micro-optimization seems an overkill. > > I agree with Norbert here. The more tinderboxes we hav

Re: unbuilded code in sd/source/ui/notes

2012-04-18 Thread David Tardon
On Wed, Apr 18, 2012 at 11:21:04PM +0100, Caolán McNamara wrote: > On Sat, 2012-04-14 at 11:31 -0300, Olivier Hallot wrote: > > Is this a feature we curently miss by mistake, or is a dead code never > > finished/released? > > We apparently built it in the past, but no longer. Its inconceivable to

Re: Build Failure on Cygwin Windows

2012-04-18 Thread Johnny Chen
Sorry, I replaced that javah command with the one you gave me but now I got another error: [ build JVH ] CustomTarget/accessibility/bridge/inc/WindowsAccessBridgeAdapter.h Error: Could not find class file for 'org.openoffice.accessibility.WindowsAccessBridgeAdapter'. C:/libo/solenv/gbuild/StaticLi

Windows - Embed Server et al.

2012-04-18 Thread Mat M
Hello, I am trying to decrypt some of the Windows bits of LO, namely OLE & ActiveX parts. If I read correctly http://en.wikipedia.org/wiki/Object_Linking_and_Embedding, it says that OLE is an interface, mainly used in Windows, but which could be implemented everywhere. When doing Insert

Re: unbuilded code in sd/source/ui/notes

2012-04-18 Thread Caolán McNamara
On Sat, 2012-04-14 at 11:31 -0300, Olivier Hallot wrote: > Is this a feature we curently miss by mistake, or is a dead code never > finished/released? We apparently built it in the past, but no longer. Its inconceivable to me that there could be a clean route where we've ended up building ok but a

Re: [patch] [fdo#42986] Presentations in Wide-screen

2012-04-18 Thread Rob Snelders
Hi Ivan, I have tested with removing the PAPER_SCREEN*. It seems to work. The size indeed dissapears where the page-size of the printer is mentioned. I only saw that the handout-page is empty on the screen. It seems to print however. Also without the patch applied it doesn't work here. But my

Re: Copying sc/sd/sw into unittest libs (Re: namespace / typing thrash ...)

2012-04-18 Thread Markus Mohrhard
Hey Bjoern, 2012/4/18 Bjoern Michaelsen : > On Wed, Apr 18, 2012 at 09:33:51PM +0200, Lubos Lunak wrote: >>  This: >> >> On Monday 16 of April 2012, Markus Mohrhard wrote: >> > 2012/4/16 Lubos Lunak : >> > > On Monday 16 of April 2012, Michael Meeks wrote: >> > >>       Oh - and finally (Lubos) I

Re: Copying sc/sd/sw into unittest libs (Re: namespace / typing thrash ...)

2012-04-18 Thread Bjoern Michaelsen
On Wed, Apr 18, 2012 at 09:33:51PM +0200, Lubos Lunak wrote: > This: > > On Monday 16 of April 2012, Markus Mohrhard wrote: > > 2012/4/16 Lubos Lunak : > > > On Monday 16 of April 2012, Michael Meeks wrote: > > >> Oh - and finally (Lubos) I pushed an item to the ESC agenda to > > >> discuss

Re: Parallel set of flag bit definitions: SFX_FILTER_FOO and FLAGVAL_FOO

2012-04-18 Thread Tor Lillqvist
Caolán pointed me to this email from 2006 that describes the meaning of most of these flag bits: http://www.mail-archive.com/dev@openoffice.org/msg05047.html I pasted that description into a comment in the documentconstants.hxx file. In 4.0, if not earlier, we should drop the parallel set of nam

[REVIEW][3-5] fdo#48647 ugly hairline double border drawing regression

2012-04-18 Thread Michael Stahl
hi all, today's border line regression fix is for fdo#48647, which is simply missing usage of the ClipRegion to clip the hairline border lines, fix proposed for libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=49bd0e4e6bb0ed0671de72d84700ddcc49828f69 please note that beca

Re: Copying sc/sd/sw into unittest libs (Re: namespace / typing thrash ...)

2012-04-18 Thread Bjoern Michaelsen
On Wed, Apr 18, 2012 at 09:33:51PM +0200, Lubos Lunak wrote: > This: > > On Monday 16 of April 2012, Markus Mohrhard wrote: > > 2012/4/16 Lubos Lunak : > > > On Monday 16 of April 2012, Michael Meeks wrote: > > >> Oh - and finally (Lubos) I pushed an item to the ESC agenda to > > >> discuss

Parallel set of flag bit definitions: SFX_FILTER_FOO and FLAGVAL_FOO

2012-04-18 Thread Tor Lillqvist
I happened to notice that in comphelper/inc/comphelper/documentconstants.hxx and filter/source/config/cache/constant.hxx are a set of preprocessor macros definiing flag bits apparently describing properties of import/export filters. The SFX_FILTER_FOO values in the former match the FLAGVAL_FOO valu

support for repeating format code in calc

2012-04-18 Thread Noel Power
Hi Eike, I've been looking at providing support for the repeating character in number formats. I've been playing abit with the code and what I have sofar seems to work reasonably well ( no doubt there are plenty of edge cases still to be discovered ) But.. life would be simpler I think if we

Copying sc/sd/sw into unittest libs (Re: namespace / typing thrash ...)

2012-04-18 Thread Lubos Lunak
On Wednesday 18 of April 2012, Bjoern Michaelsen wrote: > On Wed, Apr 18, 2012 at 06:09:06PM +0200, Lubos Lunak wrote: > > Does somebody see a problem with this? > > What should this possibly solve? This thread is a quite bit ADHD to me > pouring in way too many different topic in one thread. Th

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #288 from Cor Nouws 2012-04-18 12:24:05 PDT --- Hi Timar, (In reply to comment #284) > 1. "Most annoying bugs" is relative, we don't have all the same opinion about Yes, so the one acting with code (fixing a bug) decides. > My opi

Re: namespace / typing thrash ...

2012-04-18 Thread Bjoern Michaelsen
On Wed, Apr 18, 2012 at 06:09:06PM +0200, Lubos Lunak wrote: > Does somebody see a problem with this? What should this possibly solve? This thread is a quite bit ADHD to me pouring in way too many different topic in one thread. Best, Bjoern ___ LibreO

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on|31217 | -- Configure bugmail: https://bugs.freedes

Re: [libreoffice-l10n] [ANNOUNCE] Branch libreoffice-3-5-3 created

2012-04-18 Thread Martin Srebotnjak
Do you plan to release 3.5.3 with this bug? https://bugs.freedesktop.org/show_bug.cgi?id=48356 It is just not acceptable for Central European users. For them the recommended release series is at this point 3.4.x. Thanks, m. 2012/4/18 Petr Mladek : > Hi all, > > there have been created the libreo

Re: [PATCH] [PUSHED] Use global constants for initial tab count bounds checking

2012-04-18 Thread Kohei Yoshida
On Wed, 2012-04-18 at 19:15 +0200, Albert Thuswaldner wrote: > Ok, good to know. IMHO it is even more important to sort this thing > out. I've updated my patch with a new proposed solution. Looks good. Pushed. Thanks a lot for this. I changed the names to remove the trailing COUNT part, since

[ANNOUNCE] Branch libreoffice-3-5-3 created

2012-04-18 Thread Petr Mladek
Hi all, there have been created the libreoffice-3-5-3 branch. It will be used for fine tuning of the 3.5.3 release. The following rules apply: + preferably just translation or blocker fixes + only cherry-picking from libreoffice-3-5 branch + 2 additional reviews needed; 2

[ANNOUNCE] libreoffice-3.5.3.1 tag created (3.5.3-rc1)

2012-04-18 Thread Petr Mladek
Hi, there have been created the libreoffice-3.5.3.1 tag for 3.5.3-rc1 release. The corresponding official builds will be available within next few days. See the attached list of changes against 3.5.2-final[*]. Now, you might switch your current 3-5 source tree to it using: ./g fetch --tags ./g

Re: [PATCH] Use global constants for initial tab count bounds checking

2012-04-18 Thread Albert Thuswaldner
Hi Kohei, Sorry for double posting, forgot to CC the list. On Wed, Apr 18, 2012 at 02:21, Kohei Yoshida wrote: > On Wed, 2012-04-18 at 00:41 +0200, Albert Thuswaldner wrote: >> Hi Kohei, >> This patch makes the bounds checking of the initial tab count more >> consistent with the actual limits. >

[LibreOffice] License statement

2012-04-18 Thread Laure Garcí­a Linde
All my contributions are under LGPLv3/MPL until further notice. lauregl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Weird error during build of 3.5.2 libreoffice

2012-04-18 Thread Tomáš Chvátal
Dne 16. dubna 2012 14:30 Petr Mladek napsal(a): > Tomáš Chvátal píše v Čt 12. 04. 2012 v 08:39 +0200: >> Complete log: https://401507.bugs.gentoo.org/attachment.cgi?id=300617 > > Could you please attach solenv/inc/tg_ext.mk from your build? > I do not see glibc-omitfp target here. > > In each case

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Lubos Lunak
On Wednesday 18 of April 2012, Caolán McNamara wrote: > On Wed, 2012-04-18 at 10:03 +0200, Stephan Bergmann wrote: > > Yes, we should certainly --enable-werror there. The code base used to > > be warning-free even for MSVC. Everything else is a regression. > > We moved to using the compiler stl o

Re: namespace / typing thrash ...

2012-04-18 Thread Lubos Lunak
On Wednesday 18 of April 2012, Stephan Bergmann wrote: > On 04/17/2012 02:38 PM, Lubos Lunak wrote: > > But maybe gbuild could be changed to include target-specific LDFLAGS? > > That way it'd be possible to build as 'make > > sc_ucalc_LDFLAGS=-Wl,--strip-all' . Probably even Bjoern's --enable-deb

Re: [PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-18 Thread Kohei Yoshida
Hi there, On Tue, 2012-04-17 at 14:31 +0200, Noel Grandin wrote: > This patch passes "make sc.subsequentcheck". Just to add a cautionary note, IIRC much of the chart functionality is not covered by our test framework. So, use caution when modifying this part of the code, and I would appreciate a

[PUSHED] Re: [PATCH] convert PTRARR usage in xmloff module

2012-04-18 Thread Michael Stahl
On 17/04/12 17:37, Noel Grandin wrote: > Hi > > This patch series converts SV_*_PTRARR usage in the xmloff module. > Depending on the usage, std::vector, boost::ptr_vector, or > boost::ptr_set was used. > > It passed "make xmloff.subsequentcheck" and most of "make > subsequentcheck" (the rest

Re: [PATCH] Remove unused debug facilities from basebmp

2012-04-18 Thread Jan Holesovsky
Hi Gabor, On 2012-04-14 at 11:58 +0200, Lubos Lunak wrote: > > Remove debug dumping facility from basebmp. > > From the patch: > > "Used in vcl/headless/svpgdi.cxx when OSL_DEBUG_LEVEL > 2" > > And it indeed is. Moreover it looks like quite useful debugging > functionality, so I don't think

[PUSHED] Re: [PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-18 Thread Michael Stahl
On 17/04/12 14:31, Noel Grandin wrote: > And here is the second patch in the series. > > This patch actually converts chart2uno.cxx from tools/table.hxx to std::map > > This was the last file using tools/table in the LO tree. > > This patch passes "make sc.subsequentcheck". great, pushed both p

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Stephan Bergmann
On 04/18/2012 01:53 PM, Caolán McNamara wrote: On Wed, 2012-04-18 at 10:03 +0200, Stephan Bergmann wrote: Yes, we should certainly --enable-werror there. The code base used to be warning-free even for MSVC. Everything else is a regression. We moved to using the compiler stl on windows as wel

[PATCH] converts SV_DECL_PTRARR in SVX module

2012-04-18 Thread Noel Grandin
Hi These patches convert the usage of SV_DECL_PTRARR in SVX module to std::set, std::vector and boost::ptr_vector variously. Survived a "make svx.check" and a "make subsequentcheck" (at least up until the point at which my Ubuntu box has a problem with one of the smoketest checks). Licens

Re: Build Failure on Cygwin Windows

2012-04-18 Thread Matúš Kukan
On 15 April 2012 17:51, Johnny Chen wrote: > [ build JVH ] > CustomTarget/accessibility/bridge/inc/WindowsAccessBridgeAdapter.h > Error: Class com.sun.star.uno.XComponentContext could not be found. Ops, sorry, does this help ? Still something missing ? -javah -classpath . -o $(call gb_Helper

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Tor Lillqvist
> The quick solution > (aside from using bool for UNO API) is to use static_cast, but then we > would need to put it in a lot of places to make MSVC warning-free. Or then just throw up our hands in the air and add one more -wd switch to disable that particular warning... We have a long list of tho

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Kohei Yoshida
On Wed, 2012-04-18 at 08:53 -0500, Norbert Thiebaud wrote: > On Wed, Apr 18, 2012 at 2:52 AM, Lubos Lunak wrote: > > Or does that mean I should enable WaE for the MSVC tinderbox too? That > > should > > be some fun, with people even now not bothering to fix that build that much. > > yes we sho

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Norbert Thiebaud
On Wed, Apr 18, 2012 at 2:52 AM, Lubos Lunak wrote: > On Wednesday 18 of April 2012, Tor Lillqvist wrote: >> > MacOSX is one of the few platform that has consistently been built >> > with --enable-werror. >> > removing the benefit of it just for a micro-optimization seems an >> > overkill. >> >> I

DEL_ONLY_EMPTY_LINES ?

2012-04-18 Thread Michael Meeks
I was wondering about this oddness in writer - should we add an easy-hack to remove it & associated code-paths ? :-) ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice maili

Re: [PUSHED] Impress Help

2012-04-18 Thread Italo Vignoli
> I fixed it now and pushed, though in the future it would be wonderful if you > could do a 'make helpcontent2' before sending the patch, so you'll see the > errors yourself. ;-) Hi Miklos, I would love to be as smart as a hacker, but I really wonder what might happen when I run technical software

master install does not respect destdir variabe

2012-04-18 Thread Tomáš Chvátal
Hi, while I finally got to move my tinderbox tester from 3.5 to master as the 3.5 finally seems quite great I encoutered this problem I can't figure out. make DESTDIR="${D}" distro-pack-install echo "Installing in /usr/lib64/libreoffice..." && \ ooinstall "/usr/lib64/libreoffice" && \ echo "" &&

Re: [PUSHED 3-5] performance improvement for fdo#48011

2012-04-18 Thread Petr Mladek
Caolán McNamara píše v St 18. 04. 2012 v 12:58 +0100: > For https://bugs.freedesktop.org/show_bug.cgi?id=48011 an apparent > performance regression in writer, I'd like to propose > 1856186951a70a0bcac4e0c3632ca4afe68c05e3 as a partial fix, code before > and after should be logical equivalent > > i

Re: [PATCH] fdo#46581 Avoid temporary rtl::OUString (LGPLv3/MPL)

2012-04-18 Thread Lubos Lunak
On Wednesday 18 of April 2012, Michael Meeks wrote: > Hi there, > > It's a nice patch :-) however - I believe that Lubos just did a chunk > of work to make this even easier to read, such that we can do: > > -if ( m_nxtSym == OUString(RTL_CONSTASCII_USTRINGPARAM( "\"" )) > ) +

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Tor Lillqvist
> does MSVC support something like #pragma GCC diagnostic warning "-Wfoo" > to tell it not to WaE for some specific warning? Sure. http://cgit.freedesktop.org/libreoffice/core/tree/avmedia/source/win/framegrabber.cxx#n29 (just a random source file that showed up early in a git grep). But I think

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #287 from sasha.libreoff...@gmail.com 2012-04-18 05:13:06 PDT --- @ Timur > 2. "LibreOffice 3.5" has releases. Although in bug itself it can be seen We can see bug title when place mouse cursor over bug numbers in field "Depends on". E

[REVIEW 3-5] performance improvement for fdo#48011

2012-04-18 Thread Caolán McNamara
For https://bugs.freedesktop.org/show_bug.cgi?id=48011 an apparent performance regression in writer, I'd like to propose 1856186951a70a0bcac4e0c3632ca4afe68c05e3 as a partial fix, code before and after should be logical equivalent i.e. http://cgit.freedesktop.org/libreoffice/core/commit/?id=185618

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Michael Stahl
On 18/04/12 13:53, Caolán McNamara wrote: > On Wed, 2012-04-18 at 10:03 +0200, Stephan Bergmann wrote: >> Yes, we should certainly --enable-werror there. The code base used to >> be warning-free even for MSVC. Everything else is a regression. > > We moved to using the compiler stl on windows as

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Caolán McNamara
On Wed, 2012-04-18 at 10:03 +0200, Stephan Bergmann wrote: > Yes, we should certainly --enable-werror there. The code base used to > be warning-free even for MSVC. Everything else is a regression. We moved to using the compiler stl on windows as well. The compiler provided "list" header on msvc

Re: launcher_unityquicklist.ulf mnissing

2012-04-18 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Em 18-04-2012 08:47, Andras Timar escreveu: > Hi, > > 2012/4/18 Olivier Hallot : >> my last build (this morning) cannot pass thru /sysui... >> >> dmake: Error: -- `launcher_unityquicklist.ulf' not found, and can't be made >> >> How can I get thru thi

Re: 'make check' with Windows/MSVC build?

2012-04-18 Thread Caolán McNamara
On Wed, 2012-04-18 at 11:06 +0100, Michael Meeks wrote: > And of course you need to source 'ooenv' to get STAR_RESOURCEPATH set > [ though strangely things seem to work without that these days ]. soffice script will source ooenv if it finds it, if you mean that. C. ___

Re: launcher_unityquicklist.ulf mnissing

2012-04-18 Thread Andras Timar
Hi, 2012/4/18 Olivier Hallot : > my last build (this morning) cannot pass thru /sysui... > > dmake:  Error: -- `launcher_unityquicklist.ulf' not found, and can't be made > > How can I get thru this? Pull, Bjoern fixed it 4 minutes ago. Andras ___ Libre

launcher_unityquicklist.ulf mnissing

2012-04-18 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, my last build (this morning) cannot pass thru /sysui... dmake: Error: -- `launcher_unityquicklist.ulf' not found, and can't be made How can I get thru this? Thank you - -- Olivier Hallot Founder, Board of Directors Member - The Document Found

Re: [PATCH] fdo#46581 Avoid temporary rtl::OUString (LGPLv3/MPL)

2012-04-18 Thread Michael Meeks
Hi there, It's a nice patch :-) however - I believe that Lubos just did a chunk of work to make this even easier to read, such that we can do: -if ( m_nxtSym == OUString(RTL_CONSTASCII_USTRINGPARAM( "\"" )) ) +if ( m_nxtSym == "\"" ) Which will turn into s

[PUSHED] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

2012-04-18 Thread Michael Meeks
On Wed, 2012-04-18 at 09:31 +0100, Noel Power wrote: > On 17/04/12 20:59, Kohei Yoshida wrote: > > On Tue, 2012-04-17 at 21:44 +0200, Albert Thuswaldner wrote: > > I would be okay to just push this patch as-is, but let's wait for Noel's > > blessing just in case. ;-) > > bless you my son, yeah it

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #286 from Petr Mladek 2012-04-18 03:50:09 PDT --- If we want to keep it working, we need to keep a balance. If we mention too many bugs here, we will create another swamp of ideas and developers will ignore it. I am not sure where ar

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #285 from Petr Mladek 2012-04-18 03:41:26 PDT --- IMHO, it currently works the following way: If you add a bug here, you send a message to developers. Hey, this is something that people really hates in this release. It annoys many pe

[PATCH] fdo#46581 Avoid temporary rtl::OUString (LGPLv3/MPL)

2012-04-18 Thread Laure Garcí­a Linde
>From f85dbd2f41f9bfc4f1530e3dc4af374645171a32 Mon Sep 17 00:00:00 2001 From: Laureano G. Linde Date: Wed, 18 Apr 2012 11:49:27 +0200 Subject: [PATCH] Avoid temporaty rtl::OUString in dtrans/source/cnttype/mcnttype.cxx --- dtrans/source/cnttype/mcnttype.cxx | 10 +- 1 files changed, 5

Re: 'make check' with Windows/MSVC build?

2012-04-18 Thread Michael Meeks
On Thu, 2012-04-12 at 14:11 +0200, Stephan Bergmann wrote: > Can't remember any details, but I think I did have a real problem with > it before I discovered --disable-linkoo sometime last year Hey ho :-) > and recently I remote-debugged something with somebody, and we came > to the con

[ANDROID-UI-PATCH] Empty Junity android project

2012-04-18 Thread Jonathan Aquilina
Attached is a patch which created an empty junit android test project which is used to create test cases and test against the main android project :) Regards Jonathan >From 2c25474a182b5f76d483188e54b0b1f1f03f235b Mon Sep 17 00:00:00 2001 From: Jonathan Aquilina Date: Wed, 18 Apr 2012 11:48:31

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #284 from Timur 2012-04-18 02:38:04 PDT --- First, I thank you all for spotting and fixing all those bugs, and especially for opening bug like this one. What's clear here is that's about bugs, and not enhancements. I'd like to discus

Re: [PUSHED][3-5] Re: [PUSHED][3-5] fdo#38635: sw: printing border lines gaps regression

2012-04-18 Thread Miklos Vajna
On Tue, Apr 17, 2012 at 10:46:20PM +0200, Michael Stahl wrote: > thanks; as mentioned in the bug report there was still a small gap > remaining with the above fix, which i've now tracked down to the > start/end positions of the horizontal and vertical lines not being equal. > > proposing the fix

Re: [REVIEW: 3-5] fdo#44861 make "Replace All" behave correctly with REs

2012-04-18 Thread Petr Mladek
David Tardon píše v St 18. 04. 2012 v 10:02 +0200: > Hi all, > > the problem is that we did not refresh search data for subsequent > searches, so the back references were always filled using the search > data of the first match. So, for RE ([0-9]{2})([0-9]{2}), replacement > $1.$2 and string "1200

Re: [PATCH] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

2012-04-18 Thread Noel Power
On 17/04/12 20:59, Kohei Yoshida wrote: Hi Albert, On Tue, 2012-04-17 at 21:44 +0200, Albert Thuswaldner wrote: I would be okay to just push this patch as-is, but let's wait for Noel's blessing just in case. ;-) bless you my son, yeah it looks ok :-) thanks, Noel

Re: [PUSHED] Impress Help

2012-04-18 Thread Miklos Vajna
Hi Italo, On Sun, Apr 15, 2012 at 11:27:33AM +0200, Italo Vignoli wrote: > Please check the patch very carefully, as I don't trust myself as a hacker. Actually it gave: ERROR: 0102.xhp449,2): Tag mismatch dmake: Error code 255, while making '../../../../unxlngx6.pro/misc/text_simpress_04

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Stephan Bergmann
On 04/18/2012 09:52 AM, Lubos Lunak wrote: On Wednesday 18 of April 2012, Tor Lillqvist wrote: MacOSX is one of the few platform that has consistently been built with --enable-werror. removing the benefit of it just for a micro-optimization seems an overkill. I agree with Norbert here. The mor

[REVIEW: 3-5] fdo#44861 make "Replace All" behave correctly with REs

2012-04-18 Thread David Tardon
Hi all, the problem is that we did not refresh search data for subsequent searches, so the back references were always filled using the search data of the first match. So, for RE ([0-9]{2})([0-9]{2}), replacement $1.$2 and string "1200-1300", that would lead to the following sequence of changes:

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Lubos Lunak
On Wednesday 18 of April 2012, Tor Lillqvist wrote: > > MacOSX is one of the few platform that has consistently been built > > with --enable-werror. > > removing the benefit of it just for a micro-optimization seems an > > overkill. > > I agree with Norbert here. The more tinderboxes we have that (

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44861, which changed state. Bug 44861 Summary: Calc EDITING: function Find&Replace behaves incorrectly if regular expressions used https://bugs.freedesktop.org/show_bug.cgi?id=44861 What|Old Value

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #283 from Petr Mladek 2012-04-18 00:48:17 PDT --- (In reply to comment #282) > (In reply to comment #281) > > Adding again Bug 44861. I ask dE not to remove other people's bugs and not > > to > > discuss them here. > > The title cle

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Stephan Bergmann
On 04/18/2012 03:25 AM, Norbert Thiebaud wrote: On Tue, Apr 17, 2012 at 4:39 PM, Lubos Lunak wrote: On Tuesday 17 of April 2012, CaolXXn McNamara wrote: writerfilter/source/dmapper/GraphicHelpers.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b92de73fd

Re: namespace / typing thrash ...

2012-04-18 Thread Stephan Bergmann
On 04/17/2012 02:38 PM, Lubos Lunak wrote: On Tuesday 17 of April 2012, Stephan Bergmann wrote: Would it be possible to replace gb_CppunitTest_add_library_objects with something that explicitly lists (only) the individual objects from the given library that should be linked into the test? I