LibreOffice Gerrit News for core on 2014-06-26
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + Force --std=gnu89 for clang. in https://gerrit.libreoffice.org/9904 from Andrzej Hunt about module build + OS X: PYTHON_CFLAGS in https://gerrit.libreoffice.org/9903 from Robert Antoni Buj i Gelonch about module build + fdo76279:Invalid Citation on RoundTrip in https://gerrit.libreoffice.org/9898 from Sourav Mahajan about module sw, writerfilter + fdo#74745-Word custom dateproperty notshown asdate in https://gerrit.libreoffice.org/9896 from Charu Tyagi about module writerfilter + fdo#80097 : tblBorders and tcBorders are not preserved for the table. in https://gerrit.libreoffice.org/9893 from Ravindra Vidhate about module sw End of freshness + fdo#80536 - UI: Menu option for 'Edit File' toolbar entry in https://gerrit.libreoffice.org/9913 from Joren De Cuyper about module sc, sd, sw + fdo#48673 - UI: No keyboard shortcut for Ignore All on misspelled word in https://gerrit.libreoffice.org/9908 from Joren De Cuyper about module sw + fdo#39111 - UI inconsistent concerning suppression of output for empty pa in https://gerrit.libreoffice.org/9907 from Joren De Cuyper about module sc + fdo#62879 Changed wording of protected section dialog in https://gerrit.libreoffice.org/9905 from Joel Madero about module sw + fdo#73148 add options to Calc function AGGREGATE in https://gerrit.libreoffice.org/9449 from Winfried Donkers about module formula, sc + new loplugin: externalandnotdefined in https://gerrit.libreoffice.org/9901 from Noel Grandin about module bean, bridges, chart2, compilerplugins, cppu, rsc, sal, vcl + fdo#80514 LO crashes on opening; tries to remove a para with NumPicBullet in https://gerrit.libreoffice.org/9897 from Vinaya Mandke about module sw, writerfilter + fdo#79940 LO crashes on opening; tries to remove a para with bookmarks in https://gerrit.libreoffice.org/9764 from Vinaya Mandke about module sw, writerfilter * Merged changes on master for project core changed in the last 25 hours: + fixes for up-casting to ReferenceXInterface in https://gerrit.libreoffice.org/9892 from Noel Grandin + Update libgltf: new build system and various fixes in https://gerrit.libreoffice.org/9895 from Zolnai Tamás + fdo#37401 - fixed the old vector length in https://gerrit.libreoffice.org/9887 from Hideki Ikeda + fix fdo#80490 - string 'Auto Spell Checking' in https://gerrit.libreoffice.org/9885 from Joren De Cuyper + partially fix fdo#80490 - string 'Non-printing Characters' in https://gerrit.libreoffice.org/9884 from Joren De Cuyper + fdo#51763 - make title of dialog localisable in https://gerrit.libreoffice.org/9883 from Joren De Cuyper + Resolves: #i74651# remove image via should change document state in https://gerrit.libreoffice.org/7286 from Maxime de Roucy * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + fix build error AVFoundation/AVFoundation.h: no such file or directory in https://gerrit.libreoffice.org/9769 from Douglas Mencken + fdo#79018: LO hangs while opening file. in https://gerrit.libreoffice.org/9564 from Yogesh Bharate + configure, gbuild: remove Cygwin paths from make environment in https://gerrit.libreoffice.org/9698 from Michael Stahl + sw/docx export: fix handling of document with header and section(s) in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer + move OpenGLContext to SAL in https://gerrit.libreoffice.org/9429 from David Tardon + Changes for Wordml in https://gerrit.libreoffice.org/9013 from Michel Messak + fdo#64945 Remove inconvenient localized symbol code. in https://gerrit.libreoffice.org/8696 from Darshana Padmadas + fdo#77716 : Paragraph spacing is not preserved after RT. in https://gerrit.libreoffice.org/9197 from Tushar Bende + Lots of changes to Tango icons in https://gerrit.libreoffice.org/7987 from Miroslav Mazel + Refactored swooxmlexport tests cases. Added function to check contents. in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar + fdo#77121 Header / Footer positions not preserved after RT in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice Gerrit News for submodules on 2014-06-26
Moin! ~~ Project dictionaries ~~ Nothing moved in the project for the last 25 hours ~~ Project translations ~~ Nothing moved in the project for the last 25 hours ~~ Project help ~~ * Open changes on master for project help changed in the last 25 hours: + fdo#63274 clarify hexadecimal argument in HEX2DEC and similar functions in https://gerrit.libreoffice.org/9906 from Stanislav Horáček * Merged changes on master for project help changed in the last 25 hours: None * Abandoned changes on master for project help changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: None Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice build error
On 2014-06-22 10:52 AM, Iric Lomax wrote: ./configure: line 38970: test: jar: integer expression expected configure: error: no, you need at least Ant = 1.6.0 Error running configure at /cygdrive/c/sources/libo-core/autogen.sh line 209. It's probably a bug in the configure script. I would suggest installing a slighter older version of Ant and seeing if that helps. Otherwise, if you feel like debugging it, what is the output of ant.sh --version ? Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: readlicense_oo/license
readlicense_oo/license/LICENSE |4 ++-- readlicense_oo/license/LICENSE.fodt |4 ++-- readlicense_oo/license/LICENSE.html |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 1d5e875a6c61ddc9fbf0ed09878b7dfb75f89fe3 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Thu Jun 26 08:44:15 2014 +0200 libgltf: fix typo in license Change-Id: I0e5f3afb19c2457c5ccca922e75e617312801ab9 diff --git a/readlicense_oo/license/LICENSE b/readlicense_oo/license/LICENSE index c010c8f..2e23527 100644 --- a/readlicense_oo/license/LICENSE +++ b/readlicense_oo/license/LICENSE @@ -1079,13 +1079,13 @@ libgltf The following software may be included in this product: libgltf. Use of any of this software is governed by the terms of the license below: - License for libgltf except trackbal.h and trackball.cpp source files: + License for libgltf except trackball.h and trackball.cpp source files: MPL 2 See MPL Version 2 below - License for trackbal.h and trackball.cpp source files: + License for trackball.h and trackball.cpp source files: (c) Copyright 1993, 1994, Silicon Graphics, Inc. ALL RIGHTS RESERVED diff --git a/readlicense_oo/license/LICENSE.fodt b/readlicense_oo/license/LICENSE.fodt index 6ca14cf..c3c69b1 100644 --- a/readlicense_oo/license/LICENSE.fodt +++ b/readlicense_oo/license/LICENSE.fodt @@ -3570,10 +3570,10 @@ text:p text:style-name=P18text:a xlink:type=simple xlink:href=#Mozilla Public License Version 2.0|outlinetext:span text:style-name=T17Jump to MPL Version /text:span/text:atext:a xlink:type=simple xlink:href=#Mozilla Public License Version 2.0|outlinetext:span text:style-name=T172/text:span/text:a/text:p text:h text:style-name=P76 text:outline-level=2text:soft-page-break/libtext:span text:style-name=T29gltf/text:span/text:h text:p text:style-name=P50The following software may be included in this product: text:span text:style-name=T7libgltf/text:span. Use of any of this software is governed by the terms of the license below:/text:p - text:p text:style-name=P150text:span text:style-name=T2License for libgltf except trackbal.h and trackball.cpp source files:/text:span#x0d;#x0d;/text:p + text:p text:style-name=P150text:span text:style-name=T2License for libgltf except trackball.h and trackball.cpp source files:/text:span#x0d;#x0d;/text:p text:p text:style-name=P150MPL 2#x0d;/text:p text:p text:style-name=P150#x0d;text:a xlink:type=simple xlink:href=#Mozilla Public License Version 2.0|outlinetext:span text:style-name=T17Jump to MPL Version /text:span/text:atext:a xlink:type=simple xlink:href=#Mozilla Public License Version 2.0|outlinetext:span text:style-name=T172/text:span/text:a/text:p - text:p text:style-name=P150#x0d;text:span text:style-name=T2License for trackbal.h and trackball.cpp source files:/text:span/text:p + text:p text:style-name=P150#x0d;text:span text:style-name=T2License for trackball.h and trackball.cpp source files:/text:span/text:p text:p text:style-name=P51(c) Copyright 1993, 1994, Silicon Graphics, Inc. text:line-break/ALL RIGHTS RESERVED /text:p text:p text:style-name=P51Permission to use, copy, modify, and distribute this software for any purpose and without fee is hereby granted, provided that the above copyright notice appear in all copies and that both the copyright notice and this permission notice appear in supporting documentation, and that the name of Silicon Graphics, Inc. not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. /text:p text:p text:style-name=P51THE MATERIAL EMBODIED ON THIS SOFTWARE IS PROVIDED TO YOU quot;AS-ISquot; AND WITHOUT WARRANTY OF ANY KIND, EXPRESS, IMPLIED OR OTHERWISE, INCLUDING WITHOUT LIMITATION, ANY WARRANTY OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. text:s/IN NO EVENT SHALL SILICON GRAPHICS, INC. text:s/BE LIABLE TO YOU OR ANYONE ELSE FOR ANY DIRECT, SPECIAL, INCIDENTAL, INDIRECT OR CONSEQUENTIAL DAMAGES OF ANY KIND, OR ANY DAMAGES WHATSOEVER, INCLUDING WITHOUT LIMITATION, LOSS OF PROFIT, LOSS OF USE, SAVINGS OR REVENUE, OR THE CLAIMS OF THIRD PARTIES, WHETHER OR NOT SILICON GRAPHICS, INC. text:s/HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH LOSS, HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, ARISING OUT OF OR IN CONNECTION WITH THE POSSESSION, USE OR PERFORMANCE OF THIS SOFTWARE. /text:p diff --git a/readlicense_oo/license/LICENSE.html b/readlicense_oo/license/LICENSE.html index 5dd870d..f915022 100644 --- a/readlicense_oo/license/LICENSE.html +++ b/readlicense_oo/license/LICENSE.html @@ -1142,13 +1142,13 @@ to MPL Version /AA HREF=#Mozilla Public License Version 2.0|outline2/A/ following software may be included in this product: libgltf. Use of any of this software is governed by the terms of the license below:/P H3 CLASS=westernLicense -for libgltf except trackbal.h and trackball.cpp
[Libreoffice-commits] core.git: external/libgltf
external/libgltf/ExternalProject_libgltf.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 5da85a21241f09a0b2d7796bc952806a1a863592 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 08:47:46 2014 +0200 external/libgltf: Hack in missing -fPIC Change-Id: Ied0fe5f376bf17bd931f440e57d15b22ab6db86e diff --git a/external/libgltf/ExternalProject_libgltf.mk b/external/libgltf/ExternalProject_libgltf.mk index 580c010..3b0bc87 100644 --- a/external/libgltf/ExternalProject_libgltf.mk +++ b/external/libgltf/ExternalProject_libgltf.mk @@ -63,6 +63,7 @@ $(call gb_ExternalProject_get_state_target,libgltf,build) : BOOST_CFLAGS=$(if $(SYSTEM_BOOST),$(BOOST_CPPFLAGS),-I$(call gb_UnpackedTarball_get_dir,boost)) -I$(BUILDDIR)/config_$(gb_Side) \ GLEW_CFLAGS=$(if $(SYSTEM_GLEW),$(GLEW_CFLAGS),-I$(call gb_UnpackedTarball_get_dir,glew)/include) \ GLM_CFLAGS=$(if $(SYSTEM_GLM),$(GLM_CFLAGS),-I$(call gb_UnpackedTarball_get_dir,glm)) \ + $(if $(filter WNT,$(OS)),,CC=$(CC) -fPIC) \ $(MAKE) \ ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/libgltf
external/libgltf/ExternalProject_libgltf.mk |1 - 1 file changed, 1 deletion(-) New commits: commit fb48904dfa640e93650264aa9913dea2305dbcc6 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 08:53:32 2014 +0200 Revert external/libgltf: Hack in missing -fPIC This reverts commit 5da85a21241f09a0b2d7796bc952806a1a863592, bb9078e3dee48afc4c2bd8006a892924f8b38b39 libgltf: use --with-pick [sic] had already added --with-pic. diff --git a/external/libgltf/ExternalProject_libgltf.mk b/external/libgltf/ExternalProject_libgltf.mk index 3b0bc87..580c010 100644 --- a/external/libgltf/ExternalProject_libgltf.mk +++ b/external/libgltf/ExternalProject_libgltf.mk @@ -63,7 +63,6 @@ $(call gb_ExternalProject_get_state_target,libgltf,build) : BOOST_CFLAGS=$(if $(SYSTEM_BOOST),$(BOOST_CPPFLAGS),-I$(call gb_UnpackedTarball_get_dir,boost)) -I$(BUILDDIR)/config_$(gb_Side) \ GLEW_CFLAGS=$(if $(SYSTEM_GLEW),$(GLEW_CFLAGS),-I$(call gb_UnpackedTarball_get_dir,glew)/include) \ GLM_CFLAGS=$(if $(SYSTEM_GLM),$(GLM_CFLAGS),-I$(call gb_UnpackedTarball_get_dir,glm)) \ - $(if $(filter WNT,$(OS)),,CC=$(CC) -fPIC) \ $(MAKE) \ ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/core/data/ooxml/pass/fdo79940.docx |binary writerfilter/source/dmapper/DomainMapper.cxx |2 ++ writerfilter/source/dmapper/DomainMapper_Impl.cxx |8 writerfilter/source/dmapper/DomainMapper_Impl.hxx |3 +++ 4 files changed, 13 insertions(+) New commits: commit 9fbdb02c9a1da28b4dd51b053d39cb254631e535 Author: Vinaya Mandke vinaya.man...@synerzip.com Date: Tue Jun 24 14:59:30 2014 +0530 fdo#79940 LO crashes on opening; tries to remove a para with bookmarks LO crashes while opening the issue file as, DomainMapper_Impl::RemoveLastParagraph tries to dispose a paragraph which has bookmarks attached. If A para finishes and a new para has not been started as yet, which means the current cursor position is outside a paragraph. In such a case move the Bookmark-End to the earlier paragraph. Added the issue file in sw/qa/core/data/ooxml/pass/ Change-Id: I62cf94718add943d042d770ab5337a0dae70d9e8 Reviewed-on: https://gerrit.libreoffice.org/9764 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/sw/qa/core/data/ooxml/pass/fdo79940.docx b/sw/qa/core/data/ooxml/pass/fdo79940.docx new file mode 100644 index 000..8d17489 Binary files /dev/null and b/sw/qa/core/data/ooxml/pass/fdo79940.docx differ diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index a103474..ea66861 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -2561,6 +2561,7 @@ void DomainMapper::lcl_startParagraphGroup() m_pImpl-GetTopContext()-Insert( PROP_BREAK_TYPE, uno::makeAny( com::sun::star::style::BreakType_COLUMN_BEFORE) ); } m_pImpl-SetIsFirstRun(true); +m_pImpl-SetIsOutsideAParagraph(false); m_pImpl-clearDeferredBreaks(); } @@ -2570,6 +2571,7 @@ void DomainMapper::lcl_endParagraphGroup() m_pImpl-getTableManager().endParagraphGroup(); //frame conversion has to be executed after table conversion m_pImpl-ExecuteFrameConversion(); +m_pImpl-SetIsOutsideAParagraph(true); } void DomainMapper::markLastParagraphInSection( ) diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index e0de4db..89edfc4 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -189,6 +189,7 @@ DomainMapper_Impl::DomainMapper_Impl( m_bUsingEnhancedFields( false ), m_bSdt(false), m_bIsFirstRun(false), +m_bIsOutsideAParagraph(true), m_bIsTableHasDirectFormatting(false), m_xAnnotationField(), m_nAnnotationId( -1 ), @@ -1132,6 +1133,7 @@ void DomainMapper_Impl::finishParagraph( PropertyMapPtr pPropertyMap ) pParaContext-ResetFrameProperties(); } +SetIsOutsideAParagraph(true); #ifdef DEBUG_DOMAINMAPPER dmapper_logger-endElement(); #endif @@ -4196,6 +4198,12 @@ void DomainMapper_Impl::AddBookmark( const OUString rBookmarkName, const OUStri } xCursor-gotoRange( xTextAppend-getEnd(), true ); +// A Paragraph was recently finished, and a new Paragraph has not been started as yet +// then move the bookmark-End to the earlier paragraph +if (IsOutsideAParagraph()) +{ +xCursor-goLeft( 1, false ); +} uno::Reference container::XNamed xBkmNamed( xBookmark, uno::UNO_QUERY_THROW ); //todo: make sure the name is not used already! if ( !aBookmarkIter-second.m_sBookmarkName.isEmpty() ) diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index 99eabb5..97b2e1e 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -388,6 +388,7 @@ private: /// If the current paragraph is inside a structured document element. boolm_bSdt; boolm_bIsFirstRun; +boolm_bIsOutsideAParagraph; boolm_bIsTableHasDirectFormatting; css::uno::Reference css::text::XTextCursor xTOCMarkerCursor; @@ -714,6 +715,8 @@ public: void SetCurrentRedlineInitials( const OUString sInitials ); bool IsFirstRun() { return m_bIsFirstRun;} void SetIsFirstRun(bool bval) { m_bIsFirstRun = bval;} +bool IsOutsideAParagraph() { return m_bIsOutsideAParagraph;} +void SetIsOutsideAParagraph(bool bval) { m_bIsOutsideAParagraph = bval;} void ApplySettingsTable(); SectionPropertyMap * GetSectionContext(); ___ Libreoffice-commits mailing list
how to cope with Calc functions that have an optional argument, which is mandatory in Excel?
Hi, Currenty I am looking at fdo#40835, which mentions the problem that Excel function F.DIST has 4 required arguments and that ODF1.2 function FDIST has the same arguments, only the last argument is optional. I have found in classes FormulaParser and FormulaFinalizer (/core/sc/source/filter/inc/formulaparser.hxx)functions that handle the other way round, i.e. Calc has all arguments mandatory and Excel has optional arguments. Is there code that handles my case? Otherwise I may have to introduce an extra function to Calc, just because of this optional/required argument difference. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Pasting in Writer or how to create a SwDoc deep copy?
Hi Jan-Marek, On Wed, Jun 25, 2014 at 01:09:01PM +0200, Jan-Marek Glogowski glo...@fbihome.de wrote: My best idea is to use SwNodeIndex aSourceIdx( rSource.GetNodes().GetEndOfExtras(), *1* ); Are you sure such an explicit offset is required here? I'm thinking about special situations like when the document starts with a table, if you want to paste that into a new document, you probably want to have the selection start at the first content node of the document, so no static offset will work here. I'm thinking about something like: SwNodeIndex aNodeIndex rSource.GetNodes().GetEndOfAutotext(); SwCntntNode* pStart = rSource.GetNodes().GoNext(aNodeIndex); Any kind of explicit offset sounds a bit scary to me. SwPaM aPara( document content start ); this-DelFullPara(aPara); But you're not really trying to delete the paragraph content, just join the two, right? SwDoc::DeleteAndJoin() might be useful to do that. Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] help.git: Changes to 'refs/tags/suse-4.0-25'
Tag 'suse-4.0-25' created by Andras Timar andras.ti...@collabora.com at 2014-06-26 10:05 -0700 suse-4.0-25 Changes since suse-4.0-22-7: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/suse-4.0-25'
Tag 'suse-4.0-25' created by Andras Timar andras.ti...@collabora.com at 2014-06-26 10:05 -0700 suse-4.0-25 Changes since suse-4.0-22-6: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/suse-4.0-25'
Tag 'suse-4.0-25' created by Andras Timar andras.ti...@collabora.com at 2014-06-26 10:05 -0700 suse-4.0-25 Changes since suse-4.0-24-2: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'refs/tags/suse-4.0-25'
Tag 'suse-4.0-25' created by Andras Timar andras.ti...@collabora.com at 2014-06-26 10:05 -0700 suse-4.0-25 Changes since suse-4.0-22-6: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Where are the base declarations for 'Point', 'sal_uInt16', 'sal_uInt32' etc?
Hi Rob, On Mon, Jun 23, 2014 at 01:49:39PM +0100, Rob Collins r...@entelecheia.com wrote: I have downloaded the libreoffice code source files and loaded them into KDevelop. I also downloaded the Libreoffice SDK. However, I can't find the declarations for many basic types. Point is in include/tools/gen.hxx, maybe KDevelop is confused about the SAL_WARN_UNUSED annotation between the keyword and the name, and throws away the information? In any case e.g. ctags can find it without issues: https://wiki.documentfoundation.org/Development/Vim#ctags Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Playing mp4 video's in Libreoffice Windows
On Thu, Jun 19, 2014 at 12:07:27PM +0200, Fernand Vanrie s...@pmgroup.be wrote: Wath 's the current situation and the future for playing mp4 video's in LibreOffice Windows ? Mp4 can aperently been played on Mac and Ubuntu (LO 4.3) From related issues i learned that there is new code using VLC and his included codec's Will the new code also work using the Basic and API who is currently using DirectX and limited to some older codec's (avi etc) oManager = CreateUnoService(com.sun.star.media.Manager_DirectX) oPlayer = oManager.createPlayer( videoURL ) Adding Minh to CC, who authored the VCL backend. signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - 2 commits - sc/source svx/source
sc/source/ui/view/drawview.cxx |2 +- svx/source/svdraw/gradtrns.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 21e4d0de7b8cce4941bebacf3e8d75c9e68ee176 Author: Damien Chambe damien.cha...@gmail.com Date: Sun Jun 15 21:17:41 2014 +0200 Resolves fdo#76160 Calc invalid image position on zooming Change-Id: Idd268a3378a902c173dc4d75d879714c2e919b2d Reviewed-on: https://gerrit.libreoffice.org/9792 Reviewed-by: Kohei Yoshida libreoff...@kohei.us Tested-by: Kohei Yoshida libreoff...@kohei.us (cherry picked from commit b8d84a3bf59212a9652f76d7852c81191b8c8a3b) diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx index c4a4da2..09d845a 100644 --- a/sc/source/ui/view/drawview.cxx +++ b/sc/source/ui/view/drawview.cxx @@ -321,7 +321,7 @@ void ScDrawView::RecalcScale() if (nEndCol20) nEndCol = 20; if (nEndRow20) -nEndRow = 1000; +nEndRow = 20; ScDrawUtil::CalcScale( pDoc, nTab, 0,0, nEndCol,nEndRow, pDev,aZoomX,aZoomY,nPPTX,nPPTY, aScaleX,aScaleY ); commit cb27f7ab60a0aac36de0dfe184149ffb339ad59b Author: Hideki Ikeda hideki.ik...@gmail.com Date: Tue Jun 24 19:05:51 2014 -0400 fdo#37401 - fixed the old vector length The center-left point in the area is used to calculate the old vector length but the coordinate was incorrect. Change-Id: I81a88182d11e30ee7a5caee3eac879b082bff160 Reviewed-on: https://gerrit.libreoffice.org/9887 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit 03675ab4a8994cb7000fd738d1685720c8b9e584) Related: fdo#37401 adjust fix to original aCenter use i.e. as far as I can see the bug came about during commit 74cb1c4cb5f72fd8cf80c6d144eda00841394647 Author: Ivo Hinkelmann i...@openoffice.org Date: Tue Nov 14 12:37:46 2006 + with 2006/10/27 12:14:08 aw 1.2.1208.5: #i39528# ::basegfx - basegfx adaption in -Vector2D aFullVec(aStartPos - aEndPos); -Vector2D aOldVec(Vector2D(aRect.Left(), aCenter.Y()) - aRect.TopLeft()); ^^^ -double fFullLen = aFullVec.GetLength(); -double fOldLen = aOldVec.GetLength(); -double fNewBorder = (fFullLen * 100.0) / fOldLen; -sal_Int32 nNewBorder = 100 - (sal_Int32)(fNewBorder + 0.5); +basegfx::B2DVector aFullVec(aStartPos - aEndPos); +const basegfx::B2DPoint aTopLeft(aRange.getMinX(), aRange.getMinY()); +const basegfx::B2DPoint aCenterLeft(aRange.getMinX(), aRange.getHeight()); ^^ +const basegfx::B2DVector aOldVec(aCenterLeft - aTopLeft); +const double fFullLen(aFullVec.getLength()); +const double fOldLen(aOldVec.getLength()); +const double fNewBorder((fFullLen * 100.0) / fOldLen); +sal_Int32 nNewBorder(100L - FRound(fNewBorder)); Change-Id: I840caa5e49a04f9b6460c4fa8e3731f3e5ebde05 (cherry picked from commit ef16d765306c932c49254f295f57e5853129c1ea) (cherry picked from commit 383135d77867d0f2c05b4c807eb17b099604eaa1) diff --git a/svx/source/svdraw/gradtrns.cxx b/svx/source/svdraw/gradtrns.cxx index f0bdfeb..be875b2 100644 --- a/svx/source/svdraw/gradtrns.cxx +++ b/svx/source/svdraw/gradtrns.cxx @@ -468,7 +468,7 @@ void GradTransformer::VecToGrad(GradTransVector rV, GradTransGradient rG, Grad { basegfx::B2DVector aFullVec(aStartPos - aEndPos); const basegfx::B2DPoint aTopLeft(aRange.getMinX(), aRange.getMinY()); -const basegfx::B2DPoint aCenterLeft(aRange.getMinX(), aRange.getHeight()); +const basegfx::B2DPoint aCenterLeft(aRange.getMinX(), aCenter.getY()); const basegfx::B2DVector aOldVec(aCenterLeft - aTopLeft); const double fFullLen(aFullVec.getLength()); const double fOldLen(aOldVec.getLength()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sw/source
sw/source/filter/ww8/ww8par.cxx |5 +- sw/source/filter/ww8/ww8par.hxx | 14 sw/source/filter/ww8/ww8par5.cxx | 66 --- sw/source/filter/ww8/ww8par6.cxx |6 +-- 4 files changed, 54 insertions(+), 37 deletions(-) New commits: commit 785b8653be59823eb9cc4efe49f4b87e2b545d33 Author: Oliver-Rainer Wittmann o...@apache.org Date: Thu Jun 26 09:24:49 2014 + 125122: WW8 import: Handle nested TOX fields - only the content of nested TOX fields is imported, no TOX field itself diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 690a066..14046d5 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -3724,8 +3724,9 @@ SwWW8ImplReader::SwWW8ImplReader(sal_uInt8 nVersionPara, SvStorage* pStorage, , nIdctHint(0) , bBidi(false) , bReadTable(false) -, mbLoadingTOCCache(false) -, mbLoadingTOCHyperlink(false) +, mbLoadingTOXCache(false) +, mnEmbeddedTOXLevel(0) +, mbLoadingTOXHyperlink(false) , mpPosAfterTOC(0) , mbCareFirstParaEndInToc(false) , mbCareLastParaEndInToc(false) diff --git a/sw/source/filter/ww8/ww8par.hxx b/sw/source/filter/ww8/ww8par.hxx index bc04b28..e3a862c 100644 --- a/sw/source/filter/ww8/ww8par.hxx +++ b/sw/source/filter/ww8/ww8par.hxx @@ -1216,10 +1216,12 @@ private: boost::shared_ptrSwPaM mpTableEndPaM; WW8PLCFx_Cp_FKP* pFirstTablePap; -// Indicate that currently on loading a TOC, managed by Read_F_TOX() and End_Field() -bool mbLoadingTOCCache; -// Indicate that current on loading a hyperlink, which is inside a TOC; Managed by Read_F_Hyperlink() and End_Field() -bool mbLoadingTOCHyperlink; +// Indicate that currently on loading a TOX, managed by Read_F_TOX() and End_Field() +bool mbLoadingTOXCache; +int mnEmbeddedTOXLevel; + +// Indicate that current on loading a hyperlink, which is inside a TOX; Managed by Read_F_Hyperlink() and End_Field() +bool mbLoadingTOXHyperlink; // a document position recorded the after-position of TOC section, managed by Read_F_TOX() and End_Field() SwPaM* mpPosAfterTOC; @@ -1289,12 +1291,10 @@ private: void ImportTox( int nFldId, String aStr ); void EndSprm( sal_uInt16 nId ); -// -- OD 2010-05-06 #i103711# -// -- OD 2010-05-11 #i105414# + void NewAttr( const SfxPoolItem rAttr, const bool bFirstLineOfStSet = false, const bool bLeftIndentSet = false ); -// -- bool GetFontParams(sal_uInt16, FontFamily, String, FontPitch, rtl_TextEncoding); diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx index 8bffc4b..9cfa749 100644 --- a/sw/source/filter/ww8/ww8par5.cxx +++ b/sw/source/filter/ww8/ww8par5.cxx @@ -706,41 +706,48 @@ sal_uInt16 SwWW8ImplReader::End_Field() } } break; -// Doing corresponding status management for TOC field, index field, hyperlink field and page reference field +// Doing corresponding status management for TOX field, index field, hyperlink field and page reference field case 13://TOX case 8://index -if (mbLoadingTOCCache) +if ( mbLoadingTOXCache ) { -maTOXEndCps.insert(nCP); -mbLoadingTOCCache = false; -if ( pPaM-End() - pPaM-End()-nNode.GetNode().GetTxtNode() - pPaM-End()-nNode.GetNode().GetTxtNode()-Len() == 0 ) +if ( mnEmbeddedTOXLevel 0 ) { -JoinNode(*pPaM); +--mnEmbeddedTOXLevel; } else { +maTOXEndCps.insert( nCP ); +mbLoadingTOXCache = false; +if ( pPaM-End() + pPaM-End()-nNode.GetNode().GetTxtNode() + pPaM-End()-nNode.GetNode().GetTxtNode()-Len() == 0 ) +{ +JoinNode( *pPaM ); +} +else +{ mbCareLastParaEndInToc = true; -} +} -if (mpPosAfterTOC) -{ -*pPaM = *mpPosAfterTOC; -delete mpPosAfterTOC; -mpPosAfterTOC = 0; +if ( mpPosAfterTOC ) +{ +*pPaM = *mpPosAfterTOC; +delete mpPosAfterTOC; +mpPosAfterTOC = 0; +} } } break; case 37://REF -
Re: [libreoffice-projects] minutes of ESC call ...
Hi, a quick hint, since I stumbled over this: On Thu, May 08, 2014 at 04:29:41PM +0100, Michael Meeks wrote: + HackFest 'pack' / box / Virtual Machines / etc. ? + Still have hardware to try out (Bjoern) + can bring to Paris - some quadro / quad CPU thingit (TDF-owned Sun Ultra 24 with Q9650) + if we buy new hardware: something like tinderboxes we have or ... + alternatives (from ebay): + refurbished HP DL165 with 24 cores at 1.5K EUR at 1HU/15kg + refurbished Lenovo W520s at ~1K EUR each (and plane-suitable) + total cost sub Eur 5k Also note these newfangled NUCs like the ZBOX IQ01: http://www.zotac.com/products/mini-pcs/zbox/product/zbox/detail/zbox-iq01/sort/starttime/order/DESC/amount/10/section/specifications.html Intel i7-4770T, easy to transport, price currently ~600EUR with 16GB RAM. + happy to have it at his place as a tinderbox the rest of the time (Kendy) Still, the Ultra 24 we own has to go first ... Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3a692cb2c8807ea587687de18067fe074a15d0aa Author: Andras Timar andras.ti...@collabora.com Date: Thu Jun 26 12:39:26 2014 +0200 Updated core Project: translations 1354e93464238d54dfd0605227afa4b1e475f421 diff --git a/translations b/translations index 9feb135..1354e93 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 9feb1358220557bb45003e586af56fc64d23918f +Subproject commit 1354e93464238d54dfd0605227afa4b1e475f421 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Branch 'libreoffice-4-3' - source/sl
source/sl/svtools/uiconfig/ui.po |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1354e93464238d54dfd0605227afa4b1e475f421 Author: Andras Timar andras.ti...@collabora.com Date: Thu Jun 26 12:39:26 2014 +0200 Updated Slovenian translation Change-Id: Ie948a952f62dfe4f37e1ae9b00c2b0ad6dbc0047 diff --git a/source/sl/svtools/uiconfig/ui.po b/source/sl/svtools/uiconfig/ui.po index 15bcee0..f1d2348 100644 --- a/source/sl/svtools/uiconfig/ui.po +++ b/source/sl/svtools/uiconfig/ui.po @@ -131,8 +131,8 @@ msgctxt GraphicExportDialog\n title\n string.text -msgid Options -msgstr Možnosti +msgid %1 Options +msgstr %1 Možnosti #: graphicexport.ui msgctxt ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Paris LibreOffice hackfest practical info
Hello everyone and especially devs who will be joining us tomorrow in Paris for the hackfest, The Simplon space will be open at 9 am and we can enter there at that time. I'll be there, here's my phone (+33)-0-6 98655424 The location is described here: https://wiki.documentfoundation.org/Hackfest/Paris2014 as well as here: www.simplon.co On the evening we will have a dinner in a central location in Paris at or around 7:30 pm but you'll know more on the spot tomorrow. Looking forward to see you all tomorrow! Charles. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/textboxhelper.cxx | 24 1 file changed, 24 insertions(+) New commits: commit ff4698da491f8d1d910559c53bd7bba49e8499d3 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu Jun 26 14:51:39 2014 +0200 SwTextBoxHelper::syncProperty: handle TextPreRotateAngle For now only the most problematic -270 case, for which we don't have a native writing direction: rotate the characters on a textportion level instead. CppunitTest_sw_ooxmlsdrexport's testFdo69636 is a reproducer for this, the document model was fine already, but with this, the layout has the rotation as well, as expected. Change-Id: Iefc56f3adcea614566aaefd41d832d9b0cdb730b diff --git a/sw/source/core/doc/textboxhelper.cxx b/sw/source/core/doc/textboxhelper.cxx index 2c90530..e0fbd5d 100644 --- a/sw/source/core/doc/textboxhelper.cxx +++ b/sw/source/core/doc/textboxhelper.cxx @@ -15,6 +15,7 @@ #include fmtornt.hxx #include fmtfsize.hxx #include doc.hxx +#include ndtxt.hxx #include docsh.hxx #include docary.hxx #include unocoll.hxx @@ -29,10 +30,12 @@ #include mvsave.hxx #include editeng/unoprnms.hxx +#include editeng/charrotateitem.hxx #include svx/svdoashp.hxx #include svx/unopage.hxx #include svx/svdpage.hxx #include svl/itemiter.hxx +#include comphelper/sequenceashashmap.hxx #include com/sun/star/document/XActionLockable.hpp #include com/sun/star/table/BorderLine2.hpp @@ -293,6 +296,27 @@ void SwTextBoxHelper::syncProperty(SwFrmFmt* pShape, const OUString rPropertyNa syncProperty(pShape, RES_HORI_ORIENT, MID_HORIORIENT_POSITION, uno::makeAny(static_castsal_Int32(convertTwipToMm100(aRectangle.Left(); syncProperty(pShape, RES_VERT_ORIENT, MID_VERTORIENT_POSITION, uno::makeAny(static_castsal_Int32(convertTwipToMm100(aRectangle.Top(); } + +if (SwFrmFmt* pFmt = findTextBox(pShape)) +{ +comphelper::SequenceAsHashMap aCustomShapeGeometry(rValue); +// That would be the btLr text direction which we don't support at a frame level, so do it at a character level. +if (aCustomShapeGeometry.find(TextPreRotateAngle) != aCustomShapeGeometry.end() aCustomShapeGeometry[TextPreRotateAngle].getsal_Int32() == -270) +{ +if (const SwNodeIndex* pNodeIndex = pFmt-GetCntnt().GetCntntIdx()) +{ +SwPaM aPaM(*pFmt-GetDoc()-GetNodes()[pNodeIndex-GetIndex() + 1], 0); +aPaM.SetMark(); +if (SwTxtNode* pMark = pFmt-GetDoc()-GetNodes()[pNodeIndex-GetNode().EndOfSectionIndex() - 1]-GetTxtNode()) +{ +aPaM.GetMark()-nNode = *pMark; +aPaM.GetMark()-nContent.Assign(pMark, pMark-GetTxt().getLength()); +SvxCharRotateItem aItem(900, false, RES_CHRATR_ROTATE); +pFmt-GetDoc()-InsertPoolItem(aPaM, aItem, 0); +} +} +} +} } else if (rPropertyName == UNO_NAME_TEXT_VERT_ADJUST) syncProperty(pShape, RES_TEXT_VERT_ADJUST, 0, rValue); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - oox/source
oox/source/drawingml/textcharacterproperties.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit ad9a48a2b31fc97bcfbf50b8f5731f520c281595 Author: Muthu Subramanian sumu...@collabora.com Date: Thu Dec 12 18:24:42 2013 +0530 n#828390: Reset charescapement. Unless the value is reset - the escapement seems to continue to the next set of textruns. (cherry picked from commit fdf77f50ab825bd2b44e980552f3383acf637b12) Signed-off-by: Andras Timar andras.ti...@collabora.com diff --git a/oox/source/drawingml/textcharacterproperties.cxx b/oox/source/drawingml/textcharacterproperties.cxx index a7be42b..8364c86 100644 --- a/oox/source/drawingml/textcharacterproperties.cxx +++ b/oox/source/drawingml/textcharacterproperties.cxx @@ -122,6 +122,9 @@ void TextCharacterProperties::pushToPropMap( PropertyMap rPropMap, const XmlFil if( moBaseline.has() ) { rPropMap[ PROP_CharEscapement ] = sal_Int16(moBaseline.get( 0 ) / 1000); rPropMap[ PROP_CharEscapementHeight ] = sal_Int8(DFLT_ESC_PROP); +} else { +rPropMap[ PROP_CharEscapement ] = sal_Int16(0); +rPropMap[ PROP_CharEscapementHeight ] = sal_Int8(100); // 100% } if( !bUseOptional || moBold.has() ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-libcmis' - uui/Library_uui.mk uui/source uui/uiconfig
uui/Library_uui.mk |1 uui/source/authfallbackdlg.cxx | 58 uui/source/authfallbackdlg.hxx | 43 ++ uui/uiconfig/ui/authfallback.ui | 93 4 files changed, 195 insertions(+) New commits: commit a01b8874f0aa93ac817405bafdf08a8250790325 Author: Mihai Varga mihai.m...@gmail.com Date: Thu Jun 26 16:50:06 2014 +0300 Authentication fallback dialog diff --git a/uui/Library_uui.mk b/uui/Library_uui.mk index 560cb65..cd85de6 100644 --- a/uui/Library_uui.mk +++ b/uui/Library_uui.mk @@ -38,6 +38,7 @@ $(eval $(call gb_Library_use_libraries,uui,\ $(eval $(call gb_Library_add_exception_objects,uui,\ uui/source/alreadyopen \ + uui/source/authfallbackdlg \ uui/source/filechanged \ uui/source/fltdlg \ uui/source/iahndl \ diff --git a/uui/source/authfallbackdlg.cxx b/uui/source/authfallbackdlg.cxx new file mode 100644 index 000..cae7deb --- /dev/null +++ b/uui/source/authfallbackdlg.cxx @@ -0,0 +1,58 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include authfallbackdlg.hxx + +#include vcl/msgbox.hxx + +using namespace boost; + +AuthFallbackDlg::AuthFallbackDlg( Window* pParent ) : +ModalDialog( pParent, AuthFallbackDlg, svt/ui/authfallback.ui ) +{ +get( m_pTVInstructions, instructions ); +get( m_pEDUrl, url ); +get( m_pEDCode, code ); +get( m_pBTOk, ok ); +get( m_pBTCancel, cancel ); + +m_pBTOk-SetClickHdl( LINK( this, AuthFallbackDlg, OKHdl) ); +m_pBTOk-Enable( false ); +} + +AuthFallbackDlg::AuthFallbackDlg( Window* pParent, +const OUString instructions, +const OUString url ) : +ModalDialog( pParent, AuthFallbackDlg, svt/ui/authfallback.ui ) +{ +get( m_pTVInstructions, instructions ); +get( m_pEDUrl, url ); +get( m_pEDCode, code ); +get( m_pBTOk, ok ); +get( m_pBTCancel, cancel ); + +m_pBTOk-SetClickHdl( LINK( this, AuthFallbackDlg, OKHdl) ); +m_pBTOk-Enable( false ); + +m_pTVInstructions-SetText( instructions ); +m_pEDUrl-SetText( url ); +} + +AuthFallbackDlg::~AuthFallbackDlg() +{ +} + +IMPL_LINK ( AuthFallbackDlg, OKHdl, Button *, EMPTYARG ) +{ +EndDialog( RET_OK ); +return 1; +} + + + diff --git a/uui/source/authfallbackdlg.hxx b/uui/source/authfallbackdlg.hxx new file mode 100644 index 000..818aa84 --- /dev/null +++ b/uui/source/authfallbackdlg.hxx @@ -0,0 +1,43 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef INCLUDED_SVTOOLS_AUTHFALLBACKDLG_HXX +#define INCLUDED_SVTOOLS_AUTHFALLBACKDLG_HXX + +#include vcl/button.hxx +#include vcl/dialog.hxx +#include vcl/edit.hxx +#include vcl/vclmedit.hxx + + +class AuthFallbackDlg : public ModalDialog +{ +private : + +VclMultiLineEdit* m_pTVInstructions; +Edit* m_pEDUrl; +Edit* m_pEDCode; +OKButton* m_pBTOk; +CancelButton* m_pBTCancel; + +public : + + AuthFallbackDlg( Window* pParent); + AuthFallbackDlg(Window* pParent, const OUString instructions, + const OUString url ); + virtual ~AuthFallbackDlg(); + +OUString GetCode() { return m_pEDCode-GetText(); } + +private: + +DECL_LINK ( OKHdl, Button * ); +}; + +#endif // INCLUDED_SVTOOLS_AUTHFALLBACKDLG_HXX diff --git a/uui/uiconfig/ui/authfallback.ui b/uui/uiconfig/ui/authfallback.ui new file mode 100644 index 000..86a0a81 --- /dev/null +++ b/uui/uiconfig/ui/authfallback.ui @@ -0,0 +1,93 @@ +?xml version=1.0 encoding=UTF-8? +interface + !-- interface-requires gtk+ 3.0 -- + object class=GtkDialog id=AuthenticationDialog +property name=can_focusFalse/property +property name=title translatable=yesOneDrive authentication code/property +child + object class=GtkBox id=box +property name=visibleTrue/property +property name=can_focusFalse/property +property name=orientationvertical/property +child + object class=GtkTextView id=instructions +property name=visibleTrue/property +property name=can_focusFalse/property +property name=pixels_below_lines4/property +property name=editableFalse/property +property name=cursor_visibleFalse/property + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-libcmis' - include/ucbhelper ucbhelper/Library_ucbhelper.mk ucbhelper/source
include/ucbhelper/authenticationfallback.hxx | 59 +++ ucbhelper/Library_ucbhelper.mk |1 ucbhelper/source/provider/authenticationfallback.cxx | 41 + 3 files changed, 101 insertions(+) New commits: commit 88c91f1178fd683a8aebf35dded0e00955de184f Author: Mihai Varga mihai.m...@gmail.com Date: Thu Jun 26 16:52:31 2014 +0300 Authentication request Change-Id: I8ff426960831a58fbd4a18309cd655c52d44eea1 diff --git a/include/ucbhelper/authenticationfallback.hxx b/include/ucbhelper/authenticationfallback.hxx new file mode 100644 index 000..19a6b7f --- /dev/null +++ b/include/ucbhelper/authenticationfallback.hxx @@ -0,0 +1,59 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the License); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ + +#ifndef INCLUDED_UCBHELPER_AUTHENTICATIONFALLBACK_HXX +#define INCLUDED_UCBHELPER_AUTHENTICATIONFALLBACK_HXX + +#include rtl/ref.hxx +#include ucbhelper/interactionrequest.hxx +#include ucbhelper/ucbhelperdllapi.h + +namespace ucbhelper { + +/** + * This class implements a simple authentication interaction request used + * when programmatically authentication cannot succeed. + * + * Read-only values : instructions, url + * Read-write values: code + */ +class UCBHELPER_DLLPUBLIC AuthenticationFallbackRequest : public ucbhelper::InteractionRequest +{ + +OUString m_Instructions; +OUString m_Url; +OUString m_Code; +public: +/** + * Constructor. + * + * @param rInstructions instructions to be followed by the user + * @param rURL contains a URL for which authentication is requested. + */ +AuthenticationFallbackRequest( const OUString rInstructions, + const OUString rURL ); +void setCode( const OUString code ) { m_Code = code; } +OUString getCode( ) { return m_Code; } +}; + +} // namespace ucbhelper + +#endif /* ! INCLUDED_UCBHELPER_AUTHENTICATIONFALLBACK_HXX*/ + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/ucbhelper/Library_ucbhelper.mk b/ucbhelper/Library_ucbhelper.mk index 8d1d805..bc755aa 100644 --- a/ucbhelper/Library_ucbhelper.mk +++ b/ucbhelper/Library_ucbhelper.mk @@ -33,6 +33,7 @@ $(eval $(call gb_Library_add_exception_objects,ucbhelper,\ ucbhelper/source/client/fileidentifierconverter \ ucbhelper/source/client/interceptedinteraction \ ucbhelper/source/client/proxydecider \ +ucbhelper/source/provider/authenticationfallback \ ucbhelper/source/provider/cancelcommandexecution \ ucbhelper/source/provider/contenthelper \ ucbhelper/source/provider/contentidentifier \ diff --git a/ucbhelper/source/provider/authenticationfallback.cxx b/ucbhelper/source/provider/authenticationfallback.cxx new file mode 100644 index 000..6692ac8 --- /dev/null +++ b/ucbhelper/source/provider/authenticationfallback.cxx @@ -0,0 +1,41 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the License); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ + +#include ucbhelper/authenticationfallback.hxx + +using namespace com::sun::star; +using namespace ucbhelper; + +AuthenticationFallbackRequest::AuthenticationFallbackRequest( + const OUString rInstructions, + const OUString rURL ) +{ + +m_Instructions = rInstructions; +
[Libreoffice-commits] core.git: Changes to 'feature/gsoc14-draw-chained-text-boxes'
New branch 'feature/gsoc14-draw-chained-text-boxes' available with the following commits: commit e918f1a987a543749cf5ec87fad1591332c8065e Author: matteocam matteo.campane...@gmail.com Date: Thu Jun 26 09:46:28 2014 +0200 Added chain attribute to SdrTextObj Change-Id: I065e9d36e2b9039466ed4e7531b3d963f145df6d ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - oox/source
oox/source/drawingml/textcharacterproperties.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit a9b019c66e1b492773a579135520d8a50b02f623 Author: Muthu Subramanian sumu...@collabora.com Date: Thu Dec 12 18:24:42 2013 +0530 n#828390: Reset charescapement. Unless the value is reset - the escapement seems to continue to the next set of textruns. (cherry picked from commit fdf77f50ab825bd2b44e980552f3383acf637b12) diff --git a/oox/source/drawingml/textcharacterproperties.cxx b/oox/source/drawingml/textcharacterproperties.cxx index a7be42b..8364c86 100644 --- a/oox/source/drawingml/textcharacterproperties.cxx +++ b/oox/source/drawingml/textcharacterproperties.cxx @@ -122,6 +122,9 @@ void TextCharacterProperties::pushToPropMap( PropertyMap rPropMap, const XmlFil if( moBaseline.has() ) { rPropMap[ PROP_CharEscapement ] = sal_Int16(moBaseline.get( 0 ) / 1000); rPropMap[ PROP_CharEscapementHeight ] = sal_Int8(DFLT_ESC_PROP); +} else { +rPropMap[ PROP_CharEscapement ] = sal_Int16(0); +rPropMap[ PROP_CharEscapementHeight ] = sal_Int8(100); // 100% } if( !bUseOptional || moBold.has() ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: GSoC mid-term evaluations NOW
Hi Cedric, Hi Fridrich, melange is crapping out on me. Neither my bjoern.michael...@gmail.com nor my bjoern.michael...@canonical.com account lets me take any action/evaluation. As mst (co-mentor) is on vacation too and possibly hasnt filed this, please handle this for me. Thanks. Best, Bjoern On Tue, Jun 17, 2014 at 08:06:30AM +0200, Cedric Bosdonnat wrote: The mid-term evaluations are just now! So, head to Google Melange and submit them before Friday. In case you really can't fill the evaluation your self, ask either your co-mentor or one of your beloved admins (Fridrich, Thorsten or myself) to do it. Below are the questions of the form. 1. How many years have you been a mentor for Google Summer of Code (Total - this doesn’t have to be consecutive)? 1. This is my first year 2. 2-3 years 2. 2-3 years 3. More than 3 years 2. If you answered “2-3 years” or “more than 3 years” as a mentor, what years did you participate? 3. How many years have you been a student in Google Summer of Code? 1. I have never been a student 1. I have never been a student 2. 1 year 3. 2 years 4. 3+ years 4. If you answered 2 years or 3+ years, what years did you participate as a student? 5. At what point did you first make contact with your student? 1. Before the program was announced 2. After my organization was selected to participate in Google Summer of Code 3. During the student application/acceptance phase of the program 3. During the student application/acceptance phase of the program 4. During the community bonding period 5. After the start of coding 6. How often do you and your student interact? 1. Daily 2. Every few days 3. Weekly 4. Every few weeks 4. Every few weeks 5. Monthly 6. Less than once a month 7. How do you communicate with your student? (Check all that apply) 1. Google+ Hangout 2. Voice (phone, Skype, etc.) 3. IM/IRC 3. IM/IRC 4. Private emails 5. Mailing Lists 5. Mailing Lists 6. Student blog updates 7. In-person meeting(s) 8. Other 8. Of the communication methods listed above, which do you use most frequently? IRC 9. How much time do you spend on Google Summer of Code per week (take into consideration your interactions with your student as well as time working with your org and on your own)? 1. 1-5 hours 1. 1-5 hours 2. 5-10 hours 3. 10-15 hours 4. 15-20 hours 5. More than 20 hours per week 10. How many time zones apart from your student are you? 1. Less than 3 2. 3-6 3. More than 6 11. How often do you require status updates from your student? 1. Daily 2. Every few days 3. Weekly 3. Weekly 4. Only when explicitly asked for by me 12. Please rate the quality of your interactions and communications with the student (consider his/her communication with you as well as your responses). 1. Very Good (Student is regularly responsive and the quality of communication is high) 1. Very Good (Student is regularly responsive and the quality of communication is high) 2. Good (Student is somewhat responsive and the quality of communication is okay) 3. Bad (Student is only somewhat or not at all responsive and the quality of communication is low) 13. Please rate the quality of the student’s
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/doc/textboxhelper.cxx | 14 -- sw/source/core/docnode/nodedump.cxx |3 +++ 2 files changed, 15 insertions(+), 2 deletions(-) New commits: commit 63da79385ad858f5040f8d0a8898d3b5be5e4f93 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu Jun 26 15:51:50 2014 +0200 SwTextBoxHelper::syncProperty: handle TextAutoGrowHeight This propagates the to shape to text property of the shape to the textbox, and the textbox is already layouted accordingly, but not the shape yet. (As the shape thinks it has no text.) Change-Id: I1fdf0d5743bcb201f112a4c5db18924210858cea diff --git a/sw/source/core/doc/textboxhelper.cxx b/sw/source/core/doc/textboxhelper.cxx index e0fbd5d..e93aae7 100644 --- a/sw/source/core/doc/textboxhelper.cxx +++ b/sw/source/core/doc/textboxhelper.cxx @@ -320,6 +320,8 @@ void SwTextBoxHelper::syncProperty(SwFrmFmt* pShape, const OUString rPropertyNa } else if (rPropertyName == UNO_NAME_TEXT_VERT_ADJUST) syncProperty(pShape, RES_TEXT_VERT_ADJUST, 0, rValue); +else if (rPropertyName == UNO_NAME_TEXT_AUTOGROWHEIGHT) +syncProperty(pShape, RES_FRM_SIZE, MID_FRMSIZE_IS_AUTO_HEIGHT, rValue); } void SwTextBoxHelper::getProperty(SwFrmFmt* pShape, sal_uInt16 nWID, sal_uInt8 nMemberId, css::uno::Any rValue) @@ -398,8 +400,16 @@ void SwTextBoxHelper::syncProperty(SwFrmFmt* pShape, sal_uInt16 nWID, sal_uInt8 } break; case RES_FRM_SIZE: -aPropertyName = UNO_NAME_SIZE; -bAdjustSize = true; +switch (nMemberId) +{ +case MID_FRMSIZE_IS_AUTO_HEIGHT: +aPropertyName = UNO_NAME_FRAME_ISAUTOMATIC_HEIGHT; +break; +default: +aPropertyName = UNO_NAME_SIZE; +bAdjustSize = true; +break; +} break; case RES_ANCHOR: switch (nMemberId) commit d89d8169716a748c098108eaada789206bb722c3 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu Jun 26 15:50:41 2014 +0200 sw doc model xml dump: handle SwFmtFrmSize Change-Id: Ie1a8dbc86c9725f3d238226c166ec657722c1770 diff --git a/sw/source/core/docnode/nodedump.cxx b/sw/source/core/docnode/nodedump.cxx index df9a8fb..248aa06 100644 --- a/sw/source/core/docnode/nodedump.cxx +++ b/sw/source/core/docnode/nodedump.cxx @@ -21,6 +21,7 @@ #include fmtautofmt.hxx #include fmtcntnt.hxx #include fmtornt.hxx +#include fmtfsize.hxx #include charfmt.hxx #include frmfmt.hxx #include fmtanchr.hxx @@ -413,6 +414,8 @@ void lcl_dumpSfxItemSet(WriterHelper writer, const SfxItemSet* pSet) case RES_FRM_SIZE: { pWhich = frame size; +const SwFmtFrmSize* pSize = static_castconst SwFmtFrmSize*(pItem); +oValue = height size type: + OString::number(pSize-GetHeightSizeType()) + , width size type: + OString::number(pSize-GetWidthSizeType()); break; } case RES_VERT_ORIENT: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 37401] EDITING with Gradient Tool: border between colors does not follow related control point movings
https://bugs.freedesktop.org/show_bug.cgi?id=37401 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] website.git: Branch 'update' - check.php
check.php | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) New commits: commit e04aa84a26db75182a5246812d4efcd6cc1f509e Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Thu Jun 26 16:46:00 2014 +0200 enable update for 4.2.5, also offer 4.2.5 for 4.1.x users diff --git a/check.php b/check.php index e8b5127..46f17a5 100644 --- a/check.php +++ b/check.php @@ -278,10 +278,19 @@ $build_hash_to_version = array( # 4.2.4 'd4c441391e20647b3d2e8dde4d20aa868e77e515' = '4.2.4.1', '63150712c6d317d27ce2db16eb94c2f3d7b699f8' = '4.2.4.2', # Final +# 4.2.5 +'881bb88abfe2992c6cede97c23e64a9885de87de' = '4.2.5.1', +'61cb170a04bb1f12e77c884eab9192be736ec5f5' = '4.2.5.2', # Final ## # 4.3.0 versions '46cfcd5a05aa1d13fecd73f5a25b64b8d8dd6781' = '4.3.0.0.a1', # alpha1 +'2e39c7e59c8fc8b16a54c3d981dceef27fb0c07f' = '4.3.0.0.b1', # beta1 +'b7cfa1eab1cb1e94f71d6df6612b73f231d0bf92' = '4.3.0.0.b1', # beta1-hotfix1 +'02d957703b758bfbd3aee0d349f65c4273bead78' = '4.3.0.0.b2', # beta2 +'a06aa316117a6ff0f05c697c82831c227812d810' = '4.3.0.0.b1', # beta1-buildfix1 +'67f5430184326974072b65403ef1d9d934fc4481' = '4.3.0.1', # rc1 +'9ed0c4329cf13f882dab0ee8b9ecd7b05e4aafbb' = '4.3.0.1', # rc1-buildfix1 ); # Descriptions of the target versions @@ -294,18 +303,18 @@ $build_hash_to_version = array( # where 'type' and 'lang' will be substitued with the right value # NOTE: '' in the URL has to be escaped as amp; $update_map = array( -'stable' = array('gitid' = '40ff705089295be5be0aae9b15123f687c05b0a', - 'id' = 'LibreOffice 4.1.6', - 'version' = '4.1.6', +'stable' = array('gitid' = '61cb170a04bb1f12e77c884eab9192be736ec5f5', + 'id' = 'LibreOffice 4.2.5', + 'version' = '4.2.5', 'update_type' = 'text/html', - 'update_src' = 'http://www.libreoffice.org/download/libreoffice-stable/?type=typeamp;lang=langamp;version=4.1.6', + 'update_src' = 'http://www.libreoffice.org/download/libreoffice-stable/?type=typeamp;lang=langamp;version=4.2.5', 'substitute' = true ), -'latest' = array('gitid' = '63150712c6d317d27ce2db16eb94c2f3d7b699f8', - 'id' = 'LibreOffice 4.2.4', - 'version' = '4.2.4', +'latest' = array('gitid' = '61cb170a04bb1f12e77c884eab9192be736ec5f5', + 'id' = 'LibreOffice 4.2.5', + 'version' = '4.2.5', 'update_type' = 'text/html', - 'update_src' = 'http://www.libreoffice.org/download/libreoffice-fresh/?type=typeamp;lang=langamp;version=4.2.4', + 'update_src' = 'http://www.libreoffice.org/download/libreoffice-fresh/?type=typeamp;lang=langamp;version=4.2.5', 'substitute' = true ), ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/libgltf
external/libgltf/UnpackedTarball_libgltf.mk |1 external/libgltf/patches/compiler_error_fixes.patch | 41 2 files changed, 42 insertions(+) New commits: commit 481a17b6a6fb332935c3e41c077cc5f60b751021 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Thu Jun 26 17:14:36 2014 +0200 libgltf: compiler error fixes: missing include and missing namespace Thanks to Rene Engelhard for the report and the fixes. Change-Id: Ia14980bdbcd9e714b1e9cd41f04af9371aa22371 diff --git a/external/libgltf/UnpackedTarball_libgltf.mk b/external/libgltf/UnpackedTarball_libgltf.mk index e8c5133..175fe43 100644 --- a/external/libgltf/UnpackedTarball_libgltf.mk +++ b/external/libgltf/UnpackedTarball_libgltf.mk @@ -28,6 +28,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,libgltf,\ external/libgltf/patches/no_animation_in_orbit_mode.patch \ external/libgltf/patches/walkthrough_mode_affects_orbit_mode_unexpectedly.patch \ external/libgltf/patches/move_fps_closer_to_the_corner.patch \ + external/libgltf/patches/compiler_error_fixes.patch \ )) # vim: set noet sw=4 ts=4: diff --git a/external/libgltf/patches/compiler_error_fixes.patch b/external/libgltf/patches/compiler_error_fixes.patch new file mode 100644 index 000..a2ff172 --- /dev/null +++ b/external/libgltf/patches/compiler_error_fixes.patch @@ -0,0 +1,41 @@ +diff -ur libgltf.org/src/Camera.cpp libgltf/src/Camera.cpp +--- libgltf.org/src/Camera.cpp 2014-06-26 15:49:57.807687346 +0200 libgltf/src/Camera.cpp 2014-06-26 15:50:46.195685296 +0200 +@@ -161,7 +161,7 @@ + } + else + { +-if (abs(x) 0.0001 || abs(y) 0.0001 || abs(z) 0.0001) ++if (std::abs(x) 0.0001 || std::abs(y) 0.0001 || std::abs(z) 0.0001) + { + bMoveCmeraModel = true; + } +@@ -240,7 +240,7 @@ + { + if (!bAerialView) + return; +-if (abs(horizontal) planar || abs(vertical) 0.0001) ++if (std::abs(horizontal) planar || std::abs(vertical) 0.0001) + { + bRotateCameraModel = true; + fRotateCameraXSpeed = 0; +@@ -275,7 +275,7 @@ + void CPhysicalCamera::RotateCamera(double horizontal, double vertical, +double planar) + { +-if (abs(horizontal) planar || abs(vertical) 0.0001) ++if (std::abs(horizontal) planar || std::abs(vertical) 0.0001) + { + bRotateCameraModel = true; + } +diff -ur libgltf.org/src/Font.cpp libgltf/src/Font.cpp +--- libgltf.org/src/Font.cpp 2014-06-26 15:49:57.807687346 +0200 libgltf/src/Font.cpp 2014-06-26 15:50:57.619684812 +0200 +@@ -8,6 +8,7 @@ + #include Font.h + + #include glm/gtc/matrix_transform.hpp ++#include cstdio + + using namespace std; + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: GSoC mid-term evaluations NOW
I see all mentor evaluation being filled. So this should be ok by now. F. On 26/06/14 16:14, Bjoern Michaelsen wrote: Hi Cedric, Hi Fridrich, melange is crapping out on me. Neither my bjoern.michael...@gmail.com nor my bjoern.michael...@canonical.com account lets me take any action/evaluation. As mst (co-mentor) is on vacation too and possibly hasnt filed this, please handle this for me. Thanks. Best, Bjoern On Tue, Jun 17, 2014 at 08:06:30AM +0200, Cedric Bosdonnat wrote: The mid-term evaluations are just now! So, head to Google Melange and submit them before Friday. In case you really can't fill the evaluation your self, ask either your co-mentor or one of your beloved admins (Fridrich, Thorsten or myself) to do it. Below are the questions of the form. 1. How many years have you been a mentor for Google Summer of Code (Total - this doesn’t have to be consecutive)? 1. This is my first year 2. 2-3 years 2. 2-3 years 3. More than 3 years 2. If you answered “2-3 years” or “more than 3 years” as a mentor, what years did you participate? 3. How many years have you been a student in Google Summer of Code? 1. I have never been a student 1. I have never been a student 2. 1 year 3. 2 years 4. 3+ years 4. If you answered 2 years or 3+ years, what years did you participate as a student? 5. At what point did you first make contact with your student? 1. Before the program was announced 2. After my organization was selected to participate in Google Summer of Code 3. During the student application/acceptance phase of the program 3. During the student application/acceptance phase of the program 4. During the community bonding period 5. After the start of coding 6. How often do you and your student interact? 1. Daily 2. Every few days 3. Weekly 4. Every few weeks 4. Every few weeks 5. Monthly 6. Less than once a month 7. How do you communicate with your student? (Check all that apply) 1. Google+ Hangout 2. Voice (phone, Skype, etc.) 3. IM/IRC 3. IM/IRC 4. Private emails 5. Mailing Lists 5. Mailing Lists 6. Student blog updates 7. In-person meeting(s) 8. Other 8. Of the communication methods listed above, which do you use most frequently? IRC 9. How much time do you spend on Google Summer of Code per week (take into consideration your interactions with your student as well as time working with your org and on your own)? 1. 1-5 hours 1. 1-5 hours 2. 5-10 hours 3. 10-15 hours 4. 15-20 hours 5. More than 20 hours per week 10. How many time zones apart from your student are you? 1. Less than 3 2. 3-6 3. More than 6 11. How often do you require status updates from your student? 1. Daily 2. Every few days 3. Weekly 3. Weekly 4. Only when explicitly asked for by me 12. Please rate the quality of your interactions and communications with the student (consider his/her communication with you as well as your responses). 1. Very Good (Student is regularly responsive and the quality of communication is high) 1. Very Good (Student is regularly responsive and the quality of communication is high) 2. Good (Student is somewhat responsive and the quality of communication is okay) 3. Bad (Student is only somewhat or not at all responsive and the quality of communication is low) 13. Please rate the quality of
[Libreoffice-commits] core.git: 3 commits - chart2/source include/svl svl/source
chart2/source/controller/dialogs/DataBrowserModel.cxx | 122 ++ chart2/source/controller/dialogs/DataBrowserModel.hxx |2 chart2/source/inc/DataSeriesHelper.hxx|5 chart2/source/tools/DataSeriesHelper.cxx | 12 + include/svl/sharedstring.hxx | 16 +- svl/source/misc/sharedstring.cxx | 32 6 files changed, 127 insertions(+), 62 deletions(-) New commits: commit 8c717ff5d7eb105380f88533edd244ea2e807499 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 11:22:59 2014 -0400 Revert needless inlining of methods for publicly exposed class. Keep the method implementations unexposed please. Change-Id: Ic9b1f8654e6ebef428d4182782c1aa4962934c6a diff --git a/include/svl/sharedstring.hxx b/include/svl/sharedstring.hxx index aac16df..fe9e851 100644 --- a/include/svl/sharedstring.hxx +++ b/include/svl/sharedstring.hxx @@ -34,18 +34,18 @@ public: bool operator== ( const SharedString r ) const; bool operator!= ( const SharedString r ) const; -OUString getString() const { return mpData ? OUString(mpData) : OUString();} +OUString getString() const; -rtl_uString* getData() { return mpData;} -const rtl_uString* getData() const { return mpData;} +rtl_uString* getData(); +const rtl_uString* getData() const; -rtl_uString* getDataIgnoreCase() { return mpDataIgnoreCase;} -const rtl_uString* getDataIgnoreCase() const { return mpDataIgnoreCase;} +rtl_uString* getDataIgnoreCase(); +const rtl_uString* getDataIgnoreCase() const; -bool isValid() const { return mpData != NULL;} -bool isEmpty() const { return mpData == NULL || mpData-length == 0;} +bool isValid() const; +bool isEmpty() const; -sal_Int32 getLength() const { return mpData ? mpData-length : 0;} +sal_Int32 getLength() const; }; } diff --git a/svl/source/misc/sharedstring.cxx b/svl/source/misc/sharedstring.cxx index 850d8df..8137952 100644 --- a/svl/source/misc/sharedstring.cxx +++ b/svl/source/misc/sharedstring.cxx @@ -95,13 +95,45 @@ bool SharedString::operator!= ( const SharedString r ) const return !operator== (r); } +OUString SharedString::getString() const +{ +return mpData ? OUString(mpData) : OUString(); +} +rtl_uString* SharedString::getData() +{ +return mpData; +} +const rtl_uString* SharedString::getData() const +{ +return mpData; +} +rtl_uString* SharedString::getDataIgnoreCase() +{ +return mpDataIgnoreCase; +} +const rtl_uString* SharedString::getDataIgnoreCase() const +{ +return mpDataIgnoreCase; +} +bool SharedString::isValid() const +{ +return mpData != NULL; +} +bool SharedString::isEmpty() const +{ +return mpData == NULL || mpData-length == 0; +} +sal_Int32 SharedString::getLength() const +{ +return mpData ? mpData-length : 0; +} } commit 8192df38879694db77228b9b046b149d53448c0e Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 10:58:55 2014 -0400 Clarify the code a little more. Change-Id: Idc0ff4913695ade9543cd30511aff61d24e7c495 diff --git a/chart2/source/controller/dialogs/DataBrowserModel.cxx b/chart2/source/controller/dialogs/DataBrowserModel.cxx index 49dfec3..e2bff5b 100644 --- a/chart2/source/controller/dialogs/DataBrowserModel.cxx +++ b/chart2/source/controller/dialogs/DataBrowserModel.cxx @@ -186,9 +186,10 @@ struct lcl_RepresentationsOfLSeqMatch : public ::std::unary_function Reference {} bool operator() ( const Reference chart2::data::XLabeledDataSequence xLSeq ) { -return (xLSeq.is() -xLSeq-getValues().is() -(xLSeq-getValues()-getSourceRangeRepresentation() == m_aValuesRep )); +if (!xLSeq.is() || !xLSeq-getValues().is()) +return false; + +return xLSeq-getValues()-getSourceRangeRepresentation() == m_aValuesRep; } private: OUString m_aValuesRep; @@ -475,42 +476,55 @@ void DataBrowserModel::removeDataSeriesOrComplexCategoryLevel( sal_Int32 nAtColu //delete sequences from internal data provider that are not used anymore //but do not delete sequences that are still in use by the remaining series + Reference chart2::XInternalDataProvider xDataProvider( m_apDialogModel-getDataProvider(), uno::UNO_QUERY ); -Reference chart2::data::XDataSource xSourceOfDeletedSeries( xSeries, uno::UNO_QUERY ); -if( xDataProvider.is() xSourceOfDeletedSeries.is()) +Reference chart2::data::XDataSource xSourceOfDeleted( xSeries, uno::UNO_QUERY ); +if (!xDataProvider.is() || !xSourceOfDeleted.is()) { -::std::vector sal_Int32 aSequenceIndexesToDelete; -Sequence Reference chart2::data::XLabeledDataSequence aSequencesOfDeletedSeries( xSourceOfDeletedSeries-getDataSequences() ); -Reference chart2::XDataSeriesContainer xSeriesCnt( getHeaderForSeries( xSeries ).m_xChartType,
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2 commits - 36/8b3a6660e8623e43529e21e41fbce1192e6a92 78/5b8653be59823eb9cc4efe49f4b87e2b545d33
36/8b3a6660e8623e43529e21e41fbce1192e6a92 |1 + 78/5b8653be59823eb9cc4efe49f4b87e2b545d33 |1 + 2 files changed, 2 insertions(+) New commits: commit ca117f62435394dd27469b89e1f8865faf9822f0 Author: Caolán McNamara caol...@redhat.com Date: Thu Jun 26 16:30:05 2014 +0100 Notes added by 'git notes add' diff --git a/36/8b3a6660e8623e43529e21e41fbce1192e6a92 b/36/8b3a6660e8623e43529e21e41fbce1192e6a92 new file mode 100644 index 000..83502b4 --- /dev/null +++ b/36/8b3a6660e8623e43529e21e41fbce1192e6a92 @@ -0,0 +1 @@ +merged as: 2f7b92c5bbd1b1aaa857a41457d866e04ce603a2 commit 8a9a19abfa54c74488bb94b8bab96b578d581b08 Author: Caolán McNamara caol...@redhat.com Date: Thu Jun 26 16:29:50 2014 +0100 Notes added by 'git notes add' diff --git a/78/5b8653be59823eb9cc4efe49f4b87e2b545d33 b/78/5b8653be59823eb9cc4efe49f4b87e2b545d33 new file mode 100644 index 000..6cb3248 --- /dev/null +++ b/78/5b8653be59823eb9cc4efe49f4b87e2b545d33 @@ -0,0 +1 @@ +merged as: e28797356f34253bcbe7237d7bfdbcda2a3f5b3c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 0a/4564b42de0fc61253ae4e69039860c09e53eba
0a/4564b42de0fc61253ae4e69039860c09e53eba |1 + 1 file changed, 1 insertion(+) New commits: commit db153b459a851cc58b3f8de2440a0ebe749c7250 Author: Caolán McNamara caol...@redhat.com Date: Thu Jun 26 16:30:24 2014 +0100 Notes added by 'git notes add' diff --git a/0a/4564b42de0fc61253ae4e69039860c09e53eba b/0a/4564b42de0fc61253ae4e69039860c09e53eba new file mode 100644 index 000..a8d0af4 --- /dev/null +++ b/0a/4564b42de0fc61253ae4e69039860c09e53eba @@ -0,0 +1 @@ +merged as: aeeb125c4d64abe9fcc7f74b14e855a823bd74ae ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/04060182.xhp | 59 ++ 1 file changed, 59 insertions(+) New commits: commit cb00f782515e7a11796d7996e89073a4ecfdb3d7 Author: Olivier Hallot olivier.hal...@edx.srv.br Date: Thu Jun 26 09:04:37 2014 -0300 Fix bug fdo#80431 Help entries for GAMMA functions Provides help entries for functions GAMMA.DIST GAMMA.INV and GAMMALN.PRECISE Change-Id: I9a675d40f7eca6a799e49706e062ea77e05feffd Reviewed-on: https://gerrit.libreoffice.org/9916 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/source/text/scalc/01/04060182.xhp b/source/text/scalc/01/04060182.xhp index f462edb..3d595d0 100644 --- a/source/text/scalc/01/04060182.xhp +++ b/source/text/scalc/01/04060182.xhp @@ -155,6 +155,29 @@ paragraph xml-lang=en-US id=par_id3153331 role=paragraph l10n=U oldref=55 item type=input=GAMMAINV(0.8;1;1)/item yields 1.61./paragraph /section + + section id=gammadotinv +bookmark xml-lang=en-US branch=index id=bm_id2914841bookmark_valueGAMMA.INV function/bookmark_value +/bookmark +bookmark xml-lang=en-US branch=hid/SC_HID_FUNC_GAMMAINV_MS id=bm_id2919249 localize=false/ +paragraph xml-lang=en-US id=hd_id2914841 role=heading level=2 l10n=U +oldref=47GAMMA.INV/paragraph + paragraph xml-lang=en-US id=par_id2913932 role=paragraph l10n=U oldref=48ahelp hid=HID_FUNC_GAMMAINV_MSReturns the inverse of the Gamma cumulative distribution GAMMADIST./ahelp This function allows you to search for variables with different distribution./paragraph +paragraph id=par_id291422405814 role=paragraph xml-lang=en-USThis function is identical to GAMAINV and was introduced for interoperability with other office suites./paragraph + paragraph xml-lang=en-US id=hd_id2919949 role=heading level=3 l10n=U +oldref=49Syntax/paragraph + paragraph xml-lang=en-US id=par_id2915828 role=code l10n=U oldref=50GAMMA.INV(Number; Alpha; Beta)/paragraph + paragraph xml-lang=en-US id=par_id2915138 role=paragraph l10n=U oldref=51 +emphNumber/emph is the probability value for which the inverse Gamma distribution is to be calculated./paragraph + paragraph xml-lang=en-US id=par_id2912785 role=paragraph l10n=U oldref=52 +emphAlpha/emph is the parameter Alpha of the Gamma distribution./paragraph + paragraph xml-lang=en-US id=par_id2914561 role=paragraph l10n=U oldref=53 +emphBeta/emph is the parameter Beta of the Gamma distribution./paragraph + paragraph xml-lang=en-US id=hd_id2918734 role=heading level=3 l10n=U +oldref=54Example/paragraph + paragraph xml-lang=en-US id=par_id2913331 role=paragraph l10n=U oldref=55 +item type=input=GAMMA.INV(0.8;1;1)/item yields 1.61./paragraph + /section section id=gammaln bookmark xml-lang=en-US branch=index id=bm_id3154806bookmark_valueGAMMALN function/bookmark_value bookmark_valuenatural logarithm of Gamma function/bookmark_value @@ -173,6 +196,24 @@ paragraph xml-lang=en-US id=par_id3153730 role=paragraph l10n=U oldref=63 item type=input=GAMMALN(2)/item yields 0./paragraph /section + section id=gammalnprecise +bookmark xml-lang=en-US branch=index id=bm_id2914806bookmark_valueGAMMALN.PRECISE function/bookmark_value + bookmark_valuenatural logarithm of Gamma function/bookmark_value +/bookmarkcommentmw added one entry/comment +bookmark xml-lang=en-US branch=hid/SC_HID_FUNC_GAMMALN_MS id=bm_id2919511 localize=false/ +paragraph xml-lang=en-US id=hd_id2914806 role=heading level=2 l10n=U +oldref=57GAMMALN.PRECISE/paragraph + paragraph xml-lang=en-US id=par_id2918572 role=paragraph l10n=U oldref=58ahelp hid=HID_FUNC_GAMMALN_MSReturns the natural logarithm of the Gamma function: G(x)./ahelp/paragraph + paragraph xml-lang=en-US id=hd_id2912999 role=heading level=3 l10n=U +oldref=59Syntax/paragraph + paragraph xml-lang=en-US id=par_id2913112 role=code l10n=U oldref=60GAMMALN.PRECISE(Number)/paragraph + paragraph xml-lang=en-US id=par_id2914502 role=paragraph l10n=U oldref=61 +emphNumber/emph is the value for which the natural logarithm of the Gamma function is to be calculated./paragraph + paragraph xml-lang=en-US id=hd_id2913568 role=heading level=3 l10n=U +oldref=62Example/paragraph + paragraph xml-lang=en-US id=par_id2913730 role=paragraph l10n=U oldref=63 +item type=input=GAMMALN.PRECISE(2)/item yields 0./paragraph + /section section id=gammadist bookmark xml-lang=en-US branch=index id=bm_id3150132bookmark_valueGAMMADIST function/bookmark_value /bookmark @@ -197,6 +238,24 @@ paragraph xml-lang=en-US id=par_id3145354 role=paragraph
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 007378409a258911c1fbe589f9cdf66b69d52211 Author: Olivier Hallot olivier.hal...@edx.srv.br Date: Thu Jun 26 09:04:37 2014 -0300 Updated core Project: help cb00f782515e7a11796d7996e89073a4ecfdb3d7 Fix bug fdo#80431 Help entries for GAMMA functions Provides help entries for functions GAMMA.DIST GAMMA.INV and GAMMALN.PRECISE Change-Id: I9a675d40f7eca6a799e49706e062ea77e05feffd Reviewed-on: https://gerrit.libreoffice.org/9916 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/helpcontent2 b/helpcontent2 index c18a4da..cb00f78 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit c18a4da59f386b125bf65adc0238a4fa712910a5 +Subproject commit cb00f782515e7a11796d7996e89073a4ecfdb3d7 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/04060115.xhp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit d2e055fb50d07664c8b90456c07c2d39d49e62df Author: Stanislav Horacek stanislav.hora...@gmail.com Date: Wed Jun 25 21:09:15 2014 +0200 fdo#63274 clarify hexadecimal argument in HEX2DEC and similar functions Change-Id: Ic8a4beb3f544be25706bd3f8c00beac150354fa8 Reviewed-on: https://gerrit.libreoffice.org/9906 Tested-by: Andras Timar andras.ti...@collabora.com Reviewed-by: Andras Timar andras.ti...@collabora.com diff --git a/source/text/scalc/01/04060115.xhp b/source/text/scalc/01/04060115.xhp index 0e27290..2c69e29 100644 --- a/source/text/scalc/01/04060115.xhp +++ b/source/text/scalc/01/04060115.xhp @@ -252,12 +252,12 @@ paragraph role=heading id=hd_id3156117 xml-lang=en-US level=3 l10n=U oldref=81Syntax/paragraph paragraph role=code id=par_id3155847 xml-lang=en-US l10n=U oldref=82HEX2BIN(Number; Places)/paragraph paragraph role=paragraph id=par_id3152810 xml-lang=en-US l10n=U oldref=83 -emphNumber/emph is a hexadecimal number. The number can have a maximum of 10 places. The most significant bit is the sign bit, the following bits return the value. Negative numbers are entered as two's complement./paragraph +emphNumber/emph is a hexadecimal number or a string that represents a hexadecimal number. It can have a maximum of 10 places. The most significant bit is the sign bit, the following bits return the value. Negative numbers are entered as two's complement./paragraph paragraph role=paragraph id=par_id3153758 xml-lang=en-US l10n=U oldref=84 emphPlaces/emph is the number of places to be output./paragraph paragraph role=heading id=hd_id3154052 xml-lang=en-US level=3 l10n=U oldref=85Example/paragraph paragraph role=paragraph id=par_id3156002 xml-lang=en-US l10n=U oldref=86 -item type=input=HEX2BIN(64;8)/item returns 01100100./paragraph +item type=input=HEX2BIN(6a;8)/item returns 01101010./paragraph /section section id=hex2dec bookmark xml-lang=en-US branch=index id=bm_id3154742bookmark_valueHEX2DEC function/bookmark_value @@ -269,10 +269,10 @@ paragraph role=heading id=hd_id3143233 xml-lang=en-US level=3 l10n=U oldref=89Syntax/paragraph paragraph role=code id=par_id3149293 xml-lang=en-US l10n=U oldref=90HEX2DEC(Number)/paragraph paragraph role=paragraph id=par_id3159176 xml-lang=en-US l10n=U oldref=91 -emphNumber/emph is a hexadecimal number. The number can have a maximum of 10 places. The most significant bit is the sign bit, the following bits return the value. Negative numbers are entered as two's complement./paragraph +emphNumber/emph is a hexadecimal number or a string that represents a hexadecimal number. It can have a maximum of 10 places. The most significant bit is the sign bit, the following bits return the value. Negative numbers are entered as two's complement./paragraph paragraph role=heading id=hd_id3154304 xml-lang=en-US level=3 l10n=U oldref=92Example/paragraph paragraph role=paragraph id=par_id3146093 xml-lang=en-US l10n=U oldref=93 -item type=input=HEX2DEC(64)/item returns 100./paragraph +item type=input=HEX2DEC(6a)/item returns 106./paragraph /section section id=hex2oct bookmark xml-lang=en-US branch=index id=bm_id3149750bookmark_valueHEX2OCT function/bookmark_value @@ -284,12 +284,12 @@ paragraph role=heading id=hd_id3145660 xml-lang=en-US level=3 l10n=U oldref=96Syntax/paragraph paragraph role=code id=par_id3151170 xml-lang=en-US l10n=U oldref=97HEX2OCT(Number; Places)/paragraph paragraph role=paragraph id=par_id3152795 xml-lang=en-US l10n=U oldref=98 -emphNumber/emph is a hexadecimal number. The number can have a maximum of 10 places. The most significant bit is the sign bit, the following bits return the value. Negative numbers are entered as two's complement./paragraph +emphNumber/emph is a hexadecimal number or a string that represents a hexadecimal number. It can have a maximum of 10 places. The most significant bit is the sign bit, the following bits return the value. Negative numbers are entered as two's complement./paragraph paragraph role=paragraph id=par_id3149204 xml-lang=en-US l10n=U oldref=99 emphPlaces/emph is the number of places to be output./paragraph paragraph role=heading id=hd_id3153901 xml-lang=en-US level=3 l10n=U oldref=100Example/paragraph paragraph role=paragraph id=par_id3159341 xml-lang=en-US l10n=U oldref=101 -item type=input=HEX2OCT(64;4)/item returns 0144./paragraph +item type=input=HEX2OCT(6a;4)/item returns 0152./paragraph /section /sort section id=Section1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 02bf9ed73a666a047c4a076de027d8ce0ef73c63 Author: Stanislav Horacek stanislav.hora...@gmail.com Date: Wed Jun 25 21:09:15 2014 +0200 Updated core Project: help d2e055fb50d07664c8b90456c07c2d39d49e62df fdo#63274 clarify hexadecimal argument in HEX2DEC and similar functions Change-Id: Ic8a4beb3f544be25706bd3f8c00beac150354fa8 Reviewed-on: https://gerrit.libreoffice.org/9906 Tested-by: Andras Timar andras.ti...@collabora.com Reviewed-by: Andras Timar andras.ti...@collabora.com diff --git a/helpcontent2 b/helpcontent2 index cb00f78..d2e055f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit cb00f782515e7a11796d7996e89073a4ecfdb3d7 +Subproject commit d2e055fb50d07664c8b90456c07c2d39d49e62df ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sw/source
sw/source/core/frmedt/feshview.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 01ee29125610a0fe4d6dcb080da09e3961f1236a Author: Julien Nabet serval2...@yahoo.fr Date: Wed Jun 25 21:58:47 2014 +0200 Resolves fdo#54155: Crash when playing with a Group inside a Group Cherry-picked from 7bd94d73ec56622685d0e23f8b5133ba110524be Change-Id: I89c80fca1cdc8bc88172eaf8057141d5e42a06dc Reviewed-on: https://gerrit.libreoffice.org/9910 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sw/source/core/frmedt/feshview.cxx b/sw/source/core/frmedt/feshview.cxx index c13dd12..04f2945 100644 --- a/sw/source/core/frmedt/feshview.cxx +++ b/sw/source/core/frmedt/feshview.cxx @@ -1198,7 +1198,7 @@ sal_Bool SwFEShell::ShouldObjectBeSelected(const Point rPt) // Don't select header / footer objects in body edition and vice-versa SwContact* pContact = static_castSwContact*(pObj-GetUserCall()); -if ( !pContact-ObjAnchoredAtPage() ) +if (pContact !pContact-ObjAnchoredAtPage() ) { const SwPosition rPos = pContact-GetCntntAnchor(); bool bInHdrFtr = GetDoc()-IsInHeaderFooter( rPos.nNode ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: tools/source
tools/source/datetime/tdate.cxx |6 -- 1 file changed, 6 deletions(-) New commits: commit d6817ba7a74ba22206006f0783c788a5dc774236 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 17:40:18 2014 +0200 Mac OS X does provide localtime_r Change-Id: I0a8860f2b0ea053cdfe9504dc266be36cdb0043e diff --git a/tools/source/datetime/tdate.cxx b/tools/source/datetime/tdate.cxx index 720692b..4fc2fc0 100644 --- a/tools/source/datetime/tdate.cxx +++ b/tools/source/datetime/tdate.cxx @@ -26,12 +26,6 @@ #include tools/date.hxx #include sal/log.hxx -#ifdef MACOSX -extern C { -struct tm *localtime_r(const time_t *timep, struct tm *buffer); -} -#endif - static const sal_uInt16 aDaysInMonth[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/source
sw/source/core/frmedt/feshview.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 44ae2ff6d2271949b2a4d22d017003f948b6aa2a Author: Julien Nabet serval2...@yahoo.fr Date: Wed Jun 25 21:58:47 2014 +0200 Resolves fdo#54155: Crash when playing with a Group inside a Group Cherry-picked from 7bd94d73ec56622685d0e23f8b5133ba110524be Change-Id: I89c80fca1cdc8bc88172eaf8057141d5e42a06dc Reviewed-on: https://gerrit.libreoffice.org/9909 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sw/source/core/frmedt/feshview.cxx b/sw/source/core/frmedt/feshview.cxx index 03d3a39..0513275 100644 --- a/sw/source/core/frmedt/feshview.cxx +++ b/sw/source/core/frmedt/feshview.cxx @@ -1117,7 +1117,7 @@ bool SwFEShell::ShouldObjectBeSelected(const Point rPt) // Don't select header / footer objects in body edition and vice-versa SwContact* pContact = static_castSwContact*(pObj-GetUserCall()); -if ( !pContact-ObjAnchoredAtPage() ) +if (pContact !pContact-ObjAnchoredAtPage() ) { const SwPosition rPos = pContact-GetCntntAnchor(); bool bInHdrFtr = GetDoc()-IsInHeaderFooter( rPos.nNode ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/source
sw/source/core/uibase/dbui/dbmgr.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit f0c2bb87122307cd7462a84a5196ec24dbfd3fb6 Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Jun 25 15:20:55 2014 +0200 MSWord uses \xb for linebreaks in DB fields, take 2 (bnc#878854) This commit also does the conversion when reading the data from a data source using the mail merge wizard. Change-Id: Ia14417507b6ddce955fec26142a42ce51f77de4e (cherry picked from commit 076e4afc61b216e34959bd4e3701f1fa19972d5c) Reviewed-on: https://gerrit.libreoffice.org/9902 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sw/source/core/uibase/dbui/dbmgr.cxx b/sw/source/core/uibase/dbui/dbmgr.cxx index 4574a91..79d417d 100644 --- a/sw/source/core/uibase/dbui/dbmgr.cxx +++ b/sw/source/core/uibase/dbui/dbmgr.cxx @@ -1669,6 +1669,7 @@ OUString SwDBManager::GetDBField(uno::ReferenceXPropertySet xColumnProps, try { sRet = xColumn-getString(); +sRet = sRet.replace( '\xb', '\n' ); // MSWord uses \xb as a newline } catch(const SQLException) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/inforeadonlydialog.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2b7c7fab14ce73dd04d636af05ee837ea7de8f23 Author: Joel jmadero@gmail.com Date: Wed Jun 25 10:09:16 2014 -0700 fdo#62879 Changed wording of protected section dialog Clarified the wording of protected section dialog from Readonly content cannot be changed. to Write protected sections cannot be changed. Change-Id: Ic6df2d84b6cc9e87727306eff8aa0e06895cab17 Reviewed-on: https://gerrit.libreoffice.org/9905 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sw/uiconfig/swriter/ui/inforeadonlydialog.ui b/sw/uiconfig/swriter/ui/inforeadonlydialog.ui index d96c668..ff3498e 100644 --- a/sw/uiconfig/swriter/ui/inforeadonlydialog.ui +++ b/sw/uiconfig/swriter/ui/inforeadonlydialog.ui @@ -9,7 +9,7 @@ property name=type_hintdialog/property property name=skip_taskbar_hintTrue/property property name=buttonsok/property -property name=text translatable=yesReadonly content cannot be changed./property +property name=text translatable=yesWrite protected sections cannot be changed./property property name=secondary_text translatable=yesNo modifications will be accepted./property child internal-child=vbox object class=GtkBox id=messagedialog-vbox ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - vcl/source
vcl/source/gdi/bitmap3.cxx | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) New commits: commit db298f22a04e409a555d7c3ccec4c1dae91a6e1b Author: Caolán McNamara caol...@redhat.com Date: Wed Jun 25 16:36:28 2014 +0100 Related: fdo#33455 retain color on scaling of 1 bit depth pngs Change-Id: I445ce672742ddb6d6592ef419bf5e14c5f09a5b5 (cherry picked from commit be9d65bb5f5a83c19eec02a037b8f808de70ecb8) diff --git a/vcl/source/gdi/bitmap3.cxx b/vcl/source/gdi/bitmap3.cxx index 7ee6405..0384e00 100644 --- a/vcl/source/gdi/bitmap3.cxx +++ b/vcl/source/gdi/bitmap3.cxx @@ -859,9 +859,7 @@ bool Bitmap::Scale( const double rScaleX, const double rScaleY, sal_uInt32 nSc { bool bRetval(false); -#ifdef DBG_UTIL const sal_uInt16 nStartCount(GetBitCount()); -#endif if(basegfx::fTools::equalZero(rScaleX) || basegfx::fTools::equalZero(rScaleY)) { @@ -875,6 +873,22 @@ bool Bitmap::Scale( const double rScaleX, const double rScaleY, sal_uInt32 nSc bRetval = true; } +//fdo#33455 +// +//If we start with a 1 bit image, then after scaling it in any mode except +//BMP_SCALE_FAST we have a a 24bit image which is perfectly correct, but we +//are going to down-shift it to mono again and Bitmap::ImplMakeMono just +//has Bitmap aNewBmp( GetSizePixel(), 1 ); to create a 1 bit bitmap which +//will default to black/white and the colors mapped to which ever is closer +//to black/white +// +//So the easiest thing to do to retain the colors of 1 bit bitmaps is to +//just use the fast scale rather than attempting to count unique colors in +//the other converters and pass all the info down through +//Bitmap::ImplMakeMono +if (nStartCount == 1 nScaleFlag != BMP_SCALE_NONE) +nScaleFlag = BMP_SCALE_FAST; + switch(nScaleFlag) { case BMP_SCALE_NONE : @@ -894,7 +908,7 @@ bool Bitmap::Scale( const double rScaleX, const double rScaleY, sal_uInt32 nSc } case BMP_SCALE_SUPER : { -if(GetSizePixel().Width() 2 || GetSizePixel().Height() 2) +if (GetSizePixel().Width() 2 || GetSizePixel().Height() 2) { // fallback to ImplScaleFast bRetval = ImplScaleFast( rScaleX, rScaleY ); @@ -936,13 +950,7 @@ bool Bitmap::Scale( const double rScaleX, const double rScaleY, sal_uInt32 nSc } } -#ifdef DBG_UTIL -if(bRetval nStartCount != GetBitCount()) -{ -OSL_ENSURE(false, Bitmap::Scale has changed the ColorDepth, this should *not* happen (!)); -} -#endif - +OSL_ENSURE(!bRetval || nStartCount == GetBitCount(), Bitmap::Scale has changed the ColorDepth, this should *not* happen (!)); return bRetval; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/lingu/olmenu.src |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 224d51af5aa9faa33a57f1325431cd12a7952a62 Author: Joren De Cuyper jore...@libreoffice.org Date: Wed Jun 25 21:49:13 2014 +0200 fdo#48673 - UI: No keyboard shortcut for Ignore All on misspelled word Also added mnemonic for Ignore entry Change-Id: I044fc0a718a32fe7b502d2c342ba5f09921053ec Reviewed-on: https://gerrit.libreoffice.org/9908 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sw/source/uibase/lingu/olmenu.src b/sw/source/uibase/lingu/olmenu.src index 293d804..6d7947b 100644 --- a/sw/source/uibase/lingu/olmenu.src +++ b/sw/source/uibase/lingu/olmenu.src @@ -33,7 +33,7 @@ Menu MN_SPELL_POPUP { Identifier = MN_IGNORE_WORD ; HelpID = HID_LINGU_IGNORE_WORD ; -Text [ en-US ] = Ignore All ; +Text [ en-US ] = I~gnore All ; }; MenuItem { @@ -116,7 +116,7 @@ String STR_LANGSTATUS_MORE }; String STR_IGNORE_SELECTION { -Text [ en-US ] = Ignore ; +Text [ en-US ] = ~Ignore ; }; String STR_EXPLANATION_LINK { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source sc/uiconfig
sc/source/ui/src/scstring.src |2 +- sc/source/ui/unoobj/docuno.cxx | 20 ++-- sc/uiconfig/scalc/ui/printeroptions.ui |8 3 files changed, 15 insertions(+), 15 deletions(-) New commits: commit 0ac652bbc01ab7c9304b5e230695f4193dfadd09 Author: Joren De Cuyper jore...@libreoffice.org Date: Wed Jun 25 21:26:00 2014 +0200 fdo#39111 - UI inconsistent concerning suppression of output for empty pages Change-Id: I6017e77e46298b45c7584830178455fe29016209 Reviewed-on: https://gerrit.libreoffice.org/9907 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sc/source/ui/src/scstring.src b/sc/source/ui/src/scstring.src index b083fff..cc07d2c 100644 --- a/sc/source/ui/src/scstring.src +++ b/sc/source/ui/src/scstring.src @@ -784,7 +784,7 @@ StringArray SCSTR_PRINT_OPTIONS ItemList [en-US] = { Pages; ; - ~Include output of empty pages; ; + ~Suppress output of empty pages; ; Print content; ; ~All sheets; ; ~Selected sheets; ; diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 57a80b5..2662e4c 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -242,10 +242,10 @@ ScPrintUIOptions::ScPrintUIOptions() m_aUIProperties[nIdx++].Value = setSubgroupControlOpt(pages, OUString(aStrings.GetString(0)), OUString()); // create a bool option for empty pages -m_aUIProperties[nIdx++].Value = setBoolControlOpt(includeemptypages, OUString( aStrings.GetString( 1 ) ), - .HelpID:vcl:PrintDialog:IsIncludeEmptyPages:CheckBox, - IsIncludeEmptyPages, - ! bSuppress); +m_aUIProperties[nIdx++].Value = setBoolControlOpt(suppressemptypages, OUString( aStrings.GetString( 1 ) ), + .HelpID:vcl:PrintDialog:IsSuppressEmptyPages:CheckBox, + IsSuppressEmptyPages, + bSuppress); // show Subgroup for print content vcl::PrinterOptionsHelper::UIControlOptions aPrintRangeOpt; aPrintRangeOpt.maGroupHint = PrintRange; @@ -326,9 +326,9 @@ void ScPrintUIOptions::SetDefaults() aPropertyValue.Value = nContent; aUIProp[nPropPos].Value = aPropertyValue; } -else if ( aPropertyValue.Name == IsIncludeEmptyPages ) +else if ( aPropertyValue.Name == IsSuppressEmptyPages ) { -ScUnoHelpFunctions::SetBoolInAny( aPropertyValue.Value, ! bSuppress ); +ScUnoHelpFunctions::SetBoolInAny( aPropertyValue.Value, bSuppress ); aUIProp[nPropPos].Value = aPropertyValue; } } @@ -789,7 +789,7 @@ bool ScModelObj::FillRenderMarkData( const uno::Any aSelection, // defaults when no options are passed: all sheets, include empty pages bool bSelectedSheetsOnly = false; -bool bIncludeEmptyPages = true; +bool bSuppressEmptyPages = true; bool bHasPrintContent = false; sal_Int32 nPrintContent = 0;// all sheets / selected sheets / selected cells @@ -802,9 +802,9 @@ bool ScModelObj::FillRenderMarkData( const uno::Any aSelection, { rOptions[i].Value = bSelectedSheetsOnly; } -else if ( rOptions[i].Name == IsIncludeEmptyPages ) +else if ( rOptions[i].Name == IsSuppressEmptyPages ) { -rOptions[i].Value = bIncludeEmptyPages; +rOptions[i].Value = bSuppressEmptyPages; } else if ( rOptions[i].Name == PageRange ) { @@ -933,7 +933,7 @@ bool ScModelObj::FillRenderMarkData( const uno::Any aSelection, } ScPrintOptions aNewOptions; -aNewOptions.SetSkipEmpty( !bIncludeEmptyPages ); +aNewOptions.SetSkipEmpty( bSuppressEmptyPages ); aNewOptions.SetAllSheets( !bSelectedSheetsOnly ); rStatus.SetOptions( aNewOptions ); diff --git a/sc/uiconfig/scalc/ui/printeroptions.ui b/sc/uiconfig/scalc/ui/printeroptions.ui index 2c9fb56..789293d 100644 --- a/sc/uiconfig/scalc/ui/printeroptions.ui +++ b/sc/uiconfig/scalc/ui/printeroptions.ui @@ -1,6 +1,7 @@ ?xml version=1.0 encoding=UTF-8? +!-- Generated with glade 3.16.1 -- interface - !-- interface-requires gtk+ 3.0 -- + requires lib=gtk+ version=3.0/ object class=GtkBox id=box property name=visibleTrue/property property name=can_focusFalse/property @@ -19,13 +20,12 @@ property name=can_focusFalse/property property name=left_padding12/property child - object
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/collator/gencoll_rule.cxx | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) New commits: commit f899ce3db7d5b9127ca95ad0675d1e5b6147e70b Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 17:54:05 2014 +0200 ICU's RuleBasedCollator::cloneRuleData is deprecated Change-Id: Ifc4a74bca5cfe58e420824a8dd85e8c246bbfac3 diff --git a/i18npool/source/collator/gencoll_rule.cxx b/i18npool/source/collator/gencoll_rule.cxx index 5ba9f5d..8c4abb3 100644 --- a/i18npool/source/collator/gencoll_rule.cxx +++ b/i18npool/source/collator/gencoll_rule.cxx @@ -17,7 +17,9 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include sal/config.h +#include vector #include stdio.h #include string.h #include stdlib.h @@ -28,8 +30,6 @@ #include unicode/tblcoll.h -U_CAPI void U_EXPORT2 uprv_free(void *mem); - using namespace ::rtl; /* Main Procedure */ @@ -117,17 +117,18 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv) RuleBasedCollator *coll = new RuleBasedCollator(reinterpret_castconst UChar *(Obuf.getStr()), status);// UChar != sal_Unicode in MinGW if (U_SUCCESS(status)) { - -int32_t len = 0; -uint8_t *data = coll-cloneRuleData(len, status); - -if (U_SUCCESS(status) data != NULL) -data_write(argv[2], argv[3], data, len); +std::vectoruint8_t data; +int32_t len = coll-cloneBinary(0, 0, status); +if (status == U_BUFFER_OVERFLOW_ERROR) { +data.resize(len); +status = U_ZERO_ERROR; +len = coll-cloneBinary(data.empty() ? 0 : data[0], len, status); +} +if (U_SUCCESS(status)) +data_write(argv[2], argv[3], data.empty() ? 0 : data[0], len); else { printf(Could not get rule data from collator\n); } - -if (data) uprv_free(data); } else { printf(\nRule parsering error\n); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/system.h |2 ++ 1 file changed, 2 insertions(+) New commits: commit b7de76d825b02005ab8cf02b3977e4be441200c5 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 17:55:05 2014 +0200 Mac OS X does provide localtime_r and gmtime_r Change-Id: I1142463972df76aac9e491abbfd08a67cf4db1f1 diff --git a/sal/osl/unx/system.h b/sal/osl/unx/system.h index 3a0babd..33aef24 100644 --- a/sal/osl/unx/system.h +++ b/sal/osl/unx/system.h @@ -402,8 +402,10 @@ struct passwd *getpwent_r(struct passwd *pwd, char *buffer, int buflen); extern struct spwd *getspnam_r(const char *name, struct spwd *result, char *buffer, int buflen); +#if !defined MACOSX struct tm *localtime_r(const time_t *timep, struct tm *buffer); struct tm *gmtime_r(const time_t *timep, struct tm *buffer); +#endif #endif /* !defined FREEBSD || (__FreeBSD_version 500112) */ #if !defined(FREEBSD) || (__FreeBSD_version 601103) struct hostent *gethostbyname_r(const char *name, struct hostent *result, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: GSoC mid-term evaluations NOW
Hi Bjoern, Michael came back from vacation on Tuesday and filed the evaluation, so everything is ok there. Thanks for thinking about us during your holidays thought ;) Regards, -- Cedric On Thu, 2014-06-26 at 16:14 +0200, Bjoern Michaelsen wrote: Hi Cedric, Hi Fridrich, melange is crapping out on me. Neither my bjoern.michael...@gmail.com nor my bjoern.michael...@canonical.com account lets me take any action/evaluation. As mst (co-mentor) is on vacation too and possibly hasnt filed this, please handle this for me. Thanks. Best, Bjoern On Tue, Jun 17, 2014 at 08:06:30AM +0200, Cedric Bosdonnat wrote: The mid-term evaluations are just now! So, head to Google Melange and submit them before Friday. In case you really can't fill the evaluation your self, ask either your co-mentor or one of your beloved admins (Fridrich, Thorsten or myself) to do it. Below are the questions of the form. 1. How many years have you been a mentor for Google Summer of Code (Total - this doesn’t have to be consecutive)? 1. This is my first year 2. 2-3 years 2. 2-3 years 3. More than 3 years 2. If you answered “2-3 years” or “more than 3 years” as a mentor, what years did you participate? 3. How many years have you been a student in Google Summer of Code? 1. I have never been a student 1. I have never been a student 2. 1 year 3. 2 years 4. 3+ years 4. If you answered 2 years or 3+ years, what years did you participate as a student? 5. At what point did you first make contact with your student? 1. Before the program was announced 2. After my organization was selected to participate in Google Summer of Code 3. During the student application/acceptance phase of the program 3. During the student application/acceptance phase of the program 4. During the community bonding period 5. After the start of coding 6. How often do you and your student interact? 1. Daily 2. Every few days 3. Weekly 4. Every few weeks 4. Every few weeks 5. Monthly 6. Less than once a month 7. How do you communicate with your student? (Check all that apply) 1. Google+ Hangout 2. Voice (phone, Skype, etc.) 3. IM/IRC 3. IM/IRC 4. Private emails 5. Mailing Lists 5. Mailing Lists 6. Student blog updates 7. In-person meeting(s) 8. Other 8. Of the communication methods listed above, which do you use most frequently? IRC 9. How much time do you spend on Google Summer of Code per week (take into consideration your interactions with your student as well as time working with your org and on your own)? 1. 1-5 hours 1. 1-5 hours 2. 5-10 hours 3. 10-15 hours 4. 15-20 hours 5. More than 20 hours per week 10. How many time zones apart from your student are you? 1. Less than 3 2. 3-6 3. More than 6 11. How often do you require status updates from your student? 1. Daily 2. Every few days 3. Weekly 3. Weekly 4. Only when explicitly asked for by me 12. Please rate the quality of your interactions and communications with the student (consider his/her communication with you as well as your responses). 1. Very Good (Student is regularly responsive and the quality of communication is high) 1. Very Good (Student is regularly responsive and the
minutes of ESC call ...
* Participants: Stephan, Christian, Adam, Miklos, Michael S., Caolan, Eilidh, Cedric, Andras, Robinson, Astron * Completed Action Items + invite Muthu (Michael) + get Board involved to listen / interact over 'titles' (Astron) * Pending Action Items: + research / seek a saner access2base solution for master (Stephan) + ask UX advise wrt. wrench icons (revert or not ?) (Astron) + scripting to generate / list last week's UI changes (Cloph) + started + review crazy SfxItemPool hash speedup patch (Kendy) + blog about the sad realities of web plugins (Bjoern) + poke potential Boston Hackfest hosters again (Michael) * GSOC Update (Cedric) + mid-term evaluations this week [!]: 23rd-27th June. + all mentors did evaluatins, all going well, Cedric keeping an eye on it * Release Engineering update (Christian) + 4.2.5 retrospective + released last Friday + no update check yet, tbd today (incl. 4.1 - 4.2.5) + 4.3.0 UI and string freeze: + 1 review needed after the tag for rc1 + 4.3.0 RC2 status + deadline next Monday, branch-off next week (2 reviews req. after that) + Android / iOS remote + no pending patches + Late features ? + OpenGL pieces / status + impress work as well ? + pending GL capabilities check to avoid crashes + mostly affects Linux ... + pending various fixes for GLTF rendering. [ starting to be at risk ! ] + experimentalising 3D chart bits. + at risk [ Tamas to look at that ] + Calc performance fixes (?) + Writer performance fix + did see crashes with that on the stack (Stephan) + not sure if that's related + in 4.3 by now * Crashtest update (Markus) + new result based on build from Sunday, June 15th http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26 + summary is available as http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26/exportCrashes.csv http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26/importCrash.csv http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26/validationErrors.csv + memcheck results + thanks to the City Of Largo + http://dev-builds.libreoffice.org/crashtest/memcheck.zip + grep for 'Invalid' or 'conditional jump' + most serious already fixed + machine rebooted itself unhelpfully midway through... (Cloph) * Certification Committee (Stephan/Bjoern/Kendy) + waiting until ~September * writerfilter / XSLT - python (Miklos) + started working on it, code gen via XSLT dubious, done via Python now * AOO merging / regressions (Caolan/Miklos) The 78908 and 79158 are probably both the same problem and are due to the integration of Armin's stuff. I test-merged the remainder of his stuff and it definitely fixes 78908, but then clobbers our character border feature, sigh. I pushed all of that to the http://cgit.freedesktop.org/libreoffice/core/log/?h=feature/aoo-fillattribute branch + Miklos plans to look at branch next week * Hackfests (Bjoern) + Paris Hackfest: + June 27-28th + please add yourself to the wiki: + https://wiki.documentfoundation.org/Hackfest/Paris2014 + 12 people listed so far + Boston Hackfest: + July 26-27th + https://wiki.documentfoundation.org/Events/2014/US_Summer_Hackfest + Tough to line-up mentoring devs + would appreciate developers via Google Hangout etc. + QA is happy to recruit programmers for our internal projects, but would like to share w/the dev team. + poke potential hosters again (Michael) + (possible) Seattle + Oct 25-27 + Straw poll: Who could make these dates? + prolly better to ping people individually (Michael) + Be great to have -really- easy easy hacks for devs (Bjoern) + Toulouse Hackfest ... + Confirmed for Nov. 15-16th + more details: https://wiki.documentfoundation.org/Hackfest/Toulouse2014 * HackFest Box (Kendy) + did we get board approval for that yet ? + no - in the budget extensions, but no ranking yet (Michael) * QA (Robinson) + Unconfirmed count ? + down to 972 + Needadvice + Bibisected regressions still increasing ... + help appreciated. + bug hunting session last weekend starting Friday. + went well + buzilla migration (Norbert) + hoping we can do it in June/July timeline. + channel busier again now * UX Update (Astron) + title resolution ? + team positions in the design team, took discussion to
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-libcmis' - uui/source uui/uiconfig uui/UIConfig_uui.mk
uui/UIConfig_uui.mk |1 + uui/source/authfallbackdlg.cxx | 17 +++-- uui/source/authfallbackdlg.hxx |5 +++-- uui/uiconfig/ui/authfallback.ui |4 +++- 4 files changed, 18 insertions(+), 9 deletions(-) New commits: commit a90e68effaf636405f0f8918c172565b3d96bf4a Author: Mihai Varga mihai.m...@gmail.com Date: Thu Jun 26 20:06:53 2014 +0300 Auth dialog update Change-Id: I0564215566504793546543d0777e6a7c7ca90290 diff --git a/uui/UIConfig_uui.mk b/uui/UIConfig_uui.mk index 076969b..cf81eac 100644 --- a/uui/UIConfig_uui.mk +++ b/uui/UIConfig_uui.mk @@ -10,6 +10,7 @@ $(eval $(call gb_UIConfig_UIConfig,uui)) $(eval $(call gb_UIConfig_add_uifiles,uui,\ + uui/uiconfig/ui/authfallback \ uui/uiconfig/ui/logindialog \ uui/uiconfig/ui/macrowarnmedium \ uui/uiconfig/ui/masterpassworddlg \ diff --git a/uui/source/authfallbackdlg.cxx b/uui/source/authfallbackdlg.cxx index cae7deb..5f1548d 100644 --- a/uui/source/authfallbackdlg.cxx +++ b/uui/source/authfallbackdlg.cxx @@ -10,11 +10,12 @@ #include authfallbackdlg.hxx #include vcl/msgbox.hxx +#include iostream using namespace boost; AuthFallbackDlg::AuthFallbackDlg( Window* pParent ) : -ModalDialog( pParent, AuthFallbackDlg, svt/ui/authfallback.ui ) +ModalDialog( pParent, AuthFallbackDlg, uui/ui/authfallback.ui ) { get( m_pTVInstructions, instructions ); get( m_pEDUrl, url ); @@ -29,7 +30,7 @@ AuthFallbackDlg::AuthFallbackDlg( Window* pParent ) : AuthFallbackDlg::AuthFallbackDlg( Window* pParent, const OUString instructions, const OUString url ) : -ModalDialog( pParent, AuthFallbackDlg, svt/ui/authfallback.ui ) +ModalDialog( pParent, AuthFallbackDlg, uui/ui/authfallback.ui ) { get( m_pTVInstructions, instructions ); get( m_pEDUrl, url ); @@ -38,13 +39,14 @@ AuthFallbackDlg::AuthFallbackDlg( Window* pParent, get( m_pBTCancel, cancel ); m_pBTOk-SetClickHdl( LINK( this, AuthFallbackDlg, OKHdl) ); -m_pBTOk-Enable( false ); +m_pBTCancel-SetClickHdl( LINK( this, AuthFallbackDlg, CancelHdl) ); +m_pBTOk-Enable( true ); m_pTVInstructions-SetText( instructions ); m_pEDUrl-SetText( url ); } -AuthFallbackDlg::~AuthFallbackDlg() +AuthFallbackDlg::~AuthFallbackDlg( ) { } @@ -54,5 +56,8 @@ IMPL_LINK ( AuthFallbackDlg, OKHdl, Button *, EMPTYARG ) return 1; } - - +IMPL_LINK ( AuthFallbackDlg, CancelHdl, Button *, EMPTYARG ) +{ +EndDialog( RET_CANCEL ); +return 0; +} diff --git a/uui/source/authfallbackdlg.hxx b/uui/source/authfallbackdlg.hxx index 818aa84..d068f48 100644 --- a/uui/source/authfallbackdlg.hxx +++ b/uui/source/authfallbackdlg.hxx @@ -23,8 +23,8 @@ private : VclMultiLineEdit* m_pTVInstructions; Edit* m_pEDUrl; Edit* m_pEDCode; -OKButton* m_pBTOk; -CancelButton* m_pBTCancel; +PushButton* m_pBTOk; +PushButton* m_pBTCancel; public : @@ -38,6 +38,7 @@ public : private: DECL_LINK ( OKHdl, Button * ); +DECL_LINK ( CancelHdl, Button * ); }; #endif // INCLUDED_SVTOOLS_AUTHFALLBACKDLG_HXX diff --git a/uui/uiconfig/ui/authfallback.ui b/uui/uiconfig/ui/authfallback.ui index 86a0a81..506197b 100644 --- a/uui/uiconfig/ui/authfallback.ui +++ b/uui/uiconfig/ui/authfallback.ui @@ -1,9 +1,11 @@ ?xml version=1.0 encoding=UTF-8? interface !-- interface-requires gtk+ 3.0 -- - object class=GtkDialog id=AuthenticationDialog + object class=GtkDialog id=AuthFallbackDlg property name=can_focusFalse/property property name=title translatable=yesOneDrive authentication code/property +property name=default_width400/property +property name=default_height270/property child object class=GtkBox id=box property name=visibleTrue/property ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-libcmis' - uui/source
uui/source/iahndl-authentication.cxx | 11 +++ uui/source/iahndl.cxx|9 +++-- uui/source/iahndl.hxx|5 + 3 files changed, 23 insertions(+), 2 deletions(-) New commits: commit b2aa6454f605adf6f79ea8db854c96bb0213aae1 Author: Mihai Varga mihai.m...@gmail.com Date: Thu Jun 26 20:08:28 2014 +0300 AuthDialog request handler - doesn't work well yet Change-Id: Ib6b9cd1969ab06e49d3f57f3f1e85660e97d8ca7 diff --git a/uui/source/iahndl-authentication.cxx b/uui/source/iahndl-authentication.cxx index fbb1dba..d1c2393 100644 --- a/uui/source/iahndl-authentication.cxx +++ b/uui/source/iahndl-authentication.cxx @@ -39,6 +39,7 @@ #include vcl/abstdlg.hxx #include vcl/svapp.hxx +#include authfallbackdlg.hxx #include ids.hrc #include getcontinuations.hxx #include passwordcontainer.hxx @@ -744,4 +745,14 @@ UUIInteractionHelper::handlePasswordRequest( return false; } +bool +UUIInteractionHelper::handleAuthFallbackRequest( +uno::Reference task::XInteractionRequest const rRequest) +{ +Window * pParent = getParentProperty(); +AuthFallbackDlg *dlg = new AuthFallbackDlg(pParent, instructions, url); +dlg-Execute( ); +return true; +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx index de4e70c..6f7f26c 100644 --- a/uui/source/iahndl.cxx +++ b/uui/source/iahndl.cxx @@ -447,6 +447,10 @@ UUIInteractionHelper::handleRequest_impl( uno::Any aAnyRequest(rRequest-getRequest()); +// TODO delete +if ( handleAuthFallbackRequest( rRequest ) ) +return true; + script::ModuleSizeExceededRequest aModSizeException; if (aAnyRequest = aModSizeException ) { @@ -823,12 +827,13 @@ UUIInteractionHelper::handleRequest_impl( return true; } - - // Handle requests which do not have a plain string representation. if (!bObtainErrorStringOnly) { +if ( handleAuthFallbackRequest( rRequest ) ) +return true; + if ( handleAuthenticationRequest( rRequest ) ) return true; diff --git a/uui/source/iahndl.hxx b/uui/source/iahndl.hxx index e87..fad1d23 100644 --- a/uui/source/iahndl.hxx +++ b/uui/source/iahndl.hxx @@ -300,6 +300,11 @@ private: const ::com::sun::star::uno::Reference ::com::sun::star::task::XInteractionRequest i_rRequest, const OUString i_rServiceName ) const; + +bool +handleAuthFallbackRequest( +com::sun::star::uno::Reference +com::sun::star::task::XInteractionRequest const rRequest); }; class ErrorResource: private Resource ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svl sc/qa svl/Library_svl.mk svl/source
include/svl/gridprinter.hxx | 44 +++ sc/qa/unit/helper/debughelper.hxx | 113 -- sc/qa/unit/helper/qahelper.hxx|2 sc/qa/unit/ucalc.cxx |2 svl/Library_svl.mk|1 svl/source/misc/gridprinter.cxx | 141 ++ 6 files changed, 191 insertions(+), 112 deletions(-) New commits: commit f15e440d148ed021091ef9b20f3aed2488f0fde3 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 13:33:09 2014 -0400 Move SheetPrinter to svl and rename it to GridPrinter. I need to use this outside of sc. Change-Id: I153863d6c5c31e5ab5f25da2dba81bd4d4b6d3fe diff --git a/include/svl/gridprinter.hxx b/include/svl/gridprinter.hxx new file mode 100644 index 000..d63adfc --- /dev/null +++ b/include/svl/gridprinter.hxx @@ -0,0 +1,44 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef INCLUDED_SVL_GRIDPRINTER_HXX +#define INCLUDED_SVL_GRIDPRINTER_HXX + +#include rtl/ustring.hxx +#include svl/svldllapi.h + +namespace svl { + +/** + * Print 2-dimensional data in a nice and pleasant fashion. Useful when + * debugging grid layout data. + */ +class SVL_DLLPUBLIC GridPrinter +{ +struct Impl; +Impl* mpImpl; + +public: +GridPrinter( size_t nRows, size_t nCols, bool bPrint = true ); +~GridPrinter(); + +void set( size_t nRow, size_t nCol, const OUString rStr ); + +void print( const char* pHeader ) const; + +void clear(); + +void resize( size_t nRows, size_t nCols ); +}; + +} + +#endif + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sc/qa/unit/helper/debughelper.hxx b/sc/qa/unit/helper/debughelper.hxx index dc6e7bd..509f4af 100644 --- a/sc/qa/unit/helper/debughelper.hxx +++ b/sc/qa/unit/helper/debughelper.hxx @@ -23,10 +23,10 @@ #undef NOMINMAX #endif -#define MDDS_HASH_CONTAINER_BOOST 1 -#include mdds/mixed_type_matrix.hpp - #include iostream +#include vector + +#include svl/gridprinter.hxx #define CALC_DEBUG_OUTPUT 0 #define CALC_TEST_PERF 0 @@ -37,113 +37,6 @@ using ::std::cerr; using ::std::endl; using ::std::vector; -/** - * Print nicely formatted sheet content to stdout. Indispensable when - * debugging the unit test code involving testing of sheet contents. - */ -class SheetPrinter -{ -typedef ::mdds::mixed_type_matrixOUString, bool MatrixType; -public: -SheetPrinter(size_t rows, size_t cols) : -maMatrix(rows, cols, ::mdds::matrix_density_sparse_empty) {} - -void set(size_t row, size_t col, const OUString aStr) -{ -maMatrix.set_string(row, col, new OUString(aStr)); -} - -#if CALC_DEBUG_OUTPUT -void print(const char* header) const -{ -if (header) -cout header endl; - -MatrixType::size_pair_type ns = maMatrix.size(); -vectorsal_Int32 aColWidths(ns.second, 0); - -// Calculate column widths first. -for (size_t row = 0; row ns.first; ++row) -{ -for (size_t col = 0; col ns.second; ++col) -{ -const OUString* p = maMatrix.get_string(row, col); -if (aColWidths[col] p-getLength()) -aColWidths[col] = p-getLength(); -} -} - -// Make the row separator string. -OUStringBuffer aBuf; -aBuf.appendAscii(+); -for (size_t col = 0; col ns.second; ++col) -{ -aBuf.appendAscii(-); -for (sal_Int32 i = 0; i aColWidths[col]; ++i) -aBuf.append(sal_Unicode('-')); -aBuf.appendAscii(-+); -} - -OUString aSep = aBuf.makeStringAndClear(); - -// Now print to stdout. -cout aSep endl; -for (size_t row = 0; row ns.first; ++row) -{ -cout | ; -for (size_t col = 0; col ns.second; ++col) -{ -const OUString* p = maMatrix.get_string(row, col); -size_t nPadding = aColWidths[col] - p-getLength(); -aBuf.append(*p); -for (size_t i = 0; i nPadding; ++i) -aBuf.append(sal_Unicode(' ')); -cout aBuf.makeStringAndClear() | ; -} -cout endl; -cout aSep endl; -} -} -#else -void print(const char*) const {} -#endif - -/** - * Print nested string array which can be copy-n-pasted into the test code - * for content verification. - */ -void printArray() const -{ -#if CALC_DEBUG_OUTPUT -MatrixType::size_pair_type ns = maMatrix.size(); -for (size_t row = 0; row ns.first; ++row) -
[Libreoffice-commits] core.git: svl/source
svl/source/misc/gridprinter.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b2bbd5375ab6ca6ddf4c133d2fdf0b5e38d818b5 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 13:36:15 2014 -0400 Initialize it with empty OUString instances. Since we only store strings the matrix. Change-Id: Ie30e9ce0235810b3082ba13ac17c7d1b3c19375a diff --git a/svl/source/misc/gridprinter.cxx b/svl/source/misc/gridprinter.cxx index c36de35..a472649 100644 --- a/svl/source/misc/gridprinter.cxx +++ b/svl/source/misc/gridprinter.cxx @@ -56,7 +56,7 @@ struct GridPrinter::Impl bool mbPrint; Impl( size_t nRows, size_t nCols, bool bPrint ) : -maMatrix(nRows, nCols), mbPrint(bPrint) {} +maMatrix(nRows, nCols, OUString()), mbPrint(bPrint) {} }; GridPrinter::GridPrinter( size_t nRows, size_t nCols, bool bPrint ) : ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/Library_svl.mk
svl/Library_svl.mk |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 1fabecb123dcc91ebd9d43f3e5c163c7b12b37b0 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 13:50:17 2014 -0400 svl now depends on mdds. Change-Id: Ifd0bde11ad7e72683e1b95106f487e1eb2a4b487 diff --git a/svl/Library_svl.mk b/svl/Library_svl.mk index d00505e..f527701 100644 --- a/svl/Library_svl.mk +++ b/svl/Library_svl.mk @@ -19,7 +19,10 @@ $(eval $(call gb_Library_Library,svl)) -$(eval $(call gb_Library_use_external,svl,boost_headers)) +$(eval $(call gb_Library_use_externals,svl,\ +boost_headers \ +mdds_headers \ +)) $(eval $(call gb_Library_set_componentfile,svl,svl/util/svl)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/inc/InternalData.hxx |4 -- chart2/source/tools/InternalData.cxx | 57 +-- 2 files changed, 36 insertions(+), 25 deletions(-) New commits: commit aa6495b6fa231abfe8b55a806ff6d5a306843cd3 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 14:23:29 2014 -0400 Better way to dump the content of InternalData. Row levels are currently not dumped, but that may change later. Change-Id: I849f8b65d6f419bc4d97e2af2d456e73c7e9a355 diff --git a/chart2/source/inc/InternalData.hxx b/chart2/source/inc/InternalData.hxx index 082f6ee..94b7eee 100644 --- a/chart2/source/inc/InternalData.hxx +++ b/chart2/source/inc/InternalData.hxx @@ -76,9 +76,7 @@ public: void setComplexColumnLabels( const tVecVecAny rNewColumnLabels ); tVecVecAny getComplexColumnLabels() const { return m_aColumnLabels;} -#if OSL_DEBUG_LEVEL 1 -void traceData() const; -#endif +void dump() const; private: //methods /** resizes the data if at least one of the given dimensions is larger than diff --git a/chart2/source/tools/InternalData.cxx b/chart2/source/tools/InternalData.cxx index f79bd62..ac796a9 100644 --- a/chart2/source/tools/InternalData.cxx +++ b/chart2/source/tools/InternalData.cxx @@ -22,6 +22,14 @@ #include Strings.hrc #include rtl/math.hxx +#if OSL_DEBUG_LEVEL 1 +#define DEBUG_INTERNAL_DATA 1 +#endif + +#ifdef DEBUG_INTERNAL_DATA +#include svl/gridprinter.hxx +#endif + #include algorithm #include iterator @@ -223,6 +231,8 @@ void InternalData::setComplexColumnLabel( sal_Int32 nColumnIndex, const vector enlargeData( nColumnIndex+1, 0 ); } m_aColumnLabels[nColumnIndex]=rComplexLabel; + +dump(); } void InternalData::setComplexRowLabel( sal_Int32 nRowIndex, const vector uno::Any rComplexLabel ) @@ -351,9 +361,7 @@ void InternalData::insertColumn( sal_Int32 nAfterIndex ) if( nAfterIndex static_cast sal_Int32 ( m_aColumnLabels.size())) m_aColumnLabels.insert( m_aColumnLabels.begin() + (nAfterIndex + 1), vector uno::Any (1) ); -#if OSL_DEBUG_LEVEL 1 -traceData(); -#endif +dump(); } sal_Int32 InternalData::appendColumn() @@ -403,9 +411,7 @@ void InternalData::insertRow( sal_Int32 nAfterIndex ) if( nAfterIndex static_cast sal_Int32 ( m_aRowLabels.size())) m_aRowLabels.insert( m_aRowLabels.begin() + nIndex, vector uno::Any (1)); -#if OSL_DEBUG_LEVEL 1 -traceData(); -#endif +dump(); } void InternalData::deleteColumn( sal_Int32 nAtIndex ) @@ -439,9 +445,7 @@ void InternalData::deleteColumn( sal_Int32 nAtIndex ) if( nAtIndex static_cast sal_Int32 ( m_aColumnLabels.size())) m_aColumnLabels.erase( m_aColumnLabels.begin() + nAtIndex ); -#if OSL_DEBUG_LEVEL 1 -traceData(); -#endif +dump(); } void InternalData::deleteRow( sal_Int32 nAtIndex ) @@ -479,9 +483,7 @@ void InternalData::deleteRow( sal_Int32 nAtIndex ) if( nAtIndex static_cast sal_Int32 ( m_aRowLabels.size())) m_aRowLabels.erase( m_aRowLabels.begin() + nAtIndex ); -#if OSL_DEBUG_LEVEL 1 -traceData(); -#endif +dump(); } @@ -507,21 +509,32 @@ void InternalData::setComplexColumnLabels( const vector vector uno::Any r enlargeData( nNewColumnCount, 0 ); } - -#if OSL_DEBUG_LEVEL 1 -void InternalData::traceData() const +#ifdef DEBUG_INTERNAL_DATA +void InternalData::dump() const { -OSL_TRACE( InternalData: Data in rows ); +// Header +svl::GridPrinter aPrinter(1, m_nColumnCount, true); +for (sal_Int32 nCol = 0; nCol m_nColumnCount; ++nCol) +{ +OUString aStr; +if (m_aColumnLabels[nCol][0] = aStr) +aPrinter.set(0, nCol, aStr); +} +aPrinter.print(Header); -for( sal_Int32 i=0; im_nRowCount; ++i ) +aPrinter.resize(m_nRowCount, m_nColumnCount); + +for (sal_Int32 nRow = 0; nRow m_nRowCount; ++nRow) { -tDataType aSlice( m_aData[ ::std::slice( i*m_nColumnCount, m_nColumnCount, 1 ) ] ); -for( sal_Int32 j=0; jm_nColumnCount; ++j ) -OSL_TRACE( %lf , aSlice[j] ); -OSL_TRACE( \n ); +tDataType aSlice( m_aData[ ::std::slice( nRow*m_nColumnCount, m_nColumnCount, 1 ) ] ); +for (sal_Int32 nCol = 0; nCol m_nColumnCount; ++nCol) +aPrinter.set(nRow, nCol, OUString::number(aSlice[nCol])); } -OSL_TRACE( \n ); + +aPrinter.print(Column data); } +#else +void InternalData::dump() const {} #endif } // namespace chart ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'private/jmux/mailmerge-fixes'
New branch 'private/jmux/mailmerge-fixes' available with the following commits: commit a6419672dadd6777bd7f1ecddaf05abc0440eea0 Author: Jan-Marek Glogowski glo...@fbihome.de Date: Thu Jun 26 20:23:39 2014 +0200 Merge SwDoc::Paste into SwDoc::CreateCopy Change-Id: I95686eb116e17b4da6662b4fbadcf08a0b92a6f4 commit d555236a488e41e0170c702b1167c0c461fdb046 Author: Jan-Marek Glogowski glo...@fbihome.de Date: Thu Jun 26 13:19:56 2014 +0200 Fixup Change-Id: I026f0e5122e58d948f20a05fe9143a0bfdf65810 commit 34456eb7095747e3f585bb6fc49beabce6a229af Author: Jan-Marek Glogowski glo...@fbihome.de Date: Mon Jun 23 09:10:22 2014 +0200 Update SwDoc::Paste from SwFEShell::Paste SwDoc::Paste is already an minimal version of SwFEShell::Paste. Update the code based on the changes made in commit 4580094d2d9d5b952c4526ee23204f75a5bb2f1b Change-Id: I4d784f393952374e2a174510f9378b05cfdb78eb commit d6ad1bc970e1fffe046990a3668a9e2fc9c63959 Author: Jan-Marek Glogowski glo...@fbihome.de Date: Mon Jun 23 09:27:27 2014 +0200 MM: always copy the internal document There is really no need to create the first document via UNO createClone(), which is also slower then the internal copy. Actually createClone also calls createCopy, but without initializing the document. Change-Id: I23437b0f3ad663942a02be575b39883f9a3b8587 commit e56db6cb805834cd28cc7dab68c4db6739afa9b6 Author: Jan-Marek Glogowski glo...@fbihome.de Date: Mon Jun 23 09:16:18 2014 +0200 Replace the whole content for copied documents If the document is initialized in CreateCopy, it already contains the initial empty paragraph. So we have to delete the content from initial document, as we're going to replace the whole content with the pasted document. Change-Id: I33faed4de77919fb926d408e19af9c1ec3b0f7d3 commit 7e0d22008eb94d8474cf521197542819fe93fc77 Author: Jan-Marek Glogowski glo...@fbihome.de Date: Fri Jun 13 14:44:37 2014 +0200 Revert fdo#66145: do not check IsFirstShared() in SwPageDesc::GetLeftFmt() This reverts commit 4df438c9a9d5e698c47c1e85903eb81880a5e6fa. Conflicts: sw/source/core/layout/pagedesc.cxx Change-Id: I8f8d32c07f8706fad6c62fba2a9a373feed6cbed commit 0dae9bf70891a0e817ceb6ad783a3829a8bf8e23 Author: Jan-Marek Glogowski glo...@fbihome.de Date: Mon Jun 23 08:43:08 2014 +0200 Save debug mail merge documents This saves the first three mail merge documents, the source and the corresponding working documents. For convenience all saved document URIs printed to the console. Change-Id: Ice86bf59fc519cfab170ff0956559dc9373d5a26 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Pasting in Writer or how to create a SwDoc deep copy?
Hi Miklos, Am 26.06.2014 10:54, schrieb Miklos Vajna: On Wed, Jun 25, 2014 at 01:09:01PM +0200, Jan-Marek Glogowski glo...@fbihome.de wrote: My best idea is to use SwNodeIndex aSourceIdx( rSource.GetNodes().GetEndOfExtras(), *1* ); Are you sure such an explicit offset is required here? I'm thinking about special situations like when the document starts with a table, if you want to paste that into a new document, you probably want to have the selection start at the first content node of the document, so no static offset will work here. I'm thinking about something like: SwNodeIndex aNodeIndex rSource.GetNodes().GetEndOfAutotext(); SwCntntNode* pStart = rSource.GetNodes().GoNext(aNodeIndex); Any kind of explicit offset sounds a bit scary to me. Well the current code uses the explicit offset 2 in SwDoc::Paste and SwFEShell::Paste, which ignores the first content node, which results in losing the paragraph anchored Flys of the first paragraph of the document. For a whole document paste, I want the whole document, including the first node with the pagedesc. This is probably special case for Mail Merge. I added a boolean to SwFEShell::Paste, so this really pastes the whole document. The only user of SwDoc::Paste is SwDoc::CreateCopy. I've merged the SwDoc::Paste code into SwDoc::CreateCopy. SwDoc::Paste used the fixed offset of 2 for the source document content offset - same for the target insert. SwPaM aPara( document content start ); this-DelFullPara(aPara); But you're not really trying to delete the paragraph content, just join the two, right? SwDoc::DeleteAndJoin() might be useful to do that. No - I really tried to get rid of the whole page. I pushed my current works for me changeset to private/jmux/mailmerge-fixes. Would be happy, if I can get a review. Thanks Jan-Marek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - basic/source comphelper/source dbaccess/source filter/source forms/source framework/source scripting/source sd/source svx/source ucb/source u
basic/source/basmgr/basicmanagerrepository.cxx|3 - basic/source/uno/dlgcont.cxx |2 basic/source/uno/namecont.cxx | 10 ++-- comphelper/source/processfactory/processfactory.cxx |4 - dbaccess/source/core/dataaccess/connection.cxx|2 filter/source/svg/svgexport.cxx |6 +- filter/source/svg/svgwriter.cxx | 10 ++-- forms/source/misc/InterfaceContainer.cxx |2 framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx | 23 ++ framework/source/uiconfiguration/uiconfigurationmanager.cxx | 17 --- framework/source/uifactory/menubarfactory.cxx |2 framework/source/uifactory/uielementfactorymanager.cxx|2 scripting/source/dlgprov/dlgprov.cxx |4 - scripting/source/stringresource/stringresource.cxx|4 - sd/source/core/sdpage2.cxx|4 - sd/source/ui/view/ViewShellBase.cxx |2 svx/source/form/fmobj.cxx |2 svx/source/form/fmshimp.cxx |4 - svx/source/form/fmtools.cxx |2 svx/source/form/fmundo.cxx|4 - svx/source/form/fmvwimp.cxx |2 svx/source/form/formcontroller.cxx|6 +- svx/source/form/navigatortree.cxx |2 ucb/source/ucp/file/bc.cxx|2 ucb/source/ucp/file/filglob.cxx |8 +-- ucb/source/ucp/ftp/ftpcontent.cxx |2 unotools/source/config/configitem.cxx |2 xmloff/source/text/txtparai.cxx |2 28 files changed, 73 insertions(+), 62 deletions(-) New commits: commit 1249dd9f358681f61c8ec69a90ce61829601fd0b Author: Noel Grandin n...@peralex.com Date: Wed Jun 25 08:43:20 2014 +0200 fixes for up-casting to ReferenceXInterface Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 Use the new type-checking Reference constructor to reduce code noise Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann sberg...@redhat.com (cherry picked from commit 533c6cb6bad6ef0432e8eebbfd4daf90ef71f3b4) Reviewed-on: https://gerrit.libreoffice.org/9919 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/basic/source/basmgr/basicmanagerrepository.cxx b/basic/source/basmgr/basicmanagerrepository.cxx index f062de0..45cb468 100644 --- a/basic/source/basmgr/basicmanagerrepository.cxx +++ b/basic/source/basmgr/basicmanagerrepository.cxx @@ -381,9 +381,10 @@ namespace basic BasicManagerPointer ImplRepository::impl_getLocationForModel( const Reference XModel _rxDocumentModel ) { +Reference XInterface xNormalized( _rxDocumentModel, UNO_QUERY ); DBG_ASSERT( _rxDocumentModel.is(), ImplRepository::impl_getLocationForModel: invalid model! ); -BasicManagerPointer location = m_aStore[ _rxDocumentModel ]; +BasicManagerPointer location = m_aStore[ xNormalized ]; return location; } diff --git a/basic/source/uno/dlgcont.cxx b/basic/source/uno/dlgcont.cxx index a759eea..a90baec 100644 --- a/basic/source/uno/dlgcont.cxx +++ b/basic/source/uno/dlgcont.cxx @@ -241,7 +241,7 @@ void SfxDialogLibraryContainer::storeLibrariesToStorage( const uno::Reference e UNO_QUERY ); ::xmlscript::importDialogModel( xInput, xDialogModel, mxContext, mxOwnerDocument ); std::vector OUString vEmbeddedImageURLs; -GraphicObject::InspectForGraphicObjectImageURL( xDialogModel, vEmbeddedImageURLs ); +GraphicObject::InspectForGraphicObjectImageURL( ReferenceXInterface(xDialogModel, UNO_QUERY), vEmbeddedImageURLs ); if ( !vEmbeddedImageURLs.empty() ) { // Export the images to the storage diff --git a/basic/source/uno/namecont.cxx b/basic/source/uno/namecont.cxx index 52d3494f..854f437 100644 --- a/basic/source/uno/namecont.cxx +++ b/basic/source/uno/namecont.cxx @@ -297,7 +297,7 @@ void SAL_CALL NameContainer::addContainerListener( const Reference XContainerLi throw RuntimeException(addContainerListener called with null xListener, static_cast cppu::OWeakObject * (this)); } -maContainerListeners.addInterface(
[Libreoffice-commits] core.git: rsc/source
rsc/source/prj/start.cxx | 15 ++- rsc/source/rsc/rsc.cxx | 15 ++- rsc/source/rscpp/cpp3.c | 14 +- 3 files changed, 41 insertions(+), 3 deletions(-) New commits: commit 7c5a21dd4142c414de4e5925533e8cfbb6f329b0 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 22:32:13 2014 +0200 rsc: ignore -isystem args Change-Id: Ic46b84d740159826542ead857d15230d54547d88 diff --git a/rsc/source/prj/start.cxx b/rsc/source/prj/start.cxx index 46c62a7..7c7cc32 100644 --- a/rsc/source/prj/start.cxx +++ b/rsc/source/prj/start.cxx @@ -235,7 +235,20 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv) bool bSetSrs = false; while( ppStr i (aCmdLine.GetCount() -1) ) { -if( '-' == **ppStr ) +if (strcmp(*ppStr, -isystem) == 0) +{ +// ignore -isystem and following arg +if (i aCmdLine.GetCount() - 1) +{ +++ppStr; +++i; +} +} +else if (strncmp(*ppStr, -isystem, strlen(-isystem)) == 0) +{ +// ignore args starting with -isystem +} +else if( '-' == **ppStr ) { if( !rsc_stricmp( (*ppStr) + 1, p ) || !rsc_stricmp( (*ppStr) + 1, l ) ) diff --git a/rsc/source/rsc/rsc.cxx b/rsc/source/rsc/rsc.cxx index 0fac410..e5a7228 100644 --- a/rsc/source/rsc/rsc.cxx +++ b/rsc/source/rsc/rsc.cxx @@ -100,7 +100,20 @@ RscCmdLine::RscCmdLine( int argc, char ** argv, RscError * pEH ) #if OSL_DEBUG_LEVEL 1 fprintf( stderr, CmdLineArg: \%s\\n, *ppStr ); #endif -if( '-' == **ppStr ) +if (strcmp(*ppStr, -isystem) == 0) +{ +// ignore -isystem and following arg +if (i aCmdLine.GetCount() - 1) +{ +++ppStr; +++i; +} +} +else if (strncmp(*ppStr, -isystem, strlen(-isystem)) == 0) +{ +// ignore args starting with -isystem +} +else if( '-' == **ppStr ) { if( !rsc_stricmp( (*ppStr) + 1, h ) || !strcmp( (*ppStr) + 1, ? ) ) diff --git a/rsc/source/rscpp/cpp3.c b/rsc/source/rscpp/cpp3.c index 287b2a5..02361649 100644 --- a/rsc/source/rscpp/cpp3.c +++ b/rsc/source/rscpp/cpp3.c @@ -217,7 +217,19 @@ dooptions(int argc, char** argv) for (i = j = 1; i argc; i++) { arg = ap = argv[i]; -if (*ap++ != '-' || *ap == EOS) +if (strcmp(arg, -isystem) == 0) +{ +// ignore -isystem and following arg +if (i argc) +{ +++i; +} +} +else if (strncmp(arg, -isystem, strlen(-isystem)) == 0) +{ +// ignore args starting with -isystem +} +else if (*ap++ != '-' || *ap == EOS) { argv[j++] = argv[i]; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: idl/source
idl/source/prj/command.cxx | 12 1 file changed, 12 insertions(+) New commits: commit 977c50178f804dad2817bca98cb9b26affd5bf9a Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 22:49:40 2014 +0200 idl: ignore -isystem args Change-Id: I0758fd3117795ed68789385576aee5a885639104 diff --git a/idl/source/prj/command.cxx b/idl/source/prj/command.cxx index 896ed4d6..9eceab1 100644 --- a/idl/source/prj/command.cxx +++ b/idl/source/prj/command.cxx @@ -316,6 +316,18 @@ SvCommand::SvCommand( int argc, char ** argv ) while(SyntaxStrings[j]) printf(%s\n,SyntaxStrings[j++]); } +else if (aParam == isystem) +{ +// ignore -isystem and following arg +if (i aList.size()) +{ +++i; +} +} +else if (aParam.startsWith(isystem)) +{ +// ignore args starting with -isystem +} else if( aParam.startsWithIgnoreAsciiCase( i ) ) { // define include paths OUString aName( aParam.copy( 1 ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/shutdowniconaqua.mm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4cda79cec3fe54b6859ec8ca550f4453ace7fcb2 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Jun 26 22:57:11 2014 +0200 loplugin:staticcall Change-Id: Idea97df52106af64f6c5605460756d48296551e2 diff --git a/sfx2/source/appl/shutdowniconaqua.mm b/sfx2/source/appl/shutdowniconaqua.mm index 7218061..24458ad 100644 --- a/sfx2/source/appl/shutdowniconaqua.mm +++ b/sfx2/source/appl/shutdowniconaqua.mm @@ -399,7 +399,7 @@ void aqua_init_systray() // disable shutdown pShutdownIcon-SetVeto( true ); -pShutdownIcon-addTerminateListener(); +ShutdownIcon::addTerminateListener(); if( ! pDefMenu ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/tools/InternalData.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 95272e7e5b7e38753ab07dbd6503b7cfa2974842 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 18:57:09 2014 -0400 Prevent a crash while dumping internal data content. Change-Id: I0938b955b460d8c91607e6df0b9d9e1a4a971013 diff --git a/chart2/source/tools/InternalData.cxx b/chart2/source/tools/InternalData.cxx index ac796a9..72ce315 100644 --- a/chart2/source/tools/InternalData.cxx +++ b/chart2/source/tools/InternalData.cxx @@ -516,6 +516,9 @@ void InternalData::dump() const svl::GridPrinter aPrinter(1, m_nColumnCount, true); for (sal_Int32 nCol = 0; nCol m_nColumnCount; ++nCol) { +if (m_aColumnLabels[nCol].empty()) +continue; + OUString aStr; if (m_aColumnLabels[nCol][0] = aStr) aPrinter.set(0, nCol, aStr); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/CppunitTest_chart2_export.mk chart2/CppunitTest_chart2_import.mk chart2/inc chart2/qa chart2/source
chart2/CppunitTest_chart2_export.mk |1 chart2/CppunitTest_chart2_import.mk |1 chart2/inc/unonames.hxx |2 chart2/qa/extras/chart2export.cxx |6 +- chart2/qa/extras/chart2import.cxx |8 +-- chart2/qa/extras/charttest.hxx |2 chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx | 25 +- chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx |5 +- chart2/source/controller/main/ObjectHierarchy.cxx |5 +- chart2/source/model/main/DataPointProperties.cxx|4 - chart2/source/tools/DataSourceHelper.cxx|5 +- chart2/source/tools/ObjectIdentifier.cxx|6 +- chart2/source/tools/StatisticsHelper.cxx|5 +- chart2/source/view/main/VDataSeries.cxx |4 - 14 files changed, 46 insertions(+), 33 deletions(-) New commits: commit c6da1842956ceced501858d582f7dcaded0a324a Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 19:35:48 2014 -0400 Track all uses of ErrorBarX and ErrorBarY UNO property names. Change-Id: I994424c98d977c3a8f913817348de813a9d7 diff --git a/chart2/CppunitTest_chart2_export.mk b/chart2/CppunitTest_chart2_export.mk index c6bf682..3b941a9 100644 --- a/chart2/CppunitTest_chart2_export.mk +++ b/chart2/CppunitTest_chart2_export.mk @@ -60,6 +60,7 @@ $(eval $(call gb_CppunitTest_use_libraries,chart2_export, \ )) $(eval $(call gb_CppunitTest_set_include,chart2_export,\ +-I$(SRCDIR)/chart2/inc \ $$(INCLUDE) \ )) diff --git a/chart2/CppunitTest_chart2_import.mk b/chart2/CppunitTest_chart2_import.mk index 55ac39d..f925e58 100644 --- a/chart2/CppunitTest_chart2_import.mk +++ b/chart2/CppunitTest_chart2_import.mk @@ -59,6 +59,7 @@ $(eval $(call gb_CppunitTest_use_libraries,chart2_import, \ )) $(eval $(call gb_CppunitTest_set_include,chart2_import,\ +-I$(SRCDIR)/chart2/inc \ $$(INCLUDE) \ )) diff --git a/chart2/inc/unonames.hxx b/chart2/inc/unonames.hxx index 2b5f601..4975ed4 100644 --- a/chart2/inc/unonames.hxx +++ b/chart2/inc/unonames.hxx @@ -19,6 +19,8 @@ #define CHART_UNONAME_CURVE_RESOLUTION CurveResolution #define CHART_UNONAME_NUMFMTNumberFormat #define CHART_UNONAME_LINK_TO_SRC_NUMFMTLinkNumberFormatToSource +#define CHART_UNONAME_ERRORBAR_XErrorBarX +#define CHART_UNONAME_ERRORBAR_YErrorBarY #endif diff --git a/chart2/qa/extras/chart2export.cxx b/chart2/qa/extras/chart2export.cxx index 80aab30..7ef8dc7 100644 --- a/chart2/qa/extras/chart2export.cxx +++ b/chart2/qa/extras/chart2export.cxx @@ -436,7 +436,7 @@ void Chart2ExportTest::testErrorBarXLSX() // test that y error bars are there Reference beans::XPropertySet xErrorBarYProps; -xPropSet-getPropertyValue(ErrorBarY) = xErrorBarYProps; +xPropSet-getPropertyValue(CHART_UNONAME_ERRORBAR_Y) = xErrorBarYProps; testErrorBar(xErrorBarYProps); } @@ -453,7 +453,7 @@ void Chart2ExportTest::testErrorBarXLSX() // test that y error bars are there Reference beans::XPropertySet xErrorBarYProps; -xPropSet-getPropertyValue(ErrorBarY) = xErrorBarYProps; +xPropSet-getPropertyValue(CHART_UNONAME_ERRORBAR_Y) = xErrorBarYProps; testErrorBar(xErrorBarYProps); } } @@ -832,7 +832,7 @@ void Chart2ExportTest::testErrorBarDataRangeODS() // test that y error bars are there Reference beans::XPropertySet xErrorBarYProps; -xPropSet-getPropertyValue(ErrorBarY) = xErrorBarYProps; +xPropSet-getPropertyValue(CHART_UNONAME_ERRORBAR_Y) = xErrorBarYProps; uno::Any aAny = xErrorBarYProps-getPropertyValue(ErrorBarRangePositive); CPPUNIT_ASSERT(aAny.hasValue()); OUString aPosRange; diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx index d5a42a1..1f31cad 100644 --- a/chart2/qa/extras/chart2import.cxx +++ b/chart2/qa/extras/chart2import.cxx @@ -89,7 +89,7 @@ void Chart2ImportTest::Fdo60083() // test that y error bars are there Reference beans::XPropertySet xErrorBarYProps; -xPropSet-getPropertyValue(ErrorBarY) = xErrorBarYProps; +xPropSet-getPropertyValue(CHART_UNONAME_ERRORBAR_Y) = xErrorBarYProps; CPPUNIT_ASSERT(xErrorBarYProps.is()); { sal_Int32 nErrorBarStyle; @@ -121,7 +121,7 @@ void Chart2ImportTest::Fdo60083() // test that x error bars are not imported Reference beans::XPropertySet xErrorBarXProps; -xPropSet-getPropertyValue(ErrorBarX) = xErrorBarXProps; +xPropSet-getPropertyValue(CHART_UNONAME_ERRORBAR_X) =
[Libreoffice-commits] core.git: chart2/source
chart2/source/tools/InternalData.cxx | 36 ++- 1 file changed, 27 insertions(+), 9 deletions(-) New commits: commit 822d0e9db610ce3cbee2cf8d3154ee41218ea562 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 22:31:20 2014 -0400 Use new GridPrinter instance for each table. resize() sometimes leads to a crash. Need to debug later. Change-Id: Ia3809eb4f171369a58b84d5b44001692be1453a1 diff --git a/chart2/source/tools/InternalData.cxx b/chart2/source/tools/InternalData.cxx index 72ce315..5265602 100644 --- a/chart2/source/tools/InternalData.cxx +++ b/chart2/source/tools/InternalData.cxx @@ -513,19 +513,37 @@ void InternalData::setComplexColumnLabels( const vector vector uno::Any r void InternalData::dump() const { // Header -svl::GridPrinter aPrinter(1, m_nColumnCount, true); -for (sal_Int32 nCol = 0; nCol m_nColumnCount; ++nCol) +if (!m_aColumnLabels.empty()) { -if (m_aColumnLabels[nCol].empty()) -continue; +svl::GridPrinter aPrinter(1, m_aColumnLabels.size(), true); +for (size_t nCol = 0; nCol m_aColumnLabels.size(); ++nCol) +{ +if (m_aColumnLabels[nCol].empty()) +continue; + +OUString aStr; +if (m_aColumnLabels[nCol][0] = aStr) +aPrinter.set(0, nCol, aStr); +} +aPrinter.print(Header); +} -OUString aStr; -if (m_aColumnLabels[nCol][0] = aStr) -aPrinter.set(0, nCol, aStr); +if (!m_aRowLabels.empty()) +{ +svl::GridPrinter aPrinter(m_aRowLabels.size(), m_aRowLabels[0].size()); +for (size_t nRow = 0; nRow m_aRowLabels.size(); ++nRow) +{ +for (size_t nCol = 0; nCol m_aRowLabels[nRow].size(); ++nCol) +{ +OUString aStr; +if (m_aRowLabels[nRow].at(nCol) = aStr) +aPrinter.set(nRow, nCol, aStr); +} +} +aPrinter.print(Row labels); } -aPrinter.print(Header); -aPrinter.resize(m_nRowCount, m_nColumnCount); +svl::GridPrinter aPrinter(m_nRowCount, m_nColumnCount); for (sal_Int32 nRow = 0; nRow m_nRowCount; ++nRow) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/dialogs/DataBrowserModel.cxx |5 - 1 file changed, 5 deletions(-) New commits: commit ecde8155fefcdacb08177a10a4eddc24f6675b0b Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 14:51:47 2014 -0400 fdo#79151: No need to offset column index by category labels. In fact, doing so would lead to a corrupt internal data table. The internal data stores category labels separately from the column data, so there is no reason why we need to offset for category labels here. Change-Id: I29dd99e53837cba7a1e28d2a1ef39a5384378805 diff --git a/chart2/source/controller/dialogs/DataBrowserModel.cxx b/chart2/source/controller/dialogs/DataBrowserModel.cxx index e2bff5b..16ac3a2 100644 --- a/chart2/source/controller/dialogs/DataBrowserModel.cxx +++ b/chart2/source/controller/dialogs/DataBrowserModel.cxx @@ -343,10 +343,6 @@ void DataBrowserModel::insertDataSeries( sal_Int32 nAfterColumnIndex ) if (!xChartType.is()) return; -sal_Int32 nOffset = 0; -if( xDiagram.is() lcl_ShowCategories( xDiagram )) -nOffset = getCategoryColumnCount(); - // Get shared sequences of current series. Normally multiple data series // only share values-x sequences. (TODO: simplify this logic). Reference chart2::XDataSeriesContainer xSeriesCnt( xChartType, uno::UNO_QUERY ); @@ -367,7 +363,6 @@ void DataBrowserModel::insertDataSeries( sal_Int32 nAfterColumnIndex ) SequenceReferencechart2::data::XLabeledDataSequence aLSequences = xSource-getDataSequences(); sal_Int32 nSeqIdx = 0; sal_Int32 nSeqSize = aLSequences.getLength(); -nStartCol -= (nOffset - 1); // ??? for (sal_Int32 nIndex = nStartCol; nSeqIdx nSeqSize; ++nSeqIdx) { lcl_tSharedSeqVec::const_iterator aSharedIt( ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/refhint.hxx | 14 +++--- sc/source/core/tool/refhint.cxx | 35 +++ 2 files changed, 42 insertions(+), 7 deletions(-) New commits: commit 3c6e378fd81b2bfd8a35e12557a90fa40428920e Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Thu Jun 26 23:25:21 2014 -0400 Make these non inline. Don't do this please... Change-Id: Id90490622bca10beabf7a1c92e51e55bc72a1db8 diff --git a/sc/inc/refhint.hxx b/sc/inc/refhint.hxx index f8a6df7..1f92731 100644 --- a/sc/inc/refhint.hxx +++ b/sc/inc/refhint.hxx @@ -31,7 +31,7 @@ protected: public: virtual ~RefHint() = 0; -Type getType() const { return meType; } +Type getType() const; }; class RefMovedHint : public RefHint @@ -47,12 +47,12 @@ public: /** * Get the source range from which the references have moved. */ -const ScRange getRange() const { return maRange;} +const ScRange getRange() const; /** * Get the movement vector. */ -const ScAddress getDelta() const { return maMoveDelta;} +const ScAddress getDelta() const; }; class RefColReorderHint : public RefHint @@ -66,11 +66,11 @@ public: RefColReorderHint( const sc::ColReorderMapType rColMap, SCTAB nTab, SCROW nRow1, SCROW nRow2 ); virtual ~RefColReorderHint(); -const sc::ColReorderMapType getColMap() const { return mrColMap;} +const sc::ColReorderMapType getColMap() const; -SCTAB getTab() const { return mnTab;} -SCROW getStartRow() const { return mnRow1;} -SCROW getEndRow() const { return mnRow2;} +SCTAB getTab() const; +SCROW getStartRow() const; +SCROW getEndRow() const; }; } diff --git a/sc/source/core/tool/refhint.cxx b/sc/source/core/tool/refhint.cxx index 25dc699..80aef93 100644 --- a/sc/source/core/tool/refhint.cxx +++ b/sc/source/core/tool/refhint.cxx @@ -14,16 +14,51 @@ namespace sc { RefHint::RefHint( Type eType ) : SfxSimpleHint(SC_HINT_REFERENCE), meType(eType) {} RefHint::~RefHint() {} +RefHint::Type RefHint::getType() const +{ +return meType; +} + RefMovedHint::RefMovedHint( const ScRange rRange, const ScAddress rMove ) : RefHint(Moved), maRange(rRange), maMoveDelta(rMove) {} RefMovedHint::~RefMovedHint() {} +const ScRange RefMovedHint::getRange() const +{ +return maRange; +} + +const ScAddress RefMovedHint::getDelta() const +{ +return maMoveDelta; +} + RefColReorderHint::RefColReorderHint( const sc::ColReorderMapType rColMap, SCTAB nTab, SCROW nRow1, SCROW nRow2 ) : RefHint(ColumnReordered), mrColMap(rColMap), mnTab(nTab), mnRow1(nRow1), mnRow2(nRow2) {} RefColReorderHint::~RefColReorderHint() {} +const sc::ColReorderMapType RefColReorderHint::getColMap() const +{ +return mrColMap; +} + +SCTAB RefColReorderHint::getTab() const +{ +return mnTab; +} + +SCROW RefColReorderHint::getStartRow() const +{ +return mnRow1; +} + +SCROW RefColReorderHint::getEndRow() const +{ +return mnRow2; +} + } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang extensions/source sal/qa sc/source toolkit/source
compilerplugins/clang/unreffun.cxx | 23 +--- extensions/source/propctrlr/xsddatatypes.cxx | 37 -- sal/qa/rtl/oustring/rtl_OUString2.cxx| 71 --- sc/source/core/data/dociter.cxx | 16 -- sc/source/core/tool/compiler.cxx | 15 - sc/source/core/tool/rangelst.cxx | 24 - sc/source/core/tool/refupdat.cxx | 57 - sc/source/filter/oox/condformatbuffer.cxx|8 --- toolkit/source/controls/unocontrolmodel.cxx | 13 9 files changed, 14 insertions(+), 250 deletions(-) New commits: commit 9a741fcad458875a806295ddbd41b68d82ce9095 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jun 27 07:51:25 2014 +0200 loplugin:unreffun: also warn about unused function templates Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1 diff --git a/compilerplugins/clang/unreffun.cxx b/compilerplugins/clang/unreffun.cxx index eece97f..8c726e3 100644 --- a/compilerplugins/clang/unreffun.cxx +++ b/compilerplugins/clang/unreffun.cxx @@ -60,12 +60,12 @@ bool UnrefFun::VisitFunctionDecl(FunctionDecl const * decl) { return true; } -//TODO, filtering out anything template for now: -if (decl-isDependentContext()) { -return true; -} +//TODO, filtering out any functions relating to (class) templates for now: CXXRecordDecl const * r = dyn_castCXXRecordDecl(decl-getDeclContext());; -if (r != nullptr r-getTemplateSpecializationKind() != TSK_Undeclared) { +if (r != nullptr + (r-getTemplateSpecializationKind() != TSK_Undeclared +|| r-isDependentContext())) +{ return true; } @@ -81,6 +81,9 @@ bool UnrefFun::VisitFunctionDecl(FunctionDecl const * decl) { compiler.getSourceManager().getSpellingLoc( canon-getNameInfo().getLoc())) || canon-isMain() +|| (decl-getTemplatedKind() == FunctionDecl::TK_FunctionTemplate + (decl-getDescribedFunctionTemplate()-spec_begin() +!= decl-getDescribedFunctionTemplate()-spec_end())) || (compiler.getDiagnostics().getDiagnosticLevel( diag::warn_unused_function, decl-getLocation()) DiagnosticsEngine::Warning)) @@ -102,13 +105,15 @@ bool UnrefFun::VisitFunctionDecl(FunctionDecl const * decl) { (canon-isDefined() #if (__clang_major__ == 3 __clang_minor__ = 4) || __clang_major__ 3 ? (canon-isExternallyVisible() -? Unreferenced externally visible function definition -: Unreferenced externally invisible function definition) +? Unreferenced externally visible function%0 definition +: Unreferenced externally invisible function%0 definition) #else - ? Unreferenced function definition + ? Unreferenced function%0 definition #endif - : Unreferenced function declaration), + : Unreferenced function%0 declaration), decl-getLocation()) + (decl-getTemplatedKind() == FunctionDecl::TK_FunctionTemplate +? template : ) decl-getSourceRange(); if (canon-isDefined() !compat::isFirstDecl(*decl)) { report( diff --git a/extensions/source/propctrlr/xsddatatypes.cxx b/extensions/source/propctrlr/xsddatatypes.cxx index 2abf09f..27c6027 100644 --- a/extensions/source/propctrlr/xsddatatypes.cxx +++ b/extensions/source/propctrlr/xsddatatypes.cxx @@ -34,24 +34,6 @@ namespace pcr using namespace ::com::sun::star::xsd; using namespace ::com::sun::star::beans; - -//= helper - - -template typename INTERFACE, typename ARGUMENT -void setSave( INTERFACE* pObject, void ( SAL_CALL INTERFACE::*pSetter )( ARGUMENT ), ARGUMENT _rArg ) -{ -try -{ -(pObject-*pSetter)( _rArg ); -} -catch( const Exception ) -{ -OSL_FAIL( XSDDataType: setSave: caught an exception! ); -} -} - - template typename INTERFACE, typename ARGUMENT ARGUMENT getSave( INTERFACE* pObject, ARGUMENT ( SAL_CALL INTERFACE::*pGetter )( ) ) { @@ -67,25 +49,6 @@ namespace pcr return aReturn; } -template typename FACETTYPE -FACETTYPE getFacet( const Reference XPropertySet _rxFacets, const OUString _rFacetName ) -{ -FACETTYPE aReturn; -try -{ -OSL_VERIFY( _rxFacets-getPropertyValue( _rFacetName ) = aReturn ); -} -catch( const Exception ) -{ -OSL_FAIL( XSDDataType: getFacet: caught an exception! ); -} -return aReturn; -} - - -//= XSDDataType - - XSDDataType::XSDDataType( const Reference XDataType _rxDataType ) :m_xDataType( _rxDataType ) ,m_refCount( 0 ) diff --git a/sal/qa/rtl/oustring/rtl_OUString2.cxx b/sal/qa/rtl/oustring/rtl_OUString2.cxx index 27a06ab..95940f7 100644 ---
Re: [Libreoffice-qa] www.libreoffice.org website has an issue
Hi *, Am 23.06.2014 21:54 schrieb Cor Nouws oo...@nouenoff.nl: thanks for posting. I see a mail with subject LibreOffice website does not display all characters at the website list, so I guess it's noticed there as well. It is noticed, but so far the problem could not be tracked down. It is not related to the Browser version or operating system - there is more to it. It is only clear that a browser bug is triggered, but not sure why... The thread has some new info though: the letters apparently just have the background color and: ad block extension does make a difference. But also in the thread people have trouble reproducing it... Ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] bug 80220
Hi Nino, *; On Wednesday, June 25, 2014, Nino Novak nn.l...@kflog.org wrote: [...] I'm going to give it a try. done. well, in my case it was easy to reproduce, as I'm using the same localization and the report is rather well done. However, I cannot estimate the importance/implications as I rather seldom use writer myself. Sounds very much like a regression and thus a candidate for bibisect... But again @whoeverstartsathread: use telling summaries, give a link to click on and a small abstract about what is all about (in this case: inserted date-field loses locale/langauge-property on document reload). It makes life so much easier for others... ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [libreoffice-projects] minutes of ESC call ...
Hi, a quick hint, since I stumbled over this: On Thu, May 08, 2014 at 04:29:41PM +0100, Michael Meeks wrote: + HackFest 'pack' / box / Virtual Machines / etc. ? + Still have hardware to try out (Bjoern) + can bring to Paris - some quadro / quad CPU thingit (TDF-owned Sun Ultra 24 with Q9650) + if we buy new hardware: something like tinderboxes we have or ... + alternatives (from ebay): + refurbished HP DL165 with 24 cores at 1.5K EUR at 1HU/15kg + refurbished Lenovo W520s at ~1K EUR each (and plane-suitable) + total cost sub Eur 5k Also note these newfangled NUCs like the ZBOX IQ01: http://www.zotac.com/products/mini-pcs/zbox/product/zbox/detail/zbox-iq01/sort/starttime/order/DESC/amount/10/section/specifications.html Intel i7-4770T, easy to transport, price currently ~600EUR with 16GB RAM. + happy to have it at his place as a tinderbox the rest of the time (Kendy) Still, the Ultra 24 we own has to go first ... Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] bug 80220
Hello Christian, Am 26.06.2014 10:06, schrieb Christian Lohmaier: But again @whoeverstartsathread: use telling summaries, give a link to click on and a small abstract about what is all about (in this case: inserted date-field loses locale/langauge-property on document reload). It makes life so much easier for others... ups... you're so right... I'll do my very best :-) Nino ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] minutes of ESC call ...
* Participants: Stephan, Christian, Adam, Miklos, Michael S., Caolan, Eilidh, Cedric, Andras, Robinson, Astron * Completed Action Items + invite Muthu (Michael) + get Board involved to listen / interact over 'titles' (Astron) * Pending Action Items: + research / seek a saner access2base solution for master (Stephan) + ask UX advise wrt. wrench icons (revert or not ?) (Astron) + scripting to generate / list last week's UI changes (Cloph) + started + review crazy SfxItemPool hash speedup patch (Kendy) + blog about the sad realities of web plugins (Bjoern) + poke potential Boston Hackfest hosters again (Michael) * GSOC Update (Cedric) + mid-term evaluations this week [!]: 23rd-27th June. + all mentors did evaluatins, all going well, Cedric keeping an eye on it * Release Engineering update (Christian) + 4.2.5 retrospective + released last Friday + no update check yet, tbd today (incl. 4.1 - 4.2.5) + 4.3.0 UI and string freeze: + 1 review needed after the tag for rc1 + 4.3.0 RC2 status + deadline next Monday, branch-off next week (2 reviews req. after that) + Android / iOS remote + no pending patches + Late features ? + OpenGL pieces / status + impress work as well ? + pending GL capabilities check to avoid crashes + mostly affects Linux ... + pending various fixes for GLTF rendering. [ starting to be at risk ! ] + experimentalising 3D chart bits. + at risk [ Tamas to look at that ] + Calc performance fixes (?) + Writer performance fix + did see crashes with that on the stack (Stephan) + not sure if that's related + in 4.3 by now * Crashtest update (Markus) + new result based on build from Sunday, June 15th http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26 + summary is available as http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26/exportCrashes.csv http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26/importCrash.csv http://dev-builds.libreoffice.org/crashtest/76f0a1307f779faf4f590fefafc445c077a39f26/validationErrors.csv + memcheck results + thanks to the City Of Largo + http://dev-builds.libreoffice.org/crashtest/memcheck.zip + grep for 'Invalid' or 'conditional jump' + most serious already fixed + machine rebooted itself unhelpfully midway through... (Cloph) * Certification Committee (Stephan/Bjoern/Kendy) + waiting until ~September * writerfilter / XSLT - python (Miklos) + started working on it, code gen via XSLT dubious, done via Python now * AOO merging / regressions (Caolan/Miklos) The 78908 and 79158 are probably both the same problem and are due to the integration of Armin's stuff. I test-merged the remainder of his stuff and it definitely fixes 78908, but then clobbers our character border feature, sigh. I pushed all of that to the http://cgit.freedesktop.org/libreoffice/core/log/?h=feature/aoo-fillattribute branch + Miklos plans to look at branch next week * Hackfests (Bjoern) + Paris Hackfest: + June 27-28th + please add yourself to the wiki: + https://wiki.documentfoundation.org/Hackfest/Paris2014 + 12 people listed so far + Boston Hackfest: + July 26-27th + https://wiki.documentfoundation.org/Events/2014/US_Summer_Hackfest + Tough to line-up mentoring devs + would appreciate developers via Google Hangout etc. + QA is happy to recruit programmers for our internal projects, but would like to share w/the dev team. + poke potential hosters again (Michael) + (possible) Seattle + Oct 25-27 + Straw poll: Who could make these dates? + prolly better to ping people individually (Michael) + Be great to have -really- easy easy hacks for devs (Bjoern) + Toulouse Hackfest ... + Confirmed for Nov. 15-16th + more details: https://wiki.documentfoundation.org/Hackfest/Toulouse2014 * HackFest Box (Kendy) + did we get board approval for that yet ? + no - in the budget extensions, but no ranking yet (Michael) * QA (Robinson) + Unconfirmed count ? + down to 972 + Needadvice + Bibisected regressions still increasing ... + help appreciated. + bug hunting session last weekend starting Friday. + went well + buzilla migration (Norbert) + hoping we can do it in June/July timeline. + channel busier again now * UX Update (Astron) + title resolution ? + team positions in the design team, took discussion to
[Libreoffice-bugs] [Bug 77173] PRINTING: Can't print after a time
https://bugs.freedesktop.org/show_bug.cgi?id=77173 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added CC||ign_christ...@yahoo.com --- Comment #2 from ign_christian ign_christ...@yahoo.com --- I guess it's Linux only bug. In addition to Andy's questions, local or network printer? If networked, I ever experience similar issue using samba, try using IPP/cups instead..more reliable. Is the print job sent? Status? Please inform your printer model also, perhaps someone here ever experience similar issue with same printer. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44417] shortcut left Alt-key behaves different form right Alt-key
https://bugs.freedesktop.org/show_bug.cgi?id=44417 --- Comment #3 from Winfried Donkers winfrieddonk...@libreoffice.org --- Problem as decsribed in comment #0 still exists in version 4.2.5.2 on Windows7. Steps to reproduce: -open new calc document -enter values in A1..A4 -select range A1:A4 -press left Alt-key and drag selected range with mouse to C11:C14 ; the range is moved, as expected -press Ctrl-Z to undo move -select range A1:A4 -press right Alt-key and drag selected range with mouse to C11:C14 ; the range is copied, which is not as expected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70653] EDITING: impossible to change existing math catalog element's font face without its name auto-switched to Unicode value
https://bugs.freedesktop.org/show_bug.cgi?id=70653 --- Comment #5 from Dominik d0m1...@gmx.net --- still existing in 4.3.0 rc1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74120] Segfault in libmergedlo.so causing kernel crash
https://bugs.freedesktop.org/show_bug.cgi?id=74120 --- Comment #7 from Matúš Kukan matus.ku...@collabora.com --- I don't understand this bug. Yes, libmerged is just a huge shared library. It should fail the same way if you split it into many smaller. So - is LO crashing? Can you provide any backtrace? Or any way to reproduce this problem? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79265] EDITING: Can't select another item from input list within protected section
https://bugs.freedesktop.org/show_bug.cgi?id=79265 --- Comment #3 from Kulo h.kulov...@lohr.at --- Confirmed on Windows 7 x64 in Version 4.3.0.1 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80550] New: create folder from save as dialog -- closes save as dialog
https://bugs.freedesktop.org/show_bug.cgi?id=80550 Priority: medium Bug ID: 80550 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: create folder from save as dialog -- closes save as dialog Severity: normal Classification: Unclassified OS: All Reporter: gdna7...@hotmail.com Hardware: Other Status: UNCONFIRMED Version: 4.3.0.1 rc Component: Libreoffice Product: LibreOffice Steps to reproduce: Tools -- Options -- General -- use libreoffice dialogs, should be ticked Open a new document. (I tried Calc and Writer) modify it. File -- save as -- click the new folder icon. Expected behavior: the opportunity to create a new folder is provided Actual behavior: save as dialog closes Tested on Win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79940] FILEOPEN: DOCX: LO crashes while opening issue file
https://bugs.freedesktop.org/show_bug.cgi?id=79940 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard||target:4.4.0 --- Comment #3 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Vinaya Mandke committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9fbdb02c9a1da28b4dd51b053d39cb254631e535 fdo#79940 LO crashes on opening; tries to remove a para with bookmarks The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80404] PRINTING: Unable to print documents to Brother printer on Mac
https://bugs.freedesktop.org/show_bug.cgi?id=80404 Jay Philips philip...@hotmail.com changed: What|Removed |Added CC||philip...@hotmail.com Summary|Printing Documents |PRINTING: Unable to print ||documents to Brother ||printer on Mac Component|Libreoffice |Printing and PDF export -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80551] New: uno Sheet annotations getByIndex is based on document annotations index
https://bugs.freedesktop.org/show_bug.cgi?id=80551 Priority: medium Bug ID: 80551 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: uno Sheet annotations getByIndex is based on document annotations index Severity: normal Classification: Unclassified OS: All Reporter: lgodard.li...@laposte.net Hardware: Other Status: UNCONFIRMED Version: 4.2.4.2 release Component: Spreadsheet Product: LibreOffice Created attachment 101785 -- https://bugs.freedesktop.org/attachment.cgi?id=101785action=edit macro illustrating the problem - run main() In a macro, get the sheet annotations the count is ok a getByIndex(0) returns the firs note of the document, not the first note of the sheet expected : the returned note should be the first of the sheet.getAnnotations() code pointers : annotations of the sheet http://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/cellsuno.cxx#6937 get By index http://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/docuno.cxx#3617 -- here index refers to notes in table ScAnnotationsObj::GetObjectByIndex_Impl http://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/docuno.cxx#3550 ScAnnotationsObj::GetAddressByIndex_Impl http://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/docuno.cxx#3541 -- here index refers to notes in doc attachement : run the Main() macro contained The 2 requested notes are not the expected one; The 0 and 1 index refer to document annotations not to sheet annotations -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72157] LibreOffice does not release WebDAV file lock on document close
https://bugs.freedesktop.org/show_bug.cgi?id=72157 --- Comment #26 from i...@medizinische-genetik.de --- (In reply to comment #25) There was an error in the installer which has been fixed now. Please try again tomorrow. Today I tried http://dev-builds.libreoffice.org/daily/libreoffice-4-2/Win-x86@42/current/libo-42~2014-06-26_00.38.42_LibreOfficeDev_4.2.6.0.0_Win_x86.msi The installer works again. With this version, the WebDAV issue seems to be fixed. When I open a Doc via WebDAV, save and close it (quickstart is still running) and re-open it, the Doc opens like expected. Thanks. Can please one of the others, who had this bug, confirm, that it works in their environment, too? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80494] Creating chart by StarBasic Macro fails
https://bugs.freedesktop.org/show_bug.cgi?id=80494 --- Comment #3 from FS bz...@florian-schmitt.net --- Checked the sample code with Apache OpenOffice.org Calc 4.1.0 on Win7 - works perfectly. So i assume the Basic code is valid and working. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79674] Opening ods file is slow (empty/bank or not), xlsx file is fast
https://bugs.freedesktop.org/show_bug.cgi?id=79674 nuageb...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #8 from nuageb...@gmail.com --- As I said the hardware is fast: - Intel Core i7-4750HQ CPU - SSD 480GB (Crucial M500) - 16 GiB RAM And I double checked the test by saving files in /tmp, which is configured to use tmpfs, so it's using RAM. Since Debian Testing is updating things all the time, my current version of LibreOffice is : Version: 4.2.4.2 Some more information: I also use a VM with kubutu, which uses an other version of LibreOffice (Version: 4.2.3.3), which doesn't have this issue. So it cannot be the hardware. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80526] DOCX formatting
https://bugs.freedesktop.org/show_bug.cgi?id=80526 Jay Philips philip...@hotmail.com changed: What|Removed |Added Attachment #101747|text/plain |application/vnd.openxmlform mime type||ats-officedocument.wordproc ||essingml.document -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80060] FORMATTING: mate panel disappear
https://bugs.freedesktop.org/show_bug.cgi?id=80060 --- Comment #9 from mihai petcu miky_brot...@yahoo.com --- using Mint 17 x64, fresh install on a Lenovo Thinkpad x200 with an Intel Mobile 4 Series Chipset Integrated Graphics Controller [8086:2A42] and a generic i915 driver. i've created an extra top panel without modifying it's standard settings. removed libreoffice from ppa and installed from official repository. now the panels are disappearing when i try to change font colour / underlining colour / background colour, and it's happening only when i open the list to select another colour. things are going back to normal by restarting X.org (Ctrl + Alt + Backspace) or by rebooting the system. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60244] Unique random number generator function
https://bugs.freedesktop.org/show_bug.cgi?id=60244 Kevin Suo suokunl...@gmail.com changed: What|Removed |Added CC||suokunl...@gmail.com --- Comment #2 from Kevin Suo suokunl...@gmail.com --- @Justin, I see in the newest libreoffice that Edit - Fill - Random Numbers is the sames as what you described. Does this resolve your request? Thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80060] FORMATTING: mate panel disappear
https://bugs.freedesktop.org/show_bug.cgi?id=80060 --- Comment #10 from mihai petcu miky_brot...@yahoo.com --- i found the cause: everything is working fine by disabling composition -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46850] iterative computation will not converge
https://bugs.freedesktop.org/show_bug.cgi?id=46850 Kevin Suo suokunl...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO CC||suokunl...@gmail.com --- Comment #2 from Kevin Suo suokunl...@gmail.com --- This bug is never confirmed. Set to UNCONFIRMED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46850] iterative computation will not converge
https://bugs.freedesktop.org/show_bug.cgi?id=46850 Kevin Suo suokunl...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80521] FORMATTING: AutoCorrect doesnt work when a sentence ends with a number or capitalized last word
https://bugs.freedesktop.org/show_bug.cgi?id=80521 Jay Philips philip...@hotmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||philip...@hotmail.com Summary|FORMATTING: starting|FORMATTING: AutoCorrect |sentence with capital |doesnt work when a sentence |letter. |ends with a number or ||capitalized last word Ever confirmed|0 |1 --- Comment #2 from Jay Philips philip...@hotmail.com --- Confirmed in 4.2.5 and 4.3.0 on Linux Mint. Steps to reproduce: 1) Type tomorrow, i'm going to be 5. but all in smallcase 2) It will turn it into Tomorrow, i'm going to be 5. but The same goes for having parenthesis at before the period. Regarding the all caps word at the end of the sentence, i believe that if LibreOffice things the word is an actual word, it will auto-correct the following sentence. I tested this with where are you going tomorrow JIMMY. what . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79674] Opening ods file is slow (empty/bank or not), xlsx file is fast
https://bugs.freedesktop.org/show_bug.cgi?id=79674 --- Comment #9 from nuageb...@gmail.com --- More information: Debian just updated the LibreOffice packages, so the new version I'm testing is: Version: 4.2.5.2 Build ID: 420m0(Build:2) Which *still* have the same problem. So I Test again with small documents: .ods : 5[s] .odt : instant .odp : instant .xlsx : instant if saved by LibreOffice, and 5[s] for another document I hope this can help to track down the bug! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80540] VIEWING: Stock chart does not display correctly
https://bugs.freedesktop.org/show_bug.cgi?id=80540 --- Comment #2 from Rinus van Weert mjmvanwe...@gmail.com --- Created attachment 101788 -- https://bugs.freedesktop.org/attachment.cgi?id=101788action=edit a (exported) picture of the BIDU-STOCK-PRICE example As shown in the attachment the example BIDU-STOCK_PRICE.ods shows the same behavior in Calc 4.2.4.2. I tried version 4.2.5, but the results were the same. Unfortunately there is version 4.3.0 for Linux Mint/Ubuntu, so I'm not able to try that version yet on my system. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80540] VIEWING: Stock chart does not display correctly
https://bugs.freedesktop.org/show_bug.cgi?id=80540 --- Comment #3 from Rinus van Weert mjmvanwe...@gmail.com --- I meant to say there is NO 4.3.0 version for Linux Mint/Ubuntu (deb version) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80526] FILEOPEN: DOCX frame not being stretched to accomodate text in it
https://bugs.freedesktop.org/show_bug.cgi?id=80526 Jay Philips philip...@hotmail.com changed: What|Removed |Added Hardware|x86 (IA32) |All OS|Windows (All) |All Status|UNCONFIRMED |NEW Whiteboard||interoperability CC||philip...@hotmail.com Summary|DOCX formatting |FILEOPEN: DOCX frame not ||being stretched to ||accomodate text in it Version|unspecified |4.1.6.2 release Ever confirmed|0 |1 --- Comment #1 from Jay Philips philip...@hotmail.com --- Confirmed in 4.1 and above on Linux Mint. In the DOCX file, there are two frames that have text in it. One for '91' and a second for 'and still having fun!'. The frame sizes being created for the two are being horizontally expanded rather than vertical. In 4.0.6, it doesnt expand the frame vertically or horizontally, but instead, shows a red error to indicate that more text is available. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80526] FILEOPEN: DOCX frame not being stretched to accomodate text in it
https://bugs.freedesktop.org/show_bug.cgi?id=80526 --- Comment #2 from Jay Philips philip...@hotmail.com --- Created attachment 101789 -- https://bugs.freedesktop.org/attachment.cgi?id=101789action=edit LibO 4.1 VS Word 2013 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80526] FILEOPEN: DOCX frame not being stretched to accomodate text in it
https://bugs.freedesktop.org/show_bug.cgi?id=80526 --- Comment #3 from Jay Philips philip...@hotmail.com --- Created attachment 101790 -- https://bugs.freedesktop.org/attachment.cgi?id=101790action=edit How it looks in 4.0 without the ribbon -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs