[Libreoffice-bugs] [Bug 92857] New: HTML Filter: Embedded images before tables breaks layout of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=92857 Bug ID: 92857 Summary: HTML Filter: Embedded images before tables breaks layout of tables Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: filters and storage Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rmil...@generalcode.com Created attachment 117362 -- https://bugs.documentfoundation.org/attachment.cgi?id=117362action=edit With image (broken table) If you have an embedded base64 encoded image before a wide table with width 100% in your html and you import it the table is not resized correctly and runs off the edge of the page. Removing the image causes the table to format correctly. I have also tried this last week with a copy freshly built out of git. Same problem. See attached html files for the broken and correct states. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92856] Incorrect table document formatting created in MS Office
https://bugs.documentfoundation.org/show_bug.cgi?id=92856 Jacques Guilleron guillero...@aol.com changed: What|Removed |Added Keywords||regression Status|UNCONFIRMED |NEW CC||guillero...@aol.com Ever confirmed|0 |1 --- Comment #1 from Jacques Guilleron guillero...@aol.com --- Hi bazillo, I reproduce with LO 5.0.0.3 Build ID: f79b5ba13f5e6cbad23f8038060e556217e66632 LO 5.0.0.0.alpha1+ Build ID: 6664859e1e8b3f8b7db8c931b8d0335510c20ce0 TinderBox: Win-x86@42, Branch:master, Time: 2015-05-16_03:16:31 but not with: LO 4.3.7.2 Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba LO 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 Windows 7 Home Premium I set status to NEW and add regression to Keywords. Thanks for the report. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92795] Please allow the presenter console to be treated as a normal window
https://bugs.documentfoundation.org/show_bug.cgi?id=92795 --- Comment #5 from Roland Taylor rolandi...@gmail.com --- I think you missed my point. Yes, you are a member of the team and that is your right, but wouldn't it be more reasonable to do this *after* the person reporting the UX bug has given you an explanation as to why the current situation is not ideal? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86845] DIALOG: Hyperlink details not retained between tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=86845 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added CC||jbfa...@libreoffice.org Severity|normal |major --- Comment #8 from Jean-Baptiste Faure jbfa...@libreoffice.org --- Rise importance a bit because this bug may generate dataloss: if you do not see that the field has been emptied and you click on Ok button, the text you had selected is lost. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - sd/source sd/uiconfig
sd/source/ui/app/sddll.cxx |2 ++ sd/uiconfig/sdraw/menubar/menubar.xml|2 ++ sd/uiconfig/sdraw/toolbar/standardbar.xml|3 ++- sd/uiconfig/simpress/menubar/menubar.xml |2 ++ sd/uiconfig/simpress/toolbar/standardbar.xml |3 ++- 5 files changed, 10 insertions(+), 2 deletions(-) New commits: commit 14c32cd60ef745d181add0445f5f2f8a3bb779a0 Author: Szymon KÅos eszka...@gmail.com Date: Tue Jul 21 17:21:57 2015 +0200 Open/Save Remote File in Impress/Draw toolbars and menu Change-Id: I9503f5beaa8b5a6afc213747a691265acd5903f7 diff --git a/sd/source/ui/app/sddll.cxx b/sd/source/ui/app/sddll.cxx index 8fb1907..8e15960 100644 --- a/sd/source/ui/app/sddll.cxx +++ b/sd/source/ui/app/sddll.cxx @@ -257,6 +257,8 @@ void SdDLL::RegisterControllers() SvxFrameLineStyleToolBoxControl::RegisterControl(SID_FRAME_LINESTYLE, pMod ); SvxColorToolBoxControl::RegisterControl(SID_FRAME_LINECOLOR, pMod ); SvxFrameToolBoxControl::RegisterControl(SID_ATTR_BORDER, pMod ); + +SfxSaveAsToolBoxControl::RegisterControl(SID_SAVEASDOC, pMod ); } void SdDLL::Init() diff --git a/sd/uiconfig/sdraw/menubar/menubar.xml b/sd/uiconfig/sdraw/menubar/menubar.xml index bc8cfee..c1a9be9 100644 --- a/sd/uiconfig/sdraw/menubar/menubar.xml +++ b/sd/uiconfig/sdraw/menubar/menubar.xml @@ -21,6 +21,7 @@ menu:menupopup menu:menuitem menu:id=.uno:AddDirect/ menu:menuitem menu:id=.uno:Open/ + menu:menuitem menu:id=.uno:OpenRemote/ menu:menuitem menu:id=.uno:RecentFileList/ menu:menuseparator/ menu:menuitem menu:id=.uno:AutoPilotMenu/ @@ -36,6 +37,7 @@ menu:menuitem menu:id=.uno:Save/ menu:menuitem menu:id=.uno:SaveAs/ menu:menuitem menu:id=.uno:SaveACopy/ + menu:menuitem menu:id=.uno:SaveAsRemote/ menu:menuitem menu:id=.uno:SaveAll/ menu:menuitem menu:id=.uno:CheckOut/ menu:menuitem menu:id=.uno:CancelCheckOut/ diff --git a/sd/uiconfig/sdraw/toolbar/standardbar.xml b/sd/uiconfig/sdraw/toolbar/standardbar.xml index 06c7d5d..6e2d1fa 100644 --- a/sd/uiconfig/sdraw/toolbar/standardbar.xml +++ b/sd/uiconfig/sdraw/toolbar/standardbar.xml @@ -22,8 +22,9 @@ toolbar:toolbaritem xlink:href=.uno:AddDirect toolbar:helpid=5537/ toolbar:toolbaritem xlink:href=.uno:NewDoc toolbar:visible=false toolbar:helpid=5500/ toolbar:toolbaritem xlink:href=.uno:Open toolbar:style=dropdown/ + toolbar:toolbaritem xlink:href=.uno:OpenRemote/ toolbar:toolbaritem xlink:href=.uno:Save toolbar:helpid=5505/ - toolbar:toolbaritem xlink:href=.uno:SaveAs toolbar:helpid=5502/ + toolbar:toolbaritem xlink:href=.uno:SaveAs toolbar:style=dropdown toolbar:helpid=5502/ toolbar:toolbaritem xlink:href=.uno:SendMail toolbar:visible=false toolbar:helpid=5331/ toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:EditDoc toolbar:helpid=6312 toolbar:visible=false/ diff --git a/sd/uiconfig/simpress/menubar/menubar.xml b/sd/uiconfig/simpress/menubar/menubar.xml index 3eb5156..71146c2 100644 --- a/sd/uiconfig/simpress/menubar/menubar.xml +++ b/sd/uiconfig/simpress/menubar/menubar.xml @@ -21,6 +21,7 @@ menu:menupopup menu:menuitem menu:id=.uno:AddDirect/ menu:menuitem menu:id=.uno:Open/ +menu:menuitem menu:id=.uno:OpenRemote/ menu:menuitem menu:id=.uno:RecentFileList/ menu:menuitem menu:id=.uno:CloseDoc/ menu:menuseparator/ @@ -38,6 +39,7 @@ menu:menuitem menu:id=.uno:Save/ menu:menuitem menu:id=.uno:SaveAs/ menu:menuitem menu:id=.uno:SaveACopy/ +menu:menuitem menu:id=.uno:SaveAsRemote/ menu:menuitem menu:id=.uno:SaveAll/ menu:menuitem menu:id=.uno:CheckOut/ menu:menuitem menu:id=.uno:CancelCheckOut/ diff --git a/sd/uiconfig/simpress/toolbar/standardbar.xml b/sd/uiconfig/simpress/toolbar/standardbar.xml index c82ad6a..a83b414 100644 --- a/sd/uiconfig/simpress/toolbar/standardbar.xml +++ b/sd/uiconfig/simpress/toolbar/standardbar.xml @@ -22,8 +22,9 @@ toolbar:toolbaritem xlink:href=.uno:AddDirect toolbar:style=dropdown/ toolbar:toolbaritem xlink:href=.uno:NewDoc toolbar:visible=false/ toolbar:toolbaritem xlink:href=.uno:Open toolbar:style=dropdown/ + toolbar:toolbaritem xlink:href=.uno:OpenRemote/ toolbar:toolbaritem xlink:href=.uno:Save/ - toolbar:toolbaritem xlink:href=.uno:SaveAs/ + toolbar:toolbaritem xlink:href=.uno:SaveAs toolbar:style=dropdown/ toolbar:toolbaritem xlink:href=.uno:SendMail toolbar:visible=false/ toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:EditDoc toolbar:visible=false/ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92857] HTML Filter: Embedded images before tables breaks layout of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=92857 --- Comment #3 from Bob Miller rmil...@generalcode.com --- Created attachment 117365 -- https://bugs.documentfoundation.org/attachment.cgi?id=117365action=edit Without image as converted -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92857] HTML Filter: Embedded images before tables breaks layout of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=92857 --- Comment #2 from Bob Miller rmil...@generalcode.com --- Created attachment 117364 -- https://bugs.documentfoundation.org/attachment.cgi?id=117364action=edit With image as converted -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92857] HTML Filter: Embedded images before tables breaks layout of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=92857 --- Comment #1 from Bob Miller rmil...@generalcode.com --- Created attachment 117363 -- https://bugs.documentfoundation.org/attachment.cgi?id=117363action=edit Without image (works) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - svx/source
svx/source/form/fmvwimp.cxx | 98 +---
svx/source/form/formcontrolling.cxx | 12 ++--
2 files changed, 87 insertions(+), 23 deletions(-)
New commits:
commit ba30fabf3ca88fedc05d521c9ec06a0b77007661
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Tue Jul 21 17:31:56 2015 +0200
Listen to error only while operating on controller.
Else, on any action done directly (not through the
FormControllerHelper) on the controller and raising an SQL error, this
would silently swallow the error message, and the operation would fail
without any message to the user.
E.g. when validating an insertion or modification in a grid control by
moving the cursor to a different line (as opposed to clicking the
Save Record button).
Change-Id: Ie569d9c826609f803f7b312c046990718ef2
diff --git a/svx/source/form/formcontrolling.cxx
b/svx/source/form/formcontrolling.cxx
index db5d2be..6fcf0a7 100644
--- a/svx/source/form/formcontrolling.cxx
+++ b/svx/source/form/formcontrolling.cxx
@@ -240,11 +240,6 @@ namespace svx
m_xFormOperations = FormOperations::createWithFormController(
comphelper::getProcessComponentContext(), _rxController );
if ( m_xFormOperations.is() )
m_xFormOperations-setFeatureInvalidation( this );
-
-// to prevent the controller from displaying any error messages
which happen while we operate on it,
-// we add ourself as XSQLErrorListener. By contract, a
FormController displays errors if and only if
-// no SQLErrorListeners are registered.
-_rxController-addSQLErrorListener( this );
}
catch( const Exception )
{
@@ -333,6 +328,11 @@ namespace svx
const_cast FormControllerHelper* ( this )-m_aOperationError.clear();
try
{
+// to prevent the controller from displaying any error messages
which happen while we operate on it,
+// we add ourself as XSQLErrorListener. By contract, a
FormController displays errors if and only if
+// no SQLErrorListeners are registered.
+m_xFormOperations-getController()-addSQLErrorListener(
const_cast FormControllerHelper* (this) );
+
switch ( _eWhat )
{
case COMMIT_CONTROL:
@@ -359,10 +359,12 @@ namespace svx
}
catch ( const SQLException )
{
+m_xFormOperations-getController()-removeSQLErrorListener(
const_cast FormControllerHelper* (this) );
aError = ::cppu::getCaughtException();
}
catch( const Exception )
{
+m_xFormOperations-getController()-removeSQLErrorListener(
const_cast FormControllerHelper* (this) );
SQLException aFallbackError;
aFallbackError.Message = ::comphelper::anyToString(
::cppu::getCaughtException() );
aError = aFallbackError;
commit b28ec7f462fcbb612b1c8a89af84c7c2601a5c65
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Tue Jul 21 17:01:37 2015 +0200
janitorial
Change-Id: I727c5af7659e9591563c0784fee5d0d9317ebc24
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index 6d6c9a6..b153f3fb6 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -746,7 +746,7 @@ IMPL_LINK_NOARG(FmXFormView, OnActivate)
pAdapter =*i;
}
-if ( pAdapter.get() )
+if ( pAdapter.is() )
{
Reference XFormController xControllerToActivate;
for ( ::std::vector Reference XFormController
::const_iterator i = pAdapter-GetList().begin();
commit 42f0a84764add89c6b22943d55c821acbcf3f37d
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Tue Jul 21 16:58:38 2015 +0200
form document view activation: prioritise activation of already active form
This avoids arbitrarily switching to the first form in the document,
which would do a (premature!) save to the database of the
modifications pending in the active form. This may lead to a database
error, when the data is not in a shape to be written to the database,
e.g. when on an insertion row and not all mandatory fields have been
filled in. This then pops up an error message to the user.
Change-Id: I30bb533598ca707b892bb7155e54ce05d4ddf275
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index 51db499..6d6c9a6 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -654,6 +654,66 @@ void FmXFormView::resumeTabOrderUpdate()
m_aNeedTabOrderUpdate.clear();
}
+namespace
+{
+bool isActivableDatabaseForm(const Reference XFormController
xController)
+{
+// only database forms are to be activated
+Reference XRowSet xForm(xController-getModel(), UNO_QUERY);
+if ( !xForm.is() || !getConnection( xForm ).is() )
+return false;
+
+
[Libreoffice-commits] libvisio.git: 2 commits - src/lib src/test
src/lib/VSD5Parser.cpp | 16
src/test/importtest.cpp |2 +-
2 files changed, 13 insertions(+), 5 deletions(-)
New commits:
commit 77a88f128700e434c093eb53590be63022edbdea
Author: David Tardon dtar...@redhat.com
Date: Tue Jul 21 17:35:13 2015 +0200
avoid overflows when reading chunk records
Change-Id: Iea13e63e977348a449b68eca329146ae6f097197
diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp
index 00cbf06..79b638b 100644
--- a/src/lib/VSD5Parser.cpp
+++ b/src/lib/VSD5Parser.cpp
@@ -102,7 +102,12 @@ void
libvisio::VSD5Parser::handleChunkRecords(librevenge::RVNGInputStream *input
long endPosition = input-tell() + m_header.dataLength;
input-seek(endPosition - 4, librevenge::RVNG_SEEK_SET);
unsigned numRecords = readU16(input);
+ const long headerPosition = endPosition - 4 * (numRecords + 1);
+ if (headerPosition = startPosition) // no records to read
+return;
unsigned endOffset = readU16(input);
+ if (long(endOffset) (headerPosition - startPosition))
+endOffset = unsigned(headerPosition - startPosition); // try to read
something anyway
std::mapunsigned, ChunkHeader records;
input-seek(endPosition-4*(numRecords+1), librevenge::RVNG_SEEK_SET);
unsigned i = 0;
@@ -114,10 +119,13 @@ void
libvisio::VSD5Parser::handleChunkRecords(librevenge::RVNGInputStream *input
unsigned tmpStart = offset;
while (tmpStart % 4)
tmpStart++;
-header.dataLength = endOffset - tmpStart;
-header.level = m_header.level + 1;
-records[tmpStart] = header;
-endOffset = offset;
+if (tmpStart endOffset)
+{
+ header.dataLength = endOffset - tmpStart;
+ header.level = m_header.level + 1;
+ records[tmpStart] = header;
+ endOffset = offset;
+}
}
i = 0;
for (std::mapunsigned, ChunkHeader::iterator iter = records.begin(); iter
!= records.end(); ++iter)
commit 2bdd7a9bfd1ed1606b7348602196f0a2baf0c099
Author: David Tardon dtar...@redhat.com
Date: Tue Jul 21 17:35:19 2015 +0200
astyle
Change-Id: I51eebdceb176ae9ded9860010a6b691d0af4cf95
diff --git a/src/test/importtest.cpp b/src/test/importtest.cpp
index 705a8c7..c09bfd8 100644
--- a/src/test/importtest.cpp
+++ b/src/test/importtest.cpp
@@ -85,7 +85,7 @@ void assertXPathNoAttribute(xmlDocPtr doc, const
librevenge::RVNGString xpath,
message2.append(' unexpected ');
message2.append(attribute);
message2.append(' attribute);
- CPPUNIT_ASSERT_EQUAL_MESSAGE(message2.cstr(), static_castxmlChar*(0),
xmlGetProp(node, BAD_CAST(attribute.cstr(;
+ CPPUNIT_ASSERT_EQUAL_MESSAGE(message2.cstr(), static_castxmlChar *(0),
xmlGetProp(node, BAD_CAST(attribute.cstr(;
xmlXPathFreeObject(xpathobject);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88329] Document preview under Windows 8.1 does not work [Hard to reproduce]
https://bugs.documentfoundation.org/show_bug.cgi?id=88329 --- Comment #9 from Gordo gordon1dr...@yahoo.com --- I meant odt. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc_formula.cxx | 19 +++
1 file changed, 19 insertions(+)
New commits:
commit bb7c3821208feef6cf713591a9805e4118dd7554
Author: Eike Rathke er...@redhat.com
Date: Tue Jul 21 16:36:26 2015 +0200
unit test for MATCH ReferenceOrForceArray parameter
Change-Id: I534480411d6c164f9f0955933b612c1a219402fd
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 0e562d7..8610c54 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -4263,6 +4263,25 @@ void Test::testFuncMATCH()
CPPUNIT_ASSERT_EQUAL(OUString(6),
m_pDoc-GetString(ScAddress(1,0,0)));
}
+{
+// Test the ReferenceOrForceArray parameter.
+
+clearRange(m_pDoc, ScRange(0,0,0,1,7,0));
+
+// B1:B5 contain numeric values.
+m_pDoc-SetValue(ScAddress(1,0,0), 1.0);
+m_pDoc-SetValue(ScAddress(1,1,0), 2.0);
+m_pDoc-SetValue(ScAddress(1,2,0), 3.0);
+m_pDoc-SetValue(ScAddress(1,3,0), 4.0);
+m_pDoc-SetValue(ScAddress(1,4,0), 5.0);
+
+// Find string value 33 in concatenated array, no implicit
+// intersection is involved, array is forced.
+m_pDoc-SetString(ScAddress(0,5,0), =MATCH(\33\;B1:B5B1:B5));
+m_pDoc-CalcAll();
+CPPUNIT_ASSERT_EQUAL(3.0, m_pDoc-GetValue(ScAddress(0,5,0)));
+}
+
m_pDoc-DeleteTab(0);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 44417] shortcut left Alt-key behaves different form right Alt-key
https://bugs.documentfoundation.org/show_bug.cgi?id=44417 --- Comment #6 from Marek Dolezel marekdole...@gmail.com --- I can confirm on win10 Version: 5.1.0.0.alpha1+ (x64) Build ID: c18f11587d37f285a95447dd8996c8b605732e00 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-01_21:36:15 Locale: en-GB (en_GB) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes
https://bugs.documentfoundation.org/show_bug.cgi?id=92803 --- Comment #12 from Tomas Kralik krali...@gmail.com --- (In reply to m.a.riosv from comment #11) I think headless use the last options used in LibreOffice. Have you tried, doing first one opening LibreOffice, setting up properly the options and try after in headless mode. Thank you for your response. However, I have LO installed only on the server version of Linux. Thus, without a graphical interface. Is it possible to somehow set the PDF export directly in the configuration file LO? For example, DPI, quality, etc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 3 commits - loleaflet/src loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/TileCache.cpp loolwsd/TileCache.hpp
loleaflet/src/control/Parts.js|1 +
loleaflet/src/layer/tile/TileLayer.js |1 +
loolwsd/LOOLSession.cpp | 24 ++--
loolwsd/LOOLSession.hpp |4
loolwsd/TileCache.cpp | 22 ++
loolwsd/TileCache.hpp |2 +-
6 files changed, 43 insertions(+), 11 deletions(-)
New commits:
commit 0492094b4eb3d21d8ff9b5e874ee806640a4b0f1
Author: Mihai Varga mihai.va...@collabora.com
Date: Tue Jul 21 16:57:50 2015 +0300
loleaflet: notify the server about the current part
We need this because we want to prefetch tiles from other parts too.
In order to render a tile we need to call 'setPart' and then 'paintTile'
so this might change the current part in the document.
But when the user is editing/selecting we want to work on the part that
he/she is viewing
diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 30eddd9..1041604 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -25,6 +25,7 @@ L.Map.include({
parts: docLayer._parts,
docType: docLayer._docType
});
+ docLayer.sendMessage('setclientpart part=' +
docLayer._currentPart);
docLayer._update();
docLayer._pruneTiles();
docLayer._clearSelections();
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index b4d8024..99b4df1 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -323,6 +323,7 @@ L.TileLayer = L.GridLayer.extend({
this._documentInfo = textMsg;
this._parts = command.parts;
this._currentPart = command.currentPart;
+ this.sendMessage('setclientpart part=' +
this._currentPart);
var partNamesStr = bytes === undefined ?
textMsg : String.fromCharCode.apply(null, bytes.subarray(index));
var partNames = partNamesStr.match(/[^\r\n]+/g);
this._map.fire('updateparts', {
commit b9884a470a89fbbcba5b500da62d3e2601299090
Author: Mihai Varga mihai.va...@collabora.com
Date: Tue Jul 21 16:56:02 2015 +0300
loolwsd: be aware of the client's current part
And set lok's part to match the client's when they start editing or
selecting
diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index 58e699e..3294806 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -277,6 +277,7 @@ bool MasterProcessSession::handleInput(const char *buffer,
int length)
tokens[0] != saveas
tokens[0] != selectgraphic
tokens[0] != selecttext
+ tokens[0] != setclientpart
tokens[0] != status
tokens[0] != tile
tokens[0] != uno)
@@ -574,7 +575,8 @@ void MasterProcessSession::forwardToPeer(const char
*buffer, int length)
ChildProcessSession::ChildProcessSession(std::shared_ptrWebSocket ws,
LibreOfficeKit *loKit) :
LOOLSession(ws, Kind::ToMaster),
_loKitDocument(NULL),
-_loKit(loKit)
+_loKit(loKit),
+_clientPart(0)
{
std::cout Util::logPrefix() ChildProcessSession ctor this= this
ws= _ws.get() std::endl;
}
@@ -608,6 +610,10 @@ bool ChildProcessSession::handleInput(const char *buffer,
int length)
sendTextFrame(error: cmd= + tokens[0] + kind=nodocloaded);
return false;
}
+else if (tokens[0] == setclientpart)
+{
+return setClientPart(buffer, length, tokens);
+}
else if (tokens[0] == status)
{
return getStatus(buffer, length);
@@ -630,6 +636,10 @@ bool ChildProcessSession::handleInput(const char *buffer,
int length)
tokens[0] == resetselection ||
tokens[0] == saveas);
+if (_loKitDocument-pClass-getPart(_loKitDocument) != _clientPart)
+{
+_loKitDocument-pClass-setPart(_loKitDocument, _clientPart);
+}
if (tokens[0] == gettextselection)
{
return getTextSelection(buffer, length, tokens);
@@ -1024,4 +1034,14 @@ bool ChildProcessSession::saveAs(const char *buffer, int
length, StringTokenizer
return true;
}
+bool ChildProcessSession::setClientPart(const char *buffer, int length,
StringTokenizer tokens)
+{
+if (tokens.count() 2 ||
+!getTokenInteger(tokens[1], part, _clientPart))
+{
+return false;
+}
+return true;
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/loolwsd/LOOLSession.hpp b/loolwsd/LOOLSession.hpp
index aa3ac25..361f6fb 100644
--- a/loolwsd/LOOLSession.hpp
+++ b/loolwsd/LOOLSession.hpp
@@ -175,10 +175,14 @@ public:
bool selectGraphic(const char *buffer,
[Libreoffice-bugs] [Bug 88329] Document preview under Windows 8.1 does not work [Hard to reproduce]
https://bugs.documentfoundation.org/show_bug.cgi?id=88329 --- Comment #8 from Gordo gordon1dr...@yahoo.com --- Perhaps MS Word is set as the default for odf file type. http://windows.microsoft.com/en-gb/windows-8/choose-programs-windows-uses-default -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/source
vcl/source/control/field2.cxx |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
New commits:
commit f838b4f5495f1e70d005bbb1e991b63409ada5a8
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Tue Jul 21 14:02:59 2015 +0200
avoid 1-past-the-end string access
Change-Id: Ia475ce737c430fab8d019e1b8a762f81897e0847
Reviewed-on: https://gerrit.libreoffice.org/17260
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Eike Rathke er...@redhat.com
diff --git a/vcl/source/control/field2.cxx b/vcl/source/control/field2.cxx
index 3f343b2..c9253f8 100644
--- a/vcl/source/control/field2.cxx
+++ b/vcl/source/control/field2.cxx
@@ -432,15 +432,14 @@ static sal_Int32 ImplPatternRightPos( const OUString
rStr, const OString rEdit
{
// search non-literal successor
sal_Int32 nNewPos = nCursorPos;
-sal_Int32 nTempPos = nNewPos;
-while ( nTempPos rEditMask.getLength() )
+;
+for(sal_Int32 nTempPos = nNewPos+1; nTempPos rEditMask.getLength();
++nTempPos )
{
-if ( rEditMask[nTempPos+1] != EDITMASK_LITERAL )
+if ( rEditMask[nTempPos] != EDITMASK_LITERAL )
{
-nNewPos = nTempPos+1;
+nNewPos = nTempPos;
break;
}
-nTempPos++;
}
ImplPatternMaxPos( rStr, rEditMask, nFormatFlags, bSameMask, nCursorPos,
nNewPos );
return nNewPos;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92832] Writer F5 shortcut brings up duplicate navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=92832 Joel Madero jmadero@gmail.com changed: What|Removed |Added CC||jmadero@gmail.com --- Comment #2 from Joel Madero jmadero@gmail.com --- @ Jiggle Billy I highly recommend you join the UX mailing list as most of the conversations about how the product works happens on that list (and in the IRC chat as well as during their weekly calls). This way your feedback will be direct to those who make the decisions and you'll get their opinions back. http://www.libreoffice.org/get-help/mailing-lists/ webchat.freenode.net/?channels=libreoffice-design -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79750] EDITING: text with less than 100% proportional line height
https://bugs.documentfoundation.org/show_bug.cgi?id=79750 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- --- Comment #6 from Yousuf (Jay) Philips philip...@hotmail.com --- Still present. It wont show up in the 60% paragraph due to bug 92858, but if you set the 80% paragraph to 60%, it will show there. Version: 5.1.0.0.alpha1+ Build ID: 85ce6a2446deb0f4c01604b6188f969603de9b16 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-07-09_02:29:43 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92858] New: Line height not respected
https://bugs.documentfoundation.org/show_bug.cgi?id=92858 Bug ID: 92858 Summary: Line height not respected Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Blocks: 79750 Steps: 1) Open attachment 100367 from bug 79602 2) Look at paragraph which has This is at a 60% proportional line height as it isnt following the 60% line height, though it is set as so. Regression as this works correctly in 4.2.8. Version: 5.1.0.0.alpha1+ Build ID: 85ce6a2446deb0f4c01604b6188f969603de9b16 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-07-09_02:29:43 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79750] EDITING: text with less than 100% proportional line height
https://bugs.documentfoundation.org/show_bug.cgi?id=79750 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Depends on||92858 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 7 commits - fpicker/source icon-themes/breeze icon-themes/galaxy icon-themes/hicontrast icon-themes/human icon-themes
fpicker/source/office/RemoteFilesDialog.cxx | 80
icon-themes/breeze/links.txt|3 +
icon-themes/galaxy/links.txt|3 +
icon-themes/hicontrast/links.txt|4 +
icon-themes/human/links.txt |3 +
icon-themes/tango/links.txt |1
include/svtools/foldertree.hxx |1
include/svtools/svtools.hrc |1
svtools/source/contnr/fileview.src |6 ++
svtools/source/contnr/foldertree.cxx|3 -
svtools/source/dialogs/PlaceEditDialog.cxx |8 ++
11 files changed, 79 insertions(+), 34 deletions(-)
New commits:
commit 0235f0ca7a06a30108de691b26c60ad2040dac48
Author: Szymon KÅos eszka...@gmail.com
Date: Tue Jul 21 16:45:00 2015 +0200
set pointer to Wait while reading url
Change-Id: I3c0786f8fb20df368cc7c03e35deba51d7ebbecd
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index c67e320..bc19740 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -468,6 +468,10 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const
sURL )
}
m_pFileView-EndInplaceEditing( false );
+
+EnableChildPointerOverwrite( true );
+SetPointer( PointerStyle::Wait );
+
eResult = m_pFileView-Initialize( sURL, sFilter, NULL, GetBlackList()
);
if( eResult == eSuccess )
@@ -481,6 +485,9 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const
sURL )
m_bIsConnected = true;
EnableControls();
}
+
+SetPointer( PointerStyle::Arrow );
+EnableChildPointerOverwrite( false );
}
return eResult;
commit 6eb95abd9adeb5ce42a361b4ad8195d1cf8f3159
Author: Szymon KÅos eszka...@gmail.com
Date: Tue Jul 21 15:50:09 2015 +0200
select recently added service
Change-Id: I55a32eef4a5eb3b9f57cf6d1b8f3cba5a9a14c55
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index 4843854..c67e320 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -549,6 +549,7 @@ IMPL_LINK_NOARG ( RemoteFilesDialog, AddServiceHdl )
m_pServices_lb-InsertEntry( sPrefix + newService-GetName() );
m_pServices_lb-SelectEntryPos( m_pServices_lb-GetEntryCount() -
1 );
+SelectServiceHdl( NULL );
m_bIsUpdated = true;
commit 0450e02bcf6de270cd2412cbaa6e8268aa4263de
Author: Szymon KÅos eszka...@gmail.com
Date: Tue Jul 21 15:39:08 2015 +0200
automatically select last used service
Change-Id: Ic66517cd65c28bd7e62e38796cf8580ed31305f7
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index 6dbbc62..4843854 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -323,6 +323,11 @@ short RemoteFilesDialog::Execute()
Show();
AddServiceHdl( NULL );
}
+if( m_pServices_lb-GetEntryCount() 0 )
+{
+Show();
+SelectServiceHdl( NULL );
+}
short nRet = SvtFileDialog_Base::Execute();
commit 469c20de440151707b288a150ff9be62f3922186
Author: Szymon KÅos eszka...@gmail.com
Date: Tue Jul 21 13:28:46 2015 +0200
avoid multiple recursive opening the same url, cleaning
Change-Id: I8a3ae75a64ffcc4879af3e3591b3b433cee1678d
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index d9f0e35..6dbbc62 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -468,7 +468,10 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const
sURL )
if( eResult == eSuccess )
{
m_pPath-SetURL( sURL );
+
+m_pTreeView-SetSelectHdl( Link() );
m_pTreeView-SetTreePath( sURL );
+m_pTreeView-SetSelectHdl( LINK( this, RemoteFilesDialog,
TreeSelectHdl ) );
m_bIsConnected = true;
EnableControls();
@@ -660,24 +663,17 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
IMPL_LINK_NOARG ( RemoteFilesDialog, DoubleClickHdl )
{
-SvTreeListEntry* pEntry = m_pFileView-FirstSelected();
-
-if( pEntry )
+if( m_pFileView-GetSelectionCount() )
{
-SvtContentEntry* pData = static_cast SvtContentEntry* (
pEntry-GetUserData() );
+OUString sURL = m_pFileView-GetCurrentURL();
-if( pData )
+if( ContentIsFolder( sURL ) )
{
-if( pData-mbIsFolder )
-{
-OUString sURL = m_pFileView-GetCurrentURL();
-
-OpenURL( sURL );
-}
-else
-{
-EndDialog( RET_OK );
-}
+
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source
sw/source/core/doc/docnum.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit ffc3876a95f896388fcb65ff7b37b5214d24eb52
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 13:45:52 2015 +0100
test should check that all levels are equal
regression from
commit bf586debd4d8274cff2737f02beac465525328e8
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Sat Feb 21 12:38:54 2015 +0100
Simplify
Change-Id: I09f83b2bab053fcd48fe1a1a4184cc11a4f9d663
(cherry picked from commit 8a01693c79a24006cbe7d8642b97408eb23a1bd9)
Reviewed-on: https://gerrit.libreoffice.org/17233
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Eike Rathke er...@redhat.com
diff --git a/sw/source/core/doc/docnum.cxx b/sw/source/core/doc/docnum.cxx
index f23053b..5340b6e 100644
--- a/sw/source/core/doc/docnum.cxx
+++ b/sw/source/core/doc/docnum.cxx
@@ -654,13 +654,17 @@ static SwTextNode* lcl_FindOutlineNum( const
SwOutlineNodes rOutlNds, OUString
const SwNodeNum rNdNum = *(pNd-GetNum());
SwNumberTree::tNumberVector aLevelVal =
rNdNum.GetNumberVector();
// now compare with the one searched for
+bool bEqual = true;
for( int n = 0; n nLevel; ++n )
{
-if ( aLevelVal[n] == nLevelVal[n] )
+if ( aLevelVal[n] != nLevelVal[n] )
{
-return pNd;
+bEqual = false;
+break;
}
}
+if (bEqual)
+return pNd;
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa
sw/qa/core/data/ww8/pass/CVE-2015-0097-1.doc |binary 1 file changed New commits: commit 6e7f44a50d8b0b4f14771b55ec00f608331cd8aa Author: Caolán McNamara caol...@redhat.com Date: Tue Jul 21 17:15:43 2015 +0100 add testcase for CVE-2015-0097 Change-Id: I794cc4de0fb35dc5471c15873649712f03178817 diff --git a/sw/qa/core/data/ww8/pass/CVE-2015-0097-1.doc b/sw/qa/core/data/ww8/pass/CVE-2015-0097-1.doc new file mode 100644 index 000..7c893da Binary files /dev/null and b/sw/qa/core/data/ww8/pass/CVE-2015-0097-1.doc differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92864] New: Autosave moving the view within a document
https://bugs.documentfoundation.org/show_bug.cgi?id=92864 Bug ID: 92864 Summary: Autosave moving the view within a document Product: LibreOffice Version: 4.4.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephen.meathering...@gmail.com Hi I have found what is, IMO, a bug with LibreOffice Writer. My version is 4.4.2.2 and Build ID 40m0(Build:2). My O/S is 64-bit Ubuntu 15.04, Linux kernel 3.19.0-21-generic. I cannot tell if the problem occurs with other versions of LibreOffice and/or on other O/S'es. The problem is pretty easy to describe and completely reproducible on my system. Let’s say I am editing a large document (it can be ODT or Word format). I make some changes, and scroll to another part of that document (for example, 50+ pages away) preparing to make an edit, but not having clicked in the new location. Then Writer decides it is time to autosave before I can click to set the new insertion point. It autosaves and sends my view in the document back to where the insertion point is, some 50+ pages away from the point I have so carefully scrolled to. I do not believe that autosave should do this, and I certainly cannot see any way to mitigate the problem. Increasing the autosave time will lessen the frequency but that is a trade-off against possible loss of more work if Writer should crash/hang and be unable to recover. Your thoughts? regards Stephen Meatheringham Canberra, Australia -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - extras/source
extras/source/autocorr/lang/sl/DocumentList.xml | 1149 1 file changed, 1149 insertions(+) New commits: commit 10f7980f27cde9d912744ab4ddabc51f7a273eb1 Author: László Németh laszlo.nem...@collabora.com Date: Tue Jul 21 02:19:13 2015 +0200 add Slovenian Emoji shortcodes As a po file, Slovenian translation was in git in time, but not in the requested AutoCorrect XML. Change-Id: I6387ff6388963c1f020c7a82e721fd103153bbea Reviewed-on: https://gerrit.libreoffice.org/17247 Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com Reviewed-by: Martin Srebotnjak mi...@filmsi.net Reviewed-by: Tomaž Vajngerl qui...@gmail.com Tested-by: Tomaž Vajngerl qui...@gmail.com diff --git a/extras/source/autocorr/lang/sl/DocumentList.xml b/extras/source/autocorr/lang/sl/DocumentList.xml index 9762f37..1466fdf 100644 --- a/extras/source/autocorr/lang/sl/DocumentList.xml +++ b/extras/source/autocorr/lang/sl/DocumentList.xml @@ -449,4 +449,1153 @@ block-list:block block-list:abbreviated-name=1/2 block-list:name=½/ block-list:block block-list:abbreviated-name=1/4 block-list:name=¼/ block-list:block block-list:abbreviated-name=3/4 block-list:name=¾/ + block-list:block block-list:abbreviated-name=:_0: block-list:name=â/ + block-list:block block-list:abbreviated-name=:^0: block-list:name=â°/ + block-list:block block-list:abbreviated-name=:100: block-list:name=ð¯/ + block-list:block block-list:abbreviated-name=:10:30: block-list:name=ð¥/ + block-list:block block-list:abbreviated-name=:10: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:11:30: block-list:name=ð¦/ + block-list:block block-list:abbreviated-name=:11: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:12:30: block-list:name=ð§/ + block-list:block block-list:abbreviated-name=:12: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:1/2: block-list:name=½/ + block-list:block block-list:abbreviated-name=:1:30: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:1/3: block-list:name=â / + block-list:block block-list:abbreviated-name=:1/4: block-list:name=¼/ + block-list:block block-list:abbreviated-name=:1/8: block-list:name=â / + block-list:block block-list:abbreviated-name=:_1: block-list:name=â/ + block-list:block block-list:abbreviated-name=:1: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:^1: block-list:name=¹/ + block-list:block block-list:abbreviated-name=:2:30: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:2/3: block-list:name=â / + block-list:block block-list:abbreviated-name=:_2: block-list:name=â/ + block-list:block block-list:abbreviated-name=:!2: block-list:name=â/ + block-list:block block-list:abbreviated-name=:?2: block-list:name=â/ + block-list:block block-list:abbreviated-name=:2: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:^2: block-list:name=²/ + block-list:block block-list:abbreviated-name=:3:30: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:3/4: block-list:name=¾/ + block-list:block block-list:abbreviated-name=:3/8: block-list:name=â / + block-list:block block-list:abbreviated-name=:_3: block-list:name=â/ + block-list:block block-list:abbreviated-name=:3: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:^3: block-list:name=³/ + block-list:block block-list:abbreviated-name=:4:30: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:_4: block-list:name=â/ + block-list:block block-list:abbreviated-name=:4: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:^4: block-list:name=â´/ + block-list:block block-list:abbreviated-name=:5:30: block-list:name=ð / + block-list:block block-list:abbreviated-name=:5/8: block-list:name=â / + block-list:block block-list:abbreviated-name=:_5: block-list:name=â / + block-list:block block-list:abbreviated-name=:5: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:^5: block-list:name=âµ/ + block-list:block block-list:abbreviated-name=:6:30: block-list:name=ð¡/ + block-list:block block-list:abbreviated-name=:_6: block-list:name=â/ + block-list:block block-list:abbreviated-name=:6: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:^6: block-list:name=â¶/ + block-list:block block-list:abbreviated-name=:7:30: block-list:name=ð¢/ + block-list:block block-list:abbreviated-name=:7/8: block-list:name=â / + block-list:block block-list:abbreviated-name=:_7: block-list:name=â/ + block-list:block block-list:abbreviated-name=:7: block-list:name=ð/ + block-list:block block-list:abbreviated-name=:^7: block-list:name=â·/ + block-list:block block-list:abbreviated-name=:8:30: block-list:name=ð£/ + block-list:block block-list:abbreviated-name=:_8: block-list:name=â/ +
[Libreoffice-bugs] [Bug 36822] DRAWING toolbar in WRITER and CALC use different icons from DRAW and IMPRESS
https://bugs.documentfoundation.org/show_bug.cgi?id=36822 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||momonas...@gmail.com Resolution|--- |WORKSFORME --- Comment #9 from Maxim Monastirsky momonas...@gmail.com --- They have the same icons now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc-tiled-rendering' - 2 commits - libreofficekit/source
Rebased ref, commits from common ancestor:
commit 2501f24e42353ae86c3ebcf4b39d493d9a1ca77c
Author: Pranav Kant pran...@gnome.org
Date: Sun Jul 19 23:05:43 2015 +0530
lokdocview: [WIP] Async. request for tile on tile invalidation
Change-Id: I57db9e3adf26996e6e1e105b8b95f53e88e7760f
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 3662f0d..e2568fa 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -520,7 +520,7 @@ setTilesInvalid (LOKDocView* pDocView, const GdkRectangle
rRectangle)
for (int i = aStart.x; i aEnd.x; i++)
for (int j = aStart.y; j aEnd.y; j++)
-priv-m_aTileBuffer.setInvalid(i, j);
+priv-m_aTileBuffer.setInvalid(i, j, priv-m_fZoom);
}
static gboolean
@@ -742,7 +742,7 @@ renderGraphicHandle(LOKDocView* pDocView,
}
static void
-rdcb(GObject* source_object, GAsyncResult* res, gpointer)
+rdcb(GObject* source_object, GAsyncResult*, gpointer)
{
LOKDocView* pDocView = LOK_DOC_VIEW(source_object);
gtk_widget_queue_draw(GTK_WIDGET(pDocView));
diff --git a/libreofficekit/source/gtk/tilebuffer.cxx
b/libreofficekit/source/gtk/tilebuffer.cxx
index 43050c0..d488f8b 100644
--- a/libreofficekit/source/gtk/tilebuffer.cxx
+++ b/libreofficekit/source/gtk/tilebuffer.cxx
@@ -27,7 +27,7 @@ float twipToPixel(float fInput, float zoom)
return fInput / 1440.0f * DPI * zoom;
}
-static void getTileFunc(GTask* task, gpointer source_object, gpointer
task_data, GCancellable*)
+static void getTileFunc(GTask*, gpointer, gpointer task_data, GCancellable*)
{
GdkPixbuf* pPixBuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8,
nTileSizePixels, nTileSizePixels);
GetTileCallbackData* pCallback =
static_castGetTileCallbackData*(task_data);
@@ -96,13 +96,17 @@ void TileBuffer::resetAllTiles()
}
}
-void TileBuffer::setInvalid(int x, int y)
+void TileBuffer::setInvalid(int x, int y, float fZoom)
{
int index = x * m_nWidth + y;
g_info(Setting tile invalid (%d, %d), x, y);
if (m_mTiles.find(index) != m_mTiles.end())
{
m_mTiles[index].valid = false;
+GTask* task = g_task_new(this, NULL, NULL, NULL);
+GetTileCallbackData* pCallback = new GetTileCallbackData(x, y, fZoom,
this);
+g_task_set_task_data(task, pCallback, g_free);
+g_task_run_in_thread(task, getTileFunc);
}
}
@@ -119,33 +123,11 @@ Tile TileBuffer::getTile(int x, int y, float aZoom,
GTask* task)
}
else if(m_mTiles.find(index) == m_mTiles.end())
{
-
-GdkPixbuf* pPixBuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8,
nTileSizePixels, nTileSizePixels);
-if (!pPixBuf)
-{
-g_info (Error allocating memory to pixbuf);
-return m_mTiles[index];
-}
-
-unsigned char* pBuffer = gdk_pixbuf_get_pixels(pPixBuf);
-GdkRectangle aTileRectangle;
-aTileRectangle.x = pixelToTwip(nTileSizePixels, aZoom) * y;
-aTileRectangle.y = pixelToTwip(nTileSizePixels, aZoom) * x;
-
-g_test_timer_start();
-m_pLOKDocument-pClass-paintTile(m_pLOKDocument,
- pBuffer,
- nTileSizePixels, nTileSizePixels,
- aTileRectangle.x, aTileRectangle.y,
- pixelToTwip(nTileSizePixels, aZoom),
- pixelToTwip(nTileSizePixels, aZoom));
-
-double elapsedTime = g_test_timer_elapsed();
-g_info (Rendered (%d, %d) in %f seconds, x, y, elapsedTime);
-
-//create a mapping for it
-m_mTiles[index].setPixbuf(pPixBuf);
-m_mTiles[index].valid = true;
+GetTileCallbackData* pCallback = new GetTileCallbackData(x, y, aZoom,
this);
+g_task_set_task_data(task, pCallback, g_free);
+g_info (running in thread new tile);
+g_task_run_in_thread(task, getTileFunc);
+return m_DummyTile;
}
return m_mTiles[index];
diff --git a/libreofficekit/source/gtk/tilebuffer.hxx
b/libreofficekit/source/gtk/tilebuffer.hxx
index 5204d40..50de72d 100644
--- a/libreofficekit/source/gtk/tilebuffer.hxx
+++ b/libreofficekit/source/gtk/tilebuffer.hxx
@@ -118,7 +118,7 @@ class TileBuffer
@param x the position of tile along x-axis
@param y the position of tile along y-axis
*/
-void setInvalid(int x, int y);
+void setInvalid(int x, int y, float zoom);
/// Contains the reference to the LOK Document that this tile buffer is
for.
commit a6918763ca5603ca2c7371295a07f4701fc40214
Author: Pranav Kant pran...@gnome.org
Date: Sun Jul 19 01:03:56 2015 +0530
WIP: Trying to make paintTile async
Change-Id: I6a1a261709e503a2f286f126f686e23fcdbcf85c
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index
[Libreoffice-bugs] [Bug 92803] Bad quality generated pdf and a very large file sizes
https://bugs.documentfoundation.org/show_bug.cgi?id=92803 m.a.riosv miguelange...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #13 from m.a.riosv miguelange...@libreoffice.org --- Sure it is possible, but indeed perhaps not so easy, apart from locate the proper keys, know which are the possible values. I think must be easy prepare the configuration in another computer, and copy the profile to the server. If I'm not wrong the setting are in the registrymodifications.xcu file that is in the root of user profile, maybe only with copy this file to the server is enough. More information about user profile in: https://wiki.documentfoundation.org/UserProfile -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72932] Dialog with ListBox where multiple selection has been checked doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=72932 --- Comment #6 from Jan Rheinländer jrheinlaen...@users.sourceforge.net --- Bug is still present in LO 4.4.3.2 on Windows 7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92796] [ODF] Writer does not remove unused page background image
https://bugs.documentfoundation.org/show_bug.cgi?id=92796 --- Comment #1 from Olivier Hallot olivier.hal...@documentfoundation.org --- Actually if you add an image background to page and later change the background to a color, the ODT file keep your image background and you have no way in the UI to remove it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Cpp Unit- Query
Hi Bernardo, On Tuesday, 2015-07-21 11:44:04 -0300, Bernardo Sulzbach wrote: This e-mail is not serious, right? It has terrible grammar, fucked up HTML and is simply stupid. Would you please not insult people from this list? Thank you. It looked like a legitimate mail, maybe resulting from a company's formal legal approval process, no matter how silly the content read and may have looked to you. Eike (who's mail agent is configured to not display text/html content-type anyway) -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack pgpK9RVjJhgz0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/chart-sidebar' - 4 commits - chart2/source include/svx svx/source
chart2/source/controller/sidebar/ChartAreaPanel.cxx | 21 -
include/svx/sidebar/AreaPropertyPanelBase.hxx |8
svx/source/sidebar/area/AreaPropertyPanelBase.cxx | 406 ++--
3 files changed, 242 insertions(+), 193 deletions(-)
New commits:
commit 1e81c2c80d552e388ff600cef40c5ca6652e2015
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue Jul 21 19:01:26 2015 +0200
avoid crash with color listbox for now
Change-Id: I36ac6513546961ec8d8d1e9437a8ef88574acbf4
diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
index bf48573..3b94efc 100644
--- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
+++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
@@ -207,7 +207,7 @@ IMPL_LINK(AreaPropertyPanelBase, SelectFillTypeHdl, ListBox
*, pToolBox)
mpLbFillAttr-Hide();
mpToolBoxColor-Show();
const OUString aTmpStr;
-const Color aColor = mpColorItem-GetColorValue();
+const Color aColor = mpColorItem ?
mpColorItem-GetColorValue() : COL_AUTO;
const XFillColorItem aXFillColorItem( aTmpStr, aColor );
// #i122676# change FillStyle and Color in one call
commit 352e5f6a6c797eb0677a24b9cdc7a73306e8e6f6
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue Jul 21 19:01:06 2015 +0200
avoid a crash that occures sometimes
Change-Id: Iccbdfdb8a46b45b76756ff8080757db3770d691c
diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
index 89eb74b..13c4a7c 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
@@ -23,7 +23,9 @@ OUString getCID(css::uno::Referencecss::frame::XModel
xModel)
return OUString();
css::uno::Any aAny = xSelectionSupplier-getSelection();
-assert(aAny.hasValue());
+if (!aAny.hasValue())
+return OUString();
+
OUString aCID;
aAny = aCID;
@@ -94,6 +96,9 @@ void ChartAreaPanel::setFillFloatTransparence(const
XFillFloatTransparenceItem
void ChartAreaPanel::setFillStyle(const XFillStyleItem rItem)
{
css::uno::Referencecss::beans::XPropertySet xPropSet =
getPropSet(mxModel);
+if (!xPropSet.is())
+return;
+
xPropSet-setPropertyValue(FillStyle,
css::uno::makeAny(rItem.GetValue()));
}
@@ -101,6 +106,9 @@ void ChartAreaPanel::setFillStyleAndColor(const
XFillStyleItem* pStyleItem,
const XFillColorItem rColorItem)
{
css::uno::Referencecss::beans::XPropertySet xPropSet =
getPropSet(mxModel);
+if (!xPropSet.is())
+return;
+
if (pStyleItem)
xPropSet-setPropertyValue(FillStyle,
css::uno::makeAny(pStyleItem-GetValue()));
xPropSet-setPropertyValue(Color,
css::uno::makeAny(rColorItem.GetValue()));
@@ -110,6 +118,9 @@ void ChartAreaPanel::setFillStyleAndGradient(const
XFillStyleItem* pStyleItem,
const XFillGradientItem rGradientItem)
{
css::uno::Referencecss::beans::XPropertySet xPropSet =
getPropSet(mxModel);
+if (!xPropSet.is())
+return;
+
if (pStyleItem)
xPropSet-setPropertyValue(FillStyle,
css::uno::makeAny(pStyleItem-GetValue()));
xPropSet-setPropertyValue(GradientName,
css::uno::makeAny(rGradientItem.GetValue()));
@@ -119,6 +130,9 @@ void ChartAreaPanel::setFillStyleAndHatch(const
XFillStyleItem* pStyleItem,
const XFillHatchItem rHatchItem)
{
css::uno::Referencecss::beans::XPropertySet xPropSet =
getPropSet(mxModel);
+if (!xPropSet.is())
+return;
+
if (pStyleItem)
xPropSet-setPropertyValue(FillStyle,
css::uno::makeAny(pStyleItem-GetValue()));
xPropSet-setPropertyValue(HatchName,
css::uno::makeAny(rHatchItem.GetValue()));
@@ -128,6 +142,9 @@ void ChartAreaPanel::setFillStyleAndBitmap(const
XFillStyleItem* pStyleItem,
const XFillBitmapItem rBitmapItem)
{
css::uno::Referencecss::beans::XPropertySet xPropSet =
getPropSet(mxModel);
+if (!xPropSet.is())
+return;
+
if (pStyleItem)
xPropSet-setPropertyValue(FillStyle,
css::uno::makeAny(pStyleItem-GetValue()));
xPropSet-setPropertyValue(FillBitmapName,
css::uno::makeAny(rBitmapItem.GetValue()));
commit 9b679334504dabaeecc60d64f6507cd781b744cf
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue Jul 21 19:00:37 2015 +0200
dispose all children
Change-Id: I96501640bc15836476eaa6ff7784ab299277ced9
diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
index 3319bf5..89eb74b 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
@@ -71,6 +71,8 @@ void ChartAreaPanel::dispose()
{
css::uno::Referencecss::util::XModifyBroadcaster xBroadcaster(mxModel,
[Libreoffice-bugs] [Bug 92859] feature request: Find next button on search loses focus
https://bugs.documentfoundation.org/show_bug.cgi?id=92859 niall.cavan...@ymail.com changed: What|Removed |Added Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87413] cursor placement in case of empty cross reference in a table cell
https://bugs.documentfoundation.org/show_bug.cgi?id=87413 --- Comment #2 from Gordo gordon1dr...@yahoo.com --- Created attachment 117367 -- https://bugs.documentfoundation.org/attachment.cgi?id=117367action=edit example 2 Preconditions: Turn Non-printing Characters on. Turn Field Shadings on. 1. Open example 2 attachment. 2. Tools → Outline Numbering → Change Level 1 Number to “None”. 3. Place cursor after empty cross reference in the first example. Result: Cursor is before reference. 4. Press Backspace. Result: Reference is deleted. 5. Undo deletion. 6. Place cursor after empty cross reference in the first example. Arrow left once and now it is really in front of the reference. 7. Place cursor after empty cross reference in the second example. Result: Cursor is before reference and field shading extends over space before reference. 8. Click on the empty cross reference in the third example. Result: Cursor is moved to the chapter heading “Yet Another Chapter”. Having the period (probably anything) after the empty reference probably allows this to happen. 9. Hover over each empty field. Result: Tooltips display for the first and third field. While all of this is inconsistent behaviour, I do not think there is much of a bug because empty cross references are only ever going to be a temporary state. The user might decide against outline numbering so turns it off and then adjusts the fields to point to the headings instead of numbered paragraphs. The only issue is when the user tries to delete the empty field in the table cell. If the cursor is placed after the field even though it is displayed in front of the field then pressing Delete will (correctly) not delete it. Windows Vista 64 Version: 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92859] New: feature request: Find next button on search loses focus
https://bugs.documentfoundation.org/show_bug.cgi?id=92859 Bug ID: 92859 Summary: feature request: Find next button on search loses focus Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: niall.cavan...@ymail.com Created attachment 117366 -- https://bugs.documentfoundation.org/attachment.cgi?id=117366action=edit odt file containing two screenshots to show cursor focus issue When searching for repeated instances of a target word in the document by clicking on the Find Next down arrow in the Find toolbar, sometimes another formatting toolbar pops in and takes the position under the cursor, causing an inadvertent edit of the document. e.g. while the found text is of Default Style, the cursor remains over the Find Next button as it is pressed repeatedly to cycle through all the matching instances in the document, but if the found text of the next match is of a different format, a new formatting toolbar can get in the way, leaving the cursor hovering over an edit function. My feature request: if the last action was to click find next and the match of the search causes another toolbar to pop in, the cursor should move to stay over the find next button, to prevent accidental editing when multiple clicks are made in quick succession. Examples in attachment are where most found matches were Default Text but then one that is Text Body matches so a Bullets and Numbering toolbar appears where the Find toolbar had been, shifting the Find toolbar upwards, leaving the risk that left clicking without moving the cursor will hit Move down with Subpoints button and cause an edit. First image - note the cursor is primed to press Find Next Second image - cursor now hovers over Move down with Subpoints -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92853] Changeing Textorientation in calc can easily result in systems UI crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92853 --- Comment #1 from thack...@nexgo.de --- Hello Filip, *, could you give us a step-by-step instruction, please? I tried it on Debian Testing AMD64 with LO Version: 5.0.0.3 Build-ID: f79b5ba13f5e6cbad23f8038060e556217e66632 Gebietsschema: de-DE (de_DE.UTF-8) , Version: 5.0.1.0.0+ Build ID: 21be4e095056800fc8869868448e005728d1bb65 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:libreoffice-5-0, Time: 2015-07-21_02:14:15 Locale: de-DE (de_DE.UTF-8) and Version: 5.1.0.0.alpha1+ Build ID: 2fd3560e0815b547ada7d7f6557857fe3c8678ba TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-07-20_23:36:28 Locale: de-DE (de_DE.UTF-8) (all three parallel installed, following the instructions from https://wiki.documentfoundation.org/Installing_in_parallel/Linux), but did not find a possibility to crash LO ... :( What I did: 1. Started Calc 2. inserted Test in A1 3. Opened Format – Cells 4. Clicked on tab Alignment 5. Changed the text orientation to 90° there 6. Hit enter No crash so far :) Did you do something different? Further questions: 1. Which graphics card / driver are you using? Mine is an NVidia GM108M (GeForce 840M), and I am using xserver-xorg-video-nouveau 1:1.0.11-1+b1. 2. Have you enabled GLX in LO / on your system? Mine is neither enabled nor installed. HTH and HAND Thomas. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92380] Style Preview broken some styles in Styles Pane on V5.0
https://bugs.documentfoundation.org/show_bug.cgi?id=92380 --- Comment #28 from David genericinet+libreoffice@gmail.com --- In doing some further testing, it looks like the application needs to be close and re-started for the spacing to be correct when filtering by styles other than hierarchical. This now applies also to version 5.0.1, which now also has the option to disable the preview. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92380] Style Preview broken some styles in Styles Pane on V5.0
https://bugs.documentfoundation.org/show_bug.cgi?id=92380 --- Comment #27 from David genericinet+libreoffice@gmail.com --- The spacing now seems to be correct in 5.1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] libvisio.git: src/lib
src/lib/VSDXMLParserBase.cpp | 42 +-
src/lib/VSDXParser.cpp | 12 ++--
2 files changed, 27 insertions(+), 27 deletions(-)
New commits:
commit 392d2d609d4f9aa1738e30da18385e832da2f379
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date: Tue Jul 21 19:57:36 2015 +0200
Fix dereferencing of uninitialized memory
Change-Id: Ic4d3c56257dec467325edd934c70074b656b31f4
diff --git a/src/lib/VSDXMLParserBase.cpp b/src/lib/VSDXMLParserBase.cpp
index 03fa396..7953d3c 100644
--- a/src/lib/VSDXMLParserBase.cpp
+++ b/src/lib/VSDXMLParserBase.cpp
@@ -31,7 +31,7 @@ libvisio::VSDXMLParserBase::VSDXMLParserBase()
m_currentShapeLevel(0), m_colours(), m_fieldList(), m_shapeList(),
m_currentBinaryData(), m_shapeStack(), m_shapeLevelStack(),
m_isShapeStarted(false), m_isPageStarted(false), m_currentGeometryList(0),
-m_currentGeometryListIndex(MINUS_ONE), m_fonts()
+m_currentGeometryListIndex(MINUS_ONE), m_fonts(), m_watcher(0)
{
initColours();
}
@@ -162,7 +162,7 @@ void
libvisio::VSDXMLParserBase::readGeometry(xmlTextReaderPtr reader)
break;
}
}
- while (((XML_GEOM != tokenId XML_SECTION != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_GEOM != tokenId XML_SECTION != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
m_currentGeometryList-addGeometry(0, level+1, noFill, noLine, noShow);
}
@@ -212,7 +212,7 @@ void
libvisio::VSDXMLParserBase::readMoveTo(xmlTextReaderPtr reader)
break;
}
}
- while (((XML_MOVETO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_MOVETO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
m_currentGeometryList-addMoveTo(ix, level, x, y);
}
@@ -262,7 +262,7 @@ void
libvisio::VSDXMLParserBase::readLineTo(xmlTextReaderPtr reader)
break;
}
}
- while (((XML_LINETO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_LINETO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
m_currentGeometryList-addLineTo(ix, level, x, y);
}
@@ -316,7 +316,7 @@ void libvisio::VSDXMLParserBase::readArcTo(xmlTextReaderPtr
reader)
break;
}
}
- while (((XML_ARCTO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_ARCTO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
m_currentGeometryList-addArcTo(ix, level, x, y, a);
}
@@ -382,7 +382,7 @@ void
libvisio::VSDXMLParserBase::readEllipticalArcTo(xmlTextReaderPtr reader)
break;
}
}
- while (((XML_ELLIPTICALARCTO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_ELLIPTICALARCTO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
m_currentGeometryList-addEllipticalArcTo(ix, level, x, y, a, b, c, d);
}
@@ -448,7 +448,7 @@ void
libvisio::VSDXMLParserBase::readEllipse(xmlTextReaderPtr reader)
break;
}
}
- while (((XML_ELLIPSE != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_ELLIPSE != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
m_currentGeometryList-addEllipse(ix, level, x, y, a, b, c, d);
}
@@ -518,7 +518,7 @@ void
libvisio::VSDXMLParserBase::readNURBSTo(xmlTextReaderPtr reader)
break;
}
}
- while (((XML_NURBSTO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_NURBSTO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
m_currentGeometryList-addNURBSTo(ix, level, x, y, knot, knotPrev, weight,
weightPrev, nurbsData);
@@ -573,7 +573,7 @@ void
libvisio::VSDXMLParserBase::readPolylineTo(xmlTextReaderPtr reader)
break;
}
}
- while (((XML_POLYLINETO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret !m_watcher-isError());
+ while (((XML_POLYLINETO != tokenId XML_ROW != tokenId) ||
XML_READER_TYPE_END_ELEMENT != tokenType) 1 == ret (!m_watcher ||
!m_watcher-isError()));
if (ret == 1)
[Libreoffice-commits] core.git: include/formula sc/source sc/uiconfig
include/formula/grammar.hxx |6 +-
sc/source/core/tool/interpr1.cxx | 14 +++---
sc/source/ui/optdlg/calcoptionsdlg.cxx|4
sc/source/ui/unoobj/confuno.cxx |2 ++
sc/uiconfig/scalc/ui/formulacalculationoptions.ui |1 +
5 files changed, 23 insertions(+), 4 deletions(-)
New commits:
commit abe178814489286aa45dc0799df50e650a78bc9d
Author: Katarina Behrens katarina.behr...@cib.de
Date: Mon Jul 20 22:07:53 2015 +0200
tdf#92256: Introducing CONV_A1_XL_A1 address pseudoconvention
a special case for INDIRECT function interpretation. Does what
OOo used to do, interprets formula using CONV_OOO first, failing
that, tries CONV_XL_A1
Change-Id: I4281ab2bb7164607206c0b8e51f7e63a1fc2db9a
Reviewed-on: https://gerrit.libreoffice.org/17255
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/include/formula/grammar.hxx b/include/formula/grammar.hxx
index 4f6a2bc..618db98 100644
--- a/include/formula/grammar.hxx
+++ b/include/formula/grammar.hxx
@@ -43,7 +43,11 @@ public:
CONV_LOTUS_A1, /* external? 3d? A1.B2 placeholder/ */
-CONV_LAST /* for loops, must always be last */
+CONV_LAST, /* for loops, must always be last */
+
+// not a real address convention, a special case for INDIRECT function
interpretation
+// only - try using CONV_OOO, failing that CONV_XL_A1
+CONV_A1_XL_A1
};
//! CONV_UNSPECIFIED is a negative value!
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index b464da4..31e98b1 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -7036,12 +7036,18 @@ void ScInterpreter::ScIndirect()
// Overwrite the config and try Excel R1C1.
eConv = FormulaGrammar::CONV_XL_R1C1;
}
-const ScAddress::Details aDetails( eConv, aPos );
+
+bool bTryXlA1 = (eConv == FormulaGrammar::CONV_A1_XL_A1);
+
+const ScAddress::Details aDetails( bTryXlA1 ? FormulaGrammar::CONV_OOO
: eConv, aPos );
+const ScAddress::Details aDetailsXlA1( FormulaGrammar::CONV_XL_A1,
aPos );
SCTAB nTab = aPos.Tab();
OUString sRefStr = GetString().getString();
ScRefAddress aRefAd, aRefAd2;
ScAddress::ExternalInfo aExtInfo;
-if (ConvertDoubleRef(pDok, sRefStr, nTab, aRefAd, aRefAd2, aDetails,
aExtInfo))
+if ( ConvertDoubleRef(pDok, sRefStr, nTab, aRefAd, aRefAd2, aDetails,
aExtInfo) ||
+ ( bTryXlA1 ConvertDoubleRef(pDok, sRefStr, nTab, aRefAd,
+aRefAd2, aDetailsXlA1, aExtInfo)
) )
{
if (aExtInfo.mbExternal)
{
@@ -7053,7 +7059,9 @@ void ScInterpreter::ScIndirect()
else
PushDoubleRef( aRefAd, aRefAd2);
}
-else if (ConvertSingleRef(pDok, sRefStr, nTab, aRefAd, aDetails,
aExtInfo))
+else if ( ConvertSingleRef(pDok, sRefStr, nTab, aRefAd, aDetails,
aExtInfo) ||
+ ( bTryXlA1 ConvertSingleRef (pDok, sRefStr, nTab, aRefAd,
+ aDetailsXlA1, aExtInfo) ) )
{
if (aExtInfo.mbExternal)
{
diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx
b/sc/source/ui/optdlg/calcoptionsdlg.cxx
index d49fb65..6f2de0b 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.cxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx
@@ -46,6 +46,8 @@ formula::FormulaGrammar::AddressConvention
toAddressConvention(sal_Int32 nPos)
return formula::FormulaGrammar::CONV_XL_A1;
case 3:
return formula::FormulaGrammar::CONV_XL_R1C1;
+case 4:
+return formula::FormulaGrammar::CONV_A1_XL_A1;
case 0:
default:
;
@@ -64,6 +66,8 @@ sal_Int32 toSelectedItem(
formula::FormulaGrammar::AddressConvention eConv )
return 2;
case formula::FormulaGrammar::CONV_XL_R1C1:
return 3;
+case formula::FormulaGrammar::CONV_A1_XL_A1:
+return 4;
default:
;
}
diff --git a/sc/source/ui/unoobj/confuno.cxx b/sc/source/ui/unoobj/confuno.cxx
index 82f2502..5d0385e 100644
--- a/sc/source/ui/unoobj/confuno.cxx
+++ b/sc/source/ui/unoobj/confuno.cxx
@@ -311,6 +311,7 @@ void SAL_CALL ScDocumentConfiguration::setPropertyValue(
case 0: // CONV_OOO
case 2: // CONV_XL_A1
case 3: // CONV_XL_R1C1
+case 7: // CONV_A1_XL_A1
aCalcConfig.meStringRefAddressSyntax =
static_castformula::FormulaGrammar::AddressConvention( nUno );
break;
default:
@@ -467,6 +468,7 @@ uno::Any SAL_CALL
ScDocumentConfiguration::getPropertyValue( const OUString aPr
Re: Writer: draft layout and hide whitespace [long]
On Tue, Jul 21, 2015 at 4:38 AM, Miklos Vajna vmik...@collabora.co.uk wrote: Hi, I think as long as the hide whitespace option is a new UI option and it's disabled by default, it's rather non-controversal. Please push to gerrit to get code review. :-) Thanks Miklos. Done: https://gerrit.libreoffice.org/#/c/17278 4 commits to make review easier, although the changeset isn't huge. Thanks for reviewers in advance! Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-online-update' - 1823 commits - accessibility/inc accessibility/source android/Bootstrap animations/source avmedia/Library_avmediavlc.mk avmedia/
Rebased ref, commits from common ancestor:
commit 8be5ec39051cc0eb70ec9882a45a95c661f7398f
Author: Jan Holesovsky ke...@collabora.com
Date: Wed Jul 22 07:17:23 2015 +0200
online update: Fix many warnings.
Not all yet, though.
Change-Id: Ic4f0fe3ded31d585faefd8bda8ab87f54b88dc6c
diff --git a/onlineupdate/source/libmar/inc/mozilla/Attributes.h
b/onlineupdate/source/libmar/inc/mozilla/Attributes.h
index b34e7d5..4d38632 100644
--- a/onlineupdate/source/libmar/inc/mozilla/Attributes.h
+++ b/onlineupdate/source/libmar/inc/mozilla/Attributes.h
@@ -83,7 +83,7 @@
#define MOZ_HAVE_NORETURN__attribute__((noreturn))
# endif
#elif defined(__GNUC__)
-# if defined(__GXX_EXPERIMENTAL_CXX0X__) || __cplusplus = 201103L
+# if defined(__GXX_EXPERIMENTAL_CXX0X__) || (defined(__cplusplus)
__cplusplus = 201103L)
#define MOZ_HAVE_CXX11_CONSTEXPR
#if MOZ_GCC_VERSION_AT_LEAST(4, 8, 0)
# define MOZ_HAVE_CXX11_CONSTEXPR_IN_TEMPLATES
diff --git a/onlineupdate/source/libmar/sign/nss_secutil.c
b/onlineupdate/source/libmar/sign/nss_secutil.c
index caa124e..ac8954c 100644
--- a/onlineupdate/source/libmar/sign/nss_secutil.c
+++ b/onlineupdate/source/libmar/sign/nss_secutil.c
@@ -66,6 +66,8 @@ GetPasswordString(void *arg, char *prompt)
char phrase[200] = {'\0'};
int isInputTerminal = isatty(fileno(stdin));
+ (void) arg; (void) prompt; // avoid warnings
+
#ifndef _WINDOWS
if (isInputTerminal) {
input = fopen(consoleName, r);
diff --git a/onlineupdate/source/libmar/src/mar_extract.c
b/onlineupdate/source/libmar/src/mar_extract.c
index f3512e9..af22766 100644
--- a/onlineupdate/source/libmar/src/mar_extract.c
+++ b/onlineupdate/source/libmar/src/mar_extract.c
@@ -40,6 +40,8 @@ static int mar_test_callback(MarFile *mar, const MarItem
*item, void *unused) {
char buf[BLOCKSIZE];
int fd, len, offset = 0;
+ (void) unused; // avoid warnings
+
if (mar_ensure_parent_dir(item-name))
return -1;
diff --git a/onlineupdate/source/libmar/tool/mar.c
b/onlineupdate/source/libmar/tool/mar.c
index 9a961ae..d14690f 100644
--- a/onlineupdate/source/libmar/tool/mar.c
+++ b/onlineupdate/source/libmar/tool/mar.c
@@ -35,12 +35,12 @@ int mar_repackage_and_sign(const char *NSSConfigDir,
const char *src,
const char * dest);
-static void print_version() {
+static void print_version(void) {
printf(Version: %s\n, MOZ_APP_VERSION);
printf(Default Channel ID: %s\n, MAR_CHANNEL_ID);
}
-static void print_usage() {
+static void print_usage(void) {
printf(usage:\n);
printf(Create a MAR file:\n);
printf( mar [-H MARChannelID] [-V ProductVersion] [-C workingDir]
@@ -99,6 +99,8 @@ static void print_usage() {
static int mar_test_callback(MarFile *mar,
const MarItem *item,
void *unused) {
+ (void) mar; (void) unused; // avoid warnings
+
printf(%u\t0%o\t%s\n, item-length, item-flags, item-name);
return 0;
}
diff --git a/onlineupdate/source/libmar/verify/cryptox.h
b/onlineupdate/source/libmar/verify/cryptox.h
index 8b92681..acecae6 100644
--- a/onlineupdate/source/libmar/verify/cryptox.h
+++ b/onlineupdate/source/libmar/verify/cryptox.h
@@ -57,7 +57,7 @@ CryptoX_Result NSS_VerifySignature(VFYContext * const *ctx ,
#define CryptoX_FreeCertificate(cert) \
CERT_DestroyCertificate(*cert)
-#elif MACOSX
+#elif defined(MACOSX)
#define CryptoX_InvalidHandleValue NULL
#define CryptoX_ProviderHandle void*
diff --git a/onlineupdate/source/libmar/verify/mar_verify.c
b/onlineupdate/source/libmar/verify/mar_verify.c
index 954fbbb..c9f715a 100644
--- a/onlineupdate/source/libmar/verify/mar_verify.c
+++ b/onlineupdate/source/libmar/verify/mar_verify.c
@@ -194,7 +194,6 @@ mar_extract_and_verify_signatures_fp(FILE *fp,
CryptoX_ProviderHandle provider,
CryptoX_PublicKey *keys,
uint32_t keyCount) {
- char buf[5] = {0};
uint32_t signatureCount, signatureLen, numVerified = 0;
uint32_t signatureAlgorithmIDs[MAX_SIGNATURES];
int rv = -1;
@@ -346,6 +345,8 @@ mar_verify_signatures_for_fp(FILE *fp,
uint32_t i;
int rv = CryptoX_Error;
+ (void) provider; (void) keys; // avoid warnings
+
memset(signatureHandles, 0, sizeof(signatureHandles));
memset(signatureLengths, 0, sizeof(signatureLengths));
diff --git a/onlineupdate/source/update/common/updatelogging.cxx
b/onlineupdate/source/update/common/updatelogging.cxx
index 9ed8f3e..4044e26 100644
--- a/onlineupdate/source/update/common/updatelogging.cxx
+++ b/onlineupdate/source/update/common/updatelogging.cxx
@@ -18,7 +18,7 @@ UpdateLog::UpdateLog() : logFP(nullptr)
{
}
-void UpdateLog::Init(NS_tchar* sourcePath,
+void UpdateLog::Init(NS_tchar* sourcePathParam,
const NS_tchar* fileName,
const NS_tchar*
[Libreoffice-bugs] [Bug 92856] Incorrect table document formatting created in MS Office
https://bugs.documentfoundation.org/show_bug.cgi?id=92856 --- Comment #3 from bazi...@kombikorm.ru --- Thanks for orkaround. But it's not good for us. Our company have not MS office. Only Libre. We must to ask any our partners to give us odt format, It's sounds quite impossible. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Version|unspecified |4.1.0.4 release Summary|Sidebar interferes with |Position vertical scroll |scrollbar. |bar widget outboard of ||Sidebar Severity|normal |enhancement --- Comment #5 from V Stuart Foote vstuart.fo...@utsa.edu --- Agree with the suggestion to reposition the vertical scroll bar and attach to the outer edge of the frame where it would benefit from activation using its infinite size. I.e. reposition outboard of the current default Sidebar attachment. But IMHO perceive no compelling reason to also reposition Sidebar to left edge of frame. Neither is there a requirement to attach Sidebar to right edge of the LO frame. So, in a practical sense believe the Sidebar's Show/Hide toggle would function equally well if the collapsed position was left of the vertical scroll bar. Its button is not sensitive to the frame edge, and so must be targeted rather than swiped. That works equally well at the frame edge or as suggested inboard of the scroll bar--which as noted can be swiped into focus. A reasonable enhancement. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Version|unspecified |4.1.0.4 release Summary|Sidebar interferes with |Position vertical scroll |scrollbar. |bar widget outboard of ||Sidebar Severity|normal |enhancement --- Comment #5 from V Stuart Foote vstuart.fo...@utsa.edu --- Agree with the suggestion to reposition the vertical scroll bar and attach to the outer edge of the frame where it would benefit from activation using its infinite size. I.e. reposition outboard of the current default Sidebar attachment. But IMHO perceive no compelling reason to also reposition Sidebar to left edge of frame. Neither is there a requirement to attach Sidebar to right edge of the LO frame. So, in a practical sense believe the Sidebar's Show/Hide toggle would function equally well if the collapsed position was left of the vertical scroll bar. Its button is not sensitive to the frame edge, and so must be targeted rather than swiped. That works equally well at the frame edge or as suggested inboard of the scroll bar--which as noted can be swiped into focus. A reasonable enhancement. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92841] FILESAVE: some .xlsx files can't be opened with MS FileFormatConverter or older LibO
https://bugs.documentfoundation.org/show_bug.cgi?id=92841 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Summary|FILESAVE: Some .xlsx files |FILESAVE: some .xlsx files |cannot be opened with MS|can't be opened with MS |FileFormatConverter or |FileFormatConverter or |older LibreOffice. |older LibO --- Comment #2 from tommy27 ba...@quipo.it --- please check the files you uploaded I can open them both on LibO 4.4.5 and 3.4.3 but they look as empty spreadsheets. am I missing something? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc-tiled-rendering' - 2 commits - include/LibreOfficeKit libreofficekit/source
Rebased ref, commits from common ancestor:
commit 61aac257c6e40a05edfe635bb0bee6ffb0c2ed61
Author: Pranav Kant pran...@gnome.org
Date: Sun Jul 19 01:03:56 2015 +0530
lokdocview: Make paintTile() async
Change-Id: I57db9e3adf26996e6e1e105b8b95f53e88e7760f
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 08c8485..3f178b0 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -520,7 +520,7 @@ setTilesInvalid (LOKDocView* pDocView, const GdkRectangle
rRectangle)
for (int i = aStart.x; i aEnd.x; i++)
for (int j = aStart.y; j aEnd.y; j++)
-priv-m_aTileBuffer.setInvalid(i, j);
+priv-m_aTileBuffer.setInvalid(i, j, priv-m_fZoom);
}
static gboolean
@@ -741,6 +741,12 @@ renderGraphicHandle(LOKDocView* pDocView,
}
}
+static void
+renderDocumentCallback(GObject* source_object, GAsyncResult*, gpointer)
+{
+LOKDocView* pDocView = LOK_DOC_VIEW(source_object);
+gtk_widget_queue_draw(GTK_WIDGET(pDocView));
+}
static gboolean
renderDocument(LOKDocView* pDocView, cairo_t* pCairo)
@@ -790,7 +796,9 @@ renderDocument(LOKDocView* pDocView, cairo_t* pCairo)
if (bPaint)
{
-Tile currentTile = priv-m_aTileBuffer.getTile(nRow, nColumn,
priv-m_fZoom);
+GTask* task = g_task_new(pDocView, NULL,
renderDocumentCallback, NULL);
+Tile currentTile = priv-m_aTileBuffer.getTile(nRow, nColumn,
priv-m_fZoom, task);
+
GdkPixbuf* pPixBuf = currentTile.getBuffer();
gdk_cairo_set_source_pixbuf (pCairo, pPixBuf,
twipToPixel(aTileRectangleTwips.x, priv-m_fZoom),
diff --git a/libreofficekit/source/gtk/tilebuffer.cxx
b/libreofficekit/source/gtk/tilebuffer.cxx
index 60aa16f..d488f8b 100644
--- a/libreofficekit/source/gtk/tilebuffer.cxx
+++ b/libreofficekit/source/gtk/tilebuffer.cxx
@@ -27,6 +27,42 @@ float twipToPixel(float fInput, float zoom)
return fInput / 1440.0f * DPI * zoom;
}
+static void getTileFunc(GTask*, gpointer, gpointer task_data, GCancellable*)
+{
+GdkPixbuf* pPixBuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8,
nTileSizePixels, nTileSizePixels);
+GetTileCallbackData* pCallback =
static_castGetTileCallbackData*(task_data);
+TileBuffer* buffer = pCallback-m_pBuffer;
+int index = pCallback-m_nX * buffer-m_nWidth + pCallback-m_nY;
+if (!pPixBuf)
+{
+g_info (Error allocating memory to pixbuf);
+return;
+}
+
+unsigned char* pBuffer = gdk_pixbuf_get_pixels(pPixBuf);
+GdkRectangle aTileRectangle;
+aTileRectangle.x = pixelToTwip(nTileSizePixels, pCallback-m_fZoom) *
pCallback-m_nY;
+aTileRectangle.y = pixelToTwip(nTileSizePixels, pCallback-m_fZoom) *
pCallback-m_nX;
+
+g_test_timer_start();
+buffer-m_pLOKDocument-pClass-paintTile(buffer-m_pLOKDocument,
+ pBuffer,
+ nTileSizePixels, nTileSizePixels,
+ aTileRectangle.x, aTileRectangle.y,
+ pixelToTwip(nTileSizePixels,
pCallback-m_fZoom),
+ pixelToTwip(nTileSizePixels,
pCallback-m_fZoom));
+
+double elapsedTime = g_test_timer_elapsed();
+g_info (Rendered (%d, %d) in %f seconds,
+pCallback-m_nX,
+pCallback-m_nY,
+elapsedTime);
+
+//create a mapping for it
+buffer-m_mTiles[index].setPixbuf(pPixBuf);
+buffer-m_mTiles[index].valid = true;
+}
+
/*
Tile class member functions
@@ -56,55 +92,42 @@ void TileBuffer::resetAllTiles()
std::mapint, Tile::iterator it = m_mTiles.begin();
for (; it != m_mTiles.end(); ++it)
{
-it-second.release();
+it-second.valid = false;
}
-m_mTiles.clear();
}
-void TileBuffer::setInvalid(int x, int y)
+void TileBuffer::setInvalid(int x, int y, float fZoom)
{
int index = x * m_nWidth + y;
g_info(Setting tile invalid (%d, %d), x, y);
if (m_mTiles.find(index) != m_mTiles.end())
{
m_mTiles[index].valid = false;
-m_mTiles[index].release();
-m_mTiles.erase(index);
+GTask* task = g_task_new(this, NULL, NULL, NULL);
+GetTileCallbackData* pCallback = new GetTileCallbackData(x, y, fZoom,
this);
+g_task_set_task_data(task, pCallback, g_free);
+g_task_run_in_thread(task, getTileFunc);
}
}
-Tile TileBuffer::getTile(int x, int y, float aZoom)
+Tile TileBuffer::getTile(int x, int y, float aZoom, GTask* task)
{
int index = x * m_nWidth + y;
-if(m_mTiles.find(index) == m_mTiles.end() || !m_mTiles[index].valid)
-{
-GdkPixbuf* pPixBuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8,
nTileSizePixels, nTileSizePixels);
-
[Libreoffice-bugs] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 --- Comment #6 from Jean-Baptiste Faure jbfa...@libreoffice.org --- This idea to put the scrollbar away from the window it controls, seems strange to me. I think it will be more confusing for all users. If a user prefer to have the sidebar on the left, he can easily configure LO and he have to do that only once. Please let the things as simple as possible. I suggest to close this enhancement request as WontFix or NotABug because it will create a bug. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 --- Comment #6 from Jean-Baptiste Faure jbfa...@libreoffice.org --- This idea to put the scrollbar away from the window it controls, seems strange to me. I think it will be more confusing for all users. If a user prefer to have the sidebar on the left, he can easily configure LO and he have to do that only once. Please let the things as simple as possible. I suggest to close this enhancement request as WontFix or NotABug because it will create a bug. Best regards. JBF -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92725] Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 --- Comment #6 from Steve breez...@yahoo.com --- (In reply to Lionel Elie Mamane from comment #4) (In reply to Steve from comment #2) Corrupted 800+ rows. Thank goodness for backups! Steve, your comment makes me think that maybe you hit a different issue / bug, since you seem to have corrupted *existing* data (*existing* rows), but David and Alex seem to be describing an issue only about *newly* *inserted* rows. Can you please confirm? If you have another bug, please describe it in a new bugzilla entry, and CC the rest of us into it. Thanks! Lionel, my apologies! Bad wording on my part. It does in fact only affect newly inserted rows. Behavior in my database is exactly as noted by Robert in Comment #5, and I can duplicate it with his sample database as well. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks||65138 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=65138 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||92831 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks||65138 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: 2 commits - external/bzip2 onlineupdate/Executable_mar.mk onlineupdate/Executable_updater.mk onlineupdate/source RepositoryExternal.mk
RepositoryExternal.mk |8
external/bzip2/ExternalProject_bzip2.mk | 30
external/bzip2/Makefile | 14
external/bzip2/Module_bzip2.mk| 17
external/bzip2/README |1
external/bzip2/UnpackedTarball_bzip2.mk | 24
onlineupdate/Executable_mar.mk|7
onlineupdate/Executable_updater.mk| 41
onlineupdate/source/libmar/inc/mozilla/Attributes.h |2
onlineupdate/source/libmar/sign/mar_sign.c|4
onlineupdate/source/libmar/sign/nss_secutil.c |6
onlineupdate/source/libmar/src/mar.h |2
onlineupdate/source/libmar/src/mar_create.c |2
onlineupdate/source/libmar/src/mar_extract.c |8
onlineupdate/source/libmar/src/mar_private.h |2
onlineupdate/source/libmar/src/mar_read.c |4
onlineupdate/source/libmar/tool/mar.c | 30
onlineupdate/source/libmar/verify/cryptox.c |4
onlineupdate/source/libmar/verify/cryptox.h |4
onlineupdate/source/libmar/verify/mar_verify.c|5
onlineupdate/source/update/common/readstrings.h |1
onlineupdate/source/update/common/updatehelper.cxx|1
onlineupdate/source/update/common/updatelogging.cxx |8
onlineupdate/source/update/inc/mozilla/Attributes.h |2
onlineupdate/source/update/inc/mozilla/Char16.h | 239
+++
onlineupdate/source/update/inc/mozilla/Move.h | 238
+++
onlineupdate/source/update/inc/mozilla/Pair.h | 219
+++
onlineupdate/source/update/inc/mozilla/UniquePtr.h| 659
+
onlineupdate/source/update/inc/nsAutoRef.h| 670
++
onlineupdate/source/update/inc/nsWindowsHelpers.h | 159 ++
onlineupdate/source/update/src/mar.h |2
onlineupdate/source/update/src/mar_create.c |2
onlineupdate/source/update/src/mar_extract.c |8
onlineupdate/source/update/src/mar_private.h |2
onlineupdate/source/update/src/mar_read.c |4
onlineupdate/source/update/updater/archivereader.cxx |1
onlineupdate/source/update/updater/loaddlls.cxx |3
onlineupdate/source/update/updater/nsWindowsRestart.cxx | 584
onlineupdate/source/update/updater/progressui_gtk.cxx |4
onlineupdate/source/update/updater/progressui_win.cxx |3
onlineupdate/source/update/updater/updater.cxx| 24
onlineupdate/source/update/updater/xpcom/glue/nsVersionComparator.cxx | 19
onlineupdate/source/update/updater/xpcom/glue/nsVersionComparator.h | 14
43 files changed, 2997 insertions(+), 84 deletions(-)
New commits:
commit 8be5ec39051cc0eb70ec9882a45a95c661f7398f
Author: Jan Holesovsky ke...@collabora.com
Date: Wed Jul 22 07:17:23 2015 +0200
online update: Fix many warnings.
Not all yet, though.
Change-Id: Ic4f0fe3ded31d585faefd8bda8ab87f54b88dc6c
diff --git a/onlineupdate/source/libmar/inc/mozilla/Attributes.h
b/onlineupdate/source/libmar/inc/mozilla/Attributes.h
index b34e7d5..4d38632 100644
--- a/onlineupdate/source/libmar/inc/mozilla/Attributes.h
+++ b/onlineupdate/source/libmar/inc/mozilla/Attributes.h
@@ -83,7 +83,7 @@
#define MOZ_HAVE_NORETURN__attribute__((noreturn))
# endif
#elif defined(__GNUC__)
-# if defined(__GXX_EXPERIMENTAL_CXX0X__) || __cplusplus = 201103L
+# if defined(__GXX_EXPERIMENTAL_CXX0X__) || (defined(__cplusplus)
__cplusplus = 201103L)
#define MOZ_HAVE_CXX11_CONSTEXPR
#if MOZ_GCC_VERSION_AT_LEAST(4, 8, 0)
# define MOZ_HAVE_CXX11_CONSTEXPR_IN_TEMPLATES
diff --git a/onlineupdate/source/libmar/sign/nss_secutil.c
b/onlineupdate/source/libmar/sign/nss_secutil.c
index caa124e..ac8954c 100644
--- a/onlineupdate/source/libmar/sign/nss_secutil.c
+++ b/onlineupdate/source/libmar/sign/nss_secutil.c
@@ -66,6 +66,8 @@ GetPasswordString(void *arg, char *prompt)
char phrase[200] = {'\0'};
int isInputTerminal = isatty(fileno(stdin));
+ (void) arg; (void) prompt; // avoid warnings
+
#ifndef _WINDOWS
if (isInputTerminal) {
input = fopen(consoleName, r);
diff --git
[Libreoffice-bugs] [Bug 68274] provide better update mechanism (was: Use Sparkle update with Stable / Beta / Nightly channels to keep users on the latest releases on OS X)
https://bugs.documentfoundation.org/show_bug.cgi?id=68274 --- Comment #24 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Nathan Yee committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b59955bf2124b558147033782bf067a3723e4730 online update tdf#68274: fix --enable-online-update=mar on Windows It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68274] provide better update mechanism (was: Use Sparkle update with Stable / Beta / Nightly channels to keep users on the latest releases on OS X)
https://bugs.documentfoundation.org/show_bug.cgi?id=68274 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA |BSA target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55292] autocorrect does not correct two dashes to en-dash *when dashes are not discreet*
https://bugs.documentfoundation.org/show_bug.cgi?id=55292 --- Comment #78 from tommy27 ba...@quipo.it --- (In reply to vermontpoet from comment #77) ... As long as the wildcards still work, I'm happy. ... ok, so keep using the wildcards if you prefer them. (In reply to vermontpoet from comment #75) ... Accomplished the same thing in 4.x, like this: *.#---#*.--- em-dash *.#--#*. --- en-dash you would obtain the same with: *.---*.--- em-dash *.#--#*. --- en-dash so the # for the em-dash is unnecessary -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92808] Standard position of table toolbar moves search toolbar and hampers searching
https://bugs.documentfoundation.org/show_bug.cgi?id=92808 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Gordo gordon1dr...@yahoo.com --- *** This bug has been marked as a duplicate of bug 55855 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92859] feature request: Find next button on search loses focus
https://bugs.documentfoundation.org/show_bug.cgi?id=92859 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Gordo gordon1dr...@yahoo.com --- *** This bug has been marked as a duplicate of bug 55855 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55855] The position of Find toolbar should stay fixed
https://bugs.documentfoundation.org/show_bug.cgi?id=55855 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added CC||niall.cavan...@ymail.com --- Comment #11 from Gordo gordon1dr...@yahoo.com --- *** Bug 92859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55855] The position of Find toolbar should stay fixed
https://bugs.documentfoundation.org/show_bug.cgi?id=55855 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added CC||tableroc...@web.de --- Comment #12 from Gordo gordon1dr...@yahoo.com --- *** Bug 92808 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92380] Style Preview broken some styles in Styles Pane on V5.0
https://bugs.documentfoundation.org/show_bug.cgi?id=92380 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Priority|high|medium Severity|major |normal --- Comment #29 from V Stuart Foote vstuart.fo...@utsa.edu --- On OS X 10.10.3 en-US with Version: 5.1.0.0.alpha1+ Build ID: ab777c9cecc7377a7bdb0cda2eb26412021c7a73 TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-07-21_00:37:19 Locale: en-US (en.UTF-8) Style preview still poorly rendered above 220% -- sample of the style renders as just an em-dash in the Sidebar content panel. Able to disable display of style preview--bug 91495, so reasonable work around. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92725] Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Hardware|x86-64 (AMD64) |All OS|Linux (All) |All --- Comment #4 from Lionel Elie Mamane lio...@mamane.lu --- (In reply to Steve from comment #2) Corrupted 800+ rows. Thank goodness for backups! Steve, your comment makes me think that maybe you hit a different issue / bug, since you seem to have corrupted *existing* data (*existing* rows), but David and Alex seem to be describing an issue only about *newly* *inserted* rows. Can you please confirm? If you have another bug, please describe it in a new bugzilla entry, and CC the rest of us into it. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Gerrit: Reliability and fidelity of verification results
On Tue, 2015-07-21 at 07:18 -0500, Norbert Thiebaud wrote:
On Tue, Jul 21, 2015 at 1:54 AM, David Ostrovsky d.ostrov...@gmx.de wrote:
On Mon, 2015-07-13 at 16:51 -0500, Norbert Thiebaud wrote:
On Mon, Jul 13, 2015 at 1:51 PM, David Ostrovsky d.ostrov...@gmx.de
wrote:
And your patch 8 would have failed the same way on tb58/tb59/tb60
[...]
The release builder have the so-called 'stale' tool chain.
Just like in real-life and like other platform there is a diversity of
platform and we usually do not drop
support for 'older' platform unless there is an imperative motivation.
I have another discrepancy with verification: [1].
[...]
On patch set 8 of this change, it's issuing -Werror=return-type: [3]
even though the last statement is assert(false);
The last statement is (void) (which is what assert resolve to in non
debug build...
hence the -Werror=return-type
The run you pointed too was not a debug one:
Thanks. It was too early in the morning and I was still sleeping,
obviously.
$ gcc -Wall -c -E foo.cxx
expands to:
int bar() {
((false) ? static_castvoid (0) : __assert_fail (false, foo.cxx,
3, __PRETTY_FUNCTION__));
}
and in release mode (this time correctly) it expands to
$ gcc -Wall -DNDEBUG -c -E foo.cxx
int bar() {
(static_castvoid (0));
}
thus the warning is correct here and Boost 1.59 beta is broken in this
regard.
I hope we don't have other tinderboxes, that are verifying Gerrit
changes in debug mode, so that the breakage above wouldn't be catched,
do we? To catch such subtleties we should multiply verification platform
with 2:
* linux_rel
* linux_dbg
* mac_rel
* mac_dbg
* win_rel
* win_dbg
Oh, wait, in this thread we learned subtle differences between Mac clang
3.5 (Mavericks) and 3.6 (Yosemite), so that it wouldn't hurt to have:
mac_3.5
mac_3.6
and of course we (still?) support old 32 bit architecture on windows, so
we should have these too:
win_32bit
win_64bit
and all these with release|debug permutations. Quite a lot resources,
but we don't care, we should have enough resources for now, right?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 55292] autocorrect does not correct two dashes to en-dash *when dashes are not discreet*
https://bugs.documentfoundation.org/show_bug.cgi?id=55292 --- Comment #75 from vermontp...@gmail.com --- (In reply to tommy27 from comment #74) it seems you did not understand how the :--: really works try adding an autocorrect replacement like #--# to en-dash and try to write super#--#man to see what happens now try to write super:--:man and see the difference... IMHO not the right attitude to comment a fix... if you have a better solution submit a patch Yeah, I didn't even have to bother with LibreOffice50. Accomplished the same thing in 4.x, like this: *.#---#*.--- em-dash *.#--#*. --- en-dash *.:---:*.--- em-dash *.:--:*. --- en-dash Works beautifully. Every time. It appears that all you've done is to spare me the trouble of having to enter the wild card (in autocorrect). In exchange for which, for that one time inconvenience, I now I have to type two extra characters every single time I want an en-dash or em-dash (that I didn't have to type before). So, yeah, I call that inelegant and brute force. But then again, maybe I'm not getting something... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/core/data/ww8/pass/hang-1.doc |binary
sw/source/filter/ww8/ww8par3.cxx|5 ++---
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit e2e6fa5ad5aaa20a9fa8a6d060d9edd241aefd52
Author: Caolán McNamara caol...@redhat.com
Date: Tue Jul 21 17:06:05 2015 +0100
need to check for after reading and before seeking
seeking resets eof, so the IsEof is always false
after the first loop
Change-Id: I2e533f3f9c494566aabb947c05258a770e883b1f
diff --git a/sw/qa/core/data/ww8/pass/hang-1.doc
b/sw/qa/core/data/ww8/pass/hang-1.doc
new file mode 100644
index 000..8d68bbb
Binary files /dev/null and b/sw/qa/core/data/ww8/pass/hang-1.doc differ
diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx
index 2079de6..3db3492 100644
--- a/sw/source/filter/ww8/ww8par3.cxx
+++ b/sw/source/filter/ww8/ww8par3.cxx
@@ -1297,15 +1297,14 @@ WW8ListManager::WW8ListManager(SvStream rSt_,
SwWW8ImplReader rReader_)
{
bOk = false;
-if (rSt.IsEof())
-break;
-
WW8LFO aLFO;
memset(aLFO, 0, sizeof( aLFO ));
rSt.ReadUInt32( aLFO.nIdLst );
rSt.SeekRel( 8 );
rSt.ReadUChar( aLFO.nLfoLvl );
+if (!rSt.good())
+break;
rSt.SeekRel( 3 );
// soviele Overrides existieren
if ((nMaxLevel aLFO.nLfoLvl) || rSt.GetError())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92725] Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 --- Comment #2 from Steve breez...@yahoo.com --- Confirming on Version: 5.0.0.3rc Locale: en-US Win7 SP1 x64 Alex is correct, this is REALLY annoying! Corrupted 800+ rows. Thank goodness for backups! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55292] autocorrect does not correct two dashes to en-dash *when dashes are not discreet*
https://bugs.documentfoundation.org/show_bug.cgi?id=55292 --- Comment #73 from vermontp...@gmail.com --- (In reply to tommy27 from comment #72) the : is not exactly a wildcard you have to digit it in order to see the conversion as Lazlo said, type :--: to have en-dash and :---: to have em-dash this should work in any situation: isolated, beginning of word, end of word, middle of word grab a 5.0.x daily build and test it. at the moment those replacements are available in US and Hungarian autocorrect lists but you may copy in any other languages as well see release notes here: https://wiki.documentfoundation.org/ReleaseNotes/5.0#Emoji_and_in- word_replacement_support Okay, I tried it. Seriously? Guess I'm not impressed...but...congratulations??? An inelegant, brute force solution. Think I'll go back to what I had. Was working very well. I mean, I could have come up with this 10 years ago -- or *--*, or #---#, etc... Or maybe I'm just not getting this... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92861] New: AutoCorrect Options chechboxes do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=92861 Bug ID: 92861 Summary: AutoCorrect Options chechboxes do not work Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@quipo.it Created attachment 117371 -- https://bugs.documentfoundation.org/attachment.cgi?id=117371action=edit screenshot tested under Win8.1 x64 using LibO 5.1.0.0.alpha1+ Build ID: fcdddbd30a8b5cf6a5cc4d2ff28b7d4a20f8ec6b TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-07-20_02:07:48 Locale: en-US (it_IT) STEPS TO REPRODUCE 1- open Writer 2- Tools/AutoCorrect/AutoCorrect/Options menu item 3- select the Options or the Localized Options tab 4- you cannot flag/unflag any of the checkboxes this is an important regression since it works fine in 4.4.5.1 by the way the checkboxes in the Exceptions and Word Completion tabs do work -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92861] AutoCorrect Options checkboxes do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=92861 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Summary|AutoCorrect Options |AutoCorrect Options |chechboxes do not work |checkboxes do not work -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92380] Style Preview broken some styles in Styles Pane on V5.0
https://bugs.documentfoundation.org/show_bug.cgi?id=92380 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Attachment #116961|application/octet-stream|application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source
sw/source/uibase/dbui/mmconfigitem.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4494547e1e17cf3230b8c1a389ed1e82aa6fe32f
Author: Michael Stahl mst...@redhat.com
Date: Tue Jul 21 20:43:12 2015 +0200
sw: speak slowly and clearly so MSVC2012 gets the message
Change-Id: I16ac1ec2e59940fadb53bed71a0306cebb2e8ab7
diff --git a/sw/source/uibase/dbui/mmconfigitem.cxx
b/sw/source/uibase/dbui/mmconfigitem.cxx
index 2a36db3..b2e4aeb 100644
--- a/sw/source/uibase/dbui/mmconfigitem.cxx
+++ b/sw/source/uibase/dbui/mmconfigitem.cxx
@@ -1039,7 +1039,7 @@ uno::Sequenceuno::Any
SwMailMergeConfigItem::GetSelection() const
if(!m_pImpl-xResultSet.is())
GetResultSet();
if(!m_pImpl-xResultSet.is())
-return {};
+return uno::Sequenceuno::Any();
m_pImpl-xResultSet-last();
sal_Int32 nResultSetSize = m_pImpl-xResultSet-getRow()+1;
std::vectoruno::Any vResult;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 87647] Error font rendering with open document with embedded font [Hard to reproduce]
https://bugs.documentfoundation.org/show_bug.cgi?id=87647 --- Comment #19 from Gordo gordon1dr...@yahoo.com --- Created attachment 117368 -- https://bugs.documentfoundation.org/attachment.cgi?id=117368action=edit second doc The second document is no longer available from that website. I did a search and found it on Github and it has the same hash. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55292] autocorrect does not correct two dashes to en-dash *when dashes are not discreet*
https://bugs.documentfoundation.org/show_bug.cgi?id=55292 --- Comment #74 from tommy27 ba...@quipo.it --- it seems you did not understand how the :--: really works try adding an autocorrect replacement like #--# to en-dash and try to write super#--#man to see what happens now try to write super:--:man and see the difference... IMHO not the right attitude to comment a fix... if you have a better solution submit a patch -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92725] Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 --- Comment #5 from rob...@familiegrosskopf.de --- Created attachment 117369 -- https://bugs.documentfoundation.org/attachment.cgi?id=117369action=edit Try to insert new value - will show value of previous record first Could be this is a new feature. Open the attached database. Open the table for editing. Click with the mouse in the new row for forename. There will be shown the content of the previous row. It will be marked and will be overwritable. Click with the mouse in the first row. Then click with the mouse in the new row for forename. There will be shown the content of the first row. It will also be marked and overwritable. Don't know if this feature is a critical feature ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87647] Error font rendering with open document with embedded font [Hard to reproduce]
https://bugs.documentfoundation.org/show_bug.cgi?id=87647 --- Comment #20 from Gordo gordon1dr...@yahoo.com --- Created attachment 117370 -- https://bugs.documentfoundation.org/attachment.cgi?id=117370action=edit screenshot 4.4.4.3 I opened the first doc and then the second doc. I then realised that the second doc is a template and that I had created a new document with it. I closed that and using File - Templates - Manage, I imported the template and then used the Edit function. After it had loaded, the first doc was immediately all higgledy-pigglety. I closed everything and opened the first doc and used the template manager to edit the second doc. It did not happen again. Windows Vista 64 Version: 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 84177] Context menu: “Paste Special” should be combined with “Paste”
https://bugs.documentfoundation.org/show_bug.cgi?id=84177 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Priority|high|medium --- Comment #20 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to Dr. Goddard from comment #19) When doing academic or technical work it is necessary to quote from various sources. Many publications require that a specific font and format be used. This requires the use of paste without formatting be an option. having the: -- edit menu achieved witha right click -- to offer this under Paste Special would greatly improve efficiency. Already implemented for 4.4 and the 5.0 release for bug 62947. There is a Paste, and also a Paste Special combo button with Unformatted text (which receives Default Style formatting when inserted, but can be easily formatted as needed), and the More options button launching a Paste Special dialog. This somewhat related issue is about GUI change to merge Paste Special with a Paste combo button. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92853] Changeing Textorientation in calc can easily result in systems UI crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92853 --- Comment #2 from Filip Mutterer filipmutte...@yandex.ru --- Hi, after you have written it to a field do not hit enter or select another field, just directly change alignment, it doesn't might crash instantly sometimes you can just change it a few times, after the 5. change it will have crashed on my system. I choose from the menu to the right. glxinfo |grep -i opengl OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 970/PCIe/SSE2 OpenGL core profile version string: 4.3.0 NVIDIA 346.72 OpenGL core profile shading language version string: 4.30 NVIDIA via Cg compiler OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.5.0 NVIDIA 346.72 OpenGL shading language version string: 4.50 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: P.S.: Ok this time it crashed while searching for your way how you did it. I have no idea where to search for the error within my system, hints are welcome. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55292] autocorrect does not correct two dashes to en-dash *when dashes are not discreet*
https://bugs.documentfoundation.org/show_bug.cgi?id=55292 --- Comment #76 from tommy27 ba...@quipo.it --- you could also use a mixed approach .*---.* for em-dash (wildcard thing) and :--: for en dash (emoji thing) so you have to type the extra characters for en-dash sequence only what you probably don't have noticed yet is that the wildcard trigger the autocorrect only when you finish a word and type enter, dot or other punctation marks. the emoji immediately trigger the autocorrect even before finishing the word -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92256] INDIRECT function lost interoperabilty with calc documents migrated by OOo3.2.1
https://bugs.documentfoundation.org/show_bug.cgi?id=92256 --- Comment #24 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Katarina Behrens committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=abe178814489286aa45dc0799df50e650a78bc9d tdf#92256: Introducing CONV_A1_XL_A1 address pseudoconvention It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 84177] Context menu: “Paste Special” should be combined with “Paste”
https://bugs.documentfoundation.org/show_bug.cgi?id=84177 Dr. Goddard d_godda...@missouricom.com changed: What|Removed |Added Priority|medium |high Severity|minor |normal --- Comment #19 from Dr. Goddard d_godda...@missouricom.com --- When doing academic or technical work it is necessary to quote from various sources. Many publications require that a specific font and format be used. This requires the use of paste without formatting be an option. having the: -- edit menu achieved witha right click -- to offer this under Paste Special would greatly improve efficiency. This would make LibreOffice Writer and LibreOffice Calc work the same way making for better efficiency and be more efficient than having to: -- find the edit menu and then -- paste special and then -- paste without fomatting -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] libvisio.git: src/lib
src/lib/VSDParser.cpp |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit 23c914ca9e0e913ac4fde07522074f4e1f47b7ee
Author: David Tardon dtar...@redhat.com
Date: Tue Jul 21 21:49:14 2015 +0200
plug a leak
Change-Id: Iece1e905a696df09b75a3a90483f76c52d6396d5
diff --git a/src/lib/VSDParser.cpp b/src/lib/VSDParser.cpp
index 6ce32eb..9bdb7c6 100644
--- a/src/lib/VSDParser.cpp
+++ b/src/lib/VSDParser.cpp
@@ -163,12 +163,9 @@ void libvisio::VSDParser::parseMetaData() try
delete sumaryInfo;
}
- librevenge::RVNGInputStream *docSumaryInfo =
m_container-getSubStreamByName(\005DocumentSummaryInformation);
- if (docSumaryInfo)
- {
-metaData.parse(docSumaryInfo);
-delete docSumaryInfo;
- }
+ RVNGInputStreamPtr_t
docSumaryInfo(m_container-getSubStreamByName(\005DocumentSummaryInformation));
+ if (bool(docSumaryInfo))
+metaData.parse(docSumaryInfo.get());
m_container-seek(0, librevenge::RVNG_SEEK_SET);
metaData.parseTimes(m_container);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92861] AutoCorrect Options checkboxes do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=92861 tommy27 ba...@quipo.it changed: What|Removed |Added Priority|medium |highest CC||nem...@numbertext.org Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] libvisio.git: 2 commits - src/lib
src/lib/VSDParser.cpp | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
New commits:
commit 379749ebfba4dfee2b73696a62d1c87121fbfc3b
Author: David Tardon dtar...@redhat.com
Date: Tue Jul 21 21:59:53 2015 +0200
use shared_ptr here too
Change-Id: I82dbb50a4e75326720f30a2dab8f732e8802b7e4
diff --git a/src/lib/VSDParser.cpp b/src/lib/VSDParser.cpp
index 9a9db15..827ed48 100644
--- a/src/lib/VSDParser.cpp
+++ b/src/lib/VSDParser.cpp
@@ -156,12 +156,9 @@ void libvisio::VSDParser::parseMetaData() try
return;
VSDMetaData metaData;
- librevenge::RVNGInputStream *sumaryInfo =
m_container-getSubStreamByName(\x05SummaryInformation);
- if (sumaryInfo)
- {
-metaData.parse(sumaryInfo);
-delete sumaryInfo;
- }
+ const RVNGInputStreamPtr_t
sumaryInfo(m_container-getSubStreamByName(\x05SummaryInformation));
+ if (bool(sumaryInfo))
+metaData.parse(sumaryInfo.get());
const RVNGInputStreamPtr_t
docSumaryInfo(m_container-getSubStreamByName(\005DocumentSummaryInformation));
if (bool(docSumaryInfo))
commit 889311ab33a0c57d5f1801044f8cd8de7d93af53
Author: David Tardon dtar...@redhat.com
Date: Tue Jul 21 22:00:08 2015 +0200
add const
Change-Id: Ieeef8936cce71f41bc2fbf114bc17739829152e9
diff --git a/src/lib/VSDParser.cpp b/src/lib/VSDParser.cpp
index 9bdb7c6..9a9db15 100644
--- a/src/lib/VSDParser.cpp
+++ b/src/lib/VSDParser.cpp
@@ -163,7 +163,7 @@ void libvisio::VSDParser::parseMetaData() try
delete sumaryInfo;
}
- RVNGInputStreamPtr_t
docSumaryInfo(m_container-getSubStreamByName(\005DocumentSummaryInformation));
+ const RVNGInputStreamPtr_t
docSumaryInfo(m_container-getSubStreamByName(\005DocumentSummaryInformation));
if (bool(docSumaryInfo))
metaData.parse(docSumaryInfo.get());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] libvisio.git: src/lib
src/lib/VDXParser.cpp | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
New commits:
commit a85ef598bb5bd8cb656482354bff0bd857fcc8f9
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date: Tue Jul 21 20:20:25 2015 +0200
Make the conditions the same for VDXParser too
Change-Id: I325e1653250cf8e583a52aea9f2bf6275df9bff1
diff --git a/src/lib/VDXParser.cpp b/src/lib/VDXParser.cpp
index a64c5fc..a409b11 100644
--- a/src/lib/VDXParser.cpp
+++ b/src/lib/VDXParser.cpp
@@ -205,7 +205,7 @@ void libvisio::VDXParser::processXmlNode(xmlTextReaderPtr
reader)
tokenId = getElementToken(reader);
tokenType = xmlTextReaderNodeType(reader);
}
- while ((XML_SOLUTIONXML != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret);
+ while ((XML_SOLUTIONXML != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret (!m_watcher || !m_watcher-isError()));
}
break;
case XML_STYLESHEET:
@@ -352,7 +352,7 @@ void libvisio::VDXParser::readLine(xmlTextReaderPtr reader)
break;
}
}
- while ((XML_LINE != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret);
+ while ((XML_LINE != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret (!m_watcher || !m_watcher-isError()));
if (m_isInStyles)
m_collector-collectLineStyle(level, strokeWidth, colour, linePattern,
startMarker, endMarker, lineCap);
@@ -432,7 +432,7 @@ void
libvisio::VDXParser::readFillAndShadow(xmlTextReaderPtr reader)
break;
}
}
- while ((XML_FILL != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret);
+ while ((XML_FILL != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret (!m_watcher || !m_watcher-isError()));
if (m_isInStyles)
m_collector-collectFillStyle(level, fillColourFG, fillColourBG,
fillPattern, fillFGTransparency,
@@ -472,7 +472,7 @@ void libvisio::VDXParser::readMisc(xmlTextReaderPtr reader)
break;
}
}
- while ((XML_MISC != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret);
+ while ((XML_MISC != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret (!m_watcher || !m_watcher-isError()));
}
void libvisio::VDXParser::readXFormData(xmlTextReaderPtr reader)
@@ -531,7 +531,7 @@ void libvisio::VDXParser::readXFormData(xmlTextReaderPtr
reader)
break;
}
}
- while ((XML_XFORM != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret);
+ while ((XML_XFORM != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret (!m_watcher || !m_watcher-isError()));
}
void libvisio::VDXParser::readTxtXForm(xmlTextReaderPtr reader)
@@ -610,7 +610,7 @@ void libvisio::VDXParser::readTxtXForm(xmlTextReaderPtr
reader)
break;
}
}
- while ((XML_TEXTXFORM != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret);
+ while ((XML_TEXTXFORM != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret (!m_watcher || !m_watcher-isError()));
}
void libvisio::VDXParser::readXForm1D(xmlTextReaderPtr reader)
@@ -665,7 +665,7 @@ void libvisio::VDXParser::readXForm1D(xmlTextReaderPtr
reader)
break;
}
}
- while ((XML_XFORM1D != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret);
+ while ((XML_XFORM1D != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret (!m_watcher || !m_watcher-isError()));
}
void libvisio::VDXParser::readPageProps(xmlTextReaderPtr reader)
@@ -720,7 +720,7 @@ void libvisio::VDXParser::readPageProps(xmlTextReaderPtr
reader)
break;
}
}
- while ((XML_PAGEPROPS != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret);
+ while ((XML_PAGEPROPS != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret (!m_watcher || !m_watcher-isError()));
if (m_isStencilStarted)
{
@@ -763,7 +763,7 @@ void libvisio::VDXParser::readFonts(xmlTextReaderPtr reader)
xmlFree(id);
}
}
- while ((XML_FACENAMES != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret);
+ while ((XML_FACENAMES != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret (!m_watcher || !m_watcher-isError()));
}
void libvisio::VDXParser::readTextBlock(xmlTextReaderPtr reader)
@@ -838,7 +838,7 @@ void libvisio::VDXParser::readTextBlock(xmlTextReaderPtr
reader)
break;
}
}
- while ((XML_TEXTBLOCK != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret);
+ while ((XML_TEXTBLOCK != tokenId || XML_READER_TYPE_END_ELEMENT !=
tokenType) 1 == ret (!m_watcher || !m_watcher-isError()));
if (m_isInStyles)
m_collector-collectTextBlockStyle(level, leftMargin, rightMargin,
topMargin, bottomMargin,
@@ -942,7 +942,7 @@ void libvisio::VDXParser::readForeignInfo(xmlTextReaderPtr
reader)
break;
}
}
- while ((XML_FOREIGN != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType)
1 == ret);
+ while ((XML_FOREIGN != tokenId ||
[Libreoffice-bugs] [Bug 92725] Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Whiteboard||bibisectRequest --- Comment #3 from Lionel Elie Mamane lio...@mamane.lu --- David, Alex, Steve, if one of you could upload an example .odb, and give click-per-click instructions (for someone not familiar with Base), that would be nice, since it would allow QA to bibisect the issue (find the change that introduced the bug, or at least narrow it down to a small range). Or do the bibisect :) https://wiki.documentfoundation.org/QA/Bibisect -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92860] New: Better search and replace
https://bugs.documentfoundation.org/show_bug.cgi?id=92860 Bug ID: 92860 Summary: Better search and replace Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d_godda...@missouricom.com When doing academic or technical work it is necessary to quote from various sources. Many publications require that a specific font and format be used. This requires the use of paste without formatting be an option. having the: -- edit menu achieved witha right click -- to offer this under Paste Special would greatly improve efficiency. :Find as well as find replace need to be able to search for formatting. When quoting various sources that are formatted differently than the required format it is necessary to strip out formatting that violates the standard and replace it with the accepted standard. For instance If the required format must end every sentence with a (period or question mark or and exclamation point) followed by two spaces, then 3 search and replace cycles searching for . or ? or ! followed by a space can then be replaced with the same followed by two spaces. Also when the source is recorded with ascii text in which paragraphs are indented wit a seriws of 5 spaces and no blank line between paragraphs, then searching for a line return followed by 5 spaces can be searched for and replaced with 2 line returns and an indent command. This results in a more powerful searchand replace tool such as microsoft's word processors have offered for more than a decade. The feature is also useful when reformatting text that will be transferred between a word processor and spreadsheet or vice-versa or other venues that do not use the same formatting techniques. It can also be used to change variable names in what will be source code etc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92675] White text background (titles and text from master ) in Impress?
https://bugs.documentfoundation.org/show_bug.cgi?id=92675 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #6 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to Katarina Behrens (CIB) from comment #5) ... newer than 4.3.X and older than 4.4.4 and it can be repaired only manually now. Bug 88056, comment 5 explains how. Think that should have been https://bugs.documentfoundation.org/show_bug.cgi?id=88055#c5 for the manual repair flushing through flat ODF for editing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92856] Incorrect table document formatting created in MS Office
https://bugs.documentfoundation.org/show_bug.cgi?id=92856 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Whiteboard||filter:doc Severity|critical|normal --- Comment #2 from V Stuart Foote vstuart.fo...@utsa.edu --- Certainly not critical. Simply a DOC filter issue. Export from MS Office - .ODT format opens table correctly in LO, so reasonable workaround. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92853] Changeing Textorientation in calc can easily result in systems UI crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92853 --- Comment #3 from Filip Mutterer filipmutte...@yandex.ru --- Disable Hardware Acceleration didn't help! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92777] unable create database file
https://bugs.documentfoundation.org/show_bug.cgi?id=92777 --- Comment #8 from Terrence Enger lo_b...@iseries-guru.com --- And on Windows Vista, LibreOffice ... Version: 5.1.0.0.alpha1+ Build ID: ab777c9cecc7377a7bdb0cda2eb26412021c7a73 TinderBox: Win-x86@39, Branch:master, Time: 2015-07-21_00:37:55 Locale: en-CA (en_CA) I can once again create a database file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Cpp Unit- Query
On Tue, Jul 21, 2015 at 3:15 PM, Adolfo Jayme Barrientos fit...@ubuntu.com wrote: 2015-07-21 9:44 GMT-05:00 Bernardo Sulzbach mafagafogiga...@gmail.com: This e-mail is not serious, right? It has terrible grammar, fucked up HTML and is simply stupid. You didn't even get the fonts (that shouldn't be specified here) right. Dude, don’t be more of an idiot. Exactly. Do your job instead of delegating it to us. No, it’s not our job. In fact, we are not even obligated to respond to your questions (which, by the way, can be solved with a little Googling) here. This is a development list. Adolfo Please, both of you, stop this. for one you are talking over each other, not even responding to the right person. second, no matter how ludicrous the inquiry may sound: either it is troll in which case 'do not feed the troll' or it is just misguided/clumsy in which case feel free to ignore it. In any case it is never appropriate, here, to mock someone attempts in expressing themselves in a foreign language. We use English as a working language, as this is a pragmatic choice... but before denigrating one's fluency in English, think for a second what would be your situation if the working language was German, Chinese or Greek. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: canvas/source
canvas/source/directx/dx_9rm.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 591238e8a4f1164adb51d3bada0cd90c3e7c655e Author: Michael Meeks michael.me...@collabora.com Date: Tue Jul 21 22:18:09 2015 +0100 tdf#91574 - ensure we get paint events to render directx presenter console. This is an odd-one; lots of details in the bug. Change-Id: I287945eba965cc637642e9226c7fe7f2a0754130 diff --git a/canvas/source/directx/dx_9rm.cxx b/canvas/source/directx/dx_9rm.cxx index 63e12b7..42c37ac 100644 --- a/canvas/source/directx/dx_9rm.cxx +++ b/canvas/source/directx/dx_9rm.cxx @@ -680,7 +680,6 @@ namespace dxcanvas mpWindow-SetControlForeground(); mpWindow-SetControlBackground(); -mpWindow-EnablePaint(sal_False); const SystemEnvData *pData = mpWindow-GetSystemData(); const HWND hwnd(reinterpret_castHWND(pData-hWnd)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92675] White text background (titles and text from master ) in Impress?
https://bugs.documentfoundation.org/show_bug.cgi?id=92675 Katarina Behrens (CIB) katarina.behr...@cib.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Katarina Behrens (CIB) katarina.behr...@cib.de --- Yet another victim of bug 88295. Tough luck, your document has been broken^W produced by LibO newer than 4.3.X and older than 4.4.4 and it can be repaired only manually now. Bug 88056, comment 5 explains how. Fix for bug 88295 prevents this from happening in the newly created documents *** This bug has been marked as a duplicate of bug 88295 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92860] Better search and replace
https://bugs.documentfoundation.org/show_bug.cgi?id=92860 m.a.riosv miguelange...@libreoffice.org changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv miguelange...@libreoffice.org --- Have you tried this extension: http://extensions.libreoffice.org/extension-center/alternative-dialog-find-replace-for-writer maybe can cover your needs. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92853] Changeing Textorientation in calc can easily result in systems UI crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92853 --- Comment #4 from Filip Mutterer filipmutte...@yandex.ru --- I am not sure wether i found a solution, but after i changed Icon size and style to small and sifr and both back to auto i didn't get a crash till now. Graphics Output is left back on default. I think i had a similar bug like that in the past, fixing was exactly the same but i do not remember which option, and its long time ago. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92853] Changeing Textorientation in calc can easily result in systems UI crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92853 --- Comment #5 from Filip Mutterer filipmutte...@yandex.ru --- One last check i want to do, i need a checksum from this file: master~2015-07-20_23.36.28_LibreOfficeDev_5.1.0.0.alpha1_Linux_x86-64_deb.tar.gz -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Need help with temporary files
Hi there,
I am working on a bug around saving big file in Writer:
https://bugs.documentfoundation.org/show_bug.cgi?id=88314
The problem seems to be we deflate streams in parallel and run out of memory.
I thought there are temporary files used for deflating since
f92183833fa569006602ac7e93c906d2094e0d4d but I see this:
#2 0xb73c9e13 in __GI_abort () at abort.c:90
#3 0xb73c12c7 in __assert_fail_base (fmt=0xb7509564 %s%s%s:%u:
%s%sAssertion `%s' failed.\n%n,
assertion=assertion@entry=0xb462e257 .L.str31 pBuf
\Possibly Reallocate failed\,
file=file@entry=0xb462df3b .L.str13
/home/matus/git/dbgutil/tools/source/stream/stream.cxx,
line=line@entry=1828,
function=function@entry=0xb462e27c
.L__PRETTY_FUNCTION__._ZN14SvMemoryStream7PutDataEPKvm virtual
sal_Size SvMemoryStream::PutData(const void *, sal_Size)) at
assert.c:92
#4 0xb73c1377 in __GI___assert_fail (assertion=0xb462e257 .L.str31
pBuf \Possibly Reallocate failed\,
file=0xb462df3b .L.str13
/home/matus/git/dbgutil/tools/source/stream/stream.cxx, line=1828,
function=0xb462e27c
.L__PRETTY_FUNCTION__._ZN14SvMemoryStream7PutDataEPKvm virtual
sal_Size SvMemoryStream::PutData(const void *, sal_Size))
at assert.c:101
#5 0xb4614d46 in SvMemoryStream::PutData (this=0x6168b908,
pData=0x61b7f5e8, nCount=0)
at /home/matus/git/dbgutil/tools/source/stream/stream.cxx:1828
#6 0xb460da7a in SvStream::Write (this=0x6168b908, pData=0x61b7f5e8,
nCount=644) at /home/matus/git/dbgutil/tools/source/stream/stream.cxx:1359
#7 0xb437b197 in OTempFileService::writeBytes (this=0x6168b8a8,
aData=uno::Sequence of length 644 = {...})
at /home/matus/git/dbgutil/unotools/source/ucbhelper/xtempfile.cxx:268
#8 0xb437b369 in non-virtual thunk to
OTempFileService::writeBytes(com::sun::star::uno::Sequencesigned
char const) ()
at /home/matus/git/dbgutil/unotools/source/ucbhelper/xtempfile.cxx:272
#9 0xab02a77e in ZipOutputEntry::doDeflate (this=0x61a7e148) at
/home/matus/git/dbgutil/package/source/zipapi/ZipOutputEntry.cxx:180
#10 0xab02a0d6 in ZipOutputEntry::closeEntry (this=0x61a7e148) at
/home/matus/git/dbgutil/package/source/zipapi/ZipOutputEntry.cxx:90
#11 0xab0833eb in deflateZipEntry (pZipEntry=0x61a7e148,
xInStream=uno::Reference to (OInputCompStream *) 0xd56a3b4)
at
/home/matus/git/dbgutil/package/source/zippackage/ZipPackageStream.cxx:456
#12 0xab08b07c in DeflateThread::doWork (this=0x61983c00) at
/home/matus/git/dbgutil/package/source/zippackage/ZipPackageStream.cxx:474
Does that mean css::io::TempFile UNO service I use in
package/source/zipapi/ZipOutputEntry.cxx provides in fact memory
stream?
OTempFileService::OTempFileService has
mpTempFile = new ::utl::TempFile;
and TempFile::GetStream has
if (!aName.isEmpty())
pStream = new SvFileStream(aName, eMode);
else
pStream = new SvMemoryStream(NULL, 0, eMode);
Should we fix that?
And/Or is there another way to get file stream?
package/ does not have many dependencies, so I would not like to
introduce some new.
Thanks,
All the best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Cpp Unit- Query
2015-07-21 15:39 GMT-05:00 Norbert Thiebaud nthieb...@gmail.com: for one you are talking over each other, not even responding to the right person. How embarrassing. I apologize. In any case it is never appropriate, here, to mock someone attempts in expressing themselves in a foreign language. We use English as a working language, as this is a pragmatic choice... but before denigrating one's fluency in English, think for a second what would be your situation if the working language was German, Chinese or Greek. I agree with this sentiment. The only stupid situation here is trying to diminish other people’s arguments by nitpicking on language quirks; that’s someting that irritates me. Adolfo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
