[Libreoffice-bugs] [Bug 95866] Sidebar Legend: Legend list does not match the display.
https://bugs.documentfoundation.org/show_bug.cgi?id=95866 Belugachanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Severity|normal |minor --- Comment #15 from Beluga --- NEW per comment 14 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: making cairo mandatory in vcl
Il 19/11/2015 10:23, Caolán McNamara ha scritto: On Mon, 2015-11-16 at 10:53 +0100, Riccardo Magliocchetti wrote: Hi, Il 16/11/2015 10:37, Caolán McNamara ha scritto: On Sat, 2015-11-14 at 17:00 +0100, Riccardo Magliocchetti wrote: Hi Caolàn, all, in [0] and [1] you made cairo mandatory for *nix platforms. This breaks --without-x but that's no big deal, i'll add some specific ifdefery. I have a couple of questions: - is there a plan to kill non cairo rendering? I'd like to yes. The non-cairo text rendering is only used in the svp path at the moment. i.e. basically I'd move the gtk3 use of cairo text rendering down to svp and have it for all svp using platforms, allowing a big piece of code to be deleted and have one text-rendering path instead of two there. Removing that code would make things a bit difficult for --without-x. How does this make things difficult for without-X. It just replaces the existing headless text renderer with one based on cairo ? We should now link against cairo and the system one is usually linked against X11. So i think i'm going to just build the libo shipped one and see how it goes. -- Riccardo Magliocchetti @rmistaken http://menodizero.it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 95850] Page fill with image always saved with option "fit automatically"
https://bugs.documentfoundation.org/show_bug.cgi?id=95850 Belugachanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Beluga --- Thanks! Let's set to WFM again, then. If you would like to continue testing stuff: https://wiki.documentfoundation.org/QA/Triage_For_Beginners -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/glyphy' - vcl/win
vcl/win/source/gdi/winlayout.cxx | 428 --- vcl/win/source/gdi/winlayout.hxx |3 2 files changed, 409 insertions(+), 22 deletions(-) New commits: commit 999d9acdaf349c10dbe9408aa4b4994af241206f Author: Tor LillqvistDate: Thu Nov 19 12:35:30 2015 +0200 Make using GLyphy optional at run-time Change-Id: I7053f16c25f5506d15ebc88f1b0465493dd35077 diff --git a/vcl/win/source/gdi/winlayout.cxx b/vcl/win/source/gdi/winlayout.cxx index 5ae2ce4..ec07be1 100644 --- a/vcl/win/source/gdi/winlayout.cxx +++ b/vcl/win/source/gdi/winlayout.cxx @@ -66,6 +66,27 @@ const int GLYPH_SPACE_RATIO = 8; const int GLYPH_OFFSET_RATIO = GLYPH_SPACE_RATIO * 2; } +struct OpenGLGlyphCacheChunk +{ +WORD mnFirstGlyph; +int mnGlyphCount; +std::vector maLocation; +std::shared_ptr mpTexture; +int mnAscent; +int mnHeight; +bool mbVertical; + +int getExtraSpace() const +{ +return std::max(mnHeight / GLYPH_SPACE_RATIO, 4); +} + +int getExtraOffset() const +{ +return std::max(mnHeight / GLYPH_OFFSET_RATIO, 2); +} +}; + // win32 specific physical font instance class ImplWinFontEntry : public ImplFontEntry { @@ -82,6 +103,7 @@ public: { return maScriptCache; } private: mutable SCRIPT_CACHEmaScriptCache; +std::vector maOpenGLGlyphCache; public: boolInitKashidaHandling( HDC ); @@ -92,6 +114,10 @@ public: GLyphyDemo::demo_atlas_t* mpGLyphyAtlas; GLyphyDemo::demo_font_t* mpGLyphyFont; +boolGlyphIsCached(int nGlyphIndex) const; +boolAddChunkOfGlyphs(int nGlyphIndex, const WinLayout& rLayout, SalGraphics& rGraphics); +const OpenGLGlyphCacheChunk& GetCachedGlyphChunkFor(int nGlyphIndex) const; + private: mutable int mnMinKashidaWidth; mutable int mnMinKashidaGlyph; @@ -100,13 +126,128 @@ private: GLuint ImplWinFontEntry::mnGLyphyProgram = 0; -#if 0 +#ifdef SAL_LOG_INFO -bool ImplWinFontEntry::AddGlyphToCache(WORD nGlyphIndex, const WinLayout& rLayout, SalGraphics& rGraphics) +namespace { + +char ColorFor(COLORREF aColor) +{ +if (aColor == RGB(0xFF, 0xFF, 0xFF)) +return ' '; +else if (aColor == RGB(0x00, 0x00, 0x00)) +return 'X'; + +return '0' + (10*(GetRValue(aColor) + GetGValue(aColor) + GetBValue(aColor))) / (0xFF*3); +} + +void DumpGlyphBitmap(HDC hDC) +{ +HBITMAP hBitmap = static_cast(GetCurrentObject(hDC, OBJ_BITMAP)); +if (hBitmap == NULL) +{ +SAL_WARN("vcl.gdi", "GetCurrentObject failed: " << WindowsErrorString(GetLastError())); +return; +} + +BITMAP aBitmap; +if (!GetObjectW(hBitmap, sizeof(aBitmap), )) +{ +SAL_WARN("vcl.gdi", "GetObjectW failed: " << WindowsErrorString(GetLastError())); +return; +} + +SAL_INFO("vcl.gdi.opengl", "Bitmap " << hBitmap << ": " << aBitmap.bmWidth << "x" << aBitmap.bmHeight << ":"); + +std::ostringstream sLine("\n"); +for (long y = 0; y < aBitmap.bmHeight; y++) +{ +for (long x = 0; x < std::min(75l, aBitmap.bmWidth); x++) +sLine << ColorFor(GetPixel(hDC, x, y)); +if (y < aBitmap.bmHeight - 1) +sLine << "\n"; +} +SAL_INFO("vcl.gdi.opengl", sLine.str()); +} + +} // anonymous namespace + +#endif // SAL_LOG_INFO + +template< typename charT, typename traits > +inline std::basic_ostream & operator <<( +std::basic_ostream & stream, const std::vector& rCache ) +{ +stream << "{"; +for (auto i = rCache.cbegin(); i != rCache.cend(); ++i) +{ +stream << "[" << i->mnFirstGlyph; +if (i->mnGlyphCount > 1) +stream << ".." << (i->mnFirstGlyph + i->mnGlyphCount - 1); +stream << "]"; +if (i+1 != rCache.cend()) +{ +stream << ","; +assert(i->mnFirstGlyph + i->mnGlyphCount <= (i+1)->mnFirstGlyph); +} +} + +return stream << "}"; +} + +bool ImplWinFontEntry::GlyphIsCached(int nGlyphIndex) const { if (nGlyphIndex == DROPPED_OUTGLYPH) return true; +for (size_t i = 0; i < maOpenGLGlyphCache.size(); i++) +if (nGlyphIndex >= maOpenGLGlyphCache[i].mnFirstGlyph && +nGlyphIndex < maOpenGLGlyphCache[i].mnFirstGlyph + maOpenGLGlyphCache[i].mnGlyphCount) +return true; + +return false; +} + +bool ImplWinFontEntry::AddChunkOfGlyphs(int nGlyphIndex, const WinLayout& rLayout, SalGraphics& rGraphics) +{ +const int DEFAULT_CHUNK_SIZE = 20; + +if (nGlyphIndex == DROPPED_OUTGLYPH) +return true; + +SAL_INFO("vcl.gdi.opengl", "this=" << this << " " << nGlyphIndex << " old: " << maOpenGLGlyphCache); + +auto n = maOpenGLGlyphCache.begin(); +while (n != maOpenGLGlyphCache.end() && + nGlyphIndex > n->mnFirstGlyph) +++n; +assert(n ==
Re: Killing obsolete Jenkins builds
By the way, one situation where it is debatable whether all the triggered builds are useful is if you push a series of changes to gerrit, and Jenkins does builds for each of the changes in the series. For me at least, in such a situation it would suffice if Jenkins just only did a build for the topmost change. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 44012] [FORMATTING] Space after paragraph appears as a white stripe, even though background is supposed to be colored
https://bugs.documentfoundation.org/show_bug.cgi?id=44012 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi Severity|normal |minor --- Comment #4 from Beluga --- Still confirmed. Severity minor as workaround exists. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: 66d2b72667792cb18b25805387824d636e2a455c TinderBox: Win-x86@39, Branch:master, Time: 2015-11-18_02:35:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
AW: Killing obsolete Jenkins builds
Maybe this plugin would help, also for the problems Ashod mentioned: https://github.com/banyan/jenkins-ci-skip-plugin It allows to skip Jenkins build by adding [ci skip] to the commit message. Von: LibreOfficeim Auftrag von Stephan Bergmann Gesendet: Donnerstag, 19. November 2015 11:39 An: libreoffice@lists.freedesktop.org Betreff: Re: Killing obsolete Jenkins builds By the way, one situation where it is debatable whether all the triggered builds are useful is if you push a series of changes to gerrit, and Jenkins does builds for each of the changes in the series. For me at least, in such a situation it would suffice if Jenkins just only did a build for the topmost change. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/compat.hxx|9 + compilerplugins/clang/typecheck.hxx |6 +++--- 2 files changed, 12 insertions(+), 3 deletions(-) New commits: commit 4a6268f0d37f377181f972ed307d2a074e8e1b6a Author: Stephan BergmannDate: Thu Nov 19 09:19:30 2015 +0100 Adapt compilerplugins to old Clang versions Change-Id: I91335f1e81e251f0578792517dded9fae239fb61 diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx index 6b14510..0a16a3c 100644 --- a/compilerplugins/clang/compat.hxx +++ b/compilerplugins/clang/compat.hxx @@ -41,6 +41,15 @@ // Compatibility wrapper to abstract over (trivial) changes in the Clang API: namespace compat { +inline bool isLookupContext(clang::DeclContext const & ctxt) { +#if (__clang_major__ == 3 && __clang_minor__ > 7) || __clang_major__ > 3 +return ctxt.isLookupContext(); +#else +return !ctxt.isFunctionOrMethod() +&& ctxt.getDeclKind() != clang::Decl::LinkageSpec; +#endif +} + inline bool isExternCContext(clang::DeclContext const & ctxt) { #if (__clang_major__ == 3 && __clang_minor__ >= 4) || __clang_major__ > 3 return ctxt.isExternCContext(); diff --git a/compilerplugins/clang/typecheck.hxx b/compilerplugins/clang/typecheck.hxx index 6ab8f74..35d4e57 100644 --- a/compilerplugins/clang/typecheck.hxx +++ b/compilerplugins/clang/typecheck.hxx @@ -12,11 +12,11 @@ #include -#include - #include #include +#include "compat.hxx" + namespace loplugin { class NamespaceCheck; @@ -72,7 +72,7 @@ public: TerminalCheck GlobalNamespace() const { return TerminalCheck( context_ != nullptr -&& ((context_->isLookupContext() +&& ((compat::isLookupContext(*context_) ? context_ : context_->getLookupParent()) ->isTranslationUnit())); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 95866] Sidebar Legend: Legend list does not match the display.
https://bugs.documentfoundation.org/show_bug.cgi?id=95866 Belugachanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e6d21d08af14a3e48eb1f9fedf1cb7e4f449a4de Author: Stephan BergmannDate: Thu Nov 19 08:59:08 2015 +0100 Fix Clang version check "clang -E -P /dev/stdin" causes warnings "clang: warning: /dev/stdin: 'linker' input unused" etc. Change-Id: Ia9c18b59b92558e1d959ce31caf38eed101865d3 diff --git a/configure.ac b/configure.ac index b8b6dc9..69d5e83 100644 --- a/configure.ac +++ b/configure.ac @@ -3826,7 +3826,7 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ if test "$COM_IS_CLANG" = TRUE; then AC_MSG_CHECKING([the Clang version]) clang_version=`echo __clang_major__.__clang_minor__.__clang_patchlevel__ | $CC -E -P /dev/stdin` -CLANG_FULL_VERSION=`echo __clang_version__ | $CC -E -P /dev/stdin` +CLANG_FULL_VERSION=`echo __clang_version__ | $CC -E -P -` CLANGVER=`echo $clang_version | $AWK -F. '{ print \$1*1+\$2*100+\$3 }'` AC_MSG_RESULT([Clang $CLANG_FULL_VERSION, $CLANGVER]) AC_DEFINE_UNQUOTED(CLANG_FULL_VERSION,$CLANG_FULL_VERSION) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 95921] Superimposed text and graphics banner above actual document
https://bugs.documentfoundation.org/show_bug.cgi?id=95921 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi OS|All |Mac OS X (All) --- Comment #2 from Beluga --- Not seeing it in the file. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: b216cc1b8096eb60c27f67e8c27b7cd756c75e38 TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-11-12_00:06:20 Locale: fi-FI (fi_FI) 3.5.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95825] video import and play
https://bugs.documentfoundation.org/show_bug.cgi?id=95825 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #4 from raal --- No crash with Version: 5.1.0.0.alpha1+ Build ID: 8bde421ccec9c10fe1382ad68485852889dd4c74, win7 I can play wmv video in presentation. I can insert but not play mp4 video, probably I have not codecs installed. Please could you test it with dev version? You can download it here: http://dev-builds.libreoffice.org/daily/master/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95810] Writer Crashes on Close
https://bugs.documentfoundation.org/show_bug.cgi?id=95810 Belugachanged: What|Removed |Added Priority|medium |high Status|UNCONFIRMED |NEW Ever confirmed|0 |1 OS|Linux (All) |All Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79156] Table cell Numbering per Cell vs. per Table
https://bugs.documentfoundation.org/show_bug.cgi?id=79156 Thibault Mollemanchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #12 from Thibault Molleman --- I just checked and this bug has indeed been fixed Tested on Windows 10 64-bit LO: 5.0.3.2 full specs: http://valid.x86.fr/6vh0d4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83387] FORMATTING: Adjusting line color does not adjust icon color in preview
https://bugs.documentfoundation.org/show_bug.cgi?id=83387 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi Version|4.2.4.2 release |Inherited From OOo --- Comment #4 from Beluga --- Still repro. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: b216cc1b8096eb60c27f67e8c27b7cd756c75e38 TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-11-12_00:06:20 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78779] PDF: Bookmarks not exported as described
https://bugs.documentfoundation.org/show_bug.cgi?id=78779 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi Severity|normal |minor --- Comment #5 from Beluga --- Still repro. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: 66d2b72667792cb18b25805387824d636e2a455c TinderBox: Win-x86@39, Branch:master, Time: 2015-11-18_02:35:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95810] Writer Crashes on Close
https://bugs.documentfoundation.org/show_bug.cgi?id=95810 --- Comment #6 from Beluga--- Created attachment 120651 --> https://bugs.documentfoundation.org/attachment.cgi?id=120651=edit Backtrace of crash on Windows 5.0.3 Suddenly started getting crashes when closing Writer. Compared our traces and it might be the same cause, but not sure. I'll set to NEW anyway. Win 7 Pro 64-bit, Version: 5.0.3.2 (x64) Build ID: e5f16313668ac592c1bfb310f4390624e3dbfb75 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95866] Sidebar Legend: Legend list does not match the display.
https://bugs.documentfoundation.org/show_bug.cgi?id=95866 --- Comment #13 from Junichi Matsukawa--- Created attachment 120652 --> https://bugs.documentfoundation.org/attachment.cgi?id=120652=edit I changed Sidebar LegendPlacement:"Left" - Displayed "Top" I tested again. 1. I changed Sidebar Legend Placement: "Left". 2. Displayed Legend as "Top" on the chart. 3. I clicked 'Format' - 'Legend' on toolbar menue. The Legend was "Left" on context menu. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95544] Writer enable vertical ruler by default
https://bugs.documentfoundation.org/show_bug.cgi?id=95544 raalchanged: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 95544] Writer enable vertical ruler by default
https://bugs.documentfoundation.org/show_bug.cgi?id=95544 raalchanged: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 95908] Can't turn off AutoCorrect globally
https://bugs.documentfoundation.org/show_bug.cgi?id=95908 --- Comment #2 from 2460...@gmail.com --- (In reply to Beluga from comment #1) > Have you unchecked Format - Autocorrect - While typing? > > Set to NEEDINFO. > Change back to UNCONFIRMED, if you had disabled the setting. Change to > RESOLVED INVALID, if you had not disabled it yet and the problem went away. There is no option to turn off Autocorrect in any of these places: Format -> Autocorrect Tools -> Options Tools -> Autocorrect options How am I supposed to turn it off? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/controller/displaymodecontroller.cxx | 71 -- sd/source/ui/controller/displaymodecontroller.hxx | 52 2 files changed, 29 insertions(+), 94 deletions(-) New commits: commit cfaa269832db6243f828e18b012a13967a2937aa Author: Maxim MonastirskyDate: Thu Nov 19 10:45:12 2015 +0200 Further cleanup of 229fc164dc1773484b74eca016863cf68860e81b Change-Id: Iaafc02f7c925c82b6bd7f98dd875028880b8788d diff --git a/sd/source/ui/controller/displaymodecontroller.cxx b/sd/source/ui/controller/displaymodecontroller.cxx index df86795..6a04f9a 100644 --- a/sd/source/ui/controller/displaymodecontroller.cxx +++ b/sd/source/ui/controller/displaymodecontroller.cxx @@ -8,54 +8,46 @@ * */ -#include -#include -#include -#include -#include -#include - -#include - -#include -#include - -#include - -#include -#include +#include #include #include +#include -#include -#include - -#include - -#include "app.hrc" -#include "facreg.hxx" -#include "glob.hrc" #include "strings.hrc" #include "res_bmp.hrc" #include "sdresid.hxx" -#include "pres.hxx" -#include "displaymodecontroller.hxx" -#include "ViewShellBase.hxx" using namespace ::com::sun::star; using namespace ::com::sun::star::uno; -using namespace ::com::sun::star::lang; -using namespace ::com::sun::star::text; using namespace ::com::sun::star::frame; -using namespace ::com::sun::star::drawing; using namespace ::com::sun::star::beans; namespace sd { // Component to select which display mode has to be used. -// Composed of a combobox in the toolbar and a popup menu to select -// the value +// Composed of a dropdown button in the toolbar and a +// popup menu to select the value + +class DisplayModeController : public svt::PopupWindowController +{ +public: +DisplayModeController( const css::uno::Reference< css::uno::XComponentContext >& rxContext ); + +virtual VclPtr createPopupWindow( vcl::Window* pParent ) override; + +// XInitialization +virtual void SAL_CALL initialize( const css::uno::Sequence< css::uno::Any >& aArguments ) +throw ( css::uno::Exception, css::uno::RuntimeException, std::exception ) override; + +// XServiceInfo +virtual OUString SAL_CALL getImplementationName() throw ( css::uno::RuntimeException, std::exception ) override; +virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() throw ( css::uno::RuntimeException, std::exception ) override; + +void setToolboxItemImage( sal_uInt16 nImage ); + +using svt::PopupWindowController::createPopupWindow; +}; class DisplayModeToolbarMenu : public svtools::ToolbarMenu { @@ -63,7 +55,7 @@ public: DisplayModeToolbarMenu( DisplayModeController& rController, const Reference< XFrame >& xFrame, vcl::Window* pParent ); virtual ~DisplayModeToolbarMenu(); -virtual void dispose() SAL_OVERRIDE; +virtual void dispose() override; protected: DECL_LINK_TYPED( SelectToolbarMenuHdl, ToolbarMenu*, void ); @@ -155,8 +147,6 @@ DisplayModeToolbarMenu::DisplayModeToolbarMenu( DisplayModeController& rControll OUString aTitle1( SD_RESSTR( STR_DISPLAYMODE_EDITMODES ) ); OUString aTitle2( SD_RESSTR( STR_DISPLAYMODE_MASTERMODES ) ); -SvtLanguageOptions aLanguageOptions; - SetSelectHdl( LINK( this, DisplayModeToolbarMenu, SelectToolbarMenuHdl ) ); mpDisplayModeSet1 = createEmptyValueSetControl(); @@ -232,14 +222,13 @@ void DisplayModeToolbarMenu::SelectHdl(void * pControl) nImage = mastermodes[mpDisplayModeSet2->GetSelectItemId() - 5 ].mnBmpResId; } -Sequence< PropertyValue > aArgs; if (!sCommandURL.isEmpty()) -mrController.dispatchCommand( sCommandURL, aArgs ); +mrController.dispatchCommand( sCommandURL, Sequence< PropertyValue >() ); mrController.setToolboxItemImage( nImage ); } -DisplayModeController::DisplayModeController( const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& rxContext ) +DisplayModeController::DisplayModeController( const css::uno::Reference< css::uno::XComponentContext >& rxContext ) : svt::PopupWindowController( rxContext, Reference< frame::XFrame >(), OUString() ) { } @@ -294,13 +283,11 @@ Sequence< OUString > SAL_CALL DisplayModeController::getSupportedServiceNames( } - extern "C" SAL_DLLPUBLIC_EXPORT ::com::sun::star::uno::XInterface* SAL_CALL -com_sun_star_comp_sd_DisplayModeController_get_implementation(::com::sun::star::uno::XComponentContext* context, - ::com::sun::star::uno::Sequence const &) +com_sun_star_comp_sd_DisplayModeController_get_implementation( css::uno::XComponentContext* context, + css::uno::Sequence const &) { return cppu::acquire(new sd::DisplayModeController(context)); } - /* vim:set shiftwidth=4 softtabstop=4
[Libreoffice-bugs] [Bug 95924] New: I received a document in Hebrew but it is not right to left
https://bugs.documentfoundation.org/show_bug.cgi?id=95924 Bug ID: 95924 Summary: I received a document in Hebrew but it is not right to left Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: oren...@gmail.com Created attachment 120650 --> https://bugs.documentfoundation.org/attachment.cgi?id=120650=edit Document presented in gmail and Microsoft word as left to right I received the attached document by email, when I open it with libreoffice it is right to left, but when I open it with google preview or microsoft word it is not right to left (It is left to right). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95810] Writer Crashes on Close
https://bugs.documentfoundation.org/show_bug.cgi?id=95810 Stephan Bergmannchanged: What|Removed |Added Attachment #120565|text/x-log |text/plain mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83387] FORMATTING: Adjusting line color does not adjust icon color in preview
https://bugs.documentfoundation.org/show_bug.cgi?id=83387 Belugachanged: What|Removed |Added Whiteboard|BSA |BSA needsDevEval -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94088] FILESAVE: paragraph background colour not saved in HTML file
https://bugs.documentfoundation.org/show_bug.cgi?id=94088 --- Comment #5 from Armin Le Grand--- As I thought - noone adapted the HTML export to the set of FillStyle items now available. It is still using SvxBrushItem. This should give the fallback by stuffing as much from the new representation to the SvxBrushItem (also used for compatibility im/export). I will check why not even that currently is working... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85754] Showing availability of formula in a table cell in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=85754 --- Comment #6 from kompilainenn <79045_79...@mail.ru> --- Created attachment 120653 --> https://bugs.documentfoundation.org/attachment.cgi?id=120653=edit formula in writer table Embodiment -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75532] Incorrect Pdf export of Gradiented drawing object In Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=75532 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #7 from Beluga --- Now the object disappears completely from the PDF. Win 7 Pro 64-bit, Version: 5.0.3.2 (x64) Build ID: e5f16313668ac592c1bfb310f4390624e3dbfb75 Locale: fi-FI (fi_FI) Version: 5.1.0.0.alpha1+ Build ID: 66d2b72667792cb18b25805387824d636e2a455c TinderBox: Win-x86@39, Branch:master, Time: 2015-11-18_02:35:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80636] FILEOPEN: Online image downloaded but not presented
https://bugs.documentfoundation.org/show_bug.cgi?id=80636 Belugachanged: What|Removed |Added Priority|high|medium CC||todven...@suomi24.fi Severity|major |minor --- Comment #11 from Beluga --- Still not rendered. Display > Graphics and objects is enabled. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: 66d2b72667792cb18b25805387824d636e2a455c TinderBox: Win-x86@39, Branch:master, Time: 2015-11-18_02:35:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/opengl/OpenGLContext.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c8a7887846754ee76a5558f4dd1e89994704ea2c Author: Tor LillqvistDate: Thu Nov 19 10:47:29 2015 +0200 Improve SAL_WARN message readability Change-Id: Ia9e1ea7a69e372725a4239fad2630b6f8bcb52e2 diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 0c58120..d7d4313 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -437,7 +437,7 @@ debug_callback(GLenum source, GLenum type, GLuint id, return; SAL_WARN("vcl.opengl", "OpenGL debug message: source: " << getSourceString(source) << ", type: " -<< getTypeString(type) << ", id: " << id << ", severity: " << getSeverityString(severity) << " with message: " << message); +<< getTypeString(type) << ", id: " << id << ", severity: " << getSeverityString(severity) << ", with message: " << message); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 69795] Macros: Copying a cell form one table to another looks different on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=69795 bugs.kde.att...@online.de changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from bugs.kde.att...@online.de --- Dear developers, I am asking myself right now whether it does make a sense to report bugs. Please don't get me wrong. I don't reply to rant. It's been more then two years ago since I reported my bug. If you can't or don't want to fix this bug, that's OK. I can live with that. In this case please close this bug report, otherwise give me a sign. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86845] DIALOG: Hyperlink details not retained between tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=86845 Konstantinchanged: What|Removed |Added CC||chetverikov@mann-schroeder. ||ru Component|Writer |LibreOffice Version|4.4.0.0.beta1 |4.4.6.3 release --- Comment #10 from Konstantin --- Confirmed under LO 4.4.6.3 for Linux. Reproduced not only in Writer and Calc, but in Draw and Impress too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 2 commits - loolwsd/LOOLSession.cpp
loolwsd/LOOLSession.cpp | 43 ++- 1 file changed, 34 insertions(+), 9 deletions(-) New commits: commit 57199a36cdc2ad802f8d7e944e6fc4ae830fab26 Author: Miklos VajnaDate: Thu Nov 19 10:08:48 2015 +0100 loolwsd: route rendering options to initializeForRendering() diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp index a8d814e..efe4cf4 100644 --- a/loolwsd/LOOLSession.cpp +++ b/loolwsd/LOOLSession.cpp @@ -1026,7 +1026,16 @@ bool ChildProcessSession::loadDocument(const char *buffer, int length, StringTok return false; } -_loKitDocument->pClass->initializeForRendering(_loKitDocument, nullptr); +std::string renderingOptions; +if (!_docOptions.empty()) +{ +Poco::JSON::Parser parser; +Poco::Dynamic::Var var = parser.parse(_docOptions); +Poco::JSON::Object::Ptr object = var.extract(); +renderingOptions = object->get("rendering").toString(); +} + +_loKitDocument->pClass->initializeForRendering(_loKitDocument, (renderingOptions.empty() ? nullptr : renderingOptions.c_str())); if ( _docType != "text" && part != -1) { commit 93c0d29c5c41453652055fb793711c743d6ebec7 Author: Miklos Vajna Date: Thu Nov 19 09:29:58 2015 +0100 loolwsd: accept load options in ChildProcessSession::loadDocument() diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp index 41b89f3..a8d814e 100644 --- a/loolwsd/LOOLSession.cpp +++ b/loolwsd/LOOLSession.cpp @@ -682,7 +682,7 @@ void MasterProcessSession::dispatchChild() _peer = childSession; childSession->_peer = shared_from_this(); -std::string loadRequest = "load" + (_loadPart >= 0 ? " part=" + std::to_string(_loadPart) : "") + " url=" + _docURL; +std::string loadRequest = "load" + (_loadPart >= 0 ? " part=" + std::to_string(_loadPart) : "") + " url=" + _docURL + (!_docOptions.empty() ? " options=" + _docOptions : ""); forwardToPeer(loadRequest.c_str(), loadRequest.size()); } @@ -961,21 +961,37 @@ extern "C" bool ChildProcessSession::loadDocument(const char *buffer, int length, StringTokenizer& tokens) { int part = -1; -if (tokens.count() < 2 || tokens.count() > 4) +if (tokens.count() < 2) { sendTextFrame("error: cmd=load kind=syntax"); return false; } -if (tokens.count() > 2 && tokens[2].find("url=") == 0) +// First token is the "load" command itself. +size_t offset = 1; +if (tokens.count() > 2 && tokens[1].find("part=") == 0) { getTokenInteger(tokens[1], "part", part); -_docURL = tokens[2].substr(strlen("url=")); +++offset; +} + +for (size_t i = offset; i < tokens.count(); ++i) +{ +if (tokens[i].find("url=") == 0) +{ +_docURL = tokens[i].substr(strlen("url=")); +++offset; +} +} + +if (tokens.count() > offset) +{ +if (getTokenString(tokens[offset], "options", _docOptions)) +{ +if (tokens.count() > offset + 1) +_docOptions += Poco::cat(std::string(" "), tokens.begin() + offset + 1, tokens.end()); +} } -else if (tokens[1].find("url=") == 0) -_docURL = tokens[1].substr(strlen("url=")); -else -_docURL = tokens[1]; URI aUri; try ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 95850] Page fill with image always saved with option "fit automatically"
https://bugs.documentfoundation.org/show_bug.cgi?id=95850 --- Comment #3 from Beluga--- You can try a daily build of 5.0.4 to see, if it is fixed: http://dev-builds.libreoffice.org/daily/libreoffice-5-0/ 4.4.x will not be receiving any more releases after 4.4.7, which already an extra release. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45771] SVG: Incorrect text size
https://bugs.documentfoundation.org/show_bug.cgi?id=45771 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #13 from Beluga --- Incorrect text size and no shading for the server objects. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: 66d2b72667792cb18b25805387824d636e2a455c TinderBox: Win-x86@39, Branch:master, Time: 2015-11-18_02:35:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41288] undefined: Memory leaks when open, get document text and close document by UNO
https://bugs.documentfoundation.org/show_bug.cgi?id=41288 --- Comment #12 from smonsarr.j...@free.fr --- This is a very old bug that has been around for years and years and was reported many times in OpenOffice long before the advent of LO. I reported https://bz.apache.org/ooo/show_bug.cgi?id=105191 back in 2009 but the bug goes back farther then that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: making cairo mandatory in vcl
On Mon, 2015-11-16 at 10:53 +0100, Riccardo Magliocchetti wrote: > Hi, > > Il 16/11/2015 10:37, Caolán McNamara ha scritto: > > On Sat, 2015-11-14 at 17:00 +0100, Riccardo Magliocchetti wrote: > > > Hi Caolàn, all, > > > > > > in [0] and [1] you made cairo mandatory for *nix platforms. This > > > breaks > > > --without-x but that's no big deal, i'll add some specific > > > ifdefery. > > > I have a couple of questions: > > > - is there a plan to kill non cairo rendering? > > > > I'd like to yes. The non-cairo text rendering is only used in the > > svp path at the moment. i.e. basically I'd move the gtk3 use of > > cairo text rendering down to svp and have it for all svp using > > platforms, allowing a big piece of code to be deleted and have one > > text-rendering path instead of two there. > > Removing that code would make things a bit difficult for --without-x. How does this make things difficult for without-X. It just replaces the existing headless text renderer with one based on cairo ? > If you have cairo, are there any case where you don't want the cairo > canvas? The android case maybe is one, where we just build enough of LibreOffice to render documents to create a viewer, but not a full blown presentation thing. But i don't have any particular options on the cairo canvas thing at this point. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/text/XMLTextFrameContext.cxx | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) New commits: commit de0432a9256188c7b5cd1a83858311e68c890ebf Author: Caolán McNamaraDate: Wed Nov 11 13:34:43 2015 + Incredible slowness and crashes with document with vast num of frame dups it looks like draw:name values are supposed to be unique in ODF, even if it's not spelled out explicitly, since it exists so the frame can be referenced, which sort of implies that it has to be unique, so a document where the values aren't unique can be considered invalid 19.197.10 The draw:name attribute specifies a name by which a element can be referenced. So reject duplicate frames Change-Id: I83f6d72fd969f667f0a8c2c85d2ffeeed672387a diff --git a/xmloff/source/text/XMLTextFrameContext.cxx b/xmloff/source/text/XMLTextFrameContext.cxx index 7df2aa5..2b4727e 100644 --- a/xmloff/source/text/XMLTextFrameContext.cxx +++ b/xmloff/source/text/XMLTextFrameContext.cxx @@ -585,6 +585,7 @@ void XMLTextFrameContext_Impl::Create( bool /*bHRefOrBase64*/ ) (!sName.isEmpty() && sOrigName != sName) ) { OUString sOldName( sName ); + sal_Int32 i = 0; while( xTextImportHelper->HasFrameByName( sName ) ) { @@ -593,8 +594,15 @@ void XMLTextFrameContext_Impl::Create( bool /*bHRefOrBase64*/ ) } xNamed->setName( sName ); if( sName != sOldName ) -xTextImportHelper->GetRenameMap().Add( XML_TEXT_RENAME_TYPE_FRAME, +{ +bool bSuccess = xTextImportHelper->GetRenameMap().Add( XML_TEXT_RENAME_TYPE_FRAME, sOldName, sName ); +if (!bSuccess) +{ +bCreateFailed = true; +return; +} +} } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Killing obsolete Jenkins builds
On 11/18/2015 03:28 PM, Ashod Nakashian wrote: As an aside, the recent drop in average build times (visible from the Jenkins build times list/graph) is something I like to believe is my fault :) The relevant commits were pushed on Sunday last and now there are far more sub 1h builds and the peaks for longer builds are shorter. I like to reduce that average even further by avoiding wasting the machine cycles on irrelevant work. As far as I understand, Jenkins builds for gerrit changes are not complete rebuilds, but are done as incremental builds on top of what previous builds (of typically unrelated gerrit changes) happened to leave behind. That likely makes analysing such build times hard. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 95925] Math programm
https://bugs.documentfoundation.org/show_bug.cgi?id=95925 Maxim Monastirskychanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||momonas...@gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Maxim Monastirsky --- Please download and install the font from http://cgit.freedesktop.org/libreoffice/core/plain/extras/source/truetype/symbol/opens___.ttf?h=libreoffice-4-4-6 *** This bug has been marked as a duplicate of bug 76239 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76239] OpenSymbol font is not retained after an upgrade (work around in comment 16, 32, .. install log in comment 50 )
https://bugs.documentfoundation.org/show_bug.cgi?id=76239 Maxim Monastirskychanged: What|Removed |Added CC||j...@mai-world.de --- Comment #91 from Maxim Monastirsky --- *** Bug 95925 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86845] DIALOG: Hyperlink details not retained between tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=86845 Timurchanged: What|Removed |Added Version|4.4.6.3 release |4.4.0.0.beta1 --- Comment #11 from Timur --- Please don't change version. It says "earliest affected", which is useful info. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95850] Page fill with image always saved with option "fit automatically"
https://bugs.documentfoundation.org/show_bug.cgi?id=95850 --- Comment #4 from Andreas Schlager--- I tested with dev-build ibreoffice-5-0~2015-11-16_13.06.56_LibreOfficeDev_5.0.4.0.0_Linux_x86-64_deb.tar.gz. With this build the problem is solved :-)) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/glyphy' - vcl/source
vcl/source/opengl/OpenGLContext.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8433643c44d3d65c587410caffd607d6cb981ad6 Author: Tor LillqvistDate: Thu Nov 19 10:47:29 2015 +0200 Improve SAL_WARN message readability Change-Id: Ia9e1ea7a69e372725a4239fad2630b6f8bcb52e2 diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 0378ac0..1f5af6f 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -437,7 +437,7 @@ debug_callback(GLenum source, GLenum type, GLuint id, return; SAL_WARN("vcl.opengl", "OpenGL debug message: source: " << getSourceString(source) << ", type: " -<< getTypeString(type) << ", id: " << id << ", severity: " << getSeverityString(severity) << " with message: " << message); +<< getTypeString(type) << ", id: " << id << ", severity: " << getSeverityString(severity) << ", with message: " << message); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 95850] Page fill with image always saved with option "fit automatically"
https://bugs.documentfoundation.org/show_bug.cgi?id=95850 Andreas Schlagerchanged: What|Removed |Added Status|RESOLVED|NEW Version|5.0.0.0.alpha0+ Master |4.4.6.3 release Resolution|WORKSFORME |--- Ever confirmed|0 |1 --- Comment #2 from Andreas Schlager --- I now tested it with stable version 4.4.6.3 - where the bug also appears. I think this is worth to reopen it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/controller/displaymodecontroller.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit db7959eeacf404b661c8ebb903c80e51438c4137 Author: Maxim MonastirskyDate: Thu Nov 19 10:56:47 2015 +0200 Let's see if this fixes Jenkins build Change-Id: I007bc7b30c6f1c52ce2d69c63a43cbe4a11e809c diff --git a/sd/source/ui/controller/displaymodecontroller.cxx b/sd/source/ui/controller/displaymodecontroller.cxx index 6a04f9a..2147682 100644 --- a/sd/source/ui/controller/displaymodecontroller.cxx +++ b/sd/source/ui/controller/displaymodecontroller.cxx @@ -8,6 +8,7 @@ * */ +#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 69795] Macros: Copying a cell form one table to another looks different on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=69795 raalchanged: What|Removed |Added Status|NEEDINFO|NEW --- Comment #9 from raal --- Hello, unfortunatelly there is no predictable time when bugs will be fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 19/ae126bc74da2b149c4dec573b4c264155627db
19/ae126bc74da2b149c4dec573b4c264155627db |1 + 1 file changed, 1 insertion(+) New commits: commit 87ce645b3821746998f614a7230d3b8ef2b37910 Author: Caolán McNamaraDate: Thu Nov 19 09:31:23 2015 + Notes added by 'git notes add' diff --git a/19/ae126bc74da2b149c4dec573b4c264155627db b/19/ae126bc74da2b149c4dec573b4c264155627db new file mode 100644 index 000..8ebbe55 --- /dev/null +++ b/19/ae126bc74da2b149c4dec573b4c264155627db @@ -0,0 +1 @@ +ignore: obsolete ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94945] FORMATTING : Certain personalized number formats are lost when reload spreadsheet, especially dates
https://bugs.documentfoundation.org/show_bug.cgi?id=94945 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #8 from raal --- Andréb, please test with dev version and let us know.. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95924] I received a document in Hebrew but it is not right to left
https://bugs.documentfoundation.org/show_bug.cgi?id=95924 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Please attach printscreens of "good" and "bad" preview. Specify your version of LO. With LO 5.0.2, win7 I see the same as in word2010. Last version you can download here https://www.libreoffice.org/download/libreoffice-fresh/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80581] VIEWING: Vertical zoom factor change different from horizontal one
https://bugs.documentfoundation.org/show_bug.cgi?id=80581 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi Severity|normal |minor --- Comment #3 from Beluga --- Still confirmed. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: 66d2b72667792cb18b25805387824d636e2a455c TinderBox: Win-x86@39, Branch:master, Time: 2015-11-18_02:35:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source xmloff/source
filter/source/msfilter/msdffimp.cxx| 54 +++-- xmloff/source/draw/ximpcustomshape.cxx | 103 +++-- xmloff/source/draw/ximpshap.cxx|8 -- xmloff/source/style/prstylei.cxx | 13 +--- 4 files changed, 28 insertions(+), 150 deletions(-) New commits: commit 49c5b9a98c45cd082e7fa6b6e399c39cd664ed66 Author: Noel GrandinDate: Thu Nov 19 10:37:10 2015 +0200 use comphelper::containerToSequence Change-Id: I223ff4af01ab2da92da0c26d32457204a5008c4a diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx index f637f66..41c1e5a 100644 --- a/filter/source/msfilter/msdffimp.cxx +++ b/filter/source/msfilter/msdffimp.cxx @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include @@ -1532,7 +1533,6 @@ void DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt // creating SdrCustomShapeGeometryItem -typedef uno::Sequence< beans::PropertyValue > PropSeq; typedef std::vector< beans::PropertyValue > PropVec; typedef PropVec::iterator PropVecIter; PropVecIter aIter; @@ -1861,15 +1861,8 @@ void DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt rSet.Put( XSecondaryFillColorItem( OUString(), rManager.MSO_CLR_ToColor( GetPropertyValue( DFF_Prop_c3DExtrusionColor, 0 ), DFF_Prop_c3DExtrusionColor ) ) ); // pushing the whole Extrusion element -const OUString sExtrusion( "Extrusion" ); -PropSeq aExtrusionPropSeq( aExtrusionPropVec.size() ); -aIter = aExtrusionPropVec.begin(); -aEnd = aExtrusionPropVec.end(); -beans::PropertyValue* pExtrusionValues = aExtrusionPropSeq.getArray(); -while ( aIter != aEnd ) -*pExtrusionValues++ = *aIter++; -aProp.Name = sExtrusion; -aProp.Value <<= aExtrusionPropSeq; +aProp.Name = "Extrusion"; +aProp.Value <<= comphelper::containerToSequence(aExtrusionPropVec); aPropVec.push_back( aProp ); } @@ -2088,18 +2081,11 @@ void DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt } if ( !aHandlePropVec.empty() ) { -PropSeq aHandlePropSeq( aHandlePropVec.size() ); -aIter = aHandlePropVec.begin(); -aEnd = aHandlePropVec.end(); -beans::PropertyValue* pHandleValues = aHandlePropSeq.getArray(); -while ( aIter != aEnd ) -*pHandleValues++ = *aIter++; -aHandles[ i ] = aHandlePropSeq; +aHandles[ i ] = comphelper::containerToSequence(aHandlePropVec); } } // pushing the whole Handles element -const OUString sHandles( "Handles" ); -aProp.Name = sHandles; +aProp.Name = "Handles"; aProp.Value <<= aHandles; aPropVec.push_back( aProp ); } @@ -2435,15 +2421,8 @@ void DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt // pushing the whole Path element if ( !aPathPropVec.empty() ) { -const OUString sPath( "Path" ); -PropSeq aPathPropSeq( aPathPropVec.size() ); -aIter = aPathPropVec.begin(); -aEnd = aPathPropVec.end(); -beans::PropertyValue* pPathValues = aPathPropSeq.getArray(); -while ( aIter != aEnd ) -*pPathValues++ = *aIter++; -aProp.Name = sPath; -aProp.Value <<= aPathPropSeq; +aProp.Name = "Path"; +aProp.Value <<= comphelper::containerToSequence(aPathPropVec); aPropVec.push_back( aProp ); } } @@ -2504,15 +2483,8 @@ void DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt aTextPathPropVec.push_back( aProp ); // pushing the whole TextPath element -const OUString sTextPath( "TextPath" ); -PropSeq aTextPathPropSeq( aTextPathPropVec.size() ); -aIter = aTextPathPropVec.begin(); -aEnd = aTextPathPropVec.end(); -beans::PropertyValue* pTextPathValues = aTextPathPropSeq.getArray(); -while ( aIter != aEnd ) -*pTextPathValues++ = *aIter++; -aProp.Name = sTextPath; -aProp.Value <<= aTextPathPropSeq; +aProp.Name = "TextPath"; +aProp.Value <<= comphelper::containerToSequence(aTextPathPropVec); aPropVec.push_back( aProp ); } @@ -2554,13 +2526,7 @@ void DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt } // creating the whole property set -PropSeq aSeq( aPropVec.size() ); -beans::PropertyValue* pValues = aSeq.getArray(); -aIter = aPropVec.begin(); -aEnd = aPropVec.end(); -while (
[Libreoffice-bugs] [Bug 95908] Can't turn off AutoCorrect globally
https://bugs.documentfoundation.org/show_bug.cgi?id=95908 --- Comment #3 from Beluga--- Created attachment 120654 --> https://bugs.documentfoundation.org/attachment.cgi?id=120654=edit Autocorrect while typing Screenshot showing the options. You mean there is no While typing in your menu? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/compat.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 526d2f8eb227bc0dacd755a6c72511adf976 Author: Stephan BergmannDate: Thu Nov 19 10:11:32 2015 +0100 isLookupContext already available in Clang 3.7.0 Change-Id: Ia17a116b1f7605b5a8d572c6a6f4ef64adea8f94 diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx index 0a16a3c..9b352db 100644 --- a/compilerplugins/clang/compat.hxx +++ b/compilerplugins/clang/compat.hxx @@ -42,7 +42,7 @@ namespace compat { inline bool isLookupContext(clang::DeclContext const & ctxt) { -#if (__clang_major__ == 3 && __clang_minor__ > 7) || __clang_major__ > 3 +#if (__clang_major__ == 3 && __clang_minor__ >= 7) || __clang_major__ > 3 return ctxt.isLookupContext(); #else return !ctxt.isFunctionOrMethod() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-commits] core.git: Revert "ToolBox: Remove unused methods"
On 11/18/2015 09:32 PM, Maxim Monastirsky wrote: commit 78214c982e1fab18b9f6c694a3b56c520da1724d Author: Maxim MonastirskyDate: Wed Nov 18 22:26:32 2015 +0200 Revert "ToolBox: Remove unused methods" The ImplLoadRes method *is* used in ToolBox::ToolBox( vcl::Window* pParent, const ResId& rResId ). This change breaks the navigator panel, and therefore the JunitTest_toolkit_unoapi_1 test. This reverts commit 99648095012187ef284d0a9399a8e12878b2a370. By the way, a good way to check whether a function is really unused is to temporarily define it as deleted. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 59913] Java spell checker extension makes Libre Office unusable in Ubuntu with java 7 64 bit
https://bugs.documentfoundation.org/show_bug.cgi?id=59913 Belugachanged: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |NOTOURBUG --- Comment #5 from Beluga --- Zemberek-NLP has been abandoned by its author and no new release of the extension since 2013 Jan. Here is an up-to-date spellchecker: http://extensions.libreoffice.org/extension-center/turkish-spellcheck-dictionary Closing as notourbug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93967] LibreOffice Crash always after try to save
https://bugs.documentfoundation.org/show_bug.cgi?id=93967 --- Comment #29 from raal--- (In reply to spamkutu from comment #0) > Steps to Reproduce: > 1.have 2 documents open first ms xls format second my editing calc. > 2.getting data from xls to calc as once to once colon copy. > 3.its not crash until i try to save calc document but it everytime crashed > 2nd 3rd or 4th save time and i lost my last input. > Actual Results: > its always crash so i could go on very little input so abuse Hello, please could you post xls file too (point 1)? I see only .ods file in attachments. Do you have these two files open in LO or xls file is opened in ms excel? Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95922] Dutch spellcheck in Ubuntu is different than spellcheck in Windows.
https://bugs.documentfoundation.org/show_bug.cgi?id=95922 Adolfo Jaymechanged: What|Removed |Added Summary|Spellcheck in Ubuntu is |Dutch spellcheck in Ubuntu |different than spellcheck |is different than |in Windows. |spellcheck in Windows. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95925] Math programm
https://bugs.documentfoundation.org/show_bug.cgi?id=95925 j...@mai-world.de changed: What|Removed |Added Component|LibreOffice |Formula Editor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95925] New: Math programm
https://bugs.documentfoundation.org/show_bug.cgi?id=95925 Bug ID: 95925 Summary: Math programm Product: LibreOffice Version: 4.4.6.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@mai-world.de Created attachment 120655 --> https://bugs.documentfoundation.org/attachment.cgi?id=120655=edit an example of the bug the math programm in LibreOffice don't work correctly, in this version the signs, don't show correctly -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/glyphy' - vcl/glyphy vcl/inc vcl/Library_vcl.mk vcl/win
vcl/Library_vcl.mk |2 vcl/glyphy/demo.cxx | 19 + vcl/glyphy/demo/demo-atlas.cc | 144 + vcl/glyphy/demo/demo-buffer.cc | 191 vcl/glyphy/demo/demo-font.cc| 333 + vcl/glyphy/demo/demo-shader.cc | 212 + vcl/glyphy/demo/matrix4x4.c | 481 ++ vcl/inc/glyphy/demo.hxx | 21 + vcl/inc/glyphy/demo/demo-atlas-glsl.h | 18 + vcl/inc/glyphy/demo/demo-atlas.h| 54 +++ vcl/inc/glyphy/demo/demo-buffer.h | 64 vcl/inc/glyphy/demo/demo-common.h | 186 +++ vcl/inc/glyphy/demo/demo-font.h | 88 + vcl/inc/glyphy/demo/demo-fshader-glsl.h | 88 + vcl/inc/glyphy/demo/demo-shader.h | 47 +++ vcl/inc/glyphy/demo/demo-vshader-glsl.h | 24 + vcl/inc/glyphy/demo/matrix4x4.h | 107 ++ vcl/win/source/gdi/winlayout.cxx| 499 18 files changed, 2270 insertions(+), 308 deletions(-) New commits: commit c0a43add02690a1bbff57685f28c6a26b1bd74cc Author: Tor LillqvistDate: Thu Nov 19 11:46:03 2015 +0200 Use GLyphy for text on Windows (broken) Work in progress. Produces visible text in some cases, but not nearly all. The text that is visible is roughly in the right place and of the right size, but horribly ugly. Compare to glyphy-demo, which does produce beautiful text, so the problem is not in the GLyphy code but in the way we use it. Include sources from GLyphy's "demo" directory (with only slight modifications to avoid unconditional debug output) and use that "demo" API from vcl. The changes to existing vcl code are all in one place, in the winlayout.cxx file. Change-Id: I69cce5d66db534c6f4c1ab85d520b6090baf8fe0 diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index 61f3cd1..ddefe0f 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -41,6 +41,7 @@ $(eval $(call gb_Library_set_include,vcl,\ $$(INCLUDE) \ -I$(SRCDIR)/vcl/inc \ $(if $(filter WNTGCC,$(OS)$(COM)),-I$(MINGW_SYSROOT)/include/gdiplus) \ + $(if $(filter WNT,$(OS)),-I$(SRCDIR)/vcl/inc/glyphy/demo) \ )) ifeq ($(ENABLE_DBUS),TRUE) @@ -684,6 +685,7 @@ endif ifeq ($(OS),WNT) $(eval $(call gb_Library_add_exception_objects,vcl,\ + vcl/glyphy/demo \ vcl/opengl/win/gdiimpl \ vcl/opengl/win/WinDeviceInfo \ vcl/opengl/win/blocklist_parser \ diff --git a/vcl/glyphy/demo.cxx b/vcl/glyphy/demo.cxx new file mode 100755 index 000..7f4f12a --- /dev/null +++ b/vcl/glyphy/demo.cxx @@ -0,0 +1,19 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include +#include + +namespace GLyphyDemo { +#include "demo/demo-atlas.cc" +#include "demo/demo-buffer.cc" +#include "demo/demo-font.cc" +#include "demo/demo-shader.cc" +#include "demo/matrix4x4.c" +} diff --git a/vcl/glyphy/demo/demo-atlas.cc b/vcl/glyphy/demo/demo-atlas.cc new file mode 100644 index 000..d84da06 --- /dev/null +++ b/vcl/glyphy/demo/demo-atlas.cc @@ -0,0 +1,144 @@ +/* + * Copyright 2012 Google, Inc. All Rights Reserved. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * Google Author(s): Behdad Esfahbod + */ + +#ifdef HAVE_CONFIG_H +#include +#endif + +#include "demo-atlas.h" + + +struct demo_atlas_t { + unsigned int refcount; + + GLuint tex_unit; + GLuint tex_name; + GLuint tex_w; + GLuint tex_h; + GLuint item_w; + GLuint item_h_q; /* height quantum */ + GLuint cursor_x; + GLuint cursor_y; +}; + + +demo_atlas_t * +demo_atlas_create (unsigned int w, + unsigned int h, + unsigned int item_w, + unsigned int item_h_quantum) +{ + TRACE(); + + demo_atlas_t *at = (demo_atlas_t *) calloc (1, sizeof (demo_atlas_t)); + at->refcount = 1; + + glGetIntegerv (GL_ACTIVE_TEXTURE, (GLint *) >tex_unit); + glGenTextures (1, >tex_name); + at->tex_w = w; + at->tex_h = h; + at->item_w = item_w; + at->item_h_q = item_h_quantum; + at->cursor_x = 0; + at->cursor_y = 0; + +
[Libreoffice-bugs] [Bug 95866] Sidebar Legend: Legend list does not match the display.
https://bugs.documentfoundation.org/show_bug.cgi?id=95866 --- Comment #14 from baffclan--- reproduce with Japanese/KeyID UI newest master/Windows 7 Pro. no reproduce en-US UI. Version: 5.1.0.0.alpha1+ (x64) Build ID: 32d4c03cba399ada807b8ec113a3928aa9e3ff7b TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-11-16_23:41:46 Locale: ja-JP (ja_JP) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 3 commits - loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/test
loolwsd/LOOLSession.cpp | 92 +- loolwsd/LOOLSession.hpp |3 + loolwsd/test/data/hide-whitespace.odt |binary loolwsd/test/httpwstest.cpp | 78 4 files changed, 105 insertions(+), 68 deletions(-) New commits: commit 0723a96df74f9d6d6d55aa7315769d01be98fecd Author: Miklos VajnaDate: Thu Nov 19 11:11:47 2015 +0100 HTTPWSTest: share socket init code between tests diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp index 35a4870..c967fff 100644 --- a/loolwsd/test/httpwstest.cpp +++ b/loolwsd/test/httpwstest.cpp @@ -21,6 +21,12 @@ /// Tests the HTTP WebSocket API of loolwsd. The server has to be started manually before running this test. class HTTPWSTest : public CPPUNIT_NS::TestFixture { +Poco::URI _uri; +Poco::Net::HTTPClientSession _session; +Poco::Net::HTTPRequest _request; +Poco::Net::HTTPResponse _response; +Poco::Net::WebSocket _socket; + CPPUNIT_TEST_SUITE(HTTPWSTest); CPPUNIT_TEST(testPaste); CPPUNIT_TEST(testRenderingOptions); @@ -30,35 +36,38 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture void testRenderingOptions(); void sendTextFrame(Poco::Net::WebSocket& socket, const std::string& string); +public: +HTTPWSTest() +: _uri("http://127.0.0.1:; + std::to_string(LOOLWSD::DEFAULT_CLIENT_PORT_NUMBER)), +_session(_uri.getHost(), _uri.getPort()), +_request(Poco::Net::HTTPRequest::HTTP_POST, "/ws"), +_socket(_session, _request, _response) +{ +} }; void HTTPWSTest::testPaste() { // Load a document and make it empty. -Poco::URI uri("http://127.0.0.1:; + std::to_string(LOOLWSD::DEFAULT_CLIENT_PORT_NUMBER)); -Poco::Net::HTTPClientSession session(uri.getHost(), uri.getPort()); -Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_POST, "/ws"); -Poco::Net::HTTPResponse response; -Poco::Net::WebSocket socket(session, request, response); std::string documentPath = TDOC "/hello.odt"; std::string documentURL = "file://" + Poco::Path(documentPath).makeAbsolute().toString(); -sendTextFrame(socket, "load url=" + documentURL); -sendTextFrame(socket, "uno .uno:SelectAll"); -sendTextFrame(socket, "uno .uno:Delete"); +sendTextFrame(_socket, "load url=" + documentURL); +sendTextFrame(_socket, "uno .uno:SelectAll"); +sendTextFrame(_socket, "uno .uno:Delete"); // Paste some text into it. -sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8 data=aaa bbb ccc"); +sendTextFrame(_socket, "paste mimetype=text/plain;charset=utf-8 data=aaa bbb ccc"); // Check if the document contains the pasted text. -sendTextFrame(socket, "uno .uno:SelectAll"); -sendTextFrame(socket, "gettextselection mimetype=text/plain;charset=utf-8"); +sendTextFrame(_socket, "uno .uno:SelectAll"); +sendTextFrame(_socket, "gettextselection mimetype=text/plain;charset=utf-8"); std::string selection; int flags; int n; do { char buffer[10]; -n = socket.receiveFrame(buffer, sizeof(buffer), flags); +n = _socket.receiveFrame(buffer, sizeof(buffer), flags); if (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != Poco::Net::WebSocket::FRAME_OP_CLOSE) { std::string line = LOOLProtocol::getFirstLine(buffer, n); @@ -71,23 +80,18 @@ void HTTPWSTest::testPaste() } } while (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != Poco::Net::WebSocket::FRAME_OP_CLOSE); -socket.shutdown(); +_socket.shutdown(); CPPUNIT_ASSERT_EQUAL(std::string("aaa bbb ccc"), selection); } void HTTPWSTest::testRenderingOptions() { // Load a document and get its size. -Poco::URI uri("http://127.0.0.1:; + std::to_string(LOOLWSD::DEFAULT_CLIENT_PORT_NUMBER)); -Poco::Net::HTTPClientSession session(uri.getHost(), uri.getPort()); -Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_POST, "/ws"); -Poco::Net::HTTPResponse response; -Poco::Net::WebSocket socket(session, request, response); std::string documentPath = TDOC "/hide-whitespace.odt"; std::string documentURL = "file://" + Poco::Path(documentPath).makeAbsolute().toString(); std::string options = "{\"rendering\":{\".uno:HideWhitespace\":{\"type\":\"boolean\",\"value\":\"true\"}}}"; -sendTextFrame(socket, "load url=" + documentURL + " options=" + options); -sendTextFrame(socket, "status"); +sendTextFrame(_socket, "load url=" + documentURL + " options=" + options); +sendTextFrame(_socket, "status"); std::string status; int flags; @@ -95,7 +99,7 @@ void HTTPWSTest::testRenderingOptions() do { char buffer[10]; -n = socket.receiveFrame(buffer, sizeof(buffer), flags); +n = _socket.receiveFrame(buffer, sizeof(buffer),
[Libreoffice-bugs] [Bug 95810] Writer Crashes on Close
https://bugs.documentfoundation.org/show_bug.cgi?id=95810 --- Comment #7 from Beluga--- Hmm my problem went away with this: https://wiki.documentfoundation.org/UserProfile#Resolving_corruption_in_the_user_profile -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89516] Changing the colour on two objects, 1 with fill, 1 without only changes the colour of the object with fill
https://bugs.documentfoundation.org/show_bug.cgi?id=89516 --- Comment #5 from raal--- Gabriel, could you please retest with actual version? Seems to be fixed. Thank you. LO 5.0.2.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95562] Crash when printing a document with images (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=95562 --- Comment #10 from Arfy--- I have the same problem, and Hardware accell is also greyed (and not set) in my option... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95852] Can't enter text to a text box
https://bugs.documentfoundation.org/show_bug.cgi?id=95852 raalchanged: What|Removed |Added Keywords||bisected CC||mrcek...@gmail.com Whiteboard|bibisectRequest |bibisected --- Comment #4 from raal --- This seems to have begun at the below commit. Adding Cc: to Marco Cecchetti ; Could you possibly take a look at this one? Thanks 4e9a26b54b5533353b8d56e813a02635d7efb21c is the first bad commit commit 4e9a26b54b5533353b8d56e813a02635d7efb21c Author: Matthew Francis Date: Sun Mar 15 05:10:04 2015 +0800 source-hash-967a386bccb15b99915a1e878e42450fbe9a2d0e commit 967a386bccb15b99915a1e878e42450fbe9a2d0e Author: Marco Cecchetti AuthorDate: Wed Nov 5 20:15:32 2014 +0100 Commit: Marco Cecchetti CommitDate: Wed Nov 5 20:21:43 2014 +0100 Fix for SUSE L3 bug 624546 (freedesktop 83733) Problem: When I'm in outline mode, if I select a slide in the left slide preview pane, ctrl-c, then select another slide I would like it after and hit ctrl-v; it refuses to cut/paste. Analysis: This issue is due to the fact that the outline view always grabs focus when activated and a view is activated whenever is pushed to the sfx shell stack even if it is not the new top-most active view shell (see `ViewShellManager`, `SfxViewShell`, `SfxDispacther`). Solution: Make the `OutlineViewShell` grabs focus only if it is the top-most active view shell. Rationale: When `OutlineViewShell::Activate` is invoked, instead of removing the focus grabbing action completely, we check if the `OutlineViewShell` instance is the the top-most view shell and perform the focus grabbing action only in such a case. This change required to have also the `DrawViewShell` grabbing focus on activation (only when it is the top-most view shell). In order to implement this solution I needed to add a new method (and data member) to the `ViewShellManager` class. I named it `GetTopViewShell`. This method returns a pointer to the top-most active view shell of the internal stack. The returned pointer is updated in the `UpdateShellStack` method, before the sfx shell stack is updated. For more details see : https://gist.github.com/mcecchetti/15b3ebc505d6582ea0db Change-Id: I619a406864f50f0e62dee3fcb9ac5d46e3d48272 bibisect-44max$ git bisect log # bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2 # good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e git bisect start 'latest' 'oldest' # good: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4 git bisect good 8cf60cc706948588e2f33a6d98b7c55d454e362a # good: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4 git bisect good 8cf60cc706948588e2f33a6d98b7c55d454e362a # good: [7beddf3808dadd525d7e55c00a5a90a2b44c23d3] source-hash-2f10386ce577f52e139aa23d41bc787d8e0b4d59 git bisect good 7beddf3808dadd525d7e55c00a5a90a2b44c23d3 # good: [fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676] source-hash-0516d123f53917d1833c7e8a8c528a619c71a0af git bisect good fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676 # bad: [47a64818ddfe63bbb8e6448fcc476f55996d61b1] source-hash-d12efada389643ab0e13a280246d14caed273029 git bisect bad 47a64818ddfe63bbb8e6448fcc476f55996d61b1 # bad: [5ce59f880a90cf8134a9d765c2b94bc4f6f5a865] source-hash-e377a65a1e6acf6241ce0bd2fc35a6a786cd8de9 git bisect bad 5ce59f880a90cf8134a9d765c2b94bc4f6f5a865 # bad: [a568e53084f7d0a47b9e814b938f8deab225f7fc] source-hash-8cdcea2689600ef16829a3f951ddf6fb8e9125a0 git bisect bad a568e53084f7d0a47b9e814b938f8deab225f7fc # good: [3c987d7227c844df37802b80ccd8fec798dfe360] source-hash-6e4ee0c0f5b0e314ead2e87438e09eae513e5dc3 git bisect good 3c987d7227c844df37802b80ccd8fec798dfe360 # good: [87d7d87521fcc3acbe035d3a5e0a6bd74c96860e] source-hash-5e48dc03fe3dfb173fe65c46d52552149b255032 git bisect good 87d7d87521fcc3acbe035d3a5e0a6bd74c96860e # bad: [b153d5222738044cd6aa8b249c8371d28d92caca] source-hash-9632045906baf165076d11a97f45b153d8e2acb7 git bisect bad b153d5222738044cd6aa8b249c8371d28d92caca # good: [313358ad8c5d66d0424f67d133d7170e5a42c0e7] source-hash-ea272d9fe4bf2dc7419f76e2ddee707d768ccd50 git bisect good 313358ad8c5d66d0424f67d133d7170e5a42c0e7 # good: [f96b11ff77327e1f5c94937755fc41b8f4e1db04] source-hash-3943daaa353ca3cd4ae1873249c94ed2856dd99a git bisect good f96b11ff77327e1f5c94937755fc41b8f4e1db04 # good:
findings from the plugfest
Hello dear LibreOffice developers, At the last ODF plugfest, LibreOffice was put under quite some scrutiny, as were the other office suites. The findings were written down in a report: http://odfplugfest.org/2015-thehague/report.html The number of bugs found can be seen at the bottom of the page. The individual bugs for LibreOffice are prepended with 'Bug: LibreOffice'. The names in bugs relate to the tests at http://autotests.opendocumentformat.org/ I hope you find the report useful in improving LibreOffice. At the next plugfest we will be running and evaluating the tests again. Best regards, Jos van den Oever -- Jos van den Oever co-chair OpenDocument Format Technical Committee . Ministry of the Interior and Kingdom Relations Center for Standards | Logius Wilhelmina van Pruisenweg 52 | 2595 AN | Den Haag Postbus 96810 | 2509 JE | Den Haag . M +31(0)6-54715404 jos.vanden.oe...@logius.nl www.logius.nl www.oasis-open.org/committees/office/ . ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 95926] Window "Edit Paragraph Style" (or any style) should have an option to switch to a different style quickly
https://bugs.documentfoundation.org/show_bug.cgi?id=95926 --- Comment #2 from Cor Nouws--- Or do you mean that in the dialog "Paragraph Style A", you would like to switch to "Paragraph Style B-Z" to change the properties for those :) ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95436] Broken text display when scrolling using up and down keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=95436 Nicholas Nirochanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||blowf...@kinserve.com Ever confirmed|0 |1 --- Comment #6 from Nicholas Niro --- Would it be possible to give more information about your computer? CPU, RAM, distro with version and also which graphical card driver you are using. It would be great to also get the output of glxinfo if possible. (that command is usually part of the one of the mesa packages, possibly demos or utils). Set this as UNCONFIRMED when you answer please. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configure.ac
configure.ac | 128 +-- 1 file changed, 64 insertions(+), 64 deletions(-) New commits: commit f4f71e96f82a819908fa2b3c7b11412e04adf63b Author: Stephan BergmannDate: Thu Nov 19 19:55:37 2015 +0100 Fix Clang version check further Change-Id: I5b4fbd8e56b20996406116732c5229fff4696650 diff --git a/configure.ac b/configure.ac index 30ec397..fd5e1ec 100644 --- a/configure.ac +++ b/configure.ac @@ -3267,69 +3267,6 @@ else fi AC_SUBST(CROSS_COMPILING) -# === -# check various GCC options that Clang does not support now but maybe -# will somewhen in the future, check them even for GCC, so that the -# flags are set -# === - -HAVE_GCC_GGDB2= -HAVE_GCC_FINLINE_LIMIT= -HAVE_GCC_FNO_INLINE= -if test "$GCC" = "yes"; then -AC_MSG_CHECKING([whether $CC supports -ggdb2]) -if test -n "$CLANGVER" -a 0"$CLANGVER" -le 30100; then -# Option just ignored and silly warning that isn't a real -# warning printed -: -else -save_CFLAGS=$CFLAGS -CFLAGS="$CFLAGS -Werror -ggdb2" -AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],[ HAVE_GCC_GGDB2=TRUE ],[]) -CFLAGS=$save_CFLAGS -fi -if test "$HAVE_GCC_GGDB2" = "TRUE"; then -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi - -AC_MSG_CHECKING([whether $CC supports -finline-limit=0]) -if test -n "$CLANGVER" -a 0"$CLANGVER" -le 30100; then -# As above -: -else -save_CFLAGS=$CFLAGS -CFLAGS="$CFLAGS -Werror -finline-limit=0" -AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],[ HAVE_GCC_FINLINE_LIMIT=TRUE ],[]) -CFLAGS=$save_CFLAGS -fi -if test "$HAVE_GCC_FINLINE_LIMIT" = "TRUE"; then -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi - -AC_MSG_CHECKING([whether $CC supports -fno-inline]) -if test -n "$CLANGVER" -a 0"$CLANGVER" -le 30100; then -# Ditto -: -else -save_CFLAGS=$CFLAGS -CFLAGS="$CFLAGS -Werror -fno-inline" -AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],[ HAVE_GCC_FNO_INLINE=TRUE ],[]) -CFLAGS=$save_CFLAGS -fi -if test "$HAVE_GCC_FNO_INLINE" = "TRUE"; then -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi -fi -AC_SUBST(HAVE_GCC_GGDB2) -AC_SUBST(HAVE_GCC_FINLINE_LIMIT) -AC_SUBST(HAVE_GCC_FNO_INLINE) - HAVE_LD_BSYMBOLIC_FUNCTIONS= if test "$GCC" = "yes"; then AC_MSG_CHECKING( for -Bsymbolic-functions linker support ) @@ -3825,7 +3762,7 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ if test "$COM_IS_CLANG" = TRUE; then AC_MSG_CHECKING([the Clang version]) -clang_version=`echo __clang_major__.__clang_minor__.__clang_patchlevel__ | $CC -E -P /dev/stdin` +clang_version=`echo __clang_major__.__clang_minor__.__clang_patchlevel__ | $CC -E -P -` CLANG_FULL_VERSION=`echo __clang_version__ | $CC -E -P -` CLANGVER=`echo $clang_version | $AWK -F. '{ print \$1*1+\$2*100+\$3 }'` AC_MSG_RESULT([Clang $CLANG_FULL_VERSION, $CLANGVER]) @@ -3862,6 +3799,69 @@ if test "$CCACHE" != ""; then AC_LANG_POP([C]) fi +# === +# check various GCC options that Clang does not support now but maybe +# will somewhen in the future, check them even for GCC, so that the +# flags are set +# === + +HAVE_GCC_GGDB2= +HAVE_GCC_FINLINE_LIMIT= +HAVE_GCC_FNO_INLINE= +if test "$GCC" = "yes"; then +AC_MSG_CHECKING([whether $CC supports -ggdb2]) +if test -n "$CLANGVER" -a 0"$CLANGVER" -le 30100; then +# Option just ignored and silly warning that isn't a real +# warning printed +: +else +save_CFLAGS=$CFLAGS +CFLAGS="$CFLAGS -Werror -ggdb2" +AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],[ HAVE_GCC_GGDB2=TRUE ],[]) +CFLAGS=$save_CFLAGS +fi +if test "$HAVE_GCC_GGDB2" = "TRUE"; then +AC_MSG_RESULT([yes]) +else +AC_MSG_RESULT([no]) +fi + +AC_MSG_CHECKING([whether $CC supports -finline-limit=0]) +if test -n "$CLANGVER" -a 0"$CLANGVER" -le 30100; then +# As above +: +else +save_CFLAGS=$CFLAGS +CFLAGS="$CFLAGS -Werror -finline-limit=0" +AC_LINK_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],[ HAVE_GCC_FINLINE_LIMIT=TRUE ],[]) +CFLAGS=$save_CFLAGS +fi +if test "$HAVE_GCC_FINLINE_LIMIT" = "TRUE"; then +AC_MSG_RESULT([yes]) +else +AC_MSG_RESULT([no]) +fi + +AC_MSG_CHECKING([whether $CC supports -fno-inline]) +if test -n "$CLANGVER" -a 0"$CLANGVER" -le 30100; then +# Ditto +: +else +save_CFLAGS=$CFLAGS +
[Libreoffice-bugs] [Bug 44267] Two decimal digits are probably not enough to specify object position and size
https://bugs.documentfoundation.org/show_bug.cgi?id=44267 Regina Henschelchanged: What|Removed |Added Status|RESOLVED|REOPENED CC||rb.hensc...@t-online.de Resolution|INVALID |--- Severity|normal |enhancement --- Comment #6 from Regina Henschel --- The internal precision of Draw is 1/100 mm. But the spin fields in the position & size dialog round to 2 decimal places. So it is impossible to enter and to see a value in its maximal possible precision. Therefore the request is, that the spin fields should allow at least as much decimal places as needed in the current unit to reflect the precision of 1/100 mm. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: making cairo mandatory in vcl
Hello Khaled, Il 19/11/2015 18:23, Khaled Hosny ha scritto: On Thu, Nov 19, 2015 at 06:15:46PM +0100, Riccardo Magliocchetti wrote: Il 19/11/2015 15:00, Khaled Hosny ha scritto: On Thu, Nov 19, 2015 at 11:14:10AM +, Caolán McNamara wrote: On Thu, 2015-11-19 at 11:16 +0100, Riccardo Magliocchetti wrote: We should now link against cairo and the system one is usually linked against X11. So i think i'm going to just build the libo shipped one and see how it goes. Yeah, that's a fair point. system cairo itself typically links to X11 and sucks that in. Just wondering what issues this linking would cause apart from having to install (unused) X11 libs to satisfy the dependency? unused X libraries may not big deal but in this specific case we are adding cairo and its dependencies too. And it's quite ironic to require X when building with --without-x, isn't it? :) I don’t see the irony, we are not using nor requiring X with this option, some builds of cairo do. I think having less code to maintain in VCL (which is in a such a messy state right now that we have, for example, at least 5 different text layout code paths) far outweighs having a few extra libraries in a non-default build configuration. I know that and i'm perfectly fine with Caolan changes :) I was just asking some questions about the future plan to sort how a fix for the non-default build configuration. cheers -- Riccardo Magliocchetti @rmistaken http://menodizero.it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 95027] Numbered paragraphs applied incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=95027 raalchanged: What|Removed |Added Version|4.5.0.0.alpha0+ Master |4.3.0.0.alpha1 --- Comment #5 from raal --- Reproducible with bibisect-44max$ git checkout oldest Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95926] Window "Edit Paragraph Style" (or any style) should have an option to switch to a different style quickly
https://bugs.documentfoundation.org/show_bug.cgi?id=95926 Cor Nouwschanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||c...@nouenoff.nl Ever confirmed|0 |1 --- Comment #1 from Cor Nouws --- Hi Nicolas, Thanks for writing and your interest in LibreOffice! There is the Select Style dropdown, at the left of the toolbar Formatting. And from 5.1, in Writer there will be a menu Style. Can you please explain if/what misses there compared to your idea? Regards, Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95843] Headless mode leaves zombie process
https://bugs.documentfoundation.org/show_bug.cgi?id=95843 Nicholas Nirochanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||blowf...@kinserve.com Ever confirmed|0 |1 --- Comment #2 from Nicholas Niro --- It's not really a good idea to run programs like libreoffice as root (or any program other than to actually change settings or run privileged apps). Libreoffice has absolutely no need to be ran as root under any conditions. (same goes for wine and many other programs). I tried to run soffice with the flag --headless. It shows this in my process list : $ ps aux | grep soffice nik_89 28745 0.0 0.7 505176 57112 pts/17 Sl+ 12:51 0:00 /opt/libreoffice4.4/program/soffice.bin --headless nik_89 28747 0.0 0.0 0 0 pts/17 Z+ 12:51 0:00 [soffice.bin] The program soffice is still running while I dumped the process list. If I SIGINT the running process by pressing Ctrl + C (in the window where soffice --headless is currently running), it is killed and it no longer shows in the process list. A zombie process is one that stays in the process list regardless of killing attempts. (You could kill -9 repeatedly and it would still stay there). Try to run soffice as a normal user to see if there's any differences. set this back to UNCONFIRMED when you answer please. Libreoffice version : 4.4.3.2 Build Id : 88805f81e9fe61362df02b9941de8e38a9b5fd16 distro : Void linux x86-64 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94326] Numbered headers not displayed and handled correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=94326 raalchanged: What|Removed |Added Keywords||bisected Whiteboard|bibisectRequest |bibisected --- Comment #8 from raal --- 4b717bca8a28effd41dea7fa15191d6ad271ee5e is the first bad commit commit 4b717bca8a28effd41dea7fa15191d6ad271ee5e Author: Matthew Francis Date: Sat Mar 14 22:22:10 2015 +0800 source-hash-c99f264be5eaf481f88606e2606c34170675c1b4 commit c99f264be5eaf481f88606e2606c34170675c1b4 Author: Oliver-Rainer Wittmann AuthorDate: Fri Jun 27 12:34:10 2014 + Commit: Caolán McNamara CommitDate: Mon Jun 30 09:46:15 2014 +0100 Related: #i78498# improvements/corrections regarding outline level & Co - import outline level attribute at Paragraph Styles - import outline level attribute at paragraphs - refactor code to apply list level properties to Outline Style -- only consider WW8 list styles applied to WW8 Built-in Heading Styles -- only assign our counterparts of WW8 Built-in Heading Styles to Outline Style (cherry picked from commit 9032e17b9989d4fc8faefe7717d2ea14d124e653) (cherry picked from commit c3a35e3885334cb37b2b569daaf536a8cc26031d) Conflicts: sw/source/filter/rtf/swparrtf.cxx sw/source/filter/ww8/ww8par.cxx sw/source/filter/ww8/ww8par.hxx sw/source/filter/ww8/ww8par2.cxx sw/source/filter/ww8/ww8par2.hxx sw/source/filter/ww8/ww8par3.cxx sw/source/filter/ww8/ww8par5.cxx sw/source/filter/ww8/ww8par6.cxx sw/source/filter/xml/swxml.cxx Change-Id: Ia70920f91300fa47236533f59356abb546a94fb3 bibisect-44max$ git bisect log # bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2 # good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e git bisect start 'latest' 'oldest' # bad: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4 git bisect bad 8cf60cc706948588e2f33a6d98b7c55d454e362a # bad: [d9885f526fc7a09cc8f9f8ee643af1b966be24bb] source-hash-d1465c64c6f64ad8dd25e40cdc69649b24b305ea git bisect bad d9885f526fc7a09cc8f9f8ee643af1b966be24bb # good: [e3eab511ffbcd2e1e2c67e7a4fec162bb0b26b7a] source-hash-dc9cc46f3223aff3f85d3ce9696178a5f4d3d087 git bisect good e3eab511ffbcd2e1e2c67e7a4fec162bb0b26b7a # good: [1477f347fb61b5b07de64312247b49371812f5b4] source-hash-4598bbe41d0906a34ceb1126c7fce2108642cd8e git bisect good 1477f347fb61b5b07de64312247b49371812f5b4 # good: [fdbfc593506d9f38152b80f14c9e7afdbef0b40a] source-hash-6024ddbfac8e62db50dd5352d610c87d279627de git bisect good fdbfc593506d9f38152b80f14c9e7afdbef0b40a # good: [b1d1e3e3ac1515cf33be95eba837476142fb6ca8] source-hash-f55ddffd7e81cc8f3314047a6aa62991e2d293b1 git bisect good b1d1e3e3ac1515cf33be95eba837476142fb6ca8 # bad: [163b7bd042acbad89907ad1e16c268229c8468a0] source-hash-e123226d874d59799ba4ca2a8919e50e7eb2ba3b git bisect bad 163b7bd042acbad89907ad1e16c268229c8468a0 # bad: [4b717bca8a28effd41dea7fa15191d6ad271ee5e] source-hash-c99f264be5eaf481f88606e2606c34170675c1b4 git bisect bad 4b717bca8a28effd41dea7fa15191d6ad271ee5e # good: [8297925628ef607d65f047e975f795b31643c08e] source-hash-67c20d42b5ca06458b154356877f4ad5952736f4 git bisect good 8297925628ef607d65f047e975f795b31643c08e # good: [9191d7a142042d0fe7a76d85c2c04fa01d02b544] source-hash-eba630ca1689d65d6f58c0e6bd7658cc6eac8dcc git bisect good 9191d7a142042d0fe7a76d85c2c04fa01d02b544 # good: [0f8de9580096702299b708f48950eab76e4eb83c] source-hash-fb597ee98f69dd3243c45cb0ff76516f7ec31c73 git bisect good 0f8de9580096702299b708f48950eab76e4eb83c # good: [9d3979ce59c5c9fa6f0f6a8dedc00bb08660a45c] source-hash-0fef0d41f7e373d562c0689107183ab40e09d129 git bisect good 9d3979ce59c5c9fa6f0f6a8dedc00bb08660a45c # good: [63d1a075ce19e6cdc9b6311b4f849840defb1d75] source-hash-679b1ed8655c3128e2f14a8d5cdc9be25c822bc0 git bisect good 63d1a075ce19e6cdc9b6311b4f849840defb1d75 # first bad commit: [4b717bca8a28effd41dea7fa15191d6ad271ee5e] source-hash-c99f264be5eaf481f88606e2606c34170675c1b4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95939] New: Graphic Problem in Write
https://bugs.documentfoundation.org/show_bug.cgi?id=95939 Bug ID: 95939 Summary: Graphic Problem in Write Product: LibreOffice Version: 5.0.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nem...@hotmail.com Created attachment 120670 --> https://bugs.documentfoundation.org/attachment.cgi?id=120670=edit Graphic Problem Hi, I have some graphic trouble in last version of LibreOffice Write, using Sanskrit Hebrew Syriac, Greek, Cyrillic, Arabic script in text cause confusion and graphic bugs... Copying some Syriac vrom BabelMap to Write, cause crash, and recovering the files is impossible beacause it always reboot and crash... The files became unrecoverable... In autocorrection there is graphic problem when adding variant unicode script, please correct this, LibreOffice office is cool, but crash to much, not stable, 5 to 10x slower compare to Excel or Access when making big table & database, it is near unusable... Correct this please... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94063] EDITING References break when putting text behind them.
https://bugs.documentfoundation.org/show_bug.cgi?id=94063 Terrence Engerchanged: What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- --- Comment #6 from Terrence Enger --- In comment 3, step (10), I meant row 7 column 3, of course. That said, I see the old behavior in daily dbgutil bibisect version 2015-11-18. I am setting bug status NEW. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/source
starmath/source/parse.cxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit 186f365a2c541c51e404b1fa819f35c9152adaf1 Author: Takeshi AbeDate: Thu Nov 19 19:14:23 2015 +0900 starmath: Use std::unique_ptr for exception safety Change-Id: Idc71dc41b88463440dd18f41ff945b7616d7 diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx index 7cc0667..dded575 100644 --- a/starmath/source/parse.cxx +++ b/starmath/source/parse.cxx @@ -992,11 +992,11 @@ void SmParser::DoTable() void SmParser::DoAlign() // parse alignment info (if any), then go on with rest of expression { -SmStructureNode *pSNode = nullptr; +std::unique_ptr pSNode; if (TokenInGroup(TGALIGN)) { -pSNode = new SmAlignNode(m_aCurToken); +pSNode.reset(new SmAlignNode(m_aCurToken)); NextToken(); @@ -1004,7 +1004,6 @@ void SmParser::DoAlign() if (TokenInGroup(TGALIGN)) { Error(PE_DOUBLE_ALIGN); -delete pSNode; return; } } @@ -1014,7 +1013,7 @@ void SmParser::DoAlign() if (pSNode) { pSNode->SetSubNode(0, popOrZero(m_aNodeStack)); -m_aNodeStack.push_front(std::unique_ptr(pSNode)); +m_aNodeStack.push_front(std::move(pSNode)); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/ui/view/viewfunc.cxx | 24 1 file changed, 12 insertions(+), 12 deletions(-) New commits: commit d9b6f836e58aa3ad1dc6120df89c4001dc7d3091 Author: Eike RathkeDate: Tue Nov 17 14:46:11 2015 +0100 Resolves: tdf#89907 do not modify original ScViewData's ScMarkData Change-Id: I2ae5a06f9ffe29de0b1cc5875615010da75f4ae9 (cherry picked from commit d1225d60af08ed874ed72066ae0320617d4c8a91) Reviewed-on: https://gerrit.libreoffice.org/20020 Tested-by: Jenkins Reviewed-by: Markus Mohrhard Tested-by: Markus Mohrhard diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx index 2cb7612..1bb2268 100644 --- a/sc/source/ui/view/viewfunc.cxx +++ b/sc/source/ui/view/viewfunc.cxx @@ -1824,13 +1824,13 @@ void ScViewFunc::SetWidthOrHeight( if (rRanges.empty()) return; -// use view's mark if none specified -if ( !pMarkData ) -pMarkData = ().GetMarkData(); +// Use view's mark if none specified, but do not modify the original data, +// i.e. no MarkToMulti() on that. +ScMarkData aMarkData( pMarkData ? *pMarkData : GetViewData().GetMarkData()); ScDocShell* pDocSh = GetViewData().GetDocShell(); ScDocument& rDoc = pDocSh->GetDocument(); -SCTAB nFirstTab = pMarkData->GetFirstSelected(); +SCTAB nFirstTab = aMarkData.GetFirstSelected(); SCTAB nCurTab = GetViewData().GetTabNo(); SCTAB nTab; if (bRecord && !rDoc.IsUndoEnabled()) @@ -1839,7 +1839,7 @@ void ScViewFunc::SetWidthOrHeight( ScDocShellModificator aModificator( *pDocSh ); bool bAllowed = true; -ScMarkData::iterator itr = pMarkData->begin(), itrEnd = pMarkData->end(); +ScMarkData::iterator itr = aMarkData.begin(), itrEnd = aMarkData.end(); for (; itr != itrEnd && bAllowed; ++itr) { for (size_t i = 0, n = rRanges.size(); i < n && bAllowed; ++i) @@ -1886,7 +1886,7 @@ void ScViewFunc::SetWidthOrHeight( rDoc.BeginDrawUndo(); // Drawing Updates pUndoDoc = new ScDocument( SCDOCMODE_UNDO ); -itr = pMarkData->begin(); +itr = aMarkData.begin(); for (; itr != itrEnd; ++itr) { if (bWidth) @@ -1918,12 +1918,12 @@ void ScViewFunc::SetWidthOrHeight( } if ( eMode==SC_SIZE_OPTIMAL || eMode==SC_SIZE_VISOPT ) -pMarkData->MarkToMulti(); +aMarkData.MarkToMulti(); bool bShow = nSizeTwips > 0 || eMode != SC_SIZE_DIRECT; bool bOutline = false; -itr = pMarkData->begin(); +itr = aMarkData.begin(); for (; itr != itrEnd; ++itr) { nTab = *itr; @@ -2036,7 +2036,7 @@ void ScViewFunc::SetWidthOrHeight( { pDocSh->GetUndoManager()->AddUndoAction( new ScUndoWidthOrHeight( -pDocSh, *pMarkData, nStart, nCurTab, nEnd, nCurTab, +pDocSh, aMarkData, nStart, nCurTab, nEnd, nCurTab, pUndoDoc, aUndoRanges, pUndoTab, eMode, nSizeTwips, bWidth)); } @@ -2044,7 +2044,7 @@ void ScViewFunc::SetWidthOrHeight( // the new heights and widths. GetViewData().GetView()->RefreshZoom(); -itr = pMarkData->begin(); +itr = aMarkData.begin(); for (; itr != itrEnd; ++itr) rDoc.UpdatePageBreaks( *itr ); @@ -2052,7 +2052,7 @@ void ScViewFunc::SetWidthOrHeight( if (bPaint) { -itr = pMarkData->begin(); +itr = aMarkData.begin(); for (; itr != itrEnd; ++itr) { nTab = *itr; @@ -2087,7 +2087,7 @@ void ScViewFunc::SetWidthOrHeight( if (ScModelObj* pModelObj = HelperNotifyChanges::getMustPropagateChangesModel(*pDocSh)) { ScRangeList aChangeRanges; -itr = pMarkData->begin(); +itr = aMarkData.begin(); for (; itr != itrEnd; ++itr) { nTab = *itr; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 95810] Writer Crashes on Close
https://bugs.documentfoundation.org/show_bug.cgi?id=95810 --- Comment #8 from J William Cupp--- How do you know that resetting the user profile cleared the problem? In my case, the crash-on-close happens frequently when I open a document with a watermark and clear the "autofit" property of the bitmap image background. It does not seem to matter whether I save the document after clearing the autofit property or not. Frequently, I say, but not always. Additionally, I have experienced the crash-on-close even when I have not opened such a document. It is not as common this way, but it has happened. What sort of reliable test could I make after I clear the user profile in order to know if the problem is gone? (Also, this begs the question as to how the user profile became corrupted so. The timing with the upgrade to 5.0.3.2 and the concurrent appearance of the autofit background bitmap seems a bit of a long stretch to write off as coincidence.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-qa] Minutes of ESC call: 2015-11-19
* Present: + Stephan, Christian, Jan-Marek, Eike, Bubli, Robinson, Kendy, Andras, jan i Muthu, Michael S, Thorsten * Completed Action Items: + Largo as a hack-fest venue ? chat to Dave (Robinson) + Had brief chat; many users available for testing, but few devs. + Encouraged investigation of local Universities for new dev blood + I'll update ESC later if I hear promising news (Robinson) * Pending Action Items: + please cleanup / merge mentoring page (JanI) [ https://wiki.documentfoundation.org/Mentors https://wiki.documentfoundation.org/FindTheExpert ] + done, no feedback so far, removed 2 experts + UserAgent - drop bundled-languages (Michael) + UserAgent - produce a patch for review (Michael) + come up with a proposal for "abandoned" / "insufficient data" resolution in the bug-flow graph (Robinson) [ lively discussion, following up, decision by the end of the week ] + setup FOSDEM Hackfest wiki page with dates (Bjoern) [ focusing on Munich / Madrid ] + book FOSDEM conf. room for board meeting (Florian/Bjoern?) [ perhaps after not before to avoid hackfest conflict ] + run the sw renaming script just before branch-off (Robinson) [ will happen after ESC meeting, & when tb's are happy ] * Release Engineering update (Cloph) + 4.4.7 RC2 - due next week + patches waiting for 4.4 and 4.4.7, please review until Monday + 5.0.4 anticipated the next week too + 5.0.4 status + OpenGL default / disable for now: + https://gerrit.libreoffice.org/#/c/19950/ AI + discussed the last ESC, Cloph will integrate it (Cloph) + RC1 / freeze next Monday + 5.1.0 branch / feature-freeze: this week. + Robinson doing branch + tag. + after the ESC, awaiting the green tinderboxes + Late Features: + OpenGL - switch to simpler double-buffering. + Slide Transitions: artwork & polish + Jay poking designers for new images + UserAgent display & tweakage + calc s/w interpreter-related patch + Android & iOS Remote + will create a new Android Viewer later this week. + the build was not stable enough, trying again + big & nice improvements by Tomaž (Cloph) * Documentation (Olivier) + no news * UX Update (Kendy) + lots of interesting ideas around notebookbar, planned a Friday session about that * Crashtest update + 1 import failures, 0 export failures, unknown coverity issues -> coverity is down * Hackfests (Bjoern) + GNOME hack-fest in Madrid - Dec 2nd -> 4th (Jacobo) + sent an invitation to LibreOffice deployments in Spain + they may need funding to attend. + guy from Valencia confirmed & will come + Wiki page: https://wiki.documentfoundation.org/Hackfest/Madrid2015 + FOSDEM / Beta Co-working (Bjoern) + LiMux hackfest end of November (Jan-Marek) + Fri 20th - Sun 22nd November 2015 + this weekend! + cooking for 20 people will be easier than for 40... + official page https://wiki.debian.org/BSP/2015/11/Munich to replace the doodle + amazon images / cloud needed? (Cloph) + not necessary this time, mostly Debian people this time + next venues / suggestions + considering another Gran Canaria hack-fest (Thorsten) + March next year (?) * Mentoring Update (JanI) + many new contributors seem not to know how to update/amend a patch (Bubli) AI + improve Wiki, write blogpost, promote git-review etc. (JanI) + List of developers who have not contributed a while AI + discussing whether / how to contact them (JanI) + update monthly + to see if we can do something for them + Gerrit oauth + current authentication a hassle (JanI) + redmine ticked for that now + Gerrit patches, set to abandon? + similar to bugs with NEEDINFO (Jan-Marek) + worth contacting a reviewer too, to see if the patch is useful or not (Bubli) + reply on gerrit goes to all, should do it (Jan-Marek) + easy case: patches with -1 where nobody reacts (Eike) + for the moment, JanI will contact the gerrit admins to abandon, does not have the rights yet (JanI) * l10n Update (Sophie) + updated templates with typo fixes (Cloph) + nothing special happening (Andras) * external libraries: mDNSResponder? (Michael S.) + checked in to random locations + not clear when we include something external + potential issue with updates + sd/source/ui/remotecontrol/mDNSResponder/ + http://www.opensource.apple.com/tarballs/mDNSResponder/ + off by default (Miklos) AI + will check & try to move to external/ (Michael S.) +
Minutes of ESC call: 2015-11-19
* Present: + Stephan, Christian, Jan-Marek, Eike, Bubli, Robinson, Kendy, Andras, jan i Muthu, Michael S, Thorsten * Completed Action Items: + Largo as a hack-fest venue ? chat to Dave (Robinson) + Had brief chat; many users available for testing, but few devs. + Encouraged investigation of local Universities for new dev blood + I'll update ESC later if I hear promising news (Robinson) * Pending Action Items: + please cleanup / merge mentoring page (JanI) [ https://wiki.documentfoundation.org/Mentors https://wiki.documentfoundation.org/FindTheExpert ] + done, no feedback so far, removed 2 experts + UserAgent - drop bundled-languages (Michael) + UserAgent - produce a patch for review (Michael) + come up with a proposal for "abandoned" / "insufficient data" resolution in the bug-flow graph (Robinson) [ lively discussion, following up, decision by the end of the week ] + setup FOSDEM Hackfest wiki page with dates (Bjoern) [ focusing on Munich / Madrid ] + book FOSDEM conf. room for board meeting (Florian/Bjoern?) [ perhaps after not before to avoid hackfest conflict ] + run the sw renaming script just before branch-off (Robinson) [ will happen after ESC meeting, & when tb's are happy ] * Release Engineering update (Cloph) + 4.4.7 RC2 - due next week + patches waiting for 4.4 and 4.4.7, please review until Monday + 5.0.4 anticipated the next week too + 5.0.4 status + OpenGL default / disable for now: + https://gerrit.libreoffice.org/#/c/19950/ AI + discussed the last ESC, Cloph will integrate it (Cloph) + RC1 / freeze next Monday + 5.1.0 branch / feature-freeze: this week. + Robinson doing branch + tag. + after the ESC, awaiting the green tinderboxes + Late Features: + OpenGL - switch to simpler double-buffering. + Slide Transitions: artwork & polish + Jay poking designers for new images + UserAgent display & tweakage + calc s/w interpreter-related patch + Android & iOS Remote + will create a new Android Viewer later this week. + the build was not stable enough, trying again + big & nice improvements by Tomaž (Cloph) * Documentation (Olivier) + no news * UX Update (Kendy) + lots of interesting ideas around notebookbar, planned a Friday session about that * Crashtest update + 1 import failures, 0 export failures, unknown coverity issues -> coverity is down * Hackfests (Bjoern) + GNOME hack-fest in Madrid - Dec 2nd -> 4th (Jacobo) + sent an invitation to LibreOffice deployments in Spain + they may need funding to attend. + guy from Valencia confirmed & will come + Wiki page: https://wiki.documentfoundation.org/Hackfest/Madrid2015 + FOSDEM / Beta Co-working (Bjoern) + LiMux hackfest end of November (Jan-Marek) + Fri 20th - Sun 22nd November 2015 + this weekend! + cooking for 20 people will be easier than for 40... + official page https://wiki.debian.org/BSP/2015/11/Munich to replace the doodle + amazon images / cloud needed? (Cloph) + not necessary this time, mostly Debian people this time + next venues / suggestions + considering another Gran Canaria hack-fest (Thorsten) + March next year (?) * Mentoring Update (JanI) + many new contributors seem not to know how to update/amend a patch (Bubli) AI + improve Wiki, write blogpost, promote git-review etc. (JanI) + List of developers who have not contributed a while AI + discussing whether / how to contact them (JanI) + update monthly + to see if we can do something for them + Gerrit oauth + current authentication a hassle (JanI) + redmine ticked for that now + Gerrit patches, set to abandon? + similar to bugs with NEEDINFO (Jan-Marek) + worth contacting a reviewer too, to see if the patch is useful or not (Bubli) + reply on gerrit goes to all, should do it (Jan-Marek) + easy case: patches with -1 where nobody reacts (Eike) + for the moment, JanI will contact the gerrit admins to abandon, does not have the rights yet (JanI) * l10n Update (Sophie) + updated templates with typo fixes (Cloph) + nothing special happening (Andras) * external libraries: mDNSResponder? (Michael S.) + checked in to random locations + not clear when we include something external + potential issue with updates + sd/source/ui/remotecontrol/mDNSResponder/ + http://www.opensource.apple.com/tarballs/mDNSResponder/ + off by default (Miklos) AI + will check & try to move to external/ (Michael S.) +
[Libreoffice-commits] core.git: libreofficekit/qa
libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) New commits: commit 9dea0a9775c1ab8c6ce8bbf00df83757cba34fb0 Author: Miklos VajnaDate: Thu Nov 19 17:29:31 2015 +0100 gtktiledviewer: allow setting custom background color E.g. it helps testing the semi-transparent shadow around Writer pages to append "--background-color yellow" to the commandline arguments. Change-Id: Ib94750e936abe3f41e4982534431fd5115e2c543 diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx index f76ad1a..9c2692c 100644 --- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx +++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx @@ -32,6 +32,7 @@ static int help() fprintf(stderr, "Usage: gtktiledviewer [ ... ]\n\n"); fprintf(stderr, "Options:\n\n"); fprintf(stderr, "--hide-whitespace: Hide whitespace between pages in text documents.\n"); +fprintf(stderr, "--background-color : Set custom background color, e.g. 'yellow'.\n"); return 1; } @@ -484,13 +485,20 @@ static void createModelAndView(const char* pLOPath, const char* pDocPath, const setupWidgetAndCreateWindow(pDocView); boost::property_tree::ptree aTree; -for (const std::string& rArgument : rArguments) +for (size_t i = 0; i < rArguments.size(); ++i) { +const std::string& rArgument = rArguments[i]; if (rArgument == "--hide-whitespace") { aTree.put(boost::property_tree::ptree::path_type(".uno:HideWhitespace/type", '/'), "boolean"); aTree.put(boost::property_tree::ptree::path_type(".uno:HideWhitespace/value", '/'), true); } +else if (rArgument == "--background-color" && i + 1 < rArguments.size()) +{ +GdkRGBA color; +gdk_rgba_parse(, rArguments[i + 1].c_str()); + gtk_widget_override_background_color(gtk_widget_get_toplevel(pDocView), GTK_STATE_FLAG_NORMAL, ); +} } std::stringstream aStream; boost::property_tree::write_json(aStream, aTree); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/awt/UnoControlButtonModel.idl | 10 ++ offapi/com/sun/star/awt/XButton.idl |3 +++ 2 files changed, 13 insertions(+) New commits: commit 054d3251d770a6104c524fa7483011877ed657b1 Author: Tsutomu UchinoDate: Wed Nov 18 12:44:57 2015 + Related: #i72580# Add descriptions about State property and button command (cherry picked from commit 78dce87d4bd6936f0310d96381a0130f3ba82ed0) Change-Id: Ide972a5574c0062a7ee4e4300e512715c55e8d37 diff --git a/offapi/com/sun/star/awt/UnoControlButtonModel.idl b/offapi/com/sun/star/awt/UnoControlButtonModel.idl index 3a5f01c..c28e31c 100644 --- a/offapi/com/sun/star/awt/UnoControlButtonModel.idl +++ b/offapi/com/sun/star/awt/UnoControlButtonModel.idl @@ -188,6 +188,16 @@ published service UnoControlButtonModel /** specifies the state of the control. + +If #Toggle property is set to `TRUE`, the pressed state +is enabled and its pressed state can be obtained with this property. + + +0: not pressed +1: pressed +2: don't know + +@see #Toggle */ [property] short State; diff --git a/offapi/com/sun/star/awt/XButton.idl b/offapi/com/sun/star/awt/XButton.idl index 24dfa73..3840d40 100644 --- a/offapi/com/sun/star/awt/XButton.idl +++ b/offapi/com/sun/star/awt/XButton.idl @@ -49,6 +49,9 @@ published interface XButton: com::sun::star::uno::XInterface /** sets a command string for pushing the button. + +@param Command +value can be used to detect which button is pressed. */ void setActionCommand( [in] string Command ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 78/dce87d4bd6936f0310d96381a0130f3ba82ed0
78/dce87d4bd6936f0310d96381a0130f3ba82ed0 |1 + 1 file changed, 1 insertion(+) New commits: commit 2f9fbf37d7503ead7a73d80b837a9f194705b6f5 Author: Caolán McNamaraDate: Thu Nov 19 21:02:28 2015 + Notes added by 'git notes add' diff --git a/78/dce87d4bd6936f0310d96381a0130f3ba82ed0 b/78/dce87d4bd6936f0310d96381a0130f3ba82ed0 new file mode 100644 index 000..999dfbf --- /dev/null +++ b/78/dce87d4bd6936f0310d96381a0130f3ba82ed0 @@ -0,0 +1 @@ +merged as: 054d3251d770a6104c524fa7483011877ed657b1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94940] "Show font history" option does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=94940 --- Comment #6 from Nicholas Niro--- Created attachment 120669 --> https://bugs.documentfoundation.org/attachment.cgi?id=120669=edit Without Font history I disabled "Show font history" and this screenshot shows the result. It seems to have removed the history but is still showing the 2 kinds of fonts which are currently in use in the document. Font Lists - Show font history When using this option, the last five fonts you have use the current document displayed on the top of the list of fonts. this quote is from : https://en.wikibooks.org/wiki/LibreOffice/Writer/Configuring_the_editor So this seems to work correctly for me. Can you confirm if this is the same behavior you are getting too? Set this as UNCONFIRMED when you answer please. Libreoffice version : 4.4.3.2 Build Id : 88805f81e9fe61362df02b9941de8e38a9b5fd16 distro : Void linux x86-64 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: findings from the plugfest
Hi Jos, On Thursday, 2015-11-19 08:39:17 +, Jos van den Oever wrote: > The findings were written down in a report: > http://odfplugfest.org/2015-thehague/report.html > The number of bugs found can be seen at the bottom of the page. The > individual bugs for LibreOffice are prepended with 'Bug: LibreOffice'. > > The names in bugs relate to the tests at > http://autotests.opendocumentformat.org/ > > I hope you find the report useful in improving LibreOffice. At the next > plugfest we will be running and evaluating the tests again. I have some feedback. For example, in http://odfplugfest.org/2015-thehague/report.html for the "odt-script" test it is reported that | Bug: LibreOffice loses the attribute fo:script. However, the input style has where fo:script="arab" (btw, correct would be "Arab") is the default script for fo:language="ar" and thus may be omitted. See also https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry which lists | Subtag: ar | Suppress-Script: Arab so it is even expected to be suppressed. For "odt-script-225" there is fo:script="225" (ISO 15924 number for Arab), however, ODF 1.2 in 19.242.1 fo:script General http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1417340_253892949 says | The attribute should be used only if necessary according to the rules | of §2.2.3 of [RFC5646], or its successors. RFC 5646 https://tools.ietf.org/html/rfc5646 says in 2.1 Syntax https://tools.ietf.org/html/rfc5646#section-2.1 | script= 4ALPHA ; ISO 15924 code so numeric is not expected. In 2.2.3. Script Subtag it explicitly restates | 2. Script subtags consist of four letters and were defined | according to the assignments found in [ISO15924] I'd say that in ODF fo:script="225" is an invalid input.. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 95852] Can't enter text to a text box
https://bugs.documentfoundation.org/show_bug.cgi?id=95852 raalchanged: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95930] DOCX IMPORT: invalid auto-contour for image text-wrap distorst image display
https://bugs.documentfoundation.org/show_bug.cgi?id=95930 Cor Nouwschanged: What|Removed |Added CC||c...@nouenoff.nl --- Comment #3 from Cor Nouws --- Indeed same as/related to 63851 ? maybe good to know is issue 87784. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79163] SVG Import - gradients bugged and some transparent sections fully white
https://bugs.documentfoundation.org/show_bug.cgi?id=79163 V Stuart Footechanged: What|Removed |Added Blocks||88277 Whiteboard||filter:svgOpen --- Comment #5 from V Stuart Foote --- For filter opening SVG in Draw, not the insert SVG filter. In the attached clip can see the state of the insert filter, which has some issues as well, and the much rougher but better than its been open filter. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88277] Meta: SVG fileOpen filter (Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=88277 V Stuart Footechanged: What|Removed |Added CC||aniste...@gmail.com --- Comment #6 from V Stuart Foote --- added bug 79163 -- not sure how I'd missed it, but a good test case for Xisco's work on the open SVG filters. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91131] UI: Crash when deleting List Style after trying to create new style with same name
https://bugs.documentfoundation.org/show_bug.cgi?id=91131 raalchanged: What|Removed |Added Keywords||bisected CC||mst...@redhat.com, ||r...@post.cz Whiteboard|bibisectRequest |bibisected --- Comment #4 from raal --- This seems to have begun at the below commit. Adding Cc: to Michael Stahl ; Could you possibly take a look at this one? Thanks 90012cb7ba832730701e29655d352a5929a14161 is the first bad commit commit 90012cb7ba832730701e29655d352a5929a14161 Author: Matthew Francis Date: Sat Mar 14 23:46:36 2015 +0800 source-hash-81b594afa7162552fc2489ba0c7e1e8b5addb4f2 commit 81b594afa7162552fc2489ba0c7e1e8b5addb4f2 Author: Michael Stahl AuthorDate: Thu Jul 24 13:42:00 2014 +0200 Commit: Michael Stahl CommitDate: Thu Jul 24 13:45:55 2014 +0200 svl: remove some odd and obsolete debugging code related to MI_HATS_REPARIERT This was apparently disabled before the MI_HATS_REPARIERT check was removed in f03a3edf2523c208948059861e0df48567834d0d, and then yesterday something in the header inclusions changed to enable the DBG macros that still used the removed stuff, but _only_ on Windows... now clean this up. Change-Id: I4222db252f4a886b3497ca0c22dbec26eaa6c994 bibisect-44max$ git bisect log # bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2 # good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e git bisect start 'latest' 'oldest' # bad: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4 git bisect bad 8cf60cc706948588e2f33a6d98b7c55d454e362a # good: [d9885f526fc7a09cc8f9f8ee643af1b966be24bb] source-hash-d1465c64c6f64ad8dd25e40cdc69649b24b305ea git bisect good d9885f526fc7a09cc8f9f8ee643af1b966be24bb # bad: [c779cf7967f4d14c5e649a5c696b07279d550efd] source-hash-e9c5022580f14c0ca97503f8b3cc56b530fff174 git bisect bad c779cf7967f4d14c5e649a5c696b07279d550efd # good: [030e0477638f9d9110ad62f88fd4b881521e0541] source-hash-1a6e47e3fda10e6d220b67d766ec6fbdfd852b80 git bisect good 030e0477638f9d9110ad62f88fd4b881521e0541 # good: [c9e7f255b30a0410226b2074702aeba9b49dce13] source-hash-2d5a7c36ee9ae7ff39d8415f81fb911ff822548e git bisect good c9e7f255b30a0410226b2074702aeba9b49dce13 # bad: [0996e94321008e9f1857c299efad9dc3bc6e5ff2] source-hash-6c1f2ea2aa11b2c8fd42b455c7c452194ed2c1e7 git bisect bad 0996e94321008e9f1857c299efad9dc3bc6e5ff2 # good: [c69835b63d379747e58c9d6315dbf32a09e842ef] source-hash-d5fb4b731938c22fcf9c5e3280da8f722b5492e4 git bisect good c69835b63d379747e58c9d6315dbf32a09e842ef # bad: [90012cb7ba832730701e29655d352a5929a14161] source-hash-81b594afa7162552fc2489ba0c7e1e8b5addb4f2 git bisect bad 90012cb7ba832730701e29655d352a5929a14161 # good: [1c81f4ba81c4e3b78798881afd8f4099156dedb2] source-hash-d6551bde0bcd06e4ed6b9aaa47f7891e47511264 git bisect good 1c81f4ba81c4e3b78798881afd8f4099156dedb2 # good: [33219b2f24783028d49cc92dd56e79b1f923e721] source-hash-b8a72f7e344fec02a0ea0fcc3848d5960a21fc0b git bisect good 33219b2f24783028d49cc92dd56e79b1f923e721 # good: [ab96982967eb1bbfb7690ed03e6610b5604869fb] source-hash-fb743559fb993d2d8d8b61354e734c27d9d13e1c git bisect good ab96982967eb1bbfb7690ed03e6610b5604869fb # good: [30dc08dd79c93996723a8add24705e790868ddef] source-hash-e08fc65e5fe716c838b0c0dc29d337967df5380f git bisect good 30dc08dd79c93996723a8add24705e790868ddef # good: [3001a2cb287cded294078fba259e51557086feef] source-hash-e904562af54545684b32d2042ded6bdb9459edca git bisect good 3001a2cb287cded294078fba259e51557086feef # first bad commit: [90012cb7ba832730701e29655d352a5929a14161] source-hash-81b594afa7162552fc2489ba0c7e1e8b5addb4f2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94940] "Show font history" option does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=94940 Nicholas Nirochanged: What|Removed |Added CC||blowf...@kinserve.com --- Comment #5 from Nicholas Niro --- Created attachment 120668 --> https://bugs.documentfoundation.org/attachment.cgi?id=120668=edit With Font History This screenshot shows an history of the last 5 fonts used (I randomly used fonts to test this) right above the fonts list. The option "Show fonts history" was active. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94940] "Show font history" option does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=94940 Nicholas Nirochanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #7 from Nicholas Niro --- -Awaiting more information- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79163] SVG Import - gradients bugged and some transparent sections fully white
https://bugs.documentfoundation.org/show_bug.cgi?id=79163 --- Comment #4 from V Stuart Foote--- Created attachment 120667 --> https://bugs.documentfoundation.org/attachment.cgi?id=120667=edit clips of the SVG inserted and opened On Windows 8.1 Pro 64-bit (en-US) with Version: 5.1.0.0.alpha1+ (x64) Build ID: 32d4c03cba399ada807b8ec113a3928aa9e3ff7b TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-11-16_23:41:46 Locale: en-US (en_US) the attached zip archive shows current state of the svgInsert vs svgOpen filters--and fully rendering in FireFox42 and ImageMagick's Display uitl. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88277] Meta: SVG fileOpen filter (Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=88277 V Stuart Footechanged: What|Removed |Added Depends on||79163 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: slideshow/source
slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ff522704109078a0cde844c74d608137b7c70f42 Author: Stephan BergmannDate: Thu Nov 19 22:45:45 2015 +0100 loplugin:redundantcast Change-Id: I89281db92f9b75e972313a95c33473d7649a9bef diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx index 2a13ca1..0298eba 100644 --- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx +++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx @@ -212,7 +212,7 @@ static void display_primitives(const Primitives_t& primitives, double nTime, dou CHECK_GL_ERROR(); glBufferData(GL_ARRAY_BUFFER, size, nullptr, GL_STREAM_DRAW); CHECK_GL_ERROR(); -Vertex *buf = reinterpret_cast (glMapBuffer(GL_ARRAY_BUFFER, GL_WRITE_ONLY)); +Vertex *buf = static_cast (glMapBuffer(GL_ARRAY_BUFFER, GL_WRITE_ONLY)); std::vector first_elements; int last_pos = 0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 95934] FORMATTING Right click -> Format Cells opens transparent dialogue box
https://bugs.documentfoundation.org/show_bug.cgi?id=95934 --- Comment #1 from A (Andy)--- For me not reproducible with LO 5.0.3.2, Win 8.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs