date:20160407

[Libreoffice-bugs] [Bug 99149] New: OLE file open dialogue displays folders as empty (degradation)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99149

Bug ID: 99149
   Summary: OLE file open dialogue displays folders as empty
(degradation)
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tenc...@gmail.com

Created attachment 124175
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124175=edit
OLE open OOo vs LO

I try to insert OLE object... Further object... From file...
File open dialogue erratically displays folder as empty folder. Also Impress
may stuck or crash.
Example contains screenshot OOo vs LO
This work correctly in LO 4.4.7 but not work in 5.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98912] Calc crashes when editing chart.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98912

--- Comment #8 from Buovjaga  ---
What are your results after disabling OpenGL?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

Joel Madero  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 31814] EMF regression: failure of displaying ChemDraw objects

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=31814

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |WORKSFORME

--- Comment #29 from Jean-Baptiste Faure  ---
(In reply to Timur from comment #28)
> Sorry, I can't see this as fixed in 5.1 or 5.2+. Please check.

Tested today with LO 5.1.3.0.0+ with the same bugdoc as Caolan and I get the
same result.
I you disagree with Caolan and me, please attach your own screencopy showing
how _this_ bug is still there.

If you see some problem with embedded EMF objects, please, open a new bug
report with a detailed description and a test file.

Closing again. As we don't know which commit[s] fixed the bug, the right status
is WorksForMe.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99148] Freeze Row & Columns + Merged Cells = Frozen only one of merged rows

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99148

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jmadero@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Joel Madero  ---
Please just attach the actual ods file instead of a screenshot then mark as
UNCONFIRMED. 

In the future it's always better to include your own sample file - we have
thousands of bug reportsthe more work our reporters do the easier it is on
the small team of contributors. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source

2016-04-07 Thread Markus Mohrhard

 oox/source/export/ColorPropertySet.cxx |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)

New commits:
commit 753c474b199a9c12f182c89c487133f9fa88e352
Author: Markus Mohrhard 
Date:   Fri Apr 8 05:06:54 2016 +0200

fix many ooxml validation errors

This code was just horribly broken. Every requested property would
return the color value which if interepreted as an alpha value gave
invalid values.

This now contains an assert that might trigger in the next set of crash
testing.

Change-Id: I959084dbce2d28878b50ec52ece71397d4ace561
Reviewed-on: https://gerrit.libreoffice.org/23909
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/oox/source/export/ColorPropertySet.cxx 
b/oox/source/export/ColorPropertySet.cxx
index 3fb4b9a..bab61b0 100644
--- a/oox/source/export/ColorPropertySet.cxx
+++ b/oox/source/export/ColorPropertySet.cxx
@@ -108,13 +108,20 @@ Reference< XPropertySetInfo > SAL_CALL 
ColorPropertySet::getPropertySetInfo()
 return m_xInfo;
 }
 
-void SAL_CALL ColorPropertySet::setPropertyValue( const OUString& /* 
aPropertyName */, const uno::Any& aValue )
+void SAL_CALL ColorPropertySet::setPropertyValue( const OUString& 
rPropertyName, const uno::Any& aValue )
 throw (UnknownPropertyException,
PropertyVetoException,
lang::IllegalArgumentException,
lang::WrappedTargetException,
uno::RuntimeException, std::exception)
 {
+if (rPropertyName != m_aColorPropName)
+{
+// trying to catch these cases in the next crash testing
+assert(false);
+return;
+}
+
 aValue >>= m_nColor;
 }
 
@@ -128,7 +135,10 @@ uno::Any SAL_CALL ColorPropertySet::getPropertyValue( 
const OUString& aPropertyN
 css::drawing::FillStyle aFillStyle = css::drawing::FillStyle_SOLID;
 return uno::makeAny(aFillStyle);
 }
-return uno::makeAny( m_nColor );
+else if (aPropertyName == m_aColorPropName)
+return uno::makeAny( m_nColor );
+
+throw UnknownPropertyException();
 }
 
 void SAL_CALL ColorPropertySet::addPropertyChangeListener( const OUString& /* 
aPropertyName */, const Reference< XPropertyChangeListener >& /* xListener */ )
@@ -199,6 +209,7 @@ uno::Any SAL_CALL ColorPropertySet::getPropertyDefault( 
const OUString& aPropert
 {
 if( aPropertyName.equals( m_aColorPropName ))
 return uno::makeAny( m_nDefaultColor );
+
 return uno::Any();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2016-04-07 Thread Tomaž Vajngerl

 vcl/source/window/toolbox.cxx |   32 
 1 file changed, 8 insertions(+), 24 deletions(-)

New commits:
commit 5a4b01f63d3f2a7d7d6fa8cf9ca6a328c5da7a6a
Author: TomaÅ¾ Vajngerl 
Date:   Fri Apr 8 11:39:51 2016 +0900

vcl: draw toolbox grip with ellipses instead of pixels, HiDPI

Previously the non-native grip was drawn manually with filling
(lots of) pixels to get kind-of 3D effect for grips. This is not
ideal for HiDPI and can also be slow on certain backends.

This commit simplifies grip drawing by just drawng ellipses
(circles actually). This makes it easy to extend the drawing to
support HiDPI scaling and it also looks better and simpler.

Change-Id: I9df192b69f7f920cececf12b40c1f70342e6d485

diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx
index eb3b005..34c722f 100644
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -286,28 +286,21 @@ void ToolBox::ImplDrawGrip(vcl::RenderContext& 
rRenderContext)
 
 const StyleSettings& rStyleSettings = 
rRenderContext.GetSettings().GetStyleSettings();
 rRenderContext.SetLineColor(rStyleSettings.GetShadowColor());
+rRenderContext.SetFillColor(rStyleSettings.GetShadowColor());
 
 Size aSz(GetOutputSizePixel());
+float fScaleFactor = rRenderContext.GetDPIScaleFactor();
 
 if (meAlign == WindowAlign::Top || meAlign == WindowAlign::Bottom)
 {
 int height = (int) (0.6 * aSz.Height() + 0.5);
 int i = (aSz.Height() - height) / 2;
 height += i;
-while( i <= height )
+while (i <= height)
 {
 int x = ImplGetDragWidth(this) / 2;
-
-rRenderContext.DrawPixel( Point(x, i), 
rStyleSettings.GetDarkShadowColor() );
-rRenderContext.DrawPixel( Point(x+1, i), 
rStyleSettings.GetShadowColor() );
-
-rRenderContext.DrawPixel( Point(x, i+1), 
rStyleSettings.GetShadowColor() );
-rRenderContext.DrawPixel( Point(x+1, i+1), 
rStyleSettings.GetFaceColor() );
-rRenderContext.DrawPixel( Point(x+2, i+1), Color(COL_WHITE) );
-
-rRenderContext.DrawPixel( Point(x+1, i+2), Color(COL_WHITE) );
-rRenderContext.DrawPixel( Point(x+2, i+2), Color(COL_WHITE) );
-i+=4;
+rRenderContext.DrawEllipse(Rectangle(Point(x, i), Size(2 * 
fScaleFactor, 2 * fScaleFactor)));
+i += 4 * fScaleFactor;
 }
 }
 else
@@ -315,20 +308,11 @@ void ToolBox::ImplDrawGrip(vcl::RenderContext& 
rRenderContext)
 int width = (int) (0.6 * aSz.Width() + 0.5);
 int i = (aSz.Width() - width) / 2;
 width += i;
-while( i <= width )
+while (i <= width)
 {
 int y = ImplGetDragWidth(this) / 2;
-
-rRenderContext.DrawPixel( Point(i, y), 
rStyleSettings.GetDarkShadowColor() );
-rRenderContext.DrawPixel( Point(i+1, y), 
rStyleSettings.GetShadowColor() );
-
-rRenderContext.DrawPixel( Point(i, y+1), 
rStyleSettings.GetShadowColor() );
-rRenderContext.DrawPixel( Point(i+1, y+1), 
rStyleSettings.GetFaceColor() );
-rRenderContext.DrawPixel( Point(i+2, y+1), Color(COL_WHITE) );
-
-rRenderContext.DrawPixel( Point(i+1, y+2), Color(COL_WHITE) );
-rRenderContext.DrawPixel( Point(i+2, y+2), Color(COL_WHITE) );
-i+=4;
+rRenderContext.DrawEllipse(Rectangle(Point(i, y), Size(2 * 
fScaleFactor, 2 * fScaleFactor)));
+i += 4 * fScaleFactor;
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99148] New: Freeze Row & Columns + Merged Cells = Frozen only one of merged rows

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99148

Bug ID: 99148
   Summary: Freeze Row & Columns + Merged Cells = Frozen only one
of merged rows
   Product: LibreOffice
   Version: 5.1.0.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: owdnx...@sharklasers.com

Created attachment 124174
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124174=edit
screenshot, note top row ...

I have:
1) Merged the top three rows
2) Split columns and rows, including a row split between rows 3 & 4
3) Frozen columns and rows

Bug: Going down the spreadsheet "Freezes" the top row, but not all three of the
merged cells across the rows.

PS: I have tried merging from the 1st AMD the 3rd rows, and the result is the
same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/UnitHTTP.hpp

2016-04-07 Thread Ashod Nakashian

 loolwsd/UnitHTTP.hpp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 703febc2e26962c88c5753476f04fc145a96aa8b
Author: Ashod Nakashian 
Date:   Thu Apr 7 20:29:27 2016 -0400

loolwsd: compatibility fixes with Poco master

Change-Id: Ide03cc4cce528fa15a9f6b6ba546477e557142fe
Reviewed-on: https://gerrit.libreoffice.org/23908
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/UnitHTTP.hpp b/loolwsd/UnitHTTP.hpp
index ea00b85..53694ff 100644
--- a/loolwsd/UnitHTTP.hpp
+++ b/loolwsd/UnitHTTP.hpp
@@ -55,8 +55,9 @@ public:
 { setURI(uri); }
 virtual std::istream& stream() override
 { return *(static_cast(nullptr)); }
-virtual bool expectContinue() const override
+virtual bool expectContinue() const /*override*/ // Some Poco version 
don't have this.
 { return false; }
+virtual bool secure() const { return true; }
virtual const SocketAddress& clientAddress() const override
 { return _clientAddress; }
virtual const SocketAddress& serverAddress() const override
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99147] New: Writer: can not change the value of line spacing

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99147

Bug ID: 99147
   Summary: Writer: can not change the value of line spacing
   Product: LibreOffice
   Version: 5.1.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jsz...@yeah.net

The "custom value" of "Line spacing" in Toolbar can not be changed.

when clicking on "Line spacing" icon in Toolbar, we can see "custom value"
field in the pop menu. If we chose the "proportional" line spacing, the "value"
field will display "100%", however, the "value" field can not be accessed, so
we can't change it to 125%, for example. For "at least", "leading" or "fixed",
the problem also exists.

However, we can change line spacing from menu "Formatting - Paragraph - Line
spacing"...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93341] loading calc is slow

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93341

Markus Mohrhard  changed:

   What|Removed |Added

 Attachment #117845|0   |1
is obsolete||

--- Comment #9 from Markus Mohrhard  ---
Comment on attachment 117845
  --> https://bugs.documentfoundation.org/attachment.cgi?id=117845
valgrind log of opening libre with file, saving one change, and exiting

valgrind is the wrong tool. callgrind(which is part of the valgrind tool suite)
is the only one that makes sense here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94792] Fileopen: performance regression for xlsx with chart (per Comment 4)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94792

Markus Mohrhard  changed:

   What|Removed |Added

   Keywords||perf

--- Comment #6 from Markus Mohrhard  ---
Please don't forget to tag performance problems as they can be easily missed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99146] Duplication of footer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99146

i.am.stack+libreoff...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99146] Duplication of footer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99146

--- Comment #4 from i.am.stack+libreoff...@gmail.com ---
Created attachment 124173
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124173=edit
Example

Here is an example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99146] Duplication of footer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99146

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jmadero@gmail.com
 Ever confirmed|0   |1

--- Comment #3 from Joel Madero  ---
Please attach an actual file demonstrating the problem then set to UNCONFIRMED.
THanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99146] Duplication of footer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99146

--- Comment #2 from i.am.stack+libreoff...@gmail.com ---
Confirmed bug on Ubuntu 15.10 with LibreOffice Impress 5.0.5.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99146] New: Duplication of footer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99146

Bug ID: 99146
   Summary: Duplication of footer
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: i.am.stack+libreoff...@gmail.com

Created attachment 124171
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124171=edit
Screen shot of pre-bug

Greetings,

I think I may have found a bug. I can reproduce quite easily on my Scientific
Linux 6 systems running LibreOffice Impress 5.1.1.3 (Had issue with 5.0 &
updated today to confirm bug still exists).

To reproduce:
Open new Impress document.
In the default window type blah for the title and window.
Insert-> Header and Footer... -> type blah in for the date and footer.
See screen shot PossibleBug_01.png.
Save as flat file fodp
Close window.
Reopen.
See screen shot PossibleBug_02.png.

Why is the footer duplicated??? Instead of showing "blah" it shows "blahblah"!

Save, close, and reopen. Now shows "blahblahblah"!!

Nothing I do makes that go away except for removing footer completely. 

Now, open the saved fodp file and open a new impress file. Copy the slides
over.
Footer is now correct! Hooray!!
Save as fodt. Close Impress. Open file again.
Footer is now duplicated again. :-(

I can not replicate if I save as odp. However, at work we save the
presentations in flat file format fodp in a Git repo for versioning/tracking.
Getting this fix would be very helpful.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99146] Duplication of footer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99146

--- Comment #1 from i.am.stack+libreoff...@gmail.com ---
Created attachment 124172
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124172=edit
screen shot of bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62355] Formula objects with widehat/widevector in Writer have wrong size, top of the hat/vector is cropped

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=62355

--- Comment #68 from hete...@gmail.com ---
LibreOffice 5.1.0.3, Windows 7 x64

widevec is shown with the arrow tip proportional to the width of the content,
making it unrecognizable when it is "too large"

http://i.imgur.com/5WDCSWF.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99115] SVG: Imported graphic has wrong colours

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99115

MM  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEW
  Component|Draw|LibreOffice
 Ever confirmed|0   |1

--- Comment #1 from MM  ---
Unconfirmed with v4.3.5.2 under ubuntu 14.04 x64.
Confirmed with v4.4.7.2 under ubuntu 14.04 x64.
Confirmed with v5.1.2.2 under ubuntu 14.04 x64.

Set as regression.
All components are affected, not only draw.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99145] pep8 compatibility of python codes

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99145

Joel Madero  changed:

   What|Removed |Added

 CC||jmadero@gmail.com
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42763] [FORMATTING] Option to clear style properties, fall back to "Inherit"

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=42763

--- Comment #8 from RGB  ---
Duplicated of Bug 41316? Anyway, it would be great to see something like this
implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99145] New: pep8 compatibility of python codes

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99145

Bug ID: 99145
   Summary: pep8 compatibility of python codes
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: skillPython
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ahmetcan.kepe...@gmail.com

There are some code written with python. (e.g. under ../sw/qa/python)
We can write python code considering pep8. (PEP8 is coding style of Python)

pep8 defined in here: https://www.python.org/dev/peps/pep-0008/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99144] New: Images resized incorrectly when Keep Ratio is checked

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99144

Bug ID: 99144
   Summary: Images resized incorrectly when Keep Ratio is checked
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marcos_van_...@hotmail.com

I load an image to Writer. Then I resize the height to a larger size using
Format Image, Keep Ratio is checked. The image is too wide to fit, so it gets
squashed in the horizontal direction (i.e., the aspect ratio changes). I then
resize it again, this time it fits in the horizontal direction, but it retains
the incorrect aspect ratio.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/dist

2016-04-07 Thread Henry Castro

 loleaflet/dist/loleaflet.html |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b6aeee816c66a725bb4283846fbf8c507e62af3f
Author: Henry Castro 
Date:   Thu Apr 7 17:33:14 2016 -0400

loleaflet: restore default example title

diff --git a/loleaflet/dist/loleaflet.html b/loleaflet/dist/loleaflet.html
index a74339a..bc6abfa 100644
--- a/loleaflet/dist/loleaflet.html
+++ b/loleaflet/dist/loleaflet.html
@@ -1,7 +1,7 @@
 
 
 
-Collabora Online
+Document Simple Example
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 2 commits - loolwsd/DocumentBroker.cpp loolwsd/LOOLWSD.cpp loolwsd/Makefile.am loolwsd/Storage.cpp loolwsd/Storage.hpp loolwsd/test loolwsd/Unit.hpp loolwsd/UnitHTTP.

2016-04-07 Thread Michael Meeks

 loolwsd/DocumentBroker.cpp   |   22 -
 loolwsd/LOOLWSD.cpp  |   36 +++---
 loolwsd/Makefile.am  |3 +
 loolwsd/Storage.cpp  |   28 +
 loolwsd/Storage.hpp  |   28 ++---
 loolwsd/Unit.hpp |   26 +++
 loolwsd/UnitHTTP.hpp |   70 +++
 loolwsd/test/Makefile.am |9 +++--
 loolwsd/test/UnitStorage.cpp |   46 
 loolwsd/test/run_unit.sh |2 -
 10 files changed, 227 insertions(+), 43 deletions(-)

New commits:
commit 7d62c74b8388170b3284e7128f19618b49853e10
Author: Michael Meeks 
Date:   Thu Apr 7 21:59:27 2016 +0100

Fix segv on failure to create a storage, and add unit test infra.

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 90f60bc..b8cfa61 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -81,7 +81,7 @@ DocumentBroker::DocumentBroker(const Poco::URI& uriPublic,
 void DocumentBroker::validate(const Poco::URI& uri)
 {
 Log::info("Validating: " + uri.toString());
-auto storage = createStorage("", "", uri);
+auto storage = StorageBase::create("", "", uri);
 if (storage == nullptr || !storage->getFileInfo(uri).isValid())
 {
 throw std::runtime_error("Invalid URI or access denied.");
@@ -111,15 +111,21 @@ bool DocumentBroker::load(const std::string& jailId)
 
 Log::info("jailPath: " + jailPath.toString() + ", jailRoot: " + jailRoot);
 
-auto storage = createStorage("", "", _uriPublic);
-const auto fileInfo = storage->getFileInfo(_uriPublic);
-_tileCache.reset(new TileCache(_uriPublic.toString(), 
fileInfo.ModifiedTime, _cacheRoot));
+auto storage = StorageBase::create("", "", _uriPublic);
+if (storage)
+{
+const auto fileInfo = storage->getFileInfo(_uriPublic);
+_tileCache.reset(new TileCache(_uriPublic.toString(), 
fileInfo.ModifiedTime, _cacheRoot));
+
+_storage = StorageBase::create(jailRoot, jailPath.toString(), 
_uriPublic);
 
-_storage = createStorage(jailRoot, jailPath.toString(), _uriPublic);
+const auto localPath = _storage->loadStorageFileToLocal();
+_uriJailed = Poco::URI(Poco::URI("file://"), localPath);
 
-const auto localPath = _storage->loadStorageFileToLocal();
-_uriJailed = Poco::URI(Poco::URI("file://"), localPath);
-return true;
+return true;
+}
+else
+return false;
 }
 
 bool DocumentBroker::save()
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 3c497db..08076c2 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -50,7 +50,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -93,6 +92,7 @@
 #include "IoUtil.hpp"
 #include "Util.hpp"
 #include "Unit.hpp"
+#include "UnitHTTP.hpp"
 
 using namespace LOOLProtocol;
 
@@ -240,7 +240,7 @@ class ClientRequestHandler: public HTTPRequestHandler
 {
 private:
 
-void handlePostRequest(HTTPServerRequest& request, HTTPServerResponse& 
response, const std::string& id)
+static void handlePostRequest(HTTPServerRequest& request, 
HTTPServerResponse& response, const std::string& id)
 {
 Log::info("Post request: [" + request.getURI() + "]");
 StringTokenizer tokens(request.getURI(), "/?");
@@ -425,7 +425,7 @@ private:
 }
 }
 
-void handleGetRequest(HTTPServerRequest& request, HTTPServerResponse& 
response, const std::string& id)
+static void handleGetRequest(HTTPServerRequest& request, 
HTTPServerResponse& response, const std::string& id)
 {
 Log::info("Starting GET request handler for session [" + id + "].");
 
@@ -546,7 +546,7 @@ private:
 }
 }
 
-void handleGetDiscovery(HTTPServerRequest& request, HTTPServerResponse& 
response)
+static void handleGetDiscovery(HTTPServerRequest& request, 
HTTPServerResponse& response)
 {
 DOMParser parser;
 DOMWriter writer;
@@ -583,6 +583,11 @@ public:
 
 void handleRequest(HTTPServerRequest& request, HTTPServerResponse& 
response) override
 {
+handleClientRequest(request,response);
+}
+
+static void handleClientRequest(HTTPServerRequest& request, 
HTTPServerResponse& response)
+{
 const auto id = LOOLWSD::GenSessionId();
 
 Util::setThreadName("client_ws_" + id);
@@ -632,6 +637,11 @@ public:
 
 void handleRequest(HTTPServerRequest& request, HTTPServerResponse& 
response) override
 {
+handlePrisonerRequest(request, response);
+}
+
+static void handlePrisonerRequest(HTTPServerRequest& request, 
HTTPServerResponse& response)
+{
 Util::setThreadName("prison_ws");
 
 Log::debug("Child connection with URI [" + request.getURI() + "].");
@@ -1395,6 +1405,8 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 int status = 0;
 while (!TerminationFlag && !LOOLWSD::DoTest)

[Libreoffice-commits] online.git: loleaflet/dist loolwsd/FileServer.hpp

2016-04-07 Thread Henry Castro

 loleaflet/dist/loleaflet.html |   23 +++--
 loolwsd/FileServer.hpp|   45 +-
 2 files changed, 52 insertions(+), 16 deletions(-)

New commits:
commit dd96c6a4de756505cc1d456272a4b279f5020b4d
Author: Henry Castro 
Date:   Thu Apr 7 17:16:40 2016 -0400

loolwsd: handle a POST request in loleaflet

diff --git a/loleaflet/dist/loleaflet.html b/loleaflet/dist/loleaflet.html
index 656fd0d..a74339a 100644
--- a/loleaflet/dist/loleaflet.html
+++ b/loleaflet/dist/loleaflet.html
@@ -1,7 +1,7 @@
 
 
 
-Document Simple Example
+Collabora Online
 
 
 
@@ -260,23 +260,16 @@

[Libreoffice-bugs] [Bug 99128] 'Save As' Dialog Window should allow re-size (window mode)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99128

--- Comment #3 from Rick Stockton  ---
Problem remains present on my PC after erasing my Profile, but I have a
workaround.

In my problem, I can see than handle, and my mouse cursor does change to <-->
on the handle and the borders as well. But moving the mouse has no effect on
the maximized window.

Workaround: If click the "hide folders" button, then the window is shrunk to a
much smaller size, and DOES become resizable.

Theory: Working a 1920*1080 screen at full resolution, plugged into a laptop
where the native screen is only 1400*900, there might be OS confusion about
reaching the "true edge" of the window border. (It might be partly or mostly
off-screen.)

Thanks for the hints - I am good with the RESOLVED/WORKSFORME closure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source

2016-04-07 Thread Noel Grandin

 basic/source/sbx/sbxarray.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ba95e61314fb310575fe1dfd035234f4d6d7ca02
Author: Noel Grandin 
Date:   Thu Apr 7 11:21:49 2016 +0200

fix bug in SbxArray::Merge

bug was recently introduced by
commit a5c232831395f8987a8395816c5a60105a52b6a0
"BASIC: Store directly SbxVarEntry in SbxArray"

bug was found by clang-tidy

Change-Id: Ibcce6d6024ac60eb143cd873760586a7f6231858
Reviewed-on: https://gerrit.libreoffice.org/23890
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/basic/source/sbx/sbxarray.cxx b/basic/source/sbx/sbxarray.cxx
index 11faaef..f78c376 100644
--- a/basic/source/sbx/sbxarray.cxx
+++ b/basic/source/sbx/sbxarray.cxx
@@ -343,7 +343,7 @@ void SbxArray::Merge( SbxArray* p )
 {
 // Take this element and clear the original.
 rEntry2.mpVar = rEntry1.mpVar;
-rEntry2.mpVar.Clear();
+rEntry1.mpVar.Clear();
 break;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97087] Timers and idles should have programmer comprehensible, unique names

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97087

--- Comment #4 from Commit Notification 
 ---
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e88ba02a70c3f2279ed7ceefeb94f843537bcf8e

tdf#97087 - Give Idles comprehensible and unique names

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/source

2016-04-07 Thread Takeshi Abe

 starmath/source/node.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 6f1df6dca04579dea5e54113cc9c0003ee98ebfe
Author: Takeshi Abe 
Date:   Tue Mar 29 16:48:51 2016 +0900

starmath: Assert that SmAlignNode must have only one child

Change-Id: Ia59e453040b121c27a1326ee4bdc8a7ccaa4074d
Reviewed-on: https://gerrit.libreoffice.org/23588
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index f7dec45..b0cecfa 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -1725,9 +1725,10 @@ void SmOperNode::Arrange(OutputDevice , const 
SmFormat )
 void SmAlignNode::Arrange(OutputDevice , const SmFormat )
 // set alignment within the entire subtree (including current node)
 {
-OSL_ENSURE(GetNumSubNodes() > 0, "Sm: missing subnode");
+assert(GetNumSubNodes() == 1);
 
 SmNode  *pNode = GetSubNode(0);
+assert(pNode);
 
 RectHorAlign  eHorAlign = RectHorAlign::Center;
 switch (GetToken().eType)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97087] Timers and idles should have programmer comprehensible, unique names

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97087

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|ToBeReviewed target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97087] Timers and idles should have programmer comprehensible, unique names

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97087

--- Comment #3 from Commit Notification 
 ---
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e943da4189e829c7b65b6d171bd6d16ca5e0b425

Fix simple typo in SAL_INFO tdf#97087

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98897] Open Remote File - Cannot Connect to Server via SSH

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98897

Eric  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0
 OS|Linux (All) |Windows (All)

--- Comment #7 from Eric  ---
I'm not sure what additional information you require?  Let me know and I'll
assist.

Note that I am running LibreOffice on the Windows 7 platform, not Linux.

I have just installed LibreOffice version 5.1.1.3 and the problem still
persists.

Remote File Type = SSH
--
We have a Linux server running a SSH service.  We can connect to the server
from any machine (including a Windows machine) using an SFTP Client and access
files - copy, delete, add files etc., so we know that remote SSH works OK.

Adding the same connection details to the "Remote Files" appears to add the
service but nothing is shown in the file list.

If I then try to "Edit Service" with the recently added service selected, the
pop-up dialog has a blank user name, displays the label, but there are no edit
boxes for the the other fields originally entered.  Re-entering the "User" name
does not restore the state of the greyed-out "OK" button.



Remote File Type = Google Drive
---
Using this option with a valid Google Drive account results in a "The specified
device is invalid" error dialog.


Eric

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source sd/source sfx2/source vcl/unx

2016-04-07 Thread Muhammet Kara

 cui/source/dialogs/cuigaldlg.cxx|2 +-
 cui/source/tabpages/backgrnd.cxx|2 +-
 sd/source/core/drawdoc4.cxx |2 +-
 sfx2/source/dialog/templdlg.cxx |2 +-
 vcl/unx/generic/print/genprnpsp.cxx |2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit e88ba02a70c3f2279ed7ceefeb94f843537bcf8e
Author: Muhammet Kara 
Date:   Thu Apr 7 11:02:03 2016 +0300

tdf#97087 - Give Idles comprehensible and unique names

Change-Id: I435d26c00f48506a3f6bfb22aae156e91636842a
Reviewed-on: https://gerrit.libreoffice.org/23887
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/cui/source/dialogs/cuigaldlg.cxx b/cui/source/dialogs/cuigaldlg.cxx
index a2abaad..92d5423 100644
--- a/cui/source/dialogs/cuigaldlg.cxx
+++ b/cui/source/dialogs/cuigaldlg.cxx
@@ -461,7 +461,7 @@ short ActualizeProgress::Execute()
 {
 short nRet;
 
-pIdle = new Idle;
+pIdle = new Idle("ActualizeProgressTimeout");
 pIdle->SetIdleHdl( LINK( this, ActualizeProgress, TimeoutHdl ) );
 pIdle->SetPriority( SchedulerPriority::LOWEST );
 pIdle->Start();
diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx
index 6504b11..2256096 100644
--- a/cui/source/tabpages/backgrnd.cxx
+++ b/cui/source/tabpages/backgrnd.cxx
@@ -951,7 +951,7 @@ void SvxBackgroundTabPage::ShowSelector()
 m_pBtnPosition->SetClickHdl( HDL(RadioClickHdl_Impl) );
 
 // delayed loading via timer (because of UI-Update)
-pPageImpl->pLoadIdle = new Idle;
+pPageImpl->pLoadIdle = new Idle("DelayedLoad");
 pPageImpl->pLoadIdle->SetPriority( SchedulerPriority::LOWEST );
 pPageImpl->pLoadIdle->SetIdleHdl(
 LINK( this, SvxBackgroundTabPage, LoadIdleHdl_Impl ) );
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx
index f02acee..e476ef3 100644
--- a/sd/source/core/drawdoc4.cxx
+++ b/sd/source/core/drawdoc4.cxx
@@ -772,7 +772,7 @@ void SdDrawDocument::StartOnlineSpelling(bool 
bForceSpelling)
 }
 
 mpOnlineSpellingList->seekShape(0);
-mpOnlineSpellingIdle = new Idle();
+mpOnlineSpellingIdle = new Idle("OnlineSpelling");
 mpOnlineSpellingIdle->SetIdleHdl( LINK(this, SdDrawDocument, 
OnlineSpellingHdl) );
 mpOnlineSpellingIdle->SetPriority(SchedulerPriority::LOWEST);
 mpOnlineSpellingIdle->Start();
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 86af63d..9bc9d6f 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -1535,7 +1535,7 @@ void SfxCommonTemplateDialog_Impl::Notify(SfxBroadcaster& 
/*rBC*/, const SfxHint
 {
 if(!pIdle)
 {
-pIdle=new Idle;
+pIdle=new Idle("SfxCommonTemplate");
 pIdle->SetPriority(SchedulerPriority::LOWEST);
 pIdle->SetIdleHdl(LINK(this,SfxCommonTemplateDialog_Impl,TimeOut));
 }
diff --git a/vcl/unx/generic/print/genprnpsp.cxx 
b/vcl/unx/generic/print/genprnpsp.cxx
index 45e3e16..d9799f2 100644
--- a/vcl/unx/generic/print/genprnpsp.cxx
+++ b/vcl/unx/generic/print/genprnpsp.cxx
@@ -1325,7 +1325,7 @@ void PrinterUpdate::update(SalGenericInstance )
 doUpdate();
 else if( ! pPrinterUpdateIdle )
 {
-pPrinterUpdateIdle = new Idle();
+pPrinterUpdateIdle = new Idle("PrinterUpdateTimer");
 pPrinterUpdateIdle->SetPriority( SchedulerPriority::LOWEST );
 pPrinterUpdateIdle->SetIdleHdl( LINK( nullptr, PrinterUpdate, 
UpdateTimerHdl ) );
 pPrinterUpdateIdle->Start();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2016-04-07 Thread Muhammet Kara

 vcl/source/app/svapp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e943da4189e829c7b65b6d171bd6d16ca5e0b425
Author: Muhammet Kara 
Date:   Thu Apr 7 10:09:46 2016 +0300

Fix simple typo in SAL_INFO tdf#97087

Change-Id: I925ff84c827b668d11cff8de13b0834dafc47e28
Reviewed-on: https://gerrit.libreoffice.org/23886
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 9c874a9..ef785b8 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -510,7 +510,7 @@ inline bool ImplYield(bool i_bWait, bool i_bAllEvents, 
sal_uLong const nReleased
 i_bWait && !pSVData->maAppData.mbAppQuit,
 i_bAllEvents, nReleased);
 
-SAL_INFO("vcl.schedule", "DoYield with " << (bHasActiveIdles ? "active 
idles" : "no ides") <<
+SAL_INFO("vcl.schedule", "DoYield with " << (bHasActiveIdles ? "active 
idles" : "no idles") <<
  " returns: " << (eResult == SalYieldResult::EVENT ? "processed 
event" : "timeout"));
 
 pSVData->maAppData.mnDispatchLevel--;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2016-04-07 Thread Takeshi Abe

 vcl/source/edit/textdat2.hxx |5 +++--
 vcl/source/edit/textdoc.hxx  |4 +++-
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit fa94cdc7fae33987b49985405d84a483010421f0
Author: Takeshi Abe 
Date:   Thu Apr 7 18:35:00 2016 +0900

vcl: Make it noncopyable by deleting copy ctor & co

Change-Id: Ia141d1d48d915f1ecc0351e47d7b9700891ebad2
Reviewed-on: https://gerrit.libreoffice.org/23891
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/vcl/source/edit/textdat2.hxx b/vcl/source/edit/textdat2.hxx
index 076d955..2788d36 100644
--- a/vcl/source/edit/textdat2.hxx
+++ b/vcl/source/edit/textdat2.hxx
@@ -174,12 +174,13 @@ private:
 boolmbInvalid;
 boolmbSimple;   // only type linearly
 
-TEParaPortion( const TEParaPortion& ) {;}
-
 public:
 TEParaPortion( TextNode* pNode );
 ~TEParaPortion();
 
+TEParaPortion( const TEParaPortion& ) = delete;
+void operator=( const TEParaPortion& ) = delete;
+
 boolIsInvalid() const   { return mbInvalid; }
 boolIsSimpleInvalid() const { return mbSimple; }
 voidSetNotSimpleInvalid()   { mbSimple = false; }
diff --git a/vcl/source/edit/textdoc.hxx b/vcl/source/edit/textdoc.hxx
index 4e7097c..91ff2ac 100644
--- a/vcl/source/edit/textdoc.hxx
+++ b/vcl/source/edit/textdoc.hxx
@@ -67,7 +67,6 @@ private:
 OUStringmaText;
 TextCharAttribList  maCharAttribs;
 
-TextNode( const TextNode& ) {;}
 protected:
 voidExpandAttribs( sal_Int32 nIndex, sal_Int32 nNewChars );
 voidCollapsAttribs( sal_Int32 nIndex, sal_Int32 nDelChars 
);
@@ -75,6 +74,9 @@ protected:
 public:
 TextNode( const OUString& rText );
 
+TextNode( const TextNode& ) = delete;
+void operator=( const TextNode& ) = delete;
+
 const OUString& GetText() const { return maText; }
 
 const TextCharAttrib&   GetCharAttrib(sal_uInt16 nPos) const  { return 
maCharAttribs.GetAttrib(nPos); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/unx

2016-04-07 Thread Caolán McNamara

 vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx |   30 ++
 1 file changed, 2 insertions(+), 28 deletions(-)

New commits:
commit 70cc48f17a61296021c035f351c3db68bc5e08ad
Author: CaolÃ¡n McNamara 
Date:   Thu Apr 7 21:02:37 2016 +0100

gtk3: the list/combo box hack to get internal buttons no longer works

with gtk3-3.20.2

Change-Id: I608f3476a82233cb49e0b43c95f5a984d7c89c92

diff --git a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
index caaa767..ef3e61c 100644
--- a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
@@ -284,9 +284,7 @@ static GtkWidget* gDumbContainer;
 static GtkWidget* gSpinBox;
 static GtkWidget* gEntryBox;
 static GtkWidget* gComboBox;
-static GtkWidget* gComboBoxButtonWidget;
 static GtkWidget* gListBox;
-static GtkWidget* gListBoxButtonWidget;
 static GtkWidget* gMenuBarWidget;
 static GtkWidget* gMenuItemMenuBarWidget;
 static GtkWidget* gCheckMenuItemWidget;
@@ -2315,22 +2313,6 @@ void GtkData::deInitNWF()
 gtk_widget_destroy(gCacheWindow);
 }
 
-static void get_combo_box_entry_inner_widgets(GtkWidget *widget, gpointer)
-{
-if (GTK_IS_TOGGLE_BUTTON(widget))
-{
-gComboBoxButtonWidget = widget;
-}
-}
-
-void get_combo_box_inner_button(GtkWidget *widget, gpointer)
-{
-if (GTK_IS_TOGGLE_BUTTON(widget))
-{
-gListBoxButtonWidget = widget;
-}
-}
-
 GtkSalGraphics::GtkSalGraphics( GtkSalFrame *pFrame, GtkWidget *pWindow )
 : SvpSalGraphics(),
   mpFrame( pFrame ),
@@ -2436,21 +2418,13 @@ GtkSalGraphics::GtkSalGraphics( GtkSalFrame *pFrame, 
GtkWidget *pWindow )
 /* Combobox */
 gComboBox = gtk_combo_box_text_new_with_entry();
 getStyleContext(, gComboBox);
-/* Get ComboBox Entry and Button */
-gtk_container_forall(GTK_CONTAINER(gComboBox),
- get_combo_box_entry_inner_widgets,
- nullptr);
-mpComboboxButtonStyle = 
gtk_widget_get_style_context(gComboBoxButtonWidget);
+mpComboboxButtonStyle = createStyleContext(GtkControlPart::Button, 
mpComboboxStyle);
 
 /* Listbox */
 gListBox = gtk_combo_box_text_new();
 gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(gListBox), "sample");
 getStyleContext(, gListBox);
-/* Get ComboBox Button */
-gtk_container_forall(GTK_CONTAINER(gListBox),
- get_combo_box_inner_button,
- nullptr);
-mpListboxButtonStyle = gtk_widget_get_style_context(gListBoxButtonWidget);
+mpListboxButtonStyle = createStyleContext(GtkControlPart::Button, 
mpListboxStyle);
 
 /* Frames */
 mpFrameOutStyle = mpFrameInStyle = 
createStyleContext(GtkControlPart::FrameBorder);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

--- Comment #13 from spectre9009  ---
(In reply to Joel Madero from comment #11)
> With this I'm asking the original reporter to clarify:
> 1) Did this ever work EXACTLY as the wiki describes to do it;
> 2) If so - what version?

I often use this feature, so I can say that it works exactly as the wiki
describes in 4.3.7.2-2 and ALL older versions (this is the default behavior).
4.3.7.2-2 is the latest version of the preview is good (it works exactly).
Works exactly for 3.3 too.
Probably you are unable to move the image to the gallery by moving the cursor
at step 4 of the wiki. At step 4 of the wiki do not move the cursor until it
changes to copying form. Only then will you be able to drag the image to the
gallery.


> 3) Can you test daily and confirm the new bad behavior?
> http://dev-builds.libreoffice.org/daily/

Yes I can check for daily (a little later).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sc/source vcl/unx

2016-04-07 Thread Caolán McNamara

 sc/source/ui/unoobj/chart2uno.cxx |7 ++-
 vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx |5 -
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 42adbfea50385d5af68040bf67149d0007a1e7bf
Author: CaolÃ¡n McNamara 
Date:   Thu Apr 7 20:55:51 2016 +0100

don't need gComboBoxEntryWidget anymore

Change-Id: Ia48817eb1476ef6479c3b8e53666e63198cc9310

diff --git a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
index 131ab4d..caaa767 100644
--- a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
@@ -285,7 +285,6 @@ static GtkWidget* gSpinBox;
 static GtkWidget* gEntryBox;
 static GtkWidget* gComboBox;
 static GtkWidget* gComboBoxButtonWidget;
-static GtkWidget* gComboBoxEntryWidget;
 static GtkWidget* gListBox;
 static GtkWidget* gListBoxButtonWidget;
 static GtkWidget* gMenuBarWidget;
@@ -2322,10 +2321,6 @@ static void get_combo_box_entry_inner_widgets(GtkWidget 
*widget, gpointer)
 {
 gComboBoxButtonWidget = widget;
 }
-else if (GTK_IS_ENTRY(widget))
-{
-gComboBoxEntryWidget = widget;
-}
 }
 
 void get_combo_box_inner_button(GtkWidget *widget, gpointer)
commit dfa05574ea01eca00f69822f872146f0da5d0303
Author: CaolÃ¡n McNamara 
Date:   Thu Apr 7 16:48:45 2016 +0100

coverity#1358119 Uninitialized scalar field

arguably a false positive seeing as coverity ignores implicit default ctors 
but
not explicit ones

Change-Id: Id01f6a2728c197239563081c92275d44869b5d96

diff --git a/sc/source/ui/unoobj/chart2uno.cxx 
b/sc/source/ui/unoobj/chart2uno.cxx
index d331f2c..84bbe70 100644
--- a/sc/source/ui/unoobj/chart2uno.cxx
+++ b/sc/source/ui/unoobj/chart2uno.cxx
@@ -148,7 +148,12 @@ struct TokenTable
 TokenTable(const TokenTable&) = delete;
 const TokenTable& operator=(const TokenTable&) = delete;
 
-TokenTable() = default;
+TokenTable()
+: mnRowCount(0)
+, mnColCount(0)
+{
+}
+
 void init( SCCOL nColCount, SCROW nRowCount )
 {
 mnColCount = nColCount;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - framework/inc framework/source

2016-04-07 Thread Stephan Bergmann

 framework/inc/classes/converter.hxx   |2 
 framework/inc/classes/filtercachedata.hxx |   14 +--
 framework/inc/classes/protocolhandlercache.hxx|2 
 framework/inc/stdtypes.h  |   18 
 framework/source/accelerators/presethandler.cxx   |4 -
 framework/source/accelerators/storageholder.cxx   |   20 ++---
 framework/source/fwi/classes/converter.cxx|4 -
 framework/source/fwi/classes/protocolhandlercache.cxx |2 
 framework/source/inc/accelerators/keymapping.hxx  |4 -
 framework/source/inc/accelerators/presethandler.hxx   |4 -
 framework/source/inc/accelerators/storageholder.hxx   |2 
 framework/source/jobs/jobexecutor.cxx |6 -
 framework/source/services/pathsettings.cxx|   70 +-
 13 files changed, 66 insertions(+), 86 deletions(-)

New commits:
commit a0c96b0aa845866ce412427a55a25941712ab3cf
Author: Stephan Bergmann 
Date:   Thu Apr 7 21:50:52 2016 +0200

Remove unused Int32HashCode

Change-Id: I0f43db050155b231dda8f78ed8f8144609c7125b

diff --git a/framework/inc/stdtypes.h b/framework/inc/stdtypes.h
index 0f1f28f..9cc1807 100644
--- a/framework/inc/stdtypes.h
+++ b/framework/inc/stdtypes.h
@@ -38,14 +38,6 @@ namespace framework{
 Own hash functions used for stl-structures ... e.g. hash tables/maps ...
 */
 
-struct Int32HashCode
-{
-size_t operator()( const ::sal_Int32& nValue ) const
-{
-return (size_t)nValue;
-}
-};
-
 struct KeyEventHashCode
 {
 size_t operator()( const css::awt::KeyEvent& aEvent ) const
commit 031d314eae926244246565b401d86396eb5b73d6
Author: Stephan Bergmann 
Date:   Thu Apr 7 21:49:06 2016 +0200

Just use the hash default

Change-Id: Ice2c0cbf382997c2d07cc8cd4a7b085a153fffef

diff --git a/framework/inc/stdtypes.h b/framework/inc/stdtypes.h
index dd0afe9..0f1f28f 100644
--- a/framework/inc/stdtypes.h
+++ b/framework/inc/stdtypes.h
@@ -38,14 +38,6 @@ namespace framework{
 Own hash functions used for stl-structures ... e.g. hash tables/maps ...
 */
 
-struct ShortHashCode
-{
-size_t operator()( const ::sal_Int16& nShort ) const
-{
-return (size_t)nShort;
-}
-};
-
 struct Int32HashCode
 {
 size_t operator()( const ::sal_Int32& nValue ) const
diff --git a/framework/source/inc/accelerators/keymapping.hxx 
b/framework/source/inc/accelerators/keymapping.hxx
index 4edc268..d86917e 100644
--- a/framework/source/inc/accelerators/keymapping.hxx
+++ b/framework/source/inc/accelerators/keymapping.hxx
@@ -55,9 +55,7 @@ class KeyMapping
 typedef std::unordered_map 
Identifier2CodeHash;
 
 /** @short  hash structure to map key codes to identifier. */
-typedef std::unordered_map< sal_Int16,
-OUString  ,
-ShortHashCode > Code2IdentifierHash;
+typedef std::unordered_map Code2IdentifierHash;
 
 // member
 
commit 4be81de0d623571d81c167f326dfb913fdb08df6
Author: Stephan Bergmann 
Date:   Thu Apr 7 21:44:02 2016 +0200

Resolve OUStringList typedef

Change-Id: Ifb5dc5128b5619abb83eea427c7fb1115fd825f3

diff --git a/framework/inc/classes/converter.hxx 
b/framework/inc/classes/converter.hxx
index 3409403..cf8adf1 100644
--- a/framework/inc/classes/converter.hxx
+++ b/framework/inc/classes/converter.hxx
@@ -39,7 +39,7 @@ class FWI_DLLPUBLIC Converter
 static css::uno::Sequence< css::beans::NamedValue >
convert_seqPropVal2seqNamedVal  ( const css::uno::Sequence< 
css::beans::PropertyValue >& lSource );
 
 // Seq => Vector
-static OUStringList
convert_seqOUString2OUStringList( const css::uno::Sequence< OUString >& 
  lSource );
+static std::vector convert_seqOUString2OUStringList( const 
css::uno::Sequence< OUString >&   lSource );
 
 static OUString 
convert_DateTime2ISO8601( const DateTime&   
 aSource );
 };
diff --git a/framework/inc/classes/filtercachedata.hxx 
b/framework/inc/classes/filtercachedata.hxx
index e16b73a..5f7f6a3 100644
--- a/framework/inc/classes/filtercachedata.hxx
+++ b/framework/inc/classes/filtercachedata.hxx
@@ -113,8 +113,8 @@ struct FileType
 OUStringsMediaType;
 OUStringsClipboardFormat;
 sal_Int32   nDocumentIconID;
-OUStringListlURLPattern;
-OUStringListlExtensions;
+std::vector lURLPattern;
+std::vector lExtensions;
 };
 
 // These struct describe a filter which is registered for one type.
@@ -179,7 +179,7 @@ struct Filter
 OUString sFilterService;
 OUString sUIComponent;

[Libreoffice-bugs] [Bug 99143] Libre office spreadsheet, table outline borders not able to highlight.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99143

BanuKumar  changed:

   What|Removed |Added

 CC||banusridhar...@gmail.com

--- Comment #1 from BanuKumar  ---
Created attachment 124170
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124170=edit
Outline borders not able to highlight with different border style in
spreadsheet

I am using Windows 64bit OS. I installed LibreOffice 5.1.1.3. I started working
in spreadsheet. After adding all values into the spreadsheet, i tried to give
different outline border for the table which i have updated in the spreadsheet.
If i try to change the outline border of my table, i can able to apply the
change for all and each cell not the outline as i have attached the screenshot.
Please have a look into this to change put or update the border of the table
with different style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/inc

2016-04-07 Thread Stephan Bergmann

 framework/inc/classes/filtercachedata.hxx |   12 ++--
 framework/inc/stdtypes.h  |6 --
 2 files changed, 6 insertions(+), 12 deletions(-)

New commits:
commit 02041335d89cfb23b59218c9201ff16baf423b81
Author: Stephan Bergmann 
Date:   Thu Apr 7 21:32:41 2016 +0200

vector::clear is just fine

Change-Id: I5d8ec98d437913861b584cf3077618a2d6b0a0be

diff --git a/framework/inc/classes/filtercachedata.hxx 
b/framework/inc/classes/filtercachedata.hxx
index 928ce99..e16b73a 100644
--- a/framework/inc/classes/filtercachedata.hxx
+++ b/framework/inc/classes/filtercachedata.hxx
@@ -86,8 +86,8 @@ struct FileType
 sClipboardFormat.clear();
 nDocumentIconID = 0;
 lUINames.clear();
-framework::free(lURLPattern);
-framework::free(lExtensions);
+lURLPattern.clear();
+lExtensions.clear();
 }
 
 inline FileType& impl_copy( const FileType& rCopy )
@@ -148,7 +148,7 @@ struct Filter
 nFileFormatVersion  = 0;
 sTemplateName.clear();
 lUINames.clear();
-framework::free(lUserData);
+lUserData.clear();
 }
 
 inline Filter& impl_copy( const Filter& rCopy )
@@ -205,7 +205,7 @@ struct Detector
 inline void impl_clear()
 {
 sName.clear();
-framework::free(lTypes);
+lTypes.clear();
 }
 
 inline Detector& impl_copy( const Detector& rCopy )
@@ -245,7 +245,7 @@ struct Loader
 {
 sName.clear();
 lUINames.clear();
-framework::free(lTypes);
+lTypes.clear();
 }
 
 inline Loader& impl_copy( const Loader& rCopy )
@@ -285,7 +285,7 @@ struct ContentHandler
 inline void impl_clear()
 {
 sName.clear();
-framework::free(lTypes);
+lTypes.clear();
 }
 
 inline ContentHandler& impl_copy( const ContentHandler& rCopy )
diff --git a/framework/inc/stdtypes.h b/framework/inc/stdtypes.h
index b87247e..c58c2b7 100644
--- a/framework/inc/stdtypes.h
+++ b/framework/inc/stdtypes.h
@@ -81,12 +81,6 @@ struct KeyEventEqualsFunc
 
 typedef ::std::vector< OUString > OUStringList;
 
-template 
-void free(std::vector& vec)
-{
-OUStringList().swap(vec);
-}
-
 /**
 Basic OUString hash.
 Key and values are OUStrings.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96887] windows / main-loop lock-up

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96887

--- Comment #9 from Michael Stahl  ---
Created attachment 124169
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124169=edit
dump of pending messages on main thread

this is with a tricky patch to replace the
GetMessageW(SAL_MSG_RELEASEWAITYIELD)
with a PeekMessage / Sleep(1) and then a debugger-enableable loop to print
results of GetMessage(0, 0) once it's deadlocked

it's truncated in the end because i put the fflush() in the wrong place :-/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99143] New: Libre office spreadsheet, table outline borders not able to highlight.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99143

Bug ID: 99143
   Summary: Libre office spreadsheet, table outline borders not
able to highlight.
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: banusridhar...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96887] windows / main-loop lock-up

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96887

--- Comment #8 from Michael Stahl  ---
Created attachment 124168
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124168=edit
stacks of where the PostMessage fails

this is with a patch that added some error checking on
PostMessageW(mpInstData->mhComWnd, SAL_MSG_RELEASEWAITYIELD, 0, 0)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93610] cannot flip .PNG properly in Writer and Draw with LXDE

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93610

--- Comment #21 from Viruch Hemapanpairo  ---
Also the problem still UNSOLVED in 
Version: 5.0.6.0.0+
Build ID: f25eca3f230c170b46d7ce9f40842161a50b1883
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-5-0, Time:
2016-04-04_08:22:20
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/inc

2016-04-07 Thread Stephan Bergmann

 framework/inc/classes/protocolhandlercache.hxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit b24937c11477af44789c3c80d1d79a966895dc44
Author: Stephan Bergmann 
Date:   Thu Apr 7 21:21:10 2016 +0200

Remove junk that erroneously remained in previous commit

Change-Id: I18ca0d4daf44eafe88d6f812fa17576edbfb8dfd

diff --git a/framework/inc/classes/protocolhandlercache.hxx 
b/framework/inc/classes/protocolhandlercache.hxx
index 61896c2..930ce17 100644
--- a/framework/inc/classes/protocolhandlercache.hxx
+++ b/framework/inc/classes/protocolhandlercache.hxx
@@ -61,8 +61,6 @@ struct FWI_DLLPUBLIC ProtocolHandler
 to search for a key by using a full qualified URL on list of all possible 
pattern keys.
 */
 typedef std::unordered_map PatternHash;
-FWI_DLLPUBLIC PatternHash::iterator findPatternKey(
-PatternHash const & hash, const OUString& sURL);
 
 /**
 This hash holds protocol handler structs by her names.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96887] windows / main-loop lock-up

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96887

Michael Stahl  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com,
   ||ke...@collabora.com

--- Comment #7 from Michael Stahl  ---
okay, with ALG's help i could reproduce this, though not very often.

it happens on CppunitTest_sc_subsequent_export_test, with
something else running (make check) to add more load.

there are several aspects to this problem, which is fundamentally
that the main thread's message queue fills up.

1. main thread retrieves some message and dispatches it,
   gets stuck in ImplSalYieldMutexAcquireWithWait() on GetMessage()
   holding mpSalWaitMutex

2. some timers go wild and post thousands of these messages
   1186 = SAL_MSG_TIMER_CALLBACK  (WM_USER+162)

3. pool threads in SalYieldMutexRelease() tries to
   PostMessage(SAL_MSG_RELEASEWAITYIELD)
   but the queue is full already and the result of PostMessage
   isn't checked so no message is posted;
   thread waits for main thread to release mpSalWaitMutex

4. deadlock


ALG has a plan to replace this SAL_MSG_RELEASEWAITYIELD with something better,
it turns out that there's a MsgWaitForMultipleObjects() function
that can wait for either a mutex (i.e. SalYieldMutex's m_mutex) to
be available or  (with QS_SENDMESSAGE) a SendMessage() to come in,
or a timeout, so that should cover all cases and we should be able
to get rid of mpSalWaitMutex.

that would fix this deadlock.

however the fact that the message queue can fill up in these parallel
file import tests is concerning; other PostMessages could get lost
and we basically never check that PostMessage() succeeds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/inc framework/source

2016-04-07 Thread Stephan Bergmann

 framework/inc/classes/protocolhandlercache.hxx|   10 +++---
 framework/source/fwi/classes/protocolhandlercache.cxx |   12 
 2 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 9a2dea064082465ba912391f637d4710ad355a64
Author: Stephan Bergmann 
Date:   Thu Apr 7 21:15:55 2016 +0200

dllexport class deriving from template means trouble with MSVC

Change-Id: I9d170168eac26c52fd6ca8d22124e8ff78b81226

diff --git a/framework/inc/classes/protocolhandlercache.hxx 
b/framework/inc/classes/protocolhandlercache.hxx
index cb9c66a..61896c2 100644
--- a/framework/inc/classes/protocolhandlercache.hxx
+++ b/framework/inc/classes/protocolhandlercache.hxx
@@ -60,13 +60,9 @@ struct FWI_DLLPUBLIC ProtocolHandler
 uno implementation names as value. Overloading of the index operator makes 
it possible
 to search for a key by using a full qualified URL on list of all possible 
pattern keys.
 */
-class FWI_DLLPUBLIC PatternHash : public std::unordered_map
-{
-/* interface */
-public:
-
-PatternHash::iterator findPatternKey( const OUString& sURL );
-};
+typedef std::unordered_map PatternHash;
+FWI_DLLPUBLIC PatternHash::iterator findPatternKey(
+PatternHash const & hash, const OUString& sURL);
 
 /**
 This hash holds protocol handler structs by her names.
diff --git a/framework/source/fwi/classes/protocolhandlercache.cxx 
b/framework/source/fwi/classes/protocolhandlercache.cxx
index ef48ef0..20b26f4 100644
--- a/framework/source/fwi/classes/protocolhandlercache.cxx
+++ b/framework/source/fwi/classes/protocolhandlercache.cxx
@@ -49,10 +49,12 @@ namespace framework{
 @return An iterator which points to the found item inside the hash or 
PatternHash::end()
 if no pattern match this given sURL.
  */
-PatternHash::iterator PatternHash::findPatternKey( const OUString& sURL )
+namespace {
+
+PatternHash::const_iterator findPatternKey(PatternHash const * hash, const 
OUString& sURL)
 {
-PatternHash::iterator pItem = this->begin();
-while( pItem!=this->end() )
+auto pItem = hash->begin();
+while( pItem!=hash->end() )
 {
 WildCard aPattern(pItem->first);
 if (aPattern.Matches(sURL))
@@ -62,6 +64,8 @@ PatternHash::iterator PatternHash::findPatternKey( const 
OUString& sURL )
 return pItem;
 }
 
+}
+
 /**
 @short  initialize static member of class HandlerCache
 @descr  We use a singleton pattern to implement this handler cache.
@@ -131,7 +135,7 @@ bool HandlerCache::search( const OUString& sURL, 
ProtocolHandler* pReturn ) cons
 
 SolarMutexGuard aGuard;
 
-PatternHash::const_iterator pItem = m_pPattern->findPatternKey(sURL);
+PatternHash::const_iterator pItem = findPatternKey(m_pPattern, sURL);
 if (pItem!=m_pPattern->end())
 {
 *pReturn = (*m_pHandler)[pItem->second];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

2016-04-07 Thread Michael Meeks

 loolwsd/test/UnitPrefork.cpp |   15 +--
 loolwsd/test/run_unit.sh |4 ++--
 2 files changed, 15 insertions(+), 4 deletions(-)

New commits:
commit 8d7a26547912b35b94d65f6bdd06baa9bea74289
Author: Michael Meeks 
Date:   Thu Apr 7 20:15:18 2016 +0100

Print preload time.

diff --git a/loolwsd/test/UnitPrefork.cpp b/loolwsd/test/UnitPrefork.cpp
index 6bca7b9..4133468 100644
--- a/loolwsd/test/UnitPrefork.cpp
+++ b/loolwsd/test/UnitPrefork.cpp
@@ -10,13 +10,19 @@
 #include 
 #include 
 #include 
+#include 
+
 #include "Util.hpp"
 #include "Unit.hpp"
 
+#include 
+using Poco::Timestamp;
+
 class UnitPrefork : public UnitHooks
 {
 int _numStarted;
 const int _numToPrefork;
+Timestamp _startTime;
 public:
 UnitPrefork()
 : _numStarted(0),
@@ -26,14 +32,19 @@ public:
 virtual void preSpawnCount(int ) override
 {
 numPrefork = _numToPrefork;
-Log::error("Hello world");
 }
-
 virtual void newChild() override
 {
 _numStarted++;
 if (_numStarted >= _numToPrefork + 1)
+{
 exitTest(TestResult::TEST_OK);
+
+Poco::Timestamp::TimeDiff elapsed = _startTime.elapsed();
+
+std::cout << "Launched " << _numStarted << " in "
+  << (1.0 * elapsed)/Poco::Timestamp::resolution() << 
std::endl;
+}
 }
 };
 
diff --git a/loolwsd/test/run_unit.sh b/loolwsd/test/run_unit.sh
index 8f2a79a..8c67750 100755
--- a/loolwsd/test/run_unit.sh
+++ b/loolwsd/test/run_unit.sh
@@ -9,8 +9,8 @@ echo > run_unit.sh.trs
 
 for tst in prefork; do
 tst_log="test_output/$tst.log"
-echo "Running test: $tst | $tst_log";
-if ../loolwsd --systemplate=${systemplate} --lotemplate="${LO_PATH}" 
--childroot="${jails}" --unitlib=".libs/unit-$tst.so" >& "$tst_log"; then
+echo "Running test: $tst | $tst_log ...";
+if ../loolwsd --systemplate=${systemplate} --lotemplate="${LO_PATH}" 
--childroot="${jails}" --unitlib=".libs/unit-$tst.so" 2> "$tst_log"; then
echo "Test $tst passed."
echo ":test-result: PASS $tst" >> run_unit.sh.trs
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99093] Wrong Data Validation in Calc

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99093

--- Comment #12 from Commit Notification 
 ---
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b9207f49f436a886bcb94ae902e16c47484b3cb

add test for tdf#99093

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2016-04-07 Thread Markus Mohrhard

 sc/qa/unit/data/xls/validation.xls |binary
 sc/qa/unit/subsequent_filters-test.cxx |   31 +++
 2 files changed, 31 insertions(+)

New commits:
commit 8b9207f49f436a886bcb94ae902e16c47484b3cb
Author: Markus Mohrhard 
Date:   Thu Apr 7 21:11:04 2016 +0200

add test for tdf#99093

Change-Id: Id47abea42867f418e80a40357baa5f6435ecbdd6

diff --git a/sc/qa/unit/data/xls/validation.xls 
b/sc/qa/unit/data/xls/validation.xls
new file mode 100644
index 000..46bbbf7
Binary files /dev/null and b/sc/qa/unit/data/xls/validation.xls differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index efd1859..8106d21 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -206,6 +206,7 @@ public:
 void testEditEngStrikeThroughXLSX();
 void testRefStringXLSX();
 void testHiddenSheetsXLSX();
+void testRelFormulaValidationXLS();
 
 void testBnc762542();
 
@@ -304,6 +305,7 @@ public:
 CPPUNIT_TEST(testErrorOnExternalReferences);
 CPPUNIT_TEST(testEditEngStrikeThroughXLSX);
 CPPUNIT_TEST(testRefStringXLSX);
+CPPUNIT_TEST(testRelFormulaValidationXLS);
 
 CPPUNIT_TEST(testBnc762542);
 
@@ -3197,6 +3199,35 @@ void ScFiltersTest::testHiddenSheetsXLSX()
 xDocSh->DoClose();
 }
 
+namespace {
+
+void checkValidationFormula(const ScAddress& rPos, ScDocument& rDoc, const 
OUString& rExpectedFormula)
+{
+const SfxUInt32Item* pItem = static_cast(rDoc.GetAttr(rPos, ATTR_VALIDDATA) );
+CPPUNIT_ASSERT(pItem);
+sal_uLong nKey = pItem->GetValue();
+const ScValidationData* pData = rDoc.GetValidationEntry(nKey);
+CPPUNIT_ASSERT(pData);
+
+OUString aFormula = pData->GetExpression(rPos, 0);
+CPPUNIT_ASSERT_EQUAL(rExpectedFormula, aFormula);
+}
+
+}
+
+void ScFiltersTest::testRelFormulaValidationXLS()
+{
+ScDocShellRef xDocSh = loadDoc("validation.", FORMAT_XLS);
+CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.Is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+checkValidationFormula(ScAddress(3, 4, 0), rDoc, "Sheet1.C5");
+checkValidationFormula(ScAddress(5, 8, 0), rDoc, "Sheet1.D7");
+
+xDocSh->DoClose();
+}
+
 ScFiltersTest::ScFiltersTest()
   : ScBootstrapFixture( "sc/qa/unit/data" )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 93610] cannot flip .PNG properly in Writer and Draw with LXDE

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93610

Joel Madero  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #22 from Joel Madero  ---
It's solved then. The commit is in 5.2. Closing as fixed.

We may or may not backport the commit depending on if it conflicts, how
intrusive it is to the code, etc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93610] cannot flip .PNG properly in Writer and Draw with LXDE

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93610

--- Comment #20 from Viruch Hemapanpairo  ---
Already tested

The problem is still UNSOLVED in :
Version: 5.1.3.0.0+
Build ID: 24635317f09ecf48e5d800147b6a2b95963b69a7
CPU Threads: 4; OS Version: Linux 3.13; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:libreoffice-5-1, Time:
2016-04-07_07:12:40
Locale: en-US (en_US.UTF-8)

The problem is already SOLVED in :
Version: 5.2.0.0.alpha0+
Build ID: 641840dc0f63d23acceb7edd833f4a31f216009d
CPU Threads: 4; OS Version: Linux 3.13; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-04-07_00:27:01
Locale: en-US (en_US.UTF-8)

Thanks
Viruch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 6 commits - loleaflet/.gitignore loolwsd/configure.ac loolwsd/.gitignore loolwsd/LOOLKit.hpp loolwsd/LOOLWSD.cpp loolwsd/Makefile.am loolwsd/test loolwsd/Unit.cpp loo

2016-04-07 Thread Michael Meeks

 loleaflet/.gitignore |1 
 loolwsd/.gitignore   |   44 +++-
 loolwsd/LOOLKit.hpp  |1 
 loolwsd/LOOLWSD.cpp  |   31 --
 loolwsd/Makefile.am  |4 +
 loolwsd/Unit.cpp |   90 ++
 loolwsd/Unit.hpp |   53 +
 loolwsd/Util.cpp |   91 ---
 loolwsd/configure.ac |   37 +
 loolwsd/test/.gitignore  |   10 ++--
 loolwsd/test/Makefile.am |   50 ++-
 loolwsd/test/UnitPrefork.cpp |   45 +
 loolwsd/test/run_unit.sh |   25 +++
 13 files changed, 430 insertions(+), 52 deletions(-)

New commits:
commit cd47b5e044893994a534c7b94b3fa11b87cfaeca
Author: Michael Meeks 
Date:   Thu Apr 7 17:43:26 2016 +0100

Signal safe signal handlers.

diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index 2d73562..678b1d7 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -18,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -89,6 +90,8 @@ namespace rng
 }
 }
 
+static char LogPrefix[256] = { '\0' };
+
 namespace Log
 {
 static const Poco::Int64 epochStart = 
Poco::Timestamp().epochMicroseconds();
@@ -135,7 +138,6 @@ namespace Log
 return stream.str();
 }
 
-
 void initialize(const std::string& name)
 {
 Source.name = name;
@@ -143,6 +145,8 @@ namespace Log
 oss << Source.name << '-'
 << std::setw(5) << std::setfill('0') << Poco::Process::id();
 Source.id = oss.str();
+assert (sizeof (LogPrefix) > strlen(oss.str().c_str()) + 1);
+strcpy(LogPrefix, oss.str().c_str());
 
 auto channel = (isatty(fileno(stdout)) || std::getenv("LOOL_LOGCOLOR")
  ? static_cast(new 
Poco::ColorConsoleChannel())
@@ -356,19 +360,38 @@ namespace Util
 }
 }
 
+// We need a signal safe means of writing messages
+//   $ man 7 signal
+static
+void log_signal(const char *message)
+{
+while (true) {
+int length = strlen(message);
+int written = write (STDERR_FILENO, message, length);
+if (written < 0)
+{
+if (errno == EINTR)
+continue; // ignore.
+else
+break;
+}
+message += written;
+if (message[0] == '\0')
+break;
+}
+}
+
 static
 void handleTerminationSignal(const int signal)
 {
 if (!TerminationFlag)
 {
-// Poco::Log takes a lock that isn't recursive.
-// If we are signaled while having that lock,
-// logging again will deadlock on it.
 TerminationFlag = true;
 
-Log::info() << "Termination signal received: "
-<< Util::signalName(signal) << " "
-<< strsignal(signal) << Log::end;
+log_signal(LogPrefix);
+log_signal(" Termination signal received: ");
+log_signal(strsignal(signal));
+log_signal("\n");
 }
 }
 
@@ -386,19 +409,19 @@ namespace Util
 sigaction(SIGHUP, , nullptr);
 }
 
+static char FatalGdbString[256] = { '\0' };
+
 static
 void handleFatalSignal(const int signal)
 {
-Log::error() << "Fatal signal received: "
- << Util::signalName(signal) << " "
- << strsignal(signal) << Log::end;
+log_signal(LogPrefix);
+log_signal(" Fatal signal received: ");
+log_signal(strsignal(signal));
+log_signal("\n");
 
 if (std::getenv("LOOL_DEBUG"))
 {
-Log::error() << "\nFatal signal! Attach debugger with:\n"
- << "sudo gdb --pid=" << Poco::Process::id() << "\n or 
\n"
- << "sudo gdb --q --n --ex 'thread apply all backtrace 
full' --batch --pid="
- << Poco::Process::id() << "\n" << Log::end;
+log_signal(FatalGdbString);
 sleep(30);
 }
 
@@ -426,6 +449,16 @@ namespace Util
 sigaction(SIGABRT, , NULL);
 sigaction(SIGILL, , NULL);
 sigaction(SIGFPE, , NULL);
+
+// prepare this in advance just in case.
+std::ostringstream stream;
+stream << "\nFatal signal! Attach debugger with:\n"
+   << "sudo gdb --pid=" << Poco::Process::id() << "\n or \n"
+   << "sudo gdb --q --n --ex 'thread apply all backtrace full' 
--batch --pid="
+   << Poco::Process::id() << "\n";
+std::string streamStr = stream.str();
+assert (sizeof (FatalGdbString) > strlen(streamStr.c_str()) + 1);
+strcpy(FatalGdbString, streamStr.c_str());
 }
 
 int getChildStatus(const int code)
commit

[Libreoffice-bugs] [Bug 99142] LibreOffice 5.0.5.2. crashes every 2 mins, 4.4.7.2. worked fine

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99142

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jmadero@gmail.com
 Resolution|--- |INVALID

--- Comment #2 from Joel Madero  ---
This really isn't a workable bug report. 

Closing as INVALID. Please read the following guides as to how to make a proper
report: https://wiki.documentfoundation.org/QA/BugReport#Good_Reports

Please report a new clean report that clearly explains the problem. Provide
your OS, your versions of LibreOffice, a sample document, explain if this
happens with all documents or just a single document (if a single document
attach that document).

Also test with a fresh profile: https://wiki.documentfoundation.org/UserProfile

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99142] LibreOffice 5.0.5.2. crashes every 2 mins, 4.4.7.2. worked fine

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99142

--- Comment #1 from penshy...@outlook.com ---
I was cutting from one Calc sheet and pasting into another. Crash after 2 mins.
Windows error says LibreOffice has quit working and will be shut down. Document
recovery works, start again, same thing after about another 2 mins.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99142] New: LibreOffice 5.0.5.2. crashes every 2 mins, 4.4.7.2. worked fine

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99142

Bug ID: 99142
   Summary: LibreOffice 5.0.5.2. crashes every 2 mins, 4.4.7.2.
worked fine
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: penshy...@outlook.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

--- Comment #12 from Joel Madero  ---
It would also be really nice if you installed something like 3.3 to really
confirm that it worked then. Please give us exact reproducible steps - you can
read the wiki provided by Buovjaga and carefully compare what you're doing to
what the wiki says to do (again, using 3.3, or maybe 4.0 would work). I just
want to get 100% confirmation that this is a known regression using precisely
identical steps.

http://downloadarchive.documentfoundation.org/libreoffice/old/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

Joel Madero  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #11 from Joel Madero  ---
Bodhi Linux
Version: 5.2.0.0.alpha0+
Build ID: ef34535ceb60d7d63b8d8671e4c6e9e43ffbd17d
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-03-27_09:53:05
Locale: en-US (en_US.UTF-8)

On this version I can no longer drag the image at all into the gallery. 


So to summarize:
5.0.2.2: Confirmed
5.2 (from 2-3 weeks ago): Confirmed
5.2 daily (today): Can no long drag
3.3: Cannot drag image into the gallery


With this I'm asking the original reporter to clarify:
1) Did this ever work EXACTLY as the wiki describes to do it;
2) If so - what version?
3) Can you test daily and confirm the new bad behavior?
http://dev-builds.libreoffice.org/daily/

Marking as NEEDINFO - once clarification has happened please set back to NEW.
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 8 commits - loolwsd/Admin.cpp loolwsd/ChildProcessSession.cpp loolwsd/Common.hpp loolwsd/IoUtil.cpp loolwsd/IoUtil.hpp loolwsd/LOOLKit.cpp loolwsd/LOOLWSD.cpp

2016-04-07 Thread Tor Lillqvist

 loolwsd/Admin.cpp   |7 +
 loolwsd/ChildProcessSession.cpp |4 ---
 loolwsd/Common.hpp  |1 
 loolwsd/IoUtil.cpp  |   50 
 loolwsd/IoUtil.hpp  |7 -
 loolwsd/LOOLKit.cpp |   14 ---
 loolwsd/LOOLWSD.cpp |   23 +-
 7 files changed, 27 insertions(+), 79 deletions(-)

New commits:
commit c71d12ae63b43636f9424632a9132305036c1d26
Author: Tor Lillqvist 
Date:   Thu Apr 7 20:22:32 2016 +0300

Process name and id are already part of each logging output line

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 5dee1a9..50637ec 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -1005,7 +1005,7 @@ void lokit_main(const std::string& childRoot,
 std::exit(Application::EXIT_SOFTWARE);
 }
 
-Log::info("loolkit [" + std::to_string(Process::id()) + "] is ready.");
+Log::info("Process is ready.");
 
 // Open websocket connection between the child process and WSD.
 HTTPClientSession cs("127.0.0.1", MASTER_PORT_NUMBER);
commit 557ca90be14b495a27007883038f951426ee6b3e
Author: Tor Lillqvist 
Date:   Thu Apr 7 20:18:22 2016 +0300

Remove unused IoUtil::readMessage()

diff --git a/loolwsd/IoUtil.cpp b/loolwsd/IoUtil.cpp
index 871f0dd..35a8e24 100644
--- a/loolwsd/IoUtil.cpp
+++ b/loolwsd/IoUtil.cpp
@@ -244,27 +244,6 @@ ssize_t readFIFO(int pipe, char* buffer, ssize_t size)
 return bytes;
 }
 
-ssize_t readMessage(const int pipe, char* buffer, const ssize_t size, const 
size_t timeoutSec)
-{
-struct pollfd pollPipe;
-
-pollPipe.fd = pipe;
-pollPipe.events = POLLIN;
-pollPipe.revents = 0;
-
-const int nPoll = poll(, 1, timeoutSec * 1000);
-if ( nPoll < 0 )
-return -1;
-
-if ( nPoll == 0 )
-errno = ETIME;
-
-if( (pollPipe.revents & POLLIN) != 0 )
-return readFIFO(pipe, buffer, size);
-
-return -1;
-}
-
 /// Reads a single line from a pipe.
 /// Returns 0 for timeout, <0 for error, and >0 on success.
 /// On success, line will contain the read message.
diff --git a/loolwsd/IoUtil.hpp b/loolwsd/IoUtil.hpp
index c01e814..4ad06f5 100644
--- a/loolwsd/IoUtil.hpp
+++ b/loolwsd/IoUtil.hpp
@@ -40,9 +40,6 @@ namespace IoUtil
 
 ssize_t readFIFO(int pipe, char* buffer, ssize_t size);
 
-ssize_t readMessage(const int pipe, char* buffer, const ssize_t size,
-const size_t timeoutSec = CHILD_TIMEOUT_SECS);
-
 class PipeReader
 {
 public:
commit 16034f66853947b309a610c49779466e68b56f50
Author: Tor Lillqvist 
Date:   Thu Apr 7 20:09:35 2016 +0300

Bin unused INTERVAL_PROBES

diff --git a/loolwsd/Common.hpp b/loolwsd/Common.hpp
index 89e780b..1423251 100644
--- a/loolwsd/Common.hpp
+++ b/loolwsd/Common.hpp
@@ -18,7 +18,6 @@ constexpr int MAX_SESSIONS = 1024;
 
 constexpr int DEFAULT_CLIENT_PORT_NUMBER = 9980;
 constexpr int MASTER_PORT_NUMBER = 9981;
-constexpr int INTERVAL_PROBES = 10;
 constexpr int MAINTENANCE_INTERVAL = 1;
 constexpr int CHILD_TIMEOUT_SECS = 10;
 constexpr int POLL_TIMEOUT_MS = 1000;
commit 4ed3393f164fd55f6c4ff9a227cbb5972600966d
Author: Tor Lillqvist 
Date:   Thu Apr 7 20:03:26 2016 +0300

Nothing ever passed for the pollTimeoutMs parameter so use the default 
value in-line

diff --git a/loolwsd/IoUtil.cpp b/loolwsd/IoUtil.cpp
index 632d2bc..871f0dd 100644
--- a/loolwsd/IoUtil.cpp
+++ b/loolwsd/IoUtil.cpp
@@ -40,13 +40,12 @@ namespace IoUtil
 void SocketProcessor(std::shared_ptr ws,
  Poco::Net::HTTPResponse& response,
  std::function handler,
- std::function stopPredicate,
- const size_t pollTimeoutMs)
+ std::function stopPredicate)
 {
 Log::info("SocketProcessor starting.");
 
 // Timeout given is in microseconds.
-const Poco::Timespan waitTime(pollTimeoutMs * 1000);
+const Poco::Timespan waitTime(POLL_TIMEOUT_MS * 1000);
 try
 {
 ws->setReceiveTimeout(0);
diff --git a/loolwsd/IoUtil.hpp b/loolwsd/IoUtil.hpp
index 42b1f8c..c01e814 100644
--- a/loolwsd/IoUtil.hpp
+++ b/loolwsd/IoUtil.hpp
@@ -26,8 +26,7 @@ namespace IoUtil
 void SocketProcessor(std::shared_ptr ws,
  Poco::Net::HTTPResponse& response,
  std::function handler,
- std::function stopPredicate,
- const size_t pollTimeoutMs = POLL_TIMEOUT_MS);
+ std::function stopPredicate);
 
 /// Call WebSocket::shutdown() ignoring Poco::IOException.
 void shutdownWebSocket(std::shared_ptr ws);
commit 584a8057813f1354238ae2d4f998be9a9004ec8e
Author: Tor Lillqvist 
Date:   Thu Apr 7 20:00:57 2016

[Libreoffice-bugs] [Bug 98912] Calc crashes when editing chart.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98912

--- Comment #7 from nj.hutchi...@sky.com ---
Contents of
C:\Users\User\AppData\Roaming\LibreOffice\4\cache\opengl_device.log:

DriverVersion: 10.18.13.5906
DriverDate: 11-24-2015
DeviceID: PCI\VEN_10DE_11C0_11C010B0_A1
AdapterVendorID: 0x10de
AdapterDeviceID: 0x11c0
AdapterSubsysID: 0x11c010b0
DeviceKey:
System\CurrentControlSet\Control\Video\{D1D67B5F-F815-4C6C-AAAD-B2438FF5A9D9}\
DeviceString: NVIDIA GeForce GTX 660

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99008] Scolling ODT file freezes LibreOffice and the desktop session

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99008

--- Comment #16 from Stanislav  ---
(In reply to Yousuf (Jay) Philips from comment #15)
> ... you'll have to wait until 5.1.3
> is released or use 5.0.

Understand. Unfortunately, users do not have neither Still nor the Fresh
LibreOffice releases in the current Debian official branches (stable and
testing, I mean). Therefore, it is impossible to install 5.0.x (Still) via
package into Debian infrastructure.

The release plan for LibreOffice and Debian are different, and there are no
obvious proposals as for Firefox ESR/Debian, for example:

"Mozilla releases new Firefox releases every 6 to 8 weeks.
In parallel of these rapid releases, Mozilla proposes a version called
ESR which is maintained for about 9 months.
On the contrary, Debian having a longer release cycle (about every two
years), release cycles don't align.
Because of the complexity of backporting security fixes, Debian cannot
maintain a deprecated ESR release.

To address this packaging issue, once a ESR cycle is over, Debian has
been accepting uploads of new ESR releases in the stable release." [1]

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815006

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98912] Calc crashes when editing chart.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98912

--- Comment #6 from Buovjaga  ---
(In reply to nj.hutchison from comment #5)
> CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 

This seems to be the key.

Copy and paste to us the contents of:
C:\Users\User\AppData\Roaming\LibreOffice\4\cache\opengl_device.log

Disable this option and restart LibreOffice and try to make it crash:
Tools - Options - LibreOffice - View - Use OpenGL for all rendering

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98912] Calc crashes when editing chart.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98912

nj.hutchi...@sky.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98912] Calc crashes when editing chart.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98912

--- Comment #5 from nj.hutchi...@sky.com ---
Info from About LibreOffice dialog:

Version: 5.1.1.3
Build ID: 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
Locale: en-GB (en_GB)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50879] form exported as pdf does not embed all required fonts

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=50879

--- Comment #22 from Peter Nagy  ---
This bug is still there in 5.0.5 and 5.1.1.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Justin L  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #28 from Justin L  ---
Created attachment 124167
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124167=edit
screenshot that belonged in comment 22 which documents the problem

confirmed in 12.04 that the bug is resolved now.
confirmed that 16.04 continues to work properly.
Marking as verified: fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47437] add a way to report missing words in the spell checker

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=47437

--- Comment #5 from Kruno  ---
(In reply to Kruno from comment #4)
> and that could send an automated email with missing
> word... 

On the second thought - that's very bed idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/inc framework/source

2016-04-07 Thread Stephan Bergmann

 framework/inc/classes/filtercachedata.hxx |6 ++--
 framework/inc/classes/protocolhandlercache.hxx|4 +-
 framework/inc/stdtypes.h  |   21 --
 framework/inc/uiconfiguration/graphicnameaccess.hxx   |2 -
 framework/inc/uielement/commandinfo.hxx   |2 -
 framework/inc/uielement/toolbarmanager.hxx|2 -
 framework/source/dispatch/dispatchinformationprovider.cxx |7 ++--
 framework/source/fwi/classes/protocolhandlercache.cxx |4 --
 framework/source/inc/accelerators/acceleratorcache.hxx|2 -
 framework/source/inc/accelerators/keymapping.hxx  |2 -
 framework/source/services/frame.cxx   |4 +-
 framework/source/services/pathsettings.cxx|2 -
 12 files changed, 17 insertions(+), 41 deletions(-)

New commits:
commit f57c9921de4d64fbe27e80e2e7c13dea23853089
Author: Stephan Bergmann 
Date:   Thu Apr 7 18:14:32 2016 +0200

Get rid of BaseHash wrapper (to unbreak Windows build)

Change-Id: Ieae7d6af7a4753958ebf2aeae9d2ae6fafe5efe9

diff --git a/framework/inc/classes/filtercachedata.hxx 
b/framework/inc/classes/filtercachedata.hxx
index f671678..928ce99 100644
--- a/framework/inc/classes/filtercachedata.hxx
+++ b/framework/inc/classes/filtercachedata.hxx
@@ -85,7 +85,7 @@ struct FileType
 sMediaType.clear();
 sClipboardFormat.clear();
 nDocumentIconID = 0;
-lUINames.free   ();
+lUINames.clear();
 framework::free(lURLPattern);
 framework::free(lExtensions);
 }
@@ -147,7 +147,7 @@ struct Filter
 nFlags  = 0;
 nFileFormatVersion  = 0;
 sTemplateName.clear();
-lUINames.free();
+lUINames.clear();
 framework::free(lUserData);
 }
 
@@ -244,7 +244,7 @@ struct Loader
 inline void impl_clear()
 {
 sName.clear();
-lUINames.free();
+lUINames.clear();
 framework::free(lTypes);
 }
 
diff --git a/framework/inc/classes/protocolhandlercache.hxx 
b/framework/inc/classes/protocolhandlercache.hxx
index 9537677..cb9c66a 100644
--- a/framework/inc/classes/protocolhandlercache.hxx
+++ b/framework/inc/classes/protocolhandlercache.hxx
@@ -60,7 +60,7 @@ struct FWI_DLLPUBLIC ProtocolHandler
 uno implementation names as value. Overloading of the index operator makes 
it possible
 to search for a key by using a full qualified URL on list of all possible 
pattern keys.
 */
-class FWI_DLLPUBLIC PatternHash : public BaseHash< OUString >
+class FWI_DLLPUBLIC PatternHash : public std::unordered_map
 {
 /* interface */
 public:
@@ -71,7 +71,7 @@ class FWI_DLLPUBLIC PatternHash : public BaseHash< OUString >
 /**
 This hash holds protocol handler structs by her names.
 */
-typedef BaseHash< ProtocolHandler > HandlerHash;
+typedef std::unordered_map 
HandlerHash;
 
 /**
 @short  this hash makes it easy to find a protocol handler by 
using his uno implementation name.
diff --git a/framework/inc/stdtypes.h b/framework/inc/stdtypes.h
index 407ecfa..b87247e 100644
--- a/framework/inc/stdtypes.h
+++ b/framework/inc/stdtypes.h
@@ -88,29 +88,10 @@ void free(std::vector& vec)
 }
 
 /**
-Basic hash based on a std::unordered_map() which provides key=[OUString] 
and value=[template type] pairs
-It implements some additional funtionality which can be useful but
-is missing at the normal hash implementation.
-*/
-template< class TType >
-class BaseHash : public std::unordered_map< OUString,
-TType  
,
-OUStringHash >
-{
-public:
-
-// the only way to free used memory really!
-void free()
-{
-BaseHash().swap( *this );// get rid of reserved capacity
-}
-};
-
-/**
 Basic OUString hash.
 Key and values are OUStrings.
 */
-typedef BaseHash< OUString > OUStringHashMap;
+typedef std::unordered_map OUStringHashMap;
 
 /**
 It can be used to map names (e.g. of properties) to her corresponding 
handles.
diff --git a/framework/inc/uiconfiguration/graphicnameaccess.hxx 
b/framework/inc/uiconfiguration/graphicnameaccess.hxx
index b299b84..b18ab5c 100644
--- a/framework/inc/uiconfiguration/graphicnameaccess.hxx
+++ b/framework/inc/uiconfiguration/graphicnameaccess.hxx
@@ -52,7 +52,7 @@ namespace framework
 throw(css::uno::RuntimeException, std::exception) override;
 
 private:
-typedef BaseHash< css::uno::Reference< css::graphic::XGraphic > > 
NameGraphicHashMap;
+typedef std::unordered_map

[Libreoffice-bugs] [Bug 99114] PDF export breaks glyph

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99114

--- Comment #10 from V Stuart Foote  ---
(In reply to sommerluk from comment #9)
> Operating system name: Microsoft Windows 10 Home
> Version: 10.0.10240 Build 10240
> 
> LibreOffice version info:
> Version: 5.1.1.3
> Build-ID: 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d
> CPU-Threats: 4; BS-Version: Windows 6.2; UI-Render: Standard; 
> Gebietsschema: de-DE (de_DE)
> 
> OpenGL: Not sure if this is the information that you want, but glview443.exe
> says that OpenGL 3.1 is available.

That was exactly what was needed, but it appears OpenGL is not the issue here.

Thanks for posting the EB Garamond 12 font--nice that it is SIL Open Font
License

Yes, I can reproduce on Windows 10 Pro 64-bit en-US with
Version: 5.1.2.2 (x64)
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
Locale: en-US (en_US)

STR

1. install linked EB Garamond 12 font
2. launch Writer  (disable OpenGL rendering and restart if needed)
3. write a couple lines of sample text--I used font name and multiple "m"s, in
the default Liberation Serif
4. copy lines, paste
5. change font for pasted selection to EB Garamond 12
6. save to .ODT
7. menu -> Export as PDF
8. in PDF dialog select lossless compression for images, and PDF/A-1a (ISO
19005-1) in general tab
9. export
10. open the resulting PDF in Adobe Acrobat Reader -- zoom resolution > 400%

Visual glitch in forming the right leg of the "m" as in attachment 124121

Various "print" to PDF methods (Adobe, MS, gs) do not exhibit same issue--so
believe issue is in LibreOffice's PDF composition.

Rendering glitch of the font on export to PDF is also present from Draw text
box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: writerfilter/source

2016-04-07 Thread Miklos Vajna

 writerfilter/source/dmapper/PropertyMap.cxx |   55 ++--
 writerfilter/source/dmapper/PropertyMap.hxx |3 +
 2 files changed, 39 insertions(+), 19 deletions(-)

New commits:
commit d56deaeb2a1e8007e50fc2334f416fddd4e3cde3
Author: Miklos Vajna 
Date:   Thu Apr 7 16:47:23 2016 +0200

tdf#99140 Factor out FloatingTableConversion() from CloseSectionGroup()

No logic changes intended, but makes it easier to add new rules when
making the decision.

Change-Id: I84d8e6a2b8a4b9ae6fe5cefd381292c2f68be45f
Reviewed-on: https://gerrit.libreoffice.org/23901
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/writerfilter/source/dmapper/PropertyMap.cxx 
b/writerfilter/source/dmapper/PropertyMap.cxx
index 56e99b6..ff8e5f3 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -1038,34 +1038,51 @@ void 
SectionPropertyMap::HandleMarginsHeaderFooter(DomainMapper_Impl& rDM_Impl)
 PrepareHeaderFooterProperties( false );
 }
 
+bool SectionPropertyMap::FloatingTableConversion(FloatingTableInfo& rInfo)
+{
+// Note that this is just a list of heuristics till sw core can have a
+// table that is floating and can span over multiple pages at the same
+// time.
+
+sal_Int32 nTextAreaWidth = GetPageWidth() - GetLeftMargin() - 
GetRightMargin();
+// Count the layout width of the table.
+sal_Int32 nTableWidth = rInfo.m_nTableWidth;
+sal_Int32 nLeftMargin = 0;
+if (rInfo.getPropertyValue("LeftMargin") >>= nLeftMargin)
+nTableWidth += nLeftMargin;
+sal_Int32 nRightMargin = 0;
+if (rInfo.getPropertyValue("RightMargin") >>= nRightMargin)
+nTableWidth += nRightMargin;
+
+// If the table is wider than the text area, then don't create a fly
+// for the table: no wrapping will be performed anyway, but multi-page
+// tables will be broken.
+if (nTableWidth < nTextAreaWidth)
+return true;
+
+// If the position is relative to the edge of the page, then we always
+// create the fly.
+if (rInfo.getPropertyValue("HoriOrientRelation") == 
text::RelOrientation::PAGE_FRAME)
+return true;
+
+// If there are columns, always create the fly, otherwise the columns would
+// restrict geometry of the table.
+if (ColumnCount() + 1 >= 2)
+return true;
+
+return false;
+}
+
 void SectionPropertyMap::CloseSectionGroup( DomainMapper_Impl& rDM_Impl )
 {
 // Text area width is known at the end of a section: decide if tables 
should be converted or not.
 std::vector& rPendingFloatingTables = 
rDM_Impl.m_aPendingFloatingTables;
-sal_Int32 nTextAreaWidth = GetPageWidth() - GetLeftMargin() - 
GetRightMargin();
 uno::Reference xBodyText( 
rDM_Impl.GetBodyText(), uno::UNO_QUERY );
 for (size_t i = 0; i < rPendingFloatingTables.size(); ++i)
 {
 FloatingTableInfo& rInfo = rPendingFloatingTables[i];
 
-// Count the layout width of the table.
-sal_Int32 nTableWidth = rInfo.m_nTableWidth;
-sal_Int32 nLeftMargin = 0;
-if (rInfo.getPropertyValue("LeftMargin") >>= nLeftMargin)
-nTableWidth += nLeftMargin;
-sal_Int32 nRightMargin = 0;
-if (rInfo.getPropertyValue("RightMargin") >>= nRightMargin)
-nTableWidth += nRightMargin;
-
-// If the table is wider than the text area, then don't create a fly
-// for the table: no wrapping will be performed anyway, but multi-page
-// tables will be broken.
-// If the position is relative to the edge of the page, then we always
-// create the fly.
-// If there are columns, always create the fly, otherwise the columns 
would
-// restrict geometry of the table.
-if ( ( rInfo.getPropertyValue("HoriOrientRelation") == 
text::RelOrientation::PAGE_FRAME ) ||
- nTableWidth < nTextAreaWidth || ColumnCount() + 1 >= 2 )
+if (FloatingTableConversion(rInfo))
 xBodyText->convertToTextFrame(rInfo.m_xStart, rInfo.m_xEnd, 
rInfo.m_aFrameProperties);
 }
 rPendingFloatingTables.clear();
diff --git a/writerfilter/source/dmapper/PropertyMap.hxx 
b/writerfilter/source/dmapper/PropertyMap.hxx
index a3a9be1..ac2b8b5 100644
--- a/writerfilter/source/dmapper/PropertyMap.hxx
+++ b/writerfilter/source/dmapper/PropertyMap.hxx
@@ -57,6 +57,7 @@ namespace com{namespace sun{namespace star{
 namespace writerfilter {
 namespace dmapper{
 class DomainMapper_Impl;
+struct FloatingTableInfo;
 
 enum BorderPosition
 {
@@ -267,6 +268,8 @@ class SectionPropertyMap : public PropertyMap
sal_Int32 nDistance,
sal_Int32 nOffsetFrom,
sal_uInt32 nLineWidth);
+/// Determintes if conversion of a given floating table is wanted or not.
+bool

[Libreoffice-bugs] [Bug 99090] Exported DOCX cannot be opened by Word 2013

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99090

raal  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98710] Crash with "show preview of fonts" enabled for combobox list with new DirectWrite rendering

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98710

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98710] Crash with "show preview of fonts" enabled for combobox list with new DirectWrite rendering

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98710

--- Comment #22 from Commit Notification 
 ---
Marco Cecchetti committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=92e33ae10d63b5acd8643d33c032dbb022bd75be

tdf#98710 - catch exception due to crash in dwrite

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98710] Crash with "show preview of fonts" enabled for combobox list with new DirectWrite rendering

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98710

--- Comment #21 from Michael Meeks  ---
pushed to master; would love to have it tested =) Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/win

2016-04-07 Thread Marco Cecchetti

 vcl/win/gdi/winlayout.cxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit 92e33ae10d63b5acd8643d33c032dbb022bd75be
Author: Marco Cecchetti 
Date:   Thu Apr 7 12:10:29 2016 +0200

tdf#98710 - catch exception due to crash in dwrite

Change-Id: I448b166866710825d2b3c582796c392436fe072e
Reviewed-on: https://gerrit.libreoffice.org/23892
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index 12df505..1ee9d02 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -4002,7 +4002,16 @@ bool D2DWriteTextOutRenderer::DrawGlyphs(const Point & 
origin, uint16_t * pGid,
 
 bool D2DWriteTextOutRenderer::GetDWriteFaceFromHDC(HDC hDC, IDWriteFontFace ** 
ppFontFace, float * lfSize) const
 {
-bool const succeeded = SUCCEEDED(mpGdiInterop->CreateFontFaceFromHdc(hDC, 
ppFontFace));
+bool succeeded = false;
+try
+{
+succeeded = SUCCEEDED(mpGdiInterop->CreateFontFaceFromHdc(hDC, 
ppFontFace));
+}
+catch (const std::exception& e)
+{
+SAL_WARN("vcl.gdi.opengl", "Error in dwrite while creating font face: 
" << e.what());
+return false;
+}
 
 if (succeeded)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99141] Font does disapear when printing

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99141

--- Comment #1 from Thierry Seewald  ---
Created attachment 124166
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124166=edit
file with two fonts, andika causing the pb.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/inc framework/Library_fwi.mk framework/source

2016-04-07 Thread Stephan Bergmann

 framework/Library_fwi.mk   |1 
 framework/inc/classes/propertysethelper.hxx|  193 -
 framework/source/fwi/classes/propertysethelper.cxx |  338 -
 framework/source/services/frame.cxx|  413 -
 4 files changed, 400 insertions(+), 545 deletions(-)

New commits:
commit e2ef26991681d6e24c32f08660382af4ca48475c
Author: Stephan Bergmann 
Date:   Thu Apr 7 17:33:26 2016 +0200

Fold PropertySetHelper into its only use, Frame

Change-Id: I148e15c2c91a985cd110f5589adbf26c102b1cfb

diff --git a/framework/Library_fwi.mk b/framework/Library_fwi.mk
index f48ef2d..5e82963 100644
--- a/framework/Library_fwi.mk
+++ b/framework/Library_fwi.mk
@@ -52,7 +52,6 @@ $(eval $(call gb_Library_use_libraries,fwi,\
 
 $(eval $(call gb_Library_add_exception_objects,fwi,\
 framework/source/fwi/classes/converter \
-framework/source/fwi/classes/propertysethelper \
 framework/source/fwi/classes/protocolhandlercache \
 framework/source/fwi/helper/mischelper \
 framework/source/fwi/helper/networkdomain \
diff --git a/framework/inc/classes/propertysethelper.hxx 
b/framework/inc/classes/propertysethelper.hxx
deleted file mode 100644
index e09c071..000
--- a/framework/inc/classes/propertysethelper.hxx
+++ /dev/null
@@ -1,193 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef INCLUDED_FRAMEWORK_INC_CLASSES_PROPERTYSETHELPER_HXX
-#define INCLUDED_FRAMEWORK_INC_CLASSES_PROPERTYSETHELPER_HXX
-
-#include 
-#include 
-#include 
-
-#include 
-#include 
-#include 
-#include 
-
-#include 
-#include 
-
-namespace framework{
-
-/** supports the API XPropertySet and XPropertySetInfo.
- *
- *  It must be used as baseclass. The internal list of supported
- *  properties can be changed every time so dynamic property set's
- *  can be implemented.
- *
- *  Further the derived and this base class share the same lock.
- *  So it's possible to be threadsafe if it's needed.
-*/
-class FWI_DLLPUBLIC PropertySetHelper : public css::beans::XPropertySet
-, public css::beans::XPropertySetInfo
-{
-
-/* types */
-protected:
-
-typedef BaseHash< css::beans::Property > TPropInfoHash;
-
-/* member */
-protected:
-
-PropertySetHelper::TPropInfoHash m_lProps;
-
-ListenerHash m_lSimpleChangeListener;
-ListenerHash m_lVetoChangeListener;
-
-// hold it weak ... otherwise this helper has to be "killed" 
explicitly .-)
-css::uno::WeakReference< css::uno::XInterface > m_xBroadcaster;
-
-TransactionManager& m_rTransactionManager;
-
-/* native interface */
-public:
-
-/** initialize new instance of this helper.
- *
- *  @param  pExternalTransactionManager
- *  this helper must be used as a baseclass ...
- *  but then it should synchronize its own calls
- *  with the same transaction manager then it's superclass.
- */
-PropertySetHelper(  osl::Mutex & mutex,
-TransactionManager*
 pExternalTransactionManager);
-
-/** free all needed memory.
- */
-virtual ~PropertySetHelper();
-
-/** set a new owner for this helper.
- *
- *  This owner is used as source for all broadcasted events.
- *  Further we hold it weak, because we don't wish to be disposed() .-)
- */
-void impl_setPropertyChangeBroadcaster(const css::uno::Reference< 
css::uno::XInterface >& xBroadcaster);
-
-/** add a new property info to the set of supported ones.
- *
- *  @param  aProperty
- *  describes the new property.
- *
- *  @throw  [css::beans::PropertyExistException]
- *  if a property with the same name already exists.
- *
- *  Note:   The consistence of the whole set of properties is not 
checked here.
- *  Means e.g. ... a handle which exists more than once is not

[Libreoffice-bugs] [Bug 99141] New: Font does disapear when printing

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99141

Bug ID: 99141
   Summary: Font does disapear when printing
   Product: LibreOffice
   Version: 5.1.2.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thierry.seew...@laposte.net

Created attachment 124165
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124165=edit
Font causing the pb.

Hi,
I use a peculiar font andika-frentight, made up from andika font.
Since recently (2.1.1?) everything worked fine.
But currently, when I print, the parts or the file using these font are blank
on the paper (parts using another font (times new roman, arial ... show up
fine).
When I make a .doc file and print it with ms-word, it's ok,
When I make a .pdf file and print it it's okay,
it's only when printing the file with LOO that it does not work.

attached : 
- the font

ps I would like to send you a file example, but it seems I can only attach one
file so I choose the font file.

regards

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

--- Comment #10 from Joel Madero  ---
(In reply to spectre9009 from comment #9)
> (In reply to Joel Madero from comment #6)
> > 6) drag a png from nemo to the gallery
> 
> This problem exists with native vector objects Draw. Not with png or other
> raster images.
> For technical drawing and circuit diagram the raster images is absolutely
> unusable.
> 

There's no need for you to keep saying how it's such a serious bug for the
corner case users like yourself - that's not going to get the bug fixed. If
you're using LibreOffice in a professional setting then I suggest professional
support contract with a certified developer. That's how you get your pet bugs
fixed on your schedule. Else, realistically it could be some time (a long time)
before this is resolved. If I can bibisect it that might help move your pet bug
forward but first I need to confirm it's a regression.

Just tested on 3.3 and it had different but still wrong behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98973] Extrusion-length of some areas changed after reopening the document

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98973

--- Comment #5 from bugzi...@hawoe.de ---
Created attachment 124164
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124164=edit
The ODG-Document with the desk

Sorry, I forgot!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98938] handout does not print in portrait orientation

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98938

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #2 from Buovjaga  ---
Repro.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.0.0.alpha0+
Build ID: 9b0069c2833313ba9fab91f45edd354ba334f94b
CPU Threads: 8; OS Version: Linux 4.4; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)
Built on April 3rd 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Crash test update

2016-04-07 Thread Crashtest VM

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/871f49e7fadb863b55c96c3f58ea7cc8fb033b40/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 98879] Some CJK characters are wrongly converted in vertical layout (Noto CJK font)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98879

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Buovjaga  ---
Confirmed, Linux-only.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.0.0.alpha0+
Build ID: 9b0069c2833313ba9fab91f45edd354ba334f94b
CPU Threads: 8; OS Version: Linux 4.4; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)
Built on April 3rd 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: minutes of ESC call ...

2016-04-07 Thread Bjoern Michaelsen

On Thu, Apr 07, 2016 at 03:36:07PM +0100, Michael Meeks wrote:
> + Made some progress on writer regressions (Bjoern)
> + could close some - have commits, but not closed.

+ count is at 6 currently (all severity minor):
+ 2 SimpleWinLayout still (was reverted already?)
+ 2 more with committed fixes
+ 1 more Windows only
+ 1 general
+ 
http://nabble.documentfoundation.org/Getting-LibreOffice-Writer-5-0-6-bibisected-regression-free-against-LibreOffice-4-4-0-was-LibreOffic-td4179580.html#a4179743

Assuming 2 SimpleWinLayout bugs can be closed as can those with committed
fixes, we are left with only 2 bibisected writer regressions (1 on non-windows)
left open from LibreOffice 5.0.0.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] minutes of ESC call ...

2016-04-07 Thread Bjoern Michaelsen

On Thu, Apr 07, 2016 at 03:36:07PM +0100, Michael Meeks wrote:
> + Made some progress on writer regressions (Bjoern)
> + could close some - have commits, but not closed.

+ count is at 6 currently (all severity minor):
+ 2 SimpleWinLayout still (was reverted already?)
+ 2 more with committed fixes
+ 1 more Windows only
+ 1 general
+ 
http://nabble.documentfoundation.org/Getting-LibreOffice-Writer-5-0-6-bibisected-regression-free-against-LibreOffice-4-4-0-was-LibreOffic-td4179580.html#a4179743

Assuming 2 SimpleWinLayout bugs can be closed as can those with committed
fixes, we are left with only 2 bibisected writer regressions (1 on non-windows)
left open from LibreOffice 5.0.0.

Best,

Bjoern
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] minutes of ESC call ...

2016-04-07 Thread Michael Meeks

* Present:
+ Lionel, Stephan, Sophie, Stefan W., Andras, Kendy, Bjoern, Miklos, Caolán,
  Olivier, Christian, Michael M, Bubli, Michael S, David, Armin, NoelG
 
* Completed Action Items:
+ provide Italo some data:
"thanks to 10,000 UI survey respondants in last year" (thanks to Heiko)
 
* Pending Action Items:
+ accept invite for GSOC mentoring (Muthu)
+ switch lcov profile to system-nss (Norbert)
+ investigate clobberring glew instead of lots of #ifdefs: (Marco, Oliver)
+ add UI guys as reviewers fo rgerrit UI patches (JanI)
[ 7 open right now, will update them shortly. ]
+ tweak UI and get LiveConnect API key / build case for board (Christian)
+ ask QA to re-test http://tdf.io/mmregressions (Robinson)
 [ testing underway ]
+ attempt to re-build a recent gstreamer 1.0 / core spec file
  on our CentOS6 base (tdf#94508) (Christian)
+ script XML / l10n string translation changes (Christian)
 [ still pending => ignore translating it for now (Cloph) ].
 
* Release Engineering update (Christian)
+ 5.0.6 RC1 - due April 12th.
+ last 5.0.x release (Bjoern)
+ 5.1.2.2 status
+ announced as final today.
+ 5.1.3 RC1 - due April 18th
+ 5.2 Alpha - ~end of week of April 18th
+ a milestone for early testing.
+ Android & iOS Remote
+ new Material-design for android / theming pending review.
+ will update mavern bits later today.
 
* Documentation (Olivier)
+ 2 Patches in Helpcontent
+ New chapter of Getting Started 5.1 : Styles & Templates
+ Wiki page comparing alternatives to Helpcontent for ESC
  
https://wiki.documentfoundation.org/Documentation/Help_content_technologies
+ no need to deep-dive here (Kendy)
   + conclusion: XHP still a reasonable source for now.
   + no huge need to move away from it - if it's more editable.
   + hope to improve it with the tender for shared on-line editing of 
it.
 
* l10n (Sophie)
+ quiet, WIP.
 
* GSoC 2016 (JanI)
+ We currently have 17 proposals selected and 23 mentors
+ We need to submit a number no later than April 11th
+ All proposals with a mentor are star marked, and mailed to all mentors 
with questions.
+ concern wrt. mentor/student ratio in some cases.
+ go to https://summerofcode.withgoogle.com/dashboard/proposals/shared/
+ tool can no longer do ranking; what's the plan (Michael)
+ we will want an ordering - done in a spreadsheet
  or somesuch for slot requests.
AI: + copy-paste proposals into a spreadsheet (Michael)
 
* UX Update (Kendy)
+ lots of GSOC discussion
+ planning a good way of co-mentoring with developers.
+ hope is that day-to-day poking, testing is ~non-technical.
+ worked well last year with Jay (Bubli)
+ good to get UX people closer to the code (Michael)
+ draw survey agreed & published
+ sidebar survey results in, prepping for publication.
+ talked wrt. notebookbar & single toolbar mode.
+ useful to use the .ui file as well.
 
* Crashtest update (Caolan)
+ 9 import failures, 1 export failures, 7 coverity
+ prolly all fixed; couldn't reproduce manually.
+ new crashtest pending
+ various people squashing warnings while Caolan away.
+ fuzzing stuff run for 2x weeks while away
+ more fixes coming.
+ hunspell update coming too.
 
* Gran Canaria hack-fest update (Thorsten/JanI etc.)
+ https://wiki.documentfoundation.org/Events/LibreOffice_Espania_Summit
   + sadly no-one on the call.
   + having talks according to Thorsten's twitter (Bjoern)
 https://twitter.com/thooorsten/status/718076286816677888
 
* Hackfests (Bjoern)
+ next venues / suggestions
+ Ankara, Turkey
+ April 30th - May 1st.
+ https://wiki.documentfoundation.org/Hackfest/Ankara2016
+ plan do an overview talk on Friday (Michael)
+ Germany, Munich, LiMux; End of May 2016 (Jan-Marek)
+ Orga: https://wiki.debian.org/BSP/2016/05/de/Munich
+ 27-29 May (parallel to the Debian Sun Camp)
 
* Mentoring Update (JanI)
+ gerrit: 146 open patches of which 94 can be merged if no open comments
 74 from new contributors of which 39 can be merged if no open 
comments
+ had a busy GSoC week helping mentors
+ Have a backlog of mentoring work
+ started discussion on how to secure new contributors can successfully 
build master
 
* Commit Access
 
* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
+ after GSOC storm.
 
* Jenkins / CI update (Norbert)
from:Thu Mar 31 14:13:43 2016
master linux rel  jobs: 171 ok: 166 ko:   4 fail ratio:  2.34 % break:   4 
broken duration: 0.65%
master linux dbg  jobs: 143 ok: 129 ko:  14 fail ratio:  9.79 % break:  11 
broken duration: 6.07%
master mac reljobs: 160 ok: 156 ko:   4 fail

minutes of ESC call ...

2016-04-07 Thread Michael Meeks

* Present:
+ Lionel, Stephan, Sophie, Stefan W., Andras, Kendy, Bjoern, Miklos, Caolán,
  Olivier, Christian, Michael M, Bubli, Michael S, David, Armin, NoelG
 
* Completed Action Items:
+ provide Italo some data:
"thanks to 10,000 UI survey respondants in last year" (thanks to Heiko)
 
* Pending Action Items:
+ accept invite for GSOC mentoring (Muthu)
+ switch lcov profile to system-nss (Norbert)
+ investigate clobberring glew instead of lots of #ifdefs: (Marco, Oliver)
+ add UI guys as reviewers fo rgerrit UI patches (JanI)
[ 7 open right now, will update them shortly. ]
+ tweak UI and get LiveConnect API key / build case for board (Christian)
+ ask QA to re-test http://tdf.io/mmregressions (Robinson)
 [ testing underway ]
+ attempt to re-build a recent gstreamer 1.0 / core spec file
  on our CentOS6 base (tdf#94508) (Christian)
+ script XML / l10n string translation changes (Christian)
 [ still pending => ignore translating it for now (Cloph) ].
 
* Release Engineering update (Christian)
+ 5.0.6 RC1 - due April 12th.
+ last 5.0.x release (Bjoern)
+ 5.1.2.2 status
+ announced as final today.
+ 5.1.3 RC1 - due April 18th
+ 5.2 Alpha - ~end of week of April 18th
+ a milestone for early testing.
+ Android & iOS Remote
+ new Material-design for android / theming pending review.
+ will update mavern bits later today.
 
* Documentation (Olivier)
+ 2 Patches in Helpcontent
+ New chapter of Getting Started 5.1 : Styles & Templates
+ Wiki page comparing alternatives to Helpcontent for ESC
  
https://wiki.documentfoundation.org/Documentation/Help_content_technologies
+ no need to deep-dive here (Kendy)
   + conclusion: XHP still a reasonable source for now.
   + no huge need to move away from it - if it's more editable.
   + hope to improve it with the tender for shared on-line editing of 
it.
 
* l10n (Sophie)
+ quiet, WIP.
 
* GSoC 2016 (JanI)
+ We currently have 17 proposals selected and 23 mentors
+ We need to submit a number no later than April 11th
+ All proposals with a mentor are star marked, and mailed to all mentors 
with questions.
+ concern wrt. mentor/student ratio in some cases.
+ go to https://summerofcode.withgoogle.com/dashboard/proposals/shared/
+ tool can no longer do ranking; what's the plan (Michael)
+ we will want an ordering - done in a spreadsheet
  or somesuch for slot requests.
AI: + copy-paste proposals into a spreadsheet (Michael)
 
* UX Update (Kendy)
+ lots of GSOC discussion
+ planning a good way of co-mentoring with developers.
+ hope is that day-to-day poking, testing is ~non-technical.
+ worked well last year with Jay (Bubli)
+ good to get UX people closer to the code (Michael)
+ draw survey agreed & published
+ sidebar survey results in, prepping for publication.
+ talked wrt. notebookbar & single toolbar mode.
+ useful to use the .ui file as well.
 
* Crashtest update (Caolan)
+ 9 import failures, 1 export failures, 7 coverity
+ prolly all fixed; couldn't reproduce manually.
+ new crashtest pending
+ various people squashing warnings while Caolan away.
+ fuzzing stuff run for 2x weeks while away
+ more fixes coming.
+ hunspell update coming too.
 
* Gran Canaria hack-fest update (Thorsten/JanI etc.)
+ https://wiki.documentfoundation.org/Events/LibreOffice_Espania_Summit
   + sadly no-one on the call.
   + having talks according to Thorsten's twitter (Bjoern)
 https://twitter.com/thooorsten/status/718076286816677888
 
* Hackfests (Bjoern)
+ next venues / suggestions
+ Ankara, Turkey
+ April 30th - May 1st.
+ https://wiki.documentfoundation.org/Hackfest/Ankara2016
+ plan do an overview talk on Friday (Michael)
+ Germany, Munich, LiMux; End of May 2016 (Jan-Marek)
+ Orga: https://wiki.debian.org/BSP/2016/05/de/Munich
+ 27-29 May (parallel to the Debian Sun Camp)
 
* Mentoring Update (JanI)
+ gerrit: 146 open patches of which 94 can be merged if no open comments
 74 from new contributors of which 39 can be merged if no open 
comments
+ had a busy GSoC week helping mentors
+ Have a backlog of mentoring work
+ started discussion on how to secure new contributors can successfully 
build master
 
* Commit Access
 
* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
+ after GSOC storm.
 
* Jenkins / CI update (Norbert)
from:Thu Mar 31 14:13:43 2016
master linux rel  jobs: 171 ok: 166 ko:   4 fail ratio:  2.34 % break:   4 
broken duration: 0.65%
master linux dbg  jobs: 143 ok: 129 ko:  14 fail ratio:  9.79 % break:  11 
broken duration: 6.07%
master mac reljobs: 160 ok: 156 ko:   4 fail

[Libreoffice-bugs] [Bug 98600] LO cannot read some svm pictures from old ODT file

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98600

Michael Stahl  changed:

   What|Removed |Added

 Attachment #123496|application/octet-stream|image/x-svm
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98579] Slides containing .wmv or .avi video crash in slideshow mode

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98579

Michael Stahl  changed:

   What|Removed |Added

 Attachment #123499|application/octet-stream|application/vnd.oasis.opend
  mime type||ocument.presentation

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99097] VBA/Basic formatting datetime with function FORMAT gives wrong result with nn (minutes)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99097

Roy D  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #4 from Roy D  ---
Uploaded a sample document and an image with the result of the macro showBug. I
hope this will give you enough information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99139] New: 'bad allocation' on opening template (.ott)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99139

Bug ID: 99139
   Summary: 'bad allocation' on opening template (.ott)
   Product: LibreOffice
   Version: 5.1.1.1 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: espiri...@hotmail.com

Created attachment 124162
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124162=edit
Writer template

I have multiple templates that can not be opened any more.
They worked before, even on this release.

I run Windows 8.1 Pro

On another computer (Window 7) there is no problem.

I expect the problem to be in another component, that interfers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98481] SUM is zero when some cells are empty and some cells reference other sheet AND file is xlsx.

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98481

Michael Stahl  changed:

   What|Removed |Added

 Attachment #123363|application/octet-stream|application/vnd.oasis.opend
  mime type||ocument.spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99097] VBA/Basic formatting datetime with function FORMAT gives wrong result with nn (minutes)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99097

--- Comment #3 from Roy D  ---
Created attachment 124161
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124161=edit
Messagebox of macro that show the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99097] VBA/Basic formatting datetime with function FORMAT gives wrong result with nn (minutes)

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99097

--- Comment #2 from Roy D  ---
Created attachment 124160
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124160=edit
Calc file with macro that shows the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/loolwsd.xml

2016-04-07 Thread Ashod Nakashian

 loolwsd/loolwsd.xml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d014589692dfb09a1b88096a0626b0de1f83e20f
Author: Ashod Nakashian 
Date:   Thu Apr 7 09:11:30 2016 -0400

loolwsd: added default LO install path in the config

Change-Id: Ic42acd1a6050104d08a5bcf2ebb90b9b8aabbbfa
Reviewed-on: https://gerrit.libreoffice.org/23899
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/loolwsd.xml b/loolwsd/loolwsd.xml
index dfa909c..6b57c5a 100644
--- a/loolwsd/loolwsd.xml
+++ b/loolwsd/loolwsd.xml
@@ -2,7 +2,7 @@
 
 
 
-
+
 
 lo
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99046] Crash when launch application

2016-04-07 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99046

Robinson Tryon (qubit)  changed:

   What|Removed |Added

 CC||qu...@runcibility.com

--- Comment #2 from Robinson Tryon (qubit)  ---
Testing with Android 5.1.1 and

tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2016-04-07 00:26:53
tinderbox: git sha1s
core:641840dc0f63d23acceb7edd833f4a31f216009d

(In reply to raal from comment #0)
> master~2016-04-02_00.12.01_LibreOfficeViewer-strippedUI-debug.apk
> 02-Apr-2016 02:24
> 
> Crashes when launching application.  Android 4.4.4

Application opens; About dialog opens; documents open. Perhaps fixed in last
couple days or Android 4.x-specific?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 >

1 - 100 of 215 matches

Mail list logo