[Libreoffice-bugs] [Bug 113727] Fresh Install wont open
https://bugs.documentfoundation.org/show_bug.cgi?id=113727 Xisco Faulíchanged: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Hello Quentin, I guess if it open in safe mode but not in normal mode it's due to OpenGL. Could you please try to disable it as explain here:https://wiki.documentfoundation.org/OpenGL#Crash_on_program_start ? OTOH, could you please share your OpenGL information as described here: https://wiki.documentfoundation.org/OpenGL#Get_your_computer.27s_OpenGL_information? Regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89557] UI: keyboard shortcut to move to end of document does not work if cursor within table of contents
https://bugs.documentfoundation.org/show_bug.cgi?id=89557 --- Comment #14 from Frank Fuchs--- The bug is still there in LibO 5.4.3.2, tested on macOS 10.13.1, MacBook Pro early 2013 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111826] Issues with sidebar's Master Slide / Close Master Slide button in handout view
https://bugs.documentfoundation.org/show_bug.cgi?id=111826 Xisco Faulíchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org |desktop.org | QA Contact|xiscofa...@libreoffice.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar, dialog and sidebar drop-down widget bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85184 Bug 85184 depends on bug 112939, which changed state. Bug 112939 Summary: Color on drop-down color chooser is always black instead of chosen color https://bugs.documentfoundation.org/show_bug.cgi?id=112939 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112939] Color on drop-down color chooser is always black instead of chosen color
https://bugs.documentfoundation.org/show_bug.cgi?id=112939 --- Comment #7 from Xisco Faulí--- A polite ping to Noel Grandin: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112939] Color on drop-down color chooser is always black instead of chosen color
https://bugs.documentfoundation.org/show_bug.cgi?id=112939 Noel Grandinchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109016] FILESAVE XLSX PIVOTTABLE: Filter set on row fields not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=109016 --- Comment #20 from Xisco Faulí--- A polite ping to Tamás Zolnai: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93789] text background color not displayed in slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=93789 Telestochanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #27 from Telesto --- > This happened to me during a presentation. It was rather awkward since the > slides didn't make much sense without the highlight colors. @Buovjaga Is it possible the raise the priority? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113729] New: macro (autoopen) no more working in 5.4.2.2 LibreBase
https://bugs.documentfoundation.org/show_bug.cgi?id=113729 Bug ID: 113729 Summary: macro (autoopen) no more working in 5.4.2.2 LibreBase Product: LibreOffice Version: 5.4.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dr.berto...@gmail.com Created attachment 137630 --> https://bugs.documentfoundation.org/attachment.cgi?id=137630=edit screeenshot of error with the new version of LibreOffice I get an error message, not in Writer, not in Calc, but in Base: "BASIC runtime error. Property or method not found: supportsService" and is highlighted the line "If NOT thisComponent.supportsService (" com.sun.star.text.TextDocument ") Then" Apparently supportsService is no more recognized in LibreBase (or, better, in Basic: I don't know!). I refer to the whole macro: sub vai_qui If NOT ThisComponent.supportsService ("com.sun.star.text.TextDocument") Then Exit Sub End If oBookmarks = ThisComponent.getBookmarks () If NOT oBookmarks.hasByName ("here") Then Exit Sub End If ViewCursor = ThisComponent.CurrentController.getviewCursor () Bookmark = ThisComponent.Bookmarks.getByName ("here") .Anchor ViewCursor.gotorange (Bookmark, False) ViewCursor = ThisComponent.CurrentController.getviewCursor () Bookmark = ThisComponent.Bookmarks.getByName ("here") .Anchor ViewCursor.gotorange (Bookmark, False) end sub -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95082] Improve LibO file dialog: Tooltips
https://bugs.documentfoundation.org/show_bug.cgi?id=95082 --- Comment #3 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76166] VIEWING: 0.05pt dashed cell borders are always shown solid
https://bugs.documentfoundation.org/show_bug.cgi?id=76166 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #14 from Xisco Faulí --- Yep, Using a dashed border with a width of 0.05pt or less the border is displayed correctly in Version: 6.0.0.0.alpha1+ Build ID: 5e0022c90c4125a1590b3688dfec73c271b7aedd CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: th-TH (ca_ES.UTF-8); Calc: group Probably fixed by recent Armin's work on borders. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59284] [META] Cell border related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=59284 Bug 59284 depends on bug 76166, which changed state. Bug 76166 Summary: VIEWING: 0.05pt dashed cell borders are always shown solid https://bugs.documentfoundation.org/show_bug.cgi?id=76166 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94446] Report exception when parameter dialog is cancelled
https://bugs.documentfoundation.org/show_bug.cgi?id=94446 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50359] Difficult to select PNG with transparent background and fine content
https://bugs.documentfoundation.org/show_bug.cgi?id=50359 --- Comment #16 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64690] EDITING: Process hang on find/replace in Basic code involving "\&"
https://bugs.documentfoundation.org/show_bug.cgi?id=64690 --- Comment #16 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94812] Form Edit find does not bring up a dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=94812 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95006] EDITING: Writer fails to preserve some html
https://bugs.documentfoundation.org/show_bug.cgi?id=95006 --- Comment #4 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94643] FILESAVE : Date format lost when saving to XML.
https://bugs.documentfoundation.org/show_bug.cgi?id=94643 --- Comment #4 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94416] FILESAVE: Don't change Qiqqa citation cluster objects
https://bugs.documentfoundation.org/show_bug.cgi?id=94416 --- Comment #7 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102298] [UI] In Autofilter the 5 elements on top do not get focus by Tab, nor have a shortcut
https://bugs.documentfoundation.org/show_bug.cgi?id=102298 --- Comment #4 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60777] FORMATTING sum of different currencies should not be one of these currencies
https://bugs.documentfoundation.org/show_bug.cgi?id=60777 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62174] Italic Greek symbols (iGreek set) fails if UI Language is changed
https://bugs.documentfoundation.org/show_bug.cgi?id=62174 --- Comment #7 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72567] FILEOPEN: Impress does not import text gradient from .PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=72567 --- Comment #11 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72687] poor precision in rotation (Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=72687 --- Comment #15 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94117] Windows 64-bit and executable name of 64-bit build of ghostscript -- gswin64c.exe
https://bugs.documentfoundation.org/show_bug.cgi?id=94117 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94395] line spacing change in paragraph style not displayed in Organizer
https://bugs.documentfoundation.org/show_bug.cgi?id=94395 --- Comment #13 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58244] Impossible to display non numeric values (labels) in bubble charts axis (for categorized data)
https://bugs.documentfoundation.org/show_bug.cgi?id=58244 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101822] glxtest zombie process on all non-Gtk+ X11 VCL platforms
https://bugs.documentfoundation.org/show_bug.cgi?id=101822 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84119] Basic IDE - Autocorrection option makes unwanted source changes
https://bugs.documentfoundation.org/show_bug.cgi?id=84119 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81012] FORMATTING: Wrong chapter title in running header after the first page of endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=81012 --- Comment #11 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95085] Improve LibO file dialog: File list view
https://bugs.documentfoundation.org/show_bug.cgi?id=95085 --- Comment #3 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72749] EDITING: Natural sorting does not work with underscore in strings
https://bugs.documentfoundation.org/show_bug.cgi?id=72749 --- Comment #7 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101323] Style name is not changed in LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=101323 --- Comment #10 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95086] Improve LibO file dialog: Places and favorites
https://bugs.documentfoundation.org/show_bug.cgi?id=95086 --- Comment #3 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89557] UI: keyboard shortcut to move to end of document does not work if cursor within table of contents
https://bugs.documentfoundation.org/show_bug.cgi?id=89557 --- Comment #13 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61813] Fields wrap to next line improperly
https://bugs.documentfoundation.org/show_bug.cgi?id=61813 --- Comment #10 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92679] Having some columns with vertical text orientation breaks right-to-left tables
https://bugs.documentfoundation.org/show_bug.cgi?id=92679 --- Comment #8 from Omer Zak--- Created attachment 137629 --> https://bugs.documentfoundation.org/attachment.cgi?id=137629=edit Attempt to reproduce the bug in 6.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92679] Having some columns with vertical text orientation breaks right-to-left tables
https://bugs.documentfoundation.org/show_bug.cgi?id=92679 --- Comment #7 from Omer Zak--- I tested in version: Version: 6.0.0.0.alpha1+ Build ID: 6070dec9ca9a15587a2aece81f9ae1ab5ac0f8c4 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; Locale: en-US (en_US.utf8); Calc: group (Build from 2017-Nov-05 00:00) OS: Debian 64bit Stretch (Debian 9.2, with some backported packages) I created a table with Hebrew in cells. I changed the text orientation to vertical after selecting all cells in the table and using: Format > Character > Position > Rotation/Scaling > 90 degrees The table remained right justified after reopening the file. However, the column widths changed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76166] VIEWING: 0.05pt dashed cell borders are always shown solid
https://bugs.documentfoundation.org/show_bug.cgi?id=76166 Kevin Suochanged: What|Removed |Added Status|NEW |NEEDINFO CC||suokunl...@126.com --- Comment #13 from Kevin Suo --- I do not reproduce this in version 5.3.7.2, Fedora 26 amd64. Please re-test, and set to RESOLVED WORKSFORME if the bug is gone. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92641] Parentheses order wrong when a line with text direction Right-to-left starts with LTR characters
https://bugs.documentfoundation.org/show_bug.cgi?id=92641 --- Comment #11 from Omer Zak--- The same behavior is seen also in: Version: 6.0.0.0.alpha1+ Build ID: 6070dec9ca9a15587a2aece81f9ae1ab5ac0f8c4 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; Locale: en-US (en_US.utf8); Calc: group (Build from 2017-Nov-05 00:00) OS: Debian 64bit Stretch (Debian 9.2, with some backported packages) However, I believe that it is not a bug. If I do at the beginning of the line starting with LTR character: Insert > Formatting Mark > Right-to-left mark Then the parenthesis order is right. In effect, the above makes the line start with a RTL character. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/osx
vcl/inc/osx/runinmain.hxx | 79 +- vcl/inc/osx/salinst.h |4 ++ vcl/osx/salinst.cxx | 53 -- 3 files changed, 89 insertions(+), 47 deletions(-) New commits: commit b5b78703b5d801c2a9a5e45126f8e87bf5ebd4b4 Author: Stephan BergmannDate: Wed Nov 8 19:01:10 2017 +0100 Avoid races when using OSX_RUNINMAIN_MEMBERS ...so that e.g. main thread in SalYieldMutex::doAcquire could reset m_aInMainTHreadCondition and then block waiting on it only after another thread had set it. (Saw such a deadlock in some 'make check' CppunitTest.) Change-Id: I5c676956a2bec6bf8f94d7dbeee64f100db39bd3 Reviewed-on: https://gerrit.libreoffice.org/44501 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/vcl/inc/osx/runinmain.hxx b/vcl/inc/osx/runinmain.hxx index a57b7908214d..8f8559dac5c8 100644 --- a/vcl/inc/osx/runinmain.hxx +++ b/vcl/inc/osx/runinmain.hxx @@ -57,8 +57,11 @@ union RuninmainResult }; #define OSX_RUNINMAIN_MEMBERS \ -osl::Condition m_aInMainCondition; \ -osl::Condition m_aResultCondition; \ +std::mutex m_runInMainMutex; \ +std::condition_variable m_aInMainCondition; \ +std::condition_variable m_aResultCondition; \ +boolm_wakeUpMain = false; \ +boolm_resultReady = false; \ RuninmainBlock m_aCodeBlock; \ RuninmainResult m_aResult; @@ -67,18 +70,24 @@ union RuninmainResult { \ DBG_TESTSOLARMUTEX(); \ SalYieldMutex *aMutex = static_cast (instance->GetYieldMutex()); \ -assert( !aMutex->m_aCodeBlock ); \ -aMutex->m_aCodeBlock = Block_copy(^{ \ -command; \ -}); \ -aMutex->m_aResultCondition.reset(); \ +{ \ +std::unique_lock g(aMutex->m_runInMainMutex); \ +assert( !aMutex->m_aCodeBlock ); \ +aMutex->m_aCodeBlock = Block_copy(^{ \ +command; \ +}); \ +aMutex->m_wakeUpMain = true; \ +aMutex->m_aInMainCondition.notify_all(); \ +} \ dispatch_async(dispatch_get_main_queue(),^{ \ ImplNSAppPostEvent( AquaSalInstance::YieldWakeupEvent, NO ); \ }); \ -aMutex->m_aInMainCondition.set(); \ -osl::Condition::Result res = aMutex->m_aResultCondition.wait(); \ -(void) res; \ -assert(osl::Condition::Result::result_ok == res); \ +{ \ +std::unique_lock g(aMutex->m_runInMainMutex); \ +aMutex->m_aResultCondition.wait( \ +g, []() { return aMutex->m_resultReady; }); \ +aMutex->m_resultReady = false; \ +} \ return; \ } @@ -87,18 +96,24 @@ union RuninmainResult { \ DBG_TESTSOLARMUTEX(); \ SalYieldMutex *aMutex = static_cast (instance->GetYieldMutex()); \ -assert( !aMutex->m_aCodeBlock ); \ -aMutex->m_aCodeBlock = Block_copy(^{ \ -aMutex->m_aResult.pointer = static_cast ( command ); \ -}); \ -aMutex->m_aResultCondition.reset(); \ +{ \ +std::unique_lock g(aMutex->m_runInMainMutex); \ +assert( !aMutex->m_aCodeBlock ); \ +aMutex->m_aCodeBlock = Block_copy(^{ \ +aMutex->m_aResult.pointer = static_cast ( command ); \ +}); \ +aMutex->m_wakeUpMain = true; \ +aMutex->m_aInMainCondition.notify_all(); \ +} \ dispatch_async(dispatch_get_main_queue(),^{ \ ImplNSAppPostEvent( AquaSalInstance::YieldWakeupEvent, NO ); \ }); \ -aMutex->m_aInMainCondition.set(); \ -osl::Condition::Result res = aMutex->m_aResultCondition.wait(); \ -(void) res; \ -assert(osl::Condition::Result::result_ok == res); \ +{ \ +std::unique_lock g(aMutex->m_runInMainMutex); \ +aMutex->m_aResultCondition.wait( \ +g, []() { return aMutex->m_resultReady; }); \ +aMutex->m_resultReady = false; \ +} \ return static_cast( aMutex->m_aResult.pointer ); \ } @@ -107,18 +122,24 @@ union RuninmainResult { \ DBG_TESTSOLARMUTEX(); \ SalYieldMutex *aMutex = static_cast (instance->GetYieldMutex()); \ -assert( !aMutex->m_aCodeBlock ); \ -aMutex->m_aCodeBlock = Block_copy(^{ \ -aMutex->m_aResult.member = command; \ -}); \ -aMutex->m_aResultCondition.reset(); \ +{ \ +std::unique_lock g(aMutex->m_runInMainMutex); \ +assert( !aMutex->m_aCodeBlock ); \ +aMutex->m_aCodeBlock = Block_copy(^{ \ +aMutex->m_aResult.member = command; \ +}); \ +
[Libreoffice-bugs] [Bug 91315] Parentheses inverted in mixed RTL and LTR text in SVG export
https://bugs.documentfoundation.org/show_bug.cgi?id=91315 --- Comment #8 from Omer Zak--- Created attachment 137628 --> https://bugs.documentfoundation.org/attachment.cgi?id=137628=edit Text's major direction changed from RTL to LTR in SVG export -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91315] Parentheses inverted in mixed RTL and LTR text in SVG export
https://bugs.documentfoundation.org/show_bug.cgi?id=91315 --- Comment #7 from Omer Zak--- In: Version: 6.0.0.0.alpha1+ Build ID: 6070dec9ca9a15587a2aece81f9ae1ab5ac0f8c4 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: gtk3; Locale: en-US (en_US.utf8); Calc: group (Build from 2017-Nov-05 00:00) OS: Debian 64bit Stretch (Debian 9.2, with some backported packages) The parenthesis inversion bug was fixed. However, there is another bug - the text's major direction changed from RTL to LTR. See new attachment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang sc/source
compilerplugins/clang/unnecessaryoverride.cxx |3 --- sc/source/ui/vba/vbaformatcondition.cxx |6 -- sc/source/ui/vba/vbaformatcondition.hxx |1 - 3 files changed, 10 deletions(-) New commits: commit 9fbe22e1d9b30c5c0087e84809c80b936c5c142f Author: Stephan BergmannDate: Thu Nov 9 07:52:32 2017 +0100 No need to blacklist this loplugin:unnecessaryoverride This now hides one of the ScVbaFormatCondition_BASE::Operator overloads, but that doesn't get called directly at ScVbaFormatCondition anyway. (And if it were, we could add an appropriate using declaration to ScVbaFormatCondition.) Change-Id: I8440b76a5745c6874f7a3bfcbb4bc4ce5618a4c4 diff --git a/compilerplugins/clang/unnecessaryoverride.cxx b/compilerplugins/clang/unnecessaryoverride.cxx index b71cf2003f3e..eb3dabb26f60 100644 --- a/compilerplugins/clang/unnecessaryoverride.cxx +++ b/compilerplugins/clang/unnecessaryoverride.cxx @@ -267,9 +267,6 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const CXXMethodDecl* methodDecl) // some very creative method hiding going on here if (loplugin::isSamePathname(aFileName, SRCDIR "/svx/source/dialog/checklbx.cxx")) return true; -// entertaining template magic -if (loplugin::isSamePathname(aFileName, SRCDIR "/sc/source/ui/vba/vbaformatcondition.cxx")) -return true; const CXXMethodDecl* overriddenMethodDecl = findOverriddenOrSimilarMethodInSuperclasses(methodDecl); if (!overriddenMethodDecl) { diff --git a/sc/source/ui/vba/vbaformatcondition.cxx b/sc/source/ui/vba/vbaformatcondition.cxx index f5f3aff26e7a..55d81e888030 100644 --- a/sc/source/ui/vba/vbaformatcondition.cxx +++ b/sc/source/ui/vba/vbaformatcondition.cxx @@ -128,12 +128,6 @@ ScVbaFormatCondition::Type( ) return nReturnType; } -::sal_Int32 -ScVbaFormatCondition::Operator( bool bVal ) -{ -return ScVbaFormatCondition_BASE::Operator( bVal ); -} - ::sal_Int32 SAL_CALL ScVbaFormatCondition::Operator( ) { diff --git a/sc/source/ui/vba/vbaformatcondition.hxx b/sc/source/ui/vba/vbaformatcondition.hxx index 8ffb1f700b96..85b102310762 100644 --- a/sc/source/ui/vba/vbaformatcondition.hxx +++ b/sc/source/ui/vba/vbaformatcondition.hxx @@ -56,7 +56,6 @@ public: virtual void SAL_CALL Delete( ) override; virtual void SAL_CALL Modify( ::sal_Int32 Type, const css::uno::Any& Operator, const css::uno::Any& Formula1, const css::uno::Any& Formula2 ) override; virtual ::sal_Int32 SAL_CALL Type( ) override; -virtual ::sal_Int32 Operator( bool ) override; virtual ::sal_Int32 SAL_CALL Operator( ) override; virtual void setFormula1( const css::uno::Any& _aFormula1) override; virtual css::uno::Reference< ::ooo::vba::excel::XInterior > SAL_CALL Interior( ) override; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93789] text background color not displayed in slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=93789 --- Comment #26 from Ken Shirriff--- This bug (highlight color appears while editing but not during slide show) happened to me on Version: 5.2.6.2, Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc, CPU Threads: 4; OS Version: Mac OS X 10.13.1; UI Render: default; Locale: en-US (en_US.UTF-8); Calc: group This happened to me during a presentation. It was rather awkward since the slides didn't make much sense without the highlight colors. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang editeng/source framework/source sc/source sd/source sfx2/source solenv/CompilerTest_compilerplugins_clang.mk svx/source sw/source
compilerplugins/clang/simplifydynamiccast.cxx | 116 compilerplugins/clang/test/simplifydynamiccast.cxx | 34 editeng/source/editeng/impedit2.cxx |4 editeng/source/editeng/impedit3.cxx |4 framework/source/layoutmanager/toolbarlayoutmanager.cxx |4 sc/source/ui/dbgui/validate.cxx |4 sc/source/ui/drawfunc/fuins2.cxx|8 - sc/source/ui/navipi/content.cxx |4 sc/source/ui/navipi/scenwnd.cxx |8 - sc/source/ui/view/viewfun2.cxx |8 - sd/source/core/drawdoc2.cxx |3 sd/source/ui/app/sdmod2.cxx |4 sd/source/ui/app/tmplctrl.cxx |4 sd/source/ui/func/fuconrec.cxx | 18 +- sd/source/ui/func/futext.cxx|3 sd/source/ui/view/DocumentRenderer.cxx |4 sd/source/ui/view/drviews8.cxx |7 sd/source/ui/view/drviewsf.cxx |8 - sd/source/ui/view/outlnvsh.cxx |8 - sfx2/source/appl/appuno.cxx |8 - sfx2/source/control/bindings.cxx|4 sfx2/source/toolbox/tbxitem.cxx |4 solenv/CompilerTest_compilerplugins_clang.mk|1 svx/source/customshapes/EnhancedCustomShape3d.cxx |4 svx/source/customshapes/EnhancedCustomShapeEngine.cxx |4 svx/source/engine3d/view3d.cxx |8 - svx/source/stbctrls/pszctrl.cxx | 12 - svx/source/stbctrls/xmlsecctrl.cxx |4 svx/source/stbctrls/zoomctrl.cxx|7 svx/source/svdraw/svdpagv.cxx |4 sw/source/core/access/acccell.cxx |3 sw/source/core/access/accframebase.cxx |3 sw/source/core/access/accmap.cxx|6 sw/source/core/doc/docdraw.cxx |4 sw/source/core/docnode/node.cxx |8 - sw/source/core/draw/dcontact.cxx|4 sw/source/core/draw/dview.cxx |4 sw/source/core/frmedt/feshview.cxx | 13 - sw/source/core/layout/atrfrm.cxx|8 - sw/source/core/layout/flowfrm.cxx |3 sw/source/core/layout/flylay.cxx|4 sw/source/core/layout/frmtool.cxx |4 sw/source/core/layout/layact.cxx| 13 - sw/source/core/layout/paintfrm.cxx |6 sw/source/core/layout/tabfrm.cxx|4 sw/source/core/text/txtfly.cxx |4 sw/source/core/unocore/unoframe.cxx | 11 - sw/source/uibase/app/apphdl.cxx |4 sw/source/uibase/app/docsh.cxx |4 49 files changed, 275 insertions(+), 148 deletions(-) New commits: commit 5ba447bdcd13ba3d7c27c8609f207910227e4ab6 Author: Noel GrandinDate: Tue Nov 7 13:55:06 2017 +0200 new loplugin simplifydynamiccast simplify dynamic_cast followed by static_cast Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279 Reviewed-on: https://gerrit.libreoffice.org/44460 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/compilerplugins/clang/simplifydynamiccast.cxx b/compilerplugins/clang/simplifydynamiccast.cxx new file mode 100644 index ..f305f8cbeaef --- /dev/null +++ b/compilerplugins/clang/simplifydynamiccast.cxx @@ -0,0 +1,116 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include +#include +#include +#include +#include + +#include +#include "compat.hxx" +#include "plugin.hxx" + +namespace +{ +class SimplifyDynamicCast : public RecursiveASTVisitor, public loplugin::Plugin +{ +public: +explicit SimplifyDynamicCast(loplugin::InstantiationData const& data) +: Plugin(data) +{ +} + +virtual void run() override +{ +//StringRef fn( compiler.getSourceManager().getFileEntryForID( +// compiler.getSourceManager().getMainFileID())->getName() ); +//if (loplugin::isSamePathname(fn, WORKDIR
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/appuno.cxx |4 +++- sfx2/source/view/viewfrm.cxx |4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) New commits: commit ea4a47d7d442d5d897cfa3a6e9f09ce3f1f233c5 Author: Noel GrandinDate: Wed Nov 8 14:48:31 2017 +0200 fix bugs in StateView_Impl and TransformItems where it was only incrementing the pointer once, meaning it was not iterating in pairs Change-Id: I26cc9b4262bc869c72231ef9eabca2d29da0a724 Reviewed-on: https://gerrit.libreoffice.org/44462 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx index c1088d275d33..56ad256aa335 100644 --- a/sfx2/source/appl/appuno.cxx +++ b/sfx2/source/appl/appuno.cxx @@ -1085,7 +1085,9 @@ void TransformItems( sal_uInt16 nSlotId, const SfxItemSet& rSet, uno::Sequencehttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: comphelper/source include/comphelper
comphelper/source/property/MasterPropertySet.cxx | 29 +++ include/comphelper/MasterPropertySet.hxx |5 +-- 2 files changed, 16 insertions(+), 18 deletions(-) New commits: commit 4be2af1e932a5ad7645af3044f509bc8006da91d Author: Noel GrandinDate: Wed Nov 8 14:16:44 2017 +0200 use rtl::Reference for SlaveData Change-Id: I0cc0455a97be2e0cd84ccadba1f3745b584e1f33 Reviewed-on: https://gerrit.libreoffice.org/44461 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/comphelper/source/property/MasterPropertySet.cxx b/comphelper/source/property/MasterPropertySet.cxx index 3f83b12b2be4..f379276a0e66 100644 --- a/comphelper/source/property/MasterPropertySet.cxx +++ b/comphelper/source/property/MasterPropertySet.cxx @@ -51,8 +51,7 @@ using namespace ::com::sun::star::beans; SlaveData::SlaveData ( ChainablePropertySet *pSlave) -: mpSlave ( pSlave ) -, mxSlave ( pSlave ) +: mxSlave ( pSlave ) , mbInit ( false ) { } @@ -105,7 +104,7 @@ void SAL_CALL MasterPropertySet::setPropertyValue( const OUString& rPropertyName } else { -ChainablePropertySet * pSlave = maSlaveMap [ (*aIter).second->mnMapId ]->mpSlave; +ChainablePropertySet * pSlave = maSlaveMap [ (*aIter).second->mnMapId ]->mxSlave.get(); // acquire mutex in c-tor and releases it in the d-tor (exception safe!). std::unique_ptr< osl::Guard< comphelper::SolarMutex > > xMutexGuard2; @@ -139,7 +138,7 @@ Any SAL_CALL MasterPropertySet::getPropertyValue( const OUString& rPropertyName } else { -ChainablePropertySet * pSlave = maSlaveMap [ (*aIter).second->mnMapId ]->mpSlave; +ChainablePropertySet * pSlave = maSlaveMap [ (*aIter).second->mnMapId ]->mxSlave.get(); // acquire mutex in c-tor and releases it in the d-tor (exception safe!). std::unique_ptr< osl::Guard< comphelper::SolarMutex > > xMutexGuard2; @@ -215,13 +214,13 @@ void SAL_CALL MasterPropertySet::setPropertyValues( const Sequence< OUString >& if (!pSlave->IsInit()) { // acquire mutex in c-tor and releases it in the d-tor (exception safe!). -if (pSlave->mpSlave->mpMutex) -aOGuardArray[i].reset( new osl::Guard< comphelper::SolarMutex >(pSlave->mpSlave->mpMutex) ); +if (pSlave->mxSlave->mpMutex) +aOGuardArray[i].reset( new osl::Guard< comphelper::SolarMutex >(pSlave->mxSlave->mpMutex) ); -pSlave->mpSlave->_preSetValues(); +pSlave->mxSlave->_preSetValues(); pSlave->SetInit ( true ); } -pSlave->mpSlave->_setSingleValue( *((*aIter).second->mpInfo), *pAny ); +pSlave->mxSlave->_setSingleValue( *((*aIter).second->mpInfo), *pAny ); } } @@ -230,7 +229,7 @@ void SAL_CALL MasterPropertySet::setPropertyValues( const Sequence< OUString >& { if( rSlave.second->IsInit() ) { -rSlave.second->mpSlave->_postSetValues(); +rSlave.second->mxSlave->_postSetValues(); rSlave.second->SetInit( false ); } } @@ -277,13 +276,13 @@ Sequence< Any > SAL_CALL MasterPropertySet::getPropertyValues( const Sequence< O if (!pSlave->IsInit()) { // acquire mutex in c-tor and releases it in the d-tor (exception safe!). -if (pSlave->mpSlave->mpMutex) -aOGuardArray[i].reset( new osl::Guard< comphelper::SolarMutex >(pSlave->mpSlave->mpMutex) ); +if (pSlave->mxSlave->mpMutex) +aOGuardArray[i].reset( new osl::Guard< comphelper::SolarMutex >(pSlave->mxSlave->mpMutex) ); -pSlave->mpSlave->_preGetValues(); +pSlave->mxSlave->_preGetValues(); pSlave->SetInit ( true ); } -pSlave->mpSlave->_getSingleValue( *((*aIter).second->mpInfo), *pAny ); +pSlave->mxSlave->_getSingleValue( *((*aIter).second->mpInfo), *pAny ); } } @@ -292,7 +291,7 @@ Sequence< Any > SAL_CALL MasterPropertySet::getPropertyValues( const Sequence< O { if( rSlave.second->IsInit() ) { -rSlave.second->mpSlave->_postSetValues(); +rSlave.second->mxSlave->_postSetValues(); rSlave.second->SetInit( false ); } } @@ -325,7 +324,7 @@ PropertyState SAL_CALL MasterPropertySet::getPropertyState( const OUString& Prop // 0 means it's one of ours ! if ( (*aIter).second->mnMapId != 0 ) { -ChainablePropertySet * pSlave = maSlaveMap [
[Libreoffice-commits] core.git: compilerplugins/clang include/tools oox/source sw/inc
compilerplugins/clang/unnecessaryvirtual.results| 74 ++-- include/tools/stream.hxx|4 - oox/source/drawingml/diagram/diagramlayoutatoms.hxx |2 sw/inc/doc.hxx |4 - 4 files changed, 42 insertions(+), 42 deletions(-) New commits: commit c40d9ecd912a777ee25c6da6fbd2564b0d43a9b9 Author: Noel GrandinDate: Wed Nov 8 11:01:57 2017 +0200 loplugin:unnecessaryvirtual Change-Id: I5696c853daa16c9e55ff046d67102ba3042bfea8 Reviewed-on: https://gerrit.libreoffice.org/44459 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results index c277376715c1..025ab76820eb 100644 --- a/compilerplugins/clang/unnecessaryvirtual.results +++ b/compilerplugins/clang/unnecessaryvirtual.results @@ -26,7 +26,9 @@ basic/source/comp/codegen.cxx:539 BufferTransformer::void-end() chart2/source/inc/WeakListenerAdapter.hxx:58 chart::WeakListenerAdapter::void-disposing(const css::lang::EventObject &,) -extensions/source/dbpilots/unoautopilot.hxx:99 +connectivity/source/drivers/firebird/SubComponent.hxx:72 + connectivity::firebird::OPropertyArrayUsageHelper::void-~OPropertyArrayUsageHelper() +extensions/source/dbpilots/unoautopilot.hxx:98 dbp::OUnoAutoPilotcppu::IPropertyArrayHelper *-createArrayHelper()const extensions/source/propctrlr/commoncontrol.hxx:127 pcr::CommonBehaviourControlsal_Int16-getControlType() @@ -64,9 +66,9 @@ forms/source/xforms/namedcollection.hxx:92 NamedCollection::sal_Bool-hasElements() forms/source/xforms/namedcollection.hxx:98 NamedCollection::css::uno::Any-getByName(const class rtl::OUString &,) -forms/source/xforms/namedcollection.hxx:108 +forms/source/xforms/namedcollection.hxx:106 NamedCollection::css::uno::Sequence-getElementNames() -forms/source/xforms/namedcollection.hxx:113 +forms/source/xforms/namedcollection.hxx:111 NamedCollection::sal_Bool-hasByName(const class rtl::OUString &,) include/comphelper/IdPropArrayHelper.hxx:53 comphelper::OIdPropertyArrayUsageHelper::void-~OIdPropertyArrayUsageHelper() @@ -92,10 +94,6 @@ include/comphelper/unique_disposing_ptr.hxx:168 comphelper::unique_disposing_solar_mutex_reset_ptr::void-reset(T *,) include/comphelper/weakeventlistener.hxx:118 comphelper::OWeakListenerAdapter::void-disposing(const css::lang::EventObject &,) -include/drawinglayer/primitive2d/borderlineprimitive2d.hxx:58 -drawinglayer::primitive2d::BorderLine::void-~BorderLine() -include/drawinglayer/primitive2d/borderlineprimitive2d.hxx:66 -drawinglayer::primitive2d::BorderLine::_Bool-operator==(const class drawinglayer::primitive2d::BorderLine &,)const include/sfx2/controlwrapper.hxx:257 sfx::MetricFieldWrapper::_Bool-IsControlDontKnow()const include/sfx2/controlwrapper.hxx:258 @@ -130,21 +128,21 @@ include/sfx2/itemwrapper.hxx:156 sfx::IdentItemWrapper::const ItemT &-GetItemValue(const ItemT &,)const include/sfx2/itemwrapper.hxx:158 sfx::IdentItemWrapper::void-SetItemValue(ItemT &,const ItemT &,)const -include/svl/itempool.hxx:171 -SfxItemPool::class SvStream &-Store(class SvStream &,)const include/svl/svdde.hxx:307 DdeService::void-~DdeService() -include/svtools/svparser.hxx:91 -SvParser::void-NextToken(T,) -include/svtools/svparser.hxx:127 -SvParser::void-Continue(T,) include/toolkit/controls/geometrycontrolmodel.hxx:192 OGeometryControlModel::void-fillProperties(css::uno::Sequence &,css::uno::Sequence &,)const -include/vbahelper/vbacollectionimpl.hxx:291 +include/tools/stream.hxx:294 +SvStream::_Bool-ReadLine(class rtl::OString &,sal_Int32,) +include/tools/stream.hxx:410 +SvStream::_Bool-good()const +include/unotools/fontcvt.hxx:55 +StarSymbolToMSMultiFont::void-~StarSymbolToMSMultiFont() +include/vbahelper/vbacollectionimpl.hxx:290 ScVbaCollectionBasesal_Int32-getCount() -include/vbahelper/vbacollectionimpl.hxx:296 +include/vbahelper/vbacollectionimpl.hxx:295 ScVbaCollectionBase::css::uno::Any-Item(const css::uno::Any &,const css::uno::Any &,) -include/vbahelper/vbacollectionimpl.hxx:325 +include/vbahelper/vbacollectionimpl.hxx:324 ScVbaCollectionBase::sal_Bool-hasElements() include/vbahelper/vbahelperinterface.hxx:77 InheritedHelperInterfaceImplsal_Int32-getCreator() @@ -166,23 +164,25 @@ include/vcl/vclptr.hxx:110 VclPtr::void-~VclPtr() mysqlc/source/mysqlc_subcomponent.hxx:104 connectivity::mysqlc::OPropertyArrayUsageHelper::void-~OPropertyArrayUsageHelper() -sc/inc/compressedarray.hxx:65 +oox/source/drawingml/diagram/diagramlayoutatoms.hxx:109 +oox::drawingml::LayoutAtom::void-addChild(const oox::drawingml::LayoutAtomPtr &,) +sc/inc/compressedarray.hxx:72
[Libreoffice-bugs] [Bug 113724] LibO Version 5.4.3.2 - if we try to open particular dbf file there is no ability to select Character (regression vs LibO 5.3.7.2)
https://bugs.documentfoundation.org/show_bug.cgi?id=113724 --- Comment #5 from Xavier Van Wijmeersch--- Confirm with Version: 5.4.4.0.0+ Build ID: 1649d5dfaca6fb29e75bd18e3e0d4f985a9eebeb CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); Calc: group Version: 5.4.2.2.0+ Build ID: SlackBuild for 5.4.2 by Eric Hameleers CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); Calc: group ok with Version: 5.3.1.2 Build ID: e80a0e0fd1875e1696614d24c32df0f95f03deb2 CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Layout Engine: new; Locale: nl-BE (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113728] Printing Problem in LibreOffice 5.4.2.2
https://bugs.documentfoundation.org/show_bug.cgi?id=113728 Mike Kaganskichanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 92190 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)
https://bugs.documentfoundation.org/show_bug.cgi?id=92190 Mike Kaganskichanged: What|Removed |Added CC||bikerman...@gmail.com --- Comment #75 from Mike Kaganski --- *** Bug 113728 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113728] New: Printing Problem in LibreOffice 5.4.2.2
https://bugs.documentfoundation.org/show_bug.cgi?id=113728 Bug ID: 113728 Summary: Printing Problem in LibreOffice 5.4.2.2 Product: LibreOffice Version: 5.4.2.2 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bikerman...@gmail.com Description: I'm currently running Version: 5.4.2.2 Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4 CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; Locale: en-US (en_US.UTF-8); Calc: group The problem is the PRINT Function ONLY allows you to print in LandScape. I would like to be able to print some things in Portrait. There is NOTHING in any of the Menu's to rotate the file 90 degrees left or right. Everything I try to print is set to landscape. I've tried changing my Printer settings, but the Preview always shows it printing in Landscape. Please investigate why this is so and how to fix it. If there is a way to work around it, it would be appreciated. Thank You Steps to Reproduce: 1. Select a Document to Print 2. Select the "Print" option on the main menu 3. Print screen shows the document will be printed in Landscape Mode 4. There is NO WAY to correct printing to Portrait as an option (LibreOffice Format) 5. The PRINT PREVIEW option shows the Document in Portrait, but the Print option of the Menu always sets the document to print in Landscape. Actual Results: 1. Select PRINT from Pull down Menu 2. Document shows up in the Print window box shows the Document in Landscape 3. Printer prints out document in Landscape mode. Expected Results: The Expected results would be for the Document to print out in Portrait instead of Landscape. No one wants a format document or outline in Landscape mode. Portrait mode should be the "Default" printing mode with the option to change it to Landscape if a person is printing a Spreadsheet, or Graphic diagram. Reproducible: Always User Profile Reset: No Additional Info: The SOFTWARE should have allowed the Customer to select which format they wish to have the Document printed in. This should be either a check box, with the selection of Landscape or Portrait or it should PRINT as the document is presented in "PRINT PREVIEW" If there is an update or a patch I can apply it would be appreciated. Thank You User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/604.3.5 (KHTML, like Gecko) Version/11.0.1 Safari/604.3.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf112352_nextPageColumns.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport9.cxx| 11 +++ writerfilter/source/dmapper/PropertyMap.cxx |2 +- 3 files changed, 12 insertions(+), 1 deletion(-) New commits: commit afc96d263959d10e457b54a574f0829d20e99df4 Author: Justin LuthDate: Tue Nov 7 09:29:30 2017 +0300 tdf#112352 ooxmlimport: ALWAYS treat 1st nextpage w/cols as cont fix 5.4 regression from 4605bd46984125a99b0e993b71efa6edb411699f. When there are columns, if a nextpage section doesn't contain any other "page style" details we treat it as a continuous break, If we don't, the column info becomes part of the style itself, and not just a section property. However, the very first section is troublesome - by definition it DOES contain page style details, and so if the document starts with columns, the default style would gain the column attribute. Usually that results in a mess, so lets make sure that we avoid that also in the case where headers/footers are defined. Change-Id: I7e08a9218e4304206579ed064bc92c9604d4470e Reviewed-on: https://gerrit.libreoffice.org/44505 Tested-by: Jenkins Reviewed-by: Justin Luth Tested-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/data/tdf112352_nextPageColumns.docx b/sw/qa/extras/ooxmlexport/data/tdf112352_nextPageColumns.docx new file mode 100644 index ..f14681dd51c2 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf112352_nextPageColumns.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx index 41a309d5713b..dddc7b2b918c 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx @@ -441,6 +441,17 @@ DECLARE_OOXMLEXPORT_TEST(testTdf103975_notPageBreakE, "tdf103975_notPageBreakE.d CPPUNIT_ASSERT_EQUAL(style::BreakType_COLUMN_BEFORE, getProperty(getParagraph(2), "BreakType")); } +DECLARE_OOXMLEXPORT_TEST(testTdf112352_nextPageColumns, "tdf112352_nextPageColumns.docx") +{ +uno::Reference xTextSection = getProperty< uno::Reference >(getParagraph(2), "TextSection"); +uno::Reference xTextColumns = getProperty< uno::Reference >(xTextSection, "TextColumns"); +CPPUNIT_ASSERT_EQUAL(sal_Int16(2), xTextColumns->getColumnCount()); + +xTextSection = getProperty< uno::Reference >(getParagraph(3), "TextSection"); +xTextColumns = getProperty< uno::Reference >(xTextSection, "TextColumns"); +CPPUNIT_ASSERT_EQUAL(sal_Int16(0), xTextColumns->getColumnCount()); +} + DECLARE_OOXMLEXPORT_TEST(testTdf109310_endnoteStyleForMSO, "tdf109310_endnoteStyleForMSO.docx") { xmlDocPtr pXmlDoc = parseExport("word/endnotes.xml"); diff --git a/writerfilter/source/dmapper/PropertyMap.cxx b/writerfilter/source/dmapper/PropertyMap.cxx index 1cf71588ce05..c416ba52ba69 100644 --- a/writerfilter/source/dmapper/PropertyMap.cxx +++ b/writerfilter/source/dmapper/PropertyMap.cxx @@ -1170,7 +1170,7 @@ void SectionPropertyMap::CloseSectionGroup( DomainMapper_Impl& rDM_Impl ) // Continuous sections usually create only a section, and not a new page style const bool bTreatAsContinuous = m_nBreakType == NS_ooxml::LN_Value_ST_SectionMark_nextPage && m_nColumnCount > 0 -&& !HasHeader( m_bTitlePage ) && !HasFooter( m_bTitlePage ) +&& (m_bIsFirstSection || (!HasHeader( m_bTitlePage ) && !HasFooter( m_bTitlePage )) ) && (m_bIsFirstSection || m_sFollowPageStyleName.isEmpty() || (m_sFirstPageStyleName.isEmpty() && m_bTitlePage)); if ( m_nBreakType == static_cast(NS_ooxml::LN_Value_ST_SectionMark_continuous) || bTreatAsContinuous ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94225] Writer crashes on undo times N ( steps in Comment 11 or Comment 38)
https://bugs.documentfoundation.org/show_bug.cgi?id=94225 --- Comment #41 from Fyodor--- I can reliably reproduce this bug on Windows even with new document. The Image should be anchored to last paragraph, and document should contain more than one paragraph. If image anchored to some other paragraph, but not last, there is no crush. During paste, image really isn't pasted, only paragraph's text. During undo not all steps undone, and crushes different every time. I'm going to investigate this bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94225] Writer crashes on undo times N ( steps in Comment 11 or Comment 38)
https://bugs.documentfoundation.org/show_bug.cgi?id=94225 Fyodorchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |fyodo...@hotmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/dist loleaflet/src
loleaflet/dist/loleaflet.css |4 loleaflet/src/control/Control.LokDialog.js |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) New commits: commit 2b8c4ee3bb2535dfc40019cf6c31684102606688 Author: Pranav KantDate: Thu Nov 9 09:48:44 2017 +0530 lokdialog: Remove padding around dialog canvas completely Change-Id: Ie6d65ca23936f081c5e2b37fff6f5d90d9fcd06e diff --git a/loleaflet/dist/loleaflet.css b/loleaflet/dist/loleaflet.css index 5c64f4dd..f139c026 100644 --- a/loleaflet/dist/loleaflet.css +++ b/loleaflet/dist/loleaflet.css @@ -344,3 +344,7 @@ body { .lokdialog.ui-dialog-content.ui-widget-content { padding: 0px; } + +.lokdialog_canvas { +display: block; /* required to remove all borders around canvas element */ +} diff --git a/loleaflet/src/control/Control.LokDialog.js b/loleaflet/src/control/Control.LokDialog.js index e7c2cd4c..329c45ea 100644 --- a/loleaflet/src/control/Control.LokDialog.js +++ b/loleaflet/src/control/Control.LokDialog.js @@ -39,7 +39,7 @@ L.Control.LokDialog = L.Control.extend({ _launchDialog: function(dialogId, width, height) { var canvas = '' + - '' + + '' + ''; $(document.body).append(canvas); var that = this; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/options/optgdlg.cxx| 125 -- cui/source/options/optgdlg.hxx|5 + cui/uiconfig/ui/optgeneralpage.ui | 65 +++ 3 files changed, 148 insertions(+), 47 deletions(-) New commits: commit 6502ebb0e977f6bea305e5e1598520a6b8b9f770 Author: Mike KaganskiDate: Wed Nov 8 23:12:44 2017 +0300 Related: tdf#110448: move Quickstart options to General page Change-Id: Ib1eab8202903adb5bfcf9bfcabab5d12a773d3bb Reviewed-on: https://gerrit.libreoffice.org/44508 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx index a9e21f35a0d2..1c90931c7afb 100644 --- a/cui/source/options/optgdlg.cxx +++ b/cui/source/options/optgdlg.cxx @@ -203,57 +203,57 @@ DeactivateRC OfaMiscTabPage::DeactivatePage( SfxItemSet* pSet_ ) namespace { -OUString impl_SystemFileOpenServiceName() -{ -const OUString = Application::GetDesktopEnvironment(); - -if ( rDesktopEnvironment.equalsIgnoreAsciiCase("kde4") ) -{ -#if ENABLE_KDE4 -return OUString("com.sun.star.ui.dialogs.KDE4FilePicker" ); -#else -return OUString(); -#endif -} -#if defined(_WIN32) -return OUString("com.sun.star.ui.dialogs.SystemFilePicker"); -#elif defined MACOSX -return OUString("com.sun.star.ui.dialogs.AquaFilePicker"); -#else -return OUString(); -#endif -} +OUString impl_SystemFileOpenServiceName() +{ +const OUString = Application::GetDesktopEnvironment(); + +if ( rDesktopEnvironment.equalsIgnoreAsciiCase("kde4") ) +{ +#if ENABLE_KDE4 +return OUString("com.sun.star.ui.dialogs.KDE4FilePicker" ); +#else +return OUString(); +#endif +} +#if defined(_WIN32) +return OUString("com.sun.star.ui.dialogs.SystemFilePicker"); +#elif defined MACOSX +return OUString("com.sun.star.ui.dialogs.AquaFilePicker"); +#else +return OUString(); +#endif +} -bool lcl_HasSystemFilePicker() -{ -if( Application::hasNativeFileSelection() ) -return true; +bool lcl_HasSystemFilePicker() +{ +if( Application::hasNativeFileSelection() ) +return true; -// Otherwise fall-back on querying services -bool bRet = false; -Reference< XMultiServiceFactory > xFactory = comphelper::getProcessServiceFactory(); +// Otherwise fall-back on querying services +bool bRet = false; +Reference< XMultiServiceFactory > xFactory = comphelper::getProcessServiceFactory(); -Reference< XContentEnumerationAccess > xEnumAccess( xFactory, UNO_QUERY ); -Reference< XSet > xSet( xFactory, UNO_QUERY ); +Reference< XContentEnumerationAccess > xEnumAccess( xFactory, UNO_QUERY ); +Reference< XSet > xSet( xFactory, UNO_QUERY ); -if ( ! xEnumAccess.is() || ! xSet.is() ) -return bRet; +if ( ! xEnumAccess.is() || ! xSet.is() ) +return bRet; -try -{ -OUString aFileService = impl_SystemFileOpenServiceName(); -Reference< XEnumeration > xEnum = xEnumAccess->createContentEnumeration( aFileService ); -if ( xEnum.is() && xEnum->hasMoreElements() ) -bRet = true; -} -catch (const IllegalArgumentException&) -{ -} -catch (const ElementExistException&) -{ -} -return bRet; -} +try +{ +OUString aFileService = impl_SystemFileOpenServiceName(); +Reference< XEnumeration > xEnum = xEnumAccess->createContentEnumeration( aFileService ); +if ( xEnum.is() && xEnum->hasMoreElements() ) +bRet = true; +} +catch (const IllegalArgumentException&) +{ +} +catch (const ElementExistException&) +{ +} +return bRet; +} } OfaMiscTabPage::OfaMiscTabPage(vcl::Window* pParent, const SfxItemSet& rSet) @@ -278,6 +278,13 @@ OfaMiscTabPage::OfaMiscTabPage(vcl::Window* pParent, const SfxItemSet& rSet) get(m_pYearValueField, "year"); get(m_pToYearFT, "toyear"); get(m_pCollectUsageInfo, "collectusageinfo"); +get(m_pQuickStarterFrame, "quickstarter"); + +#if defined(UNX) +get(m_pQuickLaunchCB, "systray"); +#else +get(m_pQuickLaunchCB, "quicklaunch"); +#endif if (m_pFileDlgCB->IsVisible() && SvtMiscOptions().IsUseSystemFileDialogReadOnly()) { @@ -285,6 +292,13 @@ OfaMiscTabPage::OfaMiscTabPage(vcl::Window* pParent, const SfxItemSet& rSet) m_pFileDlgCB->Disable(); } +m_pQuickLaunchCB->Show(); + +//Only
[Libreoffice-commits] online.git: kit/Kit.cpp loleaflet/src
kit/Kit.cpp| 89 + loleaflet/src/control/Control.LokDialog.js | 30 + loleaflet/src/control/Toolbar.js |3 loleaflet/src/core/Socket.js | 15 +++- loleaflet/src/layer/tile/TileLayer.js |5 - 5 files changed, 99 insertions(+), 43 deletions(-) New commits: commit a2a72572bbc7f48b6772ea5481b004102b3f08a0 Author: Pranav KantDate: Tue Nov 7 15:30:51 2017 +0530 lokdialog: Paint only part of the dialog when specified Change-Id: I5543c95a48fd0192e5c654598991125bcaeb62e4 Reviewed-on: https://gerrit.libreoffice.org/44519 Reviewed-by: pranavk Tested-by: pranavk diff --git a/kit/Kit.cpp b/kit/Kit.cpp index d798ce88..1a7d87c1 100644 --- a/kit/Kit.cpp +++ b/kit/Kit.cpp @@ -851,10 +851,6 @@ public: assert(ws && "Expected a non-null websocket."); const bool child = tokens[0] == "dialogchild"; -const int nCanvasWidth = 800; -const int nCanvasHeight = 600; -size_t pixmapDataSize = 4 * nCanvasWidth * nCanvasHeight; -std::vector pixmap(pixmapDataSize); std::unique_lock lock(_documentMutex); if (!_loKitDocument) @@ -869,38 +865,83 @@ public: return; } -int nWidth = nCanvasWidth; -int nHeight = nCanvasHeight; -Timestamp timestamp; +int startX = 0, startY = 0; +int bufferWidth = 800, bufferHeight = 600; // hopefully, this is big enough +std::string paintRectangle; +// find the rectangle to paint, if specified +if (tokens.size() >= 3 && getTokenString(tokens[2], "rectangle", paintRectangle)) +{ +const std::vector rectParts = LOOLProtocol::tokenize(paintRectangle.c_str(), paintRectangle.length(), ','); +startX = std::atoi(rectParts[0].c_str()); +startY = std::atoi(rectParts[1].c_str()); +bufferWidth = std::atoi(rectParts[2].c_str()); +bufferHeight = std::atoi(rectParts[3].c_str()); +} + +size_t pixmapDataSize = 4 * bufferWidth * bufferHeight; +std::vector pixmap(pixmapDataSize); + char* pDialogTitle = nullptr; +int width = bufferWidth; +int height = bufferHeight; +std::string response; if (child) -_loKitDocument->paintActiveFloatingWindow(tokens[1].c_str(), pixmap.data(), nWidth, nHeight); +{ +Timestamp timestamp; +_loKitDocument->paintActiveFloatingWindow(tokens[1].c_str(), pixmap.data(), width, height); +const auto elapsed = timestamp.elapsed(); +const double area = width * height; +LOG_TRC("paintActiveFloatingWindow for " << tokens[1] << " returned floating window " +<< width << "X" << height << " " +<< "rendered in " << (elapsed/1000.) +<< "ms (" << area / elapsed << " MP/s)."); + +response = "dialogchildpaint: id=" + tokens[1] + " width=" + std::to_string(width) + " height=" + std::to_string(height) + "\n"; +} else -_loKitDocument->paintDialog(tokens[1].c_str(), pixmap.data(), , nWidth, nHeight); +{ +Timestamp timestamp; +_loKitDocument->paintDialog(tokens[1].c_str(), pixmap.data(), startX, startY, width, height); +const auto elapsed = timestamp.elapsed(); -const double area = nWidth * nHeight; -const auto elapsed = timestamp.elapsed(); -LOG_TRC((child ? std::string("paintActiveFloatingWindow") : std::string("paintDialog")) + -" for " << tokens[1] << " returned with size" << nWidth << "X" << nHeight -<< " and rendered in " << (elapsed/1000.) << -" ms (" << area / elapsed << " MP/s)."); +int dialogWidth = 0; +int dialogHeight = 0; +_loKitDocument->getDialogInfo(tokens[1].c_str(), , dialogWidth, dialogHeight); -std::string encodedDialogTitle; -if (pDialogTitle) -{ -std::string aDialogTitle(pDialogTitle); -URI::encode(aDialogTitle, "", encodedDialogTitle); -free(pDialogTitle); +std::string encodedDialogTitle; +if (pDialogTitle) +{ +std::string aDialogTitle(pDialogTitle); +URI::encode(aDialogTitle, "", encodedDialogTitle); +free(pDialogTitle); +} + +// rendered width, height cannot be less than the dialog width, height +width = std::min(width, dialogWidth); +height = std::min(height, dialogHeight); +const double area = width * height; + +LOG_TRC("paintDialog for " << tokens[1] << " returned " << width << "X" << height +<< "@(" << startX << "," <<
[Libreoffice-commits] online.git: 2 commits - kit/Kit.cpp loleaflet/dist loleaflet/src wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp
kit/Kit.cpp| 11 --- loleaflet/dist/loleaflet.css |6 +- loleaflet/src/control/Control.LokDialog.js | 21 + loleaflet/src/control/Toolbar.js |4 ++-- wsd/ClientSession.cpp | 28 ++-- wsd/ClientSession.hpp |2 -- wsd/DocumentBroker.cpp |8 ++-- wsd/DocumentBroker.hpp |4 +--- 8 files changed, 33 insertions(+), 51 deletions(-) New commits: commit f1d78c7e6268ca43c6a949f61599780a5a8d7d73 Author: Pranav KantDate: Sun Nov 5 15:57:12 2017 +0530 lokdialog: send invalidate rectangle in dialog command Change-Id: Iae00498a0ead1ee65dfce0332721e0d0fd2202fb Reviewed-on: https://gerrit.libreoffice.org/44518 Reviewed-by: pranavk Tested-by: pranavk diff --git a/kit/Kit.cpp b/kit/Kit.cpp index 2cf541ed..d798ce88 100644 --- a/kit/Kit.cpp +++ b/kit/Kit.cpp @@ -846,10 +846,11 @@ public: ws->sendFrame(output.data(), output.size(), WebSocket::FRAME_BINARY); } -void renderDialog(const std::vector& tokens, const std::shared_ptr& ws, bool child) +void renderDialog(const std::vector& tokens, const std::shared_ptr& ws) { assert(ws && "Expected a non-null websocket."); +const bool child = tokens[0] == "dialogchild"; const int nCanvasWidth = 800; const int nCanvasHeight = 600; size_t pixmapDataSize = 4 * nCanvasWidth * nCanvasHeight; @@ -1733,13 +1734,9 @@ private: { renderCombinedTiles(tokens, _ws); } -else if (tokens[0] == "dialog") +else if (tokens[0] == "dialog" || tokens[0] == "dialogchild") { -renderDialog(tokens, _ws, false); -} -else if (tokens[0] == "dialogchild") -{ -renderDialog(tokens, _ws, true); +renderDialog(tokens, _ws); } else if (LOOLProtocol::getFirstToken(tokens[0], '-') == "child") { diff --git a/loleaflet/src/control/Control.LokDialog.js b/loleaflet/src/control/Control.LokDialog.js index 96e5388f..65ebf07c 100644 --- a/loleaflet/src/control/Control.LokDialog.js +++ b/loleaflet/src/control/Control.LokDialog.js @@ -19,12 +19,17 @@ L.Control.LokDialog = L.Control.extend({ }, _onDialogMsg: function(e) { - // FIXME: core sends a different id for many dialogs in callbacks e.dialogId = e.dialogId.replace('.uno:', ''); if (e.action === 'invalidate') { // ignore any invalidate callbacks when we have closed the dialog if (this._isOpen(e.dialogId)) { - this._map.sendDialogCommand(e.dialogId); + var rect = e.rectangle.match(/\d+g/); + if (rect != null && rect.length == 4) { + var json = { + rectangle: e.rectangle + }; + } + this._map.sendDialogCommand(e.dialogId, json); } } else if (e.action === 'close') { this._onDialogClose(e.dialogId); diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js index 4ec419e3..960c02d4 100644 --- a/loleaflet/src/control/Toolbar.js +++ b/loleaflet/src/control/Toolbar.js @@ -139,14 +139,14 @@ L.Map.include({ } }, - sendDialogCommand: function (command, json, child) { + sendDialogCommand: function (command, rectangle, child) { if (this._permission === 'edit') { if (!command.startsWith('.uno:')) command = '.uno:' + command; var dialogCmd = 'dialog'; if (child) dialogCmd = 'dialogchild'; - this._socket.sendMessage(dialogCmd + ' ' + command + (json ? ' ' + JSON.stringify(json) : '')); + this._socket.sendMessage(dialogCmd + ' ' + command + (rectangle ? ' rectangle=' + rectangle : '')); } }, diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp index 544b8497..c6b25f8f 100644 --- a/wsd/ClientSession.cpp +++ b/wsd/ClientSession.cpp @@ -221,13 +221,9 @@ bool ClientSession::_handleInput(const char *buffer, int length) { return sendTile(buffer, length, tokens, docBroker); } -else if (tokens[0] == "dialog") +else if (tokens[0] == "dialog" || tokens[0] == "dialogchild") { -
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx | 133 1 file changed, 133 insertions(+) New commits: commit 03989b70e005599fc4dc290d7689a014a25c48de Author: Pranav KantDate: Wed Nov 8 19:45:13 2017 +0530 lokdialog: Compress invalidation callbacks in Callback flush handler Change-Id: Id76bde54395611f509a5d4be6bb2ac9b7f6ed1c0 Reviewed-on: https://gerrit.libreoffice.org/44474 Tested-by: Jenkins Reviewed-by: pranavk diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index a5df72c72ac9..45a59345375a 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -1022,6 +1022,139 @@ void CallbackFlushHandler::queue(const int type, const char* data) } } break; + +case LOK_CALLBACK_DIALOG: +{ +// reading JSON by boost might be slow? +boost::property_tree::ptree aTree; +std::stringstream aStream(payload); +boost::property_tree::read_json(aStream, aTree); +const std::string aDialogId = aTree.get("dialogId", ""); +if (aTree.get("action", "") == "invalidate") +{ +std::string aRectStr = aTree.get("rectangle", ""); +// no 'rectangle' field => invalidate all of the dialog => +// remove all previous dialog part invalidations +if (aRectStr.empty()) +{ +removeAll([] (const queue_type::value_type& elem) { +if (elem.first == LOK_CALLBACK_DIALOG) +{ +boost::property_tree::ptree aOldTree; +std::stringstream aOldStream(elem.second); + boost::property_tree::read_json(aOldStream, aOldTree); +const std::string aOldDialogId = aOldTree.get("dialogId", ""); +if (aOldTree.get("action", "") == "invalidate" && +aDialogId == aOldDialogId) +{ +return true; +} +} +return false; +}); +} +else +{ +// if we have to invalidate all of the dialog, ignore +// any part invalidation message +const auto& pos = std::find_if(m_queue.rbegin(), m_queue.rend(), + [] (const queue_type::value_type& elem) + { + if (elem.first != LOK_CALLBACK_DIALOG) + return false; + + boost::property_tree::ptree aOldTree; + std::stringstream aOldStream(elem.second); + boost::property_tree::read_json(aOldStream, aOldTree); + const std::string aOldDialogId = aOldTree.get("dialogId", ""); + if (aOldTree.get("action", "") == "invalidate" && + aDialogId == aOldDialogId && + aOldTree.get("rectangle", "").empty()) + { + return true; + } + return false; + }); + +// we found a invalidate-all dialog callback +if (pos != m_queue.rend()) +{ +SAL_INFO("lok.dialog", "Skipping queue [" << type << "]: [" << payload << "] since whole dialog needs to be invalidated."); +return; +} + +std::istringstream aRectStream(aRectStr); +long nLeft, nTop, nWidth, nHeight; +char nComma; +aRectStream >> nLeft >> nComma >> nTop >> nComma >> nWidth >> nComma >> nHeight; +tools::Rectangle aNewRect = tools::Rectangle(nLeft, nTop, nLeft +
[Libreoffice-commits] core.git: desktop/source include/LibreOfficeKit include/vcl libreofficekit/qa sw/inc sw/source
desktop/source/lib/init.cxx | 46 +--- include/LibreOfficeKit/LibreOfficeKit.h | 10 +++- include/LibreOfficeKit/LibreOfficeKit.hxx | 40 ++--- include/vcl/IDialogRenderable.hxx |5 +- libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx |6 +- sw/inc/unotxdoc.hxx |3 - sw/source/uibase/uno/unotxdoc.cxx | 24 -- 7 files changed, 91 insertions(+), 43 deletions(-) New commits: commit 25822ff930edd13442442a47714755a99fbb9992 Author: Pranav KantDate: Sun Nov 5 18:40:52 2017 +0530 lokdialog: Move getting dialog information in separate LOK call Using outparameters to get the dialog information with the paintDialog call was quite confusing. Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2 Reviewed-on: https://gerrit.libreoffice.org/44473 Tested-by: Jenkins Reviewed-by: pranavk diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index d126da925b2b..a5df72c72ac9 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -610,7 +610,12 @@ static unsigned char* doc_renderFont(LibreOfficeKitDocument* pThis, int* pFontHeight); static char* doc_getPartHash(LibreOfficeKitDocument* pThis, int nPart); -static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId, const int x, const int y, unsigned char* pBuffer, char** pDialogTitle, int* nWidth, int* nHeight); +static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId, unsigned char* pBuffer, +const int nX, const int nY, +const int nWidth, const int nHeight); + +static void doc_getDialogInfo(LibreOfficeKitDocument* pThis, const char* pDialogId, + char** pDialogTitle, int* nWidth, int* nHeight); static void doc_paintActiveFloatingWindow(LibreOfficeKitDocument* pThis, const char* pDialogId, unsigned char* pBuffer, int* nWidth, int* nHeight); @@ -664,6 +669,7 @@ LibLODocument_Impl::LibLODocument_Impl(const uno::Reference getPartHash = doc_getPartHash; m_pDocumentClass->paintDialog = doc_paintDialog; +m_pDocumentClass->getDialogInfo = doc_getDialogInfo; m_pDocumentClass->paintActiveFloatingWindow = doc_paintActiveFloatingWindow; gDocumentClass = m_pDocumentClass; @@ -3091,11 +3097,29 @@ unsigned char* doc_renderFont(SAL_UNUSED_PARAMETER LibreOfficeKitDocument* /*pTh return nullptr; } +static void doc_getDialogInfo(LibreOfficeKitDocument* pThis, const char* pDialogId, + char** pDialogTitle, int* nWidth, int* nHeight) +{ +SolarMutexGuard aGuard; + +IDialogRenderable* pDialogRenderable = getDialogRenderable(pThis); +vcl::DialogID aDialogID = OUString::createFromAscii(pDialogId); +OUString aDialogTitle; +pDialogRenderable->getDialogInfo(aDialogID, aDialogTitle, *nWidth, *nHeight); + +// copy dialog title +if (!aDialogTitle.isEmpty()) +{ +OString aTitleString = OUStringToOString(aDialogTitle, RTL_TEXTENCODING_UTF8); +*pDialogTitle = static_cast (malloc(aTitleString.getLength() + 1)); +strcpy(*pDialogTitle, aTitleString.getStr()); +} +} + static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId, -const int x, const int y, unsigned char* pBuffer, -char** pDialogTitle, -int* nWidth, int* nHeight) +const int nX, const int nY, +const int nWidth, const int nHeight) { SolarMutexGuard aGuard; @@ -3104,24 +3128,16 @@ static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId ScopedVclPtrInstance pDevice(nullptr, Size(1, 1), DeviceFormat::DEFAULT); pDevice->SetBackground(Wallpaper(Color(COL_TRANSPARENT))); -pDevice->SetOutputSizePixelScaleOffsetAndBuffer(Size(*nWidth, *nHeight), Fraction(1.0), Point(), pBuffer); +pDevice->SetOutputSizePixelScaleOffsetAndBuffer(Size(nWidth, nHeight), Fraction(1.0), Point(), pBuffer); vcl::DialogID aDialogID = OUString::createFromAscii(pDialogId); MapMode aMapMode(pDevice->GetMapMode()); -aMapMode.SetOrigin(Point(-x, -y)); +aMapMode.SetOrigin(Point(-nX, -nY)); pDevice->SetMapMode(aMapMode); comphelper::LibreOfficeKit::setDialogPainting(true); -// copy the title of the dialog to outparam -OUString aDialogTitle; -pDialogRenderable->paintDialog(aDialogID, *pDevice.get(), aDialogTitle, *nWidth, *nHeight); -if (!aDialogTitle.isEmpty()) -{ -OString aTitleString = OUStringToOString(aDialogTitle, RTL_TEXTENCODING_UTF8); -
[Libreoffice-commits] core.git: desktop/source include/LibreOfficeKit include/sfx2 include/vcl libreofficekit/qa sfx2/source sw/inc sw/source vcl/source
desktop/source/lib/init.cxx | 13 - include/LibreOfficeKit/LibreOfficeKit.h |6 ++ include/LibreOfficeKit/LibreOfficeKit.hxx | 14 +- include/sfx2/lokhelper.hxx |2 include/vcl/IDialogRenderable.hxx |2 libreofficekit/qa/gtktiledviewer/gtv-helpers.cxx| 19 libreofficekit/qa/gtktiledviewer/gtv-helpers.hxx|2 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx | 22 +++--- libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.hxx |2 libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx | 21 - sfx2/source/view/lokhelper.cxx | 11 +++-- sw/inc/unotxdoc.hxx |2 sw/source/uibase/uno/unotxdoc.cxx |4 - vcl/source/control/ctrl.cxx |4 + vcl/source/window/dialog.cxx|6 +- 15 files changed, 100 insertions(+), 30 deletions(-) New commits: commit 446a37ece35dbe4c442f0679dd1cb4df79ed87a7 Author: Pranav KantDate: Sun Nov 5 14:01:42 2017 +0530 lokdialog: Support painting parts of the dialog Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins Reviewed-by: pranavk diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 891911429438..d126da925b2b 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -610,7 +610,7 @@ static unsigned char* doc_renderFont(LibreOfficeKitDocument* pThis, int* pFontHeight); static char* doc_getPartHash(LibreOfficeKitDocument* pThis, int nPart); -static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId, unsigned char* pBuffer, char** pDialogTitle, int* nWidth, int* nHeight); +static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId, const int x, const int y, unsigned char* pBuffer, char** pDialogTitle, int* nWidth, int* nHeight); static void doc_paintActiveFloatingWindow(LibreOfficeKitDocument* pThis, const char* pDialogId, unsigned char* pBuffer, int* nWidth, int* nHeight); @@ -3091,7 +3091,11 @@ unsigned char* doc_renderFont(SAL_UNUSED_PARAMETER LibreOfficeKitDocument* /*pTh return nullptr; } -static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId, unsigned char* pBuffer, char** pDialogTitle, int* nWidth, int* nHeight) +static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId, +const int x, const int y, +unsigned char* pBuffer, +char** pDialogTitle, +int* nWidth, int* nHeight) { SolarMutexGuard aGuard; @@ -3104,8 +3108,11 @@ static void doc_paintDialog(LibreOfficeKitDocument* pThis, const char* pDialogId vcl::DialogID aDialogID = OUString::createFromAscii(pDialogId); -comphelper::LibreOfficeKit::setDialogPainting(true); +MapMode aMapMode(pDevice->GetMapMode()); +aMapMode.SetOrigin(Point(-x, -y)); +pDevice->SetMapMode(aMapMode); +comphelper::LibreOfficeKit::setDialogPainting(true); // copy the title of the dialog to outparam OUString aDialogTitle; pDialogRenderable->paintDialog(aDialogID, *pDevice.get(), aDialogTitle, *nWidth, *nHeight); diff --git a/include/LibreOfficeKit/LibreOfficeKit.h b/include/LibreOfficeKit/LibreOfficeKit.h index cc4752e04ab2..cb0f17a41655 100644 --- a/include/LibreOfficeKit/LibreOfficeKit.h +++ b/include/LibreOfficeKit/LibreOfficeKit.h @@ -268,7 +268,11 @@ struct _LibreOfficeKitDocumentClass /// Paints dialog with given dialog id to the buffer /// @see lok::Document::paintDialog(). -void (*paintDialog) (LibreOfficeKitDocument* pThis, const char* pDialogId, unsigned char* pBuffer, char** pDialogTitle, int* nWidth, int* nHeight); +void (*paintDialog) (LibreOfficeKitDocument* pThis, const char* pDialogId, + const int x, const int y, + unsigned char* pBuffer, + char** pDialogTitle, + int* nWidth, int* nHeight);
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/data/tdf66401.docx |binary sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx | 13 + 2 files changed, 13 insertions(+) New commits: commit ee57d2f8a57ac851c1250f2962ecd1fa987ee3d9 Author: Andreas BrandnerDate: Fri Oct 27 15:29:25 2017 +0200 related tdf#66401 docx Combined Characters roundtrip unit test Change-Id: Ibe11882ab24e9161a36d195497b0a430497d7f79 Reviewed-on: https://gerrit.libreoffice.org/43953 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/sw/qa/extras/ooxmlexport/data/tdf66401.docx b/sw/qa/extras/ooxmlexport/data/tdf66401.docx new file mode 100644 index ..2e2ddca375d7 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf66401.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx index 736a4b9e6a24..458c91652873 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx @@ -692,6 +692,19 @@ DECLARE_OOXMLEXPORT_TEST( testTdf85161, "tdf85161.docx" ) CPPUNIT_ASSERT_EQUAL(OUString(u'\x5e'),getParagraph(1)->getString()); } +DECLARE_OOXMLEXPORT_TEST( testTdf66401, "tdf66401.docx") +{ +if (xmlDocPtr pXmlDoc = parseExport("word/document.xml")) +{ +assertXPath(pXmlDoc, "/w:document/w:body/w:p[1]/w:r[3]/w:rPr/w:rFonts", 1); +assertXPath(pXmlDoc, "/w:document/w:body/w:p[1]/w:r[3]/w:rPr/w:rFonts", "ascii", "Arial Black"); +assertXPath(pXmlDoc, "/w:document/w:body/w:p[1]/w:r[3]/w:rPr/w:sz", "val", "24"); +assertXPath(pXmlDoc, "/w:document/w:body/w:p[1]/w:r[9]/w:rPr/w:rFonts", 1); +assertXPath(pXmlDoc, "/w:document/w:body/w:p[1]/w:r[9]/w:rPr/w:rFonts", "ascii", "Arial Black"); +assertXPath(pXmlDoc, "/w:document/w:body/w:p[1]/w:r[9]/w:rPr/w:sz", "val", "24"); +} +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112998] Calc Hangs When Auto-filter Is Set and Row/ Column Freeze Enabled and Fcitx Input Method Enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=112998 Kevin Suochanged: What|Removed |Added Keywords||haveBacktrace Summary|Calc Freezes (Not |Calc Hangs When Auto-filter |Responding) When|Is Set and Row/Column |Auto-filter Is Set and |Freeze Enabled and Fcitx |Row/Column Freeze Enabled |Input Method Enabled |and Fcitx Input Method | |Enabled | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112998] Calc Freezes (Not Responding) When Auto-filter Is Set and Row /Column Freeze Enabled and Fcitx Input Method Enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=112998 Kevin Suochanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #16 from Kevin Suo --- Set to NEW per comment 15. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113727] New: Fresh Install wont open
https://bugs.documentfoundation.org/show_bug.cgi?id=113727 Bug ID: 113727 Summary: Fresh Install wont open Product: LibreOffice Version: 5.4.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: quentin.hol...@gmail.com I have installed a few times. Windows 10. Laptop with not much on it. But when ever i open LibreOffice it just goes to a blank window and sit there. It opens in Safe mode but nothing i have tried will get it to open in normal mode. Ideas? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108580] Cannot run LibreOffice, api-ms-win-crt-runtime-l1-1-0.dll is missing ( for local solution see comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=108580 --- Comment #26 from Boris Silva R--- (In reply to Boris Silva R from comment #25) > What are the dll to copy to get installed 5.4.2.2 from 5.4.2.2 portable? For now i copy all api-ms-win-***.dll fron the LibreOfficePortable\App\libreoffice\program to the installed LO 5.4.2.2 and get it working in Win7 (no sp1) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35077] [UI] Add an OPTION to switch off special effects, such as flashing lines around copy source cell(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=35077 --- Comment #27 from MarjaE--- I have trouble seeing around flashing/blinking/etc. pain. I mostly use NeoOffice, because it works with a hack to stop the pain. I still occasionally use LibreOffice Draw, where escape drops the selection, so that workaround won't help. So from my perspective, with my disabilities, flashing/blinking/etc. objects are an important barrier to usability and accessibility. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113714] Flicker when hovering over main menu with default rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=113714 --- Comment #2 from Aron Budea--- It is hard to say what constitutes "same" issue. The flickering in the about box is much older than this issue, and first appeared in 4.0.0.3 (vs being fine in 3.6.0.4). But of course the underlying behavior what causes the flickering could be closely related. On another note there's bug 91366 on menu item flickering, which isn't really fixed: the flickering only got restricted to the selected menu item, but is still there. Actually, even the individual toolbar buttons flicker a little upon hovering over them. It would be nice to learn of a recipe on how similar issues could now be tackled. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112889] [META] Screen flickering when hovering on items or selecting text with default rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=112889 Aron Budeachanged: What|Removed |Added Depends on||91366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91366 [Bug 91366] UI: Menu flicker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91366] UI: Menu flicker
https://bugs.documentfoundation.org/show_bug.cgi?id=91366 Aron Budeachanged: What|Removed |Added Blocks||112889 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112889 [Bug 112889] [META] Screen flickering when hovering on items or selecting text with default rendering -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113726] New: Trailing space in cell text not encoded as
https://bugs.documentfoundation.org/show_bug.cgi?id=113726 Bug ID: 113726 Summary: Trailing space in cell text not encoded as Product: LibreOffice Version: 5.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: achurch+...@achurch.org If a cell contains a trailing space, the space is copied literally to the content of the tag for the cell rather than being encoded as a tag: ... spaces ... I'm not familiar with the ODS spec so I don't know whether a literal space is permitted in this context, but at least some versions of Excel seem to discard the space. (LibreOffice itself preserves the space without problems.) To reproduce, create a new Calc document, enter the text " spaces " in the first cell, and save as ODS. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112998] Calc Freezes (Not Responding) When Auto-filter Is Set and Row /Column Freeze Enabled and Fcitx Input Method Enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=112998 --- Comment #15 from Xuetian Weng--- Hi I'm a fcitx developer. So to reproduce this problem the ooo desktop plugin need to be Gtk. Qt(KDE) doesn't have such problem. IBus and Fcitx have been using such implementation for long time: https://github.com/fcitx/fcitx/blob/master/src/frontend/gtk2/fcitximcontext.c#L922 https://github.com/ibus/ibus/blob/master/client/gtk2/ibusimcontext.c#L944 And IMHO it is the only way to get the surrounding text in Gtk "on-time". Otherwise, if the surrounding text is not updated before the key event, the input method won't be able to use the up-to-date surrounding text information to process the key event. I noticed that when after bug is triggered, in spite of the freeze, the memory is increasing dramatically. My guess is that certain function in libreoffice is not reentrant and causes this bug. My trick on reproducing this bug, is to do a "alt-tab" when the drop down list is opened. I can always reproduce this freeze with this additional step. I tried to apply some workaround locally, e.g. delay "retrieve-surrounding" signal and emit it later. The issue is gone here. But I don't know if it can be still triggered in some other places. E.g. , we can't delay the retrieve-surrounding signal when handle key event. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89466] [META] SIDEBAR: Slide and Page content panels in Properties tab in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=89466 Xisco Faulíchanged: What|Removed |Added Depends on||113725 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113725 [Bug 113725] Sidebar: Master Slide menu is broken if going from handout view -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113725] Sidebar: Master Slide menu is broken if going from handout view
https://bugs.documentfoundation.org/show_bug.cgi?id=113725 Xisco Faulíchanged: What|Removed |Added Keywords||bibisected, bisected, ||regression Status|UNCONFIRMED |NEW CC||timo...@eastlincoln.net, ||xiscofa...@libreoffice.org, ||zolnaitamas2...@gmail.com Blocks||89466 Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Regression introduced by: author blendergeek 2017-09-05 21:12:21 (GMT) committer Tamás Zolnai 2017-09-06 15:02:30 (GMT) commit 6758db065d77bdebed54e5d3532796a2c3c24088 (patch) treead8f3b49ce507dd6c886613f3afa7672ceb285a7 parent 4fa014099e99d91088f55b15273117fd0fc26679 (diff) tdf#111834: hide useless background controls in Handout View Bisected with: bibisect-linux64-6.0 Adding Cc: to blendergeek Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=89466 [Bug 89466] [META] SIDEBAR: Slide and Page content panels in Properties tab in Impress/Draw -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113725] New: Sidebar: Master Slide menu is broken if going from handout view
https://bugs.documentfoundation.org/show_bug.cgi?id=113725 Bug ID: 113725 Summary: Sidebar: Master Slide menu is broken if going from handout view Product: LibreOffice Version: 6.0.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Created attachment 137627 --> https://bugs.documentfoundation.org/attachment.cgi?id=137627=edit screenshot Steps to reproduce: 1. Open Impress 2. Go to View - Master Handout 3. Go to View - Master Slide Spacing between elements in the sidebar is none. See attached image Reproduced in Version: 6.0.0.0.alpha1+ Build ID: 5e0022c90c4125a1590b3688dfec73c271b7aedd CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: th-TH (ca_ES.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111826] Issues with sidebar's Master Slide / Close Master Slide button in handout view
https://bugs.documentfoundation.org/show_bug.cgi?id=111826 --- Comment #2 from Xisco Faulí--- Gerrit patch: https://gerrit.libreoffice.org/#/c/44516/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111826] Issues with sidebar's Master Slide / Close Master Slide button in handout view
https://bugs.documentfoundation.org/show_bug.cgi?id=111826 Xisco Faulíchanged: What|Removed |Added Status|NEW |ASSIGNED CC||xiscofa...@libreoffice.org QA Contact||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/source
sw/source/filter/ww8/docxattributeoutput.cxx | 22 +++--- sw/source/filter/ww8/docxattributeoutput.hxx |2 +- sw/source/filter/ww8/wrtw8nds.cxx|4 ++-- sw/source/filter/ww8/wrtww8.hxx |4 ++-- sw/source/filter/ww8/ww8atr.cxx | 18 -- 5 files changed, 40 insertions(+), 10 deletions(-) New commits: commit a3dbed366cdebac4e8cad5ecab6e735cd4b4efe3 Author: Andreas BrandnerDate: Sun Nov 5 20:41:31 2017 +0100 tdf#66401 don't lose docx-combined-characters' font props on roundtrip - font-size will now get halfed, if exported within a combined-characters-field in docx - font-property will get exported for every run in a field, this redundancy is required by MS Word Change-Id: Idbdb5bf3066e2ed86b494255d72d66eebf72f755 Reviewed-on: https://gerrit.libreoffice.org/44509 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 467177d013fa..e8cdfc86182c 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -1740,12 +1740,18 @@ void DocxAttributeOutput::DoWriteCmd( const OUString& rCmd ) void DocxAttributeOutput::CmdField_Impl( const SwTextNode* pNode, sal_Int32 nPos, FieldInfos const & rInfos, bool bWriteRun ) { +bool bWriteCombChars(false); + // Write the Field instruction { if ( bWriteRun ) { m_pSerializer->startElementNS( XML_w, XML_r, FSEND ); -DoWriteFieldRunProperties( pNode, nPos ); + +if (rInfos.eType == ww::eEQ) +bWriteCombChars = true; + +DoWriteFieldRunProperties( pNode, nPos, bWriteCombChars ); } sal_Int32 nNbToken = comphelper::string::getTokenCount(rInfos.sCmd, '\t'); @@ -1829,7 +1835,7 @@ void DocxAttributeOutput::CmdField_Impl( const SwTextNode* pNode, sal_Int32 nPos /// /// /// See, tdf#38778 -void DocxAttributeOutput::DoWriteFieldRunProperties( const SwTextNode * pNode, sal_Int32 nPos ) +void DocxAttributeOutput::DoWriteFieldRunProperties( const SwTextNode * pNode, sal_Int32 nPos, bool bWriteCombChars) { if (! pNode) { @@ -1859,7 +1865,17 @@ void DocxAttributeOutput::DoWriteFieldRunProperties( const SwTextNode * pNode, s // 3. output all other character properties SwWW8AttrIter aAttrIt( m_rExport, *pNode ); -aAttrIt.OutAttr( nPos, false ); +aAttrIt.OutAttr( nPos, false, bWriteCombChars ); + +// 4. explicitly write the font-properties, to ensure all runs in the field have them +// see tdf#66401 +if ( m_pFontsAttrList.is() ) +{ +XFastAttributeListRef xAttrList( m_pFontsAttrList.get() ); +m_pFontsAttrList.clear(); + +m_pSerializer->singleElementNS( XML_w, XML_rFonts, xAttrList ); +} m_pSerializer->endElementNS( XML_w, XML_rPr ); diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx b/sw/source/filter/ww8/docxattributeoutput.hxx index 4c41f83d2f30..64fa4238e617 100644 --- a/sw/source/filter/ww8/docxattributeoutput.hxx +++ b/sw/source/filter/ww8/docxattributeoutput.hxx @@ -729,7 +729,7 @@ private: void DoWriteCmd( const OUString& rCmd ); void CmdField_Impl( const SwTextNode* pNode, sal_Int32 nPos, FieldInfos const & rInfos, bool bWriteRun ); void EndField_Impl( const SwTextNode* pNode, sal_Int32 nPos, FieldInfos& rInfos ); -void DoWriteFieldRunProperties( const SwTextNode* pNode, sal_Int32 nPos ); +void DoWriteFieldRunProperties( const SwTextNode* pNode, sal_Int32 nPos, bool bWriteCombChars = false ); virtual void GenerateBookmarksForSequenceField(const SwTextNode& rNode, SwWW8AttrIter& rAttrIter) override; static void AddToAttrList( css::uno::Reference& pAttrList, sal_Int32 nAttrName, const sal_Char* sAttrValue ); diff --git a/sw/source/filter/ww8/wrtw8nds.cxx b/sw/source/filter/ww8/wrtw8nds.cxx index e9ba18f40d6f..33b67ea5e627 100644 --- a/sw/source/filter/ww8/wrtw8nds.cxx +++ b/sw/source/filter/ww8/wrtw8nds.cxx @@ -382,7 +382,7 @@ static bool lcl_isFontsizeItem( const SfxPoolItem& rItem ) rItem.Which( ) == RES_CHRATR_CTL_FONTSIZE ); } -void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool bRuby ) +void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool bRuby , bool bWriteCombChars) { m_rExport.AttrOutput().RTLAndCJKState( IsCharRTL(), GetScript() ); @@ -488,7 +488,7 @@ void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool bRuby ) // tdf#38778 Fix output of the font in DOC run for fields const SvxFontItem * pFontToOutput = ( rParentFont != *pFont )? pFont : nullptr; -m_rExport.ExportPoolItemsToCHP( aExportItems, GetScript(), pFontToOutput ); +
[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104520 Bug 104520 depends on bug 66401, which changed state. Bug 66401 Summary: FILESAVE: DOCX exported document shows 'Combined Characters' with wrong font in MSWord https://bugs.documentfoundation.org/show_bug.cgi?id=66401 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx | 22 +++--- sw/source/filter/ww8/docxattributeoutput.hxx |2 +- sw/source/filter/ww8/wrtw8nds.cxx|4 ++-- sw/source/filter/ww8/wrtww8.hxx |4 ++-- sw/source/filter/ww8/ww8atr.cxx | 18 -- 5 files changed, 40 insertions(+), 10 deletions(-) New commits: commit e4ccf5f597d84f5745d73d306e83594f665024bb Author: Andreas BrandnerDate: Sun Nov 5 20:41:31 2017 +0100 tdf#66401 don't lose docx-combined-characters' font props on roundtrip Change-Id: Idbdb5bf3066e2ed86b494255d72d66eebf72f755 Reviewed-on: https://gerrit.libreoffice.org/44336 Tested-by: Jenkins Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index d844268dbff3..1ab6cde62852 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -1747,12 +1747,18 @@ void DocxAttributeOutput::DoWriteCmd( const OUString& rCmd ) void DocxAttributeOutput::CmdField_Impl( const SwTextNode* pNode, sal_Int32 nPos, FieldInfos const & rInfos, bool bWriteRun ) { +bool bWriteCombChars(false); + // Write the Field instruction { if ( bWriteRun ) { m_pSerializer->startElementNS( XML_w, XML_r, FSEND ); -DoWriteFieldRunProperties( pNode, nPos ); + +if (rInfos.eType == ww::eEQ) +bWriteCombChars = true; + +DoWriteFieldRunProperties( pNode, nPos, bWriteCombChars ); } sal_Int32 nNbToken = comphelper::string::getTokenCount(rInfos.sCmd, '\t'); @@ -1836,7 +1842,7 @@ void DocxAttributeOutput::CmdField_Impl( const SwTextNode* pNode, sal_Int32 nPos /// /// /// See, tdf#38778 -void DocxAttributeOutput::DoWriteFieldRunProperties( const SwTextNode * pNode, sal_Int32 nPos ) +void DocxAttributeOutput::DoWriteFieldRunProperties( const SwTextNode * pNode, sal_Int32 nPos, bool bWriteCombChars) { if (! pNode) { @@ -1866,7 +1872,17 @@ void DocxAttributeOutput::DoWriteFieldRunProperties( const SwTextNode * pNode, s // 3. output all other character properties SwWW8AttrIter aAttrIt( m_rExport, *pNode ); -aAttrIt.OutAttr( nPos, false ); +aAttrIt.OutAttr( nPos, false, bWriteCombChars ); + +// 4. explicitly write the font-properties, to ensure all runs in the field have them +// see tdf#66401 +if ( m_pFontsAttrList.is() ) +{ +XFastAttributeListRef xAttrList( m_pFontsAttrList.get() ); +m_pFontsAttrList.clear(); + +m_pSerializer->singleElementNS( XML_w, XML_rFonts, xAttrList ); +} m_pSerializer->endElementNS( XML_w, XML_rPr ); diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx b/sw/source/filter/ww8/docxattributeoutput.hxx index 7a09130e23e5..76bfc1a98af0 100644 --- a/sw/source/filter/ww8/docxattributeoutput.hxx +++ b/sw/source/filter/ww8/docxattributeoutput.hxx @@ -732,7 +732,7 @@ private: void DoWriteCmd( const OUString& rCmd ); void CmdField_Impl( const SwTextNode* pNode, sal_Int32 nPos, FieldInfos const & rInfos, bool bWriteRun ); void EndField_Impl( const SwTextNode* pNode, sal_Int32 nPos, FieldInfos& rInfos ); -void DoWriteFieldRunProperties( const SwTextNode* pNode, sal_Int32 nPos ); +void DoWriteFieldRunProperties( const SwTextNode* pNode, sal_Int32 nPos, bool bWriteCombChars = false ); virtual void GenerateBookmarksForSequenceField(const SwTextNode& rNode, SwWW8AttrIter& rAttrIter) override; static void AddToAttrList( rtl::Reference& pAttrList, sal_Int32 nAttrName, const sal_Char* sAttrValue ); diff --git a/sw/source/filter/ww8/wrtw8nds.cxx b/sw/source/filter/ww8/wrtw8nds.cxx index 23208e90a8fc..663036af6b70 100644 --- a/sw/source/filter/ww8/wrtw8nds.cxx +++ b/sw/source/filter/ww8/wrtw8nds.cxx @@ -379,7 +379,7 @@ static bool lcl_isFontsizeItem( const SfxPoolItem& rItem ) rItem.Which( ) == RES_CHRATR_CTL_FONTSIZE ); } -void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool bRuby ) +void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool bRuby , bool bWriteCombChars) { m_rExport.AttrOutput().RTLAndCJKState( mbCharIsRTL, GetScript() ); @@ -484,7 +484,7 @@ void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool bRuby ) // tdf#38778 Fix output of the font in DOC run for fields const SvxFontItem * pFontToOutput = ( rParentFont != *pFont )? pFont : nullptr; -m_rExport.ExportPoolItemsToCHP( aExportItems, GetScript(), pFontToOutput ); +m_rExport.ExportPoolItemsToCHP( aExportItems, GetScript(), pFontToOutput, bWriteCombChars ); // HasTextItem only allowed in the above range
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/winproc.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 65d69d95e88de25bcb59486231d92ace6be5feed Author: Caolán McNamaraDate: Wed Nov 8 17:38:43 2017 + Resolves: tdf#113562 desired window didn't get the input Change-Id: I4a2089a715dc67783bfd18d2ee0e55193c4ed741 Reviewed-on: https://gerrit.libreoffice.org/44500 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx index fdc584eb7513..81cf9f67765f 100644 --- a/vcl/source/window/winproc.cxx +++ b/vcl/source/window/winproc.cxx @@ -2063,10 +2063,11 @@ static void ImplHandleSalKeyMod( vcl::Window* pWindow, SalKeyModEvent const * pE // #105224# send commandevent to allow special treatment of Ctrl-LeftShift/Ctrl-RightShift etc. // + auto-accelerator feature, tdf#92630 -// find window +// try to find a key input window... vcl::Window* pChild = ImplGetKeyInputWindow( pWindow ); -if ( !pChild ) -return; +//...otherwise fail safe... +if (!pChild) +pChild = pWindow; CommandModKeyData data( pEvent->mnModKeyCode, pEvent->mbDown ); ImplCallCommand( pChild, CommandEventId::ModKeyChange, ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: canvas/source editeng/source emfio/source filter/source framework/source i18nutil/source include/unotools sc/qa sc/source sd/source sfx2/source svl/source svtools/sourc
canvas/source/factory/cf_service.cxx |2 +- editeng/source/editeng/impedit3.cxx|2 +- editeng/source/items/numitem.cxx |2 +- emfio/source/reader/mtftools.cxx |2 +- filter/source/config/cache/filtercache.cxx |2 +- filter/source/graphicfilter/idxf/dxfreprd.cxx |2 +- filter/source/graphicfilter/ieps/ieps.cxx |2 +- filter/source/msfilter/msdffimp.cxx|2 +- framework/source/jobs/jobexecutor.cxx |2 +- framework/source/services/desktop.cxx |2 +- i18nutil/source/utility/paper.cxx |2 +- include/unotools/configmgr.hxx | 10 +- sc/qa/unit/datacache.cxx |2 +- sc/qa/unit/range.cxx |2 +- sc/source/core/data/global2.cxx|2 +- sc/source/core/data/globalx.cxx|2 +- sc/source/core/tool/calcconfig.cxx |4 ++-- sc/source/core/tool/compiler.cxx |2 +- sc/source/core/tool/optutil.cxx|2 +- sc/source/filter/lotus/lotus.cxx |2 +- sc/source/ui/docshell/docsh2.cxx |4 ++-- sc/source/ui/docshell/externalrefmgr.cxx |2 +- sc/source/ui/docshell/tablink.cxx |2 +- sd/source/core/TransitionPreset.cxx|2 +- sd/source/core/drawdoc.cxx |8 sd/source/filter/ppt/pptin.cxx |4 ++-- sd/source/ui/app/sddll.cxx | 14 +++--- sd/source/ui/docshell/docshell.cxx |2 +- sfx2/source/appl/app.cxx |8 sfx2/source/appl/appbas.cxx|8 sfx2/source/appl/appinit.cxx |2 +- sfx2/source/control/shell.cxx |2 +- sfx2/source/doc/docfile.cxx|2 +- sfx2/source/doc/objstor.cxx|6 +++--- sfx2/source/doc/objxtor.cxx|4 ++-- svl/source/numbers/zforlist.cxx|2 +- svtools/source/config/accessibilityoptions.cxx |2 +- svtools/source/config/colorcfg.cxx |6 +++--- svtools/source/graphic/grfmgr.cxx |4 ++-- svx/source/gallery2/gallery1.cxx |2 +- svx/source/sdr/contact/objectcontactofpageview.cxx |4 ++-- svx/source/svdraw/svdetc.cxx |4 ++-- svx/source/svdraw/svdmodel.cxx |4 ++-- svx/source/xoutdev/xtabcolr.cxx|2 +- sw/source/core/bastyp/init.cxx |4 ++-- sw/source/core/doc/DocumentDrawModelManager.cxx|2 +- sw/source/core/doc/DocumentSettingManager.cxx |2 +- sw/source/core/doc/docdesc.cxx |2 +- sw/source/core/doc/docfmt.cxx |2 +- sw/source/core/doc/number.cxx |2 +- sw/source/core/doc/tblafmt.cxx |4 ++-- sw/source/core/draw/drawdoc.cxx|2 +- sw/source/core/edit/edws.cxx |2 +- sw/source/core/text/txtfrm.cxx |2 +- sw/source/core/view/viewsh.cxx |2 +- sw/source/filter/ww8/ww8par.cxx|4 ++-- sw/source/filter/ww8/ww8toolbar.cxx|2 +- sw/source/uibase/app/docsh2.cxx|2 +- sw/source/uibase/app/docshdrw.cxx |2 +- sw/source/uibase/app/docshini.cxx |4 ++-- sw/source/uibase/app/swdll.cxx |4 ++-- sw/source/uibase/app/swmodule.cxx |6 +++--- sw/source/uibase/config/fontcfg.cxx|6 +++--- sw/source/uibase/config/modcfg.cxx |2 +- sw/source/uibase/config/usrpref.cxx|2 +- sw/source/uibase/config/viewopt.cxx|4 ++-- sw/source/uibase/uiview/view.cxx |2 +- sw/source/uibase/uiview/view0.cxx |2 +- unotools/source/config/configitem.cxx |4 ++-- unotools/source/config/configmgr.cxx | 10 +- unotools/source/config/eventcfg.cxx|2 +- unotools/source/config/fontcfg.cxx |4 ++-- unotools/source/config/saveopt.cxx |2 +- unotools/source/config/securityoptions.cxx |2 +- unotools/source/config/syslocaleoptions.cxx|2 +- unotools/source/config/viewoptions.cxx |2 +- unotools/source/misc/mediadescriptor.cxx |2 +- vcl/source/app/settings.cxx| 14 +++--- vcl/source/app/svapp.cxx |
[Libreoffice-bugs] [Bug 110003] Lower-case ß is capitalized as SS instead of ẞ
https://bugs.documentfoundation.org/show_bug.cgi?id=110003 Adolfo Jaymechanged: What|Removed |Added Summary|RFE Choice of replacement |Lower-case ß is capitalized |of ß when capitalized |as SS instead of ẞ |between SS and ẞ| --- Comment #5 from Adolfo Jayme --- Thomas: as said above, we are not looking to add any options for users to switch between the two capitalizations; we want to embrace the new orthography and that’s it. A user who wants to use “SS” can just simply type it that way. And as Heiko says, we need an internal fallback to the old-style capitalization (as current Google Chrome has) just in case that the user is using a font lacking the character U+1E9E. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102204] Default set locale doesnt set page size according to locale settings ( see comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=102204 --- Comment #8 from Danny Schneider--- Think I can confirm this bug as I suffer from the same/similar Problem all Programms use A4, only LO always comes up with US Letter, setting "default" template to default for writer changed behaviour: new writer docs now are A4 also, calc, impress, draw still US Letter my system is archlinux with Xfce Desktop locale LANG=de_DE.utf8 LC_CTYPE="de_DE.utf8" LC_NUMERIC=en_DK.utf8 LC_TIME=en_DK.utf8 LC_COLLATE="de_DE.utf8" LC_MONETARY="de_DE.utf8" LC_MESSAGES="de_DE.utf8" LC_PAPER="de_DE.utf8" LC_NAME="de_DE.utf8" LC_ADDRESS="de_DE.utf8" LC_TELEPHONE="de_DE.utf8" LC_MEASUREMENT="de_DE.utf8" LC_IDENTIFICATION="de_DE.utf8" LC_ALL= localectl status System Locale: LANG=de_DE.utf8 LC_NUMERIC=en_DK.utf8 LC_TIME=en_DK.utf8 VC Keymap: de-latin1-nodeadkeys X11 Layout: n/a fyi: discussion on ask.libreoffice.org https://ask.libreoffice.org/en/question/137308/how-to-force-a-default-page-size/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113657] impress crashes when trying to format - char an empty paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=113657 Julien Nabetchanged: What|Removed |Added Priority|medium |high Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | Severity|normal |major --- Comment #5 from Julien Nabet --- Michael: as you may have seen, I put you in cc for reviewing https://gerrit.libreoffice.org/#/c/44513/ (let's increase the importance of the bugtracker since it's a crash + regression) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113428] Arabic PDF export is messy in old files < 5.3
https://bugs.documentfoundation.org/show_bug.cgi?id=113428 Khaled Hosnychanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |khaledho...@eglug.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113161] Quickstarter still appears in custom installer
https://bugs.documentfoundation.org/show_bug.cgi?id=113161 --- Comment #2 from Xisco Faulí--- For now, the option in memory is going to be moved to General: https://gerrit.libreoffice.org/#/c/44508/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/scannotationobj.cxx |1 + sc/qa/extras/scannotationshapeobj.cxx |3 ++- sc/qa/extras/scannotationsobj.cxx |1 + sc/qa/extras/scarealinkobj.cxx |1 + sc/qa/extras/sccellobj.cxx |1 + sc/qa/extras/scdatapilotfieldobj.cxx |1 + sc/qa/extras/scdatapilottableobj.cxx |1 + sc/qa/extras/sceditfieldobj-cell.cxx |1 + sc/qa/extras/sceditfieldobj-header.cxx |1 + sc/qa/extras/scmodelobj.cxx|1 + sc/qa/extras/scnamedrangeobj.cxx |1 + sc/qa/extras/scnamedrangesobj.cxx |1 + sc/qa/extras/scoutlineobj.cxx |1 + sc/qa/extras/scstyleloaderobj.cxx |1 + sc/qa/extras/sctabviewobj.cxx |1 + sc/qa/extras/scviewpaneobj.cxx |1 + 16 files changed, 17 insertions(+), 1 deletion(-) New commits: commit f5765d9f621bdc8fd0e1ac5eec1dcab9ae5b5d06 Author: Jens CarlDate: Sat Sep 2 07:46:53 2017 + Improve sc/ UNO API unit tests Improve sc/ UNO API unit tests by adding a CPPUNIT_ASSERT with NUMBER_OF_TESTS in setUp(). Makes it easier to spot a mismatch between actual and expected number of tests (you get a cppunit message instead of a crash without an explanation). Change-Id: I7621d8afde3bebbf94cfc3923ad2c12e249ed4c2 Reviewed-on: https://gerrit.libreoffice.org/41829 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/sc/qa/extras/scannotationobj.cxx b/sc/qa/extras/scannotationobj.cxx index 1120974d71b4..fd2bcfd4430d 100644 --- a/sc/qa/extras/scannotationobj.cxx +++ b/sc/qa/extras/scannotationobj.cxx @@ -107,6 +107,7 @@ uno::Reference< uno::XInterface > ScAnnontationObj::init() void ScAnnontationObj::setUp() { nTest++; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/scannotationshapeobj.cxx b/sc/qa/extras/scannotationshapeobj.cxx index 6b18077e86c0..805fe1f940a4 100644 --- a/sc/qa/extras/scannotationshapeobj.cxx +++ b/sc/qa/extras/scannotationshapeobj.cxx @@ -58,7 +58,8 @@ ScAnnotationShapeObj::ScAnnotationShapeObj() void ScAnnotationShapeObj::setUp() { -++nTest; +nTest++; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/scannotationsobj.cxx b/sc/qa/extras/scannotationsobj.cxx index 8c3a097999a0..f4cb9c853fd7 100644 --- a/sc/qa/extras/scannotationsobj.cxx +++ b/sc/qa/extras/scannotationsobj.cxx @@ -83,6 +83,7 @@ uno::Reference< uno::XInterface > ScAnnontationsObj::init() void ScAnnontationsObj::setUp() { nTest++; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/scarealinkobj.cxx b/sc/qa/extras/scarealinkobj.cxx index cad49d556e5d..c84d0964dbb9 100644 --- a/sc/qa/extras/scarealinkobj.cxx +++ b/sc/qa/extras/scarealinkobj.cxx @@ -91,6 +91,7 @@ uno::Reference< uno::XInterface > ScAreaLinkObj::init() void ScAreaLinkObj::setUp() { nTest++; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/sccellobj.cxx b/sc/qa/extras/sccellobj.cxx index c50fd3e2ebc4..6d0f90c1f732 100644 --- a/sc/qa/extras/sccellobj.cxx +++ b/sc/qa/extras/sccellobj.cxx @@ -74,6 +74,7 @@ uno::Reference< uno::XInterface > ScCellObj::init() void ScCellObj::setUp() { nTest++; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/scdatapilotfieldobj.cxx b/sc/qa/extras/scdatapilotfieldobj.cxx index 58849d88cf6d..903839dd55fa 100644 --- a/sc/qa/extras/scdatapilotfieldobj.cxx +++ b/sc/qa/extras/scdatapilotfieldobj.cxx @@ -88,6 +88,7 @@ uno::Reference< uno::XInterface > ScDataPilotFieldObj::init() void ScDataPilotFieldObj::setUp() { nTest++; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/scdatapilottableobj.cxx b/sc/qa/extras/scdatapilottableobj.cxx index 8ce6d6be9028..beaaeae7f4a1 100644 --- a/sc/qa/extras/scdatapilottableobj.cxx +++ b/sc/qa/extras/scdatapilottableobj.cxx @@ -142,6 +142,7 @@ uno::Reference< uno::XInterface > ScDataPilotTableObj::initDP2() void ScDataPilotTableObj::setUp() { nTest++; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/sceditfieldobj-cell.cxx b/sc/qa/extras/sceditfieldobj-cell.cxx index 6258b8a95173..0d469969cb7f 100644 --- a/sc/qa/extras/sceditfieldobj-cell.cxx +++ b/sc/qa/extras/sceditfieldobj-cell.cxx @@ -78,6 +78,7 @@ ScEditFieldObj_Cell::ScEditFieldObj_Cell() void ScEditFieldObj_Cell::setUp() { ++nTest; +CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); } diff --git a/sc/qa/extras/sceditfieldobj-header.cxx b/sc/qa/extras/sceditfieldobj-header.cxx index 4a5cb25fb1e1..a1ae16e86eb8 100644 --- a/sc/qa/extras/sceditfieldobj-header.cxx +++ b/sc/qa/extras/sceditfieldobj-header.cxx
[Libreoffice-bugs] [Bug 113722] [l10n, Russian] LibO Version 5.4.3.2 in Open dialog - item ' Version' has no Russian translation
https://bugs.documentfoundation.org/show_bug.cgi?id=113722 Serg Bormantchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||borm...@mail.ru, ||cl...@documentfoundation.or ||g Ever confirmed|0 |1 --- Comment #2 from Serg Bormant --- Semms to me that Vista File Picker implementation has no translation markers not only for "Version": https://opengrok.libreoffice.org/xref/core/fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx#552 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113428] Arabic PDF export is messy in old files < 5.3
https://bugs.documentfoundation.org/show_bug.cgi?id=113428 --- Comment #10 from Khaled Hosny--- (In reply to Xisco Faulí from comment #9) > Ok, I've bisected it again using the UI at export time and it points me to > this commit instead: > > authorKhaled Hosny 2016-12-07 22:43:09 > (GMT) > committer Khaled Hosny 2016-12-10 00:58:26 > (GMT) > commitb894104a0b02a9b074c76feb925389d7bee6a493 (patch) > tree 93e8a9362281f2c992f503a4e38ec17d04a9132b > parentb52167df08511239c3d08904a3d12a3c92141f38 (diff) > Pass GlyphItem around > We have this nice structure that contains (almost) all the information > we need, so pass it around instead of passing separate fragments of said > information. > > The ultimate is to kill the horrible sal_GlyphId hack if encoding > various bits of information in the higher bits of a 32-bit integer. > > @Khaled, Does it make more sense now? Yes, that makes a lot of since. I was expecting something around this area as it touched PDF export. Thank you! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113723] [l10n, Russian] LibO Version 5.4.3.2 while saving dbf file into different charset we see partially translated error message
https://bugs.documentfoundation.org/show_bug.cgi?id=113723 Serg Bormantchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||borm...@mail.ru, ||cl...@documentfoundation.or ||g Ever confirmed|0 |1 --- Comment #2 from Serg Bormant --- Source string: core/sc/inc/scerrors.hrc:66 { NC_("RID_ERRHDLSC", "Cell $(ARG1) contains characters that are not representable in the selected target character set \"$(ARG2)\".") , SCERR_EXPORT_ENCODING }, This string is missing in Pootle for UI Russian 5.4. This string and translation are present in Pootle for UI Russian 5.2, 5.3 and master: https://translations.documentfoundation.org/ru/libo52_ui/translate/sc/source/ui/src.po#unit=113178189 https://translations.documentfoundation.org/ru/libo53_ui/translate/sc/source/ui/src.po#unit=121876320 https://translations.documentfoundation.org/ru/libo_ui/translate/sc/messages.po#unit=138745379 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Changes to 'refs/tags/2.1.5-rc3'
Tag '2.1.5-rc3' created by Andras Timarat 2017-11-08 20:38 + 2.1.5-rc3 Changes since 2.1.5-rc2-8: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - debian/changelog loolwsd.spec.in
debian/changelog |6 ++ loolwsd.spec.in |2 +- 2 files changed, 7 insertions(+), 1 deletion(-) New commits: commit c9a8aede39092b664ccd296b7068bd8f06c8c639 Author: Andras TimarDate: Wed Nov 8 21:36:46 2017 +0100 Bump version for packages 2.1.5-4 Change-Id: I4c460e593698eda98c514cbe640a2fcaea7c1867 diff --git a/debian/changelog b/debian/changelog index d91ed574..a1920788 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +loolwsd (2.1.5-4) unstable; urgency=medium + + * see the git log: http://col.la/cool21 + + -- Andras Timar Wed, 08 Nov 2017 21:20:00 +0100 + loolwsd (2.1.5-3) unstable; urgency=medium * see the git log: http://col.la/cool21 diff --git a/loolwsd.spec.in b/loolwsd.spec.in index 3c8bc090..844c327c 100644 --- a/loolwsd.spec.in +++ b/loolwsd.spec.in @@ -12,7 +12,7 @@ Name: loolwsd%{name_suffix} Name: loolwsd %endif Version:@PACKAGE_VERSION@ -Release:3%{?dist} +Release:4%{?dist} %if 0%{?suse_version} == 1110 Group: Productivity/Office/Suite BuildRoot: %{_tmppath}/%{name}-%{version}-build ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/dist
loleaflet/dist/toolbar/toolbar.js | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) New commits: commit 72a7b95261fbfd3aeb7fcb87c3641bbd367187c7 Author: Jan HolesovskyDate: Wed Nov 8 19:36:15 2017 +0100 Save As: Don't save the document several times. Also don't perform the save as when the document name hasn't changed. Change-Id: I4fb7e0abd73996e90107b301a09b8703b66e80f9 Reviewed-on: https://gerrit.libreoffice.org/44504 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/loleaflet/dist/toolbar/toolbar.js b/loleaflet/dist/toolbar/toolbar.js index 1e1a89f5..663a4937 100644 --- a/loleaflet/dist/toolbar/toolbar.js +++ b/loleaflet/dist/toolbar/toolbar.js @@ -776,7 +776,7 @@ function onSearchKeyPress(e) { function documentNameConfirm() { var value = $('#document-name-input').val(); - if (value !== null && value != '') { + if (value !== null && value != '' && value != map['wopi'].BaseFileName) { map.saveAs(value); } map._onGotFocus(); @@ -795,6 +795,11 @@ function onDocumentNameKeyPress(e) { } } +function onDocumentNameFocus() { + // hide the caret in the main document + map._onLostFocus(); +} + function sortFontSizes() { var oldVal = $('.fontsizes-select').val(); var selectList = $('.fontsizes-select option'); @@ -992,9 +997,9 @@ map.on('wopiprops', function(e) { // Save As allowed $('#document-name-input').prop('disabled', false); $('#document-name-input').addClass('editable'); - $('#document-name-input').on('keypress', onDocumentNameKeyPress); - $('#document-name-input').on('focus', function() { map._onLostFocus(); /* hide the caret in the main document */ }); - $('#document-name-input').on('blur', documentNameCancel); + $('#document-name-input').off('keypress', onDocumentNameKeyPress).on('keypress', onDocumentNameKeyPress); + $('#document-name-input').off('focus', onDocumentNameFocus).on('focus', onDocumentNameFocus); + $('#document-name-input').off('blur', documentNameCancel).on('blur', documentNameCancel); } else { $('#document-name-input').prop('disabled', true); $('#document-name-input').removeClass('editable'); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113696] XHTML Export: Convert exotic image formats to png
https://bugs.documentfoundation.org/show_bug.cgi?id=113696 --- Comment #3 from Regina Henschel--- If you save those file, which have fake "svm", in ODF 1.2 extended, then the fake "svm" file is removed and only the png is there. That could help to sort out the fake "svm" from true svm, and make files with fake "svm" ready for XHTML. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands
https://bugs.documentfoundation.org/show_bug.cgi?id=86899 Bug 86899 depends on bug 101977, which changed state. Bug 101977 Summary: TRACK CHANGES: More uno commands for accepting/rejecting changes https://bugs.documentfoundation.org/show_bug.cgi?id=101977 What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Bug 83946 depends on bug 101977, which changed state. Bug 101977 Summary: TRACK CHANGES: More uno commands for accepting/rejecting changes https://bugs.documentfoundation.org/show_bug.cgi?id=101977 What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113131] Paragraph style: "Next-style"-rule is ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=113131 --- Comment #4 from Dieter Praas--- I put the cursor somewhere in the text and press enter - that's it. There are some documents, where I have no problems, and some, where the "next-style-rule" is ignored. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs