[Libreoffice-bugs] [Bug 98522] Format of navigationbar in tablecontrols differ while zooming form

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98522

--- Comment #6 from rob...@familiegrosskopf.de ---
Same buggy behavior here with LO 6.0.4.2, OpenSUSE 42.3, 64bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 34850] incorrect positioning when dragging newly-created frame (editing formatting ui)

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=34850

--- Comment #11 from Lawrence D'Oliveiro  
---
Bug reconfirmed, LibreOffice version 6.0.4.2 (“Build ID: 1:6.0.4-1” on Debian
Unstable AMD64.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117883] The features for the "Create:" heading below "Impress Presentation" can't be accessed.

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117883

--- Comment #3 from Adolfo Jayme  ---
This is not reproducible neither under Linux (with version 6.0.4.2 and the Gtk+
3 VCL backend) nor under Windows XP (with version 5.4.7.1): neither of these
versions allow me to resize down the Start Center window so that some of its
contents isn’t visible. Maybe this was due to a corrupt user profile. Anyhow,
this can be fixed by making the side pane of the Start Center window
scrollable.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117977] New: Unable to print to Dell 3100cn from within LibreOffice.

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117977

Bug ID: 117977
   Summary: Unable to print to Dell 3100cn from within
LibreOffice.
   Product: LibreOffice
   Version: 6.0.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: light...@excite.com

Description:
Unable to print on Dell 3100cn laser printer from within LibreOffice 6.0.4.2. 
Printer previously worked under LibreOffice 5.  Printer will print web pages,
so it is not a driver issue.  Running Windows 10 with latest update.  Installed
Apache OpenOffice as experiment.  Same files print perfectly in OpenOffice, but
not in LibreOffice 6.  Lexmark e312 prints under both office suites, so it
seems to be a problem with how libreoffice accesses the printer properties on
the Dell. 

Steps to Reproduce:
1.Type out letter in LibreOffice write.
2.Print
3.wait

Actual Results:  
nothing

Expected Results:
file to go to printer for printing


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Response not necessary, I just wanted LibreOffice to be aware of it on future
releases  One thing that I left out was that I seem unable to access the
printer properties while in LibreOffice.  The button just grays out when
pressed.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36 OPR/53.0.2907.68

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107002] EDITING: Selecting multiple slide transitions in a row will rendered all transitions sequentially

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107002

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 35954] styles not imported thoroughly: with paragraph style associated bullet list is not imported when List styles are not selected with Import (see comment #12)

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=35954

--- Comment #20 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 71169] EDITING: Impress custom animations 'Lighten' and 'Contrasting Color' don't work with pictures

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71169

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 35847] [UI] Wrong page style name in status bar after page preview

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=35847

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 34850] incorrect positioning when dragging newly-created frame (editing formatting ui)

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=34850

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105689] Emoji not available

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105689

--- Comment #29 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 47163] Profile folder cannot be created in nonANSI path

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47163

--- Comment #15 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 98522] Format of navigationbar in tablecontrols differ while zooming form

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98522

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2018-06-02 Thread Henry Castro
 sc/source/ui/docshell/docsh.cxx  |  542 +++
 sc/source/ui/docshell/docsh2.cxx |   42 +--
 sc/source/ui/docshell/docsh3.cxx |  152 +-
 sc/source/ui/docshell/docsh4.cxx |  342 
 sc/source/ui/docshell/docsh5.cxx |  228 
 sc/source/ui/docshell/docsh6.cxx |   66 ++--
 sc/source/ui/docshell/docsh8.cxx |   40 +-
 sc/source/ui/inc/docsh.hxx   |   70 ++---
 8 files changed, 741 insertions(+), 741 deletions(-)

New commits:
commit 5cbf6e936dfa402bc3b9c6cd2745f64fc71e0cc0
Author: Henry Castro 
Date:   Thu May 31 17:39:26 2018 -0400

sc: prefix members of ScDocShell

Change-Id: I7c2a4e5e850b26da515719f7df869f12c49b0ad3
Reviewed-on: https://gerrit.libreoffice.org/55148
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 362ddbd0a6e7..d32eb818910b 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -209,7 +209,7 @@ void ScDocShell::FillClass( SvGlobalName* pClassName,
 
 std::set ScDocShell::GetDocColors()
 {
-return aDocument.GetDocColors();
+return m_aDocument.GetDocColors();
 }
 
 void ScDocShell::DoEnterHandler()
@@ -239,16 +239,16 @@ HiddenInformation ScDocShell::GetHiddenInformationState( 
HiddenInformation nStat
 
 if ( nStates & HiddenInformation::RECORDEDCHANGES )
 {
-if ( aDocument.GetChangeTrack() && 
aDocument.GetChangeTrack()->GetFirst() )
+if ( m_aDocument.GetChangeTrack() && 
m_aDocument.GetChangeTrack()->GetFirst() )
   nState |= HiddenInformation::RECORDEDCHANGES;
 }
 if ( nStates & HiddenInformation::NOTES )
 {
-SCTAB nTableCount = aDocument.GetTableCount();
+SCTAB nTableCount = m_aDocument.GetTableCount();
 bool bFound = false;
 for (SCTAB nTab = 0; nTab < nTableCount && !bFound; ++nTab)
 {
-if (aDocument.HasTabNotes(nTab)) //TODO:
+if (m_aDocument.HasTabNotes(nTab)) //TODO:
 bFound = true;
 }
 
@@ -261,17 +261,17 @@ HiddenInformation ScDocShell::GetHiddenInformationState( 
HiddenInformation nStat
 
 void ScDocShell::BeforeXMLLoading()
 {
-aDocument.EnableIdle(false);
+m_aDocument.EnableIdle(false);
 
 // prevent unnecessary broadcasts and updates
-OSL_ENSURE(pModificator == nullptr, "The Modificator should not exist");
-pModificator = new ScDocShellModificator( *this );
+OSL_ENSURE(m_pModificator == nullptr, "The Modificator should not exist");
+m_pModificator = new ScDocShellModificator( *this );
 
-aDocument.SetImportingXML( true );
-aDocument.EnableExecuteLink( false );   // #i101304# to be safe, prevent 
nested loading from external references
-aDocument.EnableUndo( false );
+m_aDocument.SetImportingXML( true );
+m_aDocument.EnableExecuteLink( false );   // #i101304# to be safe, prevent 
nested loading from external references
+m_aDocument.EnableUndo( false );
 // prevent unnecessary broadcasts and "half way listeners"
-aDocument.SetInsertingFromOtherDoc( true );
+m_aDocument.SetInsertingFromOtherDoc( true );
 }
 
 void ScDocShell::AfterXMLLoading(bool bRet)
@@ -280,22 +280,22 @@ void ScDocShell::AfterXMLLoading(bool bRet)
 {
 UpdateLinks();
 // don't prevent establishing of listeners anymore
-aDocument.SetInsertingFromOtherDoc( false );
+m_aDocument.SetInsertingFromOtherDoc( false );
 if ( bRet )
 {
-ScChartListenerCollection* pChartListener = 
aDocument.GetChartListenerCollection();
+ScChartListenerCollection* pChartListener = 
m_aDocument.GetChartListenerCollection();
 if (pChartListener)
 pChartListener->UpdateDirtyCharts();
 
 // #95582#; set the table names of linked tables to the new path
-SCTAB nTabCount = aDocument.GetTableCount();
+SCTAB nTabCount = m_aDocument.GetTableCount();
 for (SCTAB i = 0; i < nTabCount; ++i)
 {
-if (aDocument.IsLinked( i ))
+if (m_aDocument.IsLinked( i ))
 {
 OUString aName;
-aDocument.GetName(i, aName);
-OUString aLinkTabName = aDocument.GetLinkTab(i);
+m_aDocument.GetName(i, aName);
+OUString aLinkTabName = m_aDocument.GetLinkTab(i);
 sal_Int32 nLinkTabNameLength = aLinkTabName.getLength();
 sal_Int32 nNameLength = aName.getLength();
 if (nLinkTabNameLength < nNameLength)
@@ -326,8 +326,8 @@ void ScDocShell::AfterXMLLoading(bool bRet)
 (aName[nIndex - 1] == '#') && // before 
the table name should be the # char
 !aINetURLObject.HasError()) // the docname 
should be a valid URL

[Libreoffice-bugs] [Bug 117976] There's a problem with the installer portion of LibreOffice_5.4.7_MacOS_x86-64.dmg.

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117976

--- Comment #1 from s2_b9...@hotmail.com ---
Created attachment 142490
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142490=edit
three installation screen shots, unsuccessful, successful

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-qa] How it went with one of the files used in last weeks bug hunting session

2018-06-02 Thread Drew Jensen
to be clear, on my typo there in the 3rd frm last line;

I could NOT be happier with how that went.

On Sat, Jun 2, 2018 at 9:43 PM Drew Jensen 
wrote:

> Howdy Tamás, list;
>
> Last weekend during the 6.1 bug hunting session I prattled on, over on the
> QA irc channel, about running the base migration assistant against an odb
> file holding ~318 thousand records in an embedded hsql database.
>
> Thought I'd post a recap here, with an added bit from today.
>
> Before running the migration assistant;
> Ran SHUTDOWN COMPACT against the original hsql odb which then had a 32.8
> Meg disc image.
>
> - pass one started
> At the 4 hr and 30 minute mark I stopped the soffice process because I had
> an idea.
>
> Did the following;
> Dropped all indexes on all tables, recalling this schema is a reporting
> dataset generated from a larger transaction set so lots of indexing on a
> smaller number of tables.
>
> With all indexes gone and cleaned up the disc image was down to 18.5 Megs.
>
> Started
> - pass two
> Can't say exactly how long it took, as it was late and after seeing this
> change; during the first run the soffice process was writing data to disc
> at a steady ~500K Bi/s,
> during the second, without the indexs, the throuput went to ~1.2M Bi/s;
> I went to bed.
>
> In the morning and the migration complete the disc image was now 24.8 Megs
>
> Picked that migrated file up again today adding back all, exact, indexing
> and then jettisoned the old hsql files from the ODB.
>
> Final disc image, 6.4 Megs.
>
> BTW, the schema was advantageous in that it holds predominantly numeric
> data, all character data in varchar or char fields, no blob data at all. It
> included two text table definitions, which it dealt with properly by
> ignoring them. And a view which, unfortunately, referenced one of those -
> but the error again didn't stop the data load.
>
> Could be happier with the results here.
>
> My take away, how did I forget to check the indexing? (i'm getting
> forgetful in my golden years..;)
>
> Best wishes,
>
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] How it went with one of the files used in last weeks bug hunting session

2018-06-02 Thread Drew Jensen
Howdy Tamás, list;

Last weekend during the 6.1 bug hunting session I prattled on, over on the
QA irc channel, about running the base migration assistant against an odb
file holding ~318 thousand records in an embedded hsql database.

Thought I'd post a recap here, with an added bit from today.

Before running the migration assistant;
Ran SHUTDOWN COMPACT against the original hsql odb which then had a 32.8
Meg disc image.

- pass one started
At the 4 hr and 30 minute mark I stopped the soffice process because I had
an idea.

Did the following;
Dropped all indexes on all tables, recalling this schema is a reporting
dataset generated from a larger transaction set so lots of indexing on a
smaller number of tables.

With all indexes gone and cleaned up the disc image was down to 18.5 Megs.

Started
- pass two
Can't say exactly how long it took, as it was late and after seeing this
change; during the first run the soffice process was writing data to disc
at a steady ~500K Bi/s,
during the second, without the indexs, the throuput went to ~1.2M Bi/s;
I went to bed.

In the morning and the migration complete the disc image was now 24.8 Megs

Picked that migrated file up again today adding back all, exact, indexing
and then jettisoned the old hsql files from the ODB.

Final disc image, 6.4 Megs.

BTW, the schema was advantageous in that it holds predominantly numeric
data, all character data in varchar or char fields, no blob data at all. It
included two text table definitions, which it dealt with properly by
ignoring them. And a view which, unfortunately, referenced one of those -
but the error again didn't stop the data load.

Could be happier with the results here.

My take away, how did I forget to check the indexing? (i'm getting
forgetful in my golden years..;)

Best wishes,
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 117976] New: There's a problem with the installer portion of LibreOffice_5.4.7_MacOS_x86-64.dmg.

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117976

Bug ID: 117976
   Summary: There's a problem with the installer portion of
LibreOffice_5.4.7_MacOS_x86-64.dmg.
   Product: LibreOffice
   Version: 5.4.7.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s2_b9...@hotmail.com

Description:
There's a problem with the installer portion of
LibreOffice_5.4.7_MacOS_x86-64.dmg.

On Saturday, June 2, 2018, I downloaded LibreOffice 5.4.7 for Mac OS X x86_64
from https://www.libreoffice.org/download/download/.

When I double-clicked LibreOffice_5.4.7_MacOS_x86-64.dmg in Finder, a pop-up
window displayed a gray and white LibreOffice icon labeled "LibreOffice.app," a
green right-pointing arrow icon, an aqua folder icon labeled "Applications," an
aqua folder icon labeled "LICENSEs," and an aqua folder icon labeled "READMEs."
Clicking on the "Applications" folder icon installed LibreOffice on my iMac.
However, when I double-clicked LibreOffice in my iMac's Applications folder,
LibreOffice wouldn't open. I got a pop-up that said "LibreOffice quit
unexpectedly."

I went to Finder > Applications, right-clicked LibreOffice.app, selected Get
Info, and under General, the Version: read "LibreOffice 6.0.1.1."

Then I went to Finder > Devices > the mounted "LibreOffice" drive,
right-clicked LibreOffice.app, selected Get Info, and under General, the
Version: read "LibreOffice 5.4.7.2."

My workaround was to copy LibreOffice.app, from the mounted drive, to the
Applications folder. Now I'm able to open LibreOffice 5.4.7.2.

I have an iMac18,2, with macOS High Sierra, Version 10.13.4.

Steps to Reproduce:
1. double-clicked LibreOffice_5.4.7_MacOS_x86-64.dmg in Finder
2. clicked "Applications" folder icon in installation pop-up
3. double-clicked LibreOffice in Applications folder

Actual Results:  
pop-up said "LibreOffice quit unexpectedly."

Expected Results:
expected LibreOffice 5.4.7.2 to open


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0)
Gecko/20100101 Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


CppCheck Report Update

2018-06-02 Thread cppcheck.libreoff...@gmail.com

A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2018-03-06 02:50:21 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 91318] SVG export should use fill pattern

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91318

--- Comment #9 from MM  ---
Confirmed on ubuntu 16.04 x64 with Version: 6.2.0.0.alpha0+
Build ID: 25fdc074528a39ff8aacf74c8db888ec9ef19a97
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-06-01_23:47:11
Locale: en-US (en_US.UTF-8); Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117975] LibreOffice 6.0.4.2 Writer won't send to printer

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117975

Peter Vintner  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Peter Vintner  ---
Ok, I have resolved this. It's a Windows 10 v1803 issue that, for me at least,
only affected LibreOffice.
Uninstall the printer(s) and reinstall using the manufacturer's own drivers. HP
in my case, and for for both printers it meant using Widows 7 drivers. 
The new clean installation update of Windows 10 (version 1803) installs
attached printers automatically, but not completely so it seems. They were
recognised in Device Manager and "Devices and Printers" and could be printed to
from other programs like FoxIt PDF Reader. And I could do test prints from the
settings dialog boxes. They were also recognised in LibreOffice but couldn't be
printed to.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117974] Closing the mail-merge-wizard after a failed source import crashes writer

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117974

--- Comment #4 from MM  ---
Could be a dup from bug 117824

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101295] Crop-Handle and Crop-Dialog are hard to distinguish in a toolbar

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101295

--- Comment #7 from Regina Henschel  ---
An icon for the crop dialog (which is .unoGrafAttrCrop) is still missing in all
icon-themes. Some uses .uno:crop explicitely via links.txt file and so show
identical icons handle and dialog. Tango and Sifr run into general fallback, so
their use of different icons for handle and dialog is accidentally.

The tooltip is OK now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117969] Light Magenta and Dark Magenta don't have Key ID in standard color palette .

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117969

Julien Nabet  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|serval2...@yahoo.fr |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #7 from Julien Nabet  ---
Abandoning patch https://gerrit.libreoffice.org/#/c/55204/ (for more details,
see my last comment on it)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107867] Crash when working with form

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107867

Julien Nabet  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #8 from Julien Nabet  ---
Eike: concerning bt, I "git-searched" sKeyword[eType] and found this old
commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=9b419039d9d967ab0d15d1142b27d24851baebeb
thought you might have some opinion here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107867] Crash when working with form

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107867

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #7 from Julien Nabet  ---
Created attachment 142489
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142489=edit
gdb bt

On pc Debian x86-64 with master sources updated today, I got an assert.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113042] FILESAVE: Saving an large calc sheet is slower in LibO5.4 compared to LibO5.3

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113042

--- Comment #16 from Buovjaga  ---
(In reply to Julien Nabet from comment #15)
> I can't uncompress xz file
> tar -xJf  callgrind-calc.tar.xz
> tar: Ignoring unknown extended header keyword 'SCHILY.fflags'
> 
> xz -d callgrind-calc.tar.xz gives callgrind-calc.tar
> but tar xvf callgrind-calc.tar
> gives
> tar: Ignoring unknown extended header keyword 'SCHILY.fflags'
> 
> Do you use bsdtar?

You can ignore the warning, check your folder: it has the file
callgrind.out.31264 after you uncompress it with tar -xJf

I use KDE's Ark, but I don't have BSD tar on my system. Only GNU tar. I don't
know why Ark makes it like so.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits -

2018-06-02 Thread Pedro Giffuni
 0 files changed

New commits:
commit 7ca6c18c0eb268322c66728dcbdbc9a2229a9e7d
Author: Pedro Giffuni 
Date:   Sat Jun 2 22:02:07 2018 +

Revert r1832747:

Drop references and the requirement for the StAX API.

The saxon build needs more care.

diff --git a/NOTICE b/NOTICE
index 1cdb073d5422..68d964b9fd9f 100644
--- a/NOTICE
+++ b/NOTICE
@@ -135,6 +135,7 @@ As part of the base system this product also includes code 
from the following
 projects which are licensed under the Apache license:
 - serf
 - redland
+- StAX
 
 The notices from these projects are following:
 
@@ -148,6 +149,10 @@ This product includes Redland software (http://librdf.org/)
 developed at the Institute for Learning and Research Technology,
 University of Bristol, UK (http://www.bristol.ac.uk/).
 
+
+StAX
+[no notices]
+
 
 
 This product includes software developed by the OpenSSL Project
diff --git a/external_deps.lst b/external_deps.lst
index 7753870b8ab3..4243d5be5c0e 100644
--- a/external_deps.lst
+++ b/external_deps.lst
@@ -187,6 +187,12 @@ if (SOLAR_JAVA == TRUE)
 URL1 = 
http://archive.apache.org/dist/tomcat/tomcat-5/v5.5.36/src/apache-tomcat-5.5.36-src.tar.gz
 URL2 = $(OOO_EXTRAS)$(MD5)-$(name)
 
+if (SOLAR_JAVA == TRUE)
+MD5 = 980143f96b3f6ce45d2e4947da21a5e9
+name = stax-src-1.2.0.zip
+URL1 = $(OOO_EXTRAS)$(MD5)-$(name)
+URL2 = http://maven.ibiblio.org/maven/stax/jars/stax-src-1.2.0.zip
+
 if (ENABLE_MEDIAWIKI == YES)
 MD5 = a7983f859eafb2677d7ff386a023bc40
 name = xsltml_2.1.2.zip
diff --git a/saxon/prj/build.lst b/saxon/prj/build.lst
index de579a047406..813097c66d90 100644
--- a/saxon/prj/build.lst
+++ b/saxon/prj/build.lst
@@ -1,2 +1,2 @@
-xx saxon   :   solenv NULL
+xx saxon   :   solenv stax NULL
 xx saxon   nmake   -   all xx_saxon NULL
diff --git a/saxon/saxon-9.0.0.7-bj.patch b/saxon/saxon-9.0.0.7-bj.patch
index c04d69c9d1c8..157ed004c2ef 100644
--- a/saxon/saxon-9.0.0.7-bj.patch
+++ b/saxon/saxon-9.0.0.7-bj.patch
@@ -1,6 +1,6 @@
 --- misc/src/build.xml 2008-07-11 12:11:50.079281000 +0200
 +++ misc/build/src/build.xml   2008-07-11 12:17:29.84874 +0200
-@@ -1 +1,1020 @@
+@@ -1 +1,1027 @@
 -dummy
 +
 +
@@ -170,6 +170,13 @@
 +
 +-->
 +
++
++
++
++
++
++
++
 +
 +
 +
diff --git a/set_soenv.in b/set_soenv.in
index 854cac9e3ccd..b4acb948299e 100644
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -2007,6 +2007,7 @@ ToFile( "RAT_JAR_HOME",  "@RAT_JAR_HOME@", "e" );
 ToFile( "DMAKE_URL", "@DMAKE_URL@","e" );
 ToFile( "DMAKE_PATH","@DMAKE_PATH@",   "e" );
 ToFile( "IS_SYSTEM_DMAKE",   "@IS_SYSTEM_DMAKE@",  "e" );
+ToFile( "BUILD_STAX","@BUILD_STAX@",   "e" );
 ToFile( "BUILD_UNOWINREG",   "@BUILD_UNOWINREG@",  "e" );
 ToFile( "USE_XINERAMA",  "@USE_XINERAMA@", "e" );
 ToFile( "XINERAMA_LINK", "@XINERAMA_LINK@","e" );
diff --git a/stax/download/README_stax-1.2.0.jar.txt 
b/stax/download/README_stax-1.2.0.jar.txt
new file mode 100644
index ..c2f4365afbac
--- /dev/null
+++ b/stax/download/README_stax-1.2.0.jar.txt
@@ -0,0 +1,13 @@
+The JSR173 is the XML pull API used at build time for the Saxon-B
+XSLT processor: it has become part of OpenJDK 6.
+
+When using an older JDK, you can get the API from
+http://dist.codehaus.org/stax/jars/
+located at the StAX Home site
+http://stax.codehaus.org/
+and put it under stax/download.
+
+1.2 Release(final) is available under the Apache License 2.0.
+
+Checksum (for reference):
+MD5 (stax-1.2.0.jar) = aa3439d235f7d999532b66bac56c1f87
diff --git a/stax/makefile.mk b/stax/makefile.mk
new file mode 100644
index ..145e787cedba
--- /dev/null
+++ b/stax/makefile.mk
@@ -0,0 +1,74 @@
+#**
+#  
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#  
+#http://www.apache.org/licenses/LICENSE-2.0
+#  
+#  Unless required by applicable law or agreed to in writing,
+#  software distributed under the License is distributed on an
+#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+#  KIND, either express or implied.  See the License for the
+#  specific language governing permissions and limitations
+#  under the License.
+#  
+#**
+
+
+
+PRJ=.
+
+PRJNAME=stax
+TARGET=stax
+USE_JAVAVER=TRUE
+
+# --- Settings -
+
+.INCLUDE : settings.mk
+.INCLUDE : antsettings.mk
+
+.IF "$(SOLAR_JAVA)" 

[Libreoffice-commits] core.git: sc/source

2018-06-02 Thread Luboš Luňák
 sc/source/core/data/global.cxx |   53 +
 1 file changed, 22 insertions(+), 31 deletions(-)

New commits:
commit bfed5c384d41253bec39fc3e44f839242602f1a1
Author: Luboš Luňák 
Date:   Fri May 25 13:03:28 2018 +0200

add mutex protection to more ScGlobal functions

Similarly to ScGlobal::Get(Case)Collator(), these also may be called
by multiple threads.

Change-Id: If0b1f2669282354ce79cdd251698f3aa1c6a30d4
Reviewed-on: https://gerrit.libreoffice.org/54798
Tested-by: Jenkins 
Reviewed-by: Luboš Luňák 

diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index bf76a7085758..2c3a98622d63 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -305,18 +305,12 @@ ScAutoFormat* ScGlobal::GetOrCreateAutoFormat()
 
 LegacyFuncCollection* ScGlobal::GetLegacyFuncCollection()
 {
-assert(!bThreadedGroupCalcInProgress);
-if (!pLegacyFuncCollection)
-pLegacyFuncCollection = new LegacyFuncCollection();
-return pLegacyFuncCollection;
+return doubleCheckedInit( pLegacyFuncCollection, []() { return new 
LegacyFuncCollection(); });
 }
 
 ScUnoAddInCollection* ScGlobal::GetAddInCollection()
 {
-assert(!bThreadedGroupCalcInProgress);
-if (!pAddInCollection)
-pAddInCollection = new ScUnoAddInCollection();
-return pAddInCollection;
+return doubleCheckedInit( pAddInCollection, []() { return new 
ScUnoAddInCollection(); });
 }
 
 ScUserList* ScGlobal::GetUserList()
@@ -1008,26 +1002,27 @@ void ScGlobal::AddLanguage( SfxItemSet& rSet, const 
SvNumberFormatter& rFormatte
 
 utl::TransliterationWrapper* ScGlobal::GetpTransliteration()
 {
-assert(!bThreadedGroupCalcInProgress);
-if ( !pTransliteration )
-{
-const LanguageType eOfficeLanguage = 
Application::GetSettings().GetLanguageTag().getLanguageType();
-pTransliteration = new ::utl::TransliterationWrapper(
-::comphelper::getProcessComponentContext(), 
TransliterationFlags::IGNORE_CASE );
-pTransliteration->loadModuleIfNeeded( eOfficeLanguage );
-}
-return pTransliteration;
+return doubleCheckedInit( pTransliteration,
+[]()
+{
+const LanguageType eOfficeLanguage = 
Application::GetSettings().GetLanguageTag().getLanguageType();
+::utl::TransliterationWrapper* p = new 
::utl::TransliterationWrapper(
+::comphelper::getProcessComponentContext(), 
TransliterationFlags::IGNORE_CASE );
+p->loadModuleIfNeeded( eOfficeLanguage );
+return p;
+});
 }
 ::utl::TransliterationWrapper* ScGlobal::GetCaseTransliteration()
 {
-assert(!bThreadedGroupCalcInProgress);
-if ( !pCaseTransliteration )
-{
-const LanguageType eOfficeLanguage = 
Application::GetSettings().GetLanguageTag().getLanguageType();
-pCaseTransliteration = new 
::utl::TransliterationWrapper(::comphelper::getProcessComponentContext(), 
TransliterationFlags::NONE );
-pCaseTransliteration->loadModuleIfNeeded( eOfficeLanguage );
-}
-return pCaseTransliteration;
+return doubleCheckedInit( pCaseTransliteration,
+[]()
+{
+const LanguageType eOfficeLanguage = 
Application::GetSettings().GetLanguageTag().getLanguageType();
+::utl::TransliterationWrapper* p = new 
::utl::TransliterationWrapper(
+::comphelper::getProcessComponentContext(), 
TransliterationFlags::NONE );
+p->loadModuleIfNeeded( eOfficeLanguage );
+return p;
+});
 }
 
 const LocaleDataWrapper* ScGlobal::GetpLocaleData()
@@ -1069,12 +1064,8 @@ CollatorWrapper*ScGlobal::GetCaseCollator()
 }
 css::lang::Locale* ScGlobal::GetLocale()
 {
-assert(!bThreadedGroupCalcInProgress);
-if ( !pLocale )
-{
-pLocale = new css::lang::Locale( 
Application::GetSettings().GetLanguageTag().getLocale());
-}
-return pLocale;
+return doubleCheckedInit( pLocale,
+[]() { return new css::lang::Locale( 
Application::GetSettings().GetLanguageTag().getLocale()); });
 }
 
 ScFieldEditEngine& ScGlobal::GetStaticFieldEditEngine()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 117973] LO crashed when starting up to open a file (ig75icd64.dll)

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117973

--- Comment #3 from Julien Nabet  ---
Just for curiosity, can you try to open the xls file again? Indeed, I wonder if
LO didn't disable OpenGL after the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117968] Google Drive Login Broken

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117968

Adolfo Jayme  changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117970] freezes when I right-click copy U+956 from Special Characters window

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117970

Julien Nabet  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Julien Nabet  ---
Thank you for your feedback, let's put this one to WFM.

About bugzilla-daemon@, I think it's expected, so to respond, you can only
comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/qa

2018-06-02 Thread Zdeněk Crhonek
 sc/qa/uitest/calc_tests/data/consolidate.ods |binary
 sc/qa/uitest/calc_tests2/consolidate.py  |   82 +++
 2 files changed, 82 insertions(+)

New commits:
commit 795945860f8ba9cbceb3b9b3b3d535076564c490
Author: Zdeněk Crhonek 
Date:   Sat Jun 2 20:37:50 2018 +0200

uitest - Calc consolidate

Change-Id: I2d38570f6dbd6046dacbbc9aa1eb9dac657c4f1c
Reviewed-on: https://gerrit.libreoffice.org/55213
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/uitest/calc_tests/data/consolidate.ods 
b/sc/qa/uitest/calc_tests/data/consolidate.ods
new file mode 100644
index ..8e17d7478f0f
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/consolidate.ods differ
diff --git a/sc/qa/uitest/calc_tests2/consolidate.py 
b/sc/qa/uitest/calc_tests2/consolidate.py
new file mode 100644
index ..e0bfc83fa312
--- /dev/null
+++ b/sc/qa/uitest/calc_tests2/consolidate.py
@@ -0,0 +1,82 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+#consolidatedialog.ui
+class consolidate(UITestCase):
+def test_consolidate(self):
+calc_doc = 
self.ui_test.load_file(get_url_for_data_file("consolidate.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+
+
self.ui_test.execute_modeless_dialog_through_command(".uno:DataConsolidate")
+xDialog = self.xUITest.getTopFocusWindow()
+xfunc = xDialog.getChild("func")
+xlbdataarea = xDialog.getChild("lbdataarea")
+xadd = xDialog.getChild("add")
+xbyrow = xDialog.getChild("byrow")
+xbycol = xDialog.getChild("bycol")
+xeddestarea = xDialog.getChild("eddestarea")
+
+props = {"TEXT": "Sum"}
+actionProps = mkPropertyValues(props)
+xfunc.executeAction("SELECT", actionProps)
+
+propsA = {"TEXT": "range1"}
+actionPropsA = mkPropertyValues(propsA)
+xlbdataarea.executeAction("SELECT", actionPropsA)
+xadd.executeAction("CLICK", tuple())
+propsB = {"TEXT": "range2"}
+actionPropsB = mkPropertyValues(propsB)
+xlbdataarea.executeAction("SELECT", actionPropsB)
+xadd.executeAction("CLICK", tuple())
+propsC = {"TEXT": "range3"}
+actionPropsC = mkPropertyValues(propsC)
+xlbdataarea.executeAction("SELECT", actionPropsC)
+xadd.executeAction("CLICK", tuple())
+xbyrow.executeAction("CLICK", tuple())
+xbycol.executeAction("CLICK", tuple())
+xeddestarea.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"CTRL+A"}))
+xeddestarea.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"BACKSPACE"}))
+xeddestarea.executeAction("TYPE", 
mkPropertyValues({"TEXT":"$Total.$A$2"}))
+xOKBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOKBtn)
+#verify
+self.assertEqual(get_cell_by_position(document, 0, 1, 2).getValue(), 
300)
+self.assertEqual(get_cell_by_position(document, 0, 1, 3).getValue(), 
303)
+self.assertEqual(get_cell_by_position(document, 0, 1, 4).getValue(), 
306)
+self.assertEqual(get_cell_by_position(document, 0, 1, 5).getValue(), 
309)
+
+self.assertEqual(get_cell_by_position(document, 0, 2, 2).getValue(), 
303)
+self.assertEqual(get_cell_by_position(document, 0, 2, 3).getValue(), 
306)
+self.assertEqual(get_cell_by_position(document, 0, 2, 4).getValue(), 
309)
+self.assertEqual(get_cell_by_position(document, 0, 2, 5).getValue(), 
312)
+
+self.assertEqual(get_cell_by_position(document, 0, 3, 2).getValue(), 
306)
+self.assertEqual(get_cell_by_position(document, 0, 3, 3).getValue(), 
309)
+self.assertEqual(get_cell_by_position(document, 0, 3, 4).getValue(), 
312)
+self.assertEqual(get_cell_by_position(document, 0, 3, 5).getValue(), 
315)
+
+self.assertEqual(get_cell_by_position(document, 0, 4, 2).getValue(), 
309)
+self.assertEqual(get_cell_by_position(document, 0, 4, 3).getValue(), 
312)
+self.assertEqual(get_cell_by_position(document, 0, 4, 4).getValue(), 
315)
+self.assertEqual(get_cell_by_position(document, 0, 4, 

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 65231, which changed state.

Bug 65231 Summary: EDITING: Enable to change the color for record changes 
without loosing the differentiation between authors
https://bugs.documentfoundation.org/show_bug.cgi?id=65231

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65231] EDITING: Enable to change the color for record changes without loosing the differentiation between authors

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65231

Thomas Lendo  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #13 from Thomas Lendo  ---
Closing the bug as RESOLVED WORKSFORME according to comment 12.

If someone knows the patch that fixed this issue, please comment and change the
status to RESOLVED FIXED.

If this bug isn't fixed completely, please reopen with status NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102187
Bug 102187 depends on bug 65231, which changed state.

Bug 65231 Summary: EDITING: Enable to change the color for record changes 
without loosing the differentiation between authors
https://bugs.documentfoundation.org/show_bug.cgi?id=65231

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 58028] VIEWING: Too big height and increased text size of integrated text box with rounded corners and gradient color fill"

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=58028

--- Comment #5 from Thomas Lendo  ---
Only I can repro is a change of the big text in the center textbox "This ist
the text box title". When double clicking on it then the text size shrinks to
the size of the other titles.

Version: 6.2.0.0.alpha0+
Build ID: 7725eff80a7bc3f3e422e56e1cd7bfa531f19a70
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: de-DE (de_DE.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115749] Deleting a (very) large number of sheets is slower than it used to be

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115749

Telesto  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Telesto  ---
(In reply to Buovjaga from comment #3)
> Results from Win 10:
> 6.2: 3min 19s
> 6.0.4: 3min 27s
> 5.4.2: 3min 20s
> 5.0.2: 2min 59s (could not jump to first sheet, control was missing)
> 4.4.7: 2min 48s
> 
> I don't know, who would want to spend ages bibisecting this especially with
> such gradually progressing results. 

Sounds more like a WFM: Report was about Version: 6.1.0.0.alpha0+ being slow (8
minutes). It's back to 'normal' with 3 min 30 seconds.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108018] [META] Writer UX bugs and enhancements

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108018

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||57190


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=57190
[Bug 57190] TABLE Strange numbering behavior on inserting rows
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 57190] TABLE Strange numbering behavior on inserting rows

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=57190

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||108018


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108018
[Bug 108018] [META] Writer UX bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 57190] TABLE Strange numbering behavior on inserting rows

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=57190

--- Comment #8 from Thomas Lendo  ---
Repro with Version: 6.2.0.0.alpha0+
Build ID: 7725eff80a7bc3f3e422e56e1cd7bfa531f19a70
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: de-DE (de_DE.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: drawinglayer/source

2018-06-02 Thread Caolán McNamara
 drawinglayer/source/texture/texture3d.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3e600bf0e99bcf9080937e8fba82ae2473d26664
Author: Caolán McNamara 
Date:   Sat Jun 2 19:56:27 2018 +0100

coverity#1435911 Arguments in wrong order

since...

commit 63e65d1743264dfa26d2aba615d71978e65784e8
Date:   Wed May 30 11:11:21 2018 +0200

dont use GetMask in GeoTexSvxBitmapEx

Change-Id: If5ea0f420ed588ccec21f9662473e1cae1b32f12
Reviewed-on: https://gerrit.libreoffice.org/55219
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/drawinglayer/source/texture/texture3d.cxx 
b/drawinglayer/source/texture/texture3d.cxx
index 0573c3e4b3f5..647b671c5ea7 100644
--- a/drawinglayer/source/texture/texture3d.cxx
+++ b/drawinglayer/source/texture/texture3d.cxx
@@ -165,7 +165,7 @@ namespace drawinglayer
 else
 {
 // this texture is a color bitmap used as transparence map
-const ::Color aColor(maBitmapEx.GetPixelColor(nY, nX));
+const ::Color aColor(maBitmapEx.GetPixelColor(nX, nY));
 
 rfOpacity = (static_cast(0xff - 
aColor.GetLuminance()) * (1.0 / 255.0));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sd/source

2018-06-02 Thread Caolán McNamara
 sd/source/ui/view/sdview.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ea1279d7f7b3176f37515951782a51327f233591
Author: Caolán McNamara 
Date:   Sat Jun 2 19:53:48 2018 +0100

coverity#1435913 Dereference after null check

Change-Id: Ieaf17be375c9381070d7141f6366b0bec7a3
Reviewed-on: https://gerrit.libreoffice.org/55218
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/view/sdview.cxx b/sd/source/ui/view/sdview.cxx
index becfb5749613..835f9fcf9afb 100644
--- a/sd/source/ui/view/sdview.cxx
+++ b/sd/source/ui/view/sdview.cxx
@@ -699,7 +699,7 @@ bool View::SdrBeginTextEdit(
 {
 
mpViewSh->GetViewShellBase().GetDrawController().FireSelectionChangeListener();
 
-if (pObj->GetObjIdentifier() == OBJ_TABLE)
+if (pObj && pObj->GetObjIdentifier() == OBJ_TABLE)
 mpViewSh->UpdateScrollBars();
 
 if (comphelper::LibreOfficeKit::isActive())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/unx

2018-06-02 Thread Caolán McNamara
 vcl/unx/generic/window/salobj.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit b01cfcb4aadc4dc440427a3b914854148d019fe0
Author: Caolán McNamara 
Date:   Sat Jun 2 19:45:19 2018 +0100

coverity#708674 Uninitialized scalar field

Change-Id: Icbd707fc5bcdad58592ab80c095ad0b1d655786c
Reviewed-on: https://gerrit.libreoffice.org/55214
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/generic/window/salobj.cxx 
b/vcl/unx/generic/window/salobj.cxx
index 76fe2311514c..6cc70916a691 100644
--- a/vcl/unx/generic/window/salobj.cxx
+++ b/vcl/unx/generic/window/salobj.cxx
@@ -213,6 +213,7 @@ SalClipRegion::UnionClipRegion( long nX, long nY, long 
nWidth, long nHeight )
 // SalObject Implementation
 X11SalObject::X11SalObject()
 : mpParent(nullptr)
+, maParentWin(0)
 , maPrimary(0)
 , maSecondary(0)
 , maColormap(0)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2018-06-02 Thread Caolán McNamara
 sw/source/ui/dialog/uiregionsw.cxx |8 
 sw/source/ui/misc/docfnote.cxx |2 +-
 sw/source/ui/misc/impfnote.hxx |2 +-
 sw/source/ui/misc/linenum.cxx  |2 +-
 sw/source/ui/misc/outline.cxx  |2 +-
 sw/source/uibase/inc/linenum.hxx   |2 +-
 sw/source/uibase/inc/numberingtypelistbox.hxx  |6 +++---
 sw/source/uibase/inc/outline.hxx   |2 +-
 sw/source/uibase/inc/regionsw.hxx  |4 ++--
 sw/source/uibase/misc/numberingtypelistbox.cxx |   10 +-
 10 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit 38bdca63743be278377271d83110b07dec2345db
Author: Caolán McNamara 
Date:   Sat Jun 2 19:40:31 2018 +0100

SwNumberingTypeListBox fully replaced now

Change-Id: I7610cf8f602c6939dc994dd4c418d9e07aaf6b20
Reviewed-on: https://gerrit.libreoffice.org/55217
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/ui/dialog/uiregionsw.cxx 
b/sw/source/ui/dialog/uiregionsw.cxx
index 50f052154de7..9c247434f2c7 100644
--- a/sw/source/ui/dialog/uiregionsw.cxx
+++ b/sw/source/ui/dialog/uiregionsw.cxx
@@ -1836,7 +1836,7 @@ 
SwSectionFootnoteEndTabPage::SwSectionFootnoteEndTabPage(TabPageParent pParent,
 , m_xFootnoteNtNumFormatCB(m_xBuilder->weld_check_button("ftnntnumfmt"))
 , m_xFootnotePrefixFT(m_xBuilder->weld_label("ftnprefix_label"))
 , m_xFootnotePrefixED(m_xBuilder->weld_entry("ftnprefix"))
-, m_xFootnoteNumViewBox(new 
NumberingTypeListBox(m_xBuilder->weld_combo_box_text("ftnnumviewbox")))
+, m_xFootnoteNumViewBox(new 
SwNumberingTypeListBox(m_xBuilder->weld_combo_box_text("ftnnumviewbox")))
 , m_xFootnoteSuffixFT(m_xBuilder->weld_label("ftnsuffix_label"))
 , m_xFootnoteSuffixED(m_xBuilder->weld_entry("ftnsuffix"))
 , m_xEndNtAtTextEndCB(m_xBuilder->weld_check_button("endntattextend"))
@@ -1846,7 +1846,7 @@ 
SwSectionFootnoteEndTabPage::SwSectionFootnoteEndTabPage(TabPageParent pParent,
 , m_xEndNtNumFormatCB(m_xBuilder->weld_check_button("endntnumfmt"))
 , m_xEndPrefixFT(m_xBuilder->weld_label("endprefix_label"))
 , m_xEndPrefixED(m_xBuilder->weld_entry("endprefix"))
-, m_xEndNumViewBox(new 
NumberingTypeListBox(m_xBuilder->weld_combo_box_text("endnumviewbox")))
+, m_xEndNumViewBox(new 
SwNumberingTypeListBox(m_xBuilder->weld_combo_box_text("endnumviewbox")))
 , m_xEndSuffixFT(m_xBuilder->weld_label("endsuffix_label"))
 , m_xEndSuffixED(m_xBuilder->weld_entry("endsuffix"))
 {
@@ -1924,7 +1924,7 @@ void SwSectionFootnoteEndTabPage::ResetState( bool 
bFootnote,
 weld::CheckButton *pNtAtTextEndCB, *pNtNumCB, *pNtNumFormatCB;
 weld::Label *pPrefixFT, *pSuffixFT;
 weld::Entry *pPrefixED, *pSuffixED;
-NumberingTypeListBox *pNumViewBox;
+SwNumberingTypeListBox *pNumViewBox;
 weld::Label *pOffsetText;
 weld::SpinButton *pOffsetField;
 
@@ -2016,7 +2016,7 @@ IMPL_LINK( SwSectionFootnoteEndTabPage, FootEndHdl, 
weld::ToggleButton&, rBox, v
 m_xFootnoteNtNumFormatCB.get() ==  ;
 
 weld::CheckButton *pNumBox, *pNumFormatBox, *pEndBox;
-NumberingTypeListBox* pNumViewBox;
+SwNumberingTypeListBox* pNumViewBox;
 weld::Label *pOffsetText;
 weld::SpinButton *pOffsetField;
 weld::Label *pPrefixFT, *pSuffixFT;
diff --git a/sw/source/ui/misc/docfnote.cxx b/sw/source/ui/misc/docfnote.cxx
index 4de40de6f68a..73ebbb95f970 100644
--- a/sw/source/ui/misc/docfnote.cxx
+++ b/sw/source/ui/misc/docfnote.cxx
@@ -72,7 +72,7 @@ SwEndNoteOptionPage::SwEndNoteOptionPage(TabPageParent 
pParent, bool bEN,
 , pSh(nullptr)
 , bPosDoc(false)
 , bEndNote(bEN)
-, m_xNumViewBox(new 
NumberingTypeListBox(m_xBuilder->weld_combo_box_text("numberinglb")))
+, m_xNumViewBox(new 
SwNumberingTypeListBox(m_xBuilder->weld_combo_box_text("numberinglb")))
 , m_xOffsetLbl(m_xBuilder->weld_label("offset"))
 , m_xOffsetField(m_xBuilder->weld_spin_button("offsetnf"))
 , m_xNumCountBox(m_xBuilder->weld_combo_box_text("countinglb"))
diff --git a/sw/source/ui/misc/impfnote.hxx b/sw/source/ui/misc/impfnote.hxx
index 7bc3e9a20d8f..8c192a620ca7 100644
--- a/sw/source/ui/misc/impfnote.hxx
+++ b/sw/source/ui/misc/impfnote.hxx
@@ -35,7 +35,7 @@ class SwEndNoteOptionPage : public SfxTabPage
 boolbPosDoc;
 boolbEndNote;
 
-std::unique_ptr m_xNumViewBox;
+std::unique_ptr m_xNumViewBox;
 std::unique_ptr m_xOffsetLbl;
 std::unique_ptr m_xOffsetField;
 std::unique_ptr m_xNumCountBox;
diff --git a/sw/source/ui/misc/linenum.cxx b/sw/source/ui/misc/linenum.cxx
index 046b1a21e20f..281dd9dd0d77 100644
--- a/sw/source/ui/misc/linenum.cxx
+++ b/sw/source/ui/misc/linenum.cxx
@@ -72,7 +72,7 @@ SwLineNumberingDlg::SwLineNumberingDlg(const SwView& rVw)
 , m_xDivRowsFT(m_xBuilder->weld_widget("lines"))
 , m_xNumIntervalNF(m_xBuilder->weld_spin_button("intervalspin"))
 , 

[Libreoffice-commits] core.git: 2 commits - cui/source extras/source sw/source sw/uiconfig vcl/source

2018-06-02 Thread Caolán McNamara
 cui/source/tabpages/textattr.cxx   |   89 --
 extras/source/glade/libreoffice-catalog.xml.in |3 
 sw/source/ui/dialog/uiregionsw.cxx |  293 +
 sw/source/uibase/inc/numberingtypelistbox.hxx  |   18 -
 sw/source/uibase/inc/regionsw.hxx  |   52 +--
 sw/source/uibase/misc/numberingtypelistbox.cxx |  145 --
 sw/uiconfig/swriter/ui/footnotesendnotestabpage.ui |   88 +-
 vcl/source/font/fontcache.cxx  |2 
 8 files changed, 187 insertions(+), 503 deletions(-)

New commits:
commit cd08397eedbe347784a3ac569481a17a8391e7b2
Author: Caolán McNamara 
Date:   Sat Jun 2 19:37:35 2018 +0100

weld SwSectionFootnoteEndTabPage

Change-Id: Ib4246a2f90780a005e79e2d071b43a5629a3242c
Reviewed-on: https://gerrit.libreoffice.org/55216
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/textattr.cxx b/cui/source/tabpages/textattr.cxx
index 9cb423211176..1e1eddde34de 100644
--- a/cui/source/tabpages/textattr.cxx
+++ b/cui/source/tabpages/textattr.cxx
@@ -322,24 +322,28 @@ bool SvxTextAttrPage::FillItemSet( SfxItemSet* rAttrs)
 
 if( m_xMtrFldLeft->get_value_changed_from_saved() )
 {
+fprintf(stderr, "a one\n");
 nValue = GetCoreValue( *m_xMtrFldLeft, eUnit );
 rAttrs->Put( makeSdrTextLeftDistItem( nValue ) );
 }
 
 if( m_xMtrFldRight->get_value_changed_from_saved() )
 {
+fprintf(stderr, "b one\n");
 nValue = GetCoreValue( *m_xMtrFldRight, eUnit );
 rAttrs->Put( makeSdrTextRightDistItem( nValue ) );
 }
 
 if( m_xMtrFldTop->get_value_changed_from_saved() )
 {
+fprintf(stderr, "c one\n");
 nValue = GetCoreValue( *m_xMtrFldTop, eUnit );
 rAttrs->Put( makeSdrTextUpperDistItem( nValue ) );
 }
 
 if( m_xMtrFldBottom->get_value_changed_from_saved() )
 {
+fprintf(stderr, "d one\n");
 nValue = GetCoreValue( *m_xMtrFldBottom, eUnit );
 rAttrs->Put( makeSdrTextLowerDistItem( nValue ) );
 }
@@ -347,108 +351,31 @@ bool SvxTextAttrPage::FillItemSet( SfxItemSet* rAttrs)
 eState = m_xTsbAutoGrowHeight->get_state();
 if( m_xTsbAutoGrowHeight->get_state_changed_from_saved() )
 {
+fprintf(stderr, "one %d\n", TRISTATE_TRUE == eState);
 rAttrs->Put( makeSdrTextAutoGrowHeightItem( TRISTATE_TRUE == eState ) 
);
 }
 
 eState = m_xTsbAutoGrowWidth->get_state();
 if( m_xTsbAutoGrowWidth->get_state_changed_from_saved() )
 {
+fprintf(stderr, "e one\n");
 rAttrs->Put( makeSdrTextAutoGrowWidthItem( TRISTATE_TRUE == eState ) );
 }
 
 eState = m_xTsbAutoGrowSize->get_state();
 if( m_xTsbAutoGrowSize->get_state_changed_from_saved() )
 {
+fprintf(stderr, "two %d\n", TRISTATE_TRUE == eState);
 rAttrs->Put( makeSdrTextAutoGrowHeightItem( TRISTATE_TRUE == eState ) 
);
 }
 
 eState = m_xTsbWordWrapText->get_state();
 if( m_xTsbWordWrapText->get_state_changed_from_saved() )
 {
+fprintf(stderr, "f one\n");
 rAttrs->Put( makeSdrTextWordWrapItem( TRISTATE_TRUE == eState ) );
 }
 
-eState = m_xTsbContour->get_state();
-if( m_xTsbContour->get_state_changed_from_saved() )
-{
-rAttrs->Put( makeSdrTextContourFrameItem( TRISTATE_TRUE == eState ) );
-}
-
-eState = m_xTsbFitToSize->get_state();
-if( m_xTsbFitToSize->get_state_changed_from_saved() )
-{
-drawing::TextFitToSizeType eFTS;
-switch( eState )
-{
-default: ; //prevent warning
-OSL_FAIL( "svx::SvxTextAttrPage::FillItemSet(), unhandled 
state!" );
-SAL_FALLTHROUGH;
-case TRISTATE_FALSE: eFTS = drawing::TextFitToSizeType_AUTOFIT; 
break;
-case TRISTATE_TRUE: eFTS = 
drawing::TextFitToSizeType_PROPORTIONAL; break;
-}
-rAttrs->Put( SdrTextFitToSizeTypeItem( eFTS ) );
-}
-
-// centered
-RectPoint eRP = m_aCtlPosition.GetActualRP();
-SdrTextVertAdjust eTVA, eOldTVA;
-SdrTextHorzAdjust eTHA, eOldTHA;
-
-switch( eRP )
-{
-default:
-case RectPoint::LT: eTVA = SDRTEXTVERTADJUST_TOP;
-eTHA = SDRTEXTHORZADJUST_LEFT; break;
-case RectPoint::LM: eTVA = SDRTEXTVERTADJUST_CENTER;
-eTHA = SDRTEXTHORZADJUST_LEFT; break;
-case RectPoint::LB: eTVA = SDRTEXTVERTADJUST_BOTTOM;
-eTHA = SDRTEXTHORZADJUST_LEFT; break;
-case RectPoint::MT: eTVA = SDRTEXTVERTADJUST_TOP;
-eTHA = SDRTEXTHORZADJUST_CENTER; break;
-case RectPoint::MM: eTVA = SDRTEXTVERTADJUST_CENTER;
-eTHA = SDRTEXTHORZADJUST_CENTER; break;
-case RectPoint::MB: eTVA = SDRTEXTVERTADJUST_BOTTOM;
-eTHA = SDRTEXTHORZADJUST_CENTER; break;
-case RectPoint::RT: eTVA = 

Crash test update

2018-06-02 Thread Crashtest VM
New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/c0c9c9d5f21d65f582de163566c46242d21dc506/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 117970] freezes when I right-click copy U+956 from Special Characters window

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117970

--- Comment #3 from kirkmil...@gmail.com ---
After updating to LO 6042 the problem resolved. 

BTW, you might want to note in your email updates that bugzilla-daemon@ does
not accept responses.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117973] LO crashed when starting up to open a file (ig75icd64.dll)

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117973

--- Comment #2 from Martin Terry  ---
1. According to my Device Manager I have Intel HD Graphics HD440 and drivers
are up to date.

  OpenGL is ver 4.3

2. I am reluctant to instant LO version 6 as I am a conservative user.

3. My LO Help\About shows LO is set to 'UI render - default'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117916] Installation of 6.0.4.2 warning so cannot install!

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117916

john4070  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from john4070  ---
Sorry, I'm 90 and having trouble following this process.
You tell me you need information and I don't know what it is.
How do I install with admin rights?  I thought I always did!
I can not install 6 nor even reinstall 5.4.3.2!  I have NO LibreOffice now.
I get the feeling that Windows Defender is keeping a file from loading thereby
screwing up the install.  It comes up with a warning but too fast for me to use
the Snipping Tool on it.
Sorry to be so dense!
I'll appreciate your help!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113042] FILESAVE: Saving an large calc sheet is slower in LibO5.4 compared to LibO5.3

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113042

--- Comment #15 from Julien Nabet  ---
I can't uncompress xz file
tar -xJf  callgrind-calc.tar.xz
tar: Ignoring unknown extended header keyword 'SCHILY.fflags'

xz -d callgrind-calc.tar.xz gives callgrind-calc.tar
but tar xvf callgrind-calc.tar
gives
tar: Ignoring unknown extended header keyword 'SCHILY.fflags'

Do you use bsdtar?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: configure.ac

2018-06-02 Thread Luboš Luňák
 configure.ac |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 7e83b2d3b52fda5c1535e85f76c096c3ee627b1e
Author: Luboš Luňák 
Date:   Sat Jun 2 20:50:36 2018 +0200

avoid configure warning about  not usable by preprocessor

Change-Id: I710579f343eab38f576311bd15d931e5521105b2

diff --git a/configure.ac b/configure.ac
index 09cadec75714..b52bba7332c2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9689,8 +9689,8 @@ else
 else
 SYSTEM_LIBNUMBERTEXT=
 AC_LANG_PUSH([C++])
-save_CXXFLAGS=$CXXFLAGS
-CXXFLAGS="$CXXFLAGS $CXXFLAGS_CXX11"
+save_CPPFLAGS=$CPPFLAGS
+CPPFLAGS="$CPPFLAGS $CXXFLAGS_CXX11"
 AC_CHECK_HEADERS([codecvt regex])
 AS_IF([test "x$ac_cv_header_codecvt" != xyes -o "x$ac_cv_header_regex" 
!= xyes],
 [ ENABLE_LIBNUMBERTEXT=''
@@ -9698,7 +9698,7 @@ else
   AC_MSG_WARN([No system-provided libnumbertext or 
codecvt/regex C++11 headers (min. libstdc++ 4.9).
Enable libnumbertext fallback (missing number 
to number name conversion).])
 ])
-CXXFLAGS=$save_CXXFLAGS
+CPPFLAGS=$save_CPPFLAGS
 AC_LANG_POP([C++])
 fi
 if test "$ENABLE_LIBNUMBERTEXT" = TRUE; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: linguistic/source

2018-06-02 Thread Caolán McNamara
 linguistic/source/gciterator.cxx |   16 
 linguistic/source/gciterator.hxx |   10 +-
 2 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit be13ca094dac91545a879905a34adb5fdb23afe9
Author: Caolán McNamara 
Date:   Sat Jun 2 17:10:42 2018 +0100

mergedlibs failure with duplicate SwXStringKeyMap

just rename this one for a quick fix

Change-Id: Iae9152356640c3454a73b56f7e097d084d8eb3a0
Reviewed-on: https://gerrit.libreoffice.org/55210
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/linguistic/source/gciterator.cxx b/linguistic/source/gciterator.cxx
index a1bba7cbf739..d124ab1865aa 100644
--- a/linguistic/source/gciterator.cxx
+++ b/linguistic/source/gciterator.cxx
@@ -233,9 +233,9 @@ static lang::Locale lcl_GetPrimaryLanguageOfSentence(
 }
 
 
-SwXStringKeyMap::SwXStringKeyMap() {}
+LngXStringKeyMap::LngXStringKeyMap() {}
 
-void SAL_CALL SwXStringKeyMap::insertValue(const OUString& aKey, const 
css::uno::Any& aValue)
+void SAL_CALL LngXStringKeyMap::insertValue(const OUString& aKey, const 
css::uno::Any& aValue)
 {
 std::map::const_iterator aIter = maMap.find(aKey);
 if (aIter != maMap.end())
@@ -244,7 +244,7 @@ void SAL_CALL SwXStringKeyMap::insertValue(const OUString& 
aKey, const css::uno:
 maMap[aKey] = aValue;
 }
 
-css::uno::Any SAL_CALL SwXStringKeyMap::getValue(const OUString& aKey)
+css::uno::Any SAL_CALL LngXStringKeyMap::getValue(const OUString& aKey)
 {
 std::map::const_iterator aIter = maMap.find(aKey);
 if (aIter == maMap.end())
@@ -253,14 +253,14 @@ css::uno::Any SAL_CALL SwXStringKeyMap::getValue(const 
OUString& aKey)
 return (*aIter).second;
 }
 
-sal_Bool SAL_CALL SwXStringKeyMap::hasValue(const OUString& aKey)
+sal_Bool SAL_CALL LngXStringKeyMap::hasValue(const OUString& aKey)
 {
 return maMap.find(aKey) != maMap.end();
 }
 
-::sal_Int32 SAL_CALL SwXStringKeyMap::getCount() { return maMap.size(); }
+::sal_Int32 SAL_CALL LngXStringKeyMap::getCount() { return maMap.size(); }
 
-OUString SAL_CALL SwXStringKeyMap::getKeyByIndex(::sal_Int32 nIndex)
+OUString SAL_CALL LngXStringKeyMap::getKeyByIndex(::sal_Int32 nIndex)
 {
 if (static_cast(nIndex) >= maMap.size())
 throw css::lang::IndexOutOfBoundsException();
@@ -268,7 +268,7 @@ OUString SAL_CALL 
SwXStringKeyMap::getKeyByIndex(::sal_Int32 nIndex)
 return OUString();
 }
 
-css::uno::Any SAL_CALL SwXStringKeyMap::getValueByIndex(::sal_Int32 nIndex)
+css::uno::Any SAL_CALL LngXStringKeyMap::getValueByIndex(::sal_Int32 nIndex)
 {
 if (static_cast(nIndex) >= maMap.size())
 throw css::lang::IndexOutOfBoundsException();
@@ -428,7 +428,7 @@ void GrammarCheckingIterator::ProcessResult(
 rDesc.nType = text::TextMarkupType::PROOFREADING;
 
 uno::Reference< container::XStringKeyMap > xKeyMap(
-new SwXStringKeyMap());
+new LngXStringKeyMap());
 for( const beans::PropertyValue& rProperty : 
rError.aProperties )
 {
 if ( rProperty.Name == "LineColor" )
diff --git a/linguistic/source/gciterator.hxx b/linguistic/source/gciterator.hxx
index 9241b4136dd7..03abfa2ac450 100644
--- a/linguistic/source/gciterator.hxx
+++ b/linguistic/source/gciterator.hxx
@@ -186,10 +186,10 @@ public:
 
 /** Implementation of the css::container::XStringKeyMap interface
  */
-class SwXStringKeyMap : public 
::cppu::WeakImplHelper
+class LngXStringKeyMap : public 
::cppu::WeakImplHelper
 {
 public:
-SwXStringKeyMap();
+LngXStringKeyMap();
 
 virtual css::uno::Any SAL_CALL getValue(const OUString& aKey) override;
 virtual sal_Bool SAL_CALL hasValue(const OUString& aKey) override;
@@ -199,10 +199,10 @@ public:
 virtual css::uno::Any SAL_CALL getValueByIndex(::sal_Int32 nIndex) 
override;
 
 private:
-SwXStringKeyMap(SwXStringKeyMap&) = delete;
-void operator=(SwXStringKeyMap&) = delete;
+LngXStringKeyMap(LngXStringKeyMap&) = delete;
+void operator=(LngXStringKeyMap&) = delete;
 
-~SwXStringKeyMap() override{};
+~LngXStringKeyMap() override{};
 
 std::map maMap;
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2018-06-02 Thread Luboš Luňák
 sc/source/core/data/global.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 656e5cecbef254c08c871381abc8364a761a6b94
Author: Luboš Luňák 
Date:   Sat Jun 2 17:58:40 2018 +0200

fix memory leak in double-checked init

The pointer indeed shouldn't be just a local argument but a reference
to the global variable, otherwise just the argument gets set.

Change-Id: Ib7060943b089336b409d4861540a861ca2793cde
Reviewed-on: https://gerrit.libreoffice.org/55209
Tested-by: Jenkins 
Reviewed-by: Luboš Luňák 

diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 6e258407653d..bf76a7085758 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -133,7 +133,7 @@ bool ScGlobal::bThreadedGroupCalcInProgress = false;
 template< typename Type, typename Function = std::function< Type*() >,
   typename Guard = osl::MutexGuard, typename GuardCtor = 
osl::GetGlobalMutex >
 static inline
-Type* doubleCheckedInit( Type* pointer, Function function, GuardCtor guardCtor 
= osl::GetGlobalMutex())
+Type* doubleCheckedInit( Type*& pointer, Function function, GuardCtor 
guardCtor = osl::GetGlobalMutex())
 {
 Type* p = pointer;
 if (!p)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 108370] Impress Crash with videos

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108370

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED
   Keywords|bibisectRequest |

--- Comment #16 from Buovjaga  ---
No response, so closing as WFM.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107322] [META] Media (audio / video) bugs and enhancements

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107322
Bug 107322 depends on bug 108370, which changed state.

Bug 108370 Summary: Impress Crash with videos
https://bugs.documentfoundation.org/show_bug.cgi?id=108370

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117619] LibreOffice unresponsive in Linux after pasting a text over several bullet points in a slide of Impress

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117619

--- Comment #2 from Buovjaga  ---
New dailies have arrived:
https://libreoffice.soluzioniopen.com/index.php/daily-version/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117974] Closing the mail-merge-wizard after a failed source import crashes writer

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117974

Julien Nabet  changed:

   What|Removed |Added

Crash report or|crashreport.libreoffice.org |http://crashreport.libreoff
crash signature|/stats/crash_details/3bc54f |ice.org/stats/crash_details
   |35-f1dd-4f08-8fb3-8101b69f2 |/51b49c67-be51-4daf-961d-66
   |6e8 |2ddfeb0c4a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117973] LO crashed when starting up to open a file (ig75icd64.dll)

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117973

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Could you check you use last graphic driver (for OpenGL part)?
Could you give a try to brand new 6.0.4
Finally, could you give a look to
https://wiki.documentfoundation.org/QA/FirstSteps ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117972] Incorrect source string for UI in Pootle - Libreoffice 6 and Master

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117972

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117974] Closing the mail-merge-wizard after a failed source import crashes writer

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117974

Julien Nabet  changed:

   What|Removed |Added

Summary|Closing the |Closing the
   |mail-merge-wizzard after a  |mail-merge-wizard after a
   |failed source import|failed source import
   |crashes writer  |crashes writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: basctl/source

2018-06-02 Thread Julien Nabet
 basctl/source/basicide/macrodlg.cxx |   15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 7667dda435b2671f1d78e967669fa0fe725b5af6
Author: Julien Nabet 
Date:   Sat May 26 22:38:24 2018 +0200

tdf#117825: check if macros are allowed when double-click one

Change-Id: I4ebb38bdac543995ee7e73dbd67ff5f1402d1a0a
Reviewed-on: https://gerrit.libreoffice.org/54867
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/basctl/source/basicide/macrodlg.cxx 
b/basctl/source/basicide/macrodlg.cxx
index 986dfecb635e..ca0b9161de7d 100644
--- a/basctl/source/basicide/macrodlg.cxx
+++ b/basctl/source/basicide/macrodlg.cxx
@@ -460,10 +460,23 @@ void MacroChooser::CheckButtons()
 
 IMPL_LINK_NOARG(MacroChooser, MacroDoubleClickHdl, SvTreeListBox*, bool)
 {
+SbMethod* pMethod = GetMacro();
+SbModule* pModule = pMethod ? pMethod->GetModule() : nullptr;
+StarBASIC* pBasic = pModule ? 
static_cast(pModule->GetParent()) : nullptr;
+BasicManager* pBasMgr = pBasic ? FindBasicManager(pBasic) : nullptr;
+ScriptDocument 
aDocument(ScriptDocument::getDocumentForBasicManager(pBasMgr));
+if (aDocument.isDocument() && !aDocument.allowMacros())
+{
+std::unique_ptr xError(
+Application::CreateMessageDialog(GetFrameWeld(), 
VclMessageType::Warning,
+ VclButtonsType::Ok, 
IDEResId(RID_STR_CANNOTRUNMACRO)));
+xError->run();
+return false;
+}
+
 StoreMacroDescription();
 if (nMode == Recording)
 {
-SbMethod* pMethod = GetMacro();
 if (pMethod && !QueryReplaceMacro(pMethod->GetName(), GetFrameWeld()))
 return false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103503] [META] GTK2 VCL backend bugs and enhancements

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103503
Bug 103503 depends on bug 101798, which changed state.

Bug 101798 Summary: VIEWING: Text boundaries broken when text is entered (GTK2)
https://bugs.documentfoundation.org/show_bug.cgi?id=101798

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/source

2018-06-02 Thread Caolán McNamara
 vcl/source/font/fontcache.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 508411a4eb17174beb255972659d38c3cd85b4e2
Author: Caolán McNamara 
Date:   Fri Jun 1 13:25:46 2018 +0100

fix dubious cache comparison check

in...

commit 083b7ca26bbf4b9bad2922520caaf5c0227dac5e
Date:   Tue Dec 26 15:58:21 2017 +0100

Move PhysicalFontFace member of FontSelectPattern

this went from...

if (
(rA.mpFontData && rA.mpFontData->IsSymbolFont()) ||
(rB.mpFontData && rB.mpFontData->IsSymbolFont())
   )

to ...

 if (rA.IsSymbolFont() && rB.IsSymbolFont())
 {

Change-Id: I1407573dfa73ac843b790ff3bc4ac0d5f66ab42c
Reviewed-on: https://gerrit.libreoffice.org/55184
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/font/fontcache.cxx b/vcl/source/font/fontcache.cxx
index 3e4945505144..205b49ada4e0 100644
--- a/vcl/source/font/fontcache.cxx
+++ b/vcl/source/font/fontcache.cxx
@@ -60,7 +60,7 @@ bool ImplFontCache::IFSD_Equal::operator()(const 
FontSelectPattern& rA, const Fo
 
 // Symbol fonts may recode from one type to another So they are only
 // safely equivalent for equal targets
-if (rA.IsSymbolFont() && rB.IsSymbolFont())
+if (rA.IsSymbolFont() || rB.IsSymbolFont())
 {
 if (rA.maTargetName != rB.maTargetName)
 return false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/unx

2018-06-02 Thread Caolán McNamara
 vcl/headless/svpgdi.cxx|   11 ---
 vcl/inc/headless/svpgdi.hxx|1 +
 vcl/unx/generic/gdi/salgdi.cxx |   15 +--
 3 files changed, 10 insertions(+), 17 deletions(-)

New commits:
commit f9de5f7ea0130a9bad889f9702ac311d6be3deb6
Author: Caolán McNamara 
Date:   Fri Jun 1 13:06:44 2018 +0100

share the cairo clipping code

Change-Id: I2dc8f55fd2612b5fc4440b46ee3184341fd56859
Reviewed-on: https://gerrit.libreoffice.org/55180
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 8bc15fb861dc..4b5050420e7a 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -489,12 +489,12 @@ bool SvpSalGraphics::drawTransformedBitmap(
 return true;
 }
 
-void SvpSalGraphics::clipRegion(cairo_t* cr)
+void SvpSalGraphics::clipRegion(cairo_t* cr, const vcl::Region& rClipRegion)
 {
 RectangleVector aRectangles;
-if (!m_aClipRegion.IsEmpty())
+if (!rClipRegion.IsEmpty())
 {
-m_aClipRegion.GetRegionRectangles(aRectangles);
+rClipRegion.GetRegionRectangles(aRectangles);
 }
 if (!aRectangles.empty())
 {
@@ -506,6 +506,11 @@ void SvpSalGraphics::clipRegion(cairo_t* cr)
 }
 }
 
+void SvpSalGraphics::clipRegion(cairo_t* cr)
+{
+SvpSalGraphics::clipRegion(cr, m_aClipRegion);
+}
+
 bool SvpSalGraphics::drawAlphaRect(long nX, long nY, long nWidth, long 
nHeight, sal_uInt8 nTransparency)
 {
 cairo_t* cr = getCairoContext(false);
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index 37ae2822bf53..c5a0639498ca 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -96,6 +96,7 @@ public:
 cairo_surface_t* getSurface() const { return m_pSurface; }
 static cairo_user_data_key_t* getDamageKey();
 
+static void clipRegion(cairo_t* cr, const vcl::Region& rClipRegion);
 static basegfx::B2DRange drawPolyLine(
 cairo_t* cr,
 const Color& rLineColor,
diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx
index dd09e8d3c62b..e09766c1e598 100644
--- a/vcl/unx/generic/gdi/salgdi.cxx
+++ b/vcl/unx/generic/gdi/salgdi.cxx
@@ -690,20 +690,7 @@ bool X11SalGraphics::drawPolyPolygon( const 
basegfx::B2DPolyPolygon& rOrigPolyPo
 #if ENABLE_CAIRO_CANVAS
 void X11SalGraphics::clipRegion(cairo_t* cr)
 {
-if(!maClipRegion.IsEmpty())
-{
-RectangleVector aRectangles;
-maClipRegion.GetRegionRectangles(aRectangles);
-
-if (!aRectangles.empty())
-{
-for (auto const& rectangle : aRectangles)
-{
-cairo_rectangle(cr, rectangle.Left(), rectangle.Top(), 
rectangle.GetWidth(), rectangle.GetHeight());
-}
-cairo_clip(cr);
-}
-}
+SvpSalGraphics::clipRegion(cr, maClipRegion);
 }
 #endif // ENABLE_CAIRO_CANVAS
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/unx

2018-06-02 Thread Caolán McNamara
 vcl/unx/generic/gdi/salgdi.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 833a76113d588b0e7ce375ccdeca0bde516a2647
Author: Caolán McNamara 
Date:   Fri Jun 1 13:02:04 2018 +0100

Resolves: tdf#101798 ResetClipRegion needs to affect cairo drawing too

regression since...

commit cb382034b061b4acd4f0fd490f42af34517a7b8d
Date:   Fri Jul 1 14:00:00 2016 +0200

tdf#50613 speedup fat line drawing on linux using cairo

Change-Id: I2f1a70f102786228d52199df9960336218c6f9f9
Reviewed-on: https://gerrit.libreoffice.org/55181
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx
index 80dc7ecad17c..bc31846f0159 100644
--- a/vcl/unx/generic/gdi/salgdi.cxx
+++ b/vcl/unx/generic/gdi/salgdi.cxx
@@ -349,6 +349,9 @@ long X11SalGraphics::GetGraphicsWidth() const
 
 void X11SalGraphics::ResetClipRegion()
 {
+#if ENABLE_CAIRO_CANVAS
+maClipRegion.SetNull();
+#endif
 mxImpl->ResetClipRegion();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/unx

2018-06-02 Thread Caolán McNamara
 vcl/unx/generic/gdi/salgdi.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit dde1586c5eebe86deeb1126cde539b3932e2d5a1
Author: Caolán McNamara 
Date:   Fri Jun 1 13:02:04 2018 +0100

Resolves: tdf#101798 ResetClipRegion needs to affect cairo drawing too

regression since...

commit cb382034b061b4acd4f0fd490f42af34517a7b8d
Date:   Fri Jul 1 14:00:00 2016 +0200

tdf#50613 speedup fat line drawing on linux using cairo

Change-Id: I2f1a70f102786228d52199df9960336218c6f9f9
Reviewed-on: https://gerrit.libreoffice.org/55177
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx
index 80dc7ecad17c..bc31846f0159 100644
--- a/vcl/unx/generic/gdi/salgdi.cxx
+++ b/vcl/unx/generic/gdi/salgdi.cxx
@@ -349,6 +349,9 @@ long X11SalGraphics::GetGraphicsWidth() const
 
 void X11SalGraphics::ResetClipRegion()
 {
+#if ENABLE_CAIRO_CANVAS
+maClipRegion.SetNull();
+#endif
 mxImpl->ResetClipRegion();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - tools/source vcl/headless vcl/inc vcl/source vcl/unx

2018-06-02 Thread Caolán McNamara
 tools/source/generic/color.cxx  |2 
 vcl/headless/svpgdi.cxx |   47 +-
 vcl/inc/headless/svpgdi.hxx |   11 +++
 vcl/source/gdi/graphictools.cxx |3 
 vcl/unx/generic/gdi/salgdi.cxx  |  127 +---
 5 files changed, 49 insertions(+), 141 deletions(-)

New commits:
commit 40b7062ffa972ae0a8f51da0b257becfab749d53
Author: Caolán McNamara 
Date:   Fri Jun 1 12:56:39 2018 +0100

share the cairo polyline drawing code

Change-Id: I35c04f33f3a87962a3d0e731213228d5b2e8590e
Reviewed-on: https://gerrit.libreoffice.org/55179
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 553b43ed9f6b..8bc15fb861dc 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -875,7 +875,10 @@ void SvpSalGraphics::drawLine( long nX1, long nY1, long 
nX2, long nY2 )
 releaseCairoContext(cr, false, extents);
 }
 
-bool SvpSalGraphics::drawPolyLine(
+basegfx::B2DRange SvpSalGraphics::drawPolyLine(
+cairo_t* cr,
+const Color& rLineColor,
+bool bAntiAliasB2DDraw,
 const basegfx::B2DPolygon& rPolyLine,
 double fTransparency,
 const basegfx::B2DVector& rLineWidths,
@@ -883,18 +886,8 @@ bool SvpSalGraphics::drawPolyLine(
 css::drawing::LineCap eLineCap,
 double fMiterMinimumAngle)
 {
-// short circuit if there is nothing to do
-const int nPointCount = rPolyLine.count();
-if (nPointCount <= 0)
-{
-return true;
-}
-
 const bool bNoJoin = (basegfx::B2DLineJoin::NONE == eLineJoin && 
basegfx::fTools::more(rLineWidths.getX(), 0.0));
 
-cairo_t* cr = getCairoContext(false);
-clipRegion(cr);
-
 // setup line attributes
 cairo_line_join_t eCairoLineJoin = CAIRO_LINE_JOIN_MITER;
 switch (eLineJoin)
@@ -936,9 +929,9 @@ bool SvpSalGraphics::drawPolyLine(
 }
 }
 
-cairo_set_source_rgba(cr, m_aLineColor.GetRed()/255.0,
-  m_aLineColor.GetGreen()/255.0,
-  m_aLineColor.GetBlue()/255.0,
+cairo_set_source_rgba(cr, rLineColor.GetRed()/255.0,
+  rLineColor.GetGreen()/255.0,
+  rLineColor.GetBlue()/255.0,
   1.0-fTransparency);
 
 cairo_set_line_join(cr, eCairoLineJoin);
@@ -951,12 +944,13 @@ bool SvpSalGraphics::drawPolyLine(
 
 if (!bNoJoin)
 {
-AddPolygonToPath(cr, rPolyLine, rPolyLine.isClosed(), 
!getAntiAliasB2DDraw(), true);
+AddPolygonToPath(cr, rPolyLine, rPolyLine.isClosed(), 
!bAntiAliasB2DDraw, true);
 extents = getClippedStrokeDamage(cr);
 cairo_stroke(cr);
 }
 else
 {
+const int nPointCount = rPolyLine.count();
 // emulate rendering::PathJoinType::NONE by painting single edges
 const sal_uInt32 nEdgeCount(rPolyLine.isClosed() ? nPointCount : 
nPointCount - 1);
 basegfx::B2DPolygon aEdge;
@@ -970,7 +964,7 @@ bool SvpSalGraphics::drawPolyLine(
 aEdge.setNextControlPoint(0, rPolyLine.getNextControlPoint(i % 
nPointCount));
 aEdge.setPrevControlPoint(1, 
rPolyLine.getPrevControlPoint(nNextIndex));
 
-AddPolygonToPath(cr, aEdge, false, !getAntiAliasB2DDraw(), true);
+AddPolygonToPath(cr, aEdge, false, !bAntiAliasB2DDraw, true);
 
 extents.expand(getStrokeDamage(cr));
 
@@ -983,6 +977,27 @@ bool SvpSalGraphics::drawPolyLine(
 extents.intersect(getClipBox(cr));
 }
 
+return extents;
+}
+
+bool SvpSalGraphics::drawPolyLine(
+const basegfx::B2DPolygon& rPolyLine,
+double fTransparency,
+const basegfx::B2DVector& rLineWidths,
+basegfx::B2DLineJoin eLineJoin,
+css::drawing::LineCap eLineCap,
+double fMiterMinimumAngle)
+{
+// short circuit if there is nothing to do
+if (rPolyLine.count() <= 0)
+return true;
+
+cairo_t* cr = getCairoContext(false);
+clipRegion(cr);
+
+basegfx::B2DRange extents = drawPolyLine(cr, m_aLineColor, 
getAntiAliasB2DDraw(), rPolyLine,
+ fTransparency, rLineWidths, 
eLineJoin, eLineCap, fMiterMinimumAngle);
+
 releaseCairoContext(cr, false, extents);
 
 return true;
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index 25e828e8618c..37ae2822bf53 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -96,6 +96,17 @@ public:
 cairo_surface_t* getSurface() const { return m_pSurface; }
 static cairo_user_data_key_t* getDamageKey();
 
+static basegfx::B2DRange drawPolyLine(
+cairo_t* cr,
+const Color& rLineColor,
+bool bAntiAliasB2DDraw,
+const basegfx::B2DPolygon& rPolyLine,
+double fTransparency,
+const basegfx::B2DVector& rLineWidths,
+basegfx::B2DLineJoin eLineJoin,
+css::drawing::LineCap eLineCap,
+

[Libreoffice-bugs] [Bug 114973] Ctrl+A and Select all don't work when a style is hidden

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114973

Buovjaga  changed:

   What|Removed |Added

   Severity|normal  |minor
Version|5.4.7.2 release |3.5.0 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107391] FILEOPEN: Images set as 'no wrap' appear floating over text

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107391

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||todven...@suomi24.fi

--- Comment #5 from Buovjaga  ---
funk: the Google Drive link is dead. We now have an upload limit of 30MB, maybe
it would fit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114973] Ctrl+A and Select all don't work when a style is hidden

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114973

Lafricain  changed:

   What|Removed |Added

   Severity|minor   |normal
Version|3.5.0 release   |5.4.7.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117856] Firebird: Migration: Simple form-subform Form fails to work after otherwise successful run of migration assistant

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117856

Drew Jensen  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117856] Firebird: Migration: Simple form-subform Form fails to work after otherwise successful run of migration assistant

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117856

Drew Jensen  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

--- Comment #5 from Drew Jensen  ---
Ok I reopened this because it is not really a duplicate of the other issue,
although it is the same bug but in different code.

The migration assistant today creates initial firebird metadata with name
parameter substitution turned off.

Grabbing the little basic script from the closed issue for firebird generally:
Option Explicit
Sub ensureConnection()
Dim DBDocUI as Object
on error resume next
'XRay ThisComponent
DBDocUI = ThisDatabaseDocument.currentController
if not DBDocUI.isConnected then
DBDocUI.connect
end if
on error goto 0
End Sub

Sub Main
ensureConnection()
ThisDatabaseDocument.DataSource.Settings.ParameterNameSubstitution =
true
End Sub

and running that against the migrated base files does indeed fix this problem,
and the forms w/regard to main/sub form access work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117970] freezes when I right-click copy U+956 from Special Characters window

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117970

V Stuart Foote  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org,
   ||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Can not reproduce on Windows 10 Home 64-bit en-US locale with
Version: 6.2.0.0.alpha0+ (x64)
Build ID: 5f1ce0a77c63df597fba9d4cbd45be3a266343c3
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-27_23:32:53
Locale: en-US (en_US); Calc: CL

nor on

Version: 6.0.4.2 (x64)
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: CL

Set CTL font to Microsoft Nimala UI (left default Hindi, but could be one of
the other Indic languages). Open the Special Character dialog, Navigate to the
Devangari block.

Mouse over any of the vowel signs, right mouse context menu "Copy to
clipboard".

Using clipboard utility (Nir Sofer's InsideClipboard) I see a Format ID 13
CF_UNICODETEXT for the selected glyph.

A +v paste to paragraph places the glyph--and will combine with other
glyps from the block. Also verified the clipboard will retain the copied glyph
for subsequent use.

The "Add to Favorites" button and selection from that stack seems to work well
as an alternative to holding on clipboard.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113878] Copy/Paste of partial cell contents string with hyperlink - nothing happens or, in recent versions, string with link appears _twice_

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113878

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #6 from Buovjaga  ---
Bisecting points to the same blamed commit as for bug 115317.
Bug 106386 is also caused by the commit.

*** This bug has been marked as a duplicate of bug 115317 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107733
Bug 107733 depends on bug 113878, which changed state.

Bug 113878 Summary: Copy/Paste of partial cell contents string with hyperlink - 
nothing happens or, in recent versions, string with link appears _twice_
https://bugs.documentfoundation.org/show_bug.cgi?id=113878

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115317] EDITING: Unable to paste URL when editing a cell

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115317

Buovjaga  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #4 from Buovjaga  ---
*** Bug 113878 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90318] Temporary files generated by reports should not be added to recent documents list.

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90318

--- Comment #8 from Drew Jensen  ---
Created attachment 142487
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142487=edit
Screen shot of start center

This bug is still alive with version 6.1Beta and 6.2 beta

It is not just reports, creating forms also and not just the menu choice is
updated the Start Center is also updated.


Attached screen shot is from a new install of Libo 6.2Beta (built on June 2)
after creating one Base file, then one form in it, followed by one report in it
which was run 3 times.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106484] UI: Print Properties Device tab dropdown items not applied or remembered

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106484

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi
 OS|All |Linux (All)

--- Comment #3 from Buovjaga  ---
Still repro and this seems to be Linux-only as Windows offers the dialog of the
printer driver itself.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: 8e63d451b2aeb646ece98c4e219f92957f4482bd
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on June 1st 2018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100215] Cropped images corrupted when reopening the Slidedeck

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100215

--- Comment #4 from Buovjaga  ---
Tested with 6.0.4 and master on Win (from scratch), but there was no problem.

Aurélien: can you do a test from scratch?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115749] Deleting a (very) large number of sheets is slower than it used to be

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115749

--- Comment #3 from Buovjaga  ---
Results from Win 10:
6.2: 3min 19s
6.0.4: 3min 27s
5.4.2: 3min 20s
5.0.2: 2min 59s (could not jump to first sheet, control was missing)
4.4.7: 2min 48s

I don't know, who would want to spend ages bibisecting this especially with
such gradually progressing results. I should probably do a callgrind.

Version: 6.2.0.0.alpha0+ (x64)
Build ID: a8f8cf72b2b9e912dc4a5aebef55d9b2c0969462
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-30_15:31:15
Locale: fi-FI (fi_FI); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: GSoC weekly update : Add Support for Python in LOEclipse Plugin - Shobhan Mandal

2018-06-02 Thread Shobhan Mandal
Hello Everyone,

The update till date includes the following :
1. My mentor (Samuel Mehrbrodt) pointed out the codes that are redundant in
the Push request earlier, therefore will be working on removing them,
before we can merge it with the original code.
https://github.com/LibreOffice/loeclipse/pull/68#discussion_r191344809
2. Found out that the export made in the earlier week had a incomplete
Manifest, so need to work on it.

Have been fixing the requested changes which will continue to the next week.

Thanks and Regards,
Shobhan.

On Fri, May 25, 2018 at 12:25 PM, Shobhan Mandal <
dev.shobhanman...@gmail.com> wrote:

> Hello Everyone,
>
> The update till date includes the following things that I have worked on:
> 1. Create a separate module for putting in the various classes of Python
> which will be needed for the creation of Project and Exporting it.
> 2. Made the necessary code changes so that we can create a new Python Uno
> Project, this project will not have any of the Java Dependencies that a
> normal Java Uno Project usually has.
> 3. Also the export option has been enabled allowing users to export the
> project if the necessary files have been put into the Project.
>
> Currently working on finding out which of the files have to be created
> automatically during the creation of the Project.
>
> https://github.com/LibreOffice/loeclipse/pull/68 : Contains the pull
> request for Project creation and export.
>
> Thanks and Regards,
> Shobhan.
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 103375] MAILMERGE: unpredictable failures: sometimes looses embedded image, or not all mails sent, when e-mailing as pdf

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103375

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5077

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115077] Merge mail wizard send empty images by mail in HTML format

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115077

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3375

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117944] Sort left to right (Sort columns) causes program crash

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117944

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #6 from Xisco Faulí  ---
Thank you for reporting the bug. 
Could you please create and attach a screencast showing the steps?
There are various free screencast software available for use, including
Camstudio (Windows), Jing (Mac), Simple Screen Recorder (Linux) or
screencast-o-matic.com (Web).

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested screencast is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117944] Sort left to right (Sort columns) causes program crash

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117944

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Crash report or|http://crashreport.libreoff |["google_breakpad::Exceptio
crash signature|ice.org/stats/crash_details |nHandler::HandlePureVirtual
   |/868950f7-da88-4635-89aa-7a |Call()"]
   |063ff7532b  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117883] The features for the "Create:" heading below "Impress Presentation" can't be accessed.

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117883

Xisco Faulí  changed:

   What|Removed |Added

   Assignee|gsha...@sbcglobal.net   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83191] SPELLCHECK: starting apostrophe ignored

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83191

--- Comment #11 from Ad Verburg  ---
tested with: Version: 6.0.4.2
Build ID: 00m0(Build:2)
CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: gtk3; 
Locale: en-GB (en_US.UTF-8); Calc: group
NO change, (error still exist).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107166] Text is invisible, both in UI and in editor on update to 5.3.2, older AMD and Intel GPUs

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107166

--- Comment #213 from Michael Meeks  ---
Piter - I think there is a fundamental problem here. The correct response to
someone fixing your bug is to say "thank you", not "you suck". Bugzilla is some
un-filtered, engineering interaction - it is not for Public Relations (PR). The
fundamental problem is that when enumerating those who did nothing to fix it
(yet) - is that you need to include yourself in that set. There is no 'they'.
Perhaps you can make an argument that our marketing needs to make it clearer
that this is a community project, and not a perfect product - and I'd
sympathize - but anyone can be part of the solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117975] New: LibreOffice 6.0.4.2 Writer won't send to printer

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117975

Bug ID: 117975
   Summary: LibreOffice 6.0.4.2 Writer won't send to printer
   Product: LibreOffice
   Version: 6.0.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pvint...@gmail.com

Description:
Windows 10 (v.1803) 64-bit clean re-install

Print command brings up dialogue box where printers are recognised, including
HP OfficeJet Pro 8100 and OfficeJet 6500. Clicking on OK brings up the graphic
as if the document is being sent to the printer, and the printer icon is shown
in the taskbar. But no print for either printer.
Saving the document as a PDF and printing from the PDF reader works fine.

I have LibreOffice version 6.0.3 on another Windows 10 (v.1803) 64-bit computer
connected to the same printers. No problems printing from that PC or that
version of LibreOffice.

Seems to be a 6.0.4.2 problem

Steps to Reproduce:
1.Create document
2.Print command
3.Choose printer
4. Click OK

Actual Results:  
Nothing

Expected Results:
1 A$ piece of printed A4 paper from the printer


Reproducible: Always


User Profile Reset: Yes



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101
Firefox/56.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109158

--- Comment #29 from tommy27  ---
interestingly LibO 6.0.4 x64 takes the same amount of time to load that list of
the corresponding x32 version.

I hoped that x64 could be faster but I wasn't right

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104199] FILEOPEN: PPTX Table cell borders shouldn't be displayed

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104199

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
 CC||jl...@mail.com
 Status|NEW |ASSIGNED

--- Comment #4 from Justin L  ---
proposed fix: https://gerrit.libreoffice.org/55205.  Both docs from the
duplicate bugs look much better.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114808] FORMATTING, PDF: Cropped image shows different crop in PDF than on screen

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114808

--- Comment #11 from Dirk Munk  ---
I tried to read the Gramps report in LibreOffice 6.04, but after scrolling to
the second page, Writer crashed. 

I tried it twice, it happened both times. I submitted the crash report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2018-06-02 Thread Olivier Hallot
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 96df6f558cae3b8a62e694dc5816ed69dee29486
Author: Olivier Hallot 
Date:   Thu May 31 15:11:59 2018 -0300

Updated core
Project: help  a25c0c5dc1b55a7c4d9338843676dafdf98d86ed

tdf#117933 help pages for MAXIFS,MINIFS

Change-Id: Ib0b27e4f00468b33a9a112ac0dc0967750570b18
Reviewed-on: https://gerrit.libreoffice.org/55143
Tested-by: Jenkins 
Reviewed-by: Sophia Schröder 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index c4b58d2a883f..a25c0c5dc1b5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c4b58d2a883f375a15a5d0ab339ce626155dd901
+Subproject commit a25c0c5dc1b55a7c4d9338843676dafdf98d86ed
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: AllLangHelp_scalc.mk source/text

2018-06-02 Thread Olivier Hallot
 AllLangHelp_scalc.mk |2 
 source/text/scalc/01/func_averageifs.xhp |2 
 source/text/scalc/01/func_countifs.xhp   |2 
 source/text/scalc/01/func_maxifs.xhp |   70 +++
 source/text/scalc/01/func_minifs.xhp |   70 +++
 source/text/scalc/01/func_sumifs.xhp |2 
 6 files changed, 145 insertions(+), 3 deletions(-)

New commits:
commit a25c0c5dc1b55a7c4d9338843676dafdf98d86ed
Author: Olivier Hallot 
Date:   Thu May 31 15:11:59 2018 -0300

tdf#117933 help pages for MAXIFS,MINIFS

Change-Id: Ib0b27e4f00468b33a9a112ac0dc0967750570b18
Reviewed-on: https://gerrit.libreoffice.org/55143
Tested-by: Jenkins 
Reviewed-by: Sophia Schröder 
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index ad9218de2..eba3ef23b 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -219,6 +219,8 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/func_imsinh \
 helpcontent2/source/text/scalc/01/func_imtan \
 helpcontent2/source/text/scalc/01/func_isoweeknum \
+helpcontent2/source/text/scalc/01/func_maxifs \
+helpcontent2/source/text/scalc/01/func_minifs \
 helpcontent2/source/text/scalc/01/func_minute \
 helpcontent2/source/text/scalc/01/func_month \
 helpcontent2/source/text/scalc/01/common_func_workdaysintl \
diff --git a/source/text/scalc/01/func_averageifs.xhp 
b/source/text/scalc/01/func_averageifs.xhp
index 749a8641e..a0a94c292 100644
--- a/source/text/scalc/01/func_averageifs.xhp
+++ b/source/text/scalc/01/func_averageifs.xhp
@@ -58,7 +58,7 @@ If the range of values for calculating the mean and any range 
for finding criter
 =AVERAGEIFS(C2:C6;A2:A6;E2".*";B2:B6;""MAX(B2:B6))
 If E2 = 
pen, the function returns 65, because the link to the cell is substituted with 
its content.
 
-AVERAGE, AVERAGEA, , , , MAX, MIN
+AVERAGE, AVERAGEA, , , , , , MAX, MIN
 
 
 
diff --git a/source/text/scalc/01/func_countifs.xhp 
b/source/text/scalc/01/func_countifs.xhp
index b5d10dc22..bb0280dc4 100644
--- a/source/text/scalc/01/func_countifs.xhp
+++ b/source/text/scalc/01/func_countifs.xhp
@@ -58,7 +58,7 @@ If ranges for arguments Range and 
Criterion have unequ
 =COUNTIFS(A2:A6;E2".*";B2:B6;""MAX(B2:B6))
 If E2 = 
pen, the function returns 1, because the link to the cell is substituted with 
its content and it works as a function above.
 
-COUNT, COUNTIF, COUNTA, , , MAX, MIN
+COUNT, 
COUNTIF, COUNTA, , , , , MAX, MIN
 
 
 
diff --git a/source/text/scalc/01/func_maxifs.xhp 
b/source/text/scalc/01/func_maxifs.xhp
new file mode 100644
index 0..238f9cfb4
--- /dev/null
+++ b/source/text/scalc/01/func_maxifs.xhp
@@ -0,0 +1,70 @@
+
+
+
+
+
+  
+MAXIFS function
+/text/scalc/01/func_maxifs.xhp
+  
+
+
+
+
+
+
+  MAXIFS function
+  maximum;satisfying conditions
+
+MAXIFS 
function
+Returns the maximum of the values of cells in 
a range that meets multiple criteria in multiple 
ranges.
+
+
+Syntax
+MAXIFS( 
Max_Range ; Criterion_range1 ; Criterion1 [ ; Criterion_range2 ; Criterion2 
[;...]])
+
+Max_Range – required argument. A range of cells, 
a name of a named range or a label of a column or a row containing values for 
calculating the maximum.
+Criterion_range1 – required argument. A range of 
cells, a named range or a label of a column or a row containing values for 
finding the corresponding criterion.
+Criterion1 – required argument. A string 
expression of the conditon that defines what cells should be used to calculate 
the maximum. The expression can contain text, numbers, regular expressions (if 
enabled in calculation options) or wildcards (if enabled in calculation 
options).
+Criterion_range2 – Optional. Criterion_range2 and 
all the following mean the same as Criterion_range1.
+Criterion2 – Optional. Criterion2 and all the 
following mean the same as Criterion1.
+Max_Range and Criterion_range1, 
Criterion_range2... must have the same size, otherwise the function 
returns err:502 - Invalid argument.
+
+The logical 
relation between criteria can be defined as logical AND (conjunction). In other 
words, if and only if all given criteria are met, a value from the 
corresponding cell of the given Max_Range is taken into 
calculation of the maximum.
+
+The 
function can have up to 255 arguments, meaning that you can specify 127 
criteria ranges and criteria for them.
+
+
+
+If a 
cell contains TRUE, it is treated as 1, if a cell contains FALSE – as 0 
(zero).
+
+
+In all 
examples below, ranges for maximum calculation contain the row #6, but it is 
ignored, because it contains text.
+
+Simple usage
+=MAXIFS(B2:B6;B2:B6;"35")
+Calculates the maximum of values of the range B2:B6 that are 
greater than or equal to 20. Returns 35. The fifth row does not meet the 
criterion.
+=MAXIFS(C2:C6;B2:B6;"=20";C2:C6;"90")
+Calculates the maximum of values of the range C2:C6 that are 
lower than 90 

[Libreoffice-bugs] [Bug 114808] FORMATTING, PDF: Cropped image shows different crop in PDF than on screen

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114808

Buovjaga  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #10 from Buovjaga  ---
This now works in master!

Version: 6.2.0.0.alpha0+ (x64)
Build ID: a8f8cf72b2b9e912dc4a5aebef55d9b2c0969462
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-30_15:31:15
Locale: fi-FI (fi_FI); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108280] [META] Image crop bugs and enhancements

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108280
Bug 108280 depends on bug 114808, which changed state.

Bug 114808 Summary: FORMATTING, PDF: Cropped image shows different crop in PDF 
than on screen
https://bugs.documentfoundation.org/show_bug.cgi?id=114808

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116082] [META] Image issues related to image DPI

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116082
Bug 116082 depends on bug 114808, which changed state.

Bug 114808 Summary: FORMATTING, PDF: Cropped image shows different crop in PDF 
than on screen
https://bugs.documentfoundation.org/show_bug.cgi?id=114808

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99088] Export to PNG messes up with DPI

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99088

Buovjaga  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #17 from Buovjaga  ---
Bisected with bibisect-win32-5.2 to
https://cgit.freedesktop.org/libreoffice/core/commit/?id=33e49a3b6655c1503dc81b583f5016fc3b2fda19

commit  33e49a3b6655c1503dc81b583f5016fc3b2fda19 (patch)
tree2c5d140f629c84ea2d4d94d42989470de7172a3c
parent  49a32f4b2f1773df353bfd05af2f81d560025d18 (diff)
tdf#96046 SVG: use the same PPI as in svgio
Change-Id: I211dcc6fb242cfbd05636d42a811523de8e83be6
Reviewed-on: https://gerrit.libreoffice.org/20182

Adding Xisco to CC

Xisco: see comment 14's "To have the exact regression in a single comment"

I don't know why Heiko changed the topic to PNG. I bisected SVG exporting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - vcl/source

2018-06-02 Thread Matthias Seidel
 vcl/source/app/settings.cxx|2 +-
 vcl/source/window/toolbox2.cxx |4 ++--
 vcl/source/window/window.cxx   |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 48f33ea9fa4084841e0ac6197f18b2be9dc0c05c
Author: Matthias Seidel 
Date:   Sat Jun 2 11:22:39 2018 +

Fixed typos:

sensisitive -> sensitive

diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx
index 7e0d7a461fb9..e394e7e6e8ac 100644
--- a/vcl/source/app/settings.cxx
+++ b/vcl/source/app/settings.cxx
@@ -1898,7 +1898,7 @@ sal_Bool AllSettings::GetLayoutRTL() const
 nUIMirroring = 0; // ask configuration only once
 utl::OConfigurationNode aNode = 
utl::OConfigurationTreeRoot::tryCreateWithServiceFactory(
 vcl::unohelper::GetMultiServiceFactory(),
-OUString::createFromAscii( "org.openoffice.Office.Common/I18N/CTL" 
) );// note: case sensisitive !
+OUString::createFromAscii( "org.openoffice.Office.Common/I18N/CTL" 
) );// note: case sensitive !
 if ( aNode.isValid() )
 {
 sal_Bool bTmp = sal_Bool();
diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx
index 424b8d047a6b..72821d3ad0f9 100644
--- a/vcl/source/window/toolbox2.cxx
+++ b/vcl/source/window/toolbox2.cxx
@@ -2367,7 +2367,7 @@ sal_Bool ToolBox::AlwaysLocked()
 
 utl::OConfigurationNode aNode = 
utl::OConfigurationTreeRoot::tryCreateWithServiceFactory(
 vcl::unohelper::GetMultiServiceFactory(),
-OUString::createFromAscii( 
"/org.openoffice.Office.UI.GlobalSettings/Toolbars" ) );// note: case 
sensisitive !
+OUString::createFromAscii( 
"/org.openoffice.Office.UI.GlobalSettings/Toolbars" ) );// note: case 
sensitive !
 if ( aNode.isValid() )
 {
 // feature enabled ?
@@ -2380,7 +2380,7 @@ sal_Bool ToolBox::AlwaysLocked()
 // now read the locking state
 utl::OConfigurationNode aNode2 = 
utl::OConfigurationTreeRoot::tryCreateWithServiceFactory(
 vcl::unohelper::GetMultiServiceFactory(),
-OUString::createFromAscii( 
"/org.openoffice.Office.UI.GlobalSettings/Toolbars/States" ) );// note: 
case sensisitive !
+OUString::createFromAscii( 
"/org.openoffice.Office.UI.GlobalSettings/Toolbars/States" ) );// note: 
case sensitive !
 
 sal_Bool bLocked = sal_Bool();
 ::com::sun::star::uno::Any aValue2 = aNode2.getNodeValue( 
OUString::createFromAscii( "Locked" ) );
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 7269794766d8..9ca096e8f6fb 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -630,7 +630,7 @@ void Window::ImplUpdateGlobalSettings( AllSettings& 
rSettings, sal_Bool bCallHdl
 sal_Bool bTmp = sal_False, bAutoHCMode = sal_True;
 utl::OConfigurationNode aNode = 
utl::OConfigurationTreeRoot::tryCreateWithServiceFactory(
 vcl::unohelper::GetMultiServiceFactory(),
-OUString::createFromAscii( 
"org.openoffice.Office.Common/Accessibility" ) );// note: case sensisitive !
+OUString::createFromAscii( 
"org.openoffice.Office.Common/Accessibility" ) );// note: case sensitive !
 if ( aNode.isValid() )
 {
 ::com::sun::star::uno::Any aValue = aNode.getNodeValue( 
OUString::createFromAscii( "AutoDetectSystemHC" ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 114980] "Preparing preview" for master slides "Recently used" or "Used in this presentation" takes a long time sometimes

2018-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114980

--- Comment #7 from Harald Berger  ---
Now it's the thame Bug in Windows10, 64-Bit
Version: 6.0.4.2 (x64)
Build-ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU-Threads: 8; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   >