[Libreoffice-commits] core.git: vcl/quartz
vcl/quartz/AquaGraphicsBackend.cxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 564ba9278189607b228e6545b8bbcb64eeba85ce
Author: Stephan Bergmann
AuthorDate: Mon May 3 17:15:55 2021 +0200
Commit: Stephan Bergmann
CommitDate: Tue May 4 07:45:19 2021 +0200
loplugin:redundantstatic
Change-Id: I933a51e9107d8f7dff5eeb03f9aba14dff534574
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115046
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/quartz/AquaGraphicsBackend.cxx
b/vcl/quartz/AquaGraphicsBackend.cxx
index 0aa6042f7eb4..6bc44b39f89e 100644
--- a/vcl/quartz/AquaGraphicsBackend.cxx
+++ b/vcl/quartz/AquaGraphicsBackend.cxx
@@ -50,8 +50,8 @@ namespace
{
const basegfx::B2DPoint aHalfPointOfs(0.5, 0.5);
-static void AddPolygonToPath(CGMutablePathRef xPath, const
basegfx::B2DPolygon& rPolygon,
- bool bClosePath, bool bPixelSnap, bool bLineDraw)
+void AddPolygonToPath(CGMutablePathRef xPath, const basegfx::B2DPolygon&
rPolygon, bool bClosePath,
+ bool bPixelSnap, bool bLineDraw)
{
// short circuit if there is nothing to do
const int nPointCount = rPolygon.count();
@@ -128,14 +128,14 @@ static void AddPolygonToPath(CGMutablePathRef xPath,
const basegfx::B2DPolygon&
}
}
-static void alignLinePoint(const Point* i_pIn, float& o_fX, float& o_fY)
+void alignLinePoint(const Point* i_pIn, float& o_fX, float& o_fY)
{
o_fX = static_cast(i_pIn->getX()) + 0.5;
o_fY = static_cast(i_pIn->getY()) + 0.5;
}
-static void getBoundRect(sal_uInt32 nPoints, const Point* pPtAry, tools::Long&
rX, tools::Long& rY,
- tools::Long& rWidth, tools::Long& rHeight)
+void getBoundRect(sal_uInt32 nPoints, const Point* pPtAry, tools::Long& rX,
tools::Long& rY,
+ tools::Long& rWidth, tools::Long& rHeight)
{
tools::Long nX1 = pPtAry->getX();
tools::Long nX2 = nX1;
@@ -167,7 +167,7 @@ static void getBoundRect(sal_uInt32 nPoints, const Point*
pPtAry, tools::Long& r
rHeight = nY2 - nY1 + 1;
}
-static Color ImplGetROPColor(SalROPColor nROPColor)
+Color ImplGetROPColor(SalROPColor nROPColor)
{
Color nColor;
if (nROPColor == SalROPColor::N0)
@@ -181,7 +181,7 @@ static Color ImplGetROPColor(SalROPColor nROPColor)
return nColor;
}
-static void drawPattern50(void*, CGContextRef rContext)
+void drawPattern50(void*, CGContextRef rContext)
{
static const CGRect aRects[2] = { { { 0, 0 }, { 2, 2 } }, { { 2, 2 }, { 2,
2 } } };
CGContextAddRects(rContext, aRects, 2);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/quartz/salgdi.h |1 - 1 file changed, 1 deletion(-) New commits: commit 04fce09a82dd2c2371dc6a203fd310ac04a8ebb7 Author: Stephan Bergmann AuthorDate: Mon May 3 17:14:25 2021 +0200 Commit: Stephan Bergmann CommitDate: Tue May 4 07:44:53 2021 +0200 loplugin:finalprotected Change-Id: I57e70a5a6432f721952d412e14270ae22b4d7a4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h index e7559c5b9e7d..afddffb6a9f9 100644 --- a/vcl/inc/quartz/salgdi.h +++ b/vcl/inc/quartz/salgdi.h @@ -287,7 +287,6 @@ private: void pattern50Fill(); #ifdef MACOSX -protected: void copyScaledArea(tools::Long nDestX, tools::Long nDestY, tools::Long nSrcX, tools::Long nSrcY, tools::Long nSrcWidth, tools::Long nSrcHeight, AquaSharedAttributes* pSrcShared); #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bridges/source connectivity/source
bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx|2 +-
connectivity/source/drivers/macab/MacabResultSet.cxx |4 ++--
connectivity/source/drivers/macab/MacabResultSet.hxx |4 ++--
connectivity/source/drivers/macab/MacabResultSetMetaData.hxx |2 +-
connectivity/source/drivers/macab/MacabStatement.cxx |4 ++--
connectivity/source/drivers/macab/MacabStatement.hxx |4 ++--
6 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit 0d913b281d3b59b7411b2bd0d348be2d15539569
Author: Stephan Bergmann
AuthorDate: Mon May 3 17:13:31 2021 +0200
Commit: Stephan Bergmann
CommitDate: Tue May 4 07:44:27 2021 +0200
loplugin:noexcept (macOS)
Change-Id: Ib8951e9590d70ffecf8fd6af3070ef9c6d4ae151
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115044
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx
b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx
index d83ecb2ae91f..10495582dcc0 100644
--- a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx
+++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx
@@ -115,7 +115,7 @@ struct __cxa_eh_globals {
#if !HAVE_CXXABI_H_CXA_GET_GLOBALS
namespace __cxxabiv1 {
-extern "C" __cxa_eh_globals * __cxa_get_globals() throw();
+extern "C" __cxa_eh_globals * __cxa_get_globals() noexcept;
}
#endif
diff --git a/connectivity/source/drivers/macab/MacabResultSet.cxx
b/connectivity/source/drivers/macab/MacabResultSet.cxx
index 090620af49d0..ecb4ea79e417 100644
--- a/connectivity/source/drivers/macab/MacabResultSet.cxx
+++ b/connectivity/source/drivers/macab/MacabResultSet.cxx
@@ -157,12 +157,12 @@ Any SAL_CALL MacabResultSet::queryInterface(const Type &
rType)
return aRet;
}
-void SAL_CALL MacabResultSet::acquire() throw()
+void SAL_CALL MacabResultSet::acquire() noexcept
{
MacabResultSet_BASE::acquire();
}
-void SAL_CALL MacabResultSet::release() throw()
+void SAL_CALL MacabResultSet::release() noexcept
{
MacabResultSet_BASE::release();
}
diff --git a/connectivity/source/drivers/macab/MacabResultSet.hxx
b/connectivity/source/drivers/macab/MacabResultSet.hxx
index d0d8061f417c..306ef562d3b4 100644
--- a/connectivity/source/drivers/macab/MacabResultSet.hxx
+++ b/connectivity/source/drivers/macab/MacabResultSet.hxx
@@ -104,8 +104,8 @@ namespace connectivity::macab
// XInterface
virtual css::uno::Any SAL_CALL queryInterface( const
css::uno::Type & rType ) override;
-virtual void SAL_CALL acquire() throw() override;
-virtual void SAL_CALL release() throw() override;
+virtual void SAL_CALL acquire() noexcept override;
+virtual void SAL_CALL release() noexcept override;
// XTypeProvider
virtual css::uno::Sequence< css::uno::Type > SAL_CALL getTypes( )
override;
diff --git a/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx
b/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx
index 6db5f240ac24..a7afdf4a094a 100644
--- a/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx
+++ b/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx
@@ -45,7 +45,7 @@ namespace connectivity::macab
MacabResultSetMetaData(MacabConnection* _pConnection, OUString
const & _sTableName);
// avoid ambiguous cast error from the compiler
-operator css::uno::Reference< css::sdbc::XResultSetMetaData > ()
throw()
+operator css::uno::Reference< css::sdbc::XResultSetMetaData > ()
noexcept
{ return this; }
/// @throws css::sdbc::SQLException
diff --git a/connectivity/source/drivers/macab/MacabStatement.cxx
b/connectivity/source/drivers/macab/MacabStatement.cxx
index 450213f7cca5..1f317150d249 100644
--- a/connectivity/source/drivers/macab/MacabStatement.cxx
+++ b/connectivity/source/drivers/macab/MacabStatement.cxx
@@ -568,12 +568,12 @@ void
MacabCommonStatement::getFastPropertyValue(Any&,sal_Int32 nHandle) const
}
}
-void SAL_CALL MacabCommonStatement::acquire() throw()
+void SAL_CALL MacabCommonStatement::acquire() noexcept
{
MacabCommonStatement_BASE::acquire();
}
-void SAL_CALL MacabCommonStatement::release() throw()
+void SAL_CALL MacabCommonStatement::release() noexcept
{
MacabCommonStatement_BASE::release();
}
diff --git a/connectivity/source/drivers/macab/MacabStatement.hxx
b/connectivity/source/drivers/macab/MacabStatement.hxx
index 83142fc56618..6b0c53c234ad 100644
--- a/connectivity/source/drivers/macab/MacabStatement.hxx
+++ b/connectivity/source/drivers/macab/MacabStatement.hxx
@@ -106,8 +106,8 @@ namespace connectivity::macab
using MacabCommonStatement_BASE::disposing;
// XInterface
-virtual void SAL_CALL release() throw() override;
-virtual void SAL_CALL acquire() throw() override;
+virtual
[Libreoffice-bugs] [Bug 142057] Improvement to User Interface Variants
https://bugs.documentfoundation.org/show_bug.cgi?id=142057 --- Comment #2 from PeeWee --- The use of the word "Toolbar" in the option name can cause confusion to a user. I am experienced with LibreOffice being one of the Technical Writers on the LO Documentation Team and I got confused with these option names using "Toolbar". Standard Toolbar is a separate toolbar that is only one part of the standard user interface. Changing the user interface is about the whole of the user interface, not just toolbars. The actual name for the dialog looks very amateurish as if this concept of changing user interface has not been thoroughly thought out. The dialog should be titled with its purpose UI Variants or Changing User Interface. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 142057] Improvement to User Interface Variants
https://bugs.documentfoundation.org/show_bug.cgi?id=142057 --- Comment #2 from PeeWee --- The use of the word "Toolbar" in the option name can cause confusion to a user. I am experienced with LibreOffice being one of the Technical Writers on the LO Documentation Team and I got confused with these option names using "Toolbar". Standard Toolbar is a separate toolbar that is only one part of the standard user interface. Changing the user interface is about the whole of the user interface, not just toolbars. The actual name for the dialog looks very amateurish as if this concept of changing user interface has not been thoroughly thought out. The dialog should be titled with its purpose UI Variants or Changing User Interface. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142071] Some of Contents of Tips of The Day Missmatch with real menu/options
https://bugs.documentfoundation.org/show_bug.cgi?id=142071 --- Comment #1 from Rizal Muttaqin --- Seems those string all available at https://opengrok.libreoffice.org/xref/core/cui/inc/tipoftheday.hrc?r=f1a20dc8 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142071] New: Some of Contents of Tips of The Day Missmatch with real menu/options
https://bugs.documentfoundation.org/show_bug.cgi?id=142071 Bug ID: 142071 Summary: Some of Contents of Tips of The Day Missmatch with real menu/options Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz...@libreoffice.org I have been busy translating LibO to Indonesian and have found some of ToTD contents are miss match with the menu or contains wrong string. Here is the content list based on KeyID Step to reproduce 1. Enable KeyID language (Tools > Options > Language Settings > Languages: User Interface) 2. Open Tips of The Day dialog (Help > Show Tip of The Day) 3. See some contents Here is the list of KeyID that has the issue 1. WMnj2 "You can customize the middle mouse button per Tools ▸ Options ▸ %PRODUCTNAME ▸ View ▸ Middle Mouse button." 2. 63noP "%PRODUCTNAME can automatically add a numbered caption when you insert objects. See Tools ▸ Options ▸ %PRODUCTNAME Writer ▸ AutoCaption." 3. DKBCg "To get the “Vertical Text” tool in the Drawing toolbar, check Tools ▸ Options ▸ Language Settings ▸ Languages ▸ Default languages ▸ Asian (and make the button visible with right-click)." 4. UggLQ "To display the scrollbar to the left, enable Tools ▸ Options ▸ Language Settings ▸ Languages ▸ Complex text and check Sheet ▸ Right-To-Left." 5. DUvk6 "Select a different icon set from Tools ▸ Options ▸ %PRODUCTNAME ▸ View ▸ User Interface ▸ Icon style." 6. QDmWG "You can change the look of %PRODUCTNAME via Tools ▸ Options ▸ View ▸ User Interface. 7. j4m6F "Select options in Tools ▸ Options ▸ %PRODUCTNAME Writer ▸ Formatting Aids ▸ Display to specify which non-printing characters are displayed." Version: gR8uu‖%ABOUTBOXPRODUCTVERSION%ABOUTBOXPRODUCTVERSIONSUFFIX / LibreOffice Community Build ID: 0dc9da5df470b9c345e78dbe9553d81b9e4a7435 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5 (cairo+xcb) Locale: id-ID (id_ID.UTF-8); UI: qtz TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-04-29_15:55:29 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73994] FILESAVE: 1 MB XLSX grows to 12 MB upon save as ODS
https://bugs.documentfoundation.org/show_bug.cgi?id=73994 --- Comment #8 from todgas --- Online games are very popular at present. Google play gift card codes are promo codes that can be used to redeem anything on Google Play Store. The Google play gift card codes help you get free credits that can be used for in-app purchases, diamonds, or rewards for free from the Play Store. https://sites.google.com/view/gplay-gift-card-generators -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141423] UNO Object Inspector: not possible to dock the toolbar back
https://bugs.documentfoundation.org/show_bug.cgi?id=141423 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141764] Wrong image showing Weblate in Firefox.
https://bugs.documentfoundation.org/show_bug.cgi?id=141764 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141763] Create a separate page count for each document section
https://bugs.documentfoundation.org/show_bug.cgi?id=141763 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132098] Custom InteractionHandler
https://bugs.documentfoundation.org/show_bug.cgi?id=132098 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137223] libreoffice writer freezes (crash) when pasting clipboard into a doc
https://bugs.documentfoundation.org/show_bug.cgi?id=137223 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137223] libreoffice writer freezes (crash) when pasting clipboard into a doc
https://bugs.documentfoundation.org/show_bug.cgi?id=137223 --- Comment #5 from QA Administrators --- Dear gary tuthill, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137861] Libre Office only allows English USA
https://bugs.documentfoundation.org/show_bug.cgi?id=137861 --- Comment #6 from QA Administrators --- Dear Richard, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137961] serial correspondence sending email
https://bugs.documentfoundation.org/show_bug.cgi?id=137961 --- Comment #4 from QA Administrators --- Dear Dominik, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137425] Spell check
https://bugs.documentfoundation.org/show_bug.cgi?id=137425 --- Comment #3 from QA Administrators --- Dear Alimentarius, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90020] UI: Bottom of Context Menu sometimes hidden behind taskbar
https://bugs.documentfoundation.org/show_bug.cgi?id=90020 --- Comment #6 from QA Administrators --- Dear Gordo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71843] Missing "Surround header" and "Surround footer" Page Border options in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=71843 --- Comment #16 from QA Administrators --- Dear Luis Felipe Marzagao, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117376] Firebird: Migration: Migration function should not mix the HSQLdb and Firebird schemas in the same altered ODB file
https://bugs.documentfoundation.org/show_bug.cgi?id=117376 --- Comment #7 from QA Administrators --- Dear Drew Jensen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58343] Master template name tooltip not updated after slide rename
https://bugs.documentfoundation.org/show_bug.cgi?id=58343 --- Comment #9 from QA Administrators --- Dear Don't use this one - Philippe Jung, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68473] UI: cannot select whole line by dragging mouse if the line starts with an object anchored as character
https://bugs.documentfoundation.org/show_bug.cgi?id=68473 --- Comment #8 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142061] Calc UI: Display anomalies when resizing columns (macOS Catalina)
https://bugs.documentfoundation.org/show_bug.cgi?id=142061 --- Comment #1 from smurf --- I'm running LO 7.1.0.3 on another machine, with MacOS Mojave; same problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svgio/source
svgio/source/svgreader/SvgNumber.cxx |6 +++---
svgio/source/svgreader/svgtools.cxx |4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 40b833351e4ffd7608ac82e79e21d189de2171ff
Author: Tomaž Vajngerl
AuthorDate: Mon May 3 21:54:49 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Tue May 4 04:47:26 2021 +0200
svgio: instead of assert(false && ...) rather use SAL_WARN instead
Previously OSL_ENSURE was changed to assert(false && ...) which
wasn't a good idea as now we hit asserts in some cases, so rather
than that, use SAL_WARN instead.
Change-Id: I69740d71ae97a79ece56d77c3dd7d0ce83c9bb34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115040
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/svgio/source/svgreader/SvgNumber.cxx
b/svgio/source/svgreader/SvgNumber.cxx
index 8254b45b035f..9a11c1979962 100644
--- a/svgio/source/svgreader/SvgNumber.cxx
+++ b/svgio/source/svgreader/SvgNumber.cxx
@@ -27,7 +27,7 @@ double SvgNumber::solveNonPercentage(const InfoProvider&
rInfoProvider) const
{
if (!isSet())
{
-assert(false && "SvgNumber not set (!)");
+SAL_WARN("svgio", "SvgNumber not set (!)");
return 0.0;
}
@@ -56,7 +56,7 @@ double SvgNumber::solveNonPercentage(const InfoProvider&
rInfoProvider) const
}
case SvgUnit::percent:
{
-assert(false && "Do not use with percentage!");
+SAL_WARN("svgio", "Do not use with percentage!");
break;
}
}
@@ -68,7 +68,7 @@ double SvgNumber::solve(const InfoProvider& rInfoProvider,
NumberType aNumberTyp
{
if (!isSet())
{
-assert(false && "SvgNumber not set (!)");
+SAL_WARN("svgio", "SvgNumber not set (!)");
return 0.0;
}
diff --git a/svgio/source/svgreader/svgtools.cxx
b/svgio/source/svgreader/svgtools.cxx
index 75227939e489..5d6534db0721 100644
--- a/svgio/source/svgreader/svgtools.cxx
+++ b/svgio/source/svgreader/svgtools.cxx
@@ -1046,7 +1046,7 @@ namespace svgio::svgreader
if(nInitPos == nPos)
{
-assert(false && "Could not interpret on current
position (!)");
+SAL_WARN("svgio", "Could not interpret on current
position (!)");
nPos++;
}
}
@@ -1249,7 +1249,7 @@ namespace svgio::svgreader
if(nInitPos == nPos)
{
-assert(false && "Could not interpret on current
position (!)");
+SAL_WARN("svgio", "Could not interpret on current
position (!)");
nPos++;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142070] Elements are hard to read when using dark GTK theme in Tabbed UI on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=142070 --- Comment #1 from Hari Rana --- Created attachment 171623 --> https://bugs.documentfoundation.org/attachment.cgi?id=171623=edit LibreOffice with Adawaita dark on the File tab. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142070] New: Elements are hard to read when using dark GTK theme in Tabbed UI on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=142070 Bug ID: 142070 Summary: Elements are hard to read when using dark GTK theme in Tabbed UI on Linux Product: LibreOffice Version: 7.1.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: theevilskele...@riseup.net Description: Some elements improperly contrast when using the Tabbed UI with a dark GTK theme irregardless of the icon theme chosen. Steps to Reproduce: 1. Change the UI to Tabbed (Ribbon UI) 2. Change GTK theme to a dark theme, like Adawaita dark 3. Launch LibreOffice Actual Results: Some elements improperly contrast with the dark theme. Elements that improperly contrast include: - File > Recent Document - File > Help - File > File - Home > Home - Insert > Insert - Layout > Layout - References > References - Review > Review - View > View - Extension > Extension - Tools > Tools - Hamburger menu Likely more. Expected Results: All the elements should properly contrast with the dark theme. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.1.2.2 / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 12; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-CA (en_CA.UTF-8); UI: en-US Flatpak Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142012] wrong taskbar icon for second-and-onwards document
https://bugs.documentfoundation.org/show_bug.cgi?id=142012 Adolfo Jayme changed: What|Removed |Added OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142029] EDITING FORMATTING Hidden columns revert to not hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=142029 kn...@holian.net changed: What|Removed |Added Version|7.0.5.2 release |6.4.4.1 rc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142029] EDITING FORMATTING Hidden columns revert to not hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=142029 --- Comment #2 from kn...@holian.net --- Always saved as file.ods -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142029] EDITING FORMATTING Hidden columns revert to not hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=142029 kn...@holian.net changed: What|Removed |Added Version|unspecified |7.0.5.2 release Hardware|All |x86-64 (AMD64) OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142029] EDITING FORMATTING Hidden columns revert to not hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=142029 kn...@holian.net changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Libreoffice Latvian format
Hello Eike,
When cleaning LO profile and starting Calc then tools/options/languages,
I noticed this log:
lv-LV requested
lv-LV loaded
warn:unotools.i18n:128132:128132:unotools/source/i18n/localedatawrapper.cxx:1529:
LocaleDataWrapper::scanDateOrder: no magic applicable
By adding some debug, I found it was:
"
rCode=. "gada" DD. ,
LocaleDataWrapper::scanDateOrder: no magic applicable nDay=13 nMonth=17
nYear=0
lv-LV requested
lv-LV loaded
warn:unotools.i18n:128132:128132:unotools/source/i18n/localedatawrapper.cxx:1529:
LocaleDataWrapper::scanDateOrder: no magic applicable nDay=13 nMonth=17
nYear=0
"
i18npool/source/localedata/data/lv_LV.xml contains:
110 type="long" usage="DATE" formatindex="19">
111 . "gada" DD. ,
112
143 type="long" usage="DATE" formatindex="30">
144 , . "gada" DD.
145
Taking a look at https://www.localeplanet.com/icu/lv-LV/index.html, I
saw these formats:
Date.3 Example: 03.05.21
Pattern: dd.MM.yy
Local Pattern: dd.MM.yy
Date.2 Example: 2021. gada 3. maijs
Pattern: y. 'gada' d. MMM
Local Pattern: y. 'gada' d. MMM
Date.1 Example: 2021. gada 3. maijs
Pattern: y. 'gada' d.
Local Pattern: y. 'gada' d.
Date.0 Example: pirmdiena, 2021. gada 3. maijs
Pattern: , y. 'gada' d.
Local Pattern: , y. 'gada' d.
So I thought about this patch:
diff --git a/unotools/source/i18n/localedatawrapper.cxx
b/unotools/source/i18n/localedatawrapper.cxx
index e0e91bbbac79..5ba530de2668 100644
--- a/unotools/source/i18n/localedatawrapper.cxx
+++ b/unotools/source/i18n/localedatawrapper.cxx
@@ -780,6 +780,12 @@ DateOrder LocaleDataWrapper::scanDateOrderImpl(
const OUString& rCode ) const
return DateOrder::YMD;
else
{
+ // lv_LV can use:
+ // - . "gada" DD. ,
+ // - , . "gada" DD.
+ if ( nYear <= nDay && nDay << nMonth && rCode.indexOf('g') != -1)
+ return DateOrder::YDM;
+
if (areChecksEnabled())
{
outputCheckMessage( appendLocaleInfo(
"LocaleDataWrapper::scanDateOrder: no magic applicable" ) );
but DateOrder::YDM doesn't exist:
48 enum class DateOrder {
49 Invalid = -1,
50 MDY = 0,
51 DMY,
52 YMD,
53 };
See
https://opengrok.libreoffice.org/xref/core/include/unotools/localedatawrapper.hxx?r=86b345a9=1897=48#48
Any thoughts here? Should I add this other DateOrder const?
Regards,
Julien
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 142047] Loss of image quality converting ODP to PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=142047 --- Comment #7 from Tim Chambers --- Thanks - the workaround is good to know -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/drawfunc/fuins1.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 931e264590100c80c413556e229a0f03316a Author: Pranam Lashkari AuthorDate: Mon May 3 04:20:00 2021 +0530 Commit: Pranam Lashkari CommitDate: Tue May 4 00:40:01 2021 +0200 LOK: calc: allow image selection on insertion in calc online, image was not selected by default when inserted problems: it was inconsistent with writer and impress/draw it caused problem in cypress testing Change-Id: Ic18b7a918c485a1cd384694d72fbb0a598d26ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114922 Tested-by: Jenkins Reviewed-by: Pranam Lashkari diff --git a/sc/source/ui/drawfunc/fuins1.cxx b/sc/source/ui/drawfunc/fuins1.cxx index f314169f216e..31b597e9ea19 100644 --- a/sc/source/ui/drawfunc/fuins1.cxx +++ b/sc/source/ui/drawfunc/fuins1.cxx @@ -44,6 +44,7 @@ #include #include #include +#include #include #include @@ -196,7 +197,7 @@ static void lcl_InsertGraphic( const Graphic& rGraphic, aAnchorType == SCA_CELL_RESIZE); // don't select if from (dispatch) API, to allow subsequent cell operations -SdrInsertFlags nInsOptions = bApi ? SdrInsertFlags::DONTMARK : SdrInsertFlags::NONE; +SdrInsertFlags nInsOptions = (bApi && !comphelper::LibreOfficeKit::isActive()) ? SdrInsertFlags::DONTMARK : SdrInsertFlags::NONE; bool bSuccess = pView->InsertObjectAtView( pObj, *pPV, nInsOptions ); // SetGraphicLink has to be used after inserting the object, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/calc_tests9/tdf60468.py | 51 +++
sc/qa/uitest/data/tdf60468.csv |5 +++
2 files changed, 56 insertions(+)
New commits:
commit 4ee58a0dedc5160551260793e5fed9e6c3842976
Author: Xisco Fauli
AuthorDate: Mon May 3 13:07:49 2021 +0200
Commit: Xisco Fauli
CommitDate: Tue May 4 00:21:00 2021 +0200
tdf#60468, tdf#142040: sc: Add UItest
Change-Id: I44eb029087708d85fa1f3712cd40bebb6174c58e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115034
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/calc_tests9/tdf60468.py
b/sc/qa/uitest/calc_tests9/tdf60468.py
new file mode 100644
index ..8990194a8b0d
--- /dev/null
+++ b/sc/qa/uitest/calc_tests9/tdf60468.py
@@ -0,0 +1,51 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from libreoffice.calc.document import get_cell_by_position
+
+class Tdf60468(UITestCase):
+
+def test_tdf60468(self):
+
+# Load file from Open dialog
+self.ui_test.execute_dialog_through_command(".uno:Open")
+
+xOpenDialog = self.xUITest.getTopFocusWindow()
+xFileName = xOpenDialog.getChild("file_name")
+xFileName.executeAction("TYPE", mkPropertyValues({"TEXT":
get_url_for_data_file("tdf60468.csv")}))
+
+xOpenBtn = xOpenDialog.getChild("open")
+xOpenBtn.executeAction("CLICK", tuple())
+
+xDialog = self.xUITest.getTopFocusWindow()
+self.assertEqual('true',
get_state_as_dict(xDialog.getChild("tab"))['Selected'])
+self.assertEqual('true',
get_state_as_dict(xDialog.getChild("comma"))['Selected'])
+self.assertEqual('true',
get_state_as_dict(xDialog.getChild("semicolon"))['Selected'])
+self.assertEqual('1',
get_state_as_dict(xDialog.getChild("fromrow"))['Text'])
+
+xOK = xDialog.getChild('ok')
+self.ui_test.close_dialog_through_button(xOK)
+
+document = self.ui_test.get_component()
+
+# tdf#142040: Without the fix in place, this test would have failed
with
+# AssertionError: 'head1' != ''
+for i in range(3):
+self.assertEqual("head" + str(i + 1),
get_cell_by_position(document, 0, i, 0).getString())
+
+self.assertEqual("value1.1\nvalue1.2", get_cell_by_position(document,
0, 0, 1).getString())
+
+# Without the fix in place, this test would have failed with
+# AssertionError: 'value2.1\n\tvalue2.2\nvalue2.3' !=
'value2.1\n\tvalue2.2'
+self.assertEqual("value2.1\n\tvalue2.2\nvalue2.3",
get_cell_by_position(document, 0, 1, 1).getString())
+self.assertEqual("value3", get_cell_by_position(document, 0, 2,
1).getString())
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/data/tdf60468.csv b/sc/qa/uitest/data/tdf60468.csv
new file mode 100644
index ..9f9cfa7238ba
--- /dev/null
+++ b/sc/qa/uitest/data/tdf60468.csv
@@ -0,0 +1,5 @@
+head1 head2 head3
+"value1.1
+value1.2" "value2.1
+ value2.2
+value2.3" value3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142040] CSV import broken in master
https://bugs.documentfoundation.org/show_bug.cgi?id=142040 --- Comment #6 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4ee58a0dedc5160551260793e5fed9e6c3842976 tdf#60468, tdf#142040: sc: Add UItest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142061] Calc UI: Display anomalies when resizing columns (macOS Catalina)
https://bugs.documentfoundation.org/show_bug.cgi?id=142061 steve changed: What|Removed |Added Summary|Calc UI: Display anomalies |Calc UI: Display anomalies |when resizing columns (Mac |when resizing columns |Catalina) |(macOS Catalina) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142022] Crash in: mergedlo.dll / on close
https://bugs.documentfoundation.org/show_bug.cgi?id=142022 --- Comment #25 from Nico --- Accessibility tools : none as far am aware... I "just" have a touch screen on computer, dual screen, a dock, my watch dock, a BT mouse So, side of that, no accessibility... No clipboard tool (side of Windows embed) Am using FR (by default UI) - FR local params. I disconnected all, same issue. I deleted LO user's profile launch LO, clic on Calc, close using top right X All looks fine, no warning. If I delete LO user's profile, all goes fine, I can reproduce what I just explained before. no error. If I keep LO user's profile, I get the warning to recover a file (but I did not had the warning when closing) Really wonder what's running making LO failing :/ Any other test I could run ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142022] Crash in: mergedlo.dll / on close
https://bugs.documentfoundation.org/show_bug.cgi?id=142022 --- Comment #24 from Nico --- Accessibility tools : none as far am aware... I "just" have a touch screen on computer, dual screen, a dock, my watch dock, a BT mouse So, side of that, no accessibility... No clipboard tool (side of Windows embed) Am using FR (by default UI) - FR local params. I disconnected all, same issue. I deleted LO user's profile launch LO, clic on Calc, close using top right X All looks fine, no warning. If I delete LO user's profile, all goes fine, I can reproduce what I just explained before. no error. If I keep LO user's profile, I get the warning to recover a file (but I did not had the warning when closing) Really wonder what's running making LO failing :/ Any other test I could run ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142067] Track changes eats text and marks all as changed
https://bugs.documentfoundation.org/show_bug.cgi?id=142067 --- Comment #3 from birnb...@posteo.de --- Created attachment 171622 --> https://bugs.documentfoundation.org/attachment.cgi?id=171622=edit how it actually looks like (file opened in LO) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142067] Track changes eats text and marks all as changed
https://bugs.documentfoundation.org/show_bug.cgi?id=142067 --- Comment #2 from birnb...@posteo.de --- Created attachment 171621 --> https://bugs.documentfoundation.org/attachment.cgi?id=171621=edit what it should look like (file opened in MS Word) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142069] New: Pulldown not able to see all if text size is 125% on windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=142069 Bug ID: 142069 Summary: Pulldown not able to see all if text size is 125% on windows 10 Product: LibreOffice Version: 7.1.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mclean8...@gmail.com Description: Not able to see all Pulldown if text size is 125% on windows 10 Steps to Reproduce: 1 Windows 10, settings, display, text size to 125% 2. In calc, pulldown view, try to see Zoom. 3. It should scroll down, but didn't Actual Results: could not see Zoom Expected Results: could not see Zoom Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142068] New: EDITING Unable to add new animations to text on any slide after duplicating a slide in LibreOffice Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142068 Bug ID: 142068 Summary: EDITING Unable to add new animations to text on any slide after duplicating a slide in LibreOffice Impress Product: LibreOffice Version: 7.0.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: speed.to...@protonmail.com Description: After creating some slides each with animations per bullet point, I saved the deck and closed the application. Upon returning, I made a duplicate slide. Then, I tried to add a bullet point to a separate slide and add animation to that bullet point. The animation does not work, however, and it shows no text to be animated. Upon saving the deck and closing after duplicating the slide, however, I am now able to add animations to new bullet points/text. Steps to Reproduce: 1.Create slide deck with multiple slides and each with multiple bullet points 2.Add separate animation to each bullet point on each slide 3.Save and quit the application 4.Start the application and duplicate one of the slides 5.Add a new bullet point to the slide and add animation to that bullet point Actual Results: The new step for animation shows no text to be animated. The animation does not work upon presenting on the slide. The animation step shows a blank entry for what is to be animated. Expected Results: The animation step entry shows what text is to be animated. The animation works as intended with the rest of the animations. Reproducible: Always User Profile Reset: Yes Additional Info: N/A -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142067] Track changes eats text and marks all as changed
https://bugs.documentfoundation.org/show_bug.cgi?id=142067 --- Comment #1 from birnb...@posteo.de --- Created attachment 171620 --> https://bugs.documentfoundation.org/attachment.cgi?id=171620=edit Changed document that opens badly in NC and well in MS Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142067] New: Track changes eats text and marks all as changed
https://bugs.documentfoundation.org/show_bug.cgi?id=142067 Bug ID: 142067 Summary: Track changes eats text and marks all as changed Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: birnb...@posteo.de Description: When activating the "track changes" and "show changes" option, NC will strike through text that is deleted and underline text that is added. Sometimes the "show changes" function keels over and gets everything wrong. In the documents I work with, all available text gets marked as new. About half of the text is missing and everything is garbled. Steps to Reproduce: It is unclear how to reproduce this bug. Amidst editing in "track changes" mode the displayed page stops making sense. Present problem may have to do with numerated lists edited in "track changes" mode. Please refer to the enclosed RTF file which opens fine on MS Word on Mac, versions 2011 and 2019. Actual Results: Text is almost completely marked as edited. From some edit point on, text is garbled. Large portions of the text have disappeared. Expected Results: Deleted text should be in strike through, inserted text in underline. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.1.2.2 / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 6; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95549] FILEOPEN - XLSM opens very slowly
https://bugs.documentfoundation.org/show_bug.cgi?id=95549 --- Comment #20 from Xisco Faulí --- (In reply to Buovjaga from comment #18) > Takes 5 seconds now to reach the dialog "The data could not be loaded > completely because the maximum number of columns per sheet was exceeded." > > Closing as wfm > > Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community > Build ID: 9c930c4f3109d123c0831d0fcecf9c8b32e5bbc7 > CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: default; VCL: win > Locale: fi-FI (fi_FI); UI: en-US > Calc: threaded @Buovjaga, could you please bisect when it improved on Windows ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 Bug 107659 depends on bug 78254, which changed state. Bug 78254 Summary: Substantial performance deterioration by scroll through cells via macro in LibreOffice Calc https://bugs.documentfoundation.org/show_bug.cgi?id=78254 What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78254] Substantial performance deterioration by scroll through cells via macro in LibreOffice Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=78254 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- --- Comment #20 from Xisco Faulí --- this is fine with X11 Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: dff586735b6618d9b011823594a33287d8f7f223 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Start: 10:21:02 PM Stop: 22:21:30 Needed Time: 00:00:28 but it takes forever with GTK3, so it might be, it's slow when using accessibility -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 141869] Rephrase "Insert Reference To" items
https://bugs.documentfoundation.org/show_bug.cgi?id=141869 --- Comment #2 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #1) > (In reply to Eyal Rozenberg from comment #0) > > "Insert reference to" -> "Refer using:" > Not an advantage in my non-native ears. "Insert reference to" is ambiguous. It can mean: 1. Choose what element of the document the reference you're inserting will target. 2. Choose what aspect of the target will be used as the text of the reference. My suggestion can only mean (2.) > > "Reference" -> "Reference target text" > Why not "Reference source text" (of course without "source") Because references don't have a source, they only have a target. There is no source text to reference. > > "Above/Below" -> ""Above"/"Below"" (i.e. add quotation marks) > The reference is not using quotation, don't see need for it. Again, it disambiguates. The current text may mean: 1. The reference will be above or below something unspecified. 2. The reference text will be either "above" or "below". > See help (-> URL) for more. I didn't quite understand this last bit of your comment. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 141869] Rephrase "Insert Reference To" items
https://bugs.documentfoundation.org/show_bug.cgi?id=141869 --- Comment #2 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #1) > (In reply to Eyal Rozenberg from comment #0) > > "Insert reference to" -> "Refer using:" > Not an advantage in my non-native ears. "Insert reference to" is ambiguous. It can mean: 1. Choose what element of the document the reference you're inserting will target. 2. Choose what aspect of the target will be used as the text of the reference. My suggestion can only mean (2.) > > "Reference" -> "Reference target text" > Why not "Reference source text" (of course without "source") Because references don't have a source, they only have a target. There is no source text to reference. > > "Above/Below" -> ""Above"/"Below"" (i.e. add quotation marks) > The reference is not using quotation, don't see need for it. Again, it disambiguates. The current text may mean: 1. The reference will be above or below something unspecified. 2. The reference text will be either "above" or "below". > See help (-> URL) for more. I didn't quite understand this last bit of your comment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109530] [META] File opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=109530 Bug 109530 depends on bug 95549, which changed state. Bug 95549 Summary: FILEOPEN - XLSM opens very slowly https://bugs.documentfoundation.org/show_bug.cgi?id=95549 What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95549] FILEOPEN - XLSM opens very slowly
https://bugs.documentfoundation.org/show_bug.cgi?id=95549 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- --- Comment #19 from Xisco Faulí --- Still reproducible here Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: dff586735b6618d9b011823594a33287d8f7f223 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded real4m4,785s user4m0,576s sys 0m2,473s -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141984] LibreOffice Writer crashed when trying to input Special Character 'Paragraph' symbol from tool bar widget.
https://bugs.documentfoundation.org/show_bug.cgi?id=141984 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2066 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142066] Writer crashes if attempt to open insert special characters
https://bugs.documentfoundation.org/show_bug.cgi?id=142066 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||1984 --- Comment #1 from Julien Nabet --- Could you take a look at tdf#141984 put in See Also, specifically: https://bugs.documentfoundation.org/show_bug.cgi?id=141984#c1 ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141800] Key assignment for modifier keys in Draw have collision on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=141800 psidiumcode changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from psidiumcode --- Confirmed. I was able to reproduce both cases as mentioned, rectangle resizing and the polygon drawing. Version: 7.0.5.2 Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 41145efffe9d5af358a52b9e114bb01b98b3d7c2 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108253 Scito changed: What|Removed |Added Depends on||142065 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142065 [Bug 142065] EDITING: Cut paste transposed with formula reference within range leads to #REF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108479] [META] Paste special bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108479 Scito changed: What|Removed |Added Depends on||142065 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142065 [Bug 142065] EDITING: Cut paste transposed with formula reference within range leads to #REF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142066] New: Writer crashes if attempt to open insert special characters
https://bugs.documentfoundation.org/show_bug.cgi?id=142066 Bug ID: 142066 Summary: Writer crashes if attempt to open insert special characters Product: LibreOffice Version: 7.0.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kro...@gmail.com Libre Writer crashes if attempt to open "insert special Characters" list. It then closes all (with saves). Attempt to re-start Libre Office runs into a loop. No way to stop the start up. Only option is to re-boot computer completely. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr3.cxx | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 45b952f64755a1ae34a8bb432b4909c5b91da474
Author: dante
AuthorDate: Sat May 1 12:40:27 2021 +0200
Commit: Eike Rathke
CommitDate: Mon May 3 21:22:38 2021 +0200
Prioritize cmath over math.h in interpr3.cxx
Change-Id: Ifdc50beed9d1b2bae8cd4f512183912366eb4604
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114967
Tested-by: Jenkins
Reviewed-by: Eike Rathke
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index d0cd61c0a228..17fe63381362 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -90,7 +90,7 @@ static double lcl_IterateInverse( const ScDistFunc&
rFunction, double fAx, doubl
unsigned short nCount;
for (nCount = 0; nCount < 1000 && !lcl_HasChangeOfSign(fAy,fBy); nCount++)
{
-if (fabs(fAy) <= fabs(fBy))
+if (std::abs(fAy) <= std::abs(fBy))
{
fTemp = fAx;
fAx += 2.0 * (fAx - fBx);
@@ -130,8 +130,8 @@ static double lcl_IterateInverse( const ScDistFunc&
rFunction, double fAx, doubl
double fSx = 0.5 * (fAx + fBx); // potential next point
bool bHasToInterpolate = true;
nCount = 0;
-while ( nCount < 500 && fabs(fRy) > fYEps &&
-(fBx-fAx) > ::std::max( fabs(fAx), fabs(fBx)) * fXEps )
+while ( nCount < 500 && std::abs(fRy) > fYEps &&
+(fBx-fAx) > ::std::max( std::abs(fAx), std::abs(fBx)) * fXEps )
{
if (bHasToInterpolate)
{
@@ -166,7 +166,7 @@ static double lcl_IterateInverse( const ScDistFunc&
rFunction, double fAx, doubl
}
// if last iteration brought too small advance, then do bisection next
// time, for safety
-bHasToInterpolate = bHasToInterpolate && (fabs(fRy) * 2.0 <=
fabs(fQy));
+bHasToInterpolate = bHasToInterpolate && (std::abs(fRy) * 2.0 <=
std::abs(fQy));
++nCount;
}
return fRx;
@@ -212,7 +212,7 @@ double ScInterpreter::taylor(const double* pPolynom,
sal_uInt16 nMax, double x)
double ScInterpreter::gauss(double x)
{
-double xAbs = fabs(x);
+double xAbs = std::abs(x);
sal_uInt16 xShort =
static_cast(::rtl::math::approxFloor(xAbs));
double nVal = 0.0;
if (xShort == 0)
@@ -268,7 +268,7 @@ double ScInterpreter::gaussinv(double x)
q=x-0.5;
-if(fabs(q)<=.425)
+if(std::abs(q)<=.425)
{
t=0.180625-q*q;
@@ -598,7 +598,7 @@ double ScInterpreter::GetGamma(double fZ)
if (fZ >= -0.5) // shift to x>=1, might overflow
{
-double fLogTest = lcl_GetLogGammaHelper(fZ+2) - rtl::math::log1p(fZ) -
log( fabs(fZ));
+double fLogTest = lcl_GetLogGammaHelper(fZ+2) - rtl::math::log1p(fZ) -
log( std::abs(fZ));
if (fLogTest >= fLogDblMax)
{
SetError( FormulaError::IllegalFPOperation);
@@ -608,7 +608,7 @@ double ScInterpreter::GetGamma(double fZ)
}
// fZ<-0.5
// Use Euler's reflection formula: gamma(x)= pi/ ( gamma(1-x)*sin(pi*x) )
-double fLogDivisor = lcl_GetLogGammaHelper(1-fZ) + log( fabs(
::rtl::math::sin( F_PI*fZ)));
+double fLogDivisor = lcl_GetLogGammaHelper(1-fZ) + log( std::abs(
::rtl::math::sin( F_PI*fZ)));
if (fLogDivisor - fLogPi >= fLogDblMax) // underflow
return 0.0;
@@ -969,7 +969,7 @@ static double lcl_GetBetaHelperContFrac(double fX, double
fA, double fB)
{
fnorm = 1.0/b2;
cfnew = a2*fnorm;
-bfinished = (fabs(cf-cfnew) < fabs(cf)*fMachEps);
+bfinished = (std::abs(cf-cfnew) < std::abs(cf)*fMachEps);
}
cf = cfnew;
rm += 1.0;
@@ -1147,7 +1147,7 @@ void ScInterpreter::ScGauss()
void ScInterpreter::ScFisher()
{
double fVal = GetDouble();
-if (fabs(fVal) >= 1.0)
+if (std::abs(fVal) >= 1.0)
PushIllegalArgument();
else
PushDouble( ::rtl::math::atanh( fVal));
@@ -2628,7 +2628,7 @@ bool ScInterpreter::CalculateTest(bool _bTemplin
PushNoValue();
return false;
}
-fT = fabs(fSum1/fCount1 - fSum2/fCount2)/sqrt(fS1+fS2);
+fT = std::abs(fSum1/fCount1 - fSum2/fCount2)/sqrt(fS1+fS2);
double c = fS1/(fS1+fS2);
// GetTDist is calculated via GetBetaDist and also works with non-integral
// degrees of freedom. The result matches Excel
@@ -2639,7 +2639,7 @@ bool ScInterpreter::CalculateTest(bool _bTemplin
// according to Bronstein-Semendjajew
double fS1 = (fSumSqr1 - fSum1*fSum1/fCount1) / (fCount1 - 1.0);//
Variance
double fS2 = (fSumSqr2 - fSum2*fSum2/fCount2) / (fCount2 - 1.0);
-fT = fabs( fSum1/fCount1 - fSum2/fCount2 ) /
+fT = std::abs( fSum1/fCount1 - fSum2/fCount2 ) /
sqrt( (fCount1-1.0)*fS1 + (fCount2-1.0)*fS2 ) *
sqrt(
[Libreoffice-bugs] [Bug 142065] EDITING: Cut paste transposed with formula reference within range leads to #REF
https://bugs.documentfoundation.org/show_bug.cgi?id=142065 Scito changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |i...@scito.ch |desktop.org | CC||i...@scito.ch Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=68 ||976, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=71 ||058 Status|UNCONFIRMED |ASSIGNED --- Comment #1 from Scito --- I'll work on it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95328] Hybrid PDF -- implement PDF 1.4 level support for Embedded File Streams to expose ODF object stream as Attachment to the PDF document
https://bugs.documentfoundation.org/show_bug.cgi?id=95328 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2051 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66580] exported PDF is invalid because of forbidden custom keys in the trailer
https://bugs.documentfoundation.org/show_bug.cgi?id=66580 V Stuart Foote changed: What|Removed |Added CC||peter.maiw...@web.de --- Comment #19 from V Stuart Foote --- *** Bug 142051 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142051] Exported hybrid pdf not showing embedded Libreoffice file in pdf viewers
https://bugs.documentfoundation.org/show_bug.cgi?id=142051 V Stuart Foote changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=95 ||328 --- Comment #2 from V Stuart Foote --- dupe, and see also. *** This bug has been marked as a duplicate of bug 66580 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142065] New: EDITING: Cut paste transposed with formula reference within range leads to #REF
https://bugs.documentfoundation.org/show_bug.cgi?id=142065 Bug ID: 142065 Summary: EDITING: Cut paste transposed with formula reference within range leads to #REF Product: LibreOffice Version: 7.1.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@scito.ch Description: Cutting and transposing a range with formula reference within range leads to #REF in pasted formula. However, copying and transposing works correctly. Interestingly, cut and transpose, 1x undo 1x and 1x redo, then it works as well correctly. Steps to Reproduce: 1. Create new spread sheet. 2. Insert cells: A1: 1 B1: =A1+10 3. Select A1 and B1 4. Cut 5. Go to cell A3 6. Paste Actual Results: Cell A4 shows #REF and contains =#REF!2+10 Expected Results: Cell A4 shows 11 and contains =A3+10 (I.e. the same result as from copy and paste transposed is expected.) Reproducible: Always User Profile Reset: No Additional Info: I've discovered this bug while writing unit tests for bug 68976 and bug 71058. Creating a bug report for QA. Version: 7.1.1.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 4; OS: Linux 5.3; UI render: GL; VCL: kf5 Locale: de-CH (en_US.UTF-8); UI: de-DE Calc: threaded Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: aa38eede9d340cbb11a792ab1ebbe681521a4489 CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142022] Crash in: mergedlo.dll / on close
https://bugs.documentfoundation.org/show_bug.cgi?id=142022 --- Comment #23 from Julien Nabet --- I succeeded on building LO master sources on Win10. I use enable-dbgutil and tried with and without Clipboard history enable, not crash. Do you use any accessibility tools? If yes could you disable them and give a new try? Also, which locale setting and which language UI do you use? (Tools/Options/Language Settings/Languages). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141463] FILEOPEN DOCX Scale of group is wrongly applied to the childelements in the group
https://bugs.documentfoundation.org/show_bug.cgi?id=141463 Regina Henschel changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | --- Comment #6 from Regina Henschel --- Likely not an easy hack at all, but I have an idea and will try to fix it together with bug 141953. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134550] FILEOPEN: Large Spreadsheet Experimental XLSX Crash in: ScBroadcastAreaSlotMachine::StartListeningArea(ScRange const &, bool, SvtListener *)
https://bugs.documentfoundation.org/show_bug.cgi?id=134550 Julien Nabet changed: What|Removed |Added Attachment #162702|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134550] FILEOPEN: Large Spreadsheet Experimental XLSX Crash in: ScBroadcastAreaSlotMachine::StartListeningArea(ScRange const &, bool, SvtListener *)
https://bugs.documentfoundation.org/show_bug.cgi?id=134550 --- Comment #5 from Julien Nabet --- Created attachment 171619 --> https://bugs.documentfoundation.org/attachment.cgi?id=171619=edit bt with debug symbols Here's an updated bt with master sources updated today (still an assertion). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx starmath/inc starmath/source starmath/uiconfig svx/source
include/svx/weldeditview.hxx |2 +
starmath/inc/edit.hxx|1
starmath/source/edit.cxx | 48 +--
starmath/uiconfig/smath/ui/editwindow.ui |2 -
svx/source/dialog/weldeditview.cxx | 17 ++
5 files changed, 22 insertions(+), 48 deletions(-)
New commits:
commit 2de0eaf467715662e68b9429c9d5050f65ffcec9
Author: Caolán McNamara
AuthorDate: Sun May 2 20:15:42 2021 +0100
Commit: Caolán McNamara
CommitDate: Mon May 3 21:08:57 2021 +0200
There's no longer a purpose to the math horizontal scrollbar
since...
commit f89860807baaa901629ce2a814b7a6c994318fe5
Date: Sat Feb 13 16:43:01 2021 +0100
Resolves tdf#140221 auto-adjust Formula Editor width
so remove that.
And merge the starmath Resize logic into the baseclass, and emit
EditViewScrollStateChange from there.
The goal is that resizing the starmath window does not visually
horizontally scroll content negatively outside the widget
Change-Id: I1a79a0d5a194e8cfb0d2d2cb07b0b80172f1f66c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115012
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/include/svx/weldeditview.hxx b/include/svx/weldeditview.hxx
index c40a754a2fc8..65bc9c979bf3 100644
--- a/include/svx/weldeditview.hxx
+++ b/include/svx/weldeditview.hxx
@@ -61,6 +61,7 @@ protected:
void DoPaint(vcl::RenderContext& rRenderContext, const tools::Rectangle&
rRect);
+public:
virtual void Paint(vcl::RenderContext& rRenderContext, const
tools::Rectangle& rRect) override;
virtual bool MouseMove(const MouseEvent& rMEvt) override;
virtual bool MouseButtonDown(const MouseEvent& rMEvt) override;
@@ -78,6 +79,7 @@ protected:
void SetAcceptsTab(bool bAcceptsTab) { m_bAcceptsTab = bAcceptsTab; }
+protected:
virtual css::uno::Reference
CreateAccessible() override;
virtual void EditViewInvalidate(const tools::Rectangle& rRect) override {
Invalidate(rRect); }
diff --git a/starmath/inc/edit.hxx b/starmath/inc/edit.hxx
index 536885794c06..773355cfff14 100644
--- a/starmath/inc/edit.hxx
+++ b/starmath/inc/edit.hxx
@@ -110,7 +110,6 @@ public:
// Window
virtual void SetText(const OUString& rText) override;
virtual OUString GetText() const override;
-virtual void Resize() override;
virtual void Command(const CommandEvent& rCEvt) override;
ESelection GetSelection() const;
diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx
index ae9b6b7c61da..5287eeca9664 100644
--- a/starmath/source/edit.cxx
+++ b/starmath/source/edit.cxx
@@ -41,9 +41,6 @@
#include
#include "accessibility.hxx"
-#define SCROLL_LINE 24
-
-
using namespace com::sun::star::accessibility;
using namespace com::sun::star;
@@ -136,7 +133,6 @@ SmEditWindow::SmEditWindow(SmCmdBoxWindow )
// compare DataChanged
SetBackground( GetSettings().GetStyleSettings().GetWindowColor() );
-mxScrolledWindow->connect_hadjustment_changed(LINK(this, SmEditWindow,
ScrollHdl));
mxScrolledWindow->connect_vadjustment_changed(LINK(this, SmEditWindow,
ScrollHdl));
CreateEditView();
@@ -234,8 +230,7 @@ void SmEditWindow::DataChanged( const DataChangedEvent&
rDCEvt )
pEditEngine->Clear(); //incorrect font size
pEditEngine->SetText( aTxt );
-AdjustScrollBars();
-Resize();
+mxTextControl->Resize();
}
}
@@ -270,34 +265,6 @@ IMPL_LINK_NOARG(SmEditTextWindow, CursorMoveTimerHdl,
Timer *, void)
aCursorMoveIdle.Stop();
}
-void SmEditWindow::Resize()
-{
-InterimItemWindow::Resize();
-
-if (EditView* pEditView = GetEditView())
-{
-// Resizes the edit engine to adjust to the size of the output area
-const Size aSize( pEditView->GetOutputArea().GetSize() );
-pEditView->GetEditEngine()->SetPaperSize(aSize);
-
-pEditView->SetOutputArea(AdjustScrollBars());
-pEditView->ShowCursor();
-
-OSL_ENSURE( pEditView->GetEditEngine(), "EditEngine missing" );
-const tools::Long nMaxVisAreaStart =
pEditView->GetEditEngine()->GetTextHeight() -
- pEditView->GetOutputArea().GetHeight();
-if (pEditView->GetVisArea().Top() > nMaxVisAreaStart)
-{
-tools::Rectangle aVisArea(pEditView->GetVisArea() );
-aVisArea.SetTop( std::max(nMaxVisAreaStart, 0) );
-aVisArea.SetSize(pEditView->GetOutputArea().GetSize());
-pEditView->SetVisArea(aVisArea);
-pEditView->ShowCursor();
-}
-SetScrollBarRanges();
-}
-}
-
bool SmEditTextWindow::MouseButtonUp(const MouseEvent )
{
bool bRet = WeldEditView::MouseButtonUp(rEvt);
@@ -488,8 +455,7 @@ void SmEditWindow::CreateEditView()
IMPL_LINK_NOARG(SmEditTextWindow, EditStatusHdl, EditStatus&, void)
{
-if
[Libreoffice-bugs] [Bug 141953] FILEOPEN PPTX: 90deg basic rectangle rotation is missing for rotated shape in group
https://bugs.documentfoundation.org/show_bug.cgi?id=141953 Regina Henschel changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | --- Comment #8 from Regina Henschel --- The attached spreadsheet is still not correct. I will not attach a new one, but try a fix in code directly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142064] blank space added randomly when updating index
https://bugs.documentfoundation.org/show_bug.cgi?id=142064 mango wodzak changed: What|Removed |Added CC||mango.wod...@gmail.com --- Comment #1 from mango wodzak --- Created attachment 171618 --> https://bugs.documentfoundation.org/attachment.cgi?id=171618=edit cannot update TOC without adding pages. i'm unable to update the toc in this doc without causing extra pages to be added and upsetting the format of the book.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142060] Page styles not correctly assigned
https://bugs.documentfoundation.org/show_bug.cgi?id=142060 yves.van...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142064] New: blank space added randomly when updating index
https://bugs.documentfoundation.org/show_bug.cgi?id=142064 Bug ID: 142064 Summary: blank space added randomly when updating index Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mango.wod...@gmail.com Description: I have a 390 page document. When I update the index -T.O.C. the number of pages increases. Not always by the same amount, sometimes 402 pages, sometimes 404.. What happens within the document is that random paragraphs in the middle of a page, are moved to the beginning of a new page. thus the number of pages in the doc increases. This is very frustrating as I can no longer get my table of contents to match the actual page numbers of chapters and headings. Steps to Reproduce: 1. My .odt file is 390 pages. 2. I go to the T.O.C. right click, and press "update index" Actual Results: After updating the T.O.C, the .odt file becomes 400+ pages with some paragraphs moved to the top of a new page. With one document I have, this happens every single time I try to update the T.O.C.. IT DOES NOT HAPPEN ALWAYS WITH EVERY DOCUMENT, BUT SEEMS TO BE RELATED TO FRAMES PRESENT WITHIN THE DOCUMENT.. Expected Results: I Expect for the TOC to be updated, and for the number of pages to stay at 390 and not increase. Reproducible: Sometimes User Profile Reset: No Additional Info: Version: 7.1.2.2 (x64) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-AU (en_AU); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141566] Implement os/DE theme support in Basic Editor, allow for dark mode when used
https://bugs.documentfoundation.org/show_bug.cgi?id=141566 --- Comment #15 from Rafael Lima --- Created attachment 171617 --> https://bugs.documentfoundation.org/attachment.cgi?id=171617=edit Basic Editor Colors Heiko, you'll find in the attached file a suggestion of colors to be used in the Basic Editor in dark mode (screenshot and details in the ODG file) Identifier: dde8cb Comment: ee Number: ffa6a6 String: ffa6a6 Operator: b4c7dc Reserved Expression: b4c7dc Error: ff3838 These suggestions are based in the hardcoded document background color "33" used the the proposed patch. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141995] Removed command flash in customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=141995 Gabor Kelemen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142051] Exported hybrid pdf not showing embedded Libreoffice file in pdf viewers
https://bugs.documentfoundation.org/show_bug.cgi?id=142051 V Stuart Foote changed: What|Removed |Added Resolution|--- |NOTABUG CC||vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED --- Comment #1 from V Stuart Foote --- No, the LibreOffice project "Hybrid PDF" simply embeds an auxiliary stream into the PDF holding the ODF file. And *only* LibreOffice will open such a "Hybrid PDF" back into its ODF module component. Other PDF Readers can see the stream, but of course would not recognize that the PDF is a LibreOffice "Hybrid PDF"--and will ignore it and simply open the PDF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/wasm' - sfx2/Library_sfx.mk sfx2/util solenv/bin
sfx2/Library_sfx.mk | 17 +
sfx2/util/sfx.component |5 -
sfx2/util/sfx.extended.component | 27 +++
solenv/bin/native-code.py|2 +-
4 files changed, 41 insertions(+), 10 deletions(-)
New commits:
commit 90d9a8dee35a6b14d5c994ace756da77b182238f
Author: Armin Le Grand (Allotropia)
AuthorDate: Mon May 3 20:43:33 2021 +0200
Commit: Armin Le Grand (Allotropia)
CommitDate: Mon May 3 20:43:33 2021 +0200
BackingWindow (RecentDocsView) optional removal
Change-Id: I8a47f879069efed5e89c6bc2b0c3e2da2e20fdd1
diff --git a/sfx2/Library_sfx.mk b/sfx2/Library_sfx.mk
index f2fe7c708da7..7750e5247bdc 100644
--- a/sfx2/Library_sfx.mk
+++ b/sfx2/Library_sfx.mk
@@ -23,6 +23,10 @@ $(eval $(call
gb_Library_add_sdi_headers,sfx,sfx2/sdi/sfxslots))
$(eval $(call gb_Library_set_componentfile,sfx,sfx2/util/sfx))
+ifneq ($(ENABLE_WASM_STRIP),TRUE)
+$(eval $(call gb_Library_set_componentfile,sfx,sfx2/util/sfx.extended))
+endif
+
$(eval $(call
gb_Library_set_precompiled_header,sfx,sfx2/inc/pch/precompiled_sfx))
$(eval $(call gb_Library_use_custom_headers,sfx,\
@@ -77,6 +81,15 @@ $(eval $(call gb_Library_use_externals,sfx,\
orcus-parser\
))
+ifneq ($(ENABLE_WASM_STRIP),TRUE)
+$(eval $(call gb_Library_add_exception_objects,sfx,\
+sfx2/source/dialog/backingcomp \
+sfx2/source/dialog/backingwindow \
+sfx2/source/control/recentdocsview \
+sfx2/source/control/recentdocsviewitem \
+))
+endif
+
$(eval $(call gb_Library_add_exception_objects,sfx,\
sfx2/source/accessibility/AccessibilityCheck \
sfx2/source/accessibility/AccessibilityIssue \
@@ -141,8 +154,6 @@ $(eval $(call gb_Library_add_exception_objects,sfx,\
sfx2/source/control/msg \
sfx2/source/control/msgpool \
sfx2/source/control/objface \
-sfx2/source/control/recentdocsview \
-sfx2/source/control/recentdocsviewitem \
sfx2/source/control/request \
sfx2/source/control/sfxstatuslistener \
sfx2/source/control/shell \
@@ -170,8 +181,6 @@ $(eval $(call gb_Library_add_exception_objects,sfx,\
sfx2/source/devtools/DocumentModelTreeHandler \
sfx2/source/devtools/ObjectInspectorTreeHandler \
sfx2/source/dialog/alienwarn \
-sfx2/source/dialog/backingcomp \
-sfx2/source/dialog/backingwindow \
sfx2/source/dialog/basedlgs \
sfx2/source/dialog/checkin \
sfx2/source/dialog/dialoghelper \
diff --git a/sfx2/util/sfx.component b/sfx2/util/sfx.component
index a7c9930e0ec8..af29af66defd 100644
--- a/sfx2/util/sfx.component
+++ b/sfx2/util/sfx.component
@@ -19,11 +19,6 @@
http://openoffice.org/2010/uno-components;>
-
-
-
-
diff --git a/sfx2/util/sfx.extended.component b/sfx2/util/sfx.extended.component
new file mode 100644
index ..f501c997cba5
--- /dev/null
+++ b/sfx2/util/sfx.extended.component
@@ -0,0 +1,27 @@
+
+
+
+http://openoffice.org/2010/uno-components;>
+
+
+
+
+
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 178d6f7fa47f..063c2729533b 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -770,7 +770,7 @@ desktop_constructor_list = [
"com_sun_star_comp_graphic_GraphicProvider_get_implementation",
"com_sun_star_comp_office_FrameLoader_get_implementation",
"com_sun_star_comp_sfx2_AppDispatchProvider_get_implementation",
-"com_sun_star_comp_sfx2_BackingComp_get_implementation",
+("com_sun_star_comp_sfx2_BackingComp_get_implementation", "#ifndef
ENABLE_WASM_STRIP"),
"com_sun_star_comp_sfx2_GlobalEventBroadcaster_get_implementation",
"com_sun_star_comp_sfx2_InsertSymbolToolBoxControl_get_implementation",
"com_sun_star_comp_sfx2_InsertSymbolToolBoxControl_get_implementation",
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9b1b29325ba988e5307a34d234cf6ba17e4350ec Author: Alain Romedenne AuthorDate: Mon May 3 20:29:10 2021 +0200 Commit: Gerrit Code Review CommitDate: Mon May 3 20:29:10 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to c5a46fef4b734a0f3a9754d0e158fd322db44ff6 - Fix Typo Change-Id: Ia9ede74f44fb9bc500916c7bbd2a66e51b7685d5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114923 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure Reviewed-by: Rafael Lima diff --git a/helpcontent2 b/helpcontent2 index f8bb58500148..c5a46fef4b73 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit f8bb58500148b126c2730977d566e7fa315439b0 +Subproject commit c5a46fef4b734a0f3a9754d0e158fd322db44ff6 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/03/lib_ScriptForge.xhp |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit c5a46fef4b734a0f3a9754d0e158fd322db44ff6 Author: Alain Romedenne AuthorDate: Mon May 3 13:52:40 2021 +0200 Commit: Rafael Lima CommitDate: Mon May 3 20:29:10 2021 +0200 Fix Typo Change-Id: Ia9ede74f44fb9bc500916c7bbd2a66e51b7685d5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114923 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure Reviewed-by: Rafael Lima diff --git a/source/text/sbasic/shared/03/lib_ScriptForge.xhp b/source/text/sbasic/shared/03/lib_ScriptForge.xhp index f3aa899f2..522fb1e83 100644 --- a/source/text/sbasic/shared/03/lib_ScriptForge.xhp +++ b/source/text/sbasic/shared/03/lib_ScriptForge.xhp @@ -76,16 +76,15 @@ Base - Basic Calc - Database + Database Document Form - FormControl + FormControl @@ -110,13 +109,14 @@ + Basic L10N Platform - Services + Services Session Timer ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Parameter for addShape for a child of a group in oox import
Hi Miklos,
answer below.
Miklos Vajna schrieb am 03.05.2021 um 15:47:
Hi Regina,
On Fri, Apr 30, 2021 at 04:39:41PM +0200, Regina Henschel
wrote:
So I still need a way to transport the values from the group to its
children. Besides my first idea to put all group infos into a struct and use
that instead of the aTransformation parameter, I can also think to put them
into the grabbag of each child.
The primary purpose of the grabbag property of shapes is to carry
information from the importer to the exporter, when the document model
doesn't handle some information. So if you can solve this without
grabbags, that would be nice. >
Such transport of information from group to child is also needed, if e.g. 3D
transformations are not made on the individual shapes but on the group.
MSOffice allows to apply attributes to the group and writes it that way to
file, but LibreOffice has no attributes on groups.
Yes, that's what I recall as well, our group shape is just a container
of shapes.
I'm still interested in you opinion how to design it.
oox/ code creates oox::drawing::Shape instances, then once all of them
is created, it turns them into XShapes ("creates and inserts them").
Do you think it would be possible to improve
oox::drawingml::Shape::createAndInsert(), so that it would get not only
the parent transform but also the parent oox::drawing::Shape? If that
would work, then setChildPosition() and setChildSize() already stores
chOff/chExt values on the parent, and you could access the needed
information.
That means, I do not sent the information to the child, but the child
fetches it from the parent. I like your idea.
Shape::addChildren() is called with a reference to the group shape. So
there the parent shape is known. It does not call
Shape::createAndInsert() directly, but calls Shape::addShape(), which
then calls Shape::createAndInsert().
So add a pointer to addShape() and to createAndInsert()? If they are
called first time, it would be a nullptr. Such pointer could likely
replace the 'bInGroup' parameter.
The parameter aTransformation in addShape() is still needed, because it
cumulates the transformations in case there are nested groups.
If this doesn't work, then the above grabbag way is also acceptable (I
would say), just less nice: what you set there will stay around even
after the import finished and nobody needs that.
I will try it without grabBag.
I'm confident about the needed calculations themselves in the meantime.
At least my manually calculations in a spreadsheet show the correct
position and size now for the shapes in case of nested groups too. But
it will take me a while to translate the principle solution into code.
Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 142057] Improvement to User Interface Variants
https://bugs.documentfoundation.org/show_bug.cgi?id=142057 V Stuart Foote changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Sorry, don't see how this might change or improve things in any sense. And, remember that these labels must be "localized" along with the rest of the user interface. IMHO -1, and => WF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 142057] Improvement to User Interface Variants
https://bugs.documentfoundation.org/show_bug.cgi?id=142057 V Stuart Foote changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Sorry, don't see how this might change or improve things in any sense. And, remember that these labels must be "localized" along with the rest of the user interface. IMHO -1, and => WF -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/csv/tdf48731.csv | 15 +++
sc/qa/unit/subsequent_filters-test.cxx | 30 ++
2 files changed, 45 insertions(+)
New commits:
commit 6ba33f724986752ceffa27b4928d140a4b948ca7
Author: Xisco Fauli
AuthorDate: Mon May 3 16:57:00 2021 +0200
Commit: Xisco Fauli
CommitDate: Mon May 3 19:54:21 2021 +0200
tdf#48731: sc_subsequent_filters: Add unittest
Change-Id: I8d3804d78f6005a594937fbdc92fa99dae70a3f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115043
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/data/csv/tdf48731.csv b/sc/qa/unit/data/csv/tdf48731.csv
new file mode 100644
index ..c0353427ced3
--- /dev/null
+++ b/sc/qa/unit/data/csv/tdf48731.csv
@@ -0,0 +1,15 @@
+WITHOUT QUOTES
+1 apostrophe,'
+2 apostrophes,''
+3 apostrophes,'''
+A number,'3
+A word,'word
+A misspelled word,'mword
+
+WITH QUOTES
+1 apostrophe,"'"
+2 apostrophes,"''"
+3 apostrophes,"'''"
+A number,"'3"
+A word,"'word"
+A misspelled word,"'mword"
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index 5bdea80d8361..a854f49f0774 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -110,6 +110,7 @@ public:
//ods, xls, xlsx filter tests
void testCondFormatOperatorsSameRangeXLSX();
void testTdf119292();
+void testTdf48731();
void testCondFormatFormulaIsXLSX();
void testCondFormatBeginsAndEndsWithXLSX();
void testExtCondFormatXLSX();
@@ -319,6 +320,7 @@ public:
CPPUNIT_TEST_SUITE(ScFiltersTest);
CPPUNIT_TEST(testCondFormatOperatorsSameRangeXLSX);
CPPUNIT_TEST(testTdf119292);
+CPPUNIT_TEST(testTdf48731);
CPPUNIT_TEST(testCondFormatFormulaIsXLSX);
CPPUNIT_TEST(testCondFormatBeginsAndEndsWithXLSX);
CPPUNIT_TEST(testExtCondFormatXLSX);
@@ -638,6 +640,34 @@ void ScFiltersTest::testTdf119292()
xDocSh->DoClose();
}
+void ScFiltersTest::testTdf48731()
+{
+ScDocShellRef xDocSh = loadDoc(u"tdf48731.", FORMAT_CSV);
+CPPUNIT_ASSERT_MESSAGE("Failed to load document", xDocSh.is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+CPPUNIT_ASSERT_EQUAL(OUString("'"), rDoc.GetString(1, 1, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("''"), rDoc.GetString(1, 2, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("'''"), rDoc.GetString(1, 3, 0));
+
+// Without the fix in place, this test would have failed with
+// - Expected: '3
+// - Actual : 3
+CPPUNIT_ASSERT_EQUAL(OUString("'3"), rDoc.GetString(1, 4, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("'word"), rDoc.GetString(1, 5, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("'mword"), rDoc.GetString(1, 6, 0));
+
+CPPUNIT_ASSERT_EQUAL(OUString("'"), rDoc.GetString(1, 9, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("''"), rDoc.GetString(1, 10, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("'''"), rDoc.GetString(1, 11, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("'3"), rDoc.GetString(1, 12, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("'word"), rDoc.GetString(1, 13, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("'mword"), rDoc.GetString(1, 14, 0));
+
+xDocSh->DoClose();
+}
+
void ScFiltersTest::testCondFormatFormulaIsXLSX()
{
ScDocShellRef xDocSh = loadDoc(u"tdf113013.", FORMAT_XLSX);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr6.cxx |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
New commits:
commit 9a71644aa475a6090f60a8b90665116b98851b9c
Author: Eike Rathke
AuthorDate: Mon May 3 17:07:39 2021 +0200
Commit: Eike Rathke
CommitDate: Mon May 3 19:39:33 2021 +0200
RAWSUBTRACT() process arguments from left to right
RAWSUBTRACT(1;2;3;4) calculated 1-4-3-2, popping from stack.
Reverse stack to calculate 1-2-3-4 in "natural" left to right
order.
That may make a difference like in
=RAWSUBTRACT(0.3;0.2;0.1;-0.1;-0.2;0.3)
where the result was 2.77555756156289E-17
(0.3-0.3--0.2--0.1-0.1-0.2) == (0.0--0.2--0.1-0.1-0.2)
same as =RAWSUBTRACT(0;0.2;0.1;-0.1;-0.2)
and now is 0
(0.3-0.2-0.1--0.1--0.2-0.3)
but =RAWSUBTRACT(0;0.2;0.1;-0.1;-0.2)
now is -2.77555756156289E-17
Change-Id: If00d88e3d3d1944a3d9a6b4576b773afe9cbd294
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115047
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/core/tool/interpr6.cxx b/sc/source/core/tool/interpr6.cxx
index a48d7d3ad77b..0e2824ef1f2e 100644
--- a/sc/source/core/tool/interpr6.cxx
+++ b/sc/source/core/tool/interpr6.cxx
@@ -995,17 +995,15 @@ void ScInterpreter::ScRawSubtract()
if (!MustHaveParamCountMin( nParamCount, 2))
return;
-// Fish the 1st parameter from the stack and push it on top.
-const FormulaToken* p = pStack[ sp - nParamCount ];
-PushWithoutError( *p );
+// Reverse stack to process arguments from left to right.
+ReverseStack( nParamCount);
// Obtain the minuend.
double fRes = GetDouble();
-while (nGlobalError == FormulaError::NONE && nParamCount > 1)
+while (nGlobalError == FormulaError::NONE && --nParamCount > 0)
{
// Simple single values without matrix support.
fRes -= GetDouble();
---nParamCount;
}
while (nParamCount-- > 0)
PopError();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142043] Correct spelling wrongly flagged
https://bugs.documentfoundation.org/show_bug.cgi?id=142043 Uwe Auer changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Uwe Auer --- repro Version: 7.1.3.2 / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded when using text language "English (UK)", while the word is not flagged incorrect, when using text language "English (US)". According to: https://dictionary.cambridge.org/dictionary/english/disconcerting the word "disconcerting" is spelled correct in UK English. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141571] Base crashed on creation of user function
https://bugs.documentfoundation.org/show_bug.cgi?id=141571 --- Comment #6 from Uwe Grasshoff --- Is there any timeline when this bug will be fixed? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142063] New: Writer and Calc macro problems with update to LO 7.1.2.2
https://bugs.documentfoundation.org/show_bug.cgi?id=142063 Bug ID: 142063 Summary: Writer and Calc macro problems with update to LO 7.1.2.2 Product: LibreOffice Version: 7.1.2.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lg7896-li...@usa.net Description: I'm in the position of [this OP](https://ask.libreoffice.org/en/question/207552/how-can-i-import-a-macro-bas-file-into-calc/?answer=307533#post-id-307533). The answer included the statement **"Installing a new version of LO should have no effect on macros."** Three notes. 1) I've updated before, and the statement above has been true. Very good to be able to rely on that. 2) I just updated to 7.1.2.2 (x64), Win 10, and I lost ALL my macros and assigned keystrokes. Luckily I had a *.bas file from Nov 2020. **The process in that answer worked.** But I had to reassign my keystrokes, and all changes since then are lo, And if I hadn't exported to bas in Nov I'd have to go back even further. I'd much rather avoid this. 3) So far, I can't save **one macro** that sets a date **to Ctrl-Shft-T in Writer** (to start a journal entry) and save **a different macro** that puts a date in a cell **to Ctrl-Shft-T in Calc**. I used to be able to do this, and it was good since conceptually they do the same thing (date an entry). Now after setting one in Writer (Writer radio button is set), when I switch to Calc the same macro appears even though the Calc radio button is set. If I choose the macro I designed for Calc, the Writer one is replaced in Writer. I can use different keystrokes for Calc/Writer and be sure to manually back up all my macros before updating. But (a) #2 above isn't great, and (b) my old functionality in #3 above used to work, which seems intentional because of the radio buttons. Steps to Reproduce: 1. create 2 user macros in an earlier version and assign one to CTRL-SHFT-T in writer and the other to CTRL-SHFT-T in Calc. 2. save the macros in a *.bas file. 3. Update to 7.1.2.2 4. All macros and keystroke assignments were gone for me 5. Import the macros created in #1. 6. Assign macro A to CTRL-CHFT-T in Calc. Radio button for Calc should be showing. (I didn't see one for Writer.) 7. Assign macro B to CTRL-CHFT-T in Writer. Radio button for Writer should be showing. (I didn't see one for Calc.) 8. In Calc, check the keystroke assignment -- it should show macro B. Actual Results: Different macros can't be assigned to the same keystroke combination in Calc and Writer. Expected Results: ? I used to be able to update without losing macros and key assignments. I used to be able to assign different macros to the same keystroke combination in Calc and Writer. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: 7.1.2.2 (x64) build https://git.libreoffice.org/core/+log/8a45595d069ef5570103caea1b71cc9d82b2aae4 cpu threads 12 O/S win 10 bulid 19041 interface UI render SkiaVulkan; VCL; win locale: en-US; UI en-US Below: "When noticing strange behavior in LibreOffice the first thing to do is to reset the user profile. To do so, 2 methods are available." Please put those steps somewhere Earlier in this reporting process. I'm a user, not a programmer. I've already lost 1 1/2 hours to researching and finding a workaround for these problems. This included searching the web for how to import *.bas, since the topic doesn't seem to be in the online help system. I don't have that kind of time. Rather than installing something for opengl (if I need to) and rebooting my system for the profile and entering all this information again, I'm going to submit without it. Sorry, but I have other things I need to do. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141867] Explain "Type" and "Insert Reference To" elements with tooltips
https://bugs.documentfoundation.org/show_bug.cgi?id=141867 --- Comment #2 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #1) > Tooltips are good to explain very short labels but must not replace the help. Agreed, but those are short labels, which could use a 1-sentence/2-sentence explanation. Not suggesting anything beyond that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 141867] Explain "Type" and "Insert Reference To" elements with tooltips
https://bugs.documentfoundation.org/show_bug.cgi?id=141867 --- Comment #2 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #1) > Tooltips are good to explain very short labels but must not replace the help. Agreed, but those are short labels, which could use a 1-sentence/2-sentence explanation. Not suggesting anything beyond that. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 104174] Loss of formatting on Pivot Tables after refreshing data
https://bugs.documentfoundation.org/show_bug.cgi?id=104174 s5t1e3v4e3...@hotmail.com changed: What|Removed |Added CC||s5t1e3v4e3...@hotmail.com --- Comment #7 from s5t1e3v4e3...@hotmail.com --- https://bugs.documentfoundation.org/show_bug.cgi?id=41645 talks about conditional formatting only, but aren't those 2 related? (I understand that any formatting on a pivot table is lost on refresh.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142029] EDITING FORMATTING Hidden columns revert to not hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=142029 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Please what file format do you use to save? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142045] Text database does not load source.CSV (filetype written in CAPS)
https://bugs.documentfoundation.org/show_bug.cgi?id=142045 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- I can't repro Version: 7.1.3.1 (x64) / LibreOffice Community Build ID: fa76d07d7006a0e2866c3247cef2d5eb55ae8369 CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142042] When auto filter is used, the output result is abnormal
https://bugs.documentfoundation.org/show_bug.cgi?id=142042 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from m.a.riosv --- Please attach a minimal sample file for test. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142056] EDITING of existing cell content via input line is no longer possible
https://bugs.documentfoundation.org/show_bug.cgi?id=142056 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode I have no issue with that, 7.1.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source
filter/source/textfilterdetect/filterdetect.cxx | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
New commits:
commit dff586735b6618d9b011823594a33287d8f7f223
Author: Mike Kaganski
AuthorDate: Mon May 3 17:04:04 2021 +0200
Commit: Mike Kaganski
CommitDate: Mon May 3 18:38:38 2021 +0200
tdf#123476: also use filter by extension when its service is the same
... as passed explicitly in the media descriptor, for 0-byte files.
This makes proper handling for such files when passing module name
in command line, like --writer for DOCX.
Change-Id: If8fd51e65dcf8a67b2653026f5fc1d5c964074af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114924
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/filter/source/textfilterdetect/filterdetect.cxx
b/filter/source/textfilterdetect/filterdetect.cxx
index 09efe5e595e0..19696ec9fa17 100644
--- a/filter/source/textfilterdetect/filterdetect.cxx
+++ b/filter/source/textfilterdetect/filterdetect.cxx
@@ -135,7 +135,7 @@ bool IsHTMLStream( const uno::Reference&
xInStream )
* writes the type name to rType, the filter name to rMediaDesc.
*/
bool HandleEmptyFileUrlByExtension(MediaDescriptor& rMediaDesc, const
OUString& rExt,
- OUString& rType)
+ OUString& rType, OUString& rService)
{
OUString aURL =
rMediaDesc.getUnpackedValueOrDefault(MediaDescriptor::PROP_URL(), OUString());
if (!tools::isEmptyFileUrl(aURL))
@@ -156,6 +156,7 @@ bool HandleEmptyFileUrlByExtension(MediaDescriptor&
rMediaDesc, const OUString&
rMediaDesc[MediaDescriptor::PROP_FILTERNAME()] <<=
pFilter->GetFilterName();
rType = pFilter->GetTypeName();
+rService = pFilter->GetServiceName();
return true;
}
}
@@ -216,14 +217,25 @@ OUString SAL_CALL
PlainTextFilterDetect::detect(uno::Sequencehttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142044] problem with slide transition effects
https://bugs.documentfoundation.org/show_bug.cgi?id=142044 Harshita Nag changed: What|Removed |Added Ever confirmed|1 |0 CC||nagharshit...@gmail.com Status|NEW |UNCONFIRMED --- Comment #3 from Harshita Nag --- Can't reproduce this. Version: 7.1.2.2 / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threade -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142044] problem with slide transition effects
https://bugs.documentfoundation.org/show_bug.cgi?id=142044 Harshita Nag changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Harshita Nag --- Yes, I can confirm this bug. Version: 7.1.2.2 / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97157] Particular XLS with macro/forms very slow to open
https://bugs.documentfoundation.org/show_bug.cgi?id=97157 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #20 from Roman Kuznetsov <79045_79...@mail.ru> --- 22 sec with Macro security - low in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 9c930c4f3109d123c0831d0fcecf9c8b32e5bbc7 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142062] New: LibreOffice Impress 7.0.5.2 does not play videos, UI unless you open the slide with the video first in the Normal View
https://bugs.documentfoundation.org/show_bug.cgi?id=142062 Bug ID: 142062 Summary: LibreOffice Impress 7.0.5.2 does not play videos, UI unless you open the slide with the video first in the Normal View Product: LibreOffice Version: 7.0.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: christian.kle...@controllab.nl Description: LibreOffice Impress 7.0.5.2 does not play video, not in Media Playback and not in slide show. Tested with Windows 10 PC and Windows 10 laptop (same result) I use VLC media player. Also installed K-Lite Tested with .wmv .m4v .mp4 .webm test videos and all play well when selected from File Explorer but not in Impress I tried running in safe mode and resetting to factory settings. Does not help. The only trick that works is to open Steps to Reproduce: 1.Make presentation with first slide (some title) and second slide with video 2. Media Playback does not play (video stays frozen) 3. Store presentation and reopen 4. Click F5 and go to page with movie (video stays frozen) 5. Click Esc to stop presentation and (in Normal View) go to slide with video 6. Click F5 and go to page with movie (now the video will play) Actual Results: video stays frozen after opening first time, will only play if you open the page with video in Normal View Expected Results: video starts playing first time Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: The video play function has started deteriorating from Libre Office version 6. I was always able to play .wmv files without problems but even this has started to become troubling. When a video is played on my second screen, a mouse click may make the presentation go to the next slide or halt (and make impress crash). This makes Impress 7 too buggy to use for important presentations. I did use Impress 5 without problems like that and am considering to go back to that version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 141986] Improve current LO Application Colors theme handling to support a LibreOffice "dark" color scheme mode
https://bugs.documentfoundation.org/show_bug.cgi?id=141986 --- Comment #4 from V Stuart Foote --- @Heiko, good start. Didn't we recently do away with the need to decimal code the colors? So, the "2364108" could/should be "2412CC", or was that just Dante for the sm modules... Also, in the rendering of your 1st patch, attachment 171611, the comments are laid out on a non-theme controlled frame so onto that hardcoded lightgray value. Also, the Table cells are an uncontrolled white background, with a balck fg font--that's an issue. Likewise the Chart axis labeling seems uncontrolled black fg font. I'm sure there are other places the os/DE theme and current Application Colors do not touch--and will need some dev attention more than just a new set of colors defined in UI.xcu Some logic to control the icon themes (based on fg / bg colors) of the ColorTheme as well? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
