[Libreoffice-bugs] [Bug 143696] Development Tools - Minor glitches and improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=143696 Tomaz Vajngerl changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Tomaz Vajngerl --- 1) All dialogs have a help button, but panels don't have. Anyway - sure can add. 2) The "page n" naming is not part of DevTools, but uses the "Name" property of the Slide/Page object and for some reason the name is "page n" and not "slide n" (most likely because the object is SdDrawPage and we don't have a special case when it represents slides. 3) Renamed... to "Name", which is more consistent how other columns are named. 4) Right, the problem is the order is alphabetical, so the indices should prepend 0 to be able to sort them correctly. 5) Yes, sounds like a bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmWriter.hxx|1 + vcl/source/filter/svm/SvmWriter.cxx | 23 +++ 2 files changed, 24 insertions(+) New commits: commit 0c7cc718cd952e39957037e7fda3ac96e32b6d61 Author: panoskorovesis AuthorDate: Mon Aug 2 20:13:03 2021 +0300 Commit: Tomaž Vajngerl CommitDate: Tue Aug 3 04:51:49 2021 +0200 Add Handler for TextLine Write The handler separates MetaTextLineAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: Iff1f22618d60f8f037a820ea2a03082b3a3bc926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119903 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx index b4cc85cad7d3..9c1cd0d1d23b 100644 --- a/include/vcl/filter/SvmWriter.hxx +++ b/include/vcl/filter/SvmWriter.hxx @@ -55,4 +55,5 @@ public: void TextArrayHandler(MetaTextArrayAction* pAction, ImplMetaWriteData* pData); void StretchTextHandler(MetaStretchTextAction* pAction, ImplMetaWriteData* pData); void TextRectHandler(MetaTextRectAction* pAction, ImplMetaWriteData* pData); +void TextLineHandler(MetaTextLineAction* pAction); }; \ No newline at end of file diff --git a/vcl/source/filter/svm/SvmWriter.cxx b/vcl/source/filter/svm/SvmWriter.cxx index bf8fe01ad0c3..e3d6f3b4e791 100644 --- a/vcl/source/filter/svm/SvmWriter.cxx +++ b/vcl/source/filter/svm/SvmWriter.cxx @@ -190,6 +190,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, ImplMetaWriteData* pData) } break; +case MetaActionType::TEXTLINE: +{ +auto* pMetaAction = static_cast(pAction); +TextLineHandler(pMetaAction); +} +break; + /* default case prevents test failure and will be removed once all the handlers are completed */ default: @@ -425,4 +432,20 @@ void SvmWriter::TextRectHandler(MetaTextRectAction* pAction, ImplMetaWriteData* write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 } + +void SvmWriter::TextLineHandler(MetaTextLineAction* pAction) +{ +mrStream.WriteUInt16(static_cast(pAction->GetType())); + +VersionCompatWrite aCompat(mrStream, 2); + +TypeSerializer aSerializer(mrStream); +aSerializer.writePoint(pAction->GetStartPoint()); + +mrStream.WriteInt32(pAction->GetWidth()); +mrStream.WriteUInt32(pAction->GetStrikeout()); +mrStream.WriteUInt32(pAction->GetUnderline()); +// new in version 2 +mrStream.WriteUInt32(pAction->GetOverline()); +} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmWriter.hxx|1 + vcl/source/filter/svm/SvmWriter.cxx | 20 2 files changed, 21 insertions(+) New commits: commit 4dad280b76853956d44d301c60c48f032fda0831 Author: panoskorovesis AuthorDate: Mon Aug 2 20:11:03 2021 +0300 Commit: Tomaž Vajngerl CommitDate: Tue Aug 3 04:51:13 2021 +0200 Add Handler for TextRect Write The handler separates MetaTextRectAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I4827df579bb866dcb3f40d22387a1c0a24fde210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119902 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx index d42780b828af..b4cc85cad7d3 100644 --- a/include/vcl/filter/SvmWriter.hxx +++ b/include/vcl/filter/SvmWriter.hxx @@ -54,4 +54,5 @@ public: void TextHandler(MetaTextAction* pAction, ImplMetaWriteData* pData); void TextArrayHandler(MetaTextArrayAction* pAction, ImplMetaWriteData* pData); void StretchTextHandler(MetaStretchTextAction* pAction, ImplMetaWriteData* pData); +void TextRectHandler(MetaTextRectAction* pAction, ImplMetaWriteData* pData); }; \ No newline at end of file diff --git a/vcl/source/filter/svm/SvmWriter.cxx b/vcl/source/filter/svm/SvmWriter.cxx index 830013b357b4..bf8fe01ad0c3 100644 --- a/vcl/source/filter/svm/SvmWriter.cxx +++ b/vcl/source/filter/svm/SvmWriter.cxx @@ -183,6 +183,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, ImplMetaWriteData* pData) } break; +case MetaActionType::TEXTRECT: +{ +auto* pMetaAction = static_cast(pAction); +TextRectHandler(pMetaAction, pData); +} +break; + /* default case prevents test failure and will be removed once all the handlers are completed */ default: @@ -405,4 +412,17 @@ void SvmWriter::StretchTextHandler(MetaStretchTextAction* pAction, ImplMetaWrite write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 } + +void SvmWriter::TextRectHandler(MetaTextRectAction* pAction, ImplMetaWriteData* pData) +{ +mrStream.WriteUInt16(static_cast(pAction->GetType())); + +VersionCompatWrite aCompat(mrStream, 2); +TypeSerializer aSerializer(mrStream); +aSerializer.writeRectangle(pAction->GetRect()); +mrStream.WriteUniOrByteString(pAction->GetText(), pData->meActualCharSet); +mrStream.WriteUInt16(static_cast(pAction->GetStyle())); + +write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 +} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmWriter.hxx|1 + vcl/source/filter/svm/SvmWriter.cxx | 22 ++ 2 files changed, 23 insertions(+) New commits: commit 04073bc1b53a8e2b7376c1a40c02c60adc69fde0 Author: panoskorovesis AuthorDate: Mon Aug 2 20:07:36 2021 +0300 Commit: Tomaž Vajngerl CommitDate: Tue Aug 3 04:50:33 2021 +0200 Add Handler for StretchText Write The handler separates MetaStretchTextAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I1e5df474921796c064aa83406356b38bd2431451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119901 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx index 2b6f8f9db997..d42780b828af 100644 --- a/include/vcl/filter/SvmWriter.hxx +++ b/include/vcl/filter/SvmWriter.hxx @@ -53,4 +53,5 @@ public: void PolyPolygonHandler(MetaPolyPolygonAction* pAction); void TextHandler(MetaTextAction* pAction, ImplMetaWriteData* pData); void TextArrayHandler(MetaTextArrayAction* pAction, ImplMetaWriteData* pData); +void StretchTextHandler(MetaStretchTextAction* pAction, ImplMetaWriteData* pData); }; \ No newline at end of file diff --git a/vcl/source/filter/svm/SvmWriter.cxx b/vcl/source/filter/svm/SvmWriter.cxx index e51ea797aceb..830013b357b4 100644 --- a/vcl/source/filter/svm/SvmWriter.cxx +++ b/vcl/source/filter/svm/SvmWriter.cxx @@ -176,6 +176,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, ImplMetaWriteData* pData) } break; +case MetaActionType::STRETCHTEXT: +{ +auto* pMetaAction = static_cast(pAction); +StretchTextHandler(pMetaAction, pData); +} +break; + /* default case prevents test failure and will be removed once all the handlers are completed */ default: @@ -383,4 +390,19 @@ void SvmWriter::TextArrayHandler(MetaTextArrayAction* pAction, ImplMetaWriteData write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 } + +void SvmWriter::StretchTextHandler(MetaStretchTextAction* pAction, ImplMetaWriteData* pData) +{ +mrStream.WriteUInt16(static_cast(pAction->GetType())); + +VersionCompatWrite aCompat(mrStream, 2); +TypeSerializer aSerializer(mrStream); +aSerializer.writePoint(pAction->GetPoint()); +mrStream.WriteUniOrByteString(pAction->GetText(), pData->meActualCharSet); +mrStream.WriteUInt32(pAction->GetWidth()); +mrStream.WriteUInt16(pAction->GetIndex()); +mrStream.WriteUInt16(pAction->GetLen()); + +write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 +} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmWriter.hxx|1 + vcl/source/filter/svm/SvmWriter.cxx | 29 + 2 files changed, 30 insertions(+) New commits: commit 46377cb8abcc20fd083c981b2e14ebc4ba78804a Author: panoskorovesis AuthorDate: Mon Aug 2 20:05:21 2021 +0300 Commit: Tomaž Vajngerl CommitDate: Tue Aug 3 04:50:00 2021 +0200 Add Handler for TextArray Write The handler separates MetaTextArrayAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I5543957d01c5f2c7d2bf4a56a8a51f9d0330e07d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119900 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx index 0fd822e86c6a..2b6f8f9db997 100644 --- a/include/vcl/filter/SvmWriter.hxx +++ b/include/vcl/filter/SvmWriter.hxx @@ -52,4 +52,5 @@ public: void PolygonHandler(MetaPolygonAction* pAction); void PolyPolygonHandler(MetaPolyPolygonAction* pAction); void TextHandler(MetaTextAction* pAction, ImplMetaWriteData* pData); +void TextArrayHandler(MetaTextArrayAction* pAction, ImplMetaWriteData* pData); }; \ No newline at end of file diff --git a/vcl/source/filter/svm/SvmWriter.cxx b/vcl/source/filter/svm/SvmWriter.cxx index 32c7144010b9..e51ea797aceb 100644 --- a/vcl/source/filter/svm/SvmWriter.cxx +++ b/vcl/source/filter/svm/SvmWriter.cxx @@ -169,6 +169,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, ImplMetaWriteData* pData) } break; +case MetaActionType::TEXTARRAY: +{ +auto* pMetaAction = static_cast(pAction); +TextArrayHandler(pMetaAction, pData); +} +break; + /* default case prevents test failure and will be removed once all the handlers are completed */ default: @@ -354,4 +361,26 @@ void SvmWriter::TextHandler(MetaTextAction* pAction, ImplMetaWriteData* pData) write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 } + +void SvmWriter::TextArrayHandler(MetaTextArrayAction* pAction, ImplMetaWriteData* pData) +{ +mrStream.WriteUInt16(static_cast(pAction->GetType())); + +tools::Long* aArray = pAction->GetDXArray(); + +const sal_Int32 nAryLen = aArray ? pAction->GetLen() : 0; + +VersionCompatWrite aCompat(mrStream, 2); +TypeSerializer aSerializer(mrStream); +aSerializer.writePoint(pAction->GetPoint()); +mrStream.WriteUniOrByteString(pAction->GetText(), pData->meActualCharSet); +mrStream.WriteUInt16(pAction->GetIndex()); +mrStream.WriteUInt16(pAction->GetLen()); +mrStream.WriteInt32(nAryLen); + +for (sal_Int32 i = 0; i < nAryLen; ++i) +mrStream.WriteInt32(aArray[i]); + +write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 +} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmWriter.hxx|1 + vcl/source/filter/svm/SvmWriter.cxx | 21 + 2 files changed, 22 insertions(+) New commits: commit e3e0efb732b1f17ca9db50809d39eecc68961e0b Author: panoskorovesis AuthorDate: Mon Aug 2 20:01:32 2021 +0300 Commit: Tomaž Vajngerl CommitDate: Tue Aug 3 04:49:32 2021 +0200 Add Handler for Text Write The handler separates MetaTextAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: Ibc2b83802e74a2d7923ebfb45036751e9f012ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119899 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx index f4019899c5ce..0fd822e86c6a 100644 --- a/include/vcl/filter/SvmWriter.hxx +++ b/include/vcl/filter/SvmWriter.hxx @@ -51,4 +51,5 @@ public: void PolyLineHandler(MetaPolyLineAction* pAction); void PolygonHandler(MetaPolygonAction* pAction); void PolyPolygonHandler(MetaPolyPolygonAction* pAction); +void TextHandler(MetaTextAction* pAction, ImplMetaWriteData* pData); }; \ No newline at end of file diff --git a/vcl/source/filter/svm/SvmWriter.cxx b/vcl/source/filter/svm/SvmWriter.cxx index fc4945274d6e..32c7144010b9 100644 --- a/vcl/source/filter/svm/SvmWriter.cxx +++ b/vcl/source/filter/svm/SvmWriter.cxx @@ -162,6 +162,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, ImplMetaWriteData* pData) } break; +case MetaActionType::TEXT: +{ +auto* pMetaAction = static_cast(pAction); +TextHandler(pMetaAction, pData); +} +break; + /* default case prevents test failure and will be removed once all the handlers are completed */ default: @@ -333,4 +340,18 @@ void SvmWriter::PolyPolygonHandler(MetaPolyPolygonAction* pAction) } } } + +void SvmWriter::TextHandler(MetaTextAction* pAction, ImplMetaWriteData* pData) +{ +mrStream.WriteUInt16(static_cast(pAction->GetType())); + +VersionCompatWrite aCompat(mrStream, 2); +TypeSerializer aSerializer(mrStream); +aSerializer.writePoint(pAction->GetPoint()); +mrStream.WriteUniOrByteString(pAction->GetText(), pData->meActualCharSet); +mrStream.WriteUInt16(pAction->GetIndex()); +mrStream.WriteUInt16(pAction->GetLen()); + +write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream, pAction->GetText()); // version 2 +} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmWriter.hxx|1 vcl/source/filter/svm/SvmWriter.cxx | 41 2 files changed, 42 insertions(+) New commits: commit a3848e4e6b433e251c5e51f1e29d3c28d54a257c Author: panoskorovesis AuthorDate: Mon Aug 2 19:57:11 2021 +0300 Commit: Tomaž Vajngerl CommitDate: Tue Aug 3 04:48:59 2021 +0200 Add Handler for PolyPolygon Write The handler separates MetaPolyPolygonAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I95b68a4ea561bf80fbe83363743ea91e3f973f7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119898 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx index 393fb19f672f..f4019899c5ce 100644 --- a/include/vcl/filter/SvmWriter.hxx +++ b/include/vcl/filter/SvmWriter.hxx @@ -50,4 +50,5 @@ public: void ChordHandler(MetaChordAction* pAction); void PolyLineHandler(MetaPolyLineAction* pAction); void PolygonHandler(MetaPolygonAction* pAction); +void PolyPolygonHandler(MetaPolyPolygonAction* pAction); }; \ No newline at end of file diff --git a/vcl/source/filter/svm/SvmWriter.cxx b/vcl/source/filter/svm/SvmWriter.cxx index 6a3a88f78b79..fc4945274d6e 100644 --- a/vcl/source/filter/svm/SvmWriter.cxx +++ b/vcl/source/filter/svm/SvmWriter.cxx @@ -155,6 +155,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, ImplMetaWriteData* pData) } break; +case MetaActionType::POLYPOLYGON: +{ +auto* pMetaAction = static_cast(pAction); +PolyPolygonHandler(pMetaAction); +} +break; + /* default case prevents test failure and will be removed once all the handlers are completed */ default: @@ -292,4 +299,38 @@ void SvmWriter::PolygonHandler(MetaPolygonAction* pAction) if (bHasPolyFlags) pAction->GetPolygon().Write(mrStream); } + +void SvmWriter::PolyPolygonHandler(MetaPolyPolygonAction* pAction) +{ +mrStream.WriteUInt16(static_cast(pAction->GetType())); + +VersionCompatWrite aCompat(mrStream, 2); + +sal_uInt16 nNumberOfComplexPolygons = 0; +sal_uInt16 i, nPolyCount = pAction->GetPolyPolygon().Count(); + +tools::Polygon aSimplePoly; // Version 1 +mrStream.WriteUInt16(nPolyCount); +for (i = 0; i < nPolyCount; i++) +{ +const tools::Polygon& rPoly = pAction->GetPolyPolygon().GetObject(i); +if (rPoly.HasFlags()) +nNumberOfComplexPolygons++; +rPoly.AdaptiveSubdivide(aSimplePoly); +WritePolygon(mrStream, aSimplePoly); +} + +mrStream.WriteUInt16(nNumberOfComplexPolygons); // Version 2 +for (i = 0; nNumberOfComplexPolygons && (i < nPolyCount); i++) +{ +const tools::Polygon& rPoly = pAction->GetPolyPolygon().GetObject(i); +if (rPoly.HasFlags()) +{ +mrStream.WriteUInt16(i); +rPoly.Write(mrStream); + +nNumberOfComplexPolygons--; +} +} +} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-bugs] [Bug 143696] Development Tools - Minor glitches and improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=143696 --- Comment #2 from Commit Notification --- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cd3289e3878f35ba66e0f0b7d62e3cbcb6e53f4b tdf#143696 rename Properties tree view column from Object to Name It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143696] Development Tools - Minor glitches and improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=143696 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sfx2/uiconfig
sfx2/uiconfig/ui/developmenttool.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cd3289e3878f35ba66e0f0b7d62e3cbcb6e53f4b Author: Tomaž Vajngerl AuthorDate: Tue Aug 3 09:22:27 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Tue Aug 3 04:48:02 2021 +0200 tdf#143696 rename Properties tree view column from Object to Name Change-Id: I600d0bf7c9dc2c6c934e1f6faaed00e296b1d042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119918 Tested-by: Tomaž Vajngerl Reviewed-by: Tomaž Vajngerl diff --git a/sfx2/uiconfig/ui/developmenttool.ui b/sfx2/uiconfig/ui/developmenttool.ui index 476f9ed610cf..2f818cae7823 100644 --- a/sfx2/uiconfig/ui/developmenttool.ui +++ b/sfx2/uiconfig/ui/developmenttool.ui @@ -415,7 +415,7 @@ True -Object +Name True True
[Libreoffice-bugs] [Bug 139847] Go back in Tip-Of-The-Day
https://bugs.documentfoundation.org/show_bug.cgi?id=139847 stragu changed: What|Removed |Added CC||stephane.guil...@member.fsf ||.org --- Comment #3 from stragu --- Was looking on Bugzilla to create the same enhancement request, specifically about a "Back" button. A few times, I was reading tips of the day, pressed "Next" and straight away wanted to go back because I thought I misread something. A place to see all tips in one go would be handy. Wondering how a wiki page would be generated, as the list is specific to the LO branch. Would there be one wiki page per version, or just one from the latest one? Such list of "rendered" tips (as opposed to just the source code in https://opengrok.libreoffice.org/xref/core/cui/inc/tipoftheday.hrc ) would not only allow users to do a quick search of a topic (for example to find a tip they had seen previously), but it would also allow contributors to quickly see what the tip looks like in production without having to click on the "Next" button potentially more than 200 times. (I just did that to get to the UI tip, the first one, to verify bug 137607). I agree however that the other buttons proposed in by Gilles might only add clutter to the dialogue, and be too specific. If an automatically generated list of tips is available on the wiki, those buttons would be superfluous anyway. So I would vote for: - "Previous Tip" button to the left of the existing "Next Tip" button; - "See all tips" button or blue link. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143630] Left contour border of caption frame behind image after caption insertion
https://bugs.documentfoundation.org/show_bug.cgi?id=143630 Dmitrii A changed: What|Removed |Added CC||anisimov...@gmail.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Dmitrii A --- confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143631] Image dimensions not retained after cut/paste from caption frame to document
https://bugs.documentfoundation.org/show_bug.cgi?id=143631 Dmitrii A changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||anisimov...@gmail.com Ever confirmed|0 |1 --- Comment #1 from Dmitrii A --- confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143632] Image shrinks heavily when activated borders of caption frame at 0, 05pt
https://bugs.documentfoundation.org/show_bug.cgi?id=143632 Dmitrii A changed: What|Removed |Added CC||anisimov...@gmail.com --- Comment #1 from Dmitrii A --- no repro in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143633] Image size set to 0, 04 cm after disabling relative image width
https://bugs.documentfoundation.org/show_bug.cgi?id=143633 Dmitrii A changed: What|Removed |Added CC||anisimov...@gmail.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Dmitrii A --- Confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143634] Frequent "Error reading data from the Internet. Server error message: 403 Forbidden." checking for extension updates
https://bugs.documentfoundation.org/show_bug.cgi?id=143634 --- Comment #2 from Dmitrii A --- no repro in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140250] Undesirable linking of Glow and Soft Edge effects
https://bugs.documentfoundation.org/show_bug.cgi?id=140250 --- Comment #8 from Marcy Toal --- Created attachment 174035 --> https://bugs.documentfoundation.org/attachment.cgi?id=174035=edit glow and soft edge are separate properties in 7.0.6.2, issue not present in this version -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140250] Undesirable linking of Glow and Soft Edge effects
https://bugs.documentfoundation.org/show_bug.cgi?id=140250 --- Comment #7 from Marcy Toal --- i downgraded to 7.0.6.2. issue is not present in this version. note that the glow and soft edge tools are separate items in this version of libreoffice. perhaps this is simply some kind of user interface error. Version: 7.0.6.2 Build ID: 00(Build:2) CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.0.6-0ubuntu0.20.04.1_lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141465] Notebookbar items aren't shown by default even if they'd fit
https://bugs.documentfoundation.org/show_bug.cgi?id=141465 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| --- Comment #4 from Aron Budea --- Thanks for confirming. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143681] Save as feature not working
https://bugs.documentfoundation.org/show_bug.cgi?id=143681 John changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from John --- Thanks Julien. I actually run Mac OSX 10.15.5. Not sure if the fix you suggest for windows applies. John -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143644] Empty field gets filled when checking 'Title' in Sidebar Chart properties. And keeps content after unchecking
https://bugs.documentfoundation.org/show_bug.cgi?id=143644 Dmitrii A changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Dmitrii A --- Confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL For my opinion it works how it should. If you uncheck checkbox by a mistake, or for some reason want to remove title and get it back after you don't need to write the title again. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143644] Empty field gets filled when checking 'Title' in Sidebar Chart properties. And keeps content after unchecking
https://bugs.documentfoundation.org/show_bug.cgi?id=143644 Dmitrii A changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Dmitrii A --- Confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL For my opinion it works how it should. If you uncheck checkbox by a mistake, or for some reason want to remove title and get it back after you don't need to write the title again. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 143644] Empty field gets filled when checking 'Title' in Sidebar Chart properties. And keeps content after unchecking
https://bugs.documentfoundation.org/show_bug.cgi?id=143644 Dmitrii A changed: What|Removed |Added CC||anisimov...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143644] Empty field gets filled when checking 'Title' in Sidebar Chart properties. And keeps content after unchecking
https://bugs.documentfoundation.org/show_bug.cgi?id=143644 Dmitrii A changed: What|Removed |Added CC||anisimov...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140652] Copying and pasting a text from clipboard pastes it twice in LibreOffice Writer in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=140652 --- Comment #3 from Toni_Rocha --- I think the problem is (on my case) because I have installed the security app from Banco do Brasil (Brasilian Bank) to access it in browser. When I uninstalled it the problem has gone! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143695] toolbar too long
https://bugs.documentfoundation.org/show_bug.cgi?id=143695 --- Comment #3 from j...@jmbaai.com --- I played around a bit with trying to throw away buttons and such. And yes I saw the double arrow but that got old fast as what I wanted was just out of reach. So, in spite of all the ways offered to customize the toolbars by far the easiest solutions I have experienced in UI design of such apps over my many many years is as I have suggested -- fine granularity of chunks of functionality that can be enabled or moved around. In my younger days I would have offered to contribute code to "fix" the problem but those days are behind me. In any case, it is a GREAT app and I greatly respect what has been accomplished. Thanks --jon -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143695] toolbar too long
https://bugs.documentfoundation.org/show_bug.cgi?id=143695 --- Comment #3 from j...@jmbaai.com --- I played around a bit with trying to throw away buttons and such. And yes I saw the double arrow but that got old fast as what I wanted was just out of reach. So, in spite of all the ways offered to customize the toolbars by far the easiest solutions I have experienced in UI design of such apps over my many many years is as I have suggested -- fine granularity of chunks of functionality that can be enabled or moved around. In my younger days I would have offered to contribute code to "fix" the problem but those days are behind me. In any case, it is a GREAT app and I greatly respect what has been accomplished. Thanks --jon -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ad1b12686da88bea57582df10fa85268ada209b8 Author: Rafael Lima AuthorDate: Tue Aug 3 01:39:29 2021 +0200 Commit: Gerrit Code Review CommitDate: Tue Aug 3 01:39:29 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 0b7cde3aabef66890ebeb3ab8581d2104473214a - Create help page for the Development Tools feature Change-Id: Ib392399fa71c27ce6be7fca8c55985d75519ea87 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119855 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 1951014d9e7c..0b7cde3aabef 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 1951014d9e7c5270904789c2964d35fca8487134 +Subproject commit 0b7cde3aabef66890ebeb3ab8581d2104473214a
[Libreoffice-commits] help.git: AllLangHelp_shared.mk source/auxiliary source/text
AllLangHelp_shared.mk |1 source/auxiliary/sbasic.tree |3 source/text/sbasic/shared/uno_objects.xhp | 98 ++- source/text/shared/guide/dev_tools.xhp| 152 ++ 4 files changed, 207 insertions(+), 47 deletions(-) New commits: commit 0b7cde3aabef66890ebeb3ab8581d2104473214a Author: Rafael Lima AuthorDate: Mon Aug 2 16:53:20 2021 +0200 Commit: Olivier Hallot CommitDate: Tue Aug 3 01:39:29 2021 +0200 Create help page for the Development Tools feature Change-Id: Ib392399fa71c27ce6be7fca8c55985d75519ea87 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119855 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/AllLangHelp_shared.mk b/AllLangHelp_shared.mk index 107c8b1a5..64696aa8d 100644 --- a/AllLangHelp_shared.mk +++ b/AllLangHelp_shared.mk @@ -664,6 +664,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\ helpcontent2/source/text/shared/guide/data_tables \ helpcontent2/source/text/shared/guide/data_view \ helpcontent2/source/text/shared/guide/database_main \ +helpcontent2/source/text/shared/guide/dev_tools \ helpcontent2/source/text/shared/guide/digital_signatures \ helpcontent2/source/text/shared/guide/digitalsign_receive \ helpcontent2/source/text/shared/guide/digitalsign_send \ diff --git a/source/auxiliary/sbasic.tree b/source/auxiliary/sbasic.tree index 52dcb35a4..9256c75d0 100644 --- a/source/auxiliary/sbasic.tree +++ b/source/auxiliary/sbasic.tree @@ -391,5 +391,8 @@ Calling Basic Macros from Python + +Object Inspector + diff --git a/source/text/sbasic/shared/uno_objects.xhp b/source/text/sbasic/shared/uno_objects.xhp index 99ba126dd..1916fa279 100644 --- a/source/text/sbasic/shared/uno_objects.xhp +++ b/source/text/sbasic/shared/uno_objects.xhp @@ -1,55 +1,59 @@ - - - -UNO Objects -/text/sbasic/shared/uno_objects.xhp - - - - -programming;UNO objects -UNO objects -UNO functions - - -UNO Objects, Functions and Services -Functions, objects and services of Unified Network Objects (UNO). - + + + +UNO Objects +/text/sbasic/shared/uno_objects.xhp + + + + +programming;UNO objects +UNO objects +UNO functions + + +UNO Objects, Functions and Services +Functions, objects and services of Unified Network Objects (UNO). + -%PRODUCTNAME Global Objects - - - - + %PRODUCTNAME Global Objects + + + + -Active document Objects -The following objects can be used from the active document. -BasicLibraries Object -DialogLibraries Object - + Active document Objects + The following objects can be used from the active document. + BasicLibraries Object + DialogLibraries Object + -UNO Methods -Use the following methods to manage or query Unified Network Objects (UNO). - - - - - - - - - - -%PRODUCTNAME provides an Application Programming Interface (API) that allows controlling the $[officename] components with different programming languages by using the $[officename] Software Development Kit (SDK). For more information about the $[officename] API and the Software Development Kit, visit https://api.libreoffice.org/; name="api.libreoffice.org">https://api.libreoffice.org + UNO Methods + Use the following methods to manage or query Unified Network Objects (UNO). + + + + + + + + + + + %PRODUCTNAME provides an Application Programming Interface (API) that allows controlling the $[officename] components with different programming languages by using the $[officename] Software Development Kit (SDK). For more information about the $[officename] API and the Software Development Kit, visit https://api.libreoffice.org/; name="api.libreoffice.org">https://api.libreoffice.org + + + + diff --git a/source/text/shared/guide/dev_tools.xhp b/source/text/shared/guide/dev_tools.xhp new file mode 100644 index 0..80df75efa --- /dev/null +++ b/source/text/shared/guide/dev_tools.xhp @@ -0,0 +1,152 @@ + + + + + + +Development Tools +/text/shared/guide/dev_tools.xhp + + + + +development tools +object inspector + + + + Development Tools + Inspects objects in %PRODUCTNAME documents and shows supported UNO services, as well as available methods, properties and implemented interfaces. This feature also allows to explore the document structure using the Document Object Model (DOM). + +Choose Tools - Development Tools + + After Development Tools is enabled it will become visible in all documents and %PRODUCTNAME applications. This setting is persistent and the Development Tools will remain visible until it is explicitly
[Libreoffice-bugs] [Bug 143664] sdf date time recognition fails for march ("Mär") in German
https://bugs.documentfoundation.org/show_bug.cgi?id=143664 Eike Rathke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Version|7.3.0.0 alpha0+ Master |Inherited From OOo Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | --- Comment #10 from Eike Rathke --- Pending review https://gerrit.libreoffice.org/c/core/+/119857 for 7-2 https://gerrit.libreoffice.org/c/core/+/119858 for 7-2 https://gerrit.libreoffice.org/c/core/+/119859 for 7-1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143664] sdf date time recognition fails for march ("Mär") in German
https://bugs.documentfoundation.org/show_bug.cgi?id=143664 --- Comment #9 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/400a44f9ac7792ffe3665f70507324e4a64dca2b Related: tdf#143664 Change {de-*} March "Mrz" to "Mär" It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143664] sdf date time recognition fails for march ("Mär") in German
https://bugs.documentfoundation.org/show_bug.cgi?id=143664 --- Comment #8 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4961dbaecc9e5cac57d99d2ea9d265a90daa4a8b Resolves: tdf#143664 {de-*} accept "Mär" and "Mrz" for March It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143664] sdf date time recognition fails for march ("Mär") in German
https://bugs.documentfoundation.org/show_bug.cgi?id=143664 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/de_DE.xml |2 +- i18npool/source/localedata/data/de_LU.xml |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 400a44f9ac7792ffe3665f70507324e4a64dca2b Author: Eike Rathke AuthorDate: Mon Aug 2 22:16:44 2021 +0200 Commit: Eike Rathke CommitDate: Tue Aug 3 01:11:32 2021 +0200 Related: tdf#143664 Change {de-*} March "Mrz" to "Mär" Change-Id: Id4a4ebe432bf5badae96eadb723336648d2ce690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119917 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/i18npool/source/localedata/data/de_DE.xml b/i18npool/source/localedata/data/de_DE.xml index 6eb8307d3c13..95f07a1e14ed 100644 --- a/i18npool/source/localedata/data/de_DE.xml +++ b/i18npool/source/localedata/data/de_DE.xml @@ -266,7 +266,7 @@ mar - Mrz + Mär März diff --git a/i18npool/source/localedata/data/de_LU.xml b/i18npool/source/localedata/data/de_LU.xml index 3dcf21c6b616..00e5a7980e3d 100644 --- a/i18npool/source/localedata/data/de_LU.xml +++ b/i18npool/source/localedata/data/de_LU.xml @@ -254,7 +254,7 @@ mar - Mrz + Mär März
[Libreoffice-commits] core.git: svl/source
svl/source/numbers/zforfind.cxx | 16 1 file changed, 16 insertions(+) New commits: commit 4961dbaecc9e5cac57d99d2ea9d265a90daa4a8b Author: Eike Rathke AuthorDate: Mon Aug 2 22:11:29 2021 +0200 Commit: Eike Rathke CommitDate: Tue Aug 3 01:11:11 2021 +0200 Resolves: tdf#143664 {de-*} accept "Mär" and "Mrz" for March Change-Id: I82c094687137995a634450cb4f617909859d1688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119916 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/svl/source/numbers/zforfind.cxx b/svl/source/numbers/zforfind.cxx index 8b01debbb1d4..121b9bd406f6 100644 --- a/svl/source/numbers/zforfind.cxx +++ b/svl/source/numbers/zforfind.cxx @@ -649,9 +649,25 @@ short ImpSvNumberInputScan::GetMonth( const OUString& rString, sal_Int32& nPos ) res = sal::static_int_cast< short >(-(i+1)); // negative break; // for } +else if (i == 2 && pFormatter->GetLanguageTag().getLanguage() == "de") +{ +if (pUpperAbbrevMonthText[i] == u"M\u00C4R" && StringContainsWord( "MRZ", rString, nPos)) +{ // Accept MRZ for MÄR +nPos = nPos + 3; +res = sal::static_int_cast< short >(-(i+1)); // negative +break; // for +} +else if (pUpperAbbrevMonthText[i] == "MRZ" && StringContainsWord( u"M\u00C4R", rString, nPos)) +{ // And vice versa, accept MÄR for MRZ +nPos = nPos + 3; +res = sal::static_int_cast< short >(-(i+1)); // negative +break; // for +} +} else if (i == 8) { // This assumes the weirdness is applicable to all locales. +// It is the case for at least en-* and de-* locales. if (pUpperAbbrevMonthText[i] == "SEPT" && StringContainsWord( "SEP", rString, nPos)) { // #102136# The correct English form of month September abbreviated is // SEPT, but almost every data contains SEP instead.
[Libreoffice-bugs] [Bug 143698] New: LibreOffice Thesaurus Greyed Out
https://bugs.documentfoundation.org/show_bug.cgi?id=143698 Bug ID: 143698 Summary: LibreOffice Thesaurus Greyed Out Product: LibreOffice Version: 7.1.2.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lyl...@hotmail.com Description: Since upgrading from version 6.2 to 7.1 of LibreOffice, I have noticed in Writer the Thesaurus option is always greyed out and non-functional. Setting language on the document did not help, and no other options appear to make Thesaurus functional. Please advise how to fix! Steps to Reproduce: 1.Open new document 2. Type a few sentences. 3. Select a word like "dire" and try to use Thesaurus. Actual Results: No function Expected Results: Thesaurus should pop up with antonyms, synonyms, etc. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104156] [postMessage] "Save" state changes
https://bugs.documentfoundation.org/show_bug.cgi?id=104156 Higor Tavares changed: What|Removed |Added Assignee|higortavares.i...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104156] [postMessage] "Save" state changes
https://bugs.documentfoundation.org/show_bug.cgi?id=104156 Higor Tavares changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |higortavares.i...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141501] Difference in PIVOTTABLE layout using Calc under Windows or Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=141501 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141501] Difference in PIVOTTABLE layout using Calc under Windows or Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=141501 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Are you sure you use the same LO version on Debian and on Windows? Page fields was changed to Filters purposely Please check your LO version -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140652] Copying and pasting a text from clipboard pastes it twice in LibreOffice Writer in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=140652 Olivier Hallot changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #2 from Olivier Hallot --- *** Bug 141567 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141567] Copy and Paste in Basic Editor pastes text twice
https://bugs.documentfoundation.org/show_bug.cgi?id=141567 Olivier Hallot changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Olivier Hallot --- *** This bug has been marked as a duplicate of bug 140652 *** -- You are receiving this mail because: You are the assignee for the bug.
Re: Important: AskBot migration
On Tue, 01 Jun 2021 at 16:52:50 +0200, sophi wrote: > With the great feedback we had, we feel now ready to go further and > fully migrate to Discourse and then, say goodbye to the AskBot instance. The migration is now complete. If you have trouble regaining access to your AskBot account, or any question with the migration, please see the FAQ summary on Discourse itself (we'll try to update with any other common question): https://ask.libreoffice.org/t/migration-from-askbot/66564 . Discourse issues can be reported using the usual infra channels, see https://tdf.io/infra . -- Guilhem. signature.asc Description: PGP signature
[Libreoffice-bugs] [Bug 139916] Calc In New Window rows do NOT fit side by side as in OpenOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=139916 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO Whiteboard| QA:needsComment| --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Steve Dulaney from comment #2) > Feb 14 2021 > Congratulations! >You fixed the bug. Now in new window the row lines between the two > windows are even. That is 5% more possible business programs. Bad Excel does > not have split windows that scrolls separately so I simulated it with new > windows in LibreOffice. That is 50% more business programs! After 25 > purchases my Cash register does Not scroll off the screen! > Again Excellent Job, > LibreOffice 7.1.0.3, Windows, AMD A8 chip > > Steve Dulaney > > 913 Ellison St #924 > > Falls Church, Va. 22046 > > stdula...@netscape.net So can we close this one as WorksForMe? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||138842 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138842 [Bug 138842] UI: Counter-intuitive "Default" context menu item for comments -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 138842] UI: Counter-intuitive "Default" context menu item for comments
https://bugs.documentfoundation.org/show_bug.cgi?id=138842 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||101216 Ever confirmed|0 |1 Whiteboard| QA:needsComment| Keywords||needsUXEval Status|UNCONFIRMED |NEW --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- OMG, it's terribly of course I confirm the bug in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4677345e3695bac158bb04048b4d5c608ed764b4 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL I think that item just applies the Draw default style to the comment's shape UX-team - we should change it (or just delete that "Default" Comment's context menu item) to something more useful Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101216 [Bug 101216] [META] Calc comment bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 138842] UI: Counter-intuitive "Default" context menu item for comments
https://bugs.documentfoundation.org/show_bug.cgi?id=138842 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||101216 Ever confirmed|0 |1 Whiteboard| QA:needsComment| Keywords||needsUXEval Status|UNCONFIRMED |NEW --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- OMG, it's terribly of course I confirm the bug in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4677345e3695bac158bb04048b4d5c608ed764b4 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL I think that item just applies the Draw default style to the comment's shape UX-team - we should change it (or just delete that "Default" Comment's context menu item) to something more useful Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101216 [Bug 101216] [META] Calc comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140652] Copying and pasting a text from clipboard pastes it twice in LibreOffice Writer in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=140652 Olivier Hallot changed: What|Removed |Added Status|RESOLVED|REOPENED Ever confirmed|0 |1 Resolution|INVALID |--- --- Comment #1 from Olivier Hallot --- Confirmed in Kubuntu 21.04, LO 7.2 Seems that the Ctrl key is acting twice. Ctrl+Shit+S issues 2 "Save As" commands. Ctrl+O issues 2 "Open file" commands. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138738] graphic error
https://bugs.documentfoundation.org/show_bug.cgi?id=138738 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Please attach the file with charts here -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138738] graphic error
https://bugs.documentfoundation.org/show_bug.cgi?id=138738 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107810] [META] OLE/Embedded object bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107810 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||140603 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140603 [Bug 140603] FILESAVE: Docx embedded in ods is lost when saving the spreadsheet in xlsx format -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140603] FILESAVE: Docx embedded in ods is lost when saving the spreadsheet in xlsx format
https://bugs.documentfoundation.org/show_bug.cgi?id=140603 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| Blocks||107810 Keywords||dataLoss, filter:xlsx CC||79045_79...@mail.ru Ever confirmed|0 |1 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4677345e3695bac158bb04048b4d5c608ed764b4 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107810 [Bug 107810] [META] OLE/Embedded object bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141465] Notebookbar items aren't shown by default even if they'd fit
https://bugs.documentfoundation.org/show_bug.cgi?id=141465 --- Comment #3 from Oksana Ivanova --- retested confirm in Windows 7 Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137847] FILESAVE XLSX Named range pointing to data range in external file breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=137847 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| Ever confirmed|0 |1 CC||79045_79...@mail.ru --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4677345e3695bac158bb04048b4d5c608ed764b4 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143697] Paragraph language picker contains entry {es}
https://bugs.documentfoundation.org/show_bug.cgi?id=143697 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143697] Paragraph language picker contains entry {es}
https://bugs.documentfoundation.org/show_bug.cgi?id=143697 --- Comment #1 from Telesto --- Created attachment 174034 --> https://bugs.documentfoundation.org/attachment.cgi?id=174034=edit Example file Source: attachment 156910 (bug 129734). But this trimmed down & without font embedding enabled -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143697] New: Paragraph language picker contains entry {es}
https://bugs.documentfoundation.org/show_bug.cgi?id=143697 Bug ID: 143697 Summary: Paragraph language picker contains entry {es} Product: LibreOffice Version: 4.2.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Paragraph language picker contains entry {es} Steps to Reproduce: 1. Open the attached file 2. Status bar (bottom) (left) click 'Spanish'. Menu expands. Actual Results: Menu contains entry {es} Expected Results: Shouldn't be present Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL and in 4.4.7.2 and in Versie: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 not in 4.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141465] Notebookbar items aren't shown by default even if they'd fit
https://bugs.documentfoundation.org/show_bug.cgi?id=141465 --- Comment #2 from Oksana Ivanova --- no repro in Windows 7 Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143695] toolbar too long
https://bugs.documentfoundation.org/show_bug.cgi?id=143695 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Disagree, you can easy customize current default toolbars or create your own toolbars -1 from me -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143695] toolbar too long
https://bugs.documentfoundation.org/show_bug.cgi?id=143695 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Disagree, you can easy customize current default toolbars or create your own toolbars -1 from me -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/filter/html/swhtml.cxx | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) New commits: commit dcf61567600251aa239010ad287e1551a181431a Author: Caolán McNamara AuthorDate: Mon Aug 2 20:25:09 2021 +0100 Commit: Caolán McNamara CommitDate: Mon Aug 2 22:37:58 2021 +0200 more ofz#36727 Change-Id: Idaf189a6d78e06fb4c4615819b06ff1b3c8d57cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119909 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx index d1ee86c60814..b79c0d5071ce 100644 --- a/sw/source/filter/html/swhtml.cxx +++ b/sw/source/filter/html/swhtml.cxx @@ -291,6 +291,7 @@ SwHTMLParser::SwHTMLParser( SwDoc* pD, SwPaM& rCursor, SvStream& rIn, m_bSetModEnabled( false ), m_bInFloatingFrame( false ), m_bInField( false ), +m_bKeepUnknown( false ), m_bCallNextToken( false ), m_bIgnoreRawData( false ), m_bLBEntrySelected ( false ), @@ -316,8 +317,12 @@ SwHTMLParser::SwHTMLParser( SwDoc* pD, SwPaM& rCursor, SvStream& rIn, { const bool bFuzzing = utl::ConfigManager::IsFuzzing(); // If requested explicitly, then force ignoring of comments (don't create postits for them). -if (!bFuzzing && officecfg::Office::Writer::Filter::Import::HTML::IgnoreComments::get()) -m_bIgnoreHTMLComments = true; +if (!bFuzzing) +{ +if (officecfg::Office::Writer::Filter::Import::HTML::IgnoreComments::get()) +m_bIgnoreHTMLComments = true; +m_bKeepUnknown = officecfg::Office::Common::Filter::HTML::Import::UnknownTag::get(); +} m_nEventId = nullptr; m_bUpperSpace = m_bViewCreated = m_bChkJumpMark = false; @@ -345,8 +350,6 @@ SwHTMLParser::SwHTMLParser( SwDoc* pD, SwPaM& rCursor, SvStream& rIn, m_aFontHeights[4] = m_aFontHeights[5] = m_aFontHeights[6] = 12 * 20; } -m_bKeepUnknown = officecfg::Office::Common::Filter::HTML::Import::UnknownTag::get(); - if(bReadNewDoc) { //CJK has different defaults, so a different object should be used for this @@ -368,7 +371,8 @@ SwHTMLParser::SwHTMLParser( SwDoc* pD, SwPaM& rCursor, SvStream& rIn, m_xDoc->getIDocumentSettingAccess().set(DocumentSettingId::HTML_MODE, true); m_pCSS1Parser.reset(new SwCSS1Parser(m_xDoc.get(), *this, m_aFontHeights, m_sBaseURL, IsNewDoc())); -m_pCSS1Parser->SetIgnoreFontFamily( officecfg::Office::Common::Filter::HTML::Import::FontSetting::get() ); +if (!bFuzzing) +m_pCSS1Parser->SetIgnoreFontFamily( officecfg::Office::Common::Filter::HTML::Import::FontSetting::get() ); if( bReadUTF8 ) {
[Libreoffice-bugs] [Bug 143696] Development Tools - Minor glitches and improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=143696 --- Comment #1 from Rafael Lima --- Hi Tomaz, could you please give your insights about these issues? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143696] New: Development Tools - Minor glitches and improvements
https://bugs.documentfoundation.org/show_bug.cgi?id=143696 Bug ID: 143696 Summary: Development Tools - Minor glitches and improvements Product: LibreOffice Version: 7.2.0.0.beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 174033 --> https://bugs.documentfoundation.org/attachment.cgi?id=174033=edit Images Describing the Issues Hi! I was writing the Help Page for the new Development Tools feature and came across a few things that still need to be fixed or improved. Because all of them are very minor, I opened a single bug report to include all of them. 1) The DevTools window needs a Help button (see attached ODG - page 1): All dialogs in LO have a default Help button that redirects to the Help system. I believe it would be great to have a Help button here so that users are redirected to the Help page. 2) Slides in Impress are presented as "pages" (see attached ODG - page 2): I believe it would be better to simply use "Silde 1" instead of "page 1". 3) In the Properties tab the first column seems to be incorrectly named. I believe the correct name should be "Property" instead of "Object" (see attached ODG - page 3) 4) Sequences should be ordered according to their indices numerically (see attached ODG - page 4). I believe this would be more natural to users. 5) The textual representation in the Properties tab is not updated when the user selects another object (see attached ODG - page 5). The example was done in Calc: "Current Selection" was enabled and I selected a single cell B2. Then I chose cell B3 and the Property "Absolute Name" was updated in the table view, but not in the textual description. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108988] [META] Validity-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108988 Bug 108988 depends on bug 143619, which changed state. Bug 143619 Summary: EDITING Validation circles move left/up on deleting a column/row https://bugs.documentfoundation.org/show_bug.cgi?id=143619 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143695] toolbar too long
https://bugs.documentfoundation.org/show_bug.cgi?id=143695 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- When toolbar is too wide for a reduced width window (e.g. for two LO Writer side-by-side) the excess controls on the toolbar will be accessible from an overflow pop-up. Click the ">>" icon. You can of course use the 'Visible Buttons' droplist to deselect any of the buttons on a Toolbar to not display them and reduce the width. But you'll have to manually recover from that to restore (or simply restore default user profile). Do not see a need to sub-group button actions on any of the toolbars to toggle them hidden or not. Bottom line, there are plenty of means already to work with multiple module windows and customize the toolbars as preferred/needed. -1 and this is a pretty clear => WF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143695] toolbar too long
https://bugs.documentfoundation.org/show_bug.cgi?id=143695 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- When toolbar is too wide for a reduced width window (e.g. for two LO Writer side-by-side) the excess controls on the toolbar will be accessible from an overflow pop-up. Click the ">>" icon. You can of course use the 'Visible Buttons' droplist to deselect any of the buttons on a Toolbar to not display them and reduce the width. But you'll have to manually recover from that to restore (or simply restore default user profile). Do not see a need to sub-group button actions on any of the toolbars to toggle them hidden or not. Bottom line, there are plenty of means already to work with multiple module windows and customize the toolbars as preferred/needed. -1 and this is a pretty clear => WF -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140957] Date formatting is not unambiguous
https://bugs.documentfoundation.org/show_bug.cgi?id=140957 Maria Grishanova changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/filter/html/swhtml.cxx | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) New commits: commit 8753431292376540eeb25d3980960632dd5fd78b Author: Caolán McNamara AuthorDate: Mon Aug 2 19:30:35 2021 +0100 Commit: Caolán McNamara CommitDate: Mon Aug 2 22:00:07 2021 +0200 ofz#36727 Abrt Change-Id: I3bc881846174f5a206c191cdeea8344809080e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119906 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx index ffed09c38cca..d1ee86c60814 100644 --- a/sw/source/filter/html/swhtml.cxx +++ b/sw/source/filter/html/swhtml.cxx @@ -314,8 +314,9 @@ SwHTMLParser::SwHTMLParser( SwDoc* pD, SwPaM& rCursor, SvStream& rIn, m_nTableDepth( 0 ), m_pTempViewFrame(nullptr) { +const bool bFuzzing = utl::ConfigManager::IsFuzzing(); // If requested explicitly, then force ignoring of comments (don't create postits for them). -if (!utl::ConfigManager::IsFuzzing() && officecfg::Office::Writer::Filter::Import::HTML::IgnoreComments::get()) +if (!bFuzzing && officecfg::Office::Writer::Filter::Import::HTML::IgnoreComments::get()) m_bIgnoreHTMLComments = true; m_nEventId = nullptr; @@ -328,13 +329,21 @@ SwHTMLParser::SwHTMLParser( SwDoc* pD, SwPaM& rCursor, SvStream& rIn, memset(m_xAttrTab.get(), 0, sizeof(HTMLAttrTable)); // Read the font sizes 1-7 from the INI file -m_aFontHeights[0] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_1::get() * 20; -m_aFontHeights[1] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_2::get() * 20; -m_aFontHeights[2] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_3::get() * 20; -m_aFontHeights[3] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_4::get() * 20; -m_aFontHeights[4] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_5::get() * 20; -m_aFontHeights[5] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_6::get() * 20; -m_aFontHeights[6] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_7::get() * 20; +if (!bFuzzing) +{ +m_aFontHeights[0] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_1::get() * 20; +m_aFontHeights[1] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_2::get() * 20; +m_aFontHeights[2] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_3::get() * 20; +m_aFontHeights[3] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_4::get() * 20; +m_aFontHeights[4] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_5::get() * 20; +m_aFontHeights[5] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_6::get() * 20; +m_aFontHeights[6] = officecfg::Office::Common::Filter::HTML::Import::FontSize::Size_7::get() * 20; +} +else +{ +m_aFontHeights[0] = m_aFontHeights[1] = m_aFontHeights[2] = m_aFontHeights[3] = +m_aFontHeights[4] = m_aFontHeights[5] = m_aFontHeights[6] = 12 * 20; +} m_bKeepUnknown = officecfg::Office::Common::Filter::HTML::Import::UnknownTag::get();
[Libreoffice-commits] core.git: sc/source
sc/source/filter/rtf/eeimpars.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 7f0e8d54c159290f0d62f269cc386480422e883f Author: Caolán McNamara AuthorDate: Mon Aug 2 19:37:20 2021 +0100 Commit: Caolán McNamara CommitDate: Mon Aug 2 21:59:44 2021 +0200 ofz#32766 Abrt Change-Id: I333e1571c68e62b209dce008edc1ab4d40b01f8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119907 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sc/source/filter/rtf/eeimpars.cxx b/sc/source/filter/rtf/eeimpars.cxx index 20857fe88350..4a3f29dfb849 100644 --- a/sc/source/filter/rtf/eeimpars.cxx +++ b/sc/source/filter/rtf/eeimpars.cxx @@ -33,6 +33,7 @@ #include #include #include +#include #include #include #include @@ -135,7 +136,7 @@ void ScEEImport::WriteToDocument( bool bSizeColsRows, double nOutputFactor, SvNu if (!pFormatter) pFormatter = mpDoc->GetFormatTable(); bool bNumbersEnglishUS = false; -if (pFormatter->GetLanguage() == LANGUAGE_SYSTEM) +if (pFormatter->GetLanguage() == LANGUAGE_SYSTEM && !utl::ConfigManager::IsFuzzing()) { // Automatic language option selected. Check for the global 'use US English' option. bNumbersEnglishUS = officecfg::Office::Common::Filter::HTML::Import::NumbersEnglishUS::get();
[Libreoffice-commits] core.git: svtools/source
svtools/source/control/inettbc.cxx | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) New commits: commit e01df5ad80cd8f34a781631da6f24f38bce613c4 Author: Noel Grandin AuthorDate: Mon Aug 2 18:59:40 2021 +0200 Commit: Noel Grandin CommitDate: Mon Aug 2 21:44:05 2021 +0200 osl::Mutex->std::mutex in SvtMatchContext_Impl Change-Id: Id9612600b3514df10cd5311cf60b6704596ed118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119895 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/svtools/source/control/inettbc.cxx b/svtools/source/control/inettbc.cxx index 5f8cf08eb72f..61940085eff1 100644 --- a/svtools/source/control/inettbc.cxx +++ b/svtools/source/control/inettbc.cxx @@ -52,6 +52,7 @@ #include #include +#include #include #include @@ -91,7 +92,7 @@ class SvtMatchContext_Impl: public salhelper::Thread boolbOnlyDirectories; boolbNoSelection; -osl::Mutex mutex_; +std::mutex mutex_; bool stopped_; css::uno::Reference< css::ucb::XCommandProcessor > processor_; sal_Int32 commandId_; @@ -154,7 +155,7 @@ void SvtMatchContext_Impl::Stop() css::uno::Reference< css::ucb::XCommandProcessor > proc; sal_Int32 id(0); { -osl::MutexGuard g(mutex_); +std::lock_guard g(mutex_); if (!stopped_) { stopped_ = true; proc = processor_; @@ -184,7 +185,7 @@ IMPL_LINK_NOARG( SvtMatchContext_Impl, Select_Impl, void*, void ) { // avoid recursion through cancel button { -osl::MutexGuard g(mutex_); +std::lock_guard g(mutex_); if (stopped_) { // Completion was stopped, no display: return; @@ -402,7 +403,7 @@ void SvtMatchContext_Impl::doExecute() ::osl::MutexGuard aGuard( theSvtMatchContextMutex::get() ); { // have we been stopped while we were waiting for the mutex? -osl::MutexGuard g(mutex_); +std::lock_guard g(mutex_); if (stopped_) { return; } @@ -477,7 +478,7 @@ void SvtMatchContext_Impl::doExecute() sal_Int32 id = proc->createCommandIdentifier(); try { { -osl::MutexGuard g(mutex_); +std::lock_guard g(mutex_); processor_ = proc; commandId_ = id; } @@ -502,7 +503,7 @@ void SvtMatchContext_Impl::doExecute() proc2->releaseCommandIdentifier(id); } { -osl::MutexGuard g(mutex_); +std::lock_guard g(mutex_); processor_.clear(); // At least the neon-based WebDAV UCP does not // properly support aborting commands, so return
[Libreoffice-bugs] [Bug 143695] New: toolbar too long
https://bugs.documentfoundation.org/show_bug.cgi?id=143695 Bug ID: 143695 Summary: toolbar too long Product: LibreOffice Version: 7.1.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@jmbaai.com I'm new to OfficeLibre. Trying to use side-by-side doc windows. The toolbars are generally too long for easy customization. E.g. standard format toolbar is 3/4 of the screen wide. Suggest subdividing the toolbars into bite sized chunks (e.g. each chunk between dividers) for easy customization and arrangement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141090] Direct Cursor causes instant slowdown in v7.xx of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=141090 --- Comment #3 from Maria Grishanova --- When Skia is disabled in the settings (Tools/Options/LibreOfficeDev/View/Graphics Output/uncheck Use Skia for all rendering), Direct Cursor works without delays. When Skia is enabled, the bug is repro. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/dbgui/dbnamdlg.cxx |8 ++-- sc/source/ui/inc/dbnamdlg.hxx |1 + 2 files changed, 7 insertions(+), 2 deletions(-) New commits: commit a07351e8181353c0c0b6df5d2ccbad4615c6706b Author: Tünde Tóth AuthorDate: Thu Jul 29 10:00:06 2021 +0200 Commit: Eike Rathke CommitDate: Mon Aug 2 21:19:36 2021 +0200 tdf#115520 sc UI: Define Database Range dialog disappeared if the name of the database range was invalid. Change-Id: If0eb08d35b2187f04ef93136acd6f7eafa3b588a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119652 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/sc/source/ui/dbgui/dbnamdlg.cxx b/sc/source/ui/dbgui/dbnamdlg.cxx index 4939663f29b4..1043e899af6d 100644 --- a/sc/source/ui/dbgui/dbnamdlg.cxx +++ b/sc/source/ui/dbgui/dbnamdlg.cxx @@ -249,6 +249,7 @@ void ScDbNameDlg::Init() bSaved = true; xSaveObj->Save(); NameModifyHdl( *m_xEdName ); +bInvalid = false; } void ScDbNameDlg::SetInfoStrings( const ScDBData* pDBData ) @@ -376,17 +377,18 @@ bool ScDbNameDlg::IsRefInputMode() const IMPL_LINK_NOARG(ScDbNameDlg, OkBtnHdl, weld::Button&, void) { +bInvalid = false; AddBtnHdl(*m_xBtnAdd); // Pass the changes and the remove list to the view: both are // transferred as a reference only, so that no dead memory can // be created at this point: +if (!bInvalid) { ScDBDocFunc aFunc(*m_rViewData.GetDocShell()); aFunc.ModifyAllDBData(aLocalDbCol, aRemoveList); +response(RET_OK); } - -response(RET_OK); } IMPL_LINK_NOARG(ScDbNameDlg, CancelBtnHdl, weld::Button&, void) @@ -469,6 +471,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, AddBtnHdl, weld::Button&, void) ERRORBOX(m_xDialog.get(), aStrInvalid); m_xEdAssign->SelectAll(); m_xEdAssign->GrabFocus(); +bInvalid = true; } } else @@ -476,6 +479,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, AddBtnHdl, weld::Button&, void) ERRORBOX(m_xDialog.get(), ScResId(STR_INVALIDNAME)); m_xEdName->select_entry_region(0, -1); m_xEdName->grab_focus(); +bInvalid = true; } } diff --git a/sc/source/ui/inc/dbnamdlg.hxx b/sc/source/ui/inc/dbnamdlg.hxx index 01dc0aab66a9..4958f121d821 100644 --- a/sc/source/ui/inc/dbnamdlg.hxx +++ b/sc/source/ui/inc/dbnamdlg.hxx @@ -41,6 +41,7 @@ public: private: boolbSaved; +boolbInvalid; OUStringaStrAdd; OUStringaStrModify;
[Libreoffice-commits] core.git: svl/source
svl/source/undo/undo.cxx | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) New commits: commit c4ff09fc8c55af1f5fadb452eef16b15be8e202a Author: Noel Grandin AuthorDate: Mon Aug 2 18:56:06 2021 +0200 Commit: Noel Grandin CommitDate: Mon Aug 2 21:18:26 2021 +0200 flatten SfxUndoManager_Data a little no need to allocate the SfxUndoArray separately Change-Id: I5866ee1382d0be22b71a7322fe4379d3e159f488 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119894 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx index ee9af634a4ba..2cc2890a9f93 100644 --- a/svl/source/undo/undo.cxx +++ b/svl/source/undo/undo.cxx @@ -155,8 +155,7 @@ typedef ::std::vector< SfxUndoListener* > UndoListeners; struct SfxUndoManager_Data { ::osl::MutexaMutex; -std::unique_ptr -pUndoArray; +SfxUndoArraymaUndoArray; SfxUndoArray* pActUndoArray; sal_Int32 mnMarks; @@ -169,7 +168,7 @@ struct SfxUndoManager_Data UndoListeners aListeners; explicit SfxUndoManager_Data( size_t i_nMaxUndoActionCount ) -:pUndoArray( new SfxUndoArray( i_nMaxUndoActionCount ) ) +:maUndoArray( i_nMaxUndoActionCount ) ,pActUndoArray( nullptr ) ,mnMarks( 0 ) ,mnEmptyMark(MARK_INVALID) @@ -178,7 +177,7 @@ struct SfxUndoManager_Data ,mbClearUntilTopLevel( false ) ,mbEmptyActions( true ) { -pActUndoArray = pUndoArray.get(); +pActUndoArray = } // Copy assignment is forbidden and not implemented. @@ -512,7 +511,7 @@ void SfxUndoManager::ImplClearUndo( UndoManagerGuard& i_guard ) void SfxUndoManager::ImplClearRedo( UndoManagerGuard& i_guard, bool const i_currentLevel ) { -SfxUndoArray* pUndoArray = ( i_currentLevel == SfxUndoManager::CurrentLevel ) ? m_xData->pActUndoArray : m_xData->pUndoArray.get(); +SfxUndoArray* pUndoArray = ( i_currentLevel == SfxUndoManager::CurrentLevel ) ? m_xData->pActUndoArray : _xData->maUndoArray; // clearance while ( pUndoArray->maUndoActions.size() > pUndoArray->nCurUndoAction ) @@ -554,7 +553,7 @@ bool SfxUndoManager::ImplAddUndoAction_NoNotify( std::unique_ptr ImplClearRedo( i_guard, SfxUndoManager::CurrentLevel ); // respect max number -if( m_xData->pActUndoArray == m_xData->pUndoArray.get() ) +if( m_xData->pActUndoArray == _xData->maUndoArray ) { while(m_xData->pActUndoArray->maUndoActions.size() >= m_xData->pActUndoArray->nMaxUndoActions) { @@ -596,7 +595,7 @@ void SfxUndoManager::AddUndoAction( std::unique_ptr pAction, bool size_t SfxUndoManager::GetUndoActionCount( bool const i_currentLevel ) const { UndoManagerGuard aGuard( *m_xData ); -const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : m_xData->pUndoArray.get(); +const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : _xData->maUndoArray; return pUndoArray->nCurUndoAction; } @@ -606,7 +605,7 @@ OUString SfxUndoManager::GetUndoActionComment( size_t nNo, bool const i_currentL UndoManagerGuard aGuard( *m_xData ); OUString sComment; -const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : m_xData->pUndoArray.get(); +const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : _xData->maUndoArray; assert(nNo < pUndoArray->nCurUndoAction); if( nNo < pUndoArray->nCurUndoAction ) sComment = pUndoArray->maUndoActions[ pUndoArray->nCurUndoAction - 1 - nNo ].pAction->GetComment(); @@ -735,7 +734,7 @@ size_t SfxUndoManager::GetRedoActionCount( bool const i_currentLevel ) const size_t SfxUndoManager::ImplGetRedoActionCount_Lock( bool const i_currentLevel ) const { -const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : m_xData->pUndoArray.get(); +const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : _xData->maUndoArray; return pUndoArray->maUndoActions.size() - pUndoArray->nCurUndoAction; } @@ -757,7 +756,7 @@ OUString SfxUndoManager::GetRedoActionComment( size_t nNo, bool const i_currentL { OUString sComment; UndoManagerGuard aGuard( *m_xData ); -const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : m_xData->pUndoArray.get(); +const SfxUndoArray* pUndoArray = i_currentLevel ? m_xData->pActUndoArray : _xData->maUndoArray; if ( (pUndoArray->nCurUndoAction + nNo) < pUndoArray->maUndoActions.size() ) { sComment = pUndoArray->maUndoActions[ pUndoArray->nCurUndoAction + nNo ].pAction->GetComment(); @@ -911,7 +910,7 @@ void SfxUndoManager::EnterListAction( const OUString& rComment, if( !ImplIsUndoEnabled_Lock() ) return; -if ( !m_xData->pUndoArray->nMaxUndoActions ) +if (
[Libreoffice-bugs] [Bug 115520] Define Database Range shouldn't close after having a false name
https://bugs.documentfoundation.org/show_bug.cgi?id=115520 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |tund...@gmail.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141090] Direct Cursor causes instant slowdown in v7.xx of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=141090 Maria Grishanova changed: What|Removed |Added Ever confirmed|0 |1 Blocks||129062 Status|UNCONFIRMED |NEW --- Comment #2 from Maria Grishanova --- confirm in Version: 7.1.5.2 (x64) / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=129062 [Bug 129062] [META] Skia library bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=129062 Maria Grishanova changed: What|Removed |Added Depends on||141090 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141090 [Bug 141090] Direct Cursor causes instant slowdown in v7.xx of Writer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91252] Export of area fill gradients to paths for PDF (and EPS) are too coarse
https://bugs.documentfoundation.org/show_bug.cgi?id=91252 --- Comment #18 from ilianus --- it seems that this bug depends on the shape 2 shapes are not affected by this bug please take a look at the attatched jpeg file i hope this help resolving this annoying bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91252] Export of area fill gradients to paths for PDF (and EPS) are too coarse
https://bugs.documentfoundation.org/show_bug.cgi?id=91252 --- Comment #17 from ilianus --- Created attachment 174032 --> https://bugs.documentfoundation.org/attachment.cgi?id=174032=edit the bug depends on the shape it seems that this bug depends on the shape 2 shapes are not affected by this bug please take a look at the attatched jpeg file i hope this help resolving this annoying bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143694] Icons are not rendered as expected (depending on screen resolution ?)
https://bugs.documentfoundation.org/show_bug.cgi?id=143694 --- Comment #1 from EL1962 --- Created attachment 174031 --> https://bugs.documentfoundation.org/attachment.cgi?id=174031=edit Screenshot with icon selection panel and toolbar -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143694] New: Icons are not rendered as expected (depending on screen resolution ?)
https://bugs.documentfoundation.org/show_bug.cgi?id=143694 Bug ID: 143694 Summary: Icons are not rendered as expected (depending on screen resolution ?) Product: LibreOffice Version: 7.1.5.2 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ephemeris.lap...@gmail.com Description: I’ve just changed my laptop and my new one has a 4k display. It runs Windows 10. When I try to set icons on personal toolbars, pictures in both the dialog and the toolbar are not rendered as expected. It’s hardly possible to select an icon. See attached screenshot. This applies with all icon size selection in options). Is it a bad resolution detection ? I’ve tried changing the zoom factor on Windows settings, but this has no effect. I’m used to do the same on 3 other computers, and without any issue… Steps to Reproduce: 1.Select a custom toolbar 2.Try to change icon (icons rendering in selection panel is wrong) 3.Select an icon (selected icon is not rendered with right size) Actual Results: Icon rendering provides tiny unreadable pictures. Expected Results: Icons should be rendered with the right size. Reproducible: Always User Profile Reset: No Additional Info: ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135629] Character can be deleted without image deletion if a second paragraph if present, else image deleted with character
https://bugs.documentfoundation.org/show_bug.cgi?id=135629 psidiumcode changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from psidiumcode --- I could reproduce it in versions: Version: 7.1.0.0.alpha0+ Build ID: 3870dd43e94c440a5094a57c47d3b7565658d73c CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.1.0.0.beta1+ Build ID: d5e786d78d2f72a39f02746d6e0faa04da72c60a CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.0.6.2 Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 7c38362dbe1922c9825dffb463072030948d406b CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded But I could not reproduce it in version: Version: 6.4.0.0.beta1+ Build ID: d54bae3471e9b9529f1ac03c811c3370d9f5ed89 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx; Locale: en-GB (en_GB.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140957] Date formatting is not unambiguous
https://bugs.documentfoundation.org/show_bug.cgi?id=140957 Maria Grishanova changed: What|Removed |Added CC||mashenka_grishan...@mail.ru --- Comment #1 from Maria Grishanova --- Hello. Describe in detail step by step what you are doing, what is the expected result, and what is the actual result -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141899] Fail selection on the text
https://bugs.documentfoundation.org/show_bug.cgi?id=141899 --- Comment #2 from Maria Grishanova --- no repro in Version: 7.1.5.2 (x64) / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: tsan-suppress.txt
tsan-suppress.txt | 12 1 file changed, 12 insertions(+) New commits: commit 8ed2207983c6d96e8866bd81e53097cb798436e8 Author: Noel Grandin AuthorDate: Mon Aug 2 14:18:56 2021 +0200 Commit: Noel Grandin CommitDate: Mon Aug 2 20:05:52 2021 +0200 more suppressions for TSAN Change-Id: I96072bdacb805135f0c267a878181035c4b0d810 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119890 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/tsan-suppress.txt b/tsan-suppress.txt index d6130b285df8..9d6c73c557ae 100644 --- a/tsan-suppress.txt +++ b/tsan-suppress.txt @@ -35,3 +35,15 @@ race:XBufferedThreadedStream::getNextBlock # not introduced in stuff the embedded JVM does race:libjvm.so + +# I think this is OK, because at this point we are doing +# if (nRefCount > 1) +# and we know from our callers that the refcount must be at least one +# so there is no failure mode +race:ireallocSequence + +# TODO There appears to be a race here, initialisng the +# ::com::sun::star::uno::Sequence< T >::s_pType +# field. But no idea at all how to fix it. +race:cppu::getTypeFavourUnsigned +
[Libreoffice-bugs] [Bug 143656] Direct SQL: Queries in Tools → SQL and macro give wrong results - direct SQL works well
https://bugs.documentfoundation.org/show_bug.cgi?id=143656 --- Comment #6 from Robert Großkopf --- (In reply to m.a.riosv from comment #5) > I didn't find exactly, but should be possible to run the sql as direct in a > macro. > In https://wiki.documentfoundation.org/images/b/b0/BH5009-Macros.pdf, page > 71 shows how to enable direct sql for mail-merge. It's only mail merge and I haven't tested it works not the same way as SQL in macros will work. Mail merge needs to know here, if it should use a table directly (by tablename), a query directly (by name of the query) or SQL-code, which should be written separately instead of the name of a query, as I have written in the Base Handbook. Note: I have written most of the content of Base Handbook. Base Handbook is translated to English from the German Base Handbuch. When I have written all these I haven't detected there is a difference between direct SQL in a query (which is real direct) and SQL in macros and Tools → SQL. I thought all this will be the same - but it isn't. If there is a real good argument for the difference between real direct SQL in a query and SQL in macros and Tools → SQL I have to change the content of the (German) Handbook here. My opinion: The difference, which appears here, isn't intended. It is a buggy behavior. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143664] sdf date time recognition fails for march ("Mär") in German
https://bugs.documentfoundation.org/show_bug.cgi?id=143664 --- Comment #7 from Eike Rathke --- @Julien: While enabling lists for short month names may sound appealing, doing so would be a cumbersome endeavour. All day and month names share a common structure (css::i18n::CalendarItem2 inherited from css::i18n::CalendarItem) that is also part of the published API. Changing AbbrevName to a list of strings would require not only to adapt all callers but also to support it as an additional new structure while maintaining the existing API for compatibility. I think these few exemptions so far are not worth that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/data/ods/tdf143619_validationCirclePos.ods |binary sc/qa/unit/scshapetest.cxx| 34 ++ sc/source/core/data/drwlayer.cxx |7 +++ 3 files changed, 41 insertions(+) New commits: commit 0cff1aa48453ee0c05bafcac5360329fb6bf9557 Author: Regina Henschel AuthorDate: Fri Jul 30 23:18:39 2021 +0200 Commit: Regina Henschel CommitDate: Mon Aug 2 19:22:10 2021 +0200 tdf#143619 validation circle anchor is special For usual drawing objects, maStart in its Calc user data means the cell address of left/top of snapRect/logicRect. For validation circle it means 'address of cell to be validated'. Thus corrections might be needed, if a general method is used for validation circle. Here the method SetLogicRect() calls via broadcast ScDrawLayer::SetCellAnchoredFromPosition(), which calculates maStart from snapRect/logicRect. Because the circle is extended to cover a larger area than the to be validated cell, maStart got the cell address of the cell one left and one above of the to be validated cell. Now the old, correct address is backuped and restored. Change-Id: I9646da3f22fef45a6e47e59ef55a70307e2f9cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119715 Tested-by: Jenkins Reviewed-by: Regina Henschel diff --git a/sc/qa/unit/data/ods/tdf143619_validationCirclePos.ods b/sc/qa/unit/data/ods/tdf143619_validationCirclePos.ods new file mode 100644 index ..6470d6a1f430 Binary files /dev/null and b/sc/qa/unit/data/ods/tdf143619_validationCirclePos.ods differ diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx index fad81ddd0e6b..c178c28578a6 100644 --- a/sc/qa/unit/scshapetest.cxx +++ b/sc/qa/unit/scshapetest.cxx @@ -46,6 +46,7 @@ public: ScShapeTest(); void saveAndReload(css::uno::Reference& xComponent, const OUString& rFilter); +void testTdf143619_validation_circle_pos(); void testTdf140252_DragCreateFormControl(); void testTdf134355_DragCreateCustomShape(); void testTdf140252_LayerOfControl(); @@ -72,6 +73,7 @@ public: void testCustomShapeCellAnchoredRotatedShape(); CPPUNIT_TEST_SUITE(ScShapeTest); +CPPUNIT_TEST(testTdf143619_validation_circle_pos); CPPUNIT_TEST(testTdf140252_DragCreateFormControl); CPPUNIT_TEST(testTdf134355_DragCreateCustomShape); CPPUNIT_TEST(testTdf140252_LayerOfControl); @@ -204,6 +206,38 @@ static SdrObject* lcl_getSdrObjectWithAssert(ScDocument& rDoc, sal_uInt16 nObjNu return pObj; } +void ScShapeTest::testTdf143619_validation_circle_pos() +{ +// Load a document, which has validation circle around cell E6. + +OUString aFileURL; +createFileURL(u"tdf143619_validationCirclePos.ods", aFileURL); +uno::Reference xComponent = loadFromDesktop(aFileURL); + +// Get document +ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); +ScDocument& rDoc = pDocSh->GetDocument(); + +// Get shape. That is the validation circle. +SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); + +// Error was, that deleting row and col before E6 does not move circle to D5, but to B3. +// Delete first row and first column. +uno::Sequence aPropertyValues = { +comphelper::makePropertyValue("ToPoint", OUString("$A$1")), +}; +dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); +dispatchCommand(xComponent, ".uno:DeleteRows", {}); +dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); +dispatchCommand(xComponent, ".uno:DeleteColumns", {}); + +// Without fix in place the position was (2007, 833) +Point aPos = pObj->GetSnapRect().TopLeft(); +lcl_AssertPointEqualWithTolerance("after row and col delete", Point(6523, 1736), aPos, 1); + +pDocSh->DoClose(); +} + void ScShapeTest::testTdf140252_DragCreateFormControl() { // Error was, that drag-created form controls were initially not on layer 'controls' and thus diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx index 1174cb656019..79b52627e015 100644 --- a/sc/source/core/data/drwlayer.cxx +++ b/sc/source/core/data/drwlayer.cxx @@ -1049,6 +1049,7 @@ void ScDrawLayer::RecalcPos( SdrObject* pObj, ScDrawObjData& rData, bool bNegati // Validation circle for detective. rData.setShapeRect(GetDocument(), pObj->GetLogicRect()); +// rData.maStart should contain the address of the be validated cell. tools::Rectangle aRect = GetCellRect(*GetDocument(), rData.maStart, true); aRect.AdjustLeft( -250 ); aRect.AdjustRight(250 ); @@ -1062,7 +1063,13 @@ void ScDrawLayer::RecalcPos( SdrObject* pObj, ScDrawObjData& rData, bool bNegati if (bRecording) AddCalcUndo( std::make_unique( *pObj ) ); rData.setShapeRect(GetDocument(), lcl_makeSafeRectangle(aRect)); +
[Libreoffice-bugs] [Bug 143656] Direct SQL: Queries in Tools → SQL and macro give wrong results - direct SQL works well
https://bugs.documentfoundation.org/show_bug.cgi?id=143656 --- Comment #5 from m.a.riosv --- I didn't find exactly, but should be possible to run the sql as direct in a macro. In https://wiki.documentfoundation.org/images/b/b0/BH5009-Macros.pdf, page 71 shows how to enable direct sql for mail-merge. -- You are receiving this mail because: You are the assignee for the bug.
Re: suspicious needed in CppunitTest/libtest_services.so
Hi Stephan, Le 02/08/2021 à 09:41, Stephan Bergmann a écrit : On 29/07/2021 19:20, Jean-Baptiste Faure wrote: [...]/libo/72/instdir/program/libpythonloaderlo.so has suspicious NEEDED: libpython3.8.so.1.0 [...]/libo/72/instdir/program/libpyuno.so has suspicious NEEDED: libpython3.8.so.1.0 make[1]: *** [[...]/libo/72/postprocess/CustomTarget_check_dynamic_objects.mk:23: [...]/libo/72/workdir/CustomTarget/postprocess/check_dynamic_objects/check.done] Error 1 make[1]: *** Waiting for unfinished jobs make: *** [Makefile:287: build] Error 2 You are presumably building with --enable-python=system (and some --with-package-format=..., so that CustomTarget_check_dynamic_objects is run in the first place, cf. postprocess/Module_postprocess.mk). The test in postprocess/CustomTarget_check_dynamic_objects.mk tries to ensure that the generated binaries do not have accidental dependencies on libraries that are only present on the build machine. This is typically less of an issue for your own local builds you do not intend to pass on to others. To silence the issue, add LO_ELFCHECK_ALLOWLIST=libpython3.8.so.1.0 to your autogen.input. Thank you very much, you solved my problem. :-) I do not have the same issue for - LO 7.1 because its autogen.input contains --enable-python=fully-internal - and for the master because its autogen.input does not contain --with-package-format=deb contrary to LO 7.2 Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
[Libreoffice-bugs] [Bug 77149] #6 envelope will not print (HP printer)
https://bugs.documentfoundation.org/show_bug.cgi?id=77149 --- Comment #10 from ree...@gmail.com --- A (my) situation, possible solutions, my selected solution, and an opinionated explanation of why I wrote all this. But, first: Thank you, thank you, thank you to all developers and maintainers of LibreOffice -- for Writer and all the other components. Thank you. Confirming for Ubuntu v18.04 with Writer v7.1.5.2 with CUPS v2.2.7 for these situations: At insert envelope selector, among many is offered: #6 3/4 (Personal) Envelope At page style selector, among many is offered: #6 3/4 (Personal) Envelope At printer setup -- whether via printer setup at insert envelope or via File > Printer Settings -- there is no offer of #6 3/4 envelope size for: Xerox Phaser 3260 Xerox 4620 HP Laserjet 4200 Then, digging a bit further: On my computer each of these printers communicates between Writer and the printer using CUPS and this is common for many Linux applications that can use a paper printer. Looking at the source code *.ppd file (the file used by CUPS to do several things) it includes the offered paper sizes for the printer. I looked at two (3260 & 4200) and neither lists 6 3/4 envelope as a paper option despite the printers can print them. (Yes, they can. I do it in each.) Possible solutions: There are two things a person can do to print 6-3/4 or any custom paper size or envelope size: 1) find the source code *.ppd for your printer (try manufacturer or maybe https://openprinting.github.io/ or search the web), learn how to edit the *.ppd, edit, and then install it to replace current ppd 2) use an envelope or paper size offering larger than the size you want as a beginning page and then **make a Writer template** that keeps the page size and uses margins and frames to make a envelope that is correctly positioned for your manual feeder envelope location (for me that was vertically centered on a landscape page with envelope right edge at right edge of (larger) paper because most (all?) printers do nothing to verify page size matches what you specify in Writer). (my choice of solution) An explanation: Why did I write all this? In defense of the developers and maintainers of Writer. The people who work to give us LibreOffice Writer do an excellent job. And in this situation, Writer is working properly. The problem is the printer manufacturers putting too few paper sizes in their *.ppd files! Yes, as best I can tell, the Writer developers and maintainers could write a whole mountain of code to enable custom sizes of paper for many different printers using CUPS (for Linux and Mac and I believe a separate system for WinOS). Instead, each of us can make a template if we need the custom size often enough. (Currently, I do have a (larger paper) template for #6-3/4. It is with prefilled fields that I use for one envelope a month. However, it could all be adapted to hundreds of envelopes using mailmerge.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143693] New: LO should be able to load files from HTTP
https://bugs.documentfoundation.org/show_bug.cgi?id=143693 Bug ID: 143693 Summary: LO should be able to load files from HTTP Product: LibreOffice Version: 6.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: oluoluolu+lobugzi...@gmail.com Description: MS Word for years has allowed the direct import of files from the web. I think LO should allow this as well. Steps to Reproduce: 1. Go to open dialog 2. Input a URL 3. Actual Results: Nothing happens Expected Results: It would be nice if this feature was implemnented. Along with support for .woff files and CSS stylesheets. Reproducible: Always User Profile Reset: No Additional Info: None. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143161] EDITING: Spurious spell-checking red wavy line for Chinese text if the cell content contains manual line-break
https://bugs.documentfoundation.org/show_bug.cgi?id=143161 --- Comment #5 from Ming Hua --- Thanks for the bibisection work, Kevin. (In reply to Kevin Suo from comment #4) > Email seems not been sent to Dennis Francis. Could someone remind him on IRC. I've added a comment on Gerrit at https://gerrit.libreoffice.org/c/core/+/104705, and if that still doesn't work, I'll try raising the issue on IRC. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143679] (spam)
https://bugs.documentfoundation.org/show_bug.cgi?id=143679 Ming Hua changed: What|Removed |Added Component|General |deletionRequest Product|Document Liberation Project |LibreOffice Resolution|--- |INVALID Summary|Safety Glasses | Safety |(spam) |Prescription Glasses | | |Prescription Lens | URL|https://www.safetylensusa.c | |om/ | Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bridges/source testtools/com testtools/source
bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx |7 ++- bridges/source/cpp_uno/gcc3_linux_x86-64/abi.hxx |3 ++- bridges/source/cpp_uno/gcc3_linux_x86-64/call.s | 11 --- bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx | 18 +- bridges/source/cpp_uno/gcc3_macosx_x86-64/abi.cxx |7 ++- bridges/source/cpp_uno/gcc3_macosx_x86-64/abi.hxx |3 ++- bridges/source/cpp_uno/gcc3_macosx_x86-64/call.cxx| 12 +--- bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx | 18 +- testtools/com/sun/star/comp/bridge/TestComponent.java |5 + testtools/source/bridgetest/bridgetest.cxx|6 ++ testtools/source/bridgetest/cli/cli_cs_testobj.cs |2 ++ testtools/source/bridgetest/cppobj.cxx|1 + testtools/source/bridgetest/idl/bridgetest.idl|6 ++ 13 files changed, 79 insertions(+), 20 deletions(-) New commits: commit d5a100f59467d94945656b54563e5ecdde2ca724 Author: Stephan Bergmann AuthorDate: Mon Aug 2 15:57:32 2021 +0200 Commit: Stephan Bergmann CommitDate: Mon Aug 2 18:21:30 2021 +0200 tdf#143450: Special integre+fp struct return case needs a fix too, of course ...similar to ca344be7aabf88e38841e6af6292ece6829b "tdf#143450: Fix special fp+integer struct return case for gcc_*_x86-64" Change-Id: Ia8110d632a1c5f328822c434efc5b09bd53ec9e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119883 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx b/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx index f36678ed3695..243e42d057e8 100644 --- a/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx +++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx @@ -269,7 +269,12 @@ x86_64::ReturnKind x86_64::getReturnKind(typelib_TypeDescriptionReference * type if (n == 2 && (classes[0] == X86_64_SSE_CLASS || classes[0] == X86_64_SSESF_CLASS) && (classes[1] == X86_64_INTEGER_CLASS || classes[1] == X86_64_INTEGERSI_CLASS)) { -return ReturnKind::RegistersSpecial; +return ReturnKind::RegistersFpInt; +} +if (n == 2 && (classes[0] == X86_64_INTEGER_CLASS || classes[0] == X86_64_INTEGERSI_CLASS) +&& (classes[1] == X86_64_SSE_CLASS || classes[1] == X86_64_SSESF_CLASS)) +{ +return ReturnKind::RegistersIntFp; } return ReturnKind::RegistersGeneral; } diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.hxx b/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.hxx index db1ed75aa243..3ef80543ac76 100644 --- a/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.hxx +++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.hxx @@ -54,7 +54,8 @@ bool return_in_hidden_param( typelib_TypeDescriptionReference *pTypeRef ) noexce enum class ReturnKind { Memory, RegistersGeneral, -RegistersSpecial +RegistersFpInt, +RegistersIntFp }; ReturnKind getReturnKind(typelib_TypeDescriptionReference * type) noexcept; diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s b/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s index ee8403ab7180..53bfea8b254f 100644 --- a/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s +++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s @@ -55,17 +55,22 @@ privateSnippetExecutor: callcpp_vtable_call - cmp $1, %rax - je .Lspecial + testl %eax, %eax + je .Lfpint + jg .Lintfp movq-144(%rbp), %rax# Potential return value (general case) movq-136(%rbp), %rdx# Potential return value (general case) movq-144(%rbp), %xmm0 # Potential return value (general case) movq-136(%rbp), %xmm1 # Potential return value (general case) jmp .Lfinish -.Lspecial: +.Lfpint: movq-144(%rbp), %xmm0 # Return value (special fp and integer case) movq-136(%rbp), %rax# Return value (special fp and integer case) + jmp .Lfinish +.Lintfp: + movq-144(%rbp), %rax# Return value (special integer and fp case) + movq-136(%rbp), %xmm0 # Return value (special integer and fp case) .Lfinish: leave diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx index 4bf5061a472f..de393582f99a 100644 --- a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx +++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx @@ -246,16 +246,24 @@ static int cpp2uno_call( { TYPELIB_DANGER_RELEASE( pReturnTypeDescr ); } -return returnKind == x86_64::ReturnKind::RegistersSpecial ? 1 : 0; +switch (returnKind) { +case x86_64::ReturnKind::RegistersFpInt: +return 0; +
[Libreoffice-bugs] [Bug 143692] FILEOPEN DOCX Outline level is not inherited from style assigned as Chapter Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=143692 Justin L changed: What|Removed |Added Summary|FILEOPEN DOCX Outline level |FILEOPEN DOCX Outline level |is not inherited from |is not inherited from style |Heading 1 style |assigned as Chapter ||Numbering Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Justin L --- To do this "very well" will be rather tricky. The problem is ALL in how LibreOffice implements "Chapter Numbering" - which is a uniquely LO concept. It would be fairly simple to duplicate the outlineLevel into every style that should inherit, but that would make it harder to manage nested styles. It is only NECESSARY to do this for styles that inherit from whatever gets stuck into Chapter Numbering (although identifying that is not trivial). Since OutlineLevel is a rather obscure setting, it probably wouldn't be too bad to spam it as an attribute onto every inheriting style. (We already do so much spamming as it is, so what is one more instance...) This has nothing to do with "Heading X" styles, so don't make that assumption. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143664] sdf date time recognition fails for march ("Mär") in German
https://bugs.documentfoundation.org/show_bug.cgi?id=143664 --- Comment #6 from Julien Nabet --- Thank you Eike for your feedback! It seems locale data should be able to deal with lists to have something clean instead of increasing a kludge. Vollbracht: as a workaround, you may change "Mär" by "Mrz" or "März" so it'll be recognized as a date. -- You are receiving this mail because: You are the assignee for the bug.
Week #8 report
Hi everyone, This week, I completed my refactoring task and got it merged. Link for it is as follows : https://gerrit.libreoffice.org/c/core/+/117918 In the upcoming weeks, I will be working on my stretch goal, i.e , implementing the UI for Character Styles. I have already started working on it. The link for it is as follows : https://gerrit.libreoffice.org/c/core/+/119834 If you have any questions, please let me know. Thanks and Regards Anshu
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 --- Comment #7 from Julien Nabet --- (In reply to Miklos Vajna from comment #6) > The function already returns 0 in various other error cases, you could > probably do the same just before the div by 0 would happen. Unless Thorsten > has a better suggestion. :-) Have you got an example of these other locations? Indeed, I git grepped in slideshow dir "mnMinDuration" and "mnMinSimpleDuration", I don't see any examples to prevent from a division by 0. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143673] LibreOffice logo / banner bad display in Start Center in GNOME dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=143673 Buovjaga changed: What|Removed |Added Keywords||bibisectRequest --- Comment #4 from Buovjaga --- Oops, can't bisect yet as it is not seen in the latest of 7.3 repo: commit d1abf4acc1ed26e35ff1347dd5bf0b4ac4f0c70a (HEAD -> master, origin/master, origin/HEAD) Author: Jenkins Build User Date: Fri Jul 23 17:33:54 2021 +0200 source sha:612d5b1a04fe022a34018d901bb9b052791d54e5 source sha:612d5b1a04fe022a34018d901bb9b052791d54e5 But good to know it is between that and source hash 1dd4a80fa076bedb3a82821517036bad8dd79857 -- You are receiving this mail because: You are the assignee for the bug.