[Libreoffice-bugs] [Bug 113364] [META] Transitional OOXML imported or exported that has different results in Office 2010 and 2013

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113364
Bug 113364 depends on bug 81507, which changed state.

Bug 81507 Summary: FILESAVE: DOCX - w:sdtContent not exported correctly 
resulting in missing line breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=81507

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113363] [META] DOCX (OOXML) content control-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113363
Bug 113363 depends on bug 81507, which changed state.

Bug 81507 Summary: FILESAVE: DOCX - w:sdtContent not exported correctly 
resulting in missing line breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=81507

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source

[Vasily Melenchuk (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf81507.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx   |   22 ++
 sw/source/filter/ww8/docxattributeoutput.cxx |   58 ---
 sw/source/filter/ww8/docxattributeoutput.hxx |3 +
 writerfilter/source/dmapper/DomainMapper.cxx |3 +
 writerfilter/source/ooxml/model.xml  |5 +-
 6 files changed, 84 insertions(+), 7 deletions(-)

New commits:
commit 75a49947c2eeb831a8e02192f1c4856eac62a743
Author: Vasily Melenchuk 
AuthorDate: Thu Nov 11 10:39:32 2021 +0300
Commit: Thorsten Behrens 
CommitDate: Thu Nov 18 08:42:43 2021 +0100

tdf#81507: word content control support for w:multiLine

 is now supported for import/export
to DOCX. Like other content control items it is stored in
grabbag.

Change-Id: Id6f1aa0072dc5db980d0fa43cab4b38a0aa047fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125024
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf81507.docx 
b/sw/qa/extras/ooxmlexport/data/tdf81507.docx
new file mode 100644
index ..2c00ee44cb24
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf81507.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index 36555f71a671..0a7879269a75 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -115,6 +115,28 @@ DECLARE_OOXMLEXPORT_TEST(testTdf142407, "tdf142407.docx")
 CPPUNIT_ASSERT_EQUAL( sal_Int16(36), nGridLines);   // was 23, left large 
space before text.
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf81507, "tdf81507.docx")
+{
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+   return; // initial import, no futher checks
+
+// Ensure that we have 
+CPPUNIT_ASSERT_EQUAL(OUString("1"), getXPath(pXmlDoc, 
"/w:document/w:body/w:sdt[1]/w:sdtPr/w:text", "multiLine"));
+
+// Ensure that we have 
+CPPUNIT_ASSERT_EQUAL(OUString("0"), getXPath(pXmlDoc, 
"/w:document/w:body/w:sdt[2]/w:sdtPr/w:text", "multiLine"));
+
+// Ensure that we have 
+getXPath(pXmlDoc, "/w:document/w:body/w:sdt[3]/w:sdtPr/w:text", "");
+
+// Ensure that we have no  (not quite correct case, but to ensure 
import/export are okay)
+xmlXPathObjectPtr pXmlObj = getXPathNode(pXmlDoc, 
"/w:document/w:body/w:sdt[4]/w:sdtPr/w:text");
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0),
+   
static_cast(xmlXPathNodeSetGetLength(pXmlObj->nodesetval)));
+xmlXPathFreeObject(pXmlObj);
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf144668, "tdf144668.odt")
 {
 uno::Reference xPara1(getParagraph(1, u"level1"), 
uno::UNO_QUERY);
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 4d49f2bf95a8..9dee5cbf5a5a 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -583,12 +583,18 @@ static OString convertToOOXMLHoriOrientRel(sal_Int16 
nOrientRel)
 }
 }
 
-static void lcl_deleteAndResetTheLists( 
rtl::Reference& pSdtPrTokenChildren, 
rtl::Reference& pSdtPrDataBindingAttrs, 
OUString& rSdtPrAlias)
+static void lcl_deleteAndResetTheLists(
+rtl::Reference& pSdtPrTokenChildren,
+rtl::Reference& pSdtPrDataBindingAttrs,
+rtl::Reference& pSdtPrTextAttrs,
+OUString& rSdtPrAlias)
 {
 if( pSdtPrTokenChildren.is() )
 pSdtPrTokenChildren.clear();
 if( pSdtPrDataBindingAttrs.is() )
 pSdtPrDataBindingAttrs.clear();
+if (pSdtPrTextAttrs.is())
+pSdtPrTextAttrs.clear();
 if (!rSdtPrAlias.isEmpty())
 rSdtPrAlias.clear();
 }
@@ -797,14 +803,14 @@ void DocxAttributeOutput::EndParagraph( 
ww8::WW8TableNodeInfoInner::Pointer_t pT
 m_pSerializer->endElementNS( XML_w, XML_p );
 // on export sdt blocks are never nested ATM
 if( !m_bAnchorLinkedToNode && !m_bStartedParaSdt )
-WriteSdtBlock( m_nParagraphSdtPrToken, m_pParagraphSdtPrTokenChildren, 
m_pParagraphSdtPrTokenAttributes, m_pParagraphSdtPrDataBindingAttrs, 
m_aParagraphSdtPrAlias, /*bPara=*/true );
+WriteSdtBlock( m_nParagraphSdtPrToken, m_pParagraphSdtPrTokenChildren, 
m_pParagraphSdtPrTokenAttributes, m_pParagraphSdtPrDataBindingAttrs, 
m_pParagraphSdtPrTextAttrs, m_aParagraphSdtPrAlias, /*bPara=*/true );
 else
 {
 //These should be written out to the actual Node and not to the anchor.
 //Clear them as they will be repopulated when the node is processed.
 m_nParagraphSdtPrToken = 0;
 m_bParagraphSdtHasId = false;
-lcl_deleteAndResetTheLists( m_pParagraphSdtPrTokenChildren, 
m_pParagraphSdtPrDataBindingAttrs, m_aParagraphSdtPrAlias );
+lcl_deleteAndResetTheLists( m_pParagraphSdtPrTokenChildren, 
m_pParagraphSdtPrDataBindingAttrs, m_pParagraphSdtPrTextAttrs, 
m_aParagraphSdtPrAlias );
 }
 
 

[Libreoffice-bugs] [Bug 145518] Feature suggestion -- add Comments field to Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145518

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145518] Feature suggestion -- add Comments field to Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145518

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 127594] [META] Javascript Macro bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127594

Dieter  changed:

   What|Removed |Added

 Depends on||145527


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145527
[Bug 145527] NoClassDefFound Error in Java Macro when trying to load another
class
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145527] NoClassDefFound Error in Java Macro when trying to load another class

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145527

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
  Component|Writer  |LibreOffice
 Blocks||127594


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127594
[Bug 127594] [META] Javascript Macro bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145518] Feature suggestion -- add Comments field to Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145518

Timur  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 OS|Windows (All)   |All
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Status|NEEDINFO|UNCONFIRMED
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145518] Feature suggestion -- add Comments field to Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145518

Timur  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 OS|Windows (All)   |All
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Status|NEEDINFO|UNCONFIRMED
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 145749] New: Image/shape rotation angle float support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145749

Bug ID: 145749
   Summary: Image/shape rotation angle float support
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: benk...@gmx.de

In LibreOffice 5 an image or shape could be rotated by a float value (e.g.
0.1°). However this is not anymore possible in newer version. Entering a float
value like 0.1° treats it as 0°; entering a float value like 0.7° rounds it to
1°. This behaviour should be changed because minor adjustments are an important
feature to be supported because one-degree-steps are way to big especially for
lare images.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 62196] EDITING: copy-paste from non-LibO-text-source pastes previous clipboard contents (see comment 62)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62196

--- Comment #142 from Mike Kaganski  ---
(In reply to Rainer Bielefeld Retired from comment #141)

Hi Rainer! Great to see you, even though it is not the most pleasant problem
that caused your comment :-)

Please see comment 133 - and definitely please do not continue this issue, but
create a new, and add this to its See Also. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145518] Feature suggestion -- add Comments field to Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145518

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #3 from Dieter  ---
KMM, thank you for your idea. But I'm not sure, if I understand it correctly.
Do you want to add a comment field to the paragraph styles dialog (for example
in organizer tab)? Use case might be that you have a template that should be
used by different persons ad every person should know, when to use a certain
style. Is this the idea?

=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sw/qa writerfilter/source

[Vasily Melenchuk (via logerrit)]

 sw/qa/uitest/data/tdf145215.docx |binary
 sw/qa/uitest/writer_tests5/tdf145215.py  |   24 +++
 writerfilter/source/dmapper/NumberingManager.cxx |9 
 3 files changed, 24 insertions(+), 9 deletions(-)

New commits:
commit 43f8051986042a2c7943c716e764f4cfdd81723c
Author: Vasily Melenchuk 
AuthorDate: Sat Oct 23 11:48:07 2021 +0200
Commit: Thorsten Behrens 
CommitDate: Thu Nov 18 08:12:43 2021 +0100

tdf#145215: docx: do not initialize prefix/suffix and include levels

On DOCX import we do not need to provide prefix, suffix and included
levels: these values are calculated in SvxNumberFormat out from list
format. Moreover these values are incorrect and do not correspond
not to DOCX data nor to internal writer representation of list level.

For 7.2 backport testcase was stripped: original testcase relies
on tdf#141964 changes not backproted to 7.2. Thus for test doc
"Chapter Numbering" dialog still looks weird.

Change-Id: I91ec9de679e67056ba3746f2e1a0bd923532d76c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124090
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124136
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/uitest/data/tdf145215.docx b/sw/qa/uitest/data/tdf145215.docx
new file mode 100644
index ..b91d13b286c8
Binary files /dev/null and b/sw/qa/uitest/data/tdf145215.docx differ
diff --git a/sw/qa/uitest/writer_tests5/tdf145215.py 
b/sw/qa/uitest/writer_tests5/tdf145215.py
new file mode 100644
index ..479e7f009e58
--- /dev/null
+++ b/sw/qa/uitest/writer_tests5/tdf145215.py
@@ -0,0 +1,24 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_url_for_data_file, get_state_as_dict
+
+class Tdf145215(UITestCase):
+
+def test_tdf145215(self):
+writer_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf145215.docx"))
+
+# Check field value (there is only one field)
+textfields = writer_doc.getTextFields()
+textfields.refresh()
+for textfield in textfields:
+
self.assertTrue(textfield.supportsService("com.sun.star.text.TextField.GetReference"))
+self.assertEqual(textfield.CurrentPresentation, "1.2.1(i)")
+
+self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/writerfilter/source/dmapper/NumberingManager.cxx 
b/writerfilter/source/dmapper/NumberingManager.cxx
index 9a3f372d7161..6b2d118a2464 100644
--- a/writerfilter/source/dmapper/NumberingManager.cxx
+++ b/writerfilter/source/dmapper/NumberingManager.cxx
@@ -548,8 +548,6 @@ void ListDef::CreateNumberingRules( DomainMapper& rDMapper,
 
aLvlProps.push_back(comphelper::makePropertyValue(getPropertyName(PROP_CHAR_STYLE_NAME),
 sStyle));
 }
 
-// Get the prefix / suffix / Parent numbering
-// and add them to the level properties
 OUString sText = pAbsLevel
? pAbsLevel->GetBulletChar()
: OUString();
@@ -557,15 +555,8 @@ void ListDef::CreateNumberingRules( DomainMapper& rDMapper,
 if (pLevel && pLevel->HasBulletChar())
 sText = pLevel->GetBulletChar( );
 
-
aLvlProps.push_back(comphelper::makePropertyValue(getPropertyName(PROP_PREFIX), 
OUString("")));
-
aLvlProps.push_back(comphelper::makePropertyValue(getPropertyName(PROP_SUFFIX), 
OUString("")));
 
aLvlProps.push_back(comphelper::makePropertyValue(getPropertyName(PROP_LIST_FORMAT),
 sText));
 
-// Total count of replacement holders is determining amount of 
required parent numbering to include
-// TODO: not sure how "%" symbol is escaped. This is not supported 
yet
-sal_Int16 nParentNum = comphelper::string::getTokenCount(sText, 
'%');
-
aLvlProps.push_back(comphelper::makePropertyValue(getPropertyName(PROP_PARENT_NUMBERING),
 nParentNum));
-
 
aLvlProps.push_back(comphelper::makePropertyValue(getPropertyName(PROP_POSITION_AND_SPACE_MODE),
 sal_Int16(text::PositionAndSpaceMode::LABEL_ALIGNMENT)));
 
 // Replace the numbering rules for the level

[Libreoffice-bugs] [Bug 62196] EDITING: copy-paste from non-LibO-text-source pastes previous clipboard contents (see comment 62)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62196

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #141 from Rainer Bielefeld Retired 
 ---
Created attachment 176329
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176329=edit
Screenshot from clipboard history

This problem has never been mine - until I switched to WIN10:

REPRODUCIBLE with Installation of Version:7.2.1.2 (x64); Build ID:
87b77fad49947c1441b67c559c339af8f3517e22; CPU threads: 12; OS: Windows 10.0
Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI:
de-DE; Calc: threaded  |  my default User Profile

Sometimes everything works fine, sometimes it's worse than hell. In "hell case"
a) all other applecations: paste will insert the "D:\Dateien\..." string
b) LibO: paste will insert "Kennzeichnung in der Auflistung ..."   
   (previous contents)

Additional info:
-
c) Until now I don't know a way how to make the problem 100%reproducible
d) Problem is not related to activated WIN10 feature "clipboard history"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/uibase/docvw/edtwin.cxx |9 -
 1 file changed, 9 deletions(-)

New commits:
commit 1d80f90afb479227044bdf0876c5576007abfdce
Author: Miklos Vajna 
AuthorDate: Wed Nov 17 20:06:53 2021 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 18 08:09:54 2021 +0100

sw: remove useless debug code in SwEditWin

The IsCursorInProtectedArea user pref flag can already toggle this, so
this is not needed.

Change-Id: I67fef0ee208f916e3af98a4215287d5c79908434
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125427
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/uibase/docvw/edtwin.cxx 
b/sw/source/uibase/docvw/edtwin.cxx
index b38b0a521326..52022b1a465a 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -1627,15 +1627,6 @@ void SwEditWin::KeyInput(const KeyEvent )
 case SwKeyState::CheckKey:
 eKeyState = SwKeyState::KeyToView;   // default forward to View
 
-#if OSL_DEBUG_LEVEL > 1
-//
-// for switching cursor behaviour in ReadOnly regions
-if( 0x7210 == rKeyCode.GetFullCode() )
-rSh.SetReadOnlyAvailable( !rSh.IsReadOnlyAvailable() );
-else
-//
-#endif
-
 if (!comphelper::LibreOfficeKit::isActive() &&
 !rKeyCode.IsMod2() && '=' == aCh &&
 !rSh.IsTableMode() && rSh.GetTableFormat() &&

[Libreoffice-commits] core.git: include/oox oox/source

[Sarper Akdemir (via logerrit)]

 include/oox/drawingml/color.hxx  |1 +
 oox/source/drawingml/color.cxx   |   16 
 oox/source/drawingml/textcharacterproperties.cxx |1 +
 3 files changed, 18 insertions(+)

New commits:
commit 3ed69deb04cca67e377c15956679f7bb9794e4ff
Author: Sarper Akdemir 
AuthorDate: Wed Aug 25 02:24:42 2021 +0300
Commit: Miklos Vajna 
CommitDate: Thu Nov 18 08:08:14 2021 +0100

implement color tint or shade import for pptx

[ Miklos: althought the PowerPoint UI doesn't seem to have a way to
generate this markup. ]

(cherry picked from commit de40c940c3a94588d44a3d1f6d8cd4191cca4f73)

Change-Id: Ibf98ba335b10859e4d6d702263f09e6ba2033bff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125426
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/oox/drawingml/color.hxx b/include/oox/drawingml/color.hxx
index 00473cfe6f27..bd67982c6e92 100644
--- a/include/oox/drawingml/color.hxx
+++ b/include/oox/drawingml/color.hxx
@@ -99,6 +99,7 @@ public:
 /** Returns the scheme name from the a:schemeClr element for 
interoperability purposes */
 const OUString& getSchemeColorName() const { return msSchemeName; }
 sal_Int16   getSchemeColorIndex() const;
+sal_Int16   getTintOrShade();
 
 /** Returns the unaltered list of transformations for interoperability 
purposes */
 const css::uno::Sequence< css::beans::PropertyValue >& 
getTransformations() const { return maInteropTransformations;}
diff --git a/oox/source/drawingml/color.cxx b/oox/source/drawingml/color.cxx
index 2ced5345904e..426197102160 100644
--- a/oox/source/drawingml/color.cxx
+++ b/oox/source/drawingml/color.cxx
@@ -479,6 +479,22 @@ void Color::clearTransparence()
 mnAlpha = MAX_PERCENT;
 }
 
+sal_Int16 Color::getTintOrShade()
+{
+for(auto const& aTransform : maTransforms)
+{
+switch(aTransform.mnToken)
+{
+case XML_tint:
+// from 1000th percent to 100th percent...
+return aTransform.mnValue/10;
+case XML_shade:
+// from 1000th percent to 100th percent...
+return -aTransform.mnValue/10;
+}
+}
+return 0;
+}
 ::Color Color::getColor( const GraphicHelper& rGraphicHelper, ::Color nPhClr ) 
const
 {
 const sal_Int32 nTempC1 = mnC1;
diff --git a/oox/source/drawingml/textcharacterproperties.cxx 
b/oox/source/drawingml/textcharacterproperties.cxx
index 90b0e38c1d3a..bd4d051a490b 100644
--- a/oox/source/drawingml/textcharacterproperties.cxx
+++ b/oox/source/drawingml/textcharacterproperties.cxx
@@ -113,6 +113,7 @@ void TextCharacterProperties::pushToPropMap( PropertyMap& 
rPropMap, const XmlFil
 rPropMap.setProperty(PROP_CharColor, 
aColor.getColor(rFilter.getGraphicHelper()));
 // set color theme index
 rPropMap.setProperty(PROP_CharColorTheme, 
aColor.getSchemeColorIndex());
+rPropMap.setProperty(PROP_CharColorTintOrShade, 
aColor.getTintOrShade());
 
 if (aColor.hasTransparency())
 {

[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103314

Dieter  changed:

   What|Removed |Added

 Depends on||145510


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145510
[Bug 145510] Writer erase template files on directory setting update
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145510] Writer erase template files on directory setting update

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145510

Dieter  changed:

   What|Removed |Added

 Blocks||103314


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103314
[Bug 103314] [META] Templates bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145695] List x86 openJDK JRE with libreoffice x64

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145695

Stephan Bergmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |sberg...@redhat.com
   |desktop.org |
 Status|UNCONFIRMED |RESOLVED

--- Comment #8 from Stephan Bergmann  ---
This is a regression introduced with

"tdf#124503: Support JRE installations with unknown java.vendor property" that
will be fixed in LibreOffice 7.3 thanks to

"Make getVersionInformation always return a VersionInfo".

(What happens is that in jfw_plugin_getAllJavaInfos in
jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx, in the loop across all
vecInfos, checkJavaVersionRequirements was only called for a given vecInfo if

> vendorSettings.getVersionInformation(vecInfo->getVendor())

returns something, which it did not for a vecInfo representing a JRE from a
vendor not listed in gVendorMap in
jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx, like "Eclipse Adoptium".)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
Bug 129062 depends on bug 143837, which changed state.

Bug 143837 Summary: Skia: Curve rendering broken with fat stroke
https://bugs.documentfoundation.org/show_bug.cgi?id=143837

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143837] Skia: Curve rendering broken with fat stroke

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143837

Luboš Luňák  changed:

   What|Removed |Added

 CC||l.lu...@collabora.com
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143837] Skia: Curve rendering broken with fat stroke

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143837

--- Comment #2 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5e6e45eb4247bf8bd57d157b44f49577dde38716

handle also curved lines for nojoin skia polylines (tdf#143837)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143837] Skia: Curve rendering broken with fat stroke

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143837

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/skia

[Luboš Luňák (via logerrit)]

 vcl/skia/gdiimpl.cxx |   47 ++-
 1 file changed, 22 insertions(+), 25 deletions(-)

New commits:
commit 5e6e45eb4247bf8bd57d157b44f49577dde38716
Author: Luboš Luňák 
AuthorDate: Wed Nov 17 16:35:31 2021 +0100
Commit: Luboš Luňák 
CommitDate: Thu Nov 18 08:01:12 2021 +0100

handle also curved lines for nojoin skia polylines (tdf#143837)

Change-Id: I2f5aa12eb656f6b337843d81a2a30de277dff7b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125410
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 6a01601662a4..f15954f95117 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -55,33 +55,28 @@ namespace
 // bottom-most line of pixels of the bounding rectangle (see
 // 
https://lists.freedesktop.org/archives/libreoffice/2019-November/083709.html).
 // So be careful with rectangle->polygon conversions (generally avoid them).
-void addPolygonToPath(const basegfx::B2DPolygon& rPolygon, SkPath& rPath,
-  bool* hasOnlyOrthogonal = nullptr)
+void addPolygonToPath(const basegfx::B2DPolygon& rPolygon, SkPath& rPath, 
sal_uInt32 nFirstIndex,
+  sal_uInt32 nLastIndex, const sal_uInt32 nPointCount, 
const bool bClosePath,
+  const bool bHasCurves, bool* hasOnlyOrthogonal = nullptr)
 {
-const sal_uInt32 nPointCount(rPolygon.count());
+assert(nFirstIndex < nPointCount);
+assert(nLastIndex <= nPointCount);
 
 if (nPointCount <= 1)
 return;
 
-const bool bClosePath(rPolygon.isClosed());
-const bool bHasCurves(rPolygon.areControlPointsUsed());
-
 bool bFirst = true;
+sal_uInt32 nPreviousIndex = nFirstIndex == 0 ? nPointCount - 1 : 
nFirstIndex - 1;
+basegfx::B2DPoint aPreviousPoint = rPolygon.getB2DPoint(nPreviousIndex);
 
-sal_uInt32 nCurrentIndex = 0;
-sal_uInt32 nPreviousIndex = nPointCount - 1;
-
-basegfx::B2DPoint aCurrentPoint;
-basegfx::B2DPoint aPreviousPoint;
-
-for (sal_uInt32 nIndex = 0; nIndex <= nPointCount; nIndex++)
+for (sal_uInt32 nIndex = nFirstIndex; nIndex <= nLastIndex; nIndex++)
 {
 if (nIndex == nPointCount && !bClosePath)
 continue;
 
 // Make sure we loop the last point to first point
-nCurrentIndex = nIndex % nPointCount;
-aCurrentPoint = rPolygon.getB2DPoint(nCurrentIndex);
+sal_uInt32 nCurrentIndex = nIndex % nPointCount;
+basegfx::B2DPoint aCurrentPoint = rPolygon.getB2DPoint(nCurrentIndex);
 
 if (bFirst)
 {
@@ -132,12 +127,19 @@ void addPolygonToPath(const basegfx::B2DPolygon& 
rPolygon, SkPath& rPath,
 aPreviousPoint = aCurrentPoint;
 nPreviousIndex = nCurrentIndex;
 }
-if (bClosePath)
+if (bClosePath && nFirstIndex == 0 && nLastIndex == nPointCount)
 {
 rPath.close();
 }
 }
 
+void addPolygonToPath(const basegfx::B2DPolygon& rPolygon, SkPath& rPath,
+  bool* hasOnlyOrthogonal = nullptr)
+{
+addPolygonToPath(rPolygon, rPath, 0, rPolygon.count(), rPolygon.count(), 
rPolygon.isClosed(),
+ rPolygon.areControlPointsUsed(), hasOnlyOrthogonal);
+}
+
 void addPolyPolygonToPath(const basegfx::B2DPolyPolygon& rPolyPolygon, SkPath& 
rPath,
   bool* hasOnlyOrthogonal = nullptr)
 {
@@ -1246,7 +1248,6 @@ bool SkiaSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectToDev
 {
 SkPath aPath;
 aPath.incReserve(aPolyLine.count() * 3); // because cubicTo is 3 
elements
-aPath.setFillType(SkPathFillType::kEvenOdd);
 addPolygonToPath(aPolyLine, aPath);
 aPath.offset(toSkX(0) + posFix, toSkY(0) + posFix, nullptr);
 addUpdateRegion(aPath.getBounds());
@@ -1256,16 +1257,12 @@ bool SkiaSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectToDev
 {
 sal_uInt32 nPoints = aPolyLine.count();
 bool bClosed = aPolyLine.isClosed();
-for (sal_uInt32 j = 0; j < (bClosed ? nPoints : nPoints - 1); ++j)
+bool bHasCurves = aPolyLine.areControlPointsUsed();
+for (sal_uInt32 j = 0; j < nPoints; ++j)
 {
-sal_uInt32 index1 = (j + 0) % nPoints;
-sal_uInt32 index2 = (j + 1) % nPoints;
 SkPath aPath;
-aPath.moveTo(aPolyLine.getB2DPoint(index1).getX(),
- aPolyLine.getB2DPoint(index1).getY());
-aPath.lineTo(aPolyLine.getB2DPoint(index2).getX(),
- aPolyLine.getB2DPoint(index2).getY());
-
+aPath.incReserve(2 * 3); // because cubicTo is 3 elements
+addPolygonToPath(aPolyLine, aPath, j, j + 1, nPoints, bClosed, 
bHasCurves);
 aPath.offset(toSkX(0) + posFix, toSkY(0) + posFix, nullptr);
 addUpdateRegion(aPath.getBounds());
 getDrawCanvas()->drawPath(aPath, aPaint);

[Libreoffice-bugs] [Bug 145712] Error when opening dbf files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145712

--- Comment #4 from Olivier Berten  ---
That's exactly what I say in my bug report: it opens fine on Win10 but not on
Ubuntu.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

--- Comment #7 from Mike Kaganski  ---
(In reply to Wolfgang Jäger from comment #6)
> I feel lost considering the consequences for users Of VBA in
> LibO generally. And what would be the effect if LiBO running code under
> VBAsupport 1 Would revert the byte order for the RGB result to its own
> habit. Where are RGB results ever exported to the file except when assigned
> to a colored object? The visible color is interpreted the LibO way, of
> course, and written after encoding it the LibO way.

This is a very good concern.

MS RGB implementation follows MS COLORREF datatype [1]. So whenever one wants
to use the color value in a WinAPI call (which is rather common in VBA), or
when one works with file IO, it may be crucial to use specific byte order. So
in compatibility mode, there's an interoperability with Windows API, but lack
of interoperability with own API working with colors.

OTOH, there's unclear aspect of cross-platform operation. WinAPI (and VBA) are
likely defined in terms of their (only) endianness? Which is little-endian
(even NT on Alpha was little-endian). Then on big-endian platforms, the byte
order should be reversed.

Anyway, I'd simply document it carefully in help (the documentation in code is
already done by Julien), and right there in the help would suggest a
recommended code that would not depend on the compatibility mode.

[1] https://docs.microsoft.com/en-us/windows/win32/gdi/colorref

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basctl/source

[Heiko Tietze (via logerrit)]

 basctl/source/basicide/linenumberwindow.cxx |4 +++-
 basctl/source/basicide/linenumberwindow.hxx |1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

New commits:
commit f0334d62da608e140073e8831fdbbd0b5e4b1e39
Author: Heiko Tietze 
AuthorDate: Wed Nov 17 15:38:02 2021 +0100
Commit: Heiko Tietze 
CommitDate: Thu Nov 18 07:02:26 2021 +0100

Resolves tdf#143462 - Fixes black row number on dark backgroud in Basic IDE

Using WindowColor for background and WindowTextColor for font color now

Change-Id: Ie7bcb66d43673722ac882ac3cd59c7d9106f3020
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125403
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/basctl/source/basicide/linenumberwindow.cxx 
b/basctl/source/basicide/linenumberwindow.cxx
index be9fe3752045..7dcbff0ddd7f 100644
--- a/basctl/source/basicide/linenumberwindow.cxx
+++ b/basctl/source/basicide/linenumberwindow.cxx
@@ -21,7 +21,8 @@ LineNumberWindow::LineNumberWindow(vcl::Window* pParent, 
ModulWindow* pModulWind
 , m_pModulWindow(pModulWindow)
 , m_nCurYOffset(0)
 {
-SetBackground(Wallpaper(GetSettings().GetStyleSettings().GetFieldColor()));
+
SetBackground(Wallpaper(GetSettings().GetStyleSettings().GetWindowColor()));
+m_FontColor = GetSettings().GetStyleSettings().GetWindowTextColor();
 m_nBaseWidth = GetTextWidth("8");
 m_nWidth = m_nBaseWidth * 3 + m_nBaseWidth / 2;
 }
@@ -78,6 +79,7 @@ void LineNumberWindow::Paint(vcl::RenderContext& 
rRenderContext, const tools::Re
 }
 
 sal_Int64 y = (nStartLine - 1) * static_cast(nLineHeight);
+rRenderContext.SetTextColor(m_FontColor);
 for (sal_uInt32 n = nStartLine; n <= nEndLine; ++n, y += nLineHeight)
 rRenderContext.DrawText(Point(0, y - m_nCurYOffset), 
OUString::number(n));
 }
diff --git a/basctl/source/basicide/linenumberwindow.hxx 
b/basctl/source/basicide/linenumberwindow.hxx
index 14305116ef10..a2e457f71103 100644
--- a/basctl/source/basicide/linenumberwindow.hxx
+++ b/basctl/source/basicide/linenumberwindow.hxx
@@ -22,6 +22,7 @@ private:
 int m_nWidth;
 tools::Long m_nCurYOffset;
 int m_nBaseWidth;
+Color m_FontColor;
 virtual void DataChanged(DataChangedEvent const& rDCEvt) override;
 
 protected:

[Libreoffice-bugs] [Bug 145207] One click and three presses of TABs crashes Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145207

--- Comment #5 from Jim Raykowski  ---
To fix this we can either move among the drawing and image objects or add a new
row to the table as Mike said happens in OOo 2.2.0. 

First stab was one that assures standard mode in SwCursorShell::GoNextCell,
which allows a new row to be added to the table without crashing. Second stab,
which I think is probably better as it is the behavior when in read-only mode,
is to make the Tab key move to the next drawing or image object. 

Here are links to both patches:
https://gerrit.libreoffice.org/c/core/+/125434
https://gerrit.libreoffice.org/c/core/+/125435

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145708] Libre Office Freezes when Remote File Menu is touched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145708

--- Comment #3 from Stephen Dol  ---
Hi Rainer,

This has resolved the issue.

Many thanks.

Regards, Steve.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145531] FILEOPEN PPTX: 3D button/cuboid with perspective shows as rectangle

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145531

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145530] Text which should be pasted below the image ends up above the image (CF_OEMTEXT Paste?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145530

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145529] Auto Fill leaves zombie Text after input string no longer matches autofill "template prototype"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145529

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145527] NoClassDefFound Error in Java Macro when trying to load another class

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145527

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145522] Libreoffice 7.2.1.2 cannot change any menue with mouse FreeBSD 13.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145522

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145520] LODraw: Export dialog forgets last used format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145520

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145515] Does LibreOffice alter xls files such that Excel 2004 must be force-quit?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145515

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145518] Feature suggestion -- add Comments field to Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145518

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141489] Inserting an image in a page with other images, sometimes other images disappear.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141489

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145487] UI BASIC - Macro causes infinite sheets to be added

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145487

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142323] LibreOffice writer often changes the numbering font while editing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142323

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142323] LibreOffice writer often changes the numbering font while editing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142323

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141489] Inserting an image in a page with other images, sometimes other images disappear.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141489

--- Comment #3 from QA Administrators  ---
Dear David Horrocks,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136095] LibreOffice 7.0.0.3 (x64) Calc problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136095

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136095] LibreOffice 7.0.0.3 (x64) Calc problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136095

--- Comment #5 from QA Administrators  ---
Dear Robert,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142401] LibreOffice writer: stucks forever when collapsing between pages on Windows 7

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142401

--- Comment #3 from QA Administrators  ---
Dear Lei Zhehan,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124784] Replace messagebox on file load with user prompt for recalculation by an infobar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124784

--- Comment #11 from QA Administrators  ---
Dear b.,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142323] LibreOffice writer often changes the numbering font while editing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142323

--- Comment #5 from Roger  ---
Created attachment 176328
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176328=edit
Bug 2.odt attached as document with changes after bug occured saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142323] LibreOffice writer often changes the numbering font while editing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142323

--- Comment #4 from Roger  ---
Created attachment 176327
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176327=edit
Bug.odt is the original document, Bug2.odt saved doc after bug occurs.

See previous comments regarding the 2 documents and how to reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142323] LibreOffice writer often changes the numbering font while editing.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142323

--- Comment #3 from Roger  ---
Attached are sample documents, "Bug.odt" and "Bug2.odt". Start with Bug.odt and
select the item on line 1, "Row 1". Type anything over this, such as I have and
saved in Bug2.odt, "Replace Row 1". Notice as I saved the changes in Bug2.odt,
the "1." line number font changed to a larger and perhaps bolder font. Anything
you type from now on will be that larger font and undo will often not undo the
font change. The only hope is to have saved changes before the buggy font
change happened and to reopen the document (requiring very frequent saves to
return to a version before the bug happens). Also copying a line and pasting
above (or below) will cause the line number to change fonts and everything I
type afterwards (this is my typical use case in adding lines to my document
lists).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145748] Text boxes have black background with Skia on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145748

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062

Aron Budea  changed:

   What|Removed |Added

 Depends on||145748


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145748
[Bug 145748] Text boxes have black background with Skia on Mac
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145748] New: Text boxes have black background with Skia on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145748

Bug ID: 145748
   Summary: Text boxes have black background with Skia on Mac
   Product: LibreOffice
   Version: 7.3.0.0.alpha1+
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
CC: thorsten.wagne...@gmail.com
Blocks: 129062

Eg. the fields in Tools -> Options -> User Data, or the various edit boxes with
spinners in the properties sidebar.

See one of the screenshots attached by Thorsten in bug 144214: attachment
176293.

Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: 4c3c94704704e5090c0382476251caee7a904454
CPU threads: 2; OS: Mac OS X 10.15.7; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_HU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
[Bug 129062] [META] Skia library bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145267] Writer crashes when docking or undocking sidebar (AMD Skia problem?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145267

benr...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #6 from benr...@gmail.com ---
Crash Report Tool does not prompt me to send a report. the crash is so instant
that there is no crash report. I provided the content of the dump.ini file
already. I don't know how to provide the link you requested.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145747] Cursor is not shown in edit window after shape is selected then comment window then edit window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145747

--- Comment #1 from Jim Raykowski  ---
Proposed patch:
https://gerrit.libreoffice.org/c/core/+/125431

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/utlui/content.cxx |  196 -
 1 file changed, 111 insertions(+), 85 deletions(-)

New commits:
commit 4be0ae19065b1b50870bc0b2a28189ad39c96a8a
Author: Jim Raykowski 
AuthorDate: Sat Nov 13 18:27:01 2021 -0900
Commit: Jim Raykowski 
CommitDate: Thu Nov 18 00:40:40 2021 +0100

SwNavigator: Improve which entry is selected in the content tree

after the tree is updated and when current document cursor position is
at content that is set to not track

Intended behavior when the content tree display is updated is for the
selected entry before update to be reselected after update if the entry
is still in the tree. Currently, if the selected entry before update is
a content type, the selected entry after update is the first entry in
the tree. If the selected entry before update is not present, e.g. the
selected entry is the only member of a content type and is deleted, the
first entry in the tree is selected. In these cases, this patch changes
the selected entry after update to be the content type entry.

Instead of reselecting by entry name, which can result in incorrect
selection when non unique entry names are possible, as in Headings,
this patch improves entry reselect by comparing unique entry user data.

Content tracking is improved by not falling through to other tracked
content, e.g. when tables are not being tracked and sections are being
tracked, clicking in a table in a section will not select the section
in the content tree, the selected entry in the content tree will be
unchanged.

Change-Id: I8d82059db8688c31c7c0d705445c1d8b4272bec6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125176
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 19af01d363a8..2227cb04f4c8 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -2365,16 +2365,15 @@ void SwContentTree::Display( bool bActive )
 std::unique_ptr xOldSelEntry(m_xTreeView->make_iterator());
 if (!m_xTreeView->get_selected(xOldSelEntry.get()))
 xOldSelEntry.reset();
-OUString sEntryName;  // Name of the entry
+OUString sOldSelEntryId;
 size_t nEntryRelPos = 0; // relative position to their parent
 size_t nOldEntryCount = GetEntryCount();
 sal_Int32 nOldScrollPos = 0;
 if (xOldSelEntry)
 {
 UpdateLastSelType();
-
+sOldSelEntryId = m_xTreeView->get_id(*xOldSelEntry);
 nOldScrollPos = m_xTreeView->vadjustment_get_value();
-sEntryName = m_xTreeView->get_text(*xOldSelEntry);
 std::unique_ptr xParentEntry = 
m_xTreeView->make_iterator(xOldSelEntry.get());
 while (m_xTreeView->get_iter_depth(*xParentEntry))
 m_xTreeView->iter_parent(*xParentEntry);
@@ -2447,40 +2446,44 @@ void SwContentTree::Display( bool bActive )
 for (const auto& rNode : aNodesToExpand)
 m_xTreeView->expand_row(*rNode);
 
-(void)m_xTreeView->get_iter_first(*xEntry);
-for (ContentTypeId nCntType : o3tl::enumrange())
+// reselect the old selected entry if it is available, else select 
the entry that is at
+// the position of the old selected entry
+if (xOldSelEntry)
 {
-sal_Int32 nExpandOptions = (State::HIDDEN == m_eState)
-? m_nHiddenBlock
-: m_nActiveBlock;
-if (nExpandOptions & (1 << static_cast(nCntType)))
+(void)m_xTreeView->get_iter_first(*xEntry);
+for (ContentTypeId nCntType : o3tl::enumrange())
 {
-if (nEntryRelPos && nCntType == m_nLastSelType)
+if (nCntType == m_nLastSelType)
 {
-// reselect the entry
-std::unique_ptr 
xChild(m_xTreeView->make_iterator(xEntry.get()));
-std::unique_ptr xTemp;
-sal_uLong nPos = 1;
-while (m_xTreeView->iter_next(*xChild))
+// nEntryRelPos == 0 means the old selected entry was 
a content type
+if (nEntryRelPos)
 {
-// The old text will be slightly favored
-if (sEntryName == m_xTreeView->get_text(*xChild) ||
-nPos == nEntryRelPos)
+std::unique_ptr 
xIter(m_xTreeView->make_iterator(xEntry.get()));
+std::unique_ptr 
xTemp(m_xTreeView->make_iterator(xIter.get()));
+sal_uLong nPos = 1;
+while (m_xTreeView->iter_next(*xIter) &&
+  

[Libreoffice-bugs] [Bug 145747] New: Cursor is not shown in edit window after shape is selected then comment window then edit window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145747

Bug ID: 145747
   Summary: Cursor is not shown in edit window after shape is
selected then comment window then edit window
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

Created attachment 176326
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176326=edit
test file with instructions to repro bug

Steps to repro:
1) Open attached test file or any file with a shape and comment and some
paragraph text
2) Left mouse-click on a shape
3) Left mouse-click on a comment
4) Either left mouse-click in document paragraph text or press keyboard Esc key

Results: No visible cursor in document window.

Expected results: Visible cursor at position of mouse-click or at comment
anchor position in document.

Repro'd back to: 
Version: 4.2.0.0.alpha1+
Build ID: fc8f44e82de4ebdd50ac5fbb9207cd1a59a927e3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 34133] Add option to automatically compress and resize images: either on insertion or when saving, and via a separate minimize document wizard like Impress has.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34133

--- Comment #88 from Luke  ---
Created attachment 176325
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176325=edit
mockup from Bug 107875

>From both an ease of use and implementation perspective, this seems like the
simplest approach to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145745] Create a "Duplicate sheet" option in LO Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145745

--- Comment #3 from Regina Henschel  ---
For renaming a sheet click on the tab while holding down the Alt-key. That
brings the tab into edit mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145745] Create a "Duplicate sheet" option in LO Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145745

--- Comment #3 from Regina Henschel  ---
For renaming a sheet click on the tab while holding down the Alt-key. That
brings the tab into edit mode.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 145745] Create a "Duplicate sheet" option in LO Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145745

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Click on the tab of the sheet, hold mouse button down and drag the tab while
holding the Ctrl-key. That duplicates the sheet. Without Ctrl-key it moves the
sheet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 145745] Create a "Duplicate sheet" option in LO Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145745

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Click on the tab of the sheet, hold mouse button down and drag the tab while
holding the Ctrl-key. That duplicates the sheet. Without Ctrl-key it moves the
sheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 34133] Add option to automatically compress and resize images: either on insertion or when saving, and via a separate minimize document wizard like Impress has.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34133

Luke  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl

--- Comment #87 from Luke  ---
*** Bug 132652 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132652] Export an image at any resolution without affecting the size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132652

--- Comment #6 from Luke  ---
Telesto,
This is for an individual image in Draw, while Bug 77407 is for images in
multiple document formats "at insertion time". Bug 34133 is for "either on
insertion or when saving" Your request of an export at the time of Save/Publish
is the right one and what other Suites use.  IMO, we should keep the highest
reasonable qualify and avoid destructive edits without the users explicit
direction.

*** This bug has been marked as a duplicate of bug 34133 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

--- Comment #6 from Wolfgang Jäger  ---
(In reply to Julien Nabet from comment #4)
> (In reply to Wolfgang Jäger from comment #3)
> > ...
...
> > But: There is a RGB() function in VBA, 
> > and it expects the arguments in order r, g, b.
> > 
> > See also
> > https://docs.microsoft.com/en-us/office/vba/language/reference/user-
> > interface-help/rgb-function
> 
> The pb isn't the order of arguments when calling the function, both LO and
> MS use R, G and B args in this order but it's a matter of how to store the
> values in one single Long value.
> 
> It's precisely indicated in Mike's link:
> "
> In other words, the individual color components are stored in the opposite
> order one would expect. VB stores the red color component in the low-order
> byte of the long integer's low-order word, the green color in the high-order
> byte of the low-order word, and the blue color in the low-order byte of the
> high-order word
> "
Sorry. 

I simply couldn't imagine such an absurd lack in standards. I should have known
better. 

In addition I feel lost considering the consequences for users Of VBA in LibO
generally. And what would be the effect if LiBO running code under VBAsupport 1
Would revert the byte order for the RGB result to its own habit. Where are RGB
results ever exported to the file except when assigned to a colored object? The
visible color is interpreted the LibO way, of course, and written after
encoding it the LibO way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

--- Comment #5 from Julien Nabet  ---
I submitted a patch on gerrit here:
https://gerrit.libreoffice.org/c/core/+/125430
to document why it's not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: FYI: ccache for MSVC/Windows

[Thorsten Behrens]

Hi Luboš,

thanks for that & the related changes!

Luboš Luňák wrote:
>  Given that AFAIK Windows bots are now the Jenkins bottleneck, I suppose it 
> could help there too, but I'll leave it to the admins to decide when it's a 
> good idea to use a random WIP patched ccache.
> 
Note that ccache performs surprisingly poor on io-starved Windows
setups [1], which possibly is true for the Jenkins VMs.

So there's no way but trying - how about we equip half of the Windows
builders with your ccache.exe & see what we end up with?

Along the same line, I've also recently added support for sccache, but
YMMV there, too (I'd choose ccache over sccache for local caches any
time). Might be interesting for our dev mentoring team though, since
sccache enables sharing of cache content via hyperscaler blob storage
[2].

[1] 
https://gerrit.libreoffice.org/c/core/+/125179/2#message-54c45dace529cc0b577a0a40d4e8200b05ba1e47
[2] https://github.com/mozilla/sccache

Cheers,

-- Thorsten


signature.asc
Description: PGP signature

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

--- Comment #4 from Julien Nabet  ---
(In reply to Wolfgang Jäger from comment #3)
> ...
> I havent access to any MS sogftware with VBA, but...
> Even MS would (hopefully) not use the function name RGB() if expeting
> parameters in the order b, g, r. 
> IF MS use a different color model by default in VBA, they need to name and
> specify their functions respectively. 
> But: There is a RGB() function in VBA, 
> and it expects the arguments in order r, g, b.
> 
> See also
> https://docs.microsoft.com/en-us/office/vba/language/reference/user-
> interface-help/rgb-function

The pb isn't the order of arguments when calling the function, both LO and MS
use R, G and B args in this order but it's a matter of how to store the values
in one single Long value.

It's precisely indicated in Mike's link:
"
In other words, the individual color components are stored in the opposite
order one would expect. VB stores the red color component in the low-order byte
of the long integer's low-order word, the green color in the high-order byte of
the low-order word, and the blue color in the low-order byte of the high-order
word
"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145205] Errormessage when I try to open a certain database table via LibreOffice 7.2 Database - no mysql connector native driver support for BIT datatype

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145205

Julien Nabet  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #8 from Julien Nabet  ---
I gave a try here:
https://gerrit.libreoffice.org/c/core/+/125429

As I put in the comment:
"
Beware, we just want to display the right info here, BIT management in
Mysql/MariaDB
needs some work

There are 2 parts in this patch:
1)
-if (sType.equalsIgnoreAsciiCase("bit") ||
sType.equalsIgnoreAsciiCase("bool")
-|| sType.equalsIgnoreAsciiCase("boolean"))
+if (sType.equalsIgnoreAsciiCase("bit"))
+return css::sdbc::DataType::BIT;
+if (sType.equalsIgnoreAsciiCase("bool") ||
sType.equalsIgnoreAsciiCase("boolean"))
allows to display BIT instead of DATE when editing the table

2)
-return css::sdbc::DataType::VARCHAR;
+return css::sdbc::DataType::BIT;
allows to show a checkbox instead of a field where you can type anything when
opening the table"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

--- Comment #3 from Wolfgang Jäger  ---
(In reply to Mike Kaganski from comment #2)
> https://www.oreilly.com/library/view/vb-vba/1565923588/1565923588_ch07-1860-
> fm2xml.html
> 
> I suppose it is not a bug. The link above explains that the order of the
> color components in the Long, returned from VBA's RGB, is the opposite of
> the expected. So it's not the color is blue, it's an MS color incompatible
> with LO color.
I havent access to any MS sogftware with VBA, but...
Even MS would (hopefully) not use the function name RGB() if expeting
parameters in the order b, g, r. 
IF MS use a different color model by default in VBA, they need to name and
specify their functions respectively. 
But: There is a RGB() function in VBA, 
and it expects the arguments in order r, g, b.

See also
https://docs.microsoft.com/en-us/office/vba/language/reference/user-interface-help/rgb-function

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108912] [META] Sheet-level bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108912

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||145745


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145745
[Bug 145745] Create a "Duplicate sheet" option in LO Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145745] Create a "Duplicate sheet" option in LO Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145745

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Ever confirmed|0   |1
 Blocks||108912

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Yep, would be nice


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108912
[Bug 108912] [META] Sheet-level bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 145745] Create a "Duplicate sheet" option in LO Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145745

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Ever confirmed|0   |1
 Blocks||108912

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Yep, would be nice


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108912
[Bug 108912] [META] Sheet-level bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/writer_tests7/tdf131936.py |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 96e9dad60bf82153bf678a15f93fb77c8cafcf43
Author: Xisco Fauli 
AuthorDate: Wed Nov 17 13:58:08 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Nov 17 21:52:48 2021 +0100

uitest: sw: I don't think this time.sleep is needed

Change-Id: Ic3f5ebb8e41a7f392385e01c9d7f0f89810ca194
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125399
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/writer_tests7/tdf131936.py 
b/sw/qa/uitest/writer_tests7/tdf131936.py
index 773386b658ff..56247711dbfe 100644
--- a/sw/qa/uitest/writer_tests7/tdf131936.py
+++ b/sw/qa/uitest/writer_tests7/tdf131936.py
@@ -4,8 +4,6 @@
 
 from uitest.framework import UITestCase
 from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
-from uitest.config import DEFAULT_SLEEP
-import time
 
 class tdf131936(UITestCase):
 
@@ -13,7 +11,6 @@ class tdf131936(UITestCase):
 with self.ui_test.load_file(get_url_for_data_file("tdf131936.docx")):
 
 with self.ui_test.execute_dialog_through_command(".uno:SaveAs", 
close_button="cancel") as xDialog:
-time.sleep(DEFAULT_SLEEP)
 xFileTypeCombo = xDialog.getChild("file_type")
 state = get_state_as_dict(xFileTypeCombo)
 self.assertEqual(state["SelectEntryText"], "Office Open XML 
Text (Transitional) (.docx)")

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/uitest/chart/create_chart.py |5 -
 1 file changed, 5 deletions(-)

New commits:
commit 69cc5b565d38eb4b50be3b6540138bb1ec880ea4
Author: Xisco Fauli 
AuthorDate: Wed Nov 17 14:02:39 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Nov 17 21:52:25 2021 +0100

uitest: sc: remove sleep

Change-Id: Id1f3eb0ce1dbf9409ef005a01b2fe3bb1e453ac0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125400
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/chart/create_chart.py 
b/sc/qa/uitest/chart/create_chart.py
index 678aca31e564..5a6a9f233a0b 100644
--- a/sc/qa/uitest/chart/create_chart.py
+++ b/sc/qa/uitest/chart/create_chart.py
@@ -10,9 +10,6 @@ from libreoffice.uno.propertyvalue import mkPropertyValues
 from uitest.framework import UITestCase
 from uitest.uihelper.calc import enter_text_to_cell
 
-import time
-import unittest
-
 class CalcChartUIDemo(UITestCase):
 
 def fill_spreadsheet(self):
@@ -78,8 +75,6 @@ class CalcChartUIDemo(UITestCase):
 
 xGridWindow.executeAction("DESELECT", mkPropertyValues({"OBJECT": 
""}))
 
-time.sleep(2)
-
 
 def test_activate_chart(self):
 

[Libreoffice-bugs] [Bug 145205] Errormessage when I try to open a certain database table via LibreOffice 7.2 Database - no mysql connector native driver support for BIT datatype

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145205

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5714

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145714] in Base, the mediumblob MySQL fields are shown as Text[VARCHAR] - no mysql connector native driver support for MEDIUMBLOB datatype.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145714

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5205

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: forms/source

[Julien Nabet (via logerrit)]

 forms/source/solar/component/navbarcontrol.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ae22b5c49c1c0c56cea2022c2979568b7fa4871e
Author: Julien Nabet 
AuthorDate: Wed Nov 17 18:25:38 2021 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 17 21:45:29 2021 +0100

tdf#145731: fix crash closing document

Regression from:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=73334560b2dd2d60ac58d2cc2b1a5295490b03e1
author  Julien Nabet   2021-11-07 15:40:37 +0100
committer   Julien Nabet   2021-11-07 21:58:53 
+0100
commit  73334560b2dd2d60ac58d2cc2b1a5295490b03e1 (patch)
treeb5bc4f69dd8ed455c78ea05ab1c5e2f3c25b909e
parent  6be03ac71e0d4927612b4a57ead3d0b245c29c77 (diff)
Replace some macros in forms part 16

Thank you Xisco for having spotted it!

Change-Id: Ie0eb2a7e0e9f4c4fc12b83a233553a8713d6a6f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125420
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/forms/source/solar/component/navbarcontrol.cxx 
b/forms/source/solar/component/navbarcontrol.cxx
index ce70d2336c22..082a670faa4d 100644
--- a/forms/source/solar/component/navbarcontrol.cxx
+++ b/forms/source/solar/component/navbarcontrol.cxx
@@ -180,7 +180,7 @@ namespace frm
 Reference< XDispatchProviderInterception > xTypedPeer(getPeer(), 
UNO_QUERY);
 if (xTypedPeer.is())
 {
-xTypedPeer->registerDispatchProviderInterceptor(_rxInterceptor);
+xTypedPeer->releaseDispatchProviderInterceptor(_rxInterceptor);
 }
 }
 

[Libreoffice-bugs] [Bug 145746] New: Crash after dragging a block diagram connector to document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145746

Bug ID: 145746
   Summary: Crash after dragging a block diagram connector to
document
   Product: LibreOffice
   Version: 7.2.1.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: patryk.kuszneruk1...@gmail.com

Description:
LibreOffice Writer crash after dragging a block scheme connector to document.
After crash and restore process all connectors disappeared.

Steps to Reproduce:
1.On the right panel select galery
2.On the list click Block Diagram("Schemat blokowy" in polish)
3.Drag a connector on document

Actual Results:
Lack of connectors in my work report

Expected Results:
:(


Reproducible: Didn't try


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: pl
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

--- Comment #2 from Mike Kaganski  ---
https://www.oreilly.com/library/view/vb-vba/1565923588/1565923588_ch07-1860-fm2xml.html

I suppose it is not a bug. The link above explains that the order of the color
components in the Long, returned from VBA's RGB, is the opposite of the
expected. So it's not the color is blue, it's an MS color incompatible with LO
color.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145714] in Base, the mediumblob MySQL fields are shown as Text[VARCHAR] - no mysql connector native driver support for MEDIUMBLOB datatype.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145714

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

Julien Nabet  changed:

   What|Removed |Added

Version|4.1.5.3 release |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/inc

[Michael Weghorn (via logerrit)]

 sc/inc/markmulti.hxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 4180b2f7855479f9187cd259d57c06e9fedfb802
Author: Michael Weghorn 
AuthorDate: Wed Nov 17 16:56:30 2021 +0100
Commit: Michael Weghorn 
CommitDate: Wed Nov 17 21:22:39 2021 +0100

sc: Drop 'typedef std::vector MapType'

Its only use is in the next line, and it's not even
a map anymore, but a vector.

Change-Id: Ib7920c420f5e3e18658f3530244097a4b1633951
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125411
Tested-by: Michael Weghorn 
Reviewed-by: Michael Weghorn 

diff --git a/sc/inc/markmulti.hxx b/sc/inc/markmulti.hxx
index c02fd5c6f0ab..0ddc6530a50c 100644
--- a/sc/inc/markmulti.hxx
+++ b/sc/inc/markmulti.hxx
@@ -31,8 +31,7 @@ class SC_DLLPUBLIC ScMultiSel
 {
 
 private:
-typedef std::vector MapType;
-MapType aMultiSelContainer;
+std::vector aMultiSelContainer;
 ScMarkArray aRowSel;
 const ScSheetLimits& mrSheetLimits;
 

[Libreoffice-bugs] [Bug 77407] Option to Reduce Image Resolution

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77407

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl

--- Comment #13 from Telesto  ---
*** Bug 132652 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132652] Export an image at any resolution without affecting the size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132652

Telesto  changed:

   What|Removed |Added

 Resolution|INSUFFICIENTDATA|DUPLICATE

--- Comment #5 from Telesto  ---


*** This bug has been marked as a duplicate of bug 77407 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145725] Under Option VBAsupport 1 the RGB() wrongly interchanges the values for Red and Blue.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145725

Julien Nabet  changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||mikekagan...@hotmail.com,
   ||serval2...@yahoo.fr
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

The involved method is SbRtl_RGB here:
https://opengrok.libreoffice.org/xref/core/basic/source/runtime/methods.cxx?r=4f5b3e4b=118773=4060#4060
and the VBAOption matters here:
   4075 if( bCompatibility )
   4076 {
   4077 nRGB   = (nBlue << 16) | (nGreen << 8) | nRed;
   4078 }
   4079 else
   4080 {
   4081 nRGB   = (nRed << 16) | (nGreen << 8) | nBlue;
   4082 }

It's like this since:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=9f19bd72abb62c018800976a1232adca64eb1a3c
author  Rüdiger Timm 2006-05-05 07:38:28 +
committer   Rüdiger Timm 2006-05-05 07:38:28
+
commit  9f19bd72abb62c018800976a1232adca64eb1a3c (patch)
treed908f551eb609ba6f5a7a6f06f70b1f3896fee65
parent  f986786ef4002cb89ce75884ab2ec996001993cd (diff)
INTEGRATION: CWS ab25 (1.64.24); FILE MERGED
2006/04/18 11:23:10 ab 1.64.24.1: #129905# Changed RGB behaviour for
compatibility mode

I must recognize I don't know what's the rationale for this.

Eike/Mike: any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145495] FILEOPEN DOCX: Anchor shows 'to paragraph' in in 4.4.7.2 until 7.2 but 'to character' in 7.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145495

Telesto  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEEDINFO|RESOLVED

--- Comment #4 from Telesto  ---
(In reply to Dieter from comment #3)
> I confirm the observation, but odt-file also has anchor "To Character". So
> for me the behaviour in Master (and also in LO 7.2.3.1) is expected.
> 
> So ülease explain your expectation => NEEDINFO

True, mea culpa.. What was I thinking..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145708] Libre Office Freezes when Remote File Menu is touched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145708

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #2 from Rainer Bielefeld Retired  
---
NOT reproducible with Server Installation of Version 7.3.0.0.alpha1+ (x64)  |  
Build ID b8d17d754830ab57099dcdfa72a96bfad404ab1a  |  CPU threads: 12; OS:
Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win  |  Locale: de-DE
(de_DE); UI: de-DE  |  Calc: CL  |  Special devUserProfile:

1. Launch LibO without any file
2. Click menu 'File'
   » Pulldown Menu opens
3. Move mouse pointer to 'Open Remote'
   » Expedted due to report: Hang / CRASH
 Actual: no crash  

For that Version and User Profile I do not have defined a remote connection.

also NOT reproducible with Installation of Version:7.2.1.2 (x64); Build ID:
87b77fad49947c1441b67c559c339af8f3517e22; CPU threads: 12; OS: Windows 10.0
Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI:
de-DE; Calc: threaded  |  my default User Profile  


For this User Profile I have defined remote connections.

a) also not reproducible from an empty writer document.

@reporter:
Please rename your user profile 
(or similar) with completely closed LibO and then relaunch LibO! Still
reproducible?

Some more detailed info concerning your OS and LibO Version / localization /
... might be useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/vcl vcl/source

[Chris Sherlock (via logerrit)]

 include/vcl/outdev.hxx |3 ++-
 vcl/source/outdev/gradient.cxx |   41 ++---
 2 files changed, 32 insertions(+), 12 deletions(-)

New commits:
commit 4c3c94704704e5090c0382476251caee7a904454
Author: Chris Sherlock 
AuthorDate: Sun Oct 31 21:34:49 2021 +1100
Commit: Tomaž Vajngerl 
CommitDate: Wed Nov 17 20:57:42 2021 +0100

vcl: split GetGradientSteps() into Get{Complex|Linear}GradientSteps()

Change-Id: Ieb0d5d6f1a7c9fff3671ef74ffac9eaf37dcb0e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123060
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index e82bf1e357a6..eec957e14973 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -815,7 +815,8 @@ private:
 SAL_DLLPRIVATE void DrawLinearGradientToMetafile( const 
tools::Rectangle& rRect, const Gradient& rGradient );
 SAL_DLLPRIVATE void DrawComplexGradientToMetafile( const 
tools::Rectangle& rRect, const Gradient& rGradient );
 
-SAL_DLLPRIVATE tools::Long GetGradientSteps( const Gradient& 
rGradient, const tools::Rectangle& rRect, bool bMtf, bool bComplex=false );
+SAL_DLLPRIVATE tools::Long  GetLinearGradientSteps( const Gradient& 
rGradient, const tools::Rectangle& rRect, bool bMtf);
+SAL_DLLPRIVATE tools::Long  GetComplexGradientSteps( const Gradient& 
rGradient, const tools::Rectangle& rRect, bool bMtf);
 
 SAL_DLLPRIVATE ColorGetSingleColorGradientFill();
 ///@}
diff --git a/vcl/source/outdev/gradient.cxx b/vcl/source/outdev/gradient.cxx
index 6bb6e8de64fc..7dc5523480db 100644
--- a/vcl/source/outdev/gradient.cxx
+++ b/vcl/source/outdev/gradient.cxx
@@ -357,7 +357,7 @@ void OutputDevice::DrawLinearGradient( const 
tools::Rectangle& rRect,
 }
 
 // calculate step count
-tools::LongnStepCount  = GetGradientSteps( rGradient, aRect, 
false/*bMtf*/ );
+tools::Long nStepCount = GetLinearGradientSteps(rGradient, aRect, 
false/*bMtf*/);
 
 // minimal three steps and maximal as max color steps
 tools::Long   nAbsRedSteps   = std::abs( nEndRed   - nStartRed );
@@ -479,7 +479,7 @@ void OutputDevice::DrawComplexGradient( const 
tools::Rectangle& rRect,
 if ( UsePolyPolygonForComplexGradient() )
 xPolyPoly = tools::PolyPolygon( 2 );
 
-tools::Long nStepCount = GetGradientSteps( rGradient, rRect, 
false/*bMtf*/, true/*bComplex*/ );
+tools::Long nStepCount = GetComplexGradientSteps(rGradient, rRect, 
false/*bMtf*/);
 
 // at least three steps and at most the number of colour differences
 tools::Long nSteps = std::max( nStepCount, tools::Long(2) );
@@ -715,7 +715,7 @@ void OutputDevice::DrawLinearGradientToMetafile( const 
tools::Rectangle& rRect,
 }
 }
 
-tools::LongnStepCount  = GetGradientSteps( rGradient, aRect, 
true/*bMtf*/ );
+tools::LongnStepCount  = GetLinearGradientSteps( rGradient, aRect, 
true/*bMtf*/ );
 
 // minimal three steps and maximal as max color steps
 tools::Long   nAbsRedSteps   = std::abs( nEndRed   - nStartRed );
@@ -816,7 +816,7 @@ void OutputDevice::DrawComplexGradientToMetafile( const 
tools::Rectangle& rRect,
 xPolyPoly = tools::PolyPolygon( 2 );
 
 // last parameter - true if complex gradient, false if linear
-tools::Long nStepCount = GetGradientSteps(rGradient, rRect, true, true);
+tools::Long nStepCount = GetComplexGradientSteps(rGradient, rRect, true);
 
 // at least three steps and at most the number of colour differences
 tools::Long nSteps = std::max(nStepCount, tools::Long(2));
@@ -951,25 +951,44 @@ tools::Long OutputDevice::GetGradientStepCount( 
tools::Long nMinRect )
 return nInc;
 }
 
-tools::Long OutputDevice::GetGradientSteps( const Gradient& rGradient, const 
tools::Rectangle& rRect, bool bMtf, bool bComplex )
+tools::Long OutputDevice::GetLinearGradientSteps(Gradient const& rGradient, 
tools::Rectangle const& rRect, bool bMtf)
 {
 // calculate step count
 tools::Long nStepCount  = rGradient.GetSteps();
-tools::Long nMinRect;
 
 // generate nStepCount, if not passed
-if (bComplex)
-nMinRect = std::min( rRect.GetWidth(), rRect.GetHeight() );
-else
-nMinRect = rRect.GetHeight();
+tools::Long nMinRect = rRect.GetHeight();
 
 if ( !nStepCount )
 {
 tools::Long nInc;
 
-nInc = GetGradientStepCount (nMinRect);
+nInc = GetGradientStepCount(nMinRect);
 if ( !nInc || bMtf )
 nInc = 1;
+
+nStepCount = nMinRect / nInc;
+}
+
+return nStepCount;
+}
+
+tools::Long OutputDevice::GetComplexGradientSteps(Gradient const& rGradient, 
tools::Rectangle const& rRect, bool bMtf)
+{
+// calculate step count
+tools::Long nStepCount  = rGradient.GetSteps();
+
+// generate nStepCount, if not passed
+tools::Long nMinRect = std::min(rRect.GetWidth(), rRect.GetHeight());
+
+if ( 

[Libreoffice-bugs] [Bug 142076] [META] Color filtering in Autofilter bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142076
Bug 142076 depends on bug 142420, which changed state.

Bug 142420 Summary: Filter By Color: Hangs after apply a color filter and then 
deselect the filter
https://bugs.documentfoundation.org/show_bug.cgi?id=142420

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source svx/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/view/gridwin.cxx|   11 ---
 svx/source/tbxctrls/tbcontrl.cxx |1 +
 2 files changed, 9 insertions(+), 3 deletions(-)

New commits:
commit b5c22a9371e22162ff7305ffaa393ed908eee610
Author: Caolán McNamara 
AuthorDate: Wed Nov 17 17:07:49 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 17 20:49:59 2021 +0100

use ListBoxPreview size for the color shown in autofilter color list

it's used for a similar case in the color button,
GetToolbarIconSizePixel is relatively narrow and we have a hectare of
space available here.

Draw a border around the color as we do for the similar color button
case.

Change-Id: If0b24a142d47038d02a977ed88281b2de0b529fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125418
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 3530e9d69d5a..acd2973075c1 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -950,10 +950,15 @@ void 
ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode eMode)
 }
 else
 {
+// ColorListBox::ShowPreview is similar
 ScopedVclPtr 
xDev(pPopupParent->create_virtual_device());
-
xDev->SetOutputSize(Application::GetSettings().GetStyleSettings().GetToolbarIconSizePixel());
-xDev->SetBackground(rColor);
-xDev->Erase();
+const StyleSettings& rStyleSettings = 
Application::GetSettings().GetStyleSettings();
+Size 
aImageSize(rStyleSettings.GetListBoxPreviewDefaultPixelSize());
+xDev->SetOutputSize(aImageSize);
+const tools::Rectangle aRect(Point(0, 0), aImageSize);
+xDev->SetFillColor(rColor);
+xDev->SetLineColor(rStyleSettings.GetDisableColor());
+xDev->DrawRect(aRect);
 
 xColorMenu->insert(-1, OUString::number(i), OUString(),
nullptr, xDev.get(), nullptr, 
TRISTATE_TRUE);
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 5a1239bdea77..04ae3e0ec4fa 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -4021,6 +4021,7 @@ void ColorListBox::LockWidthRequest()
 
 void ColorListBox::ShowPreview(const NamedColor )
 {
+// ScGridWindow::UpdateAutoFilterFromMenu is similar
 const StyleSettings& rStyleSettings = 
Application::GetSettings().GetStyleSettings();
 Size aImageSize(rStyleSettings.GetListBoxPreviewDefaultPixelSize());
 

[Libreoffice-commits] core.git: include/vcl sc/source sc/uiconfig sc/UIConfig_scalc.mk vcl/source

[Caolán McNamara (via logerrit)]

 include/vcl/menu.hxx  |4 
 sc/UIConfig_scalc.mk  |1 +
 sc/source/ui/view/gridwin.cxx |   23 ---
 sc/uiconfig/scalc/ui/colormenu.ui |9 +
 vcl/source/window/menu.cxx|   14 --
 5 files changed, 26 insertions(+), 25 deletions(-)

New commits:
commit c3c526e0192b9cf429d326b129ce9e94ec9e346b
Author: Caolán McNamara 
AuthorDate: Wed Nov 17 16:26:19 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 17 20:49:41 2021 +0100

weld colormenu

Change-Id: I6feef72cf924865e2407a96cdd0b6e60c835dbc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125417
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index f96c775fa64d..7834fe22519e 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -24,7 +24,6 @@
 #include 
 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -303,9 +302,6 @@ public:
 void SetItemImage( sal_uInt16 nItemId, const Image& rImage );
 Image GetItemImage( sal_uInt16 nItemId ) const;
 
-// Instead of an image, draw a color
-void SetItemColor( sal_uInt16 nItemId, const Color& rColor );
-
 void SetItemCommand( sal_uInt16 nItemId, const OUString& rCommand );
 OUString GetItemCommand( sal_uInt16 nItemId ) const;
 
diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk
index ce625df9f301..c1bd1b075926 100644
--- a/sc/UIConfig_scalc.mk
+++ b/sc/UIConfig_scalc.mk
@@ -94,6 +94,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\
sc/uiconfig/scalc/ui/chardialog \
sc/uiconfig/scalc/ui/checkwarningdialog \
sc/uiconfig/scalc/ui/chisquaretestdialog \
+   sc/uiconfig/scalc/ui/colormenu \
sc/uiconfig/scalc/ui/colorrowdialog \
sc/uiconfig/scalc/ui/colwidthdialog \
sc/uiconfig/scalc/ui/condformatmanager \
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 39c2f7d8fd98..3530e9d69d5a 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -43,6 +43,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -928,7 +929,10 @@ void ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode 
eMode)
 ScFilterEntries aFilterEntries;
 rDoc.GetFilterEntries(rPos.Col(), rPos.Row(), rPos.Tab(), 
aFilterEntries);
 
-VclPtr pColorMenu = VclPtr::Create();
+weld::Window* pPopupParent = mpAutoFilterPopup->GetFrameWeld();
+std::unique_ptr 
xBuilder(Application::CreateBuilder(pPopupParent, 
"modules/scalc/ui/colormenu.ui"));
+std::unique_ptr 
xColorMenu(xBuilder->weld_menu("menu"));
+
 std::set aColors = eMode == AutoFilterMode::TextColor
   ? aFilterEntries.getTextColors()
   : 
aFilterEntries.getBackgroundColors();
@@ -942,12 +946,17 @@ void 
ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode eMode)
 OUString sText = eMode == AutoFilterMode::TextColor
  ? 
ScResId(SCSTR_FILTER_AUTOMATIC_COLOR)
  : ScResId(SCSTR_FILTER_NO_FILL);
-pColorMenu->InsertItem(i, sText, 
MenuItemBits::CHECKABLE);
+xColorMenu->append_check(OUString::number(i), sText);
 }
 else
 {
-pColorMenu->InsertItem(i, OUString(), 
MenuItemBits::CHECKABLE);
-pColorMenu->SetItemColor(i, rColor);
+ScopedVclPtr 
xDev(pPopupParent->create_virtual_device());
+
xDev->SetOutputSize(Application::GetSettings().GetStyleSettings().GetToolbarIconSizePixel());
+xDev->SetBackground(rColor);
+xDev->Erase();
+
+xColorMenu->insert(-1, OUString::number(i), OUString(),
+   nullptr, xDev.get(), nullptr, 
TRISTATE_TRUE);
 }
 auto aItem = pEntry->GetQueryItem();
 if (aItem.maColor == rColor
@@ -957,14 +966,14 @@ void 
ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode eMode)
 && aItem.meType == 
ScQueryEntry::ByBackgroundColor)))
 {
 nActive = i;
-pColorMenu->CheckItem(i, true);
+xColorMenu->set_active(OString::number(i), true);
 }
 i++;
 }
 
 tools::Rectangle aRect = rControl.GetSubMenuParentRect();
-sal_uInt16 nSelected = pColorMenu->Execute(mpAutoFilterPopup, 
aRect, PopupMenuFlags::ExecuteRight);
-pColorMenu.disposeAndClear();
+  

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 44 commits - chart2/source configure.ac connectivity/source download.lst external/graphite external/libabw external/libcdr externa

[Michael Stahl (via logerrit)]

 chart2/source/tools/InternalDataProvider.cxx   
  |7 
 configure.ac   
  |2 
 connectivity/source/commontools/dbconversion.cxx   
  |9 -
 connectivity/source/drivers/dbase/DTable.cxx   
  |   13 +
 download.lst   
  |   58 
 external/graphite/StaticLibrary_graphite.mk
  |4 
 external/graphite/UnpackedTarball_graphite.mk  
  |4 
 external/graphite/graphite2.issue1115.patch.1  
  |   22 ---
 external/graphite/graphite2.win64.patch.1  
  |   60 
 external/graphite/ubsan.patch  
  |   53 ---
 external/libabw/UnpackedTarball_libabw.mk  
  |4 
 external/libabw/libabw-msvc.patch.1
  |   46 --
 external/libcdr/UnpackedTarball_libcdr.mk  
  |4 
 external/libcdr/libcdr-visibility-win.patch
  |   11 +
 external/libetonyek/Library_etonyek.mk 
  |1 
 external/libetonyek/UnpackedTarball_libetonyek.mk  
  |1 
 external/libetonyek/initial-creator.patch.1
  |   26 ---
 external/libetonyek/libetonyek-bundled-soname.patch.0  
  |3 
 external/libjpeg-turbo/UnpackedTarball_libjpeg-turbo.mk
  |1 
 external/libjpeg-turbo/c76f4a08263b0cea40d2967560ac7c21f6959079.patch.1
  |   38 +
 external/libmwaw/0001-ssize_t-is-not-std-type.patch.1  
  |   27 ---
 external/libmwaw/Library_mwaw.mk   
  |5 
 external/libmwaw/UnpackedTarball_libmwaw.mk
  |4 
 external/libmwaw/libmwaw-bundled-soname.patch.0
  |6 
 
external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
 |   58 
 external/libodfgen/ExternalProject_libodfgen.mk
  |4 
 external/libodfgen/Library_odfgen.mk   
  |3 
 external/libodfgen/UnpackedTarball_libodfgen.mk
  |4 
 external/libodfgen/libodfgen-bundled-soname.patch.0
  |5 
 external/libvisio/0001-fix-debug-build.patch.1 
  |   40 -
 external/libvisio/UnpackedTarball_libvisio.mk  
  |1 
 external/libvisio/ubsan.patch  
  |4 
 external/libwpd/Library_wpd.mk 
  |2 
 external/libwpd/include.patch  
  |4 
 external/libwpd/libwpd-bundled-soname.patch.0  
  |3 
 external/pdfium/Library_pdfium.mk  
  |   44 +++---
 external/pdfium/README 
  |2 
 external/pdfium/build.patch.1  
  |   71 +-
 external/pdfium/msvc2015.patch.1   
  |2 
 external/pdfium/ubsan.patch
  |6 
 external/poppler/StaticLibrary_poppler.mk  
  |2 
 external/poppler/poppler-config.patch.1
  |   58 ++--
 include/vcl/BitmapTools.hxx
  |5 
 lotuswordpro/source/filter/lwpfribptr.cxx  
  |   35 ++--
 lotuswordpro/source/filter/lwpfribptr.hxx  
  |4 
 sc/source/core/tool/compiler.cxx   
  |9 +
 sc/source/core/tool/interpr1.cxx   
  |2 
 solenv/flatpak-manifest.in 
  |   55 +++
 svtools/source/svhtml/parhtml.cxx  
  |8 -
 sw/qa/core/data/html/pass/ofz40593-1.html  
  |binary
 sw/qa/core/data/ww5/pass/ooo37322-1-WW2.doc
  |binary
 sw/qa/core/data/ww8/pass/ofz34749-1.doc 

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source vcl/unx

[Caolán McNamara (via logerrit)]

 include/vcl/weld.hxx  |   10 +-
 vcl/inc/salvtables.hxx|3 ++-
 vcl/source/app/salvtables.cxx |   11 ---
 vcl/unx/gtk3/gtkinst.cxx  |   21 +++--
 4 files changed, 38 insertions(+), 7 deletions(-)

New commits:
commit 6b4b82626a30418c2d566c4fc1ecfe559557bf2b
Author: Caolán McNamara 
AuthorDate: Wed Nov 17 17:00:58 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 17 20:49:22 2021 +0100

allow menu placement either under or at end

Change-Id: Id76cbe69464f439eec900bf9b80b0c63d99b6597
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125416
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index df036c8fde1a..b25e9abe5383 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -2277,6 +2277,12 @@ private:
 virtual void click(const Point& rPos) = 0;
 };
 
+enum class Placement
+{
+Under,
+End
+};
+
 class VCL_DLLPUBLIC Menu
 {
 protected:
@@ -2285,7 +2291,9 @@ protected:
 void signal_activate(const OString& rIdent) { m_aActivateHdl.Call(rIdent); 
}
 
 public:
-virtual OString popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle& rRect) = 0;
+virtual OString popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle& rRect,
+  Placement ePlace = Placement::Under)
+= 0;
 
 void connect_activate(const Link& rLink) { 
m_aActivateHdl = rLink; }
 
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index 57f6149ff7bc..c97b39df575d 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -145,7 +145,8 @@ private:
 
 public:
 SalInstanceMenu(PopupMenu* pMenu, bool bTakeOwnership);
-virtual OString popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle& rRect) override;
+virtual OString popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle& rRect,
+  weld::Placement ePlace = 
weld::Placement::Under) override;
 virtual void set_sensitive(const OString& rIdent, bool bSensitive) 
override;
 virtual bool get_sensitive(const OString& rIdent) const override;
 virtual void set_active(const OString& rIdent, bool bActive) override;
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 792534a92517..987a9ffe2aeb 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -772,12 +772,17 @@ SalInstanceMenu::SalInstanceMenu(PopupMenu* pMenu, bool 
bTakeOwnership)
 m_nLastId = nCount ? pMenu->GetItemId(nCount - 1) : 0;
 m_xMenu->SetSelectHdl(LINK(this, SalInstanceMenu, SelectMenuHdl));
 }
-OString SalInstanceMenu::popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle& rRect)
+OString SalInstanceMenu::popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle& rRect,
+   weld::Placement ePlace)
 {
 SalInstanceWidget* pVclWidget = dynamic_cast(pParent);
 assert(pVclWidget);
-m_xMenu->Execute(pVclWidget->getWidget(), rRect,
- PopupMenuFlags::ExecuteDown | 
PopupMenuFlags::NoMouseUpClose);
+PopupMenuFlags eFlags = PopupMenuFlags::NoMouseUpClose;
+if (ePlace == weld::Placement::Under)
+eFlags = eFlags | PopupMenuFlags::ExecuteDown;
+else
+eFlags = eFlags | PopupMenuFlags::ExecuteRight;
+m_xMenu->Execute(pVclWidget->getWidget(), rRect, eFlags);
 return m_xMenu->GetCurItemIdent();
 }
 void SalInstanceMenu::set_sensitive(const OString& rIdent, bool bSensitive)
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 93035fd27cbb..6ce18a346ac4 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -10718,7 +10718,7 @@ public:
 #endif
 }
 
-virtual OString popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle ) override
+virtual OString popup_at_rect(weld::Widget* pParent, const 
tools::Rectangle , weld::Placement ePlace) override
 {
 m_sActivated.clear();
 
@@ -10743,6 +10743,15 @@ public:
 GtkWidget* pOrigParent = gtk_widget_get_parent(GTK_WIDGET(m_pMenu));
 gtk_widget_set_parent(GTK_WIDGET(m_pMenu), pWidget);
 gtk_popover_set_pointing_to(GTK_POPOVER(m_pMenu), );
+if (ePlace == weld::Placement::Under)
+gtk_popover_set_position(GTK_POPOVER(m_pMenu), GTK_POS_BOTTOM);
+else
+{
+if (SwapForRTL(pWidget))
+gtk_popover_set_position(GTK_POPOVER(m_pMenu), GTK_POS_LEFT);
+else
+gtk_popover_set_position(GTK_POPOVER(m_pMenu), GTK_POS_RIGHT);
+}
 gtk_popover_popup(GTK_POPOVER(m_pMenu));
 #else
 gulong nSignalId = g_signal_connect_swapped(G_OBJECT(m_pMenu), 
"deactivate", G_CALLBACK(g_main_loop_quit), pLoop);
@@ -10765,7 +10774,15 @@ public:
 if (!pTriggerEvent)
 pTriggerEvent = pKeyEvent;
 
-gtk_menu_popup_at_rect(m_pMenu, 

[Libreoffice-commits] core.git: compilerplugins/clang include/vcl vcl/source

[Caolán McNamara (via logerrit)]

 compilerplugins/clang/unusedenumconstants.readonly.results |2 --
 include/vcl/menu.hxx   |8 +---
 vcl/source/window/menu.cxx |3 ---
 3 files changed, 1 insertion(+), 12 deletions(-)

New commits:
commit 9f68cc110c16cc096f5549a4a0812cee56cb09db
Author: Caolán McNamara 
AuthorDate: Wed Nov 17 16:31:07 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 17 20:49:02 2021 +0100

drop unused PopupMenuFlags::NoHorzPlacement

Change-Id: Ic279160f96e5aa2a37690f987c2323b91b2ec49c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125415
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index 935e74505021..02ec1e8a728f 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -512,8 +512,6 @@ include/vcl/keycodes.hxx:175
 enum ModKeyFlags Mod2Msk
 include/vcl/menu.hxx:78
 enum PopupMenuFlags ExecuteUp
-include/vcl/menu.hxx:86
-enum PopupMenuFlags NoHorzPlacement
 include/vcl/pdf/PDFAnnotationSubType.hxx:17
 enum vcl::pdf::PDFAnnotationSubType Unknown
 include/vcl/pdf/PDFAnnotationSubType.hxx:26
diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index c0a627a30f88..f96c775fa64d 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -77,17 +77,11 @@ enum class PopupMenuFlags
 ExecuteUp   = 0x0002,
 ExecuteRight= 0x0008,
 NoMouseUpClose  = 0x0010,
-//If there isn't enough space to put the menu where it wants
-//to go, then they will be autoplaced. Toggle this bit
-//on to force menus to be placed either above or below
-//the starting rectangle and shrunk to fit and then scroll rather than place
-//the menu beside that rectangle
-NoHorzPlacement = 0x0020,
 };
 
 namespace o3tl
 {
-template<> struct typed_flags : 
is_typed_flags {};
+template<> struct typed_flags : 
is_typed_flags {};
 }
 
 enum class MenuFlags
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index 797740d127b8..53f5e28e6f53 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -2798,9 +2798,6 @@ sal_uInt16 PopupMenu::Execute( vcl::Window* pExecWindow, 
const tools::Rectangle&
 if (nFlags & PopupMenuFlags::NoMouseUpClose )  // 
allow popup menus to stay open on mouse button up
 nPopupModeFlags |= FloatWinPopupFlags::NoMouseUpClose;// useful if 
the menu was opened on mousebutton down (eg toolbox configuration)
 
-if (nFlags & PopupMenuFlags::NoHorzPlacement)
-nPopupModeFlags |= FloatWinPopupFlags::NoHorzPlacement;
-
 return ImplExecute( pExecWindow, rRect, nPopupModeFlags, nullptr, false );
 }
 

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/cctrl/checklistmenu.cxx |9 -
 sc/source/ui/inc/checklistmenu.hxx   |5 +
 sc/source/ui/view/gridwin.cxx|6 +++---
 3 files changed, 16 insertions(+), 4 deletions(-)

New commits:
commit 2b3cc82b88d0c6508e9c0c6ccc53e0f9bfb4069e
Author: Caolán McNamara 
AuthorDate: Wed Nov 17 15:20:33 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 17 20:47:55 2021 +0100

tdf#142420 color menu should be a child of the autofilter, not a sibling

which is why it doesn't appear at all under wayland. This should also
get it positioned better rather than using a fixed pixel offset.

Change-Id: I9a4193c27b4172469cea3d980c86cff9ca701ca2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125409
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 56fb60477220..328c51718364 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -283,6 +283,13 @@ void ScCheckListMenuControl::queueCloseSubMenu()
 maCloseTimer.maTimer.Start();
 }
 
+tools::Rectangle ScCheckListMenuControl::GetSubMenuParentRect()
+{
+if (!mxMenu->get_selected(mxScratchIter.get()))
+return tools::Rectangle();
+return mxMenu->get_row_area(*mxScratchIter);
+}
+
 void ScCheckListMenuControl::launchSubMenu(bool bSetMenuPos)
 {
 ScCheckListMenuWindow* pSubMenu = maOpenTimer.mpSubMenu;
@@ -292,7 +299,7 @@ void ScCheckListMenuControl::launchSubMenu(bool bSetMenuPos)
 if (!mxMenu->get_selected(mxScratchIter.get()))
 return;
 
-tools::Rectangle aRect = mxMenu->get_row_area(*mxScratchIter);
+tools::Rectangle aRect = GetSubMenuParentRect();
 ScCheckListMenuControl& rSubMenuControl = pSubMenu->get_widget();
 rSubMenuControl.StartPopupMode(aRect, FloatWinPopupFlags::Right);
 if (bSetMenuPos)
diff --git a/sc/source/ui/inc/checklistmenu.hxx 
b/sc/source/ui/inc/checklistmenu.hxx
index 302f2bd0b55d..cb78bf226a45 100644
--- a/sc/source/ui/inc/checklistmenu.hxx
+++ b/sc/source/ui/inc/checklistmenu.hxx
@@ -177,6 +177,11 @@ public:
  */
 void terminateAllPopupMenus();
 
+/**
+ * Get the area of the active row. Suitable as the parent rectangle
+ * argument for Executing a popup
+*/
+tools::Rectangle GetSubMenuParentRect();
 private:
 
 std::vector maMenuItems;
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 6013848bb85c..39c2f7d8fd98 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -961,9 +961,9 @@ void ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode 
eMode)
 }
 i++;
 }
-Point pos(mpAutoFilterPopup->GetPosPixel());
-pos.Move(150, 0);
-sal_uInt16 nSelected = pColorMenu->Execute(this, pos);
+
+tools::Rectangle aRect = rControl.GetSubMenuParentRect();
+sal_uInt16 nSelected = pColorMenu->Execute(mpAutoFilterPopup, 
aRect, PopupMenuFlags::ExecuteRight);
 pColorMenu.disposeAndClear();
 rControl.terminateAllPopupMenus();
 

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/view/gridwin.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3c4c98784d352c6edeae598233fd46775373d332
Author: Caolán McNamara 
AuthorDate: Wed Nov 17 14:51:39 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 17 20:46:29 2021 +0100

wrong function name in comment

Change-Id: I80f7f8cbf17bea0de770eb590ade6bbdb2fc7ac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125406
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index d850ac042872..6013848bb85c 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -502,7 +502,7 @@ public:
 virtual bool execute() override
 {
 mpWindow->UpdateAutoFilterFromMenu(meMode);
-// RefreshAutoFilterButton manually closes the popup so return
+// UpdateAutoFilterFromMenu manually closes the popup so return
 // false to not attempt a second close
 return false;
 }

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - download.lst

[Michael Stahl (via logerrit)]

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a4b570ef8da51881aedcd25d66430ca9d9c69221
Author: Michael Stahl 
AuthorDate: Tue Nov 16 14:41:57 2021 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 17 20:37:42 2021 +0100

postgresql: upgrade to release 13.5

Fixes CVE-2021-23222.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125308
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 71b9369f1cc40143108e3f2189d96e402895e315)

Change-Id: I4e16fcc60c634382a864f66b211d0e0170a06db0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125391
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 

diff --git a/download.lst b/download.lst
index 22cd0fb9ed4c..d20af4b159f7 100644
--- a/download.lst
+++ b/download.lst
@@ -208,8 +208,8 @@ export LIBPNG_SHA256SUM := 
505e70834d35383537b6491e7ae8641f1a4bed1876dbfe361201f
 export LIBPNG_TARBALL := libpng-1.6.37.tar.xz
 export POPPLER_SHA256SUM := 
31b76b5cac0a48612fdd154c02d9eca01fd38fb8eaa77c1196840ecdeb53a584
 export POPPLER_TARBALL := poppler-21.11.0.tar.xz
-export POSTGRESQL_SHA256SUM := 
12345c83b89aa29808568977f5200d6da00f88a035517f925293355432ffe61f
-export POSTGRESQL_TARBALL := postgresql-13.1.tar.bz2
+export POSTGRESQL_SHA256SUM := 
9b81067a55edbaabc418aacef457dd8477642827499560b00615a6ea6c13f6b3
+export POSTGRESQL_TARBALL := postgresql-13.5.tar.bz2
 export PYTHON_SHA256SUM := 
c24a37c63a67f53bdd09c5f287b5cff8e8b98f857bf348c577d454d3f74db049
 export PYTHON_TARBALL := Python-3.5.9.tar.xz
 export QXP_SHA256SUM := 
e137b6b110120a52c98edd02ebdc4095ee08d0d5295a94316a981750095a945c

[Libreoffice-bugs] [Bug 145743] Embedded file crash master document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145743

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|unspecified |7.3.0.0 alpha0+ Master
 CC||michael.st...@allotropia.de
   ||, serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Michael: on pc Debian x86-64 with master sources updated today + gtk3, I don't
reproduce this and noticed this on console:
...
warn:sw.core:1131933:1131933:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.
warn:sw.core:1131933:1131933:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.
warn:sw.core:1131933:1131933:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.
warn:legacy.osl:1131933:1131933:sw/source/core/access/acccontext.cxx:445: fire
event for disposed frame?
warn:legacy.osl:1131933:1131933:sw/source/core/layout/layact.cxx:771:
LoopControl_2 in Interrupt formatting in SwLayAction::InternalAction
...

but I could reproduce this with kf5 rendering.
I got:
warn:sw.core:1132189:1132189:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.
warn:sw.core:1132189:1132189:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.

but no these:
warn:legacy.osl:1131933:1131933:sw/source/core/access/acccontext.cxx:445: fire
event for disposed frame?
warn:legacy.osl:1131933:1131933:sw/source/core/layout/layact.cxx:771:
LoopControl_2 in Interrupt formatting in SwLayAction::InternalAction

It seems to loop in :
SwLayAction::InternalAction (this=0x7fffdd0737f0, pRenderContext=0x91a91b0) at
sw/source/core/layout/layact.cxx:587

With gen rendering, I don't reproduce this and got this on console:
...
warn:sw.core:1132486:1132486:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.
warn:sw.core:1132486:1132486:sw/source/core/docnode/node.cxx:1983: Wrong cond
collection, skipping check of Cond Colls.
warn:legacy.osl:1132486:1132486:sw/source/core/layout/layact.cxx:771:
LoopControl_2 in Interrupt formatting in SwLayAction::InternalAction


Any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 139031] Some dropdowns in the PDF export dialog should be aligned better (kf5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139031

BogdanB  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #22 from BogdanB  ---
On help pages they are separated terms, in the image.
In this case ignore my previous comment.

https://help.libreoffice.org/7.3/en-US/text/shared/01/ref_pdf_export_general.html?System=UNIX=CALC=filter/ui/pdfgeneralpage/PdfGeneralPage#bm_id1033968

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 139031] Some dropdowns in the PDF export dialog should be aligned better (kf5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139031

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #21 from BogdanB  ---
Created attachment 176324
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176324=edit
screenshot

Jus a note:
"JPEG compression Quality" seems to be formed from 2 expresions OR there is a
double space between "JPEG compression" and "Quality". I thing this expresion
should be just one.

Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: fcad2503ede92b515076f9bb3162855dcc2c575d
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.