[Libreoffice-bugs] [Bug 99671] [META] Gallery bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=99671 Bug 99671 depends on bug 81593, which changed state. Bug 81593 Summary: Regression: thumbnails in gallery have poor resolution and excessive enlargement when the vector source has small dimensions https://bugs.documentfoundation.org/show_bug.cgi?id=81593 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81593] Regression: thumbnails in gallery have poor resolution and excessive enlargement when the vector source has small dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=81593 Callegar changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #23 from Callegar --- Incidentally, this is really a minor glitch that affects usability in an extremely marginal way. Unless things really differ just for tiny details, one can quickly learn to match in the mind the thumbnail with the expected objects, no matter how large the loss in the details (there may be usage cases where the details really count though). The only actual issue is that it makes the application look less professional than counterparts. My two cents: - The thumbnail resolution should be a bit higher. - When the thumbnailed objects are really very small, three should be some minor enlargement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147135] Crash in: _GLOBAL__sub_I_protectiondlg.cxx.lto_priv.2643 ( Calc crashes )
https://bugs.documentfoundation.org/show_bug.cgi?id=147135 --- Comment #35 from Dorange-Pattoret Didier --- (In reply to nouvo09 from comment #32) Version: 7.3.0.3 / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded uname - gives: Linux Bigone 5.13.0-28-generic #31-Ubuntu SMP Thu Jan 13 17:41:06 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81593] Regression: thumbnails in gallery have poor resolution and excessive enlargement when the vector source has small dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=81593 --- Comment #22 from Callegar --- Created attachment 178107 --> https://bugs.documentfoundation.org/attachment.cgi?id=178107=edit Comparison of gallery thumbnail views from Openoffice to today. Reopening. In LibO 7.3, the situation has certainly improved wrt LibO 7.2 but it remains evidently worse than it was with way older versions of LibO and OO. Please, check the attached comparison of gallery thumbnail views form OO to today. In my system I have a gallery that has been built over time, so some of the entries go back to OO age. Because of how the thumbnails are generated, the older entries keep the thumbnail that was initially made and this allows for a comparison of the thumbnail generation strategy. The attachment includes 6 entries. From left to right, top to bottom: 1. The three entries in the top row were generated with a very old LibO or even OO. They look *perfect*, apart from the fact that it is not evident that the background is transparent. Another minor issue is that the item at the top left corner is excessively enlarged. 2. The left entry in the bottom row was generated with the just released LibO 7.3. The resolution is insufficient. One line of the drawing is completely invisible. 3. The center and right entries in the bottom row were generated with some relatively recent LibO. It has the same poor resolution as the entry made by LibO 7.3 plus excessive enlargement. Altogether, I think that anyone can agree that the best thumbnails are those made with the oldest versions of LibO. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source
sc/source/filter/html/htmlpars.cxx | 10 ++
1 file changed, 10 insertions(+)
New commits:
commit 2ea7055ea6115051a92c66a439b02d83bb067db7
Author: Eike Rathke
AuthorDate: Sat Feb 5 22:43:13 2022 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Mon Feb 7 08:27:24 2022 +0100
Resolves: tdf#74577 tdf#92960 Create missing offsets in very outer table
... if local table is outer table.
Change-Id: I5996609264f4ad9efa8d76a8d0ab730bf1dded24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129540
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 8a9b870a40c41c7cae6e43452b593804fa17f831)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129550
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sc/source/filter/html/htmlpars.cxx
b/sc/source/filter/html/htmlpars.cxx
index 2dabd09d10b4..ae93c3e56021 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -761,6 +761,16 @@ void ScHTMLLayoutParser::SetWidths()
sal_uInt16 nMax = static_cast(pLocalColOffset->back());
if ( aPageSize.Width() < nMax )
aPageSize.setWidth( nMax );
+if (nTableLevel == 0)
+{
+// Local table is very outer table, create missing offsets.
+for (auto it = pLocalColOffset->begin(); it !=
pLocalColOffset->end(); ++it)
+{
+// Only exact offsets, do not use MakeColNoRef().
+if (maColOffset.find(*it) == maColOffset.end())
+maColOffset.insert(*it);
+}
+}
}
for ( size_t i = nFirstTableCell, nListSize = maList.size(); i <
nListSize; ++i )
{
[Libreoffice-bugs] [Bug 108835] Writer freezes when clicking OK / creating new Autocorrect entry
https://bugs.documentfoundation.org/show_bug.cgi?id=108835 --- Comment #15 from Watodis Smit --- Arranging flowers can be a challenge, but with a little patience and creativity, you'll have a beautiful arrangement that will brighten your home or office for days to come. https://tutuappx.com/ https://vidmate.onl/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108832] Ubuntu hosted VirtualBox Windows 7 VM has disappearing text from dialogs and buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=108832 --- Comment #11 from Watodis Smit --- Pick an ideal vase, add some structure, and then arrange those flowers to your heart's content. https://dltutuapp.com/tutuapp-download/ https://showbox.run/ https://kodi.software/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147206] copy+Rich Text Formatting RTF paste special turns entire document into hyperlink text
https://bugs.documentfoundation.org/show_bug.cgi?id=147206 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147206] copy+Rich Text Formatting RTF paste special turns entire document into hyperlink text
https://bugs.documentfoundation.org/show_bug.cgi?id=147206 Mike Kaganski changed: What|Removed |Added Version|7.1.3.2 release |6.4.0.3 release Keywords||bibisectRequest, regression --- Comment #2 from Mike Kaganski --- No repro with Version: 6.0.0.3 (x64) Build ID: 64a0f66915f38c6217de274f0aa8e15618924765 CPU threads: 12; OS: Windows 10.0; UI render: GL; Locale: ru-RU (ru_RU); Calc: CL Repro with Version: 6.4.0.3 (x64) Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8 CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147073] Line chart with date does not always show the last element
https://bugs.documentfoundation.org/show_bug.cgi?id=147073 Leyan changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Leyan --- Duplicate of bug 146066 which is already solved, will be available in 7.3.1 and 7.4 *** This bug has been marked as a duplicate of bug 146066 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 40575] Maximum date value in Base is 27/06/9957
https://bugs.documentfoundation.org/show_bug.cgi?id=40575 Alex Thurgood changed: What|Removed |Added Resolution|WORKSFORME |FIXED --- Comment #35 from Alex Thurgood --- Hi * Yes, sorry, this should be resolved fixed due to the commits that have gone in. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147029] Improve lots of templates loading performance
https://bugs.documentfoundation.org/show_bug.cgi?id=147029 Po-Yen Huang changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146937] Is the "refresh" command needed in the Template Manager?
https://bugs.documentfoundation.org/show_bug.cgi?id=146937 Po-Yen Huang changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |j...@mail.ossii.com.tw |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146937] Is the "refresh" command needed in the Template Manager?
https://bugs.documentfoundation.org/show_bug.cgi?id=146937 --- Comment #7 from Po-Yen Huang --- https://gerrit.libreoffice.org/c/core/+/129584 Commit pushed, please review :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: forms/source
forms/source/component/DatabaseForm.cxx | 29 +
forms/source/component/clickableimage.cxx |5 +
2 files changed, 14 insertions(+), 20 deletions(-)
New commits:
commit 6dcd73f505eca7d0ea3164855dd4cd0813b4
Author: Julien Nabet
AuthorDate: Sun Feb 6 21:47:14 2022 +0100
Commit: Julien Nabet
CommitDate: Mon Feb 7 07:56:16 2022 +0100
Simplify sequence of PropertyValue in forms
Change-Id: Iab1af5c8d8d824ef2a4be471395f174cadabfc1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129583
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/forms/source/component/DatabaseForm.cxx
b/forms/source/component/DatabaseForm.cxx
index 6ba5a380ee9c..e22acf270fb5 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -29,6 +29,7 @@
#include "GroupManager.hxx"
#include
#include
+#include
#include
#include
@@ -2103,9 +2104,6 @@ static void lcl_dispatch(const Reference< XFrame >&
xFrame,const Reference aArgs(2);
-aArgs.getArray()[0].Name = "Referer";
-aArgs.getArray()[0].Value <<= aReferer;
// build a sequence from the to-be-submitted string
OString a8BitData(OUStringToOString(aData, _eEncoding));
@@ -2113,8 +2111,11 @@ static void lcl_dispatch(const Reference< XFrame >&
xFrame,const Reference aPostData(reinterpret_cast(a8BitData.getStr()), a8BitData.getLength());
Reference< XInputStream > xPostData = new SequenceInputStream(aPostData);
-aArgs.getArray()[1].Name = "PostData";
-aArgs.getArray()[1].Value <<= xPostData;
+Sequence aArgs
+{
+comphelper::makePropertyValue("Referer", aReferer),
+comphelper::makePropertyValue("PostData", xPostData)
+};
xDisp->dispatch(aURL, aArgs);
}
@@ -2193,9 +2194,7 @@ void ODatabaseForm::submit_impl(const
Reference& Control, const css::a
if (xDisp.is())
{
-Sequence aArgs(1);
-aArgs.getArray()->Name = "Referer";
-aArgs.getArray()->Value <<= aReferer;
+Sequence aArgs {
comphelper::makePropertyValue("Referer", aReferer) };
xDisp->dispatch(aURL, aArgs);
}
}
@@ -2226,17 +2225,15 @@ void ODatabaseForm::submit_impl(const
Reference& Control, const css::a
if (!aData.hasElements())
return;
-Sequence aArgs(3);
-aArgs.getArray()[0].Name = "Referer";
-aArgs.getArray()[0].Value <<= aReferer;
-aArgs.getArray()[1].Name = "ContentType";
-aArgs.getArray()[1].Value <<= aContentType;
-
// build a sequence from the to-be-submitted string
Reference< XInputStream > xPostData = new
SequenceInputStream(aData);
-aArgs.getArray()[2].Name = "PostData";
-aArgs.getArray()[2].Value <<= xPostData;
+Sequence aArgs
+{
+comphelper::makePropertyValue("Referer", aReferer),
+comphelper::makePropertyValue("ContentType", aContentType),
+comphelper::makePropertyValue("PostData", xPostData)
+};
xDisp->dispatch(aURL, aArgs);
}
diff --git a/forms/source/component/clickableimage.cxx
b/forms/source/component/clickableimage.cxx
index c84ba34cfb95..6a1ec1120192 100644
--- a/forms/source/component/clickableimage.cxx
+++ b/forms/source/component/clickableimage.cxx
@@ -301,10 +301,7 @@ namespace frm
FrameSearchFlag::SELF | FrameSearchFlag::PARENT |
FrameSearchFlag::SIBLINGS |
FrameSearchFlag::CREATE );
-Sequence aArgs(1);
-PropertyValue& rProp = aArgs.getArray()[0];
-rProp.Name = "Referer";
-rProp.Value <<= xModel->getURL();
+Sequence aArgs {
comphelper::makePropertyValue("Referer", xModel->getURL()) };
if (xDisp.is())
xDisp->dispatch( aURL, aArgs );
[Libreoffice-bugs] [Bug 147239] New: Can not resize table height in specific situation
https://bugs.documentfoundation.org/show_bug.cgi?id=147239 Bug ID: 147239 Summary: Can not resize table height in specific situation Product: LibreOffice Version: 7.1.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@mail.ossii.com.tw Description: Can't resize table height in some specific situation, maybe overflow. Steps to Reproduce: 1. Insert a table into presentation 2. Increase height of table 3. Drag whole table down over presentation page border 4. Right click table and click "Position and Size" 5. Set "Position Y" to a huge negtive number 6. Type many words in cells to make table size over page size 7. Delete all of contents but not table itself 8. Try to set height to a size less than page height Actual Results: Can not resize table height to less than page height Expected Results: Height of table is fit to set number Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.3.0.3 / LibreOffice Community Build ID: 30(Build:3) CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+xcb) Locale: zh-TW (zh_TW.UTF-8); UI: zh-TW 7.3.0-4 Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114532] add support for WEBP image format (image import and inside .ods/.odt)
https://bugs.documentfoundation.org/show_bug.cgi?id=114532 --- Comment #28 from Mike Kaganski --- Also: please let's close this bug, and file new bugs. Although this one started as "please add support for WEBP image format (image import and inside .ods/.odt)", the stated scope is too broad for a single issue. It would be reasonable to only track manageable scope here (which is "add support for reading" - and which is RESOLVED FIXED by now); and track other multiple aspects (transition period behavior; related options; point in time to end the transition) separately, maybe blocking this one, or having a separate meta. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64679] [META] Printer settings related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=64679 --- Comment #32 from Riya Sharma --- Start learning graphic designing at professional level by joining https://www.admecindia.co.in/courses/graphic-design-courses-delhi/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147238] Why does LibreOffice ignore Apache poi setLandscape(true) option where MS Excel does not
https://bugs.documentfoundation.org/show_bug.cgi?id=147238 Mike Kaganski changed: What|Removed |Added URL||https://ask.libreoffice.org ||/t/why-does-libreoffice-ign ||ore-apache-poi-setlandscape ||-true-option-where-ms-excel ||-does-not/73632 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114532] add support for WEBP image format (image import and inside .ods/.odt)
https://bugs.documentfoundation.org/show_bug.cgi?id=114532 --- Comment #27 from Mike Kaganski --- (In reply to Tomaz Vajngerl from comment #26) TL;DR summary of the following: that is a very dangerous and serves only a couple of users. The idea to save both formats (one as fallback) would only serve people who have the ultimate goal to get to the original bytes at some unspecified future time. What is the real use case, that would require someone to desperately need the original embedded image bytes, as opposed to a converted copy? OTOH, there are *real* use cases, that would be served poorly by that decision. 1. People who chose WebP to save space. Well, PNG is not ideal for those; but speculating that 110% is better for those who are unhappy with 100% is not reasonable, right? And we possibly need to have a "convert lossy WebP to" option with JPEG and PNG, like we have in Compress dialog - as you suggest. 2. People who didn't even realize they used a WebP (IMO, the vast majority, who e.g. dragged the images from a web page). They don't care about the image original format at all. They would have to pay their disk space (that +10%) for a couple of those who needed it. And the last category of users would be in real danger then. You argue that the idea behind saving both formats is being able to return to WebP at some later stage - meaning that the fallback PNG would be dropped, right? But that means that at some update, unprepared users would suddenly have their existing documents dropping embedded PNGs, which they would not notice, because they use a version that supports the format; but you have no control who is their recipients are, and what they use. Of course, the decision to drop PNG would happen when WebP support in ODF readers is reasonable, but you can't guarantee 100% - and that means that *existing* edited documents with pre-existing images can suddenly become unreadable on colleagues' systems where they used to be working. It would be OK to argue "you use a modern program that supports WebP; you have just inserted a WebP into a new document; it's OK that this image is not shown on your colleague who uses AOO 4.1" - but it is *not* OK to tell that about document that they had happily edited for long time, and that broke after editing with updated LO, without any image insertion. So IMO: 1. If people want to be notified about conversion, do that using an infobar (just inform, do not ask and do not provide options there, except maybe a button to go to relevant configuration, or to help). 2. Provide a (preferably expert) option to *not* convert at all - i.e., for those who really want to use WebP, let them have the WebP - with no fallback. 3. Provide an option to convert lossy WebP to JPEG instead of PNG. 4. Do not complicate things with a fallback. That will inevitably hit much more users in long term, than those who benefit from that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/edit/edlingu.cxx |6 ++
sw/source/core/unocore/unoredline.cxx | 25 +++--
sw/source/core/unocore/unostyle.cxx | 16
sw/source/ui/dbui/addresslistdialog.cxx | 18 --
sw/source/ui/dbui/mmlayoutpage.cxx| 12 ++--
sw/source/ui/dbui/mmresultdialogs.cxx | 10 ++
sw/source/ui/dbui/selectdbtabledialog.cxx | 20
sw/source/ui/envelp/mailmrge.cxx | 15 +++
sw/source/ui/vba/vbadocuments.cxx |4 +---
sw/source/uibase/dbui/mmconfigitem.cxx| 23 ---
sw/source/uibase/uiview/view2.cxx | 29 +
11 files changed, 74 insertions(+), 104 deletions(-)
New commits:
commit ed652a6af731c5cd024c245013923717b7764a60
Author: Julien Nabet
AuthorDate: Sun Feb 6 14:05:46 2022 +0100
Commit: Julien Nabet
CommitDate: Mon Feb 7 07:05:17 2022 +0100
Simplify sequences uses in sw (2)
Change-Id: Ic4b3136414d778990e179e36162ca61327cb13f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129578
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/source/core/edit/edlingu.cxx b/sw/source/core/edit/edlingu.cxx
index a393afdb225c..3c0d8b2e8524 100644
--- a/sw/source/core/edit/edlingu.cxx
+++ b/sw/source/core/edit/edlingu.cxx
@@ -55,6 +55,7 @@
#include
#include
#include
+#include
using namespace ::svx;
using namespace ::com::sun::star;
@@ -945,10 +946,7 @@ uno::Reference< XSpellAlternatives >
// than returning e.g. 16 suggestions and using only the
// first 7. Thus we hand down the value to use to that
// implementation here by providing an additional
parameter.
-Sequence< PropertyValue > aPropVals(1);
-PropertyValue = aPropVals.getArray()[0];
-rVal.Name = UPN_MAX_NUMBER_OF_SUGGESTIONS;
-rVal.Value <<= sal_Int16(7);
+Sequence< PropertyValue > aPropVals ( {
comphelper::makePropertyValue( UPN_MAX_NUMBER_OF_SUGGESTIONS, sal_Int16(7)) } );
xSpellAlt = xSpell->spell( aWord,
static_cast(eActLang), aPropVals );
}
diff --git a/sw/source/core/unocore/unoredline.cxx
b/sw/source/core/unocore/unoredline.cxx
index f0d784658f57..197a5542b072 100644
--- a/sw/source/core/unocore/unoredline.cxx
+++ b/sw/source/core/unocore/unoredline.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
@@ -175,24 +176,20 @@ SwXRedlinePortion::~SwXRedlinePortion()
static uno::Sequence lcl_GetSuccessorProperties(const
SwRangeRedline& rRedline)
{
-uno::Sequence aValues(4);
-
const SwRedlineData* pNext = rRedline.GetRedlineData().Next();
if(pNext)
{
-beans::PropertyValue* pValues = aValues.getArray();
-pValues[0].Name = UNO_NAME_REDLINE_AUTHOR;
-// GetAuthorString(n) walks the SwRedlineData* chain;
-// here we always need element 1
-pValues[0].Value <<= rRedline.GetAuthorString(1);
-pValues[1].Name = UNO_NAME_REDLINE_DATE_TIME;
-pValues[1].Value <<= pNext->GetTimeStamp().GetUNODateTime();
-pValues[2].Name = UNO_NAME_REDLINE_COMMENT;
-pValues[2].Value <<= pNext->GetComment();
-pValues[3].Name = UNO_NAME_REDLINE_TYPE;
-pValues[3].Value <<= SwRedlineTypeToOUString(pNext->GetType());
+return
+{
+// GetAuthorString(n) walks the SwRedlineData* chain;
+// here we always need element 1
+comphelper::makePropertyValue(UNO_NAME_REDLINE_AUTHOR,
rRedline.GetAuthorString(1)),
+comphelper::makePropertyValue(UNO_NAME_REDLINE_DATE_TIME,
pNext->GetTimeStamp().GetUNODateTime()),
+comphelper::makePropertyValue(UNO_NAME_REDLINE_COMMENT,
pNext->GetComment()),
+comphelper::makePropertyValue(UNO_NAME_REDLINE_TYPE,
SwRedlineTypeToOUString(pNext->GetType()))
+};
}
-return aValues;
+return uno::Sequence(4);
}
uno::Any SwXRedlinePortion::getPropertyValue( const OUString& rPropertyName )
diff --git a/sw/source/core/unocore/unostyle.cxx
b/sw/source/core/unocore/unostyle.cxx
index b19758648ddf..40b9878f59a2 100644
--- a/sw/source/core/unocore/unostyle.cxx
+++ b/sw/source/core/unocore/unostyle.cxx
@@ -21,6 +21,7 @@
#include
#include
+#include
#include
#include
#include
@@ -598,15 +599,14 @@ void SwXStyleFamilies::loadStylesFromURL(const OUString&
rURL,
uno::Sequence< beans::PropertyValue > SwXStyleFamilies::getStyleLoaderOptions()
{
SolarMutexGuard aGuard;
-uno::Sequence< beans::PropertyValue > aSeq(5);
-beans::PropertyValue* pArray = aSeq.getArray();
const uno::Any aVal(true);
-pArray[0] = beans::PropertyValue(UNO_NAME_LOAD_TEXT_STYLES, -1, aVal,
beans::PropertyState_DIRECT_VALUE);
-pArray[1] =
[Libreoffice-bugs] [Bug 79186] Re-saving DOC with table running over page end breaks layout (table header on 1st page; vertically aligned text influences cells on 2nd page; remainder on 3rd page)
https://bugs.documentfoundation.org/show_bug.cgi?id=79186 --- Comment #12 from Justin L --- Not surprisingly, the problem is with the vertical textbox (or whatever it is) on the left. In the initial document, the position's "Keep inside text boundaries" is off, but on the round-trip that checkbox is turned on. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147238] Why does LibreOffice ignore Apache poi setLandscape(true) option where MS Excel does not
https://bugs.documentfoundation.org/show_bug.cgi?id=147238 --- Comment #1 from minee...@gmail.com --- Created attachment 178106 --> https://bugs.documentfoundation.org/attachment.cgi?id=178106=edit The worksheet is landscape orientation in MS office, but the same worksheet is portrait orientation in Libre Office. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147238] New: Why does LibreOffice ignore Apache poi setLandscape(true) option where MS Excel does not
https://bugs.documentfoundation.org/show_bug.cgi?id=147238 Bug ID: 147238 Summary: Why does LibreOffice ignore Apache poi setLandscape(true) option where MS Excel does not Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: minee...@gmail.com Description: I wanted to change excel page orientation to horizontal(landscape), so I used apache poi method PrintSetup.setLandscape(true). Unfortunetly It seems not working approprietly in Libre office, though I can see it right in MS Office. The settings show that Landscape option is selected, but right picture shows portrait. What LibreOffice show you and what LibreOffice’settings have are different. I don’t know how to resolve it. I will take any advice appreciate. Thank you. When the file is opened in Libre Office and MS Office, https://ask.libreoffice.org/uploads/asklibo/optimized/3X/5/3/53cc54c0353e5d3a217db5e14abc82526f31fbae_2_473x500.png Steps to Reproduce: 1. Using Apahe Poi XSSF PrintSetup setLandscape(true), set excel file's page orientation to landscape 2.Open this excel file in MS Office and Libre Office. 3.See this in page preview mode and check page style. Actual Results: The worksheet is landscape orientation in MS office, but the same worksheet is portrait orientation in Libre Office. Expected Results: The worksheet has to be landscape orientation when it was opened in Libre Office. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.5.2 (x64) / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ko-KR (ko_KR); UI: ko-KR Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/docsh.cxx | 28
1 file changed, 8 insertions(+), 20 deletions(-)
New commits:
commit 76fa8d13c5244cf8b1f573e849f4cd2d2347a128
Author: Mike Kaganski
AuthorDate: Sun Feb 6 21:22:56 2022 +0100
Commit: Mike Kaganski
CommitDate: Mon Feb 7 06:06:59 2022 +0100
Simplify the code a bit
Change-Id: I9c35a32dcb877634d885b64ee56099fb8f314a94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129559
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 1d68cfd1e070..8995aceafdff 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -1843,33 +1843,21 @@ void lcl_ScDocShell_GetFixedWidthString( OUString&
rStr, const ScDocument& rDoc,
{
if ( bValue && eHorJust == SvxCellHorJustify::Standard )
eHorJust = SvxCellHorJustify::Right;
-sal_Int32 nBlanks = nLen - aString.getLength();
+OUStringBuffer aTmp(nLen);
switch ( eHorJust )
{
case SvxCellHorJustify::Right:
-{
-OUStringBuffer aTmp;
-comphelper::string::padToLength( aTmp, nBlanks, ' ' );
-aString = aTmp.append(aString).makeStringAndClear();
-}
-break;
+comphelper::string::padToLength( aTmp, nLen -
aString.getLength(), ' ' );
+aString = aTmp.append(aString);
+break;
case SvxCellHorJustify::Center:
-{
-sal_Int32 nLeftPad = nBlanks / 2;
-OUStringBuffer aTmp;
-comphelper::string::padToLength( aTmp, nLeftPad, ' ' );
-aTmp.append(aString);
-comphelper::string::padToLength( aTmp, nLen, ' ' );
-aString = aTmp.makeStringAndClear();
-}
-break;
+comphelper::string::padToLength( aTmp, (nLen -
aString.getLength()) / 2, ' ' );
+[[fallthrough]];
default:
-{
-OUStringBuffer aTmp(aString);
+aTmp.append(aString);
comphelper::string::padToLength( aTmp, nLen, ' ' );
-aString = aTmp.makeStringAndClear();
-}
}
+aString = aTmp.makeStringAndClear();
}
rStr = aString;
}
[Libreoffice-bugs] [Bug 147221] Cell references not updated correctly during merge cells
https://bugs.documentfoundation.org/show_bug.cgi?id=147221 --- Comment #5 from Jim Avera --- Merging *moves content* in the common case rather than just hiding it. That is why references to the (moved) content break. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82674] PDF: Export-as-PDF during Page Preview corrupts display (2 overlapping images)
https://bugs.documentfoundation.org/show_bug.cgi?id=82674 Jim Avera changed: What|Removed |Added Attachment #178104|0 |1 is obsolete|| --- Comment #19 from Jim Avera --- Created attachment 178105 --> https://bugs.documentfoundation.org/attachment.cgi?id=178105=edit Video showing reproducing the bug on Master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82674] PDF: Export-as-PDF during Page Preview corrupts display (2 overlapping images)
https://bugs.documentfoundation.org/show_bug.cgi?id=82674 --- Comment #18 from Jim Avera --- Created attachment 178104 --> https://bugs.documentfoundation.org/attachment.cgi?id=178104=edit Video showing reproducing bug on Master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143781] [META] Development- and code-related bug reports
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 Michael Warner changed: What|Removed |Added Depends on||145759 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145759 [Bug 145759] Use symbolic constants instead of magic numerical constants -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145759] Use symbolic constants instead of magic numerical constants
https://bugs.documentfoundation.org/show_bug.cgi?id=145759 Michael Warner changed: What|Removed |Added Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147229] File name when saving a new text document
https://bugs.documentfoundation.org/show_bug.cgi?id=147229 --- Comment #1 from Michael Warner --- A name like "Untitled 1" is what some other word processors and text editors use. Actually, in my own documents, the first words of the document are never what I want the name of the file to be. I don't have any metrics to back this up, but my guess is that in almost all cases someone will have to type in the file name regardless of what is used as default. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82674] PDF: Export-as-PDF during Page Preview corrupts display (2 overlapping images)
https://bugs.documentfoundation.org/show_bug.cgi?id=82674 --- Comment #17 from Jim Avera --- Hi Jean-Baptiste, I documented the zoom levels which happened to be in effect for me, just in case it was important. There is nothing special about those particular settings. I'm stumped. Maybe the problem occurs only with certain screen resolutions and/or Gnome extensions. My monitor is 1920x1200 which is fairly unusual. Also I have the Gnome "Dash to Panel" extension installed, with the panel at the bottom of the screen (not the default left edge), with Panel thickness set to 48 pixels. Can anyone think of how to figure out what is different between Jean-Baptiste's and my system? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147215] LibreOfficeDev_7.3.1.0.0_Linux_x86-64_rpm DL04-02-2022 CALC crashes everytime in every way
https://bugs.documentfoundation.org/show_bug.cgi?id=147215 Michael Warner changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #3 from Michael Warner --- Can you post the information from Help->About LibreOffice? It doesn't have to be while using Calc, getting it from Writer or the recent files screen is fine. Use the button in that window to copy it to the clipboard and then paste it here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146599] XIRR produces incorrect value
https://bugs.documentfoundation.org/show_bug.cgi?id=146599 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145808] Incorrect (too large) UI font / text on macOS with Japanese langpack
https://bugs.documentfoundation.org/show_bug.cgi?id=145808 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141478] Calc crashes on any copy or cut operation when Croatian language used
https://bugs.documentfoundation.org/show_bug.cgi?id=141478 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146947] Ability to show/reveal characters being typed into password prompt to decrypt a document
https://bugs.documentfoundation.org/show_bug.cgi?id=146947 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146945] Chart in writer doesn't update axis labels if its data is in Writer table
https://bugs.documentfoundation.org/show_bug.cgi?id=146945 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146936] Libreoffice loosing all keyboard inputs after certein tooltip conditions
https://bugs.documentfoundation.org/show_bug.cgi?id=146936 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146933] Certain Keypress events in Base no longer responded to
https://bugs.documentfoundation.org/show_bug.cgi?id=146933 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146930] Image changes position for every anchoring change
https://bugs.documentfoundation.org/show_bug.cgi?id=146930 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146929] Compression settings for images should remember user's choice
https://bugs.documentfoundation.org/show_bug.cgi?id=146929 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146928] inconsistent display of font name
https://bugs.documentfoundation.org/show_bug.cgi?id=146928 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146916] LibreOffice failed to load non-Unicode CJK fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=146916 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147193] Generation of pivot table in calc fails with more then 1000 records
https://bugs.documentfoundation.org/show_bug.cgi?id=147193 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147193] Generation of pivot table in calc fails with more then 1000 records
https://bugs.documentfoundation.org/show_bug.cgi?id=147193 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147029] Improve lots of templates loading performance
https://bugs.documentfoundation.org/show_bug.cgi?id=147029 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147029] Improve lots of templates loading performance
https://bugs.documentfoundation.org/show_bug.cgi?id=147029 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141116] Running a convert from Word to PDF script grey lines are added to the final PDF document
https://bugs.documentfoundation.org/show_bug.cgi?id=141116 --- Comment #3 from QA Administrators --- Dear Bob, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140512] Charts convert data range to internal table when copying worksheets
https://bugs.documentfoundation.org/show_bug.cgi?id=140512 --- Comment #4 from QA Administrators --- Dear snarfolus, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139802] Middle mouse button paste creates double space
https://bugs.documentfoundation.org/show_bug.cgi?id=139802 --- Comment #3 from QA Administrators --- Dear Quintao, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139671] Unwanted scroll deleting header
https://bugs.documentfoundation.org/show_bug.cgi?id=139671 --- Comment #6 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136808] getting "please install hyphenation package for locale en-US" every time I start Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=136808 --- Comment #6 from QA Administrators --- Dear Bill Holmes, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134079] Layout freeze with specific document and an image anchored to character at the wrong spot
https://bugs.documentfoundation.org/show_bug.cgi?id=134079 --- Comment #11 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146851] The logic of Cross Reference representing Paragraph Numbering is different between MSOffice and LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146851 --- Comment #9 from yilin --- Same problem as softdev1...@outlook.com, Looking forward to your response asap, thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146851] The logic of Cross Reference representing Paragraph Numbering is different between MSOffice and LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146851 --- Comment #8 from thomas.bull...@joseflegal.com --- I am encountering the same issues as softdev1...@outlook.com Can we get some action on this? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114532] add support for WEBP image format (image import and inside .ods/.odt)
https://bugs.documentfoundation.org/show_bug.cgi?id=114532 --- Comment #26 from Tomaz Vajngerl --- So IMHO we should store both WebP and PNG in the document. The reason is that after we decide that WebP has been supported in enough LO versions, we can just turn off saving the additional PNG fallback. Any documents that were created in the mean time with the WebP images will be able to remove the fallback PNG after this with just re-saving the file. One thing we need to remember is that WebP on the web is mostly used to super-compress the images to save bandwidth, so the images will mostly be using the lossy part of WebP. So if we convert such an image to PNG the size will increase significantly, so storing the original WebP in addition is insignificant compared to the overall size of PNG. I did a test - a 24MP photo compressed to 80% WebP was giving me 2.6MB. Convert that to PNG at compression level 9 resulted in 33.7MB and it took a looong time to compress. Reducing the compression level to a more typical 5 gave me 35.8MB. So the PNG vs. PNG + WebP is not even 10% increase in size and the size of WebP is similar to the difference between the PNG compression levels. There is another thing we can do and instead PNG use JPEG in such cases (Lossy WebP), so we would keep WebP and use JPEG for the fallback when opening in the older versions of LibreOffice. JPEG at 80,85,90 is giving me 4MB/5MB/6.6MB, which combined with the original WebP is still less than 1/3 of the PNG. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147029] Improve lots of templates loading performance
https://bugs.documentfoundation.org/show_bug.cgi?id=147029 --- Comment #2 from Po-Yen Huang --- (In reply to Roman Kuznetsov from comment #1) > How many templates do you have there? Over hundreds? I need some number for > confirming It is about 300~400 templates. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147206] copy+Rich Text Formatting RTF paste special turns entire document into hyperlink text
https://bugs.documentfoundation.org/show_bug.cgi?id=147206 --- Comment #1 from Tai --- Some users responded, they think it's a bug: https://ask.libreoffice.org/t/table-of-contents-copy-rich-text-formatting-paste-special-makes-entire-document-hyperlink/73557/2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147161] [LODE] Consider cloning core/ repo with less history
https://bugs.documentfoundation.org/show_bug.cgi?id=147161 --- Comment #3 from Hossein --- Without sub-modules, the cloned size of cloned core tar.xz is: (for me) core -> 2.1G core.tar.xz core, depth=1 -> 573M core1.tar.xz -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146174] ALT no longer usable for hotkeys, goes to dropdown menu now (started in 7.2.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=146174 --- Comment #8 from freenas.k...@gmx.at --- The bug also appears in Linux Mint 20.3 Version: 7.3.0.3 / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded I use my hotkeys ALT+F, ALT+H etc all day, so I cannot work anymore since updating from 7.2.0 ... Seems to be a problem with gtk3 only. If I do: export SAL_USE_VCLPLUGIN=qt5 or export SAL_USE_VCLPLUGIN=gen and start LO from command line, the hotkeys work. (They also work in LO for Windows) So Michael's connection with the recent commit to gtk3 menubar might be correct? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81593] Regression: thumbnails in gallery have poor resolution and excessive enlargement when the vector source has small dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=81593 --- Comment #21 from Jean-Baptiste Faure --- Created attachment 178103 --> https://bugs.documentfoundation.org/attachment.cgi?id=178103=edit thumbails from LO 7.4.0.0.alpha0+ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99671] [META] Gallery bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=99671 Bug 99671 depends on bug 81593, which changed state. Bug 81593 Summary: Regression: thumbnails in gallery have poor resolution and excessive enlargement when the vector source has small dimensions https://bugs.documentfoundation.org/show_bug.cgi?id=81593 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81593] Regression: thumbnails in gallery have poor resolution and excessive enlargement when the vector source has small dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=81593 Jean-Baptiste Faure changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC||jbfa...@libreoffice.org --- Comment #20 from Jean-Baptiste Faure --- Not reproducible for me with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 8b327cd86d71d71d2f5f883321e5d53e3b42ed4e CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: en-US Ubuntu_20.04_x86-64 Calc: threaded Closing as WorksForMe. Please feel free to reopen if you disagree. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146992] Arrowheads in dropdowns shift a little when opened
https://bugs.documentfoundation.org/show_bug.cgi?id=146992 Aron Budea changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from Aron Budea --- Verified, thanks for fixing, Caolán! Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: d5f015185240a7bddfed7ddf10d6b5426e35fb72 CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80120] Crop combined with contour gives wrong PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=80120 --- Comment #14 from Jean-Baptiste Faure --- Created attachment 178102 --> https://bugs.documentfoundation.org/attachment.cgi?id=178102=edit PDF produced with LO 7.4.0.0.alpha0+ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116109] [META] Regressions introduced by unified Graphic processing to use GraphicPrimitive2D
https://bugs.documentfoundation.org/show_bug.cgi?id=116109 Bug 116109 depends on bug 80120, which changed state. Bug 80120 Summary: Crop combined with contour gives wrong PDF export https://bugs.documentfoundation.org/show_bug.cgi?id=80120 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108280] [META] Image crop bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108280 Bug 108280 depends on bug 80120, which changed state. Bug 80120 Summary: Crop combined with contour gives wrong PDF export https://bugs.documentfoundation.org/show_bug.cgi?id=80120 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 80120, which changed state. Bug 80120 Summary: Crop combined with contour gives wrong PDF export https://bugs.documentfoundation.org/show_bug.cgi?id=80120 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80120] Crop combined with contour gives wrong PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=80120 Jean-Baptiste Faure changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC||jbfa...@libreoffice.org --- Comment #13 from Jean-Baptiste Faure --- Not reproducible with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 8b327cd86d71d71d2f5f883321e5d53e3b42ed4e CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: en-US Ubuntu_20.04_x86-64 Calc: threaded and Version: 7.3.1.0.0+ / LibreOffice Community Build ID: 57a9a2f2c7b60b1edffae0a070f0eefaedcf9e6d CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Ubuntu_20.04_x86-64 Calc: threaded Closing as WorksForMe. Please feel free to reopen if you disagree. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 79802] SLIDESHOW: long text "scroll through" animation shows just black block
https://bugs.documentfoundation.org/show_bug.cgi?id=79802 --- Comment #15 from Jean-Baptiste Faure --- No problem with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 8b327cd86d71d71d2f5f883321e5d53e3b42ed4e CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: en-US Ubuntu_20.04_x86-64 Calc: threaded and Version: 7.3.1.0.0+ / LibreOffice Community Build ID: 57a9a2f2c7b60b1edffae0a070f0eefaedcf9e6d CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Ubuntu_20.04_x86-64 Calc: threaded Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147235] Writer doesn't remember "view/resolved comments"
https://bugs.documentfoundation.org/show_bug.cgi?id=147235 --- Comment #1 from thestro...@cock.li --- Version: 7.1.8.1 / LibreOffice Community Build ID: 10(Build:1) CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: nl-NL (en_US.UTF-8); UI: en-US 7.1.8-5 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147236] Hidden resolved comments are shown when text is copy-pasted
https://bugs.documentfoundation.org/show_bug.cgi?id=147236 --- Comment #1 from thestro...@cock.li --- Version: 7.1.8.1 / LibreOffice Community Build ID: 10(Build:1) CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: nl-NL (en_US.UTF-8); UI: en-US 7.1.8-5 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147237] New: Dynamic theme gtk switching only partially switches colors
https://bugs.documentfoundation.org/show_bug.cgi?id=147237 Bug ID: 147237 Summary: Dynamic theme gtk switching only partially switches colors Product: LibreOffice Version: 7.1.8.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thestro...@cock.li Description: When switching dark/light theme while running writer some parts of the UI don't switch colors, leading to very bad contrast. This is fixed by restarting. Steps to Reproduce: 1. Open writer when light theme is on 2. Switch to dark theme Actual Results: See the left part of the attached image Expected Results: See the right part of the attached image Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.8.1 / LibreOffice Community Build ID: 10(Build:1) CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: nl-NL (en_US.UTF-8); UI: en-US 7.1.8-5 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147236] New: Hidden resolved comments are shown when text is copy-pasted
https://bugs.documentfoundation.org/show_bug.cgi?id=147236 Bug ID: 147236 Summary: Hidden resolved comments are shown when text is copy-pasted Product: LibreOffice Version: 7.1.8.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thestro...@cock.li Description: When the setting "view/resolved comments" in the menu bar is unchecked, resolved comments should not be visible. However when you copy-paste text that contains some resolved comment, the comment appears again. Steps to Reproduce: 1. Create a resolved comment 2. Hide the resolved comments by unchecking "view/resolved comments" 3. Cut the text that contains the comment 4. Paste the text Actual Results: The comment is visible again Expected Results: The comment should still be invisble. Reproducible: Always User Profile Reset: No Additional Info: The toggle "view/resolved comments" is still unchecked. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138924] Libre Writer does not properly execute the IMAGE anchor choice as coded in STYLES.XML
https://bugs.documentfoundation.org/show_bug.cgi?id=138924 --- Comment #6 from John Lockridge --- 2/6/22 Some months ago, this bug was FIXED. I don't remember which release fixed it. I am now running 7.2.5.2. A couple of points worth noting: 1) After the bug was fixed, the user still had to change the default setup to FORMAT/ANCHOR/AS CHARACTER. (I don't remember what the original default is, perhaps "TO CHARACTER" instead of "AS CHARACTER". Once the default is changed to AS CHARACTER it works exactly like a former Microsoft Word user would expect. I think it would be better to make the DEFAULT be AS CHARACTER. That way a new convert from MSWORD would not need to fumble around trying to figure it out, become frustrated and possibly just turn back to WORD 2) If this fix is advertised, I would expect to see a lot of former WORD users pile onboard. Thanks much for fixing this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138924] Libre Writer does not properly execute the IMAGE anchor choice as coded in STYLES.XML
https://bugs.documentfoundation.org/show_bug.cgi?id=138924 Dieter changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147235] New: Writer doesn't remember "view/resolved comments"
https://bugs.documentfoundation.org/show_bug.cgi?id=147235 Bug ID: 147235 Summary: Writer doesn't remember "view/resolved comments" Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thestro...@cock.li How to reproduce: - Create a new document, put a comment in it and resolve that comment. - Uncheck "view/resolved comments" in the menu bar. The comment is not visible anymore. - Save document and close writer - Open the document again. Expected behavior: The comment is still not visible. Writer remembers the view setting. Actual behavior: The comment is visible again. The checkbox is checked again. Notes: The state of "view/comments" is remembered. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138924] Libre Writer does not properly execute the IMAGE anchor choice as coded in STYLES.XML
https://bugs.documentfoundation.org/show_bug.cgi?id=138924 John Lockridge changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 79544] Impress not yet able to import and render faithfully Office 2007 “WordArt Effects” text styles
https://bugs.documentfoundation.org/show_bug.cgi?id=79544 Luke changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7696 --- Comment #10 from Luke --- Improved after bug 127696 was fixed. But still repo in Version: 7.4.0.0.alpha0+ / LibreOffice Community -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101569] FILEOPEN: PPTX import WordArt is invisible when white text on white background
https://bugs.documentfoundation.org/show_bug.cgi?id=101569 --- Comment #10 from Luke --- Verified FIXED in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 29e66d56d1f5499556fc38e51df76ce9210119fe -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147232] Improvement of CALC diagrams
https://bugs.documentfoundation.org/show_bug.cgi?id=147232 --- Comment #2 from LeroyG --- Created attachment 178101 --> https://bugs.documentfoundation.org/attachment.cgi?id=178101=edit Sample file. As a workaround, you can set the size of the wall to match your needs. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147021] Use std::size() instead of SAL_N_ELEMENTS() macro
https://bugs.documentfoundation.org/show_bug.cgi?id=147021 --- Comment #3 from Commit Notification --- VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8b327cd86d71d71d2f5f883321e5d53e3b42ed4e tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: basctl/source basegfx/source basic/qa basic/source binaryurp/qa chart2/qa chart2/source codemaker/source
basctl/source/basicide/baside2.cxx |2 +-
basegfx/source/polygon/b2dpolypolygontools.cxx |2 +-
basic/qa/cppunit/test_vba.cxx|4 ++--
basic/source/runtime/methods.cxx |2 +-
basic/source/runtime/methods1.cxx| 14 +++---
binaryurp/qa/test-cache.cxx |2 +-
chart2/qa/extras/chart2export.cxx|2 +-
chart2/source/controller/dialogs/res_BarGeometry.cxx |2 +-
chart2/source/controller/dialogs/res_DataLabel.cxx |2 +-
codemaker/source/cppumaker/cpputype.cxx | 10 --
10 files changed, 20 insertions(+), 22 deletions(-)
New commits:
commit 8b327cd86d71d71d2f5f883321e5d53e3b42ed4e
Author: VaibhavMalik4187
AuthorDate: Fri Feb 4 17:36:52 2022 +0530
Commit: Hossein
CommitDate: Sun Feb 6 21:38:32 2022 +0100
tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
Change-Id: I4f5258ca5b37e9b1b4237c5d29e4a9e5362fa855
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129116
Reviewed-by: Arkadiy Illarionov
Reviewed-by: Mike Kaganski
Tested-by: Jenkins
diff --git a/basctl/source/basicide/baside2.cxx
b/basctl/source/basicide/baside2.cxx
index 52769276bacb..eecf917d6035 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -1584,7 +1584,7 @@ void ModulWindowLayout::SyntaxColors::NewConfig (bool
bFirst)
}
bool bChanged = false;
-for (unsigned i = 0; i != SAL_N_ELEMENTS(vIds); ++i)
+for (unsigned i = 0; i != std::size(vIds); ++i)
{
Color const aColor = aConfig.GetColorValue(vIds[i].eEntry).nColor;
Color& rMyColor = aColors[vIds[i].eTokenType];
diff --git a/basegfx/source/polygon/b2dpolypolygontools.cxx
b/basegfx/source/polygon/b2dpolypolygontools.cxx
index 74cdf23241d3..b49de907d45c 100644
--- a/basegfx/source/polygon/b2dpolypolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolypolygontools.cxx
@@ -514,7 +514,7 @@ namespace basegfx::utils
}
B2DPolygon aCurrSegment;
-const size_t sliceSize=SAL_N_ELEMENTS(numbers)/12;
+const size_t sliceSize=std::size(numbers)/12;
const int* pCurrSegment=numbers + nNumber*sliceSize;
for( size_t i=0; i(eType) & 0x0FFF;
-const size_t nTypeNameCount = SAL_N_ELEMENTS( pTypeNames );
+const size_t nTypeNameCount = std::size( pTypeNames );
if ( nPos >= nTypeNameCount )
{
nPos = nTypeNameCount - 1;
diff --git a/basic/source/runtime/methods1.cxx
b/basic/source/runtime/methods1.cxx
index 16104540ba96..31943cde2b80 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -1807,13 +1807,13 @@ static IntervalInfo const * getIntervalInfo( const
OUString& rStringCode )
{ INTERVAL_N,"n",1.0 / 1440.0, true }, // Minute
{ INTERVAL_S,"s",1.0 / 86400.0, true } // Second
};
-for( std::size_t i = 0; i != SAL_N_ELEMENTS(aIntervalTable); ++i )
-{
-if( rStringCode.equalsIgnoreAsciiCaseAscii(
-aIntervalTable[i].mStringCode ) )
-{
-return [i];
-}
+auto const pred = [](const IntervalInfo ) {
+return
rStringCode.equalsIgnoreAsciiCaseAscii(aInterval.mStringCode);
+};
+
+auto intervalIter = std::find_if(std::begin(aIntervalTable),
std::end(aIntervalTable), pred);
+if(intervalIter != std::end(aIntervalTable)) {
+return intervalIter;
}
return nullptr;
}
diff --git a/binaryurp/qa/test-cache.cxx b/binaryurp/qa/test-cache.cxx
index 989b103e2e90..c024f1f711d6 100644
--- a/binaryurp/qa/test-cache.cxx
+++ b/binaryurp/qa/test-cache.cxx
@@ -39,7 +39,7 @@ private:
// cf. jurt/test/com/sun/star/lib/uno/protocols/urp/Cache_Test.java:
void Test::testNothingLostFromLruList() {
int a[8];
-for (int i = 0; i != int(SAL_N_ELEMENTS(a)); ++i) {
+for (int i = 0; i != int(std::size(a)); ++i) {
for (int j = 0; j != i; ++j) {
a[j] = 0;
}
diff --git a/chart2/qa/extras/chart2export.cxx
b/chart2/qa/extras/chart2export.cxx
index a5c2e20cc58c..bca7897025a0 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -932,7 +932,7 @@ void Chart2ExportTest::testDataLabelBordersDOCX()
{ 2, css::drawing::LineStyle_SOLID, 0x00FF } // solid red
};
-for (size_t i = 0; i < SAL_N_ELEMENTS(aDataPoints); ++i)
+for (size_t i = 0; i < std::size(aDataPoints); ++i)
{
xPropSet =
xDataSeries->getDataPointByIndex(aDataPoints[i].mnIndex);
CPPUNIT_ASSERT(xPropSet.is());
diff --git a/chart2/source/controller/dialogs/res_BarGeometry.cxx
b/chart2/source/controller/dialogs/res_BarGeometry.cxx
index 182d391aac33..97befbe1f8f5 100644
---
[Libreoffice-bugs] [Bug 147021] Use std::size() instead of SAL_N_ELEMENTS() macro
https://bugs.documentfoundation.org/show_bug.cgi?id=147021 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147234] Inconsistent recognition of date
https://bugs.documentfoundation.org/show_bug.cgi?id=147234 LeroyG changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Version|7.3.0.2 rc |7.1.8.1 release OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/notebookbar_compact.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6bbc2eba29389bf7937ab5fd08b62821cbd56a97 Author: Andrea Gelmini AuthorDate: Thu Feb 3 15:58:01 2022 +0100 Commit: Julien Nabet CommitDate: Sun Feb 6 21:29:30 2022 +0100 Fix typo in code Change-Id: I1c5350ab5e039b80ebc36922a66da7f0083162a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129450 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/sw/uiconfig/swriter/ui/notebookbar_compact.ui b/sw/uiconfig/swriter/ui/notebookbar_compact.ui index 3012b7dcab1f..b9387a2effc9 100644 --- a/sw/uiconfig/swriter/ui/notebookbar_compact.ui +++ b/sw/uiconfig/swriter/ui/notebookbar_compact.ui @@ -3189,7 +3189,7 @@ False center - + True False center
[Libreoffice-bugs] [Bug 140147] position of cursor not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=140147 --- Comment #33 from Giovanni --- Here too. LibreOffice 7.3 is bugged again. Using it on ArchLinux and Manjaro Linux with Xfce 64 bits. All packages updated at the current date. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/inc/interpre.hxx | 14 +++---
sc/source/core/tool/interpr1.cxx |9 -
sc/source/core/tool/interpr2.cxx |4 +---
sc/source/core/tool/interpr5.cxx |2 +-
sc/source/core/tool/interpr8.cxx | 18 +-
5 files changed, 22 insertions(+), 25 deletions(-)
New commits:
commit 1c635de6ed48dec4566341c174351432ddab757d
Author: Mike Kaganski
AuthorDate: Sun Feb 6 18:48:44 2022 +0100
Commit: Mike Kaganski
CommitDate: Sun Feb 6 21:06:55 2022 +0100
Avoid excessive reallocations
Change-Id: I68ff7021c26dd2148f85506fd0c67e233753c63a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129558
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index 322b2e32d5a0..2e90271af4c0 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -481,11 +481,11 @@ private:
// Check for String overflow of rResult+rAdd and set error and erase
rResult
// if so. Return true if ok, false if overflow
-inline bool CheckStringResultLen( OUString& rResult, const OUString& rAdd
);
+inline bool CheckStringResultLen( OUString& rResult, sal_Int32 nIncrease );
// Check for String overflow of rResult+rAdd and set error and erase
rResult
// if so. Return true if ok, false if overflow
-inline bool CheckStringResultLen( OUStringBuffer& rResult, const OUString&
rAdd );
+inline bool CheckStringResultLen( OUStringBuffer& rResult, sal_Int32
nIncrease );
// Set error according to rVal, and set rVal to 0.0 if there was an error.
inline void TreatDoubleError( double& rVal );
@@ -1113,9 +1113,9 @@ inline sal_Int32
ScInterpreter::GetStringPositionArgument()
return static_cast(fVal);
}
-inline bool ScInterpreter::CheckStringResultLen( OUString& rResult, const
OUString& rAdd )
+inline bool ScInterpreter::CheckStringResultLen( OUString& rResult, sal_Int32
nIncrease )
{
-if (rAdd.getLength() > kScInterpreterMaxStrLen - rResult.getLength())
+if (nIncrease > kScInterpreterMaxStrLen - rResult.getLength())
{
SetError( FormulaError::StringOverflow );
rResult.clear();
@@ -1124,12 +1124,12 @@ inline bool ScInterpreter::CheckStringResultLen(
OUString& rResult, const OUStri
return true;
}
-inline bool ScInterpreter::CheckStringResultLen( OUStringBuffer& rResult,
const OUString& rAdd )
+inline bool ScInterpreter::CheckStringResultLen( OUStringBuffer& rResult,
sal_Int32 nIncrease )
{
-if (rAdd.getLength() > kScInterpreterMaxStrLen - rResult.getLength())
+if (nIncrease > kScInterpreterMaxStrLen - rResult.getLength())
{
SetError( FormulaError::StringOverflow );
-rResult = OUStringBuffer();
+rResult.setLength(0);
return false;
}
return true;
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 450b70f264b9..983f2aca8020 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -8865,9 +8865,8 @@ void ScInterpreter::ScReplace()
aOldStr.iterateCodePoints( );
++nCnt;
}
-aOldStr = aOldStr.replaceAt( nStart, nIdx - nStart, u"" );
-if ( CheckStringResultLen( aOldStr, aNewStr ) )
-aOldStr = aOldStr.replaceAt( nStart, 0, aNewStr );
+if ( CheckStringResultLen( aOldStr, aNewStr.getLength() - (nIdx -
nStart) ) )
+aOldStr = aOldStr.replaceAt( nStart, nIdx - nStart, aNewStr );
PushString( aOldStr );
}
}
@@ -9704,7 +9703,7 @@ void ScInterpreter::ScSubstitute()
oResult.emplace(sStr.getLength() + sNewStr.getLength() -
sOldStr.getLength());
oResult->append(sStr.subView(nPos, nEnd - nPos)); // Copy leading
unchanged text
-if (!CheckStringResultLen(*oResult, sNewStr))
+if (!CheckStringResultLen(*oResult, sNewStr.getLength()))
return PushError(GetError());
oResult->append(sNewStr); // Copy the replacement
nPos = nEnd + sOldStr.getLength();
@@ -9750,7 +9749,7 @@ void ScInterpreter::ScConcat()
while( nParamCount-- > 0)
{
OUString aStr = GetString().getString();
-if (CheckStringResultLen( aRes, aStr))
+if (CheckStringResultLen(aRes, aStr.getLength()))
aRes = aStr + aRes;
else
break;
diff --git a/sc/source/core/tool/interpr2.cxx b/sc/source/core/tool/interpr2.cxx
index 6525f2a6784b..fda54fcf898f 100644
--- a/sc/source/core/tool/interpr2.cxx
+++ b/sc/source/core/tool/interpr2.cxx
@@ -3033,10 +3033,8 @@ void ScInterpreter::ScRoman()
sal_Int32 nPad = nDigit % 5;
if (nPad)
{
-OUStringBuffer aBuf(aRoman);
-comphelper::string::padToLength(aBuf, aBuf.getLength() +
nPad,
+
[Libreoffice-bugs] [Bug 147234] Inconsistent recognition of date
https://bugs.documentfoundation.org/show_bug.cgi?id=147234 Victor changed: What|Removed |Added Resolution|NOTABUG |--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED --- Comment #3 from Victor --- Maybe it is not a bug in 2022, but it soon will be. So there will be a moment that we are forced to break the backwards compatibility in the next 8 years. This transition should not be made for a fixed year. Wenn it was coded, it was apparently seen as appropriate to have this transition a few decades in the future. That is what it should be dynamically. That should be based on the year a spread sheet was created, not to mess with existing documents. Also for people not expecting this behaviour and accidentally creating big problems (which will become more common as we near 2030), it would be good to produce a warning when years from two different centuries are in a spreadsheet while the date format specifies to format the year in two digits. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146548] FORMATTING - Negative numbers not red
https://bugs.documentfoundation.org/show_bug.cgi?id=146548 --- Comment #7 from m.a.riosv --- Works for me Version: 7.3.0.3 (x64) / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL Maybe Menu/View/Value Highlighting? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics
https://bugs.documentfoundation.org/show_bug.cgi?id=132643 --- Comment #723 from Commit Notification --- Johnny_M committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/1cd6e1e0360f3bef1879d717be450d6ec27e3f38 tdf#132643 Translate German section IDs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 68aa3222b1b7953f2b5eb419ea3bec871091e574 Author: Johnny_M AuthorDate: Sun Feb 6 20:45:32 2022 +0100 Commit: Gerrit Code Review CommitDate: Sun Feb 6 20:45:32 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 1cd6e1e0360f3bef1879d717be450d6ec27e3f38 - tdf#132643 Translate German section IDs Remove unused. Change-Id: I68c7f378b8edea60771ae25829f618e6598955a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129577 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 75d8c2b3a223..1cd6e1e0360f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 75d8c2b3a2233265040c08483d5e889916b8616a +Subproject commit 1cd6e1e0360f3bef1879d717be450d6ec27e3f38
[Libreoffice-commits] help.git: source/text
source/text/swriter/02/1812.xhp |6 -- 1 file changed, 6 deletions(-) New commits: commit 1cd6e1e0360f3bef1879d717be450d6ec27e3f38 Author: Johnny_M AuthorDate: Sun Feb 6 13:56:03 2022 +0100 Commit: Olivier Hallot CommitDate: Sun Feb 6 20:45:31 2022 +0100 tdf#132643 Translate German section IDs Remove unused. Change-Id: I68c7f378b8edea60771ae25829f618e6598955a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129577 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/02/1812.xhp b/source/text/swriter/02/1812.xhp index 63473e6b5..84a1651cf 100644 --- a/source/text/swriter/02/1812.xhp +++ b/source/text/swriter/02/1812.xhp @@ -27,8 +27,6 @@ - - Images and Charts @@ -39,9 +37,6 @@ If the Images and Charts icon on the Tools bar is activated, no graphics are displayed - only empty frames as placeholders. - - - @@ -54,7 +49,6 @@ -
[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics
https://bugs.documentfoundation.org/show_bug.cgi?id=132643 --- Comment #722 from Commit Notification --- Johnny_M committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/75d8c2b3a2233265040c08483d5e889916b8616a tdf#132643 Translate German section IDs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 46e20f95bc459add5c2f4cc2daef112ff768535e Author: Johnny_M AuthorDate: Sun Feb 6 20:44:52 2022 +0100 Commit: Gerrit Code Review CommitDate: Sun Feb 6 20:44:52 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 75d8c2b3a2233265040c08483d5e889916b8616a - tdf#132643 Translate German section IDs Change-Id: Ie93feb7f23ef7f83d72f59c1ae0706de60e3f426 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129576 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 507676ac0051..75d8c2b3a223 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 507676ac005119b4e006fd3fa4c1dd57ab9a191f +Subproject commit 75d8c2b3a2233265040c08483d5e889916b8616a
[Libreoffice-commits] help.git: source/text
source/text/swriter/02/0322.xhp |4 ++-- source/text/swriter/main0215.xhp|4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 75d8c2b3a2233265040c08483d5e889916b8616a Author: Johnny_M AuthorDate: Sun Feb 6 13:51:52 2022 +0100 Commit: Olivier Hallot CommitDate: Sun Feb 6 20:44:51 2022 +0100 tdf#132643 Translate German section IDs Change-Id: Ie93feb7f23ef7f83d72f59c1ae0706de60e3f426 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129576 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/02/0322.xhp b/source/text/swriter/02/0322.xhp index 294a91256..ca9da786a 100644 --- a/source/text/swriter/02/0322.xhp +++ b/source/text/swriter/02/0322.xhp @@ -32,7 +32,7 @@ - + frames;unlinking unlinking frames @@ -40,7 +40,7 @@ Unlink Frames Breaks the link between two frames. You can only break the link that extends from the selected frame to the target frame. - + diff --git a/source/text/swriter/main0215.xhp b/source/text/swriter/main0215.xhp index 7cdfa8edc..a7efc6d7d 100644 --- a/source/text/swriter/main0215.xhp +++ b/source/text/swriter/main0215.xhp @@ -78,7 +78,7 @@ - - + +
[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics
https://bugs.documentfoundation.org/show_bug.cgi?id=132643 --- Comment #721 from Commit Notification --- Johnny_M committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/507676ac005119b4e006fd3fa4c1dd57ab9a191f tdf#132643 Translate German section IDs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8cd3565cfed84d517d0839d96a620423ab02b9cc Author: Johnny_M AuthorDate: Sun Feb 6 20:42:25 2022 +0100 Commit: Gerrit Code Review CommitDate: Sun Feb 6 20:42:25 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 507676ac005119b4e006fd3fa4c1dd57ab9a191f - tdf#132643 Translate German section IDs Change-Id: I118f997877d52531f12f977a9038c47dade422ac Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129574 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 23bf50f5437f..507676ac0051 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 23bf50f5437f38debeaff483b662c7be552fdda5 +Subproject commit 507676ac005119b4e006fd3fa4c1dd57ab9a191f
[Libreoffice-commits] help.git: source/text
source/text/swriter/02/1405.xhp |4 ++-- source/text/swriter/main0214.xhp|4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 507676ac005119b4e006fd3fa4c1dd57ab9a191f Author: Johnny_M AuthorDate: Sun Feb 6 13:15:26 2022 +0100 Commit: Olivier Hallot CommitDate: Sun Feb 6 20:42:20 2022 +0100 tdf#132643 Translate German section IDs Change-Id: I118f997877d52531f12f977a9038c47dade422ac Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129574 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/02/1405.xhp b/source/text/swriter/02/1405.xhp index e22b7a30b..80ad856e4 100644 --- a/source/text/swriter/02/1405.xhp +++ b/source/text/swriter/02/1405.xhp @@ -32,11 +32,11 @@ - + Formula Area Allows you to create a formula by typing it directly into the input line or by clicking the Formula icon to display the formulas in submenu. - + diff --git a/source/text/swriter/main0214.xhp b/source/text/swriter/main0214.xhp index 95cdf7745..f32b79590 100644 --- a/source/text/swriter/main0214.xhp +++ b/source/text/swriter/main0214.xhp @@ -43,7 +43,7 @@ - - + +
