[Libreoffice-bugs] [Bug 148051] Crashings for unkown reasons, despite reset user profile etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=148051 --- Comment #11 from Sam --- FWIW, already in 2017, when I was running macOS Sierra 10.12.6, LO began to crash for no apparent reason (before that, on Mountain Lion, LO worked perfectly): https://ask.libreoffice.org/t/due-to-an-unexpected-error-libreoffice-crashed/24936 Back then I took my mac and went to an Apple shop. They said they could not offer any support since a third-party app was the only app causing problems on my machine, and I should ask the developers instead to solve the issue. I filed #114064 and was asked to provide a sample file, but I did not provide one because the crashes occurred even with empty/new files. I was frustrated and had no choice but to stop using LO altogether. I gave LO another try in 2020, now on a different macOS (can't remember which one), and LO worked fine. There were the occasional crashes (maybe once every few days), but I could live with that. Since version 6.2 LibreOffice is by far the best office software for me to use; I rely heavily on ICU Regular Expressions in Writer and Calc, so simply changing to a different office software is no option for me (even if MS office does not crash on my computer). I think it was after updating to macOS Monterey that crashes becan to occur frequently again – once or even several times every few hours. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147796] Quickly opening and closing documents causes extra menubars to be added until LibreOffice crashes when LanguageTool extension is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=147796 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147097] Text boxes in Basic dialogs are being rendered without borders
https://bugs.documentfoundation.org/show_bug.cgi?id=147097 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147910] F1 (Help) for menu entries in dropdown menu for "Manage" button in Template Manager has no link to relevant help page entries
https://bugs.documentfoundation.org/show_bug.cgi?id=147910 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147911] F1 (Help) for all context menu items for templates in Template Manager have no links to relevant help page entries
https://bugs.documentfoundation.org/show_bug.cgi?id=147911 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147901] two problematic sentences in "Font Color" section in "Formatting Bar" help page
https://bugs.documentfoundation.org/show_bug.cgi?id=147901 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147898] instructions about paint can in "Font Color" section of "Font Effects" help page appears to be incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=147898 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147897] Unrolled items in Tools/ Customized/ Menus -> Category: My Macros
https://bugs.documentfoundation.org/show_bug.cgi?id=147897 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147891] Regression: roundtrip of presentations/drawings including cropped PDF images is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=147891 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147885] Crash if properties resize bar is dragged vertically
https://bugs.documentfoundation.org/show_bug.cgi?id=147885 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144067] Cannot export a template
https://bugs.documentfoundation.org/show_bug.cgi?id=144067 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144710] Crash in: ScViewData::GetDispatcher()
https://bugs.documentfoundation.org/show_bug.cgi?id=144710 --- Comment #2 from QA Administrators --- Dear Michael Dewsbury, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144067] Cannot export a template
https://bugs.documentfoundation.org/show_bug.cgi?id=144067 --- Comment #8 from QA Administrators --- Dear TorrAB, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144709] Crash in: SwTextShell::Execute(SfxRequest &) New
https://bugs.documentfoundation.org/show_bug.cgi?id=144709 --- Comment #3 from QA Administrators --- Dear Michael Dewsbury, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131917] Export of text introduces line break
https://bugs.documentfoundation.org/show_bug.cgi?id=131917 --- Comment #12 from QA Administrators --- Dear Paul Mirowsky, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Bug 117497 depends on bug 148135, which changed state. Bug 148135 Summary: Colibre: Group and Ungroup Icons for Shapes Are The Same https://bugs.documentfoundation.org/show_bug.cgi?id=148135 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148135] Colibre: Group and Ungroup Icons for Shapes Are The Same
https://bugs.documentfoundation.org/show_bug.cgi?id=148135 Rizal Muttaqin changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148135] Colibre: Group and Ungroup Icons for Shapes Are The Same
https://bugs.documentfoundation.org/show_bug.cgi?id=148135 --- Comment #3 from Rizal Muttaqin --- Created attachment 179092 --> https://bugs.documentfoundation.org/attachment.cgi?id=179092=edit Here the new icons in right click context menu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148169] New: Font selection in format toolbar is very slow to respond
https://bugs.documentfoundation.org/show_bug.cgi?id=148169 Bug ID: 148169 Summary: Font selection in format toolbar is very slow to respond Product: LibreOffice Version: 7.3.1.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robgr...@gmx.com Version: 7.3.1.3 / LibreOffice Community Build ID: eead5aec017556e2cdbf9dfff06537ec58969b73 CPU threads: 6; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: CL LO is installed from the snap. Deleted user profile. No success. Copied fonts to /snap/libreoffice/247/usr/share/fonts. No success. Problem: Open LO Writer. On format toolbar, click the font menu box to list fonts. Very long delay to show list of fonts: about 15 seconds. Cannot scroll up or down to find a font. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/hbox.cxx | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit e8c95b796626cb9db163f5d563fa67f38a5e92b0
Author: Caolán McNamara
AuthorDate: Thu Mar 24 20:14:41 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 25 00:10:45 2022 +0100
ofz: ensure unsigned index
Change-Id: I38d6238a6eede0188f942229b2fb931614e56309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132090
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index ed477155f7b9..59b0285926fb 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -175,7 +175,7 @@ hchar_string DateCode::GetString()
case '@':
{
static_assert((std::size(eng_mon) - 1) / 3 == 12);
-size_t nIndex = (date[MONTH] - 1) % 12;
+size_t nIndex = o3tl::make_unsigned(date[MONTH] - 1) % 12;
memcpy(cbuf, eng_mon + nIndex * 3, 3);
cbuf[3] = '.';
cbuf[4] = 0;
@@ -183,7 +183,7 @@ hchar_string DateCode::GetString()
}
case '*':
{
-size_t nIndex = (date[MONTH] - 1) % std::size(en_mon);
+size_t nIndex = o3tl::make_unsigned(date[MONTH] - 1) %
std::size(en_mon);
strncat(cbuf, en_mon[nIndex], sizeof(cbuf) - strlen(cbuf) - 1);
break;
}
@@ -220,14 +220,14 @@ hchar_string DateCode::GetString()
break;
case '6':
{
-size_t nIndex = date[WEEK] % std::size(kor_week);
+size_t nIndex = o3tl::make_unsigned(date[WEEK]) %
std::size(kor_week);
ret.push_back(kor_week[nIndex]);
break;
}
case '^':
{
static_assert((std::size(eng_week) - 1) / 3 == 7);
-size_t nIndex = date[WEEK] % 7;
+size_t nIndex = o3tl::make_unsigned(date[WEEK]) % 7;
memcpy(cbuf, eng_week + nIndex * 3, 3);
cbuf[3] = '.';
cbuf[4] = 0;
@@ -235,7 +235,7 @@ hchar_string DateCode::GetString()
}
case '_':
{
-size_t nIndex = date[WEEK] % std::size(en_week);
+size_t nIndex = o3tl::make_unsigned(date[WEEK]) %
std::size(en_week);
strncat(cbuf, en_week[nIndex], sizeof(cbuf) - strlen(cbuf) - 1);
break;
}
@@ -274,7 +274,7 @@ hchar_string DateCode::GetString()
fmt++;
if (*fmt == '6')
{
-size_t nIndex = date[WEEK] % std::size(china_week);
+size_t nIndex = o3tl::make_unsigned(date[WEEK]) %
std::size(china_week);
ret.push_back(china_week[nIndex]);
break;
}
[Libreoffice-bugs] [Bug 147774] CROSS REFERENCE TO HEADING: Need option to drop the final number separator in reference text
https://bugs.documentfoundation.org/show_bug.cgi?id=147774
Eyal Rozenberg changed:
What|Removed |Added
Summary|CROSS REFERENCE TO HEADING: |CROSS REFERENCE TO HEADING:
|There should be an option |Need option to drop the
|to drop the separator in|final number separator in
|reference text |reference text
--- Comment #8 from Eyal Rozenberg ---
(In reply to Heiko Tietze from comment #7)
First, my apologies for not being able to make the design meeting yesterday,
for the agenda item regarding this issue. Try as I might, I have many things
going on in my life, and that's besides my day job, so... even if I know a
meeting is upcoming I can usually not make it.
Anyway, I agree that
> I don't think we get a final clarification by renaming.
But that point is moot, because the "Number" and "Chapter" entries in the
refer-by dialog now have two differences. But none of the distinctions between
the two are properly served by the current names. And again, that's not the
point of this bug.
> To understand the
> idea behind "full number" and "number without final separator" you need to
> know this discussion. Ultimately it's a piece of cake to pick the right
> option by trial and error.
Ah, no. It is _impossible_ to pick the right option, because once there are two
semantic differences between the items, LO is only offering two of the four
possible options:
* Containing header ("chapter") number, with final separator
* Containing header ("chapter") number, without final separator
* Paragraph's number, with final separator
* Paragraph's number, without final separator
> For bug 142555 I believe we have to resolve it as WF. Both chapter and
> number are needed.
And so are with and without final separator options.
But like I've already written - even that is not enough. Because the
with/without final separator is necessary also for "Number (no context)" and
"Number (full context)". Which is why a toggle, separate from the list box, is
necessary.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148168] LibreOffice Document Recovery dialog shows weird text input field
https://bugs.documentfoundation.org/show_bug.cgi?id=148168 --- Comment #1 from skierpage --- Created attachment 179091 --> https://bugs.documentfoundation.org/attachment.cgi?id=179091=edit weird text input field over LibreOffice Document Recovery dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148168] New: LibreOffice Document Recovery dialog shows weird text input field
https://bugs.documentfoundation.org/show_bug.cgi?id=148168 Bug ID: 148168 Summary: LibreOffice Document Recovery dialog shows weird text input field Product: LibreOffice Version: 7.3.1.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@skierpage.com Description: When LibreOffice shows its Document Recovery dialog, if you start typing a text input field appears on it (see attachment), but it has no point and seems non-functional. Steps to Reproduce: 1. Trigger the LibreOffice Document Recovery dialog 2. Type random characters. Actual Results: A little text field appears obscuring the dialog's buttons (see attachment), but it doesn't do anything. Expected Results: No text field should appear. The dialog does accept keystrokes, e.g. if I recall correctly Alt+S to start recovery. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: LibreOffice crashed while I was editing two temporary read-only Calc spreadsheets that I opened from ZIP files in KDE's Ark archiving tool. Editing read-only temporary files created by another program despite the warnings is probably a bad idea. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133823] Firebird: Alias in a query will give "CASE" as column name in a form, if a field with same name existed
https://bugs.documentfoundation.org/show_bug.cgi?id=133823 Andreas Heinisch changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Andreas Heinisch --- Should be fixed with Bug 132924. *** This bug has been marked as a duplicate of bug 132924 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148167] Writer does not display SVG file correctly when inserted as image
https://bugs.documentfoundation.org/show_bug.cgi?id=148167 --- Comment #1 from Gerry --- Created attachment 179090 --> https://bugs.documentfoundation.org/attachment.cgi?id=179090=edit SVG-incorreclty-displayed-in-Writer.svg -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148167] New: Writer does not display SVG file correctly when inserted as image
https://bugs.documentfoundation.org/show_bug.cgi?id=148167 Bug ID: 148167 Summary: Writer does not display SVG file correctly when inserted as image Product: LibreOffice Version: 7.3.1.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gerry.trep...@googlemail.com Description: Writer does not display correctly the attached .svg file when inserted as image. The image shows four grey boxes with text in it. The text in the right grey box is not displayed correctly. Firefox, Chromium and Inkscape correctly display the file. There is no problem. The file was produced in Inkscape (saved as standard .svg) Steps to Reproduce: 1. Open empty writer document 2. Insert -> Image -> choose .svg file attached to this bug report 3. You see the incorrectly rendered text in the right box Actual Results: The text in they right gray box is wrongly displayed Expected Results: Writer should display the image exactly as in Firefox, Chromium or Inkscape. Reproducible: Always User Profile Reset: No Additional Info: System: tested on Windows 10 and Ubuntu 21.10 LibreOffice: Version: 7.3.1.3 / LibreOffice Community Build ID: 30(Build:3) CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Ubuntu package version: 1:7.3.1~rc3-0ubuntu0.21.10.1~lo2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/chart/create_chart.py | 119 -
sc/qa/uitest/chart/edit_chart.py | 63 ---
2 files changed, 182 deletions(-)
New commits:
commit be77181b3338ac249ca30b4f18c4d8e9e0a58da3
Author: Xisco Fauli
AuthorDate: Thu Mar 24 20:03:42 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Mar 24 22:31:09 2022 +0100
uitest: sc: remove tests not testing anything in particular
these tests were added in 2016 as a demo:
- 8a9861c47b66afed9f9a22ee7f507ba99cd4162a
"uitest: add demo for chart wizard"
- fc0c5d6163e99d29498c9b8599d9bdf9a3e4ca6c
"uitest: add demo showing how to deselect an UI object"
- 559f2e233108ed5e9da305ffbf945d6ed568f7eb
"uitest: add demo showing how to activate chart"
and others.
They just perform pretty basic actions and they have
no asserts at all.
After all these years, there are already other tests
covering the same actions
Change-Id: I978e28c090cf71a65db4881da96c865080ab9b6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132088
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/chart/create_chart.py
b/sc/qa/uitest/chart/create_chart.py
deleted file mode 100644
index 1da46638c46a..
--- a/sc/qa/uitest/chart/create_chart.py
+++ /dev/null
@@ -1,119 +0,0 @@
-# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-from libreoffice.uno.propertyvalue import mkPropertyValues
-
-from uitest.framework import UITestCase
-from uitest.uihelper.calc import enter_text_to_cell
-
-class CalcChartUIDemo(UITestCase):
-
-def fill_spreadsheet(self):
-xCalcDoc = self.xUITest.getTopFocusWindow()
-xGridWindow = xCalcDoc.getChild("grid_window")
-
-enter_text_to_cell(xGridWindow, "A1", "col1")
-enter_text_to_cell(xGridWindow, "B1", "col2")
-enter_text_to_cell(xGridWindow, "C1", "col3")
-enter_text_to_cell(xGridWindow, "A2", "1")
-enter_text_to_cell(xGridWindow, "B2", "3")
-enter_text_to_cell(xGridWindow, "C2", "5")
-
-xGridWindow.executeAction("SELECT", mkPropertyValues({"RANGE":
"A1:C2"}))
-
-def test_cancel_immediately(self):
-
-with self.ui_test.create_doc_in_start_center("calc"):
-
-self.fill_spreadsheet()
-
-with
self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart",
close_button="cancel"):
-pass
-
-
-def test_create_from_first_page(self):
-
-with self.ui_test.create_doc_in_start_center("calc"):
-
-self.fill_spreadsheet()
-
-with
self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart",
close_button="finish"):
-pass
-
-
-def test_create_from_second_page(self):
-
-with self.ui_test.create_doc_in_start_center("calc"):
-
-self.fill_spreadsheet()
-
-with
self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart",
close_button="finish") as xChartDlg:
-xNextBtn = xChartDlg.getChild("next")
-xNextBtn.executeAction("CLICK", tuple())
-
-xDataInRows = xChartDlg.getChild("RB_DATAROWS")
-xDataInRows.executeAction("CLICK", tuple())
-
-xDataInCols = xChartDlg.getChild("RB_DATACOLS")
-xDataInCols.executeAction("CLICK", tuple())
-
-
-def test_deselect_chart(self):
-with self.ui_test.create_doc_in_start_center("calc"):
-
-self.fill_spreadsheet()
-
-xCalcDoc = self.xUITest.getTopFocusWindow()
-xGridWindow = xCalcDoc.getChild("grid_window")
-
-with
self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart",
close_button="finish"):
-pass
-
-xGridWindow.executeAction("DESELECT", mkPropertyValues({"OBJECT":
""}))
-
-
-def test_activate_chart(self):
-
-with self.ui_test.create_doc_in_start_center("calc"):
-
-self.fill_spreadsheet()
-
-xCalcDoc = self.xUITest.getTopFocusWindow()
-xGridWindow = xCalcDoc.getChild("grid_window")
-
-with
self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart",
close_button="finish"):
-pass
-
-xGridWindow.executeAction("DESELECT", mkPropertyValues({"OBJECT":
""}))
-
-xGridWindow.executeAction("SELECT", mkPropertyValues({"OBJECT":
"Object 1"}))
-xGridWindow.executeAction("ACTIVATE", tuple())
-
-xGridWindow.executeAction("DESELECT", mkPropertyValues({"OBJECT":
""}))
-
-
-def select_chart_element(self):
-
-with
[Libreoffice-bugs] [Bug 148039] LO opens PPTX with out of position text
https://bugs.documentfoundation.org/show_bug.cgi?id=148039 --- Comment #21 from Dhaval Sonawane --- Created attachment 179089 --> https://bugs.documentfoundation.org/attachment.cgi?id=179089=edit LO 7.4.0 gives the same result on Ubuntu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148039] LO opens PPTX with out of position text
https://bugs.documentfoundation.org/show_bug.cgi?id=148039 --- Comment #20 from Dhaval Sonawane --- I was able to see the same behavior on Ubuntu as well. See the screenshot attached -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125895] Calc: print does not print unsaved cell
https://bugs.documentfoundation.org/show_bug.cgi?id=125895 --- Comment #7 from Todd --- Just got an eMail on this: What Removed Added Severity normal enhancement This is a DEFECT or BUG or whatever you want to call it. It is NOT an "enhancement". Please update the status properly. Many thanks, -T -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148166] Chart is empty when using data ranges from another document and the current document is empty
https://bugs.documentfoundation.org/show_bug.cgi?id=148166 --- Comment #2 from m.a.riosv --- If I remember fine to have links between files working, you need to have saved both files first. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148039] LO opens PPTX with out of position text
https://bugs.documentfoundation.org/show_bug.cgi?id=148039 --- Comment #19 from Dhaval Sonawane --- Created attachment 179088 --> https://bugs.documentfoundation.org/attachment.cgi?id=179088=edit LO 7.4.0 gives the same result -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148039] LO opens PPTX with out of position text
https://bugs.documentfoundation.org/show_bug.cgi?id=148039 --- Comment #18 from Dhaval Sonawane --- Thanks. I tried the 7.4.0 dev build on my mac and I still see the same issue. Find the attached snapshot -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125895] Calc: print does not print unsaved cell
https://bugs.documentfoundation.org/show_bug.cgi?id=125895 m.a.riosv changed: What|Removed |Added CC|miguelangelrv@libreoffice.o | |rg | Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125895] Calc: print does not print unsaved cell
https://bugs.documentfoundation.org/show_bug.cgi?id=125895 Todd changed: What|Removed |Added Resolution|NOTABUG |--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED --- Comment #6 from Todd --- Fedora 35 libreoffice7.3-calc-7.3.1.3-3.x86_64 IT'S BACK !!! Showed up at the bank with a missing line again. Fortunately, I remembered what it was suppose to say. Please fix this PERMANENTLY. Many thanks, -T -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147097] Text boxes in Basic dialogs are being rendered without borders
https://bugs.documentfoundation.org/show_bug.cgi?id=147097 Rafael Lima changed: What|Removed |Added Whiteboard||QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/writer_tests6/save_readonly_with_password.py |4 1 file changed, 4 insertions(+) New commits: commit 54e99c0bdea45ee76fd5d10c9712e848a010ed39 Author: Xisco Fauli AuthorDate: Tue Mar 1 14:30:27 2022 +0100 Commit: Xisco Fauli CommitDate: Thu Mar 24 21:10:26 2022 +0100 uitest: add prints to see the current dialog See https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/36931/consoleFull#-156104958948ce9c26-9d0a-43a8-83d8-c44f54920d59 I suspect it might fail because there is a dialog displayed Change-Id: Ia68b780d5a3881a6e555e6a4bc3086c6c9644749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130793 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sw/qa/uitest/writer_tests6/save_readonly_with_password.py b/sw/qa/uitest/writer_tests6/save_readonly_with_password.py index 5e6e8380345f..5593e852d7ed 100644 --- a/sw/qa/uitest/writer_tests6/save_readonly_with_password.py +++ b/sw/qa/uitest/writer_tests6/save_readonly_with_password.py @@ -10,6 +10,7 @@ from uitest.framework import UITestCase from libreoffice.uno.propertyvalue import mkPropertyValues from org.libreoffice.unotest import systemPathToFileUrl from uitest.uihelper.common import select_by_text +from uitest.uihelper.common import get_state_as_dict from tempfile import TemporaryDirectory import os.path @@ -47,6 +48,9 @@ class save_readonly_with_password(UITestCase): with self.ui_test.execute_dialog_through_action(xOk, "CLICK", close_button="save"): pass +win = self.xUITest.getTopFocusWindow() +print(get_state_as_dict(win)) +print(win.getChildren()) self.ui_test.wait_until_file_is_available(xFilePath) with self.ui_test.load_file(systemPathToFileUrl(xFilePath)) as document:
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/csv_dialog/tdf39716.py | 30 ++ sc/qa/uitest/data/tdf39716.csv |4 2 files changed, 34 insertions(+) New commits: commit 618b38fb406dfc578c60f63d002ecc1cf912a901 Author: Xisco Fauli AuthorDate: Thu Mar 24 18:07:23 2022 +0100 Commit: Xisco Fauli CommitDate: Thu Mar 24 21:08:36 2022 +0100 tdf#39716: sc: Add UItest Change-Id: Ic28f676d14b21edc1f06b726afbcfc19c8015b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132081 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/uitest/csv_dialog/tdf39716.py b/sc/qa/uitest/csv_dialog/tdf39716.py new file mode 100644 index ..a6c5035e38ff --- /dev/null +++ b/sc/qa/uitest/csv_dialog/tdf39716.py @@ -0,0 +1,30 @@ +# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +from uitest.framework import UITestCase +from uitest.uihelper.common import get_state_as_dict +from libreoffice.calc.csv_dialog import load_csv_file +from libreoffice.calc.document import get_cell_by_position + +class Tdf39716(UITestCase): + +def test_tdf39716(self): + +with load_csv_file(self, "tdf39716.csv", True) as xDialog: +pass + +document = self.ui_test.get_component() + +# Without the fix in place, this test would have failed with +# AssertionError: 2.5e-13 != 0.0 +self.assertEqual(2.5e-13, get_cell_by_position(document, 0, 0, 0).getValue()) +self.assertEqual(5e-13, get_cell_by_position(document, 0, 0, 1).getValue()) +self.assertEqual(7.5e-13, get_cell_by_position(document, 0, 0, 2).getValue()) +self.assertEqual(1e-12, get_cell_by_position(document, 0, 0, 3).getValue()) + +# vim: set shiftwidth=4 softtabstop=4 expandtab: diff --git a/sc/qa/uitest/data/tdf39716.csv b/sc/qa/uitest/data/tdf39716.csv new file mode 100644 index ..e400e6110895 --- /dev/null +++ b/sc/qa/uitest/data/tdf39716.csv @@ -0,0 +1,4 @@ +2.5E-13 +5E-13 +7.5E-13 +1E-12
[Libreoffice-bugs] [Bug 148166] Chart is empty when using data ranges from another document and the current document is empty
https://bugs.documentfoundation.org/show_bug.cgi?id=148166 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2011 CC||er...@redhat.com, ||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- @Eike, since you fixed bug 122011, I thought you might be interested in this issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148166] New: Chart is empty when using data ranges from another document and the current document is empty
https://bugs.documentfoundation.org/show_bug.cgi?id=148166 Bug ID: 148166 Summary: Chart is empty when using data ranges from another document and the current document is empty Product: LibreOffice Version: 6.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org I found this issue while creating a unittest for tdf#122011 Steps to reproduce: 1. Create a new document in calc 2. Add some data to A1:A3 3. Save 4. Open a document 5. Insert - Chart 6. In Data Range add the reference to the other document ( e.g. 'file:///home/xisco/Descargas/Untitled 1.ods'#$Sheet1.$A$1:$A$3 ) 7. Finish -> The chart is empty This issue is not reproducible if the current document contains some data. Repeat the steps before and add a number to any cell before inserting the chart. In this case the chart has data. Reproduced in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 4a46a74a3de0ac7df5d3ce949dda5e809c1729ab CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded and Version: 6.4.0.0.alpha1+ Build ID: 9bc848cf0d301aa57eabcffa101a1cf87bad6470 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: es-ES (es_ES.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148165] Misalignment between bullet points and text when line spacing is altered
https://bugs.documentfoundation.org/show_bug.cgi?id=148165 --- Comment #1 from Callegar --- Created attachment 179087 --> https://bugs.documentfoundation.org/attachment.cgi?id=179087=edit Screenshot showing the issue Note that both the dash and the round circle are too high wrt the following text. Setting the line spacing to 100% fixes this issue, but gives a too loose line spacing with this font. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148165] New: Misalignment between bullet points and text when line spacing is altered
https://bugs.documentfoundation.org/show_bug.cgi?id=148165 Bug ID: 148165 Summary: Misalignment between bullet points and text when line spacing is altered Product: LibreOffice Version: 7.3.1.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sergio.calleg...@gmail.com Description: When using some fonts it is almost indispensable to alter the line spacing. For instance, this is the case with the Adobe Source Sans 3 font that in LibO gives an extremely loose distance between lines. Unfortunately, when adjusting the line spacing (e.g., to proportional 80%), the alignment of bullet points to the text in bullet lists gets lost. With a reduced line spacing, the bullet appears too high. The opposite occurs with an enlarged line spacing. This is particularly visible in presentations. Steps to Reproduce: 1. Open a new presentation 2. Insert some text in the slide space where a bulleted list is pre-arranged 3. Change the formatting to use a font with a loose line spacing (e.g. Source Sans 3) 4. Fix the line spacing with paragraph properties, reducing it Actual Results: See the bullet loosing the vertical alignment to the text going too high Expected Results: The bullet should stay aligned to the text Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: PresentationDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146681] Shapes in DOCX worse and split since LO 7.3
https://bugs.documentfoundation.org/show_bug.cgi?id=146681 --- Comment #6 from Regina Henschel --- If you disable "contour wrap" on the group shape, rendering seems to be OK. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/xlsx/tdf70455.xlsx |binary
sc/qa/unit/subsequent_filters_test2.cxx | 15 +++
2 files changed, 15 insertions(+)
New commits:
commit f34994b20ecede29f03bf6c51bca2d48fda4ad1a
Author: Xisco Fauli
AuthorDate: Thu Mar 24 19:29:05 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Mar 24 20:15:47 2022 +0100
tdf#70455: sc_subsequent_filters2: Add unittest
Change-Id: I757bef506eff21071de8b8b40f5e1fc9d82b1ab7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132083
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/data/xlsx/tdf70455.xlsx
b/sc/qa/unit/data/xlsx/tdf70455.xlsx
new file mode 100644
index ..6c946ef35493
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf70455.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters_test2.cxx
b/sc/qa/unit/subsequent_filters_test2.cxx
index e8164070fd47..df6bb82fa518 100644
--- a/sc/qa/unit/subsequent_filters_test2.cxx
+++ b/sc/qa/unit/subsequent_filters_test2.cxx
@@ -154,6 +154,7 @@ public:
void testColumnWidthRowHeightXLSXML();
void testCharacterSetXLSXML();
void testTdf137091();
+void testTdf70455();
void testTdf62268();
void testTdf137453();
void testTdf112780();
@@ -265,6 +266,7 @@ public:
CPPUNIT_TEST(testCharacterSetXLSXML);
CPPUNIT_TEST(testCondFormatFormulaListenerXLSX);
CPPUNIT_TEST(testTdf137091);
+CPPUNIT_TEST(testTdf70455);
CPPUNIT_TEST(testTdf62268);
CPPUNIT_TEST(testTdf137453);
CPPUNIT_TEST(testTdf112780);
@@ -2322,6 +2324,19 @@ void ScFiltersTest2::testTdf137091()
xDocSh->DoClose();
}
+void ScFiltersTest2::testTdf70455()
+{
+ScDocShellRef xDocSh = loadDoc(u"tdf70455.", FORMAT_XLSX);
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// Without the fix in place, this test would have failed with
+// - Expected: €780.00
+// - Actual : Err:509
+CPPUNIT_ASSERT_EQUAL(OUString(OUStringChar(u'\x20AC') + "780.00"),
+ rDoc.GetString(ScAddress(7, 7, 0)));
+xDocSh->DoClose();
+}
+
void ScFiltersTest2::testTdf62268()
{
ScDocShellRef xDocSh = loadDoc(u"tdf62268.", FORMAT_ODS);
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/IDocumentContentOperations.hxx |7 ---
sw/source/core/doc/DocumentContentOperationsManager.cxx | 37 +---
sw/source/core/inc/DocumentContentOperationsManager.hxx | 11 +---
3 files changed, 18 insertions(+), 37 deletions(-)
New commits:
commit 897c3c8308ccfed1001e0ebc7b3461fbc0811f44
Author: Noel Grandin
AuthorDate: Thu Mar 24 10:59:38 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Mar 24 19:55:25 2022 +0100
loplugin:constantparam
Change-Id: Ic5fe48315ed86d72371191df75866b8a1d72b249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132033
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/IDocumentContentOperations.hxx
b/sw/inc/IDocumentContentOperations.hxx
index 8f082a632d73..c9445ebc9281 100644
--- a/sw/inc/IDocumentContentOperations.hxx
+++ b/sw/inc/IDocumentContentOperations.hxx
@@ -138,13 +138,8 @@ public:
virtual bool DelFullPara(SwPaM&) = 0;
/** complete delete of a given PaM
-
-#i100466#
-Add optional parameter , default value
-Needed for hiding of deletion redlines
*/
-virtual bool DeleteAndJoin( SwPaM&,
-const bool bForceJoinNext = false ) = 0;
+virtual bool DeleteAndJoin( SwPaM& ) = 0;
virtual bool MoveRange(SwPaM&, SwPosition&, SwMoveFlags) = 0;
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index d94632d3b92a..1355c7a488b3 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -639,7 +639,7 @@ namespace
{
bool lcl_DoWithBreaks(::sw::DocumentContentOperationsManager &
rDocumentContentOperations, SwPaM & rPam,
-bool (::sw::DocumentContentOperationsManager::*pFunc)(SwPaM&,
bool), const bool bForceJoinNext = false)
+bool (::sw::DocumentContentOperationsManager::*pFunc)(SwPaM&))
{
std::vector> Breaks;
@@ -647,7 +647,7 @@ namespace
if (Breaks.empty())
{
-return (rDocumentContentOperations.*pFunc)(rPam, bForceJoinNext);
+return (rDocumentContentOperations.*pFunc)(rPam);
}
// Deletion must be split into several parts if the text node
@@ -671,7 +671,7 @@ namespace
rStart = SwPosition(*rNodes[iter->first - nOffset]->GetTextNode(),
iter->second + 1);
if (rStart < rEnd) // check if part is empty
{
-bRet &= (rDocumentContentOperations.*pFunc)(aPam,
bForceJoinNext);
+bRet &= (rDocumentContentOperations.*pFunc)(aPam);
nOffset = iter->first - rStart.nNode.GetIndex(); // deleted
fly nodes...
}
rEnd = SwPosition(*rNodes[iter->first - nOffset]->GetTextNode(),
iter->second);
@@ -681,7 +681,7 @@ namespace
rStart = *rPam.Start(); // set to original start
if (rStart < rEnd) // check if part is empty
{
-bRet &= (rDocumentContentOperations.*pFunc)(aPam, bForceJoinNext);
+bRet &= (rDocumentContentOperations.*pFunc)(aPam);
}
return bRet;
@@ -2292,17 +2292,14 @@ bool DocumentContentOperationsManager::DelFullPara(
SwPaM& rPam )
return true;
}
-// #i100466# Add handling of new optional parameter
-bool DocumentContentOperationsManager::DeleteAndJoin( SwPaM & rPam,
- const bool bForceJoinNext )
+bool DocumentContentOperationsManager::DeleteAndJoin( SwPaM & rPam )
{
if ( lcl_StrLenOverflow( rPam ) )
return false;
bool const ret = lcl_DoWithBreaks( *this, rPam,
(m_rDoc.getIDocumentRedlineAccess().IsRedlineOn())
?
::DeleteAndJoinWithRedlineImpl
-: ::DeleteAndJoinImpl,
-bForceJoinNext );
+: ::DeleteAndJoinImpl );
return ret;
}
@@ -3494,7 +3491,7 @@ bool DocumentContentOperationsManager::ReplaceRange(
SwPaM& rPam, const OUString
{
bRet &= (m_rDoc.getIDocumentRedlineAccess().IsRedlineOn())
? DeleteAndJoinWithRedlineImpl(aPam)
-: DeleteAndJoinImpl(aPam, false);
+: DeleteAndJoinImpl(aPam);
nOffset = iter->first - rStart.nNode.GetIndex(); // deleted fly
nodes...
}
rEnd = SwPosition(*rNodes[iter->first - nOffset]->GetTextNode(),
iter->second);
@@ -4067,7 +4064,7 @@
DocumentContentOperationsManager::~DocumentContentOperationsManager()
}
//Private methods
-bool DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl( SwPaM &
rPam, const bool )
+bool DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl( SwPaM &
rPam )
{
assert(m_rDoc.getIDocumentRedlineAccess().IsRedlineOn());
@@ -4209,22 +4206,14 @@ bool
DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl( SwPaM & rPa
return true;
}
-bool
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/numrule.hxx |1 -
sw/source/core/doc/number.cxx| 19 ---
sw/source/core/txtnode/ndtxt.cxx |1 -
3 files changed, 4 insertions(+), 17 deletions(-)
New commits:
commit 9e12f49c6c1683f9a7545cc0b7f1082110d27df9
Author: Noel Grandin
AuthorDate: Thu Mar 24 10:41:57 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Mar 24 19:55:07 2022 +0100
loplugin:constantparam
Change-Id: I48abe56cc6be52b2a3cd0998e79e6643f65bbbf0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132032
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/numrule.hxx b/sw/inc/numrule.hxx
index e10603a7e3dc..5003ab22e928 100644
--- a/sw/inc/numrule.hxx
+++ b/sw/inc/numrule.hxx
@@ -168,7 +168,6 @@ public:
restrict returned string to this level. */
OUString MakeNumString( const SwNumberTree::tNumberVector & rNumVector,
const bool bInclStrings = true,
- const bool bOnlyArabic = false,
const unsigned int _nRestrictToThisLevel = MAXLEVEL,
Extremities* pExtremities = nullptr,
LanguageType nLang = LANGUAGE_SYSTEM) const;
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index 2589084f807d..0615c9a912d5 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -649,7 +649,6 @@ OUString SwNumRule::MakeNumString( const SwNodeNum& rNum,
bool bInclStrings ) co
OUString SwNumRule::MakeNumString( const SwNumberTree::tNumberVector &
rNumVector,
const bool bInclStrings,
- const bool bOnlyArabic,
const unsigned int _nRestrictToThisLevel,
SwNumRule::Extremities* pExtremities,
LanguageType nLang ) const
@@ -711,12 +710,7 @@ OUString SwNumRule::MakeNumString( const
SwNumberTree::tNumberVector & rNumVecto
}
}
else if (rNumVector[i])
-{
-if (bOnlyArabic)
-sReplacement = OUString::number(rNumVector[i]);
-else
-sReplacement = Get(i).GetNumStr(rNumVector[i], aLocale);
-}
+sReplacement = Get(i).GetNumStr(rNumVector[i], aLocale);
else
sReplacement = "0";// all 0 level are a 0
@@ -761,12 +755,7 @@ OUString SwNumRule::MakeNumString( const
SwNumberTree::tNumberVector & rNumVecto
}
if (rNumVector[i])
-{
-if (bOnlyArabic)
-aStr.append(rNumVector[i]);
-else
-aStr.append(rNFormat.GetNumStr(rNumVector[i], aLocale));
-}
+aStr.append(rNFormat.GetNumStr(rNumVector[i], aLocale));
else
aStr.append("0");// all 0 level are a 0
if (i != nLevel && !aStr.isEmpty())
@@ -775,7 +764,7 @@ OUString SwNumRule::MakeNumString( const
SwNumberTree::tNumberVector & rNumVecto
// The type doesn't have any number, so don't append
// the post-/prefix string
-if (bInclStrings && !bOnlyArabic &&
+if (bInclStrings &&
SVX_NUM_CHAR_SPECIAL != rMyNFormat.GetNumberingType() &&
SVX_NUM_BITMAP != rMyNFormat.GetNumberingType())
{
@@ -831,7 +820,7 @@ OUString SwNumRule::MakeRefNumString( const SwNodeNum&
rNodeNum,
{
Extremities aExtremities;
OUString aPrevStr = MakeNumString(
pWorkingNodeNum->GetNumberVector(),
- true, false, MAXLEVEL,
+ true, MAXLEVEL,
);
sal_Int32 nStrip = 0;
while ( nStrip < aExtremities.nPrefixChars )
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 6b314cf49653..9b575ad4b821 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -3121,7 +3121,6 @@ OUString SwTextNode::GetNumString( const bool
_bInclPrefixAndSuffixStrings,
{
return pRule->MakeNumString( GetNum(pLayout)->GetNumberVector(),
_bInclPrefixAndSuffixStrings,
- false,
_nRestrictToThisLevel,
nullptr,
GetLang(0));
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/textboxhelper.hxx |4 ++--
sw/source/core/doc/textboxhelper.cxx | 28 ++--
sw/source/core/layout/flycnt.cxx |2 +-
3 files changed, 17 insertions(+), 17 deletions(-)
New commits:
commit 2488029673365f03b14ddd1e4ccb0993dc1be7b7
Author: Noel Grandin
AuthorDate: Thu Mar 24 10:18:14 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Mar 24 19:54:48 2022 +0100
loplugin:constantparam
Change-Id: Ib863ea852792635e521050019a3a190b3eeb681e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132031
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/textboxhelper.hxx b/sw/inc/textboxhelper.hxx
index b700ef596603..3881d897c629 100644
--- a/sw/inc/textboxhelper.hxx
+++ b/sw/inc/textboxhelper.hxx
@@ -125,8 +125,8 @@ public:
/// If we have an associated TextFrame, then return its XTextFrame.
static css::uno::Reference
getUnoTextFrame(css::uno::Reference const& xShape);
-/// Return the textbox rectangle of a draw shape (in twips).
-static tools::Rectangle getTextRectangle(SdrObject* pShape, bool bAbsolute
= true);
+/// Return the textbox rectangle of a draw shape (in relative twips).
+static tools::Rectangle getRelativeTextRectangle(SdrObject* pShape);
/**
* Is the frame format a text box?
diff --git a/sw/source/core/doc/textboxhelper.cxx
b/sw/source/core/doc/textboxhelper.cxx
index f1613a8052b3..50af58ae4786 100644
--- a/sw/source/core/doc/textboxhelper.cxx
+++ b/sw/source/core/doc/textboxhelper.cxx
@@ -548,7 +548,7 @@ uno::Any SwTextBoxHelper::queryInterface(const
SwFrameFormat* pShape, const uno:
return aRet;
}
-tools::Rectangle SwTextBoxHelper::getTextRectangle(SdrObject* pShape, bool
bAbsolute)
+tools::Rectangle SwTextBoxHelper::getRelativeTextRectangle(SdrObject* pShape)
{
tools::Rectangle aRet;
aRet.SetEmpty();
@@ -576,7 +576,7 @@ tools::Rectangle
SwTextBoxHelper::getTextRectangle(SdrObject* pShape, bool bAbso
aRet = pShape->GetCurrentBoundRect();
}
-if (!bAbsolute && pShape)
+if (pShape)
{
// Relative, so count the logic (reference) rectangle, see the
EnhancedCustomShape2d ctor.
Point aPoint(pShape->GetSnapRect().Center());
@@ -978,7 +978,7 @@ void SwTextBoxHelper::syncProperty(SwFrameFormat* pShape,
sal_uInt16 nWID, sal_u
{
changeAnchor(pShape, pObj);
tools::Rectangle aRect
-= getTextRectangle(pObj ? pObj : pShape->FindRealSdrObject(),
/*bAbsolute=*/false);
+= getRelativeTextRectangle(pObj ? pObj :
pShape->FindRealSdrObject());
if (!aRect.IsEmpty())
{
if (bAdjustX || bAdjustY)
@@ -1094,8 +1094,8 @@ void SwTextBoxHelper::syncFlyFrameAttr(SwFrameFormat&
rShape, SfxItemSet const&
return;
SwFormatVertOrient
aOrient(pItem->StaticWhichCast(RES_VERT_ORIENT));
-tools::Rectangle aRect = getTextRectangle(pObj ? pObj :
rShape.FindRealSdrObject(),
- /*bAbsolute=*/false);
+tools::Rectangle aRect
+= getRelativeTextRectangle(pObj ? pObj :
rShape.FindRealSdrObject());
if (!aRect.IsEmpty())
aOrient.SetPos(aOrient.GetPos() + aRect.Top());
@@ -1124,8 +1124,8 @@ void SwTextBoxHelper::syncFlyFrameAttr(SwFrameFormat&
rShape, SfxItemSet const&
return;
SwFormatHoriOrient
aOrient(pItem->StaticWhichCast(RES_HORI_ORIENT));
-tools::Rectangle aRect = getTextRectangle(pObj ? pObj :
rShape.FindRealSdrObject(),
- /*bAbsolute=*/false);
+tools::Rectangle aRect
+= getRelativeTextRectangle(pObj ? pObj :
rShape.FindRealSdrObject());
if (!aRect.IsEmpty())
aOrient.SetPos(aOrient.GetPos() + aRect.Left());
@@ -1145,8 +1145,8 @@ void SwTextBoxHelper::syncFlyFrameAttr(SwFrameFormat&
rShape, SfxItemSet const&
SwFormatHoriOrient aHoriOrient(rShape.GetHoriOrient());
SwFormatFrameSize aSize(pFormat->GetFrameSize());
-tools::Rectangle aRect = getTextRectangle(pObj ? pObj :
rShape.FindRealSdrObject(),
- /*bAbsolute=*/false);
+tools::Rectangle aRect
+= getRelativeTextRectangle(pObj ? pObj :
rShape.FindRealSdrObject());
if (!aRect.IsEmpty())
{
if (!bInlineAnchored)
@@ -1341,8 +1341,8 @@ bool SwTextBoxHelper::doTextBoxPositioning(SwFrameFormat*
pShape, SdrObject* pOb
if (pShape->GetAnchor().GetAnchorId() == RndStdIds::FLY_AS_CHAR)
{
// Get the text area of the shape
-tools::Rectangle aRect(
-getTextRectangle(pObj ? pObj :
[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/qt5 vcl/unx
vcl/headless/svpcairotextrender.cxx |4 ++--
vcl/inc/headless/svpgdi.hxx |8
vcl/qt5/QtSvpSurface.cxx |2 +-
vcl/unx/gtk3/gtkcairo.cxx |2 +-
vcl/unx/gtk3/salnativewidgets-gtk.cxx |2 +-
5 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit 463c851ac898a81465632d090a1d2c8fcc3ca297
Author: Noel Grandin
AuthorDate: Thu Mar 24 09:05:07 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Mar 24 19:54:04 2022 +0100
loplugin:constantparam
Change-Id: I6bfbd0cb5c2eac60bdac69fd862154fb2f537a89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132030
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/headless/svpcairotextrender.cxx
b/vcl/headless/svpcairotextrender.cxx
index 9abd5902864d..c64bafae0969 100644
--- a/vcl/headless/svpcairotextrender.cxx
+++ b/vcl/headless/svpcairotextrender.cxx
@@ -16,7 +16,7 @@ SvpCairoTextRender::SvpCairoTextRender(SvpSalGraphics&
rParent)
{
}
-cairo_t* SvpCairoTextRender::getCairoContext() { return
mrParent.getCairoContext(false); }
+cairo_t* SvpCairoTextRender::getCairoContext() { return
mrParent.getCairoContext(); }
void SvpCairoTextRender::getSurfaceOffset(double& nDX, double& nDY)
{
@@ -28,7 +28,7 @@ void SvpCairoTextRender::clipRegion(cairo_t* cr) {
mrParent.clipRegion(cr); }
void SvpCairoTextRender::releaseCairoContext(cairo_t* cr)
{
-mrParent.releaseCairoContext(cr, false, basegfx::B2DRange());
+mrParent.releaseCairoContext(cr, basegfx::B2DRange());
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index b3b932cc3d73..a63e7f289abf 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -105,14 +105,14 @@ public:
virtual css::uno::Any GetNativeSurfaceHandle(cairo::SurfaceSharedPtr&
rSurface, const basegfx::B2ISize& rSize) const override;
#endif // ENABLE_CAIRO_CANVAS
-cairo_t* getCairoContext(bool bXorModeAllowed) const
+cairo_t* getCairoContext() const
{
-return m_aCairoCommon.getCairoContext(bXorModeAllowed, getAntiAlias());
+return m_aCairoCommon.getCairoContext(/*bXorModeAllowed*/false,
getAntiAlias());
}
-void releaseCairoContext(cairo_t* cr, bool bXorModeAllowed, const
basegfx::B2DRange& rExtents) const
+void releaseCairoContext(cairo_t* cr, const basegfx::B2DRange& rExtents)
const
{
-return m_aCairoCommon.releaseCairoContext(cr, bXorModeAllowed,
rExtents);
+return m_aCairoCommon.releaseCairoContext(cr,
/*bXorModeAllowed*/false, rExtents);
}
void clipRegion(cairo_t* cr)
diff --git a/vcl/qt5/QtSvpSurface.cxx b/vcl/qt5/QtSvpSurface.cxx
index 456de177ce2c..a2a39c12b387 100644
--- a/vcl/qt5/QtSvpSurface.cxx
+++ b/vcl/qt5/QtSvpSurface.cxx
@@ -42,7 +42,7 @@ QtSvpSurface::QtSvpSurface(const CairoSurfaceSharedPtr&
pSurface)
QtSvpSurface::QtSvpSurface(const QtSvpGraphics* pGraphics, int x, int y, int
width, int height)
: m_pGraphics(pGraphics)
-, m_pCairoContext(pGraphics->getCairoContext(false))
+, m_pCairoContext(pGraphics->getCairoContext())
{
cairo_surface_t* surface = cairo_get_target(m_pCairoContext);
m_pSurface.reset(cairo_surface_create_for_rectangle(surface, x, y, width,
height),
diff --git a/vcl/unx/gtk3/gtkcairo.cxx b/vcl/unx/gtk3/gtkcairo.cxx
index 8c684295f046..202e3244d617 100644
--- a/vcl/unx/gtk3/gtkcairo.cxx
+++ b/vcl/unx/gtk3/gtkcairo.cxx
@@ -55,7 +55,7 @@ namespace cairo
**/
Gtk3Surface::Gtk3Surface(const GtkSalGraphics* pGraphics, int x, int y,
int width, int height)
: mpGraphics(pGraphics)
-, cr(pGraphics->getCairoContext(false))
+, cr(pGraphics->getCairoContext())
{
cairo_surface_t* surface = cairo_get_target(cr);
mpSurface.reset(
diff --git a/vcl/unx/gtk3/salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
index 0505010bea81..e2cef41100ec 100644
--- a/vcl/unx/gtk3/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
@@ -1802,7 +1802,7 @@ bool GtkSalGraphics::drawNativeControl( ControlType
nType, ControlPart nPart, co
return false;
}
-cairo_t *cr = getCairoContext(false);
+cairo_t *cr = getCairoContext();
clipRegion(cr);
cairo_translate(cr, rControlRegion.Left(), rControlRegion.Top());
[Libreoffice-bugs] [Bug 148164] Calc - Not so obvious to apply multiple borderstyles to a group of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=148164 --- Comment #3 from Arnold Huzen --- Created attachment 179086 --> https://bugs.documentfoundation.org/attachment.cgi?id=179086=edit Situation after clicking the horizontal border for the second time -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148164] Calc - Not so obvious to apply multiple borderstyles to a group of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=148164 --- Comment #2 from Arnold Huzen --- Created attachment 179085 --> https://bugs.documentfoundation.org/attachment.cgi?id=179085=edit Situation after setting the horizontal border and selecting the vertical -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148149] Impossibilité d'encoder correctement exposant 6
https://bugs.documentfoundation.org/show_bug.cgi?id=148149 Julien Nabet changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #9 from Julien Nabet --- Great! Let's rather put this one to WFM since there's no specific fix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148164] Calc - Not so obvious to apply multiple borderstyles to a group of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=148164 --- Comment #1 from Arnold Huzen --- Created attachment 179084 --> https://bugs.documentfoundation.org/attachment.cgi?id=179084=edit Situation after setting the outer border style and selecting the horizontal inner -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148164] New: Calc - Not so obvious to apply multiple borderstyles to a group of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=148164 Bug ID: 148164 Summary: Calc - Not so obvious to apply multiple borderstyles to a group of cells Product: LibreOffice Version: 7.3.1.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: arnold.hu...@tutanota.com Description: If a user wants to set different borderstyles to a group of cells it is not obvious how to do so. Steps to Reproduce: 1. Select a group of cells (at least 2x2). 2. Open the cell formatting dialog (Ctrl+1). 3. Select the double-line border and set as the outer border using the button at the top of the screen. 4. Select the horizontal inner line of the group and select the single-line border. 5. Select the vertical inner line of the group. 6. Click OK and see the result. Only the vertical inner line has a single-line border. 7. Repeat steps 1 to 5. 8. Click on the horizontal inner line again. 9. Click OK and see the result. Now both horizontal and vertical inner lines have a single-line border. Actual Results: The result at step 6 is what I would logically do, but it results in a horizontal inner border with a double-line. Expected Results: The result at step 9 is what I would expect to be the state at step 6. Reproducible: Always User Profile Reset: No Additional Info: I discovered this behaviour after reading a question on the LibreOffice User Group on Facebook. -- You are receiving this mail because: You are the assignee for the bug.
Mapping OOXML camera to our camera model
Hi all, I have asked Microsoft about details about their camera. Find the answer in https://docs.microsoft.com/en-us/answers/questions/769795/how-to-get-distance-of-view-point-to-xy-plane-for.html Kind regards, Regina
Improve WriteCustomGeometry in oox export; review of patch
Hi Miklos, hi all, the patch in https://gerrit.libreoffice.org/c/core/+/131837 is now ready for review. It is a change in the way a custGeom element is generated. I have dropped the export via PolyPolygon. Instead our path commands are directly mapped to oox path commands. That is a larger change, so it would be good, if you find time to review it. The commit message is quite detailed. If something is still unclear, please send me a mail. BTW, Jenkins fails for a reason I don't know. But I want to first incorporate your suggestions before I start a next try with Jenkins. Kind regards, Regina
[Libreoffice-bugs] [Bug 148149] Impossibilité d'encoder correctement exposant 6
https://bugs.documentfoundation.org/show_bug.cgi?id=148149 Yannick DUPAGNE changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #8 from Yannick DUPAGNE --- Thank you. I found the problem. My PC has 2 different fonts named Liberation : the first one in 'Liberation' directory (version 1.07.4) and the second one in 'Liberation2' directory (version 2.1.0). I don't know why. The character exponent 6 (hexadecimal U+2076) is not part of the Liberation Regular set in 'Liberation2' directory. So I've deleted this directory and now the problem is resolved. LibreOffice now takes Liberation font only in the first directory. Many thanks for your help. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89387] improve performance for some matrix operations
https://bugs.documentfoundation.org/show_bug.cgi?id=89387 --- Comment #50 from Sarrah --- (In reply to Łukasz Hryniuk from comment #30) > (In reply to jan iversen from comment #29) > > A polite ping, are you still working on this ? > > Yes. For now more than half of functions listed at the beginning are > improved and I've written unit and performance tests for few of the rest. I > have to implement one thing in mdds - way to work on two matrices at once - > and use it in remaining functions. I'll try to do it as soon as possible. Hey, just wondering if you were able to implement the way to work on two matrices at once using walk() method or iterator, as most of the functions reliant on that still use loops on rely on loops or use lcl_MatrixCalculation, which in turn also uses nested loops. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oox/source wizards/source
oox/source/drawingml/diagram/datamodel.hxx |2 +- wizards/source/scriptforge/SF_Region.xba | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit c8e5c2e65aec50ff338ec1967e3865438093fbc8 Author: Andrea Gelmini AuthorDate: Thu Mar 24 18:14:16 2022 +0100 Commit: Julien Nabet CommitDate: Thu Mar 24 19:18:50 2022 +0100 Fix typos Change-Id: Iccb89d32b83b7f7035557ad7c0634f66f4c947d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132082 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/oox/source/drawingml/diagram/datamodel.hxx b/oox/source/drawingml/diagram/datamodel.hxx index 8da6ee9998e8..8e4417652a57 100644 --- a/oox/source/drawingml/diagram/datamodel.hxx +++ b/oox/source/drawingml/diagram/datamodel.hxx @@ -198,7 +198,7 @@ private: // the model definition, // - FillStyle -// - logic connections/assoziations +// - logic connections/associations // - data point entries FillPropertiesPtr mpFillProperties; dgm::Connections maConnections; diff --git a/wizards/source/scriptforge/SF_Region.xba b/wizards/source/scriptforge/SF_Region.xba index 52b913dd90f3..33a564b52a20 100644 --- a/wizards/source/scriptforge/SF_Region.xba +++ b/wizards/source/scriptforge/SF_Region.xba @@ -169,7 +169,7 @@ End Property ScriptForge.SF_Region.Language (get) REM - Property Get ListSeparator(Optional ByVal Region As Variant) As String - Returns the separator used in lits applicable in the given region. + Returns the separator used in list applicable in the given region. The region is expressed as a locale combining language-COUNTRY (la-CO) Example: MsgBox Regio.ListSeparator(it-IT) ; @@ -249,7 +249,7 @@ Public Function DSTOffset(Optional ByVal LocalDateTime As Variant _ , Optional ByVal TimeZone As Variant _ , Optional ByVal Locale As Variant _ ) As Integer - Computes the additional offset due to day light saving (summer time) + Computes the additional offset due to daylight saving (summer time) Args LocalDateTime: local date and time as a Date. DST offset varies during the year. TimeZone: specified as Region/City name like Europe/Berlin, or a custom time zone ID such as UTC or GMT-8:00 @@ -348,7 +348,7 @@ Public Function LocalDateTime(Optional ByVal UTCDateTime As Variant _ Return: The local time converted from the corresponding UTC date and time as a Date If the returned value is before 1900, it is likely that the Locale is not recognized - If the returned value matches the local time, it is likely that the the timezone is not recognized + If the returned value matches the local time, it is likely that the timezone is not recognized Examples: regio.LocalDateTime(DateSerial(2022, 3, 20) + TimeSerial(16, 58, 17), Europe/Brussels, fr-BE) 2022-03-20 17:58:17 @@ -411,7 +411,7 @@ Public Function Number2Text(Optional ByVal Number As Variant _ Convert numbers and money amounts in many languages into words Args Number: the number to spell out - Accepted types: strings or numeric values (integeror real numbers) + Accepted types: strings or numeric values (integer or real numbers) When a string, a variety of prefixes is supported The string help provides helpful tips about allowed prefixes by language Example for french @@ -858,4 +858,4 @@ Finally: End Function ScriptForge.SF_Region._PropertyGet REM END OF SCRIPTFORGE.SF_REGION - \ No newline at end of file +
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/qa sc/source
sc/qa/unit/data/ods/too-many-cols-rows.ods |binary
sc/qa/unit/subsequent_filters_test2.cxx| 17 ++---
sc/source/filter/xml/xmlcelli.cxx |6 ++
3 files changed, 20 insertions(+), 3 deletions(-)
New commits:
commit ccad7357b983294ba2f0d8e18f3c2955d7a6d41d
Author: Luboš Luňák
AuthorDate: Tue Mar 22 16:46:55 2022 +0100
Commit: Eike Rathke
CommitDate: Thu Mar 24 19:11:11 2022 +0100
warn on too many rows/column when loading ODS
There's a warning when loading XLSX, but not when loading ODS.
Now that 7.4 is going to support 16k columns, that would be a useful
warning, either if we raise the limits again, or backported to
7.2/7.3 .
Change-Id: I204bca32e1ff37332b86361d3d81d3fee29c15ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131944
Tested-by: Jenkins
Reviewed-by: Eike Rathke
diff --git a/sc/qa/unit/data/ods/too-many-cols-rows.ods
b/sc/qa/unit/data/ods/too-many-cols-rows.ods
new file mode 100644
index ..fcf1a0bc9ea8
Binary files /dev/null and b/sc/qa/unit/data/ods/too-many-cols-rows.ods differ
diff --git a/sc/qa/unit/subsequent_filters_test2.cxx
b/sc/qa/unit/subsequent_filters_test2.cxx
index 75db57388f41..c40f26dfc78d 100644
--- a/sc/qa/unit/subsequent_filters_test2.cxx
+++ b/sc/qa/unit/subsequent_filters_test2.cxx
@@ -71,9 +71,7 @@
#include
#include
#include
-
-#include
-#include
+#include
#include
#include
@@ -209,6 +207,7 @@ public:
void testTdf139763ShapeAnchor();
void testAutofilterNamedRangesXLSX();
void testInvalidBareBiff5();
+void testTooManyColsRows();
CPPUNIT_TEST_SUITE(ScFiltersTest2);
@@ -316,6 +315,7 @@ public:
CPPUNIT_TEST(testTdf139763ShapeAnchor);
CPPUNIT_TEST(testAutofilterNamedRangesXLSX);
CPPUNIT_TEST(testInvalidBareBiff5);
+CPPUNIT_TEST(testTooManyColsRows);
CPPUNIT_TEST_SUITE_END();
@@ -3025,6 +3025,17 @@ void ScFiltersTest2::testInvalidBareBiff5()
xDocSh->DoClose();
}
+void ScFiltersTest2::testTooManyColsRows()
+{
+// The intentionally doc has cells beyond our MAXROW/MAXCOL, so there
+// should be a warning on load.
+ScDocShellRef xDocSh = loadDoc(u"too-many-cols-rows.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.is());
+CPPUNIT_ASSERT(xDocSh->GetErrorCode() == SCWARN_IMPORT_ROW_OVERFLOW
+ || xDocSh->GetErrorCode() == SCWARN_IMPORT_COLUMN_OVERFLOW);
+xDocSh->DoClose();
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScFiltersTest2);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b/sc/source/filter/xml/xmlcelli.cxx
index a31a7659cc76..d27b076e1ad6 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -1170,7 +1170,10 @@ void ScXMLTableRowCellContext::AddTextAndValueCell(
const ScAddress& rCellPos,
// it makes no sense to import data after the last supported column
// fdo#58539 & gnome#627150
if(rCurrentPos.Col() > pDoc->MaxCol())
+{
+rXMLImport.SetRangeOverflowType(SCWARN_IMPORT_COLUMN_OVERFLOW);
break;
+}
if (i > 0)
rTables.AddColumn(false);
@@ -1183,7 +1186,10 @@ void ScXMLTableRowCellContext::AddTextAndValueCell(
const ScAddress& rCellPos,
// it makes no sense to import data after last supported row
// fdo#58539 & gnome#627150
if(rCurrentPos.Row() > pDoc->MaxRow())
+{
+
rXMLImport.SetRangeOverflowType(SCWARN_IMPORT_ROW_OVERFLOW);
break;
+}
if( (rCurrentPos.Col() == 0) && (j > 0) )
{
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sc/qa sc/source
sc/qa/unit/data/ods/too-many-cols-rows.ods |binary
sc/qa/unit/subsequent_filters-test2.cxx| 17 ++---
sc/source/filter/xml/xmlcelli.cxx |6 ++
3 files changed, 20 insertions(+), 3 deletions(-)
New commits:
commit cb9a166f4d3fff1ff364aade5d40ef9a6d4da24b
Author: Luboš Luňák
AuthorDate: Tue Mar 22 16:46:55 2022 +0100
Commit: Eike Rathke
CommitDate: Thu Mar 24 19:10:54 2022 +0100
warn on too many rows/column when loading ODS
There's a warning when loading XLSX, but not when loading ODS.
Now that 7.4 is going to support 16k columns, that would be a useful
warning, either if we raise the limits again, or backported to
7.2/7.3 .
Change-Id: I204bca32e1ff37332b86361d3d81d3fee29c15ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131945
Tested-by: Jenkins
Reviewed-by: Eike Rathke
diff --git a/sc/qa/unit/data/ods/too-many-cols-rows.ods
b/sc/qa/unit/data/ods/too-many-cols-rows.ods
new file mode 100644
index ..fcf1a0bc9ea8
Binary files /dev/null and b/sc/qa/unit/data/ods/too-many-cols-rows.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test2.cxx
b/sc/qa/unit/subsequent_filters-test2.cxx
index 35ad23deba54..d6b738d43c33 100644
--- a/sc/qa/unit/subsequent_filters-test2.cxx
+++ b/sc/qa/unit/subsequent_filters-test2.cxx
@@ -70,9 +70,7 @@
#include
#include
#include
-
-#include
-#include
+#include
#include
#include
@@ -207,6 +205,7 @@ public:
void testTdf139763ShapeAnchor();
void testAutofilterNamedRangesXLSX();
void testInvalidBareBiff5();
+void testTooManyColsRows();
CPPUNIT_TEST_SUITE(ScFiltersTest2);
@@ -313,6 +312,7 @@ public:
CPPUNIT_TEST(testTdf139763ShapeAnchor);
CPPUNIT_TEST(testAutofilterNamedRangesXLSX);
CPPUNIT_TEST(testInvalidBareBiff5);
+CPPUNIT_TEST(testTooManyColsRows);
CPPUNIT_TEST_SUITE_END();
@@ -2983,6 +2983,17 @@ void ScFiltersTest2::testInvalidBareBiff5()
xDocSh->DoClose();
}
+void ScFiltersTest2::testTooManyColsRows()
+{
+// The intentionally doc has cells beyond our MAXROW/MAXCOL, so there
+// should be a warning on load.
+ScDocShellRef xDocSh = loadDoc(u"too-many-cols-rows.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.is());
+CPPUNIT_ASSERT(xDocSh->GetErrorCode() == SCWARN_IMPORT_ROW_OVERFLOW
+ || xDocSh->GetErrorCode() == SCWARN_IMPORT_COLUMN_OVERFLOW);
+xDocSh->DoClose();
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScFiltersTest2);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b/sc/source/filter/xml/xmlcelli.cxx
index 638c2c5cba67..04bf96b98860 100644
--- a/sc/source/filter/xml/xmlcelli.cxx
+++ b/sc/source/filter/xml/xmlcelli.cxx
@@ -1170,7 +1170,10 @@ void ScXMLTableRowCellContext::AddTextAndValueCell(
const ScAddress& rCellPos,
// it makes no sense to import data after the last supported column
// fdo#58539 & gnome#627150
if(rCurrentPos.Col() > pDoc->MaxCol())
+{
+rXMLImport.SetRangeOverflowType(SCWARN_IMPORT_COLUMN_OVERFLOW);
break;
+}
if (i > 0)
rTables.AddColumn(false);
@@ -1183,7 +1186,10 @@ void ScXMLTableRowCellContext::AddTextAndValueCell(
const ScAddress& rCellPos,
// it makes no sense to import data after last supported row
// fdo#58539 & gnome#627150
if(rCurrentPos.Row() > pDoc->MaxRow())
+{
+
rXMLImport.SetRangeOverflowType(SCWARN_IMPORT_ROW_OVERFLOW);
break;
+}
if( (rCurrentPos.Col() == 0) && (j > 0) )
{
[Libreoffice-bugs] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 --- Comment #7 from Dave Barton --- Obvious typo: 7.3.13 should read 7.3.1.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 --- Comment #7 from Dave Barton --- Obvious typo: 7.3.13 should read 7.3.1.3 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 --- Comment #6 from Dave Barton --- Have now tested on deb & rpm installs of TDF provided editions of 7.3.13 and can definitely confirm this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 --- Comment #6 from Dave Barton --- Have now tested on deb & rpm installs of TDF provided editions of 7.3.13 and can definitely confirm this bug. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148163] #REF! in incorrect references
https://bugs.documentfoundation.org/show_bug.cgi?id=148163 Xisco Faulí changed: What|Removed |Added Keywords||bibisectRequest, regression CC||er...@redhat.com --- Comment #1 from Xisco Faulí --- @Eike, since you fixed bug 46338, I thought you might be interested in this issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148163] #REF! in incorrect references
https://bugs.documentfoundation.org/show_bug.cgi?id=148163 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=46 ||338 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148163] New: #REF! in incorrect references
https://bugs.documentfoundation.org/show_bug.cgi?id=148163 Bug ID: 148163 Summary: #REF! in incorrect references Product: LibreOffice Version: 6.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org I found this issue when I tried to create a unittest for tdf#46338. In https://cgit.freedesktop.org/libreoffice/core/commit/?id=1135bfd78802e5c40ca09bcbc75d0908a423872a The behaviour was changed to show #NAME for invalid references ( e.g =SheetX.A1 ) However, in master Calc shows #REF! ( the old behaviour ) Reproduced in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 4a46a74a3de0ac7df5d3ce949dda5e809c1729ab CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded and Version: 6.3.0.0.alpha1+ Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: es-ES (es_ES.UTF-8); UI-Language: en-US Calc: threaded but not in Version: 6.1.7.0.0+ Build ID: 5b3765f4d881e7ddefd0c4aad6886a46f000b4fc CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: es-ES (es_ES.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147226] FORMATTING: Cell Style completely lost from imported xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=147226 Buovjaga changed: What|Removed |Added Version|7.3.0.3 release |7.2.4.1 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130383] Filesave ODS: Row height after Optimal Height still opens as 1 line instead of 2 in cell F5 (not with XLS/X)
https://bugs.documentfoundation.org/show_bug.cgi?id=130383 --- Comment #12 from he...@ungoverned.org --- I'm not exactly sure what you are seeing, but I didn't have the "Enable very large spreadsheets" selected. For that matter, it didn't even appear in my options unless I first enabled "Experimental Features" under the "Advanced" settings. So, it does not seem to be exactly the same issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148160] Return carriage in a cell in Calc breaks french autocorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=148160 Aron Budea changed: What|Removed |Added Whiteboard|target:7.3.3|target:7.4.0 target:7.3.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/metaact.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 59352ff39dc5fa0af9cebe3f717cc45a4b321f5d
Author: Caolán McNamara
AuthorDate: Thu Mar 24 12:39:45 2022 +
Commit: Caolán McNamara
CommitDate: Thu Mar 24 18:10:28 2022 +0100
ofz#45991 Timeout, reduce allowed scaling
Change-Id: I559df8ecc2778f6de9406da871941555a81d21eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132074
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index cc724b7fb2fa..9a85d805b41a 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -841,7 +841,7 @@ static bool AllowScale(const Size& rSource, const Size&
rDest)
{
if (utl::ConfigManager::IsFuzzing())
{
-constexpr int nMaxScaleWhenFuzzing = 1024;
+constexpr int nMaxScaleWhenFuzzing = 512;
auto nSourceHeight = rSource.Height();
auto nDestHeight = rDest.Height();
[Libreoffice-bugs] [Bug 147359] Show placeholder or preview when dragging to copy a shape
https://bugs.documentfoundation.org/show_bug.cgi?id=147359 Buovjaga changed: What|Removed |Added Severity|minor |enhancement Keywords||needsUXEval CC||ilmari.lauhakangas@libreoff ||ice.org, ||libreoffice-ux-advise@lists ||.freedesktop.org Status|RESOLVED|UNCONFIRMED Summary|Copied dragged form is not |Show placeholder or preview |displayed |when dragging to copy a ||shape Resolution|WORKSFORME |--- --- Comment #8 from Buovjaga --- Resetting status, tweaking summary and adding UX team. I remember something similar for simply moving stuff, but could not find an existing report. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147359] Show placeholder or preview when dragging to copy a shape
https://bugs.documentfoundation.org/show_bug.cgi?id=147359 Buovjaga changed: What|Removed |Added Severity|minor |enhancement Keywords||needsUXEval CC||ilmari.lauhakangas@libreoff ||ice.org, ||libreoffice-ux-advise@lists ||.freedesktop.org Status|RESOLVED|UNCONFIRMED Summary|Copied dragged form is not |Show placeholder or preview |displayed |when dragging to copy a ||shape Resolution|WORKSFORME |--- --- Comment #8 from Buovjaga --- Resetting status, tweaking summary and adding UX team. I remember something similar for simply moving stuff, but could not find an existing report. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147888] Only one option to choose when slide elements should appear
https://bugs.documentfoundation.org/show_bug.cgi?id=147888 --- Comment #8 from pieter kristensen --- A few moments ago I got on the same machine (comment 5) an update to the version below out of the libreoffice-ppa Version: 7.2.6.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+wayland) Locale: nl-NL (nl_NL.UTF-8); UI: nl-NL Ubuntu package version: 1:7.2.6-0ubuntu0.20.04.1~lo2 Calc: threaded You won't believe this: this bug is gone! Before I press "save changes" I will do some more testing... No, I really believe it's gone... Just to let you know. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148160] Return carriage in a cell in Calc breaks french autocorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=148160 --- Comment #4 from Commit Notification --- Szymon Kłos committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/98fdfd74c8a9f8c6ee95e21751e41fa8cce656c7 tdf#148160 Use correct language for spellchecking in calc It will be available in 7.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148160] Return carriage in a cell in Calc breaks french autocorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=148160 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source
sc/source/ui/view/spellcheckcontext.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 98fdfd74c8a9f8c6ee95e21751e41fa8cce656c7 Author: Szymon Kłos AuthorDate: Wed Mar 23 13:02:29 2022 +0100 Commit: Michael Meeks CommitDate: Thu Mar 24 18:01:08 2022 +0100 tdf#148160 Use correct language for spellchecking in calc Fixes the problem of not applied spellchecking language change in calc. 1. Open spreadsheet with German text but with English UI language 2. Change spellchecking language to German result: no difference expected: spellchecking should be performed and mark words correctly Visible in both LOK and desktop. Regression introduced in: commit bdd149b1ff3d43b94cadc0d43365100c287c7639 Author: Dennis Francis Date: Sun Oct 4 12:47:46 2020 +0530 Improve spell checking performance and impl. in several ways: Change-Id: I679b1181af118e9894a3f5240523d4945af8ccf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131965 Reviewed-by: Michael Meeks Tested-by: Jenkins CollaboraOffice (cherry picked from commit 32a99d53ef6c9f2406351e85d3acfbe2bf8c06b7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132034 Tested-by: Michael Meeks diff --git a/sc/source/ui/view/spellcheckcontext.cxx b/sc/source/ui/view/spellcheckcontext.cxx index 224af6859f59..a1358dcd647a 100644 --- a/sc/source/ui/view/spellcheckcontext.cxx +++ b/sc/source/ui/view/spellcheckcontext.cxx @@ -327,12 +327,14 @@ void SpellCheckContext::ensureResults(SCCOL nCol, SCROW nRow) } // Cache miss, the cell needs spell-check.. -mpEngine->SetDefaultItem(SvxLanguageItem(eCellLang, EE_CHAR_LANGUAGE)); if (eType == CELLTYPE_STRING) mpEngine->SetText(aCell.mpString->getString()); else mpEngine->SetText(*aCell.mpEditText); +// it has to happen after we set text +mpEngine->SetDefaultItem(SvxLanguageItem(eCellLang, EE_CHAR_LANGUAGE)); + mpStatus->mbModified = false; mpEngine->CompleteOnlineSpelling(); std::unique_ptr pRanges;
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit d9f3a656c40e47d23a1c6de427bcdc7511d5249a
Author: Jim Raykowski
AuthorDate: Sun Mar 20 19:25:12 2022 -0800
Commit: Jim Raykowski
CommitDate: Thu Mar 24 17:54:10 2022 +0100
fix gtk3 combobox up arrow and page up does not select first entry
when popup is not active
Change-Id: I0c4c0841bf0b24cc528d428829ec628e47032fb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131882
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Reviewed-by: Jim Raykowski
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 117c5c88a788..b738160118f2 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -20363,7 +20363,7 @@ private:
sal_uInt16 nKeyMod = aKeyCode.GetModifier();
if (!nKeyMod)
{
-int nStartBound = m_bPopupActive ? 0 : (m_nMRUCount + 1);
+int nStartBound = m_bPopupActive || !m_nMRUCount ? 0 :
(m_nMRUCount + 1);
int nActive = get_active_including_mru() - 1;
while (nActive >= nStartBound &&
separator_function(nActive))
--nActive;
@@ -20379,7 +20379,7 @@ private:
if (!nKeyMod)
{
int nCount = get_count_including_mru();
-int nStartBound = m_bPopupActive ? 0 : (m_nMRUCount + 1);
+int nStartBound = m_bPopupActive || !m_nMaxMRUCount ? 0 :
(m_nMRUCount + 1);
int nActive = nStartBound;
while (nActive < nCount && separator_function(nActive))
++nActive;
[Libreoffice-ux-advise] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 Dave Barton changed: What|Removed |Added CC||da...@libreoffice.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Dave Barton --- (In reply to lol from comment #4) > Did you do exactly the steps in comment 1? Yes it appears to be an error in the procedure/function called from the main menu "Page -> Rename Page" option. Confirmed as a bug in 7.3.1.3, 7.2.6.2 and: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6adabd915d931b845fcf2fef15fbf3fca14ec9b3 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-IE (en_IE); UI: en-GB Calc: CL This seems to be a definite bug, but I will test for both rpm & deb installations. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 Dave Barton changed: What|Removed |Added CC||da...@libreoffice.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Dave Barton --- (In reply to lol from comment #4) > Did you do exactly the steps in comment 1? Yes it appears to be an error in the procedure/function called from the main menu "Page -> Rename Page" option. Confirmed as a bug in 7.3.1.3, 7.2.6.2 and: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6adabd915d931b845fcf2fef15fbf3fca14ec9b3 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-IE (en_IE); UI: en-GB Calc: CL This seems to be a definite bug, but I will test for both rpm & deb installations. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148051] Crashings for unkown reasons, despite reset user profile etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=148051 --- Comment #10 from MarcS --- (In reply to Xisco Faulí from comment #9) > Anyone can confirm this issue ? Yes, me, author of "duplicate" Bug 148145. Will try completely removing 7.2.5.2, and installing 7.2.6. Only thing I did not do up until now was to restart the computer after uninstall and after new install. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147553] Saving basic macro results in excessive cpu usage; freezes Calc for 20+ seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=147553 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||ilmari.lauhakangas@libreoff ||ice.org Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147523] unable to expand formula region in calc using mouse in 7.4
https://bugs.documentfoundation.org/show_bug.cgi?id=147523 Buovjaga changed: What|Removed |Added Keywords||bibisectRequest, regression CC||ilmari.lauhakangas@libreoff ||ice.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147275] Locked libreOffice Writer file
https://bugs.documentfoundation.org/show_bug.cgi?id=147275 Buovjaga changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #4 from Buovjaga --- The lock file is temporary and it is normally removed, when you close the document. If you don't have the document open, you can delete the lock file. A crash might cause a lock file to stay in place. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147208] In Office Libre power point information not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=147208 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #2 from Buovjaga --- Ashlee: please copy and paste here the contents of your Help - About by clicking the copy button. This allows us to know more about your system. You could also test with version 7.3. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkobject.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit ff3f11a7fa8b7f1096d0bb64a2aa41c4d1edae59
Author: Arnaud Versini
AuthorDate: Thu Mar 24 14:33:19 2022 +0100
Commit: Arnaud Versini
CommitDate: Thu Mar 24 17:31:03 2022 +0100
gtk3 VCL : remove useless check
Change-Id: I45869f2160435da27f1b30acf41dbee76ce524e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132076
Tested-by: Jenkins
Reviewed-by: Arnaud Versini
diff --git a/vcl/unx/gtk3/gtkobject.cxx b/vcl/unx/gtk3/gtkobject.cxx
index 6f8fffd3f0a0..e5adb887cbeb 100644
--- a/vcl/unx/gtk3/gtkobject.cxx
+++ b/vcl/unx/gtk3/gtkobject.cxx
@@ -33,8 +33,6 @@ GtkSalObjectBase::GtkSalObjectBase(GtkSalFrame* pParent)
, m_pParent(pParent)
, m_pRegion(nullptr)
{
-if (!m_pParent)
-return;
}
GtkSalObject::GtkSalObject(GtkSalFrame* pParent, bool bShow)
[Libreoffice-commits] core.git: offapi/com sw/inc sw/qa sw/source
offapi/com/sun/star/text/TextField.idl |6 ++
sw/inc/fldbas.hxx |4
sw/qa/core/unocore/unocore.cxx | 29 +
sw/source/core/fields/fldbas.cxx | 15 +++
sw/source/core/fields/usrfld.cxx |1 +
sw/source/core/inc/unofldmid.h |1 +
sw/source/core/unocore/unomap.cxx |1 +
sw/source/uibase/docvw/edtwin2.cxx | 12
8 files changed, 69 insertions(+)
New commits:
commit 1acf8e3cfaf1ef92008e39514a32ace0d036e552
Author: Miklos Vajna
AuthorDate: Thu Mar 24 15:18:28 2022 +0100
Commit: Miklos Vajna
CommitDate: Thu Mar 24 17:29:52 2022 +0100
sw fields: add Title uno property
The use-case is user fields, which are kind of variables in the
document. They have a name and a value, but the name might be only
readable to an extension or macro, not to the user. In this case, it
makes sense to have a way to specify a user-readable tooltip.
Be consistent with TextFrames which already have a Title property.
Change-Id: I986792f5e55e0b96489347be482d640d155113cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132077
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/offapi/com/sun/star/text/TextField.idl
b/offapi/com/sun/star/text/TextField.idl
index 38c58e9afb1e..5499792b8c41 100644
--- a/offapi/com/sun/star/text/TextField.idl
+++ b/offapi/com/sun/star/text/TextField.idl
@@ -66,6 +66,12 @@ published service TextField
*/
[optional, property, readonly] boolean IsFieldDisplayed;
+/** Contains short title for the field, used to for tooltip purposes if
it's non-empty.
+
+@since LibreOffice 7.4
+*/
+[optional, property] string Title;
+
};
diff --git a/sw/inc/fldbas.hxx b/sw/inc/fldbas.hxx
index ccef32fa7921..5a256cb1884d 100644
--- a/sw/inc/fldbas.hxx
+++ b/sw/inc/fldbas.hxx
@@ -297,6 +297,8 @@ private:
LanguageTypem_nLang;///< Always change via
SetLanguage!
boolm_bUseFieldValueCache; /// control the usage of the
cached field value
boolm_bIsAutomaticLanguage;
+/// Used for tooltip purposes when it's not-empty.
+OUString m_aTitle;
virtual OUStringExpandImpl(SwRootFrame const* pLayout) const = 0;
virtual std::unique_ptr Copy() const = 0;
@@ -389,6 +391,8 @@ public:
/// Is this field clickable?
bool IsClickable() const;
virtual void dumpAsXml(xmlTextWriterPtr pWriter) const;
+OUString GetTitle() const { return m_aTitle; }
+void SetTitle(const OUString& rTitle) { m_aTitle = rTitle; }
};
inline SwFieldType* SwField::GetTyp() const
diff --git a/sw/qa/core/unocore/unocore.cxx b/sw/qa/core/unocore/unocore.cxx
index 30839266a7fc..3a569d64feef 100644
--- a/sw/qa/core/unocore/unocore.cxx
+++ b/sw/qa/core/unocore/unocore.cxx
@@ -13,6 +13,7 @@
#include
#include
#include
+#include
#include
#include
@@ -280,6 +281,34 @@ CPPUNIT_TEST_FIXTURE(SwCoreUnocoreTest,
testLineBreakTextPortionEnum)
CPPUNIT_ASSERT_EQUAL(static_cast(SwLineBreakClear::ALL),
eClear);
}
+CPPUNIT_TEST_FIXTURE(SwModelTestBase, testUserFieldTooltip)
+{
+// Given a document with a user field:
+loadURL("private:factory/swriter", nullptr);
+uno::Reference xFactory(mxComponent,
uno::UNO_QUERY);
+uno::Reference xField(
+xFactory->createInstance("com.sun.star.text.TextField.User"),
uno::UNO_QUERY);
+uno::Reference xMaster(
+xFactory->createInstance("com.sun.star.text.FieldMaster.User"),
uno::UNO_QUERY);
+xMaster->setPropertyValue("Name", uno::makeAny(OUString("a_user_field")));
+xField->attachTextFieldMaster(xMaster);
+xField->getTextFieldMaster()->setPropertyValue("Content",
uno::makeAny(OUString("42")));
+uno::Reference xDocument(mxComponent, uno::UNO_QUERY);
+uno::Reference xText = xDocument->getText();
+xText->insertTextContent(xText->createTextCursor(), xField,
/*bAbsorb=*/false);
+uno::Reference xFieldProps(xField, uno::UNO_QUERY);
+
+// When setting a tooltip on the field:
+OUString aExpected("first line\nsecond line");
+xFieldProps->setPropertyValue("Title", uno::makeAny(aExpected));
+
+// Then make sure that the tooltip we read back matches the one previously
specified:
+// Without the accompanying fix in place, this test would have failed with:
+// - the property is of unexpected type or void: Title
+// i.e. reading of the tooltip was broken.
+CPPUNIT_ASSERT_EQUAL(aExpected, getProperty(xFieldProps,
"Title"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/fields/fldbas.cxx b/sw/source/core/fields/fldbas.cxx
index c4272c3dadea..59e54e291dbb 100644
--- a/sw/source/core/fields/fldbas.cxx
+++ b/sw/source/core/fields/fldbas.cxx
@@ -355,6 +355,11 @@ bool SwField::QueryValue( uno::Any& rVal, sal_uInt16
nWhichId
[Libreoffice-commits] core.git: officecfg/registry svl/source uui/source
officecfg/registry/schema/org/openoffice/Office/Common.xcs |6 +
svl/source/passwordcontainer/passwordcontainer.cxx | 41 -
svl/source/passwordcontainer/passwordcontainer.hxx |6 +
uui/source/iahndl-authentication.cxx |5 -
4 files changed, 55 insertions(+), 3 deletions(-)
New commits:
commit d7ba5614d90381d68f880ca7e7c5ef8bbb1b1c43
Author: Caolán McNamara
AuthorDate: Mon Mar 21 20:58:34 2022 +
Commit: Caolán McNamara
CommitDate: Thu Mar 24 17:27:30 2022 +0100
make hash encoding match decoding
Seeing as old versions of the hash may be in the users config, add a
StorageVersion field to the office config Passwords section which
defaults to 0 to indicate the old hash is in use.
Try the old varient when StorageVersion is 0. When a new encoded master
password it set write StorageVersion of 1 to indicate a new hash is in
use and use the new style when StorageVersion is 1.
Change-Id: I3174c37a5891bfc849984e0ec5c2c392b9c6e7b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131947
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index dd896317adda..6e280eac2fc5 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -943,6 +943,12 @@
false
+
+
+ Specifies what version of encoding scheme the password
container uses.
+
+0
+
Specifies if there is a valid master password.
diff --git a/svl/source/passwordcontainer/passwordcontainer.cxx
b/svl/source/passwordcontainer/passwordcontainer.cxx
index 54fa34ce93f0..e8f521c28014 100644
--- a/svl/source/passwordcontainer/passwordcontainer.cxx
+++ b/svl/source/passwordcontainer/passwordcontainer.cxx
@@ -18,6 +18,7 @@
*/
#include
+#include
#include
@@ -256,6 +257,24 @@ bool StorageItem::useStorage()
}
+sal_Int32 StorageItem::getStorageVersion()
+{
+Sequence aNodeNames { "StorageVersion" };
+
+Sequence< Any > aPropertyValues = ConfigItem::GetProperties( aNodeNames );
+
+if( aPropertyValues.getLength() != aNodeNames.getLength() )
+{
+OSL_FAIL( "Problems during reading" );
+return 0;
+}
+
+sal_Int32 nResult = 0;
+aPropertyValues[0] >>= nResult;
+
+return nResult;
+}
+
bool StorageItem::getEncodedMasterPassword( OUString& aResult )
{
if( hasEncoded )
@@ -288,7 +307,8 @@ void StorageItem::setEncodedMasterPassword( const OUString&
aEncoded, bool bAcce
bool bHasMaster = ( !aEncoded.isEmpty() || bAcceptEmpty );
ConfigItem::SetModified();
-ConfigItem::PutProperties( { "HasMaster", "Master" }, {
uno::Any(bHasMaster), uno::Any(aEncoded) } );
+ConfigItem::PutProperties( { "HasMaster", "Master", "StorageVersion" },
+ { uno::Any(bHasMaster), uno::Any(aEncoded),
uno::Any(nCurrentStorageVersion) } );
hasEncoded = bHasMaster;
mEncoded = aEncoded;
@@ -772,6 +792,18 @@ OUString PasswordContainer::RequestPasswordFromUser(
PasswordRequestMode aRMode,
return aResult;
}
+// Mangle the key to match an old bug
+static OUString ReencodeAsOldHash(const OUString& rPass)
+{
+OUStringBuffer aBuffer;
+for (int ind = 0; ind < RTL_DIGEST_LENGTH_MD5; ++ind)
+{
+unsigned char i = static_cast(rPass.copy(ind * 2,
2).toUInt32(16));
+aBuffer.append(static_cast< sal_Unicode >('a' + (i >> 4)));
+aBuffer.append(static_cast< sal_Unicode >('a' + (i & 15)));
+}
+return aBuffer.makeStringAndClear();
+}
OUString const & PasswordContainer::GetMasterPassword( const Reference<
XInteractionHandler >& aHandler )
{
@@ -810,6 +842,9 @@ OUString const & PasswordContainer::GetMasterPassword(
const Reference< XInterac
}
else
{
+if (m_xStorageFile->getStorageVersion() == 0)
+aPass = ReencodeAsOldHash(aPass);
+
std::vector< OUString > aRM( DecodePasswords(
aEncodedMP, aPass, aRMode ) );
if( aRM.empty() || aPass != aRM[0] )
{
@@ -1014,6 +1049,10 @@ sal_Bool SAL_CALL
PasswordContainer::authorizateWithMasterPassword( const uno::R
do {
aPass = RequestPasswordFromUser( aRMode, xTmpHandler );
+
+if (m_xStorageFile->getStorageVersion() == 0)
+aPass = ReencodeAsOldHash(aPass);
+
bResult = ( !aPass.isEmpty() && aPass == m_aMasterPassword
);
aRMode = PasswordRequestMode_PASSWORD_REENTER; // further
questions with error notification
} while( !bResult &&
[Libreoffice-commits] core.git: external/liborcus
external/liborcus/forcepoint-83.patch.1 | 16
external/liborcus/forcepoint-84.patch.1 | 16
2 files changed, 16 insertions(+), 16 deletions(-)
New commits:
commit 2323fa29617e4919226517d50abbb9ad33b320ca
Author: Caolán McNamara
AuthorDate: Thu Mar 24 08:56:39 2022 +
Commit: Caolán McNamara
CommitDate: Thu Mar 24 17:26:39 2022 +0100
forcepoint#83 forcepoint#84 update to upstream fix
Change-Id: I5add09b4379a1f86a720af75b758389424f4f50b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132055
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/external/liborcus/forcepoint-83.patch.1
b/external/liborcus/forcepoint-83.patch.1
index bfd3bb86fcf9..644c0dcfff4e 100644
--- a/external/liborcus/forcepoint-83.patch.1
+++ b/external/liborcus/forcepoint-83.patch.1
@@ -1,4 +1,4 @@
-From 283b45ba3bcb22dc28303a09a96c9b94f86d1ba2 Mon Sep 17 00:00:00 2001
+From 4d58816e995a562f26f3cc5006ae9ddd46b1bbed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?=
Date: Wed, 23 Mar 2022 16:44:00 +
Subject: [PATCH] forcepoint#83 Invalid read of size 1
@@ -17,22 +17,22 @@ Subject: [PATCH] forcepoint#83 Invalid read of size 1
==343916==by 0x30E60945: (anonymous
namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence&)
(filterdetect.cxx:83)
==343916==by 0x30E60ABE: non-virtual thunk to (anonymous
namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence&)
(filterdetect.cxx:0)
---
- include/orcus/sax_parser.hpp | 2 ++
- 1 file changed, 2 insertions(+)
+ include/orcus/sax_parser.hpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/orcus/sax_parser.hpp b/include/orcus/sax_parser.hpp
-index 15e8d917..d0fc45b5 100644
+index 15e8d917..2e707568 100644
--- a/include/orcus/sax_parser.hpp
+++ b/include/orcus/sax_parser.hpp
-@@ -255,6 +255,8 @@ void
sax_parser<_Handler,_Config>::element_open(std::ptrdiff_t begin_pos)
+@@ -255,7 +255,7 @@ void
sax_parser<_Handler,_Config>::element_open(std::ptrdiff_t begin_pos)
while (true)
{
skip_space_and_control();
-+if (!has_char())
-+return;
- char c = cur_char();
+-char c = cur_char();
++char c = cur_char_checked();
if (c == '/')
{
+ // Self-closing element:
--
2.35.1
diff --git a/external/liborcus/forcepoint-84.patch.1
b/external/liborcus/forcepoint-84.patch.1
index 99aa0b9623b5..bbe05340bc63 100644
--- a/external/liborcus/forcepoint-84.patch.1
+++ b/external/liborcus/forcepoint-84.patch.1
@@ -1,4 +1,4 @@
-From 0fee6c0e3074be11874f1911a76f10eef5f59985 Mon Sep 17 00:00:00 2001
+From ec469f774bb91302c4df21eff1314dfd508d37c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?=
Date: Wed, 23 Mar 2022 20:04:31 +
Subject: [PATCH] forcepoint#84 Invalid read of size 1
@@ -17,22 +17,22 @@ Subject: [PATCH] forcepoint#84 Invalid read of size 1
==356879==by 0x11BE3855: orcus::orcus_xlsx::detect(unsigned char const*,
unsigned long) (orcus_xlsx.cpp:188)
==356879==by 0x11AB2492: orcus::detect(unsigned char const*, unsigned
long) (format_detection.cpp:60)
---
- src/parser/sax_parser_base.cpp | 2 ++
- 1 file changed, 2 insertions(+)
+ src/parser/sax_parser_base.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/parser/sax_parser_base.cpp b/src/parser/sax_parser_base.cpp
-index 46acb81d..11791edc 100644
+index 46acb81d..1cee821e 100644
--- a/src/parser/sax_parser_base.cpp
+++ b/src/parser/sax_parser_base.cpp
-@@ -300,6 +300,8 @@ void parser_base::value_with_encoded_char(cell_buffer&
buf, std::string_view& st
+@@ -300,7 +300,7 @@ void parser_base::value_with_encoded_char(cell_buffer&
buf, std::string_view& st
bool parser_base::value(std::string_view& str, bool decode)
{
-+if (!has_char())
-+throw malformed_xml_error("value must be quoted", offset());
- char c = cur_char();
+-char c = cur_char();
++char c = cur_char_checked();
if (c != '"' && c != '\'')
throw malformed_xml_error("value must be quoted", offset());
+
--
2.35.1
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/itratr.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 28e5cedd9be8f33dcbd95d345c0f530acaecfad4
Author: Caolán McNamara
AuthorDate: Thu Mar 24 14:32:22 2022 +
Commit: Caolán McNamara
CommitDate: Thu Mar 24 17:17:55 2022 +0100
forcepoint#86 RES_TXTATR_UNKNOWN_CONTAINER item put at invalid index
RES_CHRATR_BEGIN is 1, presumably RES_TXTATR_UNKNOWN_CONTAINER should
be stored in the last index
Change-Id: Id37fff41cbbccbc26fe5ccce6027014af7362729
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/core/text/itratr.cxx b/sw/source/core/text/itratr.cxx
index f76f15254e9f..95f7929a0e14 100644
--- a/sw/source/core/text/itratr.cxx
+++ b/sw/source/core/text/itratr.cxx
@@ -444,7 +444,7 @@ static void InsertCharAttrs(SfxPoolItem const** pAttrs,
SfxItemSet const& rItems
}
else if (nWhich == RES_TXTATR_UNKNOWN_CONTAINER)
{
-pAttrs[RES_CHRATR_END] = pItem;
+pAttrs[RES_CHRATR_END - RES_CHRATR_BEGIN] = pItem;
}
}
}
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/uicalc/uicalc.cxx | 16
1 file changed, 16 insertions(+)
New commits:
commit 400bfd03a97a9af75a55230bffd53fca45a0f3a6
Author: Xisco Fauli
AuthorDate: Thu Mar 24 12:33:10 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Mar 24 17:17:04 2022 +0100
tdf#113898: sc_uicalc: Add unittest
Change-Id: I52fa7ad0cb1f9b3d2f72229d961674f6292be60f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132071
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 8871195f4609..90bafa91f64e 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -234,6 +234,10 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testExternalReferences)
insertStringToCell(*pModelObj, "C2", "20");
insertStringToCell(*pModelObj, "C3", "5");
+insertStringToCell(*pModelObj, "D1", "BIG FISH");
+insertStringToCell(*pModelObj, "D2", "FISHFISH");
+insertStringToCell(*pModelObj, "D3", "FISHY");
+
// Save the document
utl::TempFile aTempFile = save(mxComponent, "calc8");
@@ -317,6 +321,18 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testExternalReferences)
CPPUNIT_ASSERT_EQUAL(OUString("TRUE"), pDoc->GetString(ScAddress(0, 0,
0)));
CPPUNIT_ASSERT_EQUAL(OUString("TRUE"), pDoc->GetString(ScAddress(1, 0,
0)));
}
+
+{
+//tdf#113898
+OUString aAndFormula = "=SUMPRODUCT(NOT(ISERROR(FIND(\"FISH\";'" +
aTempFile.GetURL()
+ + "'#$Sheet1.D1:D3";
+insertStringToCell(*pModelObj, "A1", aAndFormula.toUtf8().getStr());
+
+// Without the fix in place, this test would have failed with
+// - Expected: 3
+// - Actual : 1
+CPPUNIT_ASSERT_EQUAL(3.0, pDoc->GetValue(ScAddress(0, 0, 0)));
+}
}
CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf103994)
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/uicalc/uicalc.cxx | 159 ---
1 file changed, 75 insertions(+), 84 deletions(-)
New commits:
commit 3756e3145c39ace4454d2569709c2c0d64ad389a
Author: Xisco Fauli
AuthorDate: Thu Mar 24 12:05:50 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Mar 24 17:16:49 2022 +0100
CppunitTest_sc_uicalc: combine external reference tests
Change-Id: Ie3bc4dbf69e1b09e5ffdc4e7a02bc3a7cb02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132069
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index fc0d7895b32f..8871195f4609 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -195,43 +195,6 @@ ScModelObj*
ScUiCalcTest::saveAndReload(css::uno::Reference(mxComponent.get());
-CPPUNIT_ASSERT(pModelObj);
-ScDocument* pDoc = pModelObj->GetDocument();
-CPPUNIT_ASSERT(pDoc);
-
-insertStringToCell(*pModelObj, "A1", "1");
-insertStringToCell(*pModelObj, "B1", "2");
-insertStringToCell(*pModelObj, "C1", "3");
-insertStringToCell(*pModelObj, "D1", "4");
-
-// Save the document
-utl::TempFile aTempFile = save(mxComponent, "calc8");
-
-// Open a new document
-mxComponent = loadFromDesktop("private:factory/scalc");
-pModelObj = dynamic_cast(mxComponent.get());
-CPPUNIT_ASSERT(pModelObj);
-pDoc = pModelObj->GetDocument();
-CPPUNIT_ASSERT(pDoc);
-
-// Insert the reference to the external document
-OUString aAndFormula = "=AND('" + aTempFile.GetURL() + "'#$Sheet1.A1:D1)";
-insertStringToCell(*pModelObj, "A1", aAndFormula.toUtf8().getStr());
-
-OUString aOrFormula = "=OR('" + aTempFile.GetURL() + "'#$Sheet1.A1:D1)";
-insertStringToCell(*pModelObj, "B1", aOrFormula.toUtf8().getStr());
-
-// Without the fix in place, this test would have failed with
-// - Expected: TRUE
-// - Actual : Err:504
-CPPUNIT_ASSERT_EQUAL(OUString("TRUE"), pDoc->GetString(ScAddress(0, 0,
0)));
-CPPUNIT_ASSERT_EQUAL(OUString("TRUE"), pDoc->GetString(ScAddress(1, 0,
0)));
-}
-
CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf100847)
{
mxComponent = loadFromDesktop("private:factory/scalc");
@@ -249,27 +212,9 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf100847)
CPPUNIT_ASSERT(pModelObj);
pDoc = pModelObj->GetDocument();
CPPUNIT_ASSERT(pDoc);
-
-// Insert the reference to the external document
-OUString aFormula = "=+'" + aTempFile.GetURL() + "'#$Sheet1.A1";
-insertStringToCell(*pModelObj, "A1", aFormula.toUtf8().getStr());
-
-aFormula = "=+'" + aTempFile.GetURL() + "'#$Sheet1.A1*1";
-insertStringToCell(*pModelObj, "B1", aFormula.toUtf8().getStr());
-
-aFormula = "=+N('" + aTempFile.GetURL() + "'#$Sheet1.A1)*1";
-insertStringToCell(*pModelObj, "C1", aFormula.toUtf8().getStr());
-
-CPPUNIT_ASSERT_EQUAL(OUString("0"), pDoc->GetString(ScAddress(0, 0, 0)));
-
-// Without the fix in place, this test would have failed with
-// - Expected: 0
-// - Actual : #VALUE!
-CPPUNIT_ASSERT_EQUAL(OUString("0"), pDoc->GetString(ScAddress(1, 0, 0)));
-CPPUNIT_ASSERT_EQUAL(OUString("0"), pDoc->GetString(ScAddress(2, 0, 0)));
}
-CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf115162)
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testExternalReferences)
{
mxComponent = loadFromDesktop("private:factory/scalc");
ScModelObj* pModelObj = dynamic_cast(mxComponent.get());
@@ -277,17 +222,17 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf115162)
ScDocument* pDoc = pModelObj->GetDocument();
CPPUNIT_ASSERT(pDoc);
+insertStringToCell(*pModelObj, "A1", "2015");
insertStringToCell(*pModelObj, "A2", "2015");
insertStringToCell(*pModelObj, "A3", "2015");
-insertStringToCell(*pModelObj, "A4", "2015");
+insertStringToCell(*pModelObj, "B1", "1");
insertStringToCell(*pModelObj, "B2", "1");
-insertStringToCell(*pModelObj, "B3", "1");
-insertStringToCell(*pModelObj, "B4", "2");
+insertStringToCell(*pModelObj, "B3", "2");
-insertStringToCell(*pModelObj, "C2", "10");
-insertStringToCell(*pModelObj, "C3", "20");
-insertStringToCell(*pModelObj, "C4", "5");
+insertStringToCell(*pModelObj, "C1", "10");
+insertStringToCell(*pModelObj, "C2", "20");
+insertStringToCell(*pModelObj, "C3", "5");
// Save the document
utl::TempFile aTempFile = save(mxComponent, "calc8");
@@ -299,33 +244,79 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf115162)
pDoc = pModelObj->GetDocument();
CPPUNIT_ASSERT(pDoc);
-// Insert the reference to the external document
-OUString aFormula = "=SUMIFS('" + aTempFile.GetURL() + "'#$Sheet1.C2:C4,'"
+ aTempFile.GetURL()
-+ "'#$Sheet1.B2:B4,1,'" + aTempFile.GetURL() +
"'#$Sheet1.A2:A4,2015)";
-insertStringToCell(*pModelObj, "A1", aFormula.toUtf8().getStr());
+// Insert the references to the external document
+{
[Libreoffice-bugs] [Bug 145752] CompatibilityMode Basic function documentation is incomplete
https://bugs.documentfoundation.org/show_bug.cgi?id=145752 --- Comment #5 from Commit Notification --- Alain Romedenne committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/8e0ace084d46ae8758b8f6ba36be31059f201537 tdf#145752 Correction to CompatibilityMode() help page -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145752] CompatibilityMode Basic function documentation is incomplete
https://bugs.documentfoundation.org/show_bug.cgi?id=145752 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/uicalc/uicalc.cxx |9 +
1 file changed, 9 insertions(+)
New commits:
commit 97d53be544fc32f1da294dde133195c5b10588e9
Author: Xisco Fauli
AuthorDate: Thu Mar 24 11:54:39 2022 +0100
Commit: Xisco Fauli
CommitDate: Thu Mar 24 17:16:05 2022 +0100
tdf#116149: sc_uicalc: Add unittest
Change-Id: I304d21e818b90b4c4daba26448836e23bc2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132067
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 84c8b208deb1..fc0d7895b32f 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -317,6 +317,15 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf115162)
// - Expected: 1
// - Actual : Err:504
CPPUNIT_ASSERT_EQUAL(OUString("1"), pDoc->GetString(ScAddress(1, 0, 0)));
+
+aFormula
+= "=VAR('" + aTempFile.GetURL() + "'#$Sheet1.C2;'" +
aTempFile.GetURL() + "'#$Sheet1.C3)";
+insertStringToCell(*pModelObj, "C1", aFormula.toUtf8().getStr());
+
+// tdf#116149: Without the fix in place, this test would have failed with
+// - Expected: 50
+// - Actual : Err:504
+CPPUNIT_ASSERT_EQUAL(OUString("50"), pDoc->GetString(ScAddress(2, 0, 0)));
}
CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf103994)
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/compatibilitymode.xhp | 65 ++-- 1 file changed, 39 insertions(+), 26 deletions(-) New commits: commit 8e0ace084d46ae8758b8f6ba36be31059f201537 Author: Alain Romedenne AuthorDate: Wed Feb 16 13:28:13 2022 +0100 Commit: Alain Romedenne CommitDate: Thu Mar 24 17:16:10 2022 +0100 tdf#145752 Correction to CompatibilityMode() help page Change-Id: Ie7ca911d8d445c57ad94458711164bdb18be1f13 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129946 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-by: Alain Romedenne diff --git a/source/text/sbasic/shared/compatibilitymode.xhp b/source/text/sbasic/shared/compatibilitymode.xhp index a7e0e1a33..f772f92c5 100644 --- a/source/text/sbasic/shared/compatibilitymode.xhp +++ b/source/text/sbasic/shared/compatibilitymode.xhp @@ -21,51 +21,64 @@ CompatibilityMode() Function -CompatibilityMode() function controls runtime mode and affects all code executed after setting or resetting the mode. - +CompatibilityMode() function controls or queries runtime mode. It affects all code executed after setting or resetting the runtime mode. + Use this feature with caution, limit it to document conversion for example. -Option Compatible turns on VBA compatibility at module level for the %PRODUCTNAME Basic interpreter. + + + + CompatibilityMode(Optional Enable As Boolean) As Boolean + + + +CompatibilityMode function always returns the mode that is active after its execution. That is if called with argument, it returns the new mode, if called without argument, it returns active mode without modifying it. + + +Enable: Sets or unsets new compatibility mode when the argument is present. +CompatibilityMode function relates to Option VBASupport 1, in which case it always returns True. It is unrelated to Option Compatible compiler directive. + This function may affect or help in the following situations: -Creating enumerations with Enum statement +Scoping of variables. Running RmDir command in VBA mode. In VBA only empty directories are removed by RmDir while %PRODUCTNAME Basic removes a directory recursively. Changing behavior of Basic Dir command. The directory flag (16) for the Dir command means that only directories are returned in %PRODUCTNAME Basic, while in VBA normal files and directories are returned. Color components calculation with the Red and Blue functions which are interchanged (The Green function is not affected). -CompatibilityMode() function may be necessary when resorting to Option Compatible or Option VBASupport compiler modes. - -CompatibilityMode(True | False) + Given a NOT empty directory at file:///home/me/Test -Sub RemoveDir -CompatibilityMode( true ) -RmDir( "file:///home/me/Test" ) -End Sub + Sub RemoveDir + MsgBox CompatibilityMode() ' False + + CompatibilityMode( True ) + RmDir( "file:///home/me/Test" ) + CompatibilityMode False + + MsgBox CompatibilityMode ' False + End Sub - With CompatibilityMode( true ) the program results in an error, otherwise the Test directory and all its content is deleted. + With CompatibilityMode( True ) the program raises an error, otherwise the Test directory and all its content is deleted. Modifying Dir behavior -Sub VBADirCommand - CompatibilityMode( true ) ' Shows also normal files -Entry$ = Dir( "file:///home/me/Tmp/*.*", 16 ) -Total$ = "" -While Entry$ "" -Total$ = Total$ + Entry$ + Chr$(13) -Entry$ = Dir -Wend -MsgBox Total$ -End Sub - +Sub VBADirCommand + CompatibilityMode( Enable := True ) ' Shows also normal files + Entry$ = Dir( "file:///home/me/Tmp/*.*", 16 ) + Total$ = "" + While Entry$ "" + Total$ = Total$ + Entry$ + Chr$(13) + Entry$ = Dir + Wend + MsgBox Total$ + CompatibilityMode Enable := False ' Shows only directories +End Sub + - -Refer to Identifying the Operating System and Getting Session Information for Option Compatible simple examples, or Access2Base shared Basic library for other class examples making use of Option Compatible compiler mode. - Variables scope modification in Using Procedures and Functions with CompatibilityMode() function.
[Libreoffice-bugs] [Bug 148158] Icons and menus unreadable across Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=148158 Robert Großkopf changed: What|Removed |Added Component|Base|LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 lol changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from lol --- (In reply to Dave Barton from comment #3) > Did you follow Heiko's recommendation to use "Help > Restart in Safe Mode > > Continue in Safe Mode"? Yes, I did. This also occurs with LO 7.0.4 in Debian. Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 2; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US Debian package version: 1:7.0.4-4+deb11u1 Calc: threaded Did you do exactly the steps in comment 1? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 lol changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from lol --- (In reply to Dave Barton from comment #3) > Did you follow Heiko's recommendation to use "Help > Restart in Safe Mode > > Continue in Safe Mode"? Yes, I did. This also occurs with LO 7.0.4 in Debian. Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 2; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US Debian package version: 1:7.0.4-4+deb11u1 Calc: threaded Did you do exactly the steps in comment 1? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144144] Crash in: SkiaSalGraphicsImpl::applyXor()
https://bugs.documentfoundation.org/show_bug.cgi?id=144144 --- Comment #9 from Julien Nabet --- If Skia related (at least for the last crash), this may help: https://wiki.documentfoundation.org/QA/FirstSteps#Graphics-related_issues_.28_Skia_.29 -- You are receiving this mail because: You are the assignee for the bug.
