[Libreoffice-bugs] [Bug 120464] Creating a new Heading style from standard Heading N style does not inherit outline level
https://bugs.documentfoundation.org/show_bug.cgi?id=120464 Timur changed: What|Removed |Added Priority|medium |low Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Telesto changed: What|Removed |Added Depends on||147726 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147726 [Bug 147726] Crash in BigPtrArray::Index2Block(unsigned long) const [assert (pTextNd), function UndoImpl, file undel.cxx, line 918] -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147726] Crash in BigPtrArray::Index2Block(unsigned long) const [assert (pTextNd), function UndoImpl, file undel.cxx, line 918]
https://bugs.documentfoundation.org/show_bug.cgi?id=147726 Telesto changed: What|Removed |Added Summary|Crash in|Crash in |BigPtrArray::Index2Block(un |BigPtrArray::Index2Block(un |signed long) const |signed long) const [assert ||(pTextNd), function ||UndoImpl, file undel.cxx, ||line 918] Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147726] Crash in BigPtrArray::Index2Block(unsigned long) const
https://bugs.documentfoundation.org/show_bug.cgi?id=147726
--- Comment #5 from Telesto ---
Assertion failed: (pTextNd), function UndoImpl, file undel.cxx, line 918.
* thread #1, queue = 'com.apple.main-thread', stop reason = hit program assert
frame #4: 0x000173e6a668
libswlo.dylib`SwUndoDelete::UndoImpl(this=0x63ac9380,
rContext=0x7ff7bfefc130) at undel.cxx:918:13
915
lcl_ReAnchorAtContentFlyFrames(*rDoc.GetSpzFrameFormats(), aPos, nOldIdx);
916 pTextNd = aPos.nNode.GetNode().GetTextNode();
917 }
-> 918 assert(pTextNd); // else where does m_aEndStr come from?
919 if( pTextNd )
920 {
921 OUString const ins( pTextNd->InsertText(*m_aEndStr,
aPos.nContent,
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text)
https://bugs.documentfoundation.org/show_bug.cgi?id=99725 Dieter changed: What|Removed |Added Blocks|97895 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages
https://bugs.documentfoundation.org/show_bug.cgi?id=97895 Dieter changed: What|Removed |Added Depends on|99725 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99725 [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages
https://bugs.documentfoundation.org/show_bug.cgi?id=97895 Dieter changed: What|Removed |Added Depends on|99724 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99724 [Bug 99724] FILEOPEN RTF layout problem with footer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99724] FILEOPEN RTF layout problem with footer
https://bugs.documentfoundation.org/show_bug.cgi?id=99724 Dieter changed: What|Removed |Added Blocks|97895 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages
https://bugs.documentfoundation.org/show_bug.cgi?id=97895 Dieter changed: What|Removed |Added Depends on|97947 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97947 [Bug 97947] FILEOPEN RTF layout problem with table -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97947] FILEOPEN RTF layout problem with table
https://bugs.documentfoundation.org/show_bug.cgi?id=97947 Dieter changed: What|Removed |Added Blocks|97895 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112765] [META] RTF (text) table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112765 Dieter changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=97 | |895 | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113423] [META] RTF (text) header and footer-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113423 Dieter changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=97 | |895 | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text)
https://bugs.documentfoundation.org/show_bug.cgi?id=99725 Dieter changed: What|Removed |Added Blocks||97895 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99724] FILEOPEN RTF layout problem with footer
https://bugs.documentfoundation.org/show_bug.cgi?id=99724 Dieter changed: What|Removed |Added Blocks||97895 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages
https://bugs.documentfoundation.org/show_bug.cgi?id=97895 Dieter changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=11 | |2765, | |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=11 | |3423| Depends on||97947, 99724, 99725 Summary|[META] FILEOPEN RTF layout |[META] FILEOPEN RTF layout |problem with table, |problem with extra pages |footers, extra pages| --- Comment #6 from Dieter --- (In reply to Dieter from comment #5) > How is this meta bug related to bug 112765 (RTF-Tables) and bug 113423 > (RTF-Header-Footer)? No answer to my question for more than three years. So I moved some report to bug 112765 and bug 113423 and changed bug summary. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97947 [Bug 97947] FILEOPEN RTF layout problem with table https://bugs.documentfoundation.org/show_bug.cgi?id=99724 [Bug 99724] FILEOPEN RTF layout problem with footer https://bugs.documentfoundation.org/show_bug.cgi?id=99725 [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97947] FILEOPEN RTF layout problem with table
https://bugs.documentfoundation.org/show_bug.cgi?id=97947 Dieter changed: What|Removed |Added Blocks||97895 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with extra pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97895] [META] FILEOPEN RTF layout problem with table, footers, extra pages
https://bugs.documentfoundation.org/show_bug.cgi?id=97895 Dieter changed: What|Removed |Added Depends on|97947 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97947 [Bug 97947] FILEOPEN RTF layout problem with table -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97947] FILEOPEN RTF layout problem with table
https://bugs.documentfoundation.org/show_bug.cgi?id=97947 Dieter changed: What|Removed |Added Blocks|97895 | CC||dgp-m...@gmx.de Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with table, footers, extra pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113423] [META] RTF (text) header and footer-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113423 Dieter changed: What|Removed |Added Depends on||99725 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99725 [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97895] [META] FILEOPEN RTF layout problem with table, footers, extra pages
https://bugs.documentfoundation.org/show_bug.cgi?id=97895 Dieter changed: What|Removed |Added Depends on|99725 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99725 [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Dieter changed: What|Removed |Added Depends on|99725 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99725 [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text)
https://bugs.documentfoundation.org/show_bug.cgi?id=99725 Dieter changed: What|Removed |Added Blocks|81234, 97895|113423 CC||dgp-m...@gmx.de Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=81234 [Bug 81234] [META] RTF filter issues https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with table, footers, extra pages https://bugs.documentfoundation.org/show_bug.cgi?id=113423 [Bug 113423] [META] RTF (text) header and footer-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113423] [META] RTF (text) header and footer-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113423 Dieter changed: What|Removed |Added Depends on||99724 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99724 [Bug 99724] FILEOPEN RTF layout problem with footer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97895] [META] FILEOPEN RTF layout problem with table, footers, extra pages
https://bugs.documentfoundation.org/show_bug.cgi?id=97895 Dieter changed: What|Removed |Added Depends on|99724 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99724 [Bug 99724] FILEOPEN RTF layout problem with footer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99724] FILEOPEN RTF layout problem with footer
https://bugs.documentfoundation.org/show_bug.cgi?id=99724 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Blocks|97895 |113423 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97895 [Bug 97895] [META] FILEOPEN RTF layout problem with table, footers, extra pages https://bugs.documentfoundation.org/show_bug.cgi?id=113423 [Bug 113423] [META] RTF (text) header and footer-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145683] LibreOffice Writer + Save As dialog box File filter + Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=145683 Dieter changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Dieter --- (In reply to krumple_sodium from comment #2) > I now have LO 7.3.2.2 and the problem is still present. But you can't confirm your own bugs => status UNCONFIRMED > Is this a problem with the Qt libraries? Since I don't work with Linux, I can't answer that question. But if the problem doesn't occur with the LO dialog, I admit, that it is not a LO bug. But I'm not sure for 100%. I hope a Linux user can help. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88278] [META] SVG import image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Dieter changed: What|Removed |Added Depends on||148191 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148191 [Bug 148191] xlink:href in SVG is deprecated -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148191] xlink:href in SVG is deprecated
https://bugs.documentfoundation.org/show_bug.cgi?id=148191 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de Blocks||88278 --- Comment #1 from Dieter --- Chamelon, thank you for reportng the bug. Does it happen, if you insert a svg-image, or if you open for example docx-file with svg-image? Please specify steps to reproduce. Thank you. => NEEDNFO Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=88278 [Bug 88278] [META] SVG import image filter (all modules) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148019] kf5 Wayland: Menus are shown as decorated separate windows when LO window was not focussed
https://bugs.documentfoundation.org/show_bug.cgi?id=148019 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147201] Progress in Wayland scaling on KF5 but still not there
https://bugs.documentfoundation.org/show_bug.cgi?id=147201 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145816] Cursor duplicates when new place is clicked, does not disappear from old location on hidpi screen
https://bugs.documentfoundation.org/show_bug.cgi?id=145816 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148191] xlink:href in SVG is deprecated
https://bugs.documentfoundation.org/show_bug.cgi?id=148191 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148188] Distribute Selection not working correctly when shadows are enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148188 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148185] German translation - little issue
https://bugs.documentfoundation.org/show_bug.cgi?id=148185 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148184] FORMATTING create a means to represent an integer as an IP Address
https://bugs.documentfoundation.org/show_bug.cgi?id=148184 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148183] Dragging widgets in the Dialog Editor should preview the full widget size
https://bugs.documentfoundation.org/show_bug.cgi?id=148183 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148182] Page number and page count mess up in exported SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148182 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148181] Libreoffice dosn't work with JAWS
https://bugs.documentfoundation.org/show_bug.cgi?id=148181 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148180] Overline text decoration misses in exported SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148180 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148179] Dashed boxes, lines and polygons appear solid in exported SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148179 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148178] SVG Export from macro in old version of SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148178 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148174] FILEOPEN DOCX Ref field incorrect with "Paragraph # in full context" and "Relative position of paragraph" enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148174 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148173] FILEOPEN DOCX Ref field incorrect with "Paragraph # from marked paragraph" and "Relative position of paragraph" enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148173 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148172] FILEOPEN DOCX Ref field incorrect with "# of paragraph in relative context" and "Relative position of paragraph" enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148172 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148171] FILEOPEN DOCX PageRef field with "Position of paragraph" option incorrectly imported
https://bugs.documentfoundation.org/show_bug.cgi?id=148171 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148165] Misalignment between bullet points and text when line spacing is altered
https://bugs.documentfoundation.org/show_bug.cgi?id=148165 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148457] Blank password works for a pdf file set with permission password
https://bugs.documentfoundation.org/show_bug.cgi?id=148457 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148457] Blank password works for a pdf file set with permission password
https://bugs.documentfoundation.org/show_bug.cgi?id=148457 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148427] EDITING: Calc freezes when attempting to "Paste Special"
https://bugs.documentfoundation.org/show_bug.cgi?id=148427 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148385] Textimport doesn't work correct
https://bugs.documentfoundation.org/show_bug.cgi?id=148385 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148427] EDITING: Calc freezes when attempting to "Paste Special"
https://bugs.documentfoundation.org/show_bug.cgi?id=148427 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148385] Textimport doesn't work correct
https://bugs.documentfoundation.org/show_bug.cgi?id=148385 --- Comment #10 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141861] Graphic placement is incorrect on last page with 2 columns and Evenly distribute contents to all columns
https://bugs.documentfoundation.org/show_bug.cgi?id=141861 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141861] Graphic placement is incorrect on last page with 2 columns and Evenly distribute contents to all columns
https://bugs.documentfoundation.org/show_bug.cgi?id=141861 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104742] [META] Network-involved bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=104742 Bug 104742 depends on bug 140484, which changed state. Bug 140484 Summary: LibreOffice 7.1 cannot save odb files created in previous versions on cifs filesystem (see steps in comment 6) https://bugs.documentfoundation.org/show_bug.cgi?id=140484 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140484] LibreOffice 7.1 cannot save odb files created in previous versions on cifs filesystem (see steps in comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=140484 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140484] LibreOffice 7.1 cannot save odb files created in previous versions on cifs filesystem (see steps in comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=140484 --- Comment #13 from QA Administrators --- Dear Lionel Elie Mamane, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 69461] SLIDESHOW: Inserted Video files play the first Video once but subsequent videos only play sound with no video image
https://bugs.documentfoundation.org/show_bug.cgi?id=69461 NoWorries changed: What|Removed |Added URL||https://bugs.launchpad.net/ ||ubuntu/+source/libreoffice/ ||+bug/1967976 Keywords|preBibisect, regression |filter:odp, needsDevEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145683] LibreOffice Writer + Save As dialog box File filter + Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=145683 krumple_sodium changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2 from krumple_sodium --- I now have LO 7.3.2.2 and the problem is still present. No, the CHECKBOX in “use of LO dialog boxes is enabled in Tools -> Options -> General” is not checked. If I check it, the dialog box looks slightly different and the filter COMBOXBOX is not editable, which is the correct behavior. Is this a problem with the Qt libraries? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126172] Tools-Options cannot be opened if GPG4win is installed and many PGP keys set (Windows 10?)
https://bugs.documentfoundation.org/show_bug.cgi?id=126172 --- Comment #22 from rugew --- Play game with to here https://happywheelsunblocked.io -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126172] Tools-Options cannot be opened if GPG4win is installed and many PGP keys set (Windows 10?)
https://bugs.documentfoundation.org/show_bug.cgi?id=126172 --- Comment #21 from rugew --- Nice [url=https://happywheelsunblocked.io]happy wheels[/url] -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126172] Tools-Options cannot be opened if GPG4win is installed and many PGP keys set (Windows 10?)
https://bugs.documentfoundation.org/show_bug.cgi?id=126172 --- Comment #20 from rugew --- Sadness is the legacy of the past, regret is the pain of memory https://happywheelsunblocked.io;>happy wheels -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112969] [META] DOCX (OOXML) field-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112969 Bug 112969 depends on bug 148052, which changed state. Bug 148052 Summary: FILEOPEN DOCX: Date(fixed) or Time(fixed) fields with has a '.' in the Date Format are updated dynamically in Writer https://bugs.documentfoundation.org/show_bug.cgi?id=148052 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svl/source
svl/source/numbers/zforfind.cxx | 23 +++
1 file changed, 23 insertions(+)
New commits:
commit 7a16002ede5fd31ae8f3358136ad49de40465ac1
Author: Eike Rathke
AuthorDate: Fri Apr 8 21:46:47 2022 +0200
Commit: Eike Rathke
CommitDate: Sat Apr 9 02:23:54 2022 +0200
Resolves: tdf#148052 accept a ". Month " name for matching DMY format
... even if the locale doesn't define such DM order or
LongDateDaySeparator.
Change-Id: I4bef720dff3582de9b60313824a84b570c153e98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132741
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/svl/source/numbers/zforfind.cxx b/svl/source/numbers/zforfind.cxx
index 438eacabc893..b0207a4df2be 100644
--- a/svl/source/numbers/zforfind.cxx
+++ b/svl/source/numbers/zforfind.cxx
@@ -2604,6 +2604,29 @@ bool ImpSvNumberInputScan::ScanMidString( const
OUString& rString, sal_uInt16 nS
SkipBlanks(rString, nPos);
bDate = SkipString( rDate, rString, nPos); // 10. 10- 10/
}
+if (!bDate && nStringPos == 1 && mpFormat && (mpFormat->GetType() &
SvNumFormatType::DATE))
+{
+// If a DMY format was given and a mid string starts with a literal
+// ". " dot+space and could contain a following month name and ends
+// with a space or LongDateMonthSeparator, like it's scanned in
+// `14". AUG "18`, then it may be a date as well. Regardless whether
+// defined such by the locale or not.
+// This *could* check for presence of ". "MMM or ". " in the actual
+// format code for further restriction to match only if present, but..
+
+const sal_uInt32 nExactDateOrder = mpFormat->GetExactDateOrder();
+// Exactly DMY.
+if (((nExactDateOrder & 0xff) == 'Y') && (((nExactDateOrder >> 8) &
0xff) == 'M')
+&& (((nExactDateOrder >> 16) & 0xff) == 'D'))
+{
+const sal_Int32 nTmpPos = nPos;
+if (SkipChar('.', rString, nPos) && SkipBlanks(rString, nPos) &&
nPos + 2 < rString.getLength()
+&& (rString.endsWith(" ") || rString.endsWith(
pLoc->getLongDateMonthSep(
+bDate = true;
+else
+nPos = nTmpPos;
+}
+}
if (bDate || ((MayBeIso8601() || MayBeMonthDate()) &&// 1999-12-31
31-Dec-1999
SkipChar( '-', rString, nPos)))
{
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/content.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit ccb78b98e0618cce365562fe326d018892b8104a
Author: Jim Raykowski
AuthorDate: Thu Apr 7 08:03:19 2022 -0800
Commit: Jim Raykowski
CommitDate: Sat Apr 9 01:35:46 2022 +0200
SwNavigator: set entry focus and update toolbox items sensitivity
when content tree entry selection is made by the SelectContentType
function
The SelectContentType function is used when the Navigate By control
combo box selection is changed by direct selection. This patch makes
the tree entry cursor position be set to the selected content type
entry so keyboard tab navigation will land on it. It also makes
the move chapter up/down and promote/demote outline level toolbox items
sensitivity update when the selection is made.
Change-Id: I56675592678accc6db3eacb25bf9bccae8eb1cef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132689
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 3ee581276a76..583f159d2a33 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5074,9 +5074,8 @@ void SwContentTree::SelectContentType(std::u16string_view
rContentTypeName)
{
if (m_xTreeView->get_text(*xIter) == rContentTypeName)
{
-m_xTreeView->unselect_all();
-m_xTreeView->select(*xIter);
-m_xTreeView->scroll_to_row(*xIter);
+m_xTreeView->set_cursor(*xIter);
+Select();
break;
}
} while (m_xTreeView->iter_next_sibling(*xIter));
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Aron Budea changed: What|Removed |Added Depends on||147483 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147483 [Bug 147483] Writer unable to read nested floating table/ group textbox in floating table. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147483] Writer unable to read nested floating table/ group textbox in floating table.
https://bugs.documentfoundation.org/show_bug.cgi?id=147483 Aron Budea changed: What|Removed |Added Blocks||139532 CC||aron.bu...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139532 [Bug 139532] [META] DOCX Floating table related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/fields/flddat.cxx |9 + 1 file changed, 1 insertion(+), 8 deletions(-) New commits: commit 1c49b677313b94efe17bf8bf8f2952416c2453cc Author: Eike Rathke AuthorDate: Fri Apr 8 21:56:54 2022 +0200 Commit: Eike Rathke CommitDate: Sat Apr 9 00:56:04 2022 +0200 Use DateTime(css::util::DateTime&) ctor Individual fragments set in the given order even raised SAL_WARN about non-existing year 0 ... Change-Id: Iadfc648423b9fc7ec1a9ebfbc05a1ea814078ac2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132742 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sw/source/core/fields/flddat.cxx b/sw/source/core/fields/flddat.cxx index 99d1ca45e728..51246f6eea0e 100644 --- a/sw/source/core/fields/flddat.cxx +++ b/sw/source/core/fields/flddat.cxx @@ -213,14 +213,7 @@ bool SwDateTimeField::PutValue( const uno::Any& rVal, sal_uInt16 nWhichId ) util::DateTime aDateTimeValue; if(!(rVal >>= aDateTimeValue)) return false; -DateTime aDateTime( DateTime::EMPTY ); -aDateTime.SetNanoSec(aDateTimeValue.NanoSeconds); -aDateTime.SetSec(aDateTimeValue.Seconds); -aDateTime.SetMin(aDateTimeValue.Minutes); -aDateTime.SetHour(aDateTimeValue.Hours); -aDateTime.SetDay(aDateTimeValue.Day); -aDateTime.SetMonth(aDateTimeValue.Month); -aDateTime.SetYear(aDateTimeValue.Year); +DateTime aDateTime(aDateTimeValue); SetDateTime(aDateTime); } break;
[Libreoffice-commits] core.git: 2 commits - sw/source vcl/source
sw/source/core/inc/fntcache.hxx |7 ---
sw/source/core/txtnode/fntcache.cxx | 14 +++---
vcl/source/gdi/impglyphitem.cxx |7 ++-
3 files changed, 13 insertions(+), 15 deletions(-)
New commits:
commit 7cc4b06fc44c06866cdabb4a8856c7cee3fcfe2d
Author: Luboš Luňák
AuthorDate: Fri Apr 8 14:35:34 2022 +0200
Commit: Luboš Luňák
CommitDate: Sat Apr 9 00:37:21 2022 +0200
use helper GetTextArray() in all places
Change-Id: Icec4326cf614574d7dabe6752f985b3ac4462fb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132744
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sw/source/core/inc/fntcache.hxx b/sw/source/core/inc/fntcache.hxx
index 3b8934013059..4f58be568951 100644
--- a/sw/source/core/inc/fntcache.hxx
+++ b/sw/source/core/inc/fntcache.hxx
@@ -78,13 +78,6 @@ class SwFntObj final : public SwCacheObj
bool m_bSymbol : 1;
bool m_bPaintBlank : 1;
-static void GetTextArray(const OutputDevice& rOutputDevice, const
OUString& rStr,
- std::vector& rDXAry, sal_Int32 nIndex,
sal_Int32 nLen,
- const vcl::text::TextLayoutCache* layoutCache =
nullptr);
-static void GetTextArray(const OutputDevice& rOutputDevice, const
SwDrawTextInfo& rInf, std::vector& rDXAry,
- sal_Int32 nLen);
-static void GetTextArray(const OutputDevice& rOutputDevice, const
SwDrawTextInfo& rInf, std::vector& rDXAry);
-
static tools::Long s_nPixWidth;
static MapMode *s_pPixMap;
diff --git a/sw/source/core/txtnode/fntcache.cxx
b/sw/source/core/txtnode/fntcache.cxx
index 39e23613e669..65a4332b462d 100644
--- a/sw/source/core/txtnode/fntcache.cxx
+++ b/sw/source/core/txtnode/fntcache.cxx
@@ -756,20 +756,20 @@ static void lcl_DrawLineForWrongListData(
rInf.GetOut().Pop();
}
-void SwFntObj::GetTextArray(const OutputDevice& rDevice, const OUString& rStr,
std::vector& rDXAry,
-sal_Int32 nIndex, sal_Int32 nLen, const
vcl::text::TextLayoutCache* layoutCache)
+static void GetTextArray(const OutputDevice& rDevice, const OUString& rStr,
std::vector& rDXAry,
+ sal_Int32 nIndex, sal_Int32 nLen, const
vcl::text::TextLayoutCache* layoutCache = nullptr)
{
const SalLayoutGlyphs* pLayoutCache =
SalLayoutGlyphsCache::self()->GetLayoutGlyphs(, rStr, nIndex, nLen,
0, layoutCache);
rDevice.GetTextArray(rStr, , nIndex, nLen, layoutCache,
pLayoutCache);
}
-void SwFntObj::GetTextArray(const OutputDevice& rOutputDevice, const
SwDrawTextInfo& rInf, std::vector& rDXAry)
+static void GetTextArray(const OutputDevice& rOutputDevice, const
SwDrawTextInfo& rInf, std::vector& rDXAry)
{
return GetTextArray(rOutputDevice, rInf.GetText(), rDXAry,
rInf.GetIdx().get(), rInf.GetLen().get(), rInf.GetVclCache());
}
-void SwFntObj::GetTextArray(const OutputDevice& rOutputDevice, const
SwDrawTextInfo& rInf, std::vector& rDXAry, sal_Int32 nLen)
+static void GetTextArray(const OutputDevice& rOutputDevice, const
SwDrawTextInfo& rInf, std::vector& rDXAry, sal_Int32 nLen)
{
// Substring is fine.
assert( nLen <= rInf.GetLen().get());
@@ -2246,7 +2246,7 @@ TextFrameIndex SwFont::GetTextBreak(SwDrawTextInfo const
& rInf, tools::Long nTe
const sal_uInt16 nGridWidth = GetGridWidth(*pGrid, *pDoc);
std::vector aKernArray;
-rInf.GetOut().GetTextArray( rInf.GetText(), ,
+GetTextArray( rInf.GetOut(), rInf.GetText(), aKernArray,
sal_Int32(rInf.GetIdx()), sal_Int32(rInf.GetLen()));
tools::Long nAvgWidthPerChar = aKernArray[sal_Int32(rInf.GetLen())
- 1] / sal_Int32(rInf.GetLen());
@@ -2277,7 +2277,7 @@ TextFrameIndex SwFont::GetTextBreak(SwDrawTextInfo const
& rInf, tools::Long nTe
const tools::Long nGridWidthAdd = EvalGridWidthAdd( pGrid, rInf );
std::vector aKernArray;
-rInf.GetOut().GetTextArray( rInf.GetText(), ,
+GetTextArray( rInf.GetOut(), rInf.GetText(), aKernArray,
sal_Int32(rInf.GetIdx()), sal_Int32(rInf.GetLen()));
tools::Long nCurrPos = aKernArray[sal_Int32(nTextBreak)] +
nGridWidthAdd;
while (++nTextBreak < rInf.GetLen() && nTextWidth >= nCurrPos)
@@ -2394,7 +2394,7 @@ TextFrameIndex SwFont::GetTextBreak(SwDrawTextInfo const
& rInf, tools::Long nTe
else if (nLn > nTextBreak2 + nTextBreak2)
nLn = nTextBreak2 + nTextBreak2;
std::vector aKernArray;
-rInf.GetOut().GetTextArray( rInf.GetText(), ,
+GetTextArray( rInf.GetOut(), rInf.GetText(), aKernArray,
sal_Int32(rInf.GetIdx()), sal_Int32(nLn));
if( rInf.GetScriptInfo()->Compress( aKernArray.data(), rInf.GetIdx(),
nLn,
rInf.GetKanaComp(),
o3tl::narrowing(GetHeight( m_nActual )),
commit
[Libreoffice-bugs] [Bug 148429] Link external data doesn't work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=148429 raal changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected OS|macOS (All) |All CC||michael.st...@allotropia.de ||, r...@post.cz --- Comment #2 from raal --- This seems to have begun at the below commit. Adding Cc: to Michael Stahl; Could you possibly take a look at this one? Thanks 115b11fc60754321653e4f44d88d1b033163c3da is the first bad commit commit 115b11fc60754321653e4f44d88d1b033163c3da Author: Jenkins Build User Date: Tue Nov 23 20:19:31 2021 +0100 source sha:bdef11f5337ecc87556a92693f6b7b5e200eb29e https://git.libreoffice.org/core/+/bdef11f5337ecc87556a92693f6b7b5e200eb29e configure: default to --with-webdav=curl -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/cib_contract138c' - 2 commits - include/vcl vcl/inc vcl/source
include/vcl/graph.hxx|7 +--
include/vcl/vectorgraphicdata.hxx|1 +
vcl/inc/impgraph.hxx |2 ++
vcl/source/gdi/bitmapex.cxx | 18 +++---
vcl/source/gdi/impgraph.cxx | 27 +++
vcl/source/gdi/vectorgraphicdata.cxx |6 ++
6 files changed, 32 insertions(+), 29 deletions(-)
New commits:
commit 4d75bb89c60590b3dc7fb441960e75a57fda3ab2
Author: Noel Grandin
AuthorDate: Mon May 20 19:08:19 2019 +0200
Commit: Michael Stahl
CommitDate: Fri Apr 8 22:30:59 2022 +0200
tdf#120837 File saving at least 5 times slower
The problem here is that we never actually hit the maExportGraphics
cache in SvXMLGraphicHelper, even though we are passing the same image
down repeatedly.
There are two bugs here:
(1) BitmapEx::operator== does not return true if we instantiate 2
Graphic objects from the same XGraphic, so change it to use the more
expensive operator==. To mitigate the cost, move the expensive checks to
the bottom of the method.
(2) in order to use an object in std::unordered_map, the object must
implement an equality function and a hash function. If two objects are
equal THEY MUST have the same hash value. Using the Impl* as the hash
value does not satisfy that condition, so rather use the checksum, which
does.
After these fixes, the save time drops to less than a second.
Also make the checksum method look more like the operator== method,
and add a checksum calculation method for SVG data that more accurately
reflects the underlying SVG data.
Change-Id: I4ca0c7bee60b2efa6fe42301e582c7b278022b46
Reviewed-on: https://gerrit.libreoffice.org/72615
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 319c57d2af5d26d3910db4b02dca145d8881af44)
diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx
index 3b91a3269478..8b42ca0cc3d7 100644
--- a/include/vcl/graph.hxx
+++ b/include/vcl/graph.hxx
@@ -197,11 +197,6 @@ public:
BitmapChecksum GetChecksum() const;
-SAL_DLLPRIVATE std::size_t getHash() const
-{
-return reinterpret_cast(ImplGetImpGraphic());
-}
-
OUString getOriginURL() const;
void setOriginURL(OUString const & rOriginURL);
@@ -249,7 +244,7 @@ struct hash
{
std::size_t operator()(Graphic const & rGraphic) const
{
-return rGraphic.getHash();
+return static_cast(rGraphic.GetChecksum());
}
};
diff --git a/include/vcl/vectorgraphicdata.hxx
b/include/vcl/vectorgraphicdata.hxx
index ea7615d2bdf6..159dc7afe286 100644
--- a/include/vcl/vectorgraphicdata.hxx
+++ b/include/vcl/vectorgraphicdata.hxx
@@ -103,6 +103,7 @@ public:
const basegfx::B2DRange& getRange() const;
const std::deque< css::uno::Reference< css::graphic::XPrimitive2D > >&
getPrimitive2DSequence() const;
const BitmapEx& getReplacement() const;
+BitmapChecksum GetChecksum() const;
};
typedef std::shared_ptr< VectorGraphicData > VectorGraphicDataPtr;
diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx
index 30c88594c5d6..133ed2d0de46 100644
--- a/vcl/inc/impgraph.hxx
+++ b/vcl/inc/impgraph.hxx
@@ -83,6 +83,8 @@ private:
bool mbSwapOut;
bool mbDummyContext;
VectorGraphicDataPtr maVectorGraphicData;
+// cache checksum computation
+mutable BitmapChecksum mnChecksum = 0;
/// The PDF stream from which this Graphic is rendered,
/// as converted (version downgraded) from the original,
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index ccf70a6c4dca..15a176924aec 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -181,9 +181,6 @@ bool BitmapEx::operator==( const BitmapEx& rBitmapEx ) const
if (meTransparent != rBitmapEx.meTransparent)
return false;
-if (!maBitmap.ShallowEquals(rBitmapEx.maBitmap))
-return false;
-
if (GetSizePixel() != rBitmapEx.GetSizePixel())
return false;
@@ -197,7 +194,10 @@ bool BitmapEx::operator==( const BitmapEx& rBitmapEx )
const
if (mbAlpha != rBitmapEx.mbAlpha)
return false;
-return maMask.ShallowEquals(rBitmapEx.maMask);
+if (maBitmap != rBitmapEx.maBitmap)
+return false;
+
+return maMask == rBitmapEx.maMask;
}
bool BitmapEx::IsEmpty() const
diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index 9b6bf0da8d77..825f6b56b852 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -1671,6 +1671,9 @@ bool ImpGraphic::ImplIsLink() const
BitmapChecksum ImpGraphic::ImplGetChecksum() const
{
+if (mnChecksum != 0)
+return mnChecksum;
+
BitmapChecksum nRet = 0;
ensureAvailable();
@@ -1684,25 +1687,16 @@ BitmapChecksum ImpGraphic::ImplGetChecksum() const
case
[Libreoffice-bugs] [Bug 148474] Want to not see ToC entries in fields listing
https://bugs.documentfoundation.org/show_bug.cgi?id=148474 --- Comment #1 from Eyal Rozenberg --- Oh, yeah, and this goes double seeing how ToC entries also appear as hyperlinks :-( ... see bug 148312. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148474] Want to not see ToC entries in fields listing
https://bugs.documentfoundation.org/show_bug.cgi?id=148474 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8312 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148312] Navigator should not show ToC entries as hyperlinks, at all
https://bugs.documentfoundation.org/show_bug.cgi?id=148312 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8474 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Eyal Rozenberg changed: What|Removed |Added Depends on||148474 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148474 [Bug 148474] Want to not see ToC entries in fields listing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148474] New: Want to not see ToC entries in fields listing
https://bugs.documentfoundation.org/show_bug.cgi?id=148474 Bug ID: 148474 Summary: Want to not see ToC entries in fields listing Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 103030 My field listing is filled with dozens, or hundreds, of entries for the items in the ToC - as though they were cross-reference fields I had inserted. I don't want that! In fact, I very much doubt any user wants to have entry-level navigator visibility into the ToC, as opposed to the entire ToC being a single thing you've entered. So, I suggest generated intra-ToC/Index entries not show up as individual items in the Navigator. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103030 [Bug 103030] [META] Navigator sidebar deck and floating window -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148473] Use field type for subtreeing in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=148473 --- Comment #1 from Eyal Rozenberg --- Created attachment 179418 --> https://bugs.documentfoundation.org/attachment.cgi?id=179418=edit A typical Navigator view of some fields -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Eyal Rozenberg changed: What|Removed |Added Depends on||148473 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148473 [Bug 148473] Use field type for subtreeing in Navigator -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148473] New: Use field type for subtreeing in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=148473 Bug ID: 148473 Summary: Use field type for subtreeing in Navigator Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 103030 Currently, all (?) fields are presented in Navigator directly under the Fields root, with the field code/name and arguments serialized into a string. For example: * Fields | + - * cross-reference - __RefHeading__Toc415784771 - יב + - * cross-reference - __RefHeading__Toc4157846681 - 2 and so on; see attachment. This is not useful. In this bug, I suggest one way of improving this state of affairs: Use the field type to form subtrees. Fields are already effectively grouped by field type because of how the serialization works, so why not save the repetitions and just make the field types into subtrees? Even without touching anything else, that would already allow the Navigator to fit more field info in, and be easier on the eyes. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103030 [Bug 103030] [META] Navigator sidebar deck and floating window -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148422] Assertion failed: (rSData.empty() || rSData[0].m_bRedlineMoved || (rSData[0].m_nRedlineCount == rDoc.getIDocumentRedlineAccess().GetRedlineTable().size())), function Se
https://bugs.documentfoundation.org/show_bug.cgi?id=148422 Telesto changed: What|Removed |Added CC||michael.st...@allotropia.de --- Comment #5 from Telesto --- @Michael There are still couple of rough edges (asserts) around redlining.. At this point I found three.. this one, bug 148419 and bug 148461 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148419] Assertion failed: (false), function newFromSubString, file strtmpl.hxx, line 981
https://bugs.documentfoundation.org/show_bug.cgi?id=148419 Telesto changed: What|Removed |Added CC||nem...@numbertext.org --- Comment #4 from Telesto --- @László You might take an interest in this one.. tables + track changes.. and it can crash on non-debug builds. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148125] "Insert > Gallery" in Tabbed user interface doesn't do anything
https://bugs.documentfoundation.org/show_bug.cgi?id=148125 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. I confirm what Aron found, reverting the patch makes this bug disappear. I maded other tests and the pb is in framework part. Before the quoted commit aCommandURL ".uno:Gallery" after, it's ".uno:Sidebar.GalleryDeck" git grep -n 'uno:Sidebar.GalleryDeck' officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu:5469: .uno:Sidebar.GalleryDeck git grep -n '.uno:Gallery' officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu:5458: sc/uiconfig/scalc/menubar/menubar.xml:183: sc/uiconfig/scalc/menubar/menubar.xml:213: ... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148122] Celtic MD font appears wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=148122 Julien Nabet changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148122] Celtic MD font appears wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=148122 Julien Nabet changed: What|Removed |Added CC||caol...@redhat.com, ||serval2...@yahoo.fr --- Comment #5 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. (downloaded font from https://www.dafont.com/fr/celtic-md.font) I also notice that you scroll down, then up several times (but sometimes once is enough), it's ok. Caolán: any thoughts here? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148458] If Calc finds an error in a formula, and users decide *not* to autocorrect, Calc may chop out parts of the formula.
https://bugs.documentfoundation.org/show_bug.cgi?id=148458 Julien Nabet changed: What|Removed |Added Summary|If Calc finds an error in a |If Calc finds an error in a |formmula, and users decide |formula, and users decide |*not* to autocorrect, Calc |*not* to autocorrect, Calc |may chop out parts of the |may chop out parts of the |formula.|formula. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - editeng/source include/editeng include/vcl sc/source svx/source sw/source vcl/inc vcl/source
editeng/source/editeng/impedit.hxx |3
editeng/source/editeng/impedit2.cxx |2
editeng/source/editeng/impedit3.cxx | 28 +++---
editeng/source/items/svxfont.cxx| 27 ++---
include/editeng/svxfont.hxx | 10 --
include/vcl/glyphitemcache.hxx | 10 +-
include/vcl/outdev.hxx |3
sc/source/ui/view/output2.cxx |5 -
svx/source/inc/StylesPreviewWindow.hxx |2
svx/source/tbxctrls/StylesPreviewWindow.cxx |3
sw/source/core/docnode/ndtbl.cxx|1
sw/source/core/inc/fntcache.hxx | 45 +
sw/source/core/layout/layact.cxx|3
sw/source/core/txtnode/fntcache.cxx | 130 +++-
vcl/inc/pdf/pdfwriter_impl.hxx |3
vcl/source/gdi/impglyphitem.cxx | 20 +++-
vcl/source/gdi/pdfwriter_impl.cxx | 10 +-
vcl/source/outdev/text.cxx |5 -
18 files changed, 89 insertions(+), 221 deletions(-)
New commits:
commit de45c09a3b48e8ab3ac995ea72681ec265c24123
Author: Luboš Luňák
AuthorDate: Thu Apr 7 17:42:30 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 8 21:29:33 2022 +0200
add SalLayoutGlyphs* parameter to OutputDevice::GetTextBreak()
Change-Id: I278e485e03cf27bc57724233453a672569dfd53f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132682
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index e1f85ad16fc7..d244638e5127 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1074,7 +1074,8 @@ public:
sal_Unicode nExtraChar,
sal_Int32& rExtraCharPos,
sal_Int32 nIndex, sal_Int32 nLen,
tools::Long nCharExtra,
- vcl::text::TextLayoutCache
const* = nullptr) const;
+ vcl::text::TextLayoutCache
const* = nullptr,
+ const SalLayoutGlyphs* pGlyphs =
nullptr) const;
static std::shared_ptr
CreateTextLayoutCache(OUString const&);
protected:
diff --git a/sw/source/core/txtnode/fntcache.cxx
b/sw/source/core/txtnode/fntcache.cxx
index 0176332889d7..39e23613e669 100644
--- a/sw/source/core/txtnode/fntcache.cxx
+++ b/sw/source/core/txtnode/fntcache.cxx
@@ -2340,11 +2340,13 @@ TextFrameIndex SwFont::GetTextBreak(SwDrawTextInfo
const & rInf, tools::Long nTe
if( rInf.GetHyphPos() ) {
sal_Int32 nHyphPos = sal_Int32(*rInf.GetHyphPos());
+const SalLayoutGlyphs* pGlyphs =
SalLayoutGlyphsCache::self()->GetLayoutGlyphs(
+(), *pTmpText, nTmpIdx.get(), nTmpLen.get(), 0,
rInf.GetVclCache());
nTextBreak = TextFrameIndex(rInf.GetOut().GetTextBreak(
*pTmpText, nTextWidth,
u'-', nHyphPos,
sal_Int32(nTmpIdx), sal_Int32(nTmpLen),
- nKern, rInf.GetVclCache()));
+ nKern, rInf.GetVclCache(), pGlyphs));
*rInf.GetHyphPos() = TextFrameIndex((nHyphPos == -1) ?
COMPLETE_STRING : nHyphPos);
}
else
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 8ac3cc379073..14e3aed21a97 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -1508,12 +1508,13 @@ sal_Int32 OutputDevice::GetTextBreak( const OUString&
rStr, tools::Long nTextWid
sal_Unicode nHyphenChar, sal_Int32&
rHyphenPos,
sal_Int32 nIndex, sal_Int32 nLen,
tools::Long nCharExtra,
- vcl::text::TextLayoutCache const*const pLayoutCache) const
+ vcl::text::TextLayoutCache const*const pLayoutCache,
+ const SalLayoutGlyphs* pGlyphs) const
{
rHyphenPos = -1;
std::unique_ptr pSalLayout = ImplLayout( rStr, nIndex, nLen,
-Point(0,0), 0, {}, eDefaultLayout, pLayoutCache);
+Point(0,0), 0, {}, eDefaultLayout, pLayoutCache, pGlyphs);
sal_Int32 nRetVal = -1;
if( pSalLayout )
{
commit 3e5863605881c6de6ad130fe06883c176ca1c69f
Author: Luboš Luňák
AuthorDate: Thu Apr 7 12:06:27 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 8 21:29:19 2022 +0200
use just one shared global SalLayoutGlyphsCache
Now the cache should be capable of detecting what needs
to stay the same for having the same result, so it should
be enough to have just one cache that can reuse results
even between callers from different places.
Change-Id: Ibdc0303f5b727d1a1d7be91d61db9465ed95e1c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132673
Tested-by:
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/glyphitemcache.hxx|9 +++--
vcl/source/gdi/impglyphitem.cxx | 17 ++---
vcl/source/gdi/pdfwriter_impl.cxx |6 +++---
3 files changed, 12 insertions(+), 20 deletions(-)
New commits:
commit 53fe4a26c7c4691fcf9d07d022adfd45247d176b
Author: Luboš Luňák
AuthorDate: Thu Apr 7 12:25:09 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 8 21:28:58 2022 +0200
ignore Point logicalPos argument in SalLayoutGlyphsCache
It's only used for the DXArray argument in ImplLayout(), so if we
ignore that one when caching, the position can be ignored too.
Change-Id: Id2a7b452e2b75139177c1e73c48eaa466742a59c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132672
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/include/vcl/glyphitemcache.hxx b/include/vcl/glyphitemcache.hxx
index 64a1a64186ee..fca8e9f12575 100644
--- a/include/vcl/glyphitemcache.hxx
+++ b/include/vcl/glyphitemcache.hxx
@@ -48,13 +48,11 @@ public:
GetLayoutGlyphs(VclPtr outputDevice, const OUString&
text,
const vcl::text::TextLayoutCache* layoutCache = nullptr)
const
{
-return GetLayoutGlyphs(outputDevice, text, 0, text.getLength(),
Point(0, 0), 0,
- layoutCache);
+return GetLayoutGlyphs(outputDevice, text, 0, text.getLength(), 0,
layoutCache);
}
const SalLayoutGlyphs*
GetLayoutGlyphs(VclPtr outputDevice, const OUString&
text, sal_Int32 nIndex,
-sal_Int32 nLen, const Point& rLogicPos = Point(0, 0),
-tools::Long nLogicWidth = 0,
+sal_Int32 nLen, tools::Long nLogicWidth = 0,
const vcl::text::TextLayoutCache* layoutCache = nullptr)
const;
void clear() { mCachedGlyphs.clear(); }
@@ -64,7 +62,6 @@ private:
OUString text;
sal_Int32 index;
sal_Int32 len;
-Point logicPos;
tools::Long logicWidth;
VclPtr outputDevice;
vcl::Font font;
@@ -73,7 +70,7 @@ private:
LanguageType digitLanguage;
size_t hashValue;
CachedGlyphsKey(const VclPtr& dev, const OUString&
t, sal_Int32 i,
-sal_Int32 l, const Point& p, tools::Long w);
+sal_Int32 l, tools::Long w);
bool operator==(const CachedGlyphsKey& other) const;
};
struct CachedGlyphsHash
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index ea3c490b0ba2..01654cfddcbc 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -97,13 +97,12 @@ bool SalLayoutGlyphsImpl::IsValid() const
const SalLayoutGlyphs*
SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr outputDevice,
const OUString& text,
- sal_Int32 nIndex, sal_Int32 nLen, const
Point& rLogicPos,
- tools::Long nLogicWidth,
+ sal_Int32 nIndex, sal_Int32 nLen,
tools::Long nLogicWidth,
const vcl::text::TextLayoutCache*
layoutCache) const
{
if (nLen == 0)
return nullptr;
-const CachedGlyphsKey key(outputDevice, text, nIndex, nLen, rLogicPos,
nLogicWidth);
+const CachedGlyphsKey key(outputDevice, text, nIndex, nLen, nLogicWidth);
auto it = mCachedGlyphs.find(key);
if (it != mCachedGlyphs.end())
{
@@ -121,7 +120,7 @@ SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr outputDevice, c
layoutCache = tmpLayoutCache.get();
}
std::unique_ptr layout
-= outputDevice->ImplLayout(text, nIndex, nLen, rLogicPos, nLogicWidth,
{},
+= outputDevice->ImplLayout(text, nIndex, nLen, Point(0, 0),
nLogicWidth, {},
SalLayoutFlags::GlyphItemsOnly,
layoutCache);
if (layout)
{
@@ -134,11 +133,10 @@ SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr outputDevice, c
SalLayoutGlyphsCache::CachedGlyphsKey::CachedGlyphsKey(const VclPtr& d,
const OUString& t,
sal_Int32 i, sal_Int32 l,
- const Point& p,
tools::Long w)
+ tools::Long w)
: text(t)
, index(i)
, len(l)
-, logicPos(p)
, logicWidth(w)
, outputDevice(d)
// we also need to save things used in
OutputDevice::ImplPrepareLayoutArgs(), in case they
@@ -154,8 +152,6 @@
SalLayoutGlyphsCache::CachedGlyphsKey::CachedGlyphsKey(const VclPtr pLayout = ImplLayout( rText, nIndex, nLen, rPos,
0, {}, SalLayoutFlags::NONE, nullptr, layoutGlyphs );
if( pLayout )
@@ -6516,7 +6516,7 @@ void PDFWriterImpl::drawTextArray( const Point& rPos,
const OUString& rText, o3t
// get a layout from the OutputDevice's SalGraphics
// this also enforces font substitution and sets the font on SalGraphics
-
[Libreoffice-bugs] [Bug 148459] Spreadsheet selection misbehaves after element selected from cell data-validity dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=148459 --- Comment #2 from giger.jonat...@gmail.com --- Version: 7.2.6.2 (x64) / LibreOffice Community Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148419] Assertion failed: (false), function newFromSubString, file strtmpl.hxx, line 981
https://bugs.documentfoundation.org/show_bug.cgi?id=148419 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148419] Assertion failed: (false), function newFromSubString, file strtmpl.hxx, line 981
https://bugs.documentfoundation.org/show_bug.cgi?id=148419 --- Comment #3 from Julien Nabet --- Created attachment 179417 --> https://bugs.documentfoundation.org/attachment.cgi?id=179417=edit gdb bt Here's a bt from assertion + gdb console retrieved on pc Debian x86-64 with master sources updated today -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148459] Spreadsheet selection misbehaves after element selected from cell data-validity dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=148459 giger.jonat...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from giger.jonat...@gmail.com --- I can confirm this happens on my build. Note that the contents of the cell are not changing, the problem is just that a different cell gets selected. Also, the menu buttons are not "clicked" the first time they are clicked on, as in, they do not react. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/inc vcl/source
include/vcl/glyphitemcache.hxx|6 +-
vcl/inc/pdf/pdfwriter_impl.hxx|3 +++
vcl/source/gdi/impglyphitem.cxx | 35 +--
vcl/source/gdi/pdfwriter_impl.cxx | 12 ++--
4 files changed, 39 insertions(+), 17 deletions(-)
New commits:
commit 9ed2912d4ecfd9573b3ca9d2390a0f1b0e3060a2
Author: Luboš Luňák
AuthorDate: Thu Apr 7 12:07:02 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 8 21:28:44 2022 +0200
check better for unchanged OutputDevice in SalLayoutGlyphsCache
Some things like font could change, so it needs to be saved and compared.
If would be even better to avoid comparing OutputDevice pointers
and instead compare only what actually matters, in order to reuse
the same glyphs used for different output devices, but I can't
find all the relevant data in OutputDevice.
Change-Id: Ib8634165b5b312d1db2c9fc28f8d7fdf7b552d25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132671
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/include/vcl/glyphitemcache.hxx b/include/vcl/glyphitemcache.hxx
index 83c77309a632..64a1a64186ee 100644
--- a/include/vcl/glyphitemcache.hxx
+++ b/include/vcl/glyphitemcache.hxx
@@ -61,12 +61,16 @@ public:
private:
struct CachedGlyphsKey
{
-VclPtr outputDevice;
OUString text;
sal_Int32 index;
sal_Int32 len;
Point logicPos;
tools::Long logicWidth;
+VclPtr outputDevice;
+vcl::Font font;
+bool rtl;
+vcl::text::ComplexTextLayoutFlags layoutMode;
+LanguageType digitLanguage;
size_t hashValue;
CachedGlyphsKey(const VclPtr& dev, const OUString&
t, sal_Int32 i,
sal_Int32 l, const Point& p, tools::Long w);
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index d320d27dad88..ea3c490b0ba2 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -135,32 +135,47 @@ SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr outputDevice, c
SalLayoutGlyphsCache::CachedGlyphsKey::CachedGlyphsKey(const VclPtr& d,
const OUString& t,
sal_Int32 i, sal_Int32 l,
const Point& p,
tools::Long w)
-: outputDevice(d)
-, text(t)
+: text(t)
, index(i)
, len(l)
, logicPos(p)
, logicWidth(w)
+, outputDevice(d)
+// we also need to save things used in
OutputDevice::ImplPrepareLayoutArgs(), in case they
+// change in the output device
+// TODO there is still something missing, otherwise it wouldn't be
necessary to compare
+// also the OutputDevice pointers
+, font(outputDevice->GetFont())
+, rtl(outputDevice->IsRTLEnabled())
+, layoutMode(outputDevice->GetLayoutMode())
+, digitLanguage(outputDevice->GetDigitLanguage())
{
hashValue = 0;
-o3tl::hash_combine(hashValue, outputDevice.get());
-SvMemoryStream stream;
-WriteFont(stream, outputDevice->GetFont());
-o3tl::hash_combine(hashValue, static_cast(stream.GetData()),
stream.GetSize());
o3tl::hash_combine(hashValue, vcl::text::FirstCharsStringHash()(text));
o3tl::hash_combine(hashValue, index);
o3tl::hash_combine(hashValue, len);
o3tl::hash_combine(hashValue, logicPos.X());
o3tl::hash_combine(hashValue, logicPos.Y());
o3tl::hash_combine(hashValue, logicWidth);
+
+o3tl::hash_combine(hashValue, outputDevice.get());
+SvMemoryStream stream;
+WriteFont(stream, font);
+o3tl::hash_combine(hashValue, static_cast(stream.GetData()),
stream.GetSize());
+o3tl::hash_combine(hashValue, rtl);
+o3tl::hash_combine(hashValue, layoutMode);
+o3tl::hash_combine(hashValue, digitLanguage.get());
}
inline bool SalLayoutGlyphsCache::CachedGlyphsKey::operator==(const
CachedGlyphsKey& other) const
{
-return hashValue == other.hashValue && outputDevice == other.outputDevice
- && index == other.index && len == other.len && logicPos ==
other.logicPos
- && logicWidth == other.logicWidth
- && vcl::text::FastStringCompareEqual()(text, other.text);
+return hashValue == other.hashValue && index == other.index && len ==
other.len
+ && logicPos == other.logicPos && logicWidth == other.logicWidth
+ && outputDevice == other.outputDevice && rtl == other.rtl
+ && layoutMode == other.layoutMode
+ && digitLanguage == other.digitLanguage
+ // slower things here
+ && font == other.font && vcl::text::FastStringCompareEqual()(text,
other.text);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 376a9792c32a51c91079a54a0cf190acd58485af
Author: Luboš Luňák
AuthorDate: Wed Apr 6 19:29:06 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 8 21:28:29 2022 +0200
use SalLayoutGlyphsCache in PDFWriterImpl
[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/inc vcl/source
include/vcl/glyphitemcache.hxx | 17 ++---
vcl/inc/TextLayoutCache.hxx| 32
vcl/source/gdi/CommonSalLayout.cxx | 30 +-
vcl/source/gdi/impglyphitem.cxx| 20 +++-
4 files changed, 58 insertions(+), 41 deletions(-)
New commits:
commit 94c2fb28d76c9c37849412a66b31d6861bce3155
Author: Luboš Luňák
AuthorDate: Wed Apr 6 19:28:07 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 8 21:28:15 2022 +0200
faster hashing of very long strings in SalLayoutGlyphsCache
tdf#147284 being a (pathological) testcase.
Change-Id: I08d8dffb40193b461555bed818c040761e8d575b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132669
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/vcl/inc/TextLayoutCache.hxx b/vcl/inc/TextLayoutCache.hxx
index 0ce0c19d8278..ecb85ea7043d 100644
--- a/vcl/inc/TextLayoutCache.hxx
+++ b/vcl/inc/TextLayoutCache.hxx
@@ -20,6 +20,8 @@
#pragma once
#include
+#include
+#include
#include
@@ -48,6 +50,36 @@ public:
std::vector runs;
TextLayoutCache(sal_Unicode const* pStr, sal_Int32 const nEnd);
};
+
+struct FirstCharsStringHash
+{
+size_t operator()(const OUString& str) const
+{
+// Strings passed to GenericSalLayout::CreateTextLayoutCache() may be
very long,
+// and computing an entire hash could almost negate the gain of
hashing. Hash just first
+// characters, that should be good enough.
+size_t hash
+= rtl_ustr_hashCode_WithLength(str.getStr(), std::min(100,
str.getLength()));
+o3tl::hash_combine(hash, str.getLength());
+return hash;
+}
+};
+
+struct FastStringCompareEqual
+{
+bool operator()(const OUString& str1, const OUString& str2) const
+{
+// Strings passed to GenericSalLayout::CreateTextLayoutCache() may be
very long,
+// and OUString operator == compares backwards and using hard-written
code, while
+// memcmp() compares much faster.
+if (str1.getLength() != str2.getLength())
+return false;
+if (str1.getStr() == str2.getStr())
+return true;
+return memcmp(str1.getStr(), str2.getStr(), str1.getLength() *
sizeof(str1.getStr()[0]))
+ == 0;
+}
+};
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index 8dee28727997..2c8a4db8398f 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -154,40 +154,12 @@ namespace {
return VerticalOrientation(nRet);
}
-struct FirstCharsStringHash
-{
-size_t operator()( const OUString& str ) const
-{
-// Strings passed to GenericSalLayout::CreateTextLayoutCache() may be
very long,
-// and computing an entire hash could almost negate the gain of
hashing. Hash just first
-// characters, that should be good enough.
-size_t hash = rtl_ustr_hashCode_WithLength( str.getStr(),
std::min( 100, str.getLength()));
-o3tl::hash_combine(hash, str.getLength());
-return hash;
-}
-};
-
-struct ForwardStringCompareEqual
-{
-bool operator()( const OUString& str1, const OUString& str2 ) const
-{
-// Strings passed to GenericSalLayout::CreateTextLayoutCache() may be
very long,
-// and OUString operator == compares backwards, which is inefficient
for very long
-// strings (bad memory prefetch).
-if( str1.getLength() != str2.getLength())
-return false;
-if( str1.getStr() == str2.getStr())
-return true;
-return memcmp( str1.getStr(), str2.getStr(), str1.getLength() *
sizeof( str1.getStr()[ 0 ] )) == 0;
-}
-};
-
} // namespace
std::shared_ptr
GenericSalLayout::CreateTextLayoutCache(OUString const& rString)
{
typedef o3tl::lru_map,
-FirstCharsStringHash, ForwardStringCompareEqual> Cache;
+vcl::text::FirstCharsStringHash, vcl::text::FastStringCompareEqual>
Cache;
static vcl::DeleteOnDeinit< Cache > cache( 1000 );
if( Cache* map = cache.get())
{
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index eaf8cf5c8453..d320d27dad88 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -21,6 +21,7 @@
#include
#include
#include
+#include
SalLayoutGlyphs::SalLayoutGlyphs() {}
@@ -146,7 +147,7 @@
SalLayoutGlyphsCache::CachedGlyphsKey::CachedGlyphsKey(const VclPtrGetFont());
o3tl::hash_combine(hashValue, static_cast(stream.GetData()),
stream.GetSize());
-o3tl::hash_combine(hashValue, text);
+o3tl::hash_combine(hashValue, vcl::text::FirstCharsStringHash()(text));
o3tl::hash_combine(hashValue, index);
o3tl::hash_combine(hashValue, len);
o3tl::hash_combine(hashValue,
[Libreoffice-bugs] [Bug 148425] Connectors not being previewed correctly when adjusting their position
https://bugs.documentfoundation.org/show_bug.cgi?id=148425 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Rafael Lima --- Setting it to NEW based on Comment 2. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148425] Connectors not being previewed correctly when adjusting their position
https://bugs.documentfoundation.org/show_bug.cgi?id=148425 --- Comment #2 from giger.jonat...@gmail.com --- I can confirm this also happens on 7.2.6.2 on Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/uiwriter6.cxx | 14 ++ 1 file changed, 14 insertions(+) New commits: commit ea3f08b91d70587400011e7a34fd9df259542e85 Author: Xisco Fauli AuthorDate: Thu Apr 7 17:31:56 2022 +0200 Commit: Xisco Fauli CommitDate: Fri Apr 8 21:06:37 2022 +0200 tdf#83037: sw_uiwriter6: Add unittest Change-Id: I42a2b697e1b3efd719c0f45474420c9367300776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132680 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sw/qa/extras/uiwriter/uiwriter6.cxx b/sw/qa/extras/uiwriter/uiwriter6.cxx index 6386c3f07fc6..50819388e96c 100644 --- a/sw/qa/extras/uiwriter/uiwriter6.cxx +++ b/sw/qa/extras/uiwriter/uiwriter6.cxx @@ -1591,6 +1591,20 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest6, testTdf133524) sReplaced += u" → "; // This was "–>" instead of "→" CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString()); + +// tdf#83037 +emulateTyping(*pXTextDocument, u"-> "); +sReplaced += u"→ "; +CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString()); +emulateTyping(*pXTextDocument, u"<- "); +sReplaced += u"← "; +CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString()); +emulateTyping(*pXTextDocument, u"<-- "); +sReplaced += u"← "; +CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString()); +emulateTyping(*pXTextDocument, u"<--> "); +sReplaced += u"↔ "; +CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString()); } CPPUNIT_TEST_FIXTURE(SwUiWriterTest6, testTdf133524_Romanian)
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/uiwriter.cxx | 109 ---
sw/qa/extras/uiwriter/uiwriter6.cxx | 126 +++-
sw/qa/extras/uiwriter/uiwriter7.cxx | 16
3 files changed, 124 insertions(+), 127 deletions(-)
New commits:
commit 2ed743de88da7ef70eb63fed925a7cf29980c01a
Author: Xisco Fauli
AuthorDate: Thu Apr 7 16:48:39 2022 +0200
Commit: Xisco Fauli
CommitDate: Fri Apr 8 21:06:20 2022 +0200
sw_uiwriter: put autocorrect tests together
Change-Id: I06e720b6fccab298a866eb05403ca98152ab4c8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132679
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx
b/sw/qa/extras/uiwriter/uiwriter.cxx
index d6e13827213b..b4b7a9eac36d 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -1045,115 +1045,6 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testFdo85554)
CPPUNIT_ASSERT_EQUAL(2, getShapes());
}
-CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testAutoCorr)
-{
-SwDoc* pDoc = createSwDoc();
-SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
-SwAutoCorrect corr(*SvxAutoCorrCfg::Get().GetAutoCorrect());
-const sal_Unicode cIns = ' ';
-
-//Normal AutoCorrect
-pWrtShell->Insert("tset");
-pWrtShell->AutoCorrect(corr, cIns);
-SwNodeOffset nIndex = pWrtShell->GetCursor()->GetNode().GetIndex();
-CPPUNIT_ASSERT_EQUAL(OUString("Test "),
static_cast(pDoc->GetNodes()[nIndex])->GetText());
-
-//AutoCorrect with change style to bolt
-pWrtShell->Insert("Bolt");
-pWrtShell->AutoCorrect(corr, cIns);
-const uno::Reference< text::XTextRange > xRun = getRun(getParagraph(1), 2);
-CPPUNIT_ASSERT_EQUAL(OUString("Bolt"), xRun->getString());
-CPPUNIT_ASSERT_EQUAL(OUString("Arial"), getProperty(xRun,
"CharFontName"));
-
-//AutoCorrect inserts Table with 2 rows and 3 columns
-pWrtShell->Insert("4xx");
-pWrtShell->AutoCorrect(corr, cIns);
-const uno::Reference< text::XTextTable > xTable(getParagraphOrTable(2),
uno::UNO_QUERY);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable->getRows()->getCount());
-CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xTable->getColumns()->getCount());
-}
-
-CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testTdf83260)
-{
-SwDoc* const pDoc(createSwDoc(DATA_DIRECTORY, "tdf83260-1.odt"));
-SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
-SwAutoCorrect corr(*SvxAutoCorrCfg::Get().GetAutoCorrect());
-
-// enabled but not shown
-CPPUNIT_ASSERT(pWrtShell->GetLayout()->IsHideRedlines());
-#if 0
-CPPUNIT_ASSERT(IDocumentRedlineAccess::IsHideChanges(
-pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
-#endif
-CPPUNIT_ASSERT(IDocumentRedlineAccess::IsRedlineOn(
-pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
-
CPPUNIT_ASSERT(!pDoc->getIDocumentRedlineAccess().GetRedlineTable().empty());
-
-// the document contains redlines that are combined with CompressRedlines()
-// if that happens during AutoCorrect then indexes in Undo are off -> crash
-pWrtShell->Insert("tset");
-pWrtShell->AutoCorrect(corr, u' ');
-sw::UndoManager& rUndoManager = pDoc->GetUndoManager();
-auto const nActions(rUndoManager.GetUndoActionCount());
-for (auto i = nActions; 0 < i; --i)
-{
-rUndoManager.Undo();
-}
-// check that every text node has a layout frame
-for (SwNodeOffset i(0); i < pDoc->GetNodes().Count(); ++i)
-{
-if (SwTextNode const*const pNode = pDoc->GetNodes()[i]->GetTextNode())
-{
-CPPUNIT_ASSERT(pNode->getLayoutFrame(nullptr, nullptr, nullptr));
-}
-}
-for (auto i = nActions; 0 < i; --i)
-{
-rUndoManager.Redo();
-}
-for (SwNodeOffset i(0); i < pDoc->GetNodes().Count(); ++i)
-{
-if (SwTextNode const*const pNode = pDoc->GetNodes()[i]->GetTextNode())
-{
-CPPUNIT_ASSERT(pNode->getLayoutFrame(nullptr, nullptr, nullptr));
-}
-}
-for (auto i = nActions; 0 < i; --i)
-{
-rUndoManager.Undo();
-}
-for (SwNodeOffset i(0); i < pDoc->GetNodes().Count(); ++i)
-{
-if (SwTextNode const*const pNode = pDoc->GetNodes()[i]->GetTextNode())
-{
-CPPUNIT_ASSERT(pNode->getLayoutFrame(nullptr, nullptr, nullptr));
-}
-}
-}
-
-CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testTdf130274)
-{
-SwDoc *const pDoc(createSwDoc());
-SwWrtShell *const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
-SwAutoCorrect corr(*SvxAutoCorrCfg::Get().GetAutoCorrect());
-
-CPPUNIT_ASSERT(!pWrtShell->GetLayout()->IsHideRedlines());
-CPPUNIT_ASSERT(!IDocumentRedlineAccess::IsRedlineOn(
-pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
-
-// "tset" may be replaced by the AutoCorrect in the test profile
-pWrtShell->Insert("tset");
-// select from left to right
-
[Libreoffice-bugs] [Bug 148471] Spreadsheet dont show the value if the cell have comments and conditional formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=148471 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Please attach a sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: basic/source chart2/source connectivity/source editeng/source filter/source framework/source include/comphelper include/o3tl oox/source sc/source sdext/source sd/source
basic/source/runtime/dllmgr-x64.cxx|3 basic/source/runtime/dllmgr-x86.cxx|3 chart2/source/tools/InternalDataProvider.cxx | 16 +- chart2/source/tools/PropertyHelper.cxx |2 chart2/source/tools/XMLRangeHelper.cxx |4 connectivity/source/drivers/dbase/DTable.cxx |7 - connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx |5 connectivity/source/drivers/odbc/ODatabaseMetaData.cxx |6 - editeng/source/misc/svxacorr.cxx |4 filter/source/msfilter/util.cxx|4 filter/source/xsltdialog/xmlfiltersettingsdialog.cxx |4 framework/source/fwe/helper/actiontriggerhelper.cxx|4 include/comphelper/string.hxx | 58 -- include/o3tl/string_view.hxx | 26 oox/source/docprop/docprophandler.cxx | 18 +-- oox/source/drawingml/customshapepresetdata.cxx |6 - oox/source/drawingml/customshapeproperties.cxx |4 oox/source/drawingml/hyperlinkcontext.cxx |4 oox/source/helper/attributelist.cxx| 14 +- oox/source/ole/axcontrol.cxx |6 - oox/source/ppt/pptshape.cxx|6 - oox/source/ppt/presentationfragmenthandler.cxx |8 - oox/source/vml/vmldrawing.cxx |4 oox/source/vml/vmlformatting.cxx |8 - oox/source/vml/vmlshape.cxx|8 - oox/source/vml/vmlshapecontext.cxx |4 sc/source/core/data/global2.cxx|8 - sc/source/core/data/table4.cxx |5 sc/source/filter/oox/formulaparser.cxx |6 - sc/source/filter/oox/pagesettings.cxx |6 - sc/source/filter/oox/sheetdatacontext.cxx |6 - sc/source/ui/docshell/impex.cxx| 12 +- sc/source/ui/miscdlgs/acredlin.cxx |4 sd/source/filter/xml/sdxmlwrp.cxx |6 - sd/source/ui/presenter/PresenterTextView.cxx |6 - sdext/source/pdfimport/wrapper/wrapper.cxx |6 - sfx2/source/appl/appopen.cxx |3 sfx2/source/appl/childwin.cxx |7 - sfx2/source/bastyp/mieclip.cxx |9 - sfx2/source/doc/docfile.cxx|3 sfx2/source/doc/sfxbasemodel.cxx |3 svl/source/numbers/zformat.cxx |4 svx/source/xoutdev/xattr.cxx |4 sw/source/core/doc/doclay.cxx |4 sw/source/core/doc/docnum.cxx |3 sw/source/core/doc/doctxm.cxx |4 sw/source/core/docnode/ndsect.cxx |4 sw/source/core/fields/cellfml.cxx |3 sw/source/core/unocore/XMLRangeHelper.cxx |4 sw/source/core/unocore/unotbl.cxx |3 sw/source/filter/ascii/wrtasc.cxx |4 sw/source/filter/html/htmlatr.cxx |4 sw/source/filter/ww8/wrtww8gr.cxx |4 sw/source/ui/vba/vbaparagraphformat.cxx|4 sw/source/uibase/app/docsh2.cxx|2 sw/source/uibase/fldui/fldmgr.cxx |5 sw/source/uibase/misc/redlndlg.cxx |4 sw/source/uibase/uiview/view2.cxx |5 sw/source/uibase/utlui/unotools.cxx|2 ucbhelper/source/client/proxydecider.cxx |6 - unotools/source/config/dynamicmenuoptions.cxx |4 vbahelper/source/vbahelper/vbalineformat.cxx |2 vcl/source/control/field2.cxx |9 - vcl/source/pdf/PDFiumLibrary.cxx | 14 +- vcl/unx/generic/printer/jobdata.cxx| 12 +- vcl/unx/generic/printer/ppdparser.cxx |7 - writerfilter/source/dmapper/ConversionHelper.cxx |6 - writerfilter/source/dmapper/DomainMapper_Impl.cxx |6 - writerfilter/source/rtftok/rtfdocumentimpl.cxx
[Libreoffice-bugs] [Bug 148472] Render of Bold Italic Strikeout font differs with MS Word for specific docx file (with null values)
https://bugs.documentfoundation.org/show_bug.cgi?id=148472 --- Comment #1 from Pavel Lobashov --- Created attachment 179416 --> https://bugs.documentfoundation.org/attachment.cgi?id=179416=edit screenshot -- You are receiving this mail because: You are the assignee for the bug.
