[Libreoffice-commits] core.git: vcl/qa

[Stanislav Lopatin (via logerrit)]

 vcl/qa/cppunit/ScanlineToolsTest.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 815851d1cbc427bbd85da1638f3b121b253d0926
Author: Stanislav Lopatin 
AuthorDate: Sun Aug 7 20:47:56 2022 +0500
Commit: Mike Kaganski 
CommitDate: Tue Aug 9 07:51:26 2022 +0200

tdf#145538 Change common loops to range based in ScanlineToolsTest.cxx

Just convert some loops to range based and fix strange loop logic
at 216 line.

Upd: rename *iterators* as Mike Kaganski adviced

Change-Id: Idf33b65f9c4466aa49c8f3bc13a12ad072dce7b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137929
Reviewed-by: Mike Kaganski 
Tested-by: Jenkins

diff --git a/vcl/qa/cppunit/ScanlineToolsTest.cxx 
b/vcl/qa/cppunit/ScanlineToolsTest.cxx
index c6751b827ca1..8b8a9088a1ea 100644
--- a/vcl/qa/cppunit/ScanlineToolsTest.cxx
+++ b/vcl/qa/cppunit/ScanlineToolsTest.cxx
@@ -122,10 +122,10 @@ void ScanlineToolsTest::ScanlineTransformer_8bit_Palette()
 
 pScanlineTransformer->startLine(aScanLine.data());
 
-for (size_t i = 0; i < aColors.size(); ++i)
+for (Color const& rColor : aColors)
 {
 Color aColor = pScanlineTransformer->readPixel();
-CPPUNIT_ASSERT_EQUAL(aColors[i], aColor);
+CPPUNIT_ASSERT_EQUAL(rColor, aColor);
 }
 }
 
@@ -162,10 +162,10 @@ void ScanlineToolsTest::ScanlineTransformer_4bit_Palette()
 
 pScanlineTransformer->startLine(aScanLine.data());
 
-for (size_t i = 0; i < aColors.size(); ++i)
+for (Color const& rColor : aColors)
 {
 Color aColor = pScanlineTransformer->readPixel();
-CPPUNIT_ASSERT_EQUAL(aColors[i], aColor);
+CPPUNIT_ASSERT_EQUAL(rColor, aColor);
 }
 }
 
@@ -213,10 +213,10 @@ void ScanlineToolsTest::ScanlineTransformer_1bit_Palette()
 Color(110, 150, 70),
 };
 
-for (size_t i = 0; i < aColors.size(); ++i)
+for (Color const& rColor : aColorsExpected)
 {
 Color aColor = pScanlineTransformer->readPixel();
-CPPUNIT_ASSERT_EQUAL(aColorsExpected[i], aColor);
+CPPUNIT_ASSERT_EQUAL(rColor, aColor);
 }
 }
 

[Libreoffice-bugs] [Bug 145538] Use range based for loops

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145538

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0 target:7.4.0   |target:7.3.0 target:7.4.0
   |reviewed:2022   |reviewed:2022 target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145538] Use range based for loops

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145538

--- Comment #9 from Commit Notification 
 ---
Stanislav Lopatin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/815851d1cbc427bbd85da1638f3b121b253d0926

tdf#145538 Change common loops to range based in ScanlineToolsTest.cxx

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135540] TABLEIMPORT CALC: Format of the header of a table is copied while importing data to the content of all rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135540

--- Comment #5 from Robert Großkopf  ---
Still the same buggy behavior in LO 7.4.0.2 on OpenSUSE 15-3 64bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147911] F1 (Help) for all context menu items for templates in Template Manager have no links to relevant help page entries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147911

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150130] Form Controls: Form navigator right click menu incorrect in some situations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150130

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150128] Form Controls: numeric field not redrawn when right aligned and field width is changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150128

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150264] FORMATTING: UI improvements to add automatic data validation of dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150264

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 150264] FORMATTING: UI improvements to add automatic data validation of dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150264

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146415] Allow Basic + "Extended" Dictionaries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146415

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150264] FORMATTING: UI improvements to add automatic data validation of dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150264

--- Comment #13 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146415] Allow Basic + "Extended" Dictionaries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146415

--- Comment #3 from QA Administrators  ---
Dear CP,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147153] Calc freezes and crash if manually selecting of thousands of lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147153

--- Comment #8 from QA Administrators  ---
Dear Martin Reichel,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150264] FORMATTING: UI improvements to add automatic data validation of dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150264

--- Comment #13 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 146824] si chiude subito

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146824

--- Comment #2 from QA Administrators  ---
Dear g1wqr2,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147102] CRASH Deleting bookmark from Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147102

--- Comment #5 from QA Administrators  ---
Dear Gabor Kelemen (allotropia),

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118678] Subtotals results moved left when saving in ODS format (steps in comment 12)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118678

--- Comment #23 from QA Administrators  ---
Dear Marcelo,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140693] Print Dialog showing wrong page layout.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140693

--- Comment #6 from QA Administrators  ---
Dear avdzm,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135540] TABLEIMPORT CALC: Format of the header of a table is copied while importing data to the content of all rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135540

--- Comment #4 from QA Administrators  ---
Dear Robert Großkopf,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108497] Convert OpenType variable font (OTVF) instances before printing and exporting to PDF or EPUB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108497

--- Comment #31 from Volga  ---
(In reply to Volga from comment #29)
> HarfBuzz will get the implementation, so I think we can waiting for new
> release for fix.
It's landed as of 5.1.0 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150239] Selecting whole column to copy data, by accident, freeze - how to hard limit numbers of rows when running calc?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150239

--- Comment #3 from elias estatistics  ---
ps. i need large spreadsheats in many cases. 
It is a problem to get these on/off... but this does not solve the problem
either way as you will read

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150306] New: Conversion from conditional formatting to regular or static formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150306

Bug ID: 150306
   Summary: Conversion from conditional formatting to regular or
static formatting
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mgb1...@gmail.com

Description:
It would be great if there was a way to convert, for a selection of cells,
conditional formatting to static or regular formatting. A kind of special
paste.

It would be like the equivalent of "Paste values" to remove the formulas and
leave only the results (fixed values), but for the formatting. That is, the
formatting will no longer depend on any condition/formula but will be fixed and
can be edited/copied to other cells.

I suppose this should be possible using macros, but this is not within the
reach of most users.

Once I wanted to use one of the colors derived from a conditional formatting,
color scale, let's say, one of the intermediate colors of the whole range of
greens created and I could not find a way to do it.

Steps to Reproduce:
Select a range of cells that have conditional formatting and convert the
formatting of that selection to static formatting.

Actual Results:
There is no simple way to do this.

Expected Results:
There is a tool that does the desired conversion.


Reproducible: Always


User Profile Reset: No



Additional Info:
For Excel, there is an extension that does exactly this, see here:
https://www.asap-utilities.com/asap-utilities-excel-tools-tip.php?tip=276=117=en_us

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150239] Selecting whole column to copy data, by accident, freeze - how to hard limit numbers of rows when running calc?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150239

elias estatistics  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #2 from elias estatistics  ---
Sorry, my incovenience

Steps to reproduce 


1. Copy a single digit or number.
2. Select A1 cell to paste it with ctr+v
3. Cause u are super mutlitasking and fast person, instead of selecting a1
cell,
u select by error whole column A, and before stop your self you pressed cntr+V.
--No big problem. U will wait some minutes in a not so fast machine to copy eg.
"1" into 2 million rows. 
4. BUT if u have selected to paste complicated formulas with Index+match type
or 1000 string characters... and u select column A instead of cell A1, then i
think the PC of most users cannot anticipate that.
5. It hangs. 

It is one of the most reasons that my PC hangs in linux. 

Propositions: 
---To be able to stop any calculation in the fly ( a stop button somewhere?) 
---Best: Libreoffice (calc) to self-limit itself based on the free resources of
system of every given time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150267] FILEOPEN DOCX RTF Unused document variable not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150267

Thorsten Behrens (allotropia)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||t...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150269] FILEOPEN RTF Single line breaks hidden property not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150269

Thorsten Behrens (allotropia)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||t...@libreoffice.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 79542] FORMCONTROLS: .xls - Option buttons contained in group boxes are not grouped.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79542

Justin L  changed:

   What|Removed |Added

 Depends on||120177

--- Comment #16 from Justin L  ---
I have something that kindof works. However, to do this well probably depends
on bug 120177 being fixed first.

The proper way to import this (seeing that LO doesn't have a working GroupBox
concept itself) is to group the buttons after all controls have been loaded. My
failed attempt to do that is at http://gerrit.libreoffice.org/c/core/+/137838

An alternative method (that works for this particular bug doc) only works if
the group-box controls are always defined prior to their contents. Perhaps that
is always true - I don't know. That version is at
http://gerrit.libreoffice.org/c/core/+/137839


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120177
[Bug 120177] FILEOPEN XLS: Radio button Form controls no longer grouped
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120177] FILEOPEN XLS: Radio button Form controls no longer grouped

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120177

Justin L  changed:

   What|Removed |Added

 Blocks||79542


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=79542
[Bug 79542] FORMCONTROLS: .xls - Option buttons contained in group boxes are
not grouped.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/source

[Miklos Vajna (via logerrit)]

 vcl/source/filter/ipdf/pdfread.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 8e5886ad0993a360f24a83de9bc2645271e92185
Author: Miklos Vajna 
AuthorDate: Mon Aug 1 09:31:48 2022 +0200
Commit: Xisco Fauli 
CommitDate: Mon Aug 8 23:16:29 2022 +0200

vcl: fix crash in vcl::ImportPDFUnloaded()

Crashreport signature:

SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x0
program/libmergedlo.so
vcl::ImportPDFUnloaded(rtl::OUString const&, 
std::vector >&)
vcl/source/filter/ipdf/pdfread.cxx:256
program/../program/libsdlo.so
SdPdfFilter::Import()
sd/source/filter/pdf/sdpdffilter.cxx:55
program/../program/libsdlo.so
sd::DrawDocShell::ConvertFrom(SfxMedium&)
sd/source/ui/docshell/docshel4.cxx:500 (discriminator 1)
program/libmergedlo.so
SfxObjectShell::DoLoad(SfxMedium*)
sfx2/source/doc/objstor.cxx:768

Change-Id: I2fc635de696643af6a80a29aa5af4fa128f8776c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137673
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 60f9ca81e84f1bede4928c6f680325692cc8bc49)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137965
Reviewed-by: Xisco Fauli 
(cherry picked from commit f37998fdc3044ce8d477c2cfb0b9219d5f8ba75d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137969

diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index a69d10c7cafc..90d195acf752 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -252,6 +252,11 @@ std::vector
 findAnnotations(const std::unique_ptr& pPage, 
basegfx::B2DSize aPageSize)
 {
 std::vector aPDFGraphicAnnotations;
+if (!pPage)
+{
+return aPDFGraphicAnnotations;
+}
+
 for (int nAnnotation = 0; nAnnotation < pPage->getAnnotationCount(); 
nAnnotation++)
 {
 auto pAnnotation = pPage->getAnnotation(nAnnotation);

[Libreoffice-bugs] [Bug 147911] F1 (Help) for all context menu items for templates in Template Manager have no links to relevant help page entries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147911

Olivier Hallot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Olivier Hallot  ---
The F1 key is inactive in this context menu. 

Need to look at the XML of the right context menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148646] Analysis functions taking XPropertySet argument need explicit documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148646

Olivier Hallot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150302] Toggle SameLetterHeights does not work if property not initialized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150302

Hossein  changed:

   What|Removed |Added

   Keywords||difficultyMedium, easyHack
 Whiteboard||reviewed:2022

--- Comment #3 from Hossein  ---
(In reply to Regina Henschel from comment #1)
> The error is in case SID_FONTWORK_SAME_LETTER_HEIGHTS in impl_execute method
> in
> https://opengrok.libreoffice.org/xref/core/svx/source/toolbars/fontworkbar.
> cxx?r=4c0b033e#242
> The else part is missing.
> Since the icon has a .uno command, a unit test is possible using the
> dispatcher.
> 
> @Hossein: I think, this can be an EasyHack. Do you agree?

Yes! And thanks for suggesting this issue for an EasyHack.

I've tested your code pointer, and the fix is straightforward. On the other
hand, I think it should be marked as difficultyMedium, because one needs to
gain a basic understanding of ODF and the draw:text-path-same-letter-heights
attribute and change it manually inside  to see its
effect, then fix the code and write a test similar to some of those in
sd/qa/unit/uiimpress.cxx.

This is the related part of the ODF 1.3 standard for the above attribute:

Open Document Format for Office Applications (OpenDocument) Version 1.3. Part
3: OpenDocument Schema
OASIS Standard - 27 April 2021
19.224 draw:text-path-same-letter-heights
https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1417288_253892949

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134588] Page image should be centered in over-wide window, not shifted right

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134588

--- Comment #7 from Galuxttor  ---
(In reply to Galuxttor from comment #5)
> Confirmed in 7.4 beta 1
> but
> the trigger are not sidebars/toolbars/page pane/property pane
> 
> The trigger is the horizontal scrollbar "touching"" the left limit. Not so
> good in English, so I've attached "2022-08-08-screenshots.jpg" with
> explanation

If left side doesn't "reach the end" then there is no autocenter and the page
is only partially showed (again, doesn't matter if you are resizing left or
right side of the window)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149895] Help for sending Email

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149895

Olivier Hallot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134588] Page image should be centered in over-wide window, not shifted right

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134588

--- Comment #6 from Galuxttor  ---
Created attachment 181656
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181656=edit
Screenshots with explanation inside to trigger the "event"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134588] Page image should be centered in over-wide window, not shifted right

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134588

--- Comment #5 from Galuxttor  ---
Confirmed in 7.4 beta 1
but
the trigger are not sidebars/toolbars/page pane/property pane

The trigger is the horizontal scrollbar "touching"" the left limit. Not so good
in English, so I've attached "2022-08-08-screenshots.jpg" with explanation

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150302] Toggle SameLetterHeights does not work if property not initialized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150302

Hossein  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Hossein  ---
Reproduced with the latest LO 7.5 dev master:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: cc3e2e7efa35dea85eecdd163de1ca1e71ce01f7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - svx/uiconfig

[Caolán McNamara (via logerrit)]

 svx/uiconfig/ui/rulermenu.ui |   59 +--
 1 file changed, 35 insertions(+), 24 deletions(-)

New commits:
commit 3905d44dd11b5722b7d5019e8705b1fbef48de9e
Author: Caolán McNamara 
AuthorDate: Mon Aug 8 16:16:15 2022 +0100
Commit: Caolán McNamara 
CommitDate: Mon Aug 8 22:24:37 2022 +0200

gtk4: set draw-as-radio explicitly on

Change-Id: I546abe771a6c6d1029258ac702713e34353b8e00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137992
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/uiconfig/ui/rulermenu.ui b/svx/uiconfig/ui/rulermenu.ui
index 6f9f024f59fe..ae7dc1f9364e 100644
--- a/svx/uiconfig/ui/rulermenu.ui
+++ b/svx/uiconfig/ui/rulermenu.ui
@@ -11,6 +11,7 @@
 False
 Millimeter
 True
+True
   
 
 
@@ -19,6 +20,7 @@
 False
 Centimeter
 True
+True
   
 
 
@@ -27,6 +29,7 @@
 False
 Meter
 True
+True
   
 
 
@@ -35,6 +38,7 @@
 False
 Kilometer
 True
+True
   
 
 
@@ -43,6 +47,7 @@
 False
 Inch
 True
+True
   
 
 
@@ -51,6 +56,7 @@
 False
 Foot
 True
+True
   
 
 
@@ -59,6 +65,7 @@
 False
 Miles
 True
+True
   
 
 
@@ -67,6 +74,7 @@
 False
 Point
 True
+True
   
 
 
@@ -75,6 +83,7 @@
 False
 Pica
 True
+True
   
 
 
@@ -83,6 +92,7 @@
 False
 Char
 True
+True
   
 
 
@@ -91,6 +101,7 @@
 False
 Line
 True
+True
   
 
   
commit 3fa9af03d409a6137c174618e0376c3c78aec60b
Author: Caolán McNamara 
AuthorDate: Mon Aug 8 16:11:46 2022 +0100
Commit: Caolán McNamara 
CommitDate: Mon Aug 8 22:24:24 2022 +0200

resave with latest glade

Change-Id: I0c217736e9c4a0eea5315f32a1562d76a6ce84f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137991
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/uiconfig/ui/rulermenu.ui b/svx/uiconfig/ui/rulermenu.ui
index 68f7c0592696..6f9f024f59fe 100644
--- a/svx/uiconfig/ui/rulermenu.ui
+++ b/svx/uiconfig/ui/rulermenu.ui
@@ -1,96 +1,96 @@
 
-
+
 
   
   
 True
-False
+False
 
   
 True
-False
+False
 Millimeter
-True
+True
   
 
 
   
 True
-False
+False
 Centimeter
-True
+True
   
 
 
   
 True
-False
+False
 Meter
-True
+True
   
 
 
   
 True
-False
+False
 Kilometer
-True
+True
   
 
 
   
 True
-False
+False
 Inch
-True
+True
   
 
 
   
 True
-False
+False
 Foot
-True
+True
   
 
 
   
 True
-False
+False
 Miles
-True
+True
   
 
 
   
 True
-False
+False
 Point
-True
+True
   
 
 
   
 True
-False
+False
 Pica
-True
+True
   
 
 
   
 True
-False
+False
 Char
-True
+True
   
 
 
   
 True
-False
+False
 Line
-True
+True
   
 
   

[Libreoffice-bugs] [Bug 149638] F1 (Help) on Table toolbar for Impress / Draw does not open help page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149638

Olivier Hallot  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Olivier Hallot  ---
I looked at this issue. It seems the toolbars are not set to launch a help
page.

The only toolbar that has a HelpId is the findbar. But the findbar is wrapped
in a .ui dialog that sends the right HelpId. See

https://opengrok.libreoffice.org/xref/help/source/text/shared/find_toolbar.xhp?r=8a560f13

Line 23 is the good one, line 24 is useless and can be removed.

It will require a new ticket to implement a helpid for the toolbars.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120201
Bug 120201 depends on bug 149638, which changed state.

Bug 149638 Summary: F1 (Help) on Table toolbar for Impress / Draw does not open 
help page
https://bugs.documentfoundation.org/show_bug.cgi?id=149638

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133299] Option to set the default anchor mode for images in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133299

Samuel Mehrbrodt (allotropia)  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |thierryalem...@gmail.com
   |desktop.org |

--- Comment #9 from Samuel Mehrbrodt (allotropia) 
 ---
(In reply to Thierry E from comment #8)
> Created attachment 176843 [details]
> patch to anchor to cell pasted image in Calc
> 
> The attached proposed patch for LibreOffice Calc 7.4 (dev version) anchors
> pasted image to Cell instead of default to Page.
> Tested on xubuntu 20.04 including saving and reopening the .ods file, and
> also tested on xubuntu 20.04 that this saved file can be opened in
> LibreOffice Calc 7.2.3.2 and the image is correctly shown as anchored to
> Cell in that version too.

Hi Thierry,
thanks a lot for your patch! And sorry it took so long.

I uploaded your patch to Gerrit and made sure it works (it does):
https://gerrit.libreoffice.org/c/core/+/138005

Before merging, we need your license statement as described here:
https://wiki.documentfoundation.org/Development/Developers#License_Statements

Can you please send that statement? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120201
Bug 120201 depends on bug 149318, which changed state.

Bug 149318 Summary: (F1) Help for Format > Table (in Draw) has no help page 
linked to it, as well as "Minimal Row Height" and "Minimal Column Width" in its 
submenu
https://bugs.documentfoundation.org/show_bug.cgi?id=149318

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149318] (F1) Help for Format > Table (in Draw) has no help page linked to it, as well as "Minimal Row Height" and "Minimal Column Width" in its submenu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149318

Olivier Hallot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/source

[Xisco Fauli (via logerrit)]

 sd/source/ui/func/fuzoom.cxx |   12 
 1 file changed, 8 insertions(+), 4 deletions(-)

New commits:
commit 729c29f3bef16ea85fd8ce7aa32a010a204589ad
Author: Xisco Fauli 
AuthorDate: Mon Aug 8 16:24:29 2022 +0200
Commit: Xisco Fauli 
CommitDate: Mon Aug 8 21:58:46 2022 +0200

sd: avoid divide by zero in FuZoom::MouseMove

See 
https://crashreport.libreoffice.org/stats/signature/sd::FuZoom::MouseMove(MouseEvent%20const%20&)

Change-Id: I3b07def2ba088a92e2358e7db57c27c047165cef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137988
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sd/source/ui/func/fuzoom.cxx b/sd/source/ui/func/fuzoom.cxx
index aa5395267183..871d594d3368 100644
--- a/sd/source/ui/func/fuzoom.cxx
+++ b/sd/source/ui/func/fuzoom.cxx
@@ -117,10 +117,14 @@ bool FuZoom::MouseMove(const MouseEvent& rMEvt)
 {
 Size aWorkSize = mpView->GetWorkArea().GetSize();
 Size aPageSize = 
mpView->GetSdrPageView()->GetPage()->GetSize();
-aScroll.setX( aScroll.X() / ( aWorkSize.Width()  / 
aPageSize.Width()) );
-aScroll.setY( aScroll.Y() / ( aWorkSize.Height() / 
aPageSize.Height()) );
-mpViewShell->Scroll(aScroll.X(), aScroll.Y());
-aBeginPosPix = aPosPix;
+if (aWorkSize.Width() != 0 && aWorkSize.Height() != 0 &&
+aPageSize.Width() != 0 && aPageSize.Height() != 0)
+{
+aScroll.setX( aScroll.X() / ( aWorkSize.Width()  / 
aPageSize.Width()) );
+aScroll.setY( aScroll.Y() / ( aWorkSize.Height() / 
aPageSize.Height()) );
+mpViewShell->Scroll(aScroll.X(), aScroll.Y());
+aBeginPosPix = aPosPix;
+}
 }
 }
 else

[Libreoffice-bugs] [Bug 150162] Trying to download a sample document from Fourier Analysis online help page fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150162

Olivier Hallot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 139469, which changed state.

Bug 139469 Summary: [LOCALHELP] fontwork help page needs review
https://bugs.documentfoundation.org/show_bug.cgi?id=139469

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139469] [LOCALHELP] fontwork help page needs review

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139469

Olivier Hallot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150303] Double click in Calc doesn't enter cell edit mode in kf5/qt5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150303

--- Comment #3 from Timur  ---
Thanks. I forgot to search commit after bibisect. 
And I trusted wrong to duplicate search in bug report form.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 80658, which changed state.

Bug 80658 Summary: LOCALHELP: write help page for Calc Stream
https://bugs.documentfoundation.org/show_bug.cgi?id=80658

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80658] LOCALHELP: write help page for Calc Stream

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80658

Olivier Hallot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120200] [META] Update or correct help for features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120200
Bug 120200 depends on bug 91344, which changed state.

Bug 91344 Summary: help for Writer "View" menu is not updated
https://bugs.documentfoundation.org/show_bug.cgi?id=91344

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 92825] [META] Update help for all menu changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92825
Bug 92825 depends on bug 91344, which changed state.

Bug 91344 Summary: help for Writer "View" menu is not updated
https://bugs.documentfoundation.org/show_bug.cgi?id=91344

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91344] help for Writer "View" menu is not updated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91344

Olivier Hallot  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 87473] EDITING: "Manage names..." fully functional after sheet is protected.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87473

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 87473] EDITING: "Manage names..." fully functional after sheet is protected.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87473

Eike Rathke  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEW |RESOLVED

--- Comment #6 from Eike Rathke  ---
Protect Sheet is not supposed to prevent all sort of possible document
modifications. It protects *cells* from modifications (unless cells are marked
to not be protected).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108912] [META] Sheet-level bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108912
Bug 108912 depends on bug 87473, which changed state.

Bug 87473 Summary: EDITING: "Manage names..." fully functional after sheet is 
protected.
https://bugs.documentfoundation.org/show_bug.cgi?id=87473

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/source

[Jim Raykowski (via logerrit)]

 sd/source/ui/dlg/sdtreelb.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 469414e66f2b55c06439aaf062aa6dae66ef3096
Author: Jim Raykowski 
AuthorDate: Sat Aug 6 20:47:13 2022 -0800
Commit: Jim Raykowski 
CommitDate: Mon Aug 8 21:40:08 2022 +0200

tdf#138868 follow up: fix selected entry not unselected

For Gtk3, setting the Navigator tree view cursor -1 doesn't unselect
the selected entry which is what is wanted when the canvas selected
object is not in the Navigator tree view.

Change-Id: I879e8dc09870b91d42eadb6b42d9236c1a1cf40c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137916
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index 1b49eccb6cc3..cd50e97c2682 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -1207,7 +1207,10 @@ bool SdPageObjsTLV::SelectEntry(const SdrObject *pObj)
 }
 }
 if (!bFound)
+{
+m_xTreeView->unselect_all();
 m_xTreeView->set_cursor(-1);
+}
 return bFound;
 }
 

[Libreoffice-bugs] [Bug 138868] UI: object selected on canvas is not indicated in Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138868

--- Comment #11 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/469414e66f2b55c06439aaf062aa6dae66ef3096

tdf#138868 follow up: fix selected entry not unselected

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146786] File > Close icon missing, X exits the program (not in Safe mode but yes with profile reset)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146786

Timur  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #17 from Timur  ---
So we need confirmation from other users of they have the problem in LO 7.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 93371] Calc mixes up languages for formula names if UI language is german

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93371

Eike Rathke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5993

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 93371] Calc mixes up languages for formula names if UI language is german

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93371

--- Comment #7 from Eike Rathke  ---
The mix of English and German (of AddIn functions) names in the UI with
"English function names" was solved for bug 135993.

The problem of storing those Date AddIn names in German if a German UI is used
isn't satisfiable solvable for binary .xls 97-2003 (unless we implement some
workarounds and handle functions individually) because Excel itself stored the
Analysis pack functions language dependent depending on the localized UI of
Excel (you might also notice that not all stored German function names are
identical to the German UI names, like UMWANDELN vs UMRECHNEN (English
CONVERT)), but those old versions apparently did not know a few date functions
that are offered as Date AddIn functions by LibreOffice.

There is only one proper remedy: do not save as .xls in such constellation
(German UI and Date AddIn functions used). Save as the more up-to-date OOXML
.xlsx Excel 2007-365 file format instead and everything is fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/reducevarscope.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cc3e2e7efa35dea85eecdd163de1ca1e71ce01f7
Author: Stephan Bergmann 
AuthorDate: Mon Aug 8 15:35:11 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Aug 8 21:04:30 2022 +0200

Adapt to changed clang::LambdaCapture::getCapturedVar return type

...where


"[Clang][C++20] Support capturing structured bindings in lambdas" on Clang 
16
trunk changed the return type from VarDecl to ValueDecl, causing

> compilerplugins/clang/reducevarscope.cxx:541:26: error: no matching 
member function for call to 'erase'
> maVarDeclMap.erase(varDecl);
> ~^
> 
/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:740:7:
 note: candidate function not viable: no known conversion from 'ValueDecl *' to 
'const_iterator' (aka '_Node_const_iterator, 
__constant_iterators::value, __hash_cached::value>') for 1st argument
>   erase(const_iterator __position)
>   ^
> 
/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:745:7:
 note: candidate function not viable: no known conversion from 'ValueDecl *' to 
'iterator' (aka '_Node_iterator, __constant_iterators::value, 
__hash_cached::value>') for 1st argument
>   erase(iterator __position)
>   ^
> 
/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:762:7:
 note: candidate function not viable: cannot convert from base class pointer 
'ValueDecl *' to derived class pointer 'const key_type' (aka 'const 
clang::VarDecl *const') for 1st argument
>   erase(const key_type& __x)
>   ^
> 
/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:780:7:
 note: candidate function not viable: requires 2 arguments, but 1 was provided
>   erase(const_iterator __first, const_iterator __last)
>   ^

etc.

Change-Id: I79b062ca604435bc83a58eeb32df673e6c658bd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137984
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/reducevarscope.cxx 
b/compilerplugins/clang/reducevarscope.cxx
index be7254a2d569..76eece2131bb 100644
--- a/compilerplugins/clang/reducevarscope.cxx
+++ b/compilerplugins/clang/reducevarscope.cxx
@@ -537,7 +537,7 @@ bool ReduceVarScope::VisitLambdaExpr(const LambdaExpr* 
lambdaExpr)
 const LambdaCapture& capture = *captureIt;
 if (capture.capturesVariable())
 {
-auto varDecl = capture.getCapturedVar();
+auto varDecl = cast(capture.getCapturedVar());
 maVarDeclMap.erase(varDecl);
 maVarUseSourceRangeMap.erase(varDecl);
 }

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/compat.hxx  |   19 +++
 compilerplugins/clang/pointerbool.cxx |2 +-
 2 files changed, 20 insertions(+), 1 deletion(-)

New commits:
commit fb992aefc8345a9be780c6928e4380da7c56904e
Author: Stephan Bergmann 
AuthorDate: Mon Aug 8 14:09:42 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Aug 8 21:04:10 2022 +0200

Adapt to changes in llvm::Optional



"[ADT] Add has_value, value, value_or to llvm::Optional" is in Clang 15, and


"[ADT] Deprecate Optional::{hasValue,getValue} (NFC)" is in Clang 16 trunk,
causing

> In file included from 
compilerplugins/clang/sharedvisitor/sharedvisitor.cxx:95:
> compilerplugins/clang/pointerbool.cxx:118:21: error: 'hasValue' is 
deprecated: Use has_value instead. [-Werror,-Wdeprecated-declarations]
> if (ret.hasValue() && (ret.getValue() == 1 || ret.getValue() 
== 0))
> ^
> ~/llvm/inst/include/llvm/ADT/Optional.h:324:5: note: 'hasValue' has been 
explicitly marked deprecated here
>   [[deprecated("Use has_value instead.")]] constexpr bool hasValue() 
const {
> ^

etc.

Change-Id: I377effe29fc6752484d2870b9a0fd66fddc26bfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137982
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index 1a6266ec5201..625e43220206 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -16,6 +16,7 @@
 #include "clang/AST/ExprCXX.h"
 #include "clang/Basic/SourceManager.h"
 #include "clang/Basic/Specifiers.h"
+#include "llvm/ADT/Optional.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/Support/FileSystem.h"
 
@@ -24,6 +25,24 @@
 // Compatibility wrapper to abstract over (trivial) changes in the Clang API:
 namespace compat {
 
+template
+constexpr bool has_value(llvm::Optional const & o) {
+#if CLANG_VERSION >= 15
+return o.has_value();
+#else
+return o.hasValue();
+#endif
+}
+
+template
+constexpr T const & value(llvm::Optional const & o) {
+#if CLANG_VERSION >= 15
+return o.value();
+#else
+return o.getValue();
+#endif
+}
+
 inline std::string toString(llvm::APSInt const & i, unsigned radix) {
 #if CLANG_VERSION >= 13
 return llvm::toString(i, radix);
diff --git a/compilerplugins/clang/pointerbool.cxx 
b/compilerplugins/clang/pointerbool.cxx
index 3bc87e743e98..9e6f3068358e 100644
--- a/compilerplugins/clang/pointerbool.cxx
+++ b/compilerplugins/clang/pointerbool.cxx
@@ -115,7 +115,7 @@ bool PointerBool::VisitCallExpr(CallExpr const* callExpr)
 if (arg->getType()->isIntegerType())
 {
 auto ret = getCallValue(arg);
-if (ret.hasValue() && (ret.getValue() == 1 || ret.getValue() == 0))
+if (compat::has_value(ret) && (compat::value(ret) == 1 || 
compat::value(ret) == 0))
 continue;
 // something like: priv->m_nLOKFeatures & 
LOK_FEATURE_DOCUMENT_PASSWORD
 if (isa(arg->IgnoreParenImpCasts()))

[Libreoffice-bugs] [Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112581
Bug 112581 depends on bug 138531, which changed state.

Bug 138531 Summary: Dynamic Data Exchange is not operable
https://bugs.documentfoundation.org/show_bug.cgi?id=138531

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138531] Dynamic Data Exchange is not operable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138531

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #14 from Julien Nabet  ---
Since 7.2 branch is EOL, I suppose we can consider this one as FIXED.

Don't hesitate to reopen this tracker if I'm wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

[Noel Grandin (via logerrit)]

 sw/inc/redline.hxx  |9 +--
 sw/qa/core/uwriter.cxx  |2 
 sw/source/core/doc/docredln.cxx |   62 
 sw/source/core/undo/undobj.cxx  |4 -
 sw/source/core/unocore/unoredline.cxx   |   10 +--
 sw/source/filter/xml/XMLRedlineImportHelper.cxx |2 
 6 files changed, 46 insertions(+), 43 deletions(-)

New commits:
commit 00f3bbc84634a9f07c046140d84445303585817c
Author: Noel Grandin 
AuthorDate: Sun Aug 7 20:37:56 2022 +0200
Commit: Noel Grandin 
CommitDate: Mon Aug 8 21:00:59 2022 +0200

unique_ptr->optional in SwRangeRedline

Change-Id: I4d4c55eef6e6b56634766bc57f11539ece9dc20d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137940
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/redline.hxx b/sw/inc/redline.hxx
index c8123f178c22..1ad8c456b56c 100644
--- a/sw/inc/redline.hxx
+++ b/sw/inc/redline.hxx
@@ -156,7 +156,7 @@ public:
 class SW_DLLPUBLIC SwRangeRedline final : public SwPaM
 {
 SwRedlineData* m_pRedlineData;
-SwNodeIndex* m_pContentSect;
+std::optional m_oContentSect;
 std::optional m_oLOKLastNodeTop;
 sal_uInt32 m_nId;
 bool m_bDelLastPara : 1;
@@ -176,7 +176,7 @@ public:
 // For sw3io: pData is taken over!
 SwRangeRedline(SwRedlineData* pData, const SwPosition& rPos,
bool bDelLP) :
-SwPaM( rPos ), m_pRedlineData( pData ), m_pContentSect( nullptr ),
+SwPaM( rPos ), m_pRedlineData( pData ),
 m_nId( s_nLastId++ ), m_bDelLastPara( bDelLP ), m_bIsVisible( true )
 {
 GetBound().SetRedline(this);
@@ -186,9 +186,10 @@ public:
 virtual ~SwRangeRedline() override;
 
 sal_uInt32 GetId() const { return m_nId; }
-SwNodeIndex* GetContentIdx() const { return m_pContentSect; }
+const SwNodeIndex* GetContentIdx() const { return m_oContentSect ? 
&*m_oContentSect : nullptr; }
 // For Undo.
-void SetContentIdx( const SwNodeIndex* );
+void SetContentIdx( const SwNodeIndex& );
+void ClearContentIdx();
 
 bool IsVisible() const { return m_bIsVisible; }
 bool IsDelLastPara() const { return m_bDelLastPara; }
diff --git a/sw/qa/core/uwriter.cxx b/sw/qa/core/uwriter.cxx
index 7cd0b38ec2ae..79545969c457 100644
--- a/sw/qa/core/uwriter.cxx
+++ b/sw/qa/core/uwriter.cxx
@@ -788,7 +788,7 @@ void SwDocTest::testSwScanner()
 SwNodes& rNds = m_pDoc->GetNodes();
 CPPUNIT_ASSERT_EQUAL(static_cast(1), 
rTable.size());
 
-SwNodeIndex* pNodeIdx = rTable[0]->GetContentIdx();
+const SwNodeIndex* pNodeIdx = rTable[0]->GetContentIdx();
 CPPUNIT_ASSERT(pNodeIdx);
 
 pTextNode = rNds[ pNodeIdx->GetIndex() + 1 ]->GetTextNode();
//first deleted txtnode
diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index 3449a6420c5f..0f76346217d9 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -1099,7 +1099,6 @@ sal_uInt32 SwRangeRedline::s_nLastId = 1;
 SwRangeRedline::SwRangeRedline(RedlineType eTyp, const SwPaM& rPam )
 : SwPaM( *rPam.GetMark(), *rPam.GetPoint() ),
 m_pRedlineData( new SwRedlineData( eTyp, 
GetDoc().getIDocumentRedlineAccess().GetRedlineAuthor() ) ),
-m_pContentSect( nullptr ),
 m_nId( s_nLastId++ )
 {
 GetBound().SetRedline(this);
@@ -1122,7 +1121,6 @@ SwRangeRedline::SwRangeRedline(RedlineType eTyp, const 
SwPaM& rPam )
 SwRangeRedline::SwRangeRedline( const SwRedlineData& rData, const SwPaM& rPam )
 : SwPaM( *rPam.GetMark(), *rPam.GetPoint() ),
 m_pRedlineData( new SwRedlineData( rData )),
-m_pContentSect( nullptr ),
 m_nId( s_nLastId++ )
 {
 GetBound().SetRedline(this);
@@ -1137,7 +1135,6 @@ SwRangeRedline::SwRangeRedline( const SwRedlineData& 
rData, const SwPaM& rPam )
 SwRangeRedline::SwRangeRedline( const SwRedlineData& rData, const SwPosition& 
rPos )
 : SwPaM( rPos ),
 m_pRedlineData( new SwRedlineData( rData )),
-m_pContentSect( nullptr ),
 m_nId( s_nLastId++ )
 {
 GetBound().SetRedline(this);
@@ -1150,7 +1147,6 @@ SwRangeRedline::SwRangeRedline( const SwRedlineData& 
rData, const SwPosition& rP
 SwRangeRedline::SwRangeRedline( const SwRangeRedline& rCpy )
 : SwPaM( *rCpy.GetMark(), *rCpy.GetPoint() ),
 m_pRedlineData( new SwRedlineData( *rCpy.m_pRedlineData )),
-m_pContentSect( nullptr ),
 m_nId( s_nLastId++ )
 {
 GetBound().SetRedline(this);
@@ -1164,12 +1160,12 @@ SwRangeRedline::SwRangeRedline( const SwRangeRedline& 
rCpy )
 
 SwRangeRedline::~SwRangeRedline()
 {
-if( m_pContentSect )
+if( m_oContentSect )
 {
 // delete the ContentSection
 if( !GetDoc().IsInDtor() )
-GetDoc().getIDocumentContentOperations().DeleteSection( 
_pContentSect->GetNode() );
-delete m_pContentSect;
+GetDoc().getIDocumentContentOperations().DeleteSection( 
_oContentSect->GetNode() );
+ 

[Libreoffice-bugs] [Bug 150303] Double click in Calc doesn't enter cell edit mode in kf5/qt5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150303

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Julien Nabet  ---


*** This bug has been marked as a duplicate of bug 149818 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81293] The dialog “manage names” forgets size and column width settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81293

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0278

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-0' - sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/config/viewopt.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 71ab5a7f5a76142f3ed542b09c2aa349ec16fe18
Author: Jim Raykowski 
AuthorDate: Wed Aug 3 21:19:09 2022 -0800
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Aug 8 20:49:02 2022 +0200

tdf#148240 follow up: Make Outline-Folding non-experimental

Change-Id: I147591c8088b1fad0575b2efe46f862573147fe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137774
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 
(cherry picked from commit a9d225df2f8772e21435523ca20df1ece37390e4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137957
Reviewed-by: Xisco Fauli 
(cherry picked from commit f76184196f16f22a8c70d7400a3282f4ab6e4257)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137967
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/source/uibase/config/viewopt.cxx 
b/sw/source/uibase/config/viewopt.cxx
index 66ea4daa05f4..c5e6f3e56b9e 100644
--- a/sw/source/uibase/config/viewopt.cxx
+++ b/sw/source/uibase/config/viewopt.cxx
@@ -98,14 +98,12 @@ bool SwViewOption::IsEqualFlags( const SwViewOption  ) 
const
 
 bool SwViewOption::IsShowOutlineContentVisibilityButton() const
 {
-return officecfg::Office::Common::Misc::ExperimentalMode::get() &&
-(m_nCoreOptions & ViewOptFlags1::ShowOutlineContentVisibilityButton);
+return static_cast(m_nCoreOptions & 
ViewOptFlags1::ShowOutlineContentVisibilityButton);
 }
 
 bool SwViewOption::IsTreatSubOutlineLevelsAsContent() const
 {
-return officecfg::Office::Common::Misc::ExperimentalMode::get() &&
-(m_nCoreOptions & ViewOptFlags1::TreatSubOutlineLevelsAsContent);
+return static_cast(m_nCoreOptions & 
ViewOptFlags1::TreatSubOutlineLevelsAsContent);
 }
 
 void SwViewOption::DrawRect( OutputDevice *pOut,

[Libreoffice-bugs] [Bug 125943] [META] Qt5 VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125943
Bug 125943 depends on bug 150303, which changed state.

Bug 150303 Summary: Double click in Calc doesn't enter cell edit mode in kf5/qt5
https://bugs.documentfoundation.org/show_bug.cgi?id=150303

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150278] Form control Property Browser dialog doesn't remember last used tab (differently wrong in gtk3 and gen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150278

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=81
   ||293
Summary|Form control Property   |Form control Property
   |Browser dialog doesn't  |Browser dialog doesn't
   |remember last used tab  |remember last used tab
   ||(differently wrong in gtk3
   ||and gen)

--- Comment #3 from Justin L  ---
It looks like APP same revolutionary fix as MOD from Noel's bug 81293.

Proposed fix at
http://gerrit.libreoffice.org/c/core/+/138002 tdf#150278 sfx2: use provided
aInfo, not factory

and

http://gerrit.libreoffice.org/c/core/+/138003 tdf#150278: avoid gen/gtk3
difference in m_xPropBox->GetCurPage()

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkframe.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 87bde9e695f72e3e9f498ef4d9d76dd2fcff24db
Author: Caolán McNamara 
AuthorDate: Mon Aug 8 15:51:15 2022 +0100
Commit: Caolán McNamara 
CommitDate: Mon Aug 8 20:30:33 2022 +0200

gtk4: cursor not changing on moving over other widgets

Change-Id: I57f924522a6fd93950f56c44ca65aa5131fb4aa8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137989
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index 999b1e8680a1..cfb9a9f628cc 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -1011,7 +1011,6 @@ void GtkSalFrame::InitCommon()
 g_signal_connect(pMotionController, "motion", G_CALLBACK(signalMotion), 
this);
 g_signal_connect(pMotionController, "enter", G_CALLBACK(signalEnter), 
this);
 g_signal_connect(pMotionController, "leave", G_CALLBACK(signalLeave), 
this);
-gtk_event_controller_set_propagation_phase(pMotionController, 
GTK_PHASE_TARGET);
 gtk_widget_add_controller(pEventWidget, pMotionController);
 
 GtkEventController* pScrollController = 
gtk_event_controller_scroll_new(GTK_EVENT_CONTROLLER_SCROLL_BOTH_AXES);

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit d632b83a4b4998930112218081db4d619713583b
Author: Caolán McNamara 
AuthorDate: Mon Aug 8 15:21:14 2022 +0100
Commit: Caolán McNamara 
CommitDate: Mon Aug 8 20:30:07 2022 +0200

gtk4: complete set_cursor for gtk4

Change-Id: I31413a6dafe1ddf1345ac6bccb96fc88ed2993c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137985
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index cd26d1f5c3b3..0576c8ac84c2 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -2495,19 +2495,18 @@ void LocalizeDecimalSeparator(guint& keyval)
 
 void set_cursor(GtkWidget* pWidget, const char *pName)
 {
-#if !GTK_CHECK_VERSION(4, 0, 0)
 if (!gtk_widget_get_realized(pWidget))
 gtk_widget_realize(pWidget);
 GdkDisplay *pDisplay = gtk_widget_get_display(pWidget);
+#if GTK_CHECK_VERSION(4, 0, 0)
+GdkCursor *pCursor = pName ? gdk_cursor_new_from_name(pName, nullptr) : 
nullptr;
+#else
 GdkCursor *pCursor = pName ? gdk_cursor_new_from_name(pDisplay, pName) : 
nullptr;
+#endif
 widget_set_cursor(pWidget, pCursor);
 gdk_display_flush(pDisplay);
 if (pCursor)
 g_object_unref(pCursor);
-#else
-(void)pWidget;
-(void)pName;
-#endif
 }
 
 vcl::Font get_font(GtkWidget* pWidget)

[Libreoffice-bugs] [Bug 146316] A marked extruded shape is not contained in CurrentSelection in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146316

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0305

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150305] New: A marked Fontwork shape is not in 'Current Selection' in Development tools

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150305

Bug ID: 150305
   Summary: A marked Fontwork shape is not in 'Current Selection'
in Development tools
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Start a Writer document. Open Development tools and click on 'Current
Selection' and 'Properties'.
Insert a Fontwork shape and select it.
Error: There is Class name: SwXTextRanges and the Properties window is empty.
'Refesh' does not change it.
Expected: The properties of the shape are shown in the window and there is
Class name: com.sun.star.drawing.SvxShapeCollection

The same problem and likely the underlying reason exists in Basic macros.
In
dim oDoc as object: oDoc=ThisComponent
dim oShapeCollectionWriter as variant
oShapeCollectionWriter = oDoc.CurrentSelection

The variable oShapeCollectionWriter is empty.

I have seen a similar problem with extruded shapes in bug 146316. For normal
shapes the variable oShapeCollectionWriter is not empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - dbaccess/source forms/source reportdesign/source

[Caolán McNamara (via logerrit)]

 dbaccess/source/ui/inc/JoinTableView.hxx |2 --
 dbaccess/source/ui/querydesign/JoinTableView.cxx |   12 +++-
 forms/source/richtext/richtextimplcontrol.cxx|   19 ---
 forms/source/richtext/richtextimplcontrol.hxx|2 --
 forms/source/richtext/richtextvclcontrol.cxx |2 --
 reportdesign/source/ui/inc/ScrollHelper.hxx  |2 --
 reportdesign/source/ui/report/ScrollHelper.cxx   |   11 ---
 reportdesign/source/ui/report/dlgedfunc.cxx  |1 -
 8 files changed, 3 insertions(+), 48 deletions(-)

New commits:
commit 479cf04cee6f360c9bca618369b6b545b94e55ef
Author: Caolán McNamara 
AuthorDate: Mon Aug 8 12:34:05 2022 +0100
Commit: Caolán McNamara 
CommitDate: Mon Aug 8 20:26:28 2022 +0200

drop unwanted scroll corner

Change-Id: I82143de336df91c5ca69693f6255b0d729e8381b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137978
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/forms/source/richtext/richtextimplcontrol.cxx 
b/forms/source/richtext/richtextimplcontrol.cxx
index fc9251074e64..790a3f88b22a 100644
--- a/forms/source/richtext/richtextimplcontrol.cxx
+++ b/forms/source/richtext/richtextimplcontrol.cxx
@@ -46,7 +46,6 @@ namespace frm
 ,m_pViewport( nullptr)
 ,m_pHScroll ( nullptr)
 ,m_pVScroll ( nullptr)
-,m_pScrollCorner( nullptr)
 ,m_pEngine  ( _pEngine)
 ,m_pTextAttrListener( _pTextAttrListener  )
 ,m_pSelectionListener   ( _pSelectionListener )
@@ -84,7 +83,6 @@ namespace frm
 m_pAntiImpl->SetBackground( Wallpaper( 
m_pAntiImpl->GetSettings().GetStyleSettings().GetFieldColor() ) );
 }
 
-
 RichTextControlImpl::~RichTextControlImpl( )
 {
 m_pEngine->RemoveView( m_pView.get() );
@@ -93,10 +91,8 @@ namespace frm
 m_pViewport.disposeAndClear();
 m_pHScroll.disposeAndClear();
 m_pVScroll.disposeAndClear();
-m_pScrollCorner.disposeAndClear();
 }
 
-
 void RichTextControlImpl::implUpdateAttribute( const 
AttributeHandlerPool::const_iterator& _pHandler )
 {
 if  (  ( _pHandler->first == sal_uInt16(SID_ATTR_CHAR_WEIGHT) )
@@ -355,21 +351,9 @@ namespace frm
 m_pHScroll->Show();
 }
 
-if ( m_pHScroll && m_pVScroll )
-{
-m_pScrollCorner.disposeAndClear();
-m_pScrollCorner = VclPtr::Create( m_pAntiImpl );
-m_pScrollCorner->Show();
-}
-else
-{
-m_pScrollCorner.disposeAndClear();
-}
-
 layoutWindow();
 }
 
-
 void RichTextControlImpl::ensureLineBreakSetting()
 {
 if ( !windowHasAutomaticLineBreak() )
@@ -378,7 +362,6 @@ namespace frm
 layoutWindow();
 }
 
-
 void RichTextControlImpl::layoutWindow()
 {
 if ( !m_bHasEverBeenShown )
@@ -424,8 +407,6 @@ namespace frm
 m_pHScroll->SetThickness(nScrollBarHeight);
 m_pHScroll->SetPosSizePixel( Point( 0, 
aViewportPlaygroundPixel.Height() ), Size( aViewportPlaygroundPixel.Width(), 
nScrollBarHeight ) );
 }
-if ( m_pScrollCorner )
-m_pScrollCorner->SetPosSizePixel( Point( 
aViewportPlaygroundPixel.Width(), aViewportPlaygroundPixel.Height() ), Size( 
nScrollBarWidth, nScrollBarHeight ) );
 
 // paper size
 if ( windowHasAutomaticLineBreak() )
diff --git a/forms/source/richtext/richtextimplcontrol.hxx 
b/forms/source/richtext/richtextimplcontrol.hxx
index f1cbb81ffe22..86b1a1831684 100644
--- a/forms/source/richtext/richtextimplcontrol.hxx
+++ b/forms/source/richtext/richtextimplcontrol.hxx
@@ -22,7 +22,6 @@
 #include "richtextviewport.hxx"
 #include "richtextengine.hxx"
 #include 
-#include 
 #include 
 
 #include 
@@ -56,7 +55,6 @@ namespace frm
 VclPtr   m_pViewport;
 VclPtr  m_pHScroll;
 VclPtr  m_pVScroll;
-VclPtr   m_pScrollCorner;
 RichTextEngine* m_pEngine;
 std::unique_ptr m_pView;
 ITextAttributeListener* m_pTextAttrListener;
diff --git a/forms/source/richtext/richtextvclcontrol.cxx 
b/forms/source/richtext/richtextvclcontrol.cxx
index cb4d613e36b2..da547afce6c6 100644
--- a/forms/source/richtext/richtextvclcontrol.cxx
+++ b/forms/source/richtext/richtextvclcontrol.cxx
@@ -43,14 +43,12 @@ namespace frm
 implInit( _pEngine, _pTextAttribListener, _pSelectionListener );
 }
 
-
 void RichTextControl::implInit( RichTextEngine* _pEngine, 
ITextAttributeListener* _pTextAttribListener, ITextSelectionListener* 
_pSelectionListener )
 {
 m_pImpl.reset( new RichTextControlImpl( this, _pEngine, 
_pTextAttribListener, _pSelectionListener ) );
 SetCompoundControl( true );
 }
 
-
 RichTextControl::~RichTextControl( )
 {
  

[Libreoffice-bugs] [Bug 150304] Cannot open ODS file created in older version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150304

Timofeus  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEEDINFO|RESOLVED

--- Comment #4 from Timofeus  ---
Yes, it seem like a profile issue, I can open it from other user.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
Bug 81234 depends on bug 148518, which changed state.

Bug 148518 Summary: FILEOPEN RTF Dropdown field does not read all items
https://bugs.documentfoundation.org/show_bug.cgi?id=148518

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148518] FILEOPEN RTF Dropdown field does not read all items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148518

Michael Stahl (allotropia)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de
   |desktop.org |

--- Comment #4 from Michael Stahl (allotropia)  ---
fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 56301] Allow user to edit document with Special Characters dialog open (convert to non-modal)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56301

--- Comment #19 from V Stuart Foote  ---
(In reply to Mike Kaganski from comment #18)
> (By the way, please elaborate on "collapsed Unicode tables" - best by
> referencing respective bug report.)

Any substantive work with Unicode is facilitated by visual feedback of the 16
column table space. Empty (undefined glyphs omitted by font designer) and
Unicode reserved blocks on the tables for the planes the font supports (bug
141319). Giving user a direct read of Unicode for each cell with a glyph or
equally without.

Look at the very functional chart implemented in BableMap [1], where visual
scaning of the Unicode charts provides coverage details--and a radio button
toggle between composite font and single font's coverage.  An easy way to
identify when a font selection needs to be changed.

In fact the SCD has retained a 16 column chart from inception. Though we've
always packed. But, rather than packing the font (loosing any Unicode context)
the ask is to render the charts with fidelity to Unicode.

=-ref-=
[1] https://www.babelstone.co.uk/Software/BabelMap.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108253
Bug 108253 depends on bug 80347, which changed state.

Bug 80347 Summary: Enhancement request: change Arguments and Outputs to English 
when Formulas are set to English names
https://bugs.documentfoundation.org/show_bug.cgi?id=80347

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80347] Enhancement request: change Arguments and Outputs to English when Formulas are set to English names

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80347

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5993

--- Comment #3 from Eike Rathke  ---
For inline mere numeric arguments this makes sense and now thy are "English"
(using the '.' dot decimal separator) as well since commit
0a78f11fdd13d914d5f063007b2df9796e6dce9d for bug 135993 that takes the symbol
map's bEnglish setting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149916] Seeing _RefHeading_ in cross-ref field listing in Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149916

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0 target:7.4.0.2 |target:7.5.0 target:7.4.0.2
   ||target:7.4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149916] Seeing _RefHeading_ in cross-ref field listing in Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149916

--- Comment #12 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/e6b9fab8be5f4a8de5126d1f3be82e0c738af9a0

tdf#149916 follow up to include expand field text

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/utlui/content.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e6b9fab8be5f4a8de5126d1f3be82e0c738af9a0
Author: Jim Raykowski 
AuthorDate: Sun Jul 31 18:34:51 2022 -0800
Commit: Xisco Fauli 
CommitDate: Mon Aug 8 19:30:49 2022 +0200

tdf#149916 follow up to include expand field text

in cross-reference entry text

Change-Id: Iaff06e02d272bbe41e63da5356e6c9a6f67c26f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137665
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 
(cherry picked from commit a0e09cf64eea663122043294b848ac1bb8f05ac9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137966
Reviewed-by: Xisco Fauli 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index f0fe95f508f3..9506827fa325 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -695,7 +695,8 @@ void SwContentType::FillMemberList(bool* pbContentChanged)
 sExpandedTextOfReferencedTextNode = 
OUString::Concat(
 
sExpandedTextOfReferencedTextNode.subView(0, 80)) + u"...";
 }
-sText = pField->GetDescription() + u" - " + 
sExpandedTextOfReferencedTextNode;
+sText = pField->GetDescription() + u" - "
++ sExpandedTextOfReferencedTextNode + 
sExpandField;
 }
 else
 {

[Libreoffice-bugs] [Bug 63795] Examples of Russian spelling errors (with detailed description in English)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63795

--- Comment #10 from Timon  ---
Bugs are still reproducible in:
Version: 7.3.5.2 (x86) / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/source

[Noel Grandin (via logerrit)]

 sw/inc/doc.hxx   |5 ++---
 sw/source/core/crsr/crsrsh.cxx   |2 +-
 sw/source/core/doc/DocumentFieldsManager.cxx |2 +-
 sw/source/core/doc/tblcpy.cxx|2 +-
 sw/source/core/docnode/ndtbl.cxx |   20 
 sw/source/core/edit/edtab.cxx|2 +-
 sw/source/core/frmedt/fecopy.cxx |2 +-
 sw/source/core/undo/unsort.cxx   |2 +-
 sw/source/uibase/dochdl/swdtflvr.cxx |8 
 9 files changed, 20 insertions(+), 25 deletions(-)

New commits:
commit 9130c1abc65aedd0358d9f9dd4b9108b7e68f70f
Author: Noel Grandin 
AuthorDate: Sun Aug 7 13:42:18 2022 +0200
Commit: Noel Grandin 
CommitDate: Mon Aug 8 19:27:36 2022 +0200

make SwDoc::IsInTable more efficient

Just follow the pointers, instead of unnecesarily indexing through
the SwNodes array.

Change-Id: I7da103d1300e1cbb54a8ca2994170fb7b2d9779f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137938
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index d63a10a1ec2e..0606ac4c33d1 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1174,9 +1174,8 @@ public:
 bool bNewModel = true );
 
 // If index is in a table, return TableNode, else 0.
-SwTableNode* IsIdxInTable( const SwNodeIndex& rIdx );
-const SwTableNode* IsIdxInTable( const SwNodeIndex& rIdx ) const;
-SwTableNode* IsInTable( const SwNode& ) const;
+static SwTableNode* IsIdxInTable( const SwNodeIndex& rIdx );
+static SwTableNode* IsInTable( const SwNode& );
 
 // Create a balanced table out of the selected range.
 const SwTable* TextToTable( const SwInsertTableOptions& rInsTableOpts, // 
HeadlineNoBorder,
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 977b94e686fb..745fb43f5239 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -1601,7 +1601,7 @@ void SwCursorShell::UpdateCursor( sal_uInt16 eFlags, bool 
bIdleEnd )
 // then the table mode is active (also if it is already active: 
m_pTableCursor)
 SwPaM* pTstCursor = getShellCursor( true );
 if( pTstCursor->HasMark() && !m_pBlockCursor &&
-mxDoc->IsIdxInTable( pTstCursor->GetPoint()->nNode ) &&
+SwDoc::IsIdxInTable( pTstCursor->GetPoint()->nNode ) &&
   ( m_pTableCursor ||
 pTstCursor->GetNode().StartOfSectionNode() !=
 pTstCursor->GetNode( false ).StartOfSectionNode() ) && 
!mbSelectAll)
diff --git a/sw/source/core/doc/DocumentFieldsManager.cxx 
b/sw/source/core/doc/DocumentFieldsManager.cxx
index cccdb2978b00..a9b22abe92d6 100644
--- a/sw/source/core/doc/DocumentFieldsManager.cxx
+++ b/sw/source/core/doc/DocumentFieldsManager.cxx
@@ -528,7 +528,7 @@ bool DocumentFieldsManager::UpdateField(SwTextField * 
pDstTextField, SwField & r
 case SwFieldIds::Table:
 {
 const SwTableNode* pTableNd =
-m_rDoc.IsIdxInTable(aTableNdIdx);
+SwDoc::IsIdxInTable(aTableNdIdx);
 if( pTableNd )
 {
 SwTableFormulaUpdate aTableUpdate( >
diff --git a/sw/source/core/doc/tblcpy.cxx b/sw/source/core/doc/tblcpy.cxx
index 135d558bb702..c7dc08b99934 100644
--- a/sw/source/core/doc/tblcpy.cxx
+++ b/sw/source/core/doc/tblcpy.cxx
@@ -707,7 +707,7 @@ bool SwTable::InsTable( const SwTable& rCpyTable, const 
SwNodeIndex& rSttBox,
 
 SwDoc* pDoc = GetFrameFormat()->GetDoc();
 
-SwTableNode* pTableNd = pDoc->IsIdxInTable( rSttBox );
+SwTableNode* pTableNd = SwDoc::IsIdxInTable( rSttBox );
 
 // Find the Box, to which should be copied:
 SwTableBox* pMyBox = GetTableBox(
diff --git a/sw/source/core/docnode/ndtbl.cxx b/sw/source/core/docnode/ndtbl.cxx
index 01e2dc21d173..c962688f9dd5 100644
--- a/sw/source/core/docnode/ndtbl.cxx
+++ b/sw/source/core/docnode/ndtbl.cxx
@@ -217,21 +217,17 @@ static SwTableBoxFormat *lcl_CreateAFormatBoxFormat( 
SwDoc , std::vector();
 do {
-SwNode* pNd = GetNodes()[ nIndex ]->StartOfSectionNode();
-pTableNd = pNd->GetTableNode();
-if( nullptr != pTableNd )
-break;
-
-nIndex = pNd->GetIndex();
-} while ( nIndex );
-return pTableNd;
+pNd = pNd->StartOfSectionNode();
+SwTableNode* pTableNd = pNd->GetTableNode();
+if( pTableNd )
+return pTableNd;
+} while ( pNd->GetIndex() );
+return nullptr;
 }
 
 /**
diff --git a/sw/source/core/edit/edtab.cxx b/sw/source/core/edit/edtab.cxx
index 0fa31a2425a0..5cb985686d8f 100644
--- a/sw/source/core/edit/edtab.cxx
+++ b/sw/source/core/edit/edtab.cxx
@@ -151,7 +151,7 @@ bool SwEditShell::TableToText( sal_Unicode cCh )
 SwWait aWait( *GetDoc()->GetDocShell(), true );
 SwPaM* pCursor = GetCursor();
 const SwTableNode* pTableNd =
-

[Libreoffice-commits] core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/core/crsr/crstrvl.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 5ae0fcbc4a93cbc52071cf6ecfe271031af3ec27
Author: Noel Grandin 
AuthorDate: Sun Aug 7 13:44:44 2022 +0200
Commit: Noel Grandin 
CommitDate: Mon Aug 8 18:59:35 2022 +0200

no need to allocate on heap in lcl_FindField

Change-Id: Ia9172292220f6935e4a21b659d07dc317c060740
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137939
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/crsr/crstrvl.cxx b/sw/source/core/crsr/crstrvl.cxx
index d0f9fdc2b414..3d03a483c646 100644
--- a/sw/source/core/crsr/crstrvl.cxx
+++ b/sw/source/core/crsr/crstrvl.cxx
@@ -661,16 +661,16 @@ lcl_FindField(bool & o_rFound, SetGetExpFields const& 
rSrtLst,
 SwTextField const *const pTextField, SwPosition const& rPos,
 sal_Int32 const nContentOffset)
 {
-std::unique_ptr pSrch;
-std::unique_ptr pIndex;
+std::optional oSrch;
+std::optional oIndex;
 if (-1 == nContentOffset)
 {
-pSrch.reset(new SetGetExpField(rPos.GetNode(), pTextField, 
));
+oSrch.emplace(rPos.GetNode(), pTextField, );
 }
 else
 {
-pIndex.reset(new SwContentIndex(rPos.GetNode().GetContentNode(), 
nContentOffset));
-pSrch.reset(new SetGetExpField(rPos.GetNode(), pTextField, 
pIndex.get()));
+oIndex.emplace(rPos.GetNode().GetContentNode(), nContentOffset);
+oSrch.emplace(rPos.GetNode(), pTextField, &*oIndex);
 }
 
 if (rPos.GetNodeIndex() < 
pTextNode->GetNodes().GetEndOfExtras().GetIndex())
@@ -678,12 +678,12 @@ lcl_FindField(bool & o_rFound, SetGetExpFields const& 
rSrtLst,
 // also at collection use only the first frame
 Point aPt;
 std::pair const tmp(aPt, false);
-pSrch->SetBodyPos(*pTextNode->getLayoutFrame(pLayout, , ));
+oSrch->SetBodyPos(*pTextNode->getLayoutFrame(pLayout, , ));
 }
 
-SetGetExpFields::const_iterator it = rSrtLst.lower_bound(pSrch.get());
+SetGetExpFields::const_iterator it = rSrtLst.lower_bound(&*oSrch);
 
-o_rFound = (it != rSrtLst.end()) && (**it == *pSrch);
+o_rFound = (it != rSrtLst.end()) && (**it == *oSrch);
 return it;
 }
 

[Libreoffice-bugs] [Bug 136220] Long fields lose its part on page end in some cases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136220

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0300

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149424] Layout loop in doc files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149424

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0300

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122878] Wrong wrap with shape in footer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122878

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0300

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150300] Writer adds blank pages indefinitely when "as character" image is larger than the page and is followed by text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150300

Mike Kaganski  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2878,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||6220,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9424
 CC||patrick.j...@tu-dresden.de,
   ||vmik...@collabora.com

--- Comment #6 from Mike Kaganski  ---
Regression after commit 7ed962571df02d1d7b286e7af534fadd717a8003
  Author Patrick Jaap 
  Date   Wed Jan 23 10:01:36 2019 +0100
tdf#122878: enable wrap for flys in footer

Possible duplicate of tdf#149424

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150304] Cannot open ODS file created in older version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150304

--- Comment #3 from Xisco Faulí  ---
Forgot about my previous comment. I can't reproduce the issue in

Version: 7.3.5.0.0+ / LibreOffice Community
Build ID: ff6e536111a966f465c4756cbfa74935752df612
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

Either.

To be certain the reported issue is not related to corruption in the user
profile, could you please reset your Libreoffice profile (
https://wiki.documentfoundation.org/UserProfile ) and re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150304] Cannot open ODS file created in older version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150304

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Xisco Faulí  ---
I can't reproduce it in

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: cdf5b6a2a6f0ba2838323ce4398948c3d3a56f8e
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

I believe the problem is that you are using 'Calc: threaded' which is not very
stable in LibreOffice 7.3 but it's in LibreOffice 7.4. So, if you are in
LibreOffice 7.3, please disable it from Tools - Options - Calc - Default -
Disable very large spreadsheets

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150300] Writer adds blank pages indefinitely when "as character" image is larger than the page and is followed by text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150300

Mike Kaganski  changed:

   What|Removed |Added

 OS|Linux (All) |All
Version|7.3.5.2 release |6.3.0.4 release
   Keywords||bibisectRequest, regression
   Hardware|x86-64 (AMD64)  |All
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from Mike Kaganski  ---
Works fine using Version: 6.2.0.3 (x64)
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

Fails (basically, hangs) using Version: 6.3.0.4 (x64)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/source

[Miklos Vajna (via logerrit)]

 vcl/source/filter/ipdf/pdfread.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit f37998fdc3044ce8d477c2cfb0b9219d5f8ba75d
Author: Miklos Vajna 
AuthorDate: Mon Aug 1 09:31:48 2022 +0200
Commit: Xisco Fauli 
CommitDate: Mon Aug 8 18:26:55 2022 +0200

vcl: fix crash in vcl::ImportPDFUnloaded()

Crashreport signature:

SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x0
program/libmergedlo.so
vcl::ImportPDFUnloaded(rtl::OUString const&, 
std::vector >&)
vcl/source/filter/ipdf/pdfread.cxx:256
program/../program/libsdlo.so
SdPdfFilter::Import()
sd/source/filter/pdf/sdpdffilter.cxx:55
program/../program/libsdlo.so
sd::DrawDocShell::ConvertFrom(SfxMedium&)
sd/source/ui/docshell/docshel4.cxx:500 (discriminator 1)
program/libmergedlo.so
SfxObjectShell::DoLoad(SfxMedium*)
sfx2/source/doc/objstor.cxx:768

Change-Id: I2fc635de696643af6a80a29aa5af4fa128f8776c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137673
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 60f9ca81e84f1bede4928c6f680325692cc8bc49)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137965
Reviewed-by: Xisco Fauli 

diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index 8510b0a0c207..e99682e0c0e4 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -258,6 +258,11 @@ std::vector
 findAnnotations(const std::unique_ptr& pPage, 
basegfx::B2DSize aPageSize)
 {
 std::vector aPDFGraphicAnnotations;
+if (!pPage)
+{
+return aPDFGraphicAnnotations;
+}
+
 for (int nAnnotation = 0; nAnnotation < pPage->getAnnotationCount(); 
nAnnotation++)
 {
 auto pAnnotation = pPage->getAnnotation(nAnnotation);

[Libreoffice-bugs] [Bug 146786] File > Close icon missing, X exits the program (not in Safe mode but yes with profile reset)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146786

Martin Terry  changed:

   What|Removed |Added

 CC||martinterry839@btinternet.c
   ||om

--- Comment #16 from Martin Terry  ---
I have upgraded to LO version 7.3.4 and the x' close buttons are no longer
missing. I normally stick with the more stable version but no sign of an update
to 7.2 so I took a chance and moved to the newer 7.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150304] Cannot open ODS file created in older version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150304

--- Comment #1 from Timofeus  ---
Created attachment 181655
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181655=edit
problem file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150304] New: Cannot open ODS file created in older version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150304

Bug ID: 150304
   Summary: Cannot open ODS file created in older version
   Product: LibreOffice
   Version: 7.3.5.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shati...@mail.ru

Description:
Cannot open ods spreadsheet file which was created in Libreoffice some time
ago. 
File is attached.



Steps to Reproduce:
1. Try to open problem file.
https://drive.google.com/file/d/15uDjCu67thF_-_4CLwBidFh2XSs7calz
2. Observe program stop responding.

Actual Results:
program stop responding.

Expected Results:
File opens


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.5.2 (x64) / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

File can be opened in Libreoffice ver. 7.0.4-4+deb11u1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150300] Writer adds blank pages indefinitely when "as character" image is larger than the page and is followed by text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150300

igor@protonmail.com changed:

   What|Removed |Added

Summary|Writer adds blank pages |Writer adds blank pages
   |indefinitely when "as   |indefinitely when "as
   |character" image is larger  |character" image is larger
   |than the page and contains  |than the page and is
   |text|followed by text

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150300] Writer adds blank pages indefinitely when "as character" image is larger than the page and contains text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150300

igor@protonmail.com changed:

   What|Removed |Added

Summary|Writer adds blank pages |Writer adds blank pages
   |indefinitely|indefinitely when "as
   ||character" image is larger
   ||than the page and contains
   ||text

-- 
You are receiving this mail because:
You are the assignee for the bug.