[Libreoffice-bugs] [Bug 109237] [META] CSV export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109237 Bug 109237 depends on bug 133756, which changed state. Bug 133756 Summary: Saving an CSV containing formula's erases formula's https://bugs.documentfoundation.org/show_bug.cgi?id=133756 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133756] Saving an CSV containing formula's erases formula's
https://bugs.documentfoundation.org/show_bug.cgi?id=133756 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW |RESOLVED --- Comment #9 from Mike Kaganski --- CSV is ideally a data-only datatype-agnostic file format. Having formulas in it is an extension, and is considered a security issue (see bug 114878). Having unsupported data and formatting lost on save to external format is expected and normal; not having this data lost in the current UI is also OK (the same would happen in Writer, when you save tables and headers and footnotes and bolds to a TXT file, and not see the loss until you reload). LibreOffice does not reload automatically on save - it also helps when one changes their mind, and decides to save to native format (or undo, or whatever) - reloading would make all that impossible. So no, there's no bug, nothing to change, and the defaults are fine. Change filter settings on save explicitly to enable saving formulas. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150710] Wrong Kashida in Arabic text when enabling "Toggle formatting marks"
https://bugs.documentfoundation.org/show_bug.cgi?id=150710 خالد حسني changed: What|Removed |Added Keywords||bibisectRequest Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from خالد حسني --- Interesting, I have seen this blue coloring before and thought it is a new feature in master or something :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9ba1e1486bf3fcccf98da93d3963b3d4036705a9 Author: Andrea Gelmini AuthorDate: Tue Aug 30 21:14:00 2022 +0200 Commit: Julien Nabet CommitDate: Wed Aug 31 07:19:56 2022 +0200 Fix typos Change-Id: I4ed7373afbb4102bbfaf0565c248a5cc84bd3ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139068 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 7ff195152f23..deeb5f4faead 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2658,8 +2658,8 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, } } -// Filter out substitutions where a proprietary font has been substituded by a -// metric-compatible one. Onviously this is just a heuristic and implemented only for some +// Filter out substitutions where a proprietary font has been substituted by a +// metric-compatible one. Obviously this is just a heuristic and implemented only for some // well-known cases. for (std::size_t i = 0; i < aFontMappingUseData.size();)
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unosrch.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit d806f9223ae53365acd9aa6cb448adbb1811c57c
Author: Andrea Gelmini
AuthorDate: Tue Aug 30 22:16:19 2022 +0200
Commit: Julien Nabet
CommitDate: Wed Aug 31 07:12:14 2022 +0200
Fix typo
Change-Id: Id405de7e2abfa6c4e77930d70b204f77e9cac1b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139070
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/source/core/unocore/unosrch.cxx
b/sw/source/core/unocore/unosrch.cxx
index 91ddb3432dbd..ee260c077b61 100644
--- a/sw/source/core/unocore/unosrch.cxx
+++ b/sw/source/core/unocore/unosrch.cxx
@@ -152,7 +152,7 @@ void SwSearchProperties_Impl::FillItemSet(SfxItemSet& rSet,
bool bIsValueSearch)
{
SfxPoolItem* pTempItem = nullptr;
const SfxItemPropertyMapEntry* pPropEntry =
mrMap.getByName(rPair.first);
-assert(pPropEntry && "SetProperties only enters values into maValues
if mrMap.hasPropertyByName() wass true");
+assert(pPropEntry && "SetProperties only enters values into maValues
if mrMap.hasPropertyByName() was true");
const SfxItemPropertyMapEntry & rPropEntry = *pPropEntry;
sal_uInt16 nWID = rPropEntry.nWID;
switch(nWID)
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 ) ( LibreOffice 7.4 only )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 Mike Kaganski changed: What|Removed |Added CC||pbarret...@gmail.com --- Comment #57 from Mike Kaganski --- *** Bug 150713 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150713] LibreOffice 7.4.0 update won't open in previously saved screen size
https://bugs.documentfoundation.org/show_bug.cgi?id=150713 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 150236 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150137] Crash when parsing an XML with undeclared namespace
https://bugs.documentfoundation.org/show_bug.cgi?id=150137 --- Comment #4 from Mike Kaganski --- (In reply to Amar from comment #3) > So what's the expected behavior? (In reply to Mike Kaganski from comment #2) > Just to avoid confusion, the bug is about the crash, that must not happen > regardless of the (potentially invalid or ambiguous or otherwise > questionable) user input. The expected behavior is: there is no crash. Since the input is not valid, missing the namespace declaration, the macro should give a runtime error. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150713] New: LibreOffice 7.4.0 update won't open in previously saved screen size
https://bugs.documentfoundation.org/show_bug.cgi?id=150713 Bug ID: 150713 Summary: LibreOffice 7.4.0 update won't open in previously saved screen size Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pbarret...@gmail.com Description: LibreOffice 7.4.0 update won't open in previously saved screen size - this applies to Writer and Calc only... Draw & Impress seem to be OK - please fix Steps to Reproduce: 1.Open Writer or Calc 2. Small opening size that needs to be enlarged 3. Actual Results: Works OK Expected Results: Opened the application to the default or previously saved screen size Reproducible: Always User Profile Reset: No Additional Info: None -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150686] Macro connected through Tools → Customize → Events → View created leads to error when document is opened again
https://bugs.documentfoundation.org/show_bug.cgi?id=150686 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150450] DOCX Document Intermittently Appears Saved as a DOC File with DOCX Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=150450 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150446] Incorrect behaviour of gutter in mirrored pages with top binding
https://bugs.documentfoundation.org/show_bug.cgi?id=150446 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150444] Track changes: Track changes manage shows only deletion icon after saving DOCX to ODT
https://bugs.documentfoundation.org/show_bug.cgi?id=150444 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150435] Track changes: reject changes doesn't restore font formatting change
https://bugs.documentfoundation.org/show_bug.cgi?id=150435 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150433] Add Thai thesaurus
https://bugs.documentfoundation.org/show_bug.cgi?id=150433 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150432] Startup of app in Wayland is throwing errors
https://bugs.documentfoundation.org/show_bug.cgi?id=150432 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150667] Ugly font rendering in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=150667 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150667] Ugly font rendering in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=150667 --- Comment #15 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147093] Crashed when I added a second picture to a document and then scrolled
https://bugs.documentfoundation.org/show_bug.cgi?id=147093 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147753] Crashes when doing various things in both writer and calc
https://bugs.documentfoundation.org/show_bug.cgi?id=147753 --- Comment #2 from QA Administrators --- Dear Gina Lambert, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147093] Crashed when I added a second picture to a document and then scrolled
https://bugs.documentfoundation.org/show_bug.cgi?id=147093 --- Comment #3 from QA Administrators --- Dear Colin, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147752] entering numbers in some columns....after going to the next column the previous column changes to a date
https://bugs.documentfoundation.org/show_bug.cgi?id=147752 --- Comment #2 from QA Administrators --- Dear magician002, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143642] Replace All Function Not Working
https://bugs.documentfoundation.org/show_bug.cgi?id=143642 --- Comment #6 from QA Administrators --- Dear Bruce Gray, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150712] Format->Conditional->Condition 100% CPU
https://bugs.documentfoundation.org/show_bug.cgi?id=150712 --- Comment #1 from Pierre Fortin --- Some testing shows that it takes a while to get the dialog window to present the formatting panel: 5000x500 cells selected == 6 seconds 1x500 cells selected -- 17 seconds 25000x500 cells selected -- 8 minutes 45 seconds No need for further tests as the processing time is clearly non-linear. Sigh... this kills my plans of using Calc. My largest sheets of this type are around 950,000x500. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92165] page numbers doubled (i.e. 1 -> 11; 2 -> 22 etc) after saving specific .odt as .doc
https://bugs.documentfoundation.org/show_bug.cgi?id=92165 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Hardware|Other |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150712] New: Format->Conditional->Condition 100% CPU
https://bugs.documentfoundation.org/show_bug.cgi?id=150712 Bug ID: 150712 Summary: Format->Conditional->Condition 100% CPU Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: p...@pfortin.com Load a smallish 230+MB .tsv file (154161x501); I will be creating Jumbo files; but need this to work before wasting time on the bigger files.. Except for Row 1 (6-digit YYMMDD date headers) and column A (ints), all cells are 2-character codes for which I want to apply background colors based on the contents. The conditions work fine on a test sheet of about 25x4 cells. Format->Conditional->Condition gives the dialog window as expected; but... if select the entire sheet first, I get the dislog window with the contents from the sheet, and calc goes 100% CPU. I've let it run for a long time and it never returns; has to be killed. When the full sheet of the 154161x501 range is selected, I never see the normal contents of the "Conditional Formatting for A1:" window. Also happens in version 7.4.0.3 which is hung as I write this report. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150711] spam
https://bugs.documentfoundation.org/show_bug.cgi?id=150711 V Stuart Foote changed: What|Removed |Added Component|BASIC |deletionRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150711] spam
https://bugs.documentfoundation.org/show_bug.cgi?id=150711 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |INVALID Summary|registe rissue |spam -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/qa sw/source
sw/qa/extras/htmlexport/htmlexport.cxx | 57 +
sw/source/filter/html/wrthtml.cxx |3 +
2 files changed, 59 insertions(+), 1 deletion(-)
New commits:
commit 184a9eec62058dcbe185d74cfd40a3772d3b801d
Author: Vasily Melenchuk
AuthorDate: Fri Aug 26 16:32:57 2022 +0300
Commit: Thorsten Behrens
CommitDate: Wed Aug 31 03:48:51 2022 +0200
tdf#114769: sw html export: better handling for relative URLs
Usage of INetURLObject makes sense only in case of full URLs,
but once relative one is provided it will contain invalid data.
Change-Id: Icc5e191e2337a3dd9a76c660b1c7709551099a1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138875
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 599da3fa69805ebf8dee4517855fd8706e19d11d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138979
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 5e5af5e70a17..ab4d71a7d02e 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -2392,6 +2392,63 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testSectionDir)
assertXPath(pXmlDoc, "//reqif-xhtml:div[@id='mysect']", "style", "dir:
ltr");
}
+CPPUNIT_TEST_FIXTURE(HtmlExportTest, testTdf114769)
+{
+// Create document from scratch since relative urls to filesystem can be
replaced
+// by absolute during save/load
+SwDoc* pDoc = createSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Insert("Hyperlink1");
+pWrtShell->SplitNode();
+pWrtShell->Insert("Hyperlink2");
+pWrtShell->SplitNode();
+pWrtShell->Insert("Hyperlink3");
+pWrtShell->SplitNode();
+pWrtShell->Insert("Hyperlink4");
+pWrtShell->SplitNode();
+pWrtShell->Insert("Hyperlink5");
+pWrtShell->SplitNode();
+
+// Normal external URL
+uno::Reference xRun(getRun(getParagraph(1), 1),
uno::UNO_QUERY);
+xRun->setPropertyValue("HyperLinkURL",
uno::Any(OUString("http://libreoffice.org/;)));
+
+// Bookmark reference
+xRun.set(getRun(getParagraph(2), 1), uno::UNO_QUERY);
+xRun->setPropertyValue("HyperLinkURL",
uno::Any(OUString("#some_bookmark")));
+
+// Filesystem absolute link
+xRun.set(getRun(getParagraph(3), 1), uno::UNO_QUERY);
+xRun->setPropertyValue("HyperLinkURL", uno::Any(OUString("C:\\test.txt")));
+
+// Filesystem relative link
+xRun.set(getRun(getParagraph(4), 1), uno::UNO_QUERY);
+xRun->setPropertyValue("HyperLinkURL",
uno::Any(OUString("..\\..\\test.odt")));
+
+// Filesystem relative link
+xRun.set(getRun(getParagraph(5), 1), uno::UNO_QUERY);
+xRun->setPropertyValue("HyperLinkURL",
uno::Any(OUString(".\\another.odt")));
+
+// Export
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+uno::Sequence aStoreProperties
+= { comphelper::makePropertyValue("FilterName", OUString("HTML
(StarWriter)")) };
+xStorable->storeToURL(maTempFile.GetURL(), aStoreProperties);
+
+htmlDocUniquePtr pHtmlDoc = parseHtml(maTempFile);
+CPPUNIT_ASSERT(pHtmlDoc);
+
+CPPUNIT_ASSERT_EQUAL(OUString("http://libreoffice.org/;),
+ getXPath(pHtmlDoc, "/html/body/p[1]/a", "href"));
+CPPUNIT_ASSERT_EQUAL(OUString("#some_bookmark"),
+ getXPath(pHtmlDoc, "/html/body/p[2]/a", "href"));
+CPPUNIT_ASSERT_EQUAL(OUString("C:\\test.txt"), getXPath(pHtmlDoc,
"/html/body/p[3]/a", "href"));
+CPPUNIT_ASSERT_EQUAL(OUString("..\\..\\test.odt"),
+ getXPath(pHtmlDoc, "/html/body/p[4]/a", "href"));
+CPPUNIT_ASSERT_EQUAL(OUString(".\\another.odt"),
+ getXPath(pHtmlDoc, "/html/body/p[5]/a", "href"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/html/wrthtml.cxx
b/sw/source/filter/html/wrthtml.cxx
index 0cede88912d3..f0a963972859 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -1334,7 +1334,8 @@ OUString SwHTMLWriter::convertHyperlinkHRefValue(const
OUString& rURL)
{
// Link is not started from "#", so looks like external link. Encode
this URL.
INetURLObject aURL(sURL);
-sURL = aURL.GetMainURL(INetURLObject::DecodeMechanism::NONE);
+if (!aURL.HasError())
+sURL = aURL.GetMainURL(INetURLObject::DecodeMechanism::NONE);
}
return URIHelper::simpleNormalizedMakeRelative( GetBaseURL(), sURL );
}
[Libreoffice-bugs] [Bug 150711] registe rissue
https://bugs.documentfoundation.org/show_bug.cgi?id=150711 --- Comment #1 from salona --- Created attachment 182108 --> https://bugs.documentfoundation.org/attachment.cgi?id=182108=edit showing the esheeq Thanks https://king.egy-best.me/egybest-608d8/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150711] New: registe rissue
https://bugs.documentfoundation.org/show_bug.cgi?id=150711 Bug ID: 150711 Summary: registe rissue Product: LibreOffice Version: 3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: salona.uploa...@gmail.com Description: shows error bug https://king.egy-best.me/egybest-608d8/ Actual Results: tasgs Expected Results: rewrew Reproducible: Always User Profile Reset: No Additional Info: rewrwe -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150137] Crash when parsing an XML with undeclared namespace
https://bugs.documentfoundation.org/show_bug.cgi?id=150137
--- Comment #3 from Amar ---
So what's the expected behavior?
I've created a test case and it fails with the fast parser and provided xml.
If I pass the IgnoreMissingNSDecl arg (which was implemented in the mentioned
commit), then it's not failing anymore. Should m_bIgnoreMissingNSDecl in
fastparser.cxx by default be set to true instead of false?
I am missing the big picture here, as I just started with the project.
The exception raising part is this:
> if( !nNamespace && !m_bIgnoreMissingNSDecl )
> throw SAXException("No namespace defined for " +
> OUString(XML_CAST(pPrefix),
> nPrefixLen, RTL_TEXTENCODING_UTF8), Reference< XInterface
> >(), Any());
and it actually never gets into:
> if ( !m_bIgnoreMissingNSDecl || URI != nullptr )
> sNamespace = OUString( XML_CAST( URI ), strlen( XML_CAST( URI )),
> RTL_TEXTENCODING_UTF8 )
or the else case
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Hossein changed: What|Removed |Added Depends on||150710 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150710 [Bug 150710] Wrong Kashida in Arabic text when enabling "Toggle formatting marks" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Hossein changed: What|Removed |Added Depends on||150710 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150710 [Bug 150710] Wrong Kashida in Arabic text when enabling "Toggle formatting marks" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150710] Wrong Kashida in Arabic text when enabling "Toggle formatting marks"
https://bugs.documentfoundation.org/show_bug.cgi?id=150710 Hossein changed: What|Removed |Added CC||kha...@aliftype.com Blocks||43808, 150285 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9627 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=43808 [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL) https://bugs.documentfoundation.org/show_bug.cgi?id=150285 [Bug 150285] [META] Problems with Justified Arabic/Persian text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150710] New: Wrong Kashida in Arabic text when enabling "Toggle formatting marks"
https://bugs.documentfoundation.org/show_bug.cgi?id=150710
Bug ID: 150710
Summary: Wrong Kashida in Arabic text when enabling "Toggle
formatting marks"
Product: LibreOffice
Version: 7.5.0.0 alpha0+ Master
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Writer
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: hoss...@libreoffice.org
Description:
When enabling the display of special characters, with "Toggle formatting marks
(CTRL+F10)", kashida placement becomes wrong.
Steps to Reproduce:
1. Open attachment 169697 from bug 139627
2. Choose "Toggle formatting marks" from toolbar or press "CTRL+F10"
Actual Results:
Bad placement of kashida, drawn in different color (blue)
Expected Results:
Correct placement of kashida, as it is without showing special characters.
Note: In previous versions of LibreOffice, this bug was happening. This was
because with or without this option ("Toggle formatting marks"), the position
of the kashida was similar (and incorrect).
Reproducible: Always
User Profile Reset: No
Additional Info:
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: aea89831f93b501738e62db9787a1085fd483193
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150705] Paste contents in Draw looses accents
https://bugs.documentfoundation.org/show_bug.cgi?id=150705 --- Comment #2 from V Stuart Foote --- Created attachment 182107 --> https://bugs.documentfoundation.org/attachment.cgi?id=182107=edit sample text pasted into sd Textboxes Inserting the following string: este é um teste de digitação -- into a sd Text box directly -- into a sd Drawing object shape's text box -- copy / paster into text box of a sd Drawing object from Writer no issue with style default Liberation Sans; or other fonts with coverage of the glyps. Even for fonts without coverage get something usable via fallback--Segoe here. Maybe see what happens with a neutral (so not-UI/unlikely-a fallback) font--do the glyphs drop if the font selection is made changing to 'Symbola' for example. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150705] Paste contents in Draw looses accents
https://bugs.documentfoundation.org/show_bug.cgi?id=150705 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 --- Comment #1 from V Stuart Foote --- Can not confirm on Windows build Version: 7.4.2.0.0+ (x64) / LibreOffice Community Build ID: ea179bb6f914cb426d1282f2556a72cb3732ebc8 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL The sd Text box held by a sd Drawing object sets a default font of Liberation Sans Text copied from writer, or an external source (e.g. translate.google.com) get rendered fully into the sd Text box in the default font. Is there some sort font fall back issue happening with kf5 that it is loosing glyphs? Is the glyph actually in the string, are the missing glyph actually there if you copy it back out of the sd drawing object and paste it somewhere? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145614] Convert #define to enum or constexpr
https://bugs.documentfoundation.org/show_bug.cgi?id=145614 --- Comment #12 from Commit Notification --- Liu Hao committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aea89831f93b501738e62db9787a1085fd483193 tdf#145614 Convert #define to enum or constexpr It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/inc/ShapeController.h | 29 +
1 file changed, 16 insertions(+), 13 deletions(-)
New commits:
commit aea89831f93b501738e62db9787a1085fd483193
Author: Liu Hao
AuthorDate: Sun Aug 14 22:45:03 2022 +0800
Commit: Hossein
CommitDate: Wed Aug 31 00:24:03 2022 +0200
tdf#145614 Convert #define to enum or constexpr
Rename CommandId to ShapeControllerCommandID
Change-Id: I41369ba893d68df876c8200aae19cc617837d077
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138251
Tested-by: Jenkins
Reviewed-by: Hossein
diff --git a/chart2/source/controller/inc/ShapeController.h
b/chart2/source/controller/inc/ShapeController.h
index 392c28d2fe4c..e326450661d3 100644
--- a/chart2/source/controller/inc/ShapeController.h
+++ b/chart2/source/controller/inc/ShapeController.h
@@ -19,19 +19,22 @@
#ifndef CHART_SHAPECONTROLLER_H
#define CHART_SHAPECONTROLLER_H
-//Command Ids:
-#define COMMAND_ID_FORMAT_LINE 1
-#define COMMAND_ID_FORMAT_AREA 2
-#define COMMAND_ID_TEXT_ATTRIBUTES 3
-#define COMMAND_ID_TRANSFORM_DIALOG 4
-#define COMMAND_ID_OBJECT_TITLE_DESCRIPTION 5
-#define COMMAND_ID_RENAME_OBJECT6
-#define COMMAND_ID_BRING_TO_FRONT 8
-#define COMMAND_ID_FORWARD 9
-#define COMMAND_ID_BACKWARD10
-#define COMMAND_ID_SEND_TO_BACK11
-#define COMMAND_ID_FONT_DIALOG 15
-#define COMMAND_ID_PARAGRAPH_DIALOG16
+//Shape Controller Command Ids:
+enum ShapeControllerCommandID
+{
+COMMAND_ID_FORMAT_LINE = 1,
+COMMAND_ID_FORMAT_AREA = 2,
+COMMAND_ID_TEXT_ATTRIBUTES = 3,
+COMMAND_ID_TRANSFORM_DIALOG = 4,
+COMMAND_ID_OBJECT_TITLE_DESCRIPTION = 5,
+COMMAND_ID_RENAME_OBJECT= 6,
+COMMAND_ID_BRING_TO_FRONT = 8,
+COMMAND_ID_FORWARD = 9,
+COMMAND_ID_BACKWARD = 10,
+COMMAND_ID_SEND_TO_BACK = 11,
+COMMAND_ID_FONT_DIALOG = 15,
+COMMAND_ID_PARAGRAPH_DIALOG = 16
+};
#endif
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/a11y/atktable.cxx | 74 ---
vcl/unx/gtk3/a11y/atkwrapper.cxx |2 +
vcl/unx/gtk3/a11y/atkwrapper.hxx |2 +
3 files changed, 66 insertions(+), 12 deletions(-)
New commits:
commit ef2ab3326ab1390c5c08d56d65af6dedd67c894f
Author: Michael Weghorn
AuthorDate: Tue Aug 30 19:03:37 2022 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 30 23:53:59 2022 +0200
gtk3 a11y: Implement methods for (un)selecting table rows/cols
The `XAccessibleTableSelection` interface provides the
required methods.
This e.g. makes (un)selecting rows and columns in a
Writer table using Accerciser as described in
Change-Id I0c239c0d36a073cd63a35ca7d0802cf5591d9738
("sw a11y: Don't confuse row and column") work with
the gtk3 VCL plugin as well.
Change-Id: Ic17cc74c209b08907adedfa59ac586732b5ec3bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139065
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/unx/gtk3/a11y/atktable.cxx b/vcl/unx/gtk3/a11y/atktable.cxx
index 11df8a73ce1c..04e9d7645cc5 100644
--- a/vcl/unx/gtk3/a11y/atktable.cxx
+++ b/vcl/unx/gtk3/a11y/atktable.cxx
@@ -24,6 +24,7 @@
#include "atkwrapper.hxx"
#include
+#include
#include
using namespace ::com::sun::star;
@@ -71,6 +72,23 @@ static
css::uno::Reference
return css::uno::Reference();
}
+static css::uno::Reference
+getTableSelection(AtkTable *pTable)
+{
+AtkObjectWrapper *pWrap = ATK_OBJECT_WRAPPER(pTable);
+if (pWrap)
+{
+if (!pWrap->mpTableSelection.is())
+{
+pWrap->mpTableSelection.set(pWrap->mpContext, css::uno::UNO_QUERY);
+}
+
+return pWrap->mpTableSelection;
+}
+
+return
css::uno::Reference();
+}
+
/*/
extern "C" {
@@ -466,37 +484,69 @@ table_wrapper_is_selected( AtkTable *table,
/*/
static gboolean
-table_wrapper_add_row_selection( AtkTable *, gint )
+table_wrapper_add_row_selection(AtkTable *pTable, gint row)
{
-g_warning( "FIXME: no simple analogue for add_row_selection" );
-return 0;
+try {
+css::uno::Reference
xTableSelection = getTableSelection(pTable);
+if (xTableSelection.is())
+return xTableSelection->selectRow(row);
+}
+catch(const uno::Exception&) {
+g_warning( "Exception in selectRow()" );
+}
+
+return false;
}
/*/
static gboolean
-table_wrapper_remove_row_selection( AtkTable *, gint )
+table_wrapper_remove_row_selection(AtkTable *pTable, gint row)
{
-g_warning( "FIXME: no simple analogue for remove_row_selection" );
-return 0;
+try {
+css::uno::Reference
xTableSelection = getTableSelection(pTable);
+if (xTableSelection.is())
+return xTableSelection->unselectRow(row);
+}
+catch(const uno::Exception&) {
+g_warning( "Exception in unselectRow()" );
+}
+
+return false;
}
/*/
static gboolean
-table_wrapper_add_column_selection( AtkTable *, gint )
+table_wrapper_add_column_selection(AtkTable *pTable, gint column)
{
-g_warning( "FIXME: no simple analogue for add_column_selection" );
-return 0;
+try {
+css::uno::Reference
xTableSelection = getTableSelection(pTable);
+if (xTableSelection.is())
+return xTableSelection->selectColumn(column);
+}
+catch(const uno::Exception&) {
+g_warning( "Exception in selectColumn()" );
+}
+
+return false;
}
/*/
static gboolean
-table_wrapper_remove_column_selection( AtkTable *, gint )
+table_wrapper_remove_column_selection(AtkTable *pTable, gint column)
{
-g_warning( "FIXME: no simple analogue for remove_column_selection" );
-return 0;
+try {
+css::uno::Reference
xTableSelection = getTableSelection(pTable);
+if (xTableSelection.is())
+return xTableSelection->unselectColumn(column);
+}
+catch(const uno::Exception&) {
+g_warning( "Exception in unselectColumn()" );
+}
+
+return false;
}
/*/
diff --git a/vcl/unx/gtk3/a11y/atkwrapper.cxx b/vcl/unx/gtk3/a11y/atkwrapper.cxx
index f798364e2003..c99290fd4a9a 100644
--- a/vcl/unx/gtk3/a11y/atkwrapper.cxx
+++ b/vcl/unx/gtk3/a11y/atkwrapper.cxx
@@ -683,6 +683,7 @@ atk_object_wrapper_init (AtkObjectWrapper *wrapper,
wrapper->mpImage = nullptr;
wrapper->mpSelection = nullptr;
wrapper->mpTable = nullptr;
+ wrapper->mpTableSelection = nullptr;
wrapper->mpText = nullptr;
wrapper->mpValue
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/acctable.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 0a8efec1cd6ad5c8a3c09d4266067944f5d9d7be
Author: Michael Weghorn
AuthorDate: Tue Aug 30 18:58:48 2022 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 30 23:52:15 2022 +0200
sw a11y: Don't confuse row and column
The previous use of `isAccessibleColumnSelected`
instead of `isAccessibleRowSelected` e.g. caused
the row not to be selected when selecting
the a11y object for a Writer table in Accerciser's
treeview of the a11y hierarchy and typing this
in Accerciser's IPython console with the qt6
VCL plugin in use:
In [25]: acc.queryTable().addColumnSelection(0)
Out[25]: True
In [26]: acc.queryTable().addRowSelection(0)
Out[26]: True
Change-Id: I0c239c0d36a073cd63a35ca7d0802cf5591d9738
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139064
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/sw/source/core/access/acctable.cxx
b/sw/source/core/access/acctable.cxx
index 75257baa5ca1..538eab08d440 100644
--- a/sw/source/core/access/acctable.cxx
+++ b/sw/source/core/access/acctable.cxx
@@ -1561,7 +1561,7 @@ sal_Bool SAL_CALL SwAccessibleTable::selectRow( sal_Int32
row )
{
SolarMutexGuard g;
-if( isAccessibleColumnSelected( row ) )
+if( isAccessibleRowSelected( row ) )
return true;
tools::Long lColumnCount = getAccessibleColumnCount();
[Libreoffice-commits] core.git: svx/source
svx/source/table/accessibletableshape.cxx | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
New commits:
commit d079415f7ddc4e47cbdfe527d1b5dcd3565599dc
Author: Michael Weghorn
AuthorDate: Tue Aug 30 15:21:10 2022 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 30 23:51:22 2022 +0200
svx a11y: Simplify AccessibleTableShapeImpl::getColumnAndRow
Just use division and modulo instead of a custom loop.
Change-Id: I70a975d6c73d4c3f645d250b9c571fe6e35cd702
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139063
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/svx/source/table/accessibletableshape.cxx
b/svx/source/table/accessibletableshape.cxx
index 3876c9104710..50d213fda3e9 100644
--- a/svx/source/table/accessibletableshape.cxx
+++ b/svx/source/table/accessibletableshape.cxx
@@ -199,17 +199,14 @@ Reference< XAccessible >
AccessibleTableShapeImpl::getAccessibleChild(sal_Int32
void AccessibleTableShapeImpl::getColumnAndRow( sal_Int32 nChildIndex,
sal_Int32& rnColumn, sal_Int32& rnRow )
{
-rnRow = 0;
-rnColumn = nChildIndex;
-
if( mxTable.is() )
{
const sal_Int32 nColumnCount = mxTable->getColumnCount();
-while( rnColumn >= nColumnCount )
-{
-rnRow++;
-rnColumn -= nColumnCount;
-}
+if (nColumnCount == 0)
+throw IndexOutOfBoundsException();
+
+rnColumn = nChildIndex % nColumnCount;
+rnRow = nChildIndex / nColumnCount;
if( rnRow < mxTable->getRowCount() )
return;
[Libreoffice-commits] core.git: svx/source
svx/source/table/accessiblecell.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 8acbe35ee38419bfa484c8c43e810c8ac68201c7 Author: Michael Weghorn AuthorDate: Tue Aug 30 15:04:09 2022 +0200 Commit: Michael Weghorn CommitDate: Tue Aug 30 23:49:09 2022 +0200 svx a11y: Drop TODO that doesn't need action `AccessibleTextHelper_Impl::getAccessibleChild` that gets called from `AccessibleTextHelper::GetChild` throws an `IndexOutOfBoundsException` on invalid index which is the expected behavior here and what the comment for `AccessibleCell::getAccessibleChild` says, so drop the TODO that seems to have been there to check this. Change-Id: If04438cc3625ce438ada75bb6dea7e6c88c3e894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139062 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/svx/source/table/accessiblecell.cxx b/svx/source/table/accessiblecell.cxx index 84dbe792cf08..1d6321084b22 100644 --- a/svx/source/table/accessiblecell.cxx +++ b/svx/source/table/accessiblecell.cxx @@ -167,7 +167,6 @@ Reference SAL_CALL AccessibleCell::getAccessibleChild (sal_Int32 nI SolarMutexGuard aSolarGuard; ThrowIfDisposed (); -// todo: does GetChild throw IndexOutOfBoundsException? return mpText->GetChild (nIndex); }
[Libreoffice-bugs] [Bug 150626] No autofocus when hovering cursor over comboboxes or dropdownboxes
https://bugs.documentfoundation.org/show_bug.cgi?id=150626 --- Comment #6 from stragu --- Just to add some more context, it looks like it stopped being possible scrolling these unfocused elements in the 7.0 branch, for GTK3 on Linux. However, for VCL plugins Gen and KF5, I can confirm that it started not being possible to scroll them in 7.5. So, if anything, this change makes it more consistent with what was already the case with GTK3. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/global.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ac371ee822e6640a8e2d6591236c22d1ab679462 Author: Eike Rathke AuthorDate: Tue Aug 30 16:55:20 2022 +0200 Commit: Eike Rathke CommitDate: Tue Aug 30 22:55:14 2022 +0200 Use ScFunctionList::IsEnglishFunctionNames() Change-Id: I21a7bf18c2117187b2e8c770b9367f46323b2c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139054 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx index 58b3a1e70281..a7b63ce1eb40 100644 --- a/sc/source/core/data/global.cxx +++ b/sc/source/core/data/global.cxx @@ -655,7 +655,7 @@ const InputHandlerFunctionNames& ScGlobal::GetInputHandlerFunctionNames() const OUString aParenthesesReplacement( cParenthesesReplacement); const ScFunctionList* pFuncList = GetStarCalcFunctionList(); const sal_uInt32 nListCount = pFuncList->GetCount(); -const CharClass* pCharClass = (SC_MOD()->GetFormulaOptions().GetUseEnglishFuncName() +const CharClass* pCharClass = (pFuncList->IsEnglishFunctionNames() ? ScCompiler::GetCharClassEnglish() : ScCompiler::GetCharClassLocalized()); for (sal_uInt32 i=0; i < nListCount; ++i)
[Libreoffice-bugs] [Bug 150709] New: Autocorrect and toolbar bulleted and numbered list not assigned to style
https://bugs.documentfoundation.org/show_bug.cgi?id=150709 Bug ID: 150709 Summary: Autocorrect and toolbar bulleted and numbered list not assigned to style Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pub...@mellomrommet.no Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: nb-NO (en_US.UTF-8); UI: en-US 7.3.5-3 Calc: threaded Using styles with Writer is mostly very powerful and flexible, with efficient keyboard shortcuts like to format the paragraph as Heading 1, as Body Text, etc. But when working with lists, there seems to be no such efficiency. There is AutoCorrect to automatically insert lists when typing "1. some text" or "* some text", or F12 to toggle lists or normal paragraphs, but there seems to be way to make these shortcuts play along with styles. Because of this, using keyboard shortcuts like F12 or AutoCorrect is actually counter-productive unless you happen to like the default formatting. Confusingly, the menu item Format > Bullets and Numbering... also is completely disconnected from any styles, while the neighbor menu Styles list several numbering styles. Editing these of course has zero effect on lists created via the mentioned method. Steps to reproduce: 1. Tools > AutoCorrect > Options: Tick "Bulleted and numbered lists". 2. Produce some text preceded by a number and a dot (1. some text) or press F12. 3. Edit the resulting list to your liking (Format > Bullets and Numbering... or F11 to select desired style). 4. Repeat when you need another list. Reproducible: Always. Expected / wanted behavior: 1. Tools > AutoCorrect > Options: Tick "Bulleted and numbered lists". 2. Select "Bulleted and numbered lists" and click "Edit". 3. Select preferred style for lists and (optional) edit the style to your liking. 4. Produce some text preceded by a number and a dot (1. some text). 5. Enjoy ordered lists with consistent styling. In short, ordered lists should default to a paragraph style. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - instsetoo_native/CustomTarget_install.mk
instsetoo_native/CustomTarget_install.mk |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 814968fc7acc470a911c013656d4ef57267e44be Author: Andras Timar AuthorDate: Tue Aug 30 22:47:25 2022 +0200 Commit: Andras Timar CommitDate: Tue Aug 30 22:47:25 2022 +0200 [cp] Collabora Office do not have langpacks on macOS Change-Id: I5ad3ea78fcc27e2c786f4264e941da8d8b94fec5 diff --git a/instsetoo_native/CustomTarget_install.mk b/instsetoo_native/CustomTarget_install.mk index bb34a34450d7..f70956fa899d 100644 --- a/instsetoo_native/CustomTarget_install.mk +++ b/instsetoo_native/CustomTarget_install.mk @@ -111,8 +111,9 @@ else # LIBO_TEST_INSTALL $(if $(and $(filter HELP,$(BUILD_TYPE)), $(filter-out MACOSX,$(OS))), \ $(foreach lang,$(gb_HELP_LANGS), \ ":$(lang)::-helppack:$(pkgformat):nostrip" )) \ - $(foreach lang,$(instsetoo_native_WITH_LANG), \ - ":$(lang)::-languagepack:$(pkgformat):nostrip" ) ))) + $(if $(filter-out MACOSX,$(OS)), \ + $(foreach lang,$(instsetoo_native_WITH_LANG), \ + ":$(lang)::-languagepack:$(pkgformat):nostrip" )) ))) endif # LIBO_TEST_INSTALL touch $@ $(call gb_Trace_EndRange,$(subst $(WORKDIR)/,,$@),PRL)
[Libreoffice-bugs] [Bug 40917] UI: Calc currently scrolling only by full row height
https://bugs.documentfoundation.org/show_bug.cgi?id=40917 Justin L changed: What|Removed |Added Summary|UI: scrolling only by full |UI: Calc currently |row height |scrolling only by full row ||height Hardware|x86 (IA32) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150691] Tabs turned into spaces by carriage returns in lists
https://bugs.documentfoundation.org/show_bug.cgi?id=150691 --- Comment #6 from William Friedman --- Thank you for linking to that other bug report. There is definitely something or several somethings wrong here, either in the description of the name of the option, the function of the program, or the help information. 1) The name of the option says "delete," but in fact the tab is *replaced* with a space. 2) In the help file for the autocorrect options (https://help.libreoffice.org/7.3/en-US/text/shared/01/06040100.html), it states: "Delete spaces and tabs at beginning and end of paragraph Removes spaces and tabs at the beginning of a paragraph. To use this option, the Apply Styles option must also be selected. Delete spaces and tabs at end and start of line Removes spaces and tabs at the beginning of each line. To use this option, the Apply Styles option must also be selected." I have the Apply Styles option *unchecked* and yet my tabs were "deleted" (again, replaced with a space). I'm happy to demonstrate this with a screencast if necessary. So either the help is wrong, or the program is not functioning as described in the help. 3) If the feature is only meant to work with lists, I think that should be made explicit in the name of the feature or at least in the help text. If it is meant to work with other styles as well, as far as I can tell it doesn't. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #28 from Commit Notification --- cutamar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/45394fcf7e45f623add7ed3c6dc43e6d6f89158c tdf#141908 Replace usage of sal_Int32 with Color in unit tests It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.4.0 |target:7.3.0 target:7.4.0 |reviewed:2022 |reviewed:2022 target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/qa svgio/qa vcl/qa writerperfect/CppunitTest_writerperfect_import.mk writerperfect/qa
sd/qa/unit/export-tests-ooxml2.cxx|4 ++--
sd/qa/unit/export-tests-ooxml3.cxx|8
svgio/qa/cppunit/SvgRead.cxx |8
vcl/qa/cppunit/drawmode.cxx |8 ++--
vcl/qa/cppunit/outdev.cxx |4 +---
writerperfect/CppunitTest_writerperfect_import.mk |1 +
writerperfect/qa/unit/ImportTest.cxx |4 ++--
7 files changed, 16 insertions(+), 21 deletions(-)
New commits:
commit 45394fcf7e45f623add7ed3c6dc43e6d6f89158c
Author: cutamar
AuthorDate: Sun Aug 28 02:42:21 2022 +0200
Commit: Stephan Bergmann
CommitDate: Tue Aug 30 22:33:06 2022 +0200
tdf#141908 Replace usage of sal_Int32 with Color in unit tests
Change-Id: Ifb5ff2e6d5ed28bcb9e190d7f2deaaa970693cbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138938
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx
b/sd/qa/unit/export-tests-ooxml2.cxx
index c74f5e41d925..6787133e3705 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -1034,8 +1034,8 @@ void SdOOXMLExportTest2::testTdf105739()
com::sun::star::awt::Gradient aFillGradient;
aXBackgroundPropSet->getPropertyValue("FillGradient") >>=
aFillGradient;
CPPUNIT_ASSERT_EQUAL(int(awt::GradientStyle_LINEAR),
static_cast(aFillGradient.Style));
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xff), aFillGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00b050), aFillGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, Color(ColorTransparency,
aFillGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(Color(0x00b050), Color(ColorTransparency,
aFillGradient.EndColor));
}
xShell->DoClose();
diff --git a/sd/qa/unit/export-tests-ooxml3.cxx
b/sd/qa/unit/export-tests-ooxml3.cxx
index 6100a9f64db6..d20c56d71766 100644
--- a/sd/qa/unit/export-tests-ooxml3.cxx
+++ b/sd/qa/unit/export-tests-ooxml3.cxx
@@ -1531,8 +1531,8 @@ void SdOOXMLExportTest3::testTdf127372()
uno::Reference xShape(getShapeFromPage(0, 0,
xDocShRef));
awt::Gradient aTransparenceGradient;
xShape->getPropertyValue("FillTransparenceGradient") >>=
aTransparenceGradient;
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00),
aTransparenceGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00), aTransparenceGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(COL_BLACK, Color(ColorTransparency,
aTransparenceGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(COL_BLACK, Color(ColorTransparency,
aTransparenceGradient.EndColor));
}
void SdOOXMLExportTest3::testTdf127379()
@@ -1558,8 +1558,8 @@ void SdOOXMLExportTest3::testTdf127379()
awt::Gradient aGradient;
CPPUNIT_ASSERT(aXBackgroundPropSet->getPropertyValue("FillGradient") >>=
aGradient);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xFF), aGradient.StartColor);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x2A6099), aGradient.EndColor);
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, Color(ColorTransparency,
aGradient.StartColor));
+CPPUNIT_ASSERT_EQUAL(Color(0x2A6099), Color(ColorTransparency,
aGradient.EndColor));
}
void SdOOXMLExportTest3::testTdf98603()
diff --git a/svgio/qa/cppunit/SvgRead.cxx b/svgio/qa/cppunit/SvgRead.cxx
index 127de19a7bbd..a26556dd7a5c 100644
--- a/svgio/qa/cppunit/SvgRead.cxx
+++ b/svgio/qa/cppunit/SvgRead.cxx
@@ -81,9 +81,9 @@ void TestParsing::testSimpleRectangle()
CPPUNIT_ASSERT_EQUAL(basegfx::B2DRange(10, 10, 110, 110),
pDrawRect->maRectangle);
CPPUNIT_ASSERT_EQUAL(3.0, pDrawRect->mnStrokeWidth);
CPPUNIT_ASSERT(bool(pDrawRect->mpStrokeColor));
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xff),
sal_Int32(Color(*pDrawRect->mpStrokeColor)));
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, Color(*pDrawRect->mpStrokeColor));
CPPUNIT_ASSERT(bool(pDrawRect->mpFillColor));
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00cc00),
sal_Int32(Color(*pDrawRect->mpFillColor)));
+CPPUNIT_ASSERT_EQUAL(Color(0x00cc00), Color(*pDrawRect->mpFillColor));
CPPUNIT_ASSERT_DOUBLES_EQUAL(0.1, pDrawRect->mnOpacity, 1E-12);
}
@@ -113,9 +113,9 @@ void TestParsing::testPath()
basegfx::utils::exportToSvgD(pDrawPath->maPolyPolygon, true, true, false));
CPPUNIT_ASSERT_EQUAL(0.0, pDrawPath->mnStrokeWidth);
CPPUNIT_ASSERT(bool(pDrawPath->mpStrokeColor));
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0xff),
sal_Int32(Color(*pDrawPath->mpStrokeColor)));
+CPPUNIT_ASSERT_EQUAL(COL_WHITE, Color(*pDrawPath->mpStrokeColor));
CPPUNIT_ASSERT(bool(pDrawPath->mpFillColor));
-CPPUNIT_ASSERT_EQUAL(sal_Int32(0x007aff),
sal_Int32(Color(*pDrawPath->mpFillColor)));
+CPPUNIT_ASSERT_EQUAL(Color(0x007aff), Color(*pDrawPath->mpFillColor));
CPPUNIT_ASSERT_DOUBLES_EQUAL(0.1, pDrawPath->mnOpacity, 1E-12);
}
diff --git a/vcl/qa/cppunit/drawmode.cxx b/vcl/qa/cppunit/drawmode.cxx
index f2b59dc8440c..e3792ae1f29f
[Libreoffice-bugs] [Bug 150688] When using a small screen and pressing 2 arrows for more buttons: CRITICAL message (gtk only)
https://bugs.documentfoundation.org/show_bug.cgi?id=150688 Julien Nabet changed: What|Removed |Added CC||caol...@redhat.com --- Comment #5 from Julien Nabet --- Caolán: thought you might be interested in this one since it's gtk related. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150688] When using a small screen and pressing 2 arrows for more buttons: CRITICAL message (gtk only)
https://bugs.documentfoundation.org/show_bug.cgi?id=150688 Julien Nabet changed: What|Removed |Added Summary|When using a small screen |When using a small screen |and pressing 2 arrows for |and pressing 2 arrows for |more buttons: CRITICAL |more buttons: CRITICAL |message |message (gtk only) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150688] When using a small screen and pressing 2 arrows for more buttons: CRITICAL message
https://bugs.documentfoundation.org/show_bug.cgi?id=150688 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150688] When using a small screen and pressing 2 arrows for more buttons: CRITICAL message
https://bugs.documentfoundation.org/show_bug.cgi?id=150688 --- Comment #4 from Julien Nabet --- Created attachment 182106 --> https://bugs.documentfoundation.org/attachment.cgi?id=182106=edit bt with debug symbols I used: export G_DEBUG=fatal_warnings but then I couldn't attach gdb to the soffice process because all was stuck when reproducing the pb. Then I tried to use --backtrace when launching soffice but it stopped because of Java part which is still broken after all these years but that's another story. So I gave a try with Calc and could retrieved a bt since it doesn't use Java at its launching. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150688] When using a small screen and pressing 2 arrows for more buttons: CRITICAL message
https://bugs.documentfoundation.org/show_bug.cgi?id=150688 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I can reproduce this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150708] New: Inserting a page break generate 2 warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150708 Bug ID: 150708 Summary: Inserting a page break generate 2 warnings Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: buzea.bog...@libreoffice.org Description: Open a new LibreOffice Writer document. Insert a Page Break (OR Ctrl+Enter). In the terminal, in the dbg version of LibreOffice I get this messages: warn:legacy.osl:84958:84958:sw/source/core/access/accmap.cxx:1064: invalid event combination warn:legacy.osl:84958:84958:sw/source/core/access/acccontext.cxx:442: fire event for disposed frame? Steps to Reproduce: 1. See description Actual Results: 2 warnings Expected Results: No warning Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 4c96abd81460977d413d4d28e891bbbac5769ede CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148015] shift+tab disappear when I finish a paragraph in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=148015 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0691 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150691] Tabs turned into spaces by carriage returns in lists
https://bugs.documentfoundation.org/show_bug.cgi?id=150691 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8015 CC||heiko.tietze@documentfounda ||tion.org, ||vstuart.fo...@utsa.edu --- Comment #5 from Telesto --- (In reply to William Friedman from comment #4) > Thank you Telesto! Turning off the options "delete spaces and tabs at > beginning and end of paragraph" and "delete spaces and tabs at end and start > of line" fixed the problem. A reminds me of bug 148015 > Two more questions, however, which might reveal an actual bug: > > 1) Why is the tab *replaced* with a space rather than deleted entirely, as > the name of the autocorrect option says? > > 2) The function of these autocorrect options seems inconsistent. If I run > the same test in Default Paragraph Style -- typing a word, hitting > control-enter, entering a tab and some text, then hitting enter -- nothing > happens. The tab stays put. Why is the tab "deleted" (actually, replaced > with a space, as I describe above) in a list but not in ordinary text? > > Thank you for your attention! Not that good in answering those questions.. adding a few people in CC.. the might know -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150687] Simple inserting of text: too many warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150687 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #2 from BogdanB --- If I go to Tools - Autotext - Only for Templates - Header Brochure I get warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/format.cxx:217: ~SwFormat: format still has clients on death, but parent format is missing: Frameformat warn:sw:79478:79478:sw/source/core/swg/SwXMLTextBlocks1.cxx:249: com.sun.star.io.IOException message: "Element does not exist and cannot be created: "atevent.xml" at /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/package/source/xstor/xstorage.cxx:1984" warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/format.cxx:217: ~SwFormat: format still has clients on death, but parent format is missing: Frameformat warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration. warn:sw.core:79478:79478:sw/source/core/attr/format.cxx:217: ~SwFormat: format still has clients on death, but parent format is missing: Frameformat -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150691] Tabs turned into spaces by carriage returns in lists
https://bugs.documentfoundation.org/show_bug.cgi?id=150691 --- Comment #4 from William Friedman --- Thank you Telesto! Turning off the options "delete spaces and tabs at beginning and end of paragraph" and "delete spaces and tabs at end and start of line" fixed the problem. Two more questions, however, which might reveal an actual bug: 1) Why is the tab *replaced* with a space rather than deleted entirely, as the name of the autocorrect option says? 2) The function of these autocorrect options seems inconsistent. If I run the same test in Default Paragraph Style -- typing a word, hitting control-enter, entering a tab and some text, then hitting enter -- nothing happens. The tab stays put. Why is the tab "deleted" (actually, replaced with a space, as I describe above) in a list but not in ordinary text? Thank you for your attention! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150707] New: Saving a new document gets some warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150707 Bug ID: 150707 Summary: Saving a new document gets some warnings Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: buzea.bog...@libreoffice.org Description: Open a new Writer document. Type anything. Save it. In the terminal I get this messages. Should not be the case since I am using ODF (standard) with the default style and no change in styles/structure of the file. warn:legacy.osl:74543:74543:xmloff/source/style/xmlexppr.cxx:907: no prop type specified warn:legacy.osl:74543:74543:xmloff/source/style/xmlexppr.cxx:907: no prop type specified warn:legacy.osl:74543:74543:xmloff/source/style/xmlexppr.cxx:907: no prop type specified warn:legacy.osl:74543:74543:xmloff/source/style/xmlexppr.cxx:907: no prop type specified Steps to Reproduce: 1. See description Actual Results: Warnings for a default style in the default format with no change Expected Results: No warnings. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 4c96abd81460977d413d4d28e891bbbac5769ede CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150706] New: Export as PDF warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150706 Bug ID: 150706 Summary: Export as PDF warnings Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: buzea.bog...@libreoffice.org Description: Open a new Writer document, type "A" and press Export Directly as PDF. If I save the document I get in terminal messages: warn:vcl.gtk:68739:68739:vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:1134: Handle unknown control 210 warn:vcl.gtk:68739:68739:vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:1372: enable unknown control 210 warn:vcl.gtk:68739:68739:vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:1134: Handle unknown control 1 warn:vcl.gtk:68739:68739:vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:1386: Set label on unknown control 1 warn:vcl.gtk:68739:68739:vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:1134: Handle unknown control 6 warn:vcl.gtk:68739:68739:vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:1386: Set label on unknown control 6 But if I press Cancel in the window that offers me a place to save: warn:sfx.doc:68739:68739:sfx2/source/doc/objserv.cxx:995: Fatal IO error during save com.sun.star.task.ErrorCodeIOException message: "ModelData_Impl::OutputFileDialog: ERRCODE_IO_ABORT at /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/sfx2/source/doc/guisaveas.cxx:1001" errcode: 283 Steps to Reproduce: 1. See description Actual Results: Fatal IO error Expected Results: NO Fatal IO error Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 4c96abd81460977d413d4d28e891bbbac5769ede CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150705] New: Paste contents in Draw looses accents
https://bugs.documentfoundation.org/show_bug.cgi?id=150705 Bug ID: 150705 Summary: Paste contents in Draw looses accents Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olivier.hal...@libreoffice.org Created attachment 182105 --> https://bugs.documentfoundation.org/attachment.cgi?id=182105=edit image shows the issue on pasting inside rectangle in Draw. When pasting text with accents in draw object looses accents. See image attached. Step to reproduce 1)Create new writer document 2) create new Draw document 3) write text in Writer with accents 4) copy contents just typed 5) create a rectangle in Draw 6) double click inside the triangle to put in text insert mode 7) paste contents copied from Writer Actual results Pasted text looses some characters Expected results Pasted text with full contents Version: 7.4.0.3 / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (en_US.UTF-8); UI: pt-BR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150691] Tabs turned into spaces by carriage returns in lists
https://bugs.documentfoundation.org/show_bug.cgi?id=150691 --- Comment #3 from Telesto --- Sounds like auto-correct based on the description (didn't test): Disable Menubar -> Tools -> Autocorrect -> Disable While typing. More advanced control: Tools -> Autocorrect -> Autocorrect options -> Options tab It might still be annoying - feeling like a bug. The auto-correct is sometimes rather disturbing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150676] Inserting and deleting a simple table in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=150676 --- Comment #7 from BogdanB --- I tried with 2 paragraphs, if I delete them I get this message, so it is not just for tables, but for anything warn:legacy.osl:63062:63062:sw/source/core/access/acccontext.cxx:442: fire event for disposed frame? warn:legacy.osl:63062:63062:sw/source/core/access/acccontext.cxx:442: fire event for disposed frame? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150681] spam
https://bugs.documentfoundation.org/show_bug.cgi?id=150681 V Stuart Foote changed: What|Removed |Added Component|Printing and PDF export |deletionRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150704] New: Inserting a new paragraph in Writer generates a lot of warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150704 Bug ID: 150704 Summary: Inserting a new paragraph in Writer generates a lot of warnings Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: buzea.bog...@libreoffice.org Description: Open a new Writer document and type "A". Press Enter to begin a new paragraph. In the dbg version of LibreOffice I get in the terminal a lot of warnings: there is no stream or folder involved! Is the same if I save the file first and than Insert "A" and press Enter, or if I just type "A" and press Enter and no save. warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! warn:legacy.osl:51227:51227:sw/source/core/swg/SwXMLTextBlocks1.cxx:316: Tried to open non-existent folder or stream! Steps to Reproduce: 1. See description Actual Results: Warnings Expected Results: No warnings Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 4c96abd81460977d413d4d28e891bbbac5769ede CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150688] When using a small screen and pressing 2 arrows for more buttons: CRITICAL message
https://bugs.documentfoundation.org/show_bug.cgi?id=150688 Telesto changed: What|Removed |Added CC||serval2...@yahoo.fr, ||tele...@surfxs.nl --- Comment #2 from Telesto --- @Julien Would you mind to verify? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150687] Simple inserting of text: too many warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150687 Telesto changed: What|Removed |Added CC||mikekagan...@hotmail.com, ||tele...@surfxs.nl --- Comment #1 from Telesto --- Confirm the existence, but I'm unable to make an assessment Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 1c1647e6ee252fe68d7406d01043e88f1721590f CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150702] Inserting a chart in Writer generates a lot of warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150702 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #1 from BogdanB --- The complete list of warnings for just an action: inserting a chart warn:xmloff.chart:47356:47356:xmloff/source/chart/SchXMLExport.cxx:3978: No DataProvider warn:xmloff.chart:47356:47356:xmloff/source/chart/SchXMLExport.cxx:3978: No DataProvider warn:xmloff.chart:47356:47356:xmloff/source/chart/SchXMLExport.cxx:3978: No DataProvider warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:47356:47356:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map
[Libreoffice-bugs] [Bug 150703] New: "Axis" versus "axes" in extended tips
https://bugs.documentfoundation.org/show_bug.cgi?id=150703 Bug ID: 150703 Summary: "Axis" versus "axes" in extended tips Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: One of these neighbouring extended tips is using the word "axis" (singular) while the other is using "axes" (plural). https://translations.documentfoundation.org/translate/libo_ui-master/chart2messages/en/?checksum=84ed41b72393575b https://translations.documentfoundation.org/translate/libo_ui-master/chart2messages/en/?checksum=556a93da228081c0 One or the other must be wrong, I guess. Steps to Reproduce: Open the links above. Actual Results: Different words are used. Expected Results: The same word (whichever is correct) is used. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150701] UI: The ruler width exceeds page dimensions with cursor in ToC
https://bugs.documentfoundation.org/show_bug.cgi?id=150701 Telesto changed: What|Removed |Added Version|7.5.0.0 alpha0+ Master |Inherited From OOo --- Comment #2 from Telesto --- Found in Version: 7.0.7.0.0+ (x64) Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL and in Version: 6.2.9.0.0+ (x86) Build ID: 5f01fe15eb2661f1f9ce12d1d99dc2a705b462ee CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL and in Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL and in Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89) and in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150702] New: Inserting a chart in Writer generates a lot of warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=150702 Bug ID: 150702 Summary: Inserting a chart in Writer generates a lot of warnings Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: buzea.bog...@libreoffice.org Description: Open a new Writer document and insert a chart A lot of warnings appears. Maybe some of them are important or just noise. This is the first step in building complex charts. Should be ok at this point. I am using LibreOffice with dbg (the warnings appears just in terminal, the chart is usable and seems ok). warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137: found no inner property set to map to warn:chart2.tools:41059:41059:chart2/source/tools/WrappedPropertySet.cxx:137:
[Libreoffice-bugs] [Bug 150701] UI: The ruler width exceeds page dimensions with cursor in ToC
https://bugs.documentfoundation.org/show_bug.cgi?id=150701 --- Comment #1 from Telesto --- Created attachment 182104 --> https://bugs.documentfoundation.org/attachment.cgi?id=182104=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150701] New: UI: The ruler width exceeds page dimensions with cursor in ToC
https://bugs.documentfoundation.org/show_bug.cgi?id=150701 Bug ID: 150701 Summary: UI: The ruler width exceeds page dimensions with cursor in ToC Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: UI: The ruler width exceeds page dimensions with cursor in ToC Steps to Reproduce: 1. Open attachment 182017 2. Click inside the ToC -after/before in the middle of ABC Actual Results: Ruler exceeds page Expected Results: Proper ruler size Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 1c1647e6ee252fe68d7406d01043e88f1721590f CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149751] Libreoffice freeze at first startup in Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=149751 Timur changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #9 from Timur --- Gwen's issue is bug 149948, please write Comment 7 there. I set Needinfo for original reporter to find that or other specific cause. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unoframe.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 4343432d423b5d92ca2b4ff5037eb29c8ac080ff
Author: Caolán McNamara
AuthorDate: Tue Aug 30 16:46:18 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Aug 30 21:12:52 2022 +0200
crash inserting odt as embedded ole object
Change-Id: I6bf8e2913fc677efe9904507ef8e4edddb9ef3ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/core/unocore/unoframe.cxx
b/sw/source/core/unocore/unoframe.cxx
index 1be52ee6113a..fd28f3bd2424 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -2262,8 +2262,9 @@ uno::Any SwXFrame::getPropertyValue(const OUString&
rPropertyName)
}
else if(WID_LAYOUT_SIZE == pEntry->nWID)
{
-// format document completely in order to get correct value
-pFormat->GetDoc()->GetEditShell()->CalcLayout();
+// format document completely in order to get correct value (no
EditShell for ole embedded case)
+if (SwEditShell* pEditShell = pFormat->GetDoc()->GetEditShell())
+pEditShell->CalcLayout();
SwFrame* pTmpFrame = SwIterator( *pFormat
).First();
if ( pTmpFrame )
[Libreoffice-bugs] [Bug 150700] New: The menu item "Document as PDF Attachment" does not exist
https://bugs.documentfoundation.org/show_bug.cgi?id=150700 Bug ID: 150700 Summary: The menu item "Document as PDF Attachment" does not exist Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: The following string references a menu item called "Document as PDF Attachment": https://translations.documentfoundation.org/translate/libo_ui-master/readlicense_oodocs/en/?checksum=7b3e7a18152a85a1 No such menu item (currently) exists in LO, though. However, there is a menu item called "Email as PDF...". Steps to Reproduce: 1. See https://translations.documentfoundation.org/translate/libo_ui-master/readlicense_oodocs/en/?checksum=7b3e7a18152a85a1 Actual Results: "Document as PDF Attachment" is referenced. Expected Results: "Email as PDF..." is referenced (if that's what's intended). Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150699] New: "Insert Sparkline..." should be "Sparkline..."
https://bugs.documentfoundation.org/show_bug.cgi?id=150699 Bug ID: 150699 Summary: "Insert Sparkline..." should be "Sparkline..." Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: In Calc, the menu item "Insert Sparkline..." in the Insert menu is named against UI conventions in LO and elsewhere. As the menu is already called "Insert", the menu item should be just "Sparkline...". (Compare to the other items in the Insert menu.) (Also, Help should be adjusted accordingly.) Steps to Reproduce: 1. In Calc, open the Insert menu. Actual Results: "Insert Sparkline..." is used. Expected Results: "Sparkline..." is used. Reproducible: Always User Profile Reset: No Additional Info: Weblate: https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en/?checksum=45eac6aca6df9608 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - desktop/source
desktop/source/lib/init.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 51e0bc91a6efaa161fef1fc5b198ea13d5edb1de
Author: Tor Lillqvist
AuthorDate: Tue Aug 30 13:38:42 2022 +0300
Commit: Tor Lillqvist
CommitDate: Tue Aug 30 20:48:18 2022 +0200
Fix typos
Change-Id: I857bdb7831bd1e4158f80f09ec232d76d4db794e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139029
Tested-by: Tor Lillqvist
Reviewed-by: Tor Lillqvist
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139057
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index bbc7224f2141..d1b1931fc69e 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2638,7 +2638,7 @@ static LibreOfficeKitDocument*
lo_documentLoadWithOptions(LibreOfficeKit* pThis,
// If the original font had an empty style and one of its
replacement fonts has the same
// family name, we assume the font is present. The root problem
here is that the code
// that collects font substitutions tends to get just empty styles
for the font that is
-// being substituded, as vcl::Font::GetStyleName() tents to return
an empty string.
+// being substituted, as vcl::Font::GetStyleName() tends to return
an empty string.
// (Italicness is instead indicated by what vcl::Font::GetItalic()
returns and boldness
// by what vcl::Font::GetWeight() returns.)
if (aFontMappingUseData[i].mOriginalFont.indexOf('/') == -1)
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - desktop/source
desktop/source/lib/init.cxx | 22 ++
1 file changed, 22 insertions(+)
New commits:
commit 38040747155276cfdb1322438d53cdad0b585b9b
Author: Tor Lillqvist
AuthorDate: Tue Aug 30 14:15:49 2022 +0300
Commit: Tor Lillqvist
CommitDate: Tue Aug 30 20:46:48 2022 +0200
Add SAL_INFOs for the recorded and pruned font substitutions
Change-Id: Ice7b64c87bff6dbc0eead7bda36f3b0a678986e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139055
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tor Lillqvist
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 23807a7f1403..bbc7224f2141 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2618,6 +2618,17 @@ static LibreOfficeKitDocument*
lo_documentLoadWithOptions(LibreOfficeKit* pThis,
auto aFontMappingUseData =
OutputDevice::FinishTrackingFontMappingUse();
+if (aFontMappingUseData.size() > 0)
+{
+SAL_INFO("lok.fontsubst", " Original
substitutions:");
+for (const auto : aFontMappingUseData)
+{
+SAL_INFO("lok.fontsubst", i.mOriginalFont);
+for (const auto : i.mUsedFonts)
+SAL_INFO("lok.fontsubst", "" << j);
+}
+}
+
// Filter out font substitutions that actually aren't any
substitutions, like "Liberation
// Serif" -> "Liberation Serif/Regular". If even one of the
"substitutions" of a font is to
// the same font, don't count that as a missing font.
@@ -2653,6 +2664,17 @@ static LibreOfficeKitDocument*
lo_documentLoadWithOptions(LibreOfficeKit* pThis,
}
}
+if (aFontMappingUseData.size() > 0)
+{
+SAL_INFO("lok.fontsubst", " Pruned
substitutions:");
+for (const auto : aFontMappingUseData)
+{
+SAL_INFO("lok.fontsubst", i.mOriginalFont);
+for (const auto : i.mUsedFonts)
+SAL_INFO("lok.fontsubst", "" << j);
+}
+}
+
for (std::size_t i = 0; i < aFontMappingUseData.size(); ++i)
{
pDocument->maFontsMissing.insert(aFontMappingUseData[i].mOriginalFont);
[Libreoffice-bugs] [Bug 150698] New: Incomplete sentence: "Best way to fix bad-looking MS Word table cells via"...
https://bugs.documentfoundation.org/show_bug.cgi?id=150698 Bug ID: 150698 Summary: Incomplete sentence: "Best way to fix bad-looking MS Word table cells via"... Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: The tip-of-the-day sentence "Best way to fix bad-looking MS Word table cells via Table ▸ Size ▸ Optimal Row Height / Column Width." is incomplete. Change to "The best way to fix bad-looking MS Word table cells is via Table ▸ Size ▸ Optimal Row Height / Column Width." (add "The" and "is"). Steps to Reproduce: 1. Go to https://translations.documentfoundation.org/translate/libo_ui-master/cuimessages/en/?checksum=1b35fb7e2595e494 Actual Results: "The" and "is" are missing. Expected Results: The string is fixed to include "The" and "is". Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118335] Writer's Groupedbar. Print preview called "Close Preview" in drop-down menu File
https://bugs.documentfoundation.org/show_bug.cgi?id=118335 Justin L changed: What|Removed |Added Summary|Writer's Groupedbar. Wrong |Writer's Groupedbar. Print |name of item Print preview |preview called "Close |in drop-down menu File |Preview" in drop-down menu ||File -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150697] "Image preferred DPI" is not good English
https://bugs.documentfoundation.org/show_bug.cgi?id=150697 --- Comment #1 from Mike Kaganski --- To be pedantic, also DPI is incorrect for image resolution - should be PPI. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150697] New: "Image preferred DPI" is not good English
https://bugs.documentfoundation.org/show_bug.cgi?id=150697 Bug ID: 150697 Summary: "Image preferred DPI" is not good English Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: The string "Image preferred DPI" is not good English. I suggest changing it to "Preferred resolution (in DPI) for images". Steps to Reproduce: 1. Go to https://translations.documentfoundation.org/translate/libo_ui-master/sfx2messages/en/?checksum=3de4e5a6e330d03a Actual Results: "Image preferred DPI" is used. Expected Results: "Preferred resolution (in DPI) for images" (or equivalent) is used. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45705] New UNO commands for "Zoom in" and "Zoom out" of document canvas, to support keyboard zoom (comment 21)
https://bugs.documentfoundation.org/show_bug.cgi?id=45705 V Stuart Foote changed: What|Removed |Added Status|REOPENED|NEW Keywords||easyHack --- Comment #49 from V Stuart Foote --- => NEW for remaining Easyhack to provide UNO for sdraw and simpress use and keyboard assignment. Code pointers in comment 47. @Jusitn, saw you unassigned Jim R. did you have a mentoree that is going to take this? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150696] New: The term "Snap Object" is only used once
https://bugs.documentfoundation.org/show_bug.cgi?id=150696 Bug ID: 150696 Summary: The term "Snap Object" is only used once Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: The term "Snap Object" is only used once in LO, in this string: https://translations.documentfoundation.org/translate/libo_ui-master/sdmessages/en/?checksum=cb20c0a94864bef8 The usual term in LO is "snap guide". I'd suggest either "snap guide" or "snap object" is used consistently in all cases. Steps to Reproduce: 1. Search for "snap object" in Weblate. 2. Compare to the results for "snap guide". Actual Results: Both "snap guide" and "snap object" are used in LO. Expected Results: Only one of the terms is used. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/complextext.cxx |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
New commits:
commit 8ca13426ca50a9466f552ac1e2f062920003d5ea
Author: Mike Kaganski
AuthorDate: Tue Aug 30 16:28:38 2022 +0300
Commit: Mike Kaganski
CommitDate: Tue Aug 30 20:04:33 2022 +0200
Workaround interdependency of tests
CppunitTest_vcl_text failed for me on Windows:
[_RUN_] VclTextTest::testSimpleText
C:/lo/src/core/vcl/qa/cppunit/text.cxx:198:VclTextTest::testSimpleText
double equality assertion failed
- Expected: 28
- Actual : -1
- Delta : 4
This turned out to depend on test order; the minimal failing command was
make CppunitTest_vcl_text CPPUNIT_TEST_NAME="testArabic testSimpleText"
and running testArabic before testSimpleText made the latter to render
white text on white background, and thus being unable to get resulting
height of the painted text.
Changing how the complex tests obtain their virtusl devices fixes this
for me. I have no idea how and why the previous complex test code
affected following tests. Windows buildbots were unaffected maybe
because they had HAVE_MORE_FONTS undefined.
Change-Id: If079e21e6b986fed5407295a71f9b121cf8de0b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139047
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index ff85b14e33ef..6c35fd740b33 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -65,12 +65,10 @@ void VclComplexTextTest::testArabic()
{
#if HAVE_MORE_FONTS
OUString aOneTwoThree(u"واحِدْ إثٍنين ثلاثةٌ");
-ScopedVclPtrInstance pWin(static_cast(nullptr));
-CPPUNIT_ASSERT( pWin );
vcl::Font aFont("DejaVu Sans", "Book", Size(0, 12));
-OutputDevice *pOutDev = pWin->GetOutDev();
+ScopedVclPtrInstance pOutDev;
pOutDev->SetFont( aFont );
// absolute character widths AKA text array.
@@ -120,10 +118,7 @@ void VclComplexTextTest::testTdf95650()
"\u0D11\u1312\u0105\u020A\u0512\u1403\u030C\u1528"
"\u2931\u632E\u7074\u0D20\u0E0A\u100A\uF00D\u0D20"
"\u030A\u0C0B\u20E0\u0A0D";
-ScopedVclPtrInstance pWin(static_cast(nullptr));
-CPPUNIT_ASSERT(pWin);
-
-OutputDevice *pOutDev = pWin->GetOutDev();
+ScopedVclPtrInstance pOutDev;
// Check that the following executes without failing assertion
pOutDev->ImplLayout(aTxt, 9, 1, Point(), 0, {}, {},
SalLayoutFlags::BiDiRtl);
}
[Libreoffice-bugs] [Bug 150695] New: The string "IgnoreAll" is probably wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=150695 Bug ID: 150695 Summary: The string "IgnoreAll" is probably wrong Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: There is a UI string "IgnoreAll" in LO: https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en/?checksum=32977a3c20b3a179 It should probably be something else, like "Ignore All" (with a space). Steps to Reproduce: 1. Go to https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en/?checksum=32977a3c20b3a179 Actual Results: The string is "IgnoreAll". Expected Results: "Ignore All", probably. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150694] New: "Text-to-text" is hard to understand
https://bugs.documentfoundation.org/show_bug.cgi?id=150694 Bug ID: 150694 Summary: "Text-to-text" is hard to understand Product: LibreOffice Version: 7.2.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: In Writer, in Format - Paragraph - Alignment tab, the meaning of the string "Text-to-text" is quite hard to understand without consulting Help. The actual meaning is "The alignment of oversized or undersized characters relative to the rest of the text in the paragraph" (see Help), so changing this string to something more understandable such as "Oversized and undersized characters" would make it easier to understand for users and translators. Relevant Help page: https://help.libreoffice.org/latest/en-US/text/shared/01/05030700.html Steps to Reproduce: 1. Go to Format -> Paragraph -> Alignment tab. Actual Results: The string "Text-to-text" is used. Expected Results: Something more descriptive is used. Reproducible: Always User Profile Reset: No Additional Info: The string in Weblate: https://translations.documentfoundation.org/translate/libo_ui-master/cuimessages/en/?checksum=165d0c2b0fd59cee -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45705] New UNO commands for "Zoom in" and "Zoom out" of document canvas, to support keyboard zoom (comment 21)
https://bugs.documentfoundation.org/show_bug.cgi?id=45705 Justin L changed: What|Removed |Added Assignee|rayk...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150693] New: Confusing language in Similarity Search
https://bugs.documentfoundation.org/show_bug.cgi?id=150693 Bug ID: 150693 Summary: Confusing language in Similarity Search Product: LibreOffice Version: 7.2.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: The Similarity Search dialog has some confusing language. "Exchange characters" does not really mean that characters will be exchanged. The actual meaning is "(the maximum number of) exchangeable characters". https://translations.documentfoundation.org/translate/libo_ui-master/cuimessages/en/?checksum=cc0ffa5f06739be3 "Add characters" does not really mean that characters will be added. The actual meaning is "(the maximum number of) additional characters". https://translations.documentfoundation.org/translate/libo_ui-master/cuimessages/en/?checksum=64413dc15303310b "Remove characters" does not really mean that characters will be removed. The actual meaning is "(the maximum number of) missing characters". https://translations.documentfoundation.org/translate/libo_ui-master/cuimessages/en/?checksum=d0c4cae6b614b3eb See Help for more information: https://help.libreoffice.org/latest/en-US/text/shared/01/02100100.html Steps to Reproduce: 1. In Writer, go to Edit -> Find & Replace 2. Check the Similarity search check box 3. Click the Similarities... button. Actual Results: The strings "Exchance characters", "Add characters" and "Remove characters" are used in the UI. Expected Results: More descriptive strings such as "Exchangeable characters:", "Additional characters:" and "Missing characters:" are used instead. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150692] LO crashes when share/extensions is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=150692 Rene Engelhard changed: What|Removed |Added Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150692] New: LO crashes when share/extensions is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=150692 Bug ID: 150692 Summary: LO crashes when share/extensions is broken Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Extensions Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r...@debian.org Hi, this shouldn't happen and is a bit artificial, but it actually happened, see below. Try the following in a LO install. $ rm -rf share/extensions $ touch share/extensions This results in a 0 byte file. This results in a crash: Thread 1 (Thread 0x7f6e40cb9180 (LWP 689175) "soffice.bin"): #0 0x7f6e472fda3f in __GI___poll (fds=0x7ffc488cce78, nfds=1, timeout=1000) at ../sysdeps/unix/sysv/linux/poll.c:29 #1 0x7f6e3e330180 in ?? () from /lib/x86_64-linux-gnu/libKF5Crash.so.5 #2 0x7f6e3e330b87 in KCrash::defaultCrashHandler(int) () from /lib/x86_64-linux-gnu/libKF5Crash.so.5 #3 0x7f6e4b94e8d4 in ?? () from /usr/lib/libreoffice/program/libuno_sal.so.3 #4 #5 0x7f6e452796a5 in ?? () from /usr/lib/libreoffice/program/libuno_cppu.so.3 #6 0x7f6e45277ae8 in ?? () from /usr/lib/libreoffice/program/libuno_cppu.so.3 #7 0x7f6e49e735c8 in ?? () from /usr/lib/libreoffice/program/libmergedlo.so #8 0x7f6e49e798a5 in ?? () from /usr/lib/libreoffice/program/libmergedlo.so #9 0x7f6e49e79aa3 in utl::ConfigItem::ConfigItem(rtl::OUString, ConfigItemMode) () from /usr/lib/libreoffice/program/libmergedlo.so #10 0x7f6e49ea59e8 in SvtSysLocaleOptions::SvtSysLocaleOptions() () from /usr/lib/libreoffice/program/libmergedlo.so #11 0x7f6e4a29506e in InitVCL() () from /usr/lib/libreoffice/program/libmergedlo.so #12 0x7f6e4a2959cd in ImplSVMain() () from /usr/lib/libreoffice/program/libmergedlo.so #13 0x7f6e4941aca6 in soffice_main () from /usr/lib/libreoffice/program/libmergedlo.so #14 0x564df860c07b in ?? () #15 0x7f6e4722920a in __libc_start_call_main (main=main@entry=0x564df860c070, argc=argc@entry=2, argv=argv@entry=0x7ffc488ce848) at ../sysdeps/nptl/libc_start_call_main.h:58 #16 0x7f6e472292bc in __libc_start_main_impl (main=0x564df860c070, argc=2, argv=0x7ffc488ce848, init=, fini=, rtld_fini=, stack_end=0x7ffc488ce838) at ../csu/libc-start.c:389 #17 0x564df860c0b1 in ?? () (found in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005832 and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018750) Regards, Rene -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/undo/untbl.cxx | 41 +
sw/source/core/undo/untblk.cxx |3 +--
2 files changed, 18 insertions(+), 26 deletions(-)
New commits:
commit cb38ff2ea917c5f7440f3d421a707cb53c1aa068
Author: Noel Grandin
AuthorDate: Tue Aug 30 15:13:28 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Aug 30 19:05:42 2022 +0200
use more SwPosition::Assign
part of hiding the internals of SwPosition
Change-Id: I8858193e94fe34f1fe13d1aaaf7c7b1ed364af61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139045
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/undo/untbl.cxx b/sw/source/core/undo/untbl.cxx
index b7b5871e30e0..98122704058d 100644
--- a/sw/source/core/undo/untbl.cxx
+++ b/sw/source/core/undo/untbl.cxx
@@ -336,9 +336,6 @@ void SwUndoInsTable::RedoImpl(::sw::UndoRedoContext &
rContext)
return;
SwPaM aPam( *pTableNode->EndOfSectionNode(), *pTableNode, SwNodeOffset(1)
);
-SwContentNode* pCNd = aPam.GetMarkContentNode();
-if( pCNd )
-aPam.GetMark()->nContent.Assign( pCNd, 0 );
if( m_pRedlineData && IDocumentRedlineAccess::IsRedlineOn(
GetRedlineFlags() ) )
{
@@ -468,9 +465,9 @@ void SwUndoTableToText::UndoImpl(::sw::UndoRedoContext &
rContext)
SwNodeIndex aFrameIdx( rDoc.GetNodes(), m_nStartNode );
SwNodeIndex aEndIdx( rDoc.GetNodes(), m_nEndNode );
-pPam->GetPoint()->nNode = aFrameIdx;
+pPam->GetPoint()->Assign( aFrameIdx );
pPam->SetMark();
-pPam->GetPoint()->nNode = aEndIdx;
+pPam->GetPoint()->Assign( aEndIdx );
rDoc.DelNumRules( *pPam );
pPam->DeleteMark();
@@ -517,9 +514,9 @@ void SwUndoTableToText::UndoImpl(::sw::UndoRedoContext &
rContext)
// Is a table selection requested?
pPam->DeleteMark();
-pPam->GetPoint()->nNode = *pTableNd->EndOfSectionNode();
+pPam->GetPoint()->Assign( *pTableNd->EndOfSectionNode() );
pPam->SetMark();
-pPam->GetPoint()->nNode = *pPam->GetPointNode().StartOfSectionNode();
+pPam->GetPoint()->Assign( *pPam->GetPointNode().StartOfSectionNode() );
pPam->Move( fnMoveForward, GoInContent );
pPam->Exchange();
pPam->Move( fnMoveBackward, GoInContent );
@@ -650,8 +647,7 @@ void SwUndoTableToText::RedoImpl(::sw::UndoRedoContext &
rContext)
SwDoc & rDoc = rContext.GetDoc();
SwPaM *const pPam(& rContext.GetCursorSupplier().CreateNewShellCursor());
-pPam->GetPoint()->nNode = m_nStartNode;
-pPam->GetPoint()->nContent.Assign( nullptr, 0 );
+pPam->GetPoint()->Assign( m_nStartNode );
SwNodeIndex aSaveIdx( pPam->GetPoint()->GetNode(), -1 );
pPam->SetMark();// log off all indices
@@ -686,7 +682,7 @@ void SwUndoTableToText::RepeatImpl(::sw::RepeatContext &
rContext)
if( pTableNd )
{
// move cursor out of table
-pPam->GetPoint()->nNode = *pTableNd->EndOfSectionNode();
+pPam->GetPoint()->Assign( *pTableNd->EndOfSectionNode() );
pPam->Move( fnMoveForward, GoInContent );
pPam->SetMark();
pPam->DeleteMark();
@@ -774,12 +770,12 @@ void SwUndoTextToTable::UndoImpl(::sw::UndoRedoContext &
rContext)
pPos->Assign(nTableNd);
if (aPam.Move(fnMoveBackward, GoInContent))
{
-SwNodeIndex & rIdx = aPam.GetPoint()->nNode;
+SwNode & rIdx = aPam.GetPoint()->GetNode();
// than move, relatively, the Cursor/etc. again
RemoveIdxRel( rIdx.GetIndex()+1, *pPos );
-rIdx.GetNode().GetContentNode()->JoinNext();
+rIdx.GetContentNode()->JoinNext();
}
}
@@ -2176,8 +2172,7 @@ void SwUndoTableNumFormat::UndoImpl(::sw::UndoRedoContext
& rContext)
SwPaM *const pPam(& rContext.GetCursorSupplier().CreateNewShellCursor());
pPam->DeleteMark();
-pPam->GetPoint()->nNode = m_nNode + 1;
-pPam->GetPoint()->nContent.Assign( pTextNd, 0 );
+pPam->GetPoint()->Assign( m_nNode + 1 );
}
namespace {
@@ -2229,7 +2224,7 @@ void SwUndoTableNumFormat::RedoImpl(::sw::UndoRedoContext
& rContext)
SwPaM *const pPam(& rContext.GetCursorSupplier().CreateNewShellCursor());
pPam->DeleteMark();
-pPam->GetPoint()->nNode = m_nNode;
+pPam->GetPoint()->Assign( m_nNode );
SwNode * pNd = & pPam->GetPoint()->GetNode();
SwStartNode* pSttNd = pNd->FindSttNodeByType( SwTableBoxStartNode );
@@ -2305,8 +2300,7 @@ void SwUndoTableNumFormat::RedoImpl(::sw::UndoRedoContext
& rContext)
}
if( !pNd->IsContentNode() )
-pNd = rDoc.GetNodes().GoNext( >GetPoint()->nNode );
-pPam->GetPoint()->nContent.Assign( static_cast(pNd), 0 );
+pNd = rDoc.GetNodes().GoNext( pPam->GetPoint() );
}
void SwUndoTableNumFormat::SetBox( const SwTableBox& rBox )
@@ -2450,7 +2444,7 @@ void SwUndoTableCpyTable::UndoImpl(::sw::UndoRedoContext
& rContext)
{
// The aPam.Point is at the moment at the
[Libreoffice-commits] core.git: sw/source
sw/source/core/undo/untbl.cxx | 33 +++--
1 file changed, 15 insertions(+), 18 deletions(-)
New commits:
commit 3f58796b5d192e1028bd32c852da53fdce1540b7
Author: Noel Grandin
AuthorDate: Tue Aug 30 15:18:48 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Aug 30 19:05:21 2022 +0200
use more SwPosition::Assign
part of hiding the internals of SwPosition
Change-Id: I4ce9a5be9f3ad6d31eac8917ddb53b2228220066
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139046
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/undo/untbl.cxx b/sw/source/core/undo/untbl.cxx
index d219d4384b3d..b7b5871e30e0 100644
--- a/sw/source/core/undo/untbl.cxx
+++ b/sw/source/core/undo/untbl.cxx
@@ -786,16 +786,15 @@ void SwUndoTextToTable::UndoImpl(::sw::UndoRedoContext &
rContext)
// join again at end?
if( m_bSplitEnd )
{
-SwNodeIndex& rIdx = pPos->nNode;
-rIdx = m_nEndNode;
-SwTextNode* pTextNd = rIdx.GetNode().GetTextNode();
+pPos->Assign( m_nEndNode );
+SwTextNode* pTextNd = pPos->GetNode().GetTextNode();
if( pTextNd && pTextNd->CanJoinNext() )
{
aPam.GetMark()->nContent.Assign( nullptr, 0 );
aPam.GetPoint()->nContent.Assign( nullptr, 0 );
// than move, relatively, the Cursor/etc. again
-pPos->nContent.Assign(pTextNd, pTextNd->GetText().getLength());
+pPos->SetContent(pTextNd->GetText().getLength());
RemoveIdxRel( m_nEndNode + 1, *pPos );
pTextNd->JoinNext();
@@ -2839,10 +2838,9 @@ void SwUndoSplitTable::UndoImpl(::sw::UndoRedoContext &
rContext)
SwDoc *const pDoc = & rContext.GetDoc();
SwPaM *const pPam(& rContext.GetCursorSupplier().CreateNewShellCursor());
-SwNodeIndex& rIdx = pPam->GetPoint()->nNode;
-rIdx = m_nTableNode + m_nOffset;
-pPam->GetPoint()->nContent.Assign(rIdx.GetNode().GetContentNode(), 0);
-assert(rIdx.GetNode().GetContentNode()->Len() == 0); // empty para inserted
+SwPosition& rPtPos = *pPam->GetPoint();
+rPtPos.Assign( m_nTableNode + m_nOffset );
+assert(rPtPos.GetNode().GetContentNode()->Len() == 0); // empty para
inserted
{
// avoid asserts from ~SwContentIndexReg
@@ -2857,8 +2855,8 @@ void SwUndoSplitTable::UndoImpl(::sw::UndoRedoContext &
rContext)
pDoc->GetNodes().Delete( idx );
}
-rIdx = m_nTableNode + m_nOffset;
-SwTableNode* pTableNd = rIdx.GetNode().GetTableNode();
+rPtPos.Assign( m_nTableNode + m_nOffset );
+SwTableNode* pTableNd = rPtPos.GetNode().GetTableNode();
SwTable& rTable = pTableNd->GetTable();
SwTableFormulaUpdate aMsgHint( );
@@ -2894,7 +2892,7 @@ void SwUndoSplitTable::UndoImpl(::sw::UndoRedoContext &
rContext)
default: break;
}
-pDoc->GetNodes().MergeTable( rIdx.GetNode() );
+pDoc->GetNodes().MergeTable( rPtPos.GetNode() );
if( m_pHistory )
{
@@ -2903,7 +2901,7 @@ void SwUndoSplitTable::UndoImpl(::sw::UndoRedoContext &
rContext)
}
if( mpSaveRowSpan )
{
-pTableNd = rIdx.GetNode().FindTableNode();
+pTableNd = rPtPos.GetNode().FindTableNode();
if( pTableNd )
pTableNd->GetTable().RestoreRowSpan( *mpSaveRowSpan );
}
@@ -2972,10 +2970,10 @@ void SwUndoMergeTable::UndoImpl(::sw::UndoRedoContext &
rContext)
SwPaM *const pPam(& rContext.GetCursorSupplier().CreateNewShellCursor());
pPam->DeleteMark();
-SwNodeIndex& rIdx = pPam->GetPoint()->nNode;
-rIdx = m_nTableNode;
+SwPosition& rPtPos = *pPam->GetPoint();
+rPtPos.Assign( m_nTableNode);
-SwTableNode* pTableNd = rIdx.GetNode().FindTableNode();
+SwTableNode* pTableNd = rPtPos.GetNode().FindTableNode();
SwTable* pTable = >GetTable();
SwTableFormulaUpdate aMsgHint( pTable );
@@ -2988,7 +2986,7 @@ void SwUndoMergeTable::UndoImpl(::sw::UndoRedoContext &
rContext)
aFndBox.DelFrames( *pTable );
// ? TL_CHART2: notification or locking of controller required ?
-SwTableNode* pNew = pDoc->GetNodes().SplitTable( rIdx.GetNode() );
+SwTableNode* pNew = pDoc->GetNodes().SplitTable( rPtPos.GetNode() );
// update layout
aFndBox.MakeFrames( *pTable );
@@ -3016,8 +3014,7 @@ void SwUndoMergeTable::UndoImpl(::sw::UndoRedoContext &
rContext)
pNew->MakeOwnFrames();
// position cursor somewhere in content
-SwContentNode* pCNd = pDoc->GetNodes().GoNext( );
-pPam->GetPoint()->nContent.Assign( pCNd, 0 );
+pDoc->GetNodes().GoNext( );
ClearFEShellTabCols(*pDoc, nullptr);
[Libreoffice-bugs] [Bug 150691] Tabs turned into spaces by carriage returns in lists
https://bugs.documentfoundation.org/show_bug.cgi?id=150691 --- Comment #2 from William Friedman --- Created attachment 182103 --> https://bugs.documentfoundation.org/attachment.cgi?id=182103=edit Document used for testing -- You are receiving this mail because: You are the assignee for the bug.
