[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - filter/source
filter/source/pdf/pdfexport.cxx | 39 +++
filter/source/pdf/pdfexport.hxx |1 +
2 files changed, 40 insertions(+)
New commits:
commit f2d44962b4f9c0e91375d829800a9b603eb454d8
Author: Miklos Vajna
AuthorDate: Thu Nov 24 14:30:22 2022 +0100
Commit: Miklos Vajna
CommitDate: Wed Dec 7 07:46:10 2022 +
Related: tdf#54053 PDF export: add UNO API to customize the watermark
rotation
The watermark direction is currently either 0 degrees for landscape
pages or 270 degrees for portrait pages.
The problem is many people expect 45 degrees rotation angle or some
custom angle in general, and we provide no way to control it.
Fix the problem by adding a new "WatermarkRotateAngle" PDF export filter
option to specify the rotation angle explicitly. Note that the watermark
text is still centered, and the text size is decreased to still fit the page
boundaries. To keep things simple, do this shrinking by going with a
size that matches the shorter dimension of the page, instead of some
more complex iterative approach.
Example cmdline usage:
soffice --convert-to
pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"},
"WatermarkRotateAngle":{"type":"long","value":"450"}}' test.odt
(cherry picked from commit 574db5efa9a2ab6d70faedf538be77a1eb8c597b)
Conflicts:
filter/CppunitTest_filter_pdf.mk
filter/qa/pdf.cxx
filter/source/pdf/pdfexport.cxx
Change-Id: I1fee14c333e68c92cf4c65ec100e04dcf024f907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143712
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index 0be005e1434c..8a7948cdf79f 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -38,6 +38,7 @@
#include
#include
#include
+#include
#include "pdfexport.hxx"
#include
@@ -550,6 +551,14 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
moWatermarkFontHeight = nFontHeight;
}
}
+else if (rProp.Name == "WatermarkRotateAngle")
+{
+sal_Int32 nRotateAngle{};
+if (rProp.Value >>= nRotateAngle)
+{
+moWatermarkRotateAngle = Degree10(nRotateAngle);
+}
+}
else if (rProp.Name == "WatermarkFontName")
{
OUString aFontName{};
@@ -1156,6 +1165,17 @@ void PDFExport::ImplWriteWatermark( vcl::PDFWriter&
rWriter, const Size& rPageSi
aFont.SetOrientation( 2700_deg10 );
}
+if (moWatermarkRotateAngle)
+{
+aFont.SetOrientation(*moWatermarkRotateAngle);
+if (rPageSize.Width() < rPageSize.Height())
+{
+// Set text width based on the shorter side, so rotation can't
push text outside the
+// page boundaries.
+nTextWidth = rPageSize.Width();
+}
+}
+
// adjust font height for text to fit
OutputDevice* pDev = rWriter.GetReferenceDevice();
pDev->Push();
@@ -1209,6 +1229,25 @@ void PDFExport::ImplWriteWatermark( vcl::PDFWriter&
rWriter, const Size& rPageSi
(rPageSize.Height()-w)/2 );
aTextRect = tools::Rectangle( aTextPoint, Size( nTextHeight, w ) );
}
+
+if (moWatermarkRotateAngle)
+{
+// First set the text's starting point to the center of the page.
+tools::Rectangle aPageRectangle(Point(0, 0), rPageSize);
+aTextPoint = aPageRectangle.Center();
+// Then adjust it so that the text remains centered, based on the
rotation angle.
+basegfx::B2DPolygon aTextPolygon
+= basegfx::utils::createPolygonFromRect(basegfx::B2DRectangle(0,
-nTextHeight, w, 0));
+basegfx::B2DHomMatrix aMatrix;
+aMatrix.rotate(-1 * toRadians(*moWatermarkRotateAngle));
+aTextPolygon.transform(aMatrix);
+basegfx::B2DPoint aPolygonCenter =
aTextPolygon.getB2DRange().getCenter();
+aTextPoint.AdjustX(-aPolygonCenter.getX());
+aTextPoint.AdjustY(-aPolygonCenter.getY());
+
+aTextRect = aPageRectangle;
+}
+
rWriter.SetClipRegion();
rWriter.BeginTransparencyGroup();
rWriter.DrawText( aTextPoint, msWatermark );
diff --git a/filter/source/pdf/pdfexport.hxx b/filter/source/pdf/pdfexport.hxx
index 6fc98f6acd47..8d839f3b18a8 100644
--- a/filter/source/pdf/pdfexport.hxx
+++ b/filter/source/pdf/pdfexport.hxx
@@ -81,6 +81,7 @@ private:
Color maWatermarkColor;
std::optional moWatermarkFontHeight;
OUStringmaWatermarkFontName;
+std::optional moWatermarkRotateAngle;
OUStringmsTiledWatermark;
// these
[Libreoffice-bugs] [Bug 152406] macOS Calc: Scrolling: scrollbar showing wrong position resulting in unscrollable document
https://bugs.documentfoundation.org/show_bug.cgi?id=152406 Buovjaga changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - filter/source
filter/source/pdf/pdfexport.cxx | 11 ++-
filter/source/pdf/pdfexport.hxx |1 +
2 files changed, 11 insertions(+), 1 deletion(-)
New commits:
commit 481bb66b2e12a2a885b1d963f719aa84069dc270
Author: Miklos Vajna
AuthorDate: Wed Nov 23 13:39:40 2022 +0100
Commit: Miklos Vajna
CommitDate: Wed Dec 7 07:40:01 2022 +
Related: tdf#54053 PDF export: add UNO API to customize the watermark font
name
The font name of the watermark text is currently hardwired to Helvetica,
a sans-serif font.
The problem is that this looks bad in case your document uses serif or
monospace fonts. Or perhaps your document uses a single font and you
want to make sure that the watermark uses exactly the same font.
Fix the problem by adding a new "WatermarkFontName" PDF export filter
option to specify the font name explicitly.
Example cmdline usage:
soffice --convert-to
pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"},
"WatermarkFontName":{"type":"string","value":"Times"}}' test.odt
(cherry picked from commit d1dd9b9733511ff451e264169537c08fa14c574f)
Conflicts:
filter/qa/pdf.cxx
Change-Id: I2f065e1517236695b0a95369bdcd803125018587
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143711
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index af21c7b1a9c8..0be005e1434c 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -107,6 +107,7 @@ PDFExport::PDFExport( const Reference< XComponent >&
rxSrcDoc,
mbIsRedactMode ( false ),
maWatermarkColor( COL_LIGHTGREEN ),
+maWatermarkFontName ( "Helvetica" ),
mbHideViewerToolbar ( false ),
mbHideViewerMenubar ( false ),
@@ -549,6 +550,14 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
moWatermarkFontHeight = nFontHeight;
}
}
+else if (rProp.Name == "WatermarkFontName")
+{
+OUString aFontName{};
+if (rProp.Value >>= aFontName)
+{
+maWatermarkFontName = aFontName;
+}
+}
else if ( rProp.Name == "TiledWatermark" )
rProp.Value >>= msTiledWatermark;
// now all the security related properties...
@@ -1135,7 +1144,7 @@ void PDFExport::ImplExportPage( vcl::PDFWriter& rWriter,
vcl::PDFExtOutDevData&
void PDFExport::ImplWriteWatermark( vcl::PDFWriter& rWriter, const Size&
rPageSize )
{
-vcl::Font aFont( "Helvetica", Size( 0, moWatermarkFontHeight ?
*moWatermarkFontHeight : 3*rPageSize.Height()/4 ) );
+vcl::Font aFont( maWatermarkFontName, Size( 0, moWatermarkFontHeight ?
*moWatermarkFontHeight : 3*rPageSize.Height()/4 ) );
aFont.SetItalic( ITALIC_NONE );
aFont.SetWidthType( WIDTH_NORMAL );
aFont.SetWeight( WEIGHT_NORMAL );
diff --git a/filter/source/pdf/pdfexport.hxx b/filter/source/pdf/pdfexport.hxx
index 489c3ec2e7a1..6fc98f6acd47 100644
--- a/filter/source/pdf/pdfexport.hxx
+++ b/filter/source/pdf/pdfexport.hxx
@@ -80,6 +80,7 @@ private:
OUStringmsWatermark;
Color maWatermarkColor;
std::optional moWatermarkFontHeight;
+OUStringmaWatermarkFontName;
OUStringmsTiledWatermark;
// these variable are here only to have a location in filter/pdf to set
the default
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - filter/source
filter/source/pdf/pdfexport.cxx | 46 ++--
filter/source/pdf/pdfexport.hxx |2 +
2 files changed, 37 insertions(+), 11 deletions(-)
New commits:
commit c1682e413712751b21a21d48c03a0eeba427d558
Author: Miklos Vajna
AuthorDate: Wed Nov 23 09:59:05 2022 +0100
Commit: Miklos Vajna
CommitDate: Wed Dec 7 07:39:52 2022 +
Related: tdf#54053 PDF export: add UNO API to customize the watermark font
size
The font height of the watermark text is currently automatic: we start
with a value based on the page size and then decrease it till the text
fits.
The problem is that sometimes you want a smaller value, but specifying
this was not possible.
Fix the problem by adding a new "WatermarkFontHeight" PDF export filter
option to specify the font size explicitly.
Example cmdline usage:
soffice --convert-to
pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"},
"WatermarkFontHeight":{"type":"long","value":"100"}}' test.odt
(cherry picked from commit 175e514c93b3696faa8c331c8b8f56e832ceb4c1)
Conflicts:
filter/qa/pdf.cxx
Change-Id: Iceab943b7a995badfcdc6b12ecc9264e39e4a3a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143710
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index f70fbba5b281..af21c7b1a9c8 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -541,6 +541,14 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
maWatermarkColor = Color(ColorTransparency, nColor);
}
}
+else if (rProp.Name == "WatermarkFontHeight")
+{
+sal_Int32 nFontHeight{};
+if (rProp.Value >>= nFontHeight)
+{
+moWatermarkFontHeight = nFontHeight;
+}
+}
else if ( rProp.Name == "TiledWatermark" )
rProp.Value >>= msTiledWatermark;
// now all the security related properties...
@@ -1127,7 +1135,7 @@ void PDFExport::ImplExportPage( vcl::PDFWriter& rWriter,
vcl::PDFExtOutDevData&
void PDFExport::ImplWriteWatermark( vcl::PDFWriter& rWriter, const Size&
rPageSize )
{
-vcl::Font aFont( "Helvetica", Size( 0, 3*rPageSize.Height()/4 ) );
+vcl::Font aFont( "Helvetica", Size( 0, moWatermarkFontHeight ?
*moWatermarkFontHeight : 3*rPageSize.Height()/4 ) );
aFont.SetItalic( ITALIC_NONE );
aFont.SetWidthType( WIDTH_NORMAL );
aFont.SetWeight( WEIGHT_NORMAL );
@@ -1145,19 +1153,26 @@ void PDFExport::ImplWriteWatermark( vcl::PDFWriter&
rWriter, const Size& rPageSi
pDev->SetFont( aFont );
pDev->SetMapMode( MapMode( MapUnit::MapPoint ) );
int w = 0;
-while( ( w = pDev->GetTextWidth( msWatermark ) ) > nTextWidth )
+if (moWatermarkFontHeight)
{
-if (w == 0)
-break;
-tools::Long nNewHeight = aFont.GetFontHeight() * nTextWidth / w;
-if( nNewHeight == aFont.GetFontHeight() )
+w = pDev->GetTextWidth(msWatermark);
+}
+else
+{
+while( ( w = pDev->GetTextWidth( msWatermark ) ) > nTextWidth )
{
-nNewHeight--;
-if( nNewHeight <= 0 )
+if (w == 0)
break;
+tools::Long nNewHeight = aFont.GetFontHeight() * nTextWidth / w;
+if( nNewHeight == aFont.GetFontHeight() )
+{
+nNewHeight--;
+if( nNewHeight <= 0 )
+break;
+}
+aFont.SetFontHeight( nNewHeight );
+pDev->SetFont( aFont );
}
-aFont.SetFontHeight( nNewHeight );
-pDev->SetFont( aFont );
}
tools::Long nTextHeight = pDev->GetTextHeight();
// leave some maneuvering room for rounding issues, also
diff --git a/filter/source/pdf/pdfexport.hxx b/filter/source/pdf/pdfexport.hxx
index 166893d4fca2..489c3ec2e7a1 100644
--- a/filter/source/pdf/pdfexport.hxx
+++ b/filter/source/pdf/pdfexport.hxx
@@ -79,6 +79,7 @@ private:
OUStringmsWatermark;
Color maWatermarkColor;
+std::optional moWatermarkFontHeight;
OUStringmsTiledWatermark;
// these variable are here only to have a location in filter/pdf to set
the default
commit 6804814e2145231e5bd649f655426a11001d42b9
Author: Miklos Vajna
AuthorDate: Thu Nov 17 13:11:27 2022 +0100
Commit: Miklos Vajna
CommitDate: Wed Dec 7 07:39:43 2022 +
Related: tdf#54053 PDF export: add UNO API to customize the watermark color
PDF export has a watermark feature, but its color is hardcoded to light
green, which won't fit all documents.
On the other hand,
[Libreoffice-commits] core.git: sdext/source
sdext/source/pdfimport/inc/pdfiprocessor.hxx |1 +
sdext/source/pdfimport/tree/drawtreevisiting.hxx |2 --
2 files changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 83e58fc9f19a8da751cabdc0440aded62dc67fea
Author: Kevin Suo
AuthorDate: Fri Dec 2 19:22:11 2022 +0800
Commit: Stephan Bergmann
CommitDate: Wed Dec 7 07:33:41 2022 +
sdext: move the include of XComponentContext.hpp to where it is used
... and remove unsed include.
XComponentContext.hpp is used in pdfiprocessor.hxx but not in
drawtreevisiting.hxx.
XMultiServiceFactory.hpp is not used drawtreevisiting.hxx.
Change-Id: Ic98cbcdcacd07cf2163e02ac569781f70edd953c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143570
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sdext/source/pdfimport/inc/pdfiprocessor.hxx
b/sdext/source/pdfimport/inc/pdfiprocessor.hxx
index 7cbe7d7a5104..3fdc146716b3 100644
--- a/sdext/source/pdfimport/inc/pdfiprocessor.hxx
+++ b/sdext/source/pdfimport/inc/pdfiprocessor.hxx
@@ -20,6 +20,7 @@
#ifndef INCLUDED_SDEXT_SOURCE_PDFIMPORT_INC_PDFIPROCESSOR_HXX
#define INCLUDED_SDEXT_SOURCE_PDFIMPORT_INC_PDFIPROCESSOR_HXX
+#include
#include
#include
#include
diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.hxx
b/sdext/source/pdfimport/tree/drawtreevisiting.hxx
index 81bfd927354b..e3ea8e537ff5 100644
--- a/sdext/source/pdfimport/tree/drawtreevisiting.hxx
+++ b/sdext/source/pdfimport/tree/drawtreevisiting.hxx
@@ -24,8 +24,6 @@
#include
#include
-#include
-#include
namespace pdfi
{
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - officecfg/registry sfx2/source
officecfg/registry/schema/org/openoffice/Office/Common.xcs | 125 +
sfx2/source/doc/docmacromode.cxx | 54 +
2 files changed, 179 insertions(+)
New commits:
commit a8017a020430857524138ff0ee72c425e8c7486d
Author: Vasily Melenchuk
AuthorDate: Mon Dec 5 20:32:41 2022 +0300
Commit: Thorsten Behrens
CommitDate: Wed Dec 7 07:33:52 2022 +
Support for Windows Security Zones for macro enable/disable
In Windows, files have security zones (local, from intranet, from
internet, etc) used by MS Word to decide in which mode it is safe to
open file.
This patch implements basic support for similar feature: it is now
possible to use expert configuration options to set up default
behavior and configure for example automatic disabling of macros, if
a file is downloaded from Internet or other unsafe location.
Changed defaults: files from untrusted zones, or the internet, get
macros disabled unconditionally. Can be overridden via
officecfg::Office::Common::Security::Scripting::WindowsSecurityZone.*
in the expert config dialog.
Change-Id: I0bf1ae4e54d75dd5d07cab309124a67a85ef2d4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143750
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index e57d26ab3366..75416223f135 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -2751,6 +2751,131 @@
List with trusted authors.
+
+
+Contains security settings regarding Basic scripts.
+
+
+
+ Action needed for opening document with macro with Windows
zone
+ identifier URLZONE_LOCAL_MACHINE (0, local machine).
+
+
+
+
+ Ask
+
+
+
+
+ Allow
+
+
+
+
+ Deny
+
+
+
+0
+
+
+
+ Action needed for opening document with macro with Windows
zone
+ identifier URLZONE_INTRANET (1, local machine).
+
+
+
+
+ Ask
+
+
+
+
+ Allow
+
+
+
+
+ Deny
+
+
+
+0
+
+
+
+ Action needed for opening document with macro with Windows
zone
+ identifier URLZONE_TRUSTED (2, trusted).
+
+
+
+
+ Ask
+
+
+
+
+ Allow
+
+
+
+
+ Deny
+
+
+
+0
+
+
+
+ Action needed for opening document with macro with Windows
zone
+ identifier URLZONE_INTERNET (3, internet).
+
+
+
+
+ Ask
+
+
+
+
+ Allow
+
+
+
+
+ Deny
+
+
+
+2
+
+
+
+ Action needed for opening document with macro with Windows
zone
+ identifier URLZONE_UNTRUSTED (3, untrusted source).
+
+
+
+
+ Ask
+
+
+
+
+ Allow
+
+
+
+
+ Deny
+
+
+
+2
+
+
diff --git a/sfx2/source/doc/docmacromode.cxx b/sfx2/source/doc/docmacromode.cxx
index 2fa7b968fc41..4d15ad30cb01 100644
--- a/sfx2/source/doc/docmacromode.cxx
+++ b/sfx2/source/doc/docmacromode.cxx
@@ -40,6 +40,10 @@
#include
#include
+#if defined(_WIN32)
+#include
+#include
+#endif
namespace sfx2
{
@@ -288,6 +292,56 @@ namespace sfx2
}
}
+#if defined(_WIN32)
+// Windows specific: try to decide macros loading depending on Windows
Security Zones
+// (file is local, or it was downloaded from internet, etc)
+
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/layout/layout.cxx | 38 -
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx |6 ++--
sw/source/core/text/xmldump.cxx|2 -
3 files changed, 26 insertions(+), 20 deletions(-)
New commits:
commit 1e8c2068ec9d1551b84152d6cf66042dc2949594
Author: Miklos Vajna
AuthorDate: Tue Dec 6 20:07:07 2022 +0100
Commit: Miklos Vajna
CommitDate: Wed Dec 7 07:24:53 2022 +
sw layout xml dump: avoid confusing content of SwParaPortion
The problem is that the SwParaPortion is also the first line layout, so
the string it presents is not the content of the paragraph but of the
first line.
Just remove it as we have better replacements:
- in case really the whole paragraph is wanted, the (text) content of
the parent SwTextFrame can be used
- in case in fact the first line is wanted, then the first child
SwLineLayout still has a portion attribute the provides the unchanged
substring
Change-Id: Ic4a0f64ecc40e9a74adc79c5205d5d92c882256b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143743
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index 2707f940dfbf..587fa4d4294e 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -715,11 +715,10 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter,
TestNestedTableMoveFwd)
CPPUNIT_ASSERT(pDoc);
xmlDocUniquePtr pXmlDoc = parseLayoutDump();
// the row with the nested table should not be split but be the first row
on page 2
-assertXPath(pXmlDoc,
"/root/page[1]/body/tab[1]/row[last()]/cell[1]/txt[1]/SwParaPortion",
-"portion", "Tabelle 1");
-assertXPath(pXmlDoc,
-
"/root/page[2]/body/tab[1]/row[1]/cell[1]/tab[1]/row[1]/cell[1]/txt/SwParaPortion",
-"portion", "Tabelle 2");
+assertXPathContent(pXmlDoc,
"/root/page[1]/body/tab[1]/row[last()]/cell[1]/txt[1]",
+ "Tabelle 1");
+assertXPathContent(
+pXmlDoc,
"/root/page[2]/body/tab[1]/row[1]/cell[1]/tab[1]/row[1]/cell[1]/txt", "Tabelle
2");
}
CPPUNIT_TEST_FIXTURE(SwLayoutWriter, TestTdf136613)
@@ -827,19 +826,25 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter,
testRedlineFlysInHeader)
CPPUNIT_ASSERT(pLayout->IsHideRedlines());
discardDumpedLayout();
xmlDocUniquePtr pXmlDoc = parseLayoutDump();
-assertXPath(pXmlDoc, "/root/page[1]/body/txt[1]/SwParaPortion[1]",
"type",
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt[1]/SwParaPortion/SwLineLayout", "type",
"PortionType::Para");
-assertXPath(pXmlDoc, "/root/page[1]/body/txt[1]/SwParaPortion[1]",
"length", "0");
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt[1]/SwParaPortion/SwLineLayout[1]", "length",
+"0");
assertXPath(pXmlDoc, "/root/page[1]/header/txt[1]/merged",
"paraPropsNodeIndex", "6");
-assertXPath(pXmlDoc, "/root/page[1]/header/txt[1]/SwParaPortion[1]",
"type",
+assertXPath(pXmlDoc,
"/root/page[1]/header/txt[1]/SwParaPortion/SwLineLayout[1]", "type",
"PortionType::Para");
-assertXPath(pXmlDoc, "/root/page[1]/header/txt[1]/SwParaPortion[1]",
"portion", "foaz");
+assertXPath(pXmlDoc,
"/root/page[1]/header/txt[1]/SwParaPortion/SwLineLayout[1]", "portion",
+"foaz");
assertXPath(pXmlDoc,
"/root/page[1]/header/txt[1]/anchored/fly[1]/txt[1]/merged",
"paraPropsNodeIndex", "11");
-assertXPath(pXmlDoc,
"/root/page[1]/header/txt[1]/anchored/fly[1]/txt[1]/SwParaPortion[1]",
-"type", "PortionType::Para");
-assertXPath(pXmlDoc,
"/root/page[1]/header/txt[1]/anchored/fly[1]/txt[1]/SwParaPortion[1]",
-"portion", "ahi");
+assertXPath(
+pXmlDoc,
+
"/root/page[1]/header/txt[1]/anchored/fly[1]/txt[1]/SwParaPortion/SwLineLayout[1]",
+"type", "PortionType::Para");
+assertXPath(
+pXmlDoc,
+
"/root/page[1]/header/txt[1]/anchored/fly[1]/txt[1]/SwParaPortion/SwLineLayout[1]",
+"portion", "ahi");
dispatchCommand(mxComponent, ".uno:ShowTrackedChanges", {});
CPPUNIT_ASSERT(!pLayout->IsHideRedlines());
@@ -853,9 +858,10 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter,
testRedlineFlysInHeader)
xmlXPathFreeObject(pXmlObj);
}
-assertXPath(pXmlDoc, "/root/page[1]/body/txt[1]/SwParaPortion[1]",
"type",
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt[1]/SwParaPortion/SwLineLayout[1]", "type",
"PortionType::Para");
-assertXPath(pXmlDoc, "/root/page[1]/body/txt[1]/SwParaPortion[1]",
"length", "0");
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt[1]/SwParaPortion/SwLineLayout[1]", "length",
+"0");
[Libreoffice-bugs] [Bug 96372] Filters do not work on Hsqldb subquery result when subquery has alias.
https://bugs.documentfoundation.org/show_bug.cgi?id=96372 --- Comment #19 from Robert Großkopf --- Bug is still the same in LO 7.4.3.2 on OpenSUSE 15.3 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.
https://bugs.documentfoundation.org/show_bug.cgi?id=147982 --- Comment #25 from Alex Thurgood --- (In reply to Alexander Van den Panhuysen from comment #24) > Excuse me, do you still need more info? I'm sure everything is explained in > detail, I can not imagine what can be explained more. > Meanwhile I'm using fore some months LibreOffice 7.4, stil not working > properly. > When will this be solved? As we don't have a crash trace, we still don't know what is happening when it crashes. That said, a possibly similar problem was recently fixed in master branch 7.5 alpha, and this seems to have removed most of the deadlocking issues that were being seen. You could try a daily developer build, and report back. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.
https://bugs.documentfoundation.org/show_bug.cgi?id=147982 Alexander Van den Panhuysen changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #24 from Alexander Van den Panhuysen --- Excuse me, do you still need more info? I'm sure everything is explained in detail, I can not imagine what can be explained more. Meanwhile I'm using fore some months LibreOffice 7.4, stil not working properly. When will this be solved? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133122] Using a shape mask with a bitmap Shapes | Subtract alters aspect ratio of bitmap
https://bugs.documentfoundation.org/show_bug.cgi?id=133122 --- Comment #5 from Derek Keats --- This bug is still present, and is now also present in Impress. Version: 7.4.2.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-ZA (en_ZA.UTF-8); UI: en-ZA Ubuntu package version: 1:7.4.2~rc3-0ubuntu1 Calc: threaded The behaviour is exactly as I documented initially, and it still forces the use of a third tool to do this one thing. It would be really awesome if it could be fixed as I use Libreoffice for everything otherwise, and it is a fantastic suite. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152160] Printed label's field content mismatch for spreadsheet data source if field added afterwards in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=152160 Petri H changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #2 from Petri H --- Thanks for looking into this Stéphane. You need to walkthrough the specified procedure to reproduce the bug. details from my LibreOffice Version: 7.4.2.3 (x86) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (sv_SE); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137955] Browse Mode in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=137955 --- Comment #9 from Quentin Christensen --- (In reply to V Stuart Foote from comment #4) > > > If NVDA 'Browse mode' is dependent on any UIA, pretty clearly > > > unsupportable > > > in LibreOffice where we support only accessible event triggers--as mapped > > > back to IA2. I can answer this (all speaking generally at least, since I haven't looked at the code on either side here) - while NVDA now uses UIA by default in recent builds of Word, because the experience there has improved to where it is better and more responsive than iA2 *in that situation* in general for the majority of users, we have otherwise (and still offer) iA2 support. So that should be possible in LO as well. I know one of our developers, Reef, commented previously that we weren't in a position to take on the whole project - https://github.com/nvaccess/nvda/issues/8148#issuecomment-744228528 - At the time he suggested looking at how NVDA handles browse mode using iA2 in browsers. I don't think we're currently in a better position to own the endeavour, but I'm happy to keep the dialog open. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152402] Prints dark background instead of white with custom dark settings
https://bugs.documentfoundation.org/show_bug.cgi?id=152402 --- Comment #3 from nopainenogai...@hushmail.com --- (In reply to nopainenogain12 from comment #2) > Created attachment 184028 [details] > sample document in print preview Not sure where to put this: I found a solution after messing with it all day. I hit the reset button. LibreOffice > Options > Applications Colorsbottom reset button changed the page to how it should have displayed in print preview and when being printed...white. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137955] Browse Mode in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=137955 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de --- Comment #8 from Dieter --- (In reply to juergenkohler23 from comment #6) > I have tried again to contact the NVDA developers; without their help the > necessary information will probably not be available... Jürgen, any news? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/unx
vcl/unx/generic/fontmanager/fontconfig.cxx |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit ef557f0742b6111827982f5e10bc2f44fb553f78
Author: Caolán McNamara
AuthorDate: Tue Dec 6 08:59:16 2022 +
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Dec 7 04:21:34 2022 +
Resolves: tdf#151722 use UI Language for localized font names
instead of system locale
Change-Id: Ie1f33644fcb8529b237db372b7d8daea19af8ede
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143593
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/unx/generic/fontmanager/fontconfig.cxx
b/vcl/unx/generic/fontmanager/fontconfig.cxx
index 1daf54b69fa6..c44cdd2ee05f 100644
--- a/vcl/unx/generic/fontmanager/fontconfig.cxx
+++ b/vcl/unx/generic/fontmanager/fontconfig.cxx
@@ -54,6 +54,7 @@ using namespace psp;
#include
#include
+#include
#include
@@ -440,13 +441,9 @@ FcResult
FontCfgWrapper::LocalizedElementFromPattern(FcPattern const * pPattern,
++k;
}
-//possible to-do, sort by UILocale instead of process locale
if (!m_pLanguageTag)
-{
-rtl_Locale* pLoc = nullptr;
-osl_getProcessLocale();
-m_pLanguageTag.reset( new LanguageTag(*pLoc) );
-}
+m_pLanguageTag.reset(new
LanguageTag(SvtSysLocaleOptions().GetRealUILanguageTag()));
+
*element = bestname(lang_and_elements, *m_pLanguageTag);
//if this element is a fontname, map the other names to this
best-name
[Libreoffice-bugs] [Bug 143700] Libreoffice All Modules Bug Reporting
https://bugs.documentfoundation.org/show_bug.cgi?id=143700 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143480] Writer: In Navigator, promotion or demotion of a level should change heading level in document
https://bugs.documentfoundation.org/show_bug.cgi?id=143480 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143480] Writer: In Navigator, promotion or demotion of a level should change heading level in document
https://bugs.documentfoundation.org/show_bug.cgi?id=143480 --- Comment #10 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148579] Print Preview jumps to a different page upon zooming in/out
https://bugs.documentfoundation.org/show_bug.cgi?id=148579 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148579] Print Preview jumps to a different page upon zooming in/out
https://bugs.documentfoundation.org/show_bug.cgi?id=148579 --- Comment #3 from QA Administrators --- Dear Ben, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146430] Cannot apply edited master slide to selected/all slides
https://bugs.documentfoundation.org/show_bug.cgi?id=146430 --- Comment #3 from QA Administrators --- Dear NarayanAras, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144529] Double ListBox dlg:selected attribute corrupts xdl dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=144529 --- Comment #3 from QA Administrators --- Dear bughugger, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146430] Cannot apply edited master slide to selected/all slides
https://bugs.documentfoundation.org/show_bug.cgi?id=146430 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149075] Windows 10 Skia: Writer closes after startup
https://bugs.documentfoundation.org/show_bug.cgi?id=149075 --- Comment #16 from QA Administrators --- Dear 2sas, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96372] Filters do not work on Hsqldb subquery result when subquery has alias.
https://bugs.documentfoundation.org/show_bug.cgi?id=96372 --- Comment #18 from QA Administrators --- Dear Saren Tasciyan, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99222] While typing, some characters appear out of order from how they are typed.
https://bugs.documentfoundation.org/show_bug.cgi?id=99222 --- Comment #10 from QA Administrators --- Dear Joseph, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66772] EDITING: LibO not allows input methods and IME to use some "Ctrl+XXX" hotkeys
https://bugs.documentfoundation.org/show_bug.cgi?id=66772 --- Comment #14 from QA Administrators --- Dear minhsien0330, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138591] Using Unicode conversion on a combined emoji results in only partial conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=138591 --- Comment #10 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138615] Insure Windows wildcards work properly with long paths
https://bugs.documentfoundation.org/show_bug.cgi?id=138615 --- Comment #3 from QA Administrators --- Dear Deb, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137042] SQL Error -607, when changing Field type of a table (Firebird)
https://bugs.documentfoundation.org/show_bug.cgi?id=137042 --- Comment #15 from QA Administrators --- Dear Richard Demattio, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136068] Certain formula get corrupted after DOC export (and get lost when converting to DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=136068 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135941] Frame has no border after DOCX export (depending on line style)
https://bugs.documentfoundation.org/show_bug.cgi?id=135941 --- Comment #2 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114116] Dialog "assign datasource" in Writer doesn't display the source name in the list
https://bugs.documentfoundation.org/show_bug.cgi?id=114116 --- Comment #8 from QA Administrators --- Dear Thomas Krumbein, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112472] "Number" number format listbox entry should toggle the format as number uno command
https://bugs.documentfoundation.org/show_bug.cgi?id=112472 --- Comment #7 from QA Administrators --- Dear Emil Tanev, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152265] UI: tip of the day: placeholder "PRODUCTNAME" in text of the tip
https://bugs.documentfoundation.org/show_bug.cgi?id=152265
--- Comment #3 from Andika Triwidada ---
found some typos: %(space)PRODUCTNAME or (probably missing %)PRODUCTNAME
andika@libre:~/libreoffice/translations/source/nl$ git status
HEAD detached at libreoffice-7.3.7.2
Untracked files:
(use "git add ..." to include in what will be committed)
../id/helpcontent2/source/text/simpress/guide.po.bak
nothing added to commit but untracked files present (use "git add" to track)
andika@libre:~/libreoffice/translations/source/nl$ grep -nR PRODUCTNAME *|grep
-v \%PRODUCTNAME|grep -v '${PRODUCTNAME}'|grep -v '\[PRODUCTNAME\]'|grep -v
'\[FULLPRODUCTNAME\]'
cui/messages.po:2614:msgstr "U kunt het uiterlijk van PRODUCTNAME wijzigen via
Extra > Opties > Beeld > Gebruikersinterface."
cui/messages.po:2626:msgstr "U kunt formules tonen in plaats van resultaten met
Beeld > Formule weergeven (of Extra > Opties > PRODUCTNAME Calc > Beeld >
Weergave > Formules."
helpcontent2/source/text/sbasic/shared.po:3221:msgstr "De variabele is geldig
zolang de% PRODUCTNAME-sessie duurt."
helpcontent2/source/text/sbasic/shared.po:4040:msgstr "% PRODUCTNAME
Standaardbibliotheken kunnen in 3 verschillende containers worden opgeslagen:"
helpcontent2/source/text/shared/01.po:6281:msgstr "Opent een nieuw venster in uw
standaard e-mailprogramma met het huidige document als bijlage. De huidige
bestandsindeling wordt gebruikt. Als het document nieuw en
niet-opgeslagen is, wordt de indeling gespecificeerd in % PRODUCTNAME -
VoorkeurenExtra -
Opties - Laden / Opslaan -
Algemeen wordt gebruikt."
helpcontent2/source/text/shared/01.po:47852:msgstr "De huidige implementatie (%
PRODUCTNAME% PRODUCTVERSION) van de enkelvoudige werkbalk is gemeenschappelijk
voor de modules Writer, Calc, Draw en Impress. Een wijziging in de enkelvoudige
werkbalk in de ene module heeft invloed op de enkelvoudige werkbalk van de
andere modules."
helpcontent2/source/text/shared/01.po:49841:msgstr "De te gebruiken
sleutelopslag kan worden geselecteerd onder % PRODUCTNAME -
Voorkeuren Extra -
Opties -% PRODUCTNAAM -
Beveiliging - Certificeringspad."
helpcontent2/source/text/shared/01.po:50642:msgstr "Indien
ingeschakeld, worden automatisch ingevoegde blanco pagina's geëxporteerd naar
het pdf-bestand. Dit is het beste als u het pdf-bestand dubbelzijdig afdrukt.
Voorbeeld: in een boek is een alinea-opmaakprofiel voor hoofdstukken ingesteld
om altijd te beginnen met een oneven genummerde pagina. Als het vorige
hoofdstuk op een oneven pagina eindigt, voegt % PRODUCTNAME een even genummerde
blanco pagina in. Deze optie bepaalt of die even genummerde pagina moet worden
geëxporteerd of niet."
helpcontent2/source/text/shared/01.po:52163:msgstr "Met % PRODUCTNAME kunt u
een ondertekeningsregel in uw document digitaal ondertekenen."
helpcontent2/source/text/shared/01.po:52172:msgstr "Bij het ondertekenen van
een ondertekening-regel vult % PRODUCTNAME de regel met de naam van de
ondertekenaar, voegt de informatie van de uitgever van het digitale certificaat
toe en voegt optioneel de datum van ondertekening in."
helpcontent2/source/text/shared/optionen.po:6533:msgstr "Dit besturingselement
wordt alleen weergegeven als Complexe tekstlay-out is ingesteld in
% PRODUCTNAME
- VoorkeurenExtra -
Opties - Taalinstellingen -
Talen."
helpcontent2/source/text/smath/01.po:13832:msgstr "Het primaire doel van%
PRODUCTNAME Math is om wiskundige formules te maken, maar het kan ook worden
gebruikt om chemische formules te schrijven. In chemische formules worden de
chemische symbolen normaal gesproken in hoofdletters geschreven met
rechtopstaande in plaats van cursieve tekens."
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Sierk Bornemann changed: What|Removed |Added Depends on||82115 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=82115 [Bug 82115] Repeatable crash/hang entering Japanese into a Writer comment on OSX ( see comment 4 ) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152402] Prints dark background instead of white with custom dark settings
https://bugs.documentfoundation.org/show_bug.cgi?id=152402 --- Comment #2 from nopainenogai...@hushmail.com --- Created attachment 184028 --> https://bugs.documentfoundation.org/attachment.cgi?id=184028=edit sample document in print preview -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152406] macOS Calc: Scrolling: scrollbar showing wrong position resulting in unscrollable document
https://bugs.documentfoundation.org/show_bug.cgi?id=152406 --- Comment #1 from steve --- Created attachment 184027 --> https://bugs.documentfoundation.org/attachment.cgi?id=184027=edit scrollbar has wrong position resulting in stuck document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152406] New: macOS Calc: Scrolling: scrollbar showing wrong position resulting in unscrollable document
https://bugs.documentfoundation.org/show_bug.cgi?id=152406 Bug ID: 152406 Summary: macOS Calc: Scrolling: scrollbar showing wrong position resulting in unscrollable document Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: l...@disr.it Description: Sadly no clear repro steps but for me it happens after scrolling around in a blank document for a while. Issue: scrollbar is stuck at the top most (y) or left most (x) position despite the document not been on the first row or first column. Once this happens scrolling in the axis showing the wrong scrollbar position is locked e.g. when y scrollbar is affected document can no longer be scrolled to top. LibreOffice seems to assume the scrollbar position (at the very top) to be correct (it actually is not, since the document is not scrolled to the top). This issue can be worked around by scrolling up and down (or sideways) for a while into the sidebar snaps into correct position which then results in a correctly scrollable document again. The issue can affect both horizontal and verital scrollbar. I have not observed both scrollbars misbehaving at the same time, although both are affected by this issue and have misbehaved in described way. Steps to Reproduce: If only I knew. Scrolling around for a while in a new calc document should be sufficient to trigger the issue after under 1 minute. Actual Results: Unscrollable document Expected Results: Scrollbars should never show wrong position and by that prevent document getting stuck on wrong position. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: c08e5db055c9d34d3f0b0b9d2a192d7ebdcd9576 CPU threads: 8; OS: Mac OS X 13.0.1; UI render: default; VCL: osx Locale: de-DE (en_DE.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 steve changed: What|Removed |Added Depends on||152405 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152405 [Bug 152405] macOS Dark Mode: white text on while background in various UI elements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152405] macOS Dark Mode: white text on while background in various UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=152405 steve changed: What|Removed |Added Blocks||118017 CC||caol...@redhat.com, ||mikekagan...@hotmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118017 [Bug 118017] [META] macOS Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152405] macOS Dark Mode: white text on while background in various UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=152405 --- Comment #2 from steve --- Created attachment 184026 --> https://bugs.documentfoundation.org/attachment.cgi?id=184026=edit fontname size and cellname - white text on white background -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152405] macOS Dark Mode: white text on while background in various UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=152405 --- Comment #1 from steve --- Created attachment 184025 --> https://bugs.documentfoundation.org/attachment.cgi?id=184025=edit buttons white text on white background -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152405] New: macOS Dark Mode: white text on while background in various UI elements
https://bugs.documentfoundation.org/show_bug.cgi?id=152405 Bug ID: 152405 Summary: macOS Dark Mode: white text on while background in various UI elements Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: l...@disr.it Description: Sadly I have no clear repro steps for this and it happens infrequently but often enough that I now file this issue. Once the issue hits, several UI elements change to white text on white background which before were displayed as expected. Find attached screenshots shows the issue happen in Calc for Fontname, Fontsize and Cellname dropdown. And a second screenshot showing the save dialog buttons misbehaving in the same way. Steps to Reproduce: If only I knew :( Actual Results: Fields and buttons become hard to use and unreadable. Expected Results: Buttons and fields should not switch to white text on white background. Reproducible: Couldn't Reproduce User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: c08e5db055c9d34d3f0b0b9d2a192d7ebdcd9576 CPU threads: 8; OS: Mac OS X 13.0.1; UI render: default; VCL: osx Locale: de-DE (en_DE.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152404] Crash in Writer when inserting a new comment while there is uncommitted text
https://bugs.documentfoundation.org/show_bug.cgi?id=152404 --- Comment #1 from Patrick Luby --- One more detail: if, in step 4, you select the Insert > Comment menu item, the crash does not occur and uncommitted text is committed and the cursor moves to the new comment. So, it appears that selecting a menu item commits the text before the new comment is created but pressing a shortcut that contains the Control key bypasses the commit process. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152404] New: Crash in Writer when inserting a new comment while there is uncommitted text
https://bugs.documentfoundation.org/show_bug.cgi?id=152404 Bug ID: 152404 Summary: Crash in Writer when inserting a new comment while there is uncommitted text Product: LibreOffice Version: 7.5.0.0 alpha1+ Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: plub...@neooffice.org Description: After some debugging, I found that the crash occurs when the new comment grabs focus, it invokes WinSalFrame::EndExtTextInput() which is supposed to commit the uncommitted text. Unfortunately, Writer's input method handler commits the text in two steps: first it deletes the uncommitted text, then it inserts the committed text. The crash occurs in the first step: when Writer deletes the uncommitted text, it triggers Writer to remove the newly added comment and the comment's vcl objects are all deleted. Steps to Reproduce: Steps to reproduce. Note: this crash occurs in Windows but not macOS since macOS has not yet implemented SalFrame::EndExtTextInput(): 1. Open a new Writer document 2. Change your keyboard entry to a Chinese, Japanese, or Korean input method (I used Japanese Hiragana) 3. Type a few characters so that the text is in an uncommitted state (I typed "aaa" on a US English physical keyboard which get converted to "あああ" by the Japanese Hiragana input method) 4. Press the Control-Alt-C keys to create a new comment 5. Crash Actual Results: Application crashes due to use of a deleted pointer. Expected Results: Uncommitted text should be committed and the cursor moved to the new comment. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: c08e5db055c9d34d3f0b0b9d2a192d7ebdcd9576 CPU threads: 1; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 55571] [META] ACCESSIBILITY: Tracking bug for issues related to the macOS Accessibility API
https://bugs.documentfoundation.org/show_bug.cgi?id=55571 steve changed: What|Removed |Added Severity|critical|normal --- Comment #29 from steve --- Lowering importance to normal. This is a meta bug. If there is a critical bug, it should be the individual bug, not this meta bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152402] Prints dark background instead of white with custom dark settings
https://bugs.documentfoundation.org/show_bug.cgi?id=152402 --- Comment #1 from steve --- Unable to reproduce on macOS with daily build. Are you seeing the dark area you are referring to in print preview? If yes, could you attach a screenshot of that please. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152397] The explanation of the help page about Calc Input settings is not appropriate.
https://bugs.documentfoundation.org/show_bug.cgi?id=152397 --- Comment #2 from nobu --- (In reply to Olivier Hallot from comment #1) > Does this makes it clearer? > > "If a range of cells is selected, each time Enter is > pressed will select the next cell inside the range, according to the > direction selected in Press Enter to move selection. Hence, > enabling both options is useful when entering values into a range of cells > sequentially." I rely on Google's automatic translation to post and read, so it's difficult to judge whether this sentence is easy to understand, but I think it's a correct description. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82115] Repeatable crash/hang entering Japanese into a Writer comment on OSX ( see comment 4 )
https://bugs.documentfoundation.org/show_bug.cgi?id=82115 Patrick Luby changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |plub...@neooffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82115] Repeatable crash/hang entering Japanese into a Writer comment on OSX ( see comment 4 )
https://bugs.documentfoundation.org/show_bug.cgi?id=82115 --- Comment #21 from Patrick Luby --- I have posted a patch that fixes this bug: https://gerrit.libreoffice.org/c/core/+/143619 The patch needs still needs to be reviewed and tested before it appears in a nightly build. Are there any people who have a macOS LibreOffice build that can test the patch? Overall, the patch commits any uncommitted text when one or more of the following events occur: - The focused window changes - A menu item is selected - Text is entered with the Command key pressed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143480] Writer: In Navigator, promotion or demotion of a level should change heading level in document
https://bugs.documentfoundation.org/show_bug.cgi?id=143480 --- Comment #9 from Paul --- Created attachment 184024 --> https://bugs.documentfoundation.org/attachment.cgi?id=184024=edit File with Navigator promotion problem Here is the sanitized file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143480] Writer: In Navigator, promotion or demotion of a level should change heading level in document
https://bugs.documentfoundation.org/show_bug.cgi?id=143480 --- Comment #8 from Paul --- (In reply to Dieter from comment #7) > (In reply to Buovjaga from comment #6) > > Paul: you closed this as insufficientdata. Does this mean you have not been > > able to sanitize the document? If so, you can send it to me via email and I > > can give it a shot (confirming with you before attaching it to the report). > > => NEEDINFO Thanks guys, I appreciate your attention greatly. I have made a screencast of the problem, using the actual problem file. In doing so, I have narrowed down the extent of the problem. In Navigator, using the toolbar arrows to promote a heading up or demote it down works fine. However, using the toolbar arrows to promote left or demote right, while it works in that it affects a Table of Contents refresh, never is reflected in the LO toolbar Style combo box item. That is, if I take an H4 heading down to H5, it shows as H5 in a refreshed ToC, but stays as H4 in the toolbar box. Here is the video: https://videy.co/v?id=H6Lde88p I will try to sanitize the file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/commontools/dbconversion.cxx | 16
1 file changed, 16 insertions(+)
New commits:
commit da3dd48eaf9086f8ab28d6a6655f9a638e51433a
Author: Eike Rathke
AuthorDate: Tue Dec 6 22:37:19 2022 +0100
Commit: Eike Rathke
CommitDate: Tue Dec 6 22:38:12 2022 +
Resolves: tdf#152381 Treat 0-0-0 invalid date as 0 relative days
Change-Id: I70cf18395e26ababa854299a58f8839f5bdf8e2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143748
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/connectivity/source/commontools/dbconversion.cxx
b/connectivity/source/commontools/dbconversion.cxx
index 26ef95b96b64..fed51204afb7 100644
--- a/connectivity/source/commontools/dbconversion.cxx
+++ b/connectivity/source/commontools/dbconversion.cxx
@@ -151,6 +151,22 @@ namespace dbtools
static sal_Int32 implRelativeToAbsoluteNull(const css::util::Date& _rDate)
{
+if (_rDate.Day == 0 && _rDate.Month == 0 && _rDate.Year == 0)
+{
+// -00-00 is *NOT* a valid date and passing it to the date
+// conversion even when normalizing rightly asserts. Whatever we
+// return here, it will be wrong. The old before commit
+// 52ff16771ac160d27fd7beb78a4cfba22ad84f06 wrong implementation
+// calculated -365 for that, effectively that would be a date of
+// -0001-01-01 now but it was likely assumed that would be
+// -00-01 or even -00-00 instead. Try if we get away with 0
+// for -0001-12-31, the same that
+// comphelper::date::convertDateToDaysNormalizing()
+// would return if comphelper::date::normalize() wouldn't ignore
+// such "empty" date.
+
+return 0;
+}
return comphelper::date::convertDateToDaysNormalizing( _rDate.Day,
_rDate.Month, _rDate.Year);
}
[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=152134 --- Comment #22 from wzpd...@gmail.com --- Stephane, thanks for the help. Have moved to v7.3.7.2 and can confirm that version works. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152134] Customize: assign user macro to menu fails and hangs LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=152134 --- Comment #21 from wzpd...@gmail.com --- Sorry, names are similar and I was asleep at the switch. Thanks for the help. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143480] Writer: In Navigator, promotion or demotion of a level should change heading level in document
https://bugs.documentfoundation.org/show_bug.cgi?id=143480 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #7 from Dieter --- (In reply to Buovjaga from comment #6) > Paul: you closed this as insufficientdata. Does this mean you have not been > able to sanitize the document? If so, you can send it to me via email and I > can give it a shot (confirming with you before attaching it to the report). => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 --- Comment #24 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3cb654972ba204efb5dd35a44f95c7d509414400 tdf#152029 Visually draw attention to in-view bookmark It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl sw/source vcl/inc vcl/source vcl/unx
include/vcl/weld.hxx |4
sw/source/uibase/inc/conttree.hxx | 10 ++
sw/source/uibase/utlui/content.cxx | 170 +
vcl/inc/salvtables.hxx |4
vcl/inc/treeglue.hxx | 25 +++--
vcl/source/app/salvtables.cxx |6 -
vcl/unx/gtk3/gtkinst.cxx | 41
7 files changed, 224 insertions(+), 36 deletions(-)
New commits:
commit 3cb654972ba204efb5dd35a44f95c7d509414400
Author: Jim Raykowski
AuthorDate: Sat Dec 3 20:11:07 2022 -0900
Commit: Jim Raykowski
CommitDate: Tue Dec 6 21:47:49 2022 +
tdf#152029 Visually draw attention to in-view bookmark
when mouse pointer is over bookmark entry in the Navigator content tree
This patch brings attention to in-view bookmarks when the mouse pointer
is positioned over bookmark content entries in the Navigator content
tree. All in-view bookmarks are brought to attention by placing the
mouse pointer over the bookmark content type (category) entry.
The patch adds a parameter to the weld::get_dest_row_at_pos function to
give the option not to auto scroll. It is needed to prevent auto
scrolling when used in the the mouse move handler. Additional use can
be made in the content tree CommandHdl to make the tree not jump when
the context popup menu is activated for entries near the top and bottom
of the the visible tree.
Change-Id: I04e306286ca58ab6c8ae7e5c02b25a0592c4a9d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143628
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 4b4ea74f13b3..3bcbc0a7a08d 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1352,7 +1352,9 @@ public:
*after the row
* b) dnd highlight the dest row
*/
-virtual bool get_dest_row_at_pos(const Point& rPos, weld::TreeIter*
pResult, bool bDnDMode) = 0;
+virtual bool get_dest_row_at_pos(const Point& rPos, weld::TreeIter*
pResult, bool bDnDMode,
+ bool bAutoScroll = true)
+= 0;
virtual void unset_drag_dest_row() = 0;
virtual tools::Rectangle get_row_area(const weld::TreeIter& rIter) const =
0;
// for dragging and dropping between TreeViews, return the active source
diff --git a/sw/source/uibase/inc/conttree.hxx
b/sw/source/uibase/inc/conttree.hxx
index cf7c383f81e4..77358b9edb30 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -32,6 +32,8 @@
#include
#include
+#include
+
class SwWrtShell;
class SwContentType;
class SwNavigationPI;
@@ -91,6 +93,7 @@ class SwContentTree final : public SfxListener
SwNavigationPI* m_pDialog;
OUStringm_sSpace;
AutoTimer m_aUpdTimer;
+AutoTimer m_aOverlayObjectDelayTimer;
o3tl::enumarray>
m_aActiveContentArr;
o3tl::enumarray>
m_aHiddenContentArr;
@@ -129,6 +132,11 @@ class SwContentTree final : public SfxListener
bool m_bDocHasChanged = true;
bool m_bIgnoreDocChange = false; // used to prevent tracking update
+std::unique_ptr m_xOverlayCompareEntry;
+std::unique_ptr m_xOverlayObject;
+
+void BringBookmarksToAttention(const std::vector& rNames);
+
/**
* Before any data will be deleted, the last active entry has to be found.
* After this the UserData will be deleted
@@ -183,6 +191,8 @@ class SwContentTree final : public SfxListener
DECL_LINK(QueryTooltipHdl, const weld::TreeIter&, OUString);
DECL_LINK(DragBeginHdl, bool&, bool);
DECL_LINK(TimerUpdate, Timer *, void);
+DECL_LINK(m_aOverlayObjectDelayTimerHdl, Timer *, void);
+DECL_LINK(MouseMoveHdl, const MouseEvent&, bool);
public:
SwContentTree(std::unique_ptr xTreeView, SwNavigationPI*
pDialog);
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 32a9e8ab63ce..cb7f96ec3b23 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -102,6 +102,12 @@
#include
#include
+#include
+#include
+#include
+#include
+#include
+
#define CTYPE_CNT 0
#define CTYPE_CTT 1
@@ -1066,6 +1072,7 @@
SwContentTree::SwContentTree(std::unique_ptr xTreeView, SwNaviga
, m_pDialog(pDialog)
, m_sSpace(OUString(""))
, m_aUpdTimer("SwContentTree m_aUpdTimer")
+, m_aOverlayObjectDelayTimer("SwContentTree m_aOverlayObjectDelayTimer")
, m_sInvisible(SwResId(STR_INVISIBLE))
, m_pHiddenShell(nullptr)
, m_pActiveShell(nullptr)
@@ -1082,6 +1089,7 @@
SwContentTree::SwContentTree(std::unique_ptr xTreeView, SwNaviga
, m_bIsLastReadOnly(false)
, m_bIsOutlineMoveable(true)
, m_bViewHasChanged(false)
+, m_xOverlayCompareEntry(m_xTreeView->make_iterator())
{
m_xTreeView->set_size_request(m_xTreeView->get_approximate_digit_width() *
30,
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152381] sal_Int32 comphelper::date::YearToDays(sal_Int16): Assertion `nYear != 0' failed.
https://bugs.documentfoundation.org/show_bug.cgi?id=152381 Eike Rathke changed: What|Removed |Added Status|NEW |ASSIGNED OS|Linux (All) |All Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 خالد حسني changed: What|Removed |Added Depends on|152396 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152396 [Bug 152396] Font width (expanded, condensed, etc.) is not supported -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152396] Font width (expanded, condensed, etc.) is not supported
https://bugs.documentfoundation.org/show_bug.cgi?id=152396 خالد حسني changed: What|Removed |Added Blocks|103378 | Summary|Variable font: variants are |Font width (expanded, |not correctly selected |condensed, etc.) is not ||supported Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152403] New: Missing space on credits list of video *LibreOffice 7.4: New Features*
https://bugs.documentfoundation.org/show_bug.cgi?id=152403 Bug ID: 152403 Summary: Missing space on credits list of video *LibreOffice 7.4: New Features* Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pmenzel+bugs.documentfoundation@molgen.mpg.de CC: olivier.hal...@libreoffice.org In the video [*LibreOffice 7.4: New Features*](https://www.youtube.com/watch?v=PC8M4UzqpqE) – also on https://www.libreoffice.org/discover/new-features/ (with PeerTube). On the credits “slide” a space is missing before Attila Bakos. It’d be great, if you rerendered the video and uploaded the improved version. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152396] Variable font: variants are not correctly selected
https://bugs.documentfoundation.org/show_bug.cgi?id=152396 --- Comment #4 from خالد حسني --- I tried to debug this and now I’m very skeptical that font width ever worked, it seems to be ignored left and right. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94524] Add option to remove trailing spaces in the Basic IDE
https://bugs.documentfoundation.org/show_bug.cgi?id=94524 Rafael Lima changed: What|Removed |Added Summary|IDE (Integrated Development |Add option to remove |Environment) Removing |trailing spaces in the |tailing spaces/tabs |Basic IDE Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 94524] Add option to remove trailing spaces in the Basic IDE
https://bugs.documentfoundation.org/show_bug.cgi?id=94524 Rafael Lima changed: What|Removed |Added Summary|IDE (Integrated Development |Add option to remove |Environment) Removing |trailing spaces in the |tailing spaces/tabs |Basic IDE Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 94524] IDE (Integrated Development Environment) Removing tailing spaces/tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=94524 Rafael Lima changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #3 from Rafael Lima --- We could have an option in the Edit menu named "Remove all trailing spaces". When the user clicks this command, it will remove all trailing spaces in the currently open module. This way, we wouldn't need to create a new setting. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113108] [META] Dialog UI/UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113108 Bug 113108 depends on bug 62948, which changed state. Bug 62948 Summary: IDE Object catalog: Enter does not openen a selected module/function https://bugs.documentfoundation.org/show_bug.cgi?id=62948 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62948] IDE Object catalog: Enter does not openen a selected module/function
https://bugs.documentfoundation.org/show_bug.cgi?id=62948 Rafael Lima changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC||rafael.palma.l...@gmail.com --- Comment #4 from Rafael Lima --- I just tried this today and Enter opens the selected module in the Object Catalog. Tested with Version: 7.4.2.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 12; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.4.2~rc3-0ubuntu1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152381] sal_Int32 comphelper::date::YearToDays(sal_Int16): Assertion `nYear != 0' failed.
https://bugs.documentfoundation.org/show_bug.cgi?id=152381 --- Comment #2 from Eike Rathke --- Sure, if code sets/uses a date with year 0 (or even day=0,month=0,year=0 in this case) for the proleptic Gregorian calendar then that code is wrong ;-) That so far didn't matter because the Base code had its own and wrong conversion. Problem here seems to be a NULL value of the database that is *not* a date to be converted to relative days, entering connectivity/source/commontools/dbconversion.cxx dbtools::DBTypeConversion::toDouble() with _rVal all 0 then via dbtools::DBTypeConversion::toDays() dbtools::implRelativeToAbsoluteNull() calls the now new comphelper::date::convertDateToDaysNormalizing() that via its calls asserts. The old dbtools::implRelativeToAbsoluteNull() implementation for day=0,month=0,year=0 returned -365 for that "date", which is completely off. Whatever the old now eliminated dbtools::implBuildFromRelative() did for such.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152392] Elements sidebar font in system dark mode lacks contrast: black on grey
https://bugs.documentfoundation.org/show_bug.cgi?id=152392 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 --- Comment #4 from Caolán McNamara --- I can reproduce -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152402] New: Prints dark background instead of white with custom dark settings
https://bugs.documentfoundation.org/show_bug.cgi?id=152402 Bug ID: 152402 Summary: Prints dark background instead of white with custom dark settings Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nopainenogai...@hushmail.com Description: The same settings in version 7 do not work as in version 6 of Libreoffice Writer. Dark settings while typing are a must but the printer prints the page dark instead of it remaining white. Not usable this way. Steps to Reproduce: 1.The steps to create dark mode--only affects top part of document 2.changing the doc to dark 3.I uninstalled LO, hoping to reinstall version 6 and find that not possible. I cannot be more specific. Actual Results: The printer prints the dark background instead of a white background, as in version 6. Expected Results: I expected to see a white paper printed with black type. Reproducible: Always User Profile Reset: No Additional Info: I already uninstalled LO, hoping to reinstall version 6. Don't have that now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: instsetoo_native/CustomTarget_install.mk
instsetoo_native/CustomTarget_install.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 968242fe3220bc3df8104c163bc3a17eee5916c1 Author: Andrea Gelmini AuthorDate: Tue Dec 6 18:33:58 2022 +0100 Commit: Andrea Gelmini CommitDate: Tue Dec 6 19:51:14 2022 + Fix typo Change-Id: I30f6c0d9a3d373078cffc46a243cdde99e707b81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143742 Tested-by: Jenkins Reviewed-by: Andrea Gelmini diff --git a/instsetoo_native/CustomTarget_install.mk b/instsetoo_native/CustomTarget_install.mk index 1e6fb07e88ec..fd27209c533e 100644 --- a/instsetoo_native/CustomTarget_install.mk +++ b/instsetoo_native/CustomTarget_install.mk @@ -94,7 +94,7 @@ $(call gb_CustomTarget_get_workdir,instsetoo_native/install)/msi_templates/%/Bin rm -rf $@ && mkdir -p $@ && cd $@ && cp $(SRCDIR)/instsetoo_native/inc_common/windows/msi_templates/Binary/*.* ./ # with all languages the logfile name would be too long when building the windows installation set, -# that's the reason for the subsitution to multilang below in case more than just en-US is packaged +# that's the reason for the substitution to multilang below in case more than just en-US is packaged $(instsetoo_installer_targets): $(SRCDIR)/solenv/bin/make_installer.pl \ $(foreach ulf,$(instsetoo_ULFLIST),$(call gb_CustomTarget_get_workdir,instsetoo_native/install)/win_ulffiles/$(ulf).ulf) \ $(if $(filter-out WNT,$(OS)),\
[Libreoffice-bugs] [Bug 152396] Variable font: variants are not correctly selected
https://bugs.documentfoundation.org/show_bug.cgi?id=152396 خالد حسني changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from خالد حسني --- It does not seem to be a variable font issue, rather it seems that LibreOffice is failing to use the width variants at all, i.e. the width is always ignored. If you install the static fonts you get the same issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152393] configmgr and vcl warnings in Math since version 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=152393 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #1 from V Stuart Foote --- @stragu, any chance it is related to recent 9939ffb9b87e536b3217232b732218e82126ad6c for bug 151842? Reverting a chunk of work around https://gerrit.libreoffice.org/c/core/+/120753 Quick to tell by simply checking if it is throwing the errors on nightlys from before 2022-12-01? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102019 Bug 102019 depends on bug 122254, which changed state. Bug 122254 Summary: LO Impress Presentation minimizer: Text at the 3rd line is cut in the final message https://bugs.documentfoundation.org/show_bug.cgi?id=122254 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122254] LO Impress Presentation minimizer: Text at the 3rd line is cut in the final message
https://bugs.documentfoundation.org/show_bug.cgi?id=122254 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 94f51512bef4fecf4121ad79cfd8e3d2aa9ecca9 Author: Olivier Hallot AuthorDate: Tue Dec 6 19:32:19 2022 + Commit: Gerrit Code Review CommitDate: Tue Dec 6 19:32:19 2022 + Update git submodules * Update helpcontent2 from branch 'master' to 490d42493e8dbec31ad58978df5084b080a36fcb - Fix typo Change-Id: Ie6f0171043ce7f0efc3db60e1b9aab7f4c3a75c2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143716 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 2201e80bead1..490d42493e8d 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 2201e80bead1e137a96775b2b6081752caeed77f +Subproject commit 490d42493e8dbec31ad58978df5084b080a36fcb
[Libreoffice-bugs] [Bug 152392] Elements sidebar font in system dark mode lacks contrast: black on grey
https://bugs.documentfoundation.org/show_bug.cgi?id=152392 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #3 from V Stuart Foote --- No issue with Elements deck on Windows builds in os/DE 'Dark' color theme. fg of each element/example is the White of the formula canvas, good contrast to the bg. Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: c50cf1883af26daebdfc9d796ced3c20c222f43b CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/05120100.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 490d42493e8dbec31ad58978df5084b080a36fcb Author: Olivier Hallot AuthorDate: Tue Dec 6 19:24:15 2022 + Commit: Olivier Hallot CommitDate: Tue Dec 6 19:32:19 2022 + Fix typo Change-Id: Ie6f0171043ce7f0efc3db60e1b9aab7f4c3a75c2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143716 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/01/05120100.xhp b/source/text/scalc/01/05120100.xhp index d77d69a0e8..6481acc51f 100644 --- a/source/text/scalc/01/05120100.xhp +++ b/source/text/scalc/01/05120100.xhp @@ -81,7 +81,7 @@ does not contain -The cell contents does not contains the text or number defined in the text box on the right. +The cell contents does not contain the text or number defined in the text box on the right.
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 121297, which changed state. Bug 121297 Summary: LO Impress: "JPG Quality" overlapping with "Reduce image resolution" in Presentation Minimizer Wizard in some GTK3 https://bugs.documentfoundation.org/show_bug.cgi?id=121297 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang officecfg/registry sdext/source sd/uiconfig sd/UIConfig_simpress.mk
compilerplugins/clang/unusedenumconstants.writeonly.results | 2 officecfg/registry/data/org/openoffice/Office/PresentationMinimizer.xcu | 22 officecfg/registry/schema/org/openoffice/Office/PresentationMinimizer.xcs | 32 - sd/UIConfig_simpress.mk | 1 sd/uiconfig/simpress/ui/pminfodialog.ui | 46 + sdext/source/minimizer/impoptimizer.cxx | 9 sdext/source/minimizer/impoptimizer.hxx | 4 sdext/source/minimizer/informationdialog.cxx | 272 +- sdext/source/minimizer/informationdialog.hxx | 41 - sdext/source/minimizer/optimizerdialog.cxx| 3 sdext/source/minimizer/pppoptimizertoken.cxx | 13 sdext/source/minimizer/pppoptimizertoken.hxx | 13 12 files changed, 137 insertions(+), 321 deletions(-) New commits: commit 54f74923644c427f5d5c1aaf307be866d1991816 Author: Caolán McNamara AuthorDate: Tue Dec 6 16:34:23 2022 + Commit: Caolán McNamara CommitDate: Tue Dec 6 19:30:22 2022 + weld InformationDialog info dialog Change-Id: I6a3631fe06a1b46164f01d706ecefd7252509382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143740 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/compilerplugins/clang/unusedenumconstants.writeonly.results b/compilerplugins/clang/unusedenumconstants.writeonly.results index bf474efc7ad8..e78ed74414cd 100644 --- a/compilerplugins/clang/unusedenumconstants.writeonly.results +++ b/compilerplugins/clang/unusedenumconstants.writeonly.results @@ -3952,8 +3952,6 @@ sdext/source/minimizer/pppoptimizertoken.hxx:110 enum PPPOptimizerTokenEnum STR_SLIDES sdext/source/minimizer/pppoptimizertoken.hxx:116 enum PPPOptimizerTokenEnum STR_SUMMARY -sdext/source/minimizer/pppoptimizertoken.hxx:119 -enum PPPOptimizerTokenEnum STR_AUTOMATICALLY_OPEN sdext/source/minimizer/pppoptimizertoken.hxx:122 enum PPPOptimizerTokenEnum STR_DELETE_SLIDES sdext/source/minimizer/pppoptimizertoken.hxx:123 diff --git a/officecfg/registry/data/org/openoffice/Office/PresentationMinimizer.xcu b/officecfg/registry/data/org/openoffice/Office/PresentationMinimizer.xcu index f1ac8d8f1891..f9a9ea5e3546 100644 --- a/officecfg/registry/data/org/openoffice/Office/PresentationMinimizer.xcu +++ b/officecfg/registry/data/org/openoffice/Office/PresentationMinimizer.xcu @@ -47,9 +47,6 @@ The current presentation contains no OLE objects. Summary - -~Open newly created presentation - Delete %SLIDES slides. @@ -65,17 +62,20 @@ The current presentation contains no OLE objects. OK - -The Presentation Minimizer has successfully updated the presentation '%TITLE'. The file size has changed from %OLDFILESIZE MB to %NEWFILESIZE MB. + +Successfully updated the presentation '%TITLE'. + + +The file size has changed from %OLDFILESIZE MB to %NEWFILESIZE MB. - -The Presentation Minimizer has successfully updated the presentation '%TITLE'. The file size has changed from %OLDFILESIZE MB to approximated %NEWFILESIZE MB. + +The file size has changed from %OLDFILESIZE MB to approximated %NEWFILESIZE MB. - -The Presentation Minimizer has successfully updated the presentation '%TITLE'. The file size has changed to %NEWFILESIZE MB. + +The file size has changed to %NEWFILESIZE MB. - -The Presentation Minimizer has successfully updated the presentation '%TITLE'. The file size has changed to approximated %NEWFILESIZE MB. + +The file size has changed to approximated %NEWFILESIZE MB. Duplicating presentation... diff --git a/officecfg/registry/schema/org/openoffice/Office/PresentationMinimizer.xcs b/officecfg/registry/schema/org/openoffice/Office/PresentationMinimizer.xcs index d2148807ca01..8a6eadb7c3a8 100644 --- a/officecfg/registry/schema/org/openoffice/Office/PresentationMinimizer.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/PresentationMinimizer.xcs @@ -161,10 +161,6 @@ The current presentation contains no OLE objects. String STR_SUMMARY. Summary - - String STR_AUTOMATICALLY_OPEN. - ~Open newly created presentation - String STR_DELETE_SLIDES. Delete %SLIDES slides @@ -187,21 +183,25
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang include/vcl officecfg/registry sdext/source sd/uiconfig sd/UIConfig_simpress.mk vcl/inc vcl/source vcl/unx
compilerplugins/clang/unusedenumconstants.writeonly.results |
64
include/vcl/weld.hxx |
2
officecfg/registry/data/org/openoffice/Office/PresentationMinimizer.xcu |
110 -
officecfg/registry/schema/org/openoffice/Office/PresentationMinimizer.xcs |
146 -
sd/UIConfig_simpress.mk |
5
sd/uiconfig/simpress/ui/pmimagespage.ui |
201 +
sd/uiconfig/simpress/ui/pmintropage.ui|
134 +
sd/uiconfig/simpress/ui/pmobjectspage.ui |
120 +
sd/uiconfig/simpress/ui/pmslidespage.ui |
129 +
sd/uiconfig/simpress/ui/pmsummarypage.ui |
267 ++
sdext/source/minimizer/configurationaccess.cxx|
2
sdext/source/minimizer/configurationaccess.hxx|
6
sdext/source/minimizer/optimizerdialog.cxx|
1042 --
sdext/source/minimizer/optimizerdialog.hxx|
258 +-
sdext/source/minimizer/optimizerdialogcontrols.cxx|
604 -
sdext/source/minimizer/pppoptimizerdialog.cxx |
1
sdext/source/minimizer/pppoptimizertoken.cxx |
56
sdext/source/minimizer/pppoptimizertoken.hxx |
54
vcl/inc/wizdlg.hxx|
1
vcl/source/app/salvtables.cxx |
5
vcl/source/control/roadmapwizard.cxx |
5
vcl/unx/gtk3/gtkinst.cxx |
5
22 files changed, 1524 insertions(+), 1693 deletions(-)
New commits:
commit 353ede41b97729a98ac090f89889a055051db98c
Author: Caolán McNamara
AuthorDate: Tue Dec 6 15:30:10 2022 +
Commit: Caolán McNamara
CommitDate: Tue Dec 6 19:29:51 2022 +
add Assistant::set_page_side_image
Change-Id: I70685a74ebed465771473ce885f4f29af209cda6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143737
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 4b376d3ac44f..4b4ea74f13b3 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -650,6 +650,8 @@ public:
virtual void set_page_side_help_id(const OString& rHelpId) = 0;
+virtual void set_page_side_image(const OUString& rImage) = 0;
+
void connect_jump_page(const Link& rLink) {
m_aJumpPageHdl = rLink; }
};
diff --git a/sdext/source/minimizer/optimizerdialog.cxx
b/sdext/source/minimizer/optimizerdialog.cxx
index 15ce1c3d1187..4b7e6f039988 100644
--- a/sdext/source/minimizer/optimizerdialog.cxx
+++ b/sdext/source/minimizer/optimizerdialog.cxx
@@ -242,9 +242,7 @@ void OptimizerDialog::InitRoadmap()
ITEM_ID_SUMMARY}
);
-#if 0
-xPropertySet->setPropertyValue( "ImageURL", Any(
OUString("private:graphicrepository/" BMP_PRESENTATION_MINIMIZER) ) );
-#endif
+m_xAssistant->set_page_side_image(BMP_PRESENTATION_MINIMIZER);
}
void OptimizerDialog::UpdateConfiguration()
diff --git a/vcl/inc/wizdlg.hxx b/vcl/inc/wizdlg.hxx
index da3ff4d1af3a..31bd376168b6 100644
--- a/vcl/inc/wizdlg.hxx
+++ b/vcl/inc/wizdlg.hxx
@@ -134,6 +134,7 @@ namespace vcl
const Size& GetPageSizePixel() const { return maPageSize; }
voidSetRoadmapHelpId( const OString& _rId );
+voidSetRoadmapBitmap( const BitmapEx& maBitmap );
voidInsertRoadmapItem(int nIndex, const OUString& rLabel,
int nId, bool bEnabled);
voidDeleteRoadmapItems();
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 7af5cccb4e6b..39ee33de947f 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -2157,6 +2157,11 @@ public:
m_xWizard->SetRoadmapHelpId(rHelpId);
}
+virtual void set_page_side_image(const OUString& rImage) override
+{
+m_xWizard->SetRoadmapBitmap(createImage(rImage).GetBitmapEx());
+}
+
weld::Button* weld_widget_for_response(int nResponse) override;
virtual ~SalInstanceAssistant() override
diff --git a/vcl/source/control/roadmapwizard.cxx
b/vcl/source/control/roadmapwizard.cxx
index b1738d5bef83..fe4c53b92e02 100644
--- a/vcl/source/control/roadmapwizard.cxx
+++ b/vcl/source/control/roadmapwizard.cxx
@@ -228,6 +228,11 @@ namespace vcl
m_xRoadmapImpl->pRoadmap->SetHelpId( _rId );
}
+void RoadmapWizard::SetRoadmapBitmap(const BitmapEx& rBmp)
+{
+m_xRoadmapImpl->pRoadmap->SetRoadmapBitmap(rBmp);
+}
+
void RoadmapWizardMachine::SetRoadmapHelpId(const OString& rId)
{
[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Olivier Hallot changed: What|Removed |Added Depends on||152397 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152397 [Bug 152397] The explanation of the help page about Calc Input settings is not appropriate. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152397] The explanation of the help page about Calc Input settings is not appropriate.
https://bugs.documentfoundation.org/show_bug.cgi?id=152397 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Blocks||80430 --- Comment #1 from Olivier Hallot --- Does this makes it clearer? "If a range of cells is selected, each time Enter is pressed will select the next cell inside the range, according to the direction selected in Press Enter to move selection. Hence, enabling both options is useful when entering values into a range of cells sequentially." Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=80430 [Bug 80430] [META] Documentation gap for new features -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102985 V Stuart Foote changed: What|Removed |Added Depends on||152396 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152396 [Bug 152396] Variable font: variants are not correctly selected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 V Stuart Foote changed: What|Removed |Added Depends on||152396 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152396 [Bug 152396] Variable font: variants are not correctly selected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152396] Variable font: variants are not correctly selected
https://bugs.documentfoundation.org/show_bug.cgi?id=152396 V Stuart Foote changed: What|Removed |Added Blocks||103378, 102985 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102985 [Bug 102985] [META] Font bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152396] Variable font: variants are not correctly selected
https://bugs.documentfoundation.org/show_bug.cgi?id=152396 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8497 CC||kha...@aliftype.com, ||vsfo...@libreoffice.org --- Comment #2 from V Stuart Foote --- I'm sure خالد will comment, but I think https://gerrit.libreoffice.org/c/core/+/142028 was an incremental handling of variable fonts until (or even if) more work on HB based instantiation in PDF provides better glyph stamping. The mangled PS font names are there in the PDF, but I don't think we can expect the bitmap glyps to match appearance on VCL canvas yet. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152278] "Unimplemented mac encoding 18432 to unicode conversion"
https://bugs.documentfoundation.org/show_bug.cgi?id=152278 --- Comment #2 from Eyal Rozenberg --- (In reply to Dieter from comment #1) > Eyal, for me your comment doens't look like a bug report Then let me clarify for you: That message should not be printed. Either such conversion needs to happen, in which case the bug is that it's not implemented; or it doesn't need to happen, in which case the bug is that this message is printed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/CppunitTest_sw_mailmerge2.mk sw/qa
sw/CppunitTest_sw_mailmerge2.mk |1
sw/qa/extras/mailmerge/mailmerge2.cxx | 70 ++
2 files changed, 71 insertions(+)
New commits:
commit 8254bd826d6d415e80ef8dcfb39e8b5c67cf2aab
Author: Henry Castro
AuthorDate: Wed Nov 30 08:17:10 2022 -0400
Commit: Henry Castro
CommitDate: Tue Dec 6 18:13:40 2022 +
sw:qa: add mailmerge export directly pdf unit test
Signed-off-by: Henry Castro
Change-Id: I53570149a6e05f05f9ebff7d4931d7f1a02a27f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143490
Tested-by: Jenkins
diff --git a/sw/CppunitTest_sw_mailmerge2.mk b/sw/CppunitTest_sw_mailmerge2.mk
index 0dcd55714c5b..f7a376b09eac 100644
--- a/sw/CppunitTest_sw_mailmerge2.mk
+++ b/sw/CppunitTest_sw_mailmerge2.mk
@@ -29,6 +29,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_mailmerge2, \
tl \
unotest \
utl \
+vcl \
))
$(eval $(call gb_CppunitTest_use_externals,sw_mailmerge2, \
diff --git a/sw/qa/extras/mailmerge/mailmerge2.cxx
b/sw/qa/extras/mailmerge/mailmerge2.cxx
index 30c26402c1c3..20eb6b0f3896 100644
--- a/sw/qa/extras/mailmerge/mailmerge2.cxx
+++ b/sw/qa/extras/mailmerge/mailmerge2.cxx
@@ -14,7 +14,10 @@
#include
+#include
+#include
#include
+#include
#include
#include
#include
@@ -23,8 +26,12 @@
#include
#include
+#include
#include
#include
+#include
+#include
+#include
#include
#include
@@ -455,6 +462,69 @@ DECLARE_FILE_MAILMERGE_TEST(testTdf122156_file,
"linked-with-condition.odt", "5-
}
}
+DECLARE_SHELL_MAILMERGE_TEST(exportDirectToPDF_shell,
"linked-with-condition.odt", "5-with-blanks.ods",
+"names")
+{
+executeMailMerge();
+
+uno::Reference xModel(mxMMComponent, uno::UNO_QUERY);
+CPPUNIT_ASSERT(xModel.is());
+
+uno::Reference
xController(xModel->getCurrentController());
+CPPUNIT_ASSERT(xController.is());
+
+uno::Reference xSupplier(xController,
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xSupplier.is());
+
+uno::Reference
xPageCursor(xSupplier->getViewCursor(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xPageCursor.is());
+
+xPageCursor->jumpToFirstPage();
+CPPUNIT_ASSERT_EQUAL(sal_Int16(1), xPageCursor->getPage());
+
+uno::Reference xFrame(xController->getFrame());
+CPPUNIT_ASSERT(xFrame.is());
+
+uno::Reference xDispatchProvider(xFrame,
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xDispatchProvider.is());
+
+util::URL aURL;
+aURL.Complete = ".uno:ExportDirectToPDF";
+{
+uno::Reference
xParser(css::util::URLTransformer::create(
+
comphelper::getProcessComponentContext()));
+CPPUNIT_ASSERT(xParser.is());
+xParser->parseStrict(aURL);
+}
+
+uno::Reference xDispatch =
xDispatchProvider->queryDispatch(aURL, OUString(), 0);
+CPPUNIT_ASSERT(xDispatch.is());
+
+const OUString sExportTo(msMailMergeOutputURL + "/ExportDirectToPDF.pdf");
+uno::Sequence aArgs {
+comphelper::makePropertyValue("SynchronMode", true),
+comphelper::makePropertyValue("URL", sExportTo)
+};
+
+xDispatch->dispatch(aURL, aArgs);
+CPPUNIT_ASSERT(comphelper::DirectoryHelper::fileExists(sExportTo));
+
+SvFileStream aPDFFile(sExportTo, StreamMode::READ);
+SvMemoryStream aMemory;
+aMemory.WriteStream(aPDFFile);
+std::shared_ptr pPDFium = vcl::pdf::PDFiumLibrary::get();
+CPPUNIT_ASSERT(pPDFium);
+
+std::unique_ptr pPdfDocument
+= pPDFium->openDocument(aMemory.GetData(), aMemory.GetSize(),
OString());
+CPPUNIT_ASSERT(pPdfDocument);
+CPPUNIT_ASSERT_EQUAL(5, pPdfDocument->getPageCount());
+
+std::unique_ptr pPdfPage = pPdfDocument->openPage(0);
+CPPUNIT_ASSERT(pPdfPage);
+CPPUNIT_ASSERT_EQUAL(4, pPdfPage->getObjectCount());
+}
+
DECLARE_SHELL_MAILMERGE_TEST(testTdf121168, "section_ps.odt", "4_v01.ods",
"Tabelle1")
{
// A document starting with a section on a page with non-default page
style with header
[Libreoffice-commits] core.git: include/sfx2 sfx2/source svx/sdi sw/source
include/sfx2/sfxsids.hrc|1 +
sfx2/source/doc/objserv.cxx |2 +-
svx/sdi/svx.sdi |2 +-
sw/source/uibase/app/docsh2.cxx |6 --
4 files changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 7a6445eedde28675c575f74c09ff236963525d20
Author: Henry Castro
AuthorDate: Fri Nov 4 07:52:09 2022 -0400
Commit: Henry Castro
CommitDate: Tue Dec 6 18:13:06 2022 +
sfx2: rename FN_PARAM_1 to FN_NOUPDATE
The parameter is intended to not update the fields
from data source otherwise it will reset to the first
record.
Signed-off-by: Henry Castro
Change-Id: I204cd20b8eb0b3f26c204e139c72b479c83bbf0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142276
Tested-by: Jenkins
diff --git a/include/sfx2/sfxsids.hrc b/include/sfx2/sfxsids.hrc
index 4e9badc4346f..a0289c0881ab 100644
--- a/include/sfx2/sfxsids.hrc
+++ b/include/sfx2/sfxsids.hrc
@@ -673,6 +673,7 @@ class SvxZoomItem;
#define FN_PARAM_4 (FN_PARAM+63)
#define FN_PARAM_5 (FN_PARAM+64)
#define FN_PARAM_6 (FN_PARAM+65)
+#define FN_NOUPDATE (FN_PARAM+66)
#define FN_FAX (SID_SW_START + 28) /* Fax */
#define SID_KEYFUNC_START (SID_SC_START + 521)
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index bb2a01b77620..f0bc6172ab1d 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -1032,7 +1032,7 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
if (bMailPrepareExport)
{
SfxRequest aRequest(SID_MAIL_PREPAREEXPORT,
SfxCallMode::SYNCHRON, GetPool());
-aRequest.AppendItem(SfxBoolItem(FN_PARAM_1, true));
+aRequest.AppendItem(SfxBoolItem(FN_NOUPDATE, true));
ExecuteSlot(aRequest);
}
diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index d4e4f62450b6..bc1d9e5c429f 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -11770,7 +11770,7 @@ SfxVoidItem InsertRowsAfter SID_TABLE_INSERT_ROW_AFTER
]
SfxBoolItem PrepareMailExport SID_MAIL_PREPAREEXPORT
-(SfxBoolItem On FN_PARAM_1)
+(SfxBoolItem On FN_NOUPDATE)
[
AutoUpdate = FALSE,
FastCall = FALSE,
diff --git a/sw/source/uibase/app/docsh2.cxx b/sw/source/uibase/app/docsh2.cxx
index 99eaf2249423..ef3c607444e5 100644
--- a/sw/source/uibase/app/docsh2.cxx
+++ b/sw/source/uibase/app/docsh2.cxx
@@ -881,13 +881,15 @@ void SwDocShell::Execute(SfxRequest& rReq)
case SID_MAIL_PREPAREEXPORT:
{
-const SfxPoolItem* pNoUpdate;
+const SfxBoolItem* pNoUpdate = pArgs ?
+pArgs->GetItem(FN_NOUPDATE, false) :
+nullptr;
//pWrtShell is not set in page preview
if (m_pWrtShell)
m_pWrtShell->StartAllAction();
-if (!pArgs || (pArgs && !pArgs->HasItem(FN_PARAM_1, )))
+if (!pNoUpdate || !pNoUpdate->GetValue())
{
m_xDoc->getIDocumentFieldsAccess().UpdateFields( false );
m_xDoc->getIDocumentLinksAdministration().EmbedAllLinks();
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sfx2/source
sfx2/source/doc/objstor.cxx | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
New commits:
commit 4114f8e21a6b6a7733764ab23e02e3f30f846902
Author: Henry Castro
AuthorDate: Thu Nov 3 10:52:16 2022 -0400
Commit: Henry Castro
CommitDate: Tue Dec 6 18:11:50 2022 +
sfx2: add log information to catch the exception
Add log information for data analysis if the ExportTo
fails due to an exception.
Signed-off-by: Henry Castro
Change-Id: I888545da14f413a970faf50b3ce60d12966f3f9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142201
Tested-by: Jenkins CollaboraOffice
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 9ec5d7980296..c56efca7cf8f 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -2492,8 +2492,19 @@ bool SfxObjectShell::ExportTo( SfxMedium& rMedium )
}
return xFilter->filter( aArgs );
-}catch(...)
-{}
+}
+catch (const css::uno::RuntimeException & e)
+{
+SAL_INFO("sfx.doc", "ExportTo: " << e);
+}
+catch (const std::exception & e)
+{
+SAL_INFO("sfx.doc", "ExportTo: " << e.what());
+}
+catch(...)
+{
+SAL_INFO("sfx.doc", "ExportTo: Unknown exception!");
+}
}
return false;
[Libreoffice-commits] core.git: sw/qa sw/sdi sw/source
sw/qa/uibase/shells/shells.cxx | 31 +
sw/sdi/swriter.sdi |2 -
sw/source/uibase/shells/textsh1.cxx | 43
3 files changed, 75 insertions(+), 1 deletion(-)
New commits:
commit fa82e151d80d15eeb6dfae434f1dbb3b68907188
Author: Miklos Vajna
AuthorDate: Tue Dec 6 14:41:45 2022 +0100
Commit: Miklos Vajna
CommitDate: Tue Dec 6 18:08:58 2022 +
sw, .uno:InsertBookmark: add a new BookmarkText parameter and accept HTML
there
There was already an UNO command to insert a new bookmark with the
provided name, in a non-interactive way.
What was missing is to allow specifying the bookmark text, which is to
some extent not part of the bookmark, but e.g. the bookmark dialog
allows editing that still.
Add a new BookmarkText parameter to .uno:InsertBookmark, in case it's
specified then we interpret this as HTML and we create the bookmark on
the imported content, not simply at the current cursor position.
This is similar to commit 1c2ef850db29beb369dcc89a58fc73416ecd9c5c (sw,
.uno:TextFormField command: accept HTML in the FieldResult parameter,
2022-11-16), but that was for the field mode, while this is for the
bookmark mode of Zotero.
Change-Id: I4928d173e197796d40fdb53f81e84b6bfd77cdc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143736
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index 01be5fda10b3..1f89211e52e8 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -377,6 +377,37 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testUpdateFieldmarks)
CPPUNIT_ASSERT_EQUAL(OUString("new result 1new result 2"), aActual);
}
+CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testInsertBookmark)
+{
+// Given an empty document:
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+
+// When inserting a bookmark with text:
+OUString aExpectedBookmarkName("ZOTERO_BREF_GiQ7DAWQYWLy");
+uno::Sequence aArgs = {
+comphelper::makePropertyValue("Bookmark",
uno::Any(aExpectedBookmarkName)),
+comphelper::makePropertyValue("BookmarkText",
uno::Any(OUString("aaabbb"))),
+};
+dispatchCommand(mxComponent, ".uno:InsertBookmark", aArgs);
+
+// Then make sure that we create a bookmark that covers that text:
+IDocumentMarkAccess& rIDMA = *pDoc->getIDocumentMarkAccess();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), rIDMA.getBookmarksCount());
+for (auto it = rIDMA.getBookmarksBegin(); it != rIDMA.getBookmarksEnd();
++it)
+{
+sw::mark::IMark* pMark = *it;
+CPPUNIT_ASSERT_EQUAL(aExpectedBookmarkName, pMark->GetName());
+SwPaM aPam(pMark->GetMarkStart(), pMark->GetMarkEnd());
+OUString aActualResult = aPam.GetText();
+// Without the accompanying fix in place, this test would have failed
with:
+// - Expected: aaa\nbbb
+// - Actual :
+// i.e. no text was inserted, the bookmark was collapsed.
+CPPUNIT_ASSERT_EQUAL(OUString("aaa\nbbb"), aActualResult);
+}
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi
index 42e24f93e878..84ca0997f982 100644
--- a/sw/sdi/swriter.sdi
+++ b/sw/sdi/swriter.sdi
@@ -2537,7 +2537,7 @@ SfxVoidItem InsertAuthoritiesEntry
FN_INSERT_AUTH_ENTRY_DLG
]
SfxVoidItem InsertBookmark FN_INSERT_BOOKMARK
-(SfxStringItem Bookmark FN_INSERT_BOOKMARK)
+(SfxStringItem Bookmark FN_INSERT_BOOKMARK, SfxStringItem BookmarkText
FN_PARAM_1)
[
AutoUpdate = FALSE,
FastCall = FALSE,
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index bf3f65e677d8..3b556b677415 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -109,6 +109,7 @@
#include
#include
#endif // ENABLE_WASM_STRIP_EXTRA
+#include
using namespace ::com::sun::star;
using namespace com::sun::star::beans;
@@ -688,10 +689,52 @@ void SwTextShell::Execute(SfxRequest )
}
case FN_INSERT_BOOKMARK:
{
+const SfxStringItem* pBookmarkText =
rReq.GetArg(FN_PARAM_1);
+SwPaM* pCursorPos = rWrtSh.GetCursor();
if ( pItem )
{
+rWrtSh.StartAction();
OUString sName = static_cast(pItem)->GetValue();
+
+if (pBookmarkText)
+{
+OUString aBookmarkText = pBookmarkText->GetValue();
+// Split node to remember where the start position is.
+bool bSuccess =
rWrtSh.GetDoc()->getIDocumentContentOperations().SplitNode(
+*pCursorPos->GetPoint(), /*bChkTableStart=*/false);
+if (bSuccess)
+{
+SwPaM
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/objstor.cxx | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
New commits:
commit 2fd5440c9766fa2833a3fc4dcb8a0d57a089121b
Author: Henry Castro
AuthorDate: Thu Nov 3 10:52:16 2022 -0400
Commit: Henry Castro
CommitDate: Tue Dec 6 18:08:32 2022 +
sfx2: add log information to catch the exception
Add log information for data analysis if the ExportTo
fails due to an exception.
Signed-off-by: Henry Castro
Change-Id: I888545da14f413a970faf50b3ce60d12966f3f9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142239
Tested-by: Jenkins
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 6c83b4066466..3b75c7e79ba9 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -2492,8 +2492,20 @@ bool SfxObjectShell::ExportTo( SfxMedium& rMedium )
}
return xFilter->filter( aArgs );
-}catch(...)
-{}
+}
+catch (const css::uno::RuntimeException&)
+{
+css::uno::Any ex(cppu::getCaughtException());
+TOOLS_INFO_EXCEPTION("sfx.doc", "exception: " <<
exceptionToString(ex));
+}
+catch (const std::exception& e)
+{
+TOOLS_INFO_EXCEPTION("sfx.doc", "exception: " << e.what());
+}
+catch(...)
+{
+TOOLS_INFO_EXCEPTION("sfx.doc", "Unknown exception!");
+}
}
return false;
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/column2.cxx | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
New commits:
commit cd90f9d0dcf0b6fc71161417deefb501929f67ce
Author: Noel Grandin
AuthorDate: Tue Dec 6 15:25:02 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Dec 6 18:05:49 2022 +
crashtesting forum-en-4598.ods
the pattern object may be replaced inside the IsValue() call
because it might trigger interpreter logic
Change-Id: I99cee16333f3ab0585d94de98946ea77938e14ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143734
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 7f3a5d1e3d5d..4f5c717cec4e 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -171,7 +171,18 @@ tools::Long ScColumn::GetNeededSize(
if (aCell.getType() == CELLTYPE_FORMULA)
{
ScFormulaCell* pFCell = aCell.getFormula();
-bCellIsValue = pFCell->IsRunning() || pFCell->IsValue();
+bCellIsValue = pFCell->IsRunning();
+if (!bCellIsValue)
+{
+bCellIsValue = pFCell->IsValue();
+if (bCellIsValue)
+{
+// the pattern may change in IsValue()
+pPattern = pAttrArray->GetPattern( nRow );
+if (ppPatternChange)
+*ppPatternChange = pPattern;
+}
+}
}
// #i111387#, tdf#121040: disable automatic line breaks for all number
formats
[Libreoffice-bugs] [Bug 120190] Data "Formula to Value" don't preserve line break with multi-line text value
https://bugs.documentfoundation.org/show_bug.cgi?id=120190 --- Comment #8 from Mike Kaganski --- Repro using Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - starmath/source
starmath/source/SmPanelFactory.cxx|2 +-
starmath/source/SmPropertiesPanel.cxx | 12
starmath/source/SmPropertiesPanel.hxx |7 +--
3 files changed, 14 insertions(+), 7 deletions(-)
New commits:
commit 689eb4a2e0890183b6ec2c54ccc07ba3c0d5c36b
Author: Mike Kaganski
AuthorDate: Tue Dec 6 11:22:47 2022 +0300
Commit: Mike Kaganski
CommitDate: Tue Dec 6 17:18:49 2022 +
tdf#150940: Store frame reference in the panel
It is needed to properly dispatch the commands in case of embedded
objects, otherwise they are dispatched to the top-level frame.
Change-Id: Ia5fadf7c35bded75f1ca20a682dc6c9f14548990
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143693
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 834f49b7e30ec9cc9bd050079b23995ad514b40c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143714
Tested-by: Jenkins CollaboraOffice
diff --git a/starmath/source/SmPanelFactory.cxx
b/starmath/source/SmPanelFactory.cxx
index 664adbcb3bcb..f14081e87bf3 100644
--- a/starmath/source/SmPanelFactory.cxx
+++ b/starmath/source/SmPanelFactory.cxx
@@ -88,7 +88,7 @@ css::uno::Reference SAL_CALL
SmPanelFactory::createUIElemen
css::ui::LayoutSize aLayoutSize{ -1, -1, -1 };
if (ResourceURL.endsWith("/MathPropertiesPanel"))
{
-pPanel = sm::sidebar::SmPropertiesPanel::Create(*pParent);
+pPanel = sm::sidebar::SmPropertiesPanel::Create(*pParent, xFrame);
}
else if (ResourceURL.endsWith("/MathElementsPanel"))
{
diff --git a/starmath/source/SmPropertiesPanel.cxx
b/starmath/source/SmPropertiesPanel.cxx
index 3ffd25c40e79..48f2c6897cd1 100644
--- a/starmath/source/SmPropertiesPanel.cxx
+++ b/starmath/source/SmPropertiesPanel.cxx
@@ -32,13 +32,17 @@
namespace sm::sidebar
{
// static
-std::unique_ptr SmPropertiesPanel::Create(weld::Widget& rParent)
+std::unique_ptr
+SmPropertiesPanel::Create(weld::Widget& rParent,
+ const css::uno::Reference&
xFrame)
{
-return std::make_unique(rParent);
+return std::make_unique(rParent, xFrame);
}
-SmPropertiesPanel::SmPropertiesPanel(weld::Widget& rParent)
+SmPropertiesPanel::SmPropertiesPanel(weld::Widget& rParent,
+ const
css::uno::Reference& xFrame)
: PanelLayout(, "MathPropertiesPanel",
"modules/smath/ui/sidebarproperties_math.ui")
+, mxFrame(xFrame)
, mpFormatFontsButton(m_xBuilder->weld_button("btnFormatFonts"))
, mpFormatFontSizeButton(m_xBuilder->weld_button("btnFormatFontSize"))
, mpFormatSpacingButton(m_xBuilder->weld_button("btnFormatSpacing"))
@@ -80,7 +84,7 @@ SmPropertiesPanel::~SmPropertiesPanel()
IMPL_LINK(SmPropertiesPanel, ButtonClickHandler, weld::Button&, rButton, void)
{
if (OUString command = maButtonCommands[]; !command.isEmpty())
-comphelper::dispatchCommand(command, {});
+comphelper::dispatchCommand(command, mxFrame, {});
}
} // end of namespace sm::sidebar
diff --git a/starmath/source/SmPropertiesPanel.hxx
b/starmath/source/SmPropertiesPanel.hxx
index e81463f37022..f19316e3fac1 100644
--- a/starmath/source/SmPropertiesPanel.hxx
+++ b/starmath/source/SmPropertiesPanel.hxx
@@ -31,13 +31,16 @@ namespace sm::sidebar
class SmPropertiesPanel : public PanelLayout
{
public:
-static std::unique_ptr Create(weld::Widget& rParent);
-SmPropertiesPanel(weld::Widget& rParent);
+static std::unique_ptr
+Create(weld::Widget& rParent, const
css::uno::Reference& xFrame);
+SmPropertiesPanel(weld::Widget& rParent, const
css::uno::Reference& xFrame);
~SmPropertiesPanel();
private:
DECL_LINK(ButtonClickHandler, weld::Button&, void);
+css::uno::Reference mxFrame;
+
std::unique_ptr mpFormatFontsButton;
std::unique_ptr mpFormatFontSizeButton;
std::unique_ptr mpFormatSpacingButton;
