[Libreoffice-ux-advise] [Bug 153299] Add drop-down menu to "Strikethrough" options
https://bugs.documentfoundation.org/show_bug.cgi?id=153299 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Keywords||needsUXEval --- Comment #2 from V Stuart Foote --- Actually we currently have a drop down, found in the 'Character' dialog -> 'Font Effects' 1. focus and select word or sentence (2 click, 3 click) 2. context menu (right mouse or keyboard) 3. character dialog 4. 'Font Effects' 5. 'Strikethrough' But currently the only defined UNO action (as used by Toolbar, Sidebar or Notebook Bar) is .uno:StrikeOut which applies the "Single" strikethrough effect. So request could be for additional UNO controls to use for customization. Or more simply to provide a UI control similar to the textunderlinecontrol.ui but for the strikeouts for the Toolbar, Sidebar or Notebookbar providing more direct access to a drop list of: RID_SVXITEMS_STRIKEOUT_NONE RID_SVXITEMS_STRIKEOUT_SINGLE RID_SVXITEMS_STRIKEOUT_DOUBLE RID_SVXITEMS_STRIKEOUT_DONTKNOW RID_SVXITEMS_STRIKEOUT_BOLD RID_SVXITEMS_STRIKEOUT_SLASH RID_SVXITEMS_STRIKEOUT_X -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153299] Add drop-down menu to "Strikethrough" options
https://bugs.documentfoundation.org/show_bug.cgi?id=153299 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Keywords||needsUXEval --- Comment #2 from V Stuart Foote --- Actually we currently have a drop down, found in the 'Character' dialog -> 'Font Effects' 1. focus and select word or sentence (2 click, 3 click) 2. context menu (right mouse or keyboard) 3. character dialog 4. 'Font Effects' 5. 'Strikethrough' But currently the only defined UNO action (as used by Toolbar, Sidebar or Notebook Bar) is .uno:StrikeOut which applies the "Single" strikethrough effect. So request could be for additional UNO controls to use for customization. Or more simply to provide a UI control similar to the textunderlinecontrol.ui but for the strikeouts for the Toolbar, Sidebar or Notebookbar providing more direct access to a drop list of: RID_SVXITEMS_STRIKEOUT_NONE RID_SVXITEMS_STRIKEOUT_SINGLE RID_SVXITEMS_STRIKEOUT_DOUBLE RID_SVXITEMS_STRIKEOUT_DONTKNOW RID_SVXITEMS_STRIKEOUT_BOLD RID_SVXITEMS_STRIKEOUT_SLASH RID_SVXITEMS_STRIKEOUT_X -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 4 commits - desktop/source include/vcl sw/inc sw/qa sw/sdi sw/source
desktop/source/lib/init.cxx |2
include/vcl/ITiledRenderable.hxx|2
sw/inc/cmdid.h |1
sw/inc/unotxdoc.hxx |4 -
sw/qa/uibase/shells/shells.cxx | 51 +
sw/qa/uibase/uno/uno.cxx| 28 +
sw/sdi/_textsh.sdi |6 ++
sw/sdi/swriter.sdi | 14 ++
sw/source/uibase/shells/textsh1.cxx | 73
sw/source/uibase/uno/loktxdoc.cxx | 42 +++-
10 files changed, 216 insertions(+), 7 deletions(-)
New commits:
commit 9f5bf1d44460fbff958c15bbe86d791050dcf1f1
Author: Pranam Lashkari
AuthorDate: Wed Jan 11 08:14:55 2023 +0530
Commit: Miklos Vajna
CommitDate: Wed Feb 1 08:39:49 2023 +0100
sw: rename .uno:UpdateSections command fields
renamed fields name in JSON to be consistent with section insertion and
getter
(cherry picked from commit 92deea6301a02f5530f17263f58402344f82013c)
Change-Id: Icca0be155542b7dc6df1b29e6c7d4191db8659ac
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index 261a363f12f9..93f9351313af 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -675,11 +675,11 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testUpdateSections)
"type": "[][]com.sun.star.beans.PropertyValue",
"value": [
{
-"Section": {
+"RegionName": {
"type": "string",
"value": "ZOTERO_BIBL {} CSL_BIBLIOGRAPHY RNDnew"
},
-"SectionText": {
+"Content": {
"type": "string",
"value": "new content"
}
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index 62ec341bdce7..8faa175ce88a 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -419,7 +419,7 @@ void UpdateSections(SfxRequest& rReq, SwWrtShell& rWrtSh)
}
comphelper::SequenceAsHashMap aMap(aSections[nSectionIndex++]);
-OUString aSectionName = aMap["Section"].get();
+OUString aSectionName = aMap["RegionName"].get();
if (aSectionName != pFormat->GetName())
{
const_cast(pFormat)->SetFormatName(aSectionName,
/*bBroadcast=*/true);
@@ -440,7 +440,7 @@ void UpdateSections(SfxRequest& rReq, SwWrtShell& rWrtSh)
rIDCO.DeleteAndJoin(*pCursorPos);
rWrtSh.EndSelect();
-OUString aSectionText = aMap["SectionText"].get();
+OUString aSectionText = aMap["Content"].get();
SwTranslateHelper::PasteHTMLToPaM(rWrtSh, pCursorPos,
aSectionText.toUtf8(), true);
}
}
commit 1602275e7717db9c5a49425c6113c0ae45b6765c
Author: Miklos Vajna
AuthorDate: Tue Jan 10 08:16:47 2023 +0100
Commit: Miklos Vajna
CommitDate: Wed Feb 1 08:34:53 2023 +0100
sw: add a new .uno:UpdateSections command
There was LOK API to insert a new section with provided HTML content and
to query it, but there was no LOK API to update such created section
with new names/contents.
This is needed in case Zotero wants to store citations with refmarks, in
which case it wants to store the bibliography with sections.
Introduce a .uno:UpdateSections UNO command that can do this: the
sections will be renamed if necessary & the content will be updated. The
content update is reasonably straightforward, because the section always
contains at least one empty paragraph, so there is no danger in simply
deleting the old content before inserting the new one.
This is similar to babba472391d26aed68d7ac31c7a918c08e65256 (sw,
UpdateFields: add new TypeName, NamePrefix and Fields parameters,
2023-01-04), but that was for refmarks / citations, this is for sections
/ bibliography.
(cherry picked from commit 71a479afb7e9762de930361e6089e23ab8d4af74)
Change-Id: Idde6d5ed1b0f25f40df502bb6b7e7ca590ef9151
diff --git a/sw/inc/cmdid.h b/sw/inc/cmdid.h
index 6f51a0e5e855..bec1acbe5446 100644
--- a/sw/inc/cmdid.h
+++ b/sw/inc/cmdid.h
@@ -323,6 +323,7 @@ class SwUINumRuleItem;
#define FN_EDIT_BOOKMARK(FN_INSERT2 + 33 ) /* Bookmark */
#define FN_UPDATE_BOOKMARKS (FN_INSERT2 + 34)
+#define FN_UPDATE_SECTIONS (FN_INSERT2 + 35)
// Region: Format
#define FN_AUTOFORMAT_APPLY (FN_FORMAT + 1 ) /* apply autoformat options */
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index 7457c62806c1..261a363f12f9 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -653,6 +653,57 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testUpdateFieldmark)
CPPUNIT_ASSERT_EQUAL(OUString("new result 1"), aActual);
}
+CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testUpdateSections)
Re: New Defects reported by Coverity Scan for LibreOffice
On 01/02/2023 02:37, Kohei Yoshida wrote:
On 28.01.2023 13:45, Caolán McNamara wrote:
FWIW this will disappear from the next libreoffice coverity run because
I typically patch it with try {} catch (...) { std::terminate(); } to
ignore warnings from "externals", but on upgrade I temporarily lost
that. It will however still appear in mdds's own separate coverity
results, which I refreshed yesterday.
I just borrowed your solution and called it "resolved", though I
believe, even without that explicit try catch block, it would just
terminate all the same?
Yes. But without the explicit try catch block it would help compiler
runtimes report the place where the (effectively uncaught, and
presumably "this can't happen"-style unexpected) exception was actually
thrown. I'm not convinced Coverity Scan is doing us a service here,
overall.
[Libreoffice-bugs] [Bug 98440] Copy and Paste of table rows un-does merging
https://bugs.documentfoundation.org/show_bug.cgi?id=98440 --- Comment #6 from Anandhi k --- yes Reproduced STEPS TO REPRODUCE: 1. Start Writer, insert a table with (say) 5 rows and 5 columns 2. Select two adjacent cells in a row, click the "Merge" icon (or Table->Merge).\ Insert unique text into every visible cell in the row 3. Select all cells in the row. Control-C to copy 4. Select all cells in another row. Control-P to paste RESULTS: The merged-ness of the copied cells is lost, and text is pasted into the wrong cells. Text in the first column is duplicated in the last column EXPECTED RESULTS: The pasted-onto row should look exactly like the source row. I had a commplicate with result if i use control-v instead of control -p in got a excepted result Environment:Linux Mint 21 Cinnamon Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 620ad1b7ae06d6f053fb2c9b57af96b736c04e57 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
Re: how to get started with contribution
On 31.1.2023 20.42, riya patil wrote: respected sir/madam, i am riya, a second year undergrad student at IGDTUW, delhi. i have just started learning about open source and i am would love to start my contribution from your organization . but could do you please help me with getting started ? hoping to hear from you soon. I have invited you to an interview. Ilmari
[Libreoffice-bugs] [Bug 152976] Print preview should start with right page, if document is in book view mode
https://bugs.documentfoundation.org/show_bug.cgi?id=152976 Dieter changed: What|Removed |Added Summary|Print preview should show |Print preview should start |left/right pages settings |with right page, if ||document is in book view ||mode --- Comment #3 from Dieter --- (In reply to Heiko Tietze from comment #2) > We have a two-pages preview with one always on the left and a book mode that > starts right (odd pages left). Is the problem to run the preview in the same > mode as the editing? Yes, print preview should start with right page, if document view is book mode First I thought, that it would also a good idea to have print preview with right page at the start, if document also contains left and right page styles. But of course there might be situations, where page style aren' used correctly. So I've changed bug summary and hope you agree. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152946] when sidebar is wider that some value, most of the final row of widgets is lost below the sidebar border, and is unreadable (but not necessarily unusable)
https://bugs.documentfoundation.org/show_bug.cgi?id=152946 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #1 from Dieter --- I can't confirm with Version: 7.5.0.2 (X86_64) / LibreOffice Community Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded but I'm also not sure, if I've grasped the steps to reproduce. Perhaps it is possible for you to add a screencast? Might also be relevant to know the size and resolution of your display. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153300] New: Format->Text menu name is confusing in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=153300 Bug ID: 153300 Summary: Format->Text menu name is confusing in Calc Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: needsUXEval, topicUI Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: er...@redhat.com In Calc, there is an important concept of cells' number format, which determines both content formatting, and recognition (conversion) of newly entered text. It is available through Format->Cells (Ctrl+1), "Numbers" tab [1]. The number formats are divided into categories, e.g. Number, Date, Text. The latter category, when applied to a cell, makes all following entry into the respective cell to be not converted to numbers and formulas, which is important for many use cases. There is rather established, common across many spreadsheet applications, idiom like "format cells as text". It means precisely the application of a number format from the respective category. In Calc, since 5.1, there is Format->Text menu [2]. It lists assorted items, some of which apply character formatting, others may edit the cell text itself (tdf#152197). These elements are not connected to the number formats discussed above. The name of the Format->Text menu creates a confusion in users [3]. People who get an advice to format cells as text, may try the Format->Text subentries. The proposal is to rename the Text menu name (which is common across different modules, i.e. Writer, Draw, ...) to something else - like maybe "Text Effects", or "String", or whatever (I realize that my wording is awful - I hope it just gives an idea). [1] https://help.libreoffice.org/7.5/en-US/text/shared/01/05020300.html?DbPAR=CALC [2] https://help.libreoffice.org/7.5/en-US/text/shared/submenu_text.html?=CALC [3] https://ask.libreoffice.org/t/keeping-zeros-infront-of-a-number/83306/3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/rtfexport/rtfexport5.cxx | 36 +++---
1 file changed, 16 insertions(+), 20 deletions(-)
New commits:
commit a262ee4c4a682f844ef380d5e843be1b3ec78c98
Author: Miklos Vajna
AuthorDate: Tue Jan 31 20:21:46 2023 +0100
Commit: Miklos Vajna
CommitDate: Wed Feb 1 07:03:38 2023 +
CppunitTest_sw_rtfexport5: fold preTest() into its only user
Avoid magic in preTest() based on the bugdoc name.
Change-Id: I7642828480bb4f636956b966275d8c3e26919a50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146421
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/rtfexport/rtfexport5.cxx
b/sw/qa/extras/rtfexport/rtfexport5.cxx
index 1104b9e4683b..fb020428ef03 100644
--- a/sw/qa/extras/rtfexport/rtfexport5.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport5.cxx
@@ -38,6 +38,7 @@
#include
#include
#include
+#include
using namespace css;
@@ -48,24 +49,6 @@ public:
: SwModelTestBase("/sw/qa/extras/rtfexport/data/", "Rich Text Format")
{
}
-
-virtual std::unique_ptr preTest(const char* filename) override
-{
-m_aSavedSettings = Application::GetSettings();
-if (filename == std::string_view("fdo72031.rtf"))
-{
-std::unique_ptr pResetter(
-new Resetter([this]() {
Application::SetSettings(this->m_aSavedSettings); }));
-AllSettings aSettings(m_aSavedSettings);
-aSettings.SetLanguageTag(LanguageTag("ru"));
-Application::SetSettings(aSettings);
-return pResetter;
-}
-return nullptr;
-}
-
-protected:
-AllSettings m_aSavedSettings;
};
DECLARE_RTFEXPORT_TEST(testFdo63023, "fdo63023.rtf")
@@ -756,9 +739,22 @@ DECLARE_RTFEXPORT_TEST(testFdo85889mac, "fdo85889-mac.rtf")
CPPUNIT_ASSERT_EQUAL(OUString(u"\u00D2\u00DA\u00DB"),
xTextRange->getString());
}
-DECLARE_RTFEXPORT_TEST(testFdo72031, "fdo72031.rtf")
+CPPUNIT_TEST_FIXTURE(Test, testFdo72031)
{
-CPPUNIT_ASSERT_EQUAL(OUString(u"\uF0C5"), getRun(getParagraph(1),
1)->getString());
+auto verify = [this]() {
+CPPUNIT_ASSERT_EQUAL(OUString(u"\uF0C5"), getRun(getParagraph(1),
1)->getString());
+};
+
+AllSettings aSavedSettings = Application::GetSettings();
+AllSettings aSettings(aSavedSettings);
+aSettings.SetLanguageTag(LanguageTag("ru"));
+Application::SetSettings(aSettings);
+comphelper::ScopeGuard g([] {
Application::SetSettings(aSavedSettings); });
+
+createSwDoc("fdo72031.rtf");
+verify();
+reload(mpFilter, "fdo72031.rtf");
+verify();
}
DECLARE_RTFEXPORT_TEST(testFdo86750, "fdo86750.rtf")
[Libreoffice-bugs] [Bug 152865] FILEOPEN RTF Paragraph below frame wrapped differently than in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=152865 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #4 from Dieter --- I confirm it with Version: 7.5.0.2 (X86_64) / LibreOffice Community Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114814] EDITING: Form Table control Field Copy disfunctional
https://bugs.documentfoundation.org/show_bug.cgi?id=114814 --- Comment #7 from Robert Großkopf --- Bug is still the same. "Copying" a listbox or a combobox won't copy the field content but copies a numeric field (listbox) or a text field (combobox) with connection to the datasource. Tested with LO 7.4.5.1 ob OpenSUSE 15.3 64bit rpm Linux -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153272] Writer Macro Find with certain Search Attributes performs Replacement.
https://bugs.documentfoundation.org/show_bug.cgi?id=153272 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126008] TABLES STYLES: Inserting a row/column changes entire table's formatting (see comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=126008 --- Comment #72 from Sasikumar --- OS :linux mint LIBRE OFFICE VERSION:7.3.7.2 STEPS:Description: When I insert a row above an existing row within a table, LibreWriter reverts the selected existing row to the default format. This is repeatable in multiple documents and different tables. I am using LibreOffice 6.2.4.2 (x64). Steps to Reproduce: 1.Select row (highlights the row) 2.Click Table | Insert | Rows Above 3. RESULT:bug partially reproduce reason:font size is automatically changed and left alignments are not changed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unosrch.cxx | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
New commits:
commit 2d9570523b16dd157384040642e3c2e0ed05
Author: Julien Nabet
AuthorDate: Mon Jan 30 22:00:31 2023 +0100
Commit: Noel Grandin
CommitDate: Wed Feb 1 06:49:59 2023 +
tdf#153272: add some missing properties in SwSearchProperties
RES_CHRATR_RELIEF
RES_CHRATR_ROTATE
RES_CHRATR_SCALEW
RES_PARATR_VERTALIGN
Change-Id: Ic4a3323a4b4b4231dee083016a6112a9e2674c86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146370
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/unocore/unosrch.cxx
b/sw/source/core/unocore/unosrch.cxx
index e7684861b5c9..4f716230de8d 100644
--- a/sw/source/core/unocore/unosrch.cxx
+++ b/sw/source/core/unocore/unosrch.cxx
@@ -140,7 +140,11 @@ void SwSearchProperties_Impl::FillItemSet(SfxItemSet&
rSet, bool bIsValueSearch)
pCTLLangItem,
pCTLPostureItem,
pCTLWeightItem,
-pShadowItem ;
+pShadowItem,
+pCharReliefItem,
+pCharRotate,
+pCharScaleWidth,
+pParaVertAlign;
auto funcClone = [](sal_uInt16 nWID, std::unique_ptr &
rpPoolItem)
{
@@ -298,6 +302,18 @@ void SwSearchProperties_Impl::FillItemSet(SfxItemSet&
rSet, bool bIsValueSearch)
case RES_CHRATR_SHADOW:
pTempItem = funcClone(nWID, pShadowItem);
break;
+case RES_CHRATR_RELIEF:
+pTempItem = funcClone(nWID, pCharReliefItem);
+break;
+case RES_CHRATR_ROTATE:
+pTempItem = funcClone(nWID, pCharRotate);
+break;
+case RES_CHRATR_SCALEW:
+pTempItem = funcClone(nWID, pCharScaleWidth);
+break;
+case RES_PARATR_VERTALIGN:
+pTempItem = funcClone(nWID, pParaVertAlign);
+break;
}
if(pTempItem)
{
[Libreoffice-bugs] [Bug 140184] Sort changes relative references same as absolute ones
https://bugs.documentfoundation.org/show_bug.cgi?id=140184 --- Comment #9 from Saravanan U --- Exactly as old Bug 81633. Not present in v.6, present in v.7. (1) open the attachment (2) select the rows from 2 to 6 (3) sort ascending in column B (date) The column E (each line with a relative reference to preceding line) is changed in the same way of column F (each line with an absolute reference to preceding column). software:linux 5.15 status : output produce ... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150451] Some text boxes in dialogs do not have borders in dark mode (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=150451 --- Comment #22 from Michael Weghorn --- (In reply to Rafael Lima from comment #21) > I have no scaling on my end. I'm using a 1080p display with 100% scaling. > When I use QT_SCALE_FACTOR=2.0 I also get no borders. > > But in my case I get no borders regardless of QT_SCALE_FACTOR. Interesting. So there must still be some other aspect that causes this. > BTW the best dialog to check these borders is Tools - Options - User Data, > because it has a lot of text boxes and it makes it easier to see the results. Here too, all textboxes have borders for me with QT_SCALE_FACTOR=1 or QT_SCALE_FACTOR=1.25, but no textbox has borders with QT_SCALE_FACTOR=1.5 or QT_SCALE_FACTOR=2. (The comboboxes have borders for all scale factors.) > Yes... I'll take a look. If I can't fix it, I'll share my findings here. Great, thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140184] Sort changes relative references same as absolute ones
https://bugs.documentfoundation.org/show_bug.cgi?id=140184 Saravanan U changed: What|Removed |Added CC||saravananu4...@gmail.com --- Comment #8 from Saravanan U --- Created attachment 185039 --> https://bugs.documentfoundation.org/attachment.cgi?id=185039=edit i got output ,form the bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124891] [META] Basic IDE bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=124891 Bug 124891 depends on bug 152073, which changed state. Bug 152073 Summary: Glitch rendering line numbers in Basic IDE editor (kf5 only) https://bugs.documentfoundation.org/show_bug.cgi?id=152073 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 152073, which changed state. Bug 152073 Summary: Glitch rendering line numbers in Basic IDE editor (kf5 only) https://bugs.documentfoundation.org/show_bug.cgi?id=152073 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152801] Input text for a formatted text box shows up as light gray instead of black.
https://bugs.documentfoundation.org/show_bug.cgi?id=152801 --- Comment #5 from Kate --- Unable to replicate (Windows 10), with or without dark mode. The provided PDF displayed light gray text as described (as well as appearing oversized and inappropriately vertically aligned); however, when I exported the provided ODT, the newly created pdf displayed black text. I also tried following the steps as described (creating a new document/pdf) to no avail. Document settings of the pdfs (as provided by Adobe Acrobat Reader) displayed similar font details for both the light gray and black results. Settings within odt also seemed identical though, again, I was unable to replicate when exporting so could not reliably identify potential differences. Not sure if more screenshots of settings would be beneficial or if it could be OS-related. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130961] LibreOffice Calc - Calculations frozen after solver and lost named ranges
https://bugs.documentfoundation.org/show_bug.cgi?id=130961 --- Comment #12 from biswaranjanpatra2...@gmail.com --- Here is the version information requested: Version: 6.0.7.3 Build ID: 1:6.0.7-0ubuntu0.18.04.10 CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: en-GB (en_GB.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/QtGraphics_Controls.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 6f4b8b7cfe2907b7da46eec6951a0e09b836a6de
Author: Michael Weghorn
AuthorDate: Tue Jan 31 16:08:53 2023 +0100
Commit: Michael Weghorn
CommitDate: Wed Feb 1 06:27:55 2023 +
tdf#152073 qt: Draw background when drawing frame
For native drawing of a frame (border), use
the window background color as default color.
As mentioned in commit f39f21d92ec83c3a5062f29dd26214fc83012c06
("tdf#138010 (IV) VclScrolledWindow: Use actual border width"),
the Qt/KDE Breeze style uses a frame width of 2, with the
actual 1 pixel border being surrounded by a 1 pixel
padding/margin.
Transparent background did not ensure that the 1 pixel
padding/margin is repainted and could thus result
in artifacts from what was painted to that location
previously (s. the Basic IDE editor example from
tdf#152073).
Use the window background for the default image color
when drawing a frame to avoid this.
The gtk3 VCL plugin also explicitly draws a background
for the corresponding code path, using
`gtk_render_background`.
An alternative might be to explicitly draw the
background further up the call stack, or pass
an explicit background color from
`DecorationView::DrawFrame` and only apply
a default color in `QtGraphics_Controls::drawNativeControl`
when a background color (other than `COL_DEFAULT`)
is passed to that method.
Sample bt for gtk3:
1 GtkSalGraphics::drawNativeControl salnativewidgets-gtk.cxx 1835
0x7fffe6271f92
2 SalGraphics::DrawNativeControlsalgdilayout.cxx 807
0x7fffee887739
3 OutputDevice::DrawNativeControl nativecontrols.cxx 287
0x7fffee58906e
4 (anonymous namespace)::ImplDrawFrame decoview.cxx 600
0x7fffee1b2055
5 DecorationView::DrawFrame decoview.cxx 886
0x7fffee1b32c8
6 ImplSmallBorderWindowView::DrawWindow brdwin.cxx 742
0x7fffee0ea3ea
7 ImplBorderWindow::Paint brdwin.cxx 1630
0x7fffee0ee99a
8 PaintHelper::DoPaint paint.cxx313
0x7fffee0c9f1c
9 vcl::Window::ImplCallPaintpaint.cxx617
0x7fffee0cb4b3
10 PaintHelper::~PaintHelper paint.cxx552
0x7fffee0cae14
11 vcl::Window::ImplCallPaintpaint.cxx623
0x7fffee0cb513
Many thanks to Rafael Lima for the
very helpful analysis in [1] and [2].
[1] https://bugs.documentfoundation.org/show_bug.cgi?id=152073#c2
[2] https://bugs.documentfoundation.org/show_bug.cgi?id=152073#c3
Change-Id: I08e6d05d0fc3d0e54952a65cd28dee92615df0a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146419
Reviewed-by: Rafael Lima
Tested-by: Jenkins
diff --git a/vcl/qt5/QtGraphics_Controls.cxx b/vcl/qt5/QtGraphics_Controls.cxx
index e6e3d820da59..e08b84719e61 100644
--- a/vcl/qt5/QtGraphics_Controls.cxx
+++ b/vcl/qt5/QtGraphics_Controls.cxx
@@ -283,6 +283,7 @@ bool QtGraphics_Controls::drawNativeControl(ControlType
type, ControlPart part,
break;
}
[[fallthrough]]; // QPalette::Window
+case ControlType::Frame:
case ControlType::Menubar:
case ControlType::WindowBackground:
m_image->fill(QApplication::palette().color(QPalette::Window).rgb());
[Libreoffice-commits] core.git: cui/source vcl/jsdialog
cui/source/dialogs/cuifmsearch.cxx |9 +++--
vcl/jsdialog/enabled.cxx |1 +
2 files changed, 8 insertions(+), 2 deletions(-)
New commits:
commit 36343165c251e30c700360cc5c4266f576d4ac00
Author: Hannah Meeks
AuthorDate: Wed Jan 25 11:07:28 2023 +
Commit: Szymon Kłos
CommitDate: Wed Feb 1 06:27:15 2023 +
cui: Make SimilaritySearch dialog async and enable use for jsdialog
Change-Id: I89c6665138c94aa355efbbc4aa0947226c68af5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146130
Tested-by: Jenkins
Reviewed-by: Szymon Kłos
diff --git a/cui/source/dialogs/cuifmsearch.cxx
b/cui/source/dialogs/cuifmsearch.cxx
index f1af2838c4b8..bb3bfaf5cac5 100644
--- a/cui/source/dialogs/cuifmsearch.cxx
+++ b/cui/source/dialogs/cuifmsearch.cxx
@@ -312,15 +312,20 @@ IMPL_LINK(FmSearchDialog, OnClickedSpecialSettings,
weld::Button&, rButton, void
if (m_ppbApproxSettings.get() == )
{
SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create();
-ScopedVclPtr
pDlg(pFact->CreateSvxSearchSimilarityDialog(m_xDialog.get(),
m_pSearchEngine->GetLevRelaxed(), m_pSearchEngine->GetLevOther(),
+
+VclPtr
pDlg(pFact->CreateSvxSearchSimilarityDialog(m_xDialog.get(),
m_pSearchEngine->GetLevRelaxed(), m_pSearchEngine->GetLevOther(),
m_pSearchEngine->GetLevShorter(),
m_pSearchEngine->GetLevLonger() ));
-if (pDlg->Execute() == RET_OK)
+pDlg->StartExecuteAsync([pDlg, this](sal_Int32 nResult){
+
+if (nResult == RET_OK)
{
m_pSearchEngine->SetLevRelaxed( pDlg->IsRelaxed() );
m_pSearchEngine->SetLevOther( pDlg->GetOther() );
m_pSearchEngine->SetLevShorter(pDlg->GetShorter() );
m_pSearchEngine->SetLevLonger( pDlg->GetLonger() );
}
+pDlg->disposeOnce();
+});
}
else if (m_pSoundsLikeCJKSettings.get() == )
{
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index e0791954d5f8..c11365d6dcbc 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -39,6 +39,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool
bMobile)
|| rUIFile == u"cui/ui/numberingformatpage.ui"
|| rUIFile == u"cui/ui/password.ui"
|| rUIFile == u"cui/ui/splitcellsdialog.ui"
+|| rUIFile == u"cui/ui/similaritysearchdialog.ui"
|| rUIFile == u"cui/ui/widgettestdialog.ui"
// scalc
|| rUIFile == u"modules/scalc/ui/analysisofvariancedialog.ui"
[Libreoffice-bugs] [Bug 150372] Clicking on "Character..." makes application freeze for ~1 minute in Win10 (RegeneratePrintDeviceCapabilities)
https://bugs.documentfoundation.org/show_bug.cgi?id=150372 --- Comment #14 from Rahamanshariff A --- 1-step followed 1. Select a word 2. Right-click, click "Character" -> "Character..." 2-Environment os windows 10, 8gp ram,intel i3,64bit 3-Result bug not produce 4-status unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: animations/source
animations/source/animcore/animcore.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit bed16c5e9df1eea4187b2b47a357414b3940bc91
Author: Andrea Gelmini
AuthorDate: Tue Jan 31 10:45:40 2023 +0100
Commit: Julien Nabet
CommitDate: Wed Feb 1 05:46:46 2023 +
Remove duplicated include
Change-Id: I84dc37baac93f946bd66b6d709a43529d023dac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146381
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/animations/source/animcore/animcore.cxx
b/animations/source/animcore/animcore.cxx
index 0f6f03aadabd..8963fa9f39c6 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -61,7 +61,6 @@
#include
#include
#include
-#include
namespace com::sun::star::uno { class XComponentContext; }
namespace com::sun::star::beans { struct NamedValue; }
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 9 commits - basctl/source basegfx/test chart2/source cui/source editeng/source filter/source include/basegfx include/editeng includ
Rebased ref, commits from common ancestor:
commit e781df7c6c3f60fea7b8fc2422baa7760d70b6af
Author: Tomaž Vajngerl
AuthorDate: Wed Nov 23 11:00:13 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Feb 1 13:17:51 2023 +0900
svx: convert SdrTextObj rotate and move to use gfx::Length
Change-Id: I82f10f82db8ac9d5653f4902276ee58fc18c52d6
diff --git a/include/basegfx/utils/RectangleWrapper.hxx
b/include/basegfx/utils/RectangleWrapper.hxx
index 00586d6eae71..4f5dbe851f66 100644
--- a/include/basegfx/utils/RectangleWrapper.hxx
+++ b/include/basegfx/utils/RectangleWrapper.hxx
@@ -55,6 +55,11 @@ public:
m_aRange.setSize(width, height);
}
+void shift(gfx::Length const& rXDelta, gfx::Length const& rYDelta)
+{
+m_aRange.shift(rXDelta, rYDelta);
+}
+
void move(sal_Int32 nXDelta, sal_Int32 nYDelta)
{
auto deltaX = gfx::Length::hmm(nXDelta);
diff --git a/svx/source/svdraw/svdotxtr.cxx b/svx/source/svdraw/svdotxtr.cxx
index 1055e5dbe3bb..9ccc69709abf 100644
--- a/svx/source/svdraw/svdotxtr.cxx
+++ b/svx/source/svdraw/svdotxtr.cxx
@@ -40,6 +40,35 @@
using namespace com::sun::star;
+namespace
+{
+gfx::Tuple2DL rotatePoint(gfx::Tuple2DL const& rPoint, gfx::Tuple2DL const&
rReference, double sinAngle, double cosAngle)
+{
+gfx::Length dx = rPoint.getX() - rReference.getX();
+gfx::Length dy = rPoint.getY() - rReference.getY();
+
+auto x = rReference.getX() + gfx::Length::emu(basegfx::fround(dx.raw() *
cosAngle + dy.raw() * sinAngle));
+auto y = rReference.getY() + gfx::Length::emu(basegfx::fround(dy.raw() *
cosAngle - dx.raw() * sinAngle));
+
+return gfx::Tuple2DL(x, y);
+}
+
+gfx::Tuple2DL toTuple(Point const& rPointHmm)
+{
+auto x = gfx::Length::hmm(rPointHmm.X());
+auto y = gfx::Length::hmm(rPointHmm.Y());
+return {x, y};
+}
+
+gfx::Size2DL toSize2D(Size const& rSizeHmm)
+{
+auto x = gfx::Length::hmm(rSizeHmm.Width());
+auto y = gfx::Length::hmm(rSizeHmm.Height());
+return {x, y};
+}
+
+} // end anonymous ns
+
void SdrTextObj::NbcSetSnapRect(const tools::Rectangle& rRect)
{
if (maGeo.nRotationAngle || maGeo.nShearAngle)
@@ -92,7 +121,9 @@ Degree100 SdrTextObj::GetShearAngle(bool /*bVertical*/) const
void SdrTextObj::NbcMove(const Size& rSize)
{
-moveRectangle(rSize.Width(), rSize.Height());
+gfx::Size2DL aSize2D = toSize2D(rSize);
+maRectangle.shift(aSize2D.getWidth(), aSize2D.getHeight());
+
moveOutRectangle(rSize.Width(), rSize.Height());
maSnapRect.Move(rSize);
SetBoundAndSnapRectsDirty(true);
@@ -183,27 +214,37 @@ void SdrTextObj::NbcResize(const Point& rRef, const
Fraction& xFact, const Fract
SetBoundAndSnapRectsDirty();
}
-void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double sn,
double cs)
+void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double
sinAngle, double cosAngle)
{
+auto aReference = toTuple(rRef);
+
SetGlueReallyAbsolute(true);
-tools::Long dx = getRectangle().Right() - getRectangle().Left();
-tools::Long dy = getRectangle().Bottom() - getRectangle().Top();
-Point aPoint1(getRectangle().TopLeft());
-RotatePoint(aPoint1, rRef, sn, cs);
-Point aPoint2(aPoint1.X() + dx, aPoint1.Y() + dy);
-tools::Rectangle aRectangle(aPoint1, aPoint2);
-setRectangle(aRectangle);
+auto const& rRange = maRectangle.getRange();
+
+auto nWidth = rRange.getWidth();
+auto nHeight = rRange.getHeight();
+
+gfx::Tuple2DL aPoint1(rRange.getMinX(), rRange.getMinY());
+aPoint1 = rotatePoint(aPoint1, aReference, sinAngle, cosAngle);
-if (maGeo.nRotationAngle==0_deg100) {
-maGeo.nRotationAngle=NormAngle36000(nAngle);
-maGeo.mfSinRotationAngle=sn;
-maGeo.mfCosRotationAngle=cs;
-} else {
-maGeo.nRotationAngle=NormAngle36000(maGeo.nRotationAngle+nAngle);
+gfx::Tuple2DL aPoint2(aPoint1.getX() + nWidth, aPoint1.getY() + nHeight);
+
+gfx::Range2DL aRange{aPoint1, aPoint2};
+maRectangle.setRange(aRange);
+
+if (maGeo.nRotationAngle == 0_deg100)
+{
+maGeo.nRotationAngle = NormAngle36000(nAngle);
+maGeo.mfSinRotationAngle = sinAngle;
+maGeo.mfCosRotationAngle = cosAngle;
+}
+else
+{
+maGeo.nRotationAngle = NormAngle36000(maGeo.nRotationAngle + nAngle);
maGeo.RecalcSinCos();
}
SetBoundAndSnapRectsDirty();
-NbcRotateGluePoints(rRef,nAngle,sn,cs);
+NbcRotateGluePoints(rRef, nAngle, sinAngle, cosAngle);
SetGlueReallyAbsolute(false);
}
commit ffac6ded8fdcf8cbe3d5ee24b45d9e511e615298
Author: Tomaž Vajngerl
AuthorDate: Tue Nov 22 13:33:30 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Feb 1 13:17:51 2023 +0900
svx: use RectangleWrapper for maRectangle on SdrTextObj
This is needed so we can now transition to use gfx::Length and
gfx::Range2DL to define the object position and size.
Change-Id:
[Libreoffice-bugs] [Bug 153299] Add drop-down menu to "Strikethrough" options
https://bugs.documentfoundation.org/show_bug.cgi?id=153299 Wolf Icefang changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Wolf Icefang --- I'll confirm this. There is no dropdown for choosing strikethrough type no matter what User Interface style you choose (Standard toolbar, tabbed, groupedbar compact, etc.). If you look in the Font Effects window https://help.libreoffice.org/7.4/en-US/text/shared/01/05020200.html you'll find a variety of strikethrough options. In favor: 1. Adding a dropdown arrow takes up relatively little space. 2. Some of the strikethrough options, like / and X, are very unique. 3. It's not even possible to set the various strikethrough types to keyboard shortcuts, so it's very inconvenient to use them. Against (devil's advocate): 1. Setting non-standard strikethrough is a pretty niche use case that people don't really need to discover or use. 2. There are quite a few extra underline types available in Font Effects... only a select few were chosen to reside in the main UI's underline dropdown. Which strikethrough options do we want to choose? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150472] Incorrect rendering of LibreOffice Logo in StartCenter
https://bugs.documentfoundation.org/show_bug.cgi?id=150472 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148994] Libre office writer crash on start in Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=148994 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148994] Libre office writer crash on start in Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=148994 --- Comment #7 from QA Administrators --- Dear minimaal6tek...@gmail.com, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140027] EDITING inserting rows before pivot table in row 1 copies format and images from headings
https://bugs.documentfoundation.org/show_bug.cgi?id=140027 --- Comment #3 from QA Administrators --- Dear Robert Lacroix, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98972] Writer table: changing data changes cell format; changing format changes cell data
https://bugs.documentfoundation.org/show_bug.cgi?id=98972 --- Comment #6 from QA Administrators --- Dear Paul, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98265] Poor formatting in Table of Contents with Multiple Fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=98265 --- Comment #11 from QA Administrators --- Dear Tim Chambers, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97310] AutoCorrect Doesn't Work with Zero-width Space
https://bugs.documentfoundation.org/show_bug.cgi?id=97310 --- Comment #5 from QA Administrators --- Dear Nathan Wells, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131001] Using PDF image using shfill displays correctly, but fails to export to PDF correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=131001 --- Comment #5 from QA Administrators --- Dear Ulrich Windl, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136583] Some resources from embedded PDF files (mainly those created by Scribus) disappear when exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=136583 --- Comment #7 from QA Administrators --- Dear dittnamn, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107896] MAILMERGE : "Exchange database" misses "next record" fields
https://bugs.documentfoundation.org/show_bug.cgi?id=107896 --- Comment #12 from QA Administrators --- Dear marc, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115239] BOOKMARKS: You can't delete a bookmark, if you only delete the word (without selecting something around the word)
https://bugs.documentfoundation.org/show_bug.cgi?id=115239 --- Comment #9 from QA Administrators --- Dear Julian Jung, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114814] EDITING: Form Table control Field Copy disfunctional
https://bugs.documentfoundation.org/show_bug.cgi?id=114814 --- Comment #6 from QA Administrators --- Dear Howard Johnson, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 7 commits - basctl/source basegfx/test chart2/source cui/source editeng/source filter/source include/basegfx include/editeng includ
Rebased ref, commits from common ancestor:
commit fc0fa12fd040716dfdb065773b5cffdfc34dc318
Author: Tomaž Vajngerl
AuthorDate: Wed Nov 23 11:00:13 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Feb 1 12:15:29 2023 +0900
svx: convert SdrTextObj rotate and move to use gfx::Length
Change-Id: I82f10f82db8ac9d5653f4902276ee58fc18c52d6
diff --git a/include/basegfx/utils/RectangleWrapper.hxx
b/include/basegfx/utils/RectangleWrapper.hxx
index 00586d6eae71..4f5dbe851f66 100644
--- a/include/basegfx/utils/RectangleWrapper.hxx
+++ b/include/basegfx/utils/RectangleWrapper.hxx
@@ -55,6 +55,11 @@ public:
m_aRange.setSize(width, height);
}
+void shift(gfx::Length const& rXDelta, gfx::Length const& rYDelta)
+{
+m_aRange.shift(rXDelta, rYDelta);
+}
+
void move(sal_Int32 nXDelta, sal_Int32 nYDelta)
{
auto deltaX = gfx::Length::hmm(nXDelta);
diff --git a/svx/source/svdraw/svdotxtr.cxx b/svx/source/svdraw/svdotxtr.cxx
index 1055e5dbe3bb..9ccc69709abf 100644
--- a/svx/source/svdraw/svdotxtr.cxx
+++ b/svx/source/svdraw/svdotxtr.cxx
@@ -40,6 +40,35 @@
using namespace com::sun::star;
+namespace
+{
+gfx::Tuple2DL rotatePoint(gfx::Tuple2DL const& rPoint, gfx::Tuple2DL const&
rReference, double sinAngle, double cosAngle)
+{
+gfx::Length dx = rPoint.getX() - rReference.getX();
+gfx::Length dy = rPoint.getY() - rReference.getY();
+
+auto x = rReference.getX() + gfx::Length::emu(basegfx::fround(dx.raw() *
cosAngle + dy.raw() * sinAngle));
+auto y = rReference.getY() + gfx::Length::emu(basegfx::fround(dy.raw() *
cosAngle - dx.raw() * sinAngle));
+
+return gfx::Tuple2DL(x, y);
+}
+
+gfx::Tuple2DL toTuple(Point const& rPointHmm)
+{
+auto x = gfx::Length::hmm(rPointHmm.X());
+auto y = gfx::Length::hmm(rPointHmm.Y());
+return {x, y};
+}
+
+gfx::Size2DL toSize2D(Size const& rSizeHmm)
+{
+auto x = gfx::Length::hmm(rSizeHmm.Width());
+auto y = gfx::Length::hmm(rSizeHmm.Height());
+return {x, y};
+}
+
+} // end anonymous ns
+
void SdrTextObj::NbcSetSnapRect(const tools::Rectangle& rRect)
{
if (maGeo.nRotationAngle || maGeo.nShearAngle)
@@ -92,7 +121,9 @@ Degree100 SdrTextObj::GetShearAngle(bool /*bVertical*/) const
void SdrTextObj::NbcMove(const Size& rSize)
{
-moveRectangle(rSize.Width(), rSize.Height());
+gfx::Size2DL aSize2D = toSize2D(rSize);
+maRectangle.shift(aSize2D.getWidth(), aSize2D.getHeight());
+
moveOutRectangle(rSize.Width(), rSize.Height());
maSnapRect.Move(rSize);
SetBoundAndSnapRectsDirty(true);
@@ -183,27 +214,37 @@ void SdrTextObj::NbcResize(const Point& rRef, const
Fraction& xFact, const Fract
SetBoundAndSnapRectsDirty();
}
-void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double sn,
double cs)
+void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double
sinAngle, double cosAngle)
{
+auto aReference = toTuple(rRef);
+
SetGlueReallyAbsolute(true);
-tools::Long dx = getRectangle().Right() - getRectangle().Left();
-tools::Long dy = getRectangle().Bottom() - getRectangle().Top();
-Point aPoint1(getRectangle().TopLeft());
-RotatePoint(aPoint1, rRef, sn, cs);
-Point aPoint2(aPoint1.X() + dx, aPoint1.Y() + dy);
-tools::Rectangle aRectangle(aPoint1, aPoint2);
-setRectangle(aRectangle);
+auto const& rRange = maRectangle.getRange();
+
+auto nWidth = rRange.getWidth();
+auto nHeight = rRange.getHeight();
+
+gfx::Tuple2DL aPoint1(rRange.getMinX(), rRange.getMinY());
+aPoint1 = rotatePoint(aPoint1, aReference, sinAngle, cosAngle);
-if (maGeo.nRotationAngle==0_deg100) {
-maGeo.nRotationAngle=NormAngle36000(nAngle);
-maGeo.mfSinRotationAngle=sn;
-maGeo.mfCosRotationAngle=cs;
-} else {
-maGeo.nRotationAngle=NormAngle36000(maGeo.nRotationAngle+nAngle);
+gfx::Tuple2DL aPoint2(aPoint1.getX() + nWidth, aPoint1.getY() + nHeight);
+
+gfx::Range2DL aRange{aPoint1, aPoint2};
+maRectangle.setRange(aRange);
+
+if (maGeo.nRotationAngle == 0_deg100)
+{
+maGeo.nRotationAngle = NormAngle36000(nAngle);
+maGeo.mfSinRotationAngle = sinAngle;
+maGeo.mfCosRotationAngle = cosAngle;
+}
+else
+{
+maGeo.nRotationAngle = NormAngle36000(maGeo.nRotationAngle + nAngle);
maGeo.RecalcSinCos();
}
SetBoundAndSnapRectsDirty();
-NbcRotateGluePoints(rRef,nAngle,sn,cs);
+NbcRotateGluePoints(rRef, nAngle, sinAngle, cosAngle);
SetGlueReallyAbsolute(false);
}
commit 79696c47efba27b79b378566bae16927aa705217
Author: Tomaž Vajngerl
AuthorDate: Tue Nov 22 13:33:30 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Feb 1 12:15:29 2023 +0900
svx: use RectangleWrapper for maRectangle on SdrTextObj
This is needed so we can now transition to use gfx::Length and
gfx::Range2DL to define the object position and size.
Change-Id:
[Libreoffice-bugs] [Bug 153299] New: Add drop-down menu to "Strikethrough" options
https://bugs.documentfoundation.org/show_bug.cgi?id=153299 Bug ID: 153299 Summary: Add drop-down menu to "Strikethrough" options Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@mail.ossii.com.tw Description: Please add drop-down menu to "Strikethrough" options, for now, we have this feature for "Underline" options. Steps to Reproduce: Click "Strikethrough" options. Actual Results: Just add strikethrough to text. Expected Results: Shows drop-down menu to select detail options. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.5.1 / LibreOffice Community Build ID: 40(Build:1) CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb) Locale: zh-TW (zh_TW.UTF-8); UI: zh-TW 7.4.5-1 Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - basegfx/test include/basegfx
basegfx/test/LengthUnitTest.cxx | 151 +-
include/basegfx/units/Length.hxx | 77 +
include/basegfx/units/LengthBase.hxx | 248 +++
include/basegfx/units/LengthTypes.hxx| 121 +++
include/basegfx/units/LengthUnitBase.hxx | 197
5 files changed, 489 insertions(+), 305 deletions(-)
New commits:
commit dab4c34e848f65b06065b5f3f3a3f4051d6e9004
Author: Tomaž Vajngerl
AuthorDate: Tue Jan 31 23:40:26 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Feb 1 11:50:45 2023 +0900
extend Length class
Change-Id: Idd2e17744c6305d8663cb29088150061be6d48c4
diff --git a/basegfx/test/LengthUnitTest.cxx b/basegfx/test/LengthUnitTest.cxx
index b7b072493573..7c4df24fe77c 100644
--- a/basegfx/test/LengthUnitTest.cxx
+++ b/basegfx/test/LengthUnitTest.cxx
@@ -19,7 +19,7 @@ public:
{
gfx::Length cm = 1_cm + 5_cm - 2_cm;
CPPUNIT_ASSERT_DOUBLES_EQUAL(4.0, cm.as_cm(), 1e-4);
-CPPUNIT_ASSERT_DOUBLES_EQUAL(0.04, cm.as_m(), 1e-4);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(0.04, cm.as_meter(), 1e-4);
CPPUNIT_ASSERT_DOUBLES_EQUAL(40.0, cm.as_mm(), 1e-4);
CPPUNIT_ASSERT_EQUAL(sal_Int64(144), cm.raw());
@@ -53,12 +53,12 @@ public:
CPPUNIT_ASSERT_EQUAL(sal_Int64(18 * 635 * 20), asLength.raw());
gfx::Length maximum = gfx::Length::emu(SAL_MAX_INT64);
-CPPUNIT_ASSERT_DOUBLES_EQUAL(256204778801.5, maximum.as_m(), 1e-1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(256204778801.5, maximum.as_meter(), 1e-1);
// 256204778 km
CPPUNIT_ASSERT_EQUAL(sal_Int64(SAL_MAX_INT64), maximum.raw());
gfx::Length minimum = gfx::Length::emu(SAL_MIN_INT64);
-CPPUNIT_ASSERT_DOUBLES_EQUAL(-256204778801.5, minimum.as_m(), 1e-1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(-256204778801.5, minimum.as_meter(),
1e-1);
CPPUNIT_ASSERT_DOUBLES_EQUAL(double(SAL_MIN_INT64), minimum.as_emu(),
1e-1);
CPPUNIT_ASSERT_EQUAL(sal_Int64(SAL_MIN_INT64), minimum.raw());
@@ -104,34 +104,21 @@ public:
CPPUNIT_ASSERT_DOUBLES_EQUAL(0.5, aRatio, 1e-9);
}
-void testInRange()
+void testGenericFrom()
{
-gfx::Range2DL aRange(1_cm, 2_cm, 2_cm, 30_mm);
-CPPUNIT_ASSERT_EQUAL(1_cm, aRange.getMinX());
-CPPUNIT_ASSERT_EQUAL(2_cm, aRange.getMaxX());
-CPPUNIT_ASSERT_EQUAL(2_cm, aRange.getMinY());
-CPPUNIT_ASSERT_EQUAL(3_cm, aRange.getMaxY());
+auto hmm1 = gfx::Length::from(gfx::LengthUnit::hmm, 1);
+CPPUNIT_ASSERT_EQUAL(sal_Int64(360), hmm1.raw());
+CPPUNIT_ASSERT_EQUAL(gfx::Length::hmm(1), hmm1);
-CPPUNIT_ASSERT_EQUAL(1_cm, aRange.getWidth());
-CPPUNIT_ASSERT_EQUAL(10_mm, aRange.getHeight());
-
-aRange.shift(1_cm, 1_cm);
-CPPUNIT_ASSERT_EQUAL(2_cm, aRange.getMinX());
-CPPUNIT_ASSERT_EQUAL(3_cm, aRange.getMinY());
-CPPUNIT_ASSERT_EQUAL(3_cm, aRange.getMaxX());
-CPPUNIT_ASSERT_EQUAL(40_mm, aRange.getMaxY());
-
-aRange.setSize(5_cm, 2_cm);
-CPPUNIT_ASSERT_EQUAL(2_cm, aRange.getMinX());
-CPPUNIT_ASSERT_EQUAL(3_cm, aRange.getMinY());
-CPPUNIT_ASSERT_EQUAL(7_cm, aRange.getMaxX());
-CPPUNIT_ASSERT_EQUAL(5_cm, aRange.getMaxY());
+auto twip2 = gfx::Length::from(gfx::LengthUnit::twip, 2);
+CPPUNIT_ASSERT_EQUAL(sal_Int64(1270), twip2.raw());
+CPPUNIT_ASSERT_EQUAL(gfx::Length::twip(2), twip2);
+}
-aRange.setPosition(0_cm, 0_cm);
-CPPUNIT_ASSERT_EQUAL(0_cm, aRange.getMinX());
-CPPUNIT_ASSERT_EQUAL(0_cm, aRange.getMinY());
-CPPUNIT_ASSERT_EQUAL(5_cm, aRange.getMaxX());
-CPPUNIT_ASSERT_EQUAL(2_cm, aRange.getMaxY());
+void testGenericAs()
+{
+CPPUNIT_ASSERT_EQUAL(1.0, (100_hmm).as(gfx::LengthUnit::mm));
+CPPUNIT_ASSERT_EQUAL(100.0, (1_m).as(gfx::LengthUnit::cm));
}
void testInTuple()
@@ -173,47 +160,90 @@ public:
CPPUNIT_ASSERT_EQUAL(true, aSize == aSize - gfx::Size2DL(0_emu,
0_emu));
CPPUNIT_ASSERT_EQUAL(true, aSize == aSize + gfx::Size2DL(0_emu,
0_emu));
}
+void testSizeLWrap()
+{
+{
+gfx::Size2DLWrap aSize(0.5_pt, 1_pt);
+CPPUNIT_ASSERT_EQUAL(6350_emu, aSize.getWidth());
+CPPUNIT_ASSERT_EQUAL(12700_emu, aSize.getHeight());
+
+gfx::Size2DLWrap aSize2(0_pt, 0_pt);
+aSize2.setWidth(0.5_pt);
+aSize2.setHeight(1_pt);
+
+CPPUNIT_ASSERT_EQUAL(6350_emu, aSize2.getWidth());
+CPPUNIT_ASSERT_EQUAL(12700_emu, aSize2.getHeight());
+
+CPPUNIT_ASSERT_EQUAL(true, aSize == aSize2);
+CPPUNIT_ASSERT_EQUAL(true, aSize != gfx::Size2DLWrap(0_emu,
0_emu));
+
+CPPUNIT_ASSERT_EQUAL(true, aSize == aSize -
gfx::Size2DLWrap(0_emu, 0_emu));
+CPPUNIT_ASSERT_EQUAL(true, aSize == aSize +
[Libreoffice-bugs] [Bug 66580] exported PDF is invalid because of forbidden custom keys in the trailer
https://bugs.documentfoundation.org/show_bug.cgi?id=66580 --- Comment #22 from Commit Notification --- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9740331d8bc56a9b6fbe3e4c1b26fb97f6639cc6 tdf#66580 write more metadata to embedded and attached files It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source include/vcl vcl/inc vcl/source
filter/source/pdf/pdfexport.cxx |2 +-
include/vcl/pdfwriter.hxx |2 +-
vcl/inc/pdf/pdfwriter_impl.hxx|3 ++-
vcl/source/gdi/pdfwriter.cxx |4 ++--
vcl/source/gdi/pdfwriter_impl.cxx | 36 +++-
5 files changed, 37 insertions(+), 10 deletions(-)
New commits:
commit 9740331d8bc56a9b6fbe3e4c1b26fb97f6639cc6
Author: Tomaž Vajngerl
AuthorDate: Sat Jan 28 19:28:06 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Feb 1 02:11:05 2023 +
tdf#66580 write more metadata to embedded and attached files
Change-Id: I6f40fd98b48893d01d29a806877821c561688897
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146288
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index 7e710dabd928..9d97f2134f41 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -935,7 +935,7 @@ bool PDFExport::Export( const OUString& rFile, const
Sequence< PropertyValue >&
else if (aSrcMimetype ==
"application/vnd.oasis.opendocument.graphics")
aExt = ".odg";
std::unique_ptr pStream(new
PDFExportStreamDoc(mxSrcDoc, aPreparedPermissionPassword));
-aPDFWriter.AddAttachedFile("Original" + aExt, aSrcMimetype,
std::move(pStream));
+aPDFWriter.AddAttachedFile("Original" + aExt, aSrcMimetype,
u"Embedded original document of this PDF file", std::move(pStream));
}
if ( pOut )
diff --git a/include/vcl/pdfwriter.hxx b/include/vcl/pdfwriter.hxx
index 80b71237138e..366cd6714412 100644
--- a/include/vcl/pdfwriter.hxx
+++ b/include/vcl/pdfwriter.hxx
@@ -1210,7 +1210,7 @@ The following structure describes the permissions used in
PDF security
@param pStream
the interface to the additional stream
*/
-void AddAttachedFile(OUString const& rFileName, const OUString& rMimeType,
std::unique_ptr pStream);
+void AddAttachedFile(OUString const& rFileName, OUString const& rMimeType,
OUString const& rDescription, std::unique_ptr pStream);
/// Write rString as a PDF hex string into rBuffer.
static void AppendUnicodeTextString(const OUString& rString,
OStringBuffer& rBuffer);
diff --git a/vcl/inc/pdf/pdfwriter_impl.hxx b/vcl/inc/pdf/pdfwriter_impl.hxx
index 32917315f66c..4e10204433cb 100644
--- a/vcl/inc/pdf/pdfwriter_impl.hxx
+++ b/vcl/inc/pdf/pdfwriter_impl.hxx
@@ -669,6 +669,7 @@ struct PDFDocumentAttachedFile
{
OUString maFilename;
OUString maMimeType;
+OUString maDescription;
sal_Int32 mnEmbeddedFileObjectId;
sal_Int32 mnObjectId;
};
@@ -1330,7 +1331,7 @@ public:
sal_Int32 createControl( const PDFWriter::AnyWidget& rControl, sal_Int32
nPageNr = -1 );
// attached file
-void addDocumentAttachedFile(OUString const& rFileName, OUString const&
rMimeType, std::unique_ptr rStream);
+void addDocumentAttachedFile(OUString const& rFileName, OUString const&
rMimeType, OUString const& rDescription, std::unique_ptr
rStream);
sal_Int32 addEmbeddedFile(BinaryDataContainer const & rDataContainer);
sal_Int32 addEmbeddedFile(std::unique_ptr rStream,
OUString const& rMimeType);
diff --git a/vcl/source/gdi/pdfwriter.cxx b/vcl/source/gdi/pdfwriter.cxx
index 7d53f45c4699..2582b392b1ae 100644
--- a/vcl/source/gdi/pdfwriter.cxx
+++ b/vcl/source/gdi/pdfwriter.cxx
@@ -443,9 +443,9 @@ PDFOutputStream::~PDFOutputStream()
{
}
-void PDFWriter::AddAttachedFile(OUString const& rFileName, OUString const&
rMimeType, std::unique_ptr pStream)
+void PDFWriter::AddAttachedFile(OUString const& rFileName, OUString const&
rMimeType, OUString const& rDescription, std::unique_ptr
pStream)
{
-xImplementation->addDocumentAttachedFile(rFileName, rMimeType,
std::move(pStream));
+xImplementation->addDocumentAttachedFile(rFileName, rMimeType,
rDescription, std::move(pStream));
}
std::set< PDFWriter::ErrorCode > const & PDFWriter::GetErrors() const
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 2a87f8cb4e23..8be74da9e1c5 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -3423,12 +3423,13 @@ bool PDFWriterImpl::appendDest( sal_Int32 nDestID,
OStringBuffer& rBuffer )
return true;
}
-void PDFWriterImpl::addDocumentAttachedFile(OUString const& rFileName,
OUString const& rMimeType, std::unique_ptr rStream)
+void PDFWriterImpl::addDocumentAttachedFile(OUString const& rFileName,
OUString const& rMimeType, OUString const& rDescription,
std::unique_ptr rStream)
{
sal_Int32 nObjectID = addEmbeddedFile(std::move(rStream), rMimeType);
auto& rAttachedFile = m_aDocumentAttachedFiles.emplace_back();
rAttachedFile.maFilename = rFileName;
rAttachedFile.maMimeType = rMimeType;
+rAttachedFile.maDescription = rDescription;
rAttachedFile.mnEmbeddedFileObjectId =
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/win
vcl/win/gdi/salnativewidgets-luna.cxx | 12
1 file changed, 12 insertions(+)
New commits:
commit c85107bc4ab93e2cdc9db1700577ec3f462d9fe9
Author: Caolán McNamara
AuthorDate: Tue Jan 31 10:22:35 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 1 01:58:06 2023 +
tdf#153287 rollover in dark mode with "Explorer" is incongruous
Using "CFD" gives a brighter border with rollover, but no notable
focus state when focused. Try a combination here to get something
decent.
Change-Id: If7844cb0f1e88410959aa622b0271c3f3954230e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146395
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/win/gdi/salnativewidgets-luna.cxx
b/vcl/win/gdi/salnativewidgets-luna.cxx
index 5ab4c6cb4dd6..1cd6245658d6 100644
--- a/vcl/win/gdi/salnativewidgets-luna.cxx
+++ b/vcl/win/gdi/salnativewidgets-luna.cxx
@@ -1189,7 +1189,11 @@ bool WinSalGraphics::drawNativeControl( ControlType
nType,
break;
case ControlType::Combobox:
if( nPart == ControlPart::Entire )
+{
+if (bUseDarkMode && !(nState & ControlState::FOCUSED))
+SetWindowTheme(mhWnd, L"CFD", nullptr);
hTheme = getThemeHandle(mhWnd, L"Edit",
mWinSalGraphicsImplBase);
+}
else if( nPart == ControlPart::ButtonDown )
{
if (bUseDarkMode)
@@ -1199,7 +1203,11 @@ bool WinSalGraphics::drawNativeControl( ControlType
nType,
break;
case ControlType::Spinbox:
if( nPart == ControlPart::Entire )
+{
+if (bUseDarkMode && !(nState & ControlState::FOCUSED))
+SetWindowTheme(mhWnd, L"CFD", nullptr);
hTheme = getThemeHandle(mhWnd, L"Edit",
mWinSalGraphicsImplBase);
+}
else
hTheme = getThemeHandle(mhWnd, L"Spin",
mWinSalGraphicsImplBase);
break;
@@ -1207,6 +1215,10 @@ bool WinSalGraphics::drawNativeControl( ControlType
nType,
hTheme = getThemeHandle(mhWnd, L"Spin", mWinSalGraphicsImplBase);
break;
case ControlType::Editbox:
+if (bUseDarkMode && !(nState & ControlState::FOCUSED))
+SetWindowTheme(mhWnd, L"CFD", nullptr);
+hTheme = getThemeHandle(mhWnd, L"Edit", mWinSalGraphicsImplBase);
+break;
case ControlType::MultilineEditbox:
hTheme = getThemeHandle(mhWnd, L"Edit", mWinSalGraphicsImplBase);
break;
Re: New Defects reported by Coverity Scan for LibreOffice
On 28.01.2023 13:45, Caolán McNamara wrote:
`On Sat, 2023-01-28 at 12:33 -0500, Kohei Yoshida wrote:
I've filed a ticket upstream:
https://gitlab.com/mdds/mdds/-/issues/82
I can look into this and figure out what is the optimal way to solve
it.
FWIW this will disappear from the next libreoffice coverity run because
I typically patch it with try {} catch (...) { std::terminate(); } to
ignore warnings from "externals", but on upgrade I temporarily lost
that. It will however still appear in mdds's own separate coverity
results, which I refreshed yesterday.
I just borrowed your solution and called it "resolved", though I
believe, even without that explicit try catch block, it would just
terminate all the same?
There may be a better way to handle this. But I'll wait until there is a
need.
Kohei
[Libreoffice-bugs] [Bug 153227] TOC Dialog Does Not Fit Screen
https://bugs.documentfoundation.org/show_bug.cgi?id=153227 --- Comment #16 from m.a.riosv --- To me, the issue is that the window doesn't keep with a so low resolution of 1024x768. More than a bug should be a request for enhancement to make the window resizable, or modify their design to make it more narrow and less high, to keep with that resolution. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153141] bizarre upper-, lower-case
https://bugs.documentfoundation.org/show_bug.cgi?id=153141 m.a.riosv changed: What|Removed |Added CC|miguelangelrv@libreoffice.o | |rg | --- Comment #5 from m.a.riosv --- (In reply to TorrAB from comment #4) > Why do I "have a direct format for 'orrens' as lowercase" ? Only you can know. > Style Heading1 has FontEffects>Case = Without, not UPPERCASE. Fine > ^m should not uppercase 'orrens' Because it was modified applying a direct format, which have precedence over styles. > Why does inserting the M work differently? BTW, enough for me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108897 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||153241 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153241 [Bug 153241] FILEOPEN: VmlDrawingsPart .emf embedded images are not shown correctly; elements moved down on Y axis -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||153241 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153241 [Bug 153241] FILEOPEN: VmlDrawingsPart .emf embedded images are not shown correctly; elements moved down on Y axis -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153241] FILEOPEN: VmlDrawingsPart .emf embedded images are not shown correctly; elements moved down on Y axis
https://bugs.documentfoundation.org/show_bug.cgi?id=153241 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||103859, 108897 --- Comment #8 from Stéphane Guillou (stragu) --- Thanks, Ilmari. You're right, what I saw in 6.2 and described at the end of comment 1 was the impact of the famous row height recalculation commit 1e55a47e89a9d9d6cf9cb3993484022aaf2c097b. Sorry about the confusion. Adding metas but you might be able to think of better ones. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108897 [Bug 108897] [META] XLSX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-22.05.10-1'
Tag 'cp-22.05.10-1' created by Andras Timar at 2023-01-31 23:15 + cp-22.05.10-1 Changes since cp-22.05.9-3-50: --- 0 files changed ---
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-22.05.10-1'
Tag 'cp-22.05.10-1' created by Andras Timar at 2023-01-31 23:15 + cp-22.05.10-1 Changes since cp-22.05.6-1-2: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-22.05.10-1'
Tag 'cp-22.05.10-1' created by Andras Timar at 2023-01-31 23:15 + cp-22.05.10-1 Changes since cp-22.05.6-1-1: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-22.05.10-1'
Tag 'cp-22.05.10-1' created by Andras Timar at 2023-01-31 23:15 + cp-22.05.10-1 Changes since cp-22.05.5-2: Aron Budea (1): Add Persian (fa-IR) dictionary --- Dictionary_fa.mk | 21 Module_dictionaries.mk|1 fa_IR/LICENSE | 15 fa_IR/META-INF/manifest.xml |6 fa_IR/README_fa_IR.txt| 26 fa_IR/description.xml | 22 fa_IR/dictionaries.xcu| 19 fa_IR/fa-IR.aff | 217 fa_IR/fa-IR.dic |104025 ++ fa_IR/icon.png|binary fa_IR/package-description.txt |4 11 files changed, 104356 insertions(+) ---
[Libreoffice-bugs] [Bug 152346] 7.5 alpha Windows 32-bit crashes on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=152346 David changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #5 from David --- (In reply to Stéphane Guillou (stragu) from comment #4) > Which installers did you use, David? And nobu, same question? I just tried the latest 7.5.0.3_x86 installer on both Windows 7 32 and 64-bit machines with any previous profile directory removed and the computer rebooted. LibreOffice still crashes on initialization. The earliest 7.5alpha that I know I tested is dated 11-24-2022. And all the ones I've tried since then have continued to fail. Default installations were used. KB3063858 is installed. I have not tried it on any later versions of Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 --- Comment #10 from Stéphane Guillou (stragu) --- Created attachment 185038 --> https://bugs.documentfoundation.org/attachment.cgi?id=185038=edit screenshot of issue in LO 7.5.0.2 This annotated screenshot shows the spellcheck dialog failing at using the paragraph's language, French. (Forget about that issue with whitespace inserted in the sentence, in comment 7, that must have been an error on my end. Haven't seen it again.) Version: 7.5.0.2 (X86_64) / LibreOffice Community Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 --- Comment #9 from Stéphane Guillou (stragu) --- (In reply to Stéphane Guillou (stragu) from comment #8) > Bibisected with linux-64-7.5 repo [...] Noel, note that I bibisected the "language is [none] in spelling dialog" issue, as described in comment 7. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153223] Red wavy lines under misspelt words disappears when viewing page at zoom factor of 160% or greater (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=153223 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2738 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 Stéphane Guillou (stragu) changed: What|Removed |Added Regression By||Noel Grandin Keywords|bibisectRequest |bibisected, bisected See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3223 CC||noelgran...@gmail.com Summary|LO75RC1: Automatic |LO75RC1: Automatic |spell-check on macOS not|spell-check not underlining |underlining misspelled |misspelled words; dialog |words |doesn't use paragraph's ||language Priority|medium |high --- Comment #8 from Stéphane Guillou (stragu) --- To bibisect, I had to first make sure that the extra dictionary was at the right spot. I copied it from my 7.5 installation /opt/libreoffice7.5/share/extensions/dict-fr and pasted in the local bibisect repo: [...]/linux-64-7.5/instdir/share/extensions/dict-fr Bibisected with linux-64-7.5 repo to first bad commit 84e282373a120d0a41bb96378085b253e8568e97 which points to core commit: commit b484e5d9e0d22b794c2d1c73741191836158a4ad[log] author Noel Grandin Sat Oct 08 07:54:48 2022 +0200 committer Noel Grandin Sun Oct 09 19:16:29 2022 +0200 treea1f8d3d3c7d0d5a01284e400f4c9d6f5d5dba260 parent ca1378b6552251743c92a19f9ce8b3833557b548 [diff] use more SwPosition::Assign part of the process of hiding the internals of SwPosition Change-Id: I20842b90d0abb4435d6b06970c2545229268e5e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141097 Noel, can you please have a look? Martin, regarding the underline issue: could you please check if it is at all related to the zoom level you are using? See bug 153223. An annotated screenshot of this aspect of the issue would be helpful. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=96000 Bug 96000 depends on bug 151972, which changed state. Bug 151972 Summary: Auto spell checker does not work https://bugs.documentfoundation.org/show_bug.cgi?id=151972 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153223] Red wavy lines under misspelt words disappears when viewing page at zoom factor of 160% or greater (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=153223 Stéphane Guillou (stragu) changed: What|Removed |Added CC||woodrack...@yahoo.com --- Comment #9 from Stéphane Guillou (stragu) --- *** Bug 151972 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151972] Auto spell checker does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=151972 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Stéphane Guillou (stragu) --- Looking at the screenshot, it looks like a high zoom level is used. I think it's a duplicate of bug 153223, and I'm marking as such, but David: can you please confirm that this depends on the zoom level, i.e. that the red lines come back at a lower zoom level? *** This bug has been marked as a duplicate of bug 153223 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 Hossein changed: What|Removed |Added Depends on||153294 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153294 [Bug 153294] Use copy_if, find_if or remove_if to simplify loops -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153294] Use copy_if, find_if or remove_if to simplify loops
https://bugs.documentfoundation.org/show_bug.cgi?id=153294 Hossein changed: What|Removed |Added CC||mentoring@documentfoundatio ||n.org Version|unspecified |4.4 all versions Keywords||difficultyBeginner, ||easyHack, skillCpp, ||topicCleanup Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125770] Smartart: Connection lines have wrong position
https://bugs.documentfoundation.org/show_bug.cgi?id=125770 --- Comment #9 from Hossein --- Still reproducible with the latest LO 7.6 dev master: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1af03aaa35dc9758a9702cddf48d9aad02ec7a94 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: fa-IR (fa_IR); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: lingucomponent/source
lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit d8e6b488ceaff7c88856ebcfcfec14d2d8cd7652 Author: Andrea Gelmini AuthorDate: Tue Jan 31 10:45:16 2023 +0100 Commit: Julien Nabet CommitDate: Tue Jan 31 21:53:56 2023 + Remove duplicated include Change-Id: Ia5f606fd64737aed372afb2ee4762f9eb3e21a86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146380 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx b/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx index d2c715325f26..9fb8a53bb300 100644 --- a/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx +++ b/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx @@ -43,7 +43,6 @@ #include #include #include -#include using namespace osl; using namespace com::sun::star;
[Libreoffice-bugs] [Bug 153297] A complex formula does not work in Calc 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=153297 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- The only way, it's with a sample file to verify the issue, please attach it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153297] A complex formula does not work in Calc 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=153297 --- Comment #1 from m.a.riosv --- *** Bug 153298 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153298] A complex formula does not work in Calc 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=153298 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 153297 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 34391] FORMATTING: Introduce table cell styles
https://bugs.documentfoundation.org/show_bug.cgi?id=34391 Hagar Delest changed: What|Removed |Added CC||delest.ha...@gmail.com --- Comment #30 from Hagar Delest --- Cell styles (primary target of this report) would also benefit the file structure. Today, cell styles are applied inside every single table like: ... Meaning that if cells have the same formatting in several tables, then the "style" will be duplicated for each table. Having cell styles recognized like character or paragraph styles would thus optimize the XML structure. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153298] New: A complex formula does not work in Calc 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=153298 Bug ID: 153298 Summary: A complex formula does not work in Calc 7.4.x Product: LibreOffice Version: 7.4.5.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yurijivanov...@gmail.com Description: In the Calc table of LibreOffice 7.3.7 and earlier, everything worked. In version 7.4.0 - 7.4.5, in the automatically filled sheet "DOWN" after any change of parameters in the sheets "LIST" ... "Ser", entries disappear. Steps to Reproduce: 1.The error cannot be described, because it appears in a specific table. But I don't see how to send it to you. 2. 3. Actual Results: When changing any parameter in the "LIST" ... "Ser" sheets, the data in the "DOWN" sheet disappears. Expected Results: Data should not disappear Reproducible: Always User Profile Reset: No Additional Info: The error occurs only in version 7.4.x. When returning to Calc 7.3.7 and earlier, the defect is absent, and then the damaged table can be restored by recalculating the fields of the "DOWN" sheet. The sample table is ready for you. Its size is slightly larger than 4 Mb. Where should you send it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153297] New: A complex formula does not work in Calc 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=153297 Bug ID: 153297 Summary: A complex formula does not work in Calc 7.4.x Product: LibreOffice Version: 7.4.5.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yurijivanov...@gmail.com Description: In the Calc table of LibreOffice 7.3.7 and earlier, everything worked. In version 7.4.0 - 7.4.5, in the automatically filled sheet "DOWN" after any change of parameters in the sheets "LIST" ... "Ser", entries disappear. Steps to Reproduce: 1.The error cannot be described, because it appears in a specific table. But I don't see how to send it to you. 2. 3. Actual Results: When changing any parameter in the "LIST" ... "Ser" sheets, the data in the "DOWN" sheet disappears. Expected Results: Data should not disappear Reproducible: Always User Profile Reset: No Additional Info: The error occurs only in version 7.4.x. When returning to Calc 7.3.7 and earlier, the defect is absent, and then the damaged table can be restored by recalculating the fields of the "DOWN" sheet. The sample table is ready for you. Its size is slightly larger than 4 Kb. Where should you send it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109527] [META] Spell check dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109527 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||152738 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152738 [Bug 152738] LO75RC1: Automatic spell-check on macOS not underlining misspelled words -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check on macOS not underlining misspelled words
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||109527 Keywords||bibisectRequest, regression Status|UNCONFIRMED |NEW OS|macOS (All) |All Ever confirmed|0 |1 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109527 [Bug 109527] [META] Spell check dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check on macOS not underlining misspelled words
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 --- Comment #7 from Stéphane Guillou (stragu) --- Created attachment 185037 --> https://bugs.documentfoundation.org/attachment.cgi?id=185037=edit test document I think I can partially reproduce the issue. I based this example document on the LO manual Martin linked, using page 2. I added a paragraph in French before the original paragraph, including some erroneous words for French: "paragraphee", "moot", "spellcheck". These words are underlined properly. However: 1. Place cursor at beginning of document 2. Tools > Spelling Results: Text language is "[None]", nothing is highlighted in the current sentence, a word is shown split, and only the "Add to dictionary" button is available. Version: 7.5.0.2 (X86_64) / LibreOffice Community Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded No issue in 7.4, the spelling tool goes straight to the first word underlined, buttons active, word highlighted, language correct. Version: 7.4.5.1 / LibreOffice Community Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153281] AutoConvert inconsistent choice between TEXT, DATE, NUMBER and FRACTION cell format.
https://bugs.documentfoundation.org/show_bug.cgi?id=153281 --- Comment #3 from ady --- (In reply to Eike Rathke from comment #2) > Note that the input of 1/4 getting converted to U+00BC ¼ happens already on > editing level, hence the input the cell receives is already text. Thank you for your reply. I still see this default behavior as non-intuitive and goes against other methods we have know for decades (e.g. forcing it as text by means of apostrophe). IOW, 2 inconsistencies, and very subjective default behavior. Users can't force each individual input to be treated as date - or as fraction. But each input can be forced to be treated as text. So choosing to force it to be a text by default reduces the available alternatives for users. It's a simple logical flowchart. When using AutoCorrect to force this input as text, the cell format should be text, not date. If Autocorrect is not enabled to force the input as text, then its OK for the cell format to be a date (and the input to be treated as such too). The current mix doesn't make sense to me, and certainly it is not intuitive or natural. -- You are receiving this mail because: You are the assignee for the bug.
Re: how to get started with contribution
Hi Riya, riya patil schrieb am 31.01.2023 um 19:42: respected sir/madam, i am riya, a second year undergrad student at IGDTUW, delhi. i have just started learning about open source and i am would love to start my contribution from your organization . You are welcome. but could do you please help me with getting started ? hoping to hear from you soon. Our mentors will answer you tomorrow at their working time. In the meantime you could have a look at the section "Getting Started with Development" on https://wiki.documentfoundation.org/Development Perhaps start with a video? https://www.youtube.com/watch?v=whHBiTwstWI Do you have used IRC already? You will meet most of the developers on https://web.libera.chat/?chan=#libreoffice-dev You should tell us, which operating system you will use and in which topic of LibreOffice you are interested in. And you should tell us whether you have experience in using LibreOffice. Kind regards, Regina
[Libreoffice-bugs] [Bug 153290] Object's text box is temporarily invisible after ungrouping
https://bugs.documentfoundation.org/show_bug.cgi?id=153290 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||vmik...@collabora.com --- Comment #2 from Stéphane Guillou (stragu) --- ... and when I said "now", I meant "when I realise I forgot about it"! :) Bibisected on linux-64-7.5 repo to first bad commit 6dd229bbde37ebc0cc51e2bda939249f4267ea56 which points to core commit: commit 914d246e0edcbdfa5969b7f3eea7c67e1a5b7522 author Miklos Vajna Wed Sep 28 08:54:06 2022 +0200 committer Miklos Vajna Wed Sep 28 09:46:30 2022 +0200 treed3df578b72b0af615bda06e69588fac49bd1599e parent ada3cf7a8392c59932fc339357cda9c3dda5c33f crashtesting: fix PDF export of fdo83057-2.docx Change-Id: Ia03f0ec70cf67626660349accc63770fe2afef5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140688 Miklos, can you please have a look? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150915] [META] Windows Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915 Bug 150915 depends on bug 122188, which changed state. Bug 122188 Summary: Disappear table lines of XLS opened with OS dark theme (XLSX OK) https://bugs.documentfoundation.org/show_bug.cgi?id=122188 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=109072 Bug 109072 depends on bug 122188, which changed state. Bug 122188 Summary: Disappear table lines of XLS opened with OS dark theme (XLSX OK) https://bugs.documentfoundation.org/show_bug.cgi?id=122188 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=143344 Bug 143344 depends on bug 122188, which changed state. Bug 122188 Summary: Disappear table lines of XLS opened with OS dark theme (XLSX OK) https://bugs.documentfoundation.org/show_bug.cgi?id=122188 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122188] Disappear table lines of XLS opened with OS dark theme (XLSX OK)
https://bugs.documentfoundation.org/show_bug.cgi?id=122188 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #16 from Caolán McNamara --- no, I think I just forget about this one -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152770] Insert - Envelope in a new document: warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152770 Caolán McNamara changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 110434] [META] Envelope bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=110434 Bug 110434 depends on bug 152770, which changed state. Bug 152770 Summary: Insert - Envelope in a new document: warnings in console with debug LO https://bugs.documentfoundation.org/show_bug.cgi?id=152770 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
how to get started with contribution
respected sir/madam, i am riya, a second year undergrad student at IGDTUW, delhi. i have just started learning about open source and i am would love to start my contribution from your organization . but could do you please help me with getting started ? hoping to hear from you soon. regards riya
[Libreoffice-bugs] [Bug 152770] Insert - Envelope in a new document: warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152770 --- Comment #17 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fa7d25625fa327ebc49ec8d0f96c192f4ed0c17b tdf#152770 undo move warning about ppd with no resolution to use of resolution It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svtools/source
svtools/source/config/languagetoolcfg.cxx | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
New commits:
commit 1af03aaa35dc9758a9702cddf48d9aad02ec7a94
Author: Caolán McNamara
AuthorDate: Tue Jan 31 11:48:13 2023 +
Commit: Caolán McNamara
CommitDate: Tue Jan 31 19:57:41 2023 +
language tool warnings in console on start up with language tool not
configured
warn:
languagetool:070:070:lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx:372:
CURL request returned with error: 3
warn:
languagetool:070:070:lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx:372:
CURL request returned with error: 3
Change-Id: I67de3351c6f01ed8274b4a282b45ded9f5cea5c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146418
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svtools/source/config/languagetoolcfg.cxx
b/svtools/source/config/languagetoolcfg.cxx
index b7bc2a56bd37..bc18e23980db 100644
--- a/svtools/source/config/languagetoolcfg.cxx
+++ b/svtools/source/config/languagetoolcfg.cxx
@@ -62,9 +62,19 @@ void SvxLanguageToolOptions::setUsername(const OUString&
rVal)
SetModified();
}
-OUString SvxLanguageToolOptions::getLocaleListURL() const { return
pImpl->sBaseURL + "/languages"; }
+OUString SvxLanguageToolOptions::getLocaleListURL() const
+{
+if (pImpl->sBaseURL.isEmpty())
+return OUString();
+return pImpl->sBaseURL + "/languages";
+}
-OUString SvxLanguageToolOptions::getCheckerURL() const { return
pImpl->sBaseURL + "/check"; }
+OUString SvxLanguageToolOptions::getCheckerURL() const
+{
+if (pImpl->sBaseURL.isEmpty())
+return OUString();
+return pImpl->sBaseURL + "/check";
+}
const OUString& SvxLanguageToolOptions::getApiKey() const { return
pImpl->sApiKey; }
[Libreoffice-commits] core.git: 2 commits - svtools/source vcl/unx
svtools/source/config/languagetoolcfg.cxx |5 -
vcl/unx/generic/printer/ppdparser.cxx |9 -
2 files changed, 12 insertions(+), 2 deletions(-)
New commits:
commit da27102aaa488d982164c54f8c7f8f3bc6181481
Author: Caolán McNamara
AuthorDate: Tue Jan 31 11:47:01 2023 +
Commit: Caolán McNamara
CommitDate: Tue Jan 31 19:57:32 2023 +
add default mode lines
Change-Id: Ie0485f52f81f31f821f8a6ebc4720528da33fa48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146417
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svtools/source/config/languagetoolcfg.cxx
b/svtools/source/config/languagetoolcfg.cxx
index 56d4a2431056..b7bc2a56bd37 100644
--- a/svtools/source/config/languagetoolcfg.cxx
+++ b/svtools/source/config/languagetoolcfg.cxx
@@ -1,4 +1,5 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+
/*
* This file is part of the LibreOffice project.
*
@@ -196,3 +197,5 @@ void SvxLanguageToolOptions::ImplCommit()
}
PutProperties(aNames, aValues);
}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
commit fa7d25625fa327ebc49ec8d0f96c192f4ed0c17b
Author: Caolán McNamara
AuthorDate: Tue Jan 31 11:37:17 2023 +
Commit: Caolán McNamara
CommitDate: Tue Jan 31 19:57:22 2023 +
tdf#152770 undo move warning about ppd with no resolution to use of
resolution
and downgrade to SAL_INFO
Change-Id: I9a565aa12f83e7ed8dd6b0f903f7b18d62c16c4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146416
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/generic/printer/ppdparser.cxx
b/vcl/unx/generic/printer/ppdparser.cxx
index 8f5c43b16e91..42a2a2a50cd8 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -678,6 +678,10 @@ PPDParser::PPDParser(OUString aFile, const
std::vector& keys)
auto pResolutions = getKey( "Resolution" );
if( pResolutions )
m_pDefaultResolution = pResolutions->getDefaultValue();
+if (pResolutions == nullptr) {
+SAL_INFO( "vcl.unx.print", "no Resolution in " << m_aFile);
+}
+SAL_INFO_IF(!m_pDefaultResolution, "vcl.unx.print", "no DefaultResolution
in " + m_aFile);
auto pInputSlots = getKey( "InputSlot" );
if( pInputSlots )
@@ -832,6 +836,10 @@ PPDParser::PPDParser( OUString aFile ) :
auto pResolutions = getKey( "Resolution" );
if( pResolutions )
m_pDefaultResolution = pResolutions->getDefaultValue();
+if (pResolutions == nullptr) {
+SAL_INFO( "vcl.unx.print", "no Resolution in " << m_aFile);
+}
+SAL_INFO_IF(!m_pDefaultResolution, "vcl.unx.print", "no DefaultResolution
in " + m_aFile);
auto pInputSlots = getKey( "InputSlot" );
if( pInputSlots )
@@ -1543,7 +1551,6 @@ void PPDParser::getDefaultResolution( int& rXRes, int&
rYRes ) const
return;
}
-SAL_WARN("vcl.unx.print", "no DefaultResolution in " << m_aFile << "
assuming 300x300");
rXRes = 300;
rYRes = 300;
}
[Libreoffice-bugs] [Bug 153296] FILESAVE DOCX VML shapetype is not detected as preset shape by Word
https://bugs.documentfoundation.org/show_bug.cgi?id=153296 Regina Henschel changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #2 from Regina Henschel --- Work has started in https://gerrit.libreoffice.org/c/core/+/146311. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103202] [META] About dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103202 Sierk Bornemann changed: What|Removed |Added Depends on||148071 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148071 [Bug 148071] change about info Mac OS X to macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148071] change about info Mac OS X to macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=148071 Sierk Bornemann changed: What|Removed |Added Blocks||103202 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103202 [Bug 103202] [META] About dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - configure.ac vcl/unx
configure.ac |2 +-
vcl/unx/generic/gdi/freetypetextrender.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit dadcf15b93ea7a20024f551327fed2744887a52f
Author: Andras Timar
AuthorDate: Tue Jan 31 20:18:41 2023 +0100
Commit: Andras Timar
CommitDate: Tue Jan 31 20:20:00 2023 +0100
Bump version to 22.05.10.1
Change-Id: I27a9ff61800178a2d1cdea300abb6d1cf704f81d
diff --git a/configure.ac b/configure.ac
index 046d9199e452..41095d2aed24 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([Collabora Office],[22.05.9.3],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[22.05.10.1],[],[],[https://collaboraoffice.com/])
dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just
fine if it is installed
dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails
hard
diff --git a/vcl/unx/generic/gdi/freetypetextrender.cxx
b/vcl/unx/generic/gdi/freetypetextrender.cxx
index ea8474e69fee..1a63f9d63076 100644
--- a/vcl/unx/generic/gdi/freetypetextrender.cxx
+++ b/vcl/unx/generic/gdi/freetypetextrender.cxx
@@ -149,7 +149,7 @@ void FreeTypeTextRenderImpl::GetFontMetric(
ImplFontMetricDataRef& rxFontMetric,
std::unique_ptr FreeTypeTextRenderImpl::GetTextLayout(int
nFallbackLevel)
{
-assert(mpFreetypeFont[nFallbackLevel]);
+//assert(mpFreetypeFont[nFallbackLevel]);
if (!mpFreetypeFont[nFallbackLevel])
return nullptr;
return std::make_unique(*mpFreetypeFont[nFallbackLevel]);
[Libreoffice-bugs] [Bug 148012] Deleting sheets multiple sheet slow (6 seconds with 7.4, compared to 1 second with 7.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=148012 Telesto changed: What|Removed |Added Keywords|bibisectRequest, perf | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148012] Deleting sheets multiple sheet slow (6 seconds with 7.4, compared to 1 second with 7.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=148012 Telesto changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #5 from Telesto --- Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 37e3455a13ab5741104bf41d05a80e60a4612682 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153282] Apple 'Finder' displays a 'Strange, Rainbow CD' image for my ODS files.
https://bugs.documentfoundation.org/show_bug.cgi?id=153282 Alex Thurgood changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #7 from Alex Thurgood --- Nik has found a way to correct the problem by activating native LO dialogs, so we can mark this as WFM. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153205] Selection not cleared when clicking elsewhere after copying text by ctrl-dragging
https://bugs.documentfoundation.org/show_bug.cgi?id=153205 --- Comment #17 from Buovjaga --- (In reply to Buovjaga from comment #9) > Sorry, I did not notice the uncontroversial point about selection staying > after clicking elsewhere. > > Bibisected with Windows 7.2 repo to > https://git.libreoffice.org/core/commit/ > a2f6b4e8995c149620db4fcfe7e355af4fbc869e > tdf#88064 In add mode don't change SetCursor and KillSel functions when > shell is popped Just a note in case it is not obvious: the relation here is that Ctrl + left mouse drag is a shortcut for Add mode selection. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153153] Incentivize users to use the latest version via the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=153153 --- Comment #4 from Maverick --- Wouldn't it be even great if users would be automatically updated/upgraded? I mean, we already have a dialog for auto-updating (that does not work in anyway and is, IMO, giving a very negative image about the product - it's 2023!) So why not put some effort in that and get this work finished? I believe it's a lot of work, but from it we could: - Get most users on the latest version (that would eliminate old bugs being reported) - It would help getting the "business" version even more tested and stable - It would provide all that a regular user is already expecting from a 2023 product (every piece of software i use auto-updates itself except for LO) - (Other advantages...) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131304] [META] MS Word compatibilityMode = 15
https://bugs.documentfoundation.org/show_bug.cgi?id=131304 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8952 -- You are receiving this mail because: You are the assignee for the bug.
