[Libreoffice-bugs] [Bug 45949] SPELL check does not work for words with hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=45949 --- Comment #20 from Mike Kaganski --- (In reply to László Németh from comment #15) > http://specs.openoffice.org/appwide/linguistic/Spellcheckdialog.sxw, > see also https://bz.apache.org/ooo/show_bug.cgi?id=40133. ... and these two also talk about general implementations, applicable to all components. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153317] New: MySQL/MariaDB direct connection: Content of field type 'Bit' isn't shown in Tools → SQL
https://bugs.documentfoundation.org/show_bug.cgi?id=153317 Bug ID: 153317 Summary: MySQL/MariaDB direct connection: Content of field type 'Bit' isn't shown in Tools → SQL Product: LibreOffice Version: 7.4.5.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de You will need a direct connection to MariaDB (or MySQL) for testing this bug. Create a field in a table as field type bit(1). Something like CREATE TABLE `test`.`tbl_Test` ( `ID` int(10) NOT NULL PRIMARY KEY, `Text` varchar(100) DEFAULT NULL, `Confirm` bit(1) DEFAULT NULL ); Add some content and click on "Confirm" for some rows. Execute this query in SQL-Mode: SELECT * FROM `test`.`tbl_Test` Will show the content of `Confirm` without problems. Now go to Tools → SQL. Set "Show output …". Execute the same query. No content appears for column `Confirm`. Same behavior will appear if you start the query by macro. No value could be found. Change the query: SELECT `ID`, `Text`, CASE WHEN `Confirm` THEN 1 ELSE 0 END FROM `test`.`tbl_Test` This query will give the correct 'values' for `Confirm`. Field type bit(1) couldn't be read directly through Tools → SQL or by macro with direct connection to MariaDB. This bug won't appear with JDBC connection to the same database. Tested with LO 7.4.5.1 on OpenSUSE 15.3 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/printer/printerinfomanager.cxx | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
New commits:
commit dccc056490a3d62e2a906a33862b09047ade925e
Author: Noel Grandin
AuthorDate: Wed Feb 1 14:12:48 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 07:43:10 2023 +
osl::Mutex->std::mutex in SystemQueueInfo
Change-Id: I4d81cee0c9bd02010399fc6670e1391b7acd50be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146466
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/unx/generic/printer/printerinfomanager.cxx
b/vcl/unx/generic/printer/printerinfomanager.cxx
index ae87f6adf0f7..ef140ad429b7 100644
--- a/vcl/unx/generic/printer/printerinfomanager.cxx
+++ b/vcl/unx/generic/printer/printerinfomanager.cxx
@@ -31,7 +31,6 @@
#include
#include
-#include
#include
// filename of configuration files
@@ -40,6 +39,7 @@ constexpr OUStringLiteral PRINT_FILENAME = u"psprint.conf";
constexpr OStringLiteral GLOBAL_DEFAULTS_GROUP = "__Global_Printer_Defaults__";
#include
+#include
#include
using namespace psp;
@@ -49,7 +49,7 @@ namespace psp
{
class SystemQueueInfo final : public Thread
{
-mutable Mutex m_aMutex;
+mutable std::mutex m_aMutex;
boolm_bChanged;
std::vector< PrinterInfoManager::SystemPrintQueue >
m_aQueues;
@@ -655,23 +655,21 @@ SystemQueueInfo::~SystemQueueInfo()
bool SystemQueueInfo::hasChanged() const
{
-MutexGuard aGuard( m_aMutex );
-bool bChanged = m_bChanged;
-return bChanged;
+std::unique_lock aGuard( m_aMutex );
+return m_bChanged;
}
void SystemQueueInfo::getSystemQueues( std::vector<
PrinterInfoManager::SystemPrintQueue >& rQueues )
{
-MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
rQueues = m_aQueues;
m_bChanged = false;
}
OUString SystemQueueInfo::getCommand() const
{
-MutexGuard aGuard( m_aMutex );
-OUString aRet = m_aCommand;
-return aRet;
+std::unique_lock aGuard( m_aMutex );
+return m_aCommand;
}
namespace {
@@ -873,7 +871,7 @@ void SystemQueueInfo::run()
{
std::vector< PrinterInfoManager::SystemPrintQueue >
aSysPrintQueues;
rParm.pHandler( aLines, aSysPrintQueues, );
-MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
m_bChanged = true;
m_aQueues = aSysPrintQueues;
m_aCommand = OUString::createFromAscii( rParm.pPrintCommand );
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 4 commits - sw/inc sw/qa sw/sdi sw/source
sw/inc/IDocumentMarkAccess.hxx |2
sw/inc/cmdid.h |2
sw/qa/uibase/shells/shells.cxx | 96 ++
sw/qa/uibase/uno/uno.cxx| 68
sw/sdi/_textsh.sdi | 11 +++
sw/sdi/swriter.sdi | 28 ++
sw/source/core/doc/docbm.cxx| 23
sw/source/core/inc/MarkManager.hxx |1
sw/source/uibase/shells/textfld.cxx | 54 +++
sw/source/uibase/shells/textsh1.cxx | 86 ++
sw/source/uibase/uno/loktxdoc.cxx | 100 +++-
11 files changed, 470 insertions(+), 1 deletion(-)
New commits:
commit 489ffdb01c121a54a5b242aad33909bece0da689
Author: Miklos Vajna
AuthorDate: Wed Jan 11 15:56:31 2023 +0100
Commit: Miklos Vajna
CommitDate: Thu Feb 2 08:40:25 2023 +0100
sw: add a new .uno:UpdateBookmark UNO command
It is possible to update all bookmarks (having a certain name prefix)
and their contet, but one can't update the bookmark under the cursor,
which is needed for Zotero citation clusters.
Fix the problem by adding a new .uno:UpdateBookmark UNO command that can
update the (innermost) bookmark under the current cursor.
This can be implemented on top of the recently added
IDocumentMarkAccess::getBookmarkFor().
The UNO command is intentionally hidden from the customize dialog since
it only makes sense to invoke it from a macro / API with parameters, not
interactively.
(cherry picked from commit ea208f6004770eb4b81d28e6930cd0c7bd5d8f12)
Change-Id: I3e750dfb637f50716be1155a94bc986131b84f20
diff --git a/sw/inc/cmdid.h b/sw/inc/cmdid.h
index befe8e26d607..3baa2f050ecc 100644
--- a/sw/inc/cmdid.h
+++ b/sw/inc/cmdid.h
@@ -325,6 +325,7 @@ class SwUINumRuleItem;
#define FN_UPDATE_BOOKMARKS (FN_INSERT2 + 34)
#define FN_UPDATE_SECTIONS (FN_INSERT2 + 35)
#define FN_DELETE_TEXT_FORMFIELDS (FN_INSERT2 + 36)
+#define FN_UPDATE_BOOKMARK (FN_INSERT2 + 37)
// Region: Format
#define FN_AUTOFORMAT_APPLY (FN_FORMAT + 1 ) /* apply autoformat options */
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index 8ca38e4a78d5..7bbfd83b6c06 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -749,6 +749,57 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testDeleteFieldmarks)
CPPUNIT_ASSERT_EQUAL(OUString("result 1result 2"), aActual);
}
+CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testUpdateBookmark)
+{
+// Given a document with a bookmarks, covering "BC":
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Insert("ABCD");
+pWrtShell->SttEndDoc(/*bStt=*/true);
+pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 1,
/*bBasicCall=*/false);
+pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/true, 2,
/*bBasicCall=*/false);
+pWrtShell->SetBookmark(vcl::KeyCode(), "ZOTERO_BREF_old");
+
+// When updating the content of the bookmark under the cursor:
+pWrtShell->SttEndDoc(/*bStt=*/true);
+pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 2,
/*bBasicCall=*/false);
+std::vector aArgsVec =
comphelper::JsonToPropertyValues(R"json(
+{
+"BookmarkNamePrefix": {
+"type": "string",
+"value": "ZOTERO_BREF_"
+},
+"Bookmark": {
+"type": "[]com.sun.star.beans.PropertyValue",
+"value": {
+"Bookmark": {
+"type": "string",
+"value": "ZOTERO_BREF_new"
+},
+"BookmarkText": {
+"type": "string",
+"value": "new result"
+}
+}
+}
+}
+)json");
+uno::Sequence aArgs =
comphelper::containerToSequence(aArgsVec);
+dispatchCommand(mxComponent, ".uno:UpdateBookmark", aArgs);
+
+// Then make sure that the only paragraph is updated correctly:
+SwCursor* pCursor = pWrtShell->GetCursor();
+OUString aActual = pCursor->GetPointNode().GetTextNode()->GetText();
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: Anew resultD
+// - Actual : ABCD
+// i.e. it was not possible to update just the bookmark under cursor.
+CPPUNIT_ASSERT_EQUAL(OUString("Anew resultD"), aActual);
+auto it = pDoc->getIDocumentMarkAccess()->findMark("ZOTERO_BREF_new");
+CPPUNIT_ASSERT(it != pDoc->getIDocumentMarkAccess()->getAllMarksEnd());
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/sdi/_textsh.sdi b/sw/sdi/_textsh.sdi
index 8dce73937deb..1098a9f14278 100644
--- a/sw/sdi/_textsh.sdi
+++ b/sw/sdi/_textsh.sdi
@@ -152,6 +152,11 @@ interface BaseText
StateMethod = GetState ;
DisableFlags="SfxDisableFlags::SwOnProtectedCursor";
]
+
[Libreoffice-bugs] [Bug 45949] SPELL check does not work for words with hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=45949 --- Comment #19 from Mike Kaganski --- Is there a tracker for other components (Calc, Impress) - since this is fixed for Writer, but its component is Linguistic? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152724] FILESAVE FORMATTING Cell custom Format Code with _- (UI visible space width) is not saved correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=152724 --- Comment #13 from ady --- (In reply to Laurent Balland from comment #12) > ? is now fixed in master (see bug 118324) TY. > 0 was already treated I'd like to emphasize that combining "?0" was not working in 7.4.4.2 for ods. I understand that you worked on the "?" part for 7.6; my point is that saying "0 was already treated" might be confusing to users, since the combination of "0" with some of the other codes was not working. > 0 was already treated, and any "reasonable" format combining #, ? and 0 > should be preserved in ODF in integer and decimal part. Would you please be so kind and mention here some example of "unreasonable" combination of "#, ? and 0"? Not only it would help for testing (now and in future versions), but especially to be aware and to be able to provide such information to other users. > _x still needs an ODF extension. I accordingly modified the summary. Would this RFE be assigned to someone for that? I compared the following 2 versions with an .ods file: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d8e6b488ceaff7c88856ebcfcfec14d2d8cd7652 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (es_AR); UI: en-US Calc: CL threaded Version: 7.4.4.2 (x64) / LibreOffice Community Build ID: 85569322deea74ec9134968a29af2df5663baa21 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: en-US (es_AR); UI: en-US Calc: CL Steps and Results (in the same order as described here): With 7.4.4.2: Saved as: _-?0;-?0;_-?0;@ Opened as: [>0]" "#;[<0]-#;" "#;@ Then with 7.6.0.0.alpha0+... Saved as: _-?0;-?0;_-?0;@ Opened as: [>0]" "?0;[<0]-?0;" "?0;@ Then closed without saving, and opened it in 7.4.4.2: [>0]" "00;[<0]-00;" "00;@ Please note the double zeros in the last one. Whether this could generate problems with users sharing files between different versions of LO, IDK. Whether this can be avoided, IDK either. (On a side note, the ods file seemed to be opened slightly slower in the aforementioned 7.6.0.0.alpha0+ than in 7.4.4.2.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153298] A complex formula does not work in Calc 7.4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=153298 --- Comment #2 from Yurij --- Created attachment 185057 --> https://bugs.documentfoundation.org/attachment.cgi?id=185057=edit The table of monthly results of the work of employees with the forms of output of annual reports. Any change in the parameter of any sheet from "LIST" to "Ser" in the "DOWN" sheet will delete all data. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/sdi
sw/sdi/_textsh.sdi |1 - 1 file changed, 1 deletion(-) New commits: commit 94c670f030fc63afe84ecfdfffc75d4764218754 Author: Miklos Vajna AuthorDate: Wed Feb 1 20:17:06 2023 +0100 Commit: Miklos Vajna CommitDate: Thu Feb 2 07:19:31 2023 + sw, FN_UPDATE_TEXT_FORMFIELD: remove unused StateMethod This was added in 337416dafb66ed8f930d2d69e83fae438fc85f3c (sw: add a new .uno:UpdateTextFormField UNO command, 2023-01-06), but only SwTextShell::ExecField() handles FN_UPDATE_TEXT_FORMFIELD, so the StateMethod is not needed. Change-Id: I237f82f7f3b5efa7e619576880d973d144c77b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146474 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/sw/sdi/_textsh.sdi b/sw/sdi/_textsh.sdi index cca84716962f..1f5db939267b 100644 --- a/sw/sdi/_textsh.sdi +++ b/sw/sdi/_textsh.sdi @@ -1821,7 +1821,6 @@ interface BaseText FN_UPDATE_TEXT_FORMFIELD [ ExecMethod = ExecField ; -StateMethod = StateField ; ] FN_DELETE_TEXT_FORMFIELDS
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/source
vcl/source/window/window2.cxx | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
New commits:
commit 8adad652f9853f54784cf8b9c99ce595e7bd4e9d
Author: Aron Budea
AuthorDate: Thu Feb 2 00:08:41 2023 +0100
Commit: Miklos Vajna
CommitDate: Thu Feb 2 07:19:13 2023 +
vcl: fix online crash in vcl::Window::IsTracking()
Crashreport signature:
program/libmergedlo.so
vcl::Window::IsTracking() const
vcl/source/window/window2.cxx:340
program/libmergedlo.so
(anonymous namespace)::LOKPostAsyncEvent(void*, void*)
sfx2/source/view/lokhelper.cxx:812
program/libmergedlo.so
LokChartHelper::postMouseEvent(int, int, int, int, int, int,
double, double)
include/rtl/ref.hxx:128
program/libmergedlo.so
SfxLokHelper::testInPlaceComponentMouseEventHit(SfxViewShell*, int,
int, int, int, int, int, double, double, bool)
sfx2/source/view/lokhelper.cxx:980
/program/libswlo.so
SwXTextDocument::postMouseEvent(int, int, int, int, int, int)
sw/source/uibase/uno/unotxdoc.cxx:3663
program/libmergedlo.so
doc_postMouseEvent
desktop/source/lib/init.cxx:4831
Change-Id: Iab7d24a901e57dc8af3fb2c77fbea3b4fdad9fb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146483
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/vcl/source/window/window2.cxx b/vcl/source/window/window2.cxx
index 7334d423e9bc..e16113add965 100644
--- a/vcl/source/window/window2.cxx
+++ b/vcl/source/window/window2.cxx
@@ -339,9 +339,15 @@ bool Window::IsTracking() const
{
if (!mpWindowImpl)
return false;
-return (mpWindowImpl->mbUseFrameData ?
-mpWindowImpl->mpFrameData->mpTrackWin == this :
-ImplGetSVData()->mpWinData->mpTrackWin == this);
+if (mpWindowImpl->mbUseFrameData && mpWindowImpl->mpFrameData)
+{
+return mpWindowImpl->mpFrameData->mpTrackWin == this;
+}
+if (!mpWindowImpl->mbUseFrameData && ImplGetSVData()->mpWinData)
+{
+return ImplGetSVData()->mpWinData->mpTrackWin == this;
+}
+return false;
}
void Window::StartAutoScroll( StartAutoScrollFlags nFlags )
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/strings.hrc |3 ++-
sfx2/source/view/viewfrm.cxx |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 4fa56b89cd1d306068a7ec8298b7ba1869e612a9
Author: Samuel Mehrbrodt
AuthorDate: Mon Jan 30 13:55:01 2023 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Feb 2 07:05:26 2023 +
Own title for macro infobars
Change-Id: If6ac6bb2379dfdc6080c768103e3d174c7bdc59c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146355
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/include/sfx2/strings.hrc b/include/sfx2/strings.hrc
index bafda3df1a6c..83e994bdde77 100644
--- a/include/sfx2/strings.hrc
+++ b/include/sfx2/strings.hrc
@@ -292,9 +292,10 @@
#define STR_HYPHENATION_BUTTON NC_("STR_HYPHENATION_BUTTON",
"Learn more")
#define STR_REFRESH_MASTER_PASSWORD
NC_("STR_REFRESH_MASTER_PASSWORD", "The master password is stored in an
outdated format, you should refresh it")
#define STR_REFRESH_PASSWORDNC_("STR_REFRESH_PASSWORD",
"Refresh Password")
+#define STR_MACROS_DISABLED_TITLE
NC_("STR_MACROS_DISABLED_TITLE", "Macros disabled")
#define STR_CONTAINS_MACROS NC_("STR_CONTAINS_MACROS",
"Macros in this document are disabled due to the Macro Security settings.")
#define STR_MACROS_DISABLED NC_("STR_MACROS_DISABLED",
"Macros are disabled due to the Macro Security settings.")
-#define STR_MACROS_DISABLED_CONTENT_UNSIGNED
NC_("STR_MACROS_DISABLED_CONTENT_UNSIGNED", "Macros are disabled. Macros are
signed, but the document (containing document events) is not signed.")
+#define STR_MACROS_DISABLED_CONTENT_UNSIGNED
NC_("STR_MACROS_DISABLED_CONTENT_UNSIGNED", "Macros are signed, but the
document (containing document events) is not signed.")
#define STR_MACROS NC_("STR_MACROS", "Show
Macros")
#define STR_EVENTS NC_("STR_EVENTS", "Show
Events")
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 1e4df24f60b9..f45075112606 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1331,7 +1331,7 @@ void SfxViewFrame::AppendContainsMacrosInfobar()
aResId = STR_CONTAINS_MACROS;
else if (pObjImpl->aMacroMode.hasUnsignedContentError())
aResId = STR_MACROS_DISABLED_CONTENT_UNSIGNED;
-auto pInfoBar = AppendInfoBar("macro",
SfxResId(RID_SECURITY_WARNING_TITLE),
+auto pInfoBar = AppendInfoBar("macro",
SfxResId(STR_MACROS_DISABLED_TITLE),
SfxResId(aResId), InfobarType::WARNING);
if (!pInfoBar)
return;
[Libreoffice-commits] core.git: 2 commits - framework/source stoc/source
framework/source/uiconfiguration/uicategorydescription.cxx | 10 +-
stoc/source/javaloader/javaloader.cxx |5 +++--
2 files changed, 8 insertions(+), 7 deletions(-)
New commits:
commit 58738b92255a2508d28c89088658fd21807e5826
Author: Noel Grandin
AuthorDate: Wed Feb 1 14:14:56 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 07:00:41 2023 +
osl::Mutex->std::mutex in JavaComponentLoader::getJavaLoader
Change-Id: Iecde82fcd1c637d4447b2bca491308a2becc38cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146467
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/stoc/source/javaloader/javaloader.cxx
b/stoc/source/javaloader/javaloader.cxx
index c8ad708ec676..b6d67a6bc923 100644
--- a/stoc/source/javaloader/javaloader.cxx
+++ b/stoc/source/javaloader/javaloader.cxx
@@ -67,6 +67,7 @@
// this one is header-only
#include
+#include
#include
#include
@@ -297,8 +298,8 @@ void JavaComponentLoader::disposing()
const css::uno::Reference &
JavaComponentLoader::getJavaLoader(OUString & rRemoteArg)
{
-static Mutex ourMutex;
-MutexGuard aGuard(ourMutex);
+static std::mutex ourMutex;
+std::unique_lock aGuard(ourMutex);
if (m_javaLoader.is())
return m_javaLoader;
commit 02950f16926564317cee90dffd8cda526bf096f2
Author: Noel Grandin
AuthorDate: Wed Feb 1 19:16:01 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 07:00:31 2023 +
osl::Mutex->std::mutex in ConfigurationAccess_UICategory
Change-Id: I55da051ad9368920224f2c762c9f95b3ea85098a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146472
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/uiconfiguration/uicategorydescription.cxx
b/framework/source/uiconfiguration/uicategorydescription.cxx
index 620384fadb14..8820a871fd27 100644
--- a/framework/source/uiconfiguration/uicategorydescription.cxx
+++ b/framework/source/uiconfiguration/uicategorydescription.cxx
@@ -47,7 +47,7 @@ namespace {
class ConfigurationAccess_UICategory : public
::cppu::WeakImplHelper
{
-osl::Mutex aMutex;
+std::mutex aMutex;
public:
ConfigurationAccess_UICategory(
std::u16string_view aModuleName, const Reference< XNameAccess >&
xGenericUICommands, const Reference< XComponentContext >& rxContext );
virtual ~ConfigurationAccess_UICategory() override;
@@ -112,7 +112,7 @@
ConfigurationAccess_UICategory::ConfigurationAccess_UICategory( std::u16string_v
ConfigurationAccess_UICategory::~ConfigurationAccess_UICategory()
{
// SAFE
-osl::MutexGuard g(aMutex);
+std::unique_lock g(aMutex);
Reference< XContainer > xContainer( m_xConfigAccess, UNO_QUERY );
if ( xContainer.is() )
xContainer->removeContainerListener(m_xConfigListener);
@@ -121,7 +121,7 @@
ConfigurationAccess_UICategory::~ConfigurationAccess_UICategory()
// XNameAccess
Any SAL_CALL ConfigurationAccess_UICategory::getByName( const OUString& rId )
{
-osl::MutexGuard g(aMutex);
+std::unique_lock g(aMutex);
if ( !m_bConfigAccessInitialized )
{
initializeConfigAccess();
@@ -242,7 +242,7 @@ Any ConfigurationAccess_UICategory::getUINameFromCache(
const OUString& rId )
Sequence< OUString > ConfigurationAccess_UICategory::getAllIds()
{
// SAFE
-osl::MutexGuard g(aMutex);
+std::unique_lock g(aMutex);
if ( !m_bConfigAccessInitialized )
{
@@ -332,7 +332,7 @@ void SAL_CALL ConfigurationAccess_UICategory::disposing(
const EventObject& aEve
{
// SAFE
// remove our reference to the config access
-osl::MutexGuard g(aMutex);
+std::unique_lock g(aMutex);
Reference< XInterface > xIfac1( aEvent.Source, UNO_QUERY );
Reference< XInterface > xIfac2( m_xConfigAccess, UNO_QUERY );
[Libreoffice-commits] core.git: 2 commits - configmgr/source
configmgr/source/readonlyaccess.cxx |8
configmgr/source/readwriteaccess.cxx |8
2 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 17523906a875f84e3c435127700bcd9ae932997b
Author: Noel Grandin
AuthorDate: Wed Feb 1 16:01:41 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 07:00:23 2023 +
osl::Mutex->std::mutex in configmgr::read_write_access::Service
Change-Id: Ic8f688d3ad66c1be33a147e05b0e9145593214f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146471
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/configmgr/source/readwriteaccess.cxx
b/configmgr/source/readwriteaccess.cxx
index 57e8b298a966..1e16cbb717a9 100644
--- a/configmgr/source/readwriteaccess.cxx
+++ b/configmgr/source/readwriteaccess.cxx
@@ -22,9 +22,9 @@
#include
#include
#include
-#include
#include
#include
+#include
#include
#include
@@ -98,7 +98,7 @@ private:
css::uno::Reference< css::uno::XComponentContext > context_;
-osl::Mutex mutex_;
+std::mutex mutex_;
rtl::Reference< RootAccess > root_;
};
@@ -110,7 +110,7 @@ void Service::initialize(css::uno::Sequence< css::uno::Any
> const & aArguments)
"not exactly one string argument",
static_cast< cppu::OWeakObject * >(this), -1);
}
-osl::MutexGuard g1(mutex_);
+std::unique_lock g1(mutex_);
if (root_.is()) {
throw css::uno::RuntimeException(
"already initialized", static_cast< cppu::OWeakObject * >(this));
@@ -122,7 +122,7 @@ void Service::initialize(css::uno::Sequence< css::uno::Any
> const & aArguments)
}
rtl::Reference< RootAccess > Service::getRoot() {
-osl::MutexGuard g(mutex_);
+std::unique_lock g(mutex_);
if (!root_.is()) {
throw css::lang::NotInitializedException(
"not initialized", static_cast< cppu::OWeakObject * >(this));
commit 90ff8cc432fd043ed662d478f7ace49438d00ff3
Author: Noel Grandin
AuthorDate: Wed Feb 1 16:00:35 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 07:00:14 2023 +
osl::Mutex->std::mutex in configmgr::read_only_access::Service
Change-Id: Ia92bb76cedb45d2c28482d34869e239cfdd32ebf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146470
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/configmgr/source/readonlyaccess.cxx
b/configmgr/source/readonlyaccess.cxx
index 76ec606d5bc4..71649bc08822 100644
--- a/configmgr/source/readonlyaccess.cxx
+++ b/configmgr/source/readonlyaccess.cxx
@@ -22,7 +22,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -31,6 +30,7 @@
#include "components.hxx"
#include "lock.hxx"
#include "rootaccess.hxx"
+#include
namespace configmgr::read_only_access {
@@ -76,7 +76,7 @@ private:
css::uno::Reference< css::uno::XComponentContext > context_;
-osl::Mutex mutex_;
+std::mutex mutex_;
rtl::Reference< RootAccess > root_;
};
@@ -88,7 +88,7 @@ void Service::initialize(css::uno::Sequence< css::uno::Any >
const & aArguments)
"not exactly one string argument",
static_cast< cppu::OWeakObject * >(this), -1);
}
-osl::MutexGuard g1(mutex_);
+std::unique_lock g1(mutex_);
if (root_.is()) {
throw css::uno::RuntimeException(
"already initialized", static_cast< cppu::OWeakObject * >(this));
@@ -100,7 +100,7 @@ void Service::initialize(css::uno::Sequence< css::uno::Any
> const & aArguments)
}
rtl::Reference< RootAccess > Service::getRoot() {
-osl::MutexGuard g(mutex_);
+std::unique_lock g(mutex_);
if (!root_.is()) {
throw css::lang::NotInitializedException(
"not initialized", static_cast< cppu::OWeakObject * >(this));
[Libreoffice-commits] core.git: sd/source
sd/source/ui/unoidl/randomnode.cxx | 71 +
1 file changed, 34 insertions(+), 37 deletions(-)
New commits:
commit 63b4126116ee0c92f8dbf2b54a2afacf8eed74cf
Author: Noel Grandin
AuthorDate: Wed Feb 1 14:19:21 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 06:59:51 2023 +
osl::Mutex->std::mutex in sd::RandomAnimationNode
Change-Id: Idebeff57bc5149a3b6ea43fdac0ccafe4a8597dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146468
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/source/ui/unoidl/randomnode.cxx
b/sd/source/ui/unoidl/randomnode.cxx
index a87ae1783721..08c0e9fda594 100644
--- a/sd/source/ui/unoidl/randomnode.cxx
+++ b/sd/source/ui/unoidl/randomnode.cxx
@@ -34,12 +34,9 @@
#include
#include
#include
-#include
#include
#include
-
-using ::osl::Mutex;
-using ::osl::Guard;
+#include
using ::com::sun::star::uno::Reference;
using ::com::sun::star::uno::Sequence;
@@ -139,7 +136,7 @@ public:
private:
// our first, last and only protection from multi-threads!
-Mutex maMutex;
+std::mutex maMutex;
sal_Int16 mnPresetClass;
WeakReference mxParent;
@@ -227,215 +224,215 @@ void SAL_CALL RandomAnimationNode::initialize( const
Sequence< Any >& aArguments
// XAnimationNode
sal_Int16 SAL_CALL RandomAnimationNode::getType()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return css::animations::AnimationNodeType::PAR;
}
// XAnimationNode
Any SAL_CALL RandomAnimationNode::getBegin()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return maBegin;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setBegin( const Any& _begin )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
maBegin = _begin;
}
// XAnimationNode
Any SAL_CALL RandomAnimationNode::getDuration()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return maDuration;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setDuration( const Any& _duration )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
maDuration = _duration;
}
// XAnimationNode
Any SAL_CALL RandomAnimationNode::getEnd()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return maEnd;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setEnd( const Any& _end )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
maEnd = _end;
}
// XAnimationNode
Any SAL_CALL RandomAnimationNode::getEndSync()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return maEndSync;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setEndSync( const Any& _endsync )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
maEndSync = _endsync;
}
// XAnimationNode
Any SAL_CALL RandomAnimationNode::getRepeatCount()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return maRepeatCount;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setRepeatCount( const Any& _repeatcount )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
maRepeatCount = _repeatcount;
}
// XAnimationNode
Any SAL_CALL RandomAnimationNode::getRepeatDuration()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return maRepeatDuration;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setRepeatDuration( const Any&
_repeatduration )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
maRepeatDuration = _repeatduration;
}
// XAnimationNode
sal_Int16 SAL_CALL RandomAnimationNode::getFill()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return mnFill;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setFill( sal_Int16 _fill )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
mnFill = _fill;
}
// XAnimationNode
sal_Int16 SAL_CALL RandomAnimationNode::getFillDefault()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return mnFillDefault;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setFillDefault( sal_Int16 _filldefault )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
mnFillDefault = _filldefault;
}
// XAnimationNode
sal_Int16 SAL_CALL RandomAnimationNode::getRestart()
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
return mnRestart;
}
// XAnimationNode
void SAL_CALL RandomAnimationNode::setRestart( sal_Int16 _restart )
{
-Guard< Mutex > aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
[Libreoffice-commits] core.git: bridges/source
bridges/source/jni_uno/jni_bridge.cxx|2 +-
bridges/source/jni_uno/jni_java2uno.cxx |2 +-
bridges/source/jni_uno/jniunoenvironmentdata.hxx |4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 5233bc74ea6c66795b5e5299e6ce554de877ef8a
Author: Noel Grandin
AuthorDate: Wed Feb 1 15:56:51 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 06:59:36 2023 +
osl::Mutex->std::mutex in JniUnoEnvironmentData
Change-Id: Iab6d430af7afc0d21e118b05d64a15664fc2f677
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146469
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/bridges/source/jni_uno/jni_bridge.cxx
b/bridges/source/jni_uno/jni_bridge.cxx
index be2e3d37ec12..5e09a8899690 100644
--- a/bridges/source/jni_uno/jni_bridge.cxx
+++ b/bridges/source/jni_uno/jni_bridge.cxx
@@ -428,7 +428,7 @@ static void java_env_dispose(uno_Environment * env) {
jobject async;
{
-osl::MutexGuard g(envData->mutex);
+std::unique_lock g(envData->mutex);
async = envData->asynchronousFinalizer;
envData->asynchronousFinalizer = nullptr;
}
diff --git a/bridges/source/jni_uno/jni_java2uno.cxx
b/bridges/source/jni_uno/jni_java2uno.cxx
index 5edb2b7b3453..53f761e82657 100644
--- a/bridges/source/jni_uno/jni_java2uno.cxx
+++ b/bridges/source/jni_uno/jni_java2uno.cxx
@@ -74,7 +74,7 @@ jobject Bridge::map_to_java(
auto * envData = static_cast(
m_java_env->pContext);
{
-osl::MutexGuard g(envData->mutex);
+std::unique_lock g(envData->mutex);
args2[ 7 ].l = envData->asynchronousFinalizer;
}
jo_iface = jni->CallStaticObjectMethodA(
diff --git a/bridges/source/jni_uno/jniunoenvironmentdata.hxx
b/bridges/source/jni_uno/jniunoenvironmentdata.hxx
index 39ffdeea6ece..d1f3bab4b12d 100644
--- a/bridges/source/jni_uno/jniunoenvironmentdata.hxx
+++ b/bridges/source/jni_uno/jniunoenvironmentdata.hxx
@@ -24,10 +24,10 @@
#include
#include
-#include
#include
#include "jni_info.h"
+#include
namespace jni_uno {
@@ -45,7 +45,7 @@ struct JniUnoEnvironmentData {
rtl::Reference const machine;
JNI_info const * const info;
-osl::Mutex mutex;
+std::mutex mutex;
jobject asynchronousFinalizer;
};
[Libreoffice-commits] core.git: framework/source
framework/source/uiconfiguration/windowstateconfiguration.cxx | 27 +-
1 file changed, 14 insertions(+), 13 deletions(-)
New commits:
commit e8d2a9ffc0d96418dbec94cdbba14aac1c09adf5
Author: Noel Grandin
AuthorDate: Wed Feb 1 19:18:45 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Feb 2 06:59:13 2023 +
osl::Mutex->std::mutex in ConfigurationAccess_WindowState
Change-Id: I399bb434da3e2c92c6df64dd6048121ad030bfb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146473
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/framework/source/uiconfiguration/windowstateconfiguration.cxx
b/framework/source/uiconfiguration/windowstateconfiguration.cxx
index eb7e72affabe..97a1402c9f2e 100644
--- a/framework/source/uiconfiguration/windowstateconfiguration.cxx
+++ b/framework/source/uiconfiguration/windowstateconfiguration.cxx
@@ -45,6 +45,7 @@
#include
#include
+#include
#include
#include
#include
@@ -203,7 +204,7 @@ class ConfigurationAccess_WindowState : public
::cppu::WeakImplHelper< XNameCon
typedef std::unordered_map< OUString,
WindowStateInfo > ResourceURLToInfoCache;
-osl::Mutexm_aMutex;
+std::mutexm_aMutex;
OUString m_aConfigWindowAccess;
Reference< XMultiServiceFactory > m_xConfigProvider;
Reference< XNameAccess > m_xConfigAccess;
@@ -230,7 +231,7 @@
ConfigurationAccess_WindowState::ConfigurationAccess_WindowState( std::u16string
ConfigurationAccess_WindowState::~ConfigurationAccess_WindowState()
{
// SAFE
-osl::MutexGuard g(m_aMutex);
+std::unique_lock g(m_aMutex);
Reference< XContainer > xContainer( m_xConfigAccess, UNO_QUERY );
if ( xContainer.is() )
xContainer->removeContainerListener(m_xConfigListener);
@@ -240,7 +241,7 @@
ConfigurationAccess_WindowState::~ConfigurationAccess_WindowState()
Any SAL_CALL ConfigurationAccess_WindowState::getByName( const OUString&
rResourceURL )
{
// SAFE
-osl::MutexGuard g(m_aMutex);
+std::unique_lock g(m_aMutex);
ResourceURLToInfoCache::const_iterator pIter =
m_aResourceURLToInfoCache.find( rResourceURL );
if ( pIter != m_aResourceURLToInfoCache.end() )
@@ -257,7 +258,7 @@ Any SAL_CALL ConfigurationAccess_WindowState::getByName(
const OUString& rResour
Sequence< OUString > SAL_CALL
ConfigurationAccess_WindowState::getElementNames()
{
// SAFE
-osl::MutexGuard g(m_aMutex);
+std::unique_lock g(m_aMutex);
if ( !m_bConfigAccessInitialized )
{
@@ -274,7 +275,7 @@ Sequence< OUString > SAL_CALL
ConfigurationAccess_WindowState::getElementNames()
sal_Bool SAL_CALL ConfigurationAccess_WindowState::hasByName( const OUString&
rResourceURL )
{
// SAFE
-osl::MutexGuard g(m_aMutex);
+std::unique_lock g(m_aMutex);
ResourceURLToInfoCache::const_iterator pIter =
m_aResourceURLToInfoCache.find( rResourceURL );
if ( pIter != m_aResourceURLToInfoCache.end() )
@@ -298,7 +299,7 @@ Type SAL_CALL
ConfigurationAccess_WindowState::getElementType()
sal_Bool SAL_CALL ConfigurationAccess_WindowState::hasElements()
{
// SAFE
-osl::MutexGuard g(m_aMutex);
+std::unique_lock g(m_aMutex);
if ( !m_bConfigAccessInitialized )
{
@@ -316,7 +317,7 @@ sal_Bool SAL_CALL
ConfigurationAccess_WindowState::hasElements()
void SAL_CALL ConfigurationAccess_WindowState::removeByName( const OUString&
rResourceURL )
{
// SAFE
-osl::ClearableMutexGuard g(m_aMutex);
+std::unique_lock g(m_aMutex);
ResourceURLToInfoCache::iterator pIter = m_aResourceURLToInfoCache.find(
rResourceURL );
if ( pIter != m_aResourceURLToInfoCache.end() )
@@ -334,7 +335,7 @@ void SAL_CALL
ConfigurationAccess_WindowState::removeByName( const OUString& rRe
Reference< XNameContainer > xNameContainer( m_xConfigAccess, UNO_QUERY
);
if ( xNameContainer.is() )
{
-g.clear();
+g.unlock();
xNameContainer->removeByName( rResourceURL );
Reference< XChangesBatch > xFlush( m_xConfigAccess, UNO_QUERY );
@@ -350,7 +351,7 @@ void SAL_CALL
ConfigurationAccess_WindowState::removeByName( const OUString& rRe
void SAL_CALL ConfigurationAccess_WindowState::insertByName( const OUString&
rResourceURL, const css::uno::Any& aPropertySet )
{
// SAFE
-osl::ClearableMutexGuard g(m_aMutex);
+std::unique_lock g(m_aMutex);
Sequence< PropertyValue > aPropSet;
if ( !(aPropertySet >>= aPropSet) )
@@ -383,7 +384,7 @@ void SAL_CALL
ConfigurationAccess_WindowState::insertByName( const OUString& rRe
return;
Reference< XSingleServiceFactory > xFactory( m_xConfigAccess, UNO_QUERY );
-g.clear();
+g.unlock();
try
{
@@ -408,7 +409,7 @@ void SAL_CALL
ConfigurationAccess_WindowState::insertByName( const OUString& rRe
void
[Libreoffice-bugs] [Bug 94074] If you select an image direct after caption was selected, imagerelated entries in contextmenu are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=94074 --- Comment #11 from Dieter --- Still present in Version: 7.5.0.2 (X86_64) / LibreOffice Community Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded Steps to Reproduce: 1. Open attachment 184581 2. Select the frame. 3. Select the image. 4. Right click on the image. 5. The frame context menu will be displayed. (see properties entry in context menu) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349 Dieter changed: What|Removed |Added Depends on||94074 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=94074 [Bug 94074] If you select an image direct after caption was selected, imagerelated entries in contextmenu are missing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80649] Frame context menu appears on picture when anchored as character, when context menu is started immediately after another picture was selected
https://bugs.documentfoundation.org/show_bug.cgi?id=80649 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||074 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94074] If you select an image direct after caption was selected, imagerelated entries in contextmenu are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=94074 Dieter changed: What|Removed |Added Blocks||86349 CC||dgp-m...@gmx.de Keywords|needsDevEval| See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=80 ||649 --- Comment #10 from Dieter --- At least related to bug 80649 (not a duplicate, bug is also present with an image anchored to character) Problem is, that context image context menu doesn't miss some entries. but it is the frame context menu. You can easily see, that it is frame context menu, if you select properties. Don't know, if we still need DevEval here, because it doesn't happen anything since 2015!!!. I remove it. Buovyaga, feel free to add it again, if you think it is necessary. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86349 [Bug 86349] [META] Context menu bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152 Bug 103152 depends on bug 152975, which changed state. Bug 152975 Summary: [UI/UX bug] Right-clicking on a selected image shows the frame's context menu when the frame was previously selected https://bugs.documentfoundation.org/show_bug.cgi?id=152975 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349 Bug 86349 depends on bug 152975, which changed state. Bug 152975 Summary: [UI/UX bug] Right-clicking on a selected image shows the frame's context menu when the frame was previously selected https://bugs.documentfoundation.org/show_bug.cgi?id=152975 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94074] If you select an image direct after caption was selected, imagerelated entries in contextmenu are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=94074 Dieter changed: What|Removed |Added CC||piotr.os...@gmail.com --- Comment #9 from Dieter --- *** Bug 152975 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152975] [UI/UX bug] Right-clicking on a selected image shows the frame's context menu when the frame was previously selected
https://bugs.documentfoundation.org/show_bug.cgi?id=152975 Dieter changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Dieter --- Looks like a duplicate of bug 94074 and at least related to bug 80649 (not a duplicate, bug is also present with an image anchored to character) *** This bug has been marked as a duplicate of bug 94074 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152975] [UI/UX bug] Right-clicking on a selected image shows the frame's context menu when the frame was previously selected
https://bugs.documentfoundation.org/show_bug.cgi?id=152975 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| Blocks||103152 --- Comment #6 from Dieter --- I confirm it with Version: 7.5.0.2 (X86_64) / LibreOffice Community Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded You can easily see, that it is frame context menu, if you select properties => frame dialog opens Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103152 [Bug 103152] [META] Writer image bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152 Dieter changed: What|Removed |Added Depends on||152975 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152975 [Bug 152975] [UI/UX bug] Right-clicking on a selected image shows the frame's context menu when the frame was previously selected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 35092] Inking functionality: Ink drawings / annotations with Stylus, Pen or Finger on Touchscreen or Tablet
https://bugs.documentfoundation.org/show_bug.cgi?id=35092 --- Comment #176 from jamesstone7575 --- https://www.newassignmenthelp.co.uk/resume-writing-services/;>Resume Writing Services from expert writers. Our team is extremely knowledgeable and skilled, and we can provide you authentic assignment writing services on schedule. Get writing help for all subjects that is quick, original, and flawless with a 100% guarantee. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 38844] Reduce XOR rendering (search RasterOp::Xor)
https://bugs.documentfoundation.org/show_bug.cgi?id=38844 dipamt1...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |dipamt1...@gmail.com |desktop.org | --- Comment #35 from dipamt1...@gmail.com --- I would like to work on this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153316] New: Libre calc auto add/convert tab space to SOH
https://bugs.documentfoundation.org/show_bug.cgi?id=153316 Bug ID: 153316 Summary: Libre calc auto add/convert tab space to SOH Product: LibreOffice Version: 7.4.5.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: a19...@gmail.com Created attachment 185056 --> https://bugs.documentfoundation.org/attachment.cgi?id=185056=edit Libre calc auto add/convert tab space to SOH I copy (ctrl + c) some VB code (with tab space in some line) EX: if isnull(ld_menu) or ld_menu = 0 then else select menu_name,menu_ename into :ls_menu_name,:ls_menu_en from sy_menus where menu_id = :ld_menu; if ls_menu_en <> '' then dw_100.object.st_100.text = ls_menu_name dw_100.object.st_101.text = ls_menu_en end if end if then open Libre cacl, dupble click a cell -> paste (ctrl +v). I copy that cell, paste to VB script editor, and the scipt cannot run. For check, i paste to Notepad++, and found some special charater (SOH) cause the problem. Please refer the picture. Please help me to check this. Thanks and best regards. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 5 commits - basctl/source chart2/source cui/source editeng/source filter/source include/basegfx include/editeng include/svx reportd
Rebased ref, commits from common ancestor:
commit 84133b2898d5d52a3c53c608432e12feff59dd6f
Author: Tomaž Vajngerl
AuthorDate: Wed Nov 23 11:00:13 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 2 12:25:29 2023 +0900
svx: convert SdrTextObj rotate and move to use gfx::Length
Change-Id: I82f10f82db8ac9d5653f4902276ee58fc18c52d6
diff --git a/include/basegfx/utils/RectangleWrapper.hxx
b/include/basegfx/utils/RectangleWrapper.hxx
index 00586d6eae71..4f5dbe851f66 100644
--- a/include/basegfx/utils/RectangleWrapper.hxx
+++ b/include/basegfx/utils/RectangleWrapper.hxx
@@ -55,6 +55,11 @@ public:
m_aRange.setSize(width, height);
}
+void shift(gfx::Length const& rXDelta, gfx::Length const& rYDelta)
+{
+m_aRange.shift(rXDelta, rYDelta);
+}
+
void move(sal_Int32 nXDelta, sal_Int32 nYDelta)
{
auto deltaX = gfx::Length::hmm(nXDelta);
diff --git a/svx/source/svdraw/svdotxtr.cxx b/svx/source/svdraw/svdotxtr.cxx
index 1055e5dbe3bb..9ccc69709abf 100644
--- a/svx/source/svdraw/svdotxtr.cxx
+++ b/svx/source/svdraw/svdotxtr.cxx
@@ -40,6 +40,35 @@
using namespace com::sun::star;
+namespace
+{
+gfx::Tuple2DL rotatePoint(gfx::Tuple2DL const& rPoint, gfx::Tuple2DL const&
rReference, double sinAngle, double cosAngle)
+{
+gfx::Length dx = rPoint.getX() - rReference.getX();
+gfx::Length dy = rPoint.getY() - rReference.getY();
+
+auto x = rReference.getX() + gfx::Length::emu(basegfx::fround(dx.raw() *
cosAngle + dy.raw() * sinAngle));
+auto y = rReference.getY() + gfx::Length::emu(basegfx::fround(dy.raw() *
cosAngle - dx.raw() * sinAngle));
+
+return gfx::Tuple2DL(x, y);
+}
+
+gfx::Tuple2DL toTuple(Point const& rPointHmm)
+{
+auto x = gfx::Length::hmm(rPointHmm.X());
+auto y = gfx::Length::hmm(rPointHmm.Y());
+return {x, y};
+}
+
+gfx::Size2DL toSize2D(Size const& rSizeHmm)
+{
+auto x = gfx::Length::hmm(rSizeHmm.Width());
+auto y = gfx::Length::hmm(rSizeHmm.Height());
+return {x, y};
+}
+
+} // end anonymous ns
+
void SdrTextObj::NbcSetSnapRect(const tools::Rectangle& rRect)
{
if (maGeo.nRotationAngle || maGeo.nShearAngle)
@@ -92,7 +121,9 @@ Degree100 SdrTextObj::GetShearAngle(bool /*bVertical*/) const
void SdrTextObj::NbcMove(const Size& rSize)
{
-moveRectangle(rSize.Width(), rSize.Height());
+gfx::Size2DL aSize2D = toSize2D(rSize);
+maRectangle.shift(aSize2D.getWidth(), aSize2D.getHeight());
+
moveOutRectangle(rSize.Width(), rSize.Height());
maSnapRect.Move(rSize);
SetBoundAndSnapRectsDirty(true);
@@ -183,27 +214,37 @@ void SdrTextObj::NbcResize(const Point& rRef, const
Fraction& xFact, const Fract
SetBoundAndSnapRectsDirty();
}
-void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double sn,
double cs)
+void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double
sinAngle, double cosAngle)
{
+auto aReference = toTuple(rRef);
+
SetGlueReallyAbsolute(true);
-tools::Long dx = getRectangle().Right() - getRectangle().Left();
-tools::Long dy = getRectangle().Bottom() - getRectangle().Top();
-Point aPoint1(getRectangle().TopLeft());
-RotatePoint(aPoint1, rRef, sn, cs);
-Point aPoint2(aPoint1.X() + dx, aPoint1.Y() + dy);
-tools::Rectangle aRectangle(aPoint1, aPoint2);
-setRectangle(aRectangle);
+auto const& rRange = maRectangle.getRange();
+
+auto nWidth = rRange.getWidth();
+auto nHeight = rRange.getHeight();
+
+gfx::Tuple2DL aPoint1(rRange.getMinX(), rRange.getMinY());
+aPoint1 = rotatePoint(aPoint1, aReference, sinAngle, cosAngle);
-if (maGeo.nRotationAngle==0_deg100) {
-maGeo.nRotationAngle=NormAngle36000(nAngle);
-maGeo.mfSinRotationAngle=sn;
-maGeo.mfCosRotationAngle=cs;
-} else {
-maGeo.nRotationAngle=NormAngle36000(maGeo.nRotationAngle+nAngle);
+gfx::Tuple2DL aPoint2(aPoint1.getX() + nWidth, aPoint1.getY() + nHeight);
+
+gfx::Range2DL aRange{aPoint1, aPoint2};
+maRectangle.setRange(aRange);
+
+if (maGeo.nRotationAngle == 0_deg100)
+{
+maGeo.nRotationAngle = NormAngle36000(nAngle);
+maGeo.mfSinRotationAngle = sinAngle;
+maGeo.mfCosRotationAngle = cosAngle;
+}
+else
+{
+maGeo.nRotationAngle = NormAngle36000(maGeo.nRotationAngle + nAngle);
maGeo.RecalcSinCos();
}
SetBoundAndSnapRectsDirty();
-NbcRotateGluePoints(rRef,nAngle,sn,cs);
+NbcRotateGluePoints(rRef, nAngle, sinAngle, cosAngle);
SetGlueReallyAbsolute(false);
}
commit db17dbdbd31694b7fa0eba3299248d54e7d21be3
Author: Tomaž Vajngerl
AuthorDate: Tue Nov 22 13:33:30 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 2 12:25:28 2023 +0900
svx: use RectangleWrapper for maRectangle on SdrTextObj
This is needed so we can now transition to use gfx::Length and
gfx::Range2DL to define the object position and size.
Change-Id:
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 7 commits - basctl/source basegfx/CppunitTest_basegfx.mk basegfx/test chart2/source cui/source editeng/source filter/source include
Rebased ref, commits from common ancestor:
commit 0463c3388aaec3e0fbed5f9236e5b02ac96d1db6
Author: Tomaž Vajngerl
AuthorDate: Wed Nov 23 11:00:13 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 2 12:23:58 2023 +0900
svx: convert SdrTextObj rotate and move to use gfx::Length
Change-Id: I82f10f82db8ac9d5653f4902276ee58fc18c52d6
diff --git a/include/basegfx/utils/RectangleWrapper.hxx
b/include/basegfx/utils/RectangleWrapper.hxx
index 00586d6eae71..4f5dbe851f66 100644
--- a/include/basegfx/utils/RectangleWrapper.hxx
+++ b/include/basegfx/utils/RectangleWrapper.hxx
@@ -55,6 +55,11 @@ public:
m_aRange.setSize(width, height);
}
+void shift(gfx::Length const& rXDelta, gfx::Length const& rYDelta)
+{
+m_aRange.shift(rXDelta, rYDelta);
+}
+
void move(sal_Int32 nXDelta, sal_Int32 nYDelta)
{
auto deltaX = gfx::Length::hmm(nXDelta);
diff --git a/svx/source/svdraw/svdotxtr.cxx b/svx/source/svdraw/svdotxtr.cxx
index 1055e5dbe3bb..9ccc69709abf 100644
--- a/svx/source/svdraw/svdotxtr.cxx
+++ b/svx/source/svdraw/svdotxtr.cxx
@@ -40,6 +40,35 @@
using namespace com::sun::star;
+namespace
+{
+gfx::Tuple2DL rotatePoint(gfx::Tuple2DL const& rPoint, gfx::Tuple2DL const&
rReference, double sinAngle, double cosAngle)
+{
+gfx::Length dx = rPoint.getX() - rReference.getX();
+gfx::Length dy = rPoint.getY() - rReference.getY();
+
+auto x = rReference.getX() + gfx::Length::emu(basegfx::fround(dx.raw() *
cosAngle + dy.raw() * sinAngle));
+auto y = rReference.getY() + gfx::Length::emu(basegfx::fround(dy.raw() *
cosAngle - dx.raw() * sinAngle));
+
+return gfx::Tuple2DL(x, y);
+}
+
+gfx::Tuple2DL toTuple(Point const& rPointHmm)
+{
+auto x = gfx::Length::hmm(rPointHmm.X());
+auto y = gfx::Length::hmm(rPointHmm.Y());
+return {x, y};
+}
+
+gfx::Size2DL toSize2D(Size const& rSizeHmm)
+{
+auto x = gfx::Length::hmm(rSizeHmm.Width());
+auto y = gfx::Length::hmm(rSizeHmm.Height());
+return {x, y};
+}
+
+} // end anonymous ns
+
void SdrTextObj::NbcSetSnapRect(const tools::Rectangle& rRect)
{
if (maGeo.nRotationAngle || maGeo.nShearAngle)
@@ -92,7 +121,9 @@ Degree100 SdrTextObj::GetShearAngle(bool /*bVertical*/) const
void SdrTextObj::NbcMove(const Size& rSize)
{
-moveRectangle(rSize.Width(), rSize.Height());
+gfx::Size2DL aSize2D = toSize2D(rSize);
+maRectangle.shift(aSize2D.getWidth(), aSize2D.getHeight());
+
moveOutRectangle(rSize.Width(), rSize.Height());
maSnapRect.Move(rSize);
SetBoundAndSnapRectsDirty(true);
@@ -183,27 +214,37 @@ void SdrTextObj::NbcResize(const Point& rRef, const
Fraction& xFact, const Fract
SetBoundAndSnapRectsDirty();
}
-void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double sn,
double cs)
+void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double
sinAngle, double cosAngle)
{
+auto aReference = toTuple(rRef);
+
SetGlueReallyAbsolute(true);
-tools::Long dx = getRectangle().Right() - getRectangle().Left();
-tools::Long dy = getRectangle().Bottom() - getRectangle().Top();
-Point aPoint1(getRectangle().TopLeft());
-RotatePoint(aPoint1, rRef, sn, cs);
-Point aPoint2(aPoint1.X() + dx, aPoint1.Y() + dy);
-tools::Rectangle aRectangle(aPoint1, aPoint2);
-setRectangle(aRectangle);
+auto const& rRange = maRectangle.getRange();
+
+auto nWidth = rRange.getWidth();
+auto nHeight = rRange.getHeight();
+
+gfx::Tuple2DL aPoint1(rRange.getMinX(), rRange.getMinY());
+aPoint1 = rotatePoint(aPoint1, aReference, sinAngle, cosAngle);
-if (maGeo.nRotationAngle==0_deg100) {
-maGeo.nRotationAngle=NormAngle36000(nAngle);
-maGeo.mfSinRotationAngle=sn;
-maGeo.mfCosRotationAngle=cs;
-} else {
-maGeo.nRotationAngle=NormAngle36000(maGeo.nRotationAngle+nAngle);
+gfx::Tuple2DL aPoint2(aPoint1.getX() + nWidth, aPoint1.getY() + nHeight);
+
+gfx::Range2DL aRange{aPoint1, aPoint2};
+maRectangle.setRange(aRange);
+
+if (maGeo.nRotationAngle == 0_deg100)
+{
+maGeo.nRotationAngle = NormAngle36000(nAngle);
+maGeo.mfSinRotationAngle = sinAngle;
+maGeo.mfCosRotationAngle = cosAngle;
+}
+else
+{
+maGeo.nRotationAngle = NormAngle36000(maGeo.nRotationAngle + nAngle);
maGeo.RecalcSinCos();
}
SetBoundAndSnapRectsDirty();
-NbcRotateGluePoints(rRef,nAngle,sn,cs);
+NbcRotateGluePoints(rRef, nAngle, sinAngle, cosAngle);
SetGlueReallyAbsolute(false);
}
commit 42e2325b52ebedb7628ae69736eeb1e830b9ec22
Author: Tomaž Vajngerl
AuthorDate: Tue Nov 22 13:33:30 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 2 12:23:58 2023 +0900
svx: use RectangleWrapper for maRectangle on SdrTextObj
This is needed so we can now transition to use gfx::Length and
gfx::Range2DL to define the object position and size.
Change-Id:
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 10 commits - basctl/source basegfx/CppunitTest_basegfx.mk basegfx/test chart2/source cui/source editeng/source filter/source includ
Rebased ref, commits from common ancestor:
commit 53379f9ebb623ebf392f28a1cd68a34aaee12cf1
Author: Tomaž Vajngerl
AuthorDate: Wed Nov 23 11:00:13 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 2 12:16:54 2023 +0900
svx: convert SdrTextObj rotate and move to use gfx::Length
Change-Id: I82f10f82db8ac9d5653f4902276ee58fc18c52d6
diff --git a/include/basegfx/utils/RectangleWrapper.hxx
b/include/basegfx/utils/RectangleWrapper.hxx
index 00586d6eae71..4f5dbe851f66 100644
--- a/include/basegfx/utils/RectangleWrapper.hxx
+++ b/include/basegfx/utils/RectangleWrapper.hxx
@@ -55,6 +55,11 @@ public:
m_aRange.setSize(width, height);
}
+void shift(gfx::Length const& rXDelta, gfx::Length const& rYDelta)
+{
+m_aRange.shift(rXDelta, rYDelta);
+}
+
void move(sal_Int32 nXDelta, sal_Int32 nYDelta)
{
auto deltaX = gfx::Length::hmm(nXDelta);
diff --git a/svx/source/svdraw/svdotxtr.cxx b/svx/source/svdraw/svdotxtr.cxx
index 1055e5dbe3bb..9ccc69709abf 100644
--- a/svx/source/svdraw/svdotxtr.cxx
+++ b/svx/source/svdraw/svdotxtr.cxx
@@ -40,6 +40,35 @@
using namespace com::sun::star;
+namespace
+{
+gfx::Tuple2DL rotatePoint(gfx::Tuple2DL const& rPoint, gfx::Tuple2DL const&
rReference, double sinAngle, double cosAngle)
+{
+gfx::Length dx = rPoint.getX() - rReference.getX();
+gfx::Length dy = rPoint.getY() - rReference.getY();
+
+auto x = rReference.getX() + gfx::Length::emu(basegfx::fround(dx.raw() *
cosAngle + dy.raw() * sinAngle));
+auto y = rReference.getY() + gfx::Length::emu(basegfx::fround(dy.raw() *
cosAngle - dx.raw() * sinAngle));
+
+return gfx::Tuple2DL(x, y);
+}
+
+gfx::Tuple2DL toTuple(Point const& rPointHmm)
+{
+auto x = gfx::Length::hmm(rPointHmm.X());
+auto y = gfx::Length::hmm(rPointHmm.Y());
+return {x, y};
+}
+
+gfx::Size2DL toSize2D(Size const& rSizeHmm)
+{
+auto x = gfx::Length::hmm(rSizeHmm.Width());
+auto y = gfx::Length::hmm(rSizeHmm.Height());
+return {x, y};
+}
+
+} // end anonymous ns
+
void SdrTextObj::NbcSetSnapRect(const tools::Rectangle& rRect)
{
if (maGeo.nRotationAngle || maGeo.nShearAngle)
@@ -92,7 +121,9 @@ Degree100 SdrTextObj::GetShearAngle(bool /*bVertical*/) const
void SdrTextObj::NbcMove(const Size& rSize)
{
-moveRectangle(rSize.Width(), rSize.Height());
+gfx::Size2DL aSize2D = toSize2D(rSize);
+maRectangle.shift(aSize2D.getWidth(), aSize2D.getHeight());
+
moveOutRectangle(rSize.Width(), rSize.Height());
maSnapRect.Move(rSize);
SetBoundAndSnapRectsDirty(true);
@@ -183,27 +214,37 @@ void SdrTextObj::NbcResize(const Point& rRef, const
Fraction& xFact, const Fract
SetBoundAndSnapRectsDirty();
}
-void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double sn,
double cs)
+void SdrTextObj::NbcRotate(const Point& rRef, Degree100 nAngle, double
sinAngle, double cosAngle)
{
+auto aReference = toTuple(rRef);
+
SetGlueReallyAbsolute(true);
-tools::Long dx = getRectangle().Right() - getRectangle().Left();
-tools::Long dy = getRectangle().Bottom() - getRectangle().Top();
-Point aPoint1(getRectangle().TopLeft());
-RotatePoint(aPoint1, rRef, sn, cs);
-Point aPoint2(aPoint1.X() + dx, aPoint1.Y() + dy);
-tools::Rectangle aRectangle(aPoint1, aPoint2);
-setRectangle(aRectangle);
+auto const& rRange = maRectangle.getRange();
+
+auto nWidth = rRange.getWidth();
+auto nHeight = rRange.getHeight();
+
+gfx::Tuple2DL aPoint1(rRange.getMinX(), rRange.getMinY());
+aPoint1 = rotatePoint(aPoint1, aReference, sinAngle, cosAngle);
-if (maGeo.nRotationAngle==0_deg100) {
-maGeo.nRotationAngle=NormAngle36000(nAngle);
-maGeo.mfSinRotationAngle=sn;
-maGeo.mfCosRotationAngle=cs;
-} else {
-maGeo.nRotationAngle=NormAngle36000(maGeo.nRotationAngle+nAngle);
+gfx::Tuple2DL aPoint2(aPoint1.getX() + nWidth, aPoint1.getY() + nHeight);
+
+gfx::Range2DL aRange{aPoint1, aPoint2};
+maRectangle.setRange(aRange);
+
+if (maGeo.nRotationAngle == 0_deg100)
+{
+maGeo.nRotationAngle = NormAngle36000(nAngle);
+maGeo.mfSinRotationAngle = sinAngle;
+maGeo.mfCosRotationAngle = cosAngle;
+}
+else
+{
+maGeo.nRotationAngle = NormAngle36000(maGeo.nRotationAngle + nAngle);
maGeo.RecalcSinCos();
}
SetBoundAndSnapRectsDirty();
-NbcRotateGluePoints(rRef,nAngle,sn,cs);
+NbcRotateGluePoints(rRef, nAngle, sinAngle, cosAngle);
SetGlueReallyAbsolute(false);
}
commit 6a9e8346b727a130d12ca6609c4c6deae5b7149a
Author: Tomaž Vajngerl
AuthorDate: Tue Nov 22 13:33:30 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Feb 2 12:16:54 2023 +0900
svx: use RectangleWrapper for maRectangle on SdrTextObj
This is needed so we can now transition to use gfx::Length and
gfx::Range2DL to define the object position and size.
Change-Id:
[Libreoffice-bugs] [Bug 152801] Input text for a formatted text box shows up as light gray instead of black.
https://bugs.documentfoundation.org/show_bug.cgi?id=152801 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148178] SVG Export from macro in old version of SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148178 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99559] If table has bad header (made in MS Word) LO Writer doesn't show the first row of data.
https://bugs.documentfoundation.org/show_bug.cgi?id=99559 --- Comment #13 from QA Administrators --- Dear inforbano, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152975] [UI/UX bug] Right-clicking on a selected image shows the frame's context menu when the frame was previously selected
https://bugs.documentfoundation.org/show_bug.cgi?id=152975 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90026] OLE Object Toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=90026 --- Comment #7 from QA Administrators --- Dear Xavier Verne, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45721] Removing horizontal rule inserted by AutoCorrect (paragraph border) is unintuitive
https://bugs.documentfoundation.org/show_bug.cgi?id=45721 --- Comment #20 from QA Administrators --- Dear Dotan Cohen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140069] View -> User Interface, not available in Master Document (Writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=140069 --- Comment #2 from QA Administrators --- Dear drei, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134201] Crash after pasting several times, then undoing those, then redoing
https://bugs.documentfoundation.org/show_bug.cgi?id=134201 --- Comment #13 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108777] Undo doesnt work after setting 'Resize shape to fit text'
https://bugs.documentfoundation.org/show_bug.cgi?id=108777 --- Comment #10 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103593] can not drag table border to resize table in writer text table
https://bugs.documentfoundation.org/show_bug.cgi?id=103593 --- Comment #9 from QA Administrators --- Dear baigali, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103581] RTL tables inside RTL two-column sections partly disappear and run over the section
https://bugs.documentfoundation.org/show_bug.cgi?id=103581 --- Comment #9 from QA Administrators --- Dear antanins, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101019] Table - changing column width in a table with merged cells is effective only in one row
https://bugs.documentfoundation.org/show_bug.cgi?id=101019 --- Comment #12 from QA Administrators --- Dear Heinrich Hartl, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153315] EDITING - Crash after changing font size in style causing reformatting the document
https://bugs.documentfoundation.org/show_bug.cgi?id=153315 Yves Poissant changed: What|Removed |Added Crash report or||d8608389-1417-4856-87e0-a5d crash signature||3cb87ba39 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142209] FILE SAVE:CALC: EXCEL compatibility issue for xlsx files containing checkboxes
https://bugs.documentfoundation.org/show_bug.cgi?id=142209 Aron Budea changed: What|Removed |Added Whiteboard||target:7.3.0 CC||aron.bu...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108256] EDITING: find/replace regular expressions: \n has 2 meanings, it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=108256 V Stuart Foote changed: What|Removed |Added CC||villapal...@yahoo.it --- Comment #14 from V Stuart Foote --- *** Bug 153311 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153311] ¶ copy-past/search LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=153311 V Stuart Foote changed: What|Removed |Added Resolution|--- |DUPLICATE CC||vsfo...@libreoffice.org Status|UNCONFIRMED |RESOLVED --- Comment #3 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 108256 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153315] EDITING - Crash after changing font size in style causing reformatting the document
https://bugs.documentfoundation.org/show_bug.cgi?id=153315 --- Comment #2 from Yves Poissant --- Oups! I see that I interverted "Actual Result" with "Expected result". Sorry -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153315] EDITING - Crash after changing font size in style causing reformatting the document
https://bugs.documentfoundation.org/show_bug.cgi?id=153315 Yves Poissant changed: What|Removed |Added CC||ypoissa...@videotron.ca --- Comment #1 from Yves Poissant --- Created attachment 185055 --> https://bugs.documentfoundation.org/attachment.cgi?id=185055=edit The Writer document that crashes This is a reproduction of a book of 1200 pages approx. The document is not completed due to the crashing bug. In addition to the crash, there are several issues with formatting the text where there are footnotes. I shall report those issues once the crash is fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153314] 'Sentence case' issue in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=153314 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #1 from V Stuart Foote --- I can not explain why, but the pasted text: sentence case. tHis IS thE FIRst sENTenCE. thIs iS ThE sEConD seNTEncE. Is not handled as a Paragraph. And the sentences--selectable with a "triple mouse click" extends to the entire Paragraph (as opposed to the "4 mouse click" paragraph selection). But if I type the same sentences, they are correctly selected: word, sentence, paragraph. Likewise applying Sentence case from Format -> Text -> Sentence works. As does the "Cycle case". Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d8e6b488ceaff7c88856ebcfcfec14d2d8cd7652 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153315] New: EDITING - Crash after changing font size in style causing reformatting the document
https://bugs.documentfoundation.org/show_bug.cgi?id=153315 Bug ID: 153315 Summary: EDITING - Crash after changing font size in style causing reformatting the document Product: LibreOffice Version: 7.4.5.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ypoissa...@videotron.ca Description: After I change the "Default Paragraph Style" Font size from 9.5pt to 9.8pt Writer crashes. Steps to Reproduce: 1. Make sure the "Linux LIbertine G" font is installed. 2. Open the attached "JAS - HEA - Linux Libertine.odt" document. 3. In the Paragraph Style explorer, right click "Default Paragraph Style" -> "Modify" -> Font" -> Change "Size" from 9.5 to 9.8, select "OK. After the text is being reformatted for a while, Writer crashes. Actual Results: Expected the whole text being cleanly reformatted. Expected Results: Writer doesn't complete the reformating process and crashes instead. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.4.5.1 (x64) / LibreOffice Community Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: fr-CA (en_US); UI: en-US Calc: CL I've been having these crash issues for a while. I just found the easy reproduction steps described above. From my observations, I expect the crash is related to reformatting the footnotes. The crash also happen after resetting the user profile and while running in safe mode. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153272] Writer Macro Find with certain Search Attributes performs Replacement.
https://bugs.documentfoundation.org/show_bug.cgi?id=153272 --- Comment #4 from Don --- (In reply to Commit Notification from comment #3) > Julien Nabet committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/ > 2d9570523b16dd157384040642e3c2e0ed05 > > tdf#153272: add some missing properties in SwSearchProperties > > It will be available in 7.6.0. > > The patch should be included in the daily builds available at > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > https://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback. Pardon me if this is not how I should report feedback, but in looking at the committed patch I do not see mention of the hyphenation and orphan/Widow settings listed, is this a separate issue? Or was my comment #2 not submitted in time? Thank you, Don -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148178] SVG Export from macro in old version of SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=148178 --- Comment #3 from AndyG --- I'm using LibreOffice 7.4.4.2 (x64) on Windows 11 (and sometimes on OpenSUSE Leap 15.4). It is indeed the old version (1.1 instead of 1.2) of SVG when exported from a macro: http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd;> http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink; stroke-width="28.222" stroke-linejoin="round" xml:space="preserve"> The rest of the file is also quite different than when exported manually. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153314] New: 'Sentence case' issue in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=153314 Bug ID: 153314 Summary: 'Sentence case' issue in Writer Product: LibreOffice Version: 7.3.7.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: andrew...@hotmail.com Description: 'Sentence case' feature doesn't capitalise after a full stop. It works after a ! or ? Steps to Reproduce: Steps 1. Type "sentence case. tHis IS thE FIRst sENTenCE. thIs iS ThE sEConD seNTEncE." 2. Apply Format/Text/Sentence case from the menu Actual Results: Actual result: "Sentence case. this is the first sentence. this is the second sentence." Expected Results: Expected result: "Sentence case. This is the first sentence. This is the second sentence." Reproducible: Always User Profile Reset: No Additional Info: It works after a ! or ? Type: "sentence case! tHis IS thE FIRst sENTenCE? thIs iS ThE sEConD seNTEncE?" Result: "Sentence case! This is the first sentence? This is the second sentence?" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133999] [META] XLSX (OOXML) Form Controls related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=133999 --- Comment #1 from Gabor Kelemen (allotropia) --- Some good example documents for future bug hunting are: attachment 127852 from bug 103048 attachment 127728 from bug 100374 attachment 156990 from bug 129861 attachment 165013 from bug 136397 attachment 173557 from bug 143328 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104309] Scrollbar or Spin Button form element is lost entirely when saving as xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=104309 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3328 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143328] FILESAVE: All 3 form controls disappear on reopen in LO, incorrect in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=143328 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||4309 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133999] [META] XLSX (OOXML) Form Controls related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=133999 Bug 133999 depends on bug 103048, which changed state. Bug 103048 Summary: FILEOPEN: XLSX with Form controls doesn't work in LO https://bugs.documentfoundation.org/show_bug.cgi?id=103048 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107742] [META] Form control bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107742 Bug 107742 depends on bug 103048, which changed state. Bug 103048 Summary: FILEOPEN: XLSX with Form controls doesn't work in LO https://bugs.documentfoundation.org/show_bug.cgi?id=103048 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103048] FILEOPEN: XLSX with Form controls doesn't work in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=103048 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #14 from Gabor Kelemen (allotropia) --- Sooo... after some time, a bit of review of issues reported: "No value appears in C14." -> this is the same issue as bug 100374 "In the hidden C10 cell a value should appear, in Excel this is an integer number, in Calc a date." -> also the same as bug 100374 Button texts no longer lose accented characters (comment #5) -> WFM, probably = bug 60673 Linked cell info disappears from the option button (comment #6) -> WFM The $ marks disappeared from linked cell info of the List Box (comment #7) -> yes, but this does not seem to be important. All in all, I don't think there is much point to keep this open in the current form. I can split out individual bugs for still remaining independent issues (which are definitely there, save as xlsx still wrecks this document :) ). *** This bug has been marked as a duplicate of bug 100374 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100374] FILEOPEN: XLSX - Form imported with wrong setting for a list box
https://bugs.documentfoundation.org/show_bug.cgi?id=100374 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #6 from Gabor Kelemen (allotropia) --- *** Bug 103048 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/view/lokhelper.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit b2bd60b8c1937502857e12b0eea42323fd2353c8
Author: Aron Budea
AuthorDate: Thu Jan 26 03:31:24 2023 +0100
Commit: Aron Budea
CommitDate: Wed Feb 1 23:04:06 2023 +
sfx2: fix crash in SfxLokHelper::notifyAllViews(...)
Crashreport signature:
program/libmergedlo.so
SfxLokHelper::notifyAllViews(int, rtl::OString const&)
sfx2/source/view/lokhelper.cxx:682
program/libmergedlo.so
SfxClipboardChangeListener::ChangedContents()
include/rtl/string.hxx:413
program/libmergedlo.so
SfxClipboardChangeListener::LinkStubAsyncExecuteHdl_Impl(void*,
void*)
include/rtl/ref.hxx:128
program/libmergedlo.so
ImplWindowFrameProc(vcl::Window*, SalEvent, void const*)
include/rtl/ref.hxx:128
program/libmergedlo.so
SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent)
Change-Id: Ibf70f42292d67a3d6cc68f579ee02f671da85acb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146150
Reviewed-by: Miklos Vajna
Tested-by: Jenkins CollaboraOffice
(cherry picked from commit dc17158c99c8a15fbca57a9a0b0ea7178dcc5a34)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146400
Tested-by: Jenkins
Reviewed-by: Aron Budea
diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index 53c2abace8b5..29f64adbb74b 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -676,6 +676,8 @@ void SfxLokHelper::notifyAllViews(int nType, const OString&
rPayload)
const auto payload = rPayload.getStr();
const SfxViewShell* const pCurrentViewShell = SfxViewShell::Current();
+if (!pCurrentViewShell)
+return;
SfxViewShell* pViewShell = SfxViewShell::GetFirst();
while (pViewShell)
{
Re: New Defects reported by Coverity Scan for LibreOffice
On 01.02.2023 02:31, Stephan Bergmann wrote: On 01/02/2023 02:37, Kohei Yoshida wrote: I just borrowed your solution and called it "resolved", though I believe, even without that explicit try catch block, it would just terminate all the same? Yes. But without the explicit try catch block it would help compiler runtimes report the place where the (effectively uncaught, and presumably "this can't happen"-style unexpected) exception was actually thrown. I'm not convinced Coverity Scan is doing us a service here, overall. Gotcha. Thinking about this a bit, maybe it's better not to have that explicit try catch block I just added. Let me know what you all think. Kohei
[Libreoffice-bugs] [Bug 133999] [META] XLSX (OOXML) Form Controls related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=133999 Bug 133999 depends on bug 129861, which changed state. Bug 129861 Summary: Drop down menu not working correctly in LibreOffice. https://bugs.documentfoundation.org/show_bug.cgi?id=129861 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100374] FILEOPEN: XLSX - Form imported with wrong setting for a list box
https://bugs.documentfoundation.org/show_bug.cgi?id=100374 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||dgbat...@gmail.com --- Comment #5 from Gabor Kelemen (allotropia) --- *** Bug 129861 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129861] Drop down menu not working correctly in LibreOffice.
https://bugs.documentfoundation.org/show_bug.cgi?id=129861 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Gabor Kelemen (allotropia) --- This is the same import problem as bug 100374: the List boxes Properties -> Data -> Contents of the linked cell setting is "The selected entry" but it should be "Position of the selected entry". Manually changing this setting fixes the problem. *** This bug has been marked as a duplicate of bug 100374 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 127215, which changed state. Bug 127215 Summary: If saving a file.with.dots, ".odt" is not appended, so Export to PDF results in file.with.PDF instead of file.with.dots.PDF (KDE or OpenSuse?) https://bugs.documentfoundation.org/show_bug.cgi?id=127215 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127215] If saving a file.with.dots, ".odt" is not appended, so Export to PDF results in file.with.PDF instead of file.with.dots.PDF (KDE or OpenSuse?)
https://bugs.documentfoundation.org/show_bug.cgi?id=127215 gorgonz changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #15 from gorgonz --- No, is not an issue anymore. Tested with Version: 7.3.6.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded and works as expected. Nice job, well done :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133999] [META] XLSX (OOXML) Form Controls related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=133999 Bug 133999 depends on bug 142209, which changed state. Bug 142209 Summary: FILE SAVE:CALC: EXCEL compatibility issue for xlsx files containing checkboxes https://bugs.documentfoundation.org/show_bug.cgi?id=142209 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142209] FILE SAVE:CALC: EXCEL compatibility issue for xlsx files containing checkboxes
https://bugs.documentfoundation.org/show_bug.cgi?id=142209 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com, ||vmik...@collabora.com Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from Gabor Kelemen (allotropia) --- Thanks Miklos for fixing this! (Don't worry about the highlighted Cell link on the image, that was lost in 7.3 but got fixed in master) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142209] FILE SAVE:CALC: EXCEL compatibility issue for xlsx files containing checkboxes
https://bugs.documentfoundation.org/show_bug.cgi?id=142209 --- Comment #8 from Gabor Kelemen (allotropia) --- Created attachment 185054 --> https://bugs.documentfoundation.org/attachment.cgi?id=185054=edit The example file exported with 7.3 in Excel 2016 This got better in 7.3 with: https://git.libreoffice.org/core/+/94678a7b9c6b7e577c15adacc885e03551bcf17b author Miklos Vajna Wed Jun 30 16:22:42 2021 +0200 committer Miklos Vajna Wed Jun 30 20:33:39 2021 +0200 XLSX export: improve handling of checkbox (form controls) Now the second checkbox is also exported and visible in Excel 2010/13/16. (and became visible in Calc as well recently, see: https://bugs.documentfoundation.org/show_bug.cgi?id=143328#c9) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142432] [DOCX] Arc is rendered as Pie, rotation is incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=142432 --- Comment #11 from Alvaro Segura --- Created attachment 185053 --> https://bugs.documentfoundation.org/attachment.cgi?id=185053=edit Arcs with arrows LO 7.4.5 vs Word The bug is still in LO 7.4.5. This attachment shows arcs with modified start and end angles (I use that often to represent angles, as in the picture) and with an arrow end. Notice the "pie" lines that go to the arc center have an arrow in one of the segments. The "camera" object also appears rotated 90 deg extra in LO, but that is a different issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Feb-01
Present: Hossein, John, Eyal, Heiko Comments: Mike, Stuart, Regina, Stéphane Tickets/Topics * Wrong cursor position when deleting a selection in Show Changes mode + https://bugs.documentfoundation.org/show_bug.cgi?id=109272 + similar bug 137972 "Correcting with spell checker context menu places cursor at the left (previously right)" and (duplicate) bug 149854 "Track Changes: replace of the first letter of a word is not consistent; new character at the left or right of deleted one depending on how" + behavior is different for selection and includes the paragraph break (Hossein) + https://en.wikipedia.org/wiki/Triple-click + Feature request -> triple click + https://bugs.documentfoundation.org/show_bug.cgi?id=98694 + how many people care (John) - a couple, see duplicate + jumping to the end of the selection after deletion if track changes is enabled is beneficial (John) + it's a pity to abstain from the straight-forward implementation we have (Heiko) => do it * Backup copies of all files are saved to a single folder + https://bugs.documentfoundation.org/show_bug.cgi?id=150148 + add option to overwrite the default path to save with the document source (Mike) + saving documents from different modules always ends up in *.bak files + MSO does not allow files from different applications having the same name like test.xlsx and test.docx (Hossein, John) + add checkbox under Load/Save > General underneath and indented to Always create backup copies "[ ] Overwirte backup path and use document folder" + not overwriting by adding or /date/random number would be an alternative and is used by MSO (Hossein) + MSO saves for example C:\Users\\appdata\roaming\microsoft\... Test((310124753096842400)).asd + see also https://www.ubackup.com/backup-restore/backup-word-documents.html + it is a nightmare to align these documents with the origin (Heiko) + using the document folder is common; would make this the default and drop the backup folder (Eyal) + alternatively using subfolders might be a solution (Eyal) + yet another alternative is to hold the path of the original file as a property of the backup copy; not very friendly for manual inspection by users, but precludes the need for complex mapping/decoding of weird extensions and codes (Eyal) => comment on ticket * Change label "Separator" to "Before Caption" and "Numbering separator" to "After numbering" in Caption dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=153242 + agree with the need to change (Stéphane) + would prefer better documentation (Heiko) + "Numbering separator" is unclear + dont like the suggestion as both are "before the caption", changing the label is welcome however (Eyal) + MSO requests manual input of caption separator (:) and provides "use separator" with a set of single characters for chapters (Hossein) + unclear how it works (Eyal) => comment on the ticket * Please provide a user preference to disable inheriting the system UI theme + https://bugs.documentfoundation.org/show_bug.cgi?id=153229 + dark mode works now (Stuart), themes may help (Regina) + Use [( ) Dark ( ) Light ( ) System] options instead of multiple options (Hossein) + It is possible to use dark mode per application in different platforms with platform specific settings. We can use them in LibreOffice. (Hossein) $ GTK_THEME=Adwaita:dark soffice https://unix.stackexchange.com/a/185115 + prefer the addition of system colors to application colors together with the ability to use gradients and bitmaps and have some kind of "libreoffice theme" that could also be shared via extension (Heiko) + majority of users would be happy with a switch for bright/dark (system) colors (softmaker/onlyoffice does it very well); and many user wont find/search for the supposed extensions (John, Eyal) => comment on ticket OpenPGP_signature Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Feb-01
Present: Hossein, John, Eyal, Heiko Comments: Mike, Stuart, Regina, Stéphane Tickets/Topics * Wrong cursor position when deleting a selection in Show Changes mode + https://bugs.documentfoundation.org/show_bug.cgi?id=109272 + similar bug 137972 "Correcting with spell checker context menu places cursor at the left (previously right)" and (duplicate) bug 149854 "Track Changes: replace of the first letter of a word is not consistent; new character at the left or right of deleted one depending on how" + behavior is different for selection and includes the paragraph break (Hossein) + https://en.wikipedia.org/wiki/Triple-click + Feature request -> triple click + https://bugs.documentfoundation.org/show_bug.cgi?id=98694 + how many people care (John) - a couple, see duplicate + jumping to the end of the selection after deletion if track changes is enabled is beneficial (John) + it's a pity to abstain from the straight-forward implementation we have (Heiko) => do it * Backup copies of all files are saved to a single folder + https://bugs.documentfoundation.org/show_bug.cgi?id=150148 + add option to overwrite the default path to save with the document source (Mike) + saving documents from different modules always ends up in *.bak files + MSO does not allow files from different applications having the same name like test.xlsx and test.docx (Hossein, John) + add checkbox under Load/Save > General underneath and indented to Always create backup copies "[ ] Overwirte backup path and use document folder" + not overwriting by adding or /date/random number would be an alternative and is used by MSO (Hossein) + MSO saves for example C:\Users\\appdata\roaming\microsoft\... Test((310124753096842400)).asd + see also https://www.ubackup.com/backup-restore/backup-word-documents.html + it is a nightmare to align these documents with the origin (Heiko) + using the document folder is common; would make this the default and drop the backup folder (Eyal) + alternatively using subfolders might be a solution (Eyal) + yet another alternative is to hold the path of the original file as a property of the backup copy; not very friendly for manual inspection by users, but precludes the need for complex mapping/decoding of weird extensions and codes (Eyal) => comment on ticket * Change label "Separator" to "Before Caption" and "Numbering separator" to "After numbering" in Caption dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=153242 + agree with the need to change (Stéphane) + would prefer better documentation (Heiko) + "Numbering separator" is unclear + dont like the suggestion as both are "before the caption", changing the label is welcome however (Eyal) + MSO requests manual input of caption separator (:) and provides "use separator" with a set of single characters for chapters (Hossein) + unclear how it works (Eyal) => comment on the ticket * Please provide a user preference to disable inheriting the system UI theme + https://bugs.documentfoundation.org/show_bug.cgi?id=153229 + dark mode works now (Stuart), themes may help (Regina) + Use [( ) Dark ( ) Light ( ) System] options instead of multiple options (Hossein) + It is possible to use dark mode per application in different platforms with platform specific settings. We can use them in LibreOffice. (Hossein) $ GTK_THEME=Adwaita:dark soffice https://unix.stackexchange.com/a/185115 + prefer the addition of system colors to application colors together with the ability to use gradients and bitmaps and have some kind of "libreoffice theme" that could also be shared via extension (Heiko) + majority of users would be happy with a switch for bright/dark (system) colors (softmaker/onlyoffice does it very well); and many user wont find/search for the supposed extensions (John, Eyal) => comment on ticket OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - external/cairo
external/cairo/ExternalProject_pixman.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9393a597aaea6be0e7aa3830d952689fcaeed54e Author: Andras Timar AuthorDate: Wed Feb 1 21:34:47 2023 +0100 Commit: Andras Timar CommitDate: Wed Feb 1 21:35:02 2023 +0100 fix pixman build when cross-compiling Change-Id: I0707911f539e502635eb7f3ce5ee796440547340 diff --git a/external/cairo/ExternalProject_pixman.mk b/external/cairo/ExternalProject_pixman.mk index 9293b9234013..6ad4cd361b0d 100644 --- a/external/cairo/ExternalProject_pixman.mk +++ b/external/cairo/ExternalProject_pixman.mk @@ -26,8 +26,8 @@ $(call gb_ExternalProject_get_state_target,pixman,build) : $(gb_RUN_CONFIGURE) ./configure \ $(if $(filter TRUE,$(DISABLE_DYNLOADING)),--disable-shared,--disable-static) \ $(if $(filter ANDROID,$(OS)),--disable-arm-simd --disable-arm-neon --disable-arm-a64-neon --disable-arm-iwmmxt) \ - $(gb_CONFIGURE_PLATFORMS) \ - $(if $(CROSS_COMPILING),$(if $(filter INTEL ARM,$(CPUNAME)),ac_cv_c_bigendian=no)) \ + $(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) \ + $(if $(filter INTEL ARM,$(CPUNAME)),ac_cv_c_bigendian=no)) \ $(if $(filter EMSCRIPTEN,$(OS)),CFLAGS="-pthread") \ && $(MAKE) \ )
[Libreoffice-bugs] [Bug 109527] [META] Spell check dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109527 Bug 109527 depends on bug 152738, which changed state. Bug 152738 Summary: LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language https://bugs.documentfoundation.org/show_bug.cgi?id=152738 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 László Németh changed: What|Removed |Added Status|ASSIGNED|RESOLVED Assignee|nem...@numbertext.org |libreoffice-b...@lists.free ||desktop.org Resolution|--- |FIXED --- Comment #13 from László Németh --- @Martin: many thanks for the bug report! (Unfortunatelly, I wasn't able to reproduce it last year likely because of my old build.) @Stéphane: many thanks for the test document and bibisecting! @Noel: many thanks for the review! @Telesto: many thanks for handling the issue! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - editeng/source include/editeng sc/source
editeng/source/editeng/editview.cxx | 47
include/editeng/editview.hxx|8 ++
sc/source/ui/app/inputhdl.cxx | 24 +-
sc/source/ui/app/inputwin.cxx | 10 ---
sc/source/ui/inc/inputhdl.hxx |2 -
5 files changed, 79 insertions(+), 12 deletions(-)
New commits:
commit a5ddcc1059ee3a5ac8fed526f5e1ceca51d32bc3
Author: Szymon Kłos
AuthorDate: Wed Jan 25 14:39:34 2023 +0100
Commit: Andras Timar
CommitDate: Wed Feb 1 20:23:15 2023 +
lok: formulabar: fix URL fields selection
field is calculated as 1 character by selection getter
let's unfold fields and send real length
Change-Id: I557f8785a4d2ee6a41c6c95f4551f5e104a58c02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146350
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/editeng/source/editeng/editview.cxx
b/editeng/source/editeng/editview.cxx
index 9fc8514d7812..c522201ff917 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -1398,6 +1398,53 @@ const SvxFieldData* EditView::GetFieldAtCursor() const
return pFieldItem ? pFieldItem->GetField() : nullptr;
}
+sal_Int32 EditView::countFieldsOffsetSum(sal_Int32 nPara, sal_Int32 nPos, bool
bCanOverflow) const
+{
+if (!pImpEditView || !pImpEditView->pEditEngine)
+return 0;
+
+int nOffset = 0;
+
+for (int nCurrentPara = 0; nCurrentPara <= nPara; nCurrentPara++)
+{
+int nFields = pImpEditView->pEditEngine->GetFieldCount( nCurrentPara );
+for (int nField = 0; nField < nFields; nField++)
+{
+EFieldInfo aFieldInfo
+= pImpEditView->pEditEngine->GetFieldInfo( nCurrentPara,
nField );
+
+bool bLastPara = nCurrentPara == nPara;
+sal_Int32 nFieldPos = aFieldInfo.aPosition.nIndex;
+
+if (bLastPara && nFieldPos >= nPos)
+break;
+
+sal_Int32 nFieldLen = aFieldInfo.aCurrentText.getLength();
+
+// position in the middle of a field
+if (!bCanOverflow && bLastPara && nFieldPos + nFieldLen > nPos)
+nFieldLen = nPos - nFieldPos;
+
+nOffset += nFieldLen - 1;
+}
+}
+
+return nOffset;
+}
+
+sal_Int32 EditView::GetPosNoField(sal_Int32 nPara, sal_Int32 nPos) const
+{
+sal_Int32 nOffset = countFieldsOffsetSum(nPara, nPos, false);
+assert(nPos >= nOffset);
+return nPos - nOffset;
+}
+
+sal_Int32 EditView::GetPosWithField(sal_Int32 nPara, sal_Int32 nPos) const
+{
+sal_Int32 nOffset = countFieldsOffsetSum(nPara, nPos, true);
+return nPos + nOffset;
+}
+
void EditView::SetInvalidateMore( sal_uInt16 nPixel )
{
pImpEditView->SetInvalidateMore( nPixel );
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index 1a9e2ed8afc9..02a120cc9b07 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -162,6 +162,10 @@ private:
EditView( const EditView& ) = delete;
EditView& operator=( const EditView& ) = delete;
+// counts how many characters take unfolded fields
+// bCanOverflow - count field length without trim to the selected pos
+sal_Int32 countFieldsOffsetSum(sal_Int32 nPara, sal_Int32 nPo, bool
bCanOverflow) const;
+
public:
EditView( EditEngine* pEng, vcl::Window* pWindow );
~EditView();
@@ -318,6 +322,10 @@ public:
/// Select and return the field at the current cursor position
const SvxFieldData* GetFieldAtCursor() const;
void SelectFieldAtCursor();
+/// Converts position in paragraph to logical position without unfolding
fields
+sal_Int32 GetPosNoField(sal_Int32 nPara, sal_Int32 nPos) const;
+/// Converts logical position in paragraph to position with unfolded fields
+sal_Int32 GetPosWithField(sal_Int32 nPara, sal_Int32 nPos) const;
voidSetInvalidateMore( sal_uInt16 nPixel );
sal_uInt16 GetInvalidateMore() const;
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 155b5a1e9a6e..1ea255f23207 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -1798,13 +1798,23 @@ void ScInputHandler::LOKPasteFunctionData(const
OUString& rFunctionName)
}
}
-void ScInputHandler::LOKSendFormulabarUpdate(const SfxViewShell* pActiveViewSh,
+void ScInputHandler::LOKSendFormulabarUpdate(EditView* pActiveView,
+ const SfxViewShell* pActiveViewSh,
const OUString& rText,
const ESelection& rSelection)
{
-OUString aSelection =
-OUString::number(rSelection.nStartPos) + ";" +
OUString::number(rSelection.nEndPos) + ";" +
-OUString::number(rSelection.nStartPara) + ";" +
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||135613 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135613 [Bug 135613] Shapes can't be moved using arrow keys when they are in a table -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||135613 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135613 [Bug 135613] Shapes can't be moved using arrow keys when they are in a table -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99671] [META] Gallery bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=99671 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|135613 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135613 [Bug 135613] Shapes can't be moved using arrow keys when they are in a table -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135613] Shapes can't be moved using arrow keys when they are in a table
https://bugs.documentfoundation.org/show_bug.cgi?id=135613 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks|99671 |108741, 103100 CC||stephane.guillou@libreoffic ||e.org Regression By||Heiko Tietze Summary|Gallery shapes can't be |Shapes can't be moved using |moved using arrow keys when |arrow keys when they are in |they are in a table (since |a table |6.3)| --- Comment #8 from Stéphane Guillou (stragu) --- DM described in Bug 129467 Description an interesting way to restore the functionality: > If you click the shape and hit the left/right > arrow keys does not 'nudge' it. > If you then click in the cell to the right and click back on the shape you > still can't nudge it. > If you now drag the shape below outside the table and drag back to where it > was you still can't nudge it. > But drag it below outside the table and as an extra click in the > aforementioned cell (to the right) and drag it back to where it was and > suddenly it is nudgeable! > Click to the right cell again and back again and it becomes unnudgeable once > more. Regina did some extra testing in Bug 129467 Comment 2. Still reproducible in a recent master build: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9740331d8bc56a9b6fbe3e4c1b26fb97f6639cc6 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99671 [Bug 99671] [META] Gallery bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/win
vcl/win/window/salframe.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit fbb3b4db190f044fc99048116087a891e7d9f25f
Author: Caolán McNamara
AuthorDate: Wed Feb 1 15:23:10 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 1 20:07:15 2023 +
tdf#148085 get a more readable hyperlink color under windows dark mode
Change-Id: I392206eb9fcff7fca39c6efee747486f4dfa925e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146405
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index e1333b4a6c67..6a7eecdb71b1 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -2683,6 +2683,13 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings
)
aStyleSettings.SetInactiveTabColor( ImplWinColorToSal( color ) );
CloseThemeData(hTheme);
+if (hTheme = OpenThemeData(mhWnd, L"Textstyle"))
+{
+GetThemeColor(hTheme, TEXT_HYPERLINKTEXT, TS_HYPERLINK_NORMAL,
TMT_TEXTCOLOR, );
+aStyleSettings.SetLinkColor(ImplWinColorToSal(color));
+CloseThemeData(hTheme);
+}
+
// tdf#148448 pick a warning color more likely to be readable as a
// background in a dark theme
aStyleSettings.SetWarningColor(Color(0xf5, 0x79, 0x00));
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx | 19 +++
1 file changed, 19 insertions(+)
New commits:
commit 56cb2b78dbd355c74d3454721b8d37ad24292f85
Author: Henry Castro
AuthorDate: Fri Dec 23 13:57:01 2022 -0400
Commit: Henry Castro
CommitDate: Wed Feb 1 20:06:09 2023 +
lok: disable spell if remote language tool enabled
.
Signed-off-by: Henry Castro
Change-Id: I73158c3feaa84af4d713d3f1b1fc9a60dcf95463
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144785
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145601
Tested-by: Jenkins
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 1097058a81c5..71c53f2d097a 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -58,6 +58,8 @@
#include
#include
#include
+#include
+#include
#include
#include
#include
@@ -7069,6 +7071,23 @@ void setLanguageToolConfig()
rLanguageOpts.setUsername(aUsername);
rLanguageOpts.setApiKey(aApiKey);
}
+
+css::uno::Reference
xLangSrv =
+css::linguistic2::LinguServiceManager::create(xContext);
+if (xLangSrv.is())
+{
+css::uno::Reference xSpell =
xLangSrv->getSpellChecker();
+if (xSpell.is())
+{
+Sequence aEmpty;
+Sequence aLocales =
xSpell->getLocales();
+
+for (int itLocale = 0; itLocale < aLocales.getLength();
itLocale++)
+{
+xLangSrv->setConfiguredServices(SN_SPELLCHECKER,
aLocales[itLocale], aEmpty);
+}
+}
+}
}
catch(uno::Exception const& rException)
{
[Libreoffice-bugs] [Bug 135613] Gallery shapes can't be moved using arrow keys when they are in a table (since 6.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=135613 Stéphane Guillou (stragu) changed: What|Removed |Added CC||miscellaneous@paintdrawer.c ||o.uk --- Comment #7 from Stéphane Guillou (stragu) --- *** Bug 129467 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129467] Shape Nudge (with Arrow Key) Fails
https://bugs.documentfoundation.org/show_bug.cgi?id=129467 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Stéphane Guillou (stragu) --- Thanks, DM and Regina. I am marking as a duplicate of more recent bug 135613 because this regression was bibisected there already. But I will mention your two comments there. *** This bug has been marked as a duplicate of bug 135613 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/win
vcl/win/window/salframe.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 49701230a9a5e87475237a0392155c4c679a1cb0
Author: Caolán McNamara
AuthorDate: Wed Feb 1 15:23:10 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 1 20:03:59 2023 +
tdf#148085 get a more readable hyperlink color under windows dark mode
Change-Id: I392206eb9fcff7fca39c6efee747486f4dfa925e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146459
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 2cc3404b771c..a271c4e5e27f 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -2700,6 +2700,13 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings
)
aMenuBarRolloverTextColor = ImplWinColorToSal( color );
CloseThemeData(hTheme);
+if (hTheme = OpenThemeData(mhWnd, L"Textstyle"))
+{
+GetThemeColor(hTheme, TEXT_HYPERLINKTEXT, TS_HYPERLINK_NORMAL,
TMT_TEXTCOLOR, );
+aStyleSettings.SetLinkColor(ImplWinColorToSal(color));
+CloseThemeData(hTheme);
+}
+
// tdf#148448 pick a warning color more likely to be readable as a
// background in a dark theme
aStyleSettings.SetWarningColor(Color(0xf5, 0x79, 0x00));
[Libreoffice-bugs] [Bug 152724] FILESAVE FORMATTING Cell custom Format Code with _- (UI visible space width) is not saved correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=152724 Laurent Balland changed: What|Removed |Added Summary|FILESAVE FORMATTING Cell|FILESAVE FORMATTING Cell |custom Format Code with _- |custom Format Code with _- |(UI visible space width)|(UI visible space width) is |and ? (optional digit space |not saved correctly |placeholder) is not saved | |correctly | --- Comment #12 from Laurent Balland --- (In reply to ady from comment #11) > There are at least 3 codes (and their combinations) that are not saved > correctly in ods. Currently, the custom Format Codes are being saved as > follows: > > ? -> # > 0 -> # > _- -> " " > > > See comment #8 for sum-up. ? is now fixed in master (see bug 118324) 0 was already treated, and any "reasonable" format combining #, ? and 0 should be preserved in ODF in integer and decimal part. _x still needs an ODF extension. I accordingly modified the summary. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153313] find and replace not working for "(" or ")"
https://bugs.documentfoundation.org/show_bug.cgi?id=153313 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Buovjaga --- Works for me. Are you sure you don't have "Regular expressions" active? Arch Linux 64-bit, X11 Version: 7.4.5.1 / LibreOffice Community Build ID: 40(Build:1) CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US 7.4.5-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103537] [META] High contrast mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103537 Bug 103537 depends on bug 152845, which changed state. Bug 152845 Summary: no visible AutoText preview in high contrast mode (Windows) https://bugs.documentfoundation.org/show_bug.cgi?id=152845 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108663] [META] AutoText bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108663 Bug 108663 depends on bug 152845, which changed state. Bug 152845 Summary: no visible AutoText preview in high contrast mode (Windows) https://bugs.documentfoundation.org/show_bug.cgi?id=152845 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Bug 118320 depends on bug 148085, which changed state. Bug 148085 Summary: About dialog hyperlinks look bad (invisible / have no contrast) in dark mode on Windows https://bugs.documentfoundation.org/show_bug.cgi?id=148085 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150915] [META] Windows Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915 Bug 150915 depends on bug 148085, which changed state. Bug 148085 Summary: About dialog hyperlinks look bad (invisible / have no contrast) in dark mode on Windows https://bugs.documentfoundation.org/show_bug.cgi?id=148085 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103202] [META] About dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103202 Bug 103202 depends on bug 148085, which changed state. Bug 148085 Summary: About dialog hyperlinks look bad (invisible / have no contrast) in dark mode on Windows https://bugs.documentfoundation.org/show_bug.cgi?id=148085 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103184 Bug 103184 depends on bug 148085, which changed state. Bug 148085 Summary: About dialog hyperlinks look bad (invisible / have no contrast) in dark mode on Windows https://bugs.documentfoundation.org/show_bug.cgi?id=148085 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/uitest/textToColumns/tdf69981.py | 11 --
sc/qa/uitest/textToColumns/tdf92423.py | 12 --
sc/qa/uitest/textToColumns/textToColumns.py | 120 +---
3 files changed, 22 insertions(+), 121 deletions(-)
New commits:
commit 05472ebc3fd9c89080cfb28c26951164139b632a
Author: Xisco Fauli
AuthorDate: Wed Feb 1 17:04:17 2023 +0100
Commit: Xisco Fauli
CommitDate: Wed Feb 1 19:32:06 2023 +
UITest_textToColumns: fix indent and simplify code
The wrong indent made those tests not to be executed
OTOH, do not change the option replwarncb so it's
enabled by default. This tests are not about testing that
Change-Id: Ib73305f43dd8285f1042f9e399efb034d872d895
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146462
Tested-by: Xisco Fauli
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/uitest/textToColumns/tdf69981.py
b/sc/qa/uitest/textToColumns/tdf69981.py
index bd4b5756c9b7..87c09e8ffcbf 100644
--- a/sc/qa/uitest/textToColumns/tdf69981.py
+++ b/sc/qa/uitest/textToColumns/tdf69981.py
@@ -18,17 +18,6 @@ class tdf69981(UITestCase):
with self.ui_test.load_file(get_url_for_data_file("tdf69981.ods")) as
calc_doc:
xCalcDoc = self.xUITest.getTopFocusWindow()
gridwin = xCalcDoc.getChild("grid_window")
-#Make sure that tools-options-StarOffice Calc-General-Input
settings-Show overwrite warning when pasting data is tagged.
-with
self.ui_test.execute_dialog_through_command(".uno:OptionsTreeDialog") as
xDialogOpt:
-
-xPages = xDialogOpt.getChild("pages")
-xWriterEntry = xPages.getChild('3') # Calc
-xWriterEntry.executeAction("EXPAND", tuple())
-xWriterGeneralEntry = xWriterEntry.getChild('0')
-xWriterGeneralEntry.executeAction("SELECT", tuple())
#General / replwarncb
-xreplwarncb = xDialogOpt.getChild("replwarncb")
-if (get_state_as_dict(xreplwarncb)["Selected"]) == "false":
-xreplwarncb.executeAction("CLICK", tuple())
#Select A2:A7
gridwin.executeAction("SELECT", mkPropertyValues({"RANGE":
"A2:A7"}))
diff --git a/sc/qa/uitest/textToColumns/tdf92423.py
b/sc/qa/uitest/textToColumns/tdf92423.py
index 44c7613db48a..99486bb2f00e 100644
--- a/sc/qa/uitest/textToColumns/tdf92423.py
+++ b/sc/qa/uitest/textToColumns/tdf92423.py
@@ -19,17 +19,6 @@ class tdf92423(UITestCase):
xCalcDoc = self.xUITest.getTopFocusWindow()
gridwin = xCalcDoc.getChild("grid_window")
-#Make sure that tools-options-StarOffice Calc-General-Input
settings-Show overwrite warning when pasting data is tagged.
-with
self.ui_test.execute_dialog_through_command(".uno:OptionsTreeDialog") as
xDialogOpt:
-
-xPages = xDialogOpt.getChild("pages")
-xWriterEntry = xPages.getChild('3') # Calc
-xWriterEntry.executeAction("EXPAND", tuple())
-xWriterGeneralEntry = xWriterEntry.getChild('0')
-xWriterGeneralEntry.executeAction("SELECT", tuple())
#General / replwarncb
-xreplwarncb = xDialogOpt.getChild("replwarncb")
-if (get_state_as_dict(xreplwarncb)["Selected"]) == "false":
-xreplwarncb.executeAction("CLICK", tuple())
#enter data
enter_text_to_cell(gridwin, "A1", "1;2")
enter_text_to_cell(gridwin, "A2", "2;3")
@@ -53,7 +42,6 @@ class tdf92423(UITestCase):
xSemicolon = xDialog.getChild("semicolon") #check semicolon
checkbox
if (get_state_as_dict(xSemicolon)["Selected"]) == "false":
xSemicolon.executeAction("CLICK", tuple())
-# Click Ok
#Verify
self.assertEqual(get_cell_by_position(document, 0, 0,
6).getValue(), 1)
diff --git a/sc/qa/uitest/textToColumns/textToColumns.py
b/sc/qa/uitest/textToColumns/textToColumns.py
index f17f6cc79ff0..c67e879d1835 100644
--- a/sc/qa/uitest/textToColumns/textToColumns.py
+++ b/sc/qa/uitest/textToColumns/textToColumns.py
@@ -20,17 +20,6 @@ class CalcTextToColumns(UITestCase):
with
self.ui_test.load_file(get_url_for_data_file("text_to_columns_dot.ods")) as
calc_doc:
xCalcDoc = self.xUITest.getTopFocusWindow()
gridwin = xCalcDoc.getChild("grid_window")
-#Make sure that tools-options-StarOffice Calc-General-Input
settings-Show overwrite warning when pasting data is tagged.
-with
self.ui_test.execute_dialog_through_command(".uno:OptionsTreeDialog") as
xDialogOpt:
-
-xPages = xDialogOpt.getChild("pages")
-xWriterEntry = xPages.getChild('3') # Calc
-xWriterEntry.executeAction("EXPAND", tuple())
-xWriterGeneralEntry =
[Libreoffice-commits] core.git: basctl/source include/sfx2 sc/source sd/source sfx2/source starmath/inc starmath/source sw/inc sw/source
basctl/source/basicide/basdoc.cxx |2 +-
basctl/source/basicide/basdoc.hxx |2 +-
include/sfx2/objsh.hxx |8 +---
sc/source/ui/docshell/docsh4.cxx|2 +-
sc/source/ui/inc/docsh.hxx |2 +-
sd/source/ui/docshell/docshel2.cxx |2 +-
sd/source/ui/inc/DrawDocShell.hxx |2 +-
sfx2/source/doc/objembed.cxx| 12 ++--
starmath/inc/document.hxx |3 ++-
starmath/source/document.cxx|3 ++-
sw/inc/docsh.hxx|2 +-
sw/inc/viewsh.hxx |3 ++-
sw/source/core/doc/notxtfrm.cxx |2 +-
sw/source/core/txtnode/fntcache.cxx | 13 -
sw/source/core/view/viewimp.cxx |2 +-
sw/source/core/view/vprint.cxx |5 -
sw/source/uibase/app/docsh.cxx |4 ++--
sw/source/uibase/utlui/unotools.cxx |3 ++-
18 files changed, 42 insertions(+), 30 deletions(-)
New commits:
commit 0eaad910442a1bbb0c6a89a8887322ea3d6906e0
Author: Caolán McNamara
AuthorDate: Mon Jan 9 12:47:57 2023 +
Commit: Caolán McNamara
CommitDate: Wed Feb 1 19:31:49 2023 +
Resolves: tdf#152845 AutoText preview not readable in high contrast mode
if its a high contrast mode with white text on black background. Reuse
isOutputToWindow to distinguish between the case we are outputting to
screen but not using a vcl::Window (and want to use the appropiate color
for autocolor) vs the cases we are printing or exporting to pdf and not
using a vcl::Window where the color should be black.
Change-Id: Ib688892a6315fe88ba585613539088611d3995ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145234
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/basctl/source/basicide/basdoc.cxx
b/basctl/source/basicide/basdoc.cxx
index 83a3f1781630..ffd22b9063c7 100644
--- a/basctl/source/basicide/basdoc.cxx
+++ b/basctl/source/basicide/basdoc.cxx
@@ -82,7 +82,7 @@ void DocShell::FillClass( SvGlobalName*,
SotClipboardFormatId*, OUString*, sal_I
DBG_ASSERT( !bTemplate, "No template for Basic" );
}
-void DocShell::Draw( OutputDevice *, const JobSetup &, sal_uInt16 )
+void DocShell::Draw( OutputDevice *, const JobSetup &, sal_uInt16, bool )
{}
} // namespace basctl
diff --git a/basctl/source/basicide/basdoc.hxx
b/basctl/source/basicide/basdoc.hxx
index d5b3aabcf961..bb847a0a9b1a 100644
--- a/basctl/source/basicide/basdoc.hxx
+++ b/basctl/source/basicide/basdoc.hxx
@@ -34,7 +34,7 @@ class DocShell: public SfxObjectShell
protected:
virtual voidDraw( OutputDevice *, const JobSetup & rSetup,
- sal_uInt16 nAspect ) override;
+ sal_uInt16 nAspect, bool bOutputForScreen ) override;
virtual voidFillClass( SvGlobalName * pClassName,
SotClipboardFormatId * pFormat,
OUString * pFullTypeName,
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index b64fa61389bf..e3a5b4a022f1 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -650,9 +650,10 @@ public:
voidDoDraw( OutputDevice *, const Point & rObjPos,
const Size & rSize,
const JobSetup & rSetup,
-sal_uInt16 nAspect = ASPECT_CONTENT );
+sal_uInt16 nAspect = ASPECT_CONTENT,
+bool bOutputForScreen = false );
virtual voidDraw( OutputDevice *, const JobSetup & rSetup,
- sal_uInt16 nAspect ) = 0;
+ sal_uInt16 nAspect, bool bOutputForScreen ) = 0;
virtual voidFillClass( SvGlobalName * pClassName,
@@ -717,7 +718,8 @@ public:
const Fraction & rScaleX,
const Fraction & rScaleY,
const JobSetup & rSetup,
-sal_uInt16 nAspect );
+sal_uInt16 nAspect,
+bool bOutputForScreen );
// Shell Interface
SAL_DLLPRIVATE void ExecFile_Impl(SfxRequest &);
diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx
index a57a40e9be8b..3ef4dba632d8 100644
--- a/sc/source/ui/docshell/docsh4.cxx
+++ b/sc/source/ui/docshell/docsh4.cxx
@@ -2174,7 +2174,7 @@ void ScDocShell::GetState( SfxItemSet )
}
}
-void ScDocShell::Draw( OutputDevice* pDev, const JobSetup & /* rSetup */,
sal_uInt16 nAspect )
+void ScDocShell::Draw( OutputDevice* pDev, const JobSetup & /* rSetup */,
sal_uInt16 nAspect, bool /*bOutputToWindow*/ )
{
SCTAB nVisTab = m_pDocument->GetVisibleTab();
diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx
index edf0cbc1c1b0..6df3ebc010e9 100644
--- a/sc/source/ui/inc/docsh.hxx
+++
[Libreoffice-commits] core.git: vcl/win
vcl/win/window/salframe.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 9274d41bd72c5310491d81c6d8d938e44ed9d223
Author: Caolán McNamara
AuthorDate: Wed Feb 1 15:23:10 2023 +
Commit: Caolán McNamara
CommitDate: Wed Feb 1 19:28:14 2023 +
tdf#148085 get a more readable hyperlink color under windows dark mode
Change-Id: I392206eb9fcff7fca39c6efee747486f4dfa925e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146458
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 474e48560fb9..f15a4f23e693 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -2683,6 +2683,13 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings
)
aStyleSettings.SetInactiveTabColor( ImplWinColorToSal( color ) );
CloseThemeData(hTheme);
+if (hTheme = OpenThemeData(mhWnd, L"Textstyle"))
+{
+GetThemeColor(hTheme, TEXT_HYPERLINKTEXT, TS_HYPERLINK_NORMAL,
TMT_TEXTCOLOR, );
+aStyleSettings.SetLinkColor(ImplWinColorToSal(color));
+CloseThemeData(hTheme);
+}
+
// tdf#148448 pick a warning color more likely to be readable as a
// background in a dark theme
aStyleSettings.SetWarningColor(Color(0xf5, 0x79, 0x00));
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docedt.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 2780b026f912a103aea3f8dc19319b998d19a43a
Author: László Németh
AuthorDate: Wed Feb 1 18:00:25 2023 +0100
Commit: László Németh
CommitDate: Wed Feb 1 19:07:13 2023 +
tdf#152738 sw: fix lost SwPosition in spelling dialog
Which resulted broken spell checking.
Regression from commit b484e5d9e0d22b794c2d1c73741191836158a4ad
"use more SwPosition::Assign".
Change-Id: I7be215f629ed73a3009f8358172ee3a7e2e72ffc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146465
Reviewed-by: Noel Grandin
Tested-by: Jenkins
Reviewed-by: László Németh
Tested-by: László Németh
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index 22b35fdf8e20..5d1e296e0b07 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -607,8 +607,8 @@ uno::Any SwDoc::Spell( SwPaM& rPaM,
pSpellArgs->pStartPos->GetContentIndex();
if( nCurrNd != nEndNd )
{
-pSttPos->Assign(nCurrNd);
-pEndPos->Assign(nCurrNd);
+pSttPos->Assign(nCurrNd,
pSttPos->GetContentIndex());
+pEndPos->Assign(nCurrNd,
pEndPos->GetContentIndex());
nCurrNd = nEndNd;
}
}
[Libreoffice-bugs] [Bug 137972] Correcting with spell checker context menu places cursor at the left (previously right)
https://bugs.documentfoundation.org/show_bug.cgi?id=137972 --- Comment #13 from Heiko Tietze --- *** Bug 149854 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
