[Libreoffice-bugs] [Bug 148597] Drop "Display" option in "Type" tab and add fields for "Caption No"/CN, "Caption Category"/CC, and "Caption Text"/CT in Entries tab for Table of Figures and Index of Ta
https://bugs.documentfoundation.org/show_bug.cgi?id=148597 --- Comment #19 from Heiko Tietze --- (In reply to sdc.blanco from comment #14) > @Heiko, should I add needsUXEval? or can this proposal be accepted? Bug 153561 is on the agenda for the design meeting, along with bug 153712 and I added this ticket now too. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 4 commits - sw/inc sw/source
sw/inc/formatflysplit.hxx |5 --
sw/source/core/attr/formatflysplit.cxx |9 +
sw/source/core/inc/flyfrm.hxx |3 +
sw/source/core/inc/flyfrms.hxx |2 +
sw/source/core/inc/frame.hxx |1
sw/source/core/layout/findfrm.cxx | 16 -
sw/source/core/layout/flowfrm.cxx |8
sw/source/core/layout/fly.cxx | 26 +++
sw/source/core/layout/flycnt.cxx | 56 -
9 files changed, 119 insertions(+), 7 deletions(-)
New commits:
commit a9b113740c02f0f25ca83d6c17d3c404b587f9ab
Author: Miklos Vajna
AuthorDate: Thu Feb 2 08:27:33 2023 +0100
Commit: Miklos Vajna
CommitDate: Mon Feb 27 08:41:50 2023 +0100
sw: call GetNextFlyLeaf() in SwFrame::GetLeaf()
- improve SwFrame::GetLeaf() so that in case we are in a fly frame and
that is allowed to split, then we call GetNextFlyLeaf()
- GetNextFlyLeaf() uses GetNextLayoutLeaf(), if that finds nothing then
calls InsertPage() and then tries again. The second
GetNextLayoutLeaf() is meant to find the follow frame's parent, but fly
frames don't in general have uppers, so teach it about split fly frames
- finally improve SwFrame::GetNextFlyLeaf() a bit, so that it does fly
insertion similar to AppendObj(): first move the anchor to the next
page then append the just created fly there
With this, a fly frame with 2 paragraphs crossing the bottom of the body
frame is split, although the second fly frame contains both paragraphs,
which still needs fixing.
Towards an initial layout for multi-page fly frames.
(cherry picked from commit 4c6c317e1743166ee772ab03413f0fa59c59f859)
Change-Id: Iec038e9fed462b1f8ee0b48fbb3fd76641c96d5c
diff --git a/sw/source/core/layout/findfrm.cxx
b/sw/source/core/layout/findfrm.cxx
index a58c74afa876..07290dee5f2a 100644
--- a/sw/source/core/layout/findfrm.cxx
+++ b/sw/source/core/layout/findfrm.cxx
@@ -360,6 +360,16 @@ const SwLayoutFrame *SwFrame::ImplGetNextLayoutLeaf( bool
bFwd ) const
// I cannot go forward, because there is no next frame.
// I'll try to go up:
p = pFrame->GetUpper();
+
+ if (!p && pFrame->IsFlyFrame())
+ {
+ const SwFlyFrame* pFlyFrame = pFrame->FindFlyFrame();
+ if (pFlyFrame->IsFlySplitAllowed())
+ {
+ p = pFlyFrame->GetAnchorFrame();
+ }
+ }
+
bGoingUp = nullptr != p;
if ( !bGoingUp )
{
diff --git a/sw/source/core/layout/flowfrm.cxx
b/sw/source/core/layout/flowfrm.cxx
index 0e762f371aa4..9939dceafa1b 100644
--- a/sw/source/core/layout/flowfrm.cxx
+++ b/sw/source/core/layout/flowfrm.cxx
@@ -877,6 +877,14 @@ SwLayoutFrame *SwFrame::GetLeaf( MakePageType eMakePage,
bool bFwd )
if ( bInSct )
return bFwd ? GetNextSctLeaf( eMakePage ) : GetPrevSctLeaf();
+if (IsInFly() && FindFlyFrame()->IsFlySplitAllowed())
+{
+if (bFwd)
+{
+return GetNextFlyLeaf(eMakePage);
+}
+}
+
return bFwd ? GetNextLeaf( eMakePage ) : GetPrevLeaf();
}
diff --git a/sw/source/core/layout/flycnt.cxx b/sw/source/core/layout/flycnt.cxx
index 0fc135b48b5f..c2fd6bc28666 100644
--- a/sw/source/core/layout/flycnt.cxx
+++ b/sw/source/core/layout/flycnt.cxx
@@ -83,7 +83,8 @@ SwFlyAtContentFrame::SwFlyAtContentFrame( SwFlyFrameFormat
*pFormat, SwFrame* pS
}
SwFlyAtContentFrame::SwFlyAtContentFrame(SwFlyAtContentFrame& rPrecede)
-: SwFlyAtContentFrame(rPrecede.GetFormat(), rPrecede.getRootFrame(),
/*pAnchor=*/nullptr)
+: SwFlyAtContentFrame(rPrecede.GetFormat(),
const_cast(rPrecede.GetAnchorFrame()),
+ const_cast(rPrecede.GetAnchorFrame()))
{
SetFollow(rPrecede.GetFollow());
rPrecede.SetFollow(this);
@@ -1560,21 +1561,23 @@ SwLayoutFrame *SwFrame::GetNextFlyLeaf( MakePageType
eMakePage )
if( pLayLeaf )
{
SwFlyAtContentFrame* pNew = nullptr;
+SwFrame* pFlyAnchor = const_cast(pFly->GetAnchorFrame());
+if (pFlyAnchor)
{
-pNew = new SwFlyAtContentFrame( *pFly );
-pNew->InsertBefore( pLayLeaf, pLayLeaf->Lower() );
-
-SwFrame* pTmp = pFly->GetNext();
-if( pTmp && pTmp != pFly->GetFollow() )
+SwFrame* pTmp = pFlyAnchor->GetNext();
+if (pTmp)
{
SwFlowFrame* pNxt = nullptr;
-if( pTmp->IsContentFrame() )
+if (pTmp->IsContentFrame())
{
pNxt = static_cast(pTmp);
}
if (pNxt)
{
-pNxt->MoveSubTree(pLayLeaf, pNew->GetNext());
+
[Libreoffice-bugs] [Bug 153293] [META] Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=153293 Dieter changed: What|Removed |Added Depends on||153584 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153584 [Bug 153584] Form fields invisible on printing in Writer when in dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153584] Form fields invisible on printing in Writer when in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153584 Dieter changed: What|Removed |Added Blocks||153293 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153293 [Bug 153293] [META] Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 58070] Switching paragraph styles removes explicit text direction choice
https://bugs.documentfoundation.org/show_bug.cgi?id=58070 --- Comment #17 from Heiko Tietze --- (In reply to Urmas from comment #16) > Italic is a formatting, while text direction is not. Both are attributes of the paragraph. Clearly NAB. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148601] Missing scrollbars in menus (interface bug since 7.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=148601 Adolfo Jayme Barrientos changed: What|Removed |Added Attachment #179651|dialogs go off screen, |menus go off screen, description|examples 2 |examples 2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #10 from Mike Kaganski --- (In reply to nouvel.aubergi...@gmail.com from comment #9) > I followed the download link for other languages from LibreOffice main page > through the French link, and that page was in English. Even the browser was > a French browser. So what? How does this help with the issue you created? Is this related to your A4 instead of Letter default page size? Please limit one issue to one problem. If you think that there is something wrong with language of download page, or with the language of just-downloaded and installed program, please create another issue, and there, provide exact steps you do (from where (URL) you opened the page; what was your browser (exact version) and your OS (including locale settings), what was your expectations, and what happened instead). > About distros, please re-read the post I do not understand what you expect me to see there. If you believe that I missed something, do not play "guess" games, and explain directly what you think I misunderstood. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #9 from nouvel.aubergi...@gmail.com --- (In reply to Mike Kaganski from comment #8) > (In reply to nouvel.aubergi...@gmail.com from comment #6) > > Who are the users you are packaging this software for? These further add to > > the users' confusion. I am speaking on behalf of my French speaking > > audience. > > I guess, for any user who can comprehend the "install the software and the > language pack that is offered on the same download page", given that the > downloads for Linux are *not* meant to be the main installation method on > that family of operating systems (distros bundle LibreOffice in their > package managers, and provide convenient methods to match the UI; the > package provided on the LibreOffice site offers only a basic level of OS > integration for Linux, since it can't know the versions of libraries > installed on your one of thousands available Linux flavors). I followed the download link for other languages from LibreOffice main page through the French link, and that page was in English. Even the browser was a French browser. About distros, please re-read the post -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source sw/uiconfig
sw/qa/uitest/ui/misc/misc.py| 12 +++
sw/source/ui/misc/contentcontroldlg.cxx | 36 +++
sw/source/uibase/inc/contentcontroldlg.hxx |2
sw/uiconfig/swriter/ui/contentcontroldlg.ui | 85 +---
4 files changed, 128 insertions(+), 7 deletions(-)
New commits:
commit 0d2a962c363632a890a994e7e143099c53ac4283
Author: Justin Luth
AuthorDate: Thu Feb 23 15:40:02 2023 -0500
Commit: Miklos Vajna
CommitDate: Mon Feb 27 07:26:17 2023 +
tdf#151548 sw content controls: add UI for Id and TabIndex
This is my first go at adding anything to the UI.
(I've done some fixing of other people's design,
but never created anything new myself.)
I took all my inspiration from Miklos'
add110bad816fadeb96e7af0d4689389c04c263e.
In the first iteration I did a fancy "same as id"
scenario. But ID-as-unsigned, securing unique IDs,
and English-only number recognition
sadly made me decide to drop the fancy features.
Now, both are simple, stand-alone spinbuttons
that depend on tooltips to guide user input, not fancy comboboxes.
It is important for the ID to display as unsigned,
since that is how it is used as a "name" in VBA.
It should be copy-pasteable for use in VBA programming.
It is useful for the TABINDEX to display as signed,
since it allows entering a -1 to disable tab navigation to the control.
make UITest_sw_ui_misc
Change-Id: Ia7c99888e60c33ac39616b24c7c1715604c3ec69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147591
Tested-by: Jenkins
Reviewed-by: Justin Luth
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/uitest/ui/misc/misc.py b/sw/qa/uitest/ui/misc/misc.py
index 2b6307cefb61..8af00054a5e6 100644
--- a/sw/qa/uitest/ui/misc/misc.py
+++ b/sw/qa/uitest/ui/misc/misc.py
@@ -26,6 +26,7 @@ class TestTmpdlg(UITestCase):
contentControl = portion.ContentControl
contentControl.Alias = "my alias"
contentControl.Tag = "my tag"
+contentControl.TabIndex = "1"
listItems = contentControl.ListItems
self.assertEqual(len(listItems), 1)
self.assertEqual(listItems[0][0].Name, "DisplayText")
@@ -42,6 +43,15 @@ class TestTmpdlg(UITestCase):
self.assertEqual(get_state_as_dict(xTag)['Text'], "my tag")
type_text(xTag, "new tag ")
xAdd = xDialog.getChild("add")
+
+xId = xDialog.getChild("idspinbutton")
+self.assertEqual(get_state_as_dict(xId)['Text'], "0")
+type_text(xId, "429496729") # added in front, making it
4294967290
+
+xTabIndex = xDialog.getChild("tabindexspinbutton")
+self.assertEqual(get_state_as_dict(xTabIndex)['Text'], "1")
+type_text(xTabIndex, "-") # add a minus in front, making it -1
+
with self.ui_test.execute_blocking_action(xAdd.executeAction,
args=('CLICK', ())) as xSubDialog:
xDisplayName = xSubDialog.getChild("displayname")
type_text(xDisplayName, "Foo Bar")
@@ -57,6 +67,8 @@ class TestTmpdlg(UITestCase):
self.assertEqual(listItems[1][1].Value, "foo-bar")
self.assertEqual(contentControl.Alias, "new alias my alias")
self.assertEqual(contentControl.Tag, "new tag my tag")
+self.assertEqual(contentControl.Id, -6) # stored as signed,
displays as unsigned
+self.assertEqual(contentControl.TabIndex, 4294967295) # stored as
unsigned, displays as signed
# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sw/source/ui/misc/contentcontroldlg.cxx
b/sw/source/ui/misc/contentcontroldlg.cxx
index 3aeeab3c6306..f318fa6a699e 100644
--- a/sw/source/ui/misc/contentcontroldlg.cxx
+++ b/sw/source/ui/misc/contentcontroldlg.cxx
@@ -40,6 +40,8 @@ SwContentControlDlg::SwContentControlDlg(weld::Window*
pParent, SwWrtShell& rWrt
,
m_xShowingPlaceHolderCB(m_xBuilder->weld_check_button("showing_place_holder"))
, m_xAlias(m_xBuilder->weld_entry("aliasentry"))
, m_xTag(m_xBuilder->weld_entry("tagentry"))
+, m_xId(m_xBuilder->weld_spin_button("idspinbutton"))
+, m_xTabIndex(m_xBuilder->weld_spin_button("tabindexspinbutton"))
, m_xCheckboxFrame(m_xBuilder->weld_frame("checkboxframe"))
, m_xCheckedState(m_xBuilder->weld_entry("checkboxcheckedentry"))
, m_xCheckedStateBtn(m_xBuilder->weld_button("btncheckboxchecked"))
@@ -108,6 +110,28 @@ SwContentControlDlg::SwContentControlDlg(weld::Window*
pParent, SwWrtShell& rWrt
m_xTag->save_value();
}
+// The ID is supposed to be a unique ID, but it isn't really used for much
+// and in MS Word it (supposedly) is automatically made unique if it is a
duplicate.
+// The main purpose for having it here is lookup, not modification,
+// since AFAIK the only use of the ID is for
[Libreoffice-bugs] [Bug 151548] No access to FormField controls in StarBASIC/VBA
https://bugs.documentfoundation.org/show_bug.cgi?id=151548 --- Comment #36 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0d2a962c363632a890a994e7e143099c53ac4283 tdf#151548 sw content controls: add UI for Id and TabIndex It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153589] Window size of "Character style for main entries" for Alphabetical Index should be increased
https://bugs.documentfoundation.org/show_bug.cgi?id=153589 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Blocks||122497 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Dieter --- I confirm it with Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122497 [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=122497 Dieter changed: What|Removed |Added Depends on||153589 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153589 [Bug 153589] Window size of "Character style for main entries" for Alphabetical Index should be increased -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - basic/source include/basic
basic/source/sbx/sbxexec.cxx | 16 +---
include/basic/sbmod.hxx |3 ++-
include/basic/sbxobj.hxx |5 ++---
3 files changed, 9 insertions(+), 15 deletions(-)
New commits:
commit bc86ef1e0ec2801d8fead9b98cbe8d4129f3e244
Author: Mike Kaganski
AuthorDate: Tue Feb 21 08:00:26 2023 +0300
Commit: Tor Lillqvist
CommitDate: Mon Feb 27 07:21:02 2023 +
Related: tdf#153752 Use virtual method to avoid dynamic casts
Change-Id: I97c09d82699621d5a43a525b5f2cf75ff5d131c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147353
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147752
Tested-by: Tor Lillqvist
Reviewed-by: Tor Lillqvist
diff --git a/basic/source/sbx/sbxexec.cxx b/basic/source/sbx/sbxexec.cxx
index de711944d36c..af7d12c00651 100644
--- a/basic/source/sbx/sbxexec.cxx
+++ b/basic/source/sbx/sbxexec.cxx
@@ -19,7 +19,6 @@
#include
-#include
#include
#include
#include
@@ -350,7 +349,7 @@ SbxVariable* SbxObject::Execute( const OUString& rTxt )
{
SetError( ERRCODE_BASIC_SYNTAX ); break;
}
-pVar = Assign( this, this, , IsModuleCompatible() );
+pVar = Assign( this, this, , IsOptionCompatible() );
if( !pVar.is() )
{
break;
@@ -373,7 +372,7 @@ SbxVariable* SbxObject::FindQualified( const OUString&
rName, SbxClassType t )
{
return nullptr;
}
-pVar = QualifiedName( this, this, , t, IsModuleCompatible() );
+pVar = QualifiedName( this, this, , t, IsOptionCompatible() );
p = SkipWhitespace( p );
if( *p )
{
@@ -382,15 +381,10 @@ SbxVariable* SbxObject::FindQualified( const OUString&
rName, SbxClassType t )
return pVar.get();
}
-bool SbxObject::IsModuleCompatible() const
+bool SbxObject::IsOptionCompatible() const
{
-const SbxObject* pObj = this;
-while (pObj)
-{
-if (auto pMod = dynamic_cast(pObj))
-return pMod->IsCompatible();
-pObj = pObj->GetParent();
-}
+if (const SbxObject* pObj = GetParent())
+return pObj->IsOptionCompatible();
return false;
}
diff --git a/include/basic/sbmod.hxx b/include/basic/sbmod.hxx
index fac7f9e50121..7ca52276d012 100644
--- a/include/basic/sbmod.hxx
+++ b/include/basic/sbmod.hxx
@@ -94,6 +94,8 @@ protected:
SAL_DLLPRIVATE virtual void Notify( SfxBroadcaster& rBC, const SfxHint&
rHint ) override;
SAL_DLLPRIVATE void handleProcedureProperties( SfxBroadcaster& rBC, const
SfxHint& rHint );
virtual ~SbModule() override;
+bool IsOptionCompatible() const override { return mbCompat; }
+
public:
SBX_DECL_PERSIST_NODATA(SBXID_BASICMOD,2);
SbModule( const OUString&, bool bVBASupport = false );
@@ -123,7 +125,6 @@ public:
SAL_DLLPRIVATE bool HasExeCode();
bool IsVBASupport() const { return mbVBASupport; }
SAL_DLLPRIVATE void SetVBASupport( bool bSupport );
-bool IsCompatible() const { return mbCompat; }
sal_Int32 GetModuleType() const { return mnType; }
void SetModuleType( sal_Int32 nType ) { mnType = nType; }
bool isProxyModule() const { return bIsProxyModule; }
diff --git a/include/basic/sbxobj.hxx b/include/basic/sbxobj.hxx
index 34c117d33853..33ffc98c77d9 100644
--- a/include/basic/sbxobj.hxx
+++ b/include/basic/sbxobj.hxx
@@ -41,6 +41,8 @@ protected:
virtual bool StoreData( SvStream& ) const override;
virtual ~SbxObject() override;
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
+virtual bool IsOptionCompatible() const; // Module's Option Compatible
+
public:
SBX_DECL_PERSIST_NODATA(SBXID_OBJECT,1);
SbxObject( const OUString& rClassname );
@@ -78,9 +80,6 @@ public:
SbxArray* GetObjects() { return pObjs.get(); }
// Debugging
void Dump( SvStream&, bool bDumpAll );
-
-private:
-bool IsModuleCompatible() const; // Module's Option Compatible
};
#endif // INCLUDED_BASIC_SBXOBJ_HXX
[Libreoffice-bugs] [Bug 153848] Update Sukapura icons in Start Center to match new icons
https://bugs.documentfoundation.org/show_bug.cgi?id=153848 Rizal Muttaqin changed: What|Removed |Added Blocks||131141 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131141 [Bug 131141] [META] Sukapura icons -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131141] [META] Sukapura icons
https://bugs.documentfoundation.org/show_bug.cgi?id=131141 Rizal Muttaqin changed: What|Removed |Added Depends on||153848 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153848 [Bug 153848] Update Sukapura icons in Start Center to match new icons -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153848] New: Update Sukapura icons in Start Center to match new icons
https://bugs.documentfoundation.org/show_bug.cgi?id=153848 Bug ID: 153848 Summary: Update Sukapura icons in Start Center to match new icons Product: LibreOffice Version: 7.5.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz...@libreoffice.org Created attachment 185600 --> https://bugs.documentfoundation.org/attachment.cgi?id=185600=edit Start Center with Sukapura icons Similar with tdf#152595, Sukapura icons need to be updated also to remove old branding images. Steps to reproduce 1. Change icon theme to Sukapura (Tools > Options > %PRODUCTNAME> View > Icon Theme) 2. Reopen LibreOffice to show Start Center Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: 50(Build:3) CPU threads: 8; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: id-ID (id_ID.UTF-8); UI: id-ID Ubuntu package version: 1:7.5.0~rc3-0ubuntu0.22.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
Re: sc: test failure depending on order of execution
Hi Xisco, On Fri, Feb 24, 2023 at 02:40:23PM +0100, Xisco Fauli wrote: > it seems there is a test in sc/qa/unit/subsequent_export_test2.cxx that > fails depending on the order of execution. > > If testTdf121260 is executed before testTdf107586, then it passes, > otherwise, it fails with > > ##Failure Location unknown## : Error > Test name: ScExportTest2::testTdf121260 > An uncaught exception of type com.sun.star.container.NoSuchElementException > - > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/package/source/zippackage/zipfileaccess.cxx:263: > at > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/package/source/zippackage/zipfileaccess.cxx:263 > > which means the file 'xl/charts/chart1.xml' doesn't exist in the zip file > and parseExport fails. See https://gerrit.libreoffice.org/c/core/+/147622 > > Anyone has any idea why the file is not created if testTdf107586 is executed > first ? Not really, but the way I would debug this is to see how XmlFilterBase::openFragmentStream() at oox/source/core/xmlfilterbase.cxx:495 gets called in the good case, and then hopefully the backtrace would give you some idea how it's not called in the bad case. My first guess would be some static variable, but who knows. Regards, Miklos
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #8 from Mike Kaganski --- (In reply to nouvel.aubergi...@gmail.com from comment #6) > Who are the users you are packaging this software for? These further add to > the users' confusion. I am speaking on behalf of my French speaking audience. I guess, for any user who can comprehend the "install the software and the language pack that is offered on the same download page", given that the downloads for Linux are *not* meant to be the main installation method on that family of operating systems (distros bundle LibreOffice in their package managers, and provide convenient methods to match the UI; the package provided on the LibreOffice site offers only a basic level of OS integration for Linux, since it can't know the versions of libraries installed on your one of thousands available Linux flavors). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153588] Writer and Calc 7.5.0.3 are very slow on INTEL (MacOS 11.7.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=153588 Dieter changed: What|Removed |Added OS|other |macOS (All) Component|Writer |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114426] [META] Caption bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114426 Dieter changed: What|Removed |Added Depends on||153585 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153585 [Bug 153585] Impossible to insert a footnote in a caption -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 48534] EDITING: No footnotes possible in frames including figure captions
https://bugs.documentfoundation.org/show_bug.cgi?id=48534 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3585 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153585] Impossible to insert a footnote in a caption
https://bugs.documentfoundation.org/show_bug.cgi?id=153585 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Summary|Impossible to insert a |Impossible to insert a |footnote in a legend|footnote in a caption Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=48 ||534 Blocks||114426, 103164 Severity|enhancement |normal --- Comment #1 from Dieter --- I confirm it with Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Same in SafeMode. At least related to (but perhaps duplicate of) bug 48534. But for me clearly a bug and not enhancement request. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103164 [Bug 103164] [META] Footnote and Endnote bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=114426 [Bug 114426] [META] Caption bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103164] [META] Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103164 Dieter changed: What|Removed |Added Depends on||153585 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153585 [Bug 153585] Impossible to insert a footnote in a caption -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152775] [Enhancement] Emphasize the entry the mouse pointer is over in the Writer Navigator content tree
https://bugs.documentfoundation.org/show_bug.cgi?id=152775 --- Comment #7 from Buovjaga --- (In reply to Heiko Tietze from comment #6) > (In reply to Buovjaga from comment #5) > > This is about making the item text bold in the Navigator, not about > > highlighting the element in the document canvas. > > Why should one do this? Should or should one not do this is exactly what is being asked from UX team. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152775] [Enhancement] Emphasize the entry the mouse pointer is over in the Writer Navigator content tree
https://bugs.documentfoundation.org/show_bug.cgi?id=152775 --- Comment #7 from Buovjaga --- (In reply to Heiko Tietze from comment #6) > (In reply to Buovjaga from comment #5) > > This is about making the item text bold in the Navigator, not about > > highlighting the element in the document canvas. > > Why should one do this? Should or should one not do this is exactly what is being asked from UX team. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 Buovjaga changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #7 from Buovjaga --- (In reply to nouvel.aubergi...@gmail.com from comment #3) > Created attachment 185597 [details] > image of libreoffice 7.3.7 version shows the problem Note that next time you can just click the copy button like I said. No need to take a screenshot. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153239] Accept english terms for functions in the non-english versions, too
https://bugs.documentfoundation.org/show_bug.cgi?id=153239 Mike Kaganski changed: What|Removed |Added Depends on|153584 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153584 [Bug 153584] Form fields invisible on printing in Writer when in dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153584] Form fields invisible on printing in Writer when in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153584 Mike Kaganski changed: What|Removed |Added Blocks|153239 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153239 [Bug 153239] Accept english terms for functions in the non-english versions, too -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152775] [Enhancement] Emphasize the entry the mouse pointer is over in the Writer Navigator content tree
https://bugs.documentfoundation.org/show_bug.cgi?id=152775 --- Comment #6 from Heiko Tietze --- (In reply to Buovjaga from comment #5) > This is about making the item text bold in the Navigator, not about > highlighting the element in the document canvas. Why should one do this? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152775] [Enhancement] Emphasize the entry the mouse pointer is over in the Writer Navigator content tree
https://bugs.documentfoundation.org/show_bug.cgi?id=152775 --- Comment #6 from Heiko Tietze --- (In reply to Buovjaga from comment #5) > This is about making the item text bold in the Navigator, not about > highlighting the element in the document canvas. Why should one do this? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153584] Form fields invisible on printing in Writer when in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153584 Dieter changed: What|Removed |Added Blocks||153239 Component|Writer |Printing and PDF export CC||dgp-m...@gmx.de Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153239 [Bug 153239] Accept english terms for functions in the non-english versions, too -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153239] Accept english terms for functions in the non-english versions, too
https://bugs.documentfoundation.org/show_bug.cgi?id=153239 Dieter changed: What|Removed |Added Depends on||153584 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153584 [Bug 153584] Form fields invisible on printing in Writer when in dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 99bb5a7843469a0c8a23215a2a72bb34a3c47d0d Author: Adolfo Jayme Barrientos AuthorDate: Mon Feb 27 00:53:20 2023 -0600 Commit: Gerrit Code Review CommitDate: Mon Feb 27 06:53:20 2023 + Update git submodules * Update helpcontent2 from branch 'master' to a2868f03eda97185d96cf661624e3c8668876294 - This sentence is missing a subject Change-Id: I2eb66e5ced49809b86a3cdb48103381646b965a2 diff --git a/helpcontent2 b/helpcontent2 index 976284c63182..a2868f03eda9 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 976284c63182811da8da66144f22ff0502c880df +Subproject commit a2868f03eda97185d96cf661624e3c8668876294
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0211.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a2868f03eda97185d96cf661624e3c8668876294 Author: Adolfo Jayme Barrientos AuthorDate: Mon Feb 27 00:52:55 2023 -0600 Commit: Adolfo Jayme Barrientos CommitDate: Mon Feb 27 00:53:08 2023 -0600 This sentence is missing a subject Change-Id: I2eb66e5ced49809b86a3cdb48103381646b965a2 diff --git a/source/text/shared/01/0211.xhp b/source/text/shared/01/0211.xhp index 427b4e6d06..bd78472198 100644 --- a/source/text/shared/01/0211.xhp +++ b/source/text/shared/01/0211.xhp @@ -122,7 +122,7 @@ When entered in the Find text box, finds a line break that was inserted with the Shift+Enter key combination in Writer, or the Ctrl+Enter key combination in a Calc cell. -When entered in the Replace text box in Writer, inserts a paragraph break that can be inserted with the Enter or Return key. Has no special meaning in Calc, and is treated literally there. +When entered in the Replace text box in Writer, inserts a paragraph break that can be inserted with the Enter or Return key. It has no special meaning in Calc, and is treated literally there. To change line breaks into paragraph breaks in Writer, enter \n in both the Find and Replace boxes, and then perform a search and replace.
[Libreoffice-bugs] [Bug 152775] [Enhancement] Emphasize the entry the mouse pointer is over in the Writer Navigator content tree
https://bugs.documentfoundation.org/show_bug.cgi?id=152775 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #5 from Buovjaga --- (In reply to Heiko Tietze from comment #4) > The color inversion works well in all cases. But it feels obtrusive to me > when the black font on white background switches to white on black. Would be > better to just "shade" the background. This is about making the item text bold in the Navigator, not about highlighting the element in the document canvas. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 152775] [Enhancement] Emphasize the entry the mouse pointer is over in the Writer Navigator content tree
https://bugs.documentfoundation.org/show_bug.cgi?id=152775 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #5 from Buovjaga --- (In reply to Heiko Tietze from comment #4) > The color inversion works well in all cases. But it feels obtrusive to me > when the black font on white background switches to white on black. Would be > better to just "shade" the background. This is about making the item text bold in the Navigator, not about highlighting the element in the document canvas. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 82637d7cba204eea626af8b76f67a389001bc680 Author: Sophia Schröder AuthorDate: Mon Feb 27 06:43:46 2023 + Commit: Gerrit Code Review CommitDate: Mon Feb 27 06:43:46 2023 + Update git submodules * Update helpcontent2 from branch 'master' to 976284c63182811da8da66144f22ff0502c880df - Impress: Rework of help files (main 01) Change-Id: I8daa90ed8b82d3b8775a613c47491f69f7be575a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147700 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 19fc47601970..976284c63182 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 19fc476019704c84f0a4aad9846b2dac579d19a3 +Subproject commit 976284c63182811da8da66144f22ff0502c880df
[Libreoffice-commits] help.git: source/text
source/text/simpress/main.xhp | 45 ++ 1 file changed, 22 insertions(+), 23 deletions(-) New commits: commit 976284c63182811da8da66144f22ff0502c880df Author: Sophia Schröder AuthorDate: Sat Feb 25 17:00:35 2023 + Commit: Adolfo Jayme Barrientos CommitDate: Mon Feb 27 06:43:46 2023 + Impress: Rework of help files (main 01) Change-Id: I8daa90ed8b82d3b8775a613c47491f69f7be575a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147700 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/simpress/main.xhp b/source/text/simpress/main.xhp index fa069665ec..c2d6b921ea 100644 --- a/source/text/simpress/main.xhp +++ b/source/text/simpress/main.xhp @@ -1,5 +1,5 @@ - + +--> - - -Welcome to the $[officename] Impress Help -/text/simpress/main.xhp - - -Sun Microsystems, Inc. - + +Welcome to the $[officename] Impress Help +/text/simpress/main.xhp + + +Sun Microsystems, Inc. + -Welcome to the $[officename] Impress Help - -How to Work With $[officename] Impress - - - - -$[officename] Impress Menus, Toolbars, and Keys - - - - +Welcome to the $[officename] Impress Help + +How to Work With $[officename] Impress + + + + +$[officename] Impress Menus, Toolbars, and Keys + + + + - + \ No newline at end of file
[Libreoffice-bugs] [Bug 153846] Dead extensions need to be purged.
https://bugs.documentfoundation.org/show_bug.cgi?id=153846 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |MOVED CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #1 from Buovjaga --- Web stuff belongs to Redmine: https://redmine.documentfoundation.org/projects/infrastructure/issues https://wiki.documentfoundation.org/QA/BugReport#Not_all_bugs_go_to_Bugzilla -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - basic/Library_sb.mk
basic/Library_sb.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4e5d0e93ea571ca10b0d920170b7bb9f3179756b Author: Tor Lillqvist AuthorDate: Wed Feb 22 14:22:15 2023 +0200 Commit: Tor Lillqvist CommitDate: Mon Feb 27 06:30:59 2023 + Fix --disable-scripting build (for example for WASM) Was broken by ccd0ef98f76011f108f8ea1d282b96386dba0a6a. Change-Id: I37f3cf14e14ca32919d54f3d0cddbc042c2a7056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147463 Tested-by: Jenkins Reviewed-by: Tor Lillqvist Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147749 Tested-by: Tor Lillqvist diff --git a/basic/Library_sb.mk b/basic/Library_sb.mk index 28effaaae0e1..f640e366a50c 100644 --- a/basic/Library_sb.mk +++ b/basic/Library_sb.mk @@ -71,7 +71,6 @@ $(eval $(call gb_Library_add_exception_objects,sb,\ basic/source/classes/sb \ basic/source/classes/sbunoobj \ basic/source/classes/sbxmod \ - basic/source/comp/basiccharclass \ basic/source/comp/buffer \ basic/source/comp/codegen \ basic/source/comp/dim \ @@ -107,6 +106,7 @@ $(eval $(call gb_Library_add_exception_objects,sb,\ basic/source/runtime/methods \ basic/source/runtime/methods1 \ basic/source/classes/sbintern \ + basic/source/comp/basiccharclass \ basic/source/sbx/sbxarray \ basic/source/sbx/sbxbool \ basic/source/sbx/sbxbyte \
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #6 from nouvel.aubergi...@gmail.com --- v737 is still the only available version in the Linux Mint/Ubuntu repository. v750 was downloaded 2 hours ago from LibreOffice's link to their FRENCH download site. But, the webpage is in English, the instructions are English, AND the software is in English, until the user applies the French language and French Help Packages. Who are the users you are packaging this software for? These further add to the users' confusion. I am speaking on behalf of my French speaking audience. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153751] Consistent naming of chapter, heading, outline, and level
https://bugs.documentfoundation.org/show_bug.cgi?id=153751 Adolfo Jayme Barrientos changed: What|Removed |Added CC||fit...@ubuntu.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103370] [META] Heading Numbering bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103370 Adolfo Jayme Barrientos changed: What|Removed |Added Summary|[META] Outline/Chapter |[META] Heading Numbering |numbering bugs and |bugs and enhancements |enhancements| Alias|Chapter-Numbering |Heading-Numbering -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #5 from nouvel.aubergi...@gmail.com --- Created attachment 185599 --> https://bugs.documentfoundation.org/attachment.cgi?id=185599=edit page_style_showing_the_default_paper_format -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #4 from nouvel.aubergi...@gmail.com --- Created attachment 185598 --> https://bugs.documentfoundation.org/attachment.cgi?id=185598=edit image of libreoffice 7.5.0 version shows the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153837] Regional settings for French Canada standards are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=153837 --- Comment #3 from nouvel.aubergi...@gmail.com --- Created attachment 185597 --> https://bugs.documentfoundation.org/attachment.cgi?id=185597=edit image of libreoffice 7.3.7 version shows the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/source desktop/source include/unotools sc/source unotools/source
cui/source/inc/autocdlg.hxx |6 ++--
cui/source/tabpages/autocdlg.cxx| 30 ++--
desktop/source/deployment/gui/dp_gui_extlistbox.cxx | 10 +++---
desktop/source/deployment/gui/dp_gui_extlistbox.hxx |3 +-
include/unotools/intlwrapper.hxx| 15 +-
sc/source/ui/dbgui/tpsort.cxx |6 ++--
sc/source/ui/inc/tpsort.hxx |2 -
unotools/source/i18n/intlwrapper.cxx|9 ++
8 files changed, 41 insertions(+), 40 deletions(-)
New commits:
commit 09680fadbcd85da3405cefeed66712bc0ba2be9c
Author: Noel Grandin
AuthorDate: Sun Feb 26 20:37:34 2023 +0200
Commit: Noel Grandin
CommitDate: Mon Feb 27 05:43:11 2023 +
no need to hold CollatorWrapper by std::unique_ptr
allocate it inline, it is only one pointer in size
Change-Id: Idb6217e6c9c37da92427aa6c497223a84015c553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147742
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx
index a1a6146fa1bb..8e31011e7a33 100644
--- a/cui/source/inc/autocdlg.hxx
+++ b/cui/source/inc/autocdlg.hxx
@@ -20,13 +20,13 @@
#include
#include
+#include
#include
#include
#include
class CharClass;
-class CollatorWrapper;
class SmartTagMgr;
namespace editeng { class SortedAutoCompleteStrings; }
@@ -166,7 +166,7 @@ private:
std::set aFormatText;
std::map
aDoubleStringTable;
-std::unique_ptr pCompareClass;
+std::optional moCompareClass;
std::unique_ptrpCharClass;
LanguageTypeeLang;
@@ -227,7 +227,7 @@ class OfaAutocorrExceptPage : public SfxTabPage
{
private:
StringsTableaStringsTable;
-std::unique_ptr pCompareClass;
+std::optional moCompareClass;
LanguageTypeeLang;
std::unique_ptr m_xAbbrevED;
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index bc3f3bcc7be7..21716d43a1a9 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -696,8 +696,8 @@
OfaAutocorrReplacePage::OfaAutocorrReplacePage(weld::Container* pPage, weld::Dia
bSWriter = pMod == SfxModule::GetActiveModule();
LanguageTag aLanguageTag( eLastDialogLanguage );
-pCompareClass.reset( new CollatorWrapper(
comphelper::getProcessComponentContext() ) );
-pCompareClass->loadDefaultCollator( aLanguageTag.getLocale(), 0 );
+moCompareClass.emplace( comphelper::getProcessComponentContext() );
+moCompareClass->loadDefaultCollator( aLanguageTag.getLocale(), 0 );
pCharClass.reset( new CharClass( std::move(aLanguageTag) ) );
auto nColWidth = m_xReplaceTLB->get_approximate_digit_width() * 32;
@@ -720,7 +720,7 @@ OfaAutocorrReplacePage::~OfaAutocorrReplacePage()
aDoubleStringTable.clear();
aChangesTable.clear();
-pCompareClass.reset();
+moCompareClass.reset();
pCharClass.reset();
}
@@ -902,8 +902,8 @@ void OfaAutocorrReplacePage::SetLanguage(LanguageType eSet)
eLastDialogLanguage = eSet;
LanguageTag aLanguageTag( eLastDialogLanguage );
-pCompareClass.reset( new CollatorWrapper(
comphelper::getProcessComponentContext() ) );
-pCompareClass->loadDefaultCollator( aLanguageTag.getLocale(), 0 );
+moCompareClass.emplace( comphelper::getProcessComponentContext() );
+moCompareClass->loadDefaultCollator( aLanguageTag.getLocale(), 0 );
pCharClass.reset( new CharClass( std::move(aLanguageTag) ) );
ModifyHdl(*m_xShortED);
}
@@ -917,7 +917,7 @@ IMPL_LINK(OfaAutocorrReplacePage, SelectHdl,
weld::TreeView&, rBox, void)
OUString sTmpShort(rBox.get_text(nEntry, 0));
// if the text is set via ModifyHdl, the cursor is always at the
beginning
// of a word, although you're editing here
-bool bSameContent = 0 == pCompareClass->compareString(sTmpShort,
m_xShortED->get_text());
+bool bSameContent = 0 == moCompareClass->compareString(sTmpShort,
m_xShortED->get_text());
int nStartPos, nEndPos;
m_xShortED->get_selection_bounds(nStartPos, nEndPos);
if (m_xShortED->get_text() != sTmpShort)
@@ -1055,7 +1055,7 @@ bool OfaAutocorrReplacePage::NewDelHdl(const
weld::Widget* pBtn)
int nCount = m_xReplaceTLB->n_children();
for (j = 0; j < nCount; ++j)
{
-if (0 >= pCompareClass->compareString(sEntry,
m_xReplaceTLB->get_text(j, 0)))
+if (0 >= moCompareClass->compareString(sEntry,
m_xReplaceTLB->get_text(j, 0)))
break;
}
nPos = j;
@@ -1108,7 +1108,7 @@ IMPL_LINK(OfaAutocorrReplacePage, ModifyHdl,
weld::Entry&, rEdt, void)
, ,
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 44a3085f9aaf0dfc62b1a8f34d3b8889d69c4e62 Author: Mike Kaganski AuthorDate: Mon Feb 27 04:43:26 2023 + Commit: Gerrit Code Review CommitDate: Mon Feb 27 04:43:26 2023 + Update git submodules * Update helpcontent2 from branch 'master' to 19fc476019704c84f0a4aad9846b2dac579d19a3 - Clarify that it's "character key" See e.g. https://ask.libreoffice.org/t/88505, where people expect capital letter in mnemonics to mean "exactly capital", i.e. with Shift. Change-Id: Id42c3aeaad6d04a4df58780f5ce5aca71532366b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147835 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/helpcontent2 b/helpcontent2 index 22b85af46f3e..19fc47601970 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 22b85af46f3eacc6abd45be4e78d13079851e55c +Subproject commit 19fc476019704c84f0a4aad9846b2dac579d19a3
[Libreoffice-commits] help.git: source/text
source/text/shared/04/0101.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 19fc476019704c84f0a4aad9846b2dac579d19a3 Author: Mike Kaganski AuthorDate: Mon Feb 27 04:39:11 2023 + Commit: Mike Kaganski CommitDate: Mon Feb 27 04:43:25 2023 + Clarify that it's "character key" See e.g. https://ask.libreoffice.org/t/88505, where people expect capital letter in mnemonics to mean "exactly capital", i.e. with Shift. Change-Id: Id42c3aeaad6d04a4df58780f5ce5aca71532366b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147835 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/source/text/shared/04/0101.xhp b/source/text/shared/04/0101.xhp index ea1b10d9ab..6ce842fd24 100644 --- a/source/text/shared/04/0101.xhp +++ b/source/text/shared/04/0101.xhp @@ -49,7 +49,7 @@ Calling Menus with Mnemonics - Some of the characters shown on the menu bar are underlined. You can access these menus directly by pressing the underlined character together with the Alt key. Once the menu is opened, you will again find underlined characters. You can access these menu items directly by simply pressing the underlined character key. + Some of the characters shown on the menu bar are underlined. You can access these menus directly by pressing the underlined character key together with the Alt key. Once the menu is opened, you will again find underlined characters. You can access these menu items directly by simply pressing the underlined character key.
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Bug 117497 depends on bug 152595, which changed state. Bug 152595 Summary: Icon Theme: Colibre: Update Start Center application icons to match new icons https://bugs.documentfoundation.org/show_bug.cgi?id=152595 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148747] Bad use of the date in formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=148747 --- Comment #20 from ady --- I admit I don't know (or rather, understand) what's the problem or how to trigger it, so IDK why this is set to "new". I'm not saying it shouldn't; I'm just saying I don't understand it. To put it bluntly (if I may, with no bad intention really), as it is at this moment, there is no way whatever the heck is happening here will be fixed. * The steps to reproduce are not clear (in no comment until now). * There is no clear indication on which specific cell (range) we should look at in order to identify what is that seems to be wrong (and I tried, again, with different LO versions). * The cell formats are inconsistent. Some are D.M., some are standard numeric values, and some are text (such as "BD:BO" mentioned before). * There is a mix of formulas, using text-related functions to compare date-formatted cells against numbers or text-formatted cells. * The sample files are not trimmed in order to show the main problem; a lot of unnecessary "noise", with a lot of unrelated cells, unrelated sheets, unrelated formulas, and non-English characters that are unnecessary in this context – is it so hard to use "sheet1" for a sample file? * The posts here are not in English. If I can use a web-based translator, I think others could too. * Is there any post at ask.libreoffice.org in whichever language, related to this issue? Please don't take these comments as complaints, but rather as suggestions, in order to get whatever is wrong to be fixed at some point. I guess I am saying that some simplification and clarity would be welcome, in order for some developer to be able to do something, and so this can be replicated by someone else, whether now or if/when a patch is proposed in the future. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Adolfo Jayme Barrientos changed: What|Removed |Added Depends on|153695 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153695 [Bug 153695] New 7.5 icons in Colibre theme -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103184 Adolfo Jayme Barrientos changed: What|Removed |Added Depends on|153695 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153695 [Bug 153695] New 7.5 icons in Colibre theme -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153722] Rename "chapter style" category into "Document Structure" and add headings
https://bugs.documentfoundation.org/show_bug.cgi?id=153722 --- Comment #6 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/22b85af46f3eacc6abd45be4e78d13079851e55c tdf#153722 "Chapter Styles" -> "Document Structure" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 85e86bc9c50eae4831286c467c6a583a5f9caf28 Author: Seth Chaiklin AuthorDate: Mon Feb 27 04:03:13 2023 + Commit: Gerrit Code Review CommitDate: Mon Feb 27 04:03:13 2023 + Update git submodules * Update helpcontent2 from branch 'master' to 22b85af46f3eacc6abd45be4e78d13079851e55c - tdf#153722 "Chapter Styles" -> "Document Structure" Change-Id: I722631402b093ee29174e4ed029f543525f46951 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147596 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index afa78ade6514..22b85af46f3e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit afa78ade65147468ca4f0b4ad168c4288e8a79b2 +Subproject commit 22b85af46f3eacc6abd45be4e78d13079851e55c
[Libreoffice-commits] help.git: source/text
source/text/swriter/01/0513.xhp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 22b85af46f3eacc6abd45be4e78d13079851e55c Author: Seth Chaiklin AuthorDate: Fri Feb 24 02:41:44 2023 + Commit: Adolfo Jayme Barrientos CommitDate: Mon Feb 27 04:03:13 2023 + tdf#153722 "Chapter Styles" -> "Document Structure" Change-Id: I722631402b093ee29174e4ed029f543525f46951 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147596 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/swriter/01/0513.xhp b/source/text/swriter/01/0513.xhp index cedab8b2ff..b31c7461cd 100644 --- a/source/text/swriter/01/0513.xhp +++ b/source/text/swriter/01/0513.xhp @@ -149,10 +149,10 @@ -Chapter Styles +Document Structure -Displays formatting styles for headings. +Displays formatting styles for structuring documents.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - cui/source
cui/source/dialogs/FontFeaturesDialog.cxx | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
New commits:
commit 4b53ed912331e457722cf51cf3fe034d784de172
Author: خالد حسني
AuthorDate: Sun Feb 26 18:14:29 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Mon Feb 27 04:01:09 2023 +
Revert "Mark ssXX and cvXX off by default in font features dialog"
This reverts commit 3f9a8a3b7656470cfcf04c18a46a7b7bbeca8950.
Reason for revert: Needs more work, currently causes all ssXX and cvXX to
be added to font string when the dialog is used.
Change-Id: I07eff710a2813e60fa4de3c23eb0a3c31d40e41d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147811
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/cui/source/dialogs/FontFeaturesDialog.cxx
b/cui/source/dialogs/FontFeaturesDialog.cxx
index f4f53f8c8655..ab6063c9b6c3 100644
--- a/cui/source/dialogs/FontFeaturesDialog.cxx
+++ b/cui/source/dialogs/FontFeaturesDialog.cxx
@@ -158,15 +158,7 @@ int
FontFeaturesDialog::fillGrid(std::vector const& rFontFea
else
{
if (nValue < 0)
-{
-// If feature is not set, we don’t know if it is enabled by
-// default or not. But we know that stylistic sets and
-// character variants are not enabled by default.
-if (rFontFeature.isStylisticSet() ||
rFontFeature.isCharacterVariant())
-aCurrentItem.m_xCheck->set_state(TRISTATE_FALSE);
-else
-aCurrentItem.m_xCheck->set_state(TRISTATE_INDET);
-}
+aCurrentItem.m_xCheck->set_state(TRISTATE_INDET);
else
aCurrentItem.m_xCheck->set_state(nValue > 0 ? TRISTATE_TRUE :
TRISTATE_FALSE);
aCurrentItem.m_xCheck->set_label(aDefinition.getDescription());
[Libreoffice-bugs] [Bug 150646] Unable to change font color in spreadsheet cells
https://bugs.documentfoundation.org/show_bug.cgi?id=150646 --- Comment #4 from ady --- Menu Tools > Options > LiberOffice > View > Use automatic font color for screen display A_ Set off / unchecked > font color is seen OK. B_ Set on / checked > font color gets back to be seen as black, as described by OP. This is not the first time, and it won't be the last one either. This setting is not understood and not well-known, so users think the resulting behavior is a bug. Unless something is done somewhere, this kind of reports will keep happening, and worse, users will keep thinking that LO Calc doesn't work in one of the most basic features. I guess the only thing to do here is to wait for John Mildfelt's confirmation, and then NAB. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151809] UI: Top level menu of Tabbed Toolbar isn't positioned well on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=151809 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153553] Make the installation easier by omitting unnecessary checks for standard program and restart
https://bugs.documentfoundation.org/show_bug.cgi?id=153553 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153563] 7.5.0.3 sometimes opens a document in tens of seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=153563 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153841] LibreOffice 7.5.1.2 Linux ignores Light view command
https://bugs.documentfoundation.org/show_bug.cgi?id=153841 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153823] When pressing F1 or clicking Help, Balena Etcher is invoked.
https://bugs.documentfoundation.org/show_bug.cgi?id=153823 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153823] When pressing F1 or clicking Help, Balena Etcher is invoked.
https://bugs.documentfoundation.org/show_bug.cgi?id=153823 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147786] Some circles do not print adequatly
https://bugs.documentfoundation.org/show_bug.cgi?id=147786 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147786] Some circles do not print adequatly
https://bugs.documentfoundation.org/show_bug.cgi?id=147786 --- Comment #6 from QA Administrators --- Dear b.dusoulier, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144361] Image filter not found
https://bugs.documentfoundation.org/show_bug.cgi?id=144361 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150705] Paste contents in Draw looses accents
https://bugs.documentfoundation.org/show_bug.cgi?id=150705 --- Comment #3 from QA Administrators --- Dear Olivier Hallot, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144361] Image filter not found
https://bugs.documentfoundation.org/show_bug.cgi?id=144361 --- Comment #10 from QA Administrators --- Dear hollnagel.erik, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150646] Unable to change font color in spreadsheet cells
https://bugs.documentfoundation.org/show_bug.cgi?id=150646 --- Comment #3 from QA Administrators --- Dear John Mildfelt, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147560] Writer Crashes with multi page documents using numbering outline (different headings) and inserted pictures.
https://bugs.documentfoundation.org/show_bug.cgi?id=147560 --- Comment #6 from QA Administrators --- Dear JCook, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149751] Libreoffice freeze at first startup in Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=149751 --- Comment #10 from QA Administrators --- Dear siapec, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141583] Rotary switch for side margin setting not accessible
https://bugs.documentfoundation.org/show_bug.cgi?id=141583 --- Comment #3 from QA Administrators --- Dear juergenkohler23, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141167] NVDA does not announce the entries in the "Labels" dialogue box
https://bugs.documentfoundation.org/show_bug.cgi?id=141167 --- Comment #3 from QA Administrators --- Dear Peter Franke, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96230] Data points on charts show wrong value when x-axis is reversed
https://bugs.documentfoundation.org/show_bug.cgi?id=96230 --- Comment #6 from QA Administrators --- Dear justreportingabug, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91732] FILEOPEN: Doc layered objects mis-formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=91732 --- Comment #6 from QA Administrators --- Dear Matthew Millar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 49848] FILEOPEN: Worse-than Linear Performance Degradation Opening Change-Tracked ODTs
https://bugs.documentfoundation.org/show_bug.cgi?id=49848 --- Comment #8 from QA Administrators --- Dear orcmid, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140216] Text breaks differently across pages while editing compared to save & reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=140216 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140035] Check Spelling: special characters do not appear immediately when OK is pressed
https://bugs.documentfoundation.org/show_bug.cgi?id=140035 --- Comment #3 from QA Administrators --- Dear R. Green, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132230] Direct internal links to specific slides are not working in Impress when exporting to PDF unless the slide is renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=132230 --- Comment #3 from QA Administrators --- Dear William Gathoye, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122746] OLE activating works in edit mode but not in show mode
https://bugs.documentfoundation.org/show_bug.cgi?id=122746 --- Comment #4 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118183] FILEOPEN: bad text position rendering in table
https://bugs.documentfoundation.org/show_bug.cgi?id=118183 --- Comment #10 from QA Administrators --- Dear Marina Latini (SUSE), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113505] Performance of Calc Chart auto updating could be better
https://bugs.documentfoundation.org/show_bug.cgi?id=113505 --- Comment #6 from QA Administrators --- Dear perie_gut, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153823] When pressing F1 or clicking Help, Balena Etcher is invoked.
https://bugs.documentfoundation.org/show_bug.cgi?id=153823 --- Comment #2 from zoom...@gmx.com --- I used apt to install Etcher. I may have also used AppImage but not sure. The problem remains. Using Ubuntu 22.04.2 and Gnome. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/wasm' - 467 commits - android/Bootstrap android/default-document android/source basctl/sdi basctl/source basctl/uiconfig basegfx/source basegfx/test bas
Rebased ref, commits from common ancestor:
commit c75b2386c2340f5e2be9126f23cbf46c2d24a79d
Author: Thorsten Behrens
AuthorDate: Tue Feb 14 18:13:37 2023 +0100
Commit: Thorsten Behrens
CommitDate: Mon Feb 27 01:18:58 2023 +0100
Another tweak in sample file imagery
Change-Id: I28ec7ebea974a17c6e0d48e680e0a3883c44fc10
diff --git a/android/default-document/example_larger.odt
b/android/default-document/example_larger.odt
index f49d3f868223..aea3816c2646 100644
Binary files a/android/default-document/example_larger.odt and
b/android/default-document/example_larger.odt differ
commit 51444202638ea4b93570fcbd374ff210d9b6f2e0
Author: Thorsten Behrens
AuthorDate: Tue Feb 14 15:31:08 2023 +0100
Commit: Thorsten Behrens
CommitDate: Mon Feb 27 01:18:58 2023 +0100
Update sample file
Change-Id: I5be3916601930bd9968a40e55c51320e99098d6e
diff --git a/android/default-document/example_larger.odt
b/android/default-document/example_larger.odt
index 1b3a1dfb877a..f49d3f868223 100644
Binary files a/android/default-document/example_larger.odt and
b/android/default-document/example_larger.odt differ
commit b9462bc2f1109bc23e423221f2fe2bfbf75b8e9b
Author: Balazs Varga
AuthorDate: Mon Jan 16 11:10:00 2023 +0100
Commit: Thorsten Behrens
CommitDate: Mon Feb 27 01:18:58 2023 +0100
WASM: headless conversion without QT5 and with unique html
Building and using soffice.html generated by emscripten and modified for
headless conversion.
Change-Id: Ic3800bc0632d241dce382f244f355f56f79ffec4
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index e3a5b4a022f1..f16b60ecd5e7 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -45,6 +45,13 @@
#include
#include
+#ifdef EMSCRIPTEN
+#include
+#include
+#include
+#include
+#endif
+
namespace weld {class Button; }
class SbxValue;
class SbxArray;
@@ -435,6 +442,10 @@ public:
virtual boolPrepareClose(bool bUI = true);
virtual HiddenInformation GetHiddenInformationState( HiddenInformation
nStates );
sal_Int16 QueryHiddenInformation( HiddenWarningFact
eFact, weld::Window* pParent );
+#ifdef EMSCRIPTEN
+voidReadWASMFile(emscripten::val& contentArray,
sal_Int32 nRead, css::uno::Sequence& aContent);
+voidWriteWASMFile(emscripten::val& contentArray,
const OUString& rFileName);
+#endif
boolIsSecurityOptOpenReadOnly() const;
voidSetSecurityOptOpenReadOnly( bool bOpenReadOnly
);
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 2cc7c3c932f0..da31ea329947 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -3005,6 +3005,37 @@ bool SfxObjectShell::PreDoSaveAs_Impl(const OUString&
rFileName, const OUString&
if( bOk )
{
+#ifdef EMSCRIPTEN
+if (aFilterName.endsWith("pdf_Export"))
+{
+try
+{
+sal_Int32 nRead;
+Reference aTempInput =
pNewFile->GetInputStream();
+sal_Int32 nBufferSize = 32767;
+Sequence aSequence(nBufferSize);
+emscripten::val contentArray = emscripten::val::array();
+do
+{
+nRead = aTempInput->readBytes(aSequence, nBufferSize);
+if (nRead < nBufferSize)
+{
+Sequence
aTempBuf(aSequence.getConstArray(), nRead);
+ReadWASMFile(contentArray, nRead, aTempBuf);
+}
+else
+{
+ReadWASMFile(contentArray, nRead, aSequence);
+}
+} while (nRead == nBufferSize);
+WriteWASMFile(contentArray, pNewFile->GetName());
+}
+catch (const Exception&)
+{
+}
+}
+#endif
+
if( !bCopyTo )
SetModified( false );
}
@@ -3050,6 +3081,40 @@ bool SfxObjectShell::PreDoSaveAs_Impl(const OUString&
rFileName, const OUString&
}
+#ifdef EMSCRIPTEN
+void SfxObjectShell::ReadWASMFile(emscripten::val& contentArray, sal_Int32
nRead, css::uno::Sequence& aContent)
+{
+emscripten::val fileContentView =
emscripten::val(emscripten::typed_memory_view(
+nRead,
+reinterpret_cast(aContent.getConstArray(;
+emscripten::val fileContentCopy =
emscripten::val::global("ArrayBuffer").new_(nRead);
+emscripten::val fileContentCopyView =
emscripten::val::global("Uint8Array").new_(fileContentCopy);
+fileContentCopyView.call("set", fileContentView);
+contentArray.call("push", fileContentCopyView);
+}
+void SfxObjectShell::WriteWASMFile(emscripten::val&
[Libreoffice-bugs] [Bug 153669] Formula stops working after copy and paste onto a different cell
https://bugs.documentfoundation.org/show_bug.cgi?id=153669 --- Comment #6 from Kohei Yoshida --- I'm looking into it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153769] error playing animations and transitions in libreoffice impress
https://bugs.documentfoundation.org/show_bug.cgi?id=153769 Michael FA changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148601] Missing scrollbars in menus (interface bug since 7.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=148601 Michael FA changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151063] Rename "Index marks" to "Index entries" (if the latter is correct)
https://bugs.documentfoundation.org/show_bug.cgi?id=151063 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #8 from sdc.bla...@youmail.dk --- Good catch Tuomas! 1. I think "Index Marks" should be changed to "Index Entries" in the Type tab (because it uses the results of the "Insert Index Entry" dialog). (even if Index Marks are involved, there is no reason/need for users to know the technical terminology used in the implementation.) 2. Proposal for tooltip (to be added) and extended tip (to be revised) for checkbox on Type tab. Tooltip: Choose this option to include any index entries inserted in the document for the selected index Type. Extended tip: Choose this option to include any index entries inserted in the document for the selected index Type. Use Insert > Table of Contents and Index > Index Entry to insert index entries in the document. Comment: have added "for the selected index Type", because this is also relevant. 3. Could only find one place in online help where "index mark" is mentioned. "To add an index mark to similar words in your document, select Apply to all similar texts." [1] Change to: To add index entries for all other occurrences of the selected entry text, select Apply to all similar texts. [side comment:] "similar" seems wrong/misleading for the command label, because it implies a "similarity" search. Perhaps that label should be: "Apply to all other occurrences" 4. "Index mark" is only mentioned in WG 7.3 to refer to this option label. 5. "Index mark" is not found in UI (including tooltips/extended tips). 6. There are three .unos that refer to Index Marks. (two for navigator forward, backward to index marks, and one (.uno:IndexMarkToIndex) which suggests that it is relevant to indexes, but have not figured out what it does exactly (in part because of sporadic crashes when used). None of these .unos seem to be included in any toolbar, menubar, contextmenu. 7. There are also two Insert Entry .unos, both of which appear in toolbars, menubars, popup menus. (side comment: see bug 153847) In sum: preponderance of evidence leans strongly to using "Index Entries" [1] https://help.libreoffice.org/7.6/en-US/text/swriter/guide/indices_enter.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153847] Change label for .uno:InsertIndexesEntry and label and tooltip for .uno:IndexEntryDialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153847 --- Comment #1 from sdc.bla...@youmail.dk --- Probably .uno:InsertIndexesEntry also needs: ContextLabel: Insert Entry -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source vcl/unx
vcl/source/fontsubset/sft.cxx | 38 ++--
vcl/unx/generic/fontmanager/fontmanager.cxx | 33
2 files changed, 31 insertions(+), 40 deletions(-)
New commits:
commit 03f58d6af52bab05545833980cca835a3df0949a
Author: Caolán McNamara
AuthorDate: Sun Feb 26 16:03:37 2023 +
Commit: Caolán McNamara
CommitDate: Sun Feb 26 23:29:17 2023 +
cid#1521198 Untrusted loop bound
move sanity check inside CountTTCFonts so it applies
to the fd smuggle in via filename mechanism
Change-Id: Id2fee5801d71720747a8736859681e7c9a324bc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147740
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 6644946699a4..549507121962 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -1073,8 +1073,6 @@ static void GetNames(AbstractTrueTypeFont *t)
int CountTTCFonts(const char* fname)
{
-int nFonts = 0;
-sal_uInt8 buffer[12];
FILE* fd;
#ifdef LINUX
int nFD;
@@ -1088,13 +1086,39 @@ int CountTTCFonts(const char* fname)
else
#endif
fd = fopen(fname, "rb");
-if( fd ) {
-if (fread(buffer, 1, 12, fd) == 12) {
-if(GetUInt32(buffer, 0) == T_ttcf )
-nFonts = GetUInt32(buffer, 8);
+
+if (!fd)
+return 0;
+
+int nFonts = 0;
+sal_uInt8 buffer[12];
+if (fread(buffer, 1, 12, fd) == 12) {
+if(GetUInt32(buffer, 0) == T_ttcf )
+nFonts = GetUInt32(buffer, 8);
+}
+
+if (nFonts > 0)
+{
+fseek(fd, 0, SEEK_END);
+sal_uInt64 fileSize = ftell(fd);
+
+//Feel free to calc the exact max possible number of fonts a file
+//could contain given its physical size. But this will clamp it to
+//a sane starting point
+//http://processingjs.nihongoresources.com/the_smallest_font/
+//https://github.com/grzegorzrolek/null-ttf
+const int nMaxFontsPossible = fileSize / 528;
+if (nFonts > nMaxFontsPossible)
+{
+SAL_WARN("vcl.fonts", "font file " << fname <<" claims to have "
+ << nFonts << " fonts, but only "
+ << nMaxFontsPossible << " are possible");
+nFonts = nMaxFontsPossible;
}
-fclose(fd);
}
+
+fclose(fd);
+
return nFonts;
}
diff --git a/vcl/unx/generic/fontmanager/fontmanager.cxx
b/vcl/unx/generic/fontmanager/fontmanager.cxx
index 0d48a692e97e..e9e2907091f9 100644
--- a/vcl/unx/generic/fontmanager/fontmanager.cxx
+++ b/vcl/unx/generic/fontmanager/fontmanager.cxx
@@ -179,14 +179,12 @@ std::vector
PrintFontManager::analyzeFontFile( int
OString aFullPath = aDir + "/" + rFontFile;
bool bSupported;
-bool bHack = false;
int nFD;
int n;
if (sscanf(aFullPath.getStr(), "/:FD:/%d%n", , ) == 1 &&
aFullPath.getStr()[n] == '\0')
{
// Hack, pathname that actually means we will use a pre-opened file
descriptor
bSupported = true;
-bHack = true;
}
else
{
@@ -220,37 +218,6 @@ std::vector
PrintFontManager::analyzeFontFile( int
{
SAL_INFO("vcl.fonts", "ttc: " << aFullPath << " contains " <<
nLength << " fonts");
-if (!bHack)
-{
-sal_uInt64 fileSize = 0;
-
-OUString aURL;
-if
(osl::File::getFileURLFromSystemPath(OStringToOUString(aFullPath,
osl_getThreadTextEncoding()),
-aURL) == osl::File::E_None)
-{
-osl::File aFile(aURL);
-if (aFile.open(osl_File_OpenFlag_Read |
osl_File_OpenFlag_NoLock) == osl::File::E_None)
-{
-osl::DirectoryItem aItem;
-if (osl::DirectoryItem::get(aURL, aItem) ==
osl::File::E_None)
-{
-osl::FileStatus aFileStatus(
osl_FileStatus_Mask_FileSize );
-if (aItem.getFileStatus(aFileStatus) ==
osl::File::E_None)
-fileSize = aFileStatus.getFileSize();
-}
-}
-}
-
-//Feel free to calc the exact max possible number of fonts a
file
-//could contain given its physical size. But this will clamp
it to
-//a sane starting point
-//http://processingjs.nihongoresources.com/the_smallest_font/
-//https://github.com/grzegorzrolek/null-ttf
-const int nMaxFontsPossible = fileSize / 528;
-if (nLength > nMaxFontsPossible)
-nLength = nMaxFontsPossible;
-}
-
for( int i = 0; i < nLength; i++ )
{
PrintFont aFont;
[Libreoffice-bugs] [Bug 153836] Spellcheck not working
https://bugs.documentfoundation.org/show_bug.cgi?id=153836 Telesto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEEDINFO|RESOLVED --- Comment #5 from Telesto --- *** This bug has been marked as a duplicate of bug 152738 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language
https://bugs.documentfoundation.org/show_bug.cgi?id=152738 Telesto changed: What|Removed |Added CC||abodro...@gmail.com --- Comment #18 from Telesto --- *** Bug 153836 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153847] New: Change label for .uno:InsertIndexesEntry and label and tooltip for .uno:IndexEntryDialog
https://bugs.documentfoundation.org/show_bug.cgi?id=153847 Bug ID: 153847 Summary: Change label for .uno:InsertIndexesEntry and label and tooltip for .uno:IndexEntryDialog Product: LibreOffice Version: 7.6.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Tools > Customize > Menus tab Search: Index Entry Actual: two "Index Entry" are shown. Suggestion/proposal: 1. For .uno:InsertIndexesEntry Label: Insert Entry Dialog 2. For .uno:IndexEntryDialog Label: Edit Index Entry Tooltip: Edit Index Entry -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113984] Content of a sub-table in another table is hidden by page footer when breaking across pages
https://bugs.documentfoundation.org/show_bug.cgi?id=113984 --- Comment #15 from Kieran Grant --- Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 32; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153573] Menus are all blank when opening .doc files
https://bugs.documentfoundation.org/show_bug.cgi?id=153573 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #6 from Stéphane Guillou (stragu) --- - Could you please provide a screenshot of the issue? - Please try version 7.4.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: jurt/source
jurt/source/pipe/staticsalhack.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 5a0ee146834fec1661051d1ad708bc3e96163af9
Author: Stephan Bergmann
AuthorDate: Sun Feb 26 21:20:33 2023 +0100
Commit: Stephan Bergmann
CommitDate: Sun Feb 26 22:07:57 2023 +
Fix Library_jpipe__staticsalhack
...after e7bad15bc13292defd99cb561f867d8b77692e97 "Unify
osl_{g,s}etThreadTextEncoding implementation across platforms" caused
> /etc/alternatives/java_sdk_11/bin/java: symbol lookup error:
/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libjpipe.so:
undefined symbol: osl_getThreadTextEncoding
(
[Libreoffice-bugs] [Bug 153568] User interface groupedBar partially destroyed after minimize
https://bugs.documentfoundation.org/show_bug.cgi?id=153568 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||stephane.guillou@libreoffic ||e.org --- Comment #4 from Stéphane Guillou (stragu) --- Thank you for your report, Helmut. As Stuart said, this has been reported in bug 153078 and should be fixed with the next release, 7.5.1. Please feel free to test and report back: https://www.libreoffice.org/download/download-libreoffice/?version=7.5.1 Do set this bug back to "unconfirmed" if the new version does not fix your issue. *** This bug has been marked as a duplicate of bug 153078 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153836] Spellcheck not working
https://bugs.documentfoundation.org/show_bug.cgi?id=153836 --- Comment #4 from Beth Metzler --- Yes, it worked. Thank you very much for the help. I appreciate it. -- You are receiving this mail because: You are the assignee for the bug.
