[Libreoffice-commits] core.git: Branch 'distro/vector/vector-7.5' - 2 commits - sw/qa sw/source
sw/qa/extras/htmlexport/data/sub_li_and_ctd.fodt | 33 sw/qa/extras/htmlexport/htmlexport.cxx | 34 + sw/source/filter/html/htmlatr.cxx|2 - sw/source/filter/html/htmlnum.cxx| 46 +++ sw/source/filter/html/htmlnum.hxx|6 +-- sw/source/filter/html/htmlnumwriter.cxx | 19 + sw/source/filter/html/htmltabw.cxx | 10 ++--- 7 files changed, 132 insertions(+), 18 deletions(-) New commits: commit d959d7399b574800e11260923817c1241fba6bd4 Author: Mike Kaganski AuthorDate: Thu May 18 15:56:46 2023 +0300 Commit: Mike Kaganski CommitDate: Thu May 18 18:57:15 2023 +0300 tdf#155387: fix list restart and opening/closing conditions 1. List restart flag in the node does not yet mean that the restart would actually happen: it will be ignored, if the next node is more nested than the previous one. 2. When writing nested list items, we should not write additional pairs for current level (previously, only level 0 was skipped); same for closing. Change-Id: I5f67e8fa9236e7e2e6dba2e0ec5dffbf0d7b7f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151958 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/qa/extras/htmlexport/data/sub_li_and_ctd.fodt b/sw/qa/extras/htmlexport/data/sub_li_and_ctd.fodt new file mode 100644 index ..b4a3977926c6 --- /dev/null +++ b/sw/qa/extras/htmlexport/data/sub_li_and_ctd.fodt @@ -0,0 +1,33 @@ + + + + + + + + l1 + l1_ctd1 + + + l2 + + + l2 + + + l1_ctd2 + + + + + l3 + + + + + l1_ctd3 + + + + + \ No newline at end of file diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx b/sw/qa/extras/htmlexport/htmlexport.cxx index 6834434bf3da..8c99342a46e3 100644 --- a/sw/qa/extras/htmlexport/htmlexport.cxx +++ b/sw/qa/extras/htmlexport/htmlexport.cxx @@ -2451,6 +2451,40 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testReqIfTransparentTifImg) CPPUNIT_ASSERT_EQUAL(GraphicFileFormat::TIF, aDescriptor.GetFileFormat()); } +CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testTdf155387) +{ +createSwDoc("sub_li_and_ctd.fodt"); +ExportToReqif(); + +SvMemoryStream aStream; +WrapReqifFromTempFile(aStream); +xmlDocUniquePtr pDoc = parseXmlStream(); +// Without the fix in place, this would fail +CPPUNIT_ASSERT(pDoc); + +// Single top-level list +assertXPath(pDoc, "/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ul"); +// Single top-level item +assertXPath(pDoc, "/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ul/reqif-xhtml:li"); +// 4 top-level paragraphs in the item +assertXPath(pDoc, + "/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ul/reqif-xhtml:li/reqif-xhtml:p", 4); +// 2 sublists in the item +assertXPath( +pDoc, "/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ul/reqif-xhtml:li/reqif-xhtml:ul", 2); +// 2 items in the first sublist +assertXPath(pDoc, + "/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ul/reqif-xhtml:li/reqif-xhtml:ul[1]/" +"reqif-xhtml:li", +2); +// Check the last (most nested) subitem's text +assertXPathContent( +pDoc, + "/reqif-xhtml:html/reqif-xhtml:div/reqif-xhtml:ul/reqif-xhtml:li/reqif-xhtml:ul[2]/" +"reqif-xhtml:li/reqif-xhtml:ul/reqif-xhtml:li/reqif-xhtml:p", +"l3"); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/filter/html/htmlatr.cxx b/sw/source/filter/html/htmlatr.cxx index 822718763e4d..95db5a76525a 100644 --- a/sw/source/filter/html/htmlatr.cxx +++ b/sw/source/filter/html/htmlatr.cxx @@ -982,7 +982,7 @@ static void OutHTML_SwFormatOff( Writer& rWrt, const SwHTMLTextCollOutputInfo& r const SwHTMLNumRuleInfo& rNRInfo = rHWrt.GetNumInfo(); if( rNextInfo.GetNumRule() != rNRInfo.GetNumRule() || rNextInfo.GetDepth() != rNRInfo.GetDepth() || -rNextInfo.IsNumbered() || rNextInfo.IsRestart() ) +rNextInfo.IsNumbered() || rNextInfo.IsRestart(rNRInfo) ) rHWrt.ChangeParaToken( HtmlTokenId::NONE ); OutHTML_NumberBulletListEnd( rHWrt, rNextInfo ); } diff --git a/sw/source/filter/html/htmlnum.cxx b/sw/source/filter/html/htmlnum.cxx index bd8317bb5676..8fa120a630cf 100644 --- a/sw/source/filter/html/htmlnum.cxx +++ b/sw/source/filter/html/htmlnum.cxx @@ -44,4 +44,50 @@ void SwHTMLNumRuleInfo::Set(const SwTextNode& rTextNd) } } +// Restart flag is only effective when this level is not below the previous +bool SwHTMLNumRuleInfo::IsRestart(const SwHTMLNumRuleInfo& rPrev) const +{ +// calling this, when the rules are different, makes no sense
[Libreoffice-commits] core.git: editeng/source include/editeng sw/source
editeng/source/misc/svxacorr.cxx | 12 include/editeng/svxacorr.hxx |2 +- sw/source/core/edit/edws.cxx |4 3 files changed, 13 insertions(+), 5 deletions(-) New commits: commit 971c9945825db02a4809538d26fff3ae77d16866 Author: Mike Kaganski AuthorDate: Thu May 18 20:06:21 2023 +0300 Commit: Mike Kaganski CommitDate: Fri May 19 07:08:46 2023 +0200 Fix "AddressSanitizer: heap-use-after-free" https://github.com/CollaboraOnline/online/issues/6380 Commit 7481e8b5500e86626be5f8eae1e7f48b7f51e21a (sw_redlinehide_4a: SwEditShell::AutoCorrect() etc., 2018-11-28) explicitly relied upon the reference to the node text being updated on editing operations. Commit 14f6700fefa945c4cf995c09af9326c2a022f886 (use more string_view in editeng, 2022-04-14) converted the argument of FnChgToEnEmDash to a string view, which means that any change in the underlying OUString frees the memory referenced by the view. But in this method, we really don't want to have the text updated; so use a local OUString copy for later reference. Partially revert commit 14f6700fefa945c4cf995c09af9326c2a022f886. And copy mst's commit 7481e8b5500e86626be5f8eae1e7f48b7f51e21a message to document the assumptions in SwEditShell::AutoCorrect. Change-Id: I0ff02958c8de9566d774f366d905aa9bb603055c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151970 Tested-by: Mike Kaganski Reviewed-by: Mike Kaganski diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index 6b759415b52b..dfb1e6c0d726 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -545,7 +545,7 @@ bool SvxAutoCorrect::FnChgOrdinalNumber( // Replace dashes bool SvxAutoCorrect::FnChgToEnEmDash( -SvxAutoCorrDoc& rDoc, std::u16string_view rTxt, +SvxAutoCorrDoc& rDoc, const OUString& rTxt, sal_Int32 nSttPos, sal_Int32 nEndPos, LanguageType eLang ) { @@ -555,6 +555,10 @@ bool SvxAutoCorrect::FnChgToEnEmDash( eLang = GetAppLang().getLanguageType(); bool bAlwaysUseEmDash = (eLang == LANGUAGE_RUSSIAN || eLang == LANGUAGE_UKRAINIAN); +// rTxt may refer to the frame text that will change in the calls to rDoc.Delete / rDoc.Insert; +// keep a local copy for later use +OUString aOrigTxt = rTxt; + // replace " - " or " --" with "enDash" if( 1 < nSttPos && 1 <= nEndPos - nSttPos ) { @@ -631,14 +635,14 @@ bool SvxAutoCorrect::FnChgToEnEmDash( bool bEnDash = (eLang == LANGUAGE_HUNGARIAN || eLang == LANGUAGE_FINNISH); if( 4 <= nEndPos - nSttPos ) { -OUString sTmp( rTxt.substr( nSttPos, nEndPos - nSttPos ) ); +OUString sTmp( aOrigTxt.subView( nSttPos, nEndPos - nSttPos ) ); sal_Int32 nFndPos = sTmp.indexOf("--"); if( nFndPos != -1 && nFndPos && nFndPos + 2 < sTmp.getLength() && ( rCC.isLetterNumeric( sTmp, nFndPos - 1 ) || - lcl_IsInAsciiArr( sImplEndSkipChars, rTxt[ nFndPos - 1 ] )) && + lcl_IsInAsciiArr( sImplEndSkipChars, aOrigTxt[ nFndPos - 1 ] )) && ( rCC.isLetterNumeric( sTmp, nFndPos + 2 ) || -lcl_IsInAsciiArr( sImplSttSkipChars, rTxt[ nFndPos + 2 ] ))) +lcl_IsInAsciiArr( sImplSttSkipChars, aOrigTxt[ nFndPos + 2 ] ))) { nSttPos = nSttPos + nFndPos; rDoc.Delete( nSttPos, nSttPos + 2 ); diff --git a/include/editeng/svxacorr.hxx b/include/editeng/svxacorr.hxx index fcb5f97aca2b..a5e43032a78f 100644 --- a/include/editeng/svxacorr.hxx +++ b/include/editeng/svxacorr.hxx @@ -408,7 +408,7 @@ public: bool FnChgOrdinalNumber( SvxAutoCorrDoc&, const OUString&, sal_Int32 nSttPos, sal_Int32 nEndPos, LanguageType eLang ); -bool FnChgToEnEmDash( SvxAutoCorrDoc&, std::u16string_view, +bool FnChgToEnEmDash( SvxAutoCorrDoc&, const OUString&, sal_Int32 nSttPos, sal_Int32 nEndPos, LanguageType eLang ); bool FnAddNonBrkSpace( SvxAutoCorrDoc&, std::u16string_view, diff --git a/sw/source/core/edit/edws.cxx b/sw/source/core/edit/edws.cxx index abbb920afdc5..4e46ae2daf5a 100644 --- a/sw/source/core/edit/edws.cxx +++ b/sw/source/core/edit/edws.cxx @@ -272,6 +272,10 @@ void SwEditShell::AutoCorrect( SvxAutoCorrect& rACorr, bool bInsert, // something - so first normalize cursor point to end of redline so that // point will then be moved forward when something is inserted. *pCursor->GetPoint() = pFrame->MapViewToModelPos(nPos); +// The hope is that the AutoCorrect never deletes nodes, hence never +// deletes SwTextFrames, hence we can pass in the SwTextFrame::GetText() +// result and it will be
[Libreoffice-bugs] [Bug 151059] Can't type "^" character with AltGr+3 using Slovenian keyboard, opening Gallery instead
https://bugs.documentfoundation.org/show_bug.cgi?id=151059 --- Comment #3 from grofaty --- I can confirm @Tex2002ans work-around fixes the problem. Excellent. This was really really really annoying, specially in LibreOffice Calc where "^" character is used for "exponent". Now I have to fix this in all of the my computers and coworkers etc. I assume (I may be wrong) this shortcut was added at some point to LibreOffice. Can someone search for the commit and revert it properly for all users. Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: sl-SI (en_SI); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155399] New: Writer shows incorrect colors on fillable form elements when system UI is set to dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155399 Bug ID: 155399 Summary: Writer shows incorrect colors on fillable form elements when system UI is set to dark mode Product: LibreOffice Version: 7.4.5.1 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: andrew.hak...@gmail.com Description: I'm running Libre Office in Linux under KDE. I have the system theme set to Breeze Dark. Opening a previously created writer document that has form elements in it, with the KDE theme set to dark mode, ALL of the form text boxes have a dark grey background and light gray text, even though the main part of the document is normal (black text on a white background). There are really 4 bugs here: 1) I can't select ALL of the form elements and change them at once. I can only select one form element at a time, and have to change them individually. This is REALLY painful. 2) Why does the background color and font color of form elements default to some color from the system color scheme when the non-form parts of the document work normally? 3) To fix the background, I can simply change the color and pick "white" instead of "default", but to fix the font color, it's actually set to "black" the first time I open the font dialog, but the text is picking a different color from the UI color scheme. To actually change it to be black, I have to change it to a color other than black, press OK, then re-open the font dialog a second time, and set it back to "black" again - then it actually changes. 4) The border colors of the form elements also got changed from black to a lighter color from the color scheme too. Form elements shouldn't default to random colors from the UI theme when the rest of the document doesn't do that. Form elements should be multi-selectible and be able to mass edit common parameters of them (such as colors, appearance, fonts, etc.) all at one time. There's also a long-standing bug with form elements that are set to "centered" text. When I open a saved file, the text is not centered, but way off to the right of the form box. If I type an extra space at the end of the text, then the text centers properly. It will remain centered until I save, and re-open the document in a new session - then it's back to not being centered correctly again. All of these bugs (form element colors, and text alignment) affects the final rendering of the document - if I export a PDF, I get the incorrect colors and alignments as well until I manually fix all of them. Steps to Reproduce: 1.Create a document with forms with the color scheme set normally - put some text in the forms and set them to "centered" - save the document, and close Writer 2.Change the system UI to dark mode and re-open the saved document Actual Results: Form fields have incorrect colors and text alignment Expected Results: Form fields maintain colors consistent with the rest of the document regardless of UI color schemes. Text alignment of text fields set to "centered" is actually centered. Reproducible: Always User Profile Reset: No Additional Info: Please add more unit tests to form fields in writer - there have been a number of weird issues with forms in the last number of versions, so clearly there isn't enough testing being done to ensure forms are working properly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142444] Hyperlink not added to the with Ctrl-A selected text in cell
https://bugs.documentfoundation.org/show_bug.cgi?id=142444 BogdanB changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #5 from BogdanB --- Feel free to reopen if it's not working for you with a newer version. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements (including formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 BogdanB changed: What|Removed |Added Depends on||119423 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119423 [Bug 119423] CTRL+D leads to invalid merged cells that are not selectable and are not saved -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119423] CTRL+D leads to invalid merged cells that are not selectable and are not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=119423 BogdanB changed: What|Removed |Added Blocks||108252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements (including formatting) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155384] Fixed width paste does not sample enough input data
https://bugs.documentfoundation.org/show_bug.cgi?id=155384 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155384] Fixed width paste does not sample enough input data
https://bugs.documentfoundation.org/show_bug.cgi?id=155384 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155353] unable to export as PDF in 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=155353 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145149] Unable to open spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=145149 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137272] Superscripted font is cut off and line spacing increased when smaller block quoted text has footnote or endnote in it, due to use of one font size for all footnotes in
https://bugs.documentfoundation.org/show_bug.cgi?id=137272 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145149] Unable to open spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=145149 --- Comment #6 from QA Administrators --- Dear Richard BARRAS, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137272] Superscripted font is cut off and line spacing increased when smaller block quoted text has footnote or endnote in it, due to use of one font size for all footnotes in
https://bugs.documentfoundation.org/show_bug.cgi?id=137272 --- Comment #14 from QA Administrators --- Dear TH, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89069] FILESAVE: HTML output removes bold/italic from open-quote characters
https://bugs.documentfoundation.org/show_bug.cgi?id=89069 --- Comment #13 from QA Administrators --- Dear Rev. Bob, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66299] FILESAVE: Shapes not exported to XHTML
https://bugs.documentfoundation.org/show_bug.cgi?id=66299 --- Comment #10 from QA Administrators --- Dear callow.mark, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64067] HTML document conversion and viewing text justification issue with Microsoft Word HTML document
https://bugs.documentfoundation.org/show_bug.cgi?id=64067 --- Comment #12 from QA Administrators --- Dear grave_123, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 52586] Mail Merge doesn't seem to respect a standard data sources filter - steps in Comment 4 (workaround: use filter in address list)
https://bugs.documentfoundation.org/show_bug.cgi?id=52586 --- Comment #20 from QA Administrators --- Dear Joshua, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142343] VIEWING Chart with calculated floating values displays broken data labels
https://bugs.documentfoundation.org/show_bug.cgi?id=142343 --- Comment #6 from QA Administrators --- Dear NISZ LibreOffice Team, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142112] Calc : routine Msgbox(Application.Name) returns "Microsoft Excel" in place of "LibreOffice Calc"
https://bugs.documentfoundation.org/show_bug.cgi?id=142112 --- Comment #5 from QA Administrators --- Dear Laurent Louvet, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141302] PARAGRAPH: Thin lines between paragraphs after filling area with a colour
https://bugs.documentfoundation.org/show_bug.cgi?id=141302 --- Comment #6 from QA Administrators --- Dear Panos Stokas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155398] Writer file error
https://bugs.documentfoundation.org/show_bug.cgi?id=155398 --- Comment #1 from david chen --- Created attachment 187389 --> https://bugs.documentfoundation.org/attachment.cgi?id=187389=edit object has error , and unrecoverable -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155398] New: Writer file error
https://bugs.documentfoundation.org/show_bug.cgi?id=155398 Bug ID: 155398 Summary: Writer file error Product: LibreOffice Version: 7.5.1.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d...@ms31.hinet.net Description: show error message then no response Steps to Reproduce: 1.open file 2.click upper icon 3.shown error Actual Results: liberoffice no response , need close this program Expected Results: it's wrong Reproducible: Always User Profile Reset: No Additional Info: I can send you file , my e-mail d...@ms31.hinet.net -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153034] Three wrong Greek characters in WordPerfect 5 import
https://bugs.documentfoundation.org/show_bug.cgi?id=153034 --- Comment #9 from e...@columbia.edu --- Just to repeat what I wrote on SourceForge: the latest commit leaves one character incorrect. I've posted the details in libwpd on SourceForge. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - writerfilter/source
writerfilter/source/dmapper/DomainMapper.cxx | 10 writerfilter/source/dmapper/DomainMapper_Impl.cxx | 76 +- writerfilter/source/dmapper/DomainMapper_Impl.hxx |4 writerfilter/source/dmapper/FontTable.cxx | 22 writerfilter/source/dmapper/FontTable.hxx | 10 writerfilter/source/dmapper/GraphicImport.cxx | 643 +++--- writerfilter/source/dmapper/NumberingManager.cxx | 12 writerfilter/source/dmapper/PropertyMap.cxx |2 writerfilter/source/dmapper/StyleSheetTable.cxx | 232 +++ writerfilter/source/dmapper/StyleSheetTable.hxx | 30 - 10 files changed, 522 insertions(+), 519 deletions(-) New commits: commit ea16ea036fa9847ca65a951f483f3e25dfc9ec49 Author: Miklos Vajna AuthorDate: Mon Feb 20 08:13:50 2023 +0100 Commit: Justin Luth CommitDate: Fri May 19 03:23:04 2023 +0200 writerfilter: prefix members of DomainMapper_Impl, EmbeddedFontHandler, ... ... GraphicImport_Impl and StyleSheetEntry See tdf#94879 for motivation. This cherry-picked cleanly from master except for writerfilter/source/dmapper/GraphicImport.cxx which had a couple of mstahl commits already merged. So, the question is whether I go ahead with this full cherry-pick, or do I just attempt to limit it to StyleSheetTable and its dependencies. If I do this, then any 7.6 commit BEFORE Mon Feb 20 08:13:50 2023 that still needs to be backported will run into trouble, while now any commit AFTER that date will run into trouble. Well, Collabora has made most of the changes to these files in the past few months, so I assume most of those have already been backported. A few made by allotropia have also already been backported. So, I think the best is to just go ahead and backport this full commit. I need at least DomainMapper_Impl and StyleSheetTable for my own purposes, so that already counts for about half of it. Change-Id: I83639c40fb8c32c1d205a9b53d24409f9a5a5a15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147307 Reviewed-by: Miklos Vajna Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151967 Tested-by: Jenkins CollaboraOffice Reviewed-by: Justin Luth diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index 28e3df63ca3c..ca6a3026f19c 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -1788,7 +1788,7 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const PropertyMapPtr& rContext ) if ( IsStyleSheetImport() ) { const StyleSheetEntryPtr pCurrStyle = GetStyleSheetTable()->GetCurrentEntry(); -if ( pCurrStyle && pCurrStyle->nStyleTypeCode == STYLE_TYPE_CHAR ) +if ( pCurrStyle && pCurrStyle->m_nStyleTypeCode == STYLE_TYPE_CHAR ) break; } @@ -2512,7 +2512,7 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const PropertyMapPtr& rContext ) // First check if the style exists in the document. StyleSheetEntryPtr pEntry = m_pImpl->GetStyleSheetTable( )->FindStyleSheetByConvertedStyleName( sConvertedName ); -bool bExists = pEntry && ( pEntry->nStyleTypeCode == STYLE_TYPE_CHAR ); +bool bExists = pEntry && ( pEntry->m_nStyleTypeCode == STYLE_TYPE_CHAR ); // Add the property if the style exists, but do not add it elements in TOC: // they will receive later another style references from TOC if ( bExists && m_pImpl->GetTopContext() && !m_pImpl->IsInTOC()) @@ -3206,9 +3206,9 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const PropertyMapPtr& rContext ) if( !sStyleName.isEmpty() && GetStyleSheetTable() ) pStyle = GetStyleSheetTable()->FindStyleSheetByConvertedStyleName( sStyleName ); -if( pStyle && pStyle->pProperties -&& pStyle->pProperties->isSet(PROP_BREAK_TYPE) -&& pStyle->pProperties->getProperty(PROP_BREAK_TYPE)->second == aBreakType ) +if( pStyle && pStyle->m_pProperties +&& pStyle->m_pProperties->isSet(PROP_BREAK_TYPE) +&& pStyle->m_pProperties->getProperty(PROP_BREAK_TYPE)->second == aBreakType ) { pParagraphProps->Insert(PROP_BREAK_TYPE, aBreakType); } diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 26893126ff72..5f83bed4c58f 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -135,7 +135,7 @@ static void lcl_linenumberingHeaderFooter( const uno::ReferenceGetStyleSheetTable()->FindStyleSheetByISTD( rname );
[Libreoffice-bugs] [Bug 155397] New: Urgent: Libreoffice crashes frequently on iMac M1 CPU
https://bugs.documentfoundation.org/show_bug.cgi?id=155397 Bug ID: 155397 Summary: Urgent: Libreoffice crashes frequently on iMac M1 CPU Product: LibreOffice Version: 7.4.6.2 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ezyl...@gmail.com Description: I cannot use Libreoffice 7.4.6.2 at all. Each time I run it, it crashes on my newly bought Apple iMac with M1 CPU and latest Vetura op system. Please fix the bug as soon as possible. I copy and past some crash report for your information. Steps to Reproduce: 1.fix the bug to make the sw work on iMac 2. 3. Actual Results: need to fix the bug as soon as possible Expected Results: Fix the bug. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: TextDocument [Information guessed from browser] OS: Mac OS X (All) OS is 64bit: no The copy of part of error report is as follows: Translated Report (Full Report Below) - Process: soffice [1715] Path: /Applications/LibreOffice.app/Contents/MacOS/soffice Identifier:org.documentfoundation.libreoffice Version: 7.4.6002 (7.4.6002) App Item ID: 1630474372 App External ID: 855383657 Code Type: ARM-64 (Native) Parent Process:launchd [1] User ID: 501 Date/Time: 2023-05-19 11:00:33.0857 +1000 OS Version:macOS 13.4 (22F66) Report Version:12 Anonymous UUID:2A2ECC49-598B-0138-979D-4974FD7C3F67 Time Awake Since Boot: 740 seconds System Integrity Protection: enabled Crashed Thread:0 Dispatch queue: com.apple.main-thread Exception Type:EXC_CRASH (SIGABRT) Exception Codes: 0x, 0x Application Specific Information: abort() called Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x1a5c64724 __pthread_kill + 8 1 libsystem_pthread.dylib0x1a5c9bc28 pthread_kill + 288 2 libsystem_c.dylib 0x1a5ba9ae8 abort + 180 3 libuno_sal.dylib.3 0x1030404c8 (anonymous namespace)::signalHandlerFunction(int, __siginfo*, void*) (.cold.1) + 32 4 libuno_sal.dylib.3 0x103033c98 (anonymous namespace)::signalHandlerFunction(int, __siginfo*, void*) + 1060 5 libsystem_platform.dylib 0x1a5ccaa24 _sigtramp + 56 6 libsystem_pthread.dylib0x1a5c9bc28 pthread_kill + 288 7 libsystem_c.dylib 0x1a5ba9ae8 abort + 180 8 libsystem_malloc.dylib 0x1a5acae28 malloc_vreport + 908 9 libsystem_malloc.dylib 0x1a5ace6e8 malloc_report + 64 10 libsystem_malloc.dylib 0x1a5adaf20 find_zone_and_free + 308 11 libuno_sal.dylib.3 0x10301f71c rtl_uString_release + 52 12 libuno_cppu.dylib.30x103259bb4 cppu::idestructElements(void*, _typelib_TypeDescriptionReference*, int, int, void (*)(void*)) + 268 13 libuno_cppu.dylib.30x103259a5c cppu::idestroySequence(_sal_Sequence*, _typelib_TypeDescriptionReference*, _typelib_TypeDescription*, void (*)(void*)) + 184 14 libuno_cppu.dylib.30x10326435c uno_type_sequence_destroy + 20 15 libvclplug_osxlo.dylib 0x107088cdc +[AquaA11yTextAttributesWrapper createAttributedStringForElement:inOrigRange:] + 1000 16 AppKit 0x1a94e9bbc -[NSAccessibilityAttributeAccessorInfo getParameterizedAttributeValue:forObject:withParameter:] + 72 17 AppKit 0x1a94eb6b4 ___NSAccessibilityEntryPointValueForAttributeWithParameter_block_invoke.777 + 408 18 AppKit 0x1a94e6a84 NSAccessibilityPerformEntryPointObject + 44 19 AppKit 0x1a94e8684 NSAccessibilityEntryPointValueForAttributeWithParameter + 232 20 AppKit 0x1a92ea2d4 CopyParameterizedAttributeValue + 504 21 HIServices 0x1ab512678 _AXXMIGCopyParameterizedAttributeValue + 464 22 HIServices 0x1ab5399ac _XCopyParameterizedAttributeValue + 540 23 HIServices 0x1ab4f152c mshMIGPerform + 204 24 CoreFoundation 0x1a5d7abcc __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 60 25 CoreFoundation 0x1a5d7aaec __CFRunLoopDoSource1 + 520 26 CoreFoundation 0x1a5d794cc
[Libreoffice-bugs] [Bug 155384] Fixed width paste does not sample enough input data
https://bugs.documentfoundation.org/show_bug.cgi?id=155384 --- Comment #5 from Pierre Fortin --- Created attachment 187388 --> https://bugs.documentfoundation.org/attachment.cgi?id=187388=edit sample file 2 I have no idea how that file got selected... Here's another try at the file I thought was attached... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120283] connector view changes when duplicating slide
https://bugs.documentfoundation.org/show_bug.cgi?id=120283 --- Comment #10 from Dave Gilbert --- I'm chasing this backwards from the XML output, the points come from SdrEdgeObj::ImpCalcEdgeTrack and it's called very differently in the good and bad cases; I'll follow it back to see why. In the good case we see (with a bunch of debug): SdrEdgeObj::ImpCalcEdgeTrack entry: 0x2637f20 eKind: 3 Angles:27000 / 9000 Points:14829,2381 / 16086,3766 BoundRects: 2758x921@(13450,1462) / 3223x1039@(14475,3765) BewareRects: 3758x1921@(12950,962) / 4223x2039@(13975,3265) bezier>2 case(Z / 4) Pts: 14829,2381 / 14829,3074 / 16086,3074 / 16086,3766 d1: 0 / 693 d2: 0 / -692 in the bad case it tries a whole bunch of different configurations, 5 point, 4 point Z, 3 point and finally a 4 point U; in all cases the bound and beware rects fro the destination is screwy compared to the original: SdrEdgeObj::ImpCalcEdgeTrack entry: 0x42daf20 eKind: 3 Angles:27000 / 0 Points:14829,2381 / 16086,3766 BoundRects: 2758x921@(13450,1462) / 1x1@(16086,3766) BewareRects: 3758x1921@(12950,962) / 1x1@(16086,3766) bezier>2 case(? / 5) Pts: 14829,2381 / 14829,3324 / 16086,3766 / 16086,3766 d1: 0 / 943 d2: 0 / 0 SdrEdgeObj::ImpCalcEdgeTrack entry: 0x42daf20 eKind: 3 Angles:27000 / 9000 Points:14829,2381 / 16086,3766 BoundRects: 2758x921@(13450,1462) / 1x1@(16086,3766) BewareRects: 3758x1921@(12950,962) / 1x1@(16086,3766) bezier>2 case(Z / 4) Pts: 14829,2381 / 14829,3324 / 16086,3324 / 16086,3766 d1: 0 / 943 d2: 0 / -442 SdrEdgeObj::ImpCalcEdgeTrack entry: 0x42daf20 eKind: 3 Angles:27000 / 18000 Points:14829,2381 / 16086,3766 BoundRects: 2758x921@(13450,1462) / 1x1@(16086,3766) BewareRects: 3758x1921@(12950,962) / 1x1@(16086,3766) bezier>2 case(L / 3) Pts: 14829,2381 / 14829,3766 / 14829,3766 / 16086,3766 d1: 0 / 1385 d2: -1257 / 0 SdrEdgeObj::ImpCalcEdgeTrack entry: 0x42daf20 eKind: 3 Angles:27000 / 27000 Points:14829,2381 / 16086,3766 BoundRects: 2758x921@(13450,1462) / 1x1@(16086,3766) BewareRects: 3758x1921@(12950,962) / 1x1@(16086,3766) bezier>2 case(U / 4) Pts: 14829,2381 / 14829,3766 / 16086,3766 / 16086,3766 d1: 0 / 1385 d2: 0 / 0 I'll chase that back. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: tools/source
tools/source/datetime/datetime.cxx | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) New commits: commit 261063e69e80193ad563e086c515fd6e22e48464 Author: Eike Rathke AuthorDate: Thu May 18 23:30:51 2023 +0200 Commit: Eike Rathke CommitDate: Fri May 19 02:29:18 2023 +0200 Eliminate 24h loops in DateTime::operator+=/-=(tools::Time&) ... and repeated Date::operator++/--() that each calculate lcl_DaysToDate( GetAsNormalizedDays() + 1 ) where Date::AddDays() does it once. Also, that probably never worked correctly with negative time results >=24h Change-Id: Ic67aaa3d93e0d6533501d52671acf765e2d9bbdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151984 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/tools/source/datetime/datetime.cxx b/tools/source/datetime/datetime.cxx index 00790ff78dd4..efdb928986c3 100644 --- a/tools/source/datetime/datetime.cxx +++ b/tools/source/datetime/datetime.cxx @@ -101,19 +101,20 @@ DateTime& DateTime::operator +=( const tools::Time& rTime ) sal_uInt16 nHours = aTime.GetHour(); if ( aTime.GetTime() > 0 ) { -while ( nHours >= 24 ) +if (nHours >= 24) { -Date::operator++(); -nHours -= 24; +AddDays( nHours / 24 ); +nHours %= 24; +aTime.SetHour( nHours ); } -aTime.SetHour( nHours ); } else if ( aTime.GetTime() != 0 ) { -while ( nHours >= 24 ) +if (nHours >= 24) { -Date::operator--(); -nHours -= 24; +AddDays( -static_cast(nHours) / 24 ); +nHours %= 24; +aTime.SetHour( nHours ); } Date::operator--(); aTime = Time( 24, 0, 0 )+aTime; @@ -130,19 +131,20 @@ DateTime& DateTime::operator -=( const tools::Time& rTime ) sal_uInt16 nHours = aTime.GetHour(); if ( aTime.GetTime() > 0 ) { -while ( nHours >= 24 ) +if (nHours >= 24) { -Date::operator++(); -nHours -= 24; +AddDays( nHours / 24 ); +nHours %= 24; +aTime.SetHour( nHours ); } -aTime.SetHour( nHours ); } else if ( aTime.GetTime() != 0 ) { -while ( nHours >= 24 ) +if (nHours >= 24) { -Date::operator--(); -nHours -= 24; +AddDays( -static_cast(nHours) / 24 ); +nHours %= 24; +aTime.SetHour( nHours ); } Date::operator--(); aTime = Time( 24, 0, 0 )+aTime;
[Libreoffice-bugs] [Bug 155392] Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode If it doesn't work, you can test with a prerelease 7.6.a1 https://qa.blog.documentfoundation.org/2023/05/17/libreoffice-7-6-alpha1-is-available-for-testing/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153527] LibreOffice 7.5 Calc: unable to apply formatting to all cells in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=153527 TBeholder changed: What|Removed |Added CC||turbobehol...@mail.ru --- Comment #19 from TBeholder --- (In reply to defector from comment #0) > Then you want > to format all the cells. Select all cells and press Ctrl + 1 and format the > cells: Obviously it’s a bug, but… I know some people try to paint on spreadsheets manually like this, but you know there are editable styles, right? (In reply to ady from comment #11) > other complains), the response would also be about a UX decision, with a > relevant comment about workarounds ("modify the default cell style"). It’s not a workaround, it’s the primary tool for this purpose. I mean, is it not obvious that ability to apply the same formatting to many elements is the main reason for having styles to begin with? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155388] Context menu in SlideShow mode temporarily disables SlideShow mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155388 --- Comment #4 from m.a.riosv --- With a clean profile, v76? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155388] Context menu in SlideShow mode temporarily disables SlideShow mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155388 --- Comment #3 from m.a.riosv --- Ok, I see, but I can't reproduce it, even with the same template. v7600a1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155392] Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 haxel...@pm.me changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from haxel...@pm.me --- (In reply to m.a.riosv from comment #2) > Have you selected > Menu/Tools/Options/Application colors - Scheme - LibreOffice dark Added an attachment, where it's selected and unmodified. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155392] Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 --- Comment #3 from haxel...@pm.me --- Created attachment 187387 --> https://bugs.documentfoundation.org/attachment.cgi?id=187387=edit Selected Application Colors Yes, it's selected here and unmodified. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155389] MCGR FILESAVE PPTX fill style is erroneously set to NONE
https://bugs.documentfoundation.org/show_bug.cgi?id=155389 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from m.a.riosv --- Who does, may have mistakes, but I'm sure I win. Reproducible. Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: b3c88dc039d447322b8c8c564ab6e2f0ce9c5b90 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded BTW, v753 shows the whole shape blank. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155396] New: Click on 'Size' field in status bar should open Position dialog in Calc too
https://bugs.documentfoundation.org/show_bug.cgi?id=155396 Bug ID: 155396 Summary: Click on 'Size' field in status bar should open Position dialog in Calc too Product: LibreOffice Version: 7.6.0.0 alpha1+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de When a shape is selected and you click on the 'Size' field in the status bar, then the Position dialog opens if the module is Writer, Impress or Draw. But if you do the same in Calc, nothing happens. Request: If you click in Calc on the 'Size' field of the status bar while a shape is selected, then the Position dialog should open, same as in the other modules. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sc/source
sc/source/filter/inc/condformatbuffer.hxx |2 +- sc/source/filter/oox/condformatbuffer.cxx |1 - sc/source/filter/oox/condformatcontext.cxx |6 ++ 3 files changed, 7 insertions(+), 2 deletions(-) New commits: commit dc3d0f58f1dfff8082e4faf0916103b6557f4079 Author: Henry Castro AuthorDate: Tue Mar 28 17:48:19 2023 -0400 Commit: Henry Castro CommitDate: Fri May 19 01:18:18 2023 +0200 sc: filter: oox: do not insert rule too early The tag is a good place to do a post check the conditional format sanity. Signed-off-by: Henry Castro Change-Id: Id6e99c81011040ec47034e993490fae5c71d7e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149719 Reviewed-by: Andras Timar Tested-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151977 Tested-by: Jenkins CollaboraOffice diff --git a/sc/source/filter/inc/condformatbuffer.hxx b/sc/source/filter/inc/condformatbuffer.hxx index d5d5ebac2ab5..a1cc7bb81381 100644 --- a/sc/source/filter/inc/condformatbuffer.hxx +++ b/sc/source/filter/inc/condformatbuffer.hxx @@ -219,9 +219,9 @@ public: const ScRangeList& getRanges() const { return maModel.maRanges; } voidsetReadyForFinalize() { mbReadyForFinalize = true; } +voidinsertRule( CondFormatRuleRef const & xRule ); private: CondFormatRuleRef createRule(); -voidinsertRule( CondFormatRuleRef const & xRule ); private: typedef RefMap< sal_Int32, CondFormatRule > CondFormatRuleMap; diff --git a/sc/source/filter/oox/condformatbuffer.cxx b/sc/source/filter/oox/condformatbuffer.cxx index 2960610f34dd..c1b7b6d84c9d 100644 --- a/sc/source/filter/oox/condformatbuffer.cxx +++ b/sc/source/filter/oox/condformatbuffer.cxx @@ -1107,7 +1107,6 @@ CondFormatRuleRef CondFormat::importCfRule( const AttributeList& rAttribs ) { CondFormatRuleRef xRule = createRule(); xRule->importCfRule( rAttribs ); -insertRule( xRule ); return xRule; } diff --git a/sc/source/filter/oox/condformatcontext.cxx b/sc/source/filter/oox/condformatcontext.cxx index 2f3ae391ab71..845d105b7605 100644 --- a/sc/source/filter/oox/condformatcontext.cxx +++ b/sc/source/filter/oox/condformatcontext.cxx @@ -202,6 +202,12 @@ void CondFormatContext::onEndElement() if(mxCondFmt) mxCondFmt->setReadyForFinalize(); break; +case XLS_TOKEN( cfRule ): +if (mxCondFmt && mxRule) +{ +mxCondFmt->insertRule(mxRule); +} +break; } }
[Libreoffice-bugs] [Bug 145702] Bad cint() behaviour for languages using comma as separator before the decimal point
https://bugs.documentfoundation.org/show_bug.cgi?id=145702 --- Comment #3 from Kai Struck --- I can confirm a (mysterious) change in behaviour of the cint command in the 7er versions. with English local language setting: In all previous versions (and OpenOffice) something like cint("1,a") gave 1 cint("1,e") gave 1 cint("1,e2") gave 1 In LO7 all above give 0 In German local setting the "e" is suddenly treated as exponent: In all previous versions (and OpenOffice) something like cint("1,a") gave 1 cint("1,e") gave 1 cint("1,e1") gave 1 cint("1,e2") gave 1 In LO7: cint("1,a") still gives 1 cint("1,e") gives 0 cint("1,e1") gives 10 cint("1,e2") gives 100 I don't know what's going on but report it here. Tested on Windows 10 and LinuxMint17 and 21. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155384] Fixed width paste does not sample enough input data
https://bugs.documentfoundation.org/show_bug.cgi?id=155384 --- Comment #4 from m.a.riosv --- Created attachment 187386 --> https://bugs.documentfoundation.org/attachment.cgi?id=187386=edit Screenshot opening csv sample file I think sample file, it's not the same you have reported. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153527] LibreOffice 7.5 Calc: unable to apply formatting to all cells in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=153527 m.a.riosv changed: What|Removed |Added CC||rob...@prino.org --- Comment #18 from m.a.riosv --- *** Bug 155395 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155395] Calc - Change font of whole sheet does not work and has side effects
https://bugs.documentfoundation.org/show_bug.cgi?id=155395 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 153527 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sc/sdi sc/source sfx2/source
sc/sdi/scalc.sdi |4 ++-- sc/source/ui/view/tabvwsha.cxx |7 +-- sfx2/source/control/unoctitm.cxx |8 3 files changed, 11 insertions(+), 8 deletions(-) New commits: commit f0e5f1a845cd4b11c062c82aa3ce3cb08d179c82 Author: Henry Castro AuthorDate: Wed May 3 16:59:37 2023 -0400 Commit: Henry Castro CommitDate: Fri May 19 00:31:26 2023 +0200 sc: fix freeze row/column panes The UNO command state has changed to Point (row, tab) and Point (col, tab), Otherwise, if the row or column has the same value for all sheets, the state cache will not report any changes to the client side. Signed-off-by: Henry Castro Change-Id: I2080f5e664825d81c4fa4dbb2c5d782f188dae64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151344 Tested-by: Andras Timar Reviewed-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151975 Tested-by: Jenkins CollaboraOffice diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi index 9da8595a56d5..cfd0f43f580b 100644 --- a/sc/sdi/scalc.sdi +++ b/sc/sdi/scalc.sdi @@ -1947,7 +1947,7 @@ SfxVoidItem FreezePanes SID_WINDOW_FIX GroupId = SfxGroupId::View; ] -SfxInt32Item FreezePanesColumn SID_WINDOW_FIX_COL +SfxPointItem FreezePanesColumn SID_WINDOW_FIX_COL [ AutoUpdate = FALSE, @@ -1964,7 +1964,7 @@ SfxInt32Item FreezePanesColumn SID_WINDOW_FIX_COL GroupId = SfxGroupId::View; ] -SfxInt32Item FreezePanesRow SID_WINDOW_FIX_ROW +SfxPointItem FreezePanesRow SID_WINDOW_FIX_ROW [ AutoUpdate = FALSE, diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx index 9e86e5319de9..d7a6b554541b 100644 --- a/sc/source/ui/view/tabvwsha.cxx +++ b/sc/source/ui/view/tabvwsha.cxx @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -457,9 +458,11 @@ void ScTabViewShell::GetState( SfxItemSet& rSet ) case SID_WINDOW_FIX_COL: case SID_WINDOW_FIX_ROW: { +Point aPos; bool bIsCol = (nWhich == SID_WINDOW_FIX_COL); -sal_Int32 nFreezeIndex = rViewData.GetLOKSheetFreezeIndex(bIsCol); -rSet.Put(SfxInt32Item(nWhich, nFreezeIndex)); +aPos.setX(rViewData.GetLOKSheetFreezeIndex(bIsCol)); +aPos.setY(rViewData.GetTabNo()); +rSet.Put(SfxPointItem(nWhich, aPos)); } break; diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index d42054d3e33e..5d1cb00db3cf 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -1131,9 +1131,7 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, SfxViewFrame* pViewFra aEvent.FeatureURL.Path == "StatusSelectionMode" || aEvent.FeatureURL.Path == "Signature" || aEvent.FeatureURL.Path == "SelectionMode" || - aEvent.FeatureURL.Path == "StatusBarFunc" || - aEvent.FeatureURL.Path == "FreezePanesColumn" || - aEvent.FeatureURL.Path == "FreezePanesRow") + aEvent.FeatureURL.Path == "StatusBarFunc") { sal_Int32 aInt32; @@ -1217,7 +1215,9 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, SfxViewFrame* pViewFra aBuffer.append("disabled"); } } -else if (aEvent.FeatureURL.Path == "Position") +else if (aEvent.FeatureURL.Path == "Position" || + aEvent.FeatureURL.Path == "FreezePanesColumn" || + aEvent.FeatureURL.Path == "FreezePanesRow") { css::awt::Point aPoint;
[Libreoffice-bugs] [Bug 155394] Inserting an animated gif crash LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155394 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- No problem here Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155392] Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #2 from m.a.riosv --- Have you selected Menu/Tools/Options/Application colors - Scheme - LibreOffice dark -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155390] "Growing Liberty" Impress template has a slide of unclear (suspicious for advertizing) nature in the end
https://bugs.documentfoundation.org/show_bug.cgi?id=155390 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Right, although the link is not clickable. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155390] "Growing Liberty" Impress template has a slide of unclear (suspicious for advertizing) nature in the end
https://bugs.documentfoundation.org/show_bug.cgi?id=155390 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Right, although the link is not clickable. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 155379] Libre Office 7.5.3 fails to launch
https://bugs.documentfoundation.org/show_bug.cgi?id=155379 Julien Nabet changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Julien Nabet --- Thank you for the feedback, let’s put this one to WFM then! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155379] Libre Office 7.5.3 fails to launch
https://bugs.documentfoundation.org/show_bug.cgi?id=155379 --- Comment #2 from steve.rawlinso...@outlook.com --- I finally fixed this bug by uninstalling and re-installing Libre Office. What may have happened, is that Libre Office had to re-start to finish its installation. During that time, I think that it got caught up with a Windows Update and God only knows what could have happened. I re-installed and everything seems OK. I have had problems with Windows Updates in the past with the CAMERA application with it not coming up immediately after an update. Thanks for your help. Steve Rawlinson. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/xmlexprt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e15f54ebe7eb53f9e5d5ae7de4449c7e27171daf Author: Andrea Gelmini AuthorDate: Thu May 18 15:29:00 2023 +0200 Commit: Julien Nabet CommitDate: Thu May 18 23:47:55 2023 +0200 Fix typo Change-Id: I885b9e86b9078dc89ba0543103fd630a9ad3bc41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151963 Tested-by: Jenkins Reviewed-by: Julien Nabet Reviewed-by: Regina Henschel diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 2959cb4e0489..e1b156e833b7 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -3500,7 +3500,7 @@ void ScXMLExport::WriteShapes(const ScMyCell& rMyCell) continue; // The current object geometry is based on bHiddenAsZero=true, but ODF file format -// needs it as if there were no hidden rows or columns. We termine a fictive snap +// needs it as if there were no hidden rows or columns. We determine a fictive snap // rectangle from the anchor as if all column/rows are shown. Then we move and resize // (in case of "resize with cell") the object to meet this snap rectangle. We need to // manipulate the object itself, because the used methods in xmloff do not evaluate the
[Libreoffice-bugs] [Bug 155395] Calc - Change font of whole sheet does not work and has side effects
https://bugs.documentfoundation.org/show_bug.cgi?id=155395 rob...@prino.org changed: What|Removed |Added CC||rob...@prino.org --- Comment #1 from rob...@prino.org --- Created attachment 187385 --> https://bugs.documentfoundation.org/attachment.cgi?id=187385=edit ODS file exhibiting the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155395] New: Calc - Change font of whole sheet does not work and has side effects
https://bugs.documentfoundation.org/show_bug.cgi?id=155395 Bug ID: 155395 Summary: Calc - Change font of whole sheet does not work and has side effects Product: LibreOffice Version: 7.5.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@prino.org Description: When changing the font of one of the sheets of the attached "lift & v100+.ods", in casu the "Waiting info" one, the first six characters in cell J7 will not be changed, but remain Segoe UI. Also, once the font is changed to "Source Code Pro Light", licking a single cell and bolding it will bold every cell of the sheet. Steps to Reproduce: 1. Open the attached "lift & v100+.ods" 2. Select the "Waiting info" sheet 3. Select the entire sheet, Ctrl-A 4. Select the new font, "Source Code Pro Light" (or for that matter, "Courier New" or "Arial", the result is the same) 5. Put the pointer on cell J7 and see that the first six characters are still "Segoe UI" 6. Select any single cell in this sheet, and click on "B(old)" (or "I(talic)" or U(nderline)" and every cell will change Additional: On two occasions, also changing other sheets to use "Source Code Pro Light", Bolding, Italicizing, and Underlining completely stopped working, but I cannot reproduce this behaviour again. Actual Results: The font in cell J7 is only partially changed Expected Results: Cell J7 should change in its entirety, bolding a single selected cell should not affect the whole sheet Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-US Calc: CL threaded Starting in Safe Mode does not correct the problem! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sd/qa
sd/qa/unit/tiledrendering/tiledrendering.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 26ea90bb5a3b43da0ceae8bb250367125dd9 Author: Justin Luth AuthorDate: Wed May 17 16:16:21 2023 -0400 Commit: Justin Luth CommitDate: Thu May 18 23:18:46 2023 +0200 fix build: sd qa tiledrendering: remove unused variables I have no idea how this would have passed QA. Unused variables is a really common error, and I would have expected newer compilers to catch these. gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) Change-Id: Ief38da8b9f68c1bcda9db1b9b343b3afee2163a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151966 Tested-by: Jenkins CollaboraOffice Reviewed-by: Justin Luth diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx index 0552193eaf30..fd990b54c757 100644 --- a/sd/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx @@ -2548,8 +2548,6 @@ void SdTiledRenderingTest::testGetViewRenderState() CPPUNIT_ASSERT_EQUAL(OString(";Default"), pXImpressDocument->getViewRenderState()); // Create a second view SfxLokHelper::createView(); -int nSecondViewId = SfxLokHelper::getView(); -ViewCallback aView2; CPPUNIT_ASSERT_EQUAL(OString(";Default"), pXImpressDocument->getViewRenderState()); // Set to dark scheme {
[Libreoffice-bugs] [Bug 113829] FILEOPEN: DOC: Incorrect position of table - on top instead of 5 cm vertical relative to page
https://bugs.documentfoundation.org/show_bug.cgi?id=113829 Justin L changed: What|Removed |Added CC||vmik...@collabora.com --- Comment #7 from Justin L --- fixed in LO 7.6 by commit 61be351ac83acec75788d2f79a9038486163160f Author: Miklos Vajna on Thu Apr 20 08:13:12 2023 +0200 sw floattable: import floating tables from DOC as split flys by default -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155393] Crash in SfxShell::GetViewShell()
https://bugs.documentfoundation.org/show_bug.cgi?id=155393 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Keywords||haveBacktrace Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155393] Crash in SfxShell::GetViewShell()
https://bugs.documentfoundation.org/show_bug.cgi?id=155393 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- Created attachment 187384 --> https://bugs.documentfoundation.org/attachment.cgi?id=187384=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153828] Lagging with GTK
https://bugs.documentfoundation.org/show_bug.cgi?id=153828 --- Comment #4 from jake.m.knep...@gmail.com --- (In reply to Telesto from comment #3) > I guess bug 153007 being related to this. Source of the problem is likely > the 4K monitor I guess a temporary solution would be not to use LibreOffice at high resolutions like 4k on Linux. I wonder if this problem effects Windows, too. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154602] Scrolling using keyboard very slow (GTK3) with 4K monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=154602 --- Comment #10 from jake.m.knep...@gmail.com --- Played with LibreOffice (writer) at 4k on Xorg and i3wm. Same thing seems to happen. CPU usages spikes to 50% plus on a single thread/core for some reason. Scrolling other applications like Firefox at 4k for example doesn't seem to push any particular CPU thread drastic usage levels. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK)
https://bugs.documentfoundation.org/show_bug.cgi?id=152657 --- Comment #24 from jake.m.knep...@gmail.com --- Would like to add I notice a single thread/core will jump to 50% or so usage when scrolling on Fedora 38 at 4k. When running Debian with i3wm, the same thing happens. It seems to happen regardless of Xorg or Wayland. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134204] SW UI: inheriting styles not updated (until reload) when fontsize+some other attribute are changed in paragraph style dialog (autostyle related?).
https://bugs.documentfoundation.org/show_bug.cgi?id=134204 Justin L changed: What|Removed |Added Summary|Area colour not properly|SW UI: inheriting styles |removed (not properly |not updated (until reload) |repainted) after changing |when fontsize+some other |style settings |attribute are changed in ||paragraph style dialog ||(autostyle related?). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134204] Area colour not properly removed (not properly repainted) after changing style settings
https://bugs.documentfoundation.org/show_bug.cgi?id=134204 --- Comment #8 from Justin L --- repro 7.6+ (In reply to Justin L from comment #6) > 134204_red.odt: example document that doesn't use highlight. Steps to reproduce: 1.) open comment 6's attachment 170679 2.) Go to the default paragraph style dialog, Font Effects tab and change the red font color to something else. Then go to the font tab and change the font size. (the order doesn't matter - can change the font size first) --> result is that Heading 1 style text and the footnote text don't change. Doing them one at a time (instead of as a combination) has no problem. Using italic or bold along with font color has no problem. It seems to be specific to the font size in combination with one or more other attributes. I was easily able to reproduce this in a new document with just two paragraphs. One was with a Title paragraph style, and the other was default paragraph style. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Aron Budea changed: What|Removed |Added URL|https://www.prism-me.com/ar | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155292] FILESAVE: Undoing all changes made in a comment leaves the document marked as needing saving
https://bugs.documentfoundation.org/show_bug.cgi?id=155292 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Blocks||116625 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116625 [Bug 116625] [META] Bugs where document modification status is wrong -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116625] [META] Bugs where document modification status is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=116625 Aron Budea changed: What|Removed |Added Depends on||155292 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155292 [Bug 155292] FILESAVE: Undoing all changes made in a comment leaves the document marked as needing saving -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c7d4d0e92219ca16e85bc153efa3670ba870bfd7 Author: Olivier Hallot AuthorDate: Thu May 18 22:47:24 2023 +0200 Commit: Gerrit Code Review CommitDate: Thu May 18 22:47:24 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to ccce5b9aa0c1d59f6e3d102eb48191ca7fdb0a0c - Fix typo Change-Id: I11c8cfde4e8a53b541cea2ae165044fac11dcae7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151919 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index f2c3da66938b..ccce5b9aa0c1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit f2c3da66938bdb8802d1225bf25fbc2f7ad49493 +Subproject commit ccce5b9aa0c1d59f6e3d102eb48191ca7fdb0a0c
[Libreoffice-commits] help.git: source/text
source/text/scalc/05/0214.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ccce5b9aa0c1d59f6e3d102eb48191ca7fdb0a0c Author: Olivier Hallot AuthorDate: Thu May 18 22:15:31 2023 +0200 Commit: Olivier Hallot CommitDate: Thu May 18 22:47:23 2023 +0200 Fix typo Change-Id: I11c8cfde4e8a53b541cea2ae165044fac11dcae7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151919 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/05/0214.xhp b/source/text/scalc/05/0214.xhp index 26be7ce4d1..fc307ad9d9 100644 --- a/source/text/scalc/05/0214.xhp +++ b/source/text/scalc/05/0214.xhp @@ -292,7 +292,7 @@ Circular reference - Formula refers directly or indirectly to itself and the Iterations option is not set under %PRODUCTNAME - Preferences -Tools - Options - %PRODUCTNAME Calc - Calculate.UFI: fixes #i23854# + Formula refers directly or indirectly to itself and the Iterations option is not set under %PRODUCTNAME - PreferencesTools - Options - %PRODUCTNAME Calc - Calculate.UFI: fixes #i23854#
[Libreoffice-bugs] [Bug 80717] FILEOPEN: DOC DOCX file has incorrect vertical position relative to 'page' of floating table
https://bugs.documentfoundation.org/show_bug.cgi?id=80717 --- Comment #28 from Justin L --- Probably each of the duplicates here will need to be re-assessed one by one. comment 11's GE Bilokin Nadia-fixed.doc had the first table hidden by 7.6's commit 61be351ac83acec75788d2f79a9038486163160f Author: Miklos Vajna on Thu Apr 20 08:13:12 2023 +0200 sw floattable: import floating tables from DOC as split flys by default And hidden paragraph's are likely related to the spacing difference between the tables as well. If I turn on Tools - Options - Writer - Formatting Aids - Hidden Characters, and remove the hidden paragraph, then it looks right. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/xmlexprt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9055b11b82367653ef552505585846619ad7c85c Author: Andrea Gelmini AuthorDate: Thu May 18 15:23:55 2023 +0200 Commit: Julien Nabet CommitDate: Thu May 18 22:21:08 2023 +0200 Fix typo Change-Id: I33ddd35cc09d0976ac64af80d597ba9d307041e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151960 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 7c84ac43c4fc..2959cb4e0489 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -3569,7 +3569,7 @@ void ScXMLExport::WriteShapes(const ScMyCell& rMyCell) } } -// The existance of an end address is equivalent to anchor mode "To Cell (resize with cell)". +// The existence of an end address is equivalent to anchor mode "To Cell (resize with cell)". // XML needs end address in regard of untransformed shape. Those are contained in rShape but // could be received from NonRotatedObjData as well. // tdf#154005: We treat the combination of "To Cell (resize with cell)" anchor with 'size
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/scshapetest.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ba9908f2ecfaa51b3def099ac3b86ae6cfb714ea Author: Andrea Gelmini AuthorDate: Thu May 18 15:24:47 2023 +0200 Commit: Julien Nabet CommitDate: Thu May 18 22:20:22 2023 +0200 Fix typo Change-Id: Ida74d3ff99c4e8c7e6c6402d580ae9d279217105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151961 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx index 21406c52cc7d..b658e44f03d5 100644 --- a/sc/qa/unit/scshapetest.cxx +++ b/sc/qa/unit/scshapetest.cxx @@ -1202,7 +1202,7 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest, testTdf154821_shape_in_group) pViewShell->GetViewData().SetCurX(0); pViewShell->GetViewData().SetCurY(5); pViewShell->GetViewData().GetDispatcher().Execute(SID_OUTLINE_SHOW); -// Expande the upper group +// Expand the upper group pViewShell = getViewShell(); pViewShell->GetViewData().SetCurX(0); pViewShell->GetViewData().SetCurY(1);
[Libreoffice-bugs] [Bug 155394] Inserting an animated gif crash LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155394 Alhay94 changed: What|Removed |Added CC||agrang...@yahoo.fr --- Comment #1 from Alhay94 --- Created attachment 187383 --> https://bugs.documentfoundation.org/attachment.cgi?id=187383=edit The attachment inserted in Writer, crashes Writer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155394] New: Inserting an animated gif crash LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155394 Bug ID: 155394 Summary: Inserting an animated gif crash LibreOffice Writer Product: LibreOffice Version: 7.5.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: agrang...@yahoo.fr Description: I open a new Documentwriter, I click on "Insert Menu" then "Picture" and choose the animated gif : "gif-esempio.gif" found on Internet. After Insertion, I click into Writer but outside of the "gif" and LibreOffice crashes. Steps to Reproduce: 1.open Writer 2.insert picture "gif-esempio.gif" 3.click after the "gif" in wwiter Actual Results: Crash of LibreOffice Writer Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: crash I Will attach the "gif" to the report -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/macos-add-entitlements-for-instruments.sh
bin/macos-add-entitlements-for-instruments.sh | 33 ++ 1 file changed, 33 insertions(+) New commits: commit ff95984c8e3475b7ff7832683d621bd09896852e Author: Patrick Luby AuthorDate: Thu May 18 13:47:40 2023 -0400 Commit: Patrick Luby CommitDate: Thu May 18 21:53:08 2023 +0200 Script that adds "com.apple.security.get-task-allow" entitlement to soffice To connect Xcode's Instruments application to profile LibreOffice, the "com.apple.security.get-task-allow" entitlement must be added to the soffice executable. This script will set the "com.apple.security.get-task-allow" entitlement instdir/LibreOfficeDev.app/Contents/MacOS/soffice executable so that profiling can be done using a local build. Credit for documenting this Xcode requirement goes to the following blog: https://cocoaphony.micro.blog/2022/10/29/solving-required-kernel.html Change-Id: I547edf7c1ad340267e9ed4c396fc723b7ea719be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151981 Tested-by: Jenkins Reviewed-by: Patrick Luby diff --git a/bin/macos-add-entitlements-for-instruments.sh b/bin/macos-add-entitlements-for-instruments.sh new file mode 100755 index ..e22b4ae6db50 --- /dev/null +++ b/bin/macos-add-entitlements-for-instruments.sh @@ -0,0 +1,33 @@ +#!/bin/bash + +# Script that adds "com.apple.security.get-task-allow" entitlement to soffice +# +# To connect Xcode's Instruments application to profile LibreOffice, the +# "com.apple.security.get-task-allow" entitlement must be added to the +# soffice executable. +# +# This script will set the "com.apple.security.get-task-allow" entitlement +# instdir/LibreOfficeDev.app/Contents/MacOS/soffice executable so that +# profiling can be done using a local build. +# +# Credit for documenting this Xcode requirement goes to the following blog: +# https://cocoaphony.micro.blog/2022/10/29/solving-required-kernel.html + +SOFFICE=`dirname "$0"`/../instdir/LibreOfficeDev.app/Contents/MacOS/soffice +if [ ! -f "$SOFFICE" -o ! -x "$SOFFICE" ] ; then +echo "Error: '$SOFFICE' is not an executable file" >&2 +exit 1 +fi + +codesign -s - -v -f --entitlements /dev/stdin "$SOFFICE" << ! + +https://www.apple.com/DTDs/PropertyList-1.0.dtd"\> + + +com.apple.security.get-task-allow + + + +! + +exit 0
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/source
sw/source/core/txtnode/ndtxt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6f608c493aa42c8fcdef8cb7220423fefb8555c9 Author: Justin Luth AuthorDate: Mon May 15 09:57:55 2023 -0400 Commit: Justin Luth CommitDate: Thu May 18 21:26:06 2023 +0200 related tdf#136536 sw: don't copy useless char escapement to next node on split This was clearing ANY single direct formatting attribute, not just char escapement. While that might be desireable in certain contexts, limit the hack to its intended subscript/superscript only. Change-Id: I0d503af826635c4325332cc985964957ee0b065d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151796 Tested-by: Jenkins Reviewed-by: Justin Luth (cherry picked from commit a4d011fb8ae24f90375744af5e98ba81716a22cb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151911 Tested-by: Jenkins CollaboraOffice diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx index a334baf87634..879ccaa9f35e 100644 --- a/sw/source/core/txtnode/ndtxt.cxx +++ b/sw/source/core/txtnode/ndtxt.cxx @@ -738,7 +738,7 @@ SwTextNode *SwTextNode::SplitContentNode(const SwPosition & rPos, } const std::shared_ptr& pSet = pHt->GetAutoFormat().GetStyleHandle(); -if (!pSet || pSet->Count() != 1 || !pSet->GetItem(RES_CHRATR_ESCAPEMENT)) +if (!pSet || pSet->Count() != 1 || !pSet->HasItem(RES_CHRATR_ESCAPEMENT)) { continue; }
[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103314 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||155390 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155390 [Bug 155390] "Growing Liberty" Impress template has a slide of unclear (suspicious for advertizing) nature in the end -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155390] "Growing Liberty" Impress template has a slide of unclear (suspicious for advertizing) nature in the end
https://bugs.documentfoundation.org/show_bug.cgi?id=155390 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||103314 Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103314 [Bug 103314] [META] Templates bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 155390] "Growing Liberty" Impress template has a slide of unclear (suspicious for advertizing) nature in the end
https://bugs.documentfoundation.org/show_bug.cgi?id=155390 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||103314 Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103314 [Bug 103314] [META] Templates bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155392] Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Component|LibreOffice |UI -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150915] [META] Windows Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=150915 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||155392 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155392 [Bug 155392] Not readable menu items in Windows 11 dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155392] Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||150915 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150915 [Bug 150915] [META] Windows Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||155393 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155393 [Bug 155393] Crash in SfxShell::GetViewShell() -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155393] Crash in SfxShell::GetViewShell()
https://bugs.documentfoundation.org/show_bug.cgi?id=155393 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||133092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155373] Feature request impress: editing slides and notes at the same time
https://bugs.documentfoundation.org/show_bug.cgi?id=155373 --- Comment #1 from Shu Zhang <122092...@qq.com> --- How about we add one more function so that the user can input the text in that field, and it will appear on both sides and notes after the user can have the ability to export the text into writer or text? I’m trying to get the idea of this function into a mockup. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 155373] Feature request impress: editing slides and notes at the same time
https://bugs.documentfoundation.org/show_bug.cgi?id=155373 --- Comment #1 from Shu Zhang <122092...@qq.com> --- How about we add one more function so that the user can input the text in that field, and it will appear on both sides and notes after the user can have the ability to export the text into writer or text? I’m trying to get the idea of this function into a mockup. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: basegfx/source basegfx/test chart2/source drawinglayer/source filter/source include/basegfx oox/source svx/source sw/source xmloff/source
basegfx/source/matrix/b2dhommatrix.cxx | 211 +++ basegfx/source/point/b2dpoint.cxx| 15 - basegfx/source/point/b2ipoint.cxx| 15 - basegfx/test/B2DHomMatrixTest.cxx| 54 - chart2/source/tools/CommonConverters.cxx | 13 - drawinglayer/source/texture/texture.cxx | 14 - drawinglayer/source/tools/primitive2dxmldump.cxx |6 filter/source/msfilter/eschesdo.cxx |7 include/basegfx/matrix/b2dhommatrix.hxx | 60 +++--- oox/source/drawingml/shape.cxx |6 oox/source/shape/WpsContext.cxx |7 svx/source/unodraw/unoshape.cxx | 13 - sw/source/core/edit/edfcol.cxx | 13 - sw/source/core/unocore/unodraw.cxx | 13 - xmloff/source/draw/shapeexport.cxx |7 xmloff/source/draw/ximpshap.cxx |6 16 files changed, 181 insertions(+), 279 deletions(-) New commits: commit fdd06037e0cf902d71270c4bf7a867efc7c9c1f4 Author: Noel Grandin AuthorDate: Wed May 17 20:13:03 2023 +0200 Commit: Noel Grandin CommitDate: Thu May 18 21:18:06 2023 +0200 improved B2DHomMatrix since we know that this is a matrix only used for 2D transforms, we know that the last row of the matrix is always { 0, 0, 1 }. Therefore, we don't need to store that information, and we can simplify some of the computations. Also remove operations like operator+ which are not legal for such a matrix. Change-Id: I482de9a45ebbedf79e3b6033575aab590e61c2d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151909 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/basegfx/source/matrix/b2dhommatrix.cxx b/basegfx/source/matrix/b2dhommatrix.cxx index 4222c7a351c2..e4a9dda9e3c5 100644 --- a/basegfx/source/matrix/b2dhommatrix.cxx +++ b/basegfx/source/matrix/b2dhommatrix.cxx @@ -26,50 +26,56 @@ namespace basegfx { - -B2DHomMatrix::B2DHomMatrix(double f_0x0, double f_0x1, double f_0x2, double f_1x0, double f_1x1, double f_1x2) -{ -maImpl.set(0, 0, f_0x0); -maImpl.set(0, 1, f_0x1); -maImpl.set(0, 2, f_0x2); -maImpl.set(1, 0, f_1x0); -maImpl.set(1, 1, f_1x1); -maImpl.set(1, 2, f_1x2); -} - -void B2DHomMatrix::set(sal_uInt16 nRow, sal_uInt16 nColumn, double fValue) -{ -maImpl.set(nRow, nColumn, fValue); -} +constexpr int RowSize = 3; void B2DHomMatrix::set3x2(double f_0x0, double f_0x1, double f_0x2, double f_1x0, double f_1x1, double f_1x2) { -maImpl.set(0, 0, f_0x0); -maImpl.set(0, 1, f_0x1); -maImpl.set(0, 2, f_0x2); -maImpl.set(1, 0, f_1x0); -maImpl.set(1, 1, f_1x1); -maImpl.set(1, 2, f_1x2); -} - -bool B2DHomMatrix::isLastLineDefault() const -{ -return maImpl.isLastLineDefault(); +mfValues[0][0] = f_0x0; +mfValues[0][1] = f_0x1; +mfValues[0][2] = f_0x2; +mfValues[1][0] = f_1x0; +mfValues[1][1] = f_1x1; +mfValues[1][2] = f_1x2; } bool B2DHomMatrix::isIdentity() const { -return maImpl.isIdentity(); +for(sal_uInt16 a(0); a < RowSize - 1; a++) +{ +for(sal_uInt16 b(0); b < RowSize; b++) +{ +const double fDefault(internal::implGetDefaultValue(a, b)); +const double fValueAB(get(a, b)); + +if(!::basegfx::fTools::equal(fDefault, fValueAB)) +{ +return false; +} +} +} + +return true; } void B2DHomMatrix::identity() { -maImpl = Impl2DHomMatrix(); +for(sal_uInt16 a(0); a < RowSize - 1; a++) +{ +for(sal_uInt16 b(0); b < RowSize; b++) +mfValues[a][b] = internal::implGetDefaultValue(a, b); +} } bool B2DHomMatrix::isInvertible() const { -return maImpl.isInvertible(); +double dst[6]; +/* Compute adjoint: */ +computeAdjoint(dst); +/* Compute determinant: */ +double det = computeDeterminant(dst); +if (fTools::equalZero(det)) +return false; +return true; } bool B2DHomMatrix::invert() @@ -77,85 +83,43 @@ namespace basegfx if(isIdentity()) return true; - -double dst[9]; +double dst[6]; /* Compute adjoint: */ - -dst[0] = + get(1, 1) * get(2, 2) - get(1, 2) * get(2, 1); -dst[1] = - get(0, 1) * get(2, 2) + get(0, 2) * get(2, 1); -dst[2] = + get(0, 1) * get(1, 2) - get(0, 2) * get(1, 1); -dst[3] = - get(1, 0) * get(2, 2) + get(1, 2) * get(2, 0); -dst[4] = + get(0, 0) * get(2, 2) - get(0, 2) * get(2, 0); -dst[5] = - get(0, 0) * get(1, 2) + get(0, 2) * get(1, 0); -
[Libreoffice-bugs] [Bug 154198] [Writer] The second and the before-final vertical lines are hidden in RTL documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=154198 --- Comment #6 from Mahmoud Alnaanah --- I missed step in previous comment. You need step 3 in this new comment. To produce the bug. 1- Open new writer document. 2- From: Tools>options>Language Settings> Languages>Enable complex text layout and set to Arabic Jordan. 3- From: Format>Page style> Change text direction to right-to-left. 4- Create 5x5 table. 5- Save the file as docx format. 6- Close the file. 7- Reopen the file. 8- Notice that the second and the before final vertical lines are hidden. Regards, -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154198] [Writer] The second and the before-final vertical lines are hidden in RTL documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=154198 Mahmoud Alnaanah changed: What|Removed |Added Resolution|WORKSFORME |WONTFIX Status|RESOLVED|VERIFIED --- Comment #5 from Mahmoud Alnaanah --- Status update: Sorry for reporting that the bug is resolved, in fact it is not. The bug exists since version 7.2 in files saved as docx format. To produce the bug. 1- Open new writer document. 2- From: Tools>options>Language Settings> Languages>Enable complex text layout and set to Arabic Jordan. 3- Create 5x5 table. 4- Save the file as docx format. 5- Close the file. 6- Reopen the file. 7- Notice that the second and the before final vertical lines are hidden. Regards, -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=143344 Bug 143344 depends on bug 144587, which changed state. Bug 144587 Summary: Tree item is inconsistent with dark theme https://bugs.documentfoundation.org/show_bug.cgi?id=144587 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 144587, which changed state. Bug 144587 Summary: Tree item is inconsistent with dark theme https://bugs.documentfoundation.org/show_bug.cgi?id=144587 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137075] Accessibility Statusline is not announced
https://bugs.documentfoundation.org/show_bug.cgi?id=137075 --- Comment #9 from Michael Weghorn --- (In reply to Ken Scott from comment #7) > I did find and install LibreOffice 7.5.2. This installer did place a > LibreOffice7.5 shortcut on the desktop using the standard option in the > installer. No desktop shortcut for LibreOffice seems to be created when > using the LibreOffice7.5.3 installer. There also seems to be no choice > about a standard or custom install option when using a screen reader with > LibreOffice7.5.3 installer. If I understand correctly, this is about the second aspect described in tdf#155236 ("First, The installer in version 7.5.3.2 did not exposed the check box to add a desktop icon/shortcut.") and unrelated to the issue described in this bug report here. Please create a separate bug report for that, which allows to keep focus (and avoids things getting "lost"). > I was able to open LibreOffice7.5.2’s Writer application. When, the NVDA > insert + end key combination is pressed the result is no status Bar > information. The anticipated result is the announcement of the status bar > information like page number and word count and so on in a word processor > application such as LibreOffice Writer. This is the issue actually handled here. This described anticipated result is what I get with the mentioned suggested NVDA change in place: https://github.com/nvaccess/nvda/pull/14933 So if that change is accepted and integrated into NVDA, it will work with a future version of NVDA, without requiring any changes on LibreOffice side. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149258] FILESAVE DOCX Dots appear IN MS WORD for custom numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=149258 Justin L changed: What|Removed |Added Summary|FILESAVE DOCX Dots appear |FILESAVE DOCX Dots appear |in Word for custom |IN MS WORD for custom |numbering |numbering --- Comment #5 from Justin L --- repro 7.6+ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155393] Crash in SfxShell::GetViewShell()
https://bugs.documentfoundation.org/show_bug.cgi?id=155393 Xisco Faulí changed: What|Removed |Added CC||caolan.mcnamara@collabora.c ||om --- Comment #1 from Xisco Faulí --- @Caolán, I thought you might be interested in this issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155393] Crash in SfxShell::GetViewShell()
https://bugs.documentfoundation.org/show_bug.cgi?id=155393 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Crash report or||["SfxShell::GetViewShell()" crash signature||] -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155393] New: Crash in SfxShell::GetViewShell()
https://bugs.documentfoundation.org/show_bug.cgi?id=155393 Bug ID: 155393 Summary: Crash in SfxShell::GetViewShell() Product: LibreOffice Version: 7.6.0.0 alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Created attachment 187382 --> https://bugs.documentfoundation.org/attachment.cgi?id=187382=edit screencast Steps to reproduce: 1. Open Impress 2. Open the navigator -> Slide 1 is selected 3. View - Notes 4. Once Slide 1 gets deselected in the navigator click many times on Shape 1 -> Crash. See screencast Reproduced in Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 343f1910d40f6d89658cf6e30b9b8f4af51deb43 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119423] CTRL+D leads to invalid merged cells that are not selectable and are not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=119423 --- Comment #9 from Aron Budea --- (In reply to BogdanB from comment #8) > What Ctrl+D is doing? I assume what is described in the first sentence of the description. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/find-unused-data.sh sw/qa
bin/find-unused-data.sh | 24 sw/qa/extras/find-unused-data.sh | 11 --- 2 files changed, 24 insertions(+), 11 deletions(-) New commits: commit 1b9702920dc7a3c36b19bbcae81176b0ad1bb0cd Author: Xisco Fauli AuthorDate: Thu May 18 11:28:12 2023 +0200 Commit: Xisco Fauli CommitDate: Thu May 18 20:45:57 2023 +0200 find-unused-data.sh: move script to bin and adapt it to check the whole repository Change-Id: Ic2df1248604e6e0053a8eeda50869eb5a3b1db0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151942 Tested-by: Xisco Fauli Reviewed-by: Xisco Fauli diff --git a/bin/find-unused-data.sh b/bin/find-unused-data.sh new file mode 100755 index ..8ca4cfc10d6c --- /dev/null +++ b/bin/find-unused-data.sh @@ -0,0 +1,24 @@ +#!/usr/bin/env bash + +SCRIPT=$(realpath "$0") +SCRIPTPATH=$(dirname "$SCRIPT") +PATHES="$(find $SCRIPTPATH/.. \( -wholename '*/qa/*/testdocuments' -o -wholename '*/qa/*/testdocuments/*' -o -wholename '*/qa/*/data' -o -wholename '*/qa/*/data/*' \) -type d )" + +for path in $PATHES +do +# Ignore pass/fail/inderterminate folders, functions test in sc, workdir folder and xml in sd +if [[ "$path" != */pass* ]] && [[ "$path" != */fail* ]] && [[ "$path" != */indeterminate* ]] \ +&& [[ "$path" != */functions* ]] && [[ "$path" != */workdir* ]] && [[ "$path" != */xml* ]]; then +for i in $path/* +do +if [ -f "$i" ]; then +file=$(basename "$i") +if ! git grep -q "$file"; then +echo "WARNING: $i is not used, write a testcase for it!" +fi +fi +done +fi +done + +# vi:set shiftwidth=4 expandtab: diff --git a/sw/qa/extras/find-unused-data.sh b/sw/qa/extras/find-unused-data.sh deleted file mode 100755 index 460c01caaaec.. --- a/sw/qa/extras/find-unused-data.sh +++ /dev/null @@ -1,11 +0,0 @@ -#!/usr/bin/env bash - -for i in */data/* -do -file=$(basename "$i") -if ! git grep -q "$file"; then -echo "WARNING: $i is not used, write a testcase for it!" -fi -done - -# vi:set shiftwidth=4 expandtab:
[Libreoffice-bugs] [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108770 Bug 108770 depends on bug 135716, which changed state. Bug 135716 Summary: FILESAVE DOCX Numbering highlight is not saved to DOCX https://bugs.documentfoundation.org/show_bug.cgi?id=135716 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135716] FILESAVE DOCX Numbering highlight is not saved to DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=135716 Justin L changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #9 from Justin L --- (In reply to NISZ LibreOffice Team from comment #0) > Steps to Reproduce: > 4. The numbering loses its yellow highlight, but does not get the new. > Numbering has no highlight color in Word. > Reopening the file in Writer sets the new highlight color on the numbering. As stated in comment 6, Not since 7.2 commit 873df086db969cadc66087a5abdb1ff33f2c99f1 > Expected Results: > Numbering should have the highlight color that is set on the UI. Above indicated that the UI doesn't set any highlight color. And that is precisely what we see in the round-trip in both Word and Writer. So, fixed, not NEW. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155392] Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 --- Comment #1 from haxel...@pm.me --- Created attachment 187381 --> https://bugs.documentfoundation.org/attachment.cgi?id=187381=edit Bug visuals -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155392] New: Not readable menu items in Windows 11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=155392 Bug ID: 155392 Summary: Not readable menu items in Windows 11 dark mode Product: LibreOffice Version: 7.5.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: haxel...@pm.me Description: Toggleable menu items in any view is barely readable in dark mode on Windows 11 22H2. Version: 7.5.3.2 (X86_64) / LibreOffice Community Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 24; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded ^ It says I run windows 10, but it's wrong. Steps to Reproduce: 1. Install latest LibreOffice in Windows 11 in dark mode. 2. Run LibreOffice Writer or any other. 3. Observe the bug when you select toggleable menu item. Actual Results: Hard-readable menu items. White text on white background. Expected Results: Readable menu items. Reproducible: Always User Profile Reset: No Additional Info: No other info. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page
https://bugs.documentfoundation.org/show_bug.cgi?id=120201 Bug 120201 depends on bug 155309, which changed state. Bug 155309 Summary: Help not found: Base forms - dialog Record Search. https://bugs.documentfoundation.org/show_bug.cgi?id=155309 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.