[Libreoffice-commits] core.git: external/coinmp

[Stephan Bergmann (via logerrit)]

 external/coinmp/UnpackedTarball_coinmp.mk |1 +
 external/coinmp/odr.patch |   30 ++
 2 files changed, 31 insertions(+)

New commits:
commit 0408e5344b5c43bc3384c264588e1d49770fd2dc
Author: Stephan Bergmann 
AuthorDate: Tue Jun 13 20:40:53 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Jun 14 07:24:36 2023 +0200

external/coinmap: Address ODR violations

...since 2193650b3373ee1889961cfb72d1fe97f73e2c23 "external/coinmp: Update 
to
CoinMP 1.8.4", as reported by 
,

> ==25531==ERROR: AddressSanitizer: odr-violation (0x7f3df9756e40):
>   [1] size=4 'CbcOrClpEnvironmentIndex' 
/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/coinmp/Clp/src/CbcOrClpParam.cpp:1236:5
>   [2] size=4 'CbcOrClpEnvironmentIndex' CbcOrClpParam.cpp:1236:5
> These globals were registered at these points:
>   [1]:
> #0 0x43e508 in __asan_register_globals.part.13 
/home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_globals.cpp:360
> #1 0x7f3df9252a6b in asan.module_ctor 
(/instdir/program/libCbcSolver.so.3+0x21fa6b)
> LLVMSymbolizer: error reading file: No such file or directory
> #2 0x7ffda20d8279  ([stack]+0x32279)
>
>   [2]:
> #0 0x43e508 in __asan_register_globals.part.13 
/home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_globals.cpp:360
> #1 0x7f3df4973a4b in asan.module_ctor 
(/instdir/program/libClpSolver.so.1+0x127a4b)
> #2 0x7ffda20d8279  ([stack]+0x32279)

and similarly for CbcOrClpRead_mode and CbcOrClpReadCommand.

There's code using those three extern variables in both libCbcSolver.so.3 
and
libClpSolver.so.1, and some of it is duplicated (in
workdir/UnpackedTarball/coinmp/Clp/src/CbcOrClpParam.cpp, which is also 
included
from workdir/UnpackedTarball/coinmp/Cbc/src/CbcCbcParam.cpp).  Those 
libraries
do not appear to make any use of symbol visibility hiding, and it is 
completely
unclear to me how all that code is actually meant to work.  But it also 
smells
like all that code is only used within standalone programs (see main in
workdir/UnpackedTarball/coinmp/Cbc/src/CoinSolve.cpp and
workdir/UnpackedTarball/coinmp/Clp/src/ClpMain.cpp).  So lets try to get 
away
with properly sharing those three extern variables across those two 
libraries.
Except on Windows, where linking the one library wouldn't find the extern
variables from the other library (and I'm not sure whether that's a general
issue on Windows, or is due to how 2193650b3373ee1889961cfb72d1fe97f73e2c23
modified external/coinmp/windows.build.patch.1).

(This also appears to be fixed on recent upstream;
 no longer mentions any of those three 
extern
variables.  Maybe a new tarball will eventually appear at
 that includes a proper fix 
of
these ODR violations.)

Change-Id: I953c7dc31f8e35315c59dc2bedd3fdf780579638
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153001
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/coinmp/UnpackedTarball_coinmp.mk 
b/external/coinmp/UnpackedTarball_coinmp.mk
index 75fa5aaf653a..83ebfca80193 100644
--- a/external/coinmp/UnpackedTarball_coinmp.mk
+++ b/external/coinmp/UnpackedTarball_coinmp.mk
@@ -46,6 +46,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,coinmp,\
external/coinmp/pedantic-errors.patch \
external/coinmp/bind2nd.patch.1 \
external/coinmp/clang-with-path.patch \
+   external/coinmp/odr.patch \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/coinmp/odr.patch b/external/coinmp/odr.patch
new file mode 100644
index ..6e91c86415d2
--- /dev/null
+++ b/external/coinmp/odr.patch
@@ -0,0 +1,30 @@
+--- Cbc/src/CbcSolver.cpp
 Cbc/src/CbcSolver.cpp
+@@ -970,8 +970,13 @@
+   this set of calls thread-safe.
+ */
+ 
++#if defined _MSC_VER
+ int CbcOrClpRead_mode = 1;
+ FILE * CbcOrClpReadCommand = stdin;
++#else
++extern int CbcOrClpRead_mode;
++extern FILE * CbcOrClpReadCommand;
++#endif
+ extern int CbcOrClpEnvironmentIndex;
+ 
+ int callCbc1(const char * input2, CbcModel & model,
+--- Clp/src/CbcOrClpParam.cpp
 Clp/src/CbcOrClpParam.cpp
+@@ -1233,7 +1233,11 @@
+ static char line[1000];
+ static char * where = NULL;
+ extern int CbcOrClpRead_mode;
++#if defined _MSC_VER || !defined COIN_HAS_CBC
+ int CbcOrClpEnvironmentIndex = -1;
++#else
++extern int CbcOrClpEnvironmentIndex;
++#endif
+ static size_t fillEnv()
+ {
+ #if defined(_MSC_VER) || defined(__MSVCRT__)

[Libreoffice-bugs] [Bug 155750] Error activating object General OLE error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155750

--- Comment #3 from Kadet  ---
It is a pity that so far none of the developers have paid attention to this
error.
My five-year work is based on using the capabilities of OLE attachments and
five programs and databases have been written.
It will be a pity if this error persists in the future and the possibility of
using OLE attachments in Base forms will be impossible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107906] The arrows don't respect their path when resized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107906

Diana Vides  changed:

   What|Removed |Added

 CC||dianavide...@gmail.com

--- Comment #8 from Diana Vides  ---
Unfortunately, It is still happening in Version: 7.5.3.2 (X86_64) / LibreOffice
Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 6; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: es-ES (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155798] Changes to scale don't update rulers immediately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155798

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155563] Practically no visual effect for selected, and non selected, {Don't save, cancel, save} Save document? window buttons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155563

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155798] Changes to scale don't update rulers immediately

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155798

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118945] PRINTING When print some signed document the paper version does not show any info about the signatures

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118945

--- Comment #13 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118945] PRINTING When print some signed document the paper version does not show any info about the signatures

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118945

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141274] Error Saving Document When Picture Pasted from Spectacle

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141274

--- Comment #6 from QA Administrators  ---
Dear Sarah Szabo,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147321] Applied text shadow disappears upon save and reload

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147321

--- Comment #2 from QA Administrators  ---
Dear milton.mendonca71,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152510] crash when I resize one libre office window and I have other window open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152510

--- Comment #3 from QA Administrators  ---
Dear Paolo Fiorito,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144108] Calc application color changes inconsistent.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144108

--- Comment #6 from QA Administrators  ---
Dear Ruven Gottlieb,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91769] Move up and down buttons work for paragraphs without list too, but only available on toolbar Bullets and Numbering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91769

--- Comment #11 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71920] FORMATTING: Text is not shown behind frame set to 'Wrap Through' and with fill set to None (see comment 10 for implementation rqmt)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71920

--- Comment #17 from QA Administrators  ---
Dear Harald Koester,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #18 from QA Administrators  ---
Dear Harald Koester,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90656] Metadata in Word 6 imported with wrong encoding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90656

--- Comment #12 from QA Administrators  ---
Dear Karl Ove Hufthammer,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128273] FORMATTING Calc changes a number format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128273

--- Comment #12 from QA Administrators  ---
Dear Fred,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124673] why toggle function DrawText, HyperlinkDialog and Horizontal Line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124673

--- Comment #17 from QA Administrators  ---
Dear andreas_k,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116804] [Impress, Slideshow, FILEOPEN]: Command Line Switch To Open In Windowed Mode Slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116804

--- Comment #6 from QA Administrators  ---
Dear Nick,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116720] LibreOffice Calc does not read its own HTML attributes (save as)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116720

--- Comment #9 from QA Administrators  ---
Dear chris,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103967] DOC import: Empty table cell has wrong font size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103967

--- Comment #14 from QA Administrators  ---
Dear Justin L,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 2 commits - oox/Library_oox.mk oox/source svgio/Library_svgio.mk svgio/source

[Tomaž Vajngerl (via logerrit)]

Rebased ref, commits from common ancestor:
commit 80773825cc2af1aa9862e7503e20110a850fdd8d
Author: Tomaž Vajngerl 
AuthorDate: Wed Jun 14 11:48:51 2023 +0900
Commit: Tomaž Vajngerl 
CommitDate: Wed Jun 14 11:48:51 2023 +0900

oox: use frozen unordered_map for static data

Change-Id: I4a53fa57f52900104d249c84cde36c9d3b9e1300

diff --git a/oox/Library_oox.mk b/oox/Library_oox.mk
index b878089027b1..3bf2d607918c 100644
--- a/oox/Library_oox.mk
+++ b/oox/Library_oox.mk
@@ -65,6 +65,7 @@ $(eval $(call gb_Library_use_libraries,oox,\
 
 $(eval $(call gb_Library_use_externals,oox,\
boost_headers \
+   frozen \
 ))
 
 ifeq ($(TLS),OPENSSL)
diff --git a/oox/source/drawingml/color.cxx b/oox/source/drawingml/color.cxx
index ad0b5ca7835e..6660c6bd2660 100644
--- a/oox/source/drawingml/color.cxx
+++ b/oox/source/drawingml/color.cxx
@@ -19,7 +19,9 @@
 
 #include 
 #include 
-#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -214,39 +216,40 @@ void lclOffValue( sal_Int32& ornValue, sal_Int32 nOff, 
sal_Int32 nMax = MAX_PERC
 ornValue = getLimitedValue< sal_Int32, sal_Int32 >( ornValue + nOff, 0, 
nMax );
 }
 
+static constexpr frozen::unordered_map aSchemeColorNameToIndex
+{
+{ u"dk1", model::ThemeColorType::Dark1 },
+{ u"lt1", model::ThemeColorType::Light1 },
+{ u"dk2", model::ThemeColorType::Dark2 },
+{ u"lt2", model::ThemeColorType::Light2 },
+{ u"accent1", model::ThemeColorType::Accent1 },
+{ u"accent2", model::ThemeColorType::Accent2 },
+{ u"accent3", model::ThemeColorType::Accent3 },
+{ u"accent4", model::ThemeColorType::Accent4 },
+{ u"accent5", model::ThemeColorType::Accent5 },
+{ u"accent6", model::ThemeColorType::Accent6 },
+{ u"hlink", model::ThemeColorType::Hyperlink },
+{ u"folHlink", model::ThemeColorType::FollowedHyperlink },
+{ u"tx1", model::ThemeColorType::Dark1 },
+{ u"bg1", model::ThemeColorType::Light1 },
+{ u"tx2", model::ThemeColorType::Dark2 },
+{ u"bg2", model::ThemeColorType::Light2 },
+{ u"dark1", model::ThemeColorType::Dark1},
+{ u"light1", model::ThemeColorType::Light1},
+{ u"dark2", model::ThemeColorType::Dark2 },
+{ u"light2", model::ThemeColorType::Light2 },
+{ u"text1", model::ThemeColorType::Dark1 },
+{ u"background1", model::ThemeColorType::Light1 },
+{ u"text2", model::ThemeColorType::Dark2 },
+{ u"background2", model::ThemeColorType::Light2 },
+{ u"hyperlink", model::ThemeColorType::Hyperlink },
+{ u"followedHyperlink", model::ThemeColorType::FollowedHyperlink }
+};
+
 } // namespace
 
 model::ThemeColorType schemeNameToThemeColorType(OUString const& rSchemeName)
 {
-static std::unordered_map const 
aSchemeColorNameToIndex{
-{ u"dk1", model::ThemeColorType::Dark1 },
-{ u"lt1", model::ThemeColorType::Light1 },
-{ u"dk2", model::ThemeColorType::Dark2 },
-{ u"lt2", model::ThemeColorType::Light2 },
-{ u"accent1", model::ThemeColorType::Accent1 },
-{ u"accent2", model::ThemeColorType::Accent2 },
-{ u"accent3", model::ThemeColorType::Accent3 },
-{ u"accent4", model::ThemeColorType::Accent4 },
-{ u"accent5", model::ThemeColorType::Accent5 },
-{ u"accent6", model::ThemeColorType::Accent6 },
-{ u"hlink", model::ThemeColorType::Hyperlink },
-{ u"folHlink", model::ThemeColorType::FollowedHyperlink },
-{ u"tx1", model::ThemeColorType::Dark1 },
-{ u"bg1", model::ThemeColorType::Light1 },
-{ u"tx2", model::ThemeColorType::Dark2 },
-{ u"bg2", model::ThemeColorType::Light2 },
-{ u"dark1", model::ThemeColorType::Dark1},
-{ u"light1", model::ThemeColorType::Light1},
-{ u"dark2", model::ThemeColorType::Dark2 },
-{ u"light2", model::ThemeColorType::Light2 },
-{ u"text1", model::ThemeColorType::Dark1 },
-{ u"background1", model::ThemeColorType::Light1 },
-{ u"text2", model::ThemeColorType::Dark2 },
-{ u"background2", model::ThemeColorType::Light2 },
-{ u"hyperlink", model::ThemeColorType::Hyperlink },
-{ u"followedHyperlink", model::ThemeColorType::FollowedHyperlink}
-};
-
 auto aIterator = aSchemeColorNameToIndex.find(rSchemeName);
 if (aIterator == aSchemeColorNameToIndex.end())
 return model::ThemeColorType::Unknown;
diff --git a/oox/source/drawingml/colorchoicecontext.cxx 
b/oox/source/drawingml/colorchoicecontext.cxx
index b0977c5e003c..04b9f996d8d5 100644
--- a/oox/source/drawingml/colorchoicecontext.cxx
+++ b/oox/source/drawingml/colorchoicecontext.cxx
@@ -24,13 +24,16 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 
 namespace oox::drawingml {
 
 namespace
 {
 
-const std::unordered_map 
constSystemColorMap =
+static constexpr frozen::unordered_map 
constSystemColorMap
 {
 { XML_scrollBar, model::SystemColorType::ScrollBar },
 { XML_background, 

[Libreoffice-commits] core.git: sd/source

[Jim Raykowski (via logerrit)]

 sd/source/ui/dlg/sdtreelb.cxx |   22 ++
 1 file changed, 2 insertions(+), 20 deletions(-)

New commits:
commit ec60d354359067f8c5c686ef2239ee705916de43
Author: Jim Raykowski 
AuthorDate: Sat Jun 10 17:16:29 2023 -0800
Commit: Jim Raykowski 
CommitDate: Wed Jun 14 03:54:21 2023 +0200

SdNavigator: Improve unique name detection

Commit ace75043781b5fe36546ec75574a14617f4feb30 added the ability to
rename page and object names from the Navigator. An approach that
searches entry names in the tree was used to check for unique naming.
This does not guarantee uniquess as the name may already be used
for an object in another view, for example, Notes view. This
patch guarantees name uniqueness by checking the document model to
see if an object with the name already exists.

Change-Id: Iad419420d6010b94380c55b7dc71a8d4abbec784
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152843
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index 45b078df0cb0..56e93bd7dfe0 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -783,27 +783,9 @@ IMPL_LINK(SdPageObjsTLV, EditedEntryHdl, const 
IterString&, rIterString, bool)
 return true;
 
 // If the new name is empty or not unique, start editing again.
-bool bUniqueName = true;
-std::unique_ptr xEntry(m_xTreeView->make_iterator());
-if (!rIterString.second.isEmpty())
-{
-if (m_xTreeView->get_iter_first(*xEntry))
-{
-do
-{
-// skip self!
-if (m_xTreeView->iter_compare(*xEntry, rIterString.first) != 0 
&&
-m_xTreeView->get_text(*xEntry) == rIterString.second)
-{
-bUniqueName = false;
-break;
-}
-} while(m_xTreeView->iter_next(*xEntry));
-}
-}
-if (rIterString.second.isEmpty() || !bUniqueName)
+if (rIterString.second.isEmpty() || m_pDoc->GetObj(rIterString.second))
 {
-m_xTreeView->copy_iterator(rIterString.first, *xEntry);
+std::unique_ptr 
xEntry(m_xTreeView->make_iterator());
 Application::PostUserEvent(LINK(this, SdPageObjsTLV, EditEntryAgain), 
xEntry.release());
 return false;
 }

[Libreoffice-commits] core.git: sw/source

[Paris Oplopoios (via logerrit)]

 sw/source/ui/misc/pagenumberdlg.cxx|   32 +---
 sw/source/uibase/inc/pagenumberdlg.hxx |1 +
 2 files changed, 26 insertions(+), 7 deletions(-)

New commits:
commit 63627c174778f7d435a540c43ec0498c76e739ab
Author: Paris Oplopoios 
AuthorDate: Wed Jun 14 01:49:07 2023 +0300
Commit: Paris Oplopoios 
CommitDate: Wed Jun 14 01:47:47 2023 +0200

Remove hardcoded values in pagenumberdlg

Removed hardcoded text width/heights and margins in pagenumberdlg to
create the preview image and also added a different text preview for
IncludePageTotal mode

Change-Id: Ib4f4f9ba702f87babf13c1435dc3845add1f43cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153030
Tested-by: Jenkins
Reviewed-by: Paris Oplopoios 

diff --git a/sw/source/ui/misc/pagenumberdlg.cxx 
b/sw/source/ui/misc/pagenumberdlg.cxx
index 1b5084c5e94b..fe965d69db19 100644
--- a/sw/source/ui/misc/pagenumberdlg.cxx
+++ b/sw/source/ui/misc/pagenumberdlg.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 
 SwPageNumberDlg::SwPageNumberDlg(weld::Window* pParent)
 : SfxDialogController(pParent, "modules/swriter/ui/pagenumberdlg.ui", 
"PageNumberDialog")
@@ -49,6 +50,7 @@ SwPageNumberDlg::SwPageNumberDlg(weld::Window* pParent)
 
SvxNumOptionsTabPageHelper::GetI18nNumbering(m_xPageNumberTypeLB->get_widget(),
  
::std::numeric_limits::max());
 m_xPageNumberTypeLB->connect_changed(LINK(this, SwPageNumberDlg, 
NumberTypeSelectHdl));
+m_xIncludePageTotal->connect_toggled(LINK(this, SwPageNumberDlg, 
IncludePageTotalChangeHdl));
 updateImage();
 }
 
@@ -76,6 +78,11 @@ IMPL_LINK_NOARG(SwPageNumberDlg, NumberTypeSelectHdl, 
weld::ComboBox&, void)
 m_nPageNumberType = m_xPageNumberTypeLB->get_active_id();
 }
 
+IMPL_LINK_NOARG(SwPageNumberDlg, IncludePageTotalChangeHdl, weld::Toggleable&, 
void)
+{
+updateImage();
+}
+
 bool SwPageNumberDlg::GetMirrorOnEvenPages()
 {
 return m_xMirrorOnEvenPages->get_sensitive()
@@ -98,8 +105,7 @@ void SwPageNumberDlg::updateImage()
 int nBackgroundWidth = 75;
 int nBackgroundHeight = 105;
 
-int nSpriteWidth = 10;
-int nSpriteHeight = 14;
+int nMargin = 7;
 
 ScopedVclPtrInstance pVirtualDev;
 Size aVDSize(nBackgroundWidth, nBackgroundHeight);
@@ -107,17 +113,29 @@ void SwPageNumberDlg::updateImage()
 pVirtualDev->SetBackground(Color(0xF0, 0xF0, 0xF0));
 pVirtualDev->Erase();
 
-int y = m_aPageNumberPosition ? (nBackgroundHeight - nSpriteHeight - 5) : 
5;
-int x = 5;
+OUString sText = "#";
+
+if (m_xIncludePageTotal->get_state() == TRISTATE_TRUE)
+{
+sText += " / #";
+}
+
+DrawTextFlags eFlags = DrawTextFlags::Left;
+
 if (m_aPageNumberAlignment == 1)
 {
-x = (nBackgroundWidth - nSpriteWidth) / 2;
+eFlags = DrawTextFlags::Center;
 }
 else if (m_aPageNumberAlignment == 2)
 {
-x = nBackgroundWidth - nSpriteWidth - 5;
+eFlags = DrawTextFlags::Right;
 }
-pVirtualDev->DrawText(Point(x, y), "#");
+
+eFlags |= m_aPageNumberPosition ? DrawTextFlags::Bottom : 
DrawTextFlags::Top;
+
+pVirtualDev->DrawText(
+tools::Rectangle(nMargin, nMargin, nBackgroundWidth - nMargin, 
nBackgroundHeight - nMargin),
+sText, eFlags);
 
 m_xPreviewImage->set_image(pVirtualDev);
 }
diff --git a/sw/source/uibase/inc/pagenumberdlg.hxx 
b/sw/source/uibase/inc/pagenumberdlg.hxx
index cf719b492a33..169c9209dbf5 100644
--- a/sw/source/uibase/inc/pagenumberdlg.hxx
+++ b/sw/source/uibase/inc/pagenumberdlg.hxx
@@ -42,6 +42,7 @@ class SwPageNumberDlg final : public SfxDialogController
 SvxNumType m_nPageNumberType;
 
 DECL_LINK(OkHdl, weld::Button&, void);
+DECL_LINK(IncludePageTotalChangeHdl, weld::Toggleable&, void);
 DECL_LINK(PositionSelectHdl, weld::ComboBox&, void);
 DECL_LINK(AlignmentSelectHdl, weld::ComboBox&, void);
 DECL_LINK(NumberTypeSelectHdl, weld::ComboBox&, void);

[Libreoffice-bugs] [Bug 128966] Writer table: Center Vertically shows some rows as Align Top (click-in restores until next fileopen) (see comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128966

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||5773

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120275] [META] Writer table alignment bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120275

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||155773


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155773
[Bug 155773] Table contents are not rendered centered on odt fileopen until
refresh
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155773] Table contents are not rendered centered on odt fileopen until refresh

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155773

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Severity|normal  |minor
 Blocks||120275
Version|7.5.4.2 release |Inherited From OOo
Summary|6, 9, # are not centered on |Table contents are not
   |odt file|rendered centered on odt
   ||fileopen until refresh
 CC||stephane.guillou@libreoffic
   ||e.org
   Priority|medium  |low
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8966

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Confirmed also in OOo 3.3, so marking as inherited.

Clicking in the third column restores the alignment, which is similar to bug
128966. Alternatively, changing the zoom level restores it too.
Save and then reload: the vertical shift reappears.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120275
[Bug 120275] [META] Writer table alignment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125544] Table cell alignment is recalculated on opening documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125544

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|unspecified |5.1.0.3 release
   Keywords||bibisectRequest, regression

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
This is a regression starting in 5.1.0.1 (tested with linux-64-releases
bibisect repo)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 63136] table cell is set to align=bottom, but cell contents are at top

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63136

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|4.0.2.2 release |Inherited From OOo
 OS|Linux (All) |All
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
I can reproduce the original issue only by changing the alignment to top, then
trying to align back to the bottom of the cell: the content stays at the top.

Inherited from LO, and also in a recent master build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3a6d360b5e585b8e92cc0d58d5fbc497448e11fb
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155804] Row-wise and/or column-wise merge in 2D area

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155804

--- Comment #2 from Eyal Rozenberg  ---
(In reply to ady from comment #1)

But I don't want to copy-paste one row into the rest, each row has its own
contents.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - external/nss

[Thorsten Behrens (via logerrit)]

 external/nss/UnpackedTarball_nss.mk |1 +
 external/nss/nss-std-string.patch.1 |   15 +++
 2 files changed, 16 insertions(+)

New commits:
commit ab7719c026386a352d1bb62e98cdbb881c46ed4f
Author: Thorsten Behrens 
AuthorDate: Wed Jun 14 01:00:36 2023 +0200
Commit: Thorsten Behrens 
CommitDate: Wed Jun 14 01:00:36 2023 +0200

Fix nss build for devtoolset-7 string erase

Error was: nss_bogo_shim.cc:43:66: error: no matching function for
call to ‘std::basic_string

Change-Id: I357d61fcb6299ac87edac2229a1a134199e7d37a

diff --git a/external/nss/UnpackedTarball_nss.mk 
b/external/nss/UnpackedTarball_nss.mk
index e77f92341d91..04d098cadc19 100644
--- a/external/nss/UnpackedTarball_nss.mk
+++ b/external/nss/UnpackedTarball_nss.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,nss,\
 external/nss/nss-win32-make.patch.1 \
 external/nss/ubsan.patch.0 \
 external/nss/clang-cl.patch.0 \
+external/nss/nss-std-string.patch.1 \
 external/nss/nss.vs2015.patch \
 external/nss/nss.vs2015.pdb.patch \
 $(if $(filter iOS,$(OS)), \
diff --git a/external/nss/nss-std-string.patch.1 
b/external/nss/nss-std-string.patch.1
new file mode 100644
index ..2669cfb51a4a
--- /dev/null
+++ b/external/nss/nss-std-string.patch.1
@@ -0,0 +1,15 @@
+diff -ur nss.org/nss/gtests/nss_bogo_shim/nss_bogo_shim.cc 
nss/nss/gtests/nss_bogo_shim/nss_bogo_shim.cc
+--- nss.org/nss/gtests/nss_bogo_shim/nss_bogo_shim.cc  2023-06-13 
22:06:35.757518272 +0200
 nss/nss/gtests/nss_bogo_shim/nss_bogo_shim.cc  2023-06-13 
22:06:50.521508892 +0200
+@@ -40,8 +40,8 @@
+ }
+ 
+ static void StringRemoveNewlines(std::string& str) {
+-  str.erase(std::remove(str.begin(), str.end(), '\n'), str.cend());
+-  str.erase(std::remove(str.begin(), str.end(), '\r'), str.cend());
++  str.erase(std::remove(str.begin(), str.end(), '\n'), str.end());
++  str.erase(std::remove(str.begin(), str.end(), '\r'), str.end());
+ }
+ 
+ class TestAgent {
+Only in nss/nss/gtests/nss_bogo_shim: nss_bogo_shim.cc~

[Libreoffice-bugs] [Bug 155825] Crash MCGR export special file odp -> pptx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155825

--- Comment #2 from Regina Henschel  ---
Created attachment 187901
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187901=edit
axial color mixed with linear transparency

Axial plus linear is indeed a problem. The attached file has a shape with both
gradients with stops at offset 0 and 1 (so do not trigger the crash) and a
screenshot of the shape. Save the file to pptx and open the pptx-file. You see
the error immediately.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155825] Crash MCGR export special file odp -> pptx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155825

--- Comment #1 from Regina Henschel  ---
Created attachment 187900
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187900=edit
reduced example

The error is in synchronizeColorStops in gradienttools.cxx in lines 440 to 454.

In both cases not only aNewAlpha (or aNewColor respectively), has to get the
stop but aNewColor (or aNewAlpha respectively) too. The both aNew... need to
grow simultaneously.

The situation in the example is, that the offsets for the colors are 0 and 0.9,
and for the transparency 0 and 1. The generated aNewColor and aNewAlpha both
need the stops 0, 0.9 and 1.

[Looking at the code, I'm not sure whether the combination of axial and linear
is handled correctly. (In the following the Number is the offset and the
characters are the values.)
Imagine a axial color gradient with 0 A, 1 B together with a linear
transparency gradient 0 X, 1 Y. Then the resulting stops should be 0 BX, 0.5 A
middle_of_XY, 1 BY. But because you apply axial after synchronizing you get 0
BY, 0.5 AX, 1 BY.
But I'm not sure and its after midnight so would need to look at it tomorrow
again.]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154044] Undoing the first applied cell formatting only works for column A

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154044

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3644

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153913] FILESAVE / FORMATTING: Failure to save / progressive loss of cell background colour of otherwise empty cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153913

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3644

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153644] Calc: Undo doesn't remove cell's borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153644

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
Version|7.4.5.1 release |7.4.0.0 beta1+
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||4044,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3913

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153913] FILESAVE / FORMATTING: Failure to save / progressive loss of cell background colour of otherwise empty cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153913

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |4066|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105948

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|154066  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154066
[Bug 154066] Unable to undo attributes part of cell's area
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153644] Calc: Undo doesn't remove cell's borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153644

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||nfsmob...@mail.ru

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
*** Bug 154066 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154066] Unable to undo attributes part of cell's area

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154066

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
Version|7.4.3.2 release |7.4.0.0 beta1+
 Blocks|105948  |
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |3913|

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
With core commit 9e2d48b9e04f7ea895fb095699c32ed8a44eb129, the issue started
with the inability to apply formatting to the whole of a cell range that does
not contain data in its edges.
Behaviour as described in comment 2 was bibisected with linux-64-7.4 repo to
commit ecdde2cb463610623dc25454f67ba99bb8c86fca which points to core commit:

commit  970ff17f47731be788ec34c0c8ddf3fb2c24ceac
author  Luboš Luňák  Mon May 30 16:33:15 2022 +0200
committer   Luboš Luňák  Mon May 30 21:20:54
2022 +0200
fix setting cell borders for unallocated cells
First of all, it should not be clamped to allocated columns. Second,
06d3294502413a231e5c5265609862c7f67a2f2b incorrectly handled
unallocated columns by setting the attribute for all rows, instead
of handling the inner ones differently.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135131

So, first commit broke things, second commit was a partial fix.

Still same root cause as bug 154044, but marking as duplicate of bug 153644
instead as the bibisect and description match.

*** This bug has been marked as a duplicate of bug 153644 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105948
[Bug 105948] [META] Undo/Redo bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100156

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||154072


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=154072
[Bug 154072] crash / no effect when clicking some dropdown buttons when toolbar
overflows
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154072] crash / no effect when clicking some dropdown buttons when toolbar overflows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154072

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||100156


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100156
[Bug 100156] [META] Wayland-related bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154072] crash / no effect when clicking some dropdown buttons when toolbar overflows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154072

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
Created attachment 187899
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187899=edit
wayland debug log

In a wayland debug log collected with:

WAYLAND_DEBUG=1 libreofficedev7.6 >& lo-wayland-log.txt

I can see:

[3812106.409] wl_display@1.error(xdg_wm_base@24, 3, "Invalid popup parent
window")

This validation seems to have been added to mutter with:

https://mail.gnome.org/archives/commits-list/2020-August/msg10980.html

The commit message says it is a client error:

"Calling `get_popup` on an unmapped window is a client bug, thus post a
protocol error when this happens."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140147] Position of cursor not saved correctly (see comment 46 for bibisect)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140147

--- Comment #65 from V Stuart Foote  ---
*** Bug 155824 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155824] documents never open up where I left off.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155824

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #2 from V Stuart Foote  ---
Beleive bug 140147 is the closer dupe

*** This bug has been marked as a duplicate of bug 140147 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154072] crash / no effect when clicking some dropdown buttons when toolbar overflows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154072

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Created attachment 187898
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187898=edit
gdb backtrace with LO 7.6 alpha1+ debug, "no stack"

I could crash a debug build using the steps in comment 3, but couldn't collect
a trace.

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 7e3ddf1e5aae5e4e956495e3d86a8cbf6e251b5e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In the console I see:

Gdk-Message: 23:37:44.155: Error 71 (Protocol error) dispatching to Wayland
display.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141586] Restoring last document position is unreliable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141586

m.a.riosv  changed:

   What|Removed |Added

 CC||spjggvlksniwaor...@bbitq.co
   ||m

--- Comment #32 from m.a.riosv  ---
*** Bug 155824 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155824] documents never open up where I left off.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155824

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |DUPLICATE

--- Comment #1 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 141586 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154168

--- Comment #12 from Commit Notification 
 ---
Paris Oplopoios committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/e691869486cd4ee4ee1dfb8f7a41440f7f6500fd

tdf#154168 Export no transparency PNGs correctly

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154168

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0   |target:24.2.0
   ||target:7.6.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 2 commits - basegfx/source drawinglayer/source filter/source include/basegfx include/svx include/vcl oox/source svx/source vcl/source

[Armin Le Grand (allotropia) (via logerrit)]

 basegfx/source/tools/bgradient.cxx |  137 
 drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx |  188 +---
 filter/source/svg/svgexport.cxx|3 
 filter/source/svg/svgwriter.cxx|  198 +++--
 filter/source/svg/svgwriter.hxx|   10 
 include/basegfx/utils/bgradient.hxx|   17 +
 include/svx/svdxcgv.hxx|6 
 include/vcl/bitmapex.hxx   |1 
 include/vcl/gdimtf.hxx |7 
 include/vcl/metaact.hxx|   11 
 oox/source/export/drawingml.cxx|   56 ---
 svx/source/svdraw/svdxcgv.cxx  |4 
 vcl/source/bitmap/BitmapEx.cxx |5 
 vcl/source/control/fmtfield.cxx|2 
 vcl/source/filter/png/PngImageWriter.cxx   |8 
 vcl/source/filter/svm/SvmReader.cxx|   21 +
 vcl/source/filter/svm/SvmWriter.cxx|   23 +
 vcl/source/gdi/gdimtf.cxx  |9 
 vcl/source/gdi/metaact.cxx |5 
 19 files changed, 535 insertions(+), 176 deletions(-)

New commits:
commit 9b8c21acd31f08a0c3f8d88ddac57c80ef5997a1
Author: Armin Le Grand (allotropia) 
AuthorDate: Mon Jun 5 17:15:34 2023 +0200
Commit: Xisco Fauli 
CommitDate: Tue Jun 13 23:20:41 2023 +0200

MCGR: tdf#155479 repair gradient SVG export for MCGR

Unfortunately SVG export is based on metafiles and thus there
is (in principle) no way to get the BGradient/ColorStop/MCGR
data transfered as needed. For that, using UNO API to read the
model or using B2DPrimitives would help - as is better for the
export respectively.

Since there is not the time to re-design SVG export I added
this 'compromize' as a fix. It gets the needed data transported
over the metafile (that part is the compromize). It then
exports the MCGR data to SVG (at least - as was already there -
if it's a linear/axial gradient). This happens now with all
Gradient Stops when there is a MCGR gradient. That part is/will
hopefully be re-usable if SVG export  gets redesigned.

I also added a handling for StepCount feature, so when used (in
LO, others do not have that) 'hard' color stops get generated
to make the gradient look identical for SVG export.

Had to make adding of that extra-information in metafiles
dependent on exporting really to SVG. There are 51 cases which
use 'MetaActionType::COMMENT' which would potentially have
to be adapted.

Also added code to solve the problem for TransparencePrimitive2D
at VclMetafileProcessor2D::processTransparencePrimitive2D. This
will now - also only for SVG export - directly create the needed
MetaFloatTransparentAction and add additional MCGR information.
This will be used on SVG export to write a 'Mask' as was done
before. This is now capable of creating fill MCGR-Masks in
the sense that any number of TransparencyStops will be supported.

Change-Id: Ic6d022714eae96b8fbc09e60652851ac5799b757
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152623
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 
(cherry picked from commit a6e72e2b314e64f3199f3eaf1ecf78157446f6dd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152882
Reviewed-by: Xisco Fauli 

diff --git a/basegfx/source/tools/bgradient.cxx 
b/basegfx/source/tools/bgradient.cxx
index b56ef0540d17..c96cd0b673cb 100644
--- a/basegfx/source/tools/bgradient.cxx
+++ b/basegfx/source/tools/bgradient.cxx
@@ -679,6 +679,117 @@ bool BColorStops::isSymmetrical() const
 return aIter > aRIter;
 }
 
+void BColorStops::doApplyAxial()
+{
+// preapare new ColorStops
+basegfx::BColorStops aNewColorStops;
+
+// add gradient stops in reverse order, scaled to [0.0 .. 0.5]
+basegfx::BColorStops::const_reverse_iterator aRevCurrColor(rbegin());
+
+while (aRevCurrColor != rend())
+{
+aNewColorStops.emplace_back((1.0 - aRevCurrColor->getStopOffset()) * 
0.5,
+aRevCurrColor->getStopColor());
+aRevCurrColor++;
+}
+
+// prepare non-reverse run
+basegfx::BColorStops::const_iterator aCurrColor(begin());
+
+if (basegfx::fTools::equalZero(aCurrColor->getStopOffset()))
+{
+// Caution: do not add 1st entry again, that would be double since it 
was
+// already added as last element of the inverse run above. But only if
+// the gradient has a start entry for 0.0 aka StartColor, else it is 
correct.
+aCurrColor++;
+}
+
+// add gradient stops in non-reverse order, translated and scaled to [0.5 
.. 1.0]
+while 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 3 commits - filter/source oox/source sw/qa sw/source writerfilter/source

[Caolán McNamara (via logerrit)]

 filter/source/svg/svgexport.cxx |7 -
 oox/source/drawingml/textcharacterproperties.cxx|2 
 oox/source/token/properties.txt |1 
 sw/qa/extras/ooxmlexport/data/Test_CharUnderlineThemeColor.docx |binary
 sw/qa/extras/ooxmlexport/ooxml_ThemeExport.cxx  |   16 +++
 sw/source/filter/ww8/docxattributeoutput.cxx|   10 +-
 writerfilter/source/dmapper/DomainMapper.cxx|   42 
++
 writerfilter/source/dmapper/PropertyIds.cxx |1 
 writerfilter/source/dmapper/PropertyIds.hxx |1 
 9 files changed, 74 insertions(+), 6 deletions(-)

New commits:
commit 1757415b4f1d81a3445c1cc9cd353ffb98d1ce22
Author: Caolán McNamara 
AuthorDate: Mon Jun 12 12:10:09 2023 +0100
Commit: Xisco Fauli 
CommitDate: Tue Jun 13 23:20:26 2023 +0200

cannot export selected fontwork in writer to svg

Background property isn't supported

Change-Id: Ic8c5ff979d16a328fece5b4b2f87c85348606bce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152896
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit b1b3c70f1f16f02a83e23d2b0265bc97b0188a11)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152917
Reviewed-by: Xisco Fauli 

diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx
index fab15a59a2e3..776643a9740d 100644
--- a/filter/source/svg/svgexport.cxx
+++ b/filter/source/svg/svgexport.cxx
@@ -2329,7 +2329,8 @@ bool SVGFilter::implCreateObjects()
 if( xPropSet.is() )
 {
 Reference< XPropertySet > xBackground;
-xPropSet->getPropertyValue( "Background" ) >>= xBackground;
+if 
(xPropSet->getPropertySetInfo()->hasPropertyByName("Background"))
+xPropSet->getPropertyValue( "Background" ) >>= xBackground;
 if( xBackground.is() )
 {
 drawing::FillStyle aFillStyle;
commit f4c42593c683a0e05a5d251f8e5af09b12d1a8bc
Author: Tomaž Vajngerl 
AuthorDate: Sun Jun 11 00:50:08 2023 +0900
Commit: Xisco Fauli 
CommitDate: Tue Jun 13 23:20:19 2023 +0200

ooxml: import and export char underline theme colors

This adds support to import and export char underline theme color
properties.

Change-Id: Ia8948ee5aacd20e0c2b7cbb1b2fdf97fc65c04e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152834
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 953ef30494661788b2e980ece84b62c653d77321)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152974
Reviewed-by: Xisco Fauli 

diff --git a/oox/source/drawingml/textcharacterproperties.cxx 
b/oox/source/drawingml/textcharacterproperties.cxx
index 0e1e2830a67f..1217c19441ae 100644
--- a/oox/source/drawingml/textcharacterproperties.cxx
+++ b/oox/source/drawingml/textcharacterproperties.cxx
@@ -206,6 +206,8 @@ void TextCharacterProperties::pushToPropMap( PropertyMap& 
rPropMap, const XmlFil
 {
 rPropMap.setProperty( PROP_CharUnderlineHasColor, true);
 rPropMap.setProperty( PROP_CharUnderlineColor, 
maUnderlineColor.getColor( rFilter.getGraphicHelper() ));
+model::ComplexColor aComplexColor = maUnderlineColor.getComplexColor();
+rPropMap.setProperty( PROP_CharUnderlineComplexColor, 
model::color::createXComplexColor(aComplexColor));
 }
 else
 {
diff --git a/oox/source/token/properties.txt b/oox/source/token/properties.txt
index 40988ffb0222..025b0628b9d8 100644
--- a/oox/source/token/properties.txt
+++ b/oox/source/token/properties.txt
@@ -91,6 +91,7 @@ CharStyleName
 CharTransparence
 CharUnderline
 CharUnderlineColor
+CharUnderlineComplexColor
 CharUnderlineHasColor
 CharWeight
 CharWeightAsian
diff --git a/sw/qa/extras/ooxmlexport/data/Test_CharUnderlineThemeColor.docx 
b/sw/qa/extras/ooxmlexport/data/Test_CharUnderlineThemeColor.docx
new file mode 100644
index ..3ee3cdf457f0
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/Test_CharUnderlineThemeColor.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxml_ThemeExport.cxx 
b/sw/qa/extras/ooxmlexport/ooxml_ThemeExport.cxx
index 3804f4606187..f9e7155859ea 100644
--- a/sw/qa/extras/ooxmlexport/ooxml_ThemeExport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxml_ThemeExport.cxx
@@ -81,6 +81,22 @@ DECLARE_SW_ROUNDTRIP_TEST(testThemePortionBorderColor_DOCX, 
"Test_ThemeBorderCol
 CPPUNIT_ASSERT(isPropertyVoid(xParagraph, "RightBorderComplexColor"));
 }
 
+DECLARE_SW_ROUNDTRIP_TEST(testCharUnderlineTheme_DOCX, 
"Test_CharUnderlineThemeColor.docx", nullptr,
+  Test)
+{
+auto xParagraph = getParagraph(1);
+CPPUNIT_ASSERT(xParagraph.is());
+auto xRun = getRun(xParagraph, 1);
+auto xComplexColor
+= getProperty>(xRun, 
"CharUnderlineComplexColor");
+auto 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/inc sw/source

[Balazs Varga (via logerrit)]

 sw/inc/editsh.hxx|7 +++
 sw/inc/strings.hrc   |4 
 sw/source/core/access/AccessibilityCheck.cxx |   11 +--
 sw/source/core/access/AccessibilityIssue.cxx |   17 -
 sw/source/core/inc/AccessibilityIssue.hxx|1 +
 sw/source/uibase/inc/wrtsh.hxx   |1 +
 sw/source/uibase/wrtsh/wrtsh1.cxx|   11 +++
 7 files changed, 49 insertions(+), 3 deletions(-)

New commits:
commit b22b71879b7570cc1b9b550b9a95af2ff91e2777
Author: Balazs Varga 
AuthorDate: Wed Jun 7 12:21:24 2023 +0200
Commit: Xisco Fauli 
CommitDate: Tue Jun 13 23:19:08 2023 +0200

tdf#155041 - A11Y sidebar: fix warning about missing form control 
description

Add form control objects to "Go to" and "Fix" functions.
In case of "Go to" a warning dialoge shows up if it is not in Design mode
and ask to switch on Design mode or not.

Change-Id: I79b6d67568e2ddfd121081d4c47ce7588f5d51b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152698
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit c5cde93cd4327f55fdd23e6230c2cb101192374d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152973
Reviewed-by: Balazs Varga 
Reviewed-by: Xisco Fauli 

diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index 41650792e10b..766e504b4072 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -637,6 +637,13 @@ public:
 return true;
 }
 
+/// Switch to Design mode for Forms
+virtual bool WarnSwitchToDesignModeDialog() const
+{
+// override in SwWrtShell
+return false;
+}
+
 /** Query text within selection. */
 void GetSelectedText( OUString ,
 ParaBreakType nHndlParaBreak = ParaBreakType::ToBlank 
);
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index c18aff49639a..38ae2f61bff9 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -1469,6 +1469,10 @@
 // in order to change %PRODUCTNAME at runtime is expensive, so limit doing 
that as much as possible.
 #define STR_A11Y_DESC_AUTO  
NC_("insertcaption|extended_tip|auto", "Opens the Caption dialog. It has the 
same information as the dialog you get by menu %PRODUCTNAME Writer - 
AutoCaption in the Options dialog box.")
 
+#define STR_A11Y_DESIGN_MODE_TITLE  
NC_("STR_A11Y_DESIGN_MODE_TITLE", "The Forms are not editable")
+#define STR_A11Y_DESIGN_MODE_PRIMARY
NC_("STR_A11Y_DESIGN_MODE_PRIMARY", "Would you like to switch to Design mode?")
+#define STR_A11Y_DESIGN_MODE_SECONDARY  
NC_("STR_A11Y_DESIGN_MODE_SECONDARY", "You need to switch to design mode to 
edit Forms.")
+
 #define STR_MARK_COPY NC_("STR_MARK_COPY", "%1 Copy ")
 
 #define STR_INFORODLG_FOLDED_PRIMARY
NC_("STR_INFORODLG_FOLDED_PRIMARY", "You are trying to delete folded (hidden) 
content.")
diff --git a/sw/source/core/access/AccessibilityCheck.cxx 
b/sw/source/core/access/AccessibilityCheck.cxx
index 302d26c9c06f..05d2634db863 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -1360,9 +1360,11 @@ void AccessibilityCheck::checkObject(SdrObject* pObject)
 lclAddIssue(m_aIssueCollection, SwResId(STR_FLOATING_TEXT));
 
 const SdrObjKind nObjId = pObject->GetObjIdentifier();
+const SdrInventor nInv = pObject->GetObjInventor();
 
 if (nObjId == SdrObjKind::CustomShape || nObjId == SdrObjKind::Text
-|| nObjId == SdrObjKind::Media || nObjId == SdrObjKind::Group)
+|| nObjId == SdrObjKind::Media || nObjId == SdrObjKind::Group
+|| nInv == SdrInventor::FmForm)
 {
 OUString sAlternative = pObject->GetTitle();
 if (sAlternative.isEmpty())
@@ -1371,7 +1373,12 @@ void AccessibilityCheck::checkObject(SdrObject* pObject)
 OUString sIssueText = 
SwResId(STR_NO_ALT).replaceAll("%OBJECT_NAME%", sName);
 auto pIssue = lclAddIssue(m_aIssueCollection, sIssueText,
   sfx::AccessibilityIssueID::NO_ALT_SHAPE);
-pIssue->setIssueObject(IssueObject::SHAPE);
+// Set FORM Issue for Form objects because of the design mode
+if (nInv == SdrInventor::FmForm)
+pIssue->setIssueObject(IssueObject::FORM);
+else
+pIssue->setIssueObject(IssueObject::SHAPE);
+
 pIssue->setObjectID(pObject->GetName());
 pIssue->setDoc(*m_pDoc);
 }
diff --git a/sw/source/core/access/AccessibilityIssue.cxx 
b/sw/source/core/access/AccessibilityIssue.cxx
index 7f09b9d7cf05..d1ebb53bdeeb 100644
--- a/sw/source/core/access/AccessibilityIssue.cxx
+++ b/sw/source/core/access/AccessibilityIssue.cxx
@@ -71,6 +71,20 @@ void AccessibilityIssue::gotoIssue() const
 pWrtShell->ShowCursor();
 }
 break;
+case IssueObject::FORM:
+

[Libreoffice-commits] core.git: svgio/source

[Xisco Fauli (via logerrit)]

 svgio/source/svgreader/svgstyleattributes.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 5e9eaaf6f298bced76ddef7bc37efcd75a224520
Author: Xisco Fauli 
AuthorDate: Tue Jun 13 16:10:57 2023 +0200
Commit: Xisco Fauli 
CommitDate: Tue Jun 13 23:19:04 2023 +0200

svgio: remove unneeded initializer

Added in b1d1a424a4d291873101f5d2348e5bd9cb9091a4
"tdf#155735: Add basic support for feColorMatrix"
Change-Id: I6217c15702f0c0338a6aef5d08c755441d2bfaf8

Change-Id: I5673e2243dec6f9ec195622178be34f4fc25b734
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152966
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/svgio/source/svgreader/svgstyleattributes.cxx 
b/svgio/source/svgreader/svgstyleattributes.cxx
index 58a982a8a927..99267c762dc5 100644
--- a/svgio/source/svgreader/svgstyleattributes.cxx
+++ b/svgio/source/svgreader/svgstyleattributes.cxx
@@ -1283,7 +1283,6 @@ namespace svgio::svgreader
 maTextAnchor(TextAnchor::notset),
 maVisibility(Visibility::notset),
 mpClipPathXLink(nullptr),
-maFilterXLink(OUString()),
 mpFilterXLink(nullptr),
 mpMaskXLink(nullptr),
 mpMarkerStartXLink(nullptr),

[Libreoffice-bugs] [Bug 155326] Calc with gtk3 VCL is unusable with large spreadsheets: huge lag, high CPU usage, etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155326

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||5455

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155455] Scroll continues when keyboard key is pressed for long and then released

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155455

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||5326

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143540] EDITING: Keypad decimal character not changed to comma

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143540

--- Comment #23 from Stéphane Guillou (stragu) 
 ---
Thank you both.

(In reply to Mattia from comment #20)

> (In reply to Stéphane Guillou (stragu) from comment #19)
>   Key val, name:  65454 KP_Decimal

I've tested the same script and get the same key val when using "English
(Australia)" for Ubuntu's Regional Formats. However, if I change the Regional
Format to "français (France)", the same key sends the key val "65452
KP_Separator".


More questions:
- can you please check that you get the right character in other GTK apps, to
make sure that it is indeed a LibreOffice issue?
- if it is only in LibreOffice, is it only for Calc or also in e.g. Writer?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155455] Scroll continues when keyboard key is pressed for long and then released

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155455

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from Telesto  ---
Setting to NEW, based on comment 3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/qa

[Khaled Hosny (via logerrit)]

 vcl/qa/cppunit/complextext.cxx   |   60 ++-
 vcl/qa/cppunit/data/tdf153440.ttf|binary
 vcl/qa/cppunit/data/tdf153440.ttf.readme |   12 ++
 3 files changed, 71 insertions(+), 1 deletion(-)

New commits:
commit 6b178c6e88ec5a765ad2b3ccd98182286222f550
Author: Khaled Hosny 
AuthorDate: Mon Jun 12 22:48:59 2023 +0300
Commit: خالد حسني 
CommitDate: Tue Jun 13 22:44:52 2023 +0200

tdf#153440: Add test

Change-Id: I0c036cd1d8022e6ff265aa67ab177c57eba0c4ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152934
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index 9473d5b7b696..631a24379a7f 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -44,8 +44,27 @@ static std::ostream& operator<<(std::ostream& rStream, const 
std::vectorAddTempDevFont(getFullUrl(sFileName), 
OUString(sFamilyName));
+OutputDevice::ImplRefreshAllFontData(true);
+return bAdded;
+}
+
+VclComplexTextTest()
+: BootstrapFixture(true, false)
+{
+}
 };
 
 CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testArabic)
@@ -421,4 +440,43 @@ CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testTdf152048_2)
 #endif
 }
 
+CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testTdf153440)
+{
+#if HAVE_MORE_FONTS
+vcl::Font aFont(u"Noto Naskh Arabic", u"Regular", Size(0, 72));
+
+ScopedVclPtrInstance pOutDev;
+pOutDev->SetFont(aFont);
+
+#if !defined _WIN32 // TODO: Fails on jenkins but passes locally
+// Add an emoji font so that we are sure a font will be found for the
+// emoji. The font is subset and supports only .
+bool bAdded = addFont(pOutDev, u"tdf153440.ttf", u"Noto Emoji");
+CPPUNIT_ASSERT_EQUAL(true, bAdded);
+#endif
+
+for (auto& aString : { u"ع  ع", u"a  a" })
+{
+OUString aText(aString);
+bool bRTL = aText.startsWith(u"ع");
+
+auto pLayout = pOutDev->ImplLayout(aText, 0, -1, Point(0, 0), 0, {}, 
{});
+
+int nStart = 0;
+DevicePoint aPos;
+const GlyphItem* pGlyphItem;
+while (pLayout->GetNextGlyph(, aPos, nStart))
+{
+// Assert glyph ID is not 0, if it is 0 then font fallback didn’t
+// happen.
+CPPUNIT_ASSERT(pGlyphItem->glyphId());
+
+// Assert that we are indeed doing RTL layout for RTL text since
+// the bug does not happen for LTR text.
+CPPUNIT_ASSERT_EQUAL(bRTL, pGlyphItem->IsRTLGlyph());
+}
+}
+#endif
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/qa/cppunit/data/tdf153440.ttf 
b/vcl/qa/cppunit/data/tdf153440.ttf
new file mode 100644
index ..933e74733b0a
Binary files /dev/null and b/vcl/qa/cppunit/data/tdf153440.ttf differ
diff --git a/vcl/qa/cppunit/data/tdf153440.ttf.readme 
b/vcl/qa/cppunit/data/tdf153440.ttf.readme
new file mode 100644
index ..6fffab0decab
--- /dev/null
+++ b/vcl/qa/cppunit/data/tdf153440.ttf.readme
@@ -0,0 +1,12 @@
+This is a subset copy of Noto Emoji font licensed under Open Font License and
+obtained from:
+
+  https://fonts.google.com/noto/specimen/Noto+Emoji
+
+And subset using hb-subset to contain only the one glyph used in the test:
+
+  hb-subset static/NotoEmoji-Regular.ttf " " -o tdf153440.ttf 
--drop-tables=GSUB,STAT,vhea,vmtx
+
+The space is added to the subset as it seems needed to get the font to work on
+Windows. (The --drop-tables argument is not necessary be saves a few bytes of
+stuff we don’t need.)

[Libreoffice-bugs] [Bug 155825] New: Crash MCGR export special file odp -> pptx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155825

Bug ID: 155825
   Summary: Crash MCGR export special file odp -> pptx
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 187897
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187897=edit
Callstack by Visual Studio

I could reproduce the crash mentioned in
https://gerrit.libreoffice.org/c/core/+/152673 for normal, not headless export.
The callstack from Visual Studio is attached.

The crash happen in oox/source/export/drawingml.cxx in
if (aColorStops.size() != aAlphaStops.size() || nullptr == pGradient)
{
// this is an error - synchronizeColorStops above *has* to create that
// state, see description there (!)
// also an error - see comment in header - is to give neither
pColorGradient
// nor pTransparenceGradient
assert(false && "oox::WriteGradientFill: non-synchronized gradients
(!)");
return;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155824] New: documents never open up where I left off.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155824

Bug ID: 155824
   Summary: documents never open up where I left off.
   Product: LibreOffice
   Version: 7.5.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: spjggvlksniwaor...@bbitq.com

Description:
this has been persistent across all versions of LibreOffice on all platforms.


Steps to Reproduce:
1. opening any document
2. page doesn't open in the same space I left it, usually like 4-8 pages it
resumes to randomly.
3. type cursor is also in a different location, usually a few sentences off.

Actual Results:
Documents do not resume where they are left off in writer. I urge you to
confirm this on your own documents.

Expected Results:
Documents never open where they are left off. I expect them to open correctly.
This is a bug, it should be urgently looked into and fixed.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Documents never open where they are left off, stop deleting this report and
acknowledge it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109195

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||155815


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155815
[Bug 155815] footnotes reordered with docx
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155815] footnotes reordered with docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155815

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||109195
 CC||nem...@numbertext.org

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
(In reply to martyhiatt from comment #5)
> i just tried opening a docx file with badly my ordered footnotes in
> microsoft word online. the footnotes there appear in the correct order. is
> it then only a matter of rendering, and my files should likely be fine?

Hopefully that's the case, but hard to say without a test file.
Could you please prepare a sample document that displays the issue when
compared  between MS Office and LO 7.5.4.2, and attach that file to this
report?
It sounds like it could be a follow up to issues mentioned above.

Copying László Németh in, who has worked on that part of the software recently.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109195
[Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155823] A specific list item does not continue numbering after save-and-reload since 7.4

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155823

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155823] New: A specific list item does not continue numbering after save-and-reload since 7.4

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155823

Bug ID: 155823
   Summary: A specific list item does not continue numbering after
save-and-reload since 7.4
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisectNotNeeded, filter:odt, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com

Created attachment 187896
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187896=edit
A single list having items with different list styles

Open the attached sample. With styles panel open on List Styles, check that the
first, second, and fourth list items have style "ListStyleOne", and the third
item has "ListStyleAnother". Note also, that the numbering of all four is
contiguous (1., 2., 3., 4.).

Save (as ODT or FODT) and reload. Since commit
8f48f91009caa86d896f247059874242ed18bf39 (version 7.4), the numbering is broken
in the last item, which is now numbered "1." instead of expected "4.".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

[Henry Castro (via logerrit)]

 sc/source/filter/inc/condformatbuffer.hxx |1 +
 sc/source/filter/inc/extlstcontext.hxx|4 +++-
 sc/source/filter/oox/condformatbuffer.cxx |   13 +
 sc/source/filter/oox/extlstcontext.cxx|   28 
 4 files changed, 45 insertions(+), 1 deletion(-)

New commits:
commit 3d4c4a95c32ad2a96831c3db552b0c389c596aea
Author: Henry Castro 
AuthorDate: Fri Mar 17 10:47:31 2023 -0400
Commit: Henry Castro 
CommitDate: Tue Jun 13 22:11:17 2023 +0200

sc: filter: oox: Add a missing tag child of the parent tag "cfvo"


 
  0
 
 
  1
 
 
 
 
 
 


Signed-off-by: Henry Castro 
Change-Id: Ie98507e11a5cdeb0d1adc77a44fd79edb2f26d6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149066
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152998
Tested-by: Jenkins

diff --git a/sc/source/filter/inc/condformatbuffer.hxx 
b/sc/source/filter/inc/condformatbuffer.hxx
index 1180b1e0aa74..cdc8d4727baf 100644
--- a/sc/source/filter/inc/condformatbuffer.hxx
+++ b/sc/source/filter/inc/condformatbuffer.hxx
@@ -242,6 +242,7 @@ struct ExCfRuleModel
 ::Color mnNegativeColor;
 OUString maAxisPosition; // DataBar
 OUString maColorScaleType; // Cfvo
+OUString msScaleTypeValue; // Cfvo
 bool mbGradient; // DataBar
 bool mbIsLower; // Cfvo
 };
diff --git a/sc/source/filter/inc/extlstcontext.hxx 
b/sc/source/filter/inc/extlstcontext.hxx
index 8635c6029523..077ebdbebf8e 100644
--- a/sc/source/filter/inc/extlstcontext.hxx
+++ b/sc/source/filter/inc/extlstcontext.hxx
@@ -32,11 +32,13 @@ public:
 
 virtual ::oox::core::ContextHandlerRef onCreateContext( sal_Int32 
nElement, const AttributeList& rAttribs ) override;
 virtual voidonStartElement( const AttributeList& rAttribs ) 
override;
+virtual voidonCharacters( const OUString& rChars ) override;
+virtual voidonEndElement() override;
 
 private:
 ScDataBarFormatData* mpTarget;
-
 bool mbFirstEntry;
+ExtCfDataBarRuleRef mpRule;
 };
 
 struct ExtCondFormatRuleModel
diff --git a/sc/source/filter/oox/condformatbuffer.cxx 
b/sc/source/filter/oox/condformatbuffer.cxx
index efff0ec62889..649046e8b3b7 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -1434,6 +1434,19 @@ void ExtCfDataBarRule::finalizeImport()
 pEntry->SetType(COLORSCALE_PERCENT);
 else if (maModel.maColorScaleType == "formula")
 pEntry->SetType(COLORSCALE_FORMULA);
+else if (maModel.maColorScaleType == "num")
+pEntry->SetType(COLORSCALE_VALUE);
+
+if (!maModel.msScaleTypeValue.isEmpty())
+{
+sal_Int32 nSize = 0;
+rtl_math_ConversionStatus eStatus = 
rtl_math_ConversionStatus_Ok;
+double fValue = 
rtl::math::stringToDouble(maModel.msScaleTypeValue, '.', '\0', , 
);
+if (eStatus == rtl_math_ConversionStatus_Ok && nSize == 
maModel.msScaleTypeValue.getLength())
+{
+pEntry->SetValue(fValue);
+}
+}
 break;
 }
 case UNKNOWN: // nothing to do
diff --git a/sc/source/filter/oox/extlstcontext.cxx 
b/sc/source/filter/oox/extlstcontext.cxx
index 760ba26c1727..2646f0969958 100644
--- a/sc/source/filter/oox/extlstcontext.cxx
+++ b/sc/source/filter/oox/extlstcontext.cxx
@@ -80,6 +80,7 @@ void ExtCfRuleContext::onStartElement( const AttributeList& 
rAttribs )
 xRule->importCfvo( rAttribs );
 xRule->getModel().mbIsLower = mbFirstEntry;
 mbFirstEntry = false;
+mpRule = xRule;
 break;
 }
 default:
@@ -87,6 +88,33 @@ void ExtCfRuleContext::onStartElement( const AttributeList& 
rAttribs )
 }
 }
 
+void ExtCfRuleContext::onCharacters( const OUString& rChars )
+{
+switch( getCurrentElement() )
+{
+case XM_TOKEN( f ):
+{
+if (mpRule)
+{
+mpRule->getModel().msScaleTypeValue = rChars;
+}
+}
+break;
+}
+}
+
+void ExtCfRuleContext::onEndElement()
+{
+switch( getCurrentElement() )
+{
+case XLS14_TOKEN( cfvo ):
+{
+mpRule.reset();
+break;
+}
+}
+}
+
 namespace {
 bool IsSpecificTextCondMode(ScConditionMode eMode)
 {

[Libreoffice-bugs] [Bug 155822] Method findAll() of com.sun.star.util.XSearchable may return NULL though specified to return XIndexAccess container.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155822

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Keywords||difficultyBeginner,
   ||easyHack, skillCpp
 Ever confirmed|0   |1

--- Comment #1 from Mike Kaganski  ---
https://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/cellsuno.cxx?r=3e7ff2a9=189177=3757#3757

introduced in the initial import.

It looks reasonable to throw an error when the initial check (pDocShell &&
xDesc.is()) fails, and if it passes, it seems possible to create an empty
ScRangeList right away, and create the returned ScCellRangesObj with it
unconditionally before return.

The easyhack needs a unit test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155822] New: Method findAll() of com.sun.star.util.XSearchable may return NULL though specified to return XIndexAccess container.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155822

Bug ID: 155822
   Summary: Method findAll() of com.sun.star.util.XSearchable may
return NULL though specified to return XIndexAccess
container.
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@psilosoph.de

Created attachment 187895
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187895=edit
The announced demo

XIndexAccess containers can well be empty. The .Count property then is 0.

The result of a .findAll() with XSearchable is one of the cases where a result
of type XIndexAccess is specified, but NO such result is returned if nothing
was found. Instead of setting .Count to 0, in this case the NULL object is
returned. 

It may factually be impossible to fix the bug because old running code would be
broken this way. However, the API documentation should give a related hint, and
list the cases where a NULL ob ject will be returned, while a XIndexAccess
object should be expected.

Thare is a demonstrating example attched.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Andrea Gelmini (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 79a96ca0083cdb692bce90d06dd2f51e1bfbdd90
Author: Andrea Gelmini 
AuthorDate: Tue Jun 13 21:35:59 2023 +0200
Commit: Gerrit Code Review 
CommitDate: Tue Jun 13 21:35:59 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to f252a686b4231cfcd3e00756b1a59509aa3ae407
  - Fix typo

Change-Id: Id2a262225d6f9029dc706c309ddcf308fa55ee62
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153000
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/helpcontent2 b/helpcontent2
index a8a5edeadd66..f252a686b423 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a8a5edeadd66edfc0fb0747ba7f1251da1b2597c
+Subproject commit f252a686b4231cfcd3e00756b1a59509aa3ae407

[Libreoffice-commits] help.git: source/text

[Andrea Gelmini (via logerrit)]

 source/text/shared/00/0208.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f252a686b4231cfcd3e00756b1a59509aa3ae407
Author: Andrea Gelmini 
AuthorDate: Tue Jun 13 20:47:15 2023 +0200
Commit: Julien Nabet 
CommitDate: Tue Jun 13 21:35:58 2023 +0200

Fix typo

Change-Id: Id2a262225d6f9029dc706c309ddcf308fa55ee62
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153000
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/source/text/shared/00/0208.xhp 
b/source/text/shared/00/0208.xhp
index 38cdfd518b..9621d543a1 100644
--- a/source/text/shared/00/0208.xhp
+++ b/source/text/shared/00/0208.xhp
@@ -116,7 +116,7 @@
 Detect scientific notation
 When this option is enabled, Calc will automatically detect numbers 
with scientific notation, like 5E2 for 500.
 The selected 
language influences how scientific notation is detected, since different 
languages and regions many have different decimal separator.
-This option 
can be be disabled only if Detect special numbers option is 
previously disabled.
+This option 
can be disabled only if Detect special numbers option is 
previously disabled.
 When this 
option is disabled, Calc will detect and convert only numbers in decimal 
notation. The rest will be imported as text. A decimal number string can have 
digits 0-9, thousands separators, and a decimal separator. Thousands separators 
and decimal separators may vary with the selected language and 
region.
 
 

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/uibase/misc/redlndlg.cxx |5 -
 1 file changed, 5 deletions(-)

New commits:
commit 76d5bf35a618dc8f7f268ec5cd40e546a4d48e17
Author: Caolán McNamara 
AuthorDate: Tue Jun 13 17:22:18 2023 +0100
Commit: Caolán McNamara 
CommitDate: Tue Jun 13 21:02:10 2023 +0200

cid#1532367 Unused value

Within the loop nPrevRowChange is not read after it is set
and nPrevRowChange is always set to nRowChange at the end of
the loop. There is no continue within the loop, so it looks
like there is no point changing nPrevRowChange as it will be
overwritten with nRowChange in any case.

probably this is the case since:

commit cc52d895314dd7b67de916bd90ccbfa098e77419
Date:   Wed Jun 7 16:53:42 2023 +0200

tdf#155342 sw tracked table column: manage changes

Change-Id: Ib7cf2da23a7553bdeea13862cf4f67248bc829a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152994
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/misc/redlndlg.cxx 
b/sw/source/uibase/misc/redlndlg.cxx
index e583dc3af1a9..3a0a67fa005d 100644
--- a/sw/source/uibase/misc/redlndlg.cxx
+++ b/sw/source/uibase/misc/redlndlg.cxx
@@ -871,7 +871,6 @@ void 
SwRedlineAcceptDlg::InsertParents(SwRedlineTable::size_type nStart, SwRedli
 {
 nNewTableParent = i;
 nLastChangeInRow = i;
-nPrevRowChange = nRowChange;
 }
 }
 else
@@ -884,12 +883,8 @@ void 
SwRedlineAcceptDlg::InsertParents(SwRedlineTable::size_type nStart, SwRedli
 {
 // redline is not in a tracked table change
 bChange = bRowChange = false;
-nPrevRowChange = SwRedlineTable::npos;
 }
 }
-else
-// redline is not in a tracked table change
-nPrevRowChange = SwRedlineTable::npos;
 
 bool bShowDeletedTextAsComment = bIsShowChangesInMargin &&
 RedlineType::Delete == rRedln.GetType() && 
rRedln.GetComment().isEmpty();

[Libreoffice-bugs] [Bug 114531] Support JPEG-XR image format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114531

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #7 from Julien Nabet  ---
(In reply to Tomaz Vajngerl from comment #3)
> Well we need Jpeg-XR for full support of images in OOXML documents.. even if
> it is just a "meh" format it is something MSO uses in some cases. So I
> wouldn't close this one...

Reading external/libjpeg-turbo/README, we use libjpeg-turbo-2.1.5.1.tar.gz for
jpeg import support (but it seems also for export too considering we use
functions like "jpeg_create_compress").

I don't know if libjpeg-turbo supports jpeg-xr if not, it means we must find a
lib (compatible with LO license) which supports the format, in C or C++, well
maintained, etc.

Considering the size of OOXML specs (see
https://en.wikipedia.org/wiki/Standardization_of_Office_Open_XML#Criticism),
I'm not sure it's a pb to not implement a standard which isn't even implemented
natively by Gimp and Photoshop (see
https://en.wikipedia.org/wiki/JPEG_XR#Software_support).

Then we can wonder if we're talking about read support only or read and write
support but quite quickly, if there's read-only support, people will complain
they can't modify the images of a doc.
Of course, we may convert the image in another format but 1) it adds even more
complexity 2) it'll bother some users
Finally I completely agree with
https://bugs.documentfoundation.org/show_bug.cgi?id=114533#c5 :
"Also removing support for a image format is much harder so adapting a new
image format should take a lot of consideration as it can have long lasting
effects"

Perhaps it could be interesting to ask ESC opinion?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

[Henry Castro (via logerrit)]

 sc/source/filter/oox/condformatbuffer.cxx |   76 ++
 1 file changed, 76 insertions(+)

New commits:
commit 77a14410c3faffb2e2b78c039a989987b0a8
Author: Henry Castro 
AuthorDate: Fri Mar 17 10:40:23 2023 -0400
Commit: Henry Castro 
CommitDate: Tue Jun 13 20:40:46 2023 +0200

sc: filter: oox: add missing attribute "indexed"


 
 
 
 
 


Signed-off-by: Henry Castro 
Change-Id: If7f6c8c902e4cd0d775f1014acad3dcd19f13f28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149065
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152968
Tested-by: Jenkins

diff --git a/sc/source/filter/oox/condformatbuffer.cxx 
b/sc/source/filter/oox/condformatbuffer.cxx
index 63e75170a367..efff0ec62889 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -168,6 +168,76 @@ void ColorScaleRule::importCfvo( const AttributeList& 
rAttribs )
 ++mnCfvo;
 }
 
+// 
https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.indexedcolors?view=openxml-2.8.1
+static ::Color IndexedColors[] = {
+0x,
+0x00FF,
+0x00FF,
+0xFF00,
+0x00FF,
+0x0000,
+0x00FF00FF,
+0x,
+0x,
+0x00FF,
+0x00FF,
+0xFF00,
+0x00FF,
+0x0000,
+0x00FF00FF,
+0x,
+0x0080,
+0x8000,
+0x0080,
+0x00808000,
+0x00800080,
+0x8080,
+0x00C0C0C0,
+0x00808080,
+0x00FF,
+0x00993366,
+0x00CC,
+0x00CC,
+0x00660066,
+0x00FF8080,
+0x66CC,
+0x00FF,
+0x0080,
+0x00FF00FF,
+0x0000,
+0x,
+0x00800080,
+0x0080,
+0x8080,
+0x00FF,
+0xCCFF,
+0x00CC,
+0x00CCFFCC,
+0x0099,
+0x0099CCFF,
+0x00FF99CC,
+0x00CC99FF,
+0x00FFCC99,
+0x003366FF,
+0x0033,
+0x0099CC00,
+0x00FFCC00,
+0x00FF9900,
+0x00FF6600,
+0x0099,
+0x00969696,
+0x3366,
+0x00339966,
+0x3300,
+0x0000,
+0x00993300,
+0x00993366,
+0x0099,
+0x0033,
+0x, // System Foreground ?
+0x, // System Background ?
+};
+
 namespace {
 
 ::Color importOOXColor(const AttributeList& rAttribs, const ThemeBuffer& 
rThemeBuffer, const GraphicHelper& rGraphicHelper)
@@ -191,6 +261,12 @@ namespace {
 
 nColor = rThemeBuffer.getColorByIndex( nThemeIndex );
 }
+else if (rAttribs.hasAttribute(XML_indexed))
+{
+sal_uInt32 nIndexed = rAttribs.getUnsigned(XML_indexed, 0);
+if (nIndexed < sizeof(IndexedColors))
+nColor = IndexedColors[nIndexed];
+}
 
 ::Color aColor;
 double nTint = rAttribs.getDouble(XML_tint, 0.0);

[Libreoffice-bugs] [Bug 154756] Vertical text direction results in rotation, not vertical text direction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154756

Eyal Rozenberg  changed:

   What|Removed |Added

   Keywords||needsUXEval

--- Comment #14 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #13)
> Don't know how UX can contribute to this discussion

You can help decide what combination of widgets should control direction and
orientation in the Page Style dialog. You could perhaps also help reviewing my
claim that what we have right now is confusing for some users.

> Btw, if there is such a serious issue I'd expect a duplicate ticket.

The likely reason this is not a "serious" issue is that it only affects non-CJK
glyphs, and few Westerners care about this direction to begin with. In fact,

> For example bug 114002.

... that _is_ a way this issue is "serious". You see, because we treat this
writing direction as a rotation - and probably some of the implementing code
also does that - we assume glyphs are supposed to be rotated. Which they are
not. Different languages have different conventions regarding the potential
orientations of their glyphs (what's possible and what's common/default). If we
had respected that, and not assumed we should "rotated everything sans certain
exceptions", bug 114002 would not have occurred.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155818] Enhancement: Please consider supporting the JPEG-XR (.jxr) format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155818

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Julien Nabet  ---


*** This bug has been marked as a duplicate of bug 114531 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114531] Support JPEG-XR image format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114531

Julien Nabet  changed:

   What|Removed |Added

 CC||xordevore...@gmail.com

--- Comment #6 from Julien Nabet  ---
*** Bug 155818 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155781] documents never open up where I left off.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155781

--- Comment #2 from Julien Nabet  ---
*** Bug 155821 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155821] documents never open up where I left off.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155821

Julien Nabet  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Julien Nabet  ---
No need to make dups, it won't be fixed faster.

*** This bug has been marked as a duplicate of bug 155781 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154255] Support embedded PDF viewing and zooming as vectorial instead of rasterized image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154255

--- Comment #6 from V Stuart Foote  ---
(In reply to Ole Tange from comment #5)

> 
> But I would really love if I could re-arrange pages like I can with
> PDFarranger.

LibreOffice is *NOT* a PDF editor. And is only a viewer in the sense that we
parse content from the PDF--the pdfium based rasters (no Skia vector canvas
yet), or for the clunky conversion of content to ODF draw objects.

The original PDF is retained, but the rendering to LO document canvas is not
bulk PDF internals. Currently the pdfium based parser works one page at a time,
so you have to split the pages out external to LibreOffice, e.g. PDFtk and add
them in the sequence you need. Scriptable but bug 114234 is open to improve
multi-page PDF.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155821] New: documents never open up where I left off.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155821

Bug ID: 155821
   Summary: documents never open up where I left off.
   Product: LibreOffice
   Version: 7.5.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: spjggvlksniwaor...@bbitq.com

Description:
this has been persistent across all versions of LibreOffice on all platforms.

Steps to Reproduce:
1. opening any document
2. page doesn't open in the same space I left it, usually like 4-8 pages it
resumes to randomly.
3. type cursor is also in a different location, usually a few sentences off.

Actual Results:
Documents do not resume where they are left off in writer. I urge you to
confirm this on your own documents.

Expected Results:
Documents never open where they are left off.
This is a bug, it should be urgently looked into and fixed.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Documents never open where they are left off

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155455] Scroll continues when keyboard key is pressed for long and then released

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155455

Adam664  changed:

   What|Removed |Added

 CC||p...@pfortin.com

--- Comment #4 from Adam664  ---
*** Bug 155766 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155766] Please sync arrow keys to selected cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155766

Adam664  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||adamsesku...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Adam664  ---
155455 has more has a better description and steps to replicate, so gonna mark
this as a duplicate

*** This bug has been marked as a duplicate of bug 155455 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155820] isCJKIVSCharacter needs to support CJK Unified Ideographs Extension Block C to H for Unicode15

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155820

--- Comment #2 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #1)
> =-ref-=
> [1] https://extensions.libreoffice.org/en/extensions/show/1077

This from the extension's page (via Google Translate)

Description
The IPAmj font is one of the fonts developed and distributed by the IPA
Independent Administrative Institution Information-technology Promotion Agency.
This is a huge font set containing approximately 60,000 characters, including
variant characters, used for personal names in municipalities throughout Japan.

This extension can search IPAmj fonts by various items including variant
characters (IVS) and paste them into documents via the clipboard.

・The IPAmj Mincho font must be installed on the system.
- The document must be formatted with the IPAmj Mincho font.

The MJ character information list included in this extension is distributed by
the following organizations, and CC-BY-SA is applied.
IPA Information-technology Promotion Agency
　https://mojikiban.ipa.go.jp/1311.html
Character Information Technology Promotion Council
　https://moji.or.jp/mojikiban/mjlist/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155820] isCJKIVSCharacter needs to support CJK Unified Ideographs Extension Block C to H for Unicode15

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155820

V Stuart Foote  changed:

   What|Removed |Added

 CC||kha...@libreoffice.org,
   ||vsfo...@libreoffice.org

--- Comment #1 from V Stuart Foote  ---
@Khaled, *, 

Not sure what is meant by support here. 

Assume that if LO receives the Unicode, and select a font with coverage, that
it renders to LO document canvas--and can save and print same.

So is this an IME question or inability to render? Does our Special Character
Dialog render chart of these codepoints?

Or is this more simply against the "IPAmj Font Charactor Finder" extension [1]? 

=-ref-=
[1] https://extensions.libreoffice.org/en/extensions/show/1077

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154255] Support embedded PDF viewing and zooming as vectorial instead of rasterized image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154255

--- Comment #5 from Ole Tange  ---
(In reply to Heiko Tietze from comment #3)

> And I struggle a bit with the use case. Your Writer document is WYSIWYG, you
> shouldn't expect different zoom level for details.

Every lawyer has a use case, and probably many more people.

We need to import hundreds of pages of PDF files into a single file.

All that will be added is a page number for the total document, and some cross
reference links into each page, so you can easily go from an index to a given
page in the PDF.

The document becomes unwieldly large if each PDF-file is converted to PNG in a
resolution that is readable (i.e. > 200 DPI). Try that with 500 pages, which is
my latest task.

I would love if LibreOffice could be an alternative to PDFarranger
https://github.com/pdfarranger/pdfarranger
So I could merge PDF-files without loss of quality and add small details like a
total page number.

It is perfectly fine if I cannot "enter into" a PDF page, so from a user
perspective the pages could be treated similar to a write protected SVG image.

But I would really love if I could re-arrange pages like I can with
PDFarranger.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143781] [META] Development- and code-related bug reports and tasks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143781
Bug 143781 depends on bug 154757, which changed state.

Bug 154757 Summary: CPP unit tests: provide message converters to allow use of 
O(U)Strings as _MESSAGE argument
https://bugs.documentfoundation.org/show_bug.cgi?id=154757

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154757] CPP unit tests: provide message converters to allow use of O(U)Strings as _MESSAGE argument

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154757

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142692] Python script connecting to LO instance fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142692

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
(same result for gen VCL by the way)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066

DaeHyun Sung  changed:

   What|Removed |Added

 Blocks||155820


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155820
[Bug 155820] isCJKIVSCharacter needs to support CJK Unified Ideographs
Extension Block C to H for Unicode15
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155820] isCJKIVSCharacter needs to support CJK Unified Ideographs Extension Block C to H for Unicode15

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155820

DaeHyun Sung  changed:

   What|Removed |Added

 CC||shinji.en...@gmail.com,
   ||sungd...@gmail.com
 Depends on||83066


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language
issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155820] New: isCJKIVSCharacter needs to support CJK Unified Ideographs Extension Block C to H for Unicode15

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155820

Bug ID: 155820
   Summary: isCJKIVSCharacter needs to support CJK Unified
Ideographs Extension Block C to H for Unicode15
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sungd...@gmail.com

Description:
isCJKIVSCharacter needs to support CJK Unified Ideographs Extension Block C to
H for Unicode15

I'm curious about CJK Characters. (I'm Korean. But, I study & can speak both
Japanese and Mandarin Chinese a little bit.)

After I contribute to support Unicode 15's CJK Unified Ideographs Extension H
for GNOME characters, I checked CJK Unified Ideographs Extension Lists on
LibreOffice.
(GNOME characters commit link:
https://gitlab.gnome.org/GNOME/gnome-characters/-/commit/daef901e34d731d6d8fe8a1f966ea9f1f04e3a2f
)

However, It doesn't support CJK Unified Ideographs Extension Block C to H. Only
supports CJK Unified Ideographs and its Extension Block A, B.

In Unicode 15, the CJK Unified Ideographs Extension Block range is here
CJK Unified Ideographs: 4E00–9FFF
CJK Unified Ideographs Extension A: 3400–4DBF
CJK Unified Ideographs Extension B: 2–2A6DF
CJK Unified Ideographs Extension C: 2A700–2B73F
CJK Unified Ideographs Extension D: 2B740–2B81F
CJK Unified Ideographs Extension E: 2B820–2CEAF
CJK Unified Ideographs Extension F: 2CEB0–2EBEF
CJK Unified Ideographs Extension G: 3–3134F
CJK Unified Ideographs Extension H: 31350–323AF
Ref: https://www.unicode.org/versions/Unicode15.0.0/ch18.pdf 

I installed the IPAmj Font Character Finder on LibreOffice
Link https://extensions.libreoffice.org/en/extensions/show/1077

Japanese MJ character Information table Ver.066.01.
https://moji.or.jp/mojikiban/mjlist/

https://moji.or.jp/mojikiban/font/

IPAmj Font Character Finder can look for characters in the CJK Unified
Ideographs Extension B or higher range.
such as "럘Ă"(U+2B7D8) It's located in CJK Unified Ideographs Extension D.
https://www.unicode.org/cgi-bin/GetUnihanData.pl?codepoint=%F0%AB%9F%98

So, For LibreOffice's CJK Users, We need to support CJK Unified Ideographs
Extension Block C to H for Unicode15


Steps to Reproduce:
1. Install the IPAmj Font Character Finder extensions on LibreOffice
Link https://extensions.libreoffice.org/en/extensions/show/1077
2. input the 'MJ060164' for MJcode or '2B7D8'UCS code 
3. If the selected CJK font supports CJK Unified Ideographs Extension Block C
to H, It can show. 

Actual Results:
If the selected CJK font supports CJK Unified Ideographs Extension Block C to
H, It can show. 

Expected Results:
If the selected CJK font supports CJK Unified Ideographs Extension Block C to
H, It can show.


Reproducible: Always


User Profile Reset: No

Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 13 commits - basctl/source basegfx/CppunitTest_basegfx.mk basegfx/test chart2/source cui/source download.lst editeng/source externa

[Tomaž Vajngerl (via logerrit)]

Rebased ref, commits from common ancestor:
commit a765a9b52fdcbb2592e8ca121b93895a59ee120d
Author: Tomaž Vajngerl 
AuthorDate: Mon Jul 25 15:38:24 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Wed Jun 14 01:23:58 2023 +0900

svgio: use "frozen" for mapping between token strings and enums

Change-Id: I2061606146cfcb34169dccf69b6f720727839d04

diff --git a/svgio/Library_svgio.mk b/svgio/Library_svgio.mk
index 6221cb141316..76c0e87123bb 100644
--- a/svgio/Library_svgio.mk
+++ b/svgio/Library_svgio.mk
@@ -25,7 +25,10 @@ $(eval $(call gb_Library_set_include,svgio,\
 -I$(SRCDIR)/svgio/inc \
 ))
 
-$(eval $(call gb_Library_use_external,svgio,boost_headers))
+$(eval $(call gb_Library_use_externals,svgio,\
+boost_headers \
+frozen \
+))
 
 $(eval $(call 
gb_Library_set_precompiled_header,svgio,svgio/inc/pch/precompiled_svgio))
 
diff --git a/svgio/source/svgreader/svgtoken.cxx 
b/svgio/source/svgreader/svgtoken.cxx
index 8228689606bf..e283b6e344bb 100644
--- a/svgio/source/svgreader/svgtoken.cxx
+++ b/svgio/source/svgreader/svgtoken.cxx
@@ -18,357 +18,369 @@
  */
 
 #include 
-#include 
+#include 
+#include 
+#include 
+#include 
 
 namespace svgio::svgreader
 {
-const char aSVGStrWidth[] = "width";
-const char aSVGStrHeight[] = "height";
-const char aSVGStrViewBox[] = "viewBox";
-const char aSVGStrTransform[] = "transform";
-const char aSVGStrStyle[] = "style";
-const char aSVGStrDisplay[] = "display"; // #i121656#
-const char aSVGStrD[] = "d";
-const char aSVGStrX[] = "x";
-const char aSVGStrY[] = "y";
-const char aSVGStrXmlns[] = "xmlns";
-const char aSVGStrVersion[] = "version";
-const char aSVGStrId[] = "id";
-const char aSVGStrIn[] = "in";
-const char aSVGStrRx[] = "rx";
-const char aSVGStrRy[] = "ry";
-const char aSVGStrPoints[] = "points";
-const char aSVGStrDx[] = "dx";
-const char aSVGStrDy[] = "dy";
-const char aSVGStrRotate[] = "rotate";
-const char aSVGStrTextLength[] = "textLength";
-const char aSVGStrLengthAdjust[] = "lengthAdjust";
-const char aSVGStrFont[] = "font";
-const char aSVGStrFontFamily[] = "font-family";
-const char aSVGStrFontSize[] = "font-size";
-const char aSVGStrFontSizeAdjust[] = "font-size-adjust";
-const char aSVGStrFontStretch[] = "font-stretch";
-const char aSVGStrFontStyle[] = "font-style";
-const char aSVGStrFontVariant[] = "font-variant";
-const char aSVGStrFontWeight[] = "font-weight";
-const char aSVGStrDirection[] = "direction";
-const char aSVGStrLetterSpacing[] = "letter-spacing";
-const char aSVGStrTextDecoration[] = "text-decoration";
-const char aSVGStrUnicodeBidi[] = "unicode-bidi";
-const char aSVGStrWordSpacing[] = "word-spacing";
-const char aSVGStrTspan[] = "tspan";
-const char aSVGStrTref[] = "tref";
-const char aSVGStrTextPath[] = "textPath";
-const char aSVGStrStartOffset[] = "startOffset";
-const char aSVGStrMethod[] = "method";
-const char aSVGStrSpacing[] = "spacing";
-const char aSVGStrStdDeviation[] = "stdDeviation";
-const char aSVGStrTextAlign[] = "text-align";
-const char aSVGStrPathLength[] = "pathLength";
-const char aSVGStrType[] = "type";
-const char aSVGStrClass[] = "class";
-const char aSVGStrTextAnchor[] = "text-anchor";
-const char aSVGStrXmlSpace[] = "xml:space";
-const char aSVGStrColor[] = "color";
-const char aSVGStrClipPathNode[] = "clipPath";
-const char aSVGStrClipPathProperty[] = "clip-path";
-const char aSVGStrFeGaussianBlur[] = "feGaussianBlur";
-const char aSVGStrFeColorMatrix[] = "feColorMatrix";
-const char aSVGStrFilter[] = "filter";
-const char aSVGStrMask[] = "mask";
-const char aSVGStrClipPathUnits[] = "clipPathUnits";
-const char aSVGStrMaskUnits[] = "maskUnits";
-const char aSVGStrMaskContentUnits[] = "maskContentUnits";
-const char aSVGStrClipRule[] = "clip-rule";
-const char aSVGStrMarker[] = "marker";
-const char aSVGStrMarkerStart[] = "marker-start";
-const char aSVGStrMarkerMid[] = "marker-mid";
-const char aSVGStrMarkerEnd[] = "marker-end";
-const char aSVGStrRefX[] = "refX";
-const char aSVGStrRefY[] = "refY";
-const char aSVGStrMarkerUnits[] = "markerUnits";
-const char aSVGStrMarkerWidth[] = "markerWidth";
-const char aSVGStrMarkerHeight[] = "markerHeight";
-const char aSVGStrOrient[] = "orient";
-const char aSVGStrPattern[] = "pattern";
-const char aSVGStrPatternUnits[] = "patternUnits";
-const char aSVGStrPatternContentUnits[] = "patternContentUnits";
-const char aSVGStrPatternTransform[] = "patternTransform";
-  

[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - sd/source

[Tomaž Vajngerl (via logerrit)]

 sd/source/filter/grf/sdgrffilter.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 48b3ed91b34d2a6667cf2c0a2dab9afeeacb9e05
Author: Tomaž Vajngerl 
AuthorDate: Wed Jun 14 01:20:05 2023 +0900
Commit: Tomaž Vajngerl 
CommitDate: Wed Jun 14 01:20:05 2023 +0900

fix: issue with pGraphic

Change-Id: I1b6a92ed8e1d29b5f6bb48a596138060809b37c8

diff --git a/sd/source/filter/grf/sdgrffilter.cxx 
b/sd/source/filter/grf/sdgrffilter.cxx
index cd621d4bddc6..dff4c8026eba 100644
--- a/sd/source/filter/grf/sdgrffilter.cxx
+++ b/sd/source/filter/grf/sdgrffilter.cxx
@@ -187,7 +187,7 @@ void SdGRFFilter::InsertSdrGrafObj(Graphic aGraphic, 
SdPage* pPage)
 {
 Point aPos;
 Size aPagSize(pPage->getSize().toToolsSize());
-Size aGrfSize(OutputDevice::LogicToLogic(aGraphic.GetPrefSize(), 
pGraphic.GetPrefMapMode(),
+Size aGrfSize(OutputDevice::LogicToLogic(aGraphic.GetPrefSize(), 
aGraphic.GetPrefMapMode(),
  MapMode(MapUnit::Map100thMM)));
 
 aPagSize.AdjustWidth(-basegfx::fround((pPage->getBorder().getLeft() + 
pPage->getBorder().getRight()).as(pPage->getUnit(;
@@ -217,7 +217,7 @@ void SdGRFFilter::InsertSdrGrafObj(Graphic aGraphic, 
SdPage* pPage)
 aPos.setX(((aPagSize.Width() - aGrfSize.Width()) / 2.0) + 
pPage->getBorder().leftUnit());
 aPos.setY(((aPagSize.Height() - aGrfSize.Height()) / 2.0) + 
pPage->getBorder().upperUnit());
 
-pPage->InsertObject(new SdrGrafObj(pPage->getSdrModelFromSdrPage(), 
+pPage->InsertObject(new SdrGrafObj(pPage->getSdrModelFromSdrPage(),
 aGraphic, ::tools::Rectangle(aPos, aGrfSize)));
 }
 

[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - 12 commits - basctl/source basegfx/CppunitTest_basegfx.mk basegfx/test chart2/source cui/source editeng/source filter/source includ

[Tomaž Vajngerl (via logerrit)]

Rebased ref, commits from common ancestor:
commit 11c082b8d9a90d9dc63a053836cac493c743883c
Author: Tomaž Vajngerl 
AuthorDate: Mon Jul 25 15:38:24 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Tue Jun 13 22:20:23 2023 +0900

svgio: use "frozen" for mapping between token strings and enums

Change-Id: I2061606146cfcb34169dccf69b6f720727839d04

diff --git a/svgio/Library_svgio.mk b/svgio/Library_svgio.mk
index 6221cb141316..76c0e87123bb 100644
--- a/svgio/Library_svgio.mk
+++ b/svgio/Library_svgio.mk
@@ -25,7 +25,10 @@ $(eval $(call gb_Library_set_include,svgio,\
 -I$(SRCDIR)/svgio/inc \
 ))
 
-$(eval $(call gb_Library_use_external,svgio,boost_headers))
+$(eval $(call gb_Library_use_externals,svgio,\
+boost_headers \
+frozen \
+))
 
 $(eval $(call 
gb_Library_set_precompiled_header,svgio,svgio/inc/pch/precompiled_svgio))
 
diff --git a/svgio/source/svgreader/svgtoken.cxx 
b/svgio/source/svgreader/svgtoken.cxx
index 8228689606bf..e283b6e344bb 100644
--- a/svgio/source/svgreader/svgtoken.cxx
+++ b/svgio/source/svgreader/svgtoken.cxx
@@ -18,357 +18,369 @@
  */
 
 #include 
-#include 
+#include 
+#include 
+#include 
+#include 
 
 namespace svgio::svgreader
 {
-const char aSVGStrWidth[] = "width";
-const char aSVGStrHeight[] = "height";
-const char aSVGStrViewBox[] = "viewBox";
-const char aSVGStrTransform[] = "transform";
-const char aSVGStrStyle[] = "style";
-const char aSVGStrDisplay[] = "display"; // #i121656#
-const char aSVGStrD[] = "d";
-const char aSVGStrX[] = "x";
-const char aSVGStrY[] = "y";
-const char aSVGStrXmlns[] = "xmlns";
-const char aSVGStrVersion[] = "version";
-const char aSVGStrId[] = "id";
-const char aSVGStrIn[] = "in";
-const char aSVGStrRx[] = "rx";
-const char aSVGStrRy[] = "ry";
-const char aSVGStrPoints[] = "points";
-const char aSVGStrDx[] = "dx";
-const char aSVGStrDy[] = "dy";
-const char aSVGStrRotate[] = "rotate";
-const char aSVGStrTextLength[] = "textLength";
-const char aSVGStrLengthAdjust[] = "lengthAdjust";
-const char aSVGStrFont[] = "font";
-const char aSVGStrFontFamily[] = "font-family";
-const char aSVGStrFontSize[] = "font-size";
-const char aSVGStrFontSizeAdjust[] = "font-size-adjust";
-const char aSVGStrFontStretch[] = "font-stretch";
-const char aSVGStrFontStyle[] = "font-style";
-const char aSVGStrFontVariant[] = "font-variant";
-const char aSVGStrFontWeight[] = "font-weight";
-const char aSVGStrDirection[] = "direction";
-const char aSVGStrLetterSpacing[] = "letter-spacing";
-const char aSVGStrTextDecoration[] = "text-decoration";
-const char aSVGStrUnicodeBidi[] = "unicode-bidi";
-const char aSVGStrWordSpacing[] = "word-spacing";
-const char aSVGStrTspan[] = "tspan";
-const char aSVGStrTref[] = "tref";
-const char aSVGStrTextPath[] = "textPath";
-const char aSVGStrStartOffset[] = "startOffset";
-const char aSVGStrMethod[] = "method";
-const char aSVGStrSpacing[] = "spacing";
-const char aSVGStrStdDeviation[] = "stdDeviation";
-const char aSVGStrTextAlign[] = "text-align";
-const char aSVGStrPathLength[] = "pathLength";
-const char aSVGStrType[] = "type";
-const char aSVGStrClass[] = "class";
-const char aSVGStrTextAnchor[] = "text-anchor";
-const char aSVGStrXmlSpace[] = "xml:space";
-const char aSVGStrColor[] = "color";
-const char aSVGStrClipPathNode[] = "clipPath";
-const char aSVGStrClipPathProperty[] = "clip-path";
-const char aSVGStrFeGaussianBlur[] = "feGaussianBlur";
-const char aSVGStrFeColorMatrix[] = "feColorMatrix";
-const char aSVGStrFilter[] = "filter";
-const char aSVGStrMask[] = "mask";
-const char aSVGStrClipPathUnits[] = "clipPathUnits";
-const char aSVGStrMaskUnits[] = "maskUnits";
-const char aSVGStrMaskContentUnits[] = "maskContentUnits";
-const char aSVGStrClipRule[] = "clip-rule";
-const char aSVGStrMarker[] = "marker";
-const char aSVGStrMarkerStart[] = "marker-start";
-const char aSVGStrMarkerMid[] = "marker-mid";
-const char aSVGStrMarkerEnd[] = "marker-end";
-const char aSVGStrRefX[] = "refX";
-const char aSVGStrRefY[] = "refY";
-const char aSVGStrMarkerUnits[] = "markerUnits";
-const char aSVGStrMarkerWidth[] = "markerWidth";
-const char aSVGStrMarkerHeight[] = "markerHeight";
-const char aSVGStrOrient[] = "orient";
-const char aSVGStrPattern[] = "pattern";
-const char aSVGStrPatternUnits[] = "patternUnits";
-const char aSVGStrPatternContentUnits[] = "patternContentUnits";
-const char aSVGStrPatternTransform[] = "patternTransform";
-  

[Libreoffice-bugs] [Bug 154757] CPP unit tests: provide message converters to allow use of O(U)Strings as _MESSAGE argument

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154757

--- Comment #1 from Stephan Bergmann  ---
As I mentioned in the comment at

"tdf#154757 Provide O(U)String converters for _MESSAGE arguments":  "I think
the main issue here is that as soon as you need a CPPUNIT_ASSERT_MESSAGE with a
programmatically assembled message, your test is doing something wrong anyway. 
:)  Test code should be as straightforward to understand and to debug for
humans as possible.  Tempting as it may be, it ideally should not contain
[e.g.] any loops over data to test, it should rather spell out those individual
tests explicitly.  Probably each of us occasionally is a sinner in this respect
when writing tests, but my argument against such improvements for the
CPPUNIT_ASSERT_MESSAGE's message argument is always the same:  If you need it,
it would be better to restructure the test code (or, failing that, to bite the
bullet and have some explicit call to OUString::getStr or similar, in the 'bad'
test code)."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150828] Make LibreOffice Writer digital signature functionality available in LibreOffice Draw "File"->"Digital Signatures"->"Sign Existing PDF" (= add signature without alterin

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150828

--- Comment #16 from Lars Uffmann  ---
PS: refer here
https://techhelp.mcla.edu/index.php/File:Readerdcwin3.png

(from article at
https://techhelp.mcla.edu/index.php?title=Creating_Self_Signed_Signatures_in_Adobe_Acrobat_Reader_DC=toggle_view_desktop
)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150828] Make LibreOffice Writer digital signature functionality available in LibreOffice Draw "File"->"Digital Signatures"->"Sign Existing PDF" (= add signature without alterin

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150828

--- Comment #15 from Lars Uffmann  ---
(In reply to Alex Thurgood from comment #14)
> (In reply to Lars Uffmann from comment #13)
> 
>  
> > 2) "Insert"->"Signature Line" -> choose the desired area on a desired page
> > -> in the pop-up, select the signing certificate, "Select" -> "Finish
> > Signing"
> > Result 2: A stamp is added to the selected area, stating
> >   "Digitally signed by:
> >(certificate signer name)
> >Date: dd/mm/"
> >   with a PDF icon as the background image.
> > 
> 
> 
> This is similar to the way it works in Adobe Reader (on macOS at least, I
> can't speak for Windows) for trusted key signatures, i.e. the user is
> invited to draw an area on the page into which the digital signature is
> inserted with a timestamp after entering the passphrase key or PIN code.


Similar, but missing one crucial bit: in Adobe Reader (both on MacOS and
Windows), you can create a signature template, for which you can choose e.g. a
custom signature image.

Adobe Reader permits to toggle signature fields to be displayed in the
document:

[x] Common Name
[x] Distinguished Name
[x] Reason (for signing)
[x] Location
[x] Date
and an option to show a graphic (like LO Writer does)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150828] Make LibreOffice Writer digital signature functionality available in LibreOffice Draw "File"->"Digital Signatures"->"Sign Existing PDF" (= add signature without alterin

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150828

--- Comment #14 from Alex Thurgood  ---
(In reply to Lars Uffmann from comment #13)


> 2) "Insert"->"Signature Line" -> choose the desired area on a desired page
> -> in the pop-up, select the signing certificate, "Select" -> "Finish
> Signing"
> Result 2: A stamp is added to the selected area, stating
>   "Digitally signed by:
>(certificate signer name)
>Date: dd/mm/"
>   with a PDF icon as the background image.
> 


This is similar to the way it works in Adobe Reader (on macOS at least, I can't
speak for Windows) for trusted key signatures, i.e. the user is invited to draw
an area on the page into which the digital signature is inserted with a
timestamp after entering the passphrase key or PIN code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source sc/source

[Henry Castro (via logerrit)]

 oox/source/token/tokens.txt   |1 +
 sc/source/filter/inc/condformatbuffer.hxx |3 +++
 sc/source/filter/oox/condformatbuffer.cxx |   15 +++
 sc/source/filter/oox/extlstcontext.cxx|6 ++
 4 files changed, 25 insertions(+)

New commits:
commit aebf004ae72e914540526269499bae27f39e04bf
Author: Henry Castro 
AuthorDate: Fri Mar 17 10:34:15 2023 -0400
Commit: Henry Castro 
CommitDate: Tue Jun 13 17:45:46 2023 +0200

sc: filter: oox: add missing tag "fillcolor"

To fill the positive color of the conditional format data bar:


 
 
 
 
 


Signed-off-by: Henry Castro 
Change-Id: I17e83a01a292ff941d92f6ae59954aa246ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149064
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152965
Tested-by: Jenkins

diff --git a/oox/source/token/tokens.txt b/oox/source/token/tokens.txt
index dee9010df789..eb5239d8a8ac 100644
--- a/oox/source/token/tokens.txt
+++ b/oox/source/token/tokens.txt
@@ -2228,6 +2228,7 @@ fileType
 fileVersion
 filetime
 fill
+fillColor
 fillClrLst
 fillFormulas
 fillId
diff --git a/sc/source/filter/inc/condformatbuffer.hxx 
b/sc/source/filter/inc/condformatbuffer.hxx
index 992f14e041a8..1180b1e0aa74 100644
--- a/sc/source/filter/inc/condformatbuffer.hxx
+++ b/sc/source/filter/inc/condformatbuffer.hxx
@@ -237,6 +237,7 @@ struct ExCfRuleModel
 ExCfRuleModel() : mnAxisColor( ColorTransparency, UNSIGNED_RGB_TRANSPARENT 
), mnNegativeColor( ColorTransparency, UNSIGNED_RGB_TRANSPARENT ), mbGradient( 
false ), mbIsLower( true ) {}
 // AxisColor
 ::Color mnAxisColor;
+::Color mnPositiveColor;
 // NegativeFillColor
 ::Color mnNegativeColor;
 OUString maAxisPosition; // DataBar
@@ -250,6 +251,7 @@ class ExtCfDataBarRule : public WorksheetHelper
 enum RuleType
 {
 DATABAR,
+POSITIVEFILLCOLOR,
 NEGATIVEFILLCOLOR,
 AXISCOLOR,
 CFVO,
@@ -263,6 +265,7 @@ public:
 ExtCfDataBarRule(ScDataBarFormatData* pTarget, const WorksheetHelper& 
rParent);
 void finalizeImport();
 void importDataBar(  const AttributeList& rAttribs );
+void importPositiveFillColor(  const AttributeList& rAttribs );
 void importNegativeFillColor(  const AttributeList& rAttribs );
 void importAxisColor(  const AttributeList& rAttribs );
 void importCfvo(  const AttributeList& rAttribs );
diff --git a/sc/source/filter/oox/condformatbuffer.cxx 
b/sc/source/filter/oox/condformatbuffer.cxx
index ac5c2738aa47..63e75170a367 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -1322,6 +1322,12 @@ void ExtCfDataBarRule::finalizeImport()
 pDataBar->maAxisColor = maModel.mnAxisColor;
 break;
 }
+case POSITIVEFILLCOLOR:
+{
+ScDataBarFormatData* pDataBar = mpTarget;
+pDataBar->maPositiveColor = maModel.mnPositiveColor;
+break;
+}
 case NEGATIVEFILLCOLOR:
 {
 ScDataBarFormatData* pDataBar = mpTarget;
@@ -1367,6 +1373,15 @@ void ExtCfDataBarRule::importDataBar( const 
AttributeList& rAttribs )
 maModel.maAxisPosition = rAttribs.getString( XML_axisPosition, "automatic" 
);
 }
 
+void ExtCfDataBarRule::importPositiveFillColor( const AttributeList& rAttribs )
+{
+mnRuleType = POSITIVEFILLCOLOR;
+ThemeBuffer& rThemeBuffer = getTheme();
+GraphicHelper& rGraphicHelper = getBaseFilter().getGraphicHelper();
+::Color aColor = importOOXColor(rAttribs, rThemeBuffer, rGraphicHelper);
+maModel.mnPositiveColor = aColor;
+}
+
 void ExtCfDataBarRule::importNegativeFillColor( const AttributeList& rAttribs )
 {
 mnRuleType = NEGATIVEFILLCOLOR;
diff --git a/sc/source/filter/oox/extlstcontext.cxx 
b/sc/source/filter/oox/extlstcontext.cxx
index 45e60e7c6f5e..760ba26c1727 100644
--- a/sc/source/filter/oox/extlstcontext.cxx
+++ b/sc/source/filter/oox/extlstcontext.cxx
@@ -56,6 +56,12 @@ void ExtCfRuleContext::onStartElement( const AttributeList& 
rAttribs )
 xRule->importDataBar( rAttribs );
 break;
 }
+case XLS14_TOKEN( fillColor ):
+{
+ExtCfDataBarRuleRef xRule = 
getCondFormats().createExtCfDataBarRule(mpTarget);
+xRule->importPositiveFillColor( rAttribs );
+break;
+}
 case XLS14_TOKEN( negativeFillColor ):
 {
 ExtCfDataBarRuleRef xRule = 
getCondFormats().createExtCfDataBarRule(mpTarget);

[Libreoffice-bugs] [Bug 147514] How many copies you want of something should not be hidden in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147514

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #1 from V Stuart Foote  ---
Find no issue with layout of the print dialog 'Range and Copies' and 'Page
Layout' supplemented with their 'More' exposure triangles.

What is visible suffices and are core to configuring the print job. While the
'Number of copies' field would not fit cleanly on the default panel, and is not
relevant to core task of configuring what to print.  It can't all fit so the
'More' extenders are necessary anyway and the copies count is fine there.

IMHO => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.