[Libreoffice-bugs] [Bug 156321] FORMATTING: Styles lost on nested elements in content

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156321

Dieter  changed:

   What|Removed |Added

Version|7.4.5.1 release |7.4.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156321] FORMATTING: Styles lost on nested elements in content

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156321

Dieter  changed:

   What|Removed |Added

Version|7.4.6.2 release |7.4.5.1 release
 CC||dgp-m...@gmx.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156343] New: Scrollbars size does not change on Mouse-Over

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156343

Bug ID: 156343
   Summary: Scrollbars size does not change on Mouse-Over
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bernh...@bmhome.ch

Description:
Desktop environments such as Xfce4 do change the size of the scrollbar slider
on Mouse-Over. This behaviour is not reflected in LibreOffice which makes it
difficult to grab and move the slider (both horizontally and vertically).

Steps to Reproduce:
1. open any libreoffice component
2. try to grab and slide any scrollbar


Actual Results:
the sliders in the scrollbar stay small - difficult to grab

Expected Results:
the size of the slider should change


Reproducible: Always


User Profile Reset: No

Additional Info:
I cannot get beyond this version for my environment:
libreoffice is already the newest version (1:7.3.7-0ubuntu0.22.04.3).

about LibreOffice:
Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: de-CH (de_CH.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.3
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135628] SendSimpleMailMessage bodytext ends up as multiple recipients

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135628

--- Comment #16 from Abdullah Sajid  ---
Ensure your mass email gets sent by entering your own email address as the
recipient in the 'TO' field. https://spotsungs.com/spotify-premium-apk-2/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156321] FORMATTING: Styles lost on nested elements in content

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156321

Phillip  changed:

   What|Removed |Added

Version|7.4.7.2 release |7.4.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156321] FORMATTING: Styles lost on nested elements in content

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156321

--- Comment #2 from Phillip  ---
On further testing, looks like it was working in 7.4.5.1 but not working in
7.4.6.1 so hopefully that narrows it down...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: configmgr/source

2023-07-17 Thread Mike Kaganski (via logerrit)
 configmgr/source/broadcaster.cxx |   25 -
 configmgr/source/broadcaster.hxx |3 ++-
 configmgr/source/rootaccess.cxx  |2 +-
 3 files changed, 19 insertions(+), 11 deletions(-)

New commits:
commit 8e9b3abce97f6ec1851cb7e3464e63107fad2793
Author: Mike Kaganski 
AuthorDate: Tue Jul 18 00:28:41 2023 +0300
Commit: Mike Kaganski 
CommitDate: Tue Jul 18 06:54:47 2023 +0200

Make sure that root listeners are notified first

The problem appeared when in a configuration listener's changesOccurred,
a configuration value was read using officecfg machinery, which could
return the old value of the configuration, or an updated one, at random.

This was caused by use of a cached value in
comphelper::detail::ConfigurationWrapper::getPropertyValue, which is
cleaned in ConfigurationChangesListener::changesOccurred; but the order
in which the listeners' changesOccurred methods were called depended on
the implementation detail of configmgr::Components::roots_, which was
previously a std::set of pointers, and now is a sorted vector. This
made the pointers sorted in order of the pointers' addresses (basically
random), and when a broadcaster's common list of change listeners was
prepared in Components::initGlobalBroadcaster, ConfigurationWrapper's
listener could arrive last. This meant, that the cache could be cleaned
too late, after its obsolete content was already used in a previous
listener.

The problem could be partially mitigated by clearing the cache in the
comphelper::detail::ConfigurationWrapper::setPropertyValue, but that
would only handle cases of config modifications using comphelper.

Instead, take into account that ConfigurationWrapper listens on the
root of configuration tree; and introduce a separate container in
configmgr::Broadcaster for root listeners. They would be triggered
first, before all other listeners.

Still, this would not guarantee the proper order, if another listener
is registered on root. To handle all cases, a special listener category
could be used, which could be filled using a dedicated internal API, so
comphelper could use it to register its privileged listener close to
the heart of the broadcaster :) This might be implemented later.

Change-Id: I956b7989b3927dca2683f63cf92b0dda04db9bdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154561
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/configmgr/source/broadcaster.cxx b/configmgr/source/broadcaster.cxx
index 03bcf8f273de..365e25f9eb02 100644
--- a/configmgr/source/broadcaster.cxx
+++ b/configmgr/source/broadcaster.cxx
@@ -97,9 +97,12 @@ void Broadcaster::addPropertiesChangeNotification(
 
 void Broadcaster::addChangesNotification(
 css::uno::Reference< css::util::XChangesListener > const & listener,
-css::util::ChangesEvent const & event)
+css::util::ChangesEvent const & event, bool bRootListener)
 {
-changesNotifications_.emplace_back(listener, event);
+if (bRootListener)
+rootChangesNotifications_.emplace_back(listener, event);
+else
+changesNotifications_.emplace_back(listener, event);
 }
 
 void Broadcaster::send() {
@@ -164,13 +167,17 @@ void Broadcaster::send() {
 appendMessage(messages, e);
 }
 }
-for (auto& rNotification : changesNotifications_) {
-try {
-rNotification.listener->changesOccurred(rNotification.event);
-} catch (css::lang::DisposedException &) {
-} catch (css::uno::Exception & e) {
-exception = cppu::getCaughtException();
-appendMessage(messages, e);
+// First root listeners, then the rest
+for (const auto& container : { rootChangesNotifications_ , 
changesNotifications_})
+{
+for (auto& rNotification : container) {
+try {
+rNotification.listener->changesOccurred(rNotification.event);
+} catch (css::lang::DisposedException &) {
+} catch (css::uno::Exception & e) {
+exception = cppu::getCaughtException();
+appendMessage(messages, e);
+}
 }
 }
 if (exception.hasValue()) {
diff --git a/configmgr/source/broadcaster.hxx b/configmgr/source/broadcaster.hxx
index d0c461e731d8..711e7a83bd9e 100644
--- a/configmgr/source/broadcaster.hxx
+++ b/configmgr/source/broadcaster.hxx
@@ -72,7 +72,7 @@ public:
 
 void addChangesNotification(
 css::uno::Reference< css::util::XChangesListener > const & listener,
-css::util::ChangesEvent const & event);
+css::util::ChangesEvent const & event, bool bRootListener);
 
 void send();
 
@@ -131,6 +131,7 @@ private:
 std::vector< ContainerNotification > 
containerElementReplacedNotifications_;
 std::vector< PropertyChangeNotification > propertyChangeNotifications_;
 std::vector< 

[Libreoffice-commits] core.git: vcl/skia

2023-07-17 Thread Aron Budea (via logerrit)
 vcl/skia/gdiimpl.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4202dfcae19ee47e9a3fda02fac34c18cb0d16ff
Author: Aron Budea 
AuthorDate: Sun Jul 16 17:25:55 2023 +0200
Commit: Tomaž Vajngerl 
CommitDate: Tue Jul 18 06:50:30 2023 +0200

tdf#155661 Apply border from center point not from whole size

Regression from 6965bb07bb33429a7663a3f3ebe58ed89c4327d9
and 8b8a988f38b704e466211bb91a3269756c34222b.

Change-Id: I2e8c21fbdbbc7efb4b473c63b098044384a70d6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154501
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 3c0957be4806..45f3fc1c1b97 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -2049,8 +2049,8 @@ bool SkiaSalGraphicsImpl::drawGradient(const 
tools::PolyPolygon& rPolyPolygon,
   SkPoint::Make(toSkX(aPoly[1].X()), 
toSkY(aPoly[1].Y())) };
 SkColor colors[3] = { endColor, startColor, endColor };
 SkScalar border = SkDoubleToScalar(aGradient.GetBorder() / 100.0);
-SkScalar pos[3]
-= { std::min(border, 0.5), 0.5, std::max(1 - 
border, 0.5) };
+SkScalar pos[3] = { std::min(border * 0.5f, 0.5f), 0.5f,
+std::max(1 - border * 0.5f, 0.5f) };
 shader = SkGradientShader::MakeLinear(points, colors, pos, 3, 
SkTileMode::kClamp);
 }
 else


[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103314
Bug 103314 depends on bug 118755, which changed state.

Bug 118755 Summary: Save as template does not overwrite as required
https://bugs.documentfoundation.org/show_bug.cgi?id=118755

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118755] Save as template does not overwrite as required

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118755

Buovjaga  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WORKSFORME  |---

--- Comment #10 from Buovjaga  ---
Elmar: please stop incorrectly marking this as worksforme.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156224] Capitalization doesn't work when sentence ends with a French quotation mark

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156224

--- Comment #2 from Ezinne  ---
Not reproducible in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 77fca616e0bd79e0b405fd0b3543cf8e94e15df3
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (en_GB.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151792] In presenter view, Impress seems to remove formatting from notes

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151792

--- Comment #2 from Ezinne  ---
Not reproducible in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 77fca616e0bd79e0b405fd0b3543cf8e94e15df3
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156228] TABLES: formatting marks missing

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156228

Ezinne  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #10 from Ezinne  ---
Reproducible in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 77fca616e0bd79e0b405fd0b3543cf8e94e15df3
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156148] Unattended Windows command line convert (headless) has inconsistant results

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156148

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155882] "Recency" is not explained in Navigator

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155882

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156131] Duplex (two-sided) printing not possible using MacBook and HP Envy 6020e printer.

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156131

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156299] Icon inconsistencies: menu Insert shape and Sidebar Shapes deck

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156299

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156299] Icon inconsistencies: menu Insert shape and Sidebar Shapes deck

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156299

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156225] High CPU usage in Writer when opening a commented DOCX file

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156225

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143404] FILEOPEN DOCX Rejecting change tracked paragraph align change in table increases spacing after paragraph

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143404

--- Comment #4 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156225] High CPU usage in Writer when opening a commented DOCX file

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156225

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 52359] "Show Details" won't work as expected

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=52359

--- Comment #11 from QA Administrators  ---
Dear Daniel Szabo,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156219] language tool extension doesn't work

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156219

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156219] language tool extension doesn't work

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156219

--- Comment #18 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148208] Can't insert image in LibreOffice Calc or not anchored correctly

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148208

--- Comment #4 from QA Administrators  ---
Dear scoccac,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134139] Long translated strings cause layout havoc in options dialog

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134139

--- Comment #16 from QA Administrators  ---
Dear mat.venturini,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126920] LibreOffice Calc is oversensitive to pasting overlapping images

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126920

--- Comment #11 from QA Administrators  ---
Dear Chris Shaw,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107409] FILESAVE DOC: Formula's seem to be (badly) rendered EMF+ images

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107409

--- Comment #12 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156342] request or enhancement: recognition of strokes

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156342

--- Comment #1 from ksso  ---
Created attachment 188427
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188427=edit
stroke recognition enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156342] New: request or enhancement: recognition of strokes

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156342

Bug ID: 156342
   Summary: request or enhancement: recognition of strokes
   Product: LibreOffice
   Version: 7.5.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kep...@gmail.com

Description:
this is not a bug
the improvement would be an extension or compilation of stroke recognition for
kanji, characters and symbols.
If you are going to search for a kanji, character or symbol instead of
searching for it one by one, by font, by radicals, by similarity, you trace in
a box and libreoffice recognizes it and searches for it.

Steps to Reproduce:
1.open symbol window
2.there is a box where you can stroke your symbol, character, kanji, etc.
3.you find a set of similarities

Actual Results:
one by one search 

Expected Results:
stroke recognition box


Reproducible: Couldn't Reproduce


User Profile Reset: No

Additional Info:
attached screenshot of something similare

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103314
Bug 103314 depends on bug 118755, which changed state.

Bug 118755 Summary: Save as template does not overwrite as required
https://bugs.documentfoundation.org/show_bug.cgi?id=118755

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118755] Save as template does not overwrite as required

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118755

Elmar  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156341] Impress Tabbed UI: extra toolbars

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156341

--- Comment #2 from ksso  ---
Created attachment 188426
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188426=edit
impress tabbed without extensions (and two extra toolbars)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113687] Wrong cell attributes assumed

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113687

Elmar  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #16 from Elmar  ---
I do not understand the logic.
If I am going to base a decision on what the user guide says, then I can simply
change the user guide to fit my decision.
What does the standard say?
If it does not address this who arbitrates?
But, I see that this does not have the support of anyone else, so after a last
attempt to change your (development team) collective mind, I will let it go
after one last attempt at improving usability.

Why permit add row above / left if the attributes are only going to be assumed
from above or to the left? If I add a row above, it means I want the row above
it to have the same attributes. Ditto add left.

It is like offering a child and ice cream of any flavour and then telling them
that they can only have strawberry.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156109] Mutual exclusion of split-preventing options in Text Flow is confusing.

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156109

--- Comment #6 from Kazinator  ---
(In reply to Heiko Tietze from comment #4)
> Radio buttons are a good way to show the mutual dependency. But Dieter has a
> point with his questions as "[ ] Do not split" meaning splitting is allowed
> has no direct consequence to orphan and widow settings (and I'd definitely
> keep the common terms).
> 
> It means essentially this
> 
> (o) Do not split paragraph
> ( ) Do split paragraph
> [ ] Orphan control [   ]
> [ ] Widow control  [   ]
> [x] Keep with next paragraph

I apologize. I have exclusively focused the discussion on the mutually
exclusive elements, and neglected to make any remarks on the "Keep with next
paragraph".

This option is currently sandwiched between the two settings that are mutually
exclusive sets of checks. So the very placement of that is bad.

I've used "Keep with next paragraph", but am not sure of the exact semantics,
and how it interacts with the split controls.

I see you've added the checkbox and simplified my radio button proposal to two
choices.  The choice to just split the paragraph freely (break it wherever it
is physically convenient for the page break to occur). Indeed, the behavior can
be obtained by adjusting the Orphan and Widow controls down to one line.

I think when we have pared down three choices down to two, we can revert back
to a checkbox:

  [x] Allow paragraph to be split
  [ ] Orphan control [   ]
  [ ] Widow control  [   ]


  [x] Keep with next paragraph

Uncheck the Allow... and it means do not split.

Since we have enable checkboxes already on Orphan and Widow, why have another
parent enabler?


   [ ] Allow paragraph split with [   ] orphan lines

   [ ] Allow paragraph split with [   ] widow lines

   [ ] Keep with next paragraph

If the widow and orphan checkboxes are not checked, then the paragraph is not
split.

The logical polarity of "Keep with" could be aligned with the other two. Here
is what the defaults would be: everything on, with 2 lines:

   [x] Allow paragraph split with [  2] orphan lines

   [x] Allow paragraph split with [  2] widow lines

   [x] Allow break between this and next paragraph

Don't want splits and breaks, uncheck things. Nothing is exclusive.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 156109] Mutual exclusion of split-preventing options in Text Flow is confusing.

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156109

--- Comment #6 from Kazinator  ---
(In reply to Heiko Tietze from comment #4)
> Radio buttons are a good way to show the mutual dependency. But Dieter has a
> point with his questions as "[ ] Do not split" meaning splitting is allowed
> has no direct consequence to orphan and widow settings (and I'd definitely
> keep the common terms).
> 
> It means essentially this
> 
> (o) Do not split paragraph
> ( ) Do split paragraph
> [ ] Orphan control [   ]
> [ ] Widow control  [   ]
> [x] Keep with next paragraph

I apologize. I have exclusively focused the discussion on the mutually
exclusive elements, and neglected to make any remarks on the "Keep with next
paragraph".

This option is currently sandwiched between the two settings that are mutually
exclusive sets of checks. So the very placement of that is bad.

I've used "Keep with next paragraph", but am not sure of the exact semantics,
and how it interacts with the split controls.

I see you've added the checkbox and simplified my radio button proposal to two
choices.  The choice to just split the paragraph freely (break it wherever it
is physically convenient for the page break to occur). Indeed, the behavior can
be obtained by adjusting the Orphan and Widow controls down to one line.

I think when we have pared down three choices down to two, we can revert back
to a checkbox:

  [x] Allow paragraph to be split
  [ ] Orphan control [   ]
  [ ] Widow control  [   ]


  [x] Keep with next paragraph

Uncheck the Allow... and it means do not split.

Since we have enable checkboxes already on Orphan and Widow, why have another
parent enabler?


   [ ] Allow paragraph split with [   ] orphan lines

   [ ] Allow paragraph split with [   ] widow lines

   [ ] Keep with next paragraph

If the widow and orphan checkboxes are not checked, then the paragraph is not
split.

The logical polarity of "Keep with" could be aligned with the other two. Here
is what the defaults would be: everything on, with 2 lines:

   [x] Allow paragraph split with [  2] orphan lines

   [x] Allow paragraph split with [  2] widow lines

   [x] Allow break between this and next paragraph

Don't want splits and breaks, uncheck things. Nothing is exclusive.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 156341] Impress Tabbed UI: extra toolbars

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156341

--- Comment #1 from ksso  ---
Created attachment 188425
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188425=edit
impress tabbed with extensions (and two extra oolbars)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156341] New: Impress Tabbed UI: extra toolbars

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156341

Bug ID: 156341
   Summary: Impress Tabbed UI: extra toolbars
   Product: LibreOffice
   Version: 7.5.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kep...@gmail.com

Description:
without and with extensions, normal tabbed UI of impress shows to extra tool
bars that decrease the space for working

Steps to Reproduce:
1.open impress
2.swith tabbed view
3.there are extra toolbars repeating commands of tabs

Actual Results:
extra toolbars that can not be hidden or closed

Expected Results:
customized workspace


Reproducible: Always


User Profile Reset: No

Additional Info:
attached screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156280] Tabbed UI: extension toolbar shown twice, inside and outside the Extensions tab

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156280

--- Comment #9 from ksso  ---
Created attachment 188424
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188424=edit
lo version

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156280] Tabbed UI: extension toolbar shown twice, inside and outside the Extensions tab

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156280

--- Comment #8 from ksso  ---
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: es-CO (es_CO.UTF-8); UI: es-ES
Ubuntu package version: 4:7.5.4-0ubuntu0.23.04.1
Calc: threaded (attached screenshot)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156320] Conditional formats not copied properly

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156320

--- Comment #2 from Daniel Moisio  ---
Lazarus,

Hello I am not sure if this is a bug or not.

I believe I have replicated the behavior; however, it looks to be more just a
convention.

In that, if A:A has conditional format 'red fill if number<1' for example

and B:B, C:C, D:D, and E:E all have the same conditional format 'green fill if
number<1' - then when you duplicate the sheet you'd see the ranges you
described.

Because the conditional format 'green fill if number<1' is the same for Columns
B,C,D, and E - and the program just groups those together.

That said, if you could be more specific if this is happening when each column
has a different conditional format? Or if you can say why specifically you view
it as a bug - please comment back!

Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156219] language tool extension doesn't work

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156219

--- Comment #17 from ksso  ---
Created attachment 188423
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188423=edit
lightproof protected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156219] language tool extension doesn't work

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156219

--- Comment #16 from ksso  ---
does not work for any language

this extension (LightProof grammar checker) is built-in or protected, it cannot
be deactivated (attached screenshot)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156323] LibreOffice should keep print settings

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156323

m.a.riosv  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156320] Conditional formats not copied properly

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156320

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Please attach a sample file, and how do you duplicate the sheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107698] EDITING: vertical position of controls anchored to cell incorrectly updated when non-default height rows are inserted/deleted above

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107698

m.a.riosv  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #14 from m.a.riosv  ---
Fixed is marked when there is an explicit patch to resolve the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery/Backup copy issues

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77999

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||151708


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151708
[Bug 151708] Unsaved documents are no longer recovered
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151708] Unsaved documents are no longer recovered

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151708

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||77999


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=77999
[Bug 77999] [META] Autosave/Autorecovery/Backup copy issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156340] Document contains macro signed by OpenPGP key can't be enabled and causes operation hanging

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156340

--- Comment #1 from Franklin Weng  ---
I have to manually kill the LibreOffice process from command line to exit
LibreOffice.

Also, even I checked to "Always trust macros from this source" and clicked
"Enable macros", it still told me that Macros disabled.  But from there, I
could check macros and exit LibreOffice.  It still told me Broken certificate
data when I clicked Macro Security in Tools - Options - Security, and the next
time I open it, it still asked me if I trust the signature or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156340] New: Document contains macro signed by OpenPGP key can't be enabled and causes operation hanging

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156340

Bug ID: 156340
   Summary: Document contains macro signed by OpenPGP key can't be
enabled and causes operation hanging
   Product: LibreOffice
   Version: 7.6.0.0 beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: frank...@goodhorse.idv.tw

Created attachment 188422
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188422=edit
Problematic file with signed signature

https://ask.libreoffice.org/t/the-right-way-to-sign-a-macro/93656

The attachment there (also attached here) is an ods file with a simple macro,
signed by the author's OpenPGP key.  He signed the macro but not the file
itself.

When I opened it with LibreOffice 7.6.0.1, it asked me if I would trust the
signature or not.  If I clicked View Signature, it didn't show the signature,
but directly got into the main screen with the macro button there.  But then it
told me that the macro was disabled due to Macro Security Settings (I set it to
"Medium" - Confirmed required before executing macros from untrusted sources).  

Now a couple of problems here - 
1. In this condition, I couldn't leave LibreOffice.  Either clicked the x
button in the upright corner, or selected "Exit LibreOffice" from File menu
didn't work.
2. It didn't respond when I click "Show Macros" or hit the macro button ("hello
world").
3. In the Tools - Options - Security, when I clicked Macro Security to check,
it popped a window saying 

Macro security problem!  
Broken certificate data: 
[a bunch of bogus messages]
com.sun.star.uno.RuntimeException message: "at
/home/buildslave/source/libo-core/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx:307"

before showing the Macro security window.

The file is signed by 7.0.4.2.  

Tested by 7.6.0.1:
Version: 7.6.0.1 (X86_64) / LibreOffice Community
Build ID: 776eaf34564cbf3f034a0ba1fd1d5c32ff9ccf1c
CPU threads: 4; OS: Linux 6.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: zh-TW (zh_TW.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107237
Bug 107237 depends on bug 136905, which changed state.

Bug 136905 Summary: NB Layout tab 'Page Size' drop list UX is poor
https://bugs.documentfoundation.org/show_bug.cgi?id=136905

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136905] NB Layout tab 'Page Size' drop list UX is poor

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136905

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136905] NB Layout tab 'Page Size' drop list UX is poor

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136905

--- Comment #9 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6256d5fe2e7cb1bb002d5fe59527d3a3fbf6963f

tdf#136905 NBB: use label font in ValueSetWithTextControl

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/source

2023-07-17 Thread Justin Luth (via logerrit)
 svx/source/sidebar/tools/ValueSetWithTextControl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6256d5fe2e7cb1bb002d5fe59527d3a3fbf6963f
Author: Justin Luth 
AuthorDate: Mon Jul 10 15:27:29 2023 -0400
Commit: Justin Luth 
CommitDate: Tue Jul 18 02:40:08 2023 +0200

tdf#136905 NBB: use label font in ValueSetWithTextControl

The label font is taken from the system settings,
and doing this matched the "more options" button font
as well as the nearby "margins" and "columns"
as well as pretty much everything else in the notebookbar.

I tested this by changing "Font Selection" in my Ubuntu Cinnamon
to a flowery font. Prior to the patch it was a normalish font,
but after the change it was using the flowery font.

Change-Id: I2585e6aec31aa4195a2354337eb243e63c719ec0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154555
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx 
b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
index 77b260272264..91cea51325e6 100644
--- a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
+++ b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
@@ -75,7 +75,7 @@ void ValueSetWithTextControl::UserDraw( const UserDrawEvent& 
rUDEvt )
 
 const tools::Long nRectHeight = aRect.GetHeight();
 
-vcl::Font aFont(OutputDevice::GetDefaultFont(DefaultFontType::UI_SANS, 
MsLangId::getConfiguredSystemLanguage(), GetDefaultFontFlags::OnlyOne));
+vcl::Font 
aFont(Application::GetSettings().GetStyleSettings().GetLabelFont());
 {
 Size aSize = aFont.GetFontSize();
 aSize.setHeight( (nRectHeight*4)/9 );


[Libreoffice-bugs] [Bug 126095] NB Impress/Draw: "Drawing" toolbar visible which should be hidden for notebookbar view when apply-to-all done in another app

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126095

--- Comment #21 from Justin L  ---
(In reply to Stéphane Guillou (stragu) from comment #17)
> Justin, any chance you could you do the same for the table toolbar that pops
> up when a table is selected in Draw/Impress?

The first three are now avoided:

graphicobjectbar: for calc/writer the default is to be visible, but for
draw/impress, it is set to be not visible
officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu
 
false

mediaobjectbar: for draw it is visible, but for impress it is not visible

tableobjectbar: for draw/impress it is visible


These remaining ones are not impacted. Perhaps they should be if they are
visible...

textobjectbar: for draw/impress it is not visible
   -(connected with a table, but not with a textbox)

extrusionobjectbar (3d stuff) for draw/impress it is visible (I don't know how
to trigger this - inserting a 3-d object doesn't call it.)

fontworkobjectbar: for draw/impress it is visible (but I don't see it coming
up. It DOES come up for the regular menu. So how is notebookbar suppressing
this one?)

bezierobjectbar: for draw/impress it is visible (but I don't know how to
trigger this)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126095] NB Impress/Draw: "Drawing" toolbar visible which should be hidden for notebookbar view when apply-to-all done in another app

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126095

--- Comment #20 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e58e251756ecb0312cb6891d4df23e17ef8f6fcb

tdf#126095 sd notebookbar: don't force table/media toolbar

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/source

2023-07-17 Thread Justin Luth (via logerrit)
 sd/source/ui/view/ToolBarManager.cxx |   66 +++
 1 file changed, 36 insertions(+), 30 deletions(-)

New commits:
commit e58e251756ecb0312cb6891d4df23e17ef8f6fcb
Author: Justin Luth 
AuthorDate: Mon Jul 17 15:43:39 2023 -0400
Commit: Justin Luth 
CommitDate: Tue Jul 18 02:33:24 2023 +0200

tdf#126095 sd notebookbar: don't force table/media toolbar

Perhaps the entire function could return early
in case the notebookbar is active, but only if all of them
have a context notebookbar tab.
Some of them I can't check since I don't know how to trigger them.

Images, media, and tables all do have a context bar.
(Media's bar is missing useful things like location, mute,
and even file-location path.
(Those will come separately in another commit.)

Change-Id: Ic4623a1cab3abc1ac1f83622cbd11e549d2b0b98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154559
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sd/source/ui/view/ToolBarManager.cxx 
b/sd/source/ui/view/ToolBarManager.cxx
index edd39c73110b..0db84b25a3b4 100644
--- a/sd/source/ui/view/ToolBarManager.cxx
+++ b/sd/source/ui/view/ToolBarManager.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1043,42 +1044,47 @@ void ToolBarRules::SelectionHasChanged (
 
 mpToolBarManager->ResetToolBars(ToolBarManager::ToolBarGroup::Function);
 
-switch (rView.GetContext())
+if (!sfx2::SfxNotebookBar::IsActive())
 {
-case SdrViewContext::Graphic:
-if( !bTextEdit )
-
mpToolBarManager->SetToolBarShell(ToolBarManager::ToolBarGroup::Function, 
ToolbarId::Draw_Graf_Toolbox);
-break;
+switch (rView.GetContext())
+{
+case SdrViewContext::Graphic:
+if (!bTextEdit)
+
mpToolBarManager->SetToolBarShell(ToolBarManager::ToolBarGroup::Function,
+  
ToolbarId::Draw_Graf_Toolbox);
+break;
 
-case SdrViewContext::Media:
-if( !bTextEdit )
-
mpToolBarManager->SetToolBarShell(ToolBarManager::ToolBarGroup::Function, 
ToolbarId::Draw_Media_Toolbox);
-break;
+case SdrViewContext::Media:
+if (!bTextEdit)
+
mpToolBarManager->SetToolBarShell(ToolBarManager::ToolBarGroup::Function,
+  
ToolbarId::Draw_Media_Toolbox);
+break;
 
-case SdrViewContext::Table:
-
mpToolBarManager->SetToolBarShell(ToolBarManager::ToolBarGroup::Function, 
ToolbarId::Draw_Table_Toolbox);
-bTextEdit = true;
-break;
+case SdrViewContext::Table:
+
mpToolBarManager->SetToolBarShell(ToolBarManager::ToolBarGroup::Function,
+  
ToolbarId::Draw_Table_Toolbox);
+bTextEdit = true;
+break;
 
-case SdrViewContext::Standard:
-default:
-if( !bTextEdit )
-{
-switch(rViewShell.GetShellType())
+case SdrViewContext::Standard:
+default:
+if (!bTextEdit)
 {
-case ::sd::ViewShell::ST_IMPRESS:
-case ::sd::ViewShell::ST_DRAW:
-case ::sd::ViewShell::ST_NOTES:
-case ::sd::ViewShell::ST_HANDOUT:
-mpToolBarManager->SetToolBar(
-ToolBarManager::ToolBarGroup::Function,
-ToolBarManager::msDrawingObjectToolBar);
-break;
-default:
-break;
+switch(rViewShell.GetShellType())
+{
+case ::sd::ViewShell::ST_IMPRESS:
+case ::sd::ViewShell::ST_DRAW:
+case ::sd::ViewShell::ST_NOTES:
+case ::sd::ViewShell::ST_HANDOUT:
+
mpToolBarManager->SetToolBar(ToolBarManager::ToolBarGroup::Function,
+ 
ToolBarManager::msDrawingObjectToolBar);
+break;
+default:
+break;
+}
+break;
 }
-break;
-}
+}
 }
 
 if( bTextEdit )


[Libreoffice-bugs] [Bug 126095] NB Impress/Draw: "Drawing" toolbar visible which should be hidden for notebookbar view when apply-to-all done in another app

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126095

--- Comment #19 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1de07de0cb063760474df70d0e4b6a7976ac2a8a

related tdf#126095 sd notebookbar: give room to .uno:AVMediaToolBox

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/uiconfig

2023-07-17 Thread Justin Luth (via logerrit)
 sd/uiconfig/sdraw/ui/notebookbar.ui|   67 +++--
 sd/uiconfig/simpress/ui/notebookbar.ui |   67 +++--
 2 files changed, 32 insertions(+), 102 deletions(-)

New commits:
commit 1de07de0cb063760474df70d0e4b6a7976ac2a8a
Author: Justin Luth 
AuthorDate: Mon Jul 17 16:40:03 2023 -0400
Commit: Justin Luth 
CommitDate: Tue Jul 18 02:26:57 2023 +0200

related tdf#126095 sd notebookbar: give room to .uno:AVMediaToolBox

There are lots of controls on the media player (like mute, position etc)
that are obviously not accessible if the control is squished to a small 
size.

Giving full access is especially important if we do not show
the extra toolbar, but depend on this notebookbar context switch.

Change-Id: Ie766c426182469015a3431b83c852ce16d7436f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154560
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sd/uiconfig/sdraw/ui/notebookbar.ui 
b/sd/uiconfig/sdraw/ui/notebookbar.ui
index e95a36ed176b..ea430f492fb3 100644
--- a/sd/uiconfig/sdraw/ui/notebookbar.ui
+++ b/sd/uiconfig/sdraw/ui/notebookbar.ui
@@ -14860,66 +14860,31 @@
   
 
 
-  
+
+148
 True
-False
-vertical
-
-  
-148
-True
-True
-False
-
-  
-True
-.uno:AVMediaToolBox
-  
-  
-False
-True
-  
-
-  
-  
-False
-True
-0
-  
-
+True
+False
 
-  
+
 True
-True
-both-horiz
-False
-
-  
-True
-.uno:AVMediaPlayer
-  
-  
-False
-True
-  
-
-  
-  
+.uno:AVMediaToolBox
+
+
 False
-True
-1
-  
+True
+
 
-  
-  
-False
+
+
+True
 True
-1
-  
+0
+
 
   
   
-False
+True
 True
 1
   
diff --git a/sd/uiconfig/simpress/ui/notebookbar.ui 
b/sd/uiconfig/simpress/ui/notebookbar.ui
index 5f4a85dc0d21..3e761fd8a2f9 100644
--- a/sd/uiconfig/simpress/ui/notebookbar.ui
+++ b/sd/uiconfig/simpress/ui/notebookbar.ui
@@ -14881,66 +14881,31 @@
   
 
 
-  
+
+148
 True
-False
-vertical
-
-  
-148
-True
-True
-False
-
-  
-True
-.uno:AVMediaToolBox
-  
-   

[Libreoffice-bugs] [Bug 156163] Thick Lines Not Printing as Thick

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156163

catheri...@vivaldi.net changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156327] F1 on "Search Commands" does not find relevant help page

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156327

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||rafael.palma.l...@gmail.com
 Status|UNCONFIRMED |NEW

--- Comment #1 from Rafael Lima  ---
Confirmed with

Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.5.4-0ubuntu0.23.04.1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156339] When text is selected, only selected text is exported

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156339

Erik Moeller  changed:

   What|Removed |Added

Version|unspecified |6.4.7.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142489] Do not display "Table" toolbar by default in Impress

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142489

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||6095

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126095] NB Impress/Draw: "Drawing" toolbar visible which should be hidden for notebookbar view when apply-to-all done in another app

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126095

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2489

--- Comment #18 from Rafael Lima  ---
(In reply to Stéphane Guillou (stragu) from comment #17)
> Justin, any chance you could you do the same for the table toolbar that pops
> up when a table is selected in Draw/Impress?

I guess this would fix bug 142489 as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155983] Strange black squares appear when loading PDFs with LibreOffice Draw

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155983

--- Comment #5 from V Stuart Foote  ---
Created attachment 188421
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188421=edit
no issue with PDF with Insert filter and 600dpi resolution as opposed to the
Import filters

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155983] Strange black squares appear when loading PDFs with LibreOffice Draw

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155983

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #4 from V Stuart Foote  ---
Nothing new here.

This is mostly caused by mismatch between the font names recorded to the PDF
and the font names as installed  to your system.  The names don't match and the
os attempts fall back replacment.  When imported to Draw, we don't make much
use of the minimal font set recorded into the PDF, and the rest of the draw
objects get fallback which may or maynot result in good quality rendering of
the text runs--even more of an issue with CJK fonts.

However, the project also provides the Chromium projects "pdfium" based insert
filter. Because it uses the exact fonts for strings contained in the PDF it can
render with very good fidelity to the original PDF.  The default resolution is
set low for performance, but can be increased by setting a
PDFIMPORT_RESOLUTION_DPI environment variable. Insertion of the PDF as an image
at 600 dpi or 1200 dpi will satisfy most work flows for high quality rendering
of PDF to an ODF document canvas.

So, give the pdfium "Insert" filter a test. Issues with the PDF "Import" filter
are unlikely to be fixed, especially the odd results for multi-byte glyph text
streams.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136905] NB Layout tab 'Page Size' drop list UX is poor

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136905

--- Comment #8 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1876feb8a8805b2f80537e2828c152ccbdf67fe2

tdf#136905 NBB: let ValueSetWithTextControl set optimal height

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136905] NB Layout tab 'Page Size' drop list UX is poor

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136905

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svx svx/source sw/source

2023-07-17 Thread Justin Luth (via logerrit)
 include/svx/sidebar/ValueSetWithTextControl.hxx  |1 +
 svx/source/sidebar/tools/ValueSetWithTextControl.cxx |9 +
 sw/source/uibase/sidebar/PageSizeControl.cxx |1 +
 3 files changed, 11 insertions(+)

New commits:
commit 1876feb8a8805b2f80537e2828c152ccbdf67fe2
Author: Justin Luth 
AuthorDate: Mon Jul 10 15:27:29 2023 -0400
Commit: Justin Luth 
CommitDate: Tue Jul 18 01:22:41 2023 +0200

tdf#136905 NBB: let ValueSetWithTextControl set optimal height

There was no way to specify a "good font size" to use
for .uno:AttributePageSize in the notebookbar.
The font "resized to match to size of the box"
which is hard-coded to aSize(250, 300).

(Even if ValueSet::SetOptimalSize worked, it would set an
inadequate height.)

So it seems like the best thing to do is simply add a function
that allows the box height to be modified.

Using the fontsize from GetDefaultFont is not correct.
Use the OS-defined label font size instead, which seems to be
the most common choice - GetPushButtonFont would has also worked.

I verified that the label font size is controled by
the OS' font preference.

The ability to define the box's optimal height
is still (somewhat) necessary. It isn't good enough
to just "use the system font size".
I tested with an OS font size of 48 (instead of 11),
and in that case the box height was too small
(but with the font only using 4/9's of a 12pt space,
even a 24pt font looked OK without adjusting optimal height).

Change-Id: I0a0774dea9c2a6c21a8e84439318a94f39783413
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154286
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/include/svx/sidebar/ValueSetWithTextControl.hxx 
b/include/svx/sidebar/ValueSetWithTextControl.hxx
index ac397f9fdab6..407e9606757f 100644
--- a/include/svx/sidebar/ValueSetWithTextControl.hxx
+++ b/include/svx/sidebar/ValueSetWithTextControl.hxx
@@ -40,6 +40,7 @@ public:
 
 SVX_DLLPRIVATE virtual void SetDrawingArea(weld::DrawingArea* 
pDrawingArea) override;
 
+void SetOptimalDrawingAreaHeight();
 void AddItem(const OUString& rItemText, const OUString& rItemText2);
 
 SVX_DLLPRIVATE virtual void UserDraw(const UserDrawEvent& rUDEvt) override;
diff --git a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx 
b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
index 1b6ca2d42979..77b260272264 100644
--- a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
+++ b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
@@ -43,6 +43,15 @@ void 
ValueSetWithTextControl::SetDrawingArea(weld::DrawingArea* pDrawingArea)
 SetColCount();
 }
 
+void ValueSetWithTextControl::SetOptimalDrawingAreaHeight()
+{
+const vcl::Font 
aFont(Application::GetSettings().GetStyleSettings().GetLabelFont());
+const sal_Int32 nRowHeight = aFont.GetFontSize().Height() * 9 / 4; // see 
UserDraw()
+const Size aSize(GetOutputSizePixel().Width(), nRowHeight * 
maItems.size());
+GetDrawingArea()->set_size_request(aSize.Width(), aSize.Height());
+SetOutputSizePixel(aSize);
+}
+
 void ValueSetWithTextControl::AddItem(
 const OUString& rItemText,
 const OUString& rItemText2 )
diff --git a/sw/source/uibase/sidebar/PageSizeControl.cxx 
b/sw/source/uibase/sidebar/PageSizeControl.cxx
index 211ebece9e5e..a85848ad753d 100644
--- a/sw/source/uibase/sidebar/PageSizeControl.cxx
+++ b/sw/source/uibase/sidebar/PageSizeControl.cxx
@@ -165,6 +165,7 @@ PageSizeControl::PageSizeControl(PageSizePopup* pControl, 
weld::Widget* pParent)
 }
 mxSizeValueSet->SetNoSelection();
 mxSizeValueSet->SetSelectHdl( LINK(this, PageSizeControl, ImplSizeHdl ) );
+mxSizeValueSet->SetOptimalDrawingAreaHeight();
 mxSizeValueSet->Show();
 mxSizeValueSet->Resize();
 


[Libreoffice-bugs] [Bug 156339] New: When text is selected, only selected text is exported

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156339

Bug ID: 156339
   Summary: When text is selected, only selected text is exported
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eloque...@gmail.com

Steps to reproduce:
- Open a multipage document
- Select a word or two
- "Export to PDF"

Expected behavior:
- Multipage PDF

Actual behavior:
- A PDF that just contains the selected word or two

Notes:
- This may be intended behavior (the "Selection" radiobutton gets selected by
default when any text is selected). If so, it still is a major usability trap.
It is quite common to have selections active, and users rarely inspect dialogs
in detail before completing a common process. I've personally hit this issue
6-7 times in half a decade or so of use.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105584] [META] Calc image bugs and enhancements

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105584
Bug 105584 depends on bug 107698, which changed state.

Bug 107698 Summary: EDITING: vertical position of controls anchored to cell 
incorrectly updated when non-default height rows are inserted/deleted above
https://bugs.documentfoundation.org/show_bug.cgi?id=107698

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107698] EDITING: vertical position of controls anchored to cell incorrectly updated when non-default height rows are inserted/deleted above

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107698

gisel.avalea...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #13 from gisel.avalea...@gmail.com ---
Resolved in

Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149660] FILEOPEN DOCX IF field conditions not read

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149660

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||6030
 CC||vasily.melenc...@cib.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149660] FILEOPEN DOCX IF field conditions not read

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149660

--- Comment #4 from Gabor Kelemen (allotropia)  ---
Created attachment 188420
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188420=edit
The example file in current master and Word 2016

Looks much better but not perfect in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2c524ab87e336418c3ee7370f76284a53dff1c82
CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

after the fix of bug 156030

The condition is not the expected
1 = 1 
but:
1 FORMULA 1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107237
Bug 107237 depends on bug 126006, which changed state.

Bug 126006 Summary: Calc with Tabbed UI used to crash after File>>Reload; many 
toolbar items aren't working including save
https://bugs.documentfoundation.org/show_bug.cgi?id=126006

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126006] Calc with Tabbed UI used to crash after File>>Reload; many toolbar items aren't working including save

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126006

Justin L  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103512
Bug 103512 depends on bug 126006, which changed state.

Bug 126006 Summary: Calc with Tabbed UI used to crash after File>>Reload; many 
toolbar items aren't working including save
https://bugs.documentfoundation.org/show_bug.cgi?id=126006

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126006] Calc with Tabbed UI used to crash after File>>Reload; many toolbar items aren't working including save

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126006

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source

2023-07-17 Thread Justin Luth (via logerrit)
 sfx2/source/view/viewfrm.cxx |   18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

New commits:
commit ef1484c731140699f26d15f4cda36f1a81e73abe
Author: Justin Luth 
AuthorDate: Fri Jul 7 13:53:01 2023 -0400
Commit: Justin Luth 
CommitDate: Tue Jul 18 00:00:15 2023 +0200

Revert "Revert "tdf#126006 sc SID_RELOAD: restart notebookbar""

This reverts commit d0bbc16b1715a3711d872a36c7e525e8d3811669.

My laptop is failing to complete UITests all the time,
so likely this patch wasn't to blame after all.

Change-Id: I3fa9fbb8ffc8df1fd9e45f8bcb6489594a8c0c46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154199
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 196a18d3d335..0766eec86088 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -838,8 +838,18 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
 
 UpdateDocument_Impl();
 
-if 
(vcl::CommandInfoProvider::GetModuleIdentifier(GetFrame().GetFrameInterface()) 
== "com.sun.star.text.TextDocument")
-
sfx2::SfxNotebookBar::ReloadNotebookBar(u"modules/swriter/ui/");
+auto sModule = 
vcl::CommandInfoProvider::GetModuleIdentifier(GetFrame().GetFrameInterface());
+OUString sReloadNotebookBar;
+if (sModule == "com.sun.star.text.TextDocument")
+sReloadNotebookBar = u"modules/swriter/ui/";
+else if (sModule == 
"com.sun.star.sheet.SpreadsheetDocument")
+sReloadNotebookBar = u"modules/scalc/ui/";
+else if (sfx2::SfxNotebookBar::IsActive()
+ && sModule != "presentation.PresentationDocument"
+ && sModule != 
"com.sun.star.drawing.DrawingDocument")
+{
+assert(false && "SID_RELOAD Notebookbar active, but 
not refreshed here");
+}
 
 try
 {
@@ -878,6 +888,10 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
 
 // Propagate document closure.
 SfxGetpApp()->NotifyEvent( SfxEventHint( 
SfxEventHintId::CloseDoc, GlobalEventConfig::GetEventName( 
GlobalEventId::CLOSEDOC ), xOldObj ) );
+
+// tdf#126006 Calc needs to reload the notebookbar after 
closing the document
+if (!sReloadNotebookBar.isEmpty())
+
sfx2::SfxNotebookBar::ReloadNotebookBar(sReloadNotebookBar);
 }
 
 // Record as done


[Libreoffice-bugs] [Bug 156286] Crash on right-click delete of selected cells in Calc

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156286

László Németh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 99746] [META] PDF import filter in Draw

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99746

raal  changed:

   What|Removed |Added

 Depends on||155983


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=155983
[Bug 155983] Strange black squares appear when loading PDFs with LibreOffice
Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155983] Strange black squares appear when loading PDFs with LibreOffice Draw

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155983

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||99746
Version|7.5.3.2 release |4.1.0.4 release

--- Comment #3 from raal  ---
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 663db89378aa1f0425e795ef5d471f134e658dc4
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=99746
[Bug 99746] [META] PDF import filter in Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156286] Crash on right-click delete of selected cells in Calc

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156286

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0   |target:24.2.0
   ||target:7.6.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156286] Crash on right-click delete of selected cells in Calc

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156286

--- Comment #13 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/2198fd843b71ea6c8152f882b107eac7b3edd647

tdf#156286 sc: fix crash with column deletion

It will be available in 7.6.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/source

2023-07-17 Thread László Németh (via logerrit)
 sc/source/core/data/table2.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2198fd843b71ea6c8152f882b107eac7b3edd647
Author: László Németh 
AuthorDate: Fri Jul 14 18:41:31 2023 +0200
Commit: László Németh 
CommitDate: Mon Jul 17 23:57:33 2023 +0200

tdf#156286 sc: fix crash with column deletion

Skip negative indices, which caused the crash, when
more columns were deleted, than the remaining columns
before them.

Regression from commit dd8e061406fac581d399da088c7f0187278035dc
"tdf#153437 sc: fix broken formatting without performance regression".

Change-Id: I223e2fbb321fc4bd2ddb7a67a16a64c69e1e7872
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154445
Reviewed-by: Czeber László 
Tested-by: Jenkins
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry picked from commit e4ae409b8e57f5efe53af7bacd08b0d226a0d96f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154538

diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index ee65a31ab6bf..027e2b424544 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -401,7 +401,7 @@ void ScTable::DeleteCol(
 for (SCCOL nCol = nStartCol + nSize; nCol < aCol.size(); ++nCol)
 aCol[nCol].SwapCol(aCol[nCol - nSize]);
 // When delete column(s), initialize the last columns from the default 
attributes
-for (SCCOL nCol = aCol.size() - nSize; nCol < aCol.size(); ++nCol)
+for (SCCOL nCol = aCol.size() < static_cast(nSize) ? 0 : 
aCol.size() - nSize; nCol < aCol.size(); ++nCol)
 aCol[nCol].Init(nCol, aCol[nCol].GetTab(), rDocument, false);
 }
 else


[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/source

2023-07-17 Thread Andrea Gelmini (via logerrit)
 sc/source/core/data/table2.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7120a54129804d08b7ea0594ffcebe3e28dd5064
Author: Andrea Gelmini 
AuthorDate: Fri Jun 9 21:13:56 2023 +0200
Commit: László Németh 
CommitDate: Mon Jul 17 23:57:06 2023 +0200

Fix typo

Change-Id: I93f8dc6746a9173847e96f1ba16e5fdc4a817ced
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152804
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit 97a4e4582698c74fa4fa5c2fed3cd48d4c66da8b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154537
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index b35caa7459bb..ee65a31ab6bf 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -400,7 +400,7 @@ void ScTable::DeleteCol(
 {
 for (SCCOL nCol = nStartCol + nSize; nCol < aCol.size(); ++nCol)
 aCol[nCol].SwapCol(aCol[nCol - nSize]);
-// When delete column(s), inicialize the last columns from the default 
attributes
+// When delete column(s), initialize the last columns from the default 
attributes
 for (SCCOL nCol = aCol.size() - nSize; nCol < aCol.size(); ++nCol)
 aCol[nCol].Init(nCol, aCol[nCol].GetTab(), rDocument, false);
 }


[Libreoffice-bugs] [Bug 156335] Word -> Writer

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156335

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|NEW |NEEDINFO

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Please don't set your own bug report to "new", someone else needs to confirm
it.

Please provide an example file, as there can be thousands of reasons why a file
won't look the same in the two apps:
https://bugs.documentfoundation.org/attachment.cgi?bugid=156335=enter

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156326] :

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156326

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Hi there.
We will need more details to identify a bug.

- Please make sure you are testing with a recent version
- try resetting your user profile
- if you can still reproduce, share you version information
- does it happen with all spreadsheets?

More information here: https://wiki.documentfoundation.org/QA/BugReport
Setting to "need info" for now, please set the status back to "Unconfirmed"
once you have provided more information.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156309] User-defined paragraph style changes to Body Text when pressing return.

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156309

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thanks Robert.
This is most likely bug 156165, on which Baole is working to fix.

*** This bug has been marked as a duplicate of bug 156165 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

Transition of already implemented features to ODF 1.4

2023-07-17 Thread Regina Henschel

Hi all,

I'm going to add the topic "Transition of already implemented features 
to ODF 1.4" to https://wiki.documentfoundation.org/Development/Budget2024


For that the RNG schemas have to be adapted to ODF 1.4 before. Should I 
include that in the above item or should that become a separate item or 
will that be done by TDF stuff?


Kind regards,
Regina



[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103610

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|156304  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156304
[Bug 156304] In presentation mode, pressing left arrow after last slide won't
return to the last slide
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156304] In presentation mode, pressing left arrow after last slide won't return to the last slide

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156304

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||daniel-...@web.de,
   ||stephane.guillou@libreoffic
   ||e.org
 Status|NEW |RESOLVED
 Blocks|103610  |

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Thanks you both.
This is resolved by ca90149fa3f7c8161393490d4c0149c1cbcc3c28 for bug 155920.
The fix is in 24.2, but hasn't been cherrypicked for 7.6 nor 7.5.

Daniel, looks like the regression had more symptoms, not only affecting dual
screens. Can you cherrypick the fix to 7.5 and 7.6?

*** This bug has been marked as a duplicate of bug 155920 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103610
[Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: external/clucene

2023-07-17 Thread Stephan Bergmann (via logerrit)
 external/clucene/patches/binary_function.patch |   23 +++
 1 file changed, 23 insertions(+)

New commits:
commit 39927fa6a9744b89b8ddf3abed0fd905510a9675
Author: Stephan Bergmann 
AuthorDate: Mon Jul 17 17:11:37 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Jul 17 23:21:02 2023 +0200

external/clucene: More uses of obsolete std::binary_function

...as seen at least when building against VS 2022 Preview 17.7.0 Preview 
3.0 and
--with-latest-c++,

> workdir\UnpackedTarball\clucene\src\core\CLucene/util/_Arrays.h(128): 
error C2039: 'binary_function': is not a member of 'std'
> 
C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1437~1.328\Include\vector(26): 
note: see declaration of 'std'
> workdir\UnpackedTarball\clucene\src\core\CLucene/util/_Arrays.h(153): 
note: see reference to class template instantiation 
'lucene::util::CLListEquals<_kt,_comparator,class1,class2>' being compiled

etc.

Change-Id: Icea14fe0c0ad85501367ac6c81a3b8aada595383
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154551
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/clucene/patches/binary_function.patch 
b/external/clucene/patches/binary_function.patch
index 5b6f8ece9bee..a7e4b867d0c7 100644
--- a/external/clucene/patches/binary_function.patch
+++ b/external/clucene/patches/binary_function.patch
@@ -1,3 +1,26 @@
+--- src/core/CLucene/search/BooleanQuery.cpp
 src/core/CLucene/search/BooleanQuery.cpp
+@@ -25,7 +25,7 @@
+ CL_NS_USE(util)
+ CL_NS_DEF(search)
+ 
+-  class BooleanClause_Compare:public CL_NS_STD(binary_function)
++  class BooleanClause_Compare
+   {
+   public:
+   bool operator()( const BooleanClause* val1, const 
BooleanClause* val2 ) const {
+--- src/core/CLucene/util/_Arrays.h
 src/core/CLucene/util/_Arrays.h
+@@ -124,8 +124,7 @@
+   
+   template 
+-  class CLListEquals:
+-  public CL_NS_STD(binary_function)
++  class CLListEquals
+   {
+   typedef typename class1::const_iterator _itr1;
+   typedef typename class2::const_iterator _itr2;
 --- src/core/CLucene/util/Equators.h
 +++ src/core/CLucene/util/Equators.h
 @@ -22,19 +22,19 @@


[Libreoffice-bugs] [Bug 156303] Saving a PDF Import to doc/docx/rtf moves all text boxes to the first page

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156303

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Created attachment 188418
  --> https://bugs.documentfoundation.org/attachment.cgi?id=188418=edit
sample ODT

The bug can be tested directly form this ODT, created in LO 7.5.4 after
importing the sample PDF with Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156303] Saving a PDF Import to doc/docx/rtf moves all text boxes to the first page

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156303

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
   Keywords||filter:doc, filter:docx
Version|7.4.4.2 release |6.0.0.3 release
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Reproduced when saved as DOCX and DOC with:

Version: 7.4.7.2 / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

And in recent master build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 77fca616e0bd79e0b405fd0b3543cf8e94e15df3
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Already the case in 6.0.0.3.

In 5.4, text boxes would disappear and LO would hang.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151756] Menu text almost invisible in Windows 10 dark mode (after sleep or when display connected) (see comment 9)

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151756

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||kiran1833i...@tuta.io

--- Comment #30 from Stéphane Guillou (stragu) 
 ---
*** Bug 156300 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156300] [UI][CALC] The background color of the "Dropdown Menu"/"Right Click Menu" turns dark grey and makes it harder to see the content of the menu. Occurs randomly and also r

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156300

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
This is most likely bug 151756.
Please update to LibreOffice 7.5 and let us know if you still have the same
issue.

*** This bug has been marked as a duplicate of bug 151756 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156338] Templates. Imperfections dialog, rsp. confusing template manager behavior

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156338

--- Comment #1 from AB  ---
Version: 7.4.7.2 (x64) / LibreOffice Community
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: cs-CZ
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156338] New: Templates. Imperfections dialog, rsp. confusing template manager behavior

2023-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156338

Bug ID: 156338
   Summary: Templates. Imperfections dialog, rsp. confusing
template manager behavior
   Product: LibreOffice
   Version: 7.4.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ales.bar...@seznam.cz

Description:
Libre office - Templates - Manage Templates - Templates
 Imperfections dialog, rsp. confusing template manager behavior:

1. In the Templates dialog (Template Manager), the "Open" button should be
called "New Document" or "New from Template" or "Use Template" instead.  
   For the "Open" button, there should be an option to edit the template file
only (e.g. the *.ott file), whereby the name of the 'Edit Template' button
would then be more apt for this action.

2. The Templates dialog has two forms of template viewing: either Thumbnail
View or List View.
The current display form is not indicated by squeezing the appropriate toggle
icon.

3. If I set the display form to List View, and if the number of templates shown
is small at the same time (e.g. if the list of templates has only 2 items), the
dialog is reduced in height. 
So far, so ok.   But:  Once I change the display form back to Thumbnail View,
the dialog stays lowered and no longer expands in height, making template
thumbnails very difficult to recognize!

4. In the dialog I miss the possibility of creating a new copy of an existing
template!

5. I lack control over where the template file is physically stored. 
The Template Manager dialog does not respond to any "manual" ("external")
changes in the naming and location of template files. 
In the dialog, the user's primary defined template name is only an "internal
Alias" of sorts, not the actual filename. I misunderstood the idea of the
author (see point 6 below).
It's definitely not a unique identifier for the user!  In addition, this alias
remains visible in the dialog, although a template file that is supposed to
represent either no longer exists or has been externally renamed by the user.
It often refers to a completely different file already!
This results in a less cautious user being able to be misled and lose their
data (e.g. by transcribing to lose the content of a previously identically
titled template, which he laboriously created for even a few hours)!

6. I wonder if a "template" (e.g., a Writer template) is an information set
that is contained entirely in only one single physical disk file.
Furthermore, I wonder if it is still the case that each disk file (within a PC)
is positively identified: by the disk name (root), by the complete path in the
directory structure, and by the file name, including the suffix, thus e.g. as
follows: 
"c:\Users\Ales\AppData\Roaming\LibreOffice\4\user\template\MyTemplate1.ott!
If the answer to both questions above is YES, then I wonder what led the author
of the program to use such a misleading and unhelpful system of Aliases,
"name_pictures" and "icon insights" in the Templates dialog, which often does
not reflect the current state of physically stored templates!

I get the same negative impression from the initial LibreOffice dialog (in the
much larger right part of the introductory dialog, template and document
previews are mixed without any structure - just behind the way the magician
time has brought them, and often they are no longer up to date either, so they
are not usable (I have to manually lubricate them if I want to use them)!
A simple updated list of complete template file names, i.e. a complete path and
physical file names, would be far more useful (to me, at least). If the
programme maker wanted to shine, it could allow the user to structure templates
according to their own themes (but not force them to have any internal fixed
fixed fixed breakdowns),
As a bonus, he could attach a page 1 preview to each file, file information
(date and time of creation and last editing ...) and the ability to attach a
user note - to each file add a description of what the template is for, or what
it contains.


Please take this text as the user's modest (and humble) contribution for the
purpose of improving the next version of the program in the future.
;-)
AB

Steps to Reproduce:
1.writer
2.File
3.Templates

Actual Results:
_

Expected Results:
_


Reproducible: Always


User Profile Reset: No

Additional Info:
_

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source

2023-07-17 Thread Mike Kaganski (via logerrit)
 sfx2/source/appl/appcfg.cxx |  542 ++--
 1 file changed, 183 insertions(+), 359 deletions(-)

New commits:
commit ca460e654a1ee17d755cff6943f07bfa88da9a27
Author: Mike Kaganski 
AuthorDate: Mon Jul 17 19:39:02 2023 +0200
Commit: Mike Kaganski 
CommitDate: Mon Jul 17 22:21:50 2023 +0200

Simplify a bit

Change-Id: I6c20a9809ee8cae27e8894c91266d82ea04540f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154534
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/appl/appcfg.cxx b/sfx2/source/appl/appcfg.cxx
index 41603134a225..3c8fe3c124f6 100644
--- a/sfx2/source/appl/appcfg.cxx
+++ b/sfx2/source/appl/appcfg.cxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -106,246 +107,156 @@ IMPL_LINK(SfxEventAsyncer_Impl, IdleHdl, Timer*, 
pAsyncIdle, void)
 delete this;
 }
 
-
-void SfxApplication::GetOptions( SfxItemSet& rSet )
+namespace
+{
+template  bool toSet(SfxItemSet& rSet, 
TypedWhichId wid)
 {
-bool bRet = false;
+return rSet.Put(Item(wid, Cfg::get()));
+}
+template 
+bool toSet_withDefault(SfxItemSet& rSet, TypedWhichId wid, Val&& defVal)
+{
+return rSet.Put(Item(wid, Cfg::get().value_or(std::move(defVal;
+}
+template  bool toSet_ifRW(SfxItemSet& rSet, 
TypedWhichId wid)
+{
+return Cfg::isReadOnly() || toSet(rSet, wid);
+}
 
-const WhichRangesContainer& pRanges = rSet.GetRanges();
+template 
+void toCfg_ifSet(const SfxItemSet& rSet, TypedWhichId wid,
+ std::shared_ptr const& 
batch)
+{
+if (const auto* pItem = rSet.GetItemIfSet(wid))
+Cfg::set(pItem->GetValue(), batch);
+}
+}
 
-for (auto const & pRange : pRanges)
+void SfxApplication::GetOptions( SfxItemSet& rSet )
+{
+SfxWhichIter iter(rSet);
+for (auto nWhich = iter.FirstWhich(); nWhich; nWhich = iter.NextWhich())
 {
-for(sal_uInt16 nWhich = pRange.first; nWhich <= pRange.second; 
++nWhich)
+bool bRet = false;
+switch(nWhich)
 {
-switch(nWhich)
-{
-case SID_ATTR_BUTTON_BIGSIZE :
+case SID_ATTR_BUTTON_BIGSIZE:
+if( rSet.Put( SfxBoolItem( SID_ATTR_BUTTON_BIGSIZE, 
SvtMiscOptions::AreCurrentSymbolsLarge() ) ) )
+bRet = true;
+break;
+case SID_ATTR_BACKUP:
+bRet = true;
+if 
(!officecfg::Office::Common::Save::Document::CreateBackup::isReadOnly())
+if (!rSet.Put( SfxBoolItem( SID_ATTR_BACKUP,
+
(officecfg::Office::Common::Save::Document::CreateBackup::get() && 
!comphelper::LibreOfficeKit::isActive()) )))
+bRet = false;
+break;
+case SID_ATTR_PRETTYPRINTING:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_PRETTYPRINTING);
+break;
+case SID_ATTR_WARNALIENFORMAT:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_WARNALIENFORMAT);
+break;
+case SID_ATTR_AUTOSAVE:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_AUTOSAVE);
+break;
+case SID_ATTR_AUTOSAVEPROMPT:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_AUTOSAVEPROMPT);
+break;
+case SID_ATTR_AUTOSAVEMINUTE:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_AUTOSAVEMINUTE);
+break;
+case SID_ATTR_USERAUTOSAVE:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_USERAUTOSAVE);
+break;
+case SID_ATTR_DOCINFO:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_DOCINFO);
+break;
+case SID_ATTR_WORKINGSET:
+bRet = toSet_ifRW(
+rSet, SID_ATTR_WORKINGSET);
+break;
+case SID_ATTR_SAVEDOCVIEW:
+bRet = 
toSet_ifRW(
+rSet, SID_ATTR_SAVEDOCVIEW);
+break;
+case SID_ATTR_METRIC:
+break;
+case SID_HELPBALLOONS:
+bRet = 
toSet(rSet, SID_HELPBALLOONS);
+break;
+case SID_HELPTIPS :
+bRet = toSet(rSet, 
SID_HELPTIPS);
+break;
+case SID_HELP_STYLESHEET:
+bRet = 
toSet(rSet,
+  
SID_HELP_STYLESHEET);
+break;
+case SID_ATTR_UNDO_COUNT:
+bRet = toSet(rSet, 
SID_ATTR_UNDO_COUNT);
+break;
+case SID_ATTR_QUICKLAUNCHER:
+if ( ShutdownIcon::IsQuickstarterInstalled() )
 {
-if( rSet.Put( SfxBoolItem( SID_ATTR_BUTTON_BIGSIZE, 

  1   2   3   4   >