[Libreoffice-bugs] [Bug 158084] Start Center: hover highlight color is inconsistent

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158084

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158084] Start Center: hover highlight color is inconsistent

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158084

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157914] Allow setting TabOverMargin per individual tab

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157914

Heiko Tietze  changed:

   What|Removed |Added

Summary|ENHANCEMENT: Allow tabbing  |Allow setting TabOverMargin
   |beyond indent   |per individual tab
   Keywords|needsUXEval |
 Status|NEEDINFO|NEW
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #9 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #8)
> Technically the per-tab "tag" is possible, only needs ODF extension.

So let's keep the ticket open for this enhancement - and make access to the
compatibility option easier meanwhile.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157914] Allow setting TabOverMargin per individual tab

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157914

Heiko Tietze  changed:

   What|Removed |Added

Summary|ENHANCEMENT: Allow tabbing  |Allow setting TabOverMargin
   |beyond indent   |per individual tab
   Keywords|needsUXEval |
 Status|NEEDINFO|NEW
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #9 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #8)
> Technically the per-tab "tag" is possible, only needs ODF extension.

So let's keep the ticket open for this enhancement - and make access to the
compatibility option easier meanwhile.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 107817] [META] Impress UI/UX bugs and enhancements

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107817
Bug 107817 depends on bug 157942, which changed state.

Bug 157942 Summary: UI: Notes optional visible on mainview - UI ENHANCEMENT
https://bugs.documentfoundation.org/show_bug.cgi?id=157942

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108381] [META] Notes and Master Notes view/mode bugs and enhancements

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108381

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||157942


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157942
[Bug 157942] UI: Notes optional visible on mainview - UI ENHANCEMENT
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107817] [META] Impress UI/UX bugs and enhancements

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107817

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||157942


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157942
[Bug 157942] UI: Notes optional visible on mainview - UI ENHANCEMENT
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108381] [META] Notes and Master Notes view/mode bugs and enhancements

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108381
Bug 108381 depends on bug 157942, which changed state.

Bug 157942 Summary: UI: Notes optional visible on mainview - UI ENHANCEMENT
https://bugs.documentfoundation.org/show_bug.cgi?id=157942

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 33603] Presenter notes should be available in normal view as a scrolling pane

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=33603

Heiko Tietze  changed:

   What|Removed |Added

 CC||st...@xoio.de

--- Comment #43 from Heiko Tietze  ---
*** Bug 157942 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157942] UI: Notes optional visible on mainview - UI ENHANCEMENT

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157942

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 Blocks||108381, 107817

--- Comment #2 from Heiko Tietze  ---
Pro: all in one view, con: occupies precious vertical space (some screen are
very small and those users may still prefer the tabbed solution). An
alternative might be to have the notes in a dedicated sidebar tab.

Anyway, this has been reported in bug 33603 and you are welcome to discuss
ideas there.

*** This bug has been marked as a duplicate of bug 33603 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107817
[Bug 107817] [META] Impress UI/UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108381
[Bug 108381] [META] Notes and Master Notes view/mode bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157942] UI: Notes optional visible on mainview - UI ENHANCEMENT

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157942

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 Blocks||108381, 107817

--- Comment #2 from Heiko Tietze  ---
Pro: all in one view, con: occupies precious vertical space (some screen are
very small and those users may still prefer the tabbed solution). An
alternative might be to have the notes in a dedicated sidebar tab.

Anyway, this has been reported in bug 33603 and you are welcome to discuss
ideas there.

*** This bug has been marked as a duplicate of bug 33603 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107817
[Bug 107817] [META] Impress UI/UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108381
[Bug 108381] [META] Notes and Master Notes view/mode bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - dbaccess/source include/sfx2 sc/source sfx2/source

2023-11-09 Thread Caolán McNamara (via logerrit)
 dbaccess/source/core/dataaccess/ModelImpl.cxx |3 +-
 include/sfx2/docmacromode.hxx |4 ++-
 include/sfx2/objsh.hxx|3 ++
 sc/source/core/data/global.cxx|   34 +-
 sfx2/source/doc/docmacromode.cxx  |8 --
 sfx2/source/doc/objmisc.cxx   |8 +-
 sfx2/source/doc/objxtor.cxx   |1 
 sfx2/source/inc/objshimp.hxx  |3 +-
 8 files changed, 57 insertions(+), 7 deletions(-)

New commits:
commit 113e16674e94955702edde514a9fb86fbe70b3ae
Author: Caolán McNamara 
AuthorDate: Fri Nov 3 17:26:25 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 10 08:14:06 2023 +0100

default to ignoring libreoffice special-purpose protocols in calc hyperlink

Change-Id: Ib9f62be3acc05f24ca234dec0fec21e24579e9de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158911
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit b6062623b4d69c79e90e9365ac7c5e7f11986793)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159046
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx 
b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 3e21289dbe9a..e399d5da7067 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -1125,7 +1125,8 @@ bool ODatabaseModelImpl::checkMacrosOnLoading()
 {
 Reference< XInteractionHandler > xInteraction;
 xInteraction = m_aMediaDescriptor.getOrDefault( "InteractionHandler", 
xInteraction );
-return m_aMacroMode.checkMacrosOnLoading( xInteraction );
+const bool bHasMacros = m_aMacroMode.hasMacros();
+return m_aMacroMode.checkMacrosOnLoading(xInteraction, false 
/*HasValidContentSignature*/, bHasMacros);
 }
 
 void ODatabaseModelImpl::resetMacroExecutionMode()
diff --git a/include/sfx2/docmacromode.hxx b/include/sfx2/docmacromode.hxx
index 7ed42f6a14dd..0acb44cbfbb1 100644
--- a/include/sfx2/docmacromode.hxx
+++ b/include/sfx2/docmacromode.hxx
@@ -264,6 +264,8 @@ namespace sfx2
 */
 static bool storageHasMacros( const css::uno::Reference< 
css::embed::XStorage >& _rxStorage );
 
+bool hasMacros() const;
+
 static bool containerHasBasicMacros( const css::uno::Reference< 
css::script::XLibraryContainer >& xContainer );
 /** checks the macro execution mode while loading the document.
 
@@ -291,7 +293,7 @@ namespace sfx2
 bool
 checkMacrosOnLoading(
 const css::uno::Reference< css::task::XInteractionHandler 
>& _rxInteraction,
-bool bHasValidContentSignature = false
+bool bHasValidContentSignature, bool bHasMacros
 );
 
 private:
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index e447b4297362..5a3cd8699663 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -428,6 +428,9 @@ public:
 voidSetMacroCallsSeenWhileLoading();
 boolGetMacroCallsSeenWhileLoading() const;
 
+// true if the document had macros (or similar) on load to trigger warning 
user
+boolGetHadCheckedMacrosOnLoad() const;
+
 const css::uno::Sequence< css::beans::PropertyValue >& 
GetModifyPasswordInfo() const;
 boolSetModifyPasswordInfo( const 
css::uno::Sequence< css::beans::PropertyValue >& aInfo );
 
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 1e8a0cb2158c..f8989403344c 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -29,7 +29,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -39,6 +41,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -820,7 +823,7 @@ void ScGlobal::OpenURL(const OUString& rURL, const 
OUString& rTarget, bool bIgno
 
 OUString aUrlName( rURL );
 SfxViewFrame* pFrame = nullptr;
-const SfxObjectShell* pObjShell = nullptr;
+SfxObjectShell* pObjShell = nullptr;
 OUString aReferName;
 if ( pScActiveViewShell )
 {
@@ -854,6 +857,35 @@ void ScGlobal::OpenURL(const OUString& rURL, const 
OUString& rTarget, bool bIgno
 aUrlName = aNewUrlName;
 }
 
+if (INetURLObject(aUrlName).IsExoticProtocol())
+{
+// Default to ignoring exotic protocols
+bool bAllow = false;
+if (pObjShell)
+{
+// If the document had macros when loaded then follow the allowed 
macro-mode
+if (pObjShell->GetHadCheckedMacrosOnLoad())
+bAllow = pObjShell->AdjustMacroMode();
+else // otherwise ask the user, defaulting to cancel
+{
+assert(pFrame && "if 

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/source xmloff/source

2023-11-09 Thread Skyler Grey (via logerrit)
 sw/source/filter/ww8/ww8atr.cxx |3 +++
 xmloff/source/text/txtfldi.cxx  |3 +++
 2 files changed, 6 insertions(+)

New commits:
commit 7471de2849e076304b6e59f4d78b83a272f46607
Author: Skyler Grey 
AuthorDate: Thu Nov 9 16:57:50 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 10 08:13:11 2023 +0100

Fix STYLEREF crashes and forwards-compatibility

This commit fixes a crash in STYLEREF caused by a dereferenced nullptr
when serializing chapter fields for .doc export. Along with the STYLEREF
changes, I also changed the chapter export logic to allow exporting
chapter fields when they were in document text, and to use the style of
the thing they pointed to. Unfortunately, in some cases that would be
null. This commit makes us fall back to previous behavior in those
cases.

This commit also adds import logic for styleref on the TEXT namespace in
addition to LO_EXT. This is important as if/when the STYLEREF field is
no longer LO_EXT we want to be able to open new documents in old
versions of libreoffice. This was erroneously missed when we changed
TEXT references to LO_EXT in our export logic.

Change-Id: I383828c9409afc8545af379307f528cee2e1a960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159230
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 62ae243168ec..6e73e9255495 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -3430,6 +3430,9 @@ void AttributeOutputBase::TextField( const SwFormatField& 
rField )
 // Otherwise, get the style of the text and use it as the 
style name
 const SwTextNode* pOutlineNd = 
pTextNd->FindOutlineNodeOfLevel(aCopy.GetLevel());
 
+if (!pOutlineNd) break;
+// Sometimes we can't find the outline node, in that case 
let's just fallback to exporting the text
+
 sStr = FieldString(ww::eSTYLEREF)
  + 
GetExport().GetStyleRefName(pOutlineNd->GetFormatColl()->GetName());
 }
diff --git a/xmloff/source/text/txtfldi.cxx b/xmloff/source/text/txtfldi.cxx
index 4b43240878af..07496cb74c05 100644
--- a/xmloff/source/text/txtfldi.cxx
+++ b/xmloff/source/text/txtfldi.cxx
@@ -408,6 +408,7 @@ XMLTextFieldImportContext::CreateTextFieldImportContext(
 case XML_ELEMENT(TEXT, XML_BOOKMARK_REF):
 case XML_ELEMENT(TEXT, XML_NOTE_REF):
 case XML_ELEMENT(TEXT, XML_SEQUENCE_REF):
+case XML_ELEMENT(TEXT, XML_STYLE_REF):
 case XML_ELEMENT(LO_EXT, XML_STYLE_REF):
 pContext = new XMLReferenceFieldImportContext( rImport, rHlp, 
nToken );
 break;
@@ -2512,6 +2513,7 @@ void XMLReferenceFieldImportContext::startFastElement(
 case XML_ELEMENT(TEXT, XML_SEQUENCE_REF):
 nSource = ReferenceFieldSource::SEQUENCE_FIELD;
 break;
+case XML_ELEMENT(TEXT, XML_STYLE_REF):
 case XML_ELEMENT(LO_EXT, XML_STYLE_REF):
 nSource = ReferenceFieldSource::STYLE;
 break;
@@ -2593,6 +2595,7 @@ void XMLReferenceFieldImportContext::PrepareField(
 {
 case XML_ELEMENT(TEXT, XML_REFERENCE_REF):
 case XML_ELEMENT(TEXT, XML_BOOKMARK_REF):
+case XML_ELEMENT(TEXT, XML_STYLE_REF):
 case XML_ELEMENT(LO_EXT, XML_STYLE_REF):
 xPropertySet->setPropertyValue("SourceName", Any(sName));
 xPropertySet->setPropertyValue("ReferenceFieldFlags", Any(nFlags));


[Libreoffice-commits] core.git: sw/source xmloff/source

2023-11-09 Thread Skyler Grey (via logerrit)
 sw/source/filter/ww8/ww8atr.cxx |3 +++
 xmloff/source/text/txtfldi.cxx  |3 +++
 2 files changed, 6 insertions(+)

New commits:
commit 7924d8fc274bb611c829443e0eb1a53d883cc9a3
Author: Skyler Grey 
AuthorDate: Thu Nov 9 16:57:50 2023 +
Commit: Miklos Vajna 
CommitDate: Fri Nov 10 08:12:28 2023 +0100

Fix STYLEREF crashes and forwards-compatibility

This commit fixes a crash in STYLEREF caused by a dereferenced nullptr
when serializing chapter fields for .doc export. Along with the STYLEREF
changes, I also changed the chapter export logic to allow exporting
chapter fields when they were in document text, and to use the style of
the thing they pointed to. Unfortunately, in some cases that would be
null. This commit makes us fall back to previous behavior in those
cases.

This commit also adds import logic for styleref on the TEXT namespace in
addition to LO_EXT. This is important as if/when the STYLEREF field is
no longer LO_EXT we want to be able to open new documents in old
versions of libreoffice. This was erroneously missed when we changed
TEXT references to LO_EXT in our export logic.

Change-Id: I383828c9409afc8545af379307f528cee2e1a960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159226
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 79446939957e..4949c7ffe6fd 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -3456,6 +3456,9 @@ void AttributeOutputBase::TextField( const SwFormatField& 
rField )
 // Otherwise, get the style of the text and use it as the 
style name
 const SwTextNode* pOutlineNd = 
pTextNd->FindOutlineNodeOfLevel(aCopy.GetLevel());
 
+if (!pOutlineNd) break;
+// Sometimes we can't find the outline node, in that case 
let's just fallback to exporting the text
+
 sStr = FieldString(ww::eSTYLEREF)
  + 
GetExport().GetStyleRefName(pOutlineNd->GetFormatColl()->GetName());
 }
diff --git a/xmloff/source/text/txtfldi.cxx b/xmloff/source/text/txtfldi.cxx
index e0f6a01ecca6..1228e232d328 100644
--- a/xmloff/source/text/txtfldi.cxx
+++ b/xmloff/source/text/txtfldi.cxx
@@ -408,6 +408,7 @@ XMLTextFieldImportContext::CreateTextFieldImportContext(
 case XML_ELEMENT(TEXT, XML_BOOKMARK_REF):
 case XML_ELEMENT(TEXT, XML_NOTE_REF):
 case XML_ELEMENT(TEXT, XML_SEQUENCE_REF):
+case XML_ELEMENT(TEXT, XML_STYLE_REF):
 case XML_ELEMENT(LO_EXT, XML_STYLE_REF):
 pContext = new XMLReferenceFieldImportContext( rImport, rHlp, 
nToken );
 break;
@@ -2512,6 +2513,7 @@ void XMLReferenceFieldImportContext::startFastElement(
 case XML_ELEMENT(TEXT, XML_SEQUENCE_REF):
 nSource = ReferenceFieldSource::SEQUENCE_FIELD;
 break;
+case XML_ELEMENT(TEXT, XML_STYLE_REF):
 case XML_ELEMENT(LO_EXT, XML_STYLE_REF):
 nSource = ReferenceFieldSource::STYLE;
 break;
@@ -2593,6 +2595,7 @@ void XMLReferenceFieldImportContext::PrepareField(
 {
 case XML_ELEMENT(TEXT, XML_REFERENCE_REF):
 case XML_ELEMENT(TEXT, XML_BOOKMARK_REF):
+case XML_ELEMENT(TEXT, XML_STYLE_REF):
 case XML_ELEMENT(LO_EXT, XML_STYLE_REF):
 xPropertySet->setPropertyValue("SourceName", Any(sName));
 xPropertySet->setPropertyValue("ReferenceFieldFlags", Any(nFlags));


[Libreoffice-bugs] [Bug 158008] Unify lockdown behavior of Options dialog page Writer - Grid

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158008

Balázs Varga (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157698] [META] Unify lockdown UX in the Options dialog

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157698
Bug 157698 depends on bug 158007, which changed state.

Bug 158007 Summary: Unify lockdown behavior of Options dialog page Writer - 
General
https://bugs.documentfoundation.org/show_bug.cgi?id=158007

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157698] [META] Unify lockdown UX in the Options dialog

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157698
Bug 157698 depends on bug 158006, which changed state.

Bug 158006 Summary: Unify lockdown behavior of Options dialog page Writer - View
https://bugs.documentfoundation.org/show_bug.cgi?id=158006

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - include/comphelper sw/source sw/uiconfig

2023-11-09 Thread Balazs Varga (via logerrit)
 include/comphelper/configuration.hxx |7 
 sw/source/ui/config/optload.cxx  |   54 +++
 sw/source/uibase/inc/optload.hxx |   11 
 sw/uiconfig/swriter/ui/optgeneralpage.ui |  497 +++
 4 files changed, 387 insertions(+), 182 deletions(-)

New commits:
commit 0012f23ca0b59edbb38da055d3388b465146f7eb
Author: Balazs Varga 
AuthorDate: Thu Nov 9 20:52:42 2023 +0100
Commit: Balazs Varga 
CommitDate: Fri Nov 10 08:08:01 2023 +0100

tdf#158007 - UI: Part 23 - Unify lockdown behavior of Options dialog

for Writer - General Page.

Change-Id: I2c679ee7f8e2d282a9f9ff19fc1743cb9bb6dbe1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159250
Tested-by: Jenkins
Reviewed-by: Balazs Varga 

diff --git a/include/comphelper/configuration.hxx 
b/include/comphelper/configuration.hxx
index 45228b700944..652e9afaa640 100644
--- a/include/comphelper/configuration.hxx
+++ b/include/comphelper/configuration.hxx
@@ -246,6 +246,13 @@ private:
 /// to access each given localized configuration property.
 template< typename T, typename U > struct ConfigurationLocalizedProperty
 {
+/// Get the read-only status of the given (localized) configuration
+/// property.
+static bool isReadOnly()
+{
+return detail::ConfigurationWrapper::get().isReadOnly(T::path());
+}
+
 /// Get the value of the given localized configuration property, for the
 /// locale currently set at the
 /// com.sun.star.configuration.theDefaultProvider.
diff --git a/sw/source/ui/config/optload.cxx b/sw/source/ui/config/optload.cxx
index 92e754113aff..675a2d48e8d6 100644
--- a/sw/source/ui/config/optload.cxx
+++ b/sw/source/ui/config/optload.cxx
@@ -83,16 +83,27 @@ SwLoadOptPage::SwLoadOptPage(weld::Container* pPage, 
weld::DialogController* pCo
 , m_xAlwaysRB(m_xBuilder->weld_radio_button("always"))
 , m_xRequestRB(m_xBuilder->weld_radio_button("onrequest"))
 , m_xNeverRB(m_xBuilder->weld_radio_button("never"))
+, m_xGridupdatelink(m_xBuilder->weld_widget("gridupdatelink"))
+, m_xUpdateLinkImg(m_xBuilder->weld_widget("lockupdatelink"))
 , m_xAutoUpdateFields(m_xBuilder->weld_check_button("updatefields"))
+, m_xAutoUpdateFieldsImg(m_xBuilder->weld_widget("lockupdatefields"))
 , m_xAutoUpdateCharts(m_xBuilder->weld_check_button("updatecharts"))
+, m_xAutoUpdateChartsImg(m_xBuilder->weld_widget("lockupdatecharts"))
 , m_xMetricLB(m_xBuilder->weld_combo_box("metric"))
+, m_xMetricImg(m_xBuilder->weld_widget("lockmetric"))
 , m_xTabFT(m_xBuilder->weld_label("tablabel"))
 , m_xTabMF(m_xBuilder->weld_metric_spin_button("tab", FieldUnit::CM))
+, m_xTabImg(m_xBuilder->weld_widget("locktab"))
 , m_xUseSquaredPageMode(m_xBuilder->weld_check_button("squaremode"))
+, m_xUseSquaredPageModeImg(m_xBuilder->weld_widget("locksquaremode"))
 , m_xUseCharUnit(m_xBuilder->weld_check_button("usecharunit"))
+, m_xUseCharUnitImg(m_xBuilder->weld_widget("lockusecharunit"))
 , m_xWordCountED(m_xBuilder->weld_entry("wordcount"))
+, m_xWordCountImg(m_xBuilder->weld_widget("lockwordcount"))
 , 
m_xShowStandardizedPageCount(m_xBuilder->weld_check_button("standardizedpageshow"))
+, 
m_xShowStandardizedPageCountImg(m_xBuilder->weld_widget("lockstandardizedpageshow"))
 , 
m_xStandardizedPageSizeNF(m_xBuilder->weld_spin_button("standardpagesize"))
+, 
m_xStandardizedPageSizeImg(m_xBuilder->weld_widget("lockstandardpagesize"))
 {
 for (sal_uInt32 i = 0; i < SwFieldUnitTable::Count(); ++i)
 {
@@ -362,16 +373,51 @@ void SwLoadOptPage::Reset( const SfxItemSet* rSet)
 }
 m_xUseCharUnit->save_state();
 
+bool bReadOnly = 
officecfg::Office::Writer::Content::Update::Link::isReadOnly();
+m_xGridupdatelink->set_sensitive(!bReadOnly);
+m_xUpdateLinkImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Content::Update::Field::isReadOnly();
+m_xAutoUpdateFields->set_sensitive(!bReadOnly);
+m_xAutoUpdateFieldsImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Content::Update::Chart::isReadOnly();
+m_xAutoUpdateCharts->set_sensitive(!bReadOnly);
+m_xAutoUpdateChartsImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Layout::Other::MeasureUnit::isReadOnly();
+m_xMetricLB->set_sensitive(!bReadOnly);
+m_xMetricImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Layout::Other::TabStop::isReadOnly();
+m_xTabMF->set_sensitive(!bReadOnly);
+m_xTabImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Layout::Other::ApplyCharUnit::isReadOnly();
+m_xUseCharUnit->set_sensitive(!bReadOnly);
+m_xUseCharUnitImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Layout::Other::IsSquaredPageMode::isReadOnly();
+m_xUseSquaredPageMode->set_sensitive(!bReadOnly);
+

[Libreoffice-commits] core.git: sw/source

2023-11-09 Thread Miklos Vajna (via logerrit)
 sw/source/core/inc/layfrm.hxx   |1 +
 sw/source/core/layout/wsfrm.cxx |   12 
 sw/source/core/text/xmldump.cxx |7 ---
 3 files changed, 13 insertions(+), 7 deletions(-)

New commits:
commit 052c917d97aa88f21008cc3d978c6ca2ad83c88e
Author: Miklos Vajna 
AuthorDate: Thu Nov 9 19:59:45 2023 +0100
Commit: Miklos Vajna 
CommitDate: Fri Nov 10 08:06:47 2023 +0100

sw layout xml dump: avoid a static_cast in SwFrame::dumpAsXmlAttributes()

Move the code to SwLayoutFrame from SwFrame, then no cast is needed.

Change-Id: Ieb402efb19710adf94bce022fca484178fce719f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159227
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/inc/layfrm.hxx b/sw/source/core/inc/layfrm.hxx
index b0f981477499..52e22829d4ad 100644
--- a/sw/source/core/inc/layfrm.hxx
+++ b/sw/source/core/inc/layfrm.hxx
@@ -183,6 +183,7 @@ public:
 m_VertPosOrientFramesFor.end(), pObj),
 m_VertPosOrientFramesFor.end());
 }
+void dumpAsXmlAttributes(xmlTextWriterPtr writer) const override;
 };
 
 /**
diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index 7fdd19ace322..1cd01d53c680 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -4139,6 +4139,18 @@ void SwLayoutFrame::FormatWidthCols( const SwBorderAttrs 
,
 }
 }
 
+void SwLayoutFrame::dumpAsXmlAttributes(xmlTextWriterPtr writer) const
+{
+SwFrame::dumpAsXmlAttributes(writer);
+
+const SwFrameFormat* pFormat = GetFormat();
+if (pFormat)
+{
+(void)xmlTextWriterWriteFormatAttribute( writer, BAD_CAST( "format" ), 
"%p", pFormat);
+(void)xmlTextWriterWriteFormatAttribute( writer, BAD_CAST( 
"formatName" ), "%s", BAD_CAST(pFormat->GetName().toUtf8().getStr()));
+}
+}
+
 static SwContentFrame* lcl_InvalidateSection( SwFrame *pCnt, SwInvalidateFlags 
nInv )
 {
 SwSectionFrame* pSect = pCnt->FindSctFrame();
diff --git a/sw/source/core/text/xmldump.cxx b/sw/source/core/text/xmldump.cxx
index 019866a9acbd..445a0e306336 100644
--- a/sw/source/core/text/xmldump.cxx
+++ b/sw/source/core/text/xmldump.cxx
@@ -234,13 +234,6 @@ void SwFrame::dumpAsXmlAttributes( xmlTextWriterPtr writer 
) const
 }
 (void)xmlTextWriterWriteAttribute(writer, BAD_CAST("WritingMode"), 
BAD_CAST(aMode.getStr()));
 }
-if (IsHeaderFrame() || IsFooterFrame())
-{
-const SwHeadFootFrame *pHeadFootFrame = static_cast(this);
-OUString aFormatName = pHeadFootFrame->GetFormat()->GetName();
-(void)xmlTextWriterWriteFormatAttribute( writer, BAD_CAST( "fmtName" 
), "%s", BAD_CAST(OUStringToOString(aFormatName, 
RTL_TEXTENCODING_UTF8).getStr()));
-(void)xmlTextWriterWriteFormatAttribute( writer, BAD_CAST( "fmtPtr" ), 
"%p", pHeadFootFrame->GetFormat());
-}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


Re: Testing CJK glyphs

2023-11-09 Thread Jun Nogata
Hi,

2023年11月10日(金) 10:18 Chris Sherlock :
> We seem to bundle Noto Sans in extras, but not the CJK variant. Is this 
> something we could look at including?

That would be nice. However, I think it would be difficult to bundle
it because of its very large size.
My idea would be to include it in a language pack. But that task would
be time consuming.

Now, for CJK, how about using Google's Noto CJK Font as a default font?
* https://github.com/notofonts/noto-cjk
For Japanese fonts for Windows and Mac, Yu Gothic and Yu Mincho are
used for OS bundled fonts. But, since they are OS bundled fonts, they
are not freely available.
Recently, BIZ UD Gothic and BIZ UD Mincho are also used. These are SIL OFL.
* https://github.com/googlefonts/morisawa-biz-ud-gothic
* https://github.com/googlefonts/morisawa-biz-ud-mincho

I haven't been able to find the cause yet, but using Propotional
Alternate Metrics in the font feature can cause the letter filling to
be wrong. I would be happy to find the cause of this problem.


2023年11月10日(金) 10:18 Chris Sherlock :
>
>
> Sent from my iPhone
>
> > On 9 Nov 2023, at 8:03 pm, Caolán McNamara  
> > wrote:
> >
> > On Thu, 2023-11-09 at 16:23 +1100, Chris Sherlock wrote:
> >> Just a quick question - I want to write a unit test that checks the
> >> glyph advancements for CJK glyphs.
> >>
> >> Specifically, I want to test the advancements of the following text:
> >>
> >> 根据10.1(37BA) Eng
> >>
> >> What font comes bundled with LibreOffice that I can use?
> >
> > My understanding is that we don't bundle a CJK font. I think the best
> > option is to follow the pattern of:
> > https://git.libreoffice.org/core/commit/6b178c6e88ec5a765ad2b3ccd98182286222f550
> > where you can see from the little font.readme how to make a small
> > testing font with just the subset of glyphs you need from (an
> > appropriately licensed) CJK font for the purposes of such a test.
>
> Thanks Caolán, that’s very helpful.
> We seem to bundle Noto Sans in extras, but not the CJK variant. Is this 
> something we could look at including?
>
> Chris

-- 
野方 純 (Jun Nogata) - mail: noga...@gmail.com
 - web: http://www.nofuture.tv/


[Libreoffice-bugs] [Bug 158093] LibreOffice hangs at at startup if LanguageToolsServer is not reachable

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158093

--- Comment #1 from Mike Kaganski  ---
I can't repro using Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

With LanguageTool enabled in Language Settings, I see DNS queries for
api.languagetool.org, when starting Writer; but when I disable LanguageTool in
settings, and restart LibreOffice, starting Writer does not produce these
queries (and other communications). Enabling and restarting the program gives
the communications again.

Version specific? OS specific? (But I don't see how it would be OS-specific,
though.)

The communication code is in
lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx. A breakpoint
in getCheckerURL there would trigger at every case of getting the respective
URL.

I recall there were some changes lately related to obtaining list of languages.
Possibly they changed the situation. Maybe commit
7fbea38b7aa5335abef55b445df88ee571d18360 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156662] Always using direct connection to api.languagetool.org

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156662

--- Comment #3 from Norimasa Yamamoto  ---
Created attachment 190777
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190777=edit
contains a line to reproduce

Not fixed at 7.5.8 release.

I made and attached an ods file which contains only a line.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158088] FILEOPEN: Version incompatibility when i open the pdf

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158088

--- Comment #14 from Rainer Bielefeld Retired  
---
(In reply to zarifahnaf from comment #13)
I think so, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158109] FILESAVE: Exporting to PDF

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158109

--- Comment #3 from Joel Hilsenrath  ---
Created attachment 190776
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190776=edit
LO version info

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154851] Cannot type any non-korean key like punctuation marks or spaces or backspace on asian(korean) input mode

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154851

Dieter  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEW |UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158109] FILESAVE: Exporting to PDF

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158109

Joel Hilsenrath  changed:

   What|Removed |Added

 CC||xoano...@yahoo.com

--- Comment #2 from Joel Hilsenrath  ---
Created attachment 190775
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190775=edit
The pdf showing a screen print

steps:
1. open file
2. "Export Directly as PDF
3. Click "Save"
4. Open pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158129] Bluescreen on Windows 11 when LibreOffice is running (with or without open document)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158129

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151307] Mac Address Book ODB file causes crash in LO when contact data edited in Contacts.app(macOS)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151307

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158129] Bluescreen on Windows 11 when LibreOffice is running (with or without open document)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158129

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152356] Show indication when clicking on a template in canvas

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152356

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154767] frequent crashes in libreoffice writer

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154767

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152356] Show indication when clicking on a template in canvas

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152356

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154767] frequent crashes in libreoffice writer

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154767

--- Comment #3 from QA Administrators  ---
Dear juagon007,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154431] Bad management of hidden text in Writer | Editing, fotmatting, viewing, UI

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154431

--- Comment #3 from QA Administrators  ---
Dear apprendista.programmatore+Bugzilla,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154431] Bad management of hidden text in Writer | Editing, fotmatting, viewing, UI

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154431

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154361] LibreOffice Writer does not show all text values of Sdt blocks in document Header

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154361

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151157] When odf saved to network location Read Error. Format error discovered in the file in sub-document styles.xml

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151157

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154361] LibreOffice Writer does not show all text values of Sdt blocks in document Header

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154361

--- Comment #4 from QA Administrators  ---
Dear Majd Azzam,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151157] When odf saved to network location Read Error. Format error discovered in the file in sub-document styles.xml

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151157

--- Comment #3 from QA Administrators  ---
Dear Kelly Trimble,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143606] Write Navigator no longer remembers 2nd monitor

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143606

--- Comment #3 from QA Administrators  ---
Dear rferraro,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 92959] PDF exported text boxes have weird border spacing

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92959

--- Comment #25 from QA Administrators  ---
Dear Florian Wicke,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 95743] Horizontal page does not rotate when printing two pages on one sheet

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95743

--- Comment #5 from QA Administrators  ---
Dear tagezi,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 76219] HANG i#84870: WW8: large objects in Russian text / DOC with complex header / ... may cause loop (see comment 7 and 8)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76219

--- Comment #31 from QA Administrators  ---
Dear Mike Kaganski,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145566] Translation of toolbar names saved in user profile, blocking changes in future versions

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145566

--- Comment #5 from QA Administrators  ---
Dear Ming Hua,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158088] FILEOPEN: Version incompatibility when i open the pdf

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158088

--- Comment #13 from zarifah...@outlook.com ---
(In reply to Cristopher from comment #12)
> Hi fella,
> So I see your problem is due to the pdf itself and not to the sowftware free
> office.so I see the pdf that you try to open has copyright since it is a
> book of editoral MC GRAW HILL.

Hi there,

Correct, the problem might be with the pdf itself. But when all the other
software:
1. Firefox
2. Edge

can open it, dont you think Libreoffice should be able to open it too?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157902] INCONSISTENT FORMATTING IN CALC

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157902

--- Comment #7 from V Stuart Foote  ---
*** Bug 158153 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158153] INCONSISTENT FORMATTING IN CALC

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158153

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
Summary|INITIAL BUG NOT PROPERLY|INCONSISTENT FORMATTING IN
   |ADDFRESSED  |CALC
 CC||vsfo...@libreoffice.org

--- Comment #3 from V Stuart Foote  ---
this belonged with bug 157902, as noted Calc responds to the default template
values in the build source.  

If you need larger font sizes modify your sheet's default style(s) and save as
a new template --> .ots document, aka. ODF Spreadsheet Template.

Then open that template when you create a new document using the larger fonts.
When saved it will become a new .ods, aka. ODF Spreadsheet of a new filename.

The default template with 10pt size default cell text will remain unchanged.

*** This bug has been marked as a duplicate of bug 157902 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152706] TRANSLATION: "Requested clipboard format is not available" error message when using DeepL translation feature

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152706

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #12 from Aron Budea  ---
Dieter, can you please check in a fresh daily build to see if the bug is still
reproducible for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113300] [META] Language detection bugs and enhancements

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113300
Bug 113300 depends on bug 152706, which changed state.

Bug 152706 Summary: TRANSLATION: "Requested clipboard format is not available" 
error message when using DeepL translation feature
https://bugs.documentfoundation.org/show_bug.cgi?id=152706

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152706] TRANSLATION: "Requested clipboard format is not available" error message when using DeepL translation feature

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152706

Aron Budea  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158088] FILEOPEN: Version incompatibility when i open the pdf

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158088

--- Comment #12 from Cristopher  ---
Hi fella,
So I see your problem is due to the pdf itself and not to the sowftware free
office.so I see the pdf that you try to open has copyright since it is a book
of editoral MC GRAW HILL.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149890] SVG: pattern is displayed with black fill

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149890

--- Comment #12 from Xisco Faulí  ---
Verified in

Version: 7.4.7.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: de-DE (es_ES.UTF-8); UI: es-ES
Debian package version: 4:7.4.7-1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154851] Cannot type any non-korean key like punctuation marks or spaces or backspace on asian(korean) input mode

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154851

jaredaguilar.rendo...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'feature/cib_contract49' - instsetoo_native/CustomTarget_install.mk solenv/bin

2023-11-09 Thread Christian Lohmaier (via logerrit)
 instsetoo_native/CustomTarget_install.mk |   16 
 solenv/bin/job-limiter.cpp   |  116 +++
 2 files changed, 131 insertions(+), 1 deletion(-)

New commits:
commit 4e1dcfe9947a57f70a394ffcc687ffb9029aff2b
Author: Christian Lohmaier 
AuthorDate: Fri Nov 3 15:41:39 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Nov 10 00:12:53 2023 +0100

limit parallelism during msi packaging stage to avoid cscript failures

with high parallelism there's a high risk of running into random
failures when calling WiLangId.vbs via cscript.

The limiter doesn't use make's jobserver since it is too easy to
deadlock the build since all jobs are started at once, consuming all
slots, but in addition all wait for an additional slot that never is
made available because all jobs are blocked waiting
All jobs being started at once and all jobs getting started from that
point on getting put under the limiter's control makes this simple
approach with separate grab/release calls possible. If they were spread
out the semaphore wouldn't be available (gets closed/removed as soon as
nothing waits for it anymore)

Change-Id: I345f2904a1d7e8989720722415fb51282ab3b05b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158886
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 
(cherry picked from commit edf6c155b0b22cbff2d255796c0541b644a5f245)

Fix typo

Change-Id: I84186bee245a95a74e92c974ca94bb81c31ee1ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158950
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit 0053dfbabd8b6711ea7e9354e5792048931daf7c)

Fix typo

Change-Id: Ie41ca6c56bf44b04bd2d65b6cb64594d66295f24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158951
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit 24e1d6dbd27fa6c37723b55bbab5f5b5cce279f2)

msi packaging job-limiter: use CXX_FOR_BUILD

since it is a build-tool it needs to match the arch of the platform the
build is performed, already had used ILIB_FOR_BUILD, but CXX was missed
and broke the build for the aarch64 daily tinderbox

Change-Id: Ie41ca6c56bf44b04bd2d65b6cb64594d66295f24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158993
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/instsetoo_native/CustomTarget_install.mk 
b/instsetoo_native/CustomTarget_install.mk
index f05b771fa107..aa18e827fda9 100644
--- a/instsetoo_native/CustomTarget_install.mk
+++ b/instsetoo_native/CustomTarget_install.mk
@@ -95,8 +95,19 @@ $(call 
gb_CustomTarget_get_workdir,instsetoo_native/install)/msi_templates/%/Bin
$(call gb_Output_announce,setting up msi templates for type $* - 
copying binary assets,$(true),CPY,4)
rm -rf $@ && mkdir -p $@ && cd $@ && cp 
$(SRCDIR)/instsetoo_native/inc_common/windows/msi_templates/Binary/*.* ./
 
+gb_Make_JobLimiter := $(WORKDIR)/job-limiter.exe
+
+$(gb_Make_JobLimiter): $(SRCDIR)/solenv/bin/job-limiter.cpp
+   cd $(WORKDIR) && \
+   $(CXX_FOR_BUILD) $(SOLARINC) -EHsc $^ -link -LIBPATH:$(subst ;, 
-LIBPATH:,$(ILIB_FOR_BUILD)) || rm -f $@
+
 # with all languages the logfile name would be too long when building the 
windows installation set,
 # that's the reason for the substitution to multilang below in case more than 
just en-US is packaged
+# also for windows msi packaging parallel execution is reduced by the 
job-limiter. This only has any
+# effect when building with help and multiple languages, and it also won't 
affect the real time for
+# packaging (since packaging the main installer takes longer than packaging 
sdk and all helppacks
+# even with the reduced parallelism (the higher the parallelism, the higher 
the chance for random
+# failures during the cscript call to WiLangId.vbs)
 $(instsetoo_installer_targets): $(SRCDIR)/solenv/bin/make_installer.pl \
 $(foreach ulf,$(instsetoo_ULFLIST),$(call 
gb_CustomTarget_get_workdir,instsetoo_native/install)/win_ulffiles/$(ulf).ulf) \
 $(if $(filter-out WNT,$(OS)),\
@@ -104,12 +115,15 @@ $(instsetoo_installer_targets): 
$(SRCDIR)/solenv/bin/make_installer.pl \
 bin/find-requires-gnome.sh \
 bin/find-requires-x11.sh) \
 ,instsetoo_msi_templates) \
-$(call gb_Postprocess_get_target,AllModulesButInstsetNative) | 
instsetoo_wipe
+$(call gb_Postprocess_get_target,AllModulesButInstsetNative) \
+| instsetoo_wipe $(if $(filter msi,$(PKGFORMAT)),$(gb_Make_JobLimiter))
$(call gb_Output_announce,$(if $(filter 
en-US$(COMMA)%,$(instsetoo_installer_langs)),$(subst 
$(instsetoo_installer_langs),multilang,$@),$@),$(true),INS,1)
+   $(if $(filter %msi‧nostrip,$@),$(gb_Make_JobLimiter) grab)
$(call gb_Trace_StartRange,$@,INSTALLER)
$(call gb_Helper_print_on_error, \

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - instsetoo_native/CustomTarget_install.mk solenv/bin

2023-11-09 Thread Christian Lohmaier (via logerrit)
 instsetoo_native/CustomTarget_install.mk |   16 
 solenv/bin/job-limiter.cpp   |  116 +++
 2 files changed, 131 insertions(+), 1 deletion(-)

New commits:
commit 58f03414215dbb84bfd8875abe73b6521b83438b
Author: Christian Lohmaier 
AuthorDate: Fri Nov 3 15:41:39 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Fri Nov 10 00:11:19 2023 +0100

limit parallelism during msi packaging stage to avoid cscript failures

with high parallelism there's a high risk of running into random
failures when calling WiLangId.vbs via cscript.

The limiter doesn't use make's jobserver since it is too easy to
deadlock the build since all jobs are started at once, consuming all
slots, but in addition all wait for an additional slot that never is
made available because all jobs are blocked waiting
All jobs being started at once and all jobs getting started from that
point on getting put under the limiter's control makes this simple
approach with separate grab/release calls possible. If they were spread
out the semaphore wouldn't be available (gets closed/removed as soon as
nothing waits for it anymore)

Change-Id: I345f2904a1d7e8989720722415fb51282ab3b05b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158886
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 
(cherry picked from commit edf6c155b0b22cbff2d255796c0541b644a5f245)

Fix typo

Change-Id: I84186bee245a95a74e92c974ca94bb81c31ee1ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158950
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit 0053dfbabd8b6711ea7e9354e5792048931daf7c)

Fix typo

Change-Id: Ie41ca6c56bf44b04bd2d65b6cb64594d66295f24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158951
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit 24e1d6dbd27fa6c37723b55bbab5f5b5cce279f2)

msi packaging job-limiter: use CXX_FOR_BUILD

since it is a build-tool it needs to match the arch of the platform the
build is performed, already had used ILIB_FOR_BUILD, but CXX was missed
and broke the build for the aarch64 daily tinderbox

Change-Id: Ie41ca6c56bf44b04bd2d65b6cb64594d66295f24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158993
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/instsetoo_native/CustomTarget_install.mk 
b/instsetoo_native/CustomTarget_install.mk
index f05b771fa107..aa18e827fda9 100644
--- a/instsetoo_native/CustomTarget_install.mk
+++ b/instsetoo_native/CustomTarget_install.mk
@@ -95,8 +95,19 @@ $(call 
gb_CustomTarget_get_workdir,instsetoo_native/install)/msi_templates/%/Bin
$(call gb_Output_announce,setting up msi templates for type $* - 
copying binary assets,$(true),CPY,4)
rm -rf $@ && mkdir -p $@ && cd $@ && cp 
$(SRCDIR)/instsetoo_native/inc_common/windows/msi_templates/Binary/*.* ./
 
+gb_Make_JobLimiter := $(WORKDIR)/job-limiter.exe
+
+$(gb_Make_JobLimiter): $(SRCDIR)/solenv/bin/job-limiter.cpp
+   cd $(WORKDIR) && \
+   $(CXX_FOR_BUILD) $(SOLARINC) -EHsc $^ -link -LIBPATH:$(subst ;, 
-LIBPATH:,$(ILIB_FOR_BUILD)) || rm -f $@
+
 # with all languages the logfile name would be too long when building the 
windows installation set,
 # that's the reason for the substitution to multilang below in case more than 
just en-US is packaged
+# also for windows msi packaging parallel execution is reduced by the 
job-limiter. This only has any
+# effect when building with help and multiple languages, and it also won't 
affect the real time for
+# packaging (since packaging the main installer takes longer than packaging 
sdk and all helppacks
+# even with the reduced parallelism (the higher the parallelism, the higher 
the chance for random
+# failures during the cscript call to WiLangId.vbs)
 $(instsetoo_installer_targets): $(SRCDIR)/solenv/bin/make_installer.pl \
 $(foreach ulf,$(instsetoo_ULFLIST),$(call 
gb_CustomTarget_get_workdir,instsetoo_native/install)/win_ulffiles/$(ulf).ulf) \
 $(if $(filter-out WNT,$(OS)),\
@@ -104,12 +115,15 @@ $(instsetoo_installer_targets): 
$(SRCDIR)/solenv/bin/make_installer.pl \
 bin/find-requires-gnome.sh \
 bin/find-requires-x11.sh) \
 ,instsetoo_msi_templates) \
-$(call gb_Postprocess_get_target,AllModulesButInstsetNative) | 
instsetoo_wipe
+$(call gb_Postprocess_get_target,AllModulesButInstsetNative) \
+| instsetoo_wipe $(if $(filter msi,$(PKGFORMAT)),$(gb_Make_JobLimiter))
$(call gb_Output_announce,$(if $(filter 
en-US$(COMMA)%,$(instsetoo_installer_langs)),$(subst 
$(instsetoo_installer_langs),multilang,$@),$@),$(true),INS,1)
+   $(if $(filter %msi‧nostrip,$@),$(gb_Make_JobLimiter) grab)
$(call gb_Trace_StartRange,$@,INSTALLER)
$(call gb_Helper_print_on_error, \

[Libreoffice-bugs] [Bug 158085] Incorrect footnote number

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158085

--- Comment #12 from Hudson  ---
It follows above annexed the file with the pages where the problem occur.

I would like to highlight the following steps to reproduce the problem:

1. Open the file.
2. The problem is with the footnote on the 2nd page.
3. Oddly, select the footnote marking, cut and paste in the same place. The
problem "disappears".
4. Reload the file.
5. On the 2nd page, the problem persists.

Thanks by all your attention.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158085] Incorrect footnote number

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158085

--- Comment #11 from Hudson  ---
Created attachment 190774
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190774=edit
File lesser than original with the problem mentioned.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158153] INITIAL BUG NOT PROPERLY ADDFRESSED

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158153

--- Comment #2 from ady  ---
(In reply to nik from comment #0)
> Created attachment 190773 [details]
> Have two more Screen Shots; but CANNOT Attach…….


In order to add more screenshots (or other relevant files) to the corresponding
bug report, you could go to the report web page for bug 158153 and click on the
link to "Add an attachment".

> I ‘REPLY’ to the eMail….

The emails are only for you to receive the info that some change was produced
on the bug report. You are not supposed to reply to the emails using emails,
but rather go to the web page of the relevant bug report and then either click
on the "Add comment" link or use a "reply" link on one (or more) of the prior
comments on the same web page.

There are probably more bug reports awaiting for your replies with additional
information (which is the meaning of setting a bug report to "needinfo").

I am tempted to close this report, since there is really no real bug reported
here and comment 1 already includes the solution to the problem.

@Nik,

Hopefully you read this comment and reply to it in the web page of bug 158153,
instead of attempting to send an unwanted email.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146093] 4 seconds delay after entering and after leaving a cell

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146093

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Lennard, do you still have this issue in the latest release of LO? Preferably
7.6.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143133] LibreOffice leaks embedded Fonts between documents

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143133

João Paulo  changed:

   What|Removed |Added

 CC||joaopauloag-freedesktop@yah
   ||oo.com.br

--- Comment #7 from João Paulo  ---
(In reply to Timur from comment #6)
> With the previous comment, this is close to WontFix. Xisco, please see.

Why close it as WontFix if the registered embedded fonts could be unregistered?
 When registering embedded fonts, save this info in a list to deregister them
after the document with the embedded font is closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Testing CJK glyphs

2023-11-09 Thread Chris Sherlock


Sent from my iPhone

> On 9 Nov 2023, at 8:03 pm, Caolán McNamara  
> wrote:
> 
> On Thu, 2023-11-09 at 16:23 +1100, Chris Sherlock wrote:
>> Just a quick question - I want to write a unit test that checks the
>> glyph advancements for CJK glyphs. 
>> 
>> Specifically, I want to test the advancements of the following text:
>> 
>> 根据10.1(37BA) Eng
>> 
>> What font comes bundled with LibreOffice that I can use?
> 
> My understanding is that we don't bundle a CJK font. I think the best
> option is to follow the pattern of:
> https://git.libreoffice.org/core/commit/6b178c6e88ec5a765ad2b3ccd98182286222f550
> where you can see from the little font.readme how to make a small
> testing font with just the subset of glyphs you need from (an
> appropriately licensed) CJK font for the purposes of such a test.

Thanks Caolán, that’s very helpful. 
We seem to bundle Noto Sans in extras, but not the CJK variant. Is this 
something we could look at including?

Chris

[Libreoffice-bugs] [Bug 157924] It opens almost all documents with distorted fonts

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157924

--- Comment #11 from Max  ---
sudo rm arachnid___arachnid___arachnid.ttf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157924] It opens almost all documents with distorted fonts

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157924

Max  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #10 from Max  ---
That's what the terminal says about the TimesNewRoman font, and the Arachnid
font really stuck there. Please tell me what to do?

fc-list | grep Times | grep ".ttf"
/usr/share/fonts/truetype/msttcorefonts/Times_New_Roman.ttf: Times New
Roman:style=Regular,Normal,obyčejné,Standard,Κανονικά,Normaali,Normál,Normale,Standaard,Normalny,Обычный,Normálne,Navadno,thường,Arrunta
/usr/share/fonts/truetype/msttcorefonts/Times_New_Roman_Italic.ttf: Times New
Roman:style=Italic,cursiva,kurzíva,kursiv,Πλάγια,Kursivoitu,Italique,Dőlt,Corsivo,Cursief,kursywa,Itálico,Курсив,İtalik,Poševno,nghiêng,Etzana
/usr/share/fonts/truetype/msttcorefonts/timesbd.ttf: Times New
Roman:style=Bold,Negreta,tučné,fed,Fett,Έντονα,Negrita,Lihavoitu,Gras,Félkövér,Grassetto,Vet,Halvfet,Pogrubiona,Negrito,Полужирный,Fet,Kalın,Krepko,đậm,Lodia
/usr/local/share/fonts/a/arachnid___arachnid___arachnid.ttf: arachnid,Times New
Roman:style=arachnid,Normal,obyčejné,Standard,Κανονικά,Normaali,Normál,Normale,Standaard,Normalny,Обычный,Normálne,Navadno,thường,Arrunta,Regular
/usr/share/fonts/truetype/msttcorefonts/Times_New_Roman_Bold_Italic.ttf: Times
New Roman:style=Bold Italic,Negreta cursiva,tučné kurzíva,fed kursiv,Fett
Kursiv,Έντονα Πλάγια,Negrita Cursiva,Lihavoitu Kursivoi,Gras Italique,Félkövér
dőlt,Grassetto Corsivo,Vet Cursief,Halvfet Kursiv,Pogrubiona kursywa,Negrito
Itálico,Полужирный Курсив,Tučná kurzíva,Fet Kursiv,Kalın İtalik,Krepko
poševno,nghiêng đậm,Lodi etzana
/usr/share/fonts/truetype/msttcorefonts/Times_New_Roman_Bold.ttf: Times New
Roman:style=Bold,Negreta,tučné,fed,Fett,Έντονα,Negrita,Lihavoitu,Gras,Félkövér,Grassetto,Vet,Halvfet,Pogrubiona,Negrito,Полужирный,Fet,Kalın,Krepko,đậm,Lodia
/usr/share/fonts/truetype/msttcorefonts/timesi.ttf: Times New
Roman:style=Italic,cursiva,kurzíva,kursiv,Πλάγια,Kursivoitu,Italique,Dőlt,Corsivo,Cursief,kursywa,Itálico,Курсив,İtalik,Poševno,nghiêng,Etzana
/usr/share/fonts/truetype/msttcorefonts/timesbi.ttf: Times New Roman:style=Bold
Italic,Negreta cursiva,tučné kurzíva,fed kursiv,Fett Kursiv,Έντονα
Πλάγια,Negrita Cursiva,Lihavoitu Kursivoi,Gras Italique,Félkövér dőlt,Grassetto
Corsivo,Vet Cursief,Halvfet Kursiv,Pogrubiona kursywa,Negrito
Itálico,Полужирный Курсив,Tučná kurzíva,Fet Kursiv,Kalın İtalik,Krepko
poševno,nghiêng đậm,Lodi etzana
/usr/share/fonts/truetype/msttcorefonts/times.ttf: Times New
Roman:style=Regular,Normal,obyčejné,Standard,Κανονικά,Normaali,Normál,Normale,Standaard,Normalny,Обычный,Normálne,Navadno,thường,Arrunta

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156200] Writer: Bad font rendering with anti-aliasing disabled (hinting enabled!) in Manjaro KDE system settings after update to LO 7.4.5-1

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156200

--- Comment #21 from Stephan Bergmann  ---
(In reply to kde-user from comment #19)
> The last NOT affected version was 7.6.2.1 from 10/23/23,
> Commit code 7a83544cc21d1380efb3eeeb9f10adb26d125bc8db4936e82312a96e357e9abf
> 
> The version now affected is (strangely enough) also version 7.6.2.1 from
> November 8th, 2023,
> Commit code 1aa14038cbe7408fab115258b431132b7c0d1e9e257ba194c187a96df5e5be95
> The subject of this version says:
> Replace use of "Calibri" and "Calibri Light" with "Noto Sans" (b6ecbefa)
> 
> But to what extent this is the only change from the previous version, and
> whether or what this change has to do with font rendering in LO Writer, I
> don't know.
> But something must have changed in this version, because immediately when I
> downgrade to the previous version everything is fine again!

The latest version of the LO 7.6.2.1 flatpak released on 2023-11-08 is based on

"Merge pull request #264 from flathub/runtime-23.08" and uses the updated
runtime org.freedesktop.Platform//23.08, rather than
org.freeedesktop.Platform//22.08 as used by the previous version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158153] INITIAL BUG NOT PROPERLY ADDFRESSED

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158153

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
You need to change the 'Default style' for cells.
And you can save it as default template.
https://help.libreoffice.org/6.2/en-US/text/swriter/guide/template_default.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152356] Show indication when clicking on a template in canvas

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152356

--- Comment #3 from emut  ---
(In reply to Stéphane Guillou (stragu) from comment #2)
> I'm not sure what you mean by "is a template".
> A template is a file type that new files can be based on.
> What is the German word that you are translating from? Or are you able to
> provide steps using the an English UI?

Sorry, my fault. I meant style.

Actually, I just wanted to raise the concern that it is not possible to see if
a text belongs to a certain style. 
However, with release 7.6 with the "Spotlight" option it seems this requested
feature has been fortunately implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=38194. 
(Though it has to be activated explicitly, seeing on the first glance (for
example if a text in the document belongs to a certain style (subtitle/title
...) is still not possible).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158148] Libreoffice crashed writer and calc open

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158148

--- Comment #3 from m.a.riosv  ---
Please test disabling Skia, Menu/Tools/Options/LibreOffice/View.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158153] New: INITIAL BUG NOT PROPERLY ADDFRESSED

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158153

Bug ID: 158153
   Summary: INITIAL BUG NOT PROPERLY ADDFRESSED
   Product: LibreOffice
   Version: 7.6.0.3 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: n...@grumpie.ca

Created attachment 190773
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190773=edit
Have two more Screen Shots; but CANNOT Attach…….

Pretty PATHETIC! I report a ‘bug.  You reply (unsatisfactory, needs further
help):
I ‘REPLY’ to the eMail….REJECTED….CANNOT BE DELIVERED ?

Response was NOT Conplete, thoughtful, nor addressed the basic problem.

LibreOffice CALC, is the ONLY component of an AMAZING Application, that INSISTS
on setting Font Height to TEN, by default.  All the rest seem to default to the
LAST USED FONT Height!

I was told to select the ENTIRE Spreadsheet when Opening a New Instance & then
make Preferences (An UNNECESSARY STEP)!  UNNECESSARY, as a sentient human,
ALREADY Know how to do this

Even WORSE; after doing this EXTRA ‘CORRECTION’; if I insert a ROW, the NEW Row
Maintains the FONT; BUT REVERTS to TEN POINT HEIGHT.

Nik FINNEY

AKA ‘Grumpir’ for good reason

PS

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158043] pptx import, placeholder shape missing, wrong inheritance from layout page

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158043

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||r...@post.cz,
   ||szymon.k...@collabora.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
  Regression By||Szymon Kłos

--- Comment #6 from raal  ---
confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

154980: pptx: import shape text from master page |
https://gerrit.libreoffice.org/c/core/+/154980

Adding Cc to: Szymon Kłos

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - desktop/source extensions/source external/libcmis include/curlinit.hxx lingucomponent/source linguistic/source svl/source ucb/sourc

2023-11-09 Thread Michael Stahl (via logerrit)
 desktop/source/app/updater.cxx 
  |4 
 desktop/source/minidump/minidump.cxx   
  |4 
 extensions/source/update/check/download.cxx
  |4 
 
external/libcmis/0002-HttpSession-add-a-callback-that-can-be-used-to-confi.patch
 |  142 ++
 external/libcmis/UnpackedTarball_libcmis.mk
  |1 
 include/curlinit.hxx   
  |   59 
 lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx  
  |3 
 linguistic/source/translate.cxx
  |4 
 svl/source/crypto/cryptosign.cxx   
  |6 
 ucb/source/ucp/cmis/cmis_content.cxx   
  |5 
 ucb/source/ucp/ftp/ftploaderthread.cxx 
  |4 
 ucb/source/ucp/webdav-curl/CurlSession.cxx 
  |2 
 12 files changed, 238 insertions(+)

New commits:
commit 6bb273876fb608d51f00b20e8cf7393eea6ce6b4
Author: Michael Stahl 
AuthorDate: Fri Nov 3 20:16:09 2023 +0100
Commit: Andras Timar 
CommitDate: Thu Nov 9 21:22:34 2023 +0100

curl: mitigate migration to OpenSSL on Linux

The problem is that curl 8.3.0 removed the NSS backend, so we now
have no other choice than to use the bundled OpenSSL on Linux.

Currently any curl https connection fails with:

  CurlSession.cxx:963: curl_easy_perform failed: (60) SSL certificate 
problem: unable to get local issuer certificate

Apparently this requires manually telling curl which CA certificates to
trust; there is a configure flag --with-ca-bundle but that is useless as
it tries to load the file relative to whatever is the current working
directory, and also did i mention that there are at least 3 different
locations where a Linux system may store its system trusted CA
certificates because ALL ABOUT CHOICE.

So add a new header with an init function to try out various file
locations listed in this nice blog article and call it from way too many
places that independently use curl.


https://www.happyassassin.net/posts/2015/01/12/a-note-about-ssltls-trusted-certificate-stores-and-platforms/

TODO: perhaps bundle a cacert.pem as a fallback in case the system chose
to innovate by putting its certificates in yet another unexpected place

(regression from commit c2930ebff82c4f7ffe8377ab82627131f8544226)

Change-Id: Ibf1cc0069bc2ae011ecead9a4c2b455e94b01241
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158915
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 11f439b861922b9286b2e47ed326f3508a48d44e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159218
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index 5fb18dfad0bf..4e4d2cda413f 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -37,6 +37,8 @@
 #include 
 #include 
 #include 
+
+#include 
 #include 
 
 #include 
@@ -546,6 +548,8 @@ std::string download_content(const OString& rURL, bool 
bFile, OUString& rHash)
 if (!curl)
 return std::string();
 
+::InitCurl_easy(curl.get());
+
 curl_easy_setopt(curl.get(), CURLOPT_URL, rURL.getStr());
 curl_easy_setopt(curl.get(), CURLOPT_USERAGENT, kUserAgent);
 bool bUseProxy = false;
diff --git a/desktop/source/minidump/minidump.cxx 
b/desktop/source/minidump/minidump.cxx
index 0bf20f2aa419..7fbb0884987d 100644
--- a/desktop/source/minidump/minidump.cxx
+++ b/desktop/source/minidump/minidump.cxx
@@ -17,6 +17,8 @@
 
 #include 
 
+#include 
+
 #ifdef _WIN32
 #include 
 #include 
@@ -95,6 +97,8 @@ static bool uploadContent(std::map& 
parameters, std::s
 if (!curl)
 return false;
 
+::InitCurl_easy(curl);
+
 std::string proxy, proxy_user_pwd, ca_certificate_file, file, url, version;
 
 getProperty("Proxy", proxy, parameters);
diff --git a/extensions/source/update/check/download.cxx 
b/extensions/source/update/check/download.cxx
index ba371bdee570..cdbbe2c32734 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -23,6 +23,8 @@
 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -222,6 +224,8 @@ static bool curl_run(std::u16string_view rURL, OutData& 
out, const OString& aPro
 
 if( nullptr != pCURL )
 {
+::InitCurl_easy(pCURL);
+
 out.curl = pCURL;
 
 OString aURL(OUStringToOString(rURL, RTL_TEXTENCODING_UTF8));
diff --git 
a/external/libcmis/0002-HttpSession-add-a-callback-that-can-be-used-to-confi.patch
 

[Libreoffice-bugs] [Bug 158140] Unify lockdown behavior of Options dialog page Writer/Web - View

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158140

raal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||r...@post.cz
 Status|UNCONFIRMED |NEW

--- Comment #2 from raal  ---
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

No crash when changing settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158141] Unify lockdown behavior of Options dialog page Writer/Web - Formatting Aids

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158141

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from raal  ---
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

No crash when changing settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152706] TRANSLATION: "Requested clipboard format is not available" error message when using DeepL translation feature

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152706

--- Comment #11 from Mike Kaganski  ---
(In reply to Timur from comment #10)

This report has nothing to do with what you describe: Michael had upgraded Curl
in commit c2930ebff82c4f7ffe8377ab82627131f8544226 on 2023-09-27, which caused
the problem that you saw, and then fixed it in commit
11f439b861922b9286b2e47ed326f3508a48d44e on 2023-11-07. But this bug existed
and was filed on 2022-12-28 - almost a year before; and I couldn't repro it on
2023-10-11, before Michael created the fix.

I don't restore the resolution myself, because I don't repro, and don't know if
Dieter still has it. But your change was unwarranted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158144] Unify lockdown behavior of Options dialog page Writer/Web - Print

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158144

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from raal  ---
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

No crash when changing settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

2023-11-09 Thread Michael Weghorn (via logerrit)
 vcl/unx/gtk4/a11y.cxx |   47 +++
 1 file changed, 47 insertions(+)

New commits:
commit 3aca2d9776a871f15009a1aa70628ba3a03ee147
Author: Michael Weghorn 
AuthorDate: Thu Nov 9 15:31:57 2023 +0100
Commit: Michael Weghorn 
CommitDate: Thu Nov 9 21:00:05 2023 +0100

gtk4 a11y: Handle the "level" object attribute

Add initial handling/mapping for object attributes.

In LibreOffice and Gtk 3/ATK/AT-SPI, object attributes
are currently key-value pairs, so arbitrary attribute
names and values can be set.

For Gtk 4, there's currently a discussion on how
AT-SPI object attributes should be handled, s. [1].

One potential option is for them to be handled as
`GtkAccessibleProperty`s.

In any case, there's already a `GTK_ACCESSIBLE_PROPERTY_LEVEL`
property that matches the "level" object attribute that
Writer sets for headings to specify what heading level
this is (s. `SwAccessibleParagraph::getExtendedAttributes`)
and that the gtk3 VCL plugin reports as an ATK/AT-SPI
object attribute with the same name and semantics for AT-SPI,
which is in line with the specification in the Core
Accessibility API Mappings 1.2 [2].

Map that LO object attribute to the above-mentioned
`GTK_ACCESSIBLE_PROPERTY_LEVEL`.

The property is currently not yet mapped to an AT-SPI
attribute in Gtk 4, but together with a corresponding
merge request [3], the object attribute can be seen
in Accerciser as expected.

While object properties in LO are currently generally
only generated/updated when they're queried
(via `XAccessibleExtendedAttributes::getExtendedAttributes`),
the `GtkAccessibleProperty` handling in Gtk 4
would require to explicitly call
`gtk_accessible_update_property` with the new value.

This may require further adjustments on LO side to
keep the properties up-to-date (e.g. adding something
like a new `AccessibleEventId::OBJECT_PROPERTY_CHANGED`
event and then implementing corresponding handling in
all places that provide object properties).
But that's something to look into later, also depending
on the outcome of the discussion in [1].
(As of now, the gtk4 VCL plugin doesn't handle any
a11y events, not even the existing ones.)

[1] https://gitlab.gnome.org/GNOME/gtk/-/issues/6196
[2] https://www.w3.org/TR/core-aam-1.2/#ariaLevelHeading
[3] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6549

Change-Id: I024afd7b527a20922e69156e1562dda783be2b49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159216
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/unx/gtk4/a11y.cxx b/vcl/unx/gtk4/a11y.cxx
index 8bd1b97f0aa9..42a0fd59e4b9 100644
--- a/vcl/unx/gtk4/a11y.cxx
+++ b/vcl/unx/gtk4/a11y.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -307,6 +308,50 @@ static void applyStates(GtkAccessible* pGtkAccessible,
 }
 }
 
+static void applyObjectAttribute(GtkAccessible* pGtkAccessible, const 
OUString& rName,
+ const OUString& rValue)
+{
+assert(pGtkAccessible);
+
+if (rName == u"level")
+{
+const int nLevel = static_cast(rValue.toInt32());
+gtk_accessible_update_property(pGtkAccessible, 
GTK_ACCESSIBLE_PROPERTY_LEVEL, nLevel, -1);
+}
+}
+
+/**
+ * Based on the object attributes set for xContext, set the corresponding Gtk 
equivalents
+ * in pGtkAccessible, where applicable.
+ */
+static void
+applyObjectAttributes(GtkAccessible* pGtkAccessible,
+  
css::uno::Reference xContext)
+{
+assert(pGtkAccessible);
+
+css::uno::Reference 
xAttributes(
+xContext, css::uno::UNO_QUERY);
+if (!xAttributes.is())
+return;
+
+OUString sAttrs;
+xAttributes->getExtendedAttributes() >>= sAttrs;
+
+sal_Int32 nIndex = 0;
+do
+{
+const OUString sAttribute = sAttrs.getToken(0, ';', nIndex);
+sal_Int32 nColonPos = 0;
+const OUString sName = sAttribute.getToken(0, ':', nColonPos);
+const OUString sValue = sAttribute.getToken(0, ':', nColonPos);
+assert(nColonPos == -1
+   && "Too many colons in attribute that should have 
\"name:value\" syntax");
+
+applyObjectAttribute(pGtkAccessible, sName, sValue);
+} while (nIndex >= 0);
+}
+
 #define LO_TYPE_ACCESSIBLE (lo_accessible_get_type())
 #define LO_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), 
LO_TYPE_ACCESSIBLE, LoAccessible))
 // #define LO_IS_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), 
LO_TYPE_ACCESSIBLE))
@@ -545,6 +590,8 @@ lo_accessible_new(GdkDisplay* pDisplay, GtkAccessible* 
pParent,
 
 applyStates(pGtkAccessible, xContext);
 
+applyObjectAttributes(GTK_ACCESSIBLE(ret), xContext);
+
 // set values from XAccessibleValue interface if that's 

[Libreoffice-bugs] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157866

--- Comment #9 from Eyal Rozenberg  ---
(In reply to Stéphane Guillou (stragu) from comment #8)
> But it might be worth splitting it, as the canvas does not jump only with
> toolbars popping up and disappear.
> A simple example is turning off the rulers (in either Writer or Impress).

And another case is if someone writes an extension which affects the UI in some
situations, enlarging or reducing the area used by the canvas. The LO code
should take care to keep the canvas stabilized.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

2023-11-09 Thread Michael Weghorn (via logerrit)
 vcl/unx/gtk4/a11y.cxx |  122 --
 1 file changed, 69 insertions(+), 53 deletions(-)

New commits:
commit 9cb506a37a3228cf820eaeec681e49c08607cf59
Author: Michael Weghorn 
AuthorDate: Thu Nov 9 15:24:26 2023 +0100
Commit: Michael Weghorn 
CommitDate: Thu Nov 9 20:58:22 2023 +0100

gtk4 a11y: Extract state handling to helper function

Change-Id: I1f6dba461b328fc41de6d944bd8657daa9b05370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159215
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/unx/gtk4/a11y.cxx b/vcl/unx/gtk4/a11y.cxx
index 482c3aef3487..8bd1b97f0aa9 100644
--- a/vcl/unx/gtk4/a11y.cxx
+++ b/vcl/unx/gtk4/a11y.cxx
@@ -240,6 +240,73 @@ static 
css::uno::Reference get_uno_accessible(G
 return pWindow->GetAccessible();
 }
 
+/**
+ * Based on the states set in xContext, set the corresponding Gtk 
states/properties
+ * in pGtkAccessible.
+ */
+static void applyStates(GtkAccessible* pGtkAccessible,
+
css::uno::Reference xContext)
+{
+assert(pGtkAccessible);
+
+if (!xContext.is())
+return;
+
+// Gtk differentiates between GtkAccessibleState and GtkAccessibleProperty
+// (both handled here) and GtkAccessiblePlatformState (handled in
+// 'lo_accessible_get_platform_state')
+const sal_Int64 nStates = xContext->getAccessibleStateSet();
+gtk_accessible_update_property(
+pGtkAccessible, GTK_ACCESSIBLE_PROPERTY_MODAL,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::MODAL),
+GTK_ACCESSIBLE_PROPERTY_MULTI_LINE,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::MULTI_LINE),
+GTK_ACCESSIBLE_PROPERTY_MULTI_SELECTABLE,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::MULTI_SELECTABLE),
+GTK_ACCESSIBLE_PROPERTY_READ_ONLY,
+bool(!(nStates & 
com::sun::star::accessibility::AccessibleStateType::EDITABLE)), -1);
+if (nStates & 
com::sun::star::accessibility::AccessibleStateType::HORIZONTAL)
+{
+gtk_accessible_update_property(pGtkAccessible, 
GTK_ACCESSIBLE_PROPERTY_ORIENTATION,
+   GTK_ORIENTATION_HORIZONTAL, -1);
+}
+else if (nStates & 
com::sun::star::accessibility::AccessibleStateType::VERTICAL)
+{
+gtk_accessible_update_property(pGtkAccessible, 
GTK_ACCESSIBLE_PROPERTY_ORIENTATION,
+   GTK_ORIENTATION_VERTICAL, -1);
+}
+
+gtk_accessible_update_state(
+pGtkAccessible, GTK_ACCESSIBLE_STATE_BUSY,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::BUSY),
+GTK_ACCESSIBLE_STATE_DISABLED,
+bool(!(nStates & 
com::sun::star::accessibility::AccessibleStateType::ENABLED)),
+GTK_ACCESSIBLE_STATE_EXPANDED,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::EXPANDED),
+GTK_ACCESSIBLE_STATE_SELECTED,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::SELECTED), -1);
+
+const sal_Int16 nRole = xContext->getAccessibleRole();
+if (nRole == com::sun::star::accessibility::AccessibleRole::CHECK_BOX)
+{
+GtkAccessibleTristate eState = GTK_ACCESSIBLE_TRISTATE_FALSE;
+if (nStates & 
com::sun::star::accessibility::AccessibleStateType::INDETERMINATE)
+eState = GTK_ACCESSIBLE_TRISTATE_MIXED;
+else if (nStates & 
com::sun::star::accessibility::AccessibleStateType::CHECKED)
+eState = GTK_ACCESSIBLE_TRISTATE_TRUE;
+gtk_accessible_update_state(pGtkAccessible, 
GTK_ACCESSIBLE_STATE_CHECKED, eState, -1);
+}
+else if (nRole == 
com::sun::star::accessibility::AccessibleRole::TOGGLE_BUTTON)
+{
+GtkAccessibleTristate eState = GTK_ACCESSIBLE_TRISTATE_FALSE;
+if (nStates & 
com::sun::star::accessibility::AccessibleStateType::INDETERMINATE)
+eState = GTK_ACCESSIBLE_TRISTATE_MIXED;
+else if (nStates & 
com::sun::star::accessibility::AccessibleStateType::PRESSED)
+eState = GTK_ACCESSIBLE_TRISTATE_TRUE;
+gtk_accessible_update_state(pGtkAccessible, 
GTK_ACCESSIBLE_STATE_PRESSED, eState, -1);
+}
+}
+
 #define LO_TYPE_ACCESSIBLE (lo_accessible_get_type())
 #define LO_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), 
LO_TYPE_ACCESSIBLE, LoAccessible))
 // #define LO_IS_ACCESSIBLE(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), 
LO_TYPE_ACCESSIBLE))
@@ -474,60 +541,9 @@ lo_accessible_new(GdkDisplay* pDisplay, GtkAccessible* 
pParent,
 ret->uno_accessible->getAccessibleContext());
 assert(xContext.is() && "No accessible context");
 
-// handle states
-// Gtk differentiates between GtkAccessibleState and GtkAccessibleProperty
-// (both handled here) and GtkAccessiblePlatformState (handled in
-// 'lo_accessible_get_platform_state')
-const sal_Int64 nStates = 

[Libreoffice-bugs] [Bug 158145] Unify lockdown behavior of Options dialog page Writer/Web - Table

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158145

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from raal  ---
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

No crash when changing settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158146] Unify lockdown behavior of Options dialog page Writer/Web - Background

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158146

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from raal  ---
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

No crash when changing settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158147] Unify lockdown behavior of Options dialog page Math - Settings

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158147

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||r...@post.cz

--- Comment #2 from raal  ---
Confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 41d9584179ef7b4e18eda47c2c0a955df8c087a5
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

No crash when changing settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source sw/uiconfig

2023-11-09 Thread Balazs Varga (via logerrit)
 sw/source/ui/config/optpage.cxx   |   84 +
 sw/source/uibase/inc/optpage.hxx  |   16 +
 sw/uiconfig/swriter/ui/viewoptionspage.ui |  254 +++---
 3 files changed, 328 insertions(+), 26 deletions(-)

New commits:
commit 51f4cadfdd50e757e593c3166d4e54c6b2634af9
Author: Balazs Varga 
AuthorDate: Wed Nov 8 12:33:56 2023 +0100
Commit: Balazs Varga 
CommitDate: Thu Nov 9 20:29:02 2023 +0100

tdf#158006 - UI: Part 21 - Unify lockdown behavior of Options dialog

for Writer - View Page.

Change-Id: Icbca23d3ec1dd95bbf703227b9479291a978a426
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159126
Tested-by: Jenkins
Reviewed-by: Balazs Varga 

diff --git a/sw/source/ui/config/optpage.cxx b/sw/source/ui/config/optpage.cxx
index b1f24d671a92..6fb499f455ad 100644
--- a/sw/source/ui/config/optpage.cxx
+++ b/sw/source/ui/config/optpage.cxx
@@ -51,6 +51,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -86,25 +87,40 @@ void drawRect(vcl::RenderContext& rRenderContext, const 
tools::Rectangle ,
 SwContentOptPage::SwContentOptPage(weld::Container* pPage, 
weld::DialogController* pController, const SfxItemSet& rCoreSet)
 : SfxTabPage(pPage, pController, "modules/swriter/ui/viewoptionspage.ui", 
"ViewOptionsPage", )
 , m_xCrossCB(m_xBuilder->weld_check_button("helplines"))
+, m_xCrossImg(m_xBuilder->weld_widget("lockhelplines"))
 , m_xHMetric(m_xBuilder->weld_combo_box("hrulercombobox"))
+, m_xHMetricImg(m_xBuilder->weld_widget("lockhruler"))
 , m_xVRulerCBox(m_xBuilder->weld_check_button("vruler"))
+, m_xVRulerImg(m_xBuilder->weld_widget("lockvruler"))
 , m_xVRulerRightCBox(m_xBuilder->weld_check_button("vrulerright"))
+, m_xVRulerRightImg(m_xBuilder->weld_widget("lockvrulerright"))
 , m_xVMetric(m_xBuilder->weld_combo_box("vrulercombobox"))
 , m_xSmoothCBox(m_xBuilder->weld_check_button("smoothscroll"))
+, m_xSmoothImg(m_xBuilder->weld_widget("locksmoothscroll"))
 , m_xGrfCB(m_xBuilder->weld_check_button("graphics"))
+, m_xGrfImg(m_xBuilder->weld_widget("lockgraphics"))
 , m_xTableCB(m_xBuilder->weld_check_button("tables"))
+, m_xTableImg(m_xBuilder->weld_widget("locktables"))
 , m_xDrwCB(m_xBuilder->weld_check_button("drawings"))
+, m_xDrwImg(m_xBuilder->weld_widget("lockdrawings"))
 , m_xPostItCB(m_xBuilder->weld_check_button("comments"))
+, m_xPostItImg(m_xBuilder->weld_widget("lockcomments"))
 , m_xSettingsFrame(m_xBuilder->weld_frame("settingsframe"))
 , m_xSettingsLabel(m_xBuilder->weld_label("settingslabel"))
 , m_xMetricLabel(m_xBuilder->weld_label("measureunitlabel"))
 , m_xMetricLB(m_xBuilder->weld_combo_box("measureunit"))
 , m_xShowInlineTooltips(m_xBuilder->weld_check_button("changestooltip"))
+, m_xShowInlineTooltipsImg(m_xBuilder->weld_widget("lockchangestooltip"))
 , 
m_xShowOutlineContentVisibilityButton(m_xBuilder->weld_check_button("outlinecontentvisibilitybutton"))
+, 
m_xShowOutlineContentVImg(m_xBuilder->weld_widget("lockoutlinecontentvisibility"))
 , 
m_xTreatSubOutlineLevelsAsContent(m_xBuilder->weld_check_button("suboutlinelevelsascontent"))
+, 
m_xTreatSubOutlineLevelsImg(m_xBuilder->weld_widget("locksuboutlinelevels"))
 , m_xShowChangesInMargin(m_xBuilder->weld_check_button("changesinmargin"))
+, m_xShowChangesInMarginImg(m_xBuilder->weld_widget("lockchangesinmargin"))
 , m_xFieldHiddenCB(m_xBuilder->weld_check_button("hiddentextfield"))
+, m_xFieldHiddenImg(m_xBuilder->weld_widget("lockhiddentextfield"))
 , m_xFieldHiddenParaCB(m_xBuilder->weld_check_button("hiddenparafield"))
+, m_xFieldHiddenParaImg(m_xBuilder->weld_widget("lockhiddenparafield"))
 {
 m_xShowOutlineContentVisibilityButton->connect_toggled(LINK(this, 
SwContentOptPage, ShowOutlineContentVisibilityButtonHdl));
 
@@ -187,25 +203,88 @@ static void lcl_SelectMetricLB(weld::ComboBox& rMetric, 
TypedWhichIdGetItemIfSet( FN_PARAM_ELEM , false );
 if(pElemAttr)
 {
+bReadOnly = 
officecfg::Office::Writer::Content::Display::Table::isReadOnly();
 m_xTableCB->set_active(pElemAttr->m_bTable);
+m_xTableCB->set_sensitive(!bReadOnly);
+m_xTableImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Content::Display::GraphicObject::isReadOnly();
 m_xGrfCB->set_active(pElemAttr->m_bGraphic);
+m_xGrfCB->set_sensitive(!bReadOnly);
+m_xGrfImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Content::Display::DrawingControl::isReadOnly();
 m_xDrwCB->set_active(pElemAttr->m_bDrawing);
+m_xDrwCB->set_sensitive(!bReadOnly);
+m_xDrwImg->set_visible(bReadOnly);
+
+bReadOnly = 
officecfg::Office::Writer::Content::Display::Note::isReadOnly();
 m_xPostItCB->set_active(pElemAttr->m_bNotes);
+m_xPostItCB->set_sensitive(!bReadOnly);

[Libreoffice-bugs] [Bug 158148] Libreoffice crashed writer and calc open

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158148

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Dieter  ---
(In reply to m.a.riosv from comment #1)
> Please test in safe mode, Menu/Help/Restart in Safe Mode

And also with actual version of LO (LO 7.6)
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - sc/source

2023-11-09 Thread Noel Grandin (via logerrit)
 sc/source/filter/xml/xmlcvali.cxx |   10 --
 sc/source/filter/xml/xmlstyli.cxx |4 ++--
 sc/source/filter/xml/xmlstyli.hxx |6 --
 3 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 38a4672bdb55314edc9ce2cd5224b879d8df007f
Author: Noel Grandin 
AuthorDate: Wed Nov 8 13:23:43 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 9 20:10:59 2023 +0100

loplugin:fieldcast in ScXMLContentValidationContext

Change-Id: I2a9138096c9e79381020eaddb75ddc1134201a95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159197
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/xml/xmlcvali.cxx 
b/sc/source/filter/xml/xmlcvali.cxx
index 6a5669b7866a..20b1f235fd17 100644
--- a/sc/source/filter/xml/xmlcvali.cxx
+++ b/sc/source/filter/xml/xmlcvali.cxx
@@ -49,7 +49,7 @@ class ScXMLContentValidationContext : public 
ScXMLImportContext
 bool   bDisplayHelp;
 bool   bDisplayError;
 
-SvXMLImportContextRef   xEventContext;
+rtl::Reference xEventContext;
 
 css::sheet::ValidationAlertStyle GetAlertStyle() const;
 void SetFormula( OUString& rFormula, OUString& rFormulaNmsp, 
FormulaGrammar::Grammar& reGrammar,
@@ -232,8 +232,8 @@ uno::Reference< xml::sax::XFastContextHandler > SAL_CALL 
ScXMLContentValidationC
 pContext = new ScXMLErrorMacroContext( GetScImport(), pAttribList, 
this);
 break;
 case XML_ELEMENT(OFFICE, XML_EVENT_LISTENERS):
-pContext = new XMLEventsImportContext( GetImport() );
-xEventContext = pContext;
+xEventContext = new XMLEventsImportContext( GetImport() );
+pContext = xEventContext.get();
 }
 
 return pContext;
@@ -357,10 +357,8 @@ void SAL_CALL 
ScXMLContentValidationContext::endFastElement( sal_Int32 /*nElemen
 // #i36650# event-listeners element moved up one level
 if (xEventContext.is())
 {
-XMLEventsImportContext* pEvents =
-static_cast(xEventContext.get());
 uno::Sequence aValues;
-pEvents->GetEventSequence( "OnError", aValues );
+xEventContext->GetEventSequence( "OnError", aValues );
 
 auto pValue = std::find_if(std::cbegin(aValues), std::cend(aValues),
 [](const beans::PropertyValue& rValue) {
commit f6370725d8a68645e82f16d61518fd2d400f148d
Author: Noel Grandin 
AuthorDate: Wed Nov 8 13:16:31 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 9 20:10:50 2023 +0100

loplugin:fieldcast in XMLTableStyleContext

Change-Id: I92b6bc3e765b19c9f250da43463aad253ba9347a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159196
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/xml/xmlstyli.cxx 
b/sc/source/filter/xml/xmlstyli.cxx
index 3d7d86488425..a607b013e9c7 100644
--- a/sc/source/filter/xml/xmlstyli.cxx
+++ b/sc/source/filter/xml/xmlstyli.cxx
@@ -426,7 +426,7 @@ void XMLTableStyleContext::SetAttribute( sal_Int32 nElement,
 
 
 XMLTableStyleContext::XMLTableStyleContext( ScXMLImport& rImport,
-SvXMLStylesContext& rStyles, XmlStyleFamily nFamily, bool 
bDefaultStyle ) :
+XMLTableStylesContext& rStyles, XmlStyleFamily nFamily, bool 
bDefaultStyle ) :
 XMLPropStyleContext( rImport, rStyles, nFamily, bDefaultStyle ),
 pStyles(),
 nNumberFormat(-1),
@@ -563,7 +563,7 @@ void XMLTableStyleContext::AddProperty(const sal_Int16 
nContextID, const uno::An
 XMLPropertyState* property = FindProperty(nContextID);
 if (property)
 property->mnIndex = -1; // #i46996# remove old property, so it isn't 
double
-sal_Int32 nIndex(static_cast(pStyles)->GetIndex(nContextID));
+sal_Int32 nIndex(pStyles->GetIndex(nContextID));
 OSL_ENSURE(nIndex != -1, "Property not found in Map");
 XMLPropertyState aPropState(nIndex, rValue);
 GetProperties().push_back(aPropState); // has to be inserted in a sort 
order later
diff --git a/sc/source/filter/xml/xmlstyli.hxx 
b/sc/source/filter/xml/xmlstyli.hxx
index 8101a72b1f7c..e977b84e0ec6 100644
--- a/sc/source/filter/xml/xmlstyli.hxx
+++ b/sc/source/filter/xml/xmlstyli.hxx
@@ -63,11 +63,13 @@ public:
 ::std::vector< XMLPropertyState >& rProperties, sal_Int32 
nStartIndex, sal_Int32 nEndIndex ) const override;
 };
 
+class XMLTableStylesContext;
+
 class XMLTableStyleContext : public XMLPropStyleContext
 {
 OUString sDataStyleName;
 OUString   sPageStyle;
-SvXMLStylesContext* pStyles;
+XMLTableStylesContext*  pStyles;
 sal_Int32   nNumberFormat;
 SCTAB   nLastSheet;
 boolbParentSet;
@@ -85,7 +87,7 @@ protected:
 public:
 
 XMLTableStyleContext( ScXMLImport& rImport,
-SvXMLStylesContext& rStyles, XmlStyleFamily nFamily, bool 
bDefaultStyle = false );
+XMLTableStylesContext& rStyles, XmlStyleFamily nFamily, bool 
bDefaultStyle = false 

[Libreoffice-commits] core.git: sw/uiconfig

2023-11-09 Thread Caolán McNamara (via logerrit)
 sw/uiconfig/swriter/ui/translationdialog.ui |   28 
 1 file changed, 4 insertions(+), 24 deletions(-)

New commits:
commit 3afdf59d7a13101de6b943efb3395e6fc406ab94
Author: Caolán McNamara 
AuthorDate: Thu Nov 9 14:37:25 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 9 20:03:49 2023 +0100

give the Language Selection dialog the usual spacings

Change-Id: I82dd94e0a0205bee2b6b2d0ef005f734d9d80f54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159220
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/uiconfig/swriter/ui/translationdialog.ui 
b/sw/uiconfig/swriter/ui/translationdialog.ui
index 2ffa83df4a0f..c520fd851921 100644
--- a/sw/uiconfig/swriter/ui/translationdialog.ui
+++ b/sw/uiconfig/swriter/ui/translationdialog.ui
@@ -15,7 +15,7 @@
   
 False
 vertical
-2
+12
 
   
 False
@@ -71,17 +71,18 @@
   
 
 
-  
+  
   
 True
 False
-5
+6
 
   
 True
 False
 start
 Select the target language for 
translation
+True
 combobox1
   
   
@@ -100,27 +101,6 @@
 1
   
 
-
-  
-
-
-  
-
-
-  
-
-
-  
-
-
-  
-
-
-  
-
-
-  
-
   
   
 False


[Libreoffice-bugs] [Bug 62179] SLIDESHOW: enhancement: start Presenter Console also with only one monitor with Alt+F5 (as Rehearse Timings)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62179

--- Comment #25 from Timur  ---
I checked 135089. It is an improvement, Console can be started more easy.
For some reason, Console starts when set to Windowed, but not when default set
to Full Screen. Window size and position are not remembered.
So we have 3 windows: preesntation file, presenting full screen and Console
limited to be windowed.

But that is not a full replacment for this bug :
"Start Presenter Console also with only one monitor with Alt+F5 (as Rehearse
Timings)"
For more reasons:
- current Rehearse Timings is inferior to Console and this of no use
- it is better to have shortcut, and Alt+F5 is known from MSO
- if this would work, presenting full screen would not be needed, so less
stress on a system

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158124] Holding down delete key doesn't work and causes crash

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158124

--- Comment #4 from ToanTran  ---
I'm also unable to reproduce it, I used both the Delete key on my MacBook and
the Backspace key on my external keyboard.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: reportdesign/source

2023-11-09 Thread Noel Grandin (via logerrit)
 reportdesign/source/filter/xml/xmlStyleImport.cxx |4 ++--
 reportdesign/source/filter/xml/xmlStyleImport.hxx |5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit fcfb7f65bfc507a6bffebea98a9e9bd281ad9dbb
Author: Noel Grandin 
AuthorDate: Wed Nov 8 13:35:20 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 9 19:04:18 2023 +0100

loplugin:fieldcast in rptxml::OControlStyleContext

Change-Id: I2609090c26a2d405aedcca57a67ec9c5c329e122
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159212
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/reportdesign/source/filter/xml/xmlStyleImport.cxx 
b/reportdesign/source/filter/xml/xmlStyleImport.cxx
index 595bd5506dca..4ccc672f97ca 100644
--- a/reportdesign/source/filter/xml/xmlStyleImport.cxx
+++ b/reportdesign/source/filter/xml/xmlStyleImport.cxx
@@ -67,7 +67,7 @@ public:
 }
 
 OControlStyleContext::OControlStyleContext( ORptFilter& rImport,
-SvXMLStylesContext& rStyles, XmlStyleFamily nFamily ) :
+OReportStylesContext& rStyles, XmlStyleFamily nFamily ) :
 XMLPropStyleContext( rImport, rStyles, nFamily, false/*bDefaultStyle*/ ),
 pStyles(),
 m_nNumberFormat(-1),
@@ -121,7 +121,7 @@ void OControlStyleContext::SetDefaults()
 
 void OControlStyleContext::AddProperty(const sal_Int16 nContextID, const 
uno::Any& rValue)
 {
-sal_Int32 nIndex(static_cast(pStyles)->GetIndex(nContextID));
+sal_Int32 nIndex(pStyles->GetIndex(nContextID));
 OSL_ENSURE(nIndex != -1, "Property not found in Map");
 XMLPropertyState aPropState(nIndex, rValue);
 GetProperties().push_back(aPropState); // has to be inserted in a sort 
order later
diff --git a/reportdesign/source/filter/xml/xmlStyleImport.hxx 
b/reportdesign/source/filter/xml/xmlStyleImport.hxx
index b51108fd5244..691b6d384160 100644
--- a/reportdesign/source/filter/xml/xmlStyleImport.hxx
+++ b/reportdesign/source/filter/xml/xmlStyleImport.hxx
@@ -27,11 +27,12 @@
 namespace rptxml
 {
 class ORptFilter;
+class OReportStylesContext;
 
 class OControlStyleContext : public XMLPropStyleContext
 {
 OUString m_sDataStyleName;
-SvXMLStylesContext* pStyles;
+OReportStylesContext*   pStyles;
 //  std::vectoraMaps;
 sal_Int32   m_nNumberFormat;
 ORptFilter& m_rImport;
@@ -46,7 +47,7 @@ namespace rptxml
 public:
 
 OControlStyleContext( ORptFilter& rImport,
-SvXMLStylesContext& rStyles, XmlStyleFamily nFamily );
+OReportStylesContext& rStyles, XmlStyleFamily nFamily );
 
 virtual ~OControlStyleContext() override;
 


[Libreoffice-bugs] [Bug 158149] I am unable to update LibreOffice

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158149

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Uninstall doesn't affect your working files, even the profile, it's not
removed.

But making a backup in other device(s) it's always a good idea.

>From where do you download the installation file?

If you need, you can download any version from:
https://downloadarchive.documentfoundation.org/libreoffice/old/?C=M;O=D

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158148] Libreoffice crashed writer and calc open

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158148

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Please test in safe mode, Menu/Help/Restart in Safe Mode

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158152] Make Presenter Console window be renamed from "file" to "Console: file"

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158152

Timur  changed:

   What|Removed |Added

Summary|Make Presenter Console  |Make Presenter Console
   |window be named as Console  |window be renamed from
   ||"file" to "Console: file"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158152] New: Make Presenter Console window be named as Console

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158152

Bug ID: 158152
   Summary: Make Presenter Console window be named as Console
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: easyHack
  Severity: enhancement
  Priority: low
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ti...@libreoffice.org
Blocks: 124438

Presenter Console window should be named "Console: file", similar as Presenting
window is named "Presenting: file".
Now Console window shows the same name as the file.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124438
[Bug 124438] [META] Presenter console bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124438

Timur  changed:

   What|Removed |Added

 Depends on||158152


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158152
[Bug 158152] Make Presenter Console window be named as Console
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151307] Mac Address Book ODB file causes crash in LO when contact data edited in Contacts.app(macOS)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151307

--- Comment #3 from kdub  ---
Hi Alex,

This could potentially be a ARM issue. I just tried doing the exact steps you
mentioned, and it worked fine for me with no crash.

Info:

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 12; OS: Mac OS X 13.5; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source

2023-11-09 Thread Mike Kaganski (via logerrit)
 sfx2/source/doc/docmacromode.cxx |   26 --
 1 file changed, 20 insertions(+), 6 deletions(-)

New commits:
commit 7a73eedf00541b5ba56b81e7d78faef4247f046f
Author: Mike Kaganski 
AuthorDate: Thu Nov 9 16:12:45 2023 +0300
Commit: Mike Kaganski 
CommitDate: Thu Nov 9 18:37:26 2023 +0100

Fix USE_CONFIG_APPROVE_CONFIRMATION and USE_CONFIG_REJECT_CONFIRMATION

They still showed UI in case of signed macros.
Two decisions were made, to improve security of 
USE_CONFIG_APPROVE_CONFIRMATION:
1. In case of High macro security mode, valid but untrusted certificate 
will be
   automatically rejected (because it is not safe to automatically add 
trusted
   certificates) - so in this mode, USE_CONFIG_APPROVE_CONFIRMATION is the 
same
   as USE_CONFIG_REJECT_CONFIRMATION;
2. In case of Medium macro security mode, valid but untrusted certificate 
will
   not automatically allow macros execution, but will proceed to the 
following
   checks - which on Windows will try to check the source's Security Zone, 
and
   may disallow macros based on that. Only after Security Zone check the 
macros
   will be automatically allowed.

Change-Id: I1a9c92c6b940b689599c5d106798ecfc691dad46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159214
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/doc/docmacromode.cxx b/sfx2/source/doc/docmacromode.cxx
index d64b0b60697f..4e9311593aed 100644
--- a/sfx2/source/doc/docmacromode.cxx
+++ b/sfx2/source/doc/docmacromode.cxx
@@ -213,9 +213,12 @@ namespace sfx2
 // should not ask any confirmations. FROM_LIST_AND_SIGNED_WARN 
should only allow
 // trusted signed macros at this point; so it may only ask for 
confirmation to add
 // certificates to trusted, and shouldn't show UI when trusted 
list is read-only.
-const bool bAllowUI = nMacroExecutionMode != 
MacroExecMode::FROM_LIST_AND_SIGNED_NO_WARN
- && (nMacroExecutionMode == 
MacroExecMode::ALWAYS_EXECUTE
- || 
!SvtSecurityOptions::IsReadOnly(SvtSecurityOptions::EOption::MacroTrustedAuthors));
+const bool bAllowUI
+= nMacroExecutionMode != 
MacroExecMode::FROM_LIST_AND_SIGNED_NO_WARN
+  && eAutoConfirm == eNoAutoConfirm
+  && (nMacroExecutionMode == MacroExecMode::ALWAYS_EXECUTE
+  || !SvtSecurityOptions::IsReadOnly(
+  
SvtSecurityOptions::EOption::MacroTrustedAuthors));
 const bool bHasTrustedMacroSignature = 
m_xData->m_rDocumentAccess.hasTrustedScriptingSignature(bAllowUI ? 
rxInteraction : nullptr);
 
 if (bHasTrustedMacroSignature)
@@ -227,9 +230,20 @@ namespace sfx2
|| nSignatureState == SignatureState::NOTVALIDATED )
 {
 // there is valid signature, but it is not from the 
trusted author
-// this case includes explicit reject from user in the UI 
in cases of
-// FROM_LIST_AND_SIGNED_WARN and ALWAYS_EXECUTE
-return disallowMacroExecution();
+if (eAutoConfirm == eAutoConfirmApprove
+&& nMacroExecutionMode == 
MacroExecMode::ALWAYS_EXECUTE)
+{
+// For ALWAYS_EXECUTE + eAutoConfirmApprove 
(USE_CONFIG_APPROVE_CONFIRMATION
+// in Medium security mode), do not approve it right 
here; let Security Zone
+// check below do its job first.
+}
+else
+{
+// All other cases of valid but untrusted signatures 
should result in denied
+// macros here. This includes explicit reject from 
user in the UI in cases
+// of FROM_LIST_AND_SIGNED_WARN and ALWAYS_EXECUTE
+return disallowMacroExecution();
+}
 }
 // Other values of nSignatureState would result in either 
rejected macros
 // (FROM_LIST_AND_SIGNED_*), or a confirmation.


[Libreoffice-bugs] [Bug 89887] FileOpen: Drawing is not visible in 2007 DOCX (opens OK if resaved in MSO)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89887

--- Comment #16 from Regina Henschel  ---
Created attachment 190772
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190772=edit
Screenshot from daily build

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89887] FileOpen: Drawing is not visible in 2007 DOCX (opens OK if resaved in MSO)

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89887

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #15 from Regina Henschel  ---
There are some problems with font size an word wrap, but the diagram is there
in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7ef3d937415185ef66e32dd3043783eddcd03db5
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157942] UI: Notes optional visible on mainview - UI ENHANCEMENT

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157942

kdub  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||kemaldon...@csumb.edu,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from kdub  ---
Hi st...@xoio.de,

I have attached the Design team to consider your suggestion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157942] UI: Notes optional visible on mainview - UI ENHANCEMENT

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157942

kdub  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||kemaldon...@csumb.edu,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from kdub  ---
Hi st...@xoio.de,

I have attached the Design team to consider your suggestion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158138] Form can not be closed

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158138

--- Comment #3 from Holger Hoffmann  ---
I have solved the issue by creating a copy of the database. With the new
database the form closes as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152247] Machine translation does not work with our own documentation guides

2023-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152247

Timur  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #13 from Timur  ---
Deepl is Experimental and I now see why. I set New.
I obsolete error to use, which should be bug 152706.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >