Re: [Libreoffice] Some more features

2010-10-07 Thread Cedric Bosdonnat
Hi Miklos, Michael, On Thu, 2010-10-07 at 16:10 +0200, Miklos Vajna wrote: I think Cedric will fix this - though if I should do it, please let me know. I just removed those files in sw/source/filter/rtf/. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo

Re: [Libreoffice] Compile fails on Ubuntu Lucid

2010-10-08 Thread Cedric Bosdonnat
Hello Jim, Thank you for trying to get started on LibreOffice build and development! On Fri, 2010-10-08 at 14:02 +, jim bobs wrote: ERROR: Product OpenOffice not defined in openoffice.lst in function: getproductblock when running bin/ooinstall -l

Re: [Libreoffice] coding style

2010-10-11 Thread Cedric Bosdonnat
Hi Prashant On Sun, 2010-10-10 at 21:21 +0530, Prashant Shah wrote: Do we have any official coding style ? I see a lot of messy code :) No, there is no coding style yet, but we will start to work on one soon (step by step). Regards, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] SAL_N_ELEMENTS, where?

2010-10-11 Thread Cedric Bosdonnat
On Sun, 2010-10-10 at 09:51 -0700, Kayo Hamid wrote: There are other places than writer, base, calc and impress repo? I'm not familiar with these many git repositories. All the git repos are in the clone folder. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org

[Libreoffice] IZ hack using GreaseMonkey

2010-10-12 Thread Cedric Bosdonnat
Hi all, The previous email may have been lost in the initial thread, so I'm reposting here. You can now see whether a bug in OpenOffice issuezilla has been fixed in LibreOffice very simply. Just install GreaseMonkey [0] on your beloved Firefox browser and then install the script [1] I cooked.

Re: [Libreoffice] [PATCH 1/1] Cleanup: remove bogus comments from inc directory

2010-10-13 Thread Cedric Bosdonnat
Hello Prashant, Thanks for the patch, I just pushed it. -- Cedric On Wed, 2010-10-13 at 10:32 +0530, Prashant Shah wrote: This patch removes bogus comments found in the inc directory including empty Beschreibung (translation: description) statements Signed-off-by: Prashant Shah

Re: [Libreoffice] [PATCH 1/2] Cleanup: remove bogus comments from unocore direcotry

2010-10-13 Thread Cedric Bosdonnat
Pushed that one too, thanks for it! On Wed, 2010-10-13 at 16:04 +0530, Prashant Shah wrote: This patch removes bogus comments found in the unocore direcotry including empty Beschreibung (translation: description) statements Signed-off-by: Prashant Shah pshah.mum...@gmail.com ---

Re: [Libreoffice] [PATCH 2/2] Cleanup: remove bogus comments from unocore directory

2010-10-13 Thread Cedric Bosdonnat
Pushed that one as well, many thanks! On Wed, 2010-10-13 at 16:05 +0530, Prashant Shah wrote: This patch removes bogus comments found in the unocore directory including empty Beschreibung (translation: description) statements Signed-off-by: Prashant Shah pshah.mum...@gmail.com ---

Re: [Libreoffice] [PATCH] A later change in download packets name.

2010-10-13 Thread Cedric Bosdonnat
Hi Giuseppe, The patch looks good to me, I pushed it. Thanks for your help. On Mon, 2010-10-11 at 19:57 +0200, Giuseppe Castagno wrote: Hi, the attached patch change the default name of downloadable packages, e.g. the one is used should a correct product name missing. See

[Libreoffice] Improving the build experience in rawbuild

2010-10-13 Thread Cedric Bosdonnat
Hi fellow developers, We improved our build process a lot since the LibreOffice creation, but there is still something I'ld like to improve. Developers should build in rawbuild in order to create patches (or commit directly) easily. The current build procedure described on the wiki and TDF

Re: [Libreoffice] Improving the build experience in rawbuild

2010-10-14 Thread Cedric Bosdonnat
Hi Christian, CC'ing the list as you apparently forgot to Reply All. On Thu, 2010-10-14 at 00:44 +0200, Christian Lohmaier wrote: The current build procedure described on the wiki and TDF website builds in build/libreoffice*. In order to change that, I'ld like to do the following: *

Re: [Libreoffice] Fix RTF export incorrect output with nested tables

2010-10-14 Thread Cedric Bosdonnat
Hi Miklos, On Thu, 2010-10-14 at 12:58 +0200, Miklos Vajna wrote: Hi Cedric, See attached patch, it fixes exporting the http://cgit.freedesktop.org/~vmiklos/ooo-gsoc/tree/writer/hallenverzeichnis_2003.odt?h=ooo-test-files test file - before the fix, only the first column was visible in

Re: [Libreoffice] [PATCH] RTF: fix non-text frames

2010-10-18 Thread Cedric Bosdonnat
Hi Miklos, it seems to be good, go ahead. On Mon, 2010-10-18 at 13:59 +0200, Miklos Vajna wrote: Hi Cedric, I'm attaching a patch that fixes a crash on non-text frames when exporting as RTF. A reproducer is here:

Re: [Libreoffice] [PATCH] tiny first patch - fix 32 bit overflow at compile

2010-10-26 Thread Cedric Bosdonnat
Hi Kevin, On Mon, 2010-10-25 at 13:44 -0400, Kevin Hunter wrote: For a project as large as LibreOffice, you may also more appreciate the use of an IDE (Integrated Development Environment). Eclipse is often touted to me, as is Geany, and KDevelop. Did you ever tried loading the sw module

Re: [Libreoffice] credits page is 403 access forbidden

2010-10-26 Thread Cedric Bosdonnat
Hi Sebastian, On Tue, 2010-10-26 at 11:41 +0200, Sebastian Spaeth wrote: Please put something like this in its place: http://sspaeth.de/uploads/tmp/index.html I'ld love to have at least the wiki authors in before making the official page live. (with or without graphs). I'ld prefer without

Re: [Libreoffice] [Patch] Moved wrappers for all debuginfo calls into the function itself

2010-10-27 Thread Cedric Bosdonnat
On Tue, 2010-10-26 at 14:32 -0700, Sean McMurray wrote: This patch is public domain. Does it mean LGPLv3+ / MPL as it's the prefered licence for LibreOffice? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer

Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces

2010-10-27 Thread Cedric Bosdonnat
Hi Mattias, On Wed, 2010-10-27 at 18:26 +1100, Mattias Johnsson wrote: Here are my patches for the easy hack / programming task Count characters without whitespace in the Writer statistics. Since it's something translators have apparently been asking for OO.org to have for eight years (see

Re: [Libreoffice] SW_DLLPUBLIC limitations ...

2010-10-27 Thread Cedric Bosdonnat
Hi Tor, Michael, I finally got it working with SAL_DLLPUBLIC_EXPORT as michael suggested. If there is any possible trouble, let me know ;) -- Cedric On Wed, 2010-10-27 at 07:21 -0600, Tor Lillqvist wrote: The question (for Tor) is - if we have a __declspec(dllexport) on two identical

Re: [Libreoffice] How to write debug output to console or file?

2010-10-29 Thread Cedric Bosdonnat
Hi Mattias, On Fri, 2010-10-29 at 15:49 +1100, Mattias Johnsson wrote: To help with debugging, it'd be very useful for me to be able to write out variable values from within the code. Writing to the console or a file would be fine. Writing to the console using fprintf of std:: is possible. I

Re: [Libreoffice] LibreOffice and Java

2010-11-02 Thread Cedric Bosdonnat
On Tue, 2010-11-02 at 12:47 +, Michael Meeks wrote: Quite; cf. such uncertainty - it probably makes considerable sense to look into a migration strategy from Java to (insert anything else). Some candidates might be python for the more scripty pieces (though I hate non-typed

Re: [Libreoffice] Styles and Formatting

2010-11-04 Thread Cedric Bosdonnat
Hi Cor, On Wed, 2010-11-03 at 20:17 +0100, Cor Nouws wrote: My experience with users is, that they are often overwhelmed by the number of available styles. So Hierarchical as default would not be my choice. Default is more then enough. Ok, then we need to fix that before pushing the patch.

Re: [Libreoffice] [PATCH] [PUSHED] Corrects problem in sysui while building current master

2010-11-04 Thread Cedric Bosdonnat
Hi Giuseppe, On Thu, 2010-11-04 at 13:18 +0100, Giuseppe Castagno wrote: Subject: [PATCH] Correct problem building menus for BrOffice Thanks for the patch, feel free to provide some others ;) I just pushed it to master branch. Regards, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] [PATCH] [PUSHED] configure.in: Cluster all extension related options at one place

2010-11-04 Thread Cedric Bosdonnat
Hi Sebastian, Thanks for the patch. I needed to massage it a bit to make it apply, but it works fine. I pushed it in master branch. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-04 Thread Cedric Bosdonnat
Hi Mattias, On Thu, 2010-11-04 at 23:38 +1100, Mattias Johnsson wrote: Patch attached. It's a very minimal change, so it's probably safe to push into the 3.3 branch as well as master. It seems that you forgot to actually attach the patch ;) Regards, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] [PATCH] [PUSHED] distro_config: adapt to new confgure options for extensions

2010-11-04 Thread Cedric Bosdonnat
On Thu, 2010-11-04 at 13:57 +0100, Sebastian Spaeth wrote: Some extensions options for configure were renamed to --enable-ext-* Adapt all distro configs to reflect that. Sorry for the churn. Thanks for the patch, I just pushed it. Regards, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-05 Thread Cedric Bosdonnat
Hi Mattias, On Fri, 2010-11-05 at 10:38 +1100, Mattias Johnsson wrote: There isn't a bug report in the LO tracker, but there are quite a few in the OO.o issue tracker. The basic issue number is 89042, with 97116, 102270, 107241, 113375, and 108072 marked as duplicates. Hum, I saw that one...

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Cedric Bosdonnat
On Fri, 2010-11-05 at 00:38 -0700, John LeMoyne Castle wrote: Dang, I was hoping it would stop counting at least some punctuation as a word.(period). Don't know what to say other than test before and after. Just some random thought here: would you be able to write some unit tests for this?

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Cedric Bosdonnat
Hi guys, I mistakenly pushed Mattias patch this morning... that shouldn't harm, but I though it would be good for you to know it for later investigations. On Sat, 2010-11-06 at 14:14 +1100, Mattias Johnsson wrote: On 6 November 2010 12:13, John LeMoyne Castle j...@mail2lee.com wrote: Hi

[Libreoffice] [UX] Some dirty stuffs around styles in calc

2010-12-01 Thread Cedric Bosdonnat
Hi all, The other day when playing with a calc document, I discovered an annoying feature. Create a new spreadsheet, protect one of the sheets and try to modify the cell styles: nothing shows up when clicking on the Modify... context menu. I had to run a debug session in sc to understand that

[Libreoffice] Fix for fdo#31190 to review for 3.3

2010-12-02 Thread Cedric Bosdonnat
Hi all, I've fixed fdo#31190, and it looks like something that could be integrated in 3.3 but before pushing to the branch, I'ld like to have some peer review. The patch is attached to the issue. https://bugs.freedesktop.org/show_bug.cgi?id=31190 Regards, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] Contributing test cases

2010-12-03 Thread Cedric Bosdonnat
Hi Michael, On Fri, 2010-12-03 at 11:57 +, Michael Meeks wrote: It failed after only a handful of documents on the attached with: #0 0xabd83b95 in writerfilter::dmapper::DomainMapper_Impl::finishParagraph(boost::shared_ptrwriterfilter::dmapper::PropertyMap) () from

Re: [Libreoffice] LibreOffice-Plug-In for Netbeans?

2010-12-06 Thread Cedric Bosdonnat
Hi Andreas, On Sat, 2010-12-04 at 17:13 +0100, Andreas Mantke wrote: there is already a Netbeans-Plug-In for OOo. But this plug-in doesn't work for me with LibreOffice and it's SDK. Because of this I'm curious, if someone is working on such a plug-in for LibreOffice. It's very unlikely

[Libreoffice] Review of fdo#32172 for 3.3 inclusion

2010-12-09 Thread Cedric Bosdonnat
Hi caolan, all, Could you please review the commit for this bug? https://bugs.freedesktop.org/show_bug.cgi?id=32172 It could be nice to have it in 3.3 as well... Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer

[Libreoffice] Any taker for a starmath bug?

2010-12-14 Thread Cedric Bosdonnat
Hello people, I know there are quite a few persons interested or knowing the starmath code... Is there any taker for this bug? https://bugs.freedesktop.org/show_bug.cgi?id=32362 Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer

Re: [Libreoffice] Need review of the ooo/OOO330_m18 changes

2010-12-15 Thread Cedric Bosdonnat
On Tue, 2010-12-14 at 21:19 +0100, Jan Holesovsky wrote: writer Done for the fix of i#115956. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Removing sw/source/filter/ww8/dump

2010-12-21 Thread Cedric Bosdonnat
Hi Caolan, others, I have wondered for a long time if sw/source/filter/ww8/dump is still used by someone... it doesn't even seems to be built. Would anyone oppose to this removal? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer

[Libreoffice] [REVIEW] Push patch to 3.3

2010-12-21 Thread Cedric Bosdonnat
Hi all, I have just finished a patch fixing a few enhanced fields issues like: * Not allowing to type before the field in protected mode * Import fields with 0-length content properly * Fix crash when exporting those imported fields The patch is sitting here:

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

2010-12-22 Thread Cedric Bosdonnat
Bonjour Guillaume, On Wed, 2010-12-22 at 11:47 +0100, Guillaume Poussel wrote: I use LibreOffice almost every day and I'm interested in Open Source softwares, so I would like to contribute. Then be welcomed among LibreOffice develers! I have grabbed the code and compile it. Then, i had a

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

2010-12-22 Thread Cedric Bosdonnat
Hello Guillaume, On Wed, 2010-12-22 at 17:53 +0100, Guillaume Poussel wrote: I was not sure about git diff or git format-patch. Next time it would be better :) Don't hesitate to join the IRC channel #libreoffice to raise questions like this: there are several git experts hanging there (maybe

Re: [Libreoffice] Styles cleanup removing option page std fonts

2011-10-19 Thread Cedric Bosdonnat
Hi Cor, On Tue, 2011-10-18 at 18:03 +0200, Cor Nouws wrote: Interest caught by your presentation in Paris, I saw your patch in cgit: 359d0fbd03a68d9131e8fb25e7dac9f19ddf6dcb I understand the idea to remove default paragraph styles such as list, list1, list1 cntd, list2 end etc etc But

Re: [Libreoffice] Styles cleanup removing option page std fonts

2011-10-20 Thread Cedric Bosdonnat
Hi Dag, On Wed, 2011-10-19 at 16:19 +0200, Dag Wieers wrote: (Maybe this was already discussed before.) It would be nice if the default template that ships with LibreOffice would ship with visually attractive styles, and paragraph styles for commonly used blocks or admonitions, eg.

Re: [Libreoffice] Styles cleanup removing option page std fonts

2011-10-20 Thread Cedric Bosdonnat
Hi Cor, On Wed, 2011-10-19 at 15:49 +0200, Cor Nouws wrote: In a not-so-far future, I'ld like to have this all configured through a default template instead of what we have... Ah, more new to come :-) Sure. and removing that option page is on the way to this goal. OK, thanks. I've

Re: [Libreoffice] Styles cleanup removing option page std fonts

2011-10-20 Thread Cedric Bosdonnat
On Thu, 2011-10-20 at 09:54 +0200, Cor Nouws wrote: Hi Cedric, The complex point isn't on the UX side now... the whole default styles thing is hard-coded ATM and uses some xcu configuration. I'll need to get rid of this before having a default template. And even when we'll be ready to

Re: [Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly

2011-10-26 Thread Cedric Bosdonnat
Hi Kohei, all, On Tue, 2011-10-25 at 09:46 -0400, Kohei Yoshida wrote: The patch looks safe to me. Cedric, if it's okay with you, I'd like to backport this to the 3.4 branch with my sign-off. What do you think? I'm all for it... I only don't have time these days as I'm attending/presenting

Re: [Libreoffice] TextSection, TextCursor and component

2011-11-14 Thread Cedric Bosdonnat
Hi Knut, On Mon, 2011-11-14 at 00:02 +0100, Knut Olav Bøhmer wrote: Is it allowed to insert a TextSection in to a document which was created from another document? Honnestly, I don't know what is allowed and what is not in that area. Clearly, this doesn't sound good and if you can insert a

Re: [Libreoffice] TextSection, TextCursor and component

2011-11-15 Thread Cedric Bosdonnat
Hi Knut, On Mon, 2011-11-14 at 17:26 +0100, Knut Olav Bøhmer wrote: The global factory can't create that service and the cursor / text range have no idea what document they're in... so I'ld say no. Would it be a good feature to let the cursor know which document their in? Well, if I was

Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-15 Thread Cedric Bosdonnat
Hello, On Sat, 2011-11-12 at 16:27 +0900, Tomofumi Yagi wrote: This patch will fix fdo#40831 Writer will crash when searching text with using regular expressions. Please review my attached patch. Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=40831 I reproduced this bug on LibO

Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

2011-11-17 Thread Cedric Bosdonnat
Hi Michael, On Wed, 2011-11-16 at 16:20 +0100, Michael Stahl wrote: now i remember: this bug is exactly the one i fixed in OOo in CWS sw34bf04 (issue i102333). the fix is not merged in libreoffice-3-4, but is in master (230fcf4a456636bb466f72834cd57238621d206d), but LO master still crashes

Re: [Libreoffice] need some explaination on formatclipboard.[hc]xx

2011-11-17 Thread Cedric Bosdonnat
Hi Maxime, On Wed, 2011-11-16 at 18:50 +0100, Maxime de Roucy wrote: I would like to understand how writer format paintbrush. I think it bug on some case and I would like to write a patch, but I am new at libreoffice developpement. I managed to locate via gdb the format paintbrush classe in

Re: [Libreoffice] [PATCH][PUSHED] Improved Header/Footer UI framerate

2011-11-21 Thread Cedric Bosdonnat
Hello Thomas, On Fri, 2011-11-18 at 20:22 +0100, Thomas Collerton wrote: Thanks for the reply :-) Sorry for the license, I meant MPL/LGPLv3+. I'm still a newbie to the coding world, and my C/C++ knowledge is still very basic, so for now I'd rather not be added to the developers' list. It was

Re: [Libreoffice] Eclipse: Libre Office integration help

2011-11-28 Thread Cedric Bosdonnat
Hello, On Sun, 2011-11-27 at 17:29 +0530, deenadayalan k wrote: Can anybody provide some information on how to integrate libre Office SDK source (LGPL license) in my own Eclipse RCP application? You asked me the same question privately and I see no reason to answer it privately. I worked on

Re: [Libreoffice] Eclipse: Libre Office integration help

2011-11-28 Thread Cedric Bosdonnat
Hi, On Mon, 2011-11-28 at 16:51 +0530, deenadayalan k wrote: Thanks for pointing to references (URL's). By the way I answered on the mailing-list, it's just because I don't want to hold such an interesting discussion privately. Please reply to the mailing-list too: this is archived and could

Re: [Libreoffice] SWT window locks LOo

2011-11-30 Thread Cedric Bosdonnat
Hi Othman, On Tue, 2011-11-29 at 10:48 -0800, othman wrote: after i close SWT browser window. i try oepn a new OO document and then OO crashes! SWT and Libreoffice on linux are very Problematic! they didn't proposed a fix to this bug since a very long time now! The best way to get things

Re: [Libreoffice] SWT window locks LOo

2011-11-30 Thread Cedric Bosdonnat
On Wed, 2011-11-30 at 02:13 -0800, othman wrote: The best way to get things done is to do them yourself. Feel free to start on that topic if it's really a blocker for you. if i knew how to fix it i wouldn't have asked in this forum. It's strange when you ask for help for a project people tell

Re: [Libreoffice] manipulating cursors/selections in writer with accessibility api's (bug 43390)

2011-12-19 Thread Cedric Bosdonnat
Hello Vincent, On Fri, 2011-12-16 at 18:24 -0600, Vincent Povirk wrote: I'm working for CodeWeavers on a project that uses accessibility API's (specifically at-spi 2) to manipulate text fields. I cannot publicly disclose the exact nature of this project before its release, though it may be

Re: [Libreoffice] [PATCH][PUSHED] Fix for fdo43460 Part XIII getLength() to isEmpty()

2011-12-21 Thread Cedric Bosdonnat
Hi Olivier, On Tue, 2011-12-20 at 20:52 -0200, Olivier Hallot wrote: Please find attached a partial fix for Easy Hack FDO43460 Part XIII Many thanks for the patch. I just pushed it to master. -- Cedric ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH][PUSHED] Fix for fdo43460 Part XII getLength() to isEmpty(

2011-12-21 Thread Cedric Bosdonnat
Hello Olivier, On Mon, 2011-12-19 at 18:13 -0200, Olivier Hallot wrote: Please find attached a partial fix for Easy Hack FDO43460 Part XII Many thanks for your patch! I fixed a typo in it, but pushed it. -- Cedric ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category

2011-12-21 Thread Cedric Bosdonnat
Hi August, All three of your patches have been pushed on master. Many thanks for these: don't hesitate to provide other nice patches ;) -- Cedric On Sun, 2011-12-18 at 14:39 -0500, August Sodora wrote: I split the work into three patches in case part of this needed to be rejected. The first

Re: [Libreoffice] [PATCH] [PUSHED] Update French dictionaries

2011-12-21 Thread Cedric Bosdonnat
Hello Olivier, On Tue, 2011-12-20 at 09:26 -0800, Olivier R. wrote: Sorry. Here is the patch: http://nabble.documentfoundation.org/file/n3601795/0001-Update-French-dictionaries.patch 0001-Update-French-dictionaries.patch Many thanks for your patch. It has been pushed to master and

Re: [Libreoffice] [MacOS] Horizontal cursor positioning in justified text

2011-12-22 Thread Cedric Bosdonnat
Hi James, On Thu, 2011-12-22 at 20:56 +1300, James C wrote: Justified text changes the kerning (space between letters) of words on a line. The cursor positioning in writer seems to assume, falsely, that all of the adjustment happens in the spaces between words. So the cursor ends up in the

Re: [Libreoffice] [REVIEW] invalid ODF fdo#37390 fdo#44073 fdo#44082

2011-12-23 Thread Cedric Bosdonnat
Hi Michael, On Fri, 2011-12-23 at 00:16 +0100, Michael Stahl wrote: proposing the following commits for 3.4.5, as they prevent LO from writing invalid ODF: http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1e1ef80e8428514499b061e00801a6a6298d0b0

Re: [Libreoffice] [Libreoffice-ux-advise] [REVIEW 3-5: Late feature] Improvements in the header / footer behavior

2012-01-02 Thread Cedric Bosdonnat
Hello everyone, Sorry for my lack of responsiveness... but I was on holidays last week. On Fri, 2011-12-30 at 18:18 +0100, Stefan Knorr (Astron) wrote: Yeah ;-) - it is hard to make everyone happy, though I am not that convinced that introducing one more option is the right solution.

Re: [Libreoffice] [REVIEW] fdo#40482 sw: view options changed by printing

2012-01-02 Thread Cedric Bosdonnat
On Thu, 2011-12-22 at 10:11 +, Caolán McNamara wrote: On Wed, 2011-12-21 at 17:11 +0100, Michael Stahl wrote: i'd like to have the fix for $SUBJECT in 3.4.5, it is a regression introduced in 3.4.2 or 3.4.3, am too lazy to check which.

Re: [Libreoffice] Cherry pick request: Fix always-false condition of FullCommentURL

2012-01-04 Thread Cedric Bosdonnat
Hi Harri, On Wed, 2012-01-04 at 18:23 +0200, Harri Pitkänen wrote: Release notes for 3.5 mention a new feature for grammar checker developers, the FullCommentURL property. I tried to use it but could not get any visible results with 3.5beta2. Then I looked at git history and noticed that the

Re: [Libreoffice] [Libreoffice-ux-advise] [REVIEW 3-5: Late feature] Improvements in the header / footer behavior

2012-01-05 Thread Cedric Bosdonnat
Hi Kendy all, On Thu, 2011-12-29 at 14:15 +0100, Jan Holesovsky wrote: I have been playing recently with the great new header / footer indicators, and there were 2 things that I considered suboptimal from the UX point of view: - Appearing / disappearing of the controls after 1 second I

Re: [Libreoffice] crasher in writer (footer)

2012-01-12 Thread Cedric Bosdonnat
Hi Michael, On Tue, 2012-01-10 at 22:28 +0100, Michael Stahl wrote: should be fixed now on master and libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e898354fc76339a9a007b30f1ebe123981d0426

[Libreoffice] [REVIEW][3.5] Writer layout fix for fdo#40438

2012-01-13 Thread Cedric Bosdonnat
Hi all, Could some of the other Writer gurus have a look at this patch: it should fix the crasher though it may not be perfect. I'ld prefer a peer review before cherry-picking it to 3.5 http://cgit.freedesktop.org/libreoffice/core/commit/?id=d83488 Thanks, -- Cedric

[Libreoffice] [REVIEW][3.4.x]fdo#38515 annoying crasher fix

2012-01-13 Thread Cedric Bosdonnat
Hello people, Could someone review / cherry-pick this patch for the 3.4.x branches? http://cgit.freedesktop.org/libreoffice/core/commit/?id=4914b23e7e91b184d69eb00a74ce1c463c5754a7 Thanks, -- Cedric ___ LibreOffice mailing list

Re: [Libreoffice] [PUSHED] Re: [REVIEW][3.5] Writer layout fix for fdo#40438

2012-01-18 Thread Cedric Bosdonnat
Hi Michael, On Tue, 2012-01-17 at 22:23 +0100, Michael Stahl wrote: On 13/01/12 18:07, Cedric Bosdonnat wrote: Hi all, Could some of the other Writer gurus have a look at this patch: it should fix the crasher though it may not be perfect. I'ld prefer a peer review before cherry

[Libreoffice] [REVIEW] Fixing page break button flickering

2012-01-20 Thread Cedric Bosdonnat
Hi all, Moving the mouse over the page break line simply makes the button flicker... it's then not possible to see or click on it. The bug has only been reported on this list and ux-advise. This is caused by the following commit:

Re: [Libreoffice] [REVIEW] Fix RTF import of dotted and word underline

2012-01-20 Thread Cedric Bosdonnat
Hi Miklos, Your patch is OK for me. I just cherry-picked it and pushed it. -- Cedric On Fri, 2012-01-20 at 01:40 +0100, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=370fc96b92e59d35c2eb2e14fd77eb14bfc72fd4 Could somebody sign-off and push to -3-5,

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Cedric Bosdonnat
On Mon, 2012-01-23 at 06:29 +0100, Jean-Baptiste Faure wrote: Hi all, In LO 3.4.5 and LO 3.5.0 rc1+ we have a weird shortcut key in Writer in the menu Edit Repeat. It is the word Encore. We have that for the UI in French and even for the UI in English. This shortcut key Encore is in Tools

Re: [Libreoffice] Replacement table enhancement for Braille table

2011-01-03 Thread Cedric Bosdonnat
Hello Sophie, On Tue, 2010-12-28 at 17:12 +0300, Sophie Gautier wrote: Now would it be possible to enhance the replacement table so that we can execute the pattern *oe* to be replaced by the pattern *oeu* in each word containing this first pattern, that could be at the beginning of the

Re: [Libreoffice] Annoying cursor behavior on sw tables

2011-01-03 Thread Cedric Bosdonnat
Hi Octavio, On Wed, 2010-12-29 at 20:58 -0800, Octavio Alvarez wrote: Now, look at this, this blog post documents the patch: :-O http://cedric.bosdonnat.free.fr/wordpress/?p=472 Hum, thanks for poking me on it... I would have skipped the thread otherwise. The thing is that

[Libreoffice] unopkg --suppress-license

2011-01-04 Thread Cedric Bosdonnat
Hello hackers, I would like to make the --suppress-license option of unopkg skip the license in all cases instead of depending on what is in the extension's description.xml //simple-licen...@suppress-if-required].

Re: [Libreoffice] [REVIEW] unopkg --suppress-license

2011-01-05 Thread Cedric Bosdonnat
Hello Kohei, others, I have created a bug report for this (fdo#32840)... and fixed it in master branch. Could someone review it for a possible integration in 3.3 ? Regards, -- Cedric On Tue, 2011-01-04 at 16:09 -0500, Kohei Yoshida wrote: On Tue, 2011-01-04 at 22:04 +0100, Cedric Bosdonnat

Re: [Libreoffice] [PATCH] set RPATH correctly in the internal ICU

2011-01-06 Thread Cedric Bosdonnat
Hi Petr, At first glance it looks OK to me, but I'm no build script expert... I may have missed some important stuffs. -- Cedric On Wed, 2011-01-05 at 20:22 +0100, Petr Mladek wrote: Hi, our build service found broken RPATH in libicudata.so.42.1; it is fixed by the attached patch

Re: [Libreoffice] [PATCH] [PUSHED] Re: Annoying cursor behavior on sw tables

2011-01-06 Thread Cedric Bosdonnat
, On Mon, 2011-01-03 at 09:00 -0800, Octavio Alvarez wrote: On Mon, 03 Jan 2011 01:52:01 -0800, Cedric Bosdonnat cbosdon...@novell.com wrote: The thing is that Window::Invalidate() gets called if I move or if I type inside a table cell, which almost any key triggers, which is wrong

[Libreoffice] Review request

2011-01-11 Thread Cedric Bosdonnat
Hello, I'ld like to get a crasher fix around the enhanced fields into libreoffice-3-3 branch... Could anyone review and cherry-pick this commit? http://cgit.freedesktop.org/libreoffice/writer/commit/?id=0921bd5dc88dfd212fc5a332e0902347377be119 Thanks, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

2011-01-25 Thread Cedric Bosdonnat
Hi David, What's the status of this patch? pushed or needs some tweaks? -- Cedric On Fri, 2011-01-21 at 09:39 +0100, David Tardon wrote: On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote: On Sat, Jan 15, 2011 at 08:00:05PM +, Caolán McNamara wrote: On Sat, 2011-01-15

Re: [Libreoffice] [PATCH][PUSHED] ure: Some fixes to documentation (part 2)

2011-01-27 Thread Cedric Bosdonnat
Hello Aurimas, I just pushed your patch to the master branch. Thank you so much for all those IDL references fixes :) Feel free to continue providing patches like this one! On Tue, 2011-01-25 at 20:27 +0200, Aurimas Fišeras wrote: Affected folders: offapi/com/sun/star/form -

Re: [Libreoffice] [PATCH] Rename Default Formatting -- Clear Direct Formatting

2011-01-27 Thread Cedric Bosdonnat
Hello Octavio, Many thanks for those changes. I've pushed them in the master branch. Feel free to continue improving Writer like that :) On Fri, 2011-01-21 at 15:09 -0800, Octavio Alvarez wrote: Hi. The purpose of the following set of patches is to rename Default Formatting to Clear Default

Re: [Libreoffice] [PATCH] removed some bogus comments

2011-01-27 Thread Cedric Bosdonnat
Hello Suguru, First, many thanks for your patch! On Thu, 2011-01-27 at 01:43 +0900, suguru hirahara wrote: I made a patch file. Please notice me if there's any mistake. Well, you removed entirely some comments containing references to some public bug reports (they look like #i12345#). In this

Re: [Libreoffice] SCID_NEWDOCUMENT

2011-01-31 Thread Cedric Bosdonnat
On Fri, 2011-01-28 at 21:22 +, Nigel Hawkins wrote: On Fri, 2011-01-28 at 21:59 +0100, Christina Roßmanith wrote: I'm still translating comments and came across a constant named SCID_NEWDOCUMENT. When I asked opengrok the only place where this constant was found was the file rechead.hxx

Re: [Libreoffice] [PATCH] Commented out some unused functions in calc

2011-01-31 Thread Cedric Bosdonnat
Hi Alfonso, On Sat, 2011-01-29 at 15:10 +, Alfonso Eusebio wrote: Hi, I've been going through the list of identified unused functions in calc and commenting out those that don't seem to be used anywhere. Why don't you simply remove them and check if it still builds? Regards, --

Re: [Libreoffice] [PATCH] added translation to description.xml

2011-01-31 Thread Cedric Bosdonnat
On Sat, 2011-01-29 at 20:05 -0400, Clio wrote: added Russian translation to dictionaries/ru_RU/description.xml Many thanks for your patch, I just pushed it. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer

Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/core/access

2011-01-31 Thread Cedric Bosdonnat
On Sun, 2011-01-30 at 04:22 +0900, Suguru Hirahara wrote: under LGPLv3+ / MPL. Pushed, but please pay attention to: * Avoid breaking the build with ill-formed comments * Provide several patches changing twice the same things in the same files but not 100% exactly in the same way. I had to

Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/filter

2011-01-31 Thread Cedric Bosdonnat
On Sun, 2011-01-30 at 01:54 +0900, Suguru Hirahara wrote: Hello, here's another patch. This one is also related with bogus comments. Pushed as well -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr

Re: [Libreoffice] (no subject)

2011-01-31 Thread Cedric Bosdonnat
Hello Antoine, Thanks for your patch. I just pushed it. Feel free to provide other patches like this one. BTW, you didn't mention anything, I supposed you were agreeing to provide the patch under LGPLv3+ / MPL... is that OK? Regards, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] [PATCH] [PUSHED] Remove unused files

2011-01-31 Thread Cedric Bosdonnat
Hello Kurosawa-san, On Mon, 2011-01-31 at 16:53 +0900, KUROSAWA, Takeshi wrote: Hi, I found some unused files in libs-gui/sv-tools/ and filters/binfilter/. Actually they are not compiled. Attached patches remove them. Many thanks for your patches. I just pushed them. I compiled them and it

Re: [Libreoffice] [PATCH] Replaced tools/list with std::list in ScAddInListener

2011-01-31 Thread Cedric Bosdonnat
Hello Soeren and Thies, On Sat, 2011-01-29 at 18:04 +0100, Soeren Moeller wrote: Now we have replaced tools/list with std::list in ScAddInListener, here we used a list, as there is adding, removing, and searching on this list, and no clear way to sort the elements. The patch comes in three

[Libreoffice] [REVIEW] Fix for bug n#664516

2011-02-01 Thread Cedric Bosdonnat
Hi all, I have just fixed the bug n#664516, around the new writer table formulas and would like to integrate it in 3.3 branch. This bug only affects the distributions adding the patches/dev300/fields-table-formula.diff The fix to push is on master, could anyone review it?

Re: [Libreoffice] [REVIEWED] Fix for bug n#664516

2011-02-01 Thread Cedric Bosdonnat
Hello Michael, On Tue, 2011-02-01 at 13:57 +, Michael Meeks wrote: On Tue, 2011-02-01 at 14:27 +0100, Cedric Bosdonnat wrote: I have just fixed the bug n#664516, around the new writer table formulas and would like to integrate it in 3.3 branch. This bug only affects the distributions

Re: [Libreoffice] Remove old Word 6.0/95 save as support

2011-02-02 Thread Cedric Bosdonnat
Hi Bryan, On Wed, 2011-02-02 at 00:06 -0500, Bryan Quigley wrote: I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: Word 6.0 Word 95 Excel 5.0 Excel 95 I would be all for it too... it's even an easy hack you could achieve.

Re: [Libreoffice] Usability issue: no way to rotate an image on a frame

2011-02-03 Thread Cedric Bosdonnat
Hello Joshua, On Fri, 2011-02-04 at 00:58 -0600, Joshua Ismael wrote: I have to rotate an image but there's no way to do it, at least not an obvious way: You probably mean you can't do it in Writer, right? In that case this is a known and old issue... thought it's no easy thing to hack.

Re: [Libreoffice] HTML formatting in comments?

2011-02-03 Thread Cedric Bosdonnat
Hi Thomas, On Thu, 2011-02-03 at 18:07 +0100, Thomas Arnhold wrote: Ok, didn't know, that idl files get handled another way. How do we clearly identify IDL and related files, which shouldn't be handled by doxygen?! Are these only files with the idl extension? And is the doxygen documentation

[Libreoffice] [REVIEW] fix for fontwork toolbar

2011-02-04 Thread Cedric Bosdonnat
Hi all, Could anyone review the fix for this quite annoying bug? https://bugs.freedesktop.org/show_bug.cgi?id=32872 The fix has been pushed to master as commit: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=05ef821abdff1ec4712cd4b054a21e4180b2298f It would be nice to have that in

[Libreoffice] [REVIEW] ugly diplay of toolbar menus in fontwork toolbar

2011-02-07 Thread Cedric Bosdonnat
Hello people, Since I fixed the toolbar menus on the fontwork toolbar, I saw that one of them as pretty badly shaped. The spacing menu was writing the text of the items over the controls that were supposed to be displayed on the left of it. Could anyone review this commit, sign it off and

[Libreoffice] [REVIEW] BorderLine fix

2011-02-08 Thread Cedric Bosdonnat
Hello fellow hackers, David fixed the BorderLine API problem a while ago with this commit http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d in master. I reviewed it and would be ok to cherry-pick it into 3.3.1 branch. Could anybody else review

Re: [Libreoffice] [REVIEW] lp#696527 enabling Human icons theme in 3.3 branch

2011-02-08 Thread Cedric Bosdonnat
Hi Bjoern, ok for me for 3.3.1 -- Cedric On Tue, 2011-02-08 at 15:54 +0100, Bjoern Michaelsen wrote: Hi all, on the master branch I already commited: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=f6a16194d1348cb1c679acec5cd9e014ca3f3104

  1   2   3   4   5   >