Re: [Libreoffice] HTML formatting in comments?
Hi Thomas, On Thu, 2011-02-03 at 18:07 +0100, Thomas Arnhold wrote: Ok, didn't know, that idl files get handled another way. How do we clearly identify IDL and related files, which shouldn't be handled by doxygen?! Are these only files with the idl extension? And is the doxygen documentation complete without these files? IMHO the files that should use that custom markup should only be the *.idl files (mostly located in the offapi module). I would say that all use of that markup in hxx files should be banned / changed. I know that some files are using it to produce the doc linked here on OOo website: http://api.openoffice.org/docs/cpp/ref/names/index.html As an simple alternative we could define aliases for TRUE/FALSE and so on with doxygen, say it replaces TRUE/ with TRUE. Well, a simple script that spots all the occurences of these tags in C++ would help as well. It could at least show us the files containing comments to switch to Doxygen documentation style. Then sed is your friend for this kind of boring job :) -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove old Word 6.0/95 save as support
Hi Bryan, On Wed, 2011-02-02 at 00:06 -0500, Bryan Quigley wrote: I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: Word 6.0 Word 95 Excel 5.0 Excel 95 I would be all for it too... it's even an easy hack you could achieve. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Fix for bug n#664516
Hi all, I have just fixed the bug n#664516, around the new writer table formulas and would like to integrate it in 3.3 branch. This bug only affects the distributions adding the patches/dev300/fields-table-formula.diff The fix to push is on master, could anyone review it? http://cgit.freedesktop.org/libreoffice/build/commit/?id=1bdae011acbbd886e6d13a8e45ab908d8e8c8296 Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] Fix for bug n#664516
Hello Michael, On Tue, 2011-02-01 at 13:57 +, Michael Meeks wrote: On Tue, 2011-02-01 at 14:27 +0100, Cedric Bosdonnat wrote: I have just fixed the bug n#664516, around the new writer table formulas and would like to integrate it in 3.3 branch. This bug only affects the distributions adding the patches/dev300/fields-table-formula.diff The fix to push is on master, could anyone review it? http://cgit.freedesktop.org/libreoffice/build/commit/?id=1bdae011acbbd886e6d13a8e45ab908d8e8c8296 Looks fine to me; and as you say a minority problem; can you cherry pick it ? Thanks for the review. I have cherry-picked it then. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SCID_NEWDOCUMENT
On Fri, 2011-01-28 at 21:22 +, Nigel Hawkins wrote: On Fri, 2011-01-28 at 21:59 +0100, Christina Roßmanith wrote: I'm still translating comments and came across a constant named SCID_NEWDOCUMENT. When I asked opengrok the only place where this constant was found was the file rechead.hxx itself. Does that mean that the constant can be removed (and probably a lot of similar constants too)? As I discovered earlier today, opengrok doesn't index binfilter. So it might get used in there (though if it does, it may well duplicate the definition there). Kohei suggested using git grep (or g grep) to look for it instead. He binfilter is skipped for the simple reason that it generates quite a lot of noise in general when you look for code bits as almost everything there is a copy. I don't know if any other modules are skipped by opengrok. No, no other module is skipped. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Commented out some unused functions in calc
Hi Alfonso, On Sat, 2011-01-29 at 15:10 +, Alfonso Eusebio wrote: Hi, I've been going through the list of identified unused functions in calc and commenting out those that don't seem to be used anywhere. Why don't you simply remove them and check if it still builds? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] added translation to description.xml
On Sat, 2011-01-29 at 20:05 -0400, Clio wrote: added Russian translation to dictionaries/ru_RU/description.xml Many thanks for your patch, I just pushed it. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/core/access
On Sun, 2011-01-30 at 04:22 +0900, Suguru Hirahara wrote: under LGPLv3+ / MPL. Pushed, but please pay attention to: * Avoid breaking the build with ill-formed comments * Provide several patches changing twice the same things in the same files but not 100% exactly in the same way. I had to massage your patches to make all three of them apply. For your information, you should simply run git commit on your local copy and when you want to provide the patches, run git format-patch -nb-commits. Many thanks for your patches, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/filter
On Sun, 2011-01-30 at 01:54 +0900, Suguru Hirahara wrote: Hello, here's another patch. This one is also related with bogus comments. Pushed as well -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] (no subject)
Hello Antoine, Thanks for your patch. I just pushed it. Feel free to provide other patches like this one. BTW, you didn't mention anything, I supposed you were agreeing to provide the patch under LGPLv3+ / MPL... is that OK? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove unused files
Hello Kurosawa-san, On Mon, 2011-01-31 at 16:53 +0900, KUROSAWA, Takeshi wrote: Hi, I found some unused files in libs-gui/sv-tools/ and filters/binfilter/. Actually they are not compiled. Attached patches remove them. Many thanks for your patches. I just pushed them. I compiled them and it went nicely. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Replaced tools/list with std::list in ScAddInListener
Hello Soeren and Thies, On Sat, 2011-01-29 at 18:04 +0100, Soeren Moeller wrote: Now we have replaced tools/list with std::list in ScAddInListener, here we used a list, as there is adding, removing, and searching on this list, and no clear way to sort the elements. The patch comes in three files: 0001 Replacing deprecated data types from solar.h 0002 Cleaning up the spacings 0003 Replacing tools/list with std::list and a non-related 4th file: 0004 Removing unnecessary include of tools/string in funcdesc.hxx Many thanks for the patches. I've just pushed them. Keep providing nice patches like these with alternating names ;) Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] ure: Some fixes to documentation (part 2)
Hello Aurimas,
I just pushed your patch to the master branch. Thank you so much for all
those IDL references fixes :) Feel free to continue providing patches
like this one!
On Tue, 2011-01-25 at 20:27 +0200, Aurimas Fišeras wrote:
Affected folders:
offapi/com/sun/star/form - offapi/com/sun/star/linguistic2
Fixes many spelling errors (checked with en_US spell checker).
Unifies spelling of some common words.
Replaces single quotes ('') with double quotes ().
Fixes several other errors.
Patch is contributed under the LGPLv3+.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Rename Default Formatting -- Clear Direct Formatting
Hello Octavio, Many thanks for those changes. I've pushed them in the master branch. Feel free to continue improving Writer like that :) On Fri, 2011-01-21 at 15:09 -0800, Octavio Alvarez wrote: Hi. The purpose of the following set of patches is to rename Default Formatting to Clear Default Formatting across all the suite. The goal is to clarify what this function currently does and should do. The current situation is that everybody has its own interpretation of this, mainly because Default Style and Default Format are different things and neither of them mean clear direct formatting. This mess doesn't help us have a common ground for decision taking. Even the specification[1] behind it is ambiguous. After a bit of analysis, I found that formatting applied over styles is uniformly called direct throughout the help but some code still talk about hard format. This should allow us to have a common ground for this. Should another resetting-specific need arise, then it will clearly be an enhancement request. Should a function do anything different than just clear direct formatting it will clearly be bug. I hope the user to benefit too, as the new name better answers the question what does this do: it clears direct formatting. The patches rename all existing instances of Default Formatting to Clear Direct Formatting, including menus and help texts. Search was done using ./g grep and replacement was made by hand. Some instances were not changed. For example, there was uno:ResetAttrs and uno:SetDefault, which obviously refer to different things. uno:SetDefault was left alone. The set of patches apply to different repositories. In the upcoming days I will include another set of patches to rename Clear formatting, which removes direct and sets default style, to Clear all formatting (I'm not so convinced about the phrasing, but that was the best+shortest text I could come up with). This should clarify it even more. I request for comments. There are still other instances of Default Formatting that should be renamed to Apply Default Style, but I can't find it as a user, so I'll wait for this. [1] http://specs.openoffice.org/writer/formatting/Assigning_Styles_in_Writer.sxw ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] removed some bogus comments
Hello Suguru, First, many thanks for your patch! On Thu, 2011-01-27 at 01:43 +0900, suguru hirahara wrote: I made a patch file. Please notice me if there's any mistake. Well, you removed entirely some comments containing references to some public bug reports (they look like #i12345#). In this case we want to keep them to keep a history. For example in comments like // -- OD 2005-12-12 #i27301# - use new type definition for _nStates you keep: // #i27301# - use new type definition for _nStates Could you please amend your patches to take this comment into account? -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit
Hi David, What's the status of this patch? pushed or needs some tweaks? -- Cedric On Fri, 2011-01-21 at 09:39 +0100, David Tardon wrote: On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote: On Sat, Jan 15, 2011 at 08:00:05PM +, Caolán McNamara wrote: On Sat, 2011-01-15 at 05:59 +0100, Lionel Elie Mamane wrote: Does not fit release blocker criteria, but would still be *very* nice to have for the release, as it easily fixes / papers over a rather annoying / stupid (from the user's point of view) bug: I pushed this to master and to the stable 3-3 branch, thanks for this. FYI, the OpenOffice.org side fixed this in a way that seems more robust to eventual future changes; you might want to push that way into at least master (IMHO maybe not stable 3-3 branch, probably not 3-3-0). OTOH, if that's the robust way, why is it not the idiom to get the value *everywhere*? I mean, why not replace *all* the xProp-setPropertyValue(FOO, uno::makeAny(static_castBAR*(BAZ)-QUX())); by It is robust in the sense that SvxLRSpaceItem::QueryValue already performs cast to sal_Int32 if MID_L_MARGIN of MID_R_MARGIN member is requested. QueryValue is the generic way to get stuff from items. The accessor functions are there for convenience. static_castconst BAR*(BAZ)-QueryValue(aValue,QUUX); Of course, the static_cast is superfluous there... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] css::table::BorderLine vs BorderLine2
Hello, - David Tardon dtar...@redhat.com a écrit : Yes, but css::table::BorderLine is used by css::table::TableBorder. Hum, I wanted to change that css::table::TableBorder type to use the new BorderLine2... but as it's published I couldn't change it. Do you have any idea how to do it better? I noticed a missing color borders of a table in a docx file. Debugging this lead to an exception in SwXCell::setPropertyValue for property LeftBorder, caused by the fact that the value was of type css::table::BorderLine. I further tracked this to writerfilter::dmapper::DomainMapperTableHandler::endTableGetTableStyle, where css::table::TableBorder's members (of type css::table::BorderLine, not BorderLine2) were used as an intermediary for the property values (incidentally, I forgot to push that part of the fix...) Thanks for the help, I'll try to have a look at it soon to fix that BorderLine use. Regards, -- Cédric Bosdonnat OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Review request
Hello, I'ld like to get a crasher fix around the enhanced fields into libreoffice-3-3 branch... Could anyone review and cherry-pick this commit? http://cgit.freedesktop.org/libreoffice/writer/commit/?id=0921bd5dc88dfd212fc5a332e0902347377be119 Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] set RPATH correctly in the internal ICU
Hi Petr, At first glance it looks OK to me, but I'm no build script expert... I may have missed some important stuffs. -- Cedric On Wed, 2011-01-05 at 20:22 +0100, Petr Mladek wrote: Hi, our build service found broken RPATH in libicudata.so.42.1; it is fixed by the attached patch Cedric, could you please sign it off for libreoffice-3-3. It works well on Linux with bash. I think that it can't be worse on other systems ;-) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Re: Annoying cursor behavior on sw tables
Hello Octavio, I just checked again the problem I remembered and couldn't reproduce it again... let's agree that it's OK. We could hack that area again if someone finds it again later. I just pushed your patch, many thanks for your help and continue with those great contributions :) Regards, On Mon, 2011-01-03 at 09:00 -0800, Octavio Alvarez wrote: On Mon, 03 Jan 2011 01:52:01 -0800, Cedric Bosdonnat cbosdon...@novell.com wrote: The thing is that Window::Invalidate() gets called if I move or if I type inside a table cell, which almost any key triggers, which is wrong. bUpdatedTable gets set to True inside SwCallLink::~SwCallLink() after some tests. Another option would be to correct those tests, but that would be far beyond my knowledge. The problem I tried to fix was that the whole row wasn't redrawn in some cases... I can't remember those for sure now but it was something like that: Make sure to have tables like this: +-+---+ |+---+| | || || | |+---+| | | | | +-+---+ Place your cursor in the right cell and go to the left: the cursor should go in the blank paragraph after the nested cell and show it. In that kind of cases some part of the border of the right cell wasn't redrawn IIRC. Did you test with a case similar to the one above? Well, I did try several different combinations including different column sizes and nesting levels. The case you point out was also tested and I just retested it now. It works. I would say it performs better. In the patch included I also remove all uses and declaration of bUpdatedTable because it was only used on the removed if(). -- Octavio. Twitter: @alvarezp2000 -- Identi.ca: @alvarezp -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] unopkg --suppress-license
Hello Kohei, others, I have created a bug report for this (fdo#32840)... and fixed it in master branch. Could someone review it for a possible integration in 3.3 ? Regards, -- Cedric On Tue, 2011-01-04 at 16:09 -0500, Kohei Yoshida wrote: On Tue, 2011-01-04 at 22:04 +0100, Cedric Bosdonnat wrote: Hello hackers, I would like to make the --suppress-license option of unopkg skip the license in all cases instead of depending on what is in the extension's description.xml //simple-licen...@suppress-if-required]. http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Description_of_XML_Elements#Element_.2Fdescription.2Fregistration.2Fsimple-license According to this wiki page, this feature has been introduced in OOo 3.3... which isn't released yet. Do you have any strong opinion against that? I would need this kind of unconditional skip to run unopkg from within ooeclipse... where people should develop their extensions and know the license ;) IMO the principle of lease surprise dictates that, when given --suppress-license, it should suppress license unconditionally no matter what some file in undisclosed location has in it. So, I'm with you on that. Kohei -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] unopkg --suppress-license
Hello hackers, I would like to make the --suppress-license option of unopkg skip the license in all cases instead of depending on what is in the extension's description.xml //simple-licen...@suppress-if-required]. http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Description_of_XML_Elements#Element_.2Fdescription.2Fregistration.2Fsimple-license According to this wiki page, this feature has been introduced in OOo 3.3... which isn't released yet. Do you have any strong opinion against that? I would need this kind of unconditional skip to run unopkg from within ooeclipse... where people should develop their extensions and know the license ;) Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Replacement table enhancement for Braille table
Hello Sophie, On Tue, 2010-12-28 at 17:12 +0300, Sophie Gautier wrote: Now would it be possible to enhance the replacement table so that we can execute the pattern *oe* to be replaced by the pattern *oeu* in each word containing this first pattern, that could be at the beginning of the word like in oeuf or in the middle like in boeuf. Well, we may have some performance issues trying to match a pattern or regexp against every single word... but that could be interesting to do: this could even be an easy hack. The same for the end of a word containing the pattern *ait at the end, only entering 3 will replace the *ait at the end of the word. Well, I don't really see this use case ;) Of course, we could use the search/replace function at the end, but it's a very different use than entering your whole text using the braille keyboard. What about adding it to the easy hacks list and enable it only with the experimental features? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Annoying cursor behavior on sw tables
Hi Octavio, On Wed, 2010-12-29 at 20:58 -0800, Octavio Alvarez wrote: Now, look at this, this blog post documents the patch: :-O http://cedric.bosdonnat.free.fr/wordpress/?p=472 Hum, thanks for poking me on it... I would have skipped the thread otherwise. The thing is that Window::Invalidate() gets called if I move or if I type inside a table cell, which almost any key triggers, which is wrong. bUpdatedTable gets set to True inside SwCallLink::~SwCallLink() after some tests. Another option would be to correct those tests, but that would be far beyond my knowledge. The problem I tried to fix was that the whole row wasn't redrawn in some cases... I can't remember those for sure now but it was something like that: Make sure to have tables like this: +-+---+ |+---+| | || || | |+---+| | | | | +-+---+ Place your cursor in the right cell and go to the left: the cursor should go in the blank paragraph after the nested cell and show it. In that kind of cases some part of the border of the right cell wasn't redrawn IIRC. Considering the above blog post from cbos I removed the Invalidate() and tested inserting a 1x1 table inside the cell of another 1x1 table and it seemed to work and update correctly and open the collapsed cell if I place the cursor inside it (by pressing Left or Right, for example). It closes back again if I go outside the empty cell. Did you test with a case similar to the one above? Regards, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string
Bonjour Guillaume, On Wed, 2010-12-22 at 11:47 +0100, Guillaume Poussel wrote: I use LibreOffice almost every day and I'm interested in Open Source softwares, so I would like to contribute. Then be welcomed among LibreOffice develers! I have grabbed the code and compile it. Then, i had a look on the wiki and found an easy task : Remove bogus macro that expand to empty string. I've attached a text file which contains my diff on 4 files I have edited. Many thanks for it, I've just pushed it. For a next time you may want to create the patch using git format-patch. Could someone please have a look and tell me if i'm on the right way ? It's OK for me. P.S. : I'm a french student (in computer science :) ), so I'm sorry if my english is not perfect :) Hey! nice to see students from french schools coming here... Where are you studying? Would it be possible for you to convince your teachers to switch some school dev project by a LibreOffice one? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string
Hello Guillaume, On Wed, 2010-12-22 at 17:53 +0100, Guillaume Poussel wrote: I was not sure about git diff or git format-patch. Next time it would be better :) Don't hesitate to join the IRC channel #libreoffice to raise questions like this: there are several git experts hanging there (maybe not that much during the Christmas holidays). I'm studying in Sophia-Antipolis, near to Nice, more precisely in Polytech'Nice-Sophia. I'm not sure to be able to convince my teachers, but i will talk about it after the Xmas holidays. Well... it's worth trying ;) Now, i will take other easy tasks and try to send my code. Nice, waiting for your next patches. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Removing sw/source/filter/ww8/dump
Hi Caolan, others, I have wondered for a long time if sw/source/filter/ww8/dump is still used by someone... it doesn't even seems to be built. Would anyone oppose to this removal? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Push patch to 3.3
Hi all, I have just finished a patch fixing a few enhanced fields issues like: * Not allowing to type before the field in protected mode * Import fields with 0-length content properly * Fix crash when exporting those imported fields The patch is sitting here: http://cgit.freedesktop.org/libreoffice/build/tree/patches/dev300/field-keyinput.diff?h=ooo-build-3-2-1 Could anyone review it for a possible integration in 3.3 branch? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need review of the ooo/OOO330_m18 changes
On Tue, 2010-12-14 at 21:19 +0100, Jan Holesovsky wrote: writer Done for the fix of i#115956. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Any taker for a starmath bug?
Hello people, I know there are quite a few persons interested or knowing the starmath code... Is there any taker for this bug? https://bugs.freedesktop.org/show_bug.cgi?id=32362 Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Review of fdo#32172 for 3.3 inclusion
Hi caolan, all, Could you please review the commit for this bug? https://bugs.freedesktop.org/show_bug.cgi?id=32172 It could be nice to have it in 3.3 as well... Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice-Plug-In for Netbeans?
Hi Andreas, On Sat, 2010-12-04 at 17:13 +0100, Andreas Mantke wrote: there is already a Netbeans-Plug-In for OOo. But this plug-in doesn't work for me with LibreOffice and it's SDK. Because of this I'm curious, if someone is working on such a plug-in for LibreOffice. It's very unlikely that the guys working on the Netbeans plugin for OOo make it support LO... as they are Oracle employees. Just for your information, I'm still working on the Eclipse plugin and made it move to LibreOffice... At least my dev version of ooeclipse works fine with dev versions of LibreOffice. If you want to help me test it, I'ld be glad to provide some build of the master branch. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Contributing test cases
Hi Michael, On Fri, 2010-12-03 at 11:57 +, Michael Meeks wrote: It failed after only a handful of documents on the attached with: #0 0xabd83b95 in writerfilter::dmapper::DomainMapper_Impl::finishParagraph(boost::shared_ptrwriterfilter::dmapper::PropertyMap) () from /data/opt/OOInstall/program/../basis-link/program/libwriterfilterli.so #1 0xabd6e446 in writerfilter::dmapper::DomainMapper::utext(unsigned char const*, unsigned int) () from /data/opt/OOInstall/program/../basis-link/program/libwriterfilterli.so #2 0xabcc17c6 in writerfilter::ooxml::OOXMLFastContextHandler::endOfParagraph() () from /data/opt/OOInstall/program/../basis-link/program/libwriterfilterli.so #3 0xabc1fefd in writerfilter::ooxml::OOXMLFactory_wml::endAction(writerfilter::ooxml::OOXMLFastContextHandler*) () from /data/opt/OOInstall/program/../basis-link/program/libwriterfilterli.so #4 0xabca302d in writerfilter::ooxml::OOXMLFactory::endAction(writerfilter::ooxml::OOXMLFastContextHandler*, long) () from /data/opt/OOInstall/program/../basis-link/program/libwriterfilterli.so #5 0xabcbda5a in writerfilter::ooxml::OOXMLFastContextHandler::lcl_endFastElement(long) () from /data/opt/OOInstall/program/../basis-link/program/libwriterfilterli.so #6 0xabcbd45f in writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(long) () from /data/opt/OOInstall/program/../basis-link/program/libwriterfilterli.so #7 0xabf86c65 in sax_fastparser::FastSaxParser::callbackEndElement(char const*) () from /data/opt/OOInstall/program/../basis-link/program/fastsax.uno.so Do you have any docx in particular raising this? This is clearly a docx import problem ;) So ... I am certain, that simply building a large collection of documents exercising our various features, and then loading / saving / closing them all in a big long churning run every now and then would catch a ton of bugs for us :-) Any volunteers to play with it ? We already have some effort started in that direction in the build repository. Have a look at the bin/run-tests.sh script and the test folder... Those tests could be improved as only the ooxml tests are automated ATM and they are not even complete. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fix for fdo#31190 to review for 3.3
Hi all, I've fixed fdo#31190, and it looks like something that could be integrated in 3.3 but before pushing to the branch, I'ld like to have some peer review. The patch is attached to the issue. https://bugs.freedesktop.org/show_bug.cgi?id=31190 Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [UX] Some dirty stuffs around styles in calc
Hi all, The other day when playing with a calc document, I discovered an annoying feature. Create a new spreadsheet, protect one of the sheets and try to modify the cell styles: nothing shows up when clicking on the Modify... context menu. I had to run a debug session in sc to understand that the problem was caused by a protected sheet... which obviously normal users won't do. I see here several usability problems: 1/ The Modify... context menu should be at leat unactivated 2/ You can still create new styles 3/ You can't even edit styles that aren't applied in the protected sheet 4/ There is no visual feedback for the user to understand what happens What's your take on this? Christoph, do you have any idea to improve that thing? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word
On Fri, 2010-11-05 at 00:38 -0700, John LeMoyne Castle wrote: Dang, I was hoping it would stop counting at least some punctuation as a word.(period). Don't know what to say other than test before and after. Just some random thought here: would you be able to write some unit tests for this? As a separate potential issue: In a fresh current dev build with AutoCorrect on for single double quotes the Apply While Typing modified them into the selected special symbols (Tools-AutoCorrect-Localized Options Tab). But I could not get the Format-AutoCorrect-Apply to change either the whole doc or a selection. Again, this could be /me from user error or from a faulty build, but this may be another bug: Format-AutoCorrect-Apply not working? for just quotes or other replacements as well?. Did you try erasing the user settings folder to reinit the options there? -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word
Hi guys, I mistakenly pushed Mattias patch this morning... that shouldn't harm, but I though it would be good for you to know it for later investigations. On Sat, 2010-11-06 at 14:14 +1100, Mattias Johnsson wrote: On 6 November 2010 12:13, John LeMoyne Castle j...@mail2lee.com wrote: Hi all, Ok, after getting over a short-term dislike of Word Count - with a new found appreciation for some of the developer comments in OOo issuezilla - I had a new idea for a test plan. Perhaps turning on the Scanner clipping has *accidentally* fixed the quote problem as well. Although I intended to make no changes within the SwScanner -- the two changes at issue are small: Mattias fix of specifying the ScriptType for the fancy punctuation is one initializer in an array, and the Scanner clipping on/off is a Boolean true/false parameter on the SwScanner constructor. So hoping for quick clarity, I backed out both changes. Of course the plan fell apart at step 1) - can see the packaging of core-04 involving libswli.so and core-05 involving new i18npool.so - also did full rm-Rf install and make dev-install to make sure I get the new stuff. - both changes removed - Still no 'leading special quote extra word' [LSQEW] problem with quotes from an existing file or quotes newly inserted into a doc. Get LSQEW on Oracle OOo 3.2 Linux on Lucid. Get LSQEW on LibO Beta2 on Win Vista. I can not recreate it in dev. In case some other change in CountWords fixed it I tried rolling the history back. After a bunch of git diff HEAD~dozens -- ./txtedt.cxx including a binary search to pin down the point just before our changes - a few weeks ago - I rolled CountWords back -40 with: git checkout -f HEAD~40 ./txtedt.cxx Saw the code as it was before any of our changes. Built soffice and ran but still no LSQEW. Know I built the old version txtedt.cxx because Char excl spaces was always zero. And selections across a leading special quote still always gave the 'correct' MSWord count. Looked further back ~200-500 and very few changes in CountWords (nParaAll++ insertion; 2 changes in TxtNode member names; change in ParaDataImpl_ WrongList type) . Did similar look back in history for the breakiterator file and few changes there as well. *Maybe a closer look at the scanner or the iterator will turn up something -- but further back than the copyright change not likely to help since it shows as broken in Beta 2 and in current OOo for Lucid from Ubuntu. If you try the 'go back machine' you may need to search a further back than 40 because of any commits to origin/master since my test (11/5). In this search it helped to step back partway before the last larger set of changes to be able to see the earlier changes. Easy to see far enough because the new field in ParaDataImplwhatever showed at the bottom of the diff. When done 'cleaned up' the local config with git checkout -f origin/master ./txtedt.cxx Still new to git but I am sure I saw and built and ran the old txtedt.cxx and still no LSQEW. Feelin' a bit lost ... I can think of some other options for trying to find what fixed the LSQEW but I feel like I'm chasing ghosts where they aren't. Maybe I have a magic bug eating build setup. I hope not -- that would make troubleshooting impossible ;-) Puzzled but not daunted -- LeMoyne Okay, I can confirm. I pulled the latest master, built it, and there's no opening quote mark problem. I have no idea what's going on. I think I'm just going to let it go for the moment, and pick another bug to fix. Hopefully one that doesn't magically fix itself, this time! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word
Hi Mattias, On Fri, 2010-11-05 at 10:38 +1100, Mattias Johnsson wrote: There isn't a bug report in the LO tracker, but there are quite a few in the OO.o issue tracker. The basic issue number is 89042, with 97116, 102270, 107241, 113375, and 108072 marked as duplicates. Hum, I saw that one... but it seems that with a recent build, the problem doesn't exist anymore... maybe due to John's changes in the SwScanner? Did you try a recent build (yesterday it was fine) without your patch applied? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Styles and Formatting
Hi Cor, On Wed, 2010-11-03 at 20:17 +0100, Cor Nouws wrote: My experience with users is, that they are often overwhelmed by the number of available styles. So Hierarchical as default would not be my choice. Default is more then enough. Ok, then we need to fix that before pushing the patch. (Now we are at it, in Writer the Default view does not show custom styles... ) Let's see that after the patch in integrated ;) Should we enhance the filters values to make it configurable for the different apps? You mean that a choice in Calc is independent from a choice in Writer etc? Hmm that already is the case. So I don't yet understand this. I mean that it's currently the same code that handles this dialog for all the applications. The side effect is that if you want the default value to be Automatic for Writer and All styles for the other apps, then you have to use dark magic... and that magic is currently causing the bug we are trying to fix ;) Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Corrects problem in sysui while building current master
Hi Giuseppe, On Thu, 2010-11-04 at 13:18 +0100, Giuseppe Castagno wrote: Subject: [PATCH] Correct problem building menus for BrOffice Thanks for the patch, feel free to provide some others ;) I just pushed it to master branch. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] configure.in: Cluster all extension related options at one place
Hi Sebastian, Thanks for the patch. I needed to massage it a bit to make it apply, but it works fine. I pushed it in master branch. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word
Hi Mattias, On Thu, 2010-11-04 at 23:38 +1100, Mattias Johnsson wrote: Patch attached. It's a very minimal change, so it's probably safe to push into the 3.3 branch as well as master. It seems that you forgot to actually attach the patch ;) Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] distro_config: adapt to new confgure options for extensions
On Thu, 2010-11-04 at 13:57 +0100, Sebastian Spaeth wrote: Some extensions options for configure were renamed to --enable-ext-* Adapt all distro configs to reflect that. Sorry for the churn. Thanks for the patch, I just pushed it. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice and Java
On Tue, 2010-11-02 at 12:47 +, Michael Meeks wrote: Quite; cf. such uncertainty - it probably makes considerable sense to look into a migration strategy from Java to (insert anything else). Some candidates might be python for the more scripty pieces (though I hate non-typed languages), and/or native C++. What about the existing Java extensions? Quite a lot of people are using Java to either writer extensions or use UNO Java bridge from an external application. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] How to write debug output to console or file?
Hi Mattias, On Fri, 2010-10-29 at 15:49 +1100, Mattias Johnsson wrote: To help with debugging, it'd be very useful for me to be able to write out variable values from within the code. Writing to the console or a file would be fine. Writing to the console using fprintf of std:: is possible. I usually output on the error stream for the debugging purposes. std::cout doesn't work with any of the internal (unicode) string types like OUString. Is there a way to cast them to something that cout can deal with, or is there some logger that can write these strings to a file? The problem here is to get a C string from them: here are some examples: * from OUString: rtl::OUStringToOString( sOUStr, RTL_TEXTENCODING_UTF8 ).getStr() * from String / UniString ByteString( sToolStr, RTL_TEXTENCODING_UTF8 ).GetBufferAccess() I typed those without checking the case... I hope it's OK, otherwise, just check the code for the correct syntax. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Moved wrappers for all debuginfo calls into the function itself
On Tue, 2010-10-26 at 14:32 -0700, Sean McMurray wrote: This patch is public domain. Does it mean LGPLv3+ / MPL as it's the prefered licence for LibreOffice? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
Hi Mattias, On Wed, 2010-10-27 at 18:26 +1100, Mattias Johnsson wrote: Here are my patches for the easy hack / programming task Count characters without whitespace in the Writer statistics. Since it's something translators have apparently been asking for OO.org to have for eight years (see http://www.openoffice.org/issues/show_bug.cgi?id=10356 and https://bugs.freedesktop.org/show_bug.cgi?id=30550) it'd be nice for it to appear in LibreOffice :-) Thanks for your patches, I reviewed them and cleaned up a bit the SwTxtNode::WordCount() method as you added some commented code. I also kept the condition for the aScanner.GetLen() 1... is there any reason to remove that? I removed the task from the EasyTasks list. Keep providing nice patches like those ;) Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SW_DLLPUBLIC limitations ...
Hi Tor, Michael, I finally got it working with SAL_DLLPUBLIC_EXPORT as michael suggested. If there is any possible trouble, let me know ;) -- Cedric On Wed, 2010-10-27 at 07:21 -0600, Tor Lillqvist wrote: The question (for Tor) is - if we have a __declspec(dllexport) on two identical symbols in two shared libraries that link to each other: will we get some vile linking conflict ? [ or not ] ;-) As far as I could see by experimenting, yes, as long as you from a DLL don't both import and export a symbol with the same name, it should work. Possibly using some clever tricks or useful options to the linker it might be possible to make the linker create a DLL that both imports a certain symbol from another DLL, and also exports the same symbol. (If just you manage to create such a DLL, using it should not be problematic... After all, to the run-time linker, there should be nothing confusing going on.) But of course, without actually trying, and considering C++ is involved, take all the above with a large grain of salt. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] tiny first patch - fix 32 bit overflow at compile
Hi Kevin, On Mon, 2010-10-25 at 13:44 -0400, Kevin Hunter wrote: For a project as large as LibreOffice, you may also more appreciate the use of an IDE (Integrated Development Environment). Eclipse is often touted to me, as is Geany, and KDevelop. Did you ever tried loading the sw module sources in Eclipse? it may be possible, but you'll have some memory troubles and slowdowns with the indexing. A combination of Vim/Emacs and ctags is great and much quicker. I'll try to cleanup and push my vim configuration somwhere for others to download. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] credits page is 403 access forbidden
Hi Sebastian, On Tue, 2010-10-26 at 11:41 +0200, Sebastian Spaeth wrote: Please put something like this in its place: http://sspaeth.de/uploads/tmp/index.html I'ld love to have at least the wiki authors in before making the official page live. (with or without graphs). I'ld prefer without the graphs as it's only a credits page. Miklos pointed to a nice script for git live stats, but I can't remember it. P.S. I can periodically rerun the script to create the page. It is also online if you want to do it yourselves. What would be needed is to integrate that script on a documentfoundation.org server and run a cron every night. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] RTF: fix non-text frames
Hi Miklos, it seems to be good, go ahead. On Mon, 2010-10-18 at 13:59 +0200, Miklos Vajna wrote: Hi Cedric, I'm attaching a patch that fixes a crash on non-text frames when exporting as RTF. A reproducer is here: http://cgit.freedesktop.org/~vmiklos/ooo-gsoc/tree/writer/21976.doc?h=ooo-test-files OK to push? :) -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Improving the build experience in rawbuild
Hi Christian, CC'ing the list as you apparently forgot to Reply All. On Thu, 2010-10-14 at 00:44 +0200, Christian Lohmaier wrote: The current build procedure described on the wiki and TDF website builds in build/libreoffice*. In order to change that, I'ld like to do the following: * Change the rawbuild/configure.in to have the defaults matching the options defined in distros-config/LibreOfficeLinux.conf.in What about Mac? What about Windows? Hum... You're right! Any better idea to have something smooth very everyone? * Hack bin/g to have bin/g clone download all the repos at the appropriate place and create the rawbuild folder. I don't understand this part. Why would you need to hack this when rawbuild folder is generated now already? The point is to generate it sooner: it is now generated by download which is generated by the build/autogen.sh. The idea here is to have a simple process to build in rawbuild instead of build/libreoffice* I'd like to be able to do rm -rf build and run make again, without re-downloading stuff again (ideally stuff downloaded using different scripts should end up in different directories, but not below build) I'd like to have one build-directory for the core office, I don't mind whether that would be build/rawbuild or different, it just should be named the same when the tree is updated. The downloaded stuffs are currently in the src folder of the build repository and are added to the gitignore files: you can currently run a rm -rf build safely :) If the dev builds are happening in rawbuild, it'll be more complicated as rawbuild is a lot of symlinks to the clone folder. but I agree that something like make clean (properly working) would be needed. I'd like to be able to git diff in the build-directory. That's why building in the current rawbuild is interesting: we could use bin/g tool to create the patches and/or commit directly instead of some black magick to move the changes from build/libreoffice* into rawbuild. And of course I'd like to be the version for Mac that way as well as a Linux version. Indeed... If that is what you propose, then sorry for not being able to parse your message. If your proposal differs significantly, I'd be happy if you could explain in more detail. The main problem I have with building in rawbuild is that one needs to input a lot of arguments to the configure depending on his OS / Distro. These infos are all in the distros-config folder of the build repository: it would be nice to be able to reuse them when running the rawbuild/autogen.sh I hope to have explained my thoughts a bit better. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fix RTF export incorrect output with nested tables
Hi Miklos, On Thu, 2010-10-14 at 12:58 +0200, Miklos Vajna wrote: Hi Cedric, See attached patch, it fixes exporting the http://cgit.freedesktop.org/~vmiklos/ooo-gsoc/tree/writer/hallenverzeichnis_2003.odt?h=ooo-test-files test file - before the fix, only the first column was visible in Word. OK to push? I'ld say yes: the patch looks fine... thought I haven't built it ;) Push it and we'll bother you if there's something wrong with it. Regards -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 1/1] Cleanup: remove bogus comments from inc directory
Hello Prashant, Thanks for the patch, I just pushed it. -- Cedric On Wed, 2010-10-13 at 10:32 +0530, Prashant Shah wrote: This patch removes bogus comments found in the inc directory including empty Beschreibung (translation: description) statements Signed-off-by: Prashant Shah pshah.mum...@gmail.com --- sw/source/ui/inc/DropDownFieldDialog.hxx |1 - sw/source/ui/inc/actctrl.hxx |2 +- sw/source/ui/inc/bmpwin.hxx |1 - sw/source/ui/inc/cfgdesc.hxx |1 - sw/source/ui/inc/cfgitems.hxx |9 +++-- sw/source/ui/inc/changedb.hxx |1 - sw/source/ui/inc/colex.hxx| 12 +--- sw/source/ui/inc/colmgr.hxx | 11 ++- sw/source/ui/inc/column.hxx |7 --- sw/source/ui/inc/condedit.hxx | 20 sw/source/ui/inc/dialmgr.hxx |2 +- sw/source/ui/inc/docstdlg.hxx |1 - sw/source/ui/inc/envimg.hxx |5 + sw/source/ui/inc/envlop.hxx |5 - sw/source/ui/inc/fldedt.hxx |5 - sw/source/ui/inc/fldmgr.hxx |4 +--- sw/source/ui/inc/fldtdlg.hxx |4 sw/source/ui/inc/fldwrap.hxx |3 +-- sw/source/ui/inc/formedt.hxx |1 - sw/source/ui/inc/frmdlg.hxx |2 -- sw/source/ui/inc/frmpage.hxx |7 --- sw/source/ui/inc/glosbib.hxx |5 + sw/source/ui/inc/idxmrk.hxx |7 --- sw/source/ui/inc/labimg.hxx |4 +--- sw/source/ui/inc/linenum.hxx |4 sw/source/ui/inc/mailconfigpage.hxx |6 -- sw/source/ui/inc/mailmergechildwindow.hxx |8 +--- sw/source/ui/inc/mailmergehelper.hxx | 24 ++-- sw/source/ui/inc/mailmrge.hxx |9 ++--- sw/source/ui/inc/mmconfigitem.hxx |7 +++ sw/source/ui/inc/navicfg.hxx |3 +-- sw/source/ui/inc/navipi.hxx |4 +--- sw/source/ui/inc/optcomp.hxx |2 -- sw/source/ui/inc/optload.hxx | 16 sw/source/ui/inc/optpage.hxx | 20 ++-- sw/source/ui/inc/outline.hxx |8 ++-- sw/source/ui/inc/pgfnote.hxx |1 - sw/source/ui/inc/pggrid.hxx |2 +- sw/source/ui/inc/pview.hxx|4 sw/source/ui/inc/regionsw.hxx | 17 + sw/source/ui/inc/srcview.hxx | 26 -- sw/source/ui/inc/swlbox.hxx |3 +-- sw/source/ui/inc/swrenamexnameddlg.hxx|5 - sw/source/ui/inc/swuicnttab.hxx | 17 ++--- sw/source/ui/inc/swuiidxmrk.hxx | 15 ++- sw/source/ui/inc/tmpdlg.hxx |3 --- sw/source/ui/inc/tmplctrl.hxx |5 - sw/source/ui/inc/toxmgr.hxx |6 +- sw/source/ui/inc/uiitems.hxx |7 --- sw/source/ui/inc/uinums.hxx |6 -- sw/source/ui/inc/uivwimp.hxx | 10 +- sw/source/ui/inc/unotools.hxx | 10 ++ sw/source/ui/inc/unotxvw.hxx | 10 +- sw/source/ui/inc/usrpref.hxx | 15 +-- sw/source/ui/inc/view.hxx |6 -- sw/source/ui/inc/viewlayoutctrl.hxx |3 --- sw/source/ui/inc/wview.hxx|4 57 files changed, 48 insertions(+), 358 deletions(-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 1/2] Cleanup: remove bogus comments from unocore direcotry
Pushed that one too, thanks for it! On Wed, 2010-10-13 at 16:04 +0530, Prashant Shah wrote: This patch removes bogus comments found in the unocore direcotry including empty Beschreibung (translation: description) statements Signed-off-by: Prashant Shah pshah.mum...@gmail.com --- sw/source/core/unocore/unoevtlstnr.cxx | 16 - sw/source/core/unocore/unofield.cxx| 208 + sw/source/core/unocore/unoobj2.cxx | 115 +--- sw/source/core/unocore/unoportenum.cxx | 54 sw/source/core/unocore/unoredline.cxx | 77 +- sw/source/core/unocore/unorefmk.cxx| 74 +- sw/source/core/unocore/unosect.cxx | 96 +-- sw/source/core/unocore/unostyle.cxx| 318 +--- sw/source/core/unocore/unotbl.cxx | 511 ++- 9 files changed, 66 insertions(+), 1403 deletions(-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH 2/2] Cleanup: remove bogus comments from unocore directory
Pushed that one as well, many thanks! On Wed, 2010-10-13 at 16:05 +0530, Prashant Shah wrote: This patch removes bogus comments found in the unocore directory including empty Beschreibung (translation: description) statements Signed-off-by: Prashant Shah pshah.mum...@gmail.com --- sw/source/core/unocore/TextCursorHelper.cxx |6 - sw/source/core/unocore/unochart.cxx | 108 +-- sw/source/core/unocore/unocrsrhelper.cxx| 36 +--- sw/source/core/unocore/unodraw.cxx | 184 ++-- sw/source/core/unocore/unoframe.cxx | 304 ++- sw/source/core/unocore/unoftn.cxx | 83 +--- sw/source/core/unocore/unoparagraph.cxx | 135 + sw/source/core/unocore/unoredlines.cxx | 39 sw/source/core/unocore/unosrch.cxx | 79 --- 9 files changed, 50 insertions(+), 924 deletions(-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] A later change in download packets name.
Hi Giuseppe,
The patch looks good to me, I pushed it. Thanks for your help.
On Mon, 2010-10-11 at 19:57 +0200, Giuseppe Castagno wrote:
Hi,
the attached patch change the default name of downloadable packages,
e.g. the one is used should a correct product name missing.
See solenv/bin/modules/installer/download.pm file for details, in
bootstrap repository.
Patch released according to LGPLv3+ license.
beppec56
differences between files attachment
(0001-Changed-one-more-of-the-dowload-package-names.patch)
From 624e5fdaab5e2e85b5d9b783f4caee8e30af4b27 Mon Sep 17 00:00:00 2001
From: Giuseppe Castagno be...@dsklnx.host.local
Date: Mon, 11 Oct 2010 18:38:37 +0200
Subject: [PATCH] Changed one more of the dowload package names.
---
solenv/bin/modules/installer/download.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/solenv/bin/modules/installer/download.pm
b/solenv/bin/modules/installer/download.pm
index 738a360..0bc616f 100644
--- a/solenv/bin/modules/installer/download.pm
+++ b/solenv/bin/modules/installer/download.pm
@@ -467,7 +467,7 @@ sub get_downloadname_productname
{
my ($allvariables) = @_;
-my $start = LO;
+my $start = LibO;
if ( $allvariables-{'PRODUCTNAME'} eq LibreOffice ) { $start =
LibO; }
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Improving the build experience in rawbuild
Hi fellow developers, We improved our build process a lot since the LibreOffice creation, but there is still something I'ld like to improve. Developers should build in rawbuild in order to create patches (or commit directly) easily. The current build procedure described on the wiki and TDF website builds in build/libreoffice*. In order to change that, I'ld like to do the following: * Change the rawbuild/configure.in to have the defaults matching the options defined in distros-config/LibreOfficeLinux.conf.in * Hack bin/g to have bin/g clone download all the repos at the appropriate place and create the rawbuild folder. This way, all that would need to be done for a new developper building on Linux would be: git clone .../build cd build bin/g clone cd rawbuild ./autogen.sh make make dev-install Do you have any strong opinion against that? -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] IZ hack using GreaseMonkey
Hi all, The previous email may have been lost in the initial thread, so I'm reposting here. You can now see whether a bug in OpenOffice issuezilla has been fixed in LibreOffice very simply. Just install GreaseMonkey [0] on your beloved Firefox browser and then install the script [1] I cooked. [0] http://www.greasespot.net/ [1] http://userscripts.org/scripts/show/87923 The bugs numbers are extracted from the git commits. Please add a reference to the bug when you fix it. The reference needs to be in the form i#123456 or #i123456#. If you find some bug that isn't marked as fixed by the script and should be, please first check that the bug number can be found in the git log. If the bug reference is present, then poke me! Happy bug fixing to all! Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] coding style
Hi Prashant On Sun, 2010-10-10 at 21:21 +0530, Prashant Shah wrote: Do we have any official coding style ? I see a lot of messy code :) No, there is no coding style yet, but we will start to work on one soon (step by step). Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SAL_N_ELEMENTS, where?
On Sun, 2010-10-10 at 09:51 -0700, Kayo Hamid wrote: There are other places than writer, base, calc and impress repo? I'm not familiar with these many git repositories. All the git repos are in the clone folder. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Compile fails on Ubuntu Lucid
Hello Jim, Thank you for trying to get started on LibreOffice build and development! On Fri, 2010-10-08 at 14:02 +, jim bobs wrote: ERROR: Product OpenOffice not defined in openoffice.lst in function: getproductblock when running bin/ooinstall -l /home/user/Desktop/libreoffice/git/build/scratch/ You should run git pull -r and bin/g pull -r: these have been fixed recently. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Some more features
Hi Miklos, Michael, On Thu, 2010-10-07 at 16:10 +0200, Miklos Vajna wrote: I think Cedric will fix this - though if I should do it, please let me know. I just removed those files in sw/source/filter/rtf/. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
