[Libreoffice-commits] core.git: download.lst external/harfbuzz

2015-05-09 Thread Khaled Hosny
(-) New commits: commit 3acb1d4b28944de908ffb3d0b756725ae015214f Author: Khaled Hosny khaledho...@eglug.org Date: Wed May 6 12:59:15 2015 +0200 Update HarfBuzz to 0.9.40 Most of ubsan.patch seems to have been applied upstream, and I can’t reproduce the issue referenced

Mac OS X and pkg-config

2015-06-08 Thread Khaled Hosny
When building on Mac OS X the configure script errors if it finds pkg-config saying it will break the build, unless --enable-bogus-pkg-config is used. Having completed the build with this option without seeing any breakage and the resulting build seems to run just fine, so I’m wondering what kind

Re: Mac OS X and pkg-config

2015-06-10 Thread Khaled Hosny
On Wed, Jun 10, 2015 at 01:17:07PM +0200, David Tardon wrote: Hi, On Tue, Jun 09, 2015 at 04:30:45PM +0200, Michael Stahl wrote: On 09.06.2015 16:20, Thorsten Behrens wrote: Tor Lillqvist wrote: But neither is it very useful to have the already small set of OS X -based

Re: Mac OS X and pkg-config

2015-06-10 Thread Khaled Hosny
On Tue, Jun 09, 2015 at 08:23:08AM +0300, Tor Lillqvist wrote: May goal is to make building LibreOffice easier for “atypical” people who have things like homebrew or macports Why? What is the point? To make building LibreOffice less complicated for certain kinds of people. The thing that

Re: Mac OS X and pkg-config

2015-06-10 Thread Khaled Hosny
On Tue, Jun 09, 2015 at 12:36:41PM +0300, Tor Lillqvist wrote: Some of us work on other opensource projects on our Mac machines which happen to need MacPorts or HomeBrew. Having LibreOffice simply say I refuse to build on this machine because you've already installed some other stuff is

Re: Mac OS X and pkg-config

2015-06-10 Thread Khaled Hosny
On Wed, Jun 10, 2015 at 02:56:59PM +0200, Michael Stahl wrote: On 10.06.2015 13:30, Khaled Hosny wrote: So why Mac OS X is treated differently, what is so special about it? Mac OS X is an actual operating system with an actual SDK that defines the stable and supported interfaces

Re: Mac OS X and pkg-config

2015-06-10 Thread Khaled Hosny
On Wed, Jun 10, 2015 at 03:06:48PM +0200, Michael Stahl wrote: On 10.06.2015 11:43, Khaled Hosny wrote: On Tue, Jun 09, 2015 at 12:36:41PM +0300, Tor Lillqvist wrote: Some of us work on other opensource projects on our Mac machines which happen to need MacPorts or HomeBrew. Having

Re: Mac OS X and pkg-config

2015-06-10 Thread Khaled Hosny
On Wed, Jun 10, 2015 at 04:49:25PM +0200, Stephan Bergmann wrote: On 06/10/2015 11:41 AM, Khaled Hosny wrote: I’m not saying we should use pkg-config on Mac, all I’m asking for is what kind of breakages are expected when pkg-config is found, because I didn’t experience any, to find better way

Re: Adding Languages to Writer's Character, Font Menu

2015-06-29 Thread Khaled Hosny
On Mon, Jun 29, 2015 at 12:14:44PM +0200, Eike Rathke wrote: Hi Richard, On Wednesday, 2015-06-24 20:54:54 +0100, Richard Wordingham wrote: The script is generally implicit in the text. You want to rely on automatic detection of scripts depending on the language chosen? Do you plan to

Bogus ligatures in OpenSymbol font

2015-08-17 Thread Khaled Hosny
While trying to fix a bug in OpenSymbol font, I found that it contains some a GSUB table with some weird ligature entries, namely: period + period + period - ellipsis integral + integral- double integral integral +

[Libreoffice-commits] core.git: extras/source

2015-08-18 Thread Khaled Hosny
extras/source/truetype/symbol/OpenSymbol.sfd | 14 +++--- extras/source/truetype/symbol/opens___.ttf |binary 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 75a8b1cf84ac718aa1c8d671cd27b0b10307f50a Author: Khaled Hosny khaledho...@eglug.org Date: Tue Aug 18 02

Re: Bogus ligatures in OpenSymbol font

2015-08-21 Thread Khaled Hosny
On Thu, Aug 20, 2015 at 04:40:29PM +0100, Caolán McNamara wrote: On Tue, 2015-08-18 at 01:53 +0200, Khaled Hosny wrote: While trying to fix a bug in OpenSymbol font, I found that it contains some a GSUB table with some weird ligature entries, namely: ... Anyone knows why those ligature

[Libreoffice-commits] core.git: 2 commits - vcl/source vcl/unx

2015-08-23 Thread Khaled Hosny
vcl/source/gdi/salgdilayout.cxx |4 ++- vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 29 +++--- 2 files changed, 25 insertions(+), 8 deletions(-) New commits: commit e2582341af9f6b756e5d95c8ddd99652b62d1a41 Author: Khaled Hosny khaledho...@eglug.org

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx

2015-08-20 Thread Khaled Hosny
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) New commits: commit a803ec69f69068e0c45a7825094941b9ea765c1c Author: Khaled Hosny khaledho...@eglug.org Date: Mon Aug 17 00:49:39 2015 +0200 Fix GTK3 right

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - 97 commits - basctl/source basic/source bin/run chart2/source configure.ac cui/source editeng/source external/apr external/libetonyek

2015-08-20 Thread Khaled Hosny
insertions(+), 1666 deletions(-) New commits: commit 2dd5ba7ee56dcb12e549d8916a4d7d1b7b1aac10 Author: Khaled Hosny khaledho...@eglug.org Date: Mon Aug 17 00:49:39 2015 +0200 Fix GTK3 right-to-left rendering * Reverse the direction of arrows e.g. in menus * Reverse the position

[Libreoffice-commits] core.git: vcl/unx

2015-08-16 Thread Khaled Hosny
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) New commits: commit 2ce903c7b2d67a46c2fe2755cfaa66d98f2eddf2 Author: Khaled Hosny khaledho...@eglug.org Date: Mon Aug 17 00:49:39 2015 +0200 Fix GTK3 right

[Libreoffice-commits] core.git: extras/source

2015-08-22 Thread Khaled Hosny
extras/source/truetype/symbol/OpenSymbol.sfd |6 -- extras/source/truetype/symbol/opens___.ttf |binary 2 files changed, 6 deletions(-) New commits: commit 26f3a6470336644988de1f8a76d982dae4de67ae Author: Khaled Hosny khaledho...@eglug.org Date: Fri Aug 21 16:58:28 2015 +0200

[Libreoffice-commits] core.git: vcl/generic

2015-08-01 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) New commits: commit 8e43f5d3222ca320e28026bfef4b6096376446c1 Author: Khaled Hosny khaledho...@eglug.org Date: Sat Aug 1 21:23:43 2015 +0200 Move fix for tdf#89231 to a better place

Re: ‘OUTPUT_DRAWMODE_CONTRAST’ defined but not used

2015-08-25 Thread Khaled Hosny
On Tue, Aug 25, 2015 at 05:54:32PM +0200, Stephan Bergmann wrote: On 08/25/2015 05:30 PM, Khaled Hosny wrote: In may build I see this warning a lot: In file included from cui/source/tabpages/textattr.cxx:37:0: include/svx/dlgutil.hxx:37:28: warning: ‘OUTPUT_DRAWMODE_CONTRAST’ defined

‘OUTPUT_DRAWMODE_CONTRAST’ defined but not used

2015-08-25 Thread Khaled Hosny
In may build I see this warning a lot: In file included from cui/source/tabpages/textattr.cxx:37:0: include/svx/dlgutil.hxx:37:28: warning: ‘OUTPUT_DRAWMODE_CONTRAST’ defined but not used [-Wunused-variable] static const DrawModeFlags OUTPUT_DRAWMODE_CONTRAST = DrawModeFlags::SettingsLine |

Re: ‘OUTPUT_DRAWMODE_CONTRAST’ defined but not used

2015-08-25 Thread Khaled Hosny
On Tue, Aug 25, 2015 at 07:28:26PM +0300, Maxim Monastirsky wrote: Hi Khaled, On Tue, Aug 25, 2015 at 6:30 PM, Khaled Hosny khaledho...@eglug.org wrote: In may build I see this warning a lot: In file included from cui/source/tabpages/textattr.cxx:37:0: include/svx/dlgutil.hxx:37:28: warning

Re: Unicode characters in Thesaurus dialog box

2015-11-10 Thread Khaled Hosny
On Tue, Nov 10, 2015 at 03:10:25AM -0600, Adolfo Jayme Barrientos wrote: > 2015-11-08 23:24 GMT-06:00 Khaled Hosny <khaledho...@eglug.org>: > > Is this true, I always had font fallback on LibreOffice UI (on Linux at > > least), even my main UI font does not support Latin

Re: Unicode characters in Thesaurus dialog box

2015-11-08 Thread Khaled Hosny
On Sun, Nov 08, 2015 at 10:06:51AM -0600, Adolfo Jayme Barrientos wrote: > Whenever the UI font doesn’t support a different script, LibreOffice > does not fall back to anything else and displays squares. Is this true, I always had font fallback on LibreOffice UI (on Linux at least), even my main

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx

2015-08-25 Thread Khaled Hosny
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 29 +++--- 1 file changed, 22 insertions(+), 7 deletions(-) New commits: commit 3a0ca27411f37b86a56737d89349ac629863af00 Author: Khaled Hosny khaledho...@eglug.org Date: Mon Aug 17 04:00:49 2015 +0200 Fix GTK3 right

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - extras/source

2015-09-30 Thread Khaled Hosny
extras/source/truetype/symbol/OpenSymbol.sfd | 14 +++--- extras/source/truetype/symbol/opens___.ttf |binary 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit bf6e219ee57bb17fdb4f176bc4888a540cbeb290 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue

[Libreoffice-commits] core.git: vcl/generic

2015-11-27 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) New commits: commit e5cc49dbf139b2d3ca2bbc0c41e7c47d63c11d66 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Nov 27 19:32:42 2015 +0400 Disable code not

[Libreoffice-commits] core.git: vcl/generic

2015-11-23 Thread Khaled Hosny
vcl/generic/glyphs/gcach_ftyp.cxx | 23 --- 1 file changed, 23 deletions(-) New commits: commit aefcb307c246275fa9001996bd815c73b4ac79b3 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Nov 24 09:13:48 2015 +0400 Remove recently unused code Cha

Re: making cairo mandatory in vcl

2015-11-19 Thread Khaled Hosny
On Thu, Nov 19, 2015 at 11:14:10AM +, Caolán McNamara wrote: > On Thu, 2015-11-19 at 11:16 +0100, Riccardo Magliocchetti wrote: > > We should now link against cairo and the system one is usually linked > > against X11. So i think i'm going to just build the libo shipped one > > and see how

Re: making cairo mandatory in vcl

2015-11-19 Thread Khaled Hosny
On Thu, Nov 19, 2015 at 06:15:46PM +0100, Riccardo Magliocchetti wrote: > Il 19/11/2015 15:00, Khaled Hosny ha scritto: > >On Thu, Nov 19, 2015 at 11:14:10AM +, Caolán McNamara wrote: > >>On Thu, 2015-11-19 at 11:16 +0100, Riccardo Magliocchetti wrote: > >>>We

Re: Feature branch request

2016-06-10 Thread Khaled Hosny
On Fri, Jun 03, 2016 at 07:20:45PM +0530, Akash Jain wrote: > Therefore I request a feature branch with commit access so I can push > code faster then the current work flow will allow. Can you we get a Akash commit access to push his work on a branch, he has sent several patches to gerrit already

Re: Feature branch request

2016-06-10 Thread Khaled Hosny
On Fri, Jun 10, 2016 at 03:27:00PM +0200, jan iversen wrote: > > > > On 10 Jun 2016, at 14:39, Khaled Hosny <khaledho...@eglug.org> wrote: > > > >> On Fri, Jun 03, 2016 at 07:20:45PM +0530, Akash Jain wrote: > >> Therefore I request a feature branch

Re: Questions about the font shaping tender

2016-02-04 Thread Khaled Hosny
bly certain you have some good ideas around > how to fix the SalLayout mess... certainly you have the technical > expertise and experience to tackle this. > > Just a suggestion :-) > > Chris > > > On 1 Feb 2016, at 9:35 PM, Khaled Hosny <khaledho...@eglug.org> wrote:

Renaming sal_Unicode to a less misleading name?

2016-02-13 Thread Khaled Hosny
I’m wondering if it is possible to rename sal_Unicode, which is actually a unsigned 16 bit integer and thus can’t fit any Unicode character, to some less confusing name like sal_Ucs2 or even just use sal_uInt16 (but please not sal_Utf16 which would give the illusion that surrogate pairs and

Questions about the font shaping tender

2016-02-01 Thread Khaled Hosny
I just came across this tender [1] and it is not quite clear to me what is it about. Am I right in thinking this is about having a shared cross-platform implementation of VCL text layout API (the dreaded SalLayout et all)? If so I don’t understand what AFM stuff is doing here since we don’t use

Re: Questions about the font shaping tender

2016-02-02 Thread Khaled Hosny
On Tue, Feb 02, 2016 at 10:15:07AM +0100, Miklos Vajna wrote: > Hi, > > I think the problem to solve is that we have different layout on Linux, > Windows and OS X, which means it's next to impossible to write unit > tests that assert the text is laid out correctly, since there can be > small

Re: is anybody able to build libreoffice on archlinux

2016-02-24 Thread Khaled Hosny
On Wed, Feb 24, 2016 at 07:22:27PM +0530, Pranav Ganorkar wrote: > Hi, > > I want to ask if anybody has been successful in building Libreoffice > recently on Archlinux. Do we need to use the switches given in PKGBUILD >

Re: is anybody able to build libreoffice on archlinux

2016-02-25 Thread Khaled Hosny
On Wed, Feb 24, 2016 at 10:34:40PM +0100, Łukasz Hryniuk wrote: > Do you have the newest version of packages? Perhaps Pranav and I have > a "special" package, which covers some default library. E.g. I wasn't > able to build LibreOffice with Python from Anaconda. I’ve an up to date system, no

Re: Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-02-22 Thread Khaled Hosny
The patch does not really fix the issue, it makes it even worse. I think she is just asking for pointers to further work on the issue, so submitting a patch to gerrit might not be the best course of action. Regards, Khaled On Mon, Feb 22, 2016 at 10:21:27AM +0100, jan iversen wrote: > Hi > >

[Libreoffice-commits] core.git: editeng/source

2016-01-22 Thread Khaled Hosny
editeng/source/items/numitem.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 65698ffa0e9274812df7fc997f9c3db7bb760ae2 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Jan 22 13:32:14 2016 +0400 Typo Cha

Re: Renaming sal_Unicode to a less misleading name?

2016-02-15 Thread Khaled Hosny
On Mon, Feb 15, 2016 at 05:57:25PM +0100, Stephan Bergmann wrote: > >yeah, I mentioned the le/be variant to be 'complete', I will certainly > >concede that it would likely be overkill. > >still having sal_utf16. sal_utf32 and even sal_utf8 would not hurt, > >especailly comapred to sal_Int32,

Re: Problem Building Libreoffice on Linux

2016-02-18 Thread Khaled Hosny
On Thu, Feb 18, 2016 at 10:39:40AM +0100, Stephan Bergmann wrote: > On 02/17/2016 05:47 PM, Pranav Ganorkar wrote: > >Program received signal SIGSEGV, Segmentation fault. > >0x2aaab93213d3 in ?? () from /usr/lib/libharfbuzz.so.0 > >(gdb) bt > >#0 0x2aaab93213d3 in ?? () from

Re: Problem Building Libreoffice on Linux

2016-02-18 Thread Khaled Hosny
t; I want to ask if there is some switch for temporarily disabling these unit > tests. > > I am building it on a 64-bit Archlinux machine. > > Regards, > Pranav > > On Thu, Feb 18, 2016 at 3:24 PM, Khaled Hosny <khaledho...@eglug.org> wrote: > > > On Thu, Fe

Re: Problem Building Libreoffice on Linux

2016-02-19 Thread Khaled Hosny
On Thu, Feb 18, 2016 at 02:36:48PM +0100, Michael Stahl wrote: > On 18.02.2016 14:17, Khaled Hosny wrote: > > I don’t think it is just the unit test that is failing, running the > > application will most likely crash as well. Building with system > > HarfBuzz should fix the

[Libreoffice-commits] core.git: vcl/unx

2016-04-13 Thread Khaled Hosny
vcl/unx/gtk3/gtk3gtkframe.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 20c9d0f3849ed8ccda7d4d270aabddf37db5c390 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Apr 13 14:46:23 2016 +0200 Fix showing tooltips in RTL UI with GTK 3 Cha

Re: Windows / font / text futures ...

2016-03-07 Thread Khaled Hosny
On Fri, Mar 04, 2016 at 12:04:38PM +, Caolán McNamara wrote: > On Thu, 2016-03-03 at 13:44 +, Michael Meeks wrote: > > Hi guys, > > > Anyhow - what to do ? > >  > > While we could switch to DirectWrite on windows, which may > > solve some > > of our problems; this will be in

Re: Windows / font / text futures ...

2016-03-07 Thread Khaled Hosny
On Mon, Mar 07, 2016 at 02:04:41PM +, Michael Meeks wrote: > Hi Thorsten, > > I missed your mail; please do maintain the CC if you want a prompt > reply =) > > On Fri, 2016-03-04 at 00:43 +0100, Thorsten Behrens wrote: > > > Having looked at this heap; and worse - the two different

Re: Windows / font / text futures ...

2016-03-07 Thread Khaled Hosny
On Tue, Mar 08, 2016 at 10:18:47AM +1100, Chris Sherlock wrote: > On 8 Mar 2016, at 5:38 AM, Khaled Hosny <khaledho...@eglug.org> wrote: > > > > On Mon, Mar 07, 2016 at 02:04:41PM +, Michael Meeks wrote: > >> Hi Thorsten, > >> > >>I missed

Re: Obtaining opens___.ttf from OpenSymbol.sfd

2016-04-04 Thread Khaled Hosny
On Mon, Apr 04, 2016 at 05:17:15PM +0900, Takeshi Abe wrote: > Hi, > > Looking into tdf#49547 [1], I wonder which version of FontForge is supposed > or recommended to be used for producing > extras/source/truetype/symbol/opens__.ttf > from OpenSymbol.sdf. > Thank you for your attention. > > [1]

[Libreoffice-commits] core.git: vcl/unx

2016-04-25 Thread Khaled Hosny
vcl/unx/generic/glyphs/gcach_layout.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit a8d853fd9c1d84d63cf41b31ea548b6be8a621ec Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Apr 25 17:41:35 2016 +0200 Update comment a bit Cha

[Libreoffice-commits] core.git: vcl/unx

2016-05-19 Thread Khaled Hosny
vcl/unx/generic/glyphs/gcach_layout.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 1a140de1f8b02759288adc33a64d35b0a0806600 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu May 19 11:14:40 2016 +0200 Try to stop the tinderboxes from spamm

[Libreoffice-commits] core.git: vcl/unx

2016-05-17 Thread Khaled Hosny
vcl/unx/generic/glyphs/gcach_layout.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 225411ebb572e4bb8b551509b37e20a529a91603 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue May 17 22:43:09 2016 +0200 Outdated comment Cha

[Libreoffice-commits] core.git: vcl/unx

2016-05-17 Thread Khaled Hosny
vcl/unx/generic/glyphs/gcach_layout.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit f688acfdae00ebdd891737e533d54368810185e1 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue May 17 22:49:40 2016 +0200 Try to fix perf regr

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/unx

2016-04-19 Thread Khaled Hosny
vcl/unx/gtk3/gtk3gtkframe.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit d01890fe4590365743783398db9611e0e498 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Apr 13 14:46:23 2016 +0200 Fix showing tooltips in RTL UI with GTK 3 Cha

Re: Help with an old regression in text rendering needed

2016-07-29 Thread Khaled Hosny
On Wed, Jul 20, 2016 at 08:55:01AM +0200, Milos Sramek wrote: > > The problem is demonstrated by the attached files, which show pixel > overlays of documents rendered in LO a MSOffice. There are some > differences visible also in the 'good' file, but these are much bigger > in the 'bad' one where

Re: What is the best way to pass a flag from a unit test?

2017-02-01 Thread Khaled Hosny
On Wed, Feb 01, 2017 at 10:41:33AM +0100, Miklos Vajna wrote: > Hi Khaled, > > On Wed, Feb 01, 2017 at 09:38:02AM +0200, Khaled Hosny > <khaledho...@eglug.org> wrote: > > What the best way to detect, inside VCL, that a given CppunitTest is > > being run and

What is the best way to pass a flag from a unit test?

2017-01-31 Thread Khaled Hosny
What the best way to detect, inside VCL, that a given CppunitTest is being run and do something conditionally? I basically want to detect if a given class of unit tests is run and disable all font searching and fallback and just use a hard-coded font name so that the tests are not affected by what

[Libreoffice-commits] core.git: vcl/README.vars vcl/source

2017-02-01 Thread Khaled Hosny
vcl/README.vars|2 ++ vcl/source/font/PhysicalFontCollection.cxx | 11 +++ 2 files changed, 13 insertions(+) New commits: commit 55916dfc59f05537c4e6fece77aef3cc1dbef34c Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Feb 1 10:32:32 2017

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

2017-01-31 Thread Khaled Hosny
On Fri, Jan 20, 2017 at 08:20:54PM +0100, Regina Henschel wrote: > Hi Khaled, > > Khaled Hosny schrieb: > > On Fri, Jan 20, 2017 at 04:55:56PM +0100, Regina Henschel wrote: > > > Hi, > > > > > > Khaled Hosny schrieb: > > > > > > >

[Libreoffice-commits] core.git: 3 commits - include/vcl svtools/source vcl/inc vcl/unx

2017-02-08 Thread Khaled Hosny
deletions(-) New commits: commit b27324d219ea14249fcc0827658a955de54f4250 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Feb 8 19:44:26 2017 +0200 Outdated comment, we are returning a reference! Change-Id: I4061f9f421666064f918d8a46375f7f770626ab6 diff --git a/vcl/i

[Libreoffice-commits] core.git: vcl/win

2017-02-08 Thread Khaled Hosny
vcl/win/gdi/salfont.cxx |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) New commits: commit 026345eeb2aa9fca02bc055f28ebd34abd7ad680 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Feb 9 00:18:10 2017 +0200 Don’t look for bundled fonts relative to exec

[Libreoffice-commits] core.git: vcl/inc vcl/source

2017-01-20 Thread Khaled Hosny
vcl/inc/salglyphid.hxx |5 - vcl/source/gdi/sallayout.cxx |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) New commits: commit ae0a317c20110ade8b9eaef3ecbd2c5781303649 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sat Jan 21 03:00:19 2017 +0200

[Libreoffice-commits] core.git: vcl/source

2017-01-20 Thread Khaled Hosny
vcl/source/gdi/sallayout.cxx |6 -- 1 file changed, 6 deletions(-) New commits: commit efd58dee26a534ba89d41efff44821b2d8967928 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sat Jan 21 03:27:12 2017 +0200 This does not seem to be needed Cha

[Libreoffice-commits] core.git: vcl/inc vcl/source

2017-01-27 Thread Khaled Hosny
vcl/inc/sallayout.hxx|1 - vcl/source/gdi/sallayout.cxx |7 --- 2 files changed, 8 deletions(-) New commits: commit 7c2e96a4e7733e315bf948dd89a5d804cef5e67e Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Jan 27 18:16:22 2017 +0200 DisableGlyphInjectio

[Libreoffice-commits] core.git: bridges/Module_bridges.mk configure.ac distro-configs/LibreOfficeEmscripten.conf external/icu include/osl include/sal sal/osl solenv/gbuild vcl/CppunitTest_vcl_wmf_test

2017-02-21 Thread Khaled Hosny
(-) New commits: commit 0e21f6619c72f1e17a7b0a52b6317810973d8a3e Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Feb 20 22:57:00 2017 +0200 Kill bitrot Emscripten experiment Change-Id: I1cd5331157e684afb01e6555168ce646194c6ff2 Reviewed-on: https://gerrit.libreoffi

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - include/vcl sw/source vcl/source

2017-02-22 Thread Khaled Hosny
: Khaled Hosny <khaledho...@eglug.org> Date: Sun Feb 19 22:21:40 2017 +0200 Fix visible space on Mac with the new layout engine This is not an issue on master since the alternative Mac code path is gone, but we need to skip it in 5.3 when the old layout engine is not

[Libreoffice-commits] core.git: vcl/source

2017-02-20 Thread Khaled Hosny
vcl/source/fontsubset/cff.cxx | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) New commits: commit fc711de31b57e0f4d4c4615ef4fd201425cd9f47 Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Feb 20 19:22:53 2017 +0200 IGNORE_HINTS have neve

[Libreoffice-commits] core.git: lingucomponent/source

2017-02-20 Thread Khaled Hosny
lingucomponent/source/spellcheck/spell/sspellimp.cxx | 160 +-- lingucomponent/source/spellcheck/spell/sspellimp.hxx | 20 +- 2 files changed, 90 insertions(+), 90 deletions(-) New commits: commit 2d028dfe846a4dccb8b4572cc51f2b57f0305d61 Author: Khaled Hosny <khale

[Libreoffice-commits] core.git: linguistic/source

2017-02-20 Thread Khaled Hosny
linguistic/source/spelldsp.cxx | 72 - linguistic/source/spelldsp.hxx | 26 +++--- 2 files changed, 49 insertions(+), 49 deletions(-) New commits: commit 2759a1260db7f8642e085dd117a0c05215f52bdf Author: Khaled Hosny <khaledho...@eglug.org>

[Libreoffice-commits] core.git: vcl/quartz

2017-02-22 Thread Khaled Hosny
vcl/quartz/ctfonts.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 04d086531ff4a3ab24b704489270c7c23792bd20 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Feb 22 23:56:19 2017 +0200 tdf#104509: Fix GetGlyphBoundRect

[Libreoffice-commits] core.git: config_host/config_liblangtag.h.in config_host.mk.in configure.ac distro-configs/LibreOfficeOssFuzz.conf external/libetonyek i18nlangtag/CppunitTest_i18nlangtag_test_la

2017-02-24 Thread Khaled Hosny
| 590 -- 12 files changed, 18 insertions(+), 813 deletions(-) New commits: commit 8dc27a0bbf74646969074414c071410ad7d07b74 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Feb 21 12:36:55 2017 +0200 Always enable liblangtag The license should not be an issue an

Re: Chart test failures on mac: text size differences

2017-02-24 Thread Khaled Hosny
On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote: > Hi Khaled, > > I see you're working on text rendering, so I thought that my findings > might be usefull for you. I had a look at chart test failures on Mac > and found that it is because of text size differences. (I checked your >

Re: Chart test failures on mac: text size differences

2017-02-25 Thread Khaled Hosny
On Sat, Feb 25, 2017 at 12:04:10PM +, Tamas Zolnai wrote: > Hi Khaled, > > On Friday, February 24, 2017 19:40 GMT, Khaled Hosny <khaledho...@eglug.org> > wrote: > > > On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote: > > > Hi Khaled, >

Re: Chart test failures on mac: text size differences

2017-02-25 Thread Khaled Hosny
I missed the attachments! On Sat, Feb 25, 2017 at 11:23:51PM +0200, Khaled Hosny wrote: > On Sat, Feb 25, 2017 at 12:04:10PM +, Tamas Zolnai wrote: > > Hi Khaled, > > > > On Friday, February 24, 2017 19:40 GMT, Khaled Hosny > > <khaledho...@eglug.org> wrote

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/quartz

2017-02-23 Thread Khaled Hosny
vcl/quartz/ctfonts.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 659a38ba7678c7a62ba0872f390c59329daadb90 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Feb 22 23:56:19 2017 +0200 tdf#104509: Fix GetGlyphBoundRect

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/quartz

2017-02-23 Thread Khaled Hosny
vcl/quartz/ctfonts.cxx | 13 + 1 file changed, 13 insertions(+) New commits: commit 0a0b98ae530c7f27c2f790a889f3edbfc98858bd Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Dec 12 14:51:32 2016 +0200 Don’t return false for blank

[Libreoffice-commits] core.git: include/vcl vcl/source

2017-02-11 Thread Khaled Hosny
include/vcl/outdevstate.hxx |5 ++--- vcl/source/outdev/text.cxx |3 --- 2 files changed, 2 insertions(+), 6 deletions(-) New commits: commit 72a311533a6b89dc7b268e2d6626816b24fcc61a Author: Khaled Hosny <khaledho...@eglug.org> Date: Sat Feb 11 18:14:23 2017

Re: system-wide location for dictionary files and dictionary file name format

2017-02-15 Thread Khaled Hosny
On Wed, Feb 15, 2017 at 12:42:22PM +, Caolán McNamara wrote: > > Hmm, it seems language tags such as ‘nl’ or ‘fr’ without a region > > component, and which are valid according to bcp47 are not recognized > > by LO. Is this a bug I should report? > > Only if you intend to work on solving it,

Re: minutes of ESC call ...

2017-02-16 Thread Khaled Hosny
On Thu, Feb 16, 2017 at 03:43:18PM +, Michael Meeks wrote: > AI: + test build configuations (Norbert) > + Is there any gain of functionality with 2015 ? Not a gain in functionality, but VS 2015 is much easier to find on MS website than 2013, last time I hat to setup a Windows machine (a

Re: minutes of ESC call ...

2017-02-17 Thread Khaled Hosny
On Thu, Feb 16, 2017 at 09:27:46PM -0700, slacka wrote: > I really hope that hour search was a bad joke. Google "Download VS 2013" and > the first link is the download link for the installer. Did you check the link? It gives you a generic download page that only offer the latest version.

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - i18npool/source

2017-01-18 Thread Khaled Hosny
i18npool/source/transliteration/ignoreDiacritics_CTL.cxx | 51 --- 1 file changed, 29 insertions(+), 22 deletions(-) New commits: commit c1836f857f706c277535428a529db82fa6aeb031 Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Jan 17 15:15:36 2017 +0200 Some cl

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - i18npool/inc i18npool/source

2017-01-17 Thread Khaled Hosny
i18npool/inc/transliteration_Ignore.hxx | 19 +++ i18npool/source/transliteration/ignoreDiacritics_CTL.cxx | 79 +-- 2 files changed, 87 insertions(+), 11 deletions(-) New commits: commit 18bc169b4727744f35227532078cbf7c9558bc9a Author: Khaled Hosny <khale

[Libreoffice-commits] core.git: i18npool/source

2017-01-17 Thread Khaled Hosny
i18npool/source/transliteration/ignoreDiacritics_CTL.cxx | 51 --- 1 file changed, 29 insertions(+), 22 deletions(-) New commits: commit fa2eb4b43fc872c171129d477cfabe9fa29d78ce Author: Khaled Hosny <khaledho...@eglug.org> Date: Tue Jan 17 15:15:36 2017 +0200 Some cl

[Libreoffice-commits] core.git: configure.ac

2017-01-16 Thread Khaled Hosny
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5cd7b656de392a6dcd05cd55cf9d330c0ab5cd07 Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Jan 16 16:13:55 2017 +0200 Enable Chart XShape tests on Windows by default They pas

[Libreoffice-commits] core.git: i18npool/inc i18npool/source

2017-01-17 Thread Khaled Hosny
i18npool/inc/transliteration_Ignore.hxx | 19 +++ i18npool/source/transliteration/ignoreDiacritics_CTL.cxx | 79 +-- 2 files changed, 87 insertions(+), 11 deletions(-) New commits: commit 278eabab2b5bdc95a51d501fcdb46c216ded3baa Author: Khaled Hosny <khale

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

2017-01-20 Thread Khaled Hosny
On Fri, Jan 20, 2017 at 12:24:05AM +0100, Regina Henschel wrote: > Hi Michael, > > Michael Stahl schrieb: > > On 19.01.2017 18:28, Regina Henschel wrote: > > > Hi, > > > > > > the build still breaks, now with error > > > > > > C:\LO_buildDebug\core\include\rtl/ref.hxx(100) : error C2027: use of

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

2017-01-20 Thread Khaled Hosny
On Fri, Jan 20, 2017 at 04:55:56PM +0100, Regina Henschel wrote: > Hi, > > Khaled Hosny schrieb: > > > Hmm, interesting. They don’t fail for me or in the CI builds, I wonder > > what is different on your system that would cause most of the tests to > > fail? &

[Libreoffice-commits] core.git: vcl/qa

2017-02-27 Thread Khaled Hosny
vcl/qa/cppunit/complextext.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 0d9a6aa1b9debc2ca4bd1cbf6d089047267575f5 Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Feb 27 13:07:31 2017 +0200 Stop the spam Cha

[Libreoffice-commits] core.git: vcl/qa

2017-02-28 Thread Khaled Hosny
vcl/qa/cppunit/complextext.cxx | 10 ++ 1 file changed, 10 insertions(+) New commits: commit 62592cf1ebcc8ef381fe53855684342d963e6138 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Mar 1 01:38:58 2017 +0200 Add a test for GetTextArray() Might help s

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3-1' - vcl/quartz

2017-03-02 Thread Khaled Hosny
vcl/quartz/ctfonts.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7dc1f5da3581c048d977cb18699fd44ea1c4d465 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Feb 22 23:56:19 2017 +0200 tdf#104509: Fix GetGlyphBoundRect

Re: Chart test failures on mac: text size differences

2017-03-02 Thread Khaled Hosny
On Tue, Feb 28, 2017 at 11:02:30PM +, Tamas Zolnai wrote: > Hi Khaled, > > > I don’t think text width or height are that interesting, but they are > > probably a good approximation, so I repurposed one of the existing VCL > > tests to test this[1]. I tried testing also the text bounding

[Libreoffice-commits] core.git: vcl/qa vcl/quartz

2017-02-26 Thread Khaled Hosny
vcl/qa/cppunit/complextext.cxx |3 --- vcl/quartz/ctfonts.cxx |9 + 2 files changed, 5 insertions(+), 7 deletions(-) New commits: commit af871d02914c9fc6a08079f67b4af71a198e166a Author: Khaled Hosny <khaledho...@eglug.org> Date: Mon Feb 27 00:44:14 2017 +0200

Re: Tinderbox failure, Linux-rpm_deb-x86@71-TDF-dbg, MASTER, last success: 2017-02-26 19:58:26

2017-02-26 Thread Khaled Hosny
On Mon, Feb 27, 2017 at 01:02:07AM +, lohmaier+tinder...@gmail.com wrote: > VclComplexTextTest::testArabic finished in: 90ms > complextext.cxx:64:Assertion > Test name: VclComplexTextTest::testArabic > equality assertion failed > - Expected: 71x14@(0,1) > - Actual : 70x14@(1,1) :( Any idea

[Libreoffice-commits] core.git: vcl/qa

2017-02-26 Thread Khaled Hosny
vcl/qa/cppunit/complextext.cxx | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) New commits: commit eb7b03b052ffe8c2c577b2349987653db6c53f76 Author: Khaled Hosny <khaledho...@eglug.org> Date: Sun Feb 26 21:52:28 2017 +0200 Make vcl_complextex

Re: Chart test failures on mac: text size differences

2017-02-26 Thread Khaled Hosny
On Sat, Feb 25, 2017 at 09:58:58PM +, Tamas Zolnai wrote: > Hi Khaled, > > > > However I think it would be better to debug this problem with a unit > > > test in vcl module which tests directly the text rendering. I would > > > suggest that if you are working making text rendering consitent.

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sw/source

2016-09-02 Thread Khaled Hosny
sw/source/uibase/docvw/edtwin.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit 438a76a9a261b9ada7b2758a66cd935d1760da39 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Sep 1 13:20:41 2016 +0200 tdf#101361: Fix cursor key movement in RTL text

[Libreoffice-commits] core.git: sw/source

2016-09-01 Thread Khaled Hosny
sw/source/uibase/docvw/edtwin.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit 67192b3cfa54be7b0b60d450783ac2ac4c38bbc6 Author: Khaled Hosny <khaledho...@eglug.org> Date: Thu Sep 1 13:20:41 2016 +0200 tdf#101361: Fix cursor key movement in RTL text

Failing tinderboxes spam

2016-09-04 Thread Khaled Hosny
Hi, I don’t work on LibreOffice on regular basis, but whenever I do always get spammed with those failing tinderboxes, so much that I just delete them on sight now. So whatever purpose they meant to serve, they no longer do it for me and if I really broke the build I won’t notice it. I don’t

[Libreoffice-commits] core.git: sd/source

2016-08-30 Thread Khaled Hosny
sd/source/core/drawdoc.cxx |5 - 1 file changed, 5 deletions(-) New commits: commit cf425acfd4a5ff7c660523601964d45cbad74b53 Author: Khaled Hosny <khaledho...@eglug.org> Date: Fri Aug 26 15:19:26 2016 +0200 tdf#56403: Text is right aligned in RTL locales Draw/I

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source

2016-09-07 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit f70bc91c154a9076809599c5a44e05ece5f615b6 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Sep 7 23:26:14 2016 +0200 Another optimization Don’

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 140 commits - android/source chart2/source compilerplugins/clang config_host.mk.in configure.ac cppuhelper/qa cui/source cui/uiconfig

2016-09-09 Thread Khaled Hosny
Rebased ref, commits from common ancestor: commit 044f956d279a87a34d26674b67bcfd631b4d7424 Author: Khaled Hosny <khaledho...@eglug.org> Date: Wed Sep 7 23:26:14 2016 +0200 Don’t check glyph class unnecessarily Don’t call hb_ot_layout_get_glyph_class() unless the glyph a

<    2   3   4   5   6   7   8   9   10   11   >