is associated with Excel
backup file. It's the file Excel creates automatically when opening a
document as a backup. The content of this file is still a normal Excel
file, so there is no reason not to open such files correctly.
Review sign-off etc appreciated.
Kohei
--
Kohei Yoshida, LibreOffice
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Maciej,
On Wed, Jul 20, 2011 at 5:24 PM, Maciej Rumianowski
maciej.rumianow...@gmail.com wrote:
I'm working further on Bug 38831 - [EasyHack] Get rid of SV_DECL_VARARR,
SV_DECL_VARARR_PLAIN, SV_DECL_VARARR_SORT ...
Where can I mark that I'm working on it? In Bug comments?
Well, you can
/libreoffice/calc/commit/?id=514fa420a68076537adfc8d7344a20e8c0baa3f3
Review and sign-off appreciated.
Looks good. Pushed to 3-4 with my sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
even when
no dp objects were deleted.
Review sign-off appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On Mon, 2011-07-25 at 10:40 -0400, Kohei Yoshida wrote:
Hi there,
I'd like to have
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=e5d0ab65f918a3a90d1b7fa4fdf7ee5c2ee89535
cherry-picked to the -3-4 branch.
As I talked to Michael on IRC, we are probably interested in putting
On Mon, 2011-07-25 at 10:46 -0400, Kohei Yoshida wrote:
So, the actual change against the original code is
much smaller when you combine this commit with my last change.
This is the combined change for the ease of reviewing.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh
into it
yet.
Regards,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Tue, 2011-07-26 at 01:37 -0400, Kohei Yoshida wrote:
There is one minor issue. The dialog that gets launched from the Change
Password button also contains the optional password input for modifying
document, and setting a new password there doesn't appear to change the
modify-document
On Tue, 2011-07-26 at 18:25 +0100, Michael Meeks wrote:
On Tue, 2011-07-26 at 10:37 -0400, Kohei Yoshida wrote:
Just to spell out my intention more clearly, if nobody disagrees that
this minor quirk will not cause any issues (after all, right now, the
whole functionality is not working
things instead of going on a rampage to put a blame on those who
work hard to improve the code base.
I'm pretty sure you mean well, but I'm just a bit concerned about your
tone of voice in your email.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
On Tue, 2011-07-26 at 14:34 -0400, Kohei Yoshida wrote:
On Tue, 2011-07-26 at 18:25 +0100, Michael Meeks wrote:
On Tue, 2011-07-26 at 10:37 -0400, Kohei Yoshida wrote:
Just to spell out my intention more clearly, if nobody disagrees that
this minor quirk will not cause any issues (after
replace dialog code while fixing on
master.
Having said all this, I'm just one developer, and this is just my
personal opinion. And I would be interested to hear from other folks as
well.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
Hi Samphan,
On Wed, 2011-07-27 at 16:12 +0700, Samphan Raruenrom wrote:
Last year I've done a comparison of memory usage on Windows between
OpenOffice.org Calc 3.1 and MS Excel 2003/2007 for spreadsheets with
simple formula of various size. I found that Calc take a lot more
memory than Excel
On Fri, 2011-07-22 at 23:59 +1000, Troy Rollo wrote:
This replaces the earlier version of this patch, which was wrong for the
NUMBER_FULL_CONTEXT cross-reference type.
I believe this is Cedric's area, but he is on vacation at the moment.
I'm also CC'ing Lubos as well since I've seen him make
.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
and subsequent numbering levels.
This one also put in queue for Cedric and Lubos.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
), just an sprmPIlvl and an sprmPIlfo. Therefore there
was no call to SwWW8ImplReader::Read_POutLvl to set nOutlineLevel.
And this one too (in queue for Cedric and Lubos for review).
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
On Thu, 2011-07-21 at 23:27 +1000, Troy Rollo wrote:
The first part of this patch adds importing of cross-references to numbered
paragraphs from docx file.
I believe this one has been replaced by your other patch submitted on
Friday, July 22nd. No need to follow up on this.
Kohei
that is modified is used *only* by vba api implementation code
so shouldn't affect ordinary calc operations at all.
Hmm... did you forget to attach your patch by any chance? I tried to
cherry-pick the commits you referenced from master, but they don't apply
cleanly...
Kohei
--
Kohei Yoshida
Hi Noel,
On Wed, 2011-07-27 at 20:08 +0100, Noel Power wrote:
Hi Kohei,
On 27/07/11 19:23, Kohei Yoshida wrote:
Hi Noel,
On Wed, 2011-07-27 at 11:50 +0100, Noel Power wrote:
I would really like to get this patch into 3.4,
[...]
Hmm... did you forget to attach your patch by any
. ;-)
I hope I'm making sense
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
svtools/source/misc/acceleratorexecute.cxx
The one in framework doesn't even get built, so I assume it's okay to
remove that one in the framework module. Anyone who might know more on
this and care to disagree? Let me know.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
. :-)
With that, I've removed the one in framework on master.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Forgot to say [PUSHED].
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Sat, 2011-07-30 at 17:43 +0200, Eike Rathke wrote:
Hi Kohei,
On Saturday, 2011-07-30 11:10:22 -0400, Kohei Yoshida wrote:
Just committed your patch to master.
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=2315d239302e4b2aa65971bcaf5909654973ab5e
Thanks, but somehow
build ) Could you do the honours and review/commit ?
Sure. Pushed to the 3-4 branch with my sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
On Tue, 2011-08-02 at 21:43 +0200, Markus Mohrhard wrote:
Hello,
this patch checks if we have a local ScRangeName before it tries to
use it.
I consider this patch safe and think it should be in 3-4 so Review
Sign-off appreciated.
I concur. Pushed to 3-4 with my sign-off.
Kohei
-pick it to libreoffice-3-4 branch.
http://cgit.freedesktop.org/libreoffice/impress/commit/?id=061ecea4152845422123ff66f1829c31f29466d1
Verified the fix, and pushed to 3-4 with my sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
to master.
Yup, the patch makes sense should be safe. Pushed to 3-4 with my
sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org
On Wed, 2011-08-03 at 03:22 +0200, Markus Mohrhard wrote:
Hello,
this patch adds a necessary check for a null pointer.
Simple enough. Pushed to 3-4.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing
), calling clear() on an empty vector does
nothing is harmless. So just calling clear() should be fine without
checking for empty-ness.
Other than that, the rest looks okay to me. I'd prefer someone more
experienced in Writer's code to sanity-check though.
Kohei
--
Kohei Yoshida, LibreOffice
to fix that in your remaining GSOC time. But if you
can implement the scrollbar and still have time left, let's look into
that.
Regards,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice
a VARARR WW8Bytes which should
be migrated to ww::bytes. Is it okay to do?
Yeah, that looks reasonable. Unless someone who knows more about
writer's code than I objects, and objects soon, I'd say go for it. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
Marking it [PUSHED].
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
many uses of such abuse, but they are
there in some corners.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
the internal size of the symbol remains the
same no matter which symbol types are selected.
Regards,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
that invalidated the stream.
Looks good.
I concur. Pushed to the 3-4 branch with my sign-off (plus Eike's).
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
the bug may occur with any cell content of STRLEN_MAX (64k)
characters and also other modules that use the EditEngine.
Yup, looks good. Cherry-picked to the 3-4 branch.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
::ODFVER_012)
and drop the additional method you added in your patch.
Conditionalizing for the ODF version 1.2 or above is common enough that
it is done in many other places, and this is how it is done there.
Other than that, the patch looks good safe.
Kohei
--
Kohei Yoshida, LibreOffice hacker
Hi Norbert,
On Sat, Aug 6, 2011 at 4:38 PM, Norbert Thiebaud nthieb...@gmail.com wrote:
The One Git conversion is done.
Just want to make sure I understand our plan correctly. The core
repository is for the master branch and future releases, while the 3.4
releases and older will still be done
On Sun, 2011-08-07 at 18:27 +0200, Markus Mohrhard wrote:
changed it and pushed to master:
Looks good. Pushed the attached patch to the 3-4 branch with my
sign-off.
Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Mon, 2011-08-08 at 17:30 +0200, Markus Mohrhard wrote:
Hello,
this patch makes our check for existing named ranges in
Insert-Names-Define case insensitive. Our formula compiler is
already case insensitive so we shouldn't be able to create two named
ranges with the same case insensitive
Marked [PUSHED 3-4].
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Mon, Aug 8, 2011 at 3:49 PM, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
Hello,
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=41f8f6d3503e91f23a6d58cbab5ae314f663aab9
changes delete to delete[] for a pointer that was created with new[].
I think it should be included
Can you double-check the bug number?
https://bugs.freedesktop.org/show_bug.cgi?id=37319
is closed as INVALID. I don't think this is the bug you are referring
to...
Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
very much appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
From 0e83658f97696e498ebbc616056fe1a4089ce321 Mon Sep 17 00:00:00 2001
From: Kohei Yoshida kohei.yosh...@suse.com
Date: Tue, 9 Aug 2011 15:49:15 -0400
Subject: [PATCH] Correctly import from Excel charts
On Tue, 2011-08-09 at 22:56 +0200, Markus Mohrhard wrote:
Given all this, I would feel a little more comfortable nailing
this on
master the right way, and *then* see if the change is safe
enough to be
backported to the 3.4 branch.
No
on the other hand hardly imagine that it hasn't been tracked
already..
I saw Miklos and Caolan discussing something like this today on IRC.
Not sure if it's the same thing or not.
B. Do we already have a QA mail list?
Yes. libreoffice...@lists.freedesktop.org.
HTH,
Kohei
--
Kohei Yoshida
and decrementing the
column / row position, to be consistent with the previous if statement
which checks the next position before moving the position, not after.
So, attached is my proposed change.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
diff --git a/sc/source/ui/view/tabview2
there.
Thanks a lot,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Wed, 2011-08-10 at 22:07 -0400, Kohei Yoshida wrote:
I'll push to master once my master build finishes there.
Now pushed to master as well.
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice
. The old,
split-repositories-based system is no more, except for the older 3.3.x
and 3.4.x branches.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
it to 3.4
Just my opinion.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
-www.libreoffice.org/extern/ccache.exe
Hmm... Is this binary right? I can actually read the content of this
exe file and it looks like an html file. ;-)
Not to mention I have trouble executing this...
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
On Thu, 2011-08-18 at 23:29 +0200, Thorsten Behrens wrote:
Kohei Yoshida wrote:
Hmm... Is this binary right? I can actually read the content of this
exe file and it looks like an html file. ;-)
*blush* - better now? ;)
Yup. A lot better. Now it looks more like an executable
So, I was looking into a mysterious build breakage in forms (on
WIndows). It would fail at link time due to missing external symbols.
It was expecting to find those symbols from icuin.lib, which is a
static library file generated from the icu module.
The funny thing is, when I do
cd icu
rm -rf
--. It looks a bit asymmetric. Of
course, it might be correct but...
I had already commented in bugzilla, but the patch not only breaks the
symmetry it changes the expected behavior. So, it's not the right way
to fix it.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
. But if you need to
give me more updates, feel free to send me patches daily. I'll probably
start my evaluation sometime mid-week and I'll use whatever code is
available that time to do a final evaluation.
Good stuff!
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
On Mon, 2011-08-22 at 09:13 -0400, Kohei Yoshida wrote:
Your patch remove only the first nCol--. It looks a bit asymmetric. Of
course, it might be correct but...
I had already commented in bugzilla, but the patch not only breaks the
symmetry it changes the expected behavior. So, it's
with no gain.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Mon, 2011-08-22 at 22:47 +0200, Francois Tigeot wrote:
Are we sure that all supported *ixes have CUPS available nowadays?
Pretty much. CUPS runs on AIX, the five *BSDs and Linux.
What about Windows?
I just got the configure failure not finding CUPS on Windows.
Kohei
--
Kohei Yoshida
still need to modify the original base class to have the
additional boolean member (m_bFireEvent) in order for the fire() method
to see that member and use it in that method. I suppose there is no way
around it (?)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
in the
OPropertySetHelper.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Mon, 2011-08-22 at 19:06 -0400, Kohei Yoshida wrote:
BTW, how do you plan to use that m_bFireEvent data member to decide to
skip or fire events in OPropertySetHelper::fire() ? The method that
needs to be influenced by that boolean is still in the
OPropertySetHelper.
Actually
On Tue, 2011-08-23 at 17:00 +0200, Lionel Elie Mamane wrote:
Any better idea?
I'm still holding on to my earlier evil idea. To me making a duplicate
is starting to feel like lesser of an evil.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
to implement as long as
it conforms to the agreed-upon interfaces. Exposing the
*implementation* of the interface to the extensions basically throws
away that freedom, and we are paying for that now.
So, no, it's definitely NOT worth the cost.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
. :-P
Thanks a lot,
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Tue, 2011-08-23 at 11:11 -0400, Kohei Yoshida wrote:
On Tue, 2011-08-23 at 17:00 +0200, Lionel Elie Mamane wrote:
Any better idea?
I'm still holding on to my earlier evil idea. To me making a duplicate
is starting to feel like lesser of an evil.
Anyway, don't listen to my ramblings
=8f931c854038dada37b96db32a0b68ffe52981fa
cppunittester was crashing for the right reason as it turned out. This
has nothing to do with make.
Please run git pull -r and try again.
FYI, this was the last fix I had to put in in order to get master to
build on Windows all the way through.
Kohei
--
Kohei
Hi Markus,
On Sat, Aug 27, 2011 at 9:24 AM, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
It would be nice if someone could give it a quick review before I push it.
Looks good to me. The second hunk was a bit hard to grok, but I came
to the same conclusion as you did.
Especially the
this is where Thorsten pushed your patches to?
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
). And because the size and position of the
page/row/column/data field areas are absolute, this caused the layout
breakage on XP.
Review sign-off appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
From 83c6787d538e556d4410bf96d41e36a7a7d58e7d Mon Sep 17 00:00:00
how to make effective use of
git's branches.
HTH,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
to confirm that your patch is under LGPLv3+/MPL 1.1 ?
Thanks,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
JYI, I cherry-picked this commit by Eike
http://cgit.freedesktop.org/libreoffice/core/commit/?id=61674465b74f60d7ddb2d7a0fa0e17c9990f6301
to the 3-4 branch with my sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
LibO, not LO, as the official abbreviation of
LibreOffice. So, I would change LO to LibO.
BTW great hacking. I'll start considering you a part of the core
developers. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
even without interacting with the ODF TC
stuff, so I don't want to give people the wrong impression that I'm the
one to talk to for all ODF needs, to avoid unnecessary frustration on
both sides.
Thanks,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
On Thu, 2011-09-01 at 03:15 +0200, Khaled Hosny wrote:
BTW, I see you merged the three patches in one commit, though I thought
splitting them into more confined changes would be preferred. Is there
any general policy for this that I can follow in future patches?
Well, I started this page
of the dialog itself.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
also.
Do you agree with the mapping? You can also look at
http://wiki.documentfoundation.org/User:Regina/DraftAdditionalSymbolsInCharts
I read the page, and to the best of my ability your mapping makes sense.
Thanks for the very detailed analysis.
Kohei
--
Kohei Yoshida, LibreOffice hacker
performance of binary Excel documents since the xls import filter
currently re-uses the range name storage to emulate shared formulas.
Review and sign-off appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
From 393f4815499c79575cb46952ecdaa9bb58918dc9 Mon Sep 17 00:00:00 2001
From: Kohei
there, I just need to make sure that we are on the same
page wrt keeping the new algorithm and moving on to fixing whatever
needs fixing.
Regards,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice
Hi Norbert,
On Sat, Sep 3, 2011 at 10:05 PM, Norbert Thiebaud nthieb...@gmail.com wrote:
I know I should use a better email
client than gmail... but until I finally get around to develop a
reasonable proficiency in mutt, extracting patch from inline content
is pretty error prone (line
Hi Eike,
On Sun, Sep 4, 2011 at 7:09 PM, Eike Rathke o...@erack.de wrote:
On Friday, 2011-09-02 17:13:22 -0400, Kohei Yoshida wrote:
I'd like to have the attached patch reviewed and pushed to the -3-4
branch.
That would also need
http://cgit.freedesktop.org/libreoffice/core/commit/?id
Cor,
On Sun, Sep 4, 2011 at 4:38 PM, Cor Nouws oo...@nouenoff.nl wrote:
- How much time can one annoying bug ask? Two day, two weeks?
e.g. https://bugs.freedesktop.org/show_bug.cgi?id=40466#c10
Hmm... I don't see the relevance of my comment in the bug to what you
are stating here. What do
Hi Eike,
On Sun, Sep 4, 2011 at 8:39 AM, Eike Rathke o...@erack.de wrote:
But based on what I'm seeing on this thread, I take that the new glyph
metric calculation algorithm is the correct way? If so, then we'll have
to make some adjustments to some of the size sensitive areas to bring
Hi there,
While looking into SfxItemPool, trying to understand how this thing
works, I've noticed that it has #ifdef TF_POOLABLE stuff all over the
place. Is there any reason why we need to have this, or is it okay to
just pick one variant and remove the other?
Kohei
--
Kohei Yoshida
On Tue, 2011-08-30 at 16:55 -0400, Kohei Yoshida wrote:
Hi there,
I'd like to have
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bf60230255e0e8da66cafff578f148858cee4ca
cherry-picked to the 3.4 branch. A patch for this commit is attached as
well for convenience
On Thu, 2011-09-08 at 16:28 +0100, Michael Meeks wrote:
AA: + give mdds website / commit rights out more diversly
(Kohei)
This is already done. Now Caolan and David should have the same rights
as I do.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
code changes
Oh come on. Save us the lecture there. We are all aware of the risks
of large code changes. So we are limiting that until we hit a code
freeze. Isn't that reasonable?
I'm very very confused.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
is non-trivial, so I have to dig a little more to understand this code
change...
Regards,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On Tue, 2011-09-13 at 11:33 -0400, Kohei Yoshida wrote:
Having said this, this problem already exists before your changes, so
I'm fine cherry-picking these commits to at least fix the reported
case.
Let me do a little more review before making the final call. The
change
is non-trivial, so I
-4 branch with my sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
://bugs.freedesktop.org/show_bug.cgi?id=35965
Review sign-off appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Markus,
On Wed, Sep 14, 2011 at 12:04 PM, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
Pushed to the 3-4 branch with my sign-off.
It has the big disadvantage that it makes inserting several sheets at the
end extremely slow. It forces for every new sheet a full recalculation now.
On Fri, 2011-09-16 at 12:06 +0200, Cor Nouws wrote:
Hi,
Older build (last week): ID: 11df18b-3f8994a-4525197
New spreadsheet
Type Mango
next row
try to type Melon
immediately Mango is placed
Turn off experimental feature, re-start Calc and try again.
Kohei
--
Kohei
On Mon, Sep 19, 2011 at 3:18 PM, Cor Nouws oo...@nouenoff.nl wrote:
Kohei Yoshida wrote (19-09-11 15:45)
Turn off experimental feature, re-start Calc and try again.
Indeed. Thanks,
Work related to new row height?
No. It's most likely due to Anurag's GSOC work to support multiline
formula
they must be repaired
Acknowledged. We can tackle these at a later time; not that pressing
issues IMO.
Great and thorough work by the way. I can see the level of details you
put into your work. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
901 - 1000 of 5163 matches
Mail list logo
