Re: How to make unokywds.hxx from module sd usable for svdlayer.cxx in module svx?

[Regina Henschel]

Hallo Stephan,

Stephan Bergmann schrieb am 18-Sep-18 um 16:53:

On 18/09/2018 16:21, Regina Henschel wrote:

The file unokywds.hxx containes a lot of string definitions. My case
is about sUNO_LayerName_controls, which is "controls".

The ctor of LayerAdmin in svdlayer.cxx has the wrong text "Controls"
instead of "controls". I have now simple set the correct text to
verify that is solved the problems. But I would like to use
sUNO_LayerName_controls to avoid such error in the future.

How to do that?


By moving sd/source/ui/inc/unokywds.hxx to a suitable include/ sub-dir,
presumably include/svx/ if that's the lowest module that would use it


What do you mean by "lowest"?


(and probably renaming the file, to reflect that it contains sd-specific
strings; and adapting the file's INCLUDED_... macro to reflect its new
place/name).  Remember to adapt solenv/clang-format/blacklist when
moving a file listed there.

(unokywds.hxx only contains static const variables, so including it from
somewhere else than Library_sd should be fine.)


Oh, that is a larger change. I suspect it is better done separate from 
my current changes from localized to real layer names.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

How to make unokywds.hxx from module sd usable for svdlayer.cxx in module svx?

[Regina Henschel]

Hi all,

The file unokywds.hxx containes a lot of string definitions. My case is 
about sUNO_LayerName_controls, which is "controls".


The ctor of LayerAdmin in svdlayer.cxx has the wrong text "Controls" 
instead of "controls". I have now simple set the correct text to verify 
that is solved the problems. But I would like to use 
sUNO_LayerName_controls to avoid such error in the future.


How to do that?

Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Review for "tdf#67248 Use localized layer name only for display in UI"

[Regina Henschel]

Hi all,

this is about https://gerrit.libreoffice.org/60507

The problem described in "Bug 67248 - FILEOPEN Layer with reserved name 
vanishes when changing UI language" has its reason in the fact, that LO 
uses localized layer names internally. So when you use a layer 
"Hintergrund" in an English UI and someone else with a German UI opens 
the file, the layer Hintergrund has vanished, because the German UI 
interprets "Hintergrund" as standard layer. Or another test: In an 
English UI add the layers "controls" and "background" (notice the lower 
characters at start of the layer name). Save the document and reload it.


In the long run the name of the layer should become authoritative for 
identifying a layer, so that we can omit "SdrLayerIDSet" bitfield at 
least in Draw/Impress. Therefore I have started to change the 
implementation to use the real layer names; that are those names, which 
occur in the saved file. That makes the layer names unambiguous.


But that is a deep change. And therefore I want to ask you, whether you 
agree with this approach. I have started work for to test, whether it 
would work at all. The result is in the mentioned patch 60507. It fixes 
the bug, but has still some UI deficiencies and tests are missing. But I 
will not go further, until I know your opinion.


In case you agree with the approach, it would be nice, if you reported 
all problems to me, which you have noticed while reviewing the patch.


Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Need help on how to insert a layer into a Draw document in a unit test

[Regina Henschel]

Hi all,

I have found suitable methods. I can use InsertNewLayer() and 
SetLayerVisible().


Kind regards
Regina

Regina Henschel schrieb am 06-Sep-18 um 01:10:

Hi all,

I'm working on
https://bugs.documentfoundation.org/show_bug.cgi?id=119392. I have a
solution for it. Now I need a unit test. I need to do:
1. Load a Draw document, which has two user defined layers with
non-default settings for visible/printable/locked.
2. Insert a new layer between these two layers, which has non-default
settings for visible/printable/locked.
3. Save the document.
4a) Examine the saved file, whether it has the correct items in the
setting.xml or
4b) Reload the file and make sure the visible/printable/locked settings
are correct for each of the user defined layers.

Is there a test, where I can look, how to make step 2? A guide for step
4b is not quite necessary because I know how to do step 4a, but would be
nice to have.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Need help on how to insert a layer into a Draw document in a unit test

[Regina Henschel]

Hi all,

I'm working on 
https://bugs.documentfoundation.org/show_bug.cgi?id=119392. I have a 
solution for it. Now I need a unit test. I need to do:
1. Load a Draw document, which has two user defined layers with 
non-default settings for visible/printable/locked.
2. Insert a new layer between these two layers, which has non-default 
settings for visible/printable/locked.

3. Save the document.
4a) Examine the saved file, whether it has the correct items in the 
setting.xml or
4b) Reload the file and make sure the visible/printable/locked settings 
are correct for each of the user defined layers.


Is there a test, where I can look, how to make step 2? A guide for step 
4b is not quite necessary because I know how to do step 4a, but would be 
nice to have.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Precedence between fo:line-height and style:line-height-at-least

[Regina Henschel]

Hi all,

the ODF specification has only for value "normal" a rule for the 
precedence between the attributes fo:line-height [3] and 
style:line-height-at-least [1] and style:line-spacing [2]. So I want to 
extend the description. Unfortunately LibreOffice behaves so, that the 
attribute order determines the final style (examine attached file). But 
in XML the order of attributes is irrelevant. So what behavior would you 
like to be specified?


The attributes "style:line-height-at-least" and "style:line-spacing" are 
not supported for ODF by MS Office. I don't know, whether something 
similar exists in OOXML.


[1] 
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-style_line-height-at-least
[2] 
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-style_line-spacing
[3] 
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-fo_line-height 



Kind regards
Regina


FoFixStyleAtLeast_combined_inonestyle.odt
Description: application/vnd.oasis.opendocument.text
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: make check fails in [build JCS]

[Regina Henschel]

Hi Stephan,

Stephan Bergmann schrieb am 29-Aug-18 um 11:06:

On 29/08/18 10:04, Regina Henschel wrote:



I run into such errors on Windows with recent JDK (9/10; I /think/ it
started with 9) for quite a while now, wondered why apparently nobody
else did, locally applied below hack for now, and moved on for the time
being without investigating deeper into the issue.  (Apparently, Java no
longer accepts file:... URLs there, at least on Windows, and won't
accept full pathnames starting with a drive letter like C:/..., but does
accept ("drive-absolute") pathnames like /...; so my hack should work as
long as your files are on drive C.)


It is D: for me.

Your changes work here too. At least checking goes further. It fails in 
chart2 now. I'll update and look, whether that solves the problem.




Apparently, needs more investigation and a proper fix, eventually.


A fix would be nice.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

make check fails in [build JCS]

[Regina Henschel]

Hi all,

after a successful build with "build-nocheck", the next step "make 
check" fails in [build JCS].


I get the error messages:
[build JCS] JunitTest/comphelper_complex
[build JCS] JunitTest/forms_unoapi_3
[build JCS] JunitTest/forms_unoapi_4
[build JCS] JunitTest/forms_complex
[build JCS] JunitTest/framework_complex
error: illegal argument for --class-path: Illegal char <:> at index 4: 
file:///D:/Build_sep18/core/instdir/program/classes/juh.jar
make[1]: *** [D:/Build_Sep18/core/solenv/gbuild/JavaClassSet.mk:53: 
D:/Build_sep18/core/workdir/JavaClassSet/JunitTest/comphelper_complex/done] 
Error 2

make[1]: *** Waiting for unfinished jobs
error: illegal argument for --class-path: Illegal char <:> at index 4: 
file:///D:/Build_sep18/core/instdir/program/classes/juh.jar
make[1]: *** [D:/Build_Sep18/core/solenv/gbuild/JavaClassSet.mk:53: 
D:/Build_sep18/core/workdir/JavaClassSet/JunitTest/forms_complex/done] 
Error 2

make: *** [Makefile:286: build] Error 2

My configure is
--with-external-tar=/cygdrive/d/Build_Sep18/externalsrc
--with-junit=/cygdrive/c/cygwin64/junit/junit-4.10.jar
--with-ant-home=/cygdrive/c/cygwin64/ant199
--disable-ccache
--with-visual-studio=2017
--with-help=html
--with-lang=de
--enable-64-bit
--enable-debug
--disable-cve-tests
--with-parallelism=4
--with-jdk-home=/cygdrive/c/Programme/Java/jdk-9.0.1

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: How to make a unit test for Draw to test file format?

[Regina Henschel]

Hi Tomaž,

Tomaž Vajngerl schrieb am 23-Aug-18 um 17:26:

Hi Regina,

On Thu, Aug 23, 2018 at 3:26 PM Regina Henschel  wrote:

[..]



I have tried a start like
void SdMiscTest::testTdf101242_ODF2ODF()
{
 ::sd::DrawDocShellRef xDocShRef =
Load(m_directories.getURLFromSrc("/sd/qa/unit/data/tdf101242_without_settings.odg"),
ODG);


I would do it like it is done in test SdExportTest::testTdf113822 in
export-tests.cxx and SdExportTest::testEmbeddedText().

utl::TempFile tempFile;
sd::DrawDocShellRef xShell =
loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/tdf101242_without_settings.odg"),
ODG);
xShell = saveAndReload(xShell.get(), ODG, );
xmlDocPtr pXmlDoc = parseExport(tempFile, "styles.xml");
assert with xpath ...
xDocShRef->DoClose();


I see a temp file in C:\cygwin64\tmp\. But it has mimetype
application/vnd.oasis.opendocument.presentation and the attributes in
the  elements are wrong.


That's weird - I hope it works with my example.


It turns out, that loadURL is not enough. Using 'Load' works now, I 
guess because it generates a Frame, which is needed for layers.


I have changed SdModelTestBase to use "private:factory/sdraw*" for odg 
documents and that gives now the correct mimetype.


The resaved file is now the same as I get from a running LO with UI.




My idea was to use something like
xmlDocPtr pXmlDoc = parseExport(aTempFile, "styles.xml");
OString
sPathStart("/office:document-styles/office:master-styles/draw:layer-set/draw:layer");
 assertXPath(pXmlDoc, sPathStart +
"[@draw:name='backgroundobjects']", "draw:protected", "true" );
I get something in pXmlDoc. How can I see, what I have got? I cannot get
nodes from it, e.g
getXPathNode(pXmlDoc,OString("/office:document-styles")) or
getXPathNode(pXmlDoc,"/office:document-styles") is already empty.


I solve this by constructing the path step by step, until it is what I want.
For example:

first try:
assertPath("/office:document-styles/");

second try I would add : master-styles:
assertPath("/office:document-styles/office:master-styles/");

third try I would add layer-set:
assertPath("/office:document-styles/office:master-styles/draw:layer-set/");


I have found the reason of my problem. assertXPath evaluates the 
attribute in the second parameter by calling method xmlGetProp. But that 
cannot handle attributes with prefix. So my solution is now to put the 
test into the predicate, e.g.
assertXPath(pXmlDoc, sPathStart + "[@draw:name='backgroundobjects' and 
@draw:protected='true']");


It works basically now.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: How to make a unit test for Draw to test file format?

[Regina Henschel]

Hi Tomaž,

Tomaž Vajngerl schrieb am 23-Aug-18 um 17:26:

Hi Regina,

On Thu, Aug 23, 2018 at 3:26 PM Regina Henschel  wrote:

Is there any example, where I can see how to do that?


Probably not.. usually just look at other tests and do what they do.
The problem is that most of them are for impress and not draw. I have
struggled with some tests in the past too.


I have tried a start like
void SdMiscTest::testTdf101242_ODF2ODF()
{
 ::sd::DrawDocShellRef xDocShRef =
Load(m_directories.getURLFromSrc("/sd/qa/unit/data/tdf101242_without_settings.odg"),
ODG);


I would do it like it is done in test SdExportTest::testTdf113822 in
export-tests.cxx and SdExportTest::testEmbeddedText().

utl::TempFile tempFile;
sd::DrawDocShellRef xShell =
loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/tdf101242_without_settings.odg"),
ODG);
xShell = saveAndReload(xShell.get(), ODG, );
xmlDocPtr pXmlDoc = parseExport(tempFile, "styles.xml");
assert with xpath ...
xDocShRef->DoClose();


"loadURL" would be called from "Load".

I have looked closer at "loadURL". It does not result in a Draw 
document, but always uses "private:factory/simpress*" and 
DocumentType::Impress. A Draw document can be opened as Impress 
document. But that is not usable for me, because the layer feature is 
one of the differences between Draw and Impress documents.


It seems, I need to extend it to get a Draw document.

BTW, SdModelTestBase has a lot of references to Calc. Copy left 
over or intentional?





Is there a human readable way to see, what I get there?


Not that I know of. You need to hunt down the temporary file and look
at it. You can look at the path of the tempFile -
tempFile.GetURLPath();


I have used CPPUNITTRACE=TRUE now, opened the interesting files and set 
breakpoints before actually starting.





Then I have continued (mimicking what I have seen in other places) with:
uno::Reference xComponent(xDocShRef->GetModel(),
uno::UNO_QUERY);
 uno::Reference xStorable(xComponent, uno::UNO_QUERY);
 utl::MediaDescriptor aMediaDescriptor;
 aMediaDescriptor["FilterName"] <<= OUString("draw8");
 utl::TempFile aTempFile;
 aTempFile.EnableKillingFile();
 xStorable->storeToURL(aTempFile.GetURL(),
aMediaDescriptor.getAsConstPropertyValueList());


This may not be needed - look at my example.


You are right, "save" works, beside the wrong factory.




I see a temp file in C:\cygwin64\tmp\. But it has mimetype
application/vnd.oasis.opendocument.presentation and the attributes in
the  elements are wrong.


That's weird - I hope it works with my example.


No, "save" has "private:factory/simpress*" too.



My idea was to use something like
xmlDocPtr pXmlDoc = parseExport(aTempFile, "styles.xml");
OString
sPathStart("/office:document-styles/office:master-styles/draw:layer-set/draw:layer");
 assertXPath(pXmlDoc, sPathStart +
"[@draw:name='backgroundobjects']", "draw:protected", "true" );
I get something in pXmlDoc. How can I see, what I have got? I cannot get
nodes from it, e.g
getXPathNode(pXmlDoc,OString("/office:document-styles")) or
getXPathNode(pXmlDoc,"/office:document-styles") is already empty.


I solve this by constructing the path step by step, until it is what I want.
For example:

first try:
assertPath("/office:document-styles/");


Already that fails. The "office:" prefix is the problem. It seems, that 
for class SdMiscTest, where I put my test, the part "registerNamespaces" 
is missing.


I am the first one who works on a "Draw" unittest?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

How to make a unit test for Draw to test file format?

[Regina Henschel]

Hi all,

I'm still working on https://gerrit.libreoffice.org/#/c/59269/. The 
suggested range-based for-loops work well. Now I try to make a unit test 
as suggested by Tomaž.


I have a test file "tdf101242_without_settings.odg", which has the 
attributes in the  elements in styles.xml and has no 
visible/printable/locked items in settings.xml. I want to load the file, 
then save it, then verify that the attributes are still there in 
styles.xml. After that works, make a test to verify, that the old kind 
items in settings.xml are written correctly.


Is there any example, where I can see how to do that?

I have tried a start like
void SdMiscTest::testTdf101242_ODF2ODF()
{
::sd::DrawDocShellRef xDocShRef = 
Load(m_directories.getURLFromSrc("/sd/qa/unit/data/tdf101242_without_settings.odg"), 
ODG);


Is there a human readable way to see, what I get there?

Then I have continued (mimicking what I have seen in other places) with:
uno::Reference xComponent(xDocShRef->GetModel(), 
uno::UNO_QUERY);

uno::Reference xStorable(xComponent, uno::UNO_QUERY);
utl::MediaDescriptor aMediaDescriptor;
aMediaDescriptor["FilterName"] <<= OUString("draw8");
utl::TempFile aTempFile;
aTempFile.EnableKillingFile();
xStorable->storeToURL(aTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());


I see a temp file in C:\cygwin64\tmp\. But it has mimetype 
application/vnd.oasis.opendocument.presentation and the attributes in 
the  elements are wrong.


My idea was to use something like
xmlDocPtr pXmlDoc = parseExport(aTempFile, "styles.xml");
OString 
sPathStart("/office:document-styles/office:master-styles/draw:layer-set/draw:layer");
assertXPath(pXmlDoc, sPathStart + 
"[@draw:name='backgroundobjects']", "draw:protected", "true" );
I get something in pXmlDoc. How can I see, what I have got? I cannot get 
nodes from it, e.g 
getXPathNode(pXmlDoc,OString("/office:document-styles")) or 
getXPathNode(pXmlDoc,"/office:document-styles") is already empty.


Obviously I need help.

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Looking for reviewer

[Regina Henschel]

Hi all,

I'm looking for a reviewer for https://gerrit.libreoffice.org/#/c/59269/

It is about reading/writing attributes draw:display and draw:protect for 
 element in Draw and Impress.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Segfault compiling master

[Regina Henschel]

Hi,

Noel Grandin schrieb am 03-Aug-18 um 09:47:



On 2018/08/02 5:23 PM, Regina Henschel wrote:


I hope, that helps to find the reason.




I think caoloan has fixed this with

https://cgit.freedesktop.org/libreoffice/core/commit/?id=653394fb199fae2d9e39f681fc72b35fe7f3




Yes it builds now. Thanks.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Segfault compiling master

[Regina Henschel]

Hi Michael,

I have a file attached, into which I have pasted the output of the IDE.

I hope, that helps to find the reason.

Kind regards
Regina

Michael Stahl schrieb am 02-Aug-18 um 14:47:


hi Regina,

your debugger is called $(DEVENV), and quoting that in the shell is a
bit of a problem... (devenv.exe is the Visual Studio IDE)


the other problem is that apparently on Windows, the image-lists that
are always rebuilt every time also respect the BUILDTOOLTRACE variable,
which is quite an annoyance as a whole bunch of IDEs pop up...

so first "cd extras" so those image-lists aren't built.

then this works for me:

BUILDTOOLTRACE="'\$(DEVENV)' /debugexe" make Gallery_computers verbose=t

...once it crashes you can select everything in the stack trace tab and
copy/paste it.

On 02.08.2018 14:16, Regina Henschel wrote:

Hi Michael,

I got the error too. Not a special Gallery theme is the problem, but
building Gallery at all. I build with VS2017 and Cygwin on Win10. Is
there a way I can gather information?

Kind regards
Regina

Michael Stahl schrieb am 02-Aug-18 um 12:17:

On 02.08.2018 12:05, Michael Stahl wrote:

On 02.08.2018 11:57, Heiko Tietze wrote:

Since a couple of days I fail compiling master. What's wrong?


what's wrong is that of the 3 (by this time) people who have sent
mails about a crash on shutdown in gengal or unit tests to the dev
list this week, 0 of them have included a backtrace of the crash,
hence nobody is able to fix the problem :(


oh, i realize for gengal you don't get a nice error message how to start
it in gdb, but this should work:

 BUILDTOOLTRACE="gdb --args" make Gallery_computers verbose=t
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


It stops in ImplDbgTestSolarMutext().

Ausnahme ausgelöst bei 0x7FFB10FA8AE0 (vcllo.dll) in gengal.exe: 
0xC005: Zugriffsverletzung beim Lesen an Position 0x.

"Aufrufliste"-window
-
>   vcllo.dll!ImplDbgTestSolarMutex() Zeile 47  C++
tllo.dll!DbgTestSolarMutex() Zeile 78   C++
svllo.dll!SfxBroadcaster::RemoveListener(SfxListener & rListener) Zeile 
126 C++
svllo.dll!SfxListener::~SfxListener() Zeile 66  C++
[Externer Code] 
sfxlo.dll!SfxPickList::~SfxPickList() Zeile 188 C++
[Externer Code] 



"Ausgabe"-window
--
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\gengal.exe" geladen. 
Symbole wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\ntdll.dll" geladen. Symbole wurden 
geladen.
"gengal.exe" (Win32): "C:\Windows\System32\kernel32.dll" geladen. Symbole 
wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\KernelBase.dll" geladen. Symbole 
wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\ucrtbase.dll" geladen. Symbole 
wurden geladen.
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\comphelper.dll" 
geladen. Symbole wurden geladen.
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\cppu3.dll" geladen. 
Symbole wurden geladen.
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\sal3.dll" geladen. 
Symbole wurden geladen.
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\cppuhelper3MSC.dll" 
geladen. Symbole wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\advapi32.dll" geladen. Symbole 
wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\advapi32.dll" geladen. Symbole 
wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\advapi32.dll" wurde entladen.
"gengal.exe" (Win32): "C:\Windows\System32\msvcrt.dll" geladen. Symbole wurden 
geladen.
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\svllo.dll" geladen. 
Symbole wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\sechost.dll" geladen. Symbole wurden 
geladen.
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\sfxlo.dll" geladen. 
Symbole wurden geladen.
"gengal.exe" (Win32): "D:\Build_Jun18\core\instdir\program\svxcorelo.dll" 
geladen. Symbole wurden geladen.
"gengal.exe" (Win32): "C:\Windows\System32\rpcrt4.dll" geladen. Symbole wurden 
geladen.
"gengal.exe" (Win32): "C:\Window

Re: Segfault compiling master

[Regina Henschel]

Hi Michael,

I got the error too. Not a special Gallery theme is the problem, but 
building Gallery at all. I build with VS2017 and Cygwin on Win10. Is 
there a way I can gather information?


Kind regards
Regina

Michael Stahl schrieb am 02-Aug-18 um 12:17:

On 02.08.2018 12:05, Michael Stahl wrote:

On 02.08.2018 11:57, Heiko Tietze wrote:

Since a couple of days I fail compiling master. What's wrong?


what's wrong is that of the 3 (by this time) people who have sent
mails about a crash on shutdown in gengal or unit tests to the dev
list this week, 0 of them have included a backtrace of the crash,
hence nobody is able to fix the problem :(


oh, i realize for gengal you don't get a nice error message how to start
it in gdb, but this should work:

 BUILDTOOLTRACE="gdb --args" make Gallery_computers verbose=t
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ODF specification for border around text portions

[Regina Henschel]

Hi Tamás,

Regina Henschel schrieb am 30-Jul-18 um 14:33:


That is the behavior of LibreOffice. But if browser (tested with
Seamonkey and Chrome) split a paragraph across pages, then the bottom
border of the paragraph in the first page is missing and the top border
of the paragraph on the second page is missing. And because ODF
indirectly uses CSS, here is a problem too.


I have just tested Word 365. It does not render borders at page breaks. 
So it is only LibreOffice.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ODF specification for border around text portions

[Regina Henschel]

Hi Tamás,

Tamás Zolnai schrieb am 30-Jul-18 um 11:57:

Hi Regina,

That's right what Miklos wrote here, it was added mainly for MS
compatibility, so the expected behavior if it works similar to that.
This line height handling "bug" seems an independent issue from the
character border, which affects that use case too.


Yes, that bug can be seen too with images anchored as character or 
single characters in larger font size. But the effect of the bug for me 
is, that I cannot say "LibreOffice has implemented borders same as Word.".




However I'm not sure that ODF specification is this detailed that you
need to specify these things too. At least I did not meet with a
detailed specification. As I remember in ODF spec the border related
attrubutes are general attributes already used for other objects like
paragraphs, pages, frames, etc.


Unfortunately it is not that simple. The border of the paragraph is a 
fo:border and is specified by a reference to XSL. And XSL specifies it 
by a reference to CSS2. And there I come to 
https://www.w3.org/TR/CSS2/visudet.html#inline-non-replaced with its 
description "The vertical padding, border and margin of an inline, 
non-replaced box start at the top and bottom of the content area, and 
has nothing to do with the 'line-height'. But only the 'line-height' is 
used when calculating the height of the line box." Therefore the current 
fo:border is not suitable to describe a intended, Word compatible rendering.


 So it might be a good idea to check how

paragraph border works for example. In theory these two should be
somewhat consistent and as I see they are. Line height - border
interaction seems similar for paragraphs and when a paragraph is
splitted between pages I see two separate boxes.


That is the behavior of LibreOffice. But if browser (tested with 
Seamonkey and Chrome) split a paragraph across pages, then the bottom 
border of the paragraph in the first page is missing and the top border 
of the paragraph on the second page is missing. And because ODF 
indirectly uses CSS, here is a problem too.


Therefor this mail: How to resolve the differences between rendering as 
specified by CSS and rendering in Word?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

ODF specification for border around text portions

[Regina Henschel]

Hi all,

you can draw borders on portions of text in Writer. This is currently in 
loext namespace. I'm working to get this feature to ODF.


I have noticed the problems described below, when looking what would be 
needed for interoperability with Word and what would be needed for EPUB 
export.


I would be happy to hear some suggestions from you.

Problem line height
---
EPUB: EPUB uses XHTML and CSS3. Border, margin and padding does not 
influence the line-height calculation in CSS. Therefore the margin-, 
border- and padding-box might overlap previous or next lines. But the 
text inside the box is always regularly visible. Overlapping happens in 
document order. The border will be painted on top of the previous line 
and the next line will be painted on top of the border.


MS Word: Word acts different. If the line-height is proportional (e.g. 
1.5 lines) the distance between lines is increased, so that the entire 
box fits into the line. The additional space is distributed so that the 
text in the box has the same baseline as the text outside the box. If 
the line-height is fixed (e.g. 24pt), the height of the box is reduced 
(not the border width) so that the border might overlap the text inside 
the box. The border is drawn on top of the text.


LibreOffice's line height implementation has currently bug 
https://bugs.documentfoundation.org/show_bug.cgi?id=69647


Problem line break
--
EPUB: If the text portion, which has got border, margin, padding is 
split so that the start of the text portion is in line A and the end is 
in the next line B, then the border box is split in CSS. That means, 
that the box in line A has no right border and the box in line B has not 
left border (in ltr script).


MS Word: Word acts different. It enclosed the text porting in line A 
with a complete box and encloses the text porting in line B with a 
complete box too.


Currently LibreOffice follows the way Word does it.

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Question, please, regarding building the code

[Regina Henschel]

Hi Susan,

Susan Jean schrieb am 24-Jul-18 um 17:56:

Hi again, Folks,

I have more information on the question I posted earlier. Sorry about that…I 
wasn’t sure if someone was going to contact me one on one or not. Bear with me, 
please. I’m just starting to get to know Cygwin.

In the “lode – LibreOffice Development Environment” document 
(https://wiki.documentfoundation.org/Development/lode), page 4, there are 3 
instructions together. They are under the title, “Now it is time to build.” 
Note that the first 2 instructions produce no errors, but I’ve included them 
for completeness:

Cd dev/core
../autogen.sh
../../opt/bin/make 2>&1 | tee build.log

The exact error after executing the last line is:
“Make: *** No targets specified and no makefile found. Stop.”


I do not use "lode", but have set up the build environment manually. For 
me the command would not be /opt/bin/make but /opt/lo/bin/make. So 
please look in folder "opt", what it contains.


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Using native SVG as image in flat ODF

[Regina Henschel]

Hi all,

currently an SVG image needs to be BASE64 encoded, if you save to flat 
ODF. I have started https://issues.oasis-open.org/browse/OFFICE-3995 to 
allow native SVG. My proposal is a first draft and it is time enough 
till ODF 1.4 to consider your ideas and concerns. So please have a look. 
Especially, should it be allowed in the normal, packed file format too?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Bringing attributes draw:fontwork-xyz to ODF?

[Regina Henschel]

Hi all,

I had some mail exchange with Armin. He supports the idea to keep this 
feature. He has given me a code pointer for the calculation of the text 
rendering. That part of the specification draft is nearly finished.


But now I am working on the character shadow in the fontwork and there 
are problems. The current way, in which LibreOffice (inherited from 
OpenOffice.org) writes it to file is so buggy, that it is not possible 
to use this as template for a specification.


I see these errors:

1)
The shadow has the types XFormTextShadow = {NONE, Normal, Slant} in 
core/include/svx/xenum.hxx#26

But in file format
“NONE” becomes draw:fontwork-shadow="normal"
“Normal” becomes draw:fontwork-shadow="slant"
“Slant” becomes draw:fontwork-shadow="none"
The reason is a wrong mapping in pXML_Fontwork_Shadow_Enum[] in 
core/xmloff/source/draw/sdpropls.cxx#699
Unfortunately this error exists at least since OOo1.1.5, so all 
documents since about 15 years have this wrong.


2)
In case of type “Slant” the angle and the scaling factor is writing into 
the draw:fontwork-shadow-offset attributes. For example a shear angle of 
30° becomes draw:fontwork-shadow-offset-x="0.3cm" and a scaling factor 
of 150% becomes draw:fontwork-shadow-offset-y="0.15cm".



The ODF 1.2 specification has currently three types of shadows:

“fo:text-shadow” with a value of data type string, with a reference to 
XSL §7.16.5, which refers to a non existing section in the CSS 
specification. It is used for shadow, that is set in character styles.


“style:shadow” with a value of data type string, with same references. 
It is used for shadow, that is in the border-dialog. It is explicitly 
mentioned, that it is not usable for text.


“draw:shadow” and the connected attributes draw:shadow-color, 
draw:shadow-offset-x, draw:shadow-offset-y and draw:shadow-opacity. That 
is used in the area dialog of shapes and produces a shadow of the entire 
shape.


Taking the new draft CSS3, the string can contain a shadow offset in x 
and y direction, a shadow color and a blur radius. An angle and a 
scaling factor, needed for type “Slant”, are not included.


I see these solutions
A)
Add for each needed, but now not available property a new draw:shadow-* 
attribute. Evaluate the draw:shadow for characters in fontwork in case 
of type “normal” and “slant” or for the entire shape in case of fontwork 
type “NONE”.


B)
Make for fontwork own attributes draw:fontwork-shadow-*, (or better 
draw:textonpath-shadow-*, see below).


C)
Make an own definition of the meaning of the string so that it contains 
shear angle and scaling factors. Use fo:text-shadow then.


D)
Keep the string as close as possible to CSS3 and add an attribute 
style:character-shadow-transform or draw:character-shadow-transform, 
which can take descriptions for linear transformations. Use 
fo:text-shadow and new character-shadow-transform attribute for the 
characters in the fontwork.


Remark: I’m going to use draw:textonpath-* instead of draw:fontwork-*, 
because that avoids conflicts with the existing draw:fontwork-* 
attributes and the term “text-on-path” is common. Mapping to our 
implementation would happen in xmloff.


It would be nice to get some comments from you, before I bring it to the 
ODF TC.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Make clean fails for unpackedTarballs in subpath firebird

[Regina Henschel]

Hi all,

if I use /opt/lo/bin/make clean it stops with the error message
"rm: das Entfernen von 
'D:/Build_ODF_layers/core/workdir/UnpackedTarball/firebird/gen/Debug/firebird' 
ist nicht möglich: Directory not empty"
And indeed it has a 0Byte file fb_trace_wj10i8 in 
unpackedTarball/firebird/gen/Debug/firebird.


I can delete the file manually in Windows explorer. But I think it is an 
error. I write here, because I don't find a suitable category in Bugzilla.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Bringing attributes draw:fontwork-xyz to ODF?

[Regina Henschel]

Hi all,

LibreOffice has a feature Fontwork, which is actually a "text along 
path". This feature exists from the beginning. You find it in the DTD of 
OpenOffice.org 1.0.


When OpenOffice.org had switched to ODF, these attributes were written 
unchanged to file and so does LibreOffice. But these attributes were 
never specified in ODF.


I have started to work on a specification. But before I continue to work 
on it, I think, there should be a general decision: Do we want to 
specify these attributes, or do we change the implementation to write 
these attributes in loext-namespace for ever and drop it for ODF strict? 
Or any other suggestion?


Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/svx svx/source

[Regina Henschel]

 include/svx/svdpage.hxx   |1 -
 svx/source/svdraw/svdpage.cxx |3 ---
 2 files changed, 4 deletions(-)

New commits:
commit 4c1a09a16b9c778119c77c8061ab5fd40dca6942
Author: Regina Henschel 
Date:   Sun Jun 10 15:39:54 2018 +0200

Remove unused member aPrefVisiLayers

The only users were removed 18-Nov-2011 in
commit ddb1d5eb, Felix Zhang.

Change-Id: I3843d278881203f63f5daf24a3acf27b7d1f4aa9
Reviewed-on: https://gerrit.libreoffice.org/55562
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx
index 418b3488f094..96fa50607806 100644
--- a/include/svx/svdpage.hxx
+++ b/include/svx/svdpage.hxx
@@ -430,7 +430,6 @@ protected:
 // new MasterPageDescriptorVector
 std::unique_ptr mpMasterPageDescriptor;
 
-SdrLayerIDSet   aPrefVisiLayers;
 sal_uInt16  nPageNum;
 
 boolmbMaster : 1;   // flag if this is a 
MasterPage
diff --git a/svx/source/svdraw/svdpage.cxx b/svx/source/svdraw/svdpage.cxx
index cf3ae4d41eb9..6c6bd36eda83 100644
--- a/svx/source/svdraw/svdpage.cxx
+++ b/svx/source/svdraw/svdpage.cxx
@@ -1146,14 +1146,12 @@ SdrPage::SdrPage(SdrModel& rModel, bool bMasterPage)
 mpSdrPageProperties(nullptr),
 mxUnoPage(),
 mpMasterPageDescriptor(nullptr),
-aPrefVisiLayers(),
 nPageNum(0),
 mbMaster(bMasterPage),
 mbInserted(false),
 mbObjectsNotPersistent(false),
 mbPageBorderOnlyLeftRight(false)
 {
-aPrefVisiLayers.SetAll();
 mpSdrPageProperties.reset(new SdrPageProperties(*this));
 }
 
@@ -1209,7 +1207,6 @@ void SdrPage::lateInit(const SdrPage& rSrcPage)
 // the contained objects
 mbMaster = rSrcPage.mbMaster;
 mbPageBorderOnlyLeftRight = rSrcPage.mbPageBorderOnlyLeftRight;
-aPrefVisiLayers = rSrcPage.aPrefVisiLayers;
 mnWidth = rSrcPage.mnWidth;
 mnHeight = rSrcPage.mnHeight;
 mnBorderLeft = rSrcPage.mnBorderLeft;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Build breaks in sw_apitests

[Regina Henschel]

Hi Noel,

No :(
The build still breaks in sw_apitests.

My HEAD is on commit d424a5578ae50382ba7062aa9624dae584601c73.

The error message in Visual Studio is
Ausgelöste Ausnahme: Lesezugriffsverletzung
"this->**_Ptr**" war "0x1EB12D738B0".

The "Aufrufliste" is:
>vcllo.dll!std::_Ref_count::_Destroy() Zeile 932  C++
vcllo.dll!std::_Ref_count_base::_Decref() Zeile 895 C++
vcllo.dll!std::_Ptr_base::_Decref() Zeile 1169   C++

vcllo.dll!std::shared_ptr::~shared_ptr() 
Zeile 1460	C++

vcllo.dll!WinSalBitmap::~WinSalBitmap() Zeile 195   C++
[Externer Code] 
vcllo.dll!Bitmap::~Bitmap() Zeile 114   C++
[Externer Code] 
vcllo.dll!ImpGraphic::~ImpGraphic() Zeile 314   C++
[Externer Code] 
vcllo.dll!GraphicObject::~GraphicObject() Zeile 322 C++
[Externer Code] 
editenglo.dll!SvxBrushItem::~SvxBrushItem() Zeile 3257  C++
[Externer Code] 

Kind regards
Regina


Noel Grandin schrieb am 07.06.2018 um 08:35:



On 2018/06/06 6:09 PM, Regina Henschel wrote:

my build breaks in sw_apitests.

My HEAD is commit e5ad0150dc543ccbf3631ea57ad0919b3faa599b


That should be fixed with


https://cgit.freedesktop.org/libreoffice/core/commit/?id=b292a27698e85fd9d60c03613c3b0c67835c4dc1




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Build breaks in sw_apitests

[Regina Henschel]

Hi all,

my build breaks in sw_apitests.

My HEAD is commit e5ad0150dc543ccbf3631ea57ad0919b3faa599b


Visual Studio shows me error message:
Ausgelöste Ausnahme: Lesezugriffsverletzung
"this->**_Ptr**" war "0x28866EB38B0".

And "Aufrufliste"
>vcllo.dll!std::_Ref_count::_Destroy() Zeile 932  C++
 vcllo.dll!std::_Ref_count_base::_Decref() Zeile 895C++
 vcllo.dll!std::_Ptr_base::_Decref() Zeile 1169  C++
vcllo.dll!std::shared_ptr::~shared_ptr() 
Zeile 1460	C++

vcllo.dll!WinSalBitmap::~WinSalBitmap() Zeile 195   C++
[Externer Code] 
vcllo.dll!Bitmap::~Bitmap() Zeile 114   C++
[Externer Code] 
vcllo.dll!ImpGraphic::~ImpGraphic() Zeile 305   C++
[Externer Code] 
vcllo.dll!GraphicObject::~GraphicObject() Zeile 322 C++
[Externer Code] 
editenglo.dll!SvxBrushItem::~SvxBrushItem() Zeile 3257  C++
[Externer Code] 

How can I exclude these tests, but run the others?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: filter/source

[Regina Henschel]

 filter/source/config/fragments/types/calc_MS_Multiplan.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 36ca18f70ee0bf9541bc0105c85f0a68f088c92b
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Thu May 3 16:05:47 2018 +0200

tdf#117323 Add file name extension mp for Multiplan

The missing file name extensions makes the assertion fail in
core/include/rtl/ustring.hxx#669

Change-Id: I1a3c95867f850d64b69dc851737b902c4aef228b
Reviewed-on: https://gerrit.libreoffice.org/53797
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: David Tardon <dtar...@redhat.com>

diff --git a/filter/source/config/fragments/types/calc_MS_Multiplan.xcu 
b/filter/source/config/fragments/types/calc_MS_Multiplan.xcu
index 8f2bba34f0a2..7f9b3c3c528d 100644
--- a/filter/source/config/fragments/types/calc_MS_Multiplan.xcu
+++ b/filter/source/config/fragments/types/calc_MS_Multiplan.xcu
@@ -11,7 +11,7 @@
 
 com.sun.star.comp.Calc.MSWorksCalcImportFilter
 
-
+mp
 
 
 true
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Making drawing layers ODF conform

[Regina Henschel]

Hi all,

to inform you, I have written a Hackfest report about what I'm going to 
do in regard of layers.


https://wiki.documentfoundation.org/Hackfest/Hamburg2018/Make_drawing_layers_ODF_conform

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Solution proposal for OOXML shape's in LibrrOffice Calc

[Regina Henschel]

Hi,

serdar tunc schrieb am 08.03.2018 um 13:00:

Hello,

As you know, when you add a shape in Excel and rotate it by any degree
LibreOffice Calc opens it without rotation.

I've tried to explain my solution proposal for OOXML shape's in
LibreOffice Calc on my blog and what causes the problem.

https://serdaroktaytunc.blogspot.com.tr/2018/03/solution-proposal-for-ooxml-shapes-in.html





From your blog post
" In my opinion, Excel writes rectangular shape's coordinates after 
rotation".


Excel writes different information. One is the object geometry in the 
xdr:spPr element. There you will find the original geometry, the size of 
the bounding box of the not rotated shape and the rotation angle. 
Another information is the anchor position of the resulting shape, e.g 
in the xdr:from and xdr:to elements of a xdr:twoCellAnchor element. 
Please do not confuse them.


"We need to control shape type for set shape rotation to zero in 
LibreOffice Calc, not anchor type (We need to delete patch for 
bnc#762542). If the shape is rectangular, set shape rotation to zero, 
not the text rotation."


I disagree with that. If the rectangle is rotated in Excel it has to be 
rotated in Calc as well. There is nothing special with a rectangle.


Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Error building

[Regina Henschel]

Hi,

fady esam schrieb am 01.03.2018 um 00:52:

When i try to build the project pn windows with cygwin it gives me this
error

configure: error: al.exe not found as /al.exe
Error running configure at /cygdrive/c/sources/core/autogen.sh line 289.


even tho i have the latest windows sdk.. what should i do?


Please give more information, e.g.

Do you use LODE [https://wiki.documentfoundation.org/Development/lode] 
or do you have manually setup all things?


Which version is your Windows? Which version of Visual Studio do you 
use?  Do you have used the default installation path?


Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Consider translation of transformation matrix of image rotation

[Regina Henschel]

Hi Armin,

Armin Le Grand schrieb am 23.02.2018 um 16:39:

Hi Regina,


It works in principle,

What does that mean ?!?


It solves the issue. Question is, whether something can be improved or 
should be changed.




A: An empty constructed basegfx::B2DHomMatrix is on identity (no-op), so it is 
ideal to test if it is used. Will even work when usages add-up to identity 
matrix whant means 'no change'. Yes, use isIdentity() please.


OK. I had seen by setting a break point, that it is indeed initialized 
with identity. Only it is not directly obvious.




B: You might calculate it, but it is not really needed. Since we rotate arouhd 
center (only) it is sufficient to extract rotation and set it - we know it's 
around center. The rest of the shape (svg:x/y/width/height) is the unrotated 
shape, so this is sufficient. It can be calculated to make error-checks if 
wanted. It will have to be calculated when someone will use more of the 
transformation later (or we do)


A correction is needed, because Word uses a shape with position (0|0) on 
which the transformation matrix is applied, when it writes out the 
document to ODF.


Example: An image position=(3cm|4cm), width=6cm height=2cm, rotate by 
30° comes out by Word as
draw:transform="translate(-1.18307in -0.39567in) rotate(-0.5236) 
translate(2.36015in 1.96928in)" and missing svg:x and svg:y (which means 
svg:x="0" and svg:y="0"). In UI it is a rotated image with center 
(6cm|5cm), same as LibreOffice, but the file format is different.

[BTW -1.18307in≈3cm; -0.39567in≈1cm; half of width/height]

That is, what the issue is about. The way Word writes it, is not common, 
but possible. I think, that LibreOffice should be able to read such 
files for interoperability.


My question is more, whether the comparison might be more expensive than 
the saved effort for the calculations. Or do you know a better way to 
detect whether a correction of the position is needed? I hesitate to 
test on position (0|0), because that would be a "Word only" fix and does 
not cover other included translations.




C: Not sure whant you mean here. Correcting the position means it's 
'overdefined'. The (svg:x/y/width/height) and back-calculating from 
transformation with (-translate, rotate, translate) to rotate around center 
*should* always give the same center. If not, it is *not clear* which 
definition is the correct one. This is the reason the transformation should 
*not* contain positioning at all. The idea is: Apply (svg:x/y/width/height) 
first (pos and size), then apply transformation to it (rotate, shear, mirror 
(scale-1)).


For LibreOffice it should give the same center, but with files generated 
by Word there is the above described problem.


My concern is, that I might add something here, which is not on the way 
to a final solution for transformations. I don't know your further plans 
for the FlyFrames.


Kind regards
Regina




-Ursprüngliche Nachricht-
Von: Regina Henschel [mailto:rb.hensc...@t-online.de]
Gesendet: Friday, February 23, 2018 15:13
An: LO dev fdo <libreoffice@lists.freedesktop.org>
Cc: Armin Le Grand <armin.legr...@extern.cib.de>
Betreff: Consider translation of transformation matrix of image rotation

Hi Armin, hi all,

this is about https://bugs.documentfoundation.org/show_bug.cgi?id=115590
and my proposal https://gerrit.libreoffice.org/#/c/50176/

It works in principle, but I'm not sure about some details:

A
It has a construction
 basegfx::B2DHomMatrix aFullTransform;

 with later on
 if ( !aFullTransform.isIdentity() )

Should I use
 basegfx::B2DHomMatrix aFullTransform;
 bool bHasTransformation;

 if ( bHasTransformation )
instead?

B
It has
 if ( aTransformedCenterPosition != aCenterPosition ) Is this check useful, 
or should I calculate the correction always, although the result might be the 
original value?

C
Is this the correct place at all to correct the position?

Kind regards
Regina



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Consider translation of transformation matrix of image rotation

[Regina Henschel]

Hi Armin, hi all,

this is about https://bugs.documentfoundation.org/show_bug.cgi?id=115590 
and my proposal https://gerrit.libreoffice.org/#/c/50176/


It works in principle, but I'm not sure about some details:

A
It has a construction
basegfx::B2DHomMatrix aFullTransform;

with later on
if ( !aFullTransform.isIdentity() )

Should I use
basegfx::B2DHomMatrix aFullTransform;
bool bHasTransformation;

if ( bHasTransformation )
instead?

B
It has
if ( aTransformedCenterPosition != aCenterPosition )
Is this check useful, or should I calculate the correction always, 
although the result might be the original value?


C
Is this the correct place at all to correct the position?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Render differences of DOCX between Word and LO/AOO

[Regina Henschel]

Hi Jens,

Jens Tröger schrieb am 23.01.2018 um 04:26:

Hello,

I am not sure if this forum is the right place to bring up this topic
for discussion, or if another one is more appropriate; please advise.


This list is for developers to discuss problems in the code. For 
discussion about using LibreOffice use the list 
us...@global.libreoffice.org or use Ask.

https://www.libreoffice.org/get-help/mailing-lists/
https://wiki.documentfoundation.org/Ask/Getting_Started

If you speak about a specific document, you should make the document 
available somewhere. The us...@global.libreoffice.org list does not 
allow attachments.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Cannot build master with VS 2017

[Regina Henschel]

Hi all,

with some guide in the chat it turns out, that the files config.sub were 
damaged. Restart PC, update cygwin, make clean and build again. Now it 
works.


Kind regards
Regina

Regina Henschel schrieb am 11.01.2018 um 14:08:

Hi all,

I need help with building. I get the error

[build PAT] libmspub
/usr/bin/sh: ./configure: Kann die Binärdatei nicht ausführen: Exec
format error
1 out of 1 hunk FAILED -- saving rejects to file
src/lib/MSPUBContentChunkType.h.rej
Patch FAILED: C:/LO_build/core/external/libmspub/ubsan.patch
make[1]: ***
[C:/LO_build/core/external/libcdr/ExternalProject_libcdr.mk:27:
C:/LO_build/core/workdir/ExternalProject/libcdr/build] Error 1
make[1]: *** Waiting for unfinished jobs
make[1]: *** [C:/LO_build/core/solenv/gbuild/UnpackedTarball.mk:172:
C:/LO_build/core/workdir/UnpackedTarball/libmspub.done] Error 1

Followed by a lot of "checking" and similar messag:
configure: error: cannot run /bin/sh ./config.sub
make[1]: ***
[C:/LO_build/core/external/libqxp/ExternalProject_libqxp.mk:25:
C:/LO_build/core/workdir/ExternalProject/libqxp/build] Error 1
and final message
configure: error: cannot run /bin/sh ./config.sub
make[1]: ***
[C:/LO_build/core/external/libzmf/ExternalProject_libzmf.mk:27:
C:/LO_build/core/workdir/ExternalProject/libzmf/build] Error 1
make: *** [Makefile:276: build] Error 2

My configure is
--with-external-tar=/cygdrive/c/LO_build/externalsrc
--with-junit=/cygdrive/c/cygwin64/junit/junit-4.10.jar
--with-ant-home=/cygdrive/c/cygwin64/ant199
--enable-pch
--disable-ccache
--with-visual-studio=2017
--without-fonts
--with-help
--enable-64-bit
--enable-debug
--with-jdk-home=/cygdrive/c/Programme/Java/jdk-9.0.1

Last successful build had been in December.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Cannot build master with VS 2017

[Regina Henschel]

Hi all,

I need help with building. I get the error

[build PAT] libmspub
/usr/bin/sh: ./configure: Kann die Binärdatei nicht ausführen: Exec 
format error
1 out of 1 hunk FAILED -- saving rejects to file 
src/lib/MSPUBContentChunkType.h.rej

Patch FAILED: C:/LO_build/core/external/libmspub/ubsan.patch
make[1]: *** 
[C:/LO_build/core/external/libcdr/ExternalProject_libcdr.mk:27: 
C:/LO_build/core/workdir/ExternalProject/libcdr/build] Error 1

make[1]: *** Waiting for unfinished jobs
make[1]: *** [C:/LO_build/core/solenv/gbuild/UnpackedTarball.mk:172: 
C:/LO_build/core/workdir/UnpackedTarball/libmspub.done] Error 1


Followed by a lot of "checking" and similar messag:
configure: error: cannot run /bin/sh ./config.sub
make[1]: *** 
[C:/LO_build/core/external/libqxp/ExternalProject_libqxp.mk:25: 
C:/LO_build/core/workdir/ExternalProject/libqxp/build] Error 1

and final message
configure: error: cannot run /bin/sh ./config.sub
make[1]: *** 
[C:/LO_build/core/external/libzmf/ExternalProject_libzmf.mk:27: 
C:/LO_build/core/workdir/ExternalProject/libzmf/build] Error 1

make: *** [Makefile:276: build] Error 2

My configure is
--with-external-tar=/cygdrive/c/LO_build/externalsrc
--with-junit=/cygdrive/c/cygwin64/junit/junit-4.10.jar
--with-ant-home=/cygdrive/c/cygwin64/ant199
--enable-pch
--disable-ccache
--with-visual-studio=2017
--without-fonts
--with-help
--enable-64-bit
--enable-debug
--with-jdk-home=/cygdrive/c/Programme/Java/jdk-9.0.1

Last successful build had been in December.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: tdf#109202 Add mimetype to image element

[Regina Henschel]

Hi Thorsten, hi Michael,

so do you see any reason to have the mime-type attribute in the 
 element? Or is the  indeed a better place?


Kind regards
Regina


Thorsten Behrens schrieb am 18.12.2017 um 23:38:

Michael Stahl wrote:

i don't see this as a disadvantage: the content of an ODF package
cannot make assumptions about what some URL that points outside the
ODF package refers to; dereferencing the URL might result in a
different file than when the ODF package was created, or it might be
a 404 because the file has been removed.


Yep, agreeing with Michael - there's an established way to transfer
the mime type of linked content, and that's the responsibility of the
server. Best is to leave that to the remote side, content could be
generated on the fly, depend on the user agent, preferred language etc
etc.

All the best,

-- Thorsten



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

tdf#109202 Add mimetype to image element

[Regina Henschel]

Hi Samuel, hi Thorsten, hi all,

I try to bring the requested mime-type attribute to ODF. In the 
discussion in the TC it was suggested, to make such attribute not an 
attribute of the  element but to make it an attribute of the 
 element.


I have thought about that proposal and see these advantage/disadvantages:

The advantage would be, that the mime-type would be also available for 
other places, where a  element is used, without 
adding it to all these places individually. Such elements are 
 or  for example.


The disadvantage is, that in case the xlink-attributes are used to 
reference an external image, the mime-type is not available. [In case 
the xlink-attributes refer to an image inside the package, the mime-type 
is available via the manifest. In case of flat file format, the image is 
always base64encoded into a  element.]


Any other arguments?

What do you think about the problem?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4469b29faeb8dbf7793a5d81d9c5ddebacf3015f
https://bugs.documentfoundation.org/show_bug.cgi?id=109202
https://issues.oasis-open.org/browse/OFFICE-3943
https://lists.oasis-open.org/archives/office/201712/msg00025.html

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Drop support for cygwin i686 building Win64 binaries?

[Regina Henschel]

Hi Thorsten,

but it will still be possible to produce Win32 binaries from a 32bit 
cygwin on a Win32 machine?


Kind regards
Regina

Thorsten Behrens schrieb am 04.12.2017 um 03:45:

Dear fellow hackers,

after three more fixes on master, we now have (almost) universal gpgme
support for Windows.

There's one snag left, as you see in

https://gerrit.libreoffice.org/#/c/45769/ :

Sadly cygwin i686's windres does not support 64 bit targets, which
makes it impossible on that platform to produce Win64
binaries. Instead of subtly disabling the feature for that
combination, the above patch breaks support for building Win64 from a
32bit cygwin, for 6.1 and onwards.

All CI and release builders are already running cygwin64, and so I
believe are most of you - at least lode defaults to cygwin64 since
quite a while, on supporting Windows installations.

Or is there a good reason to keep universal cygwin32 support around?

Cheers,

-- Thorsten



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Need code pointer for import of attributes

[Regina Henschel]

Hi Michael,

Michael Stahl schrieb am 23.11.2017 um 21:37:

On 22.11.2017 17:32, Regina Henschel wrote:

Hi all,

I've started on
https://bugs.documentfoundation.org/show_bug.cgi?id=101242. My current
work is in the attachment.

Problem: Although I remove the config-items IsVisible, IsPrintable,
IsLocked from the settings.xml of a file, the values from draw:display
and draw:locked of the  element are not used. It seems to
me, that somewhere the read values are overwritten with a default.

Where and when are the values from settings.xml transformed to
properties of the layers of a newly opened draw document?


probably in sd/source/ui/view/frmview.cxx,
FrameView::ReadUserDataSequence(), around line 858


There the values from settings.xml are indeed read, but it sets no 
defaults. If the node does not exists, nothing is changed.





Any other hint, where to look?


there are SetVisibleLayers functions on 3 different classes, maybe
setting breakpoints on those would be helpful.


"setting breakpoints" was a good tip.

I use VS2017 and there is no "vs2017-ide-integration" yet. But I have 
tried the "vs2015-ide-integration" and it seems to work :)


I looked a little bit around for SetVisibleLayers and SdrLayerIDSet 
without success.


Then I started from the other end and looked what happens with my not 
working
xLayer->setPropertyValue("IsLocked",(msbProtected == "true") ? Any(true) 
: Any(false) );

compared to the working
xLayer->setPropertyValue("Title", Any( sTitleBuffer.makeStringAndClear() 
) );


I found this:
setPropertyValue is a method of class SdLayer [in 
sd\source\ui\unoidl\unolayer.hxx]


The SdLayer itself has no members to store the information. In case of 
"Title" the SdrLayer is used, for which the SdLayer has a pointer. This 
SdrLayer has the member maTitle to take the information. It has no 
members to take IsLocked, IsVisible or IsPrintable.


In case of "IsLocked" the SdLayer uses its member mxLayerManager to get 
a View of a page or a FrameView of the DocShell. But both doesn't exists 
at this stage, when loading a document. So the call of set(...) returns 
false; the source has the comment "//TODO: uno::Exception?"


The result is, that the information is not overwritten as I first 
thought, but is simple lost.


A  can have its own . But the 
 to be used for the page can also be inherited from a 
master page via  or . Therefore 
a solution is needed, which can be extended to support all three places.


As you know, currently the IsLocked/IsVisible/IsPrintable is not stored 
in the document itself, but in the settings.xml, despite the fact, that 
ODF can express the information. [Remember ODF TC discussion on 
OFFICE-3693 to not use settings.xml in those cases.]


New members mbIsLocked, mbIsVisible and mbIsPrintable for the SdrLayer 
would likely work [not worked out yet] as long as the layer settings are 
unique throughout the document, but they need not be unique in ODF.


So what to do?

Kind regard
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Need code pointer for import of attributes

[Regina Henschel]

Hi all,

I've started on 
https://bugs.documentfoundation.org/show_bug.cgi?id=101242. My current 
work is in the attachment.


Problem: Although I remove the config-items IsVisible, IsPrintable, 
IsLocked from the settings.xml of a file, the values from draw:display 
and draw:locked of the  element are not used. It seems to 
me, that somewhere the read values are overwritten with a default.


Where and when are the values from settings.xml transformed to 
properties of the layers of a newly opened draw document?

Any other hint, where to look?

Besides that, it would be nice, if you could tell me, if my approach is 
correct so far.


Kind regards
Regina
diff --git a/xmloff/source/draw/layerexp.cxx b/xmloff/source/draw/layerexp.cxx
index e1a3727f97f0..ec880e24f211 100644
--- a/xmloff/source/draw/layerexp.cxx
+++ b/xmloff/source/draw/layerexp.cxx
@@ -56,6 +56,9 @@ void SdXMLayerExporter::exportLayer( SvXMLExport& rExport )
 const OUString strName( "Name" );
 const OUString strTitle( "Title" );
 const OUString strDescription( "Description" );
+const OUString strIsLocked( "IsLocked" );
+const OUString strIsVisible( "IsVisible" );
+const OUString strIsPrintable( "IsPrintable" );
 
 OUString sTmp;
 
@@ -70,6 +73,40 @@ void SdXMLayerExporter::exportLayer( SvXMLExport& rExport )
 if(!sTmp.isEmpty())
 rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_NAME, sTmp );
 
+bool bIsLocked;
+xLayer->getPropertyValue( strIsLocked ) >>= bIsLocked;
+if ( bIsLocked )
+rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_PROTECTED, 
"true" );
+else
+rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_PROTECTED, 
"false" );
+
+bool bIsVisible;
+xLayer->getPropertyValue( strIsVisible ) >>= bIsVisible;
+bool bIsPrintable;
+xLayer->getPropertyValue( strIsPrintable ) >>= bIsPrintable;
+if ( bIsVisible )
+{
+if ( bIsPrintable )
+{
+rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_DISPLAY, 
"always" );
+}
+else
+{
+rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_DISPLAY, 
"screen" );
+}
+}
+else
+{
+if ( bIsPrintable )
+{
+rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_DISPLAY, 
"printer" );
+}
+else
+{
+rExport.AddAttribute( XML_NAMESPACE_DRAW, XML_DISPLAY, 
"none" );
+}
+}
+
 SvXMLElementExport aEle( rExport, XML_NAMESPACE_DRAW, XML_LAYER, 
true, true );
 
 // title property (as  element)
diff --git a/xmloff/source/draw/layerimp.cxx b/xmloff/source/draw/layerimp.cxx
index bc28f6c83226..77b7dabe4b43 100644
--- a/xmloff/source/draw/layerimp.cxx
+++ b/xmloff/source/draw/layerimp.cxx
@@ -58,6 +58,8 @@ public:
 private:
 css::uno::Reference< css::container::XNameAccess > mxLayerManager;
 OUString msName;
+OUString mseDisplay; // always, none, printer, screen
+OUString msbProtected; // false, true
 OUStringBuffer sDescriptionBuffer;
 OUStringBuffer sTitleBuffer;
 };
@@ -77,7 +79,14 @@ SdXMLLayerContext::SdXMLLayerContext( SvXMLImport& rImport, 
sal_uInt16 nPrefix,
 if( IsXMLToken( aLocalName, XML_NAME ) )
 {
 msName = sValue;
-break; // no more attributes needed
+}
+if( IsXMLToken( aLocalName, XML_PROTECTED ) )
+{
+msbProtected = sValue;
+}
+if( IsXMLToken( aLocalName, XML_DISPLAY ) )
+{
+mseDisplay = sValue;
 }
 }
 }
@@ -127,6 +136,27 @@ void SdXMLLayerContext::EndElement()
 {
 xLayer->setPropertyValue("Title", Any( 
sTitleBuffer.makeStringAndClear() ) );
 xLayer->setPropertyValue("Description", Any( 
sDescriptionBuffer.makeStringAndClear() ) );
+xLayer->setPropertyValue("IsLocked",(msbProtected == "true") ? 
Any(true) : Any(false) );
+if( mseDisplay == "always" )
+{
+xLayer->setPropertyValue("IsVisible", Any(true) );
+xLayer->setPropertyValue("IsPrintable", Any(true) );
+}
+else if( mseDisplay == "screen" )
+{
+xLayer->setPropertyValue("IsVisible", Any(true) );
+xLayer->setPropertyValue("IsPrintable",Any(false) );
+}
+else if( mseDisplay == "printer" )
+{
+xLayer->setPropertyValue("IsVisible", Any(false) );
+xLayer->setPropertyValue("IsPrintable", Any(true) );
+}
+else // "none"
+{
+xLayer->setPropertyValue("IsVisible", 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sd/qa xmloff/source

[Regina Henschel]

 sd/qa/unit/data/objectwithtext.fodg |  189 
 sd/qa/unit/export-tests.cxx |   32 ++
 xmloff/source/draw/shapeexport.cxx  |   15 +-
 3 files changed, 228 insertions(+), 8 deletions(-)

New commits:
commit 0958cd79545a21a37642f812937d57164117bffe
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Sun Oct 22 19:34:44 2017 +0200

tdf#112547 element p to draw:object, import expects it there

There exists no documents produced by LibreOffice, where text on OLE
objects has worked, because import expects the paragraphs inside the
draw:object element, but LO has written them outside. The patch
changes LO to write the paragraphs inside the draw:object element.
The patch does not enable LibreOffice to read the paragraphs in
old documents. But versions at least since 5.1 will be able to read
text on OLE objects from documents which were produced by versions
with applied patch.

Reviewed-on: https://gerrit.libreoffice.org/43696
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Armin Le Grand <armin.le.gr...@cib.de>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
Reviewed-by: Michael Stahl <mst...@redhat.com>
(cherry picked from commit 21f61ffeb7e72caee98f12cac2dd25fe7ec3a821)

tdf#112547 sd: add unit test
(cherry picked from commit b3cfb849b19dc1e40c12586bebd2b76fc41007fa)

Change-Id: I879135f1a869e46c32361db653ede05227bab95e
Reviewed-on: https://gerrit.libreoffice.org/44374
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>

diff --git a/sd/qa/unit/data/objectwithtext.fodg 
b/sd/qa/unit/data/objectwithtext.fodg
new file mode 100644
index ..f58a377f2a3f
--- /dev/null
+++ b/sd/qa/unit/data/objectwithtext.fodg
@@ -0,0 +1,189 @@
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:smil="urn:oasis:names:tc:opendocument:xmlns:smil-compatible:1.0" 
xmlns:anim="urn:oasis:names:tc:opendocument:xmlns:animation:1.0" 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xml
 ns:calcext:1.0" 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.graphics">
+ 
2017-11-06T19:36:05.7708592582017-11-06T19:38:11.864425937PT2M6S1LibreOfficeDev/6.0.0.0.alpha1$Linux_X86_64
 
LibreOffice_project/2f8c1379a07d581ac46337ca0f91609c544c3d6e
+ 
+  
+  
+  
+  
+  
+ 
+ 
+  
+  
+   
+   
+
+   
+   
+  
+  
+   
+
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+ 
+  
+  
+ 
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+   
+  
+  
+   
+   
+   
+  
+  
+   
+   
+   
+  
+  
+   
+   
+   
+

[Libreoffice-commits] core.git: xmloff/source

[Regina Henschel]

 xmloff/source/draw/shapeexport.cxx |   15 +++
 1 file changed, 7 insertions(+), 8 deletions(-)

New commits:
commit 21f61ffeb7e72caee98f12cac2dd25fe7ec3a821
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Sun Oct 22 19:34:44 2017 +0200

tdf#112547 element p to draw:object, import expects it there

There exists no documents produced by LibreOffice, where text on OLE
objects has worked, because import expects the paragraphs inside the
draw:object element, but LO has written them outside. The patch
changes LO to write the paragraphs inside the draw:object element.
The patch does not enable LibreOffice to read the paragraphs in
old documents. But versions at least since 5.1 will be able to read
text on OLE objects from documents which were produced by versions
with applied patch.

Change-Id: I879135f1a869e46c32361db653ede05227bab95e
Reviewed-on: https://gerrit.libreoffice.org/43696
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Armin Le Grand <armin.le.gr...@cib.de>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>
Reviewed-by: Michael Stahl <mst...@redhat.com>

diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index 7c1c9cb206bb..88cc1efd9782 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -2774,14 +2774,6 @@ void XMLShapeExport::ImpExportOLE2Shape(
 
 if( !bIsEmptyPresObj || bSaveBackwardsCompatible )
 {
-// tdf#112005 export text *before* adding any attributes
-if (!bIsEmptyPresObj && supportsText(eShapeType))
-{
-// #i118485# Add text export, the draw OLE shape allows text 
now
-// fdo#58571 chart objects don't allow text:p
-ImpExportText( xShape, TextPNS::EXTENSION );
-}
-
 if (pAttrList)
 {
 mrExport.AddAttributeList(pAttrList);
@@ -2846,6 +2838,13 @@ void XMLShapeExport::ImpExportOLE2Shape(
 enum XMLTokenEnum eElem = sClassId.isEmpty() ? XML_OBJECT : 
XML_OBJECT_OLE ;
 SvXMLElementExport aElem( mrExport, XML_NAMESPACE_DRAW, eElem, 
true, true );
 
+// tdf#112547 export text as child of draw:object, where import 
expects it
+if (!bIsEmptyPresObj && supportsText(eShapeType))
+{
+// #i118485# Add text export, the draw OLE shape allows text 
now
+ImpExportText( xShape, TextPNS::EXTENSION );
+}
+
 if(bExportEmbedded && !bIsEmptyPresObj)
 {
 if(bInternal)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - 4 commits - include/oox include/sal offapi/com oox/source writerfilter/source xmloff/source xmlsecurity/inc xmlsecurity

[Regina Henschel]

 include/oox/vml/vmlshape.hxx  |7 
 include/sal/log-areas.dox |1 
 offapi/com/sun/star/security/DocumentSignatureInformation.idl |   17 ++
 oox/source/vml/vmlshape.cxx   |   74 --
 oox/source/vml/vmlshapecontext.cxx|7 
 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |7 
 xmloff/source/text/txtimp.cxx |2 
 xmloff/source/text/txtparae.cxx   |2 
 xmlsecurity/inc/xmlsecurity/sigstruct.hxx |6 
 xmlsecurity/qa/unit/signing/data/signatureline.docx   |binary
 xmlsecurity/qa/unit/signing/signing.cxx   |   27 +++
 xmlsecurity/source/component/documentdigitalsignatures.cxx|9 +
 xmlsecurity/source/helper/ooxmlsecparser.cxx  |   53 +++
 xmlsecurity/source/helper/ooxmlsecparser.hxx  |6 
 xmlsecurity/source/helper/xsecctl.hxx |3 
 xmlsecurity/source/helper/xsecverify.cxx  |   64 
 16 files changed, 267 insertions(+), 18 deletions(-)

New commits:
commit 11c842f450561953b11f3bc9a44404c6e83682ea
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Thu Oct 26 14:41:38 2017 +0200

tdf#113367 Change namespace from svg to draw for attr transform

The new feature of rotating images in Writer first time triggers the
export of the attribute transform. So now it becomes visible, that
it has the wrong namespace, see ODF 19.228 part 1.

Change-Id: I00d5e6a12bd564e814679e8be862c7d08baae956
Reviewed-on: https://gerrit.libreoffice.org/43890
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 08dafafdcbfe..3c19db3b8a1a 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -364,7 +364,7 @@ static const SvXMLTokenMapEntry aTextFrameAttrTokenMap[] =
 { XML_NAMESPACE_XLINK, XML_HREF, XML_TOK_TEXT_FRAME_HREF },
 { XML_NAMESPACE_DRAW, XML_NAME, XML_TOK_TEXT_FRAME_FILTER_NAME },
 { XML_NAMESPACE_DRAW, XML_ZINDEX, XML_TOK_TEXT_FRAME_Z_INDEX },
-{ XML_NAMESPACE_SVG, XML_TRANSFORM, XML_TOK_TEXT_FRAME_TRANSFORM },
+{ XML_NAMESPACE_DRAW, XML_TRANSFORM, XML_TOK_TEXT_FRAME_TRANSFORM },
 { XML_NAMESPACE_DRAW, XML_CLASS_ID, XML_TOK_TEXT_FRAME_CLASS_ID },
 { XML_NAMESPACE_DRAW,   XML_CODE,   XML_TOK_TEXT_FRAME_CODE },
 { XML_NAMESPACE_DRAW,   XML_OBJECT, XML_TOK_TEXT_FRAME_OBJECT },
diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx
index 481d474674aa..a809bf0b758c 100644
--- a/xmloff/source/text/txtparae.cxx
+++ b/xmloff/source/text/txtparae.cxx
@@ -3068,7 +3068,7 @@ void XMLTextParagraphExport::_exportTextGraphic(
 sRet.append( '(' );
 ::sax::Converter::convertNumber( sRet, (sal_Int32)nVal );
 sRet.append( ')' );
-GetExport().AddAttribute( XML_NAMESPACE_SVG, XML_TRANSFORM,
+GetExport().AddAttribute( XML_NAMESPACE_DRAW, XML_TRANSFORM,
   sRet.makeStringAndClear() );
 }
 
commit 637cdd25bd1b5268ddba0f23be6701538c73fc62
Author: Stephan Bergmann <sberg...@redhat.com>
Date:   Fri Nov 3 18:42:44 2017 +0100

Only downcast to OOXMLFastContextHandlerShape when actually necessary

After bd3c5c4c234e3dc6b89cd235321945a41a08d562 "[API CHANGE] tdf#65393 
Import
signature line images from ooxml", UBSan CppunitTest_chart2_export had 
started
to fail with

> writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1898:25: runtime 
error: downcast of address 0x61200070a440 which does not point to an object of 
type 'writerfilter::ooxml::OOXMLFastContextHandlerShape'
> 0x61200070a440: note: object is of type 
'writerfilter::ooxml::OOXMLFastContextHandlerWrapper'
>  0e 10 00 20  50 86 4a 00 a2 7f 00 00  01 00 00 00 be be be be  00 00 00 
00 00 00 00 00  00 00 00 00
>   ^~~
>   vptr for 
'writerfilter::ooxml::OOXMLFastContextHandlerWrapper'

Change-Id: I028ef619766466e8cd9bb0ca09174b926fc6d23c

diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx 
b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index b3eae0abd171..d3a6a02d3ab6 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -1844,11 +1844,10 @@ 
OOXMLFastContextHandlerWrapper::lcl_createFastChildContext
 // here until we need a more generic solution.
 bool bIsWrap = Element == static_cast(NMSP_vmlWord | XML_wrap);
 bool bIsSignatureLine = Element == static_cast(NMSP_vmlOffice | 
XML_signatureline);
-bool bIsShapeSent = 
st

Re: [Writer] Macro for "Edit->Links->[Select All]->Remove Links

[Regina Henschel]

Hello,

Jambunathan K schrieb:

Hello

Could someone help me with a Basic Macro that does

   "Edit->Links->[Select All]->Remove Links"



Why do you need a macro? You know, that you can multi-select in the list 
in Edit-> Links and so break all links in one go?


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Problem with xmllint

[Regina Henschel]

Hi all,

please notice the mail 
https://lists.oasis-open.org/archives/office/201710/msg00058.html


Affected are the attributes manifest:preferred-view-mode, 
form:control-implementation, chart:class, draw:engine, and 
db:server-database.

Thereof chart:class is indeed used by LibreOffice.

You can prove that Andreas Guelzow is right, if you validate a chart 
document and validate again after changing the schema to have "string" 
instead of "namespacedToken".


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

RotGrfFlyFrame: Problems with rotated images, that need to be solved before next release

[Regina Henschel]

Hi all,

I consider the current state of the new feature of rotating Writer 
images not complete enough to be released. I have collected the 
problems, which I see into these bugs:


FILESAVE: New feature image rotation uses wrong value in transformation 
attribute

https://bugs.documentfoundation.org/show_bug.cgi?id=113494

rotated image should keep its size and bounding box should scale accordingly
https://bugs.documentfoundation.org/show_bug.cgi?id=113507

Integrate image rotation in properties dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113509

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: xmloff/source

[Regina Henschel]

 xmloff/source/text/txtimp.cxx   |2 +-
 xmloff/source/text/txtparae.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7cebfbeabb24f908fb586ef5fa47f103042d769c
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Thu Oct 26 14:41:38 2017 +0200

tdf#113367 Change namespace from svg to draw for attr transform

The new feature of rotating images in Writer first time triggers the
export of the attribute transform. So now it becomes visible, that
it has the wrong namespace, see ODF 19.228 part 1.

Change-Id: I00d5e6a12bd564e814679e8be862c7d08baae956
Reviewed-on: https://gerrit.libreoffice.org/43890
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 54016575a620..87586098ec17 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -364,7 +364,7 @@ static const SvXMLTokenMapEntry aTextFrameAttrTokenMap[] =
 { XML_NAMESPACE_XLINK, XML_HREF, XML_TOK_TEXT_FRAME_HREF },
 { XML_NAMESPACE_DRAW, XML_NAME, XML_TOK_TEXT_FRAME_FILTER_NAME },
 { XML_NAMESPACE_DRAW, XML_ZINDEX, XML_TOK_TEXT_FRAME_Z_INDEX },
-{ XML_NAMESPACE_SVG, XML_TRANSFORM, XML_TOK_TEXT_FRAME_TRANSFORM },
+{ XML_NAMESPACE_DRAW, XML_TRANSFORM, XML_TOK_TEXT_FRAME_TRANSFORM },
 { XML_NAMESPACE_DRAW, XML_CLASS_ID, XML_TOK_TEXT_FRAME_CLASS_ID },
 { XML_NAMESPACE_DRAW,   XML_CODE,   XML_TOK_TEXT_FRAME_CODE },
 { XML_NAMESPACE_DRAW,   XML_OBJECT, XML_TOK_TEXT_FRAME_OBJECT },
diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx
index 53548573be0a..65d072b240b8 100644
--- a/xmloff/source/text/txtparae.cxx
+++ b/xmloff/source/text/txtparae.cxx
@@ -3060,7 +3060,7 @@ void XMLTextParagraphExport::_exportTextGraphic(
 sRet.append( '(' );
 sRet.append( (sal_Int32)nVal );
 sRet.append( ')' );
-GetExport().AddAttribute( XML_NAMESPACE_SVG, XML_TRANSFORM,
+GetExport().AddAttribute( XML_NAMESPACE_DRAW, XML_TRANSFORM,
   sRet.makeStringAndClear() );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Text on OLE object (chart, math, true OLE) ?

[Regina Henschel]

Regina Henschel schrieb:


That was fixed in the meantime. But now the entire text on OLE objects
does not work at all. It is written to a  child in
, but it is not read. => tdf#118485


Issue is https://bugs.documentfoundation.org/show_bug.cgi?id=112547

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Start position of grid not specified

[Regina Henschel]

Hi all,

while working on "logarithmic axis scale" [1] in the ODF TC we noticed, 
that positioning of grid is generally different between LO and Gnumeric.


Gnumeric has a position independent of the minimum of the axis. LO 
starts grid always at the minimum of the axis. Example: currently for a 
major-interval=2 and min=-2.5 LO gives grid position -2.5, -0.5, 1.5 and 
for min=-1.5 LO give grid position -1.5, 0.5, 2.5.


It would be nice to determine the grid position for to get -2, 0, 2 
independent of minimum value.


I can imagine of a new style attribute chart:grid-anchor where you can 
set a value (0 for linear scale e.g) or "start" (to get the current 
behavior). But as this would require additions in the code, I will not 
suggest it to the TC without your OK.


Currently the spec has no rule for it, so both LO and Gnumeric are 
"right". But for interoperability it is a bad situation and the spec 
should describe the grid position.


[1] https://issues.oasis-open.org/browse/OFFICE-3936

Kind regards
Regina



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Text on OLE object (chart, math, true OLE) ?

[Regina Henschel]

Hi all,

when implementing fill and line attributes and transformations for OLE 
objects in AOO, they get the ability to carry text. But the 
implementation for text produced invalid files.


LibreOffice got some fixes:
commit 9e41982ac165092ed024b8ab318eedc7fcf4c6a9
and commit 204d1093d4954596cc7d7578e0630648f1f678f5 and perhaps others.

After that the attributes draw:class-id and 
draw:notify-on-update-of-ranges were broken => tdf#112005


That was fixed in the meantime. But now the entire text on OLE objects 
does not work at all. It is written to a  child in 
, but it is not read. => tdf#118485


Do you really want that feature?

If yes, is there someone who will mentor me to fix the problem?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: LibreOffice Core Development build Issue

[Regina Henschel]

Hi Koushik Sekhar,

do you have checked, that your installation of Visual Studio is OK? Try 
to run Visual Studio. Run "devenv.exe", it is in folder Common7/IDE.


Kind regards
Regina

koushik.sek...@ssrlabs.com schrieb:

Hi Shinnok,

I have setup the basic environment for LibreOffice Document Project. I am
facing issues while running the build for libo core. I have also
explicitly specified the JDK and the Microsoft Visual Studio versions when
I run the autogen.sh \ file but I am still getting errors. I have attached
the screenshot of the error for your reference. Could you please provide
your suggestion as how to rectify the same.

Thank you.

Regards,
Koushik Sekhar



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Text on OLE objects?

[Regina Henschel]

Hi all,


Regina Henschel schrieb:

Hi all,

Currently there is muddle in the UI and in code.

Insert a chart or Math object or an OLE to a foreign application, then
click on it so that is gets green handles, then press F2 and enter text.
That is the same behavior as for normal shapes, where you can add text
to the shape that way. But when you save and reload the document, the
text on the OLE is gone. (I think, there is no bug report yet.)


The missing text error is in in 
https://bugs.documentfoundation.org/show_bug.cgi?id=106262


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Text on OLE objects?

[Regina Henschel]

Hi all,

Currently there is muddle in the UI and in code.

Insert a chart or Math object or an OLE to a foreign application, then 
click on it so that is gets green handles, then press F2 and enter text. 
That is the same behavior as for normal shapes, where you can add text 
to the shape that way. But when you save and reload the document, the 
text on the OLE is gone. (I think, there is no bug report yet.)


With AOO #i118485# the feature "text on Draw OLE shape" was introduced. 
But that has problems in file format, because it puts the text as 
 inside the  element, which is not valid.
That was changed by moving the  one level up to the  
object. But there it neither valid.
So with fdo#58571 the element was put into loext namespace, which 
results in a  child element of the  element. But in 
ODF1.2 strict, you now get a  element without any namespace, so still 
not valid.


In the meantime it has been introduced, that the attribute 
draw:notify-on-update-of-ranges of the  element is used. 
But currently it does not go to the  element, but it goes 
to the  element. The same happens with the draw:class-id 
attribute of the  element. That is tdf#112005. 
https://gerrit.libreoffice.org/#/c/42401/ has a fix for that. But it 
does not solve the problem, that you can enter text, which is gone after 
reload.


I wonder, whether it is good to allow at all text (via F2) on OLE 
objects. And in consequence, whether it would be better to remove this 
feature than to get all aspects fixed?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cd-5.3' - oox/source

[Regina Henschel]

 oox/source/ppt/timenodelistcontext.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 649b14eb85205f6cfa31e01138e3bc6ce393f9a0
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Tue Feb 14 20:18:51 2017 +0100

tdf#99617 convert powerpoint angle to degree

1 powerpoint angle unit = 1/6 degree
Roundtrip test not yet possible because of tdf#106002.

Change-Id: I5854c4f9f013f1a2db7e9536fc9cf5198c7a02ed
Reviewed-on: https://gerrit.libreoffice.org/34279
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/42076
Reviewed-by: Jan Holesovsky <ke...@collabora.com>
Tested-by: Jan Holesovsky <ke...@collabora.com>

diff --git a/oox/source/ppt/timenodelistcontext.cxx 
b/oox/source/ppt/timenodelistcontext.cxx
index e795b6e8b129..287e67ebf066 100644
--- a/oox/source/ppt/timenodelistcontext.cxx
+++ b/oox/source/ppt/timenodelistcontext.cxx
@@ -711,18 +711,18 @@ namespace oox { namespace ppt {
 // sd/source/filter/ppt/pptinanimations.cxx
 if(attribs.hasAttribute( XML_by ) )
 {
-sal_Int32 nBy = attribs.getInteger( XML_by, 0 );
-pNode->setBy( makeAny( (double) nBy ) );
+double fBy = attribs.getDouble( XML_by, 0.0 ) / 
PER_DEGREE; //1 PowerPoint-angle-unit = 1/6 degree
+pNode->setBy( makeAny( fBy ) );
 }
 if(attribs.hasAttribute( XML_from ) )
 {
-sal_Int32 nFrom = attribs.getInteger( XML_from, 0 );
-pNode->setFrom( makeAny( (double) nFrom ) );
+double fFrom = attribs.getDouble( XML_from, 0.0 ) / 
PER_DEGREE;
+pNode->setFrom( makeAny( fFrom ) );
 }
 if(attribs.hasAttribute( XML_to ) )
 {
-sal_Int32 nTo = attribs.getInteger( XML_to, 0 );
-pNode->setTo( makeAny( (double) nTo ) );
+double fTo = attribs.getDouble( XML_to, 0.0 ) / PER_DEGREE;
+pNode->setTo( makeAny( fTo ) );
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - oox/source

[Regina Henschel]

 oox/source/ppt/timenodelistcontext.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit af282a9c7fe78a088fcd883012e31d5b962f4afe
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Tue Feb 14 20:18:51 2017 +0100

tdf#99617 convert powerpoint angle to degree

1 powerpoint angle unit = 1/6 degree
Roundtrip test not yet possible because of tdf#106002.

Change-Id: I5854c4f9f013f1a2db7e9536fc9cf5198c7a02ed
Reviewed-on: https://gerrit.libreoffice.org/34279
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/42078
Reviewed-by: Jan Holesovsky <ke...@collabora.com>
Tested-by: Jan Holesovsky <ke...@collabora.com>

diff --git a/oox/source/ppt/timenodelistcontext.cxx 
b/oox/source/ppt/timenodelistcontext.cxx
index e795b6e8b129..287e67ebf066 100644
--- a/oox/source/ppt/timenodelistcontext.cxx
+++ b/oox/source/ppt/timenodelistcontext.cxx
@@ -711,18 +711,18 @@ namespace oox { namespace ppt {
 // sd/source/filter/ppt/pptinanimations.cxx
 if(attribs.hasAttribute( XML_by ) )
 {
-sal_Int32 nBy = attribs.getInteger( XML_by, 0 );
-pNode->setBy( makeAny( (double) nBy ) );
+double fBy = attribs.getDouble( XML_by, 0.0 ) / 
PER_DEGREE; //1 PowerPoint-angle-unit = 1/6 degree
+pNode->setBy( makeAny( fBy ) );
 }
 if(attribs.hasAttribute( XML_from ) )
 {
-sal_Int32 nFrom = attribs.getInteger( XML_from, 0 );
-pNode->setFrom( makeAny( (double) nFrom ) );
+double fFrom = attribs.getDouble( XML_from, 0.0 ) / 
PER_DEGREE;
+pNode->setFrom( makeAny( fFrom ) );
 }
 if(attribs.hasAttribute( XML_to ) )
 {
-sal_Int32 nTo = attribs.getInteger( XML_to, 0 );
-pNode->setTo( makeAny( (double) nTo ) );
+double fTo = attribs.getDouble( XML_to, 0.0 ) / PER_DEGREE;
+pNode->setTo( makeAny( fTo ) );
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [ODF] Gradient fill for backgrounds of text documents and spreadsheets

[Regina Henschel]

Hi all,

the same problem of allowing gradient fill exists for paragraph, table 
and header/footer. I have attached an analysis text and some variants of 
changes to the schema to 
https://bugs.documentfoundation.org/show_bug.cgi?id=103602. So if you 
are interested in extending the Area tab to these objects, please have a 
look and comment.


Kind regards
Regina

Regina Henschel schrieb:

Hi all,

currently LibreOffice writes invalid documents, in case you set the
background of a text document to a gradient fill. That is
https://bugs.documentfoundation.org/show_bug.cgi?id=103602

I suggest not to use the loext namespace to solve the problem, but to
handle it this way:

Add the attribute draw:style-name to the element  and
let is refer a  element with style:family="drawing-page".
This family allows all the needed attributes.

Advantage:
(1) No private namespace needed. The document validates against the
ODF1.2 schema.
(2) The style family "drawing-page" provides the attribute
draw:background-size. With its value "full" it would be possible to
implement the long demanded background fill till page edge without any
change to ODF1.2.

It might be needed to make some additions to the textual part in the
ODF1.2 specification in "19.219.27" to explicitly
allow this for text documents and spreadsheets too.

What do you think about this approach?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[ODF] Gradient fill for backgrounds of text documents and spreadsheets

[Regina Henschel]

Hi all,

currently LibreOffice writes invalid documents, in case you set the 
background of a text document to a gradient fill. That is 
https://bugs.documentfoundation.org/show_bug.cgi?id=103602


I suggest not to use the loext namespace to solve the problem, but to 
handle it this way:


Add the attribute draw:style-name to the element  and 
let is refer a  element with style:family="drawing-page". 
This family allows all the needed attributes.


Advantage:
(1) No private namespace needed. The document validates against the 
ODF1.2 schema.
(2) The style family "drawing-page" provides the attribute 
draw:background-size. With its value "full" it would be possible to 
implement the long demanded background fill till page edge without any 
change to ODF1.2.


It might be needed to make some additions to the textual part in the 
ODF1.2 specification in "19.219.27" to explicitly 
allow this for text documents and spreadsheets too.


What do you think about this approach?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Call for testing: LibreOffice 5.4.0.3-hotfix

[Regina Henschel]

Hi,

I have tested pre-release Version: 5.4.0.3
Build-ID: 7556cbc6811c9d992f4064ab9287069087d7f62c and LODev Version: 
6.0.0.0.alpha0+ Build ID: 343d40206a929969e1755b073edae91cc4bd9751


The error of bug 109281 is gone, text and images are printed. I have 
used printer "MS Office Document Image Writer", "MS XPS Document Writer" 
and real printer "Epson WP-4025" on Windows 7.


I cannot test bug 107166, because OpenGL needs to be disabled on my PC.

Kind regards
Regina

Xisco Fauli schrieb:

Hello,

The builds for 5.4.0.3 has been now replaced by new builds containing
the fix tdf#109281 [1], which was a critical bug discover in LibreOffice
5.4.0.3 this week.

I would like to ask everyone, specially those with a Windows
environment, to download the new builds and test that tdf#109281 [1] is
fixed and it doesn't cause any other problem, specially those related
with the text rendering on printing (tdf#109281 [1]) and the text
rendering on the UI( tdf#107166 [2]).

You can download the new builds from
http://dev-builds.libreoffice.org/pre-releases/

Regards

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=109281

[2] https://bugs.documentfoundation.org/show_bug.cgi?id=107166




___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: ODF 9.1.12 purpose of element

[Regina Henschel]

Hi Luke,

Luke Deller schrieb:

Hi Regina,

I did some digging into the source history hoping to find clues about
the original motivation for introducing this  element.

Support for importing this element was added to Calc in 2000 along with
, as part of the initial work for freezing
rows and columns as headers in a spreadsheet.
Relevant commits are 7c9e9bfa for the export of headers, and 9cd39996
and 05c72064 for the import.

I suppose the idea was that two groups of columns would be used: the
header columns in a  element followed by the
non-header columns in a  element.  However the
export was not actually updated to emit a  element
like this, only the import support was added.

A couple of weeks later another similar element
 was added, for implementing the Outlines
feature described in help here:
https://help.libreoffice.org/Calc/Group_and_Outline

In this Outlines change (commit 869fb45a), all these three column
grouping elements were allowed to be nested inside each other.  Prior to
that, the  and  could
only occur beneath the  element.

Anyway I think this background supports that the 
element was not necessary from the beginning.


That supports my intention to remove it.



On 22/07/17 08:12, Regina Henschel wrote:

Luke Deller schrieb:

2. A database (odb) file can contain reports containing tables, which
will be emitted with .


I was not able to generate such document. I have tried it with report
as text document, report as spreadsheet and with the old kind of
reports from OOo2.4.3. I always have got only 
elements.


Sorry perhaps I should call it a "report design" rather than a "report".
 I created such a design using the "Use Wizard to Create Report" link in
the "Tasks" pane in Base.

Afterwards, in the Reports pane of Base, simply double clicking the
report gives me a Writer document, but if I right click on the report
and select "Edit", then I get a window entitled "Oracle Report Builder"
which allows the design to be edited.  (BTW should we update this window
title?)

The report design was stored in a separate XML file within the odb file,
which was referenced in the content.xml like this:


  


The  element was located in the file
"reports/Obj11/content.xml" within the odb.



Thank you. I have found it now. I had only looked at the generated 
reports, but not at their definitions. In reports definition the 
 elements are all inside an element in 
"rpt"-namespace. So removing (or deprecate)  
element in ODF1.3 would not affect these parts.


Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ODF 9.1.12 purpose of element

[Regina Henschel]

Hi Luke,

thank you for pointing to the code.

Luke Deller schrieb:

Hi Regina

On 21/07/17 21:52, Regina Henschel wrote:

it seems to me, that the element  is useless.
Exists any situation where LibreOffice writes such element?


I can see only two places in the code which will emit this element:

1. A chart object (e.g. in a spreadsheet) contains a 
representing the data for the chart.  LibreOffice always emits
 for this table.


Indeed. I can generate it from scratch. Fortunately LibreOffice can read 
the chart too, if I remove the  element. So older 
versions would be able to read charts, if the element is removed in a 
newer version.




2. A database (odb) file can contain reports containing tables, which
will be emitted with .


I was not able to generate such document. I have tried it with report as 
text document, report as spreadsheet and with the old kind of reports 
from OOo2.4.3. I always have got only  elements.





What is the purpose of this element?


In both of these cases the  simply wraps all the
 elements, which looks redundant to me.


I think it is redundant. I consider to propose, that the element is 
removed or at least deprecated in ODF 1.3.

BTW, the OASIS-issues are
https://issues.oasis-open.org/browse/OFFICE-3839
https://issues.oasis-open.org/browse/OFFICE-3838


Kind regards
Regina



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

ODF 9.1.12 purpose of element

[Regina Henschel]

Hi all,

it seems to me, that the element  is useless. 
Exists any situation where LibreOffice writes such element?

What is the purpose of this element?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Protect Ask against spam

[Regina Henschel]

Hi all,

can the ESC please discuss methods to protect Ask against spam? [And of 
cause establish a solution, or suggest a solution to the board.]


Read e.g. 
https://ask.libreoffice.org/en/question/106719/spam-why-doesnt-someone-from-tdf-post-their-view/

https://ask.libreoffice.org/en/question/103981/anti-spam-measures/

My personal favorites would be to block a user automatically after two 
of his posts have been deleted, or to block a user, after he had made 
two posts within a short time (2 min e.g.).


Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[ODF] attribute draw:name for dr3d-objects not allowed

[Regina Henschel]

Hi all,

the 2D-objects like  have an attribute draw:name to 
identify the object. This attribute is needed, if you want the object to 
be listed in the Navigator. You can set this attribute in the UI via 
menu Modify > Name in Draw.


You can do the same for 3D-objects like  and you will see 
this object in the Navigator. But the attribute draw:name is not allowed 
as attribute of 3D-objects and therefore LibreOffice writes invalid 
files, if the user has named the 3D-object.


Shall I propose in the TC, that the draw:name attribute is allowed for 
3D-objects too?
Or do you want to make changes in LibreOffice? Then I would write a bug 
report.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Help with Button Control

[Regina Henschel]

Hi Ian,

this is a mailing list for developers, who work on the code of 
LibreOffice. For support requests about _using_ LibreOffice please use a 
way listed in http://www.libreoffice.org/get-help/community-support/


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Help with Button Control

[Regina Henschel]

Hi Ian,

Ian Hartley schrieb:

Dear Libre Office Users,

I am trying to create a button that when pressed, will take the user to
a particular slide in my presentation.  I have created the button but
cannot find which control I should set to make this happen.


You can use any shape for this, e.g. an arrow. Find the item 
"Interaction" in the context menu (right mouse button) of the shape. 
Then choose item "Go to page or object" from the "Action at mouse click" 
drop-down-list and select the target.


The items in the "Form Control" toolbar are designed to be used in 
connection with a data base, not with a presentation.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ODF problem with margin between paragraphs of same style

[Regina Henschel]

Hi Miklos,

Miklos Vajna schrieb:

Hi Regina,

On Sun, May 28, 2017 at 11:01:14PM +0200, Regina Henschel 
<rb.hensc...@t-online.de> wrote:

What to do?
(1) Make a hard cut and render it correctly if a document is saved in ODF
1.3?
(2) Add an attribute to ODF 1.3 to allow such rendering?


The usual approach we take is enabling incomaptible-but-sane behavior
for new documents only. See e.g.
c5cf8824a619401627f18abc7b3049551c71ac2a from Michael Stahl for an
example of adding a layout compat flag to keep old documents as-is, but
have some sanity for new documents. (In the context of Writer.)


So I will take it as a simple bug, with no need for any action in the 
ODF TC.


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

ODF problem with margin between paragraphs of same style

[Regina Henschel]

Hi all,

LibreOffice and all older versions down to OOo1.1.5 (the oldest one I 
have installed) fill the margin between two paragraphs with the 
background of the padding rectangle, in case that the two paragraphs 
have got the same style.


That behavior is not correct. According to CSS, which is referenced in 
the end by ODF 1.2, the margin is _always_ transparent.


I'm writing here to the dev-list, because you will have to implement any 
changes.


The problem is described in 
https://bugs.documentfoundation.org/show_bug.cgi?id=106021. The bug 
report has a file attached and screenshots how this file is rendered in 
other applications.


What to do?
(1) Make a hard cut and render it correctly if a document is saved in 
ODF 1.3?

(2) Add an attribute to ODF 1.3 to allow such rendering?

Other suggestions?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

No menu bar on Lenovo T470s

[Regina Henschel]

Hi experts,

in bug https://bugs.documentfoundation.org/show_bug.cgi?id=107764 is a 
report, that an installation of LO 5.3.2 or LO5.3.3 on a new Lenovo 
Thinkpad T470s results in missing menu bars.


Has anyone access to such a notebook to test, or has anyone an idea, 
what might be wrong?


I have collected already some information from the reporter and do not 
see any user error.


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/svx sd/source svx/source

[Regina Henschel]

 include/svx/polypolygoneditor.hxx |3 +--
 sd/source/ui/animations/motionpathtag.cxx |6 +++---
 svx/source/svdraw/polypolygoneditor.cxx   |6 +++---
 svx/source/svdraw/svdpoev.cxx |6 +++---
 4 files changed, 10 insertions(+), 11 deletions(-)

New commits:
commit c10aaf94a9054e48ddd1112c84876eecd3dec726
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Sun Jan 29 01:03:16 2017 +0100

tdf#105545 Allow closed paths having 2 points

Closed paths with 2 points can be created from scratch,
therefore allow them too, if a point is deleted.
Remove now unused member mbIsClosed

Change-Id: Iac2a08df52f734c99c6ac14d9f1a16d8b943d399
Reviewed-on: https://gerrit.libreoffice.org/33654
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/include/svx/polypolygoneditor.hxx 
b/include/svx/polypolygoneditor.hxx
index a65200fd3ad2..c5b079d707c8 100644
--- a/include/svx/polypolygoneditor.hxx
+++ b/include/svx/polypolygoneditor.hxx
@@ -34,7 +34,7 @@ namespace sdr
 class SVX_DLLPUBLIC PolyPolygonEditor
 {
 public:
-PolyPolygonEditor( const basegfx::B2DPolyPolygon& rPolyPolygon, bool 
bClosed );
+PolyPolygonEditor( const basegfx::B2DPolyPolygon& rPolyPolygon);
 
 const basegfx::B2DPolyPolygon& GetPolyPolygon() const { return 
maPolyPolygon; }
 
@@ -58,7 +58,6 @@ public:
 
 private:
 basegfx::B2DPolyPolygon maPolyPolygon;
-bool mbIsClosed;
 };
 
 }
diff --git a/sd/source/ui/animations/motionpathtag.cxx 
b/sd/source/ui/animations/motionpathtag.cxx
index 39369192911d..4ce9ad62bc66 100644
--- a/sd/source/ui/animations/motionpathtag.cxx
+++ b/sd/source/ui/animations/motionpathtag.cxx
@@ -1036,7 +1036,7 @@ void MotionPathTag::DeleteMarkedPoints()
 mrView.BrkAction();
 
 SdrUShortCont& rPts = mpMark->GetMarkedPoints();
-PolyPolygonEditor aEditor( mpPathObj->GetPathPoly(), 
mpPathObj->IsClosed() );
+PolyPolygonEditor aEditor( mpPathObj->GetPathPoly());
 if (aEditor.DeletePoints(rPts))
 {
 if( aEditor.GetPolyPolygon().count() )
@@ -1088,7 +1088,7 @@ void 
MotionPathTag::SetMarkedSegmentsKind(SdrPathSegmentKind eKind)
 if(mpPathObj && isSelected() && (GetMarkedPointCount() != 0))
 {
 SdrUShortCont& rPts = mpMark->GetMarkedPoints();
-PolyPolygonEditor aEditor( mpPathObj->GetPathPoly(), 
mpPathObj->IsClosed() );
+PolyPolygonEditor aEditor( mpPathObj->GetPathPoly() );
 if (aEditor.SetSegmentsKind(eKind, rPts))
 {
 mpPathObj->SetPathPoly(aEditor.GetPolyPolygon());
@@ -1138,7 +1138,7 @@ void 
MotionPathTag::SetMarkedPointsSmooth(SdrPathSmoothKind eKind)
 if(mpPathObj && mpMark && isSelected() && (GetMarkedPointCount() != 0))
 {
 SdrUShortCont& rPts = mpMark->GetMarkedPoints();
-PolyPolygonEditor aEditor( mpPathObj->GetPathPoly(), 
mpPathObj->IsClosed() );
+PolyPolygonEditor aEditor( mpPathObj->GetPathPoly());
 if (aEditor.SetPointsSmooth(eFlags, rPts))
 {
 mpPathObj->SetPathPoly(aEditor.GetPolyPolygon());
diff --git a/svx/source/svdraw/polypolygoneditor.cxx 
b/svx/source/svdraw/polypolygoneditor.cxx
index 9fab1ba153f3..3cdd3c799231 100644
--- a/svx/source/svdraw/polypolygoneditor.cxx
+++ b/svx/source/svdraw/polypolygoneditor.cxx
@@ -25,9 +25,8 @@
 
 namespace sdr {
 
-PolyPolygonEditor::PolyPolygonEditor( const basegfx::B2DPolyPolygon& 
rPolyPolygon, bool bClosed )
+PolyPolygonEditor::PolyPolygonEditor( const basegfx::B2DPolyPolygon& 
rPolyPolygon)
 : maPolyPolygon( rPolyPolygon )
-, mbIsClosed( bClosed )
 {
 }
 
@@ -46,7 +45,8 @@ bool PolyPolygonEditor::DeletePoints( const std::set< 
sal_uInt16 >& rAbsPoints )
 
 aCandidate.remove(nPnt);
 
-if( ( mbIsClosed && aCandidate.count() < 3L) || 
(aCandidate.count() < 2L) )
+
+if( aCandidate.count() < 2L )
 {
 maPolyPolygon.remove(nPoly);
 }
diff --git a/svx/source/svdraw/svdpoev.cxx b/svx/source/svdraw/svdpoev.cxx
index 77185149eafb..9d259ab4f319 100644
--- a/svx/source/svdraw/svdpoev.cxx
+++ b/svx/source/svdraw/svdpoev.cxx
@@ -207,7 +207,7 @@ void 
SdrPolyEditView::SetMarkedPointsSmooth(SdrPathSmoothKind eKind)
 continue;
 
 SdrUShortCont& rPts = pM->GetMarkedPoints();
-PolyPolygonEditor aEditor(pPath->GetPathPoly(), pPath->IsClosed());
+PolyPolygonEditor aEditor(pPath->GetPathPoly());
 if (aEditor.SetPointsSmooth(eFlags, rPts))
 {
 if( bUndo )
@@ -240,7 +240,7 @@ void 
SdrPolyEditView::SetMarkedSegmentsKind(SdrPathSegmentKind eKind)
 if (!pPath)
 continue;
 SdrUShortCon

Re: [Libreoffice-commits] core.git: tdf#106792: Fix "Geometry" property of changed-to-bezier SvxShapePolyPolygon

[Regina Henschel]

Hi Stephan,

the steps described in the issue do not crash for me, neither with 5.4.0 
nor with 5.2.6. But I am on Win7 and my graphic card is not able to use 
OpenGL. Has some tested, whether the crash only occur with OpenGl enabled?


Kind regards
Regina

Stephan Bergmann schrieb:

Anybody familiar with that SvxShape stuff?  I see there is both
SvxShapePolyPolygon and SvxShapePolyPolygonBezier classes in
include/svx/unoshape.hxx, and wonder whether it's plausible that an
originally straight-line polygon remains an SvxShapePolyPolygon when one
of its edges is manipulated with "Convert to Curve"?  If it should
instead become an SvxShapePolyPolygonBezier then, then the proper fix
for  "Error
when saving a polygon with points converted to curve" would probably
need to be done elsewhere.

On 03/29/2017 10:11 AM, Stephan Bergmann wrote:

commit 26909d9de4c6e7165fc8f5d938ee6ef55b87cc5c
Author: Stephan Bergmann 
Date:   Wed Mar 29 09:15:48 2017 +0200

tdf#106792: Fix "Geometry" property of changed-to-bezier
SvxShapePolyPolygon

After "Convert to Curve" as described in the issue, the shape
apparently is
still an SvxShapePolyPolygon shape but with getShapeKind() of
OBJ_PATHLINE
instead of OBJ_PLIN (and same for OBJ_PATHFILL).  That causes
XMLShapeExport::ImpExportPolygonShape
(xmloff/source/draw/shapeexport.cxx) to
determine bBezier == true and thus expect the obtained "Geometry"
property to be
of type css::drawing::PolyPolygonBezierCoords, not merely
css::drawing::PointSequenceSequence.

Smells like this issue had always been present, and would have
caused bad memory
access when accessing the
non-css::drawing::PolyPolygonBezierCoords object in
XMLShapeExport::ImpExportPolygonShape, and only now throws an
exception since
0d7c5823124696f80583ac2a5f0e28f329f6f786 "New o3tl::try/doGet to
obtain value
from Any".

Change-Id: Ica31a114e5beac97bac2a1c509eb1a85f8354d5e
Reviewed-on: https://gerrit.libreoffice.org/35825
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/svx/source/unodraw/unoshap2.cxx
b/svx/source/unodraw/unoshap2.cxx
index bf964ff653db..201b245b0017 100644
--- a/svx/source/unodraw/unoshap2.cxx
+++ b/svx/source/unodraw/unoshap2.cxx
@@ -1123,9 +1123,25 @@ bool SvxShapePolyPolygon::getPropertyValueImpl(
const OUString& rName, const Sfx
 if(mpObj.is())
 mpObj->TRGetBaseGeometry(aNewHomogenMatrix,
aNewPolyPolygon);

-drawing::PointSequenceSequence aRetval(aNewPolyPolygon.count());
-B2DPolyPolygonToSvxPointSequenceSequence(aNewPolyPolygon,
aRetval);
-rValue <<= aRetval;
+switch (getShapeKind()) {
+case OBJ_PATHLINE:
+case OBJ_PATHFILL:
+{
+drawing::PolyPolygonBezierCoords aRetval;
+basegfx::unotools::b2DPolyPolygonToPolyPolygonBezier(
+aNewPolyPolygon, aRetval);
+rValue <<= aRetval;
+break;
+}
+default:
+{
+drawing::PointSequenceSequence
aRetval(aNewPolyPolygon.count());
+B2DPolyPolygonToSvxPointSequenceSequence(
+aNewPolyPolygon, aRetval);
+rValue <<= aRetval;
+break;
+}
+}
 break;
 }
 case OWN_ATTR_VALUE_POLYGON:


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Invalid ODF

[Regina Henschel]

Hi,

Michael Stahl schrieb:

On 03.04.2017 20:21, Regina Henschel wrote:

Hi all,

does a meta issue exists for those bugs, where LibreOffice writes
invalid ODF? Or is there a way to mark such bugs in a consistent way?


hi Regina,

there are 2 words you can put in whiteboard:


The Whiteboard field is not available when creating an issue.



"odf" -> this is any ODF interop issue

"odf_validation" -> this is narrowly defined as something that an ODF
validator complains about


I do not find any description. I have looked at
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard
and
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard/Inactive
and
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard/Advanced

I do not belong to the QA-team, but I write a lot of bug reports and 
comments. So it would be nice to get an "official" description.




of course, not every invalid ODF issue is detectable by a validator...
perhaps the separate keyword odf_validation exists because these issues
are often quite easy to fix :)


Kind regards
Regina
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] Invalid ODF

[Regina Henschel]

Hi all,

does a meta issue exists for those bugs, where LibreOffice writes 
invalid ODF? Or is there a way to mark such bugs in a consistent way?


Kind regards
Regina
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: oox/source

[Regina Henschel]

 oox/source/ppt/timenodelistcontext.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 386748d514fe1c84e4d373b828841308580665a8
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Tue Feb 14 20:18:51 2017 +0100

tdf#99617 convert powerpoint angle to degree

1 powerpoint angle unit = 1/6 degree
Roundtrip test not yet possible because of tdf#106002.

Change-Id: I5854c4f9f013f1a2db7e9536fc9cf5198c7a02ed
Reviewed-on: https://gerrit.libreoffice.org/34279
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>

diff --git a/oox/source/ppt/timenodelistcontext.cxx 
b/oox/source/ppt/timenodelistcontext.cxx
index 3aaa9815d57e..ef62a85e44f2 100644
--- a/oox/source/ppt/timenodelistcontext.cxx
+++ b/oox/source/ppt/timenodelistcontext.cxx
@@ -695,18 +695,18 @@ namespace oox { namespace ppt {
 // sd/source/filter/ppt/pptinanimations.cxx
 if(attribs.hasAttribute( XML_by ) )
 {
-sal_Int32 nBy = attribs.getInteger( XML_by, 0 );
-pNode->setBy( makeAny( (double) nBy ) );
+double fBy = attribs.getDouble( XML_by, 0.0 ) / 
PER_DEGREE; //1 PowerPoint-angle-unit = 1/6 degree
+pNode->setBy( makeAny( fBy ) );
 }
 if(attribs.hasAttribute( XML_from ) )
 {
-sal_Int32 nFrom = attribs.getInteger( XML_from, 0 );
-pNode->setFrom( makeAny( (double) nFrom ) );
+double fFrom = attribs.getDouble( XML_from, 0.0 ) / 
PER_DEGREE;
+pNode->setFrom( makeAny( fFrom ) );
 }
 if(attribs.hasAttribute( XML_to ) )
 {
-sal_Int32 nTo = attribs.getInteger( XML_to, 0 );
-pNode->setTo( makeAny( (double) nTo ) );
+double fTo = attribs.getDouble( XML_to, 0.0 ) / PER_DEGREE;
+pNode->setTo( makeAny( fTo ) );
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - svx/source

[Regina Henschel]

 svx/source/svdraw/svdopath.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 89f08aecf58c97cc75eaae1d7b5e8531b04eaccd
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Sat Feb 4 00:19:46 2017 +0100

tdf#105656 only delete path if less than 2 points

This prevents the crash. It might be related to
gerrit #/c/33654

Change-Id: I92907c7874964af722b69ed8afd9249e110b3401
Reviewed-on: https://gerrit.libreoffice.org/33907
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: jan iversen <j...@documentfoundation.org>
(cherry picked from commit 9e8f2afc2e2bbdbe136e74a24fb6c6eb94cde3c6)
Reviewed-on: https://gerrit.libreoffice.org/34688
Reviewed-by: Thorsten Behrens <thorsten.behr...@cib.de>

diff --git a/svx/source/svdraw/svdopath.cxx b/svx/source/svdraw/svdopath.cxx
index 1ba7ff8..21feaf9 100644
--- a/svx/source/svdraw/svdopath.cxx
+++ b/svx/source/svdraw/svdopath.cxx
@@ -879,7 +879,7 @@ bool ImpPathForDragAndCreate::endPathDrag(SdrDragStat& 
rDrag)
 basegfx::B2DPolygon 
aCandidate(aTempPolyPolygon.getB2DPolygon(nPoly));
 aCandidate.remove(nPnt);
 
-if((IsClosed(meObjectKind) && aCandidate.count() < 3L) || 
aCandidate.count() < 2L)
+if(aCandidate.count() < 2L)
 {
 aTempPolyPolygon.remove(nPoly);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Tool for converting PowerPoint angle to degree

[Regina Henschel]

Hi Tomaž,

Tomaž Vajngerl schrieb:


Seems like there is a good place in
include/oox/drawingml/drawingmltypes.hxx (where EMU to 100th
conversion is) and as far as I see PER_DEGREE constant is what you are
searching for. If you'll add a conversion method I think it is best to
add it into this header too.



I'll add it there. It looks indeed suitable.

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Tool for converting PowerPoint angle to degree

[Regina Henschel]

Hi all,

I'm looking at https://bugs.documentfoundation.org/show_bug.cgi?id=99617
The reason for that bug is a missing convert from the PowerPoint angle 
unit to degree. I can correct it by /6. But I think, that converting 
between PowerPoint angle unit and degree is such a common task, that 
there should already exist a tool. But I do not find such method.


If it not exists, shall I write it, if yes where? Or shall I simple fix 
it by /6 ?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svx/source

[Regina Henschel]

 svx/source/svdraw/svdopath.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9e8f2afc2e2bbdbe136e74a24fb6c6eb94cde3c6
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Sat Feb 4 00:19:46 2017 +0100

tdf#105656 only delete path if less than 2 points

This prevents the crash. It might be related to
gerrit #/c/33654

Change-Id: I92907c7874964af722b69ed8afd9249e110b3401
Reviewed-on: https://gerrit.libreoffice.org/33907
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: jan iversen <j...@documentfoundation.org>

diff --git a/svx/source/svdraw/svdopath.cxx b/svx/source/svdraw/svdopath.cxx
index 1d94274..54a83bf 100644
--- a/svx/source/svdraw/svdopath.cxx
+++ b/svx/source/svdraw/svdopath.cxx
@@ -879,7 +879,7 @@ bool ImpPathForDragAndCreate::endPathDrag(SdrDragStat& 
rDrag)
 basegfx::B2DPolygon 
aCandidate(aTempPolyPolygon.getB2DPolygon(nPoly));
 aCandidate.remove(nPnt);
 
-if((IsClosed(meObjectKind) && aCandidate.count() < 3L) || 
aCandidate.count() < 2L)
+if(aCandidate.count() < 2L)
 {
 aTempPolyPolygon.remove(nPoly);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx svx/source

[Regina Henschel]

 include/svx/svdopath.hxx  |2 
 svx/source/customshapes/EnhancedCustomShape2d.cxx |   72 ++
 svx/source/svdraw/svdopath.cxx|2 
 3 files changed, 50 insertions(+), 26 deletions(-)

New commits:
commit 852b29b091eeb4d4b9521b082b522c37a2a6ec16
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Fri Jan 20 09:06:23 2017 +0100

tdf#105266 Make LIGHTEN and DARKEN follow MS specification

Enhanced geometry of custom shapes has got commands for LIGHTEN and
DARKEN of subpaths. MS specifies, that LIGHTEN is a blending with
white and DARKEN is a blending with black. This patch adapts the
calcuation accordingly.

Change-Id: Ie46f1a1a2210c209c3fac34a7a58758b72eb276c
Reviewed-on: https://gerrit.libreoffice.org/7
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: jan iversen <j...@documentfoundation.org>

diff --git a/include/svx/svdopath.hxx b/include/svx/svdopath.hxx
index 08f6179..85eca76 100644
--- a/include/svx/svdopath.hxx
+++ b/include/svx/svdopath.hxx
@@ -69,7 +69,7 @@ public:
 double GetBrightness() { return mdBrightness; }
 
 SdrPathObj(SdrObjKind eNewKind);
-SdrPathObj(SdrObjKind eNewKind, const basegfx::B2DPolyPolygon& rPathPoly, 
double dBrightness = 1.0);
+SdrPathObj(SdrObjKind eNewKind, const basegfx::B2DPolyPolygon& rPathPoly, 
double dBrightness = 0.0);
 virtual ~SdrPathObj() override;
 
 virtual void TakeObjInfo(SdrObjTransformInfoRec& rInfo) const override;
diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx 
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index c5c0601..011a4ac 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -1039,16 +1039,40 @@ sal_Int32 EnhancedCustomShape2d::GetLuminanceChange( 
sal_uInt32 nIndex ) const
 
 Color EnhancedCustomShape2d::GetColorData( const Color& rFillColor, sal_uInt32 
nIndex, double dBrightness ) const
 {
-const sal_Int32 nLuminance = GetLuminanceChange(nIndex);
-if( !nLuminance && dBrightness == 1.0 )
-return rFillColor;
-
-basegfx::BColor aHSVColor=
-basegfx::tools::rgb2hsv(
-basegfx::BColor(rFillColor.GetRed()/255.0,
-rFillColor.GetGreen()/255.0,
-rFillColor.GetBlue()/255.0));
-if (nLuminance ) {
+if ( bOOXMLShape || ( mso_sptMin == eSpType /* ODF "non-primitive" */ ) )
+{ //do LibreOffice way, using dBrightness
+if ( dBrightness == 0.0)
+{
+return rFillColor;
+}
+else
+{
+if (dBrightness >=0.0)
+{ //lighten, blending with white
+return Color( (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(rFillColor.GetRed() * (1.0-dBrightness) + dBrightness * 255.0, 
0.0, 255.0)  ),
+  (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(rFillColor.GetGreen() * (1.0-dBrightness) + dBrightness * 255.0, 
0.0, 255.0) ),
+  (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(rFillColor.GetBlue() * (1.0-dBrightness) + dBrightness * 255.0, 
0.0, 255.0) )  );
+}
+else
+{ //darken (indicated by negative sign), blending with black
+return Color( (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(rFillColor.GetRed() * (1.0+dBrightness), 0.0, 255.0)  ),
+  (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(rFillColor.GetGreen() * (1.0+dBrightness), 0.0, 255.0) ),
+  (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(rFillColor.GetBlue() * (1.0+dBrightness), 0.0, 255.0) )  );
+}
+}
+}
+else
+{ //do OpenOffice way, using nColorData
+const sal_Int32 nLuminance = GetLuminanceChange(nIndex);
+if( !nLuminance )
+return rFillColor;
+
+basegfx::BColor aHSVColor=
+basegfx::tools::rgb2hsv(
+basegfx::BColor(rFillColor.GetRed()/255.0,
+rFillColor.GetGreen()/255.0,
+rFillColor.GetBlue()/255.0));
+
 if( nLuminance > 0 )
 {
 aHSVColor.setGreen(
@@ -1062,12 +1086,12 @@ Color EnhancedCustomShape2d::GetColorData( const Color& 
rFillColor, sal_uInt32 n
 aHSVColor.setBlue(
 (1.0+nLuminance/100.0)*aHSVColor.getBlue());
 }
-}
 
-aHSVColor = basegfx::tools::hsv2rgb(aHSVColor);
-return Color( (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(dBrightness*aHSVColor.getRed(),0.0,1.0) * 255.0 + 0.5 ),
-  (sal_uInt8)static_cast< sal_Int32 >( 
basegfx::clamp(dBrightness*aHSVColor.getGreen(),0.0,1.0) * 255.0 + 0.5 ),
-   

Re: ODF TC issue 2049 custom shape enhancement

[Regina Henschel]

Hi Mark,

Mark Hung schrieb:

Hi Regina,

Sorry that being late to reply about this topic.


It is on the agenda of the TC, but we will surely not decide next Monday.

 I've spend some time in

oox last year. I try to make built-in shapes export to ooxml as much as
possible.


The problem with built-in shapes in the view of ODF file format is, that 
the rendering in LO depends on 'draw:type' attribute. But that should 
not be.


 It might be a little wired, but my major concern about

blending to another color value is how reset of the filters can emulate
the effect.  Currently users can group different shapes with different
transparency.  That might be an alternative although there are still
differences.


I do not understand you. The problem is how to specify changes to the 
color of a subpath in an enhanced geometry.


The current implementation has three concepts:
(1) Use the new commands H I J K inside the 'drawooo:enhanced-path' 
attribute in case of draw:type="ooxml-foo" and direct pptx import.
(2a) Use a value for the member nColorData which is set from constants 
inside the ctor of the enhanced-geometry. This is used in case of 
"mso_sptfoo".
(2b) Extract the value for the member nColorData from the value in 
draw:type. That is done for the cases draw:type="col-nnn". That is used 
for the shapes "Octagon Bevel" and "Diamond Bevel", but would work for 
other shapes too, see attached document.


The colors in (1) are currently different from the specification for the 
OOXML attribute 'ST_PathFillMode'. I think, that is a bug and have 
proposed a patch to change that.


But using nColorData allows colors, that cannot be represented with the 
four values possible in the OOXML attribute 'ST_PathFillMode'. On the 
other hand, besides the shapes "ActionButtonHome" and "CurvedArrow" only 
20% and 40% is actually used and LibreOffice is not effected for direct 
pptx import but only for documents which already contain shapes of type 
"mso_sptfoo" or "col-nnn".


Kind regards
Regina



Best Regards.

2017-01-14 23:34 GMT+08:00 Regina Henschel <rb.hensc...@t-online.de
<mailto:rb.hensc...@t-online.de>>:

Hi all,

the ODF TC is going to discuss
https://issues.oasis-open.org/browse/OFFICE-2049
<https://issues.oasis-open.org/browse/OFFICE-2049>.
The MS Office preset shapes have subpaths, which are lighten or
darken, e.g. the shape type “Borders”, which is “quad-bevel” in
LibreOffice. The issue is about adding a way to store such subpath
information in the file. In ODF 1.2 it is not possible.

Apache OpenOffice does not store the information, but renders the
shape depending on its type name. That works only for the preset
shapes of OOXML. In LibreOffice this subpath information is stored
as new path commands. LibreOffice uses an own namespace “drawooo”
for that. This has been added by commits by Radek Doulik at 2012-01-11.

But the implementation is faulty, see
https://bugs.documentfoundation.org/show_bug.cgi?id=105266
<https://bugs.documentfoundation.org/show_bug.cgi?id=105266>.
On the other hand there is the request for multiple colors for the
enhanced-geometry, see
https://bugs.documentfoundation.org/show_bug.cgi?id=103298
<https://bugs.documentfoundation.org/show_bug.cgi?id=103298>

I can imagine this solution: Add a new attribute to the
 element which carries a list of value
pairs. Such pair has a factor from [0;1] for the degree of blending
and a color value for the blending color. Such attribute would be
able to carry the information needed for “lighten” and “darken”, but
give the additional opportunity to implement color change in subpath.

My question, should ODF 1.3 follow the current LO way and add new
path commands? Or do you like my other idea, or do you have a
different idea?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
<mailto:LibreOffice@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/libreoffice
<https://lists.freedesktop.org/mailman/listinfo/libreoffice>




--
Mark Hung




BlendingFromType.fodg
Description: application/vnd.oasis.opendocument.graphics-flat-xml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

[Regina Henschel]

Hi Khaled,

Khaled Hosny schrieb:

On Fri, Jan 20, 2017 at 04:55:56PM +0100, Regina Henschel wrote:

Hi,

Khaled Hosny schrieb:


Hmm, interesting. They don’t fail for me or in the CI builds, I wonder
what is different on your system that would cause most of the tests to
fail?



Can you tell me, what is relevant for the tests? Then I can post information
about my system.


I’m still to get to the bottom of these tests, but my hunch is that they
are very sensitive to fonts, since the file used seem to use all sorts
of fonts that might or might not always be installed. So have you done
anything unusual with the fonts on your system?


"ClearType" is activated on my system.

I've got about 350 fonts, a lot of them with the common four font faces. 
These include the fonts, which you get from Windows to support Asian 
languages.


The text size in Windows for the screen is set to 125%.

I've got a "ATI Radeon HD 3200 Graphics" on board graphics card and use 
it in 1920 x 1080.


I don't know, whether this is "unusual".

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

[Regina Henschel]

Hi,

Khaled Hosny schrieb:


Hmm, interesting. They don’t fail for me or in the CI builds, I wonder
what is different on your system that would cause most of the tests to
fail?



Can you tell me, what is relevant for the tests? Then I can post 
information about my system.


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: CppunitTest_chart2_xshape fails

[Regina Henschel]

Hi,

how can I disable this special test? Or is there something in my 
environment, which I can change, so that the test do not fail? Or can we 
get it disabled as default on Windows?


Kind regards
Regina

Michael Stahl schrieb:

On 20.01.2017 00:24, Regina Henschel wrote:

Hi Michael,

Michael Stahl schrieb:

On 19.01.2017 18:28, Regina Henschel wrote:

Hi,

the build still breaks, now with error

C:\LO_buildDebug\core\include\rtl/ref.hxx(100) : error C2027: use of
undefined type 'SwTextAPIObject'


unfortunately there were ~2 more breakages but now master builds again
on windows.


The pure build works now. But it fails in unit test chart2_xshape. I
have attached the log.


CppunitTest_chart2_xshape is an optional layout test that will be
enabled only with --enable-chart-tests ... or by default on windows,
since this commit:

commit 5cd7b656de392a6dcd05cd55cf9d330c0ab5cd07
Author: Khaled Hosny <khaledho...@eglug.org>
AuthorDate: Mon Jan 16 16:13:55 2017 +0200

Enable Chart XShape tests on Windows by default

They pass both locally and on CI builds on Windows, so I think they
are reliable enough to be enabled by default. On Linux CI builds one
tests is failing but not locally, so not enabling them on Linux for
now. Mac is a whole different story with most of the tests failing.



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

[Regina Henschel]

Hi Michael,

Michael Stahl schrieb:

On 19.01.2017 18:28, Regina Henschel wrote:

Hi,

the build still breaks, now with error

C:\LO_buildDebug\core\include\rtl/ref.hxx(100) : error C2027: use of
undefined type 'SwTextAPIObject'


unfortunately there were ~2 more breakages but now master builds again
on windows.


The pure build works now. But it fails in unit test chart2_xshape. I 
have attached the log.


Kind regards
Regina
cd C:/LO_buildDebug/core/chart2 && C:/cygwin/opt/lo/bin/make -j 4 -rs check
[build CUT] chart2_common_functors
[build CUT] chart2_export
[build CUT] chart2_import
[build CUT] chart2_trendcalculators
[build CUT] chart2_xshape
warn:sal.bootstrap:3928:3656:sal/rtl/bootstrap.cxx:379: couldn't open file: 
file:///C:/LO_buildDebug/core/workdir/LinkTarget/Executable/cppunittester.ini
warn:sfx.appl:3928:3656:sfx2/source/appl/app.cxx:199: No DDE-Service possible. 
Error: 16399
warn:vcl.opengl:3928:3656:vcl/opengl/win/WinDeviceInfo.cxx:486: use : 
warn:sc:3928:3656:sc/source/filter/orcus/orcusfiltersimpl.cxx:163: Unable to 
load styles from xml file! failed to load \calc\styles.xml
warn:linguistic:3928:3656:linguistic/source/lngsvcmgr.cxx:460: no extension 
manager - should fire on mobile only
warn:chart2:3928:3656:chart2/source/view/main/ShapeFactory.cxx:2135: Exception 
caught. Type: class com::sun::star::uno::Exception, Message: 
warn:chart2:3928:3656:chart2/source/view/main/ShapeFactory.cxx:2135: Exception 
caught. Type: class com::sun::star::uno::Exception, Message: 
warn:vcl.window:3928:3656:vcl/source/window/window.cxx:3246: ignoring 
DeploymentException "component context fails to supply service 
com.sun.star.datatransfer.clipboard.SystemClipboard of type 
com.sun.star.datatransfer.clipboard.XSystemClipboard"
warn:vcl:3928:3656:vcl/win/window/salframe.cxx:1100: WinSalFrame::SetIcon(): 
Could not load large icon !
warn:vcl:3928:3656:vcl/win/window/salframe.cxx:1101: WinSalFrame::SetIcon(): 
Could not load small icon !
warn:sfx.control:3928:3656:sfx2/source/control/dispatch.cxx:1415: Childwindow 
slot missing: 25807
warn:vcl.layout:3928:3656:vcl/source/window/builder.cxx:210: Unable to read .ui 
file: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/svx/ui/sidebarstylespanel.ui
warn:sfx.sidebar:3928:3656:sfx2/source/sidebar/SidebarController.cxx:864: 
Cannot create panel 
private:resource/toolpanel/SvxPanelFactory/StylesPropertyPanel: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/svx/ui/sidebarstylespanel.ui
warn:vcl.layout:3928:3656:vcl/source/window/builder.cxx:210: Unable to read .ui 
file: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/svx/ui/sidebartextpanel.ui
warn:sfx.sidebar:3928:3656:sfx2/source/sidebar/SidebarController.cxx:864: 
Cannot create panel 
private:resource/toolpanel/SvxPanelFactory/TextPropertyPanel: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/svx/ui/sidebartextpanel.ui
warn:vcl.layout:3928:3656:vcl/source/window/builder.cxx:210: Unable to read .ui 
file: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/modules/scalc/ui/sidebarnumberformat.ui
warn:sfx.sidebar:3928:3656:sfx2/source/sidebar/SidebarController.cxx:864: 
Cannot create panel 
private:resource/toolpanel/ScPanelFactory/NumberFormatPropertyPanel: 
ScPanelFactory::createUIElement exception
warn:vcl.layout:3928:3656:vcl/source/window/builder.cxx:210: Unable to read .ui 
file: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/modules/scalc/ui/sidebaralignment.ui
warn:sfx.sidebar:3928:3656:sfx2/source/sidebar/SidebarController.cxx:864: 
Cannot create panel 
private:resource/toolpanel/ScPanelFactory/AlignmentPropertyPanel: 
ScPanelFactory::createUIElement exception
warn:vcl.layout:3928:3656:vcl/source/window/builder.cxx:210: Unable to read .ui 
file: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/modules/scalc/ui/sidebarcellappearance.ui
warn:sfx.sidebar:3928:3656:sfx2/source/sidebar/SidebarController.cxx:864: 
Cannot create panel 
private:resource/toolpanel/ScPanelFactory/CellAppearancePropertyPanel: 
ScPanelFactory::createUIElement exception
warn:vcl.layout:3928:3656:vcl/source/window/builder.cxx:210: Unable to read .ui 
file: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/svx/ui/sidebarstylespanel.ui
warn:sfx.sidebar:3928:3656:sfx2/source/sidebar/SidebarController.cxx:864: 
Cannot create panel 
private:resource/toolpanel/SvxPanelFactory/StylesPropertyPanel: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/svx/ui/sidebarstylespanel.ui
warn:vcl.layout:3928:3656:vcl/source/window/builder.cxx:210: Unable to read .ui 
file: 
file:///C:/LO_buildDebug/core/workdir/unittest/user/config/soffice.cfg/svx/ui/sidebartextpanel.ui
warn:sfx.sidebar:3928:3656:sfx2/source/sidebar/SidebarController.cxx:864: 
Cannot create panel 
private:resource/toolpanel/SvxPanelFactory/TextPropert

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

[Regina Henschel]

Hi,

the build still breaks, now with error

C:\LO_buildDebug\core\include\rtl/ref.hxx(100) : error C2027: use of 
undefined type 'SwTextAPIObject'
C:\LO_buildDebug\core\sw\inc\docufld.hxx(34) : see declaration of 
'SwTextAPIObject'
C:\LO_buildDebug\core\include\rtl/ref.hxx(98) : while compiling class 
template member function 'rtl::Reference 
::Reference::set(reference_type *)'

with
[
reference_type=SwTextAPIObject
]
C:\LO_buildDebug\core\include\rtl/ref.hxx(115) : see reference to 
function template instantiation 'rtl::Reference 
::Reference::set(reference_type *)' being compiled

with
[
reference_type=SwTextAPIObject
]
C:\LO_buildDebug\core\sw\inc\docufld.hxx(446) : see reference to class 
template instantiation 'rtl::Reference' being compiled
C:\LO_buildDebug\core\include\rtl/ref.hxx(100) : error C2227: left of 
'->acquire' must point to class/struct/union/generic type
C:\LO_buildDebug\core\include\rtl/ref.hxx(104) : error C2027: use of 
undefined type 'SwTextAPIObject'
C:\LO_buildDebug\core\sw\inc\docufld.hxx(34) : see declaration of 
'SwTextAPIObject'
C:\LO_buildDebug\core\include\rtl/ref.hxx(104) : error C2227: left of 
'->release' must point to class/struct/union/generic type
C:/LO_buildDebug/core/solenv/gbuild/PrecompiledHeaders.mk:40: recipe for 
target 
'C:/LO_buildDebug/core/workdir/PrecompiledHeader/debug/precompiled_sw.hxx.gch' 
failed
make[1]: *** 
[C:/LO_buildDebug/core/workdir/PrecompiledHeader/debug/precompiled_sw.hxx.gch] 
Error 2


Kind regards
Regina



Regina Henschel schrieb:

Hi Michael,

thanks, will make a new "pull" and try again.

Kind regards
Regina

Michael Stahl schrieb:

On 19.01.2017 15:03, Regina Henschel wrote:

Hi all,

I have made a clean build with fresh rebase from today without any own
changes. It breaks with error message
C:/LO_buildDebug/core/embeddedobj/source/msole/olemisc.cxx(134) : error
C2614: 'OleEmbeddedObject' : illegal member initialization: 'm_pOwnView'
is not a base or member
[build CXX] embeddedobj/source/msole/olevisual.cxx


apparently that was fixed an hour ago in commit
5e58ea581e330680ce0a6695b86fd909d7b5fcb0 "fix windows build"


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: build breaks in embeddedobj/source/msole/olemisc.cxx

[Regina Henschel]

Hi Michael,

thanks, will make a new "pull" and try again.

Kind regards
Regina

Michael Stahl schrieb:

On 19.01.2017 15:03, Regina Henschel wrote:

Hi all,

I have made a clean build with fresh rebase from today without any own
changes. It breaks with error message
C:/LO_buildDebug/core/embeddedobj/source/msole/olemisc.cxx(134) : error
C2614: 'OleEmbeddedObject' : illegal member initialization: 'm_pOwnView'
is not a base or member
[build CXX] embeddedobj/source/msole/olevisual.cxx


apparently that was fixed an hour ago in commit
5e58ea581e330680ce0a6695b86fd909d7b5fcb0 "fix windows build"


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

build breaks in embeddedobj/source/msole/olemisc.cxx

[Regina Henschel]

Hi all,

I have made a clean build with fresh rebase from today without any own 
changes. It breaks with error message
C:/LO_buildDebug/core/embeddedobj/source/msole/olemisc.cxx(134) : error 
C2614: 'OleEmbeddedObject' : illegal member initialization: 'm_pOwnView' 
is not a base or member

[build CXX] embeddedobj/source/msole/olevisual.cxx

I'm on Windows 7.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

ODF TC issue 2049 custom shape enhancement

[Regina Henschel]

Hi all,

the ODF TC is going to discuss
https://issues.oasis-open.org/browse/OFFICE-2049.
The MS Office preset shapes have subpaths, which are lighten or darken, 
e.g. the shape type “Borders”, which is “quad-bevel” in LibreOffice. The 
issue is about adding a way to store such subpath information in the 
file. In ODF 1.2 it is not possible.


Apache OpenOffice does not store the information, but renders the shape 
depending on its type name. That works only for the preset shapes of 
OOXML. In LibreOffice this subpath information is stored as new path 
commands. LibreOffice uses an own namespace “drawooo” for that. This has 
been added by commits by Radek Doulik at 2012-01-11.


But the implementation is faulty, see
https://bugs.documentfoundation.org/show_bug.cgi?id=105266.
On the other hand there is the request for multiple colors for the 
enhanced-geometry, see

https://bugs.documentfoundation.org/show_bug.cgi?id=103298

I can imagine this solution: Add a new attribute to the 
 element which carries a list of value pairs. 
Such pair has a factor from [0;1] for the degree of blending and a color 
value for the blending color. Such attribute would be able to carry the 
information needed for “lighten” and “darken”, but give the additional 
opportunity to implement color change in subpath.


My question, should ODF 1.3 follow the current LO way and add new path 
commands? Or do you like my other idea, or do you have a different idea?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Need help for building

[Regina Henschel]

Hi all,

Regina Henschel schrieb:

Hi Mike,

Kaganski Mike schrieb:

On 12/31/2016 3:59 PM, Regina Henschel wrote:

my last build was in August. Now I tried a new build, but it fails. I
have started with
git pull -r


I may remember that wrong, but I have a feeling that it was this problem
when I was given an advise to use ./g pull -r instead of git pull -r


That seems to work. At least compiling is running now.


Build was successful. :)

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Need help for building

[Regina Henschel]

Hi Mike,

Kaganski Mike schrieb:

On 12/31/2016 3:59 PM, Regina Henschel wrote:

my last build was in August. Now I tried a new build, but it fails. I
have started with
git pull -r


I may remember that wrong, but I have a feeling that it was this problem
when I was given an advise to use ./g pull -r instead of git pull -r


That seems to work. At least compiling is running now.

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Need help for building

[Regina Henschel]

Hi all,

my last build was in August. Now I tried a new build, but it fails. I 
have started with

git pull -r

then
/opt/lo/bin/make clean

then
/opt/lo/bin/make

It gives the error
/usr/bin/cp: der Aufruf von stat für 
„C:/LO_buildSymbol/core/workdir/CustomTarget/postprocess/images/images_breeze.zip“ 
ist nicht möglich: No such file or directory


My current autogen.input is
--with-external-tar=/cygdrive/c/LO_buildSymbol/externalsrc
--with-junit=/cygdrive/c/LO_buildSymbol/junit-4.10.jar
--with-ant-home=/cygdrive/c/cygwin/ant195
--enable-pch
--disable-ccache
--enable-symbols
--with-help

What do I miss?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Ask for help - disable OpenCL via config-file (*.xcu) or registry-key

[Regina Henschel]

Hi Thomas,

Thomas Krumbein schrieb:

Hey all,

there is a technical question in german ask.libreoffice.org system I
cannot answer.

Maybe someone can help? I will pass the answer.

#  original message:

"Hallo,

wir nutzen LibreOffice in unseren Schule für ca. 3500 Accounts. Jetzt
haben wir festgestellt, dass bei Impress im einer Fehler "fatal error"
auftritt. Wir haben rausgefunden, dass dies mit der
Hardwarebeschleunigung, Kantenglättung und OpenGL zusammenhängt.

Kann mir bitte jemand die Registry-Keys zum Deaktiveren der
Hardwarebeschleunigung und der Kantenglättung verraten? Zum deaktiveren
von OpenGL habe ich schon ein Admx-Template gefunden.

Vielen Dank"

##

free translation:

it is a school and the are using 3500 seats with LibreOffice. They do
have a problem in Impress "fatal error" (crash) - this is a problem with
OpenGL, edge smoothing and
hardware acceleration options. Now they want to disable this options via
Windows registry-Key.

##

It would help if we have a caonfiguration file (*.xcu) - I can translate
this to an registry key;)


A registry fragment to disable OpenGL is attached to 
https://bugs.documentfoundation.org/show_bug.cgi?id=93546


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: writing attribute style:background-transparency

[Regina Henschel]

Hi Armin,

Armin Le Grand schrieb:

Hi Regina,

tried, but could not create one (tried frames in SW, too).

Might have to do with the change of SW FillStyle/Transparency attributes
to the full Draw ItemSet. These get written with the same attributes as
for draw objects, but before the change that attribute might have been
used. It would be loaded and converted at import, though.

Thus, might be if you use an older version which had not that change and
insert a frame and set transparency, but no guarantees


Direct hit :)

AOO 3.4.1 writes a style:background-transparency for a Writer frame with 
background color and transparency. LibreOffice 5.3 writes 
style:background-transparency too, but in addition it writes draw:fill, 
draw:fill-color and draw:opacity.


LibreOffice writes draw:fill, draw:fill-color and draw:opacity too in 
style:page-layout-properties, however there without 
style:background-transparency. But for draw:fill, draw:fill-color and 
draw:opacity it is the same problem as for 
style:background-transparency: It is not allowed in 
style:page-layout-properties.


So my conclusion is, that a transparent property for page background is 
indeed needed. But I would suggest not to extend the 
style:background-transparency, but the draw:xyz attributes, because they 
are richer and already used in LibreOffice.


Kind regards
Regina





HTH!
ALG


Am 21.09.2016 um 19:36 schrieb Regina Henschel:

Hi all,

the ODF TC is going to discuss issue OFFICE-3770 [1], which is about
the attribute style:background-transparency. I'm trying to generate a
document by LibreOffice, in which this attribute is used. But in all
my tries I always get draw:opacity or draw:opacity-name (in case of
gradient).

Do you know a situation where LibreOffice writes the attribute
style:background-transparency ?

Kind regards
Regina

[1] https://issues.oasis-open.org/browse/OFFICE-3770
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: swriter with chart

[Regina Henschel]

Hi,

Alain ANTOCI schrieb:

Hi,


I use Delphi to develop an application which needs to work with MS
office and LibreOffice. I've a question about Chart in Libreoffice, I
need to access a chart in a libreoffice document to change values. I try
to use GetCharts then getbyname or getbyindex like in calc but it
doesn't seem to work is there anything to do, i've seen some posts
talking about writer and ole object it doesn't seem to be support yet.


Can you confirm to me if it is possible or not, or is it schedule in a
future version please ?


Charts are OLE objects. Use the Basic macro below (you might need to fix 
unwanted line breaks) and the Basic IDE to examine the Chart-object. In 
the column Type in the watch-window and in the variable 
"SupportedServiceNames" you will find the hints, which part of the API 
is relevant. The variable "Types" contains information about the 
supported methods. Or use Xray (in Basic) to examine the objects to 
learn the supported methods.


You can start examine the objects, if you set a break point at the line 
"msgbox" inside the for-loop and add the objects to the Watch-window.


Kind regards
Regina

sub ExamineEmbeddedObjects
dim oCurrentController as variant: oCurrentController = 
ThisComponent.getCurrentController()

dim oDoc as variant: oDoc=ThisComponent
if 
not(oCurrentController.supportsService("com.sun.star.text.TextDocumentView")) 
then

msgbox("Macro works only in text documents.")
exit sub
end if
dim oModelTextDocument as variant: oModelTextDocument = 
oCurrentController.Model
dim oEmbeddedObjects as variant: oEmbeddedObjects = 
oModelTextDocument.EmbeddedObjects

dim nIndex as long
dim nEndIndex as long: nEndIndex = oEmbeddedObjects.Count-1
dim oEmbeddedObject as variant: rem like green handle status
dim oModel as variant: rem like edit status
dim oXCOEO as variant: rem oExtendedControlOverEmbeddedObject
for nIndex=0 to nEndIndex
oEmbeddedObject = oEmbeddedObjects.getByIndex(nIndex)
oModel = oEmbeddedObject.Model: rem I'm not sure, whether it might be 
empty
if Not(isEmpty(oModel)) then
Rem Do something with the object
Rem Use xray or Basic IDE to examine the object
msgbox("I am: " & oEmbeddedObject.StreamName)
oXCOEO = oEmbeddedObject.ExtendedControlOverEmbeddedObject
oXCOEO.update() 
end if
next nIndex
end sub

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

writing attribute style:background-transparency

[Regina Henschel]

Hi all,

the ODF TC is going to discuss issue OFFICE-3770 [1], which is about the 
attribute style:background-transparency. I'm trying to generate a 
document by LibreOffice, in which this attribute is used. But in all my 
tries I always get draw:opacity or draw:opacity-name (in case of gradient).


Do you know a situation where LibreOffice writes the attribute 
style:background-transparency ?


Kind regards
Regina

[1] https://issues.oasis-open.org/browse/OFFICE-3770
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ODF specification regarding multistop/-color gradients

[Regina Henschel]

Hi Heiko,

Heiko Tietze schrieb:

Hello all,

the LibreOffice conference gave me the chance to present some ideas regarding 
Draw and shapes in general. One of the most wanted features is the multistop 
gradient. Today we can define gradients between two colors, either linear, 
radial, or whatever. It would be nice to have a) non-linear multistop 
gradients, for example to illustrate a sundown with a small red and a larger 
yellow section, and b) a gradient over more than two colors, e.g. in order to 
add blue sky to the sundown.

Since Calligra offers multicolor gradients, Armin and me checked how it is 
saved (the rendering is build-in right now). And it turns out that they hack 
SVG into the ODF.


That is no "hack SVG into ODF ". The feature "svg-gradient is in ODF 
from the beginning. In ODF 1.1 it is in "14.14.2 SVG Gradients", and in 
ODF 1.2 it is in 16.40.2, 
16.40.3 and 16.40.4 and its attributes in 
chapter 19. Only OpenOffice.org had no implementation for it.


The request for LO is in
https://bugs.documentfoundation.org/show_bug.cgi?id=94588

 For the (predefined) rainbow-like gradient the style.xml looks like this:







A true "rainbow" is not possible, because that needs a HSB color model. 
So using stops is the only way to do it as SVG gradient. The quoted 
snippet is all valid ODF.


ODF has some restrictions compared to SVG. But starting with that, what 
is currently possible in ODF, would help a lot. And I personally see no 
problem in getting further SVG features into ODF1.3 if needed and an 
implementation exists.




As an UX evangelist I don't care too much about the implementation


But I do. I prefer a solution with clean ODF.

Therefore I do not want an isolated, workaround solution for OOXML 
import as touched upon in 
https://bugs.documentfoundation.org/show_bug.cgi?id=76682 and was 
proposed in https://gerrit.libreoffice.org/#/c/12056/


 and have rather the workflow and interactions in mind.

It needs another UI. The linear bar as in PowerPoint is not the only 
possible solution. I like more the two dimensional way, where you define 
a way in a color area. (I just don't remember, where I saw it.)


 Ideally the multi-gradient works with all features, and not as another 
type next to linear, radial etc. (There might be a problem that result 
in this sub-optimal solution).


It is another kind of gradient. The  kind 'rectangle' and 
'square' are not possible with SVG.




And finally we have to take interoperability into account as well as the 
conformity to the ODF specs (no idea if and how it is defined).


See above.



So how do we make multistop/multicolor gradients possible?


There exists already rendering solutions in rendering SVG-images.




Cheers,
Heiko

PS: Suggestions on how to implement this feature in the UI are existing.


Where?

Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

ODF problems with feature table-template

[Regina Henschel]

Hi,

I have locked at the new feature of storing a  and 
see some problems:


1
The link to the commit in 
https://wiki.documentfoundation.org/Development/ODF_Implementer_Notes/List_of_LibreOffice_ODF_Extensions

does not work.

2
If the document is saved as strict ODF1.2, then the attributes in loext 
namespace are not omitted as it should be, but they are written without 
any namespace.


3
If the document is saved as ODF1.1, then the attributes in loext 
namespace are written, but without namespace.


4
The generated cell styles have an attribute style:parent-style-name. Its 
value should be a reference to a style in style family "table-cell". But 
the value is in all cases the name of the  
element. I expect that there exists a default table-cell style and maybe 
in addition a basic table-cell style for this specific table template. 
Those would be suitable as value of style:parent-style-name attribute.



Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Implementing l10n in an extension

[Regina Henschel]

Hi Katarina,

Katarina Behrens schrieb:

Hello world,

I've implemented a Calc extension that includes some dialogs and I'd like to
have those translated to multiple languages. The dialogs are implemented in
this funny .xdl Basic format, the handlers in Java.

However, as you might've already expected ;) l10n didn't quite work out so
far. No matter what I do, I can't get localized strings displayed. Instead of
English or German strings, I see only the references e.g.
"&3.Dialog1.CommandButton1.Label"

It has certainly something to do with the fact that I've created l10n files
manually, since GUI for that is currently completely defunct due to [1] so if
anyone can spot an obvious mistake, something missing etc. in my data below
and/or give me some useful advice, I'd be grateful


Make sure, that the files *.properties are included in the finished 
extension. If not, copy them manually.





My folder structure:

dialogs/
   +- Dialog1.xdl
   +- Dialog2.xdl
   +- DialogStrings_de_DE.properties
   +- DialogStrings_en_US.default
   +- DialogStrings_en_US.properties
   +- dialog.xlb


What is "dialogs"? The module name?



Dialog1.xdl:



DialogStrings_en_US.properties:

3.Dialog1.CommandButton1.Label=Close

DialogStrings_de_DE.properties:

3. Dialog1.CommandButton1.Label=Schließen


Without blank after 3.
You have to escape special characters
ß   \u00df



dialog.xlb:

http://openoffice.org/2000/library;
library:name="dialogs" library:readonly="false"
library:passwordprotected="false">
  
  




Are you sure about the value of library:name? If I use the Basic Macro 
Organizer, it is the name shown in the list "Library" in tab "Libraries".


Do you have used an own module? You cannot do it in Module "Standard".

I would do a mini test in AOO or a very old LO to be sure about the 
needed structure, and then add the missing parts manually.


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Implementing l10n in an extension

[Regina Henschel]

Hi Katarina,

Katarina Behrens schrieb:
[..]



[1] https://bugs.documentfoundation.org/show_bug.cgi?id=93592



and hier

https://bugs.documentfoundation.org/show_bug.cgi?id=100792

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: icon-themes/galaxy icon-themes/hicontrast

[Regina Henschel]

 icon-themes/galaxy/svx/res/cropmarkers.png |binary
 icon-themes/hicontrast/svx/res/cropmarkers.png |binary
 2 files changed

New commits:
commit 7ffe3d742ee992cd704a52d9aeb9b131dded7d14
Author: Regina Henschel <rb.hensc...@t-online.de>
Date:   Fri Aug 12 16:50:32 2016 +0200

tdf101291 Resize cropmarkers.png to requested dimension

The pick-up positions for handles were changed some time ago and fit
cropmarkers.png of icon-themes Tango and Breeze. But Galaxy
and HighContrast were not adjusted. The patch will bring this by.

Change-Id: Ia55cc8c8196c2125f46f8f5755ec1063d68cb8e7
Reviewed-on: https://gerrit.libreoffice.org/28089
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: jan iversen <j...@documentfoundation.org>

diff --git a/icon-themes/galaxy/svx/res/cropmarkers.png 
b/icon-themes/galaxy/svx/res/cropmarkers.png
old mode 100644
new mode 100755
index 7c240df..2e11d17
Binary files a/icon-themes/galaxy/svx/res/cropmarkers.png and 
b/icon-themes/galaxy/svx/res/cropmarkers.png differ
diff --git a/icon-themes/hicontrast/svx/res/cropmarkers.png 
b/icon-themes/hicontrast/svx/res/cropmarkers.png
old mode 100644
new mode 100755
index 001b531..d4e4f48
Binary files a/icon-themes/hicontrast/svx/res/cropmarkers.png and 
b/icon-themes/hicontrast/svx/res/cropmarkers.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Help with isssue with gerrit

[Regina Henschel]

Hi Olivier,

Olivier Hallot schrieb:

Hello Regina

Here is what I have in the file config you mentioned.

8<---

[core]
 repositoryformatversion = 0
 filemode = true
 bare = false
 logallrefupdates = true
 worktree = ../../../helpcontent2
[remote "origin"]
 url = git://gerrit.libreoffice.org/help


I have added
pushurl = ssh://logerrit/help
in section [remote "origin"]

Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice