[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - include/svx sc/CppunitTest_sc_shapetest.mk sc/Module_sc.mk sc/qa sc/source svx/source

2020-02-07 Thread Regina Henschel (via logerrit)
insertions(+), 3 deletions(-) New commits: commit 7efd182997cb29ed4820145efc99a6c18e2c3303 Author: Regina Henschel AuthorDate: Thu Nov 28 19:28:29 2019 +0100 Commit: Xisco Faulí CommitDate: Fri Feb 7 18:40:31 2020 +0100 tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRect

Problems with Skia in my build

2020-02-07 Thread Regina Henschel
Hi all, after a "./g pull -r" I cannot build. It fails in Skia, see attached log. I have not yet tried a clean build. Is there anything else I can do? Kind regards Regina C:/cygwin64/opt/lo/bin/make -j 4 -rs -f D:/Build_forCommit/core/Makefile.gbuild build [build DEP]

Re: Problems in building libre-office

2020-01-30 Thread Regina Henschel
Hi Anshu, anshu khare schrieb am 30-Jan-20 um 22:15: Hi everyone, There are some issues with my pc. It can run continually for only 2-3 hours. After that it shuts down on its own. Likely overheating. You can use a tool like HWinFO64 (www.hwinfo.com) to see the current temperature. [..]

Re: help in writing tests

2020-01-26 Thread Regina Henschel
Hi Shivam, Shivam Kumar Singh schrieb am 26-Jan-20 um 18:24: Also ,  tdf123684 is very similar to tdf123841 , Check for an object and inspect its style to be FillStyle_NONE, I used the code and have submitted a patch https://gerrit.libreoffice.org/c/core/+/87440 and here is the build

Re: sign problem with shear angle in transform matrix

2020-01-23 Thread Regina Henschel
Hi Armin, Armin Le Grand schrieb am 22-Jan-20 um 18:13: Interesting - so they do the same thing and let it look like the coordinate system we all know from school and that rotates counterClockWise - a good argument to mabe just stay with that in the files. But that raises a problem with

Re: Contribution to the organization

2020-01-23 Thread Regina Henschel
Anshu schrieb am 22-Jan-20 um 13:46: Hi mentors, I am Anshu. I am new to this organization. I am willing to take part in Gsoc 2020 and I want to contribute to this organization. I was trying to build Libre-Office by following its documentation but got stuck at a point( I have Visual Studio

Re: help in writing tests

2020-01-23 Thread Regina Henschel
I had some private mails with Shivam. I have suggested to create a new document and verify, that the default style has filling NONE. default style --> style, which is "Object without fill" in the UI ___ LibreOffice mailing list

Re: help in writing tests

2020-01-23 Thread Regina Henschel
Hi all, I had some private mails with Shivam. I have suggested to create a new document and verify, that the default style has filling NONE. Code pointers for that are: new document: use loadFromDesktop with pseudo URL privat:factory/sdraw getting a style: SdImportTest::testTdf97808() in

Re: sign problem with shear angle in transform matrix

2020-01-20 Thread Regina Henschel
Hi Armin, Armin Le Grand schrieb am 20-Jan-20 um 14:32: Hiho, sorry for the late answer :-) History: When doing deep change work quite some years ago, I did *not* realize that rot angle and shear angle were *mirrored* - sigh. This was probably historically the case due to the Y-Axis going

[Libreoffice-commits] core.git: svx/CppunitTest_svx_unit.mk svx/qa svx/source xmloff/source

2020-01-17 Thread Regina Henschel (via logerrit)
| 28 +++ xmloff/source/draw/xexptran.cxx | 10 + xmloff/source/draw/ximpshap.cxx | 53 +-- 7 files changed, 260 insertions(+), 21 deletions(-) New commits: commit bc886f523872d4f9845c188c7d525d72a1a60946 Author: Regina Henschel AuthorDate: Thu Jan 2 17:37:32

Re: Perhaps crash in debug build

2020-01-16 Thread Regina Henschel
Hi all, I have made a clean build now and it still crashes. Julian has pointed me to https://bugs.documentfoundation.org/show_bug.cgi?id=129943. That describes the same crash in Calc. Kind regards Regina Regina Henschel schrieb am 16-Jan-20 um 15:51: Hi Muhammet, thank you for testing

Re: Perhaps crash in debug build

2020-01-16 Thread Regina Henschel
: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Best, Muhammet On 1/16/20 5:28 PM, Regina Henschel wrote: Hi all, can someone please test, whether the below described operation gives a crash in a debug build. If it is OK for you, I need to make a clean

Perhaps crash in debug build

2020-01-16 Thread Regina Henschel
Hi all, can someone please test, whether the below described operation gives a crash in a debug build. If it is OK for you, I need to make a clean build, which I would like to avoid. Start a Writer document. Insert a control element "push button". While it is still selected click on

Re: introducing myself

2020-01-11 Thread Regina Henschel
Hi Shivam, in case you have not found the page, please have a look at the part "Getting started with Development" on page https://wiki.documentfoundation.org/Development. Which programming language do you know? Do you have a special area of interest? Do you know LibreOffice well from a user

Please review "Correct import draw:transform values skewY and matrix"

2020-01-09 Thread Regina Henschel
Hi all, I'm looking for reviewer for https://gerrit.libreoffice.org/#/c/core/+/86244/ It is in the main about correctly reading ODF files, where the draw:transform attribute contains skewY() or matrix(). Kind regards Regina ___ LibreOffice

sign problem with shear angle in transform matrix

2020-01-06 Thread Regina Henschel
Hi all, the matrix, which is product by TRGetBaseGeometry and which is available as property "Transformation" in macros, is mathematically wrong, because the shear element has a wrong sign. What to do? A) Convert the matrix into a mathematically correct one, where it is needed, e.g. in case

Re: Cannot review Gerrit patch

2020-01-02 Thread Regina Henschel
Hi Chris, I can confirm, that it does not work in the old UI. Chris Sherlock schrieb am 02-Jan-20 um 23:01: On 2 Jan 2020, at 10:24 am, Thorsten Behrens wrote: Hey Chris, Chris Sherlock wrote: Quick ping. Anyone able to assist? Not really - seems to work fine here, though not using the

Re: Need help for unit test with rotated shape in Calc

2019-12-17 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 17-Dec-19 um 10:56: Hi Regina, On Sun, Dec 08, 2019 at 12:50:42AM +0100, Regina Henschel wrote: Question: Can I leave the test in "ScAnchorTest" in "extras", or should I create a new test class in "unit", where I copy

[Libreoffice-commits] core.git: include/svx sc/CppunitTest_sc_shapetest.mk sc/Module_sc.mk sc/qa sc/source svx/source

2019-12-11 Thread Regina Henschel (via logerrit)
insertions(+), 3 deletions(-) New commits: commit f44140bebb9c493d97ba5aef26c9692c53a6b93f Author: Regina Henschel AuthorDate: Thu Nov 28 19:28:29 2019 +0100 Commit: Regina Henschel CommitDate: Wed Dec 11 23:42:39 2019 +0100 tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRect

Re: Need help for unit test with rotated shape in Calc

2019-12-07 Thread Regina Henschel
"unit", where I copy the hierarchy of "ScAnchorTest", or something else? Kind regards Regina Miklos Vajna schrieb am 03-Dec-19 um 11:22: Hi Regina, On Tue, Dec 03, 2019 at 01:38:59AM +0100, Regina Henschel wrote: Any idea, how I can apply FitToCellSize() to a sha

chart2.check fails in testAxisTitlePositionDOCX

2019-12-04 Thread Regina Henschel
Hi all, Jenkins found a unit test failure in my patch https://gerrit.libreoffice.org/#/c/84216/. But I think, that it is unrelated to the changes in my patch. So I tried locally with a build, that does not have my patch. And indeed, that build has the failure for chart2.check too. So it is

Re: Need help for unit test with rotated shape in Calc

2019-12-03 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 03-Dec-19 um 11:22: Hi Regina, On Tue, Dec 03, 2019 at 01:38:59AM +0100, Regina Henschel wrote: Any idea, how I can apply FitToCellSize() to a shape in a unit test? Here is an sc/ test dispatching an UNO command: sc/qa/unit/screenshots/screenshots.cxx

Re: Problems with SetSnapRect() for rotated and/or sheared custom shapes

2019-12-02 Thread Regina Henschel
Hi all, next steps in SetSnapRect(). Working on tdf#119191, I have noticed, that there the caller of SetSnapRect() assumes, that the shape shrinks/grows so, that it fits into its anchor cell. That works for a legacy rectangle, for example, but it does not work for custom shapes, which are

Need help for unit test with rotated shape in Calc

2019-12-02 Thread Regina Henschel
Hi all, my proposed fix for tdf#119191 in https://gerrit.libreoffice.org/#/c/84216/ will also fix, that the command .uno:FitCellSize does not work on cell anchored custom shapes, in case they are transformed. So I'm trying to write a unit test for it. The command is new [1] and has no unit

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/qa sc/source

2019-11-21 Thread Regina Henschel (via logerrit)
e8997a95f8f06a32d32124c55897138ac0fe840d Author: Regina Henschel AuthorDate: Sat Nov 16 21:55:05 2019 +0100 Commit: Christian Lohmaier CommitDate: Thu Nov 21 20:27:47 2019 +0100 tdf#103092 export uses MeasureUnit not FieldUnit ctor of SvXMLExport expects a util::MeasureUnit, but getMetric() from

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/qa sc/source

2019-11-18 Thread Regina Henschel (via logerrit)
bbfcada38c71ca8f0adf779e9fb66d577683ad71 Author: Regina Henschel AuthorDate: Sat Nov 16 21:55:05 2019 +0100 Commit: Xisco Faulí CommitDate: Mon Nov 18 21:32:05 2019 +0100 tdf#103092 export uses MeasureUnit not FieldUnit ctor of SvXMLExport expects a util::MeasureUnit, but getMetric() from

[Libreoffice-commits] core.git: sc/qa sc/source

2019-11-18 Thread Regina Henschel (via logerrit)
58ee73068fa881950e42cca22ed17cf5829b8d14 Author: Regina Henschel AuthorDate: Sat Nov 16 21:55:05 2019 +0100 Commit: Regina Henschel CommitDate: Mon Nov 18 14:22:42 2019 +0100 tdf#103092 export uses MeasureUnit not FieldUnit ctor of SvXMLExport expects a util::MeasureUnit, but getMetric() from

Where to put a Calc unit test

2019-11-12 Thread Regina Henschel
Hi all, I'm working on bug tdf#103092. The error is, that Calc interprets the measure unit from registrymodifications.xcu wrongly and therefore writes for a transformed shape a wrong unit in the draw:transform attribute, which results in a wrong position of the shape after reopening the file.

[Libreoffice-commits] core.git: sd/qa svx/source

2019-11-12 Thread Regina Henschel (via logerrit)
7cf0e43d39172cc083e7b64e06cf0730f14bcf19 Author: Regina Henschel AuthorDate: Sat Nov 9 23:46:22 2019 +0100 Commit: Regina Henschel CommitDate: Tue Nov 12 11:16:20 2019 +0100 tdf#128651 SdrObjCustomShape::NbcSetSnapRect needs logic rect SdrObjCustomShape::NbcSetSnapRect needs a logic rect in its

Re: Need help for unit test about undo

2019-11-09 Thread Regina Henschel
Hi all, Miklos Vajna schrieb am 08-Nov-19 um 09:33: Hi, On Thu, Nov 07, 2019 at 11:01:33PM +0100, Regina Henschel wrote: Ok, that contains how to use an UndoManager. Yes, that was the intention I assume -- tiledrendering is just a suite that happened to contain that example code

[Libreoffice-commits] core.git: svx/qa svx/source

2019-11-08 Thread Regina Henschel (via logerrit)
9b2a94321e3a05364064cb60dafc1d1b69eece56 Author: Regina Henschel AuthorDate: Thu Nov 7 15:25:21 2019 +0100 Commit: Regina Henschel CommitDate: Fri Nov 8 15:25:35 2019 +0100 tdf#128413 SetSnapRect of custom shapes expects logic rect SdrObjCustomShape has its own version of SetSnapRect. This expects a logic

Re: Need help for unit test about undo

2019-11-07 Thread Regina Henschel
El 7/11/19 a les 19:07, Regina Henschel ha escrit: Hi all, It is about bug https://bugs.documentfoundation.org/show_bug.cgi?id=128651 The reason is the already discussed behavior of SdrObjCustomShape::SetShapRect, so I know how to fix it. But I do not know, how to make a unit test about und

Need help for unit test about undo

2019-11-07 Thread Regina Henschel
Hi all, It is about bug https://bugs.documentfoundation.org/show_bug.cgi?id=128651 The reason is the already discussed behavior of SdrObjCustomShape::SetShapRect, so I know how to fix it. But I do not know, how to make a unit test about undo and redo functionality. Kind regards Regina

Re: Problems with SetSnapRect() for rotated and/or sheared custom shapes

2019-11-05 Thread Regina Henschel
Hi all, Regina Henschel schrieb am 05-Nov-19 um 13:42: And I have found a comment in SdrObj /// SetSnapRect() tries to size the Object so that it fits into the /// passed Rect (without stroke width, ...) The longer I think about it, the more I get convinced that I really have to change

Re: Problems with SetSnapRect() for rotated and/or sheared custom shapes

2019-11-05 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 05-Nov-19 um 08:50: Hi Regina, On Mon, Nov 04, 2019 at 07:00:18PM +0100, Regina Henschel wrote: So my question is: What is SdrObjCustomShape::SetSnapRect() supposed to do? My guess is the snap rectangle is the same as the bounding box, The "bou

Problems with SetSnapRect() for rotated and/or sheared custom shapes

2019-11-04 Thread Regina Henschel
Hi all, During my work on the oox import of vert="eaVert" I encountered, that my changes in oox do not work as expected, because SdrObjCustomShape::SetVerticalWriting() is faulty. The origin of the error is in SdrObjCustomShape::SetSnapRect(). SdrObjCustomShape::SetSnapRect() has a

Re: oox export of chart transparency

2019-10-21 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 21-Oct-19 um 09:21: Hi Regina, On Sun, Oct 20, 2019 at 04:53:09PM +0200, Regina Henschel wrote: To get a gradient form "FillTransparenceGradientName", I have found "com.sun.star.drawing.TransparencyGradientTable". To us

oox export of chart transparency

2019-10-20 Thread Regina Henschel
Hi all, in connection with discussions in bug 108065, I looked at the export of transparency in charts. https://bugs.documentfoundation.org/show_bug.cgi?id=108065 [FILESAVE DOCX] Gradient property of the data series not preserved when saved as DOCX The problem has several reasons a) void

Cannot upload images to Wiki

2019-10-11 Thread Regina Henschel
Hi all, I want to prepare a Wiki page for a technical question. The page needs illustrations, but I cannot upload the needed images. I get the error message "Diese Datei einhält einen Virus! Details: Scan fehlgeschlagen (Code 2)". I have checked the files with current "G DATA Antivirus" and

[Libreoffice-commits] core.git: 2 commits - dbaccess/source oox/source reportdesign/source sc/source svx/qa svx/source sw/source

2019-10-09 Thread Regina Henschel (via logerrit)
13 files changed, 59 insertions(+), 28 deletions(-) New commits: commit 5e68f0e2a13cc21f95a875cf694e926e01642050 Author: Regina Henschel AuthorDate: Sat Oct 5 22:52:42 2019 +0200 Commit: Regina Henschel CommitDate: Wed Oct 9 20:43:38 2019 +0200 tdf#127785 Apply 180deg compensation

Re: Problems with LineStyle Dash-Dot definitions in standard.sod

2019-10-07 Thread Regina Henschel
Hi Chris, Chris Sherlock schrieb am 07-Oct-19 um 13:50: On 28 Aug 2019, at 9:17 am, Regina Henschel wrote: Hi all, ... So what to do? Map the styles from standard.sod to a roughly fitting MS Office preset definition on export to ppt? Get rid of the current set in standard.sod

review for patch for tdf#127785 Apply 180deg compensation for flipV to text range

2019-10-06 Thread Regina Henschel
Hi all, because my first attempt to fix the error was wrong, I have made a new proposal in https://gerrit.libreoffice.org/#/c/80310/ To be sure, that it is correct now, it would be nice, if you review the patch. Some comments and test documents are in the bug report. But perhaps you know

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-8' - sd/source

2019-10-04 Thread Regina Henschel (via logerrit)
sd/source/ui/unoidl/unolayer.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit af01bedc4433ed20aa68e98314cc46185a989b1b Author: Regina Henschel AuthorDate: Fri Sep 27 14:12:39 2019 +0200 Commit: Eike Rathke CommitDate: Fri Oct 4 15:12:13 2019 +0200 tdf

[Libreoffice-commits] core.git: svx/qa svx/source

2019-10-02 Thread Regina Henschel (via logerrit)
caaa8fe7c4bb88185b5b11591ee8a619cff0eced Author: Regina Henschel AuthorDate: Tue Oct 1 18:20:53 2019 +0200 Commit: Regina Henschel CommitDate: Wed Oct 2 13:36:17 2019 +0200 tdf#127785 compensate 180deg rotation for position of text box If a shape is vertically flipped, then the text is rotated

Re: TextPreRotateAngle vs. TextRotateAngle

2019-10-02 Thread Regina Henschel
Hi all, hi Miklos, Regina Henschel schrieb am 27-Sep-19 um 16:45: Hi all, commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=5c4d1b05faa8a3d704fc74a186a173f8cc019cc1 has introduced the TextPreRotateAngle. As far as I understand it, it has been introduced to express

Bug 125585 - Filesave: OLE objects corruption and missing

2019-09-30 Thread Regina Henschel
Hi all, the layers of an embedded Draw or Impress document had got the status "not visible" and "not printable" on saving. The reason for this is fixed by https://gerrit.libreoffice.org/#/c/79701/. The corrupted documents can be manually repaired as described in the bug comments, or by

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sd/source

2019-09-30 Thread Regina Henschel (via logerrit)
sd/source/ui/unoidl/unolayer.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit 44c0b7416d1abee971ef0b4b17e67f6e391dd807 Author: Regina Henschel AuthorDate: Fri Sep 27 14:12:39 2019 +0200 Commit: Xisco Faulí CommitDate: Mon Sep 30 15:08:38 2019 +0200 tdf

[Libreoffice-commits] core.git: svx/qa svx/source

2019-09-28 Thread Regina Henschel (via logerrit)
7830a9d42926a9c5265230d42fce4a4858b303c1 Author: Regina Henschel AuthorDate: Sat Sep 28 00:34:35 2019 +0200 Commit: Regina Henschel CommitDate: Sat Sep 28 20:00:51 2019 +0200 tdf#127785 correct calculation of text rectangle in flipped shape The calculation had used a wrong corner. That resulted

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sd/source

2019-09-28 Thread Regina Henschel (via logerrit)
sd/source/ui/unoidl/unolayer.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit a955330e052cc12c622982f38c5f5d138484013a Author: Regina Henschel AuthorDate: Fri Sep 27 14:12:39 2019 +0200 Commit: Xisco Faulí CommitDate: Sat Sep 28 14:22:30 2019 +0200 tdf

[Libreoffice-commits] core.git: sd/source

2019-09-27 Thread Regina Henschel (via logerrit)
sd/source/ui/unoidl/unolayer.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit 12f9a9f341fd8f8a98f7cd98f296a8729d279e0d Author: Regina Henschel AuthorDate: Fri Sep 27 14:12:39 2019 +0200 Commit: Regina Henschel CommitDate: Fri Sep 27 18:00:15 2019 +0200 tdf

TextPreRotateAngle vs. TextRotateAngle

2019-09-27 Thread Regina Henschel
Hi all, commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=5c4d1b05faa8a3d704fc74a186a173f8cc019cc1 has introduced the TextPreRotateAngle. As far as I understand it, it has been introduced to express the rotation, which is applied to the TextFrames inside a custom shape and

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/qa sw/source

2019-09-17 Thread Regina Henschel (via logerrit)
+ 4 files changed, 64 insertions(+) New commits: commit 90c29687bbbd467c5ec234adc19fc861ea8e270b Author: Regina Henschel AuthorDate: Tue Apr 2 21:36:57 2019 +0200 Commit: Andras Timar CommitDate: Tue Sep 17 08:21:08 2019 +0200 tdf#118375, tdf#70838 correct position of rotated shape

clean up "text in custom shapes"

2019-09-08 Thread Regina Henschel
Hi all, I have started to familiarize myself with the topic 'text in custom shapes'. My goal is to clean up the current mess and eliminate mistakes. It is possible to rotate the text area into which the text is written in addition to a rotation of the shape itself. That is done in ODF by the

[Libreoffice-commits] core.git: filter/source include/oox oox/source sd/qa sw/qa

2019-09-05 Thread Regina Henschel (via logerrit)
/tdf127166_prstDash_Word97.doc |binary sw/qa/extras/ww8export/ww8export3.cxx | 36 ++ 14 files changed, 496 insertions(+), 225 deletions(-) New commits: commit 57c9bdab377a00649299d1a4c9ed2f9e5e03b84e Author: Regina Henschel AuthorDate: Sun Sep 1 19:26:40 2019 +0200 Commit: Regina

Re: manually changing content.xml > invalid xml.. but why

2019-09-04 Thread Regina Henschel
Hi, I do not unzip to a folder. But I use "Open Archive" from 7-Zip. The context menu of content.xml then has "View" and "Edit". I have setup 7-Zip to use "XML Notepad" with "Edit" and Notepad++ with "View". Then I use either of them to change the content of content.xml and use "Save" in

Re: Review for "improve import/export of line styles"

2019-09-02 Thread Regina Henschel
Hi, thank you all for the technical help. I have not removed the file yet. And now I know, that 'git rm' will be the correct way. Kind regards Regina Kaganski Mike schrieb am 02-Sep-19 um 12:25: On 02.09.2019 9:20, Németh László wrote: And technical question: What do I need to do

Review for "improve import/export of line styles"

2019-09-01 Thread Regina Henschel
Hi all, please have a look at https://gerrit.libreoffice.org/#/c/78372/ An important question is whether you agree that I have changed the import and export of our own line styles so that no prstDash line styles are used for them. Instead I export them as custDash elements and reconstruct

Problems with LineStyle Dash-Dot definitions in standard.sod

2019-08-27 Thread Regina Henschel
Hi all, I'm working on import and export of Dash-Dot LineStyles. I have not yet checked whether it does not break a unit test. But from visual appearance and file format these works already: Roundtrip in pptx and ppt format with MS Office preset dash definitions. Roundtrip in pptx format

[Libreoffice-commits] core.git: oox/source sd/qa

2019-08-23 Thread Regina Henschel (via logerrit)
72b50be0197159c5afc5da4daf01ba303519b14a Author: Regina Henschel AuthorDate: Tue Aug 20 10:43:46 2019 +0200 Commit: Regina Henschel CommitDate: Fri Aug 23 23:38:33 2019 +0200 tdf#99497 CircleKind ARC, CUT, SECTION to OOXML arc, chord, pie Before this patch, a classical ellipse or circle

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-1' - svx/source

2019-08-23 Thread Regina Henschel (via logerrit)
svx/source/svdraw/svdopath.cxx | 71 + 1 file changed, 44 insertions(+), 27 deletions(-) New commits: commit 7bdaab829a4e17eabba0559cf9a4ac62bd7a6fbe Author: Regina Henschel AuthorDate: Wed Aug 21 14:11:23 2019 +0200 Commit: Caolán McNamara

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - svx/source

2019-08-22 Thread Regina Henschel (via logerrit)
svx/source/svdraw/svdopath.cxx | 71 + 1 file changed, 44 insertions(+), 27 deletions(-) New commits: commit 46c7341014870b4d2c9babd91c14dfed4422f93a Author: Regina Henschel AuthorDate: Wed Aug 21 14:11:23 2019 +0200 Commit: Caolán McNamara

Re: Reverting patch

2019-08-22 Thread Regina Henschel
Hi Michael, Michael Weghorn schrieb am 22-Aug-19 um 13:21: Hi Regina, On 22/08/2019 13.12, Regina Henschel wrote: Hi Michael, I need help with some basics. Michael Weghorn schrieb am 22-Aug-19 um 08:41: If you want to explicitly test this actually works as expected, you can build

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - svx/source

2019-08-22 Thread Regina Henschel (via logerrit)
svx/source/svdraw/svdopath.cxx | 71 + 1 file changed, 44 insertions(+), 27 deletions(-) New commits: commit 6f9e19c85ffc290e600084b33d9a929db28c144d Author: Regina Henschel AuthorDate: Wed Aug 21 14:11:23 2019 +0200 Commit: Caolán McNamara

Reverting patch

2019-08-21 Thread Regina Henschel
Hi all, it is about https://gerrit.libreoffice.org/#/c/77882/ That reverts a patch, that I had made 9 months ago, because it had introduced a regression, see bug 126271. I have submitted the revert to master. Unfortunately, this regression is in LibreOffice 6.3 too. Of cause I have tested

[Libreoffice-commits] core.git: svx/source

2019-08-21 Thread Regina Henschel (via logerrit)
svx/source/svdraw/svdopath.cxx | 71 + 1 file changed, 44 insertions(+), 27 deletions(-) New commits: commit 59189f3e02acbdf4e5bbd35fc278252b30022f43 Author: Regina Henschel AuthorDate: Wed Aug 21 14:11:23 2019 +0200 Commit: Regina Henschel

Reviewer for tdf#99497 CircleKind ARC, CUT, SECTION to OOXML arc, chord, pie

2019-08-20 Thread Regina Henschel
Hi all, I'm looking for review for https://gerrit.libreoffice.org/#/c/77785/ I think, it is correct. But you are the experts. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Relationship between linecap and dashes

2019-08-15 Thread Regina Henschel
Hi all, perhaps someone has an idea how to solve the problems with round dashes. The problems are (1) LibreOffice applies the linecap not only to the true line ends, but to the dashes too. That might result in contradiction between DashStyle and LineCap (UNO enums). LibreOffice ignores the

Re: ODF "implementation defined", collection for LibreOffice?

2019-08-10 Thread Regina Henschel
Hi Thorsten, Thorsten Behrens schrieb am 10-Aug-19 um 03:09: Hi Regina, Regina Henschel wrote: So we need to provide this information. Do we already have such part? If not, should it go to the Wiki? If yes, where in the Wiki? A page with placeholder would be sufficient, so that I (or someone

[Libreoffice-commits] core.git: svx/Library_svxcore.mk svx/qa svx/source

2019-08-10 Thread Regina Henschel (via logerrit)
/svdraw/presetooxhandleadjustmentrelations.hxx | 29 + svx/source/svdraw/svdoashp.cxx | 40 + 6 files changed, 453 insertions(+) New commits: commit ba61c3174bc24bc03e3f72fbc8d102b3312b5ff6 Author: Regina Henschel AuthorDate: Fri Aug 2 21:19:30 2019 +0200 Commit

ODF "implementation defined", collection for LibreOffice?

2019-08-09 Thread Regina Henschel
Hi all, The ODF standard uses in some places the term "implementation-defined". And it specifies: Implementation-defined is used in this standard for values or processing that may differ between ODF implementations, but is required to be specified by the implementor for each particular

Re: FYI Test file with all OOXML preset shapes with handles

2019-08-09 Thread Regina Henschel
Oh I forgot, it is attached to the issue. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

FYI Test file with all OOXML preset shapes with handles

2019-08-09 Thread Regina Henschel
Hi all, while working on tdf#126512, I have created a pptx-file with all those preset shapes, which have handles. I thought some of you might be interested in such a test file. Shapes with XY-handles have orange filling, shapes with at least one angle or radius handle have green filling.

Re: Make ooxml-handles work in odp

2019-08-07 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 06-Aug-19 um 09:26: Hi Regina, [..] 1) If you want to know which import filter was used to create the doc model, you can get that info from SfxBaseModel::getArgs(). One of the property values returned by that function has the info. Thank you for the hint.

Re: Make ooxml-handles work in odp

2019-08-06 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 06-Aug-19 um 09:26: Hi Regina, [..] 2) I wonder if you want to behave differently for ooxml- shapes if they are loaded from ODF or OOXML. I thought that the idea for ooxml- shapes is exactly that the know they are from OOXML, so no matter if they are loaded

Re: Make ooxml-handles work in odp

2019-08-05 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 05-Aug-19 um 09:26: Hi Regina, On Sun, Aug 04, 2019 at 02:19:49PM +0200, Regina Henschel wrote: Is there a way to tell at this point whether the current file has an 'ooxml' format? The custom shape type is a string, always in the format of ooxml-"p

[Libreoffice-commits] core.git: filter/source

2019-08-04 Thread Regina Henschel (via logerrit)
filter/source/msfilter/msdffimp.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 513f54ee850eb909c4d636c6e7be8dbc2a99024b Author: Regina Henschel AuthorDate: Sun Aug 4 23:40:33 2019 +0200 Commit: Regina Henschel CommitDate: Mon Aug 5 00:41:31 2019 +0200 CppCheck

Re: Make ooxml-handles work in odp

2019-08-04 Thread Regina Henschel
Hi all, Regina Henschel schrieb am 28-Jul-19 um 20:03: I can imagine to write a parser similar to the one from https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/customshapepresetdata.cxx. There the information is fetched at runtime from the file "oox-drawingml-cs-pr

Re: Makefile in "git status -s"

2019-07-29 Thread Regina Henschel
Hi Michael, Michael Stahl schrieb am 29-Jul-19 um 13:45: On 28.07.19 17:39, Regina Henschel wrote: Hi all, With git status -s I get a lot of "Makefile" items. A diff for such item gives e.g $ git diff svl/Makefile diff --git a/svl/Makefile b/svl/Makefile index ccb1c85a04da..ab

[Libreoffice-qa] How to handle spam in existing bug reports?

2019-07-29 Thread Regina Henschel
Hi all, we get frequently comments with spam to existing bugs. How do treat those comments? Kind regards Regina ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings:

Make ooxml-handles work in odp

2019-07-28 Thread Regina Henschel
Hi all, I'm working on https://bugs.documentfoundation.org/show_bug.cgi?id=126512 "Open pptx and save as odp, handle of shape is visible but cannot be moved" I have found, that this can be fixed by adding the reference properties (RefX, RefY, RefAngle, RefR) to the handles in method

Makefile in "git status -s"

2019-07-28 Thread Regina Henschel
Hi all, With git status -s I get a lot of "Makefile" items. A diff for such item gives e.g $ git diff svl/Makefile diff --git a/svl/Makefile b/svl/Makefile index ccb1c85a04da..ab354ea6760e 100644 --- a/svl/Makefile +++ b/svl/Makefile @@ -1,7 +1,2 @@ -# -*- Mode: makefile-gmake; tab-width:

[Libreoffice-commits] core.git: svx/source

2019-07-25 Thread Regina Henschel (via logerrit)
svx/source/customshapes/EnhancedCustomShape2d.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit ab4806de79a1c8772024f0e51cd9ba7a30b96405 Author: Regina Henschel AuthorDate: Thu Jul 25 13:09:08 2019 +0200 Commit: Regina Henschel CommitDate: Thu Jul 25 16:57:04 2019 +0200

Re: version 102.11 of OpenSymbol

2019-07-14 Thread Regina Henschel
On Sat, Jul 13, 2019 at 5:48 PM Regina Henschel <mailto:regina.hensc...@libreoffice.org>> wrote: Hi all, can someone please update opens___.tff to version 102.11? The package has still version 102.10. (bug 126374). I don't know how to do it. Perhaps in addition add

version 102.11 of OpenSymbol

2019-07-13 Thread Regina Henschel
Hi all, can someone please update opens___.tff to version 102.11? The package has still version 102.10. (bug 126374). I don't know how to do it. Perhaps in addition add an instruction to the README in /core/extras/source/truetype/symbol/? Takeshi Abe had added the new symbols "harpoon" and

Re: windows master build stops at: [MOD] scp2

2019-07-12 Thread Regina Henschel
Hi, Regina Henschel schrieb am 12-Jul-19 um 10:50: Hi, Oliver Brinzing schrieb am 11-Jul-19 um 20:38: Hi, are there any known building issues at the moment? my windows x64 master build with VS 2017 15.9.12  stops reproducible at: [MOD] scp2 there is no error message... a full build after

Re: windows master build stops at: [MOD] scp2

2019-07-12 Thread Regina Henschel
Hi, Oliver Brinzing schrieb am 11-Jul-19 um 20:38: Hi, are there any known building issues at the moment? my windows x64 master build with VS 2017 15.9.12  stops reproducible at: [MOD] scp2 there is no error message... a full build after clean did not help. It stops for me too. I see 9

Re: Change shape from text box mode to ordinary shape in Writer

2019-07-05 Thread Regina Henschel
Hi all, Regina Henschel schrieb am 01-Jul-19 um 20:26: My questions: Is it possible at all? If yes, what do I have overlooked? I have found my mistake. The structure of the custom shape geometry was not correct. But the result doesn't convince me. I consider to import "

Re: Change shape from text box mode to ordinary shape in Writer

2019-07-01 Thread Regina Henschel
Hi all, https://gerrit.libreoffice.org/#/c/74966/1 shows some of my attempts. Kind regards Regina Regina Henschel schrieb am 01-Jul-19 um 20:26: Hi all, I'm working on tdf#125884 "FILEOPEN: DOCX WordArt "Transform" (Fontwork, TextWarp) is not imported". But I need help

Change shape from text box mode to ordinary shape in Writer

2019-07-01 Thread Regina Henschel
Hi all, I'm working on tdf#125884 "FILEOPEN: DOCX WordArt "Transform" (Fontwork, TextWarp) is not imported". But I need help. Problem: A shape in DOCX can have a text box. The shape itself has a geometry, which is in most cases one of the presets, e.g. a "triangle". The text box can in

[Libreoffice-commits] core.git: oox/source sd/qa

2019-06-26 Thread Regina Henschel (via logerrit)
/tdf125573_FontWorkScaleX.pptx |binary sd/qa/unit/export-tests-ooxml2.cxx | 34 + 6 files changed, 63 insertions(+), 9 deletions(-) New commits: commit e7c0bc4811029abca878343dcce8057f9d3b7053 Author: Regina Henschel AuthorDate: Mon Jun 24 15:23:44 2019 +0200 Commit

Re: Request for review of draft: Resolvable comments in Writer

2019-06-20 Thread Regina Henschel
Hi Jim, Jim MacArthur schrieb am 20-Jun-19 um 17:30: I have a draft patch series which adds the ability to mark comments in Writer as resolved. This has had some discussion on https://bugs.documentfoundation.org/show_bug.cgi?id=119228.

[Libreoffice-commits] core.git: sd/qa

2019-06-20 Thread Regina Henschel (via logerrit)
sd/qa/unit/data/odp/tdf100348_Fontwork2TextWarp.odp |binary sd/qa/unit/export-tests-ooxml2.cxx | 59 2 files changed, 59 insertions(+) New commits: commit a4d30a3809c5bf973d39c5e4368a1276582b04b3 Author: Regina Henschel AuthorDate: Wed Jun 19 22:04

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - svx/qa svx/source

2019-06-19 Thread Regina Henschel (via logerrit)
54c7f48ded248f6da6a22fffca053d82674aa7b5 Author: Regina Henschel AuthorDate: Sat Jun 8 21:49:50 2019 +0200 Commit: Xisco Faulí CommitDate: Wed Jun 19 09:41:52 2019 +0200 tdf#125782 use correct 'current point' for quadraticcurveto Use the same way to get the 'current point

[Libreoffice-commits] core.git: oox/inc oox/source

2019-06-17 Thread Regina Henschel (via logerrit)
insertions(+), 18 deletions(-) New commits: commit 2be2c914ed48823304c2e95a836ee93a08853628 Author: Regina Henschel AuthorDate: Fri Jun 14 19:10:36 2019 +0200 Commit: Regina Henschel CommitDate: Mon Jun 17 18:48:14 2019 +0200 tdf#51195, tdf#100348 Convert Fontwork to TextWarp on export

Request for review: Convert Fontwork to TextWarp on export

2019-06-14 Thread Regina Henschel
Hi all, Please have a look at https://gerrit.libreoffice.org/#/c/74057/ tdf#51195, tdf#100348 Convert Fontwork to TextWarp on export "Fontwork" of LibreOffice and "TextWarp" of MS Office have fundamental differences although they look similar. I have collected some at

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - oox/source sd/qa

2019-06-14 Thread Regina Henschel (via logerrit)
oox/source/drawingml/shape.cxx | 77 ++-- sd/qa/unit/data/pptx/tdf116350-texteffects.pptx |binary 2 files changed, 58 insertions(+), 19 deletions(-) New commits: commit 0aff57b3a4f227c02bfdb4850bb11279325f41db Author: Regina Henschel AuthorDate: Thu

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0-29' - 11 commits - chart2/qa chart2/source include/oox oox/source sdext/source sd/qa sw/qa sw/source writerfilter/source

2019-06-12 Thread Regina Henschel (via logerrit)
deletions(-) New commits: commit 4db76f9332641ed87ff1c5217a16167be4c6c353 Author: Regina Henschel AuthorDate: Tue Apr 2 21:36:57 2019 +0200 Commit: Andras Timar CommitDate: Wed Jun 12 11:17:50 2019 +0200 tdf#118375, tdf#70838 correct position of rotated shape in doc Word relates

[Libreoffice-commits] core.git: svx/qa svx/source

2019-06-10 Thread Regina Henschel (via logerrit)
39599fc689364b70cf83e834a5742cc2181b13b0 Author: Regina Henschel AuthorDate: Sat Jun 8 21:49:50 2019 +0200 Commit: Regina Henschel CommitDate: Mon Jun 10 20:00:58 2019 +0200 tdf#125782 use correct 'current point' for quadraticcurveto Use the same way to get the 'current point

[Libreoffice-commits] core.git: oox/source sd/qa

2019-06-07 Thread Regina Henschel (via logerrit)
oox/source/drawingml/shape.cxx | 77 ++-- sd/qa/unit/data/pptx/tdf116350-texteffects.pptx |binary 2 files changed, 58 insertions(+), 19 deletions(-) New commits: commit 95b61f7da41acaabeb0a4bf74749b8fa95ae9966 Author: Regina Henschel AuthorDate: Thu

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/qa sw/source

2019-06-04 Thread Regina Henschel (via logerrit)
+ 4 files changed, 64 insertions(+) New commits: commit 4977bf684097247d7121a43d6d3e9374684b0d07 Author: Regina Henschel AuthorDate: Tue Apr 2 21:36:57 2019 +0200 Commit: Aron Budea CommitDate: Tue Jun 4 22:55:20 2019 +0200 tdf#118375, tdf#70838 correct position of rotated shape in doc

<    2   3   4   5   6   7   8   9   10   11   >