Re: Tinderbox failure, Linux-RHEL6-x86_64@14-with-check, MASTER, last success: 2012-02-08 09:52:51

2012-02-08 Thread Stephan Bergmann
On 02/08/2012 06:27 PM, stephan.bergmann.tinder...@googlemail.com wrote: /usr/lib/gcc/x86_64-redhat-linux/4.4.6/../../../../include/c++/4.4.6/bits/stl_algo.h:1678: error: function requires a valid iterator range [__middle, __last). Objects involved in the operation: iterator __middle @

Re: OK to merge the fw? libraries in framework?

2012-02-08 Thread Stephan Bergmann
On 02/09/2012 12:09 AM, Lubos Lunak wrote: [*] Seriously, I can't find a thing. Is there actually something using the library? Many libraries that export UNO services are never linked against directly. Stephan ___ LibreOffice mailing list

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Stephan Bergmann
On 02/09/2012 06:16 PM, Lubos Lunak wrote: Attached is a patch that removes the need for RTL_CONSTASCII_USTRINGPARAM (henceafter called 'macro', because it annoys me to write this even in its death warrant) when using the OUString ctor. Assuming this code compiles also with MSVC[*], the result

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Stephan Bergmann
On 02/10/2012 11:30 AM, Lubos Lunak wrote: diff --git a/sal/inc/osl/module.hxx b/sal/inc/osl/module.hxx index c8d39a2..a7f9c35 100644 --- a/sal/inc/osl/module.hxx +++ b/sal/inc/osl/module.hxx @@ -152,11 +152,28 @@ public: return ( osl_getFunctionSymbol( m_Module,

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Stephan Bergmann
On 02/10/2012 12:18 PM, Lubos Lunak wrote: This is sal/, so the library needs to maintain binary compatibility, does it not? That requires adding the OUString overload rather than fixing the exiting function. I don't know if the const char* overload really needs the non-const variant as well,

Re: [PATCH] New Unit test

2012-02-10 Thread Stephan Bergmann
On 02/10/2012 09:01 AM, Jan Holesovsky wrote: Santiago Martinez píše v Čt 09. 02. 2012 v 21:15 +0100: Hello, in file comphelper/qa/string/test_string.cxx there is a missing unit test to check the method islowerAsciiString(rtl::OString const). Attached to this mail there is a patch to add this

Re: minutes of ESC call ...

2012-02-10 Thread Stephan Bergmann
On 02/09/2012 06:54 PM, Michael Meeks wrote: * system stdlibs for Linux universal builds ? (Stephan/Petr) + https://bugs.freedesktop.org/show_bug.cgi?id=45696 + https://bugs.freedesktop.org/show_bug.cgi?id=45074 + problem is - that for generic RPMs/DEBs +

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-13 Thread Stephan Bergmann
On 02/11/2012 07:24 PM, julien2412 wrote: On master branch (not on 3.5 branch), each time I start a module Calc, Writer or Impress (I didn't test on others), when I begin to type something, it seems to freeze for some seconds (about 10 secs) then everything seems ok. So I runned valgrind by

Re: changes in profile path in release notes for 3.5

2012-02-13 Thread Stephan Bergmann
On 02/12/2012 05:05 PM, Cor Nouws wrote: Jean-Baptiste Faure wrote (11-02-12 09:04) On Linux (or Linux Gnome only ???) the profile directory for LO 3.5.0 has been move to ~/.config/libreoffice. This information should be clearly stated in the release notes for 3.5. Could somebody who knows

Re: basegfx::fround and friends seems needed in windows build

2012-02-13 Thread Stephan Bergmann
On 02/12/2012 06:45 AM, Korrawit Pruegsanusak wrote: On Thu, Feb 9, 2012 at 17:39, Michael Meeksmichael.me...@suse.com wrote: On Wed, 2012-02-08 at 21:36 +0100, Stephan Bergmann wrote: On 02/08/2012 09:30 PM, Caolán McNamara wrote: So there are some alternatives options to hide something

Re: [PATCH][PUSHED] Remove unused code (5)

2012-02-13 Thread Stephan Bergmann
On 02/11/2012 03:59 PM, Ivan Timofeev wrote: Pushed, thank you. marking thread as pushed Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: minutes of ESC call ...

2012-02-13 Thread Stephan Bergmann
On 02/09/2012 06:54 PM, Michael Meeks wrote: * make check triggers build + make it as easy as possible to run checks (Stephan) + 'make check' is simpler + hopefully time it takes to re-run a pristine make will improve over time (Norbert) Seen fixed. Thanks a

Re: [Libreoffice-commits] .: external/gcc3_specific

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 03:39 PM, Fridrich Strba wrote: New commits: commit 9a51a7ae7153fee17013867bd7bbaacedee1980a Author: Fridrich Štrbafridrich.st...@bluewin.ch Date: Mon Feb 13 15:39:43 2012 +0100 Copy the gcc's stdlibs to solver even if not packaging them Hi Fridrich, Mid-term, once

Re: building master fails on nlpsolver

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 12:34 PM, Caolán McNamara wrote: On Sat, 2012-02-11 at 08:47 +0100, Jean-Baptiste Faure wrote: When building the master (Ubuntu 11.10, x86_64), it fails and says that the problem is inside nlpsolver. If I try to build nlpsolver by make nlpsolver I get the following error messages

Re: Tinderbox failure, last success: 2012-02-13 15:48:45

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 06:18 PM, Ivan Timofeev wrote: On 13.02.2012 21:08, nthieb...@gmail.com wrote: /Volumes/Raid0/core/solver/unxmacxi.pro/inc/svtools/ctrlbox.hxx: In member function 'void FontSizeBox::SetUserValue(sal_Int64)': /Volumes/Raid0/core/solver/unxmacxi.pro/inc/svtools/ctrlbox.hxx:563:

Re: Master fails to compile with cclan in moz module

2012-02-13 Thread Stephan Bergmann
On 02/13/2012 09:12 PM, julien2412 wrote: You were right Michael about moz, i did a rm -Rf unxlng* and the errors quoted in my first post didn't appear again. (strange because i had done a make clean on root level). Now i've got these errors : In file included from

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Stephan Bergmann
On 02/03/2012 03:56 AM, Josh Heidenreich wrote: It uses cgit to download the README or readme.txt files in all of the top-level directories, and it generates some HTML files for easy viewing. The first paragraph (everything before an empty line) is considered the short description, and is shown

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-14 Thread Stephan Bergmann
On 02/13/2012 11:21 PM, Matúš Kukan wrote: On 12 February 2012 23:51, Matúš Kukanmatus.ku...@gmail.com wrote: Do not push them without improvement, make check fails for me. Attached diff solves one problem but still there is something wrong. Well, I was fooled by

[REVIEW 3-5] Adapt SDK to changed paths in LO installation

2012-02-14 Thread Stephan Bergmann
Please review and cherry-pick to libreoffice-3-5 the commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=bcdadc2e9f3f6a400438cbbefffc60bf02baa0f1 Resolves rhbz#789622: Adapt SDK to changed paths in LO installation. Without it, SDK fails to build even simple examples, cf.

Re: sal / gcc conditionals ...

2012-02-14 Thread Stephan Bergmann
On 02/13/2012 06:45 PM, Michael Meeks wrote: * cppu/inc/cppu/macros.hxx: CPPU_GCC3_ALIGN - uh ? I assume this should be just CPPU_GCC_ALIGN and with only one definition in today's world ? We still need two versions of the define, one for __GNUC__ and one for others. The name

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Stephan Bergmann
On 02/14/2012 01:37 PM, Josh Heidenreich wrote: What is the markup format to be used in the READMEs? It's a loose copy of the wikimedia syntax used in the wiki, so: - Paragraphs are separated by a blank line. - Headings are in the form == heading == (without the quotes) - Links to modules are

Re: [Libreoffice-commits] Remove unused VolumeDevice functions and related code

2012-02-14 Thread Stephan Bergmann
On 02/05/2012 09:52 PM, François Tigeot wrote: sal/inc/osl/file.h| 43 sal/inc/osl/file.hxx | 28 - sal/osl/unx/file_volume.cxx | 80 -- sal/osl/w32/file_dirvol.cxx | 18

Re: adding getINT64 to comphelper

2012-02-14 Thread Stephan Bergmann
On 02/14/2012 07:17 PM, Lionel Elie Mamane wrote: I guess it would be OK to add getINT64 to comphelper? It already has getINT16 and getINT32. I would rather deprecate those in favour of Any::getT(). Stephan ___ LibreOffice mailing list

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Stephan Bergmann
On 02/14/2012 10:39 PM, Josh Heidenreich wrote: Do we need licence blocks in a README? Can we just write the licence in on all pages generated by the script? My (naive?) take on it is that, technically, all the files committed to the git repo are source files that should have a legal header.

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-15 Thread Stephan Bergmann
On 02/14/2012 02:33 PM, Michael Meeks wrote: On Tue, 2012-02-14 at 23:07 +1030, Josh Heidenreich wrote: What is the markup format to be used in the READMEs? It's a loose copy of the wikimedia syntax used in the wiki, so: - Paragraphs are separated by a blank line. - Headings are in the form

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Stephan Bergmann
On 02/14/2012 06:23 PM, Tor Lillqvist wrote: I also merged sal and sal_textenc (in the --enable-mergelibs case). I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, to reduce the overall number of dynamic libraries. But for other

[REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-15 Thread Stephan Bergmann
As per https://bugs.freedesktop.org/show_bug.cgi?id=45696#c3 Importing uno bindings in python causes crash the master commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b1be1ce0e0ac7b34c4b73d53f4bf32ec5df7290 Reintroduce pyuno.so wrapper around libpyuno.so should please be

Re: [REVIEW] smoketest - gbuild, TestExtension.idl needed ?

2012-02-15 Thread Stephan Bergmann
On 02/15/2012 03:11 PM, Tor Lillqvist wrote: I'm not sure this is not counter-productive. For Android and iOS it might be vital to get sal_textenc merged, Well, --enable-mergelibs is probably actually intended for Android only, I think? I wasn't sure about the status of --enable-mergelibs,

Re: javadep.c Java 7

2012-02-15 Thread Stephan Bergmann
On 02/15/2012 04:31 PM, Ivan Timofeev wrote: I found soltools/javadep/javadep.c that contains a very simple parser for java class files. The problem is that it is old, at least it does not handle the class files generated by Java 7: as far as I remember, java guys added the new types of constant

Re: .: 2 commits - configure.in sw/source

2012-02-15 Thread Stephan Bergmann
On 02/15/2012 05:48 PM, Michael Stahl wrote: WaE: type name first seen using 'class' now seen using 'struct' IMHO this is an utterly pointless warning, because the only difference between class and struct is the default visibility of the members, and a forward declaration doesn't declare

dbaccess_macros_test: no orderly shutdown

2012-02-15 Thread Stephan Bergmann
Hi all, Just experienced a spurious crash of cppunittester when executing Cppunit_dbaccess_macros_test, see backtraces below: * Thread 5 is the main thread, already in exit(3). * Thread 1 is executing a FastLoader thread (dbaccess/source/filter/xml/xmlfilter.cxx), and that code indeed has

[REVIEW-3-5] Fix some apparent misuses of RTL_CONSTASCII_USTRINGPARAM

2012-02-15 Thread Stephan Bergmann
year and do not affect LO 3.4. How severe these errors are in practice, and whether they are responsible for any actual bug reports, I do not know. Thanks, Stephan From d792f93081948520d6421961a98be28abd7167f3 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann sberg...@redhat.com Date: Wed, 15 Feb

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] - [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else.

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote: Otherwise you can simplify it even more: sal_Bool bLeft = (meAlign == WINDOWALIGN_TOP || meAlign == WINDOWALIGN_LEFT) ? sal_False : sal_True; ... which of course reduces to bool bLeft = !(meAlign == WINDOWALIGN_TOP || meAlign ==

Re: [Libreoffice-commits] .: enable XDatabaseRangeTest again

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 12:58 AM, Markus Mohrhard wrote: dbaccess/Module_dbaccess.mk|6 +- sc/Module_sc.mk|1 + sc/qa/extras/scdatabaserangeobj.cxx|6 -- sc/qa/unit/filters-test.cxx|2 +-

Configure LO for Python 3?

2012-02-16 Thread Stephan Bergmann
With http://cgit.freedesktop.org/libreoffice/core/commit/?id=a09ce46818fd4d5e08b3af9a478501cd8ef5b4fe Port PyUno to support Python 3, is there any way to configure a LO build so that it actually uses Python 3 instead of 2, on a Fedora 16 machine that has both installed? Stephan

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 12:18 PM, Matteo Casalin wrote: I personally find 'if' more legible than ?: and definitely expressions like b = x==y || x==z; I am not sure if WindowAlign will always have only these 4 members and possibly the author of the original version wasn't either (thus final else). Since

Re: Configure LO for Python 3?

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 01:46 PM, Rene Engelhard wrote: On Thu, Feb 16, 2012 at 01:29:59PM +0100, Rene Engelhard wrote: On Thu, Feb 16, 2012 at 01:08:48PM +0100, Stephan Bergmann wrote: Withhttp://cgit.freedesktop.org/libreoffice/core/commit/?id=a09ce46818fd4d5e08b3af9a478501cd8ef5b4fe Port PyUno

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-16 Thread Stephan Bergmann
On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As perhttps://bugs.freedesktop.org/show_bug.cgi?id=45696#c3 Importing uno bindings in python causes crash the master commit http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 04:50 PM, Stephan Bergmann wrote: On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As perhttps://bugs.freedesktop.org/show_bug.cgi?id=45696#c3 Importing uno bindings in python causes crash the master commit http

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 05:12 PM, Stephan Bergmann wrote: On 02/16/2012 04:50 PM, Stephan Bergmann wrote: On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As perhttps://bugs.freedesktop.org/show_bug.cgi?id=45696#c3 Importing uno bindings in python

Re: dbaccess_macros_test: no orderly shutdown

2012-02-16 Thread Stephan Bergmann
On 02/15/2012 08:12 PM, Stephan Bergmann wrote: * Thread 4 is executing a comphelper::AsyncEventNotifier. That class is mentioned only in a few places (dbaccess/source/core/dataaccess/documenteventnotifier.cxx, extensions/source/propctrl/browserlistbox.cxx, and forms/source/component/ListBox

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in tools/source/generic/poly.cxx

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 09:43 PM, julien2412 wrote: /home/julien/compile-libreoffice/libo/tools/source/generic/poly.cxx:91:9: warning: Null pointer passed as an argument to a 'nonnull' parameter memset( mpPointAry, 0, nInitSize ); ^ ~~ 1 warning generated. Here are the

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Stephan Bergmann
On 02/16/2012 11:39 PM, julien2412 wrote: /home/julien/compile-libreoffice/libo/vcl/unx/generic/app/i18n_wrp.cxx:250:9: warning: Null pointer passed as an argument to a 'nonnull' parameter dlclose(g_dlmodule); ^ ~~ 1 warning generated. Here are the lines :

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Stephan Bergmann
On 02/17/2012 09:53 AM, Tor Lillqvist wrote: So I would suggest to remove that code wholesale. Hmm, but was this code used on Solaris? Have we already removed some functionality needed (or at least useful) on Solaris then? Too bad as there recently has been people here talking about supporting

Re: [PUSHED] x11 / cairo-less build try #3

2012-02-20 Thread Stephan Bergmann
On 02/17/2012 05:52 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 17:55 +0100, Riccardo Magliocchetti wrote: $ ./soffice.bin terminate called after throwing an instance of 'com::sun::star::loader::CannotActivateFactoryException' Aborted (core dumped) ... Nice - IMHO this is all a

Re: [REVIEW 3-5][PUSHED] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-20 Thread Stephan Bergmann
On 02/17/2012 03:51 PM, Michael Meeks wrote: Any chance you can merge it to -3-5 yourself ? done Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

2012-02-20 Thread Stephan Bergmann
On 02/18/2012 03:21 PM, julien2412 wrote: This subject, switch/if else, reminded me what I read recently on the Stroustrup book. 1) The fact that switch allows a better quality machine code. I wouldn't bet anything on that one. Compilers should be able to automatically identify

Re: R: cygwin 1.7.10 - LO-3-5-0 - build fails - my git problem ?

2012-02-20 Thread Stephan Bergmann
On 02/19/2012 02:28 AM, walter wrote: The build fails in module 125. After re-run inside the module: = (1/1) Building module translations = Entering /cygdrive/c/LO350/translations dmake: Error: -- `/cygdrive/c/LO350/solver/wntmsci12.pro/bin/localize' not found, and

Re: Unused solenv tools - can I remove these?

2012-02-20 Thread Stephan Bergmann
On 02/19/2012 01:31 AM, Norbert Thiebaud wrote: On Sat, Feb 18, 2012 at 3:54 PM, Tim Retoutt...@retout.co.uk wrote: cleandiff.pl # used in 'create_patch' target of solenv/inc/tg_ext.mk, but I can't find 'create_patch' in any makefiles. Is this likely to be called manually? yes, I believe

Re: [REVIEW 3-5][PUSHED] New libvisio release

2012-02-20 Thread Stephan Bergmann
On 02/20/2012 10:43 AM, Fridrich Strba wrote: On 20/02/12 10:21, Fridrich Strba wrote: And the URL is naturally here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=21366a4b95defb007ddccd409126536a6e8dc50d And the issues immediately reported are fixed here:

Re: [REVIEW:3-5] bin bogus JRE warnings on first-start ...

2012-02-20 Thread Stephan Bergmann
On 02/16/2012 01:49 PM, Michael Meeks wrote: This is not really my sphere of expertise, so review appreciated. Rather than clobber the DesktopContext with some out-of band magic (which creates the JavaInteractionHandler that in the end complains). I thought I'd just give this guy a nil

Re: comphelper dep of officecfg

2012-02-20 Thread Stephan Bergmann
[including LO ML on cc, hope you don't mind; context for new readers: officecfg/CppunitTest_officecfg_cppheader_test.mk requires officecfg/qa/cppheader.cxx, which indirectly includes headers from higher up the module hierarchy; plain make build logs show that the cxx is needlessly compiled,

Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-20 Thread Stephan Bergmann
On 02/18/2012 04:29 PM, Michael Meeks wrote: officecfg/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8c67428341d42ada42f9186bbfe3d6f25a0edaef Author: Michael Meeksmichael.me...@suse.com Date: Sat Feb 18 15:28:35 2012 + WaE: add missing

Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-20 Thread Stephan Bergmann
On 02/20/2012 08:52 PM, Michael Meeks wrote: On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: WaE: add missing sal and cppunit dependencies causing tinderbox failure ... @@ -1,2 +1,2 @@ -oc officecfg :TRANSLATIONS:translations soltools solenv LIBXSLT:libxslt NULL +oc

Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:21 AM, Michael Meeks wrote: On Mon, 2012-02-20 at 21:24 +0100, Stephan Bergmann wrote: On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: WaE: add missing sal and cppunit dependencies causing tinderbox failure ... Yes, as you say - it was for the unit

Re: [PATCH][PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 02:36 PM, Khoo Wei Ming wrote: On pc Debian x86-64, I've got this kind of errors : /home/julien/compile- libreoffice/libo/connectivity/source/drivers/mozab/mozillasrc/MLdapAttributeMap.cxx:51:23: error: ISO C++ forbids declaration of 'typeof' with no type [-fpermissive] Could

Re: [PUSHED] x11 / cairo-less build try #3

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 04:07 PM, Michael Meeks wrote: On Mon, 2012-02-20 at 09:21 +0100, Stephan Bergmann wrote: Nice - IMHO this is all a bit silly - the 'main' has no wrapper 'catch' around it, so if we get an un-caught exception we bomb out in a very unpleasant way for no particularly good

Re: Has the time come to get rid of the delivering of public headers?

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 03:39 PM, Michael Stahl wrote: would need to try that out on Windows, but my guess is that even if it doesn't blow out command line length limits (which could be worked around with a response file) it'll make the Windows build a lot slower because compiler has to try out all

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 04:15 PM, Michael Meeks wrote: On Tue, 2012-02-21 at 11:53 +0100, Helmar Spangenberg wrote: I would love to use the MSVC version - however my application is based on some essential MinGW parts, and until now I have not found a way to link my application against the MSVC-DLLs

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 06:31 PM, Helmar Spangenberg wrote: actually the SAL C API seems to work nicely - after Tor's remarks I re-installed the MSVC-SDK and tried to link my MinGW-code against ist. However, the CPPU interface denies the linking - I observe undefined references to cppu::bootstrap(),

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:05 PM, Helmar Spangenberg wrote: Yes exactly, that is my problem. That's why I am bound to the MinGW port of LibreOffice, but somehow the URE part has some problems. Yeah, sorry, but I fear I have no idea for you there. UnoUrlResolver is probably the first service that shall

Re: [PATCH][PUSHED] LibreOffice 3.6.0alpha built on clang

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:09 PM, julien2412 wrote: I git updated and it failed again the same way. With Khoo's patch, it worked. Then I removed his patch and tried again, it failed again. [...] Each test made like this : make connectivity.clean make connectivity Should I have recompiled another

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:29 PM, Chr. Rossmanith wrote: during code cleanup I came across badly readable RTL_CONSTASCII_USTRINGPARAM(bla) lines. I could replace them with bla which should be possible with Lubos patch removing the need for The macro... But Lobos's patch is not yet in? (And it would

Re: [Libreoffice-commits] .:

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 08:57 PM, Thomas Arnhold wrote: commit 45ad6029e1422c659e627bb30ecda50ccb61060c Author: Thomas Arnholdtho...@arnhold.org Date: Tue Feb 21 19:46:36 2012 +0100 WaE: duplicateBranch and use sal_False diff --git a/sc/source/core/data/dptabres.cxx

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-21 Thread Stephan Bergmann
On 02/16/2012 06:21 PM, Stephan Bergmann wrote: On 02/16/2012 05:12 PM, Stephan Bergmann wrote: On 02/16/2012 04:50 PM, Stephan Bergmann wrote: On 02/15/2012 04:54 PM, Michael Meeks wrote: On Wed, 2012-02-15 at 15:07 +0100, Stephan Bergmann wrote: As perhttps://bugs.freedesktop.org

Re: [REVIEW 3-5][PUSHED] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 10:57 PM, Stephan Bergmann wrote: Embarrassing as it is, turns out yet another patch needs to be backported from master to libreoffice-3-5, namely http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ea723e8ce4077c7efa957d278637c4d9f32cf14 Revert 'Mac OS X uses .dylib

Re: Configure LO for Python 3?

2012-02-22 Thread Stephan Bergmann
On 02/16/2012 04:27 PM, Stephan Bergmann wrote: For the record, adding ## ## Python 3 ## PYTHON_{CFLGS,LIBS}: pkg-config --{cflags,libs} python3 ## --enable-python=system PYTHON=/usr/bin/python3 PYTHON_CFLAGS=-I/usr/include/python3.2mu PYTHON_LIBS=-lpython3.2mu ## to autogen.lastrun did

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-22 Thread Stephan Bergmann
On 02/22/2012 11:30 AM, Michael Meeks wrote: On Tue, 2012-02-21 at 17:51 +0100, Stephan Bergmann wrote: The problem here appears not be C-based sal but C++-based cppuhelper (using ::cppu::bootstrap()), which will only work if cppuhelper and client code are compiled with the same compiler

Re: [PATCH] change in solenv/bin/ooinstall

2012-02-22 Thread Stephan Bergmann
On 02/22/2012 11:14 AM, Petr Mladek wrote: eval `sed -e 's|=\(.\+\)|=\\1\|' config_host.mk` eval $(sed -e s/\'/\'\'\'/g -e 's/=\(.\+\)/='\''\1'\'/ config_host.mk) would be safer (just in case any of the values are not invariant under double quote expansion) ;) Stephan

Re: Visual Studio cppu::bootstrap exception on 3.5.

2012-02-22 Thread Stephan Bergmann
On 02/22/2012 12:13 PM, Martin Thoma wrote: To exclude errors in our application, we created a new project and inserted the source from /sdk/examples/DevelopersGuide/ProfUNO/SimpleBootstrap_cpp/SimpleBootstrap_cp p.cxx = this works fine in LO 3.4.5., but with 3.5, we get the

Re: RTL_CONSTASCII_USTRINGPARAM: cleanup wanted?

2012-02-22 Thread Stephan Bergmann
On 02/22/2012 11:25 AM, Michael Meeks wrote: Great ! :-) incidentally, I had one minor point around the ASCII vs. UTF-8 side; the rtl_string2UString (cf. sal/rtl/source/string.cxx) does a typically slower UTF-8 length counting loop; I suggest that we could do better performance wise (and

Re: Visual Studio cppu::bootstrap exception on 3.5.

2012-02-22 Thread Stephan Bergmann
On 02/22/2012 01:50 PM, Martin Thoma wrote: Are you building that SimpleBootstrap_cpp example with the 3.4.5 SDK, with the 3.5 SDK, or with a hand-crafted build environment of your own? So far with a hand-craftet build environment for Microsoft Visual Studio. For 3.5, LO's basis and brand

Re: Has the time come to get rid of the delivering of public headers?

2012-02-22 Thread Stephan Bergmann
On 02/22/2012 04:23 PM, Norbert Thiebaud wrote: While we are at it, why not have just one public header file per module... that would seriously simplify the header inclusion stuff. sure the downside is that that header can be pretty big, and any change in a module's header would trigger a

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 09:04 AM, Matúš Kukan wrote: I got: c:/git/libo/fpicker/source/win32/misc/resourceprovider.cxx(125) : error C2666: 'SimpleResMgr::SimpleResMgr' : 2 overloads have similar conversions C:/git/libo/solver/wntmsci12.pro/inc\tools/simplerm.hxx(76): could be

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 10:56 AM, Stephan Bergmann wrote: On 02/23/2012 09:04 AM, Matúš Kukan wrote: I got: c:/git/libo/fpicker/source/win32/misc/resourceprovider.cxx(125) : error C2666: 'SimpleResMgr::SimpleResMgr' : 2 overloads have similar conversions C:/git/libo/solver/wntmsci12.pro/inc\tools

Re: const*const - what is the purpose of this?

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 11:23 AM, Jesús Corrius wrote: On Thu, Feb 23, 2012 at 9:04 AM, Noel Grandinn...@peralex.com wrote: I'm seeing declarations like this scattered around the SW module: e.g. in sw/inc/swtable.hxx at line 301 static SwTable * FindTable( SwFrmFmt const*const pFmt ); As far as I

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 12:22 PM, Michael Meeks wrote: On Thu, 2012-02-23 at 10:56 +0100, Stephan Bergmann wrote: Yes, fix should be good. With the newly added rtl::OUString ctor, a string literal can now implicitly be converted to an rtl::OUString, which can lead to ambiguities. In this case

Re: windows build error in NeonLockStore because of salhelper::Thread

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 02:46 PM, Noel Grandin wrote: $ make ucb cd ucb /opt/lo/bin/make -j 8 -rs gb_PARTIALBUILD=T /cygdrive/e/libo/ucb/StaticLibrary_odma_lib.mk:37: [ WARN ] !!! [ WARN ] !!! ucb/source/ucp/odma/odma_lib is linked in by Library/iucpodma1.lib StaticLibrary/odma_lib.lib [ WARN ] !!! [

Re: -std=c++0x vs -std=gnu++0x

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 05:08 PM, Lubos Lunak wrote: commit 437fe5a11f68d1848c49121394f16f09611b made me notice that we actually build with -std=c++0x and not -std=gnu++0x, which I think would make more sense and be consistent with the case when we do not build in C++0x mode. If you look at the

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 02:35 PM, Lubos Lunak wrote: On Thursday 23 of February 2012, Stephan Bergmann wrote: On 02/23/2012 10:56 AM, Stephan Bergmann wrote: On 02/23/2012 09:04 AM, Matúš Kukan wrote: The patch helped me to build on Windows but I did not push because I don't know what really

Re: [REVIEW-3-5][REVIEW-3-5-1] libxml2 on MacOSX

2012-02-23 Thread Stephan Bergmann
On 02/22/2012 11:54 PM, Norbert Thiebaud wrote: as a follow-up to it was necessary to use libxml2 as an internal library for MacOSX... which was not well supported. http://cgit.freedesktop.org/libreoffice/core/commit/?id=49843f0f9788e01805d8d0d27428fe5e6a4cc530 is what I had to do to get it to

Re: .: 14 commits - binaryurp/source comphelper/inc comphelper/Library_comphelp.mk comphelper/prj comphelper/source configmgr/source cui/Library_cui.mk cui/prj cui/source dbaccess/source desktop/Libra

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 02:56 PM, Michael Stahl wrote: On 23/02/12 10:48, Stephan Bergmann wrote: +void salhelper::Thread::launch() { +SAL_INFO(salhelper.thread, launch name_); +// Assumption is that osl::Thread::create returns normally iff it causes +// osl::Thread::run to start executing

Re: [PATCH][PUSHED] Fix windows build

2012-02-23 Thread Stephan Bergmann
On 02/23/2012 10:53 PM, Matúš Kukan wrote: On 23 February 2012 18:04, Stephan Bergmannsberg...@redhat.com wrote: OMG. In this case, it might be safer to change the code again to make it actually use the ctor variant it used before (char const * and Locale const ). Matúš, can you check

Re: [PUSHED] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-24 Thread Stephan Bergmann
On 02/24/2012 11:46 AM, Michael Meeks wrote: On Fri, 2012-02-24 at 10:50 +0100, Dézsi Szabolcs wrote: Hi all! Started all over again, this patch removes the MSFilterTracer class, which is no longer used, and removes all references to it (in sc, sd and sw) The previous patch is obsolete now.

Re: [PUSHED] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-24 Thread Stephan Bergmann
On 02/24/2012 02:19 PM, Stephan Bergmann wrote: On 02/24/2012 11:46 AM, Michael Meeks wrote: On Fri, 2012-02-24 at 10:50 +0100, Dézsi Szabolcs wrote: Hi all! Started all over again, this patch removes the MSFilterTracer class, which is no longer used, and removes all references to it (in sc

[REVIEW 3-5][REVIEW 3-5-1] Fix for fdo#46074 FILEOPEN: No Recent Documents...

2012-02-24 Thread Stephan Bergmann
Please review master commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=f3f79cc9e6c265baf48955d53f7e888205e0b3e0 Resolves fdo#46074: Fix Partial::contains for paths that go past a leaf node that fixes https://bugs.freedesktop.org/show_bug.cgi?id=46074 FILEOPEN: No Recent

Re: [Libreoffice-commits] .: Makefile

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 09:28 AM, Norbert Thiebaud wrote: On 2/26/12 13:00 , Peter Foley wrote: Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit a75873dea15719b5216cfd0476d30003ffc76e80 Author: Peter Foleypefol...@verizon.net Date: Sun Feb 26 13:53:09

User installation migrated onto itself

2012-02-27 Thread Stephan Bergmann
I wondered why https://bugs.freedesktop.org/show_bug.cgi?id=46074 FILEOPEN: No Recent Documents... reportedly hits Mac and Windows users going from LO 3.4 to 3.5, when it should only hit in cases where the user installation is migrated (which happens on Linux when going from LO 3.4 to 3.5,

Re: [REVIEW:3-5, 3-5-1][PUSHED-3-5] do not pack stdlibs twice (fdo#46658)

2012-02-27 Thread Stephan Bergmann
[Petr, I assume you meant 3-5-1 instead of 3-4-5 in the subject; changed.] On 02/27/2012 12:33 PM, Petr Mladek wrote: we moved the stdlibs into separate optional package for LO-3.5.1-rc1. Unfortunately, the related gid entries were still listed in the the ure module in scp2. It causes

Re: Weird undefined symbol: ReferenceXInterface::operator ReferenceXInterface const() const

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 01:20 PM, Tor Lillqvist wrote: Anybody have a clue what might cause this (in a build for the iOS simulator, using the llvm-g++ 4.2.1 in Xcode 4.3): Undefined symbols for architecture i386: com::sun::star::uno::Referencecom::sun::star::uno::XInterface::operator

Re: MinGW-Port: Problems with UnoUrlResolver

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 01:07 PM, Helmar Spangenberg wrote: Anyway - using the older toolchain I got a working testing environment and proceded a little bit. I have the impression that the difficulties rise building the local context. As far as I could debug it, everything looks fine until a

Re: [PUSHED:3-5][PUSHED:3-5-1] fix build with internal libxml on MAC PPC

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 05:03 PM, Petr Mladek wrote: Fridrich Strba píše v Po 27. 02. 2012 v 12:00 +0100: Please review these three patches that are needed currently for the build of 3.5.1-rc1 with internal libxml on MacOSX 10.4 PPC The change for libcroco looks a bit hacky. Anyway, all the changes

Re: REVIEW 3-5, 3-5-1

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 12:00 PM, Fridrich Strba wrote: Please review these three patches that are needed currently for the build of 3.5.1-rc1 with internal libxml on MacOSX 10.4 PPC Any reason you did not push this to master, Fridrich? Stephan ___

Re: JUnit sc_complex fails in Localized enviroment

2012-02-27 Thread Stephan Bergmann
On 02/27/2012 08:19 PM, Maciej Rumianowski wrote: I have build with pl and de languages and when I set all locale enviroment variables (LANG LC_*) to en_US.UTF-8 the test uses German language with output like: So you configured --with-lang='pl de' (i.e., without any mention of en-US), and

Re: Small note on static analyzer, includes and build times...

2012-02-28 Thread Stephan Bergmann
On 02/27/2012 11:07 PM, Albert Thuswaldner wrote: What I did: 1: I created a folder doxygen in the root of the sc module. 2. Adapted his script and put it in this folder. 3. Made a simple doxygen config file (Doxyfile) and ran doxygen 4. finally ran the script: ./analyze_includes.pl analyze.log

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-28 Thread Stephan Bergmann
On 02/28/2012 07:25 AM, Tommy wrote: however I still confirm that the freeze has something to do with autocorrection... if you download this portable versione of LibO 3.5.0 http://www.winpenpack.com/main/download.php?view.1338 which comes out with a virgin user preset, you won't notice any

Re: [PUSHED-3-5][PUSHED-3-5-1] libxml2 on MacOSX

2012-02-28 Thread Stephan Bergmann
On 02/24/2012 05:52 AM, Norbert Thiebaud wrote: I've cherry-picked these to the 3-5 branch. tinderbox is happy Seen pushed into both libreoffice-3-5 and libreoffice-3-5-1, marking thread accordingly. Stephan ___ LibreOffice mailing list

Re: [PUSHED 3-5] duplicate fonts, one broken, one not, results in neither being detected

2012-02-28 Thread Stephan Bergmann
On 02/27/2012 12:50 PM, Caolán McNamara wrote: i.e. https://bugs.freedesktop.org/show_bug.cgi?id=42901 and this commit to fix: http://cgit.freedesktop.org/libreoffice/core/commit/?id=65a3ec97b5032d1748c8f84eeb0b8656e1c25918 broken duplicate seen before working duplicate, first rejected for

Re: JUnit sc_complex fails in Localized enviroment

2012-02-28 Thread Stephan Bergmann
On 02/28/2012 08:47 AM, Stephan Bergmann wrote: On 02/27/2012 08:19 PM, Maciej Rumianowski wrote: I have build with pl and de languages and when I set all locale enviroment variables (LANG LC_*) to en_US.UTF-8 the test uses German language with output like: So you configured --with-lang='pl

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-28 Thread Stephan Bergmann
On 02/28/2012 10:43 AM, Tommy wrote: On Tue, 28 Feb 2012 09:14:06 +0100, Stephan Bergmann sberg...@redhat.com wrote: But that's exactly the thing discussed in the recent [PATCH] Reduced loadtime of autocorrect tables mail thread then, right? Stephan no, that thread was about loading time

<    7   8   9   10   11   12   13   14   15   16   >