Re: [Libreoffice] few queastions about building sal

2011-08-29 Thread Stephan Bergmann
On Aug 29, 2011, at 8:35 PM, Caolán McNamara wrote: On Mon, 2011-08-29 at 15:53 +0200, Stephan Bergmann wrote: On Aug 29, 2011, at 2:50 PM, Matúš Kukan wrote: rtl_hashfunc, rtl_hashentry_destroy and 5 more rtl_hashtable_* from rtl/source/locale.c Ah, I see. Yes, indeed, appears they have

Re: [Libreoffice] unnecessary build of obj/bootstrap.o?

2011-08-29 Thread Stephan Bergmann
On Aug 29, 2011, at 5:12 PM, Kevin Hunter wrote: In tracking down another issue, I've run across a number of object files that we appear to build but not use. Example: g++ -o sal/unxlngx6/obj/bootstrap.o [...] A few lines later in the build, we build this, with a few extra g++

Re: [Libreoffice] Platform-specific OUTPATH variables

2011-08-30 Thread Stephan Bergmann
Sent from my iPhone On 30.08.2011, at 14:40, Eike Rathke o...@erack.de wrote: Hi Tor, On Tuesday, 2011-08-30 00:15:50 -0600, Tor Lillqvist wrote: Can't we at least get rid of the '350' subdirectory ? Yes please. The 350 should be 340 (isn't it?) for 3-4 branches, so different

Re: [Libreoffice] [PATCH] [PUSHED] (was: Re: buglet in 1ec7b6a4 (?))

2011-08-31 Thread Stephan Bergmann
On Aug 31, 2011, at 3:55 AM, Kohei Yoshida wrote: On Mon, 2011-08-29 at 12:08 +0200, Stephan Bergmann wrote: http://cgit.freedesktop.org/libreoffice/core/commit/autogen.sh?id=3ea37ac7005c64f378756a5dbc3fbfbc3bf8b053 does not fix this for the one-argument case, however, due to an error

Re: [Libreoffice] inconsistency between rtl::OString/rtl::OUString and optimization opportunities ?

2011-08-31 Thread Stephan Bergmann
On Aug 31, 2011, at 12:04 PM, Caolán McNamara wrote: rtl_string_new_WithLength/rtl_uString_new_WithLength create an rtl/String/rtl_uString of the given length, but set the full buffer contents to 0s[1] No idea whether specifying that the values of all characters are set to 0 was meant to be

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 2:19 AM, Mohammad Elahi wrote: Changed function lcl_formatPersianWord to be more generic, and added support for some more numbering types: English word: one, two, three, ... English cardinal: first, second, third, ... English cardinal semi-word: 1st, 2nd, 3rd, ... Persian

Re: [Libreoffice] New desktop integration modules

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 5:32 AM, Timothy Pearson wrote: I have created a patch that adds Trinity Desktop Environment integration to LibreOffice, and would like to get it included in the upstream LibreOffice sources if you are interested. It is based on the old KDE3 integration module, but has

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 11:00 AM, Mohammad Elahi wrote: Here, however, someone doing localization would need to add new constants to NumberingType.idl and would need to add code to defaultnumberingprovider.cxx. That does not feel right. OK, I'm just started to work with libreoffice code ;) Just

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 12:30 PM, Tor Lillqvist wrote: The changes themself look sane, regarding the background Khaled gave and knowing part of his work from older days I didn't hesitate much to commit this :) OK, excellect! Khaled, if you want direct commit access, just ask (hmm, file a bug

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 1:01 PM, Eike Rathke wrote: On Thursday, 2011-09-01 09:35:09 +0200, Stephan Bergmann wrote: First, I think extending this from Persian to English already shows the biggest flaw of this approach: Do you want to extend in in this way for all languages supported by LibO? I

Re: [Libreoffice] Build break when generating RDBs

2011-09-02 Thread Stephan Bergmann
On Sep 1, 2011, at 5:33 PM, Peter Foley wrote: On Thu, 1 Sep 2011, Eike Rathke wrote: Hi Peter, On Tuesday, 2011-08-30 14:36:01 -0400, Peter Foley wrote: [ build ALL ] top level modules: i18npool [ build ALL ] loaded modules: i18npool [ build RDB ] i18npool_test_breakiterator awk:

[Libreoffice] [PATCH] fix basebmp symbol visibility (was: bug in vcl make files?)

2011-09-02 Thread Stephan Bergmann
On Sep 1, 2011, at 9:26 PM, Stephan Bergmann wrote: On Sep 1, 2011, at 3:47 PM, Matúš Kukan wrote: That's not about makefiles. debugDump() is not marked for exporting, you can do this in cxx file with SAL_DLLPUBLIC_EXPORT or in hxx files. But in hxx you need to use library specific macro

Re: [Libreoffice] [Libreoffice-commits] .: 3 commits - offapi/com offapi/UnoApi_offapi.mk oovbaapi/ooo oovbaapi/UnoApi_oovbaapi.mk solenv/gbuild udkapi/UnoApi_udkapi.mk

2011-09-02 Thread Stephan Bergmann
On Sep 2, 2011, at 11:58 AM, Matus Kukan wrote: offapi/UnoApi_offapi.mk| 7859 + offapi/com/sun/star/rendering/XMtfRenderer.idl |2 oovbaapi/UnoApi_oovbaapi.mk| 2087 +++--- oovbaapi/ooo/vba/excel/XControlObject.idl |

Re: [Libreoffice] [Libreoffice-commits] .: 3 commits - offapi/com offapi/UnoApi_offapi.mk oovbaapi/ooo oovbaapi/UnoApi_oovbaapi.mk solenv/gbuild udkapi/UnoApi_udkapi.mk

2011-09-02 Thread Stephan Bergmann
On Sep 2, 2011, at 3:36 PM, Matúš Kukan wrote: On 2 September 2011 14:29, Stephan Bergmann stephan.bergmann.second...@googlemail.com wrote: On Sep 2, 2011, at 11:58 AM, Matus Kukan wrote: offapi/UnoApi_offapi.mk| 7859 + offapi/com/sun/star

Re: [Libreoffice] map files: how to update? [was: cppu::OPropertySetHelper ABI backwards compatibility]

2011-09-05 Thread Stephan Bergmann
On Sep 2, 2011, at 5:13 PM, Lionel Elie Mamane wrote: - For the question of which symbols for OPropertySetHelper2 to list in the various map files, see http://udk.openoffice.org/common/man/apicppclasses.html (you probably need access to builds on the various platforms to find out the correct

Re: [Libreoffice] Build break when generating RDBs

2011-09-05 Thread Stephan Bergmann
On Sep 2, 2011, at 6:28 PM, Peter Foley wrote: On Fri, 2 Sep 2011, Stephan Bergmann wrote: On Sep 1, 2011, at 5:33 PM, Peter Foley wrote: On Thu, 1 Sep 2011, Eike Rathke wrote: Hi Peter, On Tuesday, 2011-08-30 14:36:01 -0400, Peter Foley wrote: [ build ALL ] top level modules

[Libreoffice] [PATCH] Honor --disable-strip in gbuild.

2011-09-06 Thread Stephan Bergmann
the license documented at http://lists.freedesktop.org/archives/libreoffice/2011-August/017383.html.) -Stephan From 5b1199602807152777b149cc3c30105c2064baa5 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann sberg...@redhat.com Date: Tue, 6 Sep 2011 09:39:07 +0200 Subject: [PATCH] Honor --disable

Re: [Libreoffice] [PATCH] Honor --disable-strip in gbuild.

2011-09-06 Thread Stephan Bergmann
On 09/06/2011 09:58 AM, Norbert Thiebaud wrote: On Tue, Sep 6, 2011 at 2:51 AM, Stephan Bergmannsberg...@redhat.com wrote: Unlike the old dmake build system, solenv/gbuild/platform/unxgcc.mk sets -Wl,--strip-all depending on --enable-symbols only, and ignores --disable-strip altogether.

[Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.

2011-09-06 Thread Stephan Bergmann
Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. -Stephan From 9bea29af5a3fd86031e28bb8b4ca3f445f3eca96 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann sberg...@redhat.com

Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.

2011-09-06 Thread Stephan Bergmann
On 09/06/2011 12:25 PM, Noel Power wrote: Hi Stephan, On 06/09/11 10:07, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. -Stephan thanks for fixing

Re: [Libreoffice] map files: how to update? [was: cppu::OPropertySetHelper ABI backwards compatibility]

2011-09-06 Thread Stephan Bergmann
On 09/06/2011 06:39 PM, Lionel Elie Mamane wrote: On Mon, Sep 05, 2011 at 09:57:30AM +0200, Stephan Bergmann wrote: - For the question of which symbols for OPropertySetHelper2 to list in the various map files, see http://udk.openoffice.org/common/man/apicppclasses.html (you probably need

[Libreoffice] fix for fdo#33960 cross reference to a list number, dot bug makes sw/qa/complex/writer fail

2011-09-06 Thread Stephan Bergmann
At least with recent git trunk builds, make subsequentcheck fails in sw with 1) checkCrossReferences(complex.writer.CheckCrossReferences) org.junit.ComparisonFailure: set reference field format doesn't result in correct field result expected: 1[.] but was: 1[] at

Re: [Libreoffice] [PATCH] build system patches

2011-09-07 Thread Stephan Bergmann
On 09/07/2011 03:14 AM, Norbert Thiebaud wrote: On Tue, Sep 6, 2011 at 5:32 PM, Peter Foleypefol...@verizon.net wrote: Hi, Here are some patches for various problems I encountered while building libreoffice. 0001-libcrnf.a is that a consequence of

Re: [Libreoffice] [PATCH] build system patches

2011-09-07 Thread Stephan Bergmann
On 09/07/2011 10:28 AM, Norbert Thiebaud wrote: On Wed, Sep 7, 2011 at 1:47 AM, Stephan Bergmannsberg...@redhat.com wrote: On 09/07/2011 03:14 AM, Norbert Thiebaud wrote: On Tue, Sep 6, 2011 at 5:32 PM, Peter Foleypefol...@verizon.netwrote: Hi, Here are some patches for various

Re: [Libreoffice] map files: how to update? [was: cppu::OPropertySetHelper ABI backwards compatibility]

2011-09-07 Thread Stephan Bergmann
On 09/07/2011 12:14 PM, Lionel Elie Mamane wrote: On Mon, Sep 05, 2011 at 09:57:30AM +0200, Stephan Bergmann wrote: On Sep 2, 2011, at 5:13 PM, Lionel Elie Mamane wrote: I assume the vtable obviously has to be exported. No, need not be exported (if none of the ctors and dtors are inline

Re: [Libreoffice] build only xpcom in moz: not working

2011-09-07 Thread Stephan Bergmann
On 09/07/2011 12:36 PM, Lionel Elie Mamane wrote: In your commit 291b85778669b4e4e276faab22add9d0e80046df (Build our mozilla (module moz) against the nss we have built anyway.) [...] Doing make only in xpcom fails from a clean state (some files that are needed are not built), so I've

Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2

2011-09-07 Thread Stephan Bergmann
On 09/07/2011 04:37 PM, Eike Rathke wrote: Hi Regina, On Wednesday, 2011-09-07 15:04:47 +0200, Regina Henschel wrote: I see a lot of sal_uInt64 in the code. Is that supported for Windows? As far as I know at least the MSVC Express has only 4Byte long. Umm.. now that you mention..

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Stephan Bergmann
On 09/08/2011 01:44 AM, Eike Rathke wrote: Hi Korrawit, On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote: Attached patch will clear the cppcheck warning for duplicate expression on both sides of ''. Yup, good catch!

Re: [Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

2011-09-08 Thread Stephan Bergmann
On 09/08/2011 08:18 AM, Stephan Bergmann wrote: On 09/08/2011 01:44 AM, Eike Rathke wrote: Hi Korrawit, On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote: Attached patch will clear the cppcheck warning for duplicate expression on both sides of ''. Yup, good catch! http

Re: [Libreoffice] configure.in monstrosity

2011-09-08 Thread Stephan Bergmann
On 09/08/2011 02:50 PM, Tomáš Chvátal wrote: I was editing the configure.in file in order to fix one tiny bug and found out it is horrible scarry place. It would be really nice if that huge file would be split into several separate parts per-use. So I would like to propose slow

Re: [Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

2011-09-09 Thread Stephan Bergmann
On 09/08/2011 10:47 PM, julien2412 wrote: Here is the pb : if( 0 )--- Found duplicate if expressions. { nFontID = EE_CHAR_FONTINFO_CJK; nFontHeightID = EE_CHAR_FONTHEIGHT_CJK; nWeightID = EE_CHAR_WEIGHT_CJK;

Re: [Libreoffice] [Libreoffice-commits] .: sal/inc

2011-09-09 Thread Stephan Bergmann
On 09/07/2011 02:56 PM, Bjoern Michaelsen wrote: sal/inc/sal/types.h | 16 1 file changed, 16 insertions(+) New commits: commit de290e726ed2aa5a4c007d61a7db1042c45d43db Author: Bjoern Michaelsenbjoern.michael...@canonical.com Date: Wed Sep 7 12:37:08 2011 +0200

Re: [Libreoffice] Cppcheck defect when @ is present

2011-09-12 Thread Stephan Bergmann
On 09/11/2011 01:27 PM, Pierre-André Jacquod wrote: What's the best thing to do : - to keep objective C++ parts ? - to replace objective C++ by plain (with or without boost) C++ ? for me there are already too many languages and flavour of languages. I would stay with plain C++, not adding

Re: [Libreoffice] Mi first very little patch

2011-09-12 Thread Stephan Bergmann
On 09/12/2011 01:03 AM, Lionel Elie Mamane wrote: On Sun, Sep 11, 2011 at 10:04:52PM +0200, CaStarCo wrote: I've created a second (very little too) patch to reduce the scope of a variable. --- a/sal/osl/w32/file_dirvol.cxx +++ b/sal/osl/w32/file_dirvol.cxx @@ -60,7 +60,6 @@ extern C BOOL

[Libreoffice] From sal/cppunit.h to sal/precppunit.hxx

2011-09-12 Thread Stephan Bergmann
Hi all, With http://cgit.freedesktop.org/libreoffice/core/commit/?id=d996328cd5f46eeed2df0cbd510eda28e2f7cef9 come three changes for CppUnit based tests in the LibO code base: - The header sal/cppunit.h has been removed (and it was not used much). - There is a new header sal/precppunit.hxx

Re: [Libreoffice] [PUSHED][PATCH] convert xml2cmp to gbuild

2011-09-13 Thread Stephan Bergmann
On 09/12/2011 11:23 PM, Norbert Thiebaud wrote: On Mon, Sep 12, 2011 at 4:04 PM, Peter Foleypefol...@verizon.net wrote: Another gbuild conversion. Nice. Pushed, Thanks. It ~looks like this broke the latest Mac OSX gcc-4.0.1 (PPC) tinderbox build, see

Re: [Libreoffice] [PUSHED][PATCH] convert xml2cmp to gbuild

2011-09-13 Thread Stephan Bergmann
On 09/13/2011 08:18 AM, Stephan Bergmann wrote: On 09/12/2011 11:23 PM, Norbert Thiebaud wrote: On Mon, Sep 12, 2011 at 4:04 PM, Peter Foleypefol...@verizon.net wrote: Another gbuild conversion. Nice. Pushed, Thanks. It ~looks like this broke the latest Mac OSX gcc-4.0.1 (PPC) tinderbox

Re: [Libreoffice] fix for fdo#33960 cross reference to a list number, dot bug makes sw/qa/complex/writer fail

2011-09-13 Thread Stephan Bergmann
On 09/07/2011 11:15 PM, Troy Rollo wrote: On Wednesday 07 September 2011, Stephan Bergmann wrote: Troy, will you come up with a fix that brings sw/source/core/doc/number.cxx and sw/qa/complex/writer/CheckCrossReferences.java in sync again? I won't be able to do that until mid November due

Re: [Libreoffice] [PATCH] convert MathMLDTD to gbuild and add to tail_build

2011-09-13 Thread Stephan Bergmann
On 09/13/2011 01:00 AM, Norbert Thiebaud wrote: On Mon, Sep 12, 2011 at 4:53 PM, Michael Stahlm...@openoffice.org wrote: On 12.09.2011 23:26, Peter Foley wrote: --- a/MathMLDTD/prj/build.lst +++ b/MathMLDTD/prj/build.lst @@ -1,3 +1,2 @@ -md MathMLDTD : solenv NULL -md

Re: [Libreoffice] [PATCH] convert MathMLDTD to gbuild and add to tail_build

2011-09-13 Thread Stephan Bergmann
On 09/13/2011 11:18 AM, Michael Stahl wrote: On 13.09.2011 11:09, Stephan Bergmann wrote: On 09/13/2011 01:00 AM, Norbert Thiebaud wrote: On Mon, Sep 12, 2011 at 4:53 PM, Michael Stahlm...@openoffice.org wrote: On 12.09.2011 23:26, Peter Foley wrote: --- a/MathMLDTD/prj/build.lst +++ b

Re: [Libreoffice] [PUSHED][PATCH] convert xml2cmp to gbuild

2011-09-13 Thread Stephan Bergmann
On 09/13/2011 08:40 AM, Stephan Bergmann wrote: On 09/13/2011 08:18 AM, Stephan Bergmann wrote: On 09/12/2011 11:23 PM, Norbert Thiebaud wrote: On Mon, Sep 12, 2011 at 4:04 PM, Peter Foleypefol...@verizon.net wrote: Another gbuild conversion. Nice. Pushed, Thanks. It ~looks like

Re: [Libreoffice] [PATCH] convert MathMLDTD to gbuild and add to tail_build

2011-09-13 Thread Stephan Bergmann
On 09/13/2011 11:20 AM, Stephan Bergmann wrote: On 09/13/2011 11:18 AM, Michael Stahl wrote: guess somebody should put back the solenv deps :) doing it right now http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f78448b9423d0b33d8ef372dc67a1903b31 -Stephan

Re: [Libreoffice] From sal/cppunit.h to sal/precppunit.hxx

2011-09-13 Thread Stephan Bergmann
On 09/13/2011 11:50 AM, Lubos Lunak wrote: On Monday 12 of September 2011, Stephan Bergmann wrote: Hi all, With http://cgit.freedesktop.org/libreoffice/core/commit/?id=d996328cd5f46eeed2 df0cbd510eda28e2f7cef9 come three changes for CppUnit based tests in the LibO code base: Please update

Re: [Libreoffice] Linux plumbers 2011: large application startup slidedeck

2011-09-14 Thread Stephan Bergmann
On 09/14/2011 10:31 AM, Caolán McNamara wrote: Taras Glek's slidedeck about firefox, etc. startup performance http://people.mozilla.com/~tglek/lpc2011/ Some goodies. On the relatively low-hanging fruit side of things... [...] b) fadvise(WILLNEED) before dlopen ?

Re: [Libreoffice] Linux plumbers 2011: large application startup slidedeck

2011-09-14 Thread Stephan Bergmann
On 09/14/2011 11:48 AM, Caolán McNamara wrote: On Wed, 2011-09-14 at 11:17 +0200, Stephan Bergmann wrote: On 09/14/2011 10:31 AM, Caolán McNamara wrote: Taras Glek's slidedeck about firefox, etc. startup performance http://people.mozilla.com/~tglek/lpc2011/ Some goodies. On the relatively low

Re: [Libreoffice] duplicateif in vcl/source/gdi/outdev3.cxx

2011-09-14 Thread Stephan Bergmann
On 09/14/2011 08:47 PM, julien2412 wrote: Since I don't know the impact I prefer proposing a review. Of course, if you're really sure of you Eike (:-) ), I can commit and push right away on master http://nabble.documentfoundation.org/file/n3336763/patch_outdev3.txt patch_outdev3.txt Looking

[Libreoffice] gbuildized xml2cmp breaks Windows (was: Tinderbox failure, last success: 2011-09-13 20:44:55)

2011-09-15 Thread Stephan Bergmann
On 09/15/2011 09:11 AM, Stephan Bergmann wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e728feaeebae96df5566bdb6d5f0458983d843ad On Windows, xml2cmp depends on uwinapi from sal. should probably fix the below problem. Turns out that that fix (making xml2cmp depend on sal

Re: [Libreoffice] Bug in XclImpOutlineBuffer::MakeScOutline ?

2011-09-15 Thread Stephan Bergmann
On 09/15/2011 12:42 AM, julien2412 wrote: I'm trying to open a quite big xls file (sorry, I'm allowed to publish it). Here are the 4 types of error in logs : [...] Error: UniString::SearchAndReplaceAllAscii() - pAsciiStr include characters 127 From File

Re: [Libreoffice] gbuildized xml2cmp breaks Windows

2011-09-15 Thread Stephan Bergmann
On 09/15/2011 11:37 AM, Michael Stahl wrote: i think somebody once told me that the last remaining functions are only required on Windows 2000, and if we raised the baseline to Windows XP then it would be unnecessary. any idea if that is true? No, looks like snprintf etc. from uwinapi are

Re: [Libreoffice] gbuildized xml2cmp breaks Windows

2011-09-15 Thread Stephan Bergmann
On 09/15/2011 11:13 AM, Tor Lillqvist wrote: OK, clearly the time now has come to get rid of uwinapi completely. Our uwinapi.dll only contains four functions nowadays: snprintf, snwprintf, vsnprintf and vsnwprintf. We should move those to sal or something. And for those pesky binary extensions

Re: [Libreoffice] gbuildized xml2cmp breaks Windows

2011-09-15 Thread Stephan Bergmann
On 09/15/2011 12:36 PM, Tor Lillqvist wrote: Patches welcome. Sounds doable (if I find access to a Windows box). -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] gbuildized xml2cmp breaks Windows

2011-09-15 Thread Stephan Bergmann
On 09/15/2011 02:57 PM, Fridrich Strba wrote: Stefan, On Thu, 2011-09-15 at 12:10 +0200, Stephan Bergmann wrote: But instead of moving those functions to, say, sal, why not keep them in a library called uwinapi.dll? And do the clean-up of not including that library implicitly in every linker

Re: [Libreoffice] gbuild question

2011-09-19 Thread Stephan Bergmann
On 09/17/2011 06:19 AM, Norbert Thiebaud wrote: On Fri, Sep 16, 2011 at 7:07 PM, Peter Foleypefol...@verizon.net wrote: I'm working on converting soltools to gbuild but I've come across a problem. soltools/testhxx/makefile.mk echos the commandline to compile a cxx file to a temporary file and

Re: [Libreoffice] Debian gcc or LO bug

2011-09-19 Thread Stephan Bergmann
On 09/18/2011 11:23 PM, julien2412 wrote: Hello, On LO-dev IRC, i met someone with this pb /home/luc/git/core/vcl/unx/gtk/a11y/atkutil.cxx:322:60: error: call of overloaded ‘insert(com::sun::star::uno::Referencecom::sun::star::accessibility::XAccessibleEventBroadcaster)’ is ambiguous detail

Re: [Libreoffice] Remove NULL checks from delete

2011-09-19 Thread Stephan Bergmann
On 09/19/2011 08:58 PM, Thomas Arnhold wrote: I've recently seen some changes, which removed unnecessary NULL checks for delete commands with the form: - if (pTextPContext) - delete pTextPContext; + delete pTextPContext; Codebase is full with these. I've attached a little perl script which

Re: [Libreoffice] [Libreoffice-commits] .: Branch 'libreoffice-3-4' - solenv/gbuild

2011-09-19 Thread Stephan Bergmann
Björn, What good is that backport to 3.4? For one, the fix turns out to not work yet (as executables already built using gbuild but only used during the build itself use a NONEBIN token in solenv/gbuild/platform/*.mk instead of the NONE token used in solenv/inc/*.mk, so that

Re: [Libreoffice] Proposal: slowcheck -- a new gbuild toplevel target

2011-09-20 Thread Stephan Bergmann
On 09/19/2011 09:18 PM, Bjoern Michaelsen wrote: we now have a good systematic set of test targets with unitcheck, subsequentcheck and check on master(*). However, we now have so many unittests (which is good) that running each and everyone on every build slows down the development cycle esp. in

Re: [Libreoffice] LO Custom properties

2011-09-20 Thread Stephan Bergmann
On 09/20/2011 10:11 AM, swagat sharma wrote: I have generated a deb package of libreoffice using epm. --enable-epm and with-package-format = deb Now the package generated is installed by default in /opt directory. How can I modify it to install in /usr/lib/ ? Which variable to change/set? Any

[Libreoffice] Undoing basis/brand split in 3.5

2011-09-20 Thread Stephan Bergmann
As recently announced on #libreoffice-dev, I consider undoing the basis/brand layer split. Historically, this was introduced at Sun to make it possible for various products (plain OpenOffice.org, Brasilian BrOffice re-branding, Sun's proprietary StarOffice, ...) to share code that is only

[Libreoffice] Suspicious warning fixes (was: [Libreoffice-commits] .: 4 commits - chart2/source cui/source desktop/test solenv/bin solenv/gdb solenv/inc)

2011-09-20 Thread Stephan Bergmann
Regina, The below two commits fix warnings from code changed through a recent commit by you, and in both cases I am a little unsure whether my fix is good (see inline below). On 09/20/2011 08:51 PM, Stephan Bergmann wrote: chart2/source/view/main/ShapeFactory.cxx |1 cui

Re: [Libreoffice] License for my patches

2011-09-21 Thread Stephan Bergmann
On 09/21/2011 09:37 AM, Samphan Raruenrom wrote: All my patches to LibreOffice project are under LGPLv3+/MPL1.1 dual license and future versions of the licenses. Please don't forget to update http://wiki.documentfoundation.org/Development/Developers accordingly. -Stephan

[Libreoffice] clean rebuilds needed

2011-09-23 Thread Stephan Bergmann
My recent commit to start undoing the basis/brand split, http://cgit.freedesktop.org/libreoffice/core/commit/?id=a66f9903bba9dc7eeff6683ebddcd34d4ad70068 makes it necessary to do clean rebuilds on non-Windows, as the RPATHs of all the moved libs have changed. Sorry for the late notification.

[Libreoffice] --enable-werror

2011-09-26 Thread Stephan Bergmann
Just a friendly reminder that all developers should use --enable-werror all the time. It helps yourself (you find potential errors early), your fellow developers (they don't need to fix your warnings for you), and our users (via a more stable product). (Different compilers tend to catch

Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-26 Thread Stephan Bergmann
On 09/25/2011 01:48 PM, Mathias Bauer wrote: The differentiation between hard and soft refererences would require a solid understanding of the relationships of all objects. With this understanding you could most probably fix the existing code without refcounting also: a weak reference always

Re: [Libreoffice] Easy Hack String replacement: SearchAndReplace

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 01:30 AM, Neil Leathers wrote: I was looking into the Easy Hacks: Removal/Replacement of the String/UniString/ByteString with OUString/OString once and for all and ran into needing to translate a SearchAndReplaceAscii. Before launching into this set I wanted to confirm that

[Libreoffice] comprehensive binfilter tests?

2011-09-26 Thread Stephan Bergmann
With the apparently somewhat semi-automatic code clean-up/removal in binfilter (removing dead code, noticing compiler warnings about thus newly unused variables, thus removing more dead code, ...), I wonder whether this does not introduce regressions. Do we have some comprehensive test suite

Re: [Libreoffice] --enable-werror

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 11:22 AM, Michael Meeks wrote: Hi Stephan, On Mon, 2011-09-26 at 08:41 +0200, Stephan Bergmann wrote: Just a friendly reminder that all developers should use --enable-werror all the time. This is a nice idea of course :-) but some platforms spew errors constantly beyond

Re: [Libreoffice] Compilation error in svx undefined reference to `XPropertyList::operator delete(void*)'

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 10:58 AM, Michael Meeks wrote: On Sun, 2011-09-25 at 01:40 -0700, julien2412 wrote: /home/maryline/compile-libreoffice/libo/workdir/unxlngi6/CxxObject/svx/source/tbxctrls/fillctrl.o: In function `~XBitmapList': /home/maryline/compile-libreoffice/libo/svx/inc/svx/xtable.hxx:469:

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 11:45 AM, Michael Meeks wrote: On Mon, 2011-09-26 at 10:23 +0200, Stephan Bergmann wrote: With the apparently somewhat semi-automatic code clean-up/removal in binfilter (removing dead code, noticing compiler warnings about thus newly unused variables, thus removing more dead code

Re: [Libreoffice] subsequenttest hang ...

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 08:24 PM, Michael Meeks wrote: On Mon, 2011-09-26 at 17:33 +0200, Stephan Bergmann wrote: A timed wait is no solution here. (Timeouts in this kind of code pose at least two problems. For one, they prevent a human from coming back to a hung make check after a while, only to find

Re: [Libreoffice] --enable-werror

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 01:15 PM, Marc-André Laverdière wrote: I tried doing that, but it seems that my autogen flags made it so that I was compiling some module unknown to me that was in 'build warning land'. Unless we don't have modules living in such countries anymore, I won't want to enable that

Re: [Libreoffice] clean rebuilds needed

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 07:00 PM, Bjoern Michaelsen wrote: The concept of dependencies only get you so far -- the rest is better left to caching (aka ccache). I think its *file based* dependencies that's the problem here -- they are simply not at the right level of granularity. (Then again, I'm not

Re: [Libreoffice] clean rebuilds needed

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 10:01 PM, Bjoern Michaelsen wrote: On Mon, 26 Sep 2011 21:33:03 +0200 Stephan Bergmannsberg...@redhat.com wrote: I think its *file based* dependencies that's the problem here -- they are simply not at the right level of granularity. (Then again, I'm not sure there's at all a

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-27 Thread Stephan Bergmann
On 09/26/2011 09:58 PM, Michael Meeks wrote: (And the cost of analysing the regressions, if they are eventually found, will also be rather high, given the aggressive pruning of allegedly dead code in the meantime). Surely git bisect is pretty impervious to the size or number of changes

Re: [Libreoffice] cppunittester hang when LC_ALL/LANG set

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 12:47 AM, Miklos Vajna wrote: I just updated my master build on my notebook after about two weeks and the build hanged in sal when I did *not* unset LANG/LC_ALL. First I bisected it: [...] Does this ring any bell? I tried to revert the commit, but it's a large one, and I could

Re: [Libreoffice] subsequenttest hang ...

2011-09-27 Thread Stephan Bergmann
On 09/26/2011 11:23 PM, Norbert Thiebaud wrote: So... my Linux tinderbox hanged again in make check... after only 3 green iterations... I have not noticed for 7 hours, nor anyone else apparently... Would that be

Re: [Libreoffice] cppunittester hang when LC_ALL/LANG set

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 08:20 AM, Stephan Bergmann wrote: On 09/27/2011 12:47 AM, Miklos Vajna wrote: I just updated my master build on my notebook after about two weeks and the build hanged in sal when I did *not* unset LANG/LC_ALL. First I bisected it: [...] Does this ring any bell? I tried to revert

Re: [Libreoffice] --enable-werror

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 10:33 AM, Michael Meeks wrote: On Tue, 2011-09-27 at 10:06 +0530, Marc-André Laverdière wrote: When I tried using this flag, I ended up not being able to _build_ at all. And that wasn't even due to my own mistake, only some module I know nothing at all is breaking the build.

Re: [Libreoffice] per-library types headers ...

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 01:24 PM, Noel Grandin wrote: (1) Nice pragma trick for making this problem show up at compile time: http://stackoverflow.com/questions/74326/how-should-i-detect-unnecessary-include-files-in-a-large-c-project/109890#109890 This would flag double includes that are there for good

Re: [Libreoffice] per-library types headers ...

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 10:55 AM, Michael Meeks wrote: I'm still a tad annoyed by our compile times, and was wondering - has a footypes.hxx header approach been tried in the past. This would add a near complete set of forward declarations of classes, templates, etc. necessary to use that library.

Re: [Libreoffice] --enable-werror

2011-09-27 Thread Stephan Bergmann
On 09/26/2011 08:41 AM, Stephan Bergmann wrote: Just a friendly reminder that all developers should use --enable-werror all the time. I wasn't aware that this might come across negatively, arrogantly, dictatorial, or something like that. Hope I didn't put off too many people. I had

[Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-09-27 Thread Stephan Bergmann
Hi all, As has recently been discussed on #libreoffice-dev, its probably a good idea to remove the rather unhelpful conversion operators rtl::OString::operator sal_Char const * () rtl::OStringBuffer::operator sal_Char const * () rtl::OUString::operator sal_Unicode const * ()

Re: [Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 09:07 PM, Caolán McNamara wrote: On Tue, 2011-09-27 at 21:00 +0200, Stephan Bergmann wrote: introduce the operator [] replacements. Any reason, we make operator[] const ?, i.e. unassignable. plenty of code out there using operator[] to get a given index, and setCharAt to set

Re: [Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 09:21 PM, Stephan Bergmann wrote: (Note that my commits just broke various tinderboxes due to some GCCs apparently complaining about alleged ambiguities in a+=b when a is a tools String and b an rtl::OUString; fixing it right now.) Hopefully fixed now with http

Re: [Libreoffice] subsequenttest hang ...

2011-09-28 Thread Stephan Bergmann
On 09/28/2011 02:01 AM, Norbert Thiebaud wrote: (1) it occurred to me that this French expression may not translate well. a surveiller comme du lait sur le feux means to keep close and attentive watch... milk being notorious -- when it start boiling -- for quickly overflowing the pot. That

Re: [Libreoffice] unit-test / code sharing ...

2011-09-28 Thread Stephan Bergmann
On 09/28/2011 11:27 AM, Caolán McNamara wrote: On Wed, 2011-09-28 at 09:46 +0100, Michael Meeks wrote: Reading the various cppunit tests we have and the code cut/paste going on gives some concern. We need a place to share most of this really bootstrap UNO heavy lifting and the various other

Re: [Libreoffice] unit-test / code sharing ...

2011-09-28 Thread Stephan Bergmann
On 09/28/2011 10:46 AM, Michael Meeks wrote: Incidentally, while trying to get some StarBasic / VBA unit tests working with Moggi, it seemed that some of our hangs were down to dialogs showing up that were simply not visible, and spinning the mainloop waiting for a response. static void

Re: [Libreoffice] New Config Variable in Impress

2011-09-29 Thread Stephan Bergmann
On 09/28/2011 11:00 PM, Rob Snelders wrote: I'm looking into bug fdo#35973. But I have trouble finding out how I can add config-variables for Impress. Can anybody give me any pointers? The configuration data is in module officecfg. There you have schema (.xcs) files describing the static

Re: [Libreoffice] need help with feature/gbuild

2011-09-29 Thread Stephan Bergmann
On 09/29/2011 01:04 AM, Matúš Kukan wrote: I have recreated feature/gbuild branch. I'm gbuildizing sal, salhelper, cppu and cppuhelper there. It's almost done but there are few problems. In odk I'm getting: check cpp docu: + ERROR:

Re: [Libreoffice] 14 files in libreoffice git source flagged as trojans

2011-09-30 Thread Stephan Bergmann
On 09/29/2011 10:52 PM, Billy Charlton wrote: After the clone completed, MS Security Essentials popped up with nine severe trojans and exploits. The affected files are .doc, .rtf, and .wmf -- which would be the places that Windows viruses and trojans would indeed hide. I have no way of knowing

Re: [Libreoffice] MinGW cross-compilation: Runs!

2011-09-30 Thread Stephan Bergmann
On 09/29/2011 11:18 PM, Jan Holesovsky wrote: Based on Tor's, Fridrich's, and others great work, I was able to get the MinGW cross-compilation to state that it not only builds, but even runs! :-) The good thing about all this is that with this, you do not need a Windows machine at all to be

Re: [Libreoffice] cppunit test and smoketest failures

2011-10-04 Thread Stephan Bergmann
On 10/02/2011 08:49 PM, Peter Foley wrote: : LD_LIBRARY_PATH=/root/libreoffice/smoketestoo_native/unxlngx6.pro/lib:/root/libreoffice/solver/unxlngx6.pro/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}} /root/libreoffice/solver/unxlngx6.pro/bin/cppunit/cppunittester \

Re: [Libreoffice] ExternalLib.mk rpath gotchas

2011-10-04 Thread Stephan Bergmann
On 10/03/2011 12:45 PM, Caolán McNamara wrote: A better solution might be to put a stock libtool into our tree, patch it to smuggle the correct gb_LinkTarget__RPATHS entry into the link line, and then always copy our patched libtool over preexisting libtools when we unpack external tarballs in

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-04 Thread Stephan Bergmann
On 10/03/2011 04:48 PM, Chr. Rossmanith wrote: One improvement suggested by Norbert on IRC: using OUString instead of ::rtl::OUString. What is the preferred syntax using ::rtl::OUString at the beginning of the file and OUString throughout the remaining source code or ::rtl::OUString

Re: [Libreoffice] ODBC handles, a quibble

2011-10-04 Thread Stephan Bergmann
On 10/04/2011 06:27 PM, Terrence Enger wrote: (*) In the hope of attracting critical feedback (but constructive, of course: this is after all LibreOffice grin /), I sprinkled the code liberally with questions and comments. Most conspicuously, - I cite the X/Open reference

Re: [Libreoffice] [Libreoffice-commits] .: stoc/source

2011-10-04 Thread Stephan Bergmann
On 10/04/2011 07:11 PM, Kevin Hunter wrote: At 9:33am -0400 Mon, 03 Oct 2011, Tor Lillqvist wrote: stoc/source/inspect/introspection.cxx | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit 9e6d06a871b366cc72f9a23ab45080b66a47f144 Making my way through a backlog

Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source

2011-10-05 Thread Stephan Bergmann
On 10/04/2011 11:01 PM, Kevin Hunter wrote: At 4:15pm -0400 Tue, 04 Oct 2011, Stephan Bergmann wrote: Thanks a lot for the patch. I think the real intent always was to actually look through all the returned getSuperclasses(), and the error that superclasses past the first one are effectively

Re: [Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-10-05 Thread Stephan Bergmann
On 09/27/2011 09:00 PM, Stephan Bergmann wrote: Hi all, As has recently been discussed on #libreoffice-dev, its probably a good idea to remove the rather unhelpful conversion operators rtl::OString::operator sal_Char const * () rtl::OStringBuffer::operator sal_Char const * () rtl::OUString

Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source

2011-10-05 Thread Stephan Bergmann
On 10/05/2011 09:13 AM, Kevin Hunter wrote: At 2:58am -0400 Wed, 05 Oct 2011, Stephan Bergmann wrote: On 10/04/2011 11:01 PM, Kevin Hunter wrote: Here is a second patch that compiles, /should/ respond to what you just confirmed was the original intent, but is untested. (It was a random drive

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-06 Thread Stephan Bergmann
On 10/05/2011 10:11 PM, Michael Stahl wrote: On 05.10.2011 22:02, Maciej Rumianowski wrote: Dnia 2011-10-05, śro o godzinie 17:35 +0200, Lubos Lunak pisze: On Wednesday 05 of October 2011, Jan Holesovsky wrote: That would allow you to convert the pO-GetData() to something like po-data(),

<    5   6   7   8   9   10   11   12   13   14   >