core.git: Branch 'libreoffice-24-2' - sc/uiconfig
sc/uiconfig/scalc/ui/conditionalentry.ui | 343 ++- 1 file changed, 160 insertions(+), 183 deletions(-) New commits: commit 32f7ef29615b25e91a73fe33632bb3b7ca506d04 Author: Heiko Tietze AuthorDate: Wed Apr 24 11:38:51 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Wed Apr 24 21:48:39 2024 +0200 Resolves tdf#159569 - Conditional Formatting dialog jumps with message string Some defined width solves the issue Change-Id: I1f92815e690828e283c275a58a71dd07613642fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166579 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit 9d29a2a6aad679129218ab4c5020c92bb3ce9cb3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166520 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sc/uiconfig/scalc/ui/conditionalentry.ui b/sc/uiconfig/scalc/ui/conditionalentry.ui index 1ff40d10460f..6e40f6cc6acc 100644 --- a/sc/uiconfig/scalc/ui/conditionalentry.ui +++ b/sc/uiconfig/scalc/ui/conditionalentry.ui @@ -1,216 +1,217 @@ - + True -True +True True -never -never -in +never +never +in True -False +False True - + True -False +False True -6 -6 -12 +6 +6 +12 - + True -False +False True -12 +12 True -False +False -0 -0 +0 +0 -10 +10 True -False +False True end -1 -0 +1 +0 -0 -0 +0 +0 - + True -False +False True -6 -12 -True +6 +12 +True -False -True +False +True Apply Style: -True -style +True +style 0 -0 -2 +0 +2 -False -True +False +True New Style... -1 -2 +1 +2 -False -True +100 +False +True Enter a value: 0 -0 -3 +0 +3 3 -True -True +True +True +True True -True -0 -4 +0 +4 -True -True +True +True +True True -True -1 -4 +1 +4 -True -True +True +True
Minutes from the UX/design meeting 2023-Apr-24
Present: Cor, Sahil, John, Ring, Heiko Comments: Stephane, Eyal, Stuart Tickets/Topics * Bullets and Numbering dialog in Writer does not say it's about an implicit list style + https://bugs.documentfoundation.org/show_bug.cgi?id=160629 + list styles created and applied via toolbar are hard to identify as such in the B dialog + no label substitutes the need to learn how this works; we may drop all shortcuts and ease functions but the cost is too high (Heiko, Cor) => suggest WF * Want indication of whether a master slide is in use or not + https://bugs.documentfoundation.org/show_bug.cgi?id=160403 + MSO Powerpoints shows the number of slides in a tooltip (Stephane) + additional boolean indication would be nice (Eyal) + tooltip sounds good and is not harmful (John) + not much useful since "Delete Master" is only available if the slide master is not in use (Cor) => no objection, low priority * When right-clicking a font family combo-box, offer font meta-data + https://bugs.documentfoundation.org/show_bug.cgi?id=152487 + unclear use case and much likely off-topic being available in font management tools (Heiko) + info dialog sounds good but rather via special characters or in the character properties dialog (Stuart) + only use case is compatibility with some other font (John) + likely not part of the meta data + the Internet returns all search results (Cor) => idea does not find support; WF * Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable independently with user-defined hotkeys per each file + https://bugs.documentfoundation.org/show_bug.cgi?id=160242 + start Impress twice (Stephane), workflow is supported with a third monitor (John) + too niche, better suited for an extension (Stephane, Sahil) => WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Apr-24
Present: Cor, Sahil, John, Ring, Heiko Comments: Stephane, Eyal, Stuart Tickets/Topics * Bullets and Numbering dialog in Writer does not say it's about an implicit list style + https://bugs.documentfoundation.org/show_bug.cgi?id=160629 + list styles created and applied via toolbar are hard to identify as such in the B dialog + no label substitutes the need to learn how this works; we may drop all shortcuts and ease functions but the cost is too high (Heiko, Cor) => suggest WF * Want indication of whether a master slide is in use or not + https://bugs.documentfoundation.org/show_bug.cgi?id=160403 + MSO Powerpoints shows the number of slides in a tooltip (Stephane) + additional boolean indication would be nice (Eyal) + tooltip sounds good and is not harmful (John) + not much useful since "Delete Master" is only available if the slide master is not in use (Cor) => no objection, low priority * When right-clicking a font family combo-box, offer font meta-data + https://bugs.documentfoundation.org/show_bug.cgi?id=152487 + unclear use case and much likely off-topic being available in font management tools (Heiko) + info dialog sounds good but rather via special characters or in the character properties dialog (Stuart) + only use case is compatibility with some other font (John) + likely not part of the meta data + the Internet returns all search results (Cor) => idea does not find support; WF * Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable independently with user-defined hotkeys per each file + https://bugs.documentfoundation.org/show_bug.cgi?id=160242 + start Impress twice (Stephane), workflow is supported with a third monitor (John) + too niche, better suited for an extension (Stephane, Sahil) => WF OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sw/qa sw/source sw/uiconfig
sw/qa/uitest/writer_tests2/formatCharacter.py | 47 -
sw/source/ui/chrdlg/chardlg.cxx | 211 --
sw/source/uibase/inc/chrdlg.hxx | 30 ---
sw/uiconfig/swriter/ui/characterproperties.ui | 30 ---
4 files changed, 3 insertions(+), 315 deletions(-)
New commits:
commit 63315d601296f7c188e920f73b12260d018807d0
Author: Heiko Tietze
AuthorDate: Tue Apr 23 17:20:47 2024 +0200
Commit: Heiko Tietze
CommitDate: Wed Apr 24 16:13:15 2024 +0200
Resolves tdf#132253 - Remove hyperlink tab from character dialog
Change-Id: Idb7fa74dbe196262cea64946452043f7de6fa20c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166553
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/qa/uitest/writer_tests2/formatCharacter.py
b/sw/qa/uitest/writer_tests2/formatCharacter.py
index 265f7b4df92e..724b8813029e 100644
--- a/sw/qa/uitest/writer_tests2/formatCharacter.py
+++ b/sw/qa/uitest/writer_tests2/formatCharacter.py
@@ -65,8 +65,6 @@ class formatCharacter(UITestCase):
xLangFontCTL = xDialog.getChild("cbCTLLanguage")
self.assertEqual(get_state_as_dict(xLangFontCTL)["Text"],
"[None]")
-
-
def test_format_character_tab_font_effects(self):
with self.ui_test.create_doc_in_start_center("writer"):
@@ -115,47 +113,6 @@ class formatCharacter(UITestCase):
self.assertEqual(get_state_as_dict(xEmphasis)["SelectEntryText"], "Dot")
self.assertEqual(get_state_as_dict(xPosition)["SelectEntryText"], "Below text")
-
-
- def test_format_character_tab_hyperlink(self):
-with self.ui_test.create_doc_in_start_center("writer") as document:
-
-with
self.ui_test.execute_dialog_through_command(".uno:FontDialog") as xDialog:
-xTabs = xDialog.getChild("tabcontrol")
-select_pos(xTabs, "4")
-
-xURL = xDialog.getChild("urled")
-xURL.executeAction("TYPE",
mkPropertyValues({"TEXT":"libreoffice.org"}))
-xTexted = xDialog.getChild("texted")
-xTexted.executeAction("TYPE",
mkPropertyValues({"TEXT":"LibreOffice"}))
-xName = xDialog.getChild("nameed")
-xName.executeAction("TYPE",
mkPropertyValues({"TEXT":"hyperlink"}))
-
-xVisited = xDialog.getChild("visitedlb")
-select_by_text(xVisited, "Bullets")
-xUnVisited = xDialog.getChild("unvisitedlb")
-select_by_text(xUnVisited, "Bullets")
-
-
-self.xUITest.executeCommand(".uno:GoLeft")
-self.assertEqual(document.Text.String[0:11], "LibreOffice")
-
-with
self.ui_test.execute_dialog_through_command(".uno:FontDialog",
close_button="cancel") as xDialog:
-xTabs = xDialog.getChild("tabcontrol")
-select_pos(xTabs, "4")
-xURL = xDialog.getChild("urled")
-xTexted = xDialog.getChild("texted")
-xName = xDialog.getChild("nameed")
-xVisited = xDialog.getChild("visitedlb")
-xUnVisited = xDialog.getChild("unvisitedlb")
-
-self.assertEqual(get_state_as_dict(xURL)["Text"],
"http://libreoffice.org/;)
-self.assertEqual(get_state_as_dict(xTexted)["Text"],
"LibreOffice")
-self.assertEqual(get_state_as_dict(xName)["Text"], "hyperlink")
-
self.assertEqual(get_state_as_dict(xVisited)["SelectEntryText"], "Bullets")
-
self.assertEqual(get_state_as_dict(xUnVisited)["SelectEntryText"], "Bullets")
-
-
def test_format_character_tab_asian_layout(self):
with self.ui_test.create_doc_in_start_center("writer"):
@@ -221,8 +178,6 @@ class formatCharacter(UITestCase):
self.assertEqual(get_state_as_dict(xFitToLine)["Selected"],
"true")
self.assertEqual(get_state_as_dict(xNoHyphenation)["Selected"], "true")
-
-
def test_format_character_tab_position_scalewidthsb(self):
with self.ui_test.create_doc_in_start_center("writer"):
@@ -240,6 +195,4 @@ class formatCharacter(UITestCase):
xScalewidth = xDialog.getChild("scalewidthsb")
self.assertEqual(get_state_as_dict(xScalewidth)["Text"],
"101%")
-
-
# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/s
core.git: sc/uiconfig
sc/uiconfig/scalc/ui/conditionalentry.ui | 343 ++- 1 file changed, 160 insertions(+), 183 deletions(-) New commits: commit 9d29a2a6aad679129218ab4c5020c92bb3ce9cb3 Author: Heiko Tietze AuthorDate: Wed Apr 24 11:38:51 2024 +0200 Commit: Heiko Tietze CommitDate: Wed Apr 24 14:58:11 2024 +0200 Resolves tdf#159569 - Conditional Formatting dialog jumps with message string Some defined width solves the issue Change-Id: I1f92815e690828e283c275a58a71dd07613642fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166579 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/sc/uiconfig/scalc/ui/conditionalentry.ui b/sc/uiconfig/scalc/ui/conditionalentry.ui index 1ff40d10460f..6e40f6cc6acc 100644 --- a/sc/uiconfig/scalc/ui/conditionalentry.ui +++ b/sc/uiconfig/scalc/ui/conditionalentry.ui @@ -1,216 +1,217 @@ - + True -True +True True -never -never -in +never +never +in True -False +False True - + True -False +False True -6 -6 -12 +6 +6 +12 - + True -False +False True -12 +12 True -False +False -0 -0 +0 +0 -10 +10 True -False +False True end -1 -0 +1 +0 -0 -0 +0 +0 - + True -False +False True -6 -12 -True +6 +12 +True -False -True +False +True Apply Style: -True -style +True +style 0 -0 -2 +0 +2 -False -True +False +True New Style... -1 -2 +1 +2 -False -True +100 +False +True Enter a value: 0 -0 -3 +0 +3 3 -True -True +True +True +True True -True -0 -4 +0 +4 -True -True +True +True +True True -True -1 -4 +1 +4 -True -True +True +True +True True -True -2 -4 +2 +4
core.git: sw/uiconfig
sw/uiconfig/swriter/ui/characterproperties.ui | 272 -- 1 file changed, 50 insertions(+), 222 deletions(-) New commits: commit e60ded9773673c356a88fa02867cb3692ee74c87 Author: Heiko Tietze AuthorDate: Tue Apr 23 16:42:56 2024 +0200 Commit: Heiko Tietze CommitDate: Wed Apr 24 11:48:28 2024 +0200 Bump Glade version Change-Id: I53c7c6cab10663b50391a45c18e09dc3e81c87cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166546 Reviewed-by: Heiko Tietze Tested-by: Jenkins diff --git a/sw/uiconfig/swriter/ui/characterproperties.ui b/sw/uiconfig/swriter/ui/characterproperties.ui index 1ba9823a1c74..414edb773b86 100644 --- a/sw/uiconfig/swriter/ui/characterproperties.ui +++ b/sw/uiconfig/swriter/ui/characterproperties.ui @@ -1,36 +1,33 @@ - + -False -False -6 +False +6 Character +False True -0 -0 -dialog - - - +0 +0 +dialog -False +False vertical 12 -False -end +False +end _Reset True -True -True +True +True +Unsaved modifications to this tab are reverted. True -Unsaved modifications to this tab are reverted. Revert any changes made on the tab shown here to the settings that were present when this dialog was opened. @@ -45,12 +42,11 @@ -_Standard -False -True -True -True -True +_Standard +True +True +True +True False @@ -62,10 +58,10 @@ _OK True -True -True -True -True +True +True +True +True True @@ -78,8 +74,8 @@ _Cancel True -True -True +True +True True @@ -92,8 +88,8 @@ _Help True -True -True +True +True True @@ -107,47 +103,23 @@ False True -end +end 0 True -True +True True True True -True +True True -False - - - - - - - - - - - - - - - - - - - - - - - - +False @@ -156,42 +128,18 @@ True -False +False Font -False +False True -False - - - - - - - - - - - - - - - - - - - - - - - - +False @@ -203,43 +151,19 @@ True -False +False Font Effects 1 -False +False True -False
core.git: svx/uiconfig
svx/uiconfig/ui/themecoloreditdialog.ui |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 8f3a19ce3a2dea548f644a8925bfe0718424ac21 Author: Heiko Tietze AuthorDate: Tue Apr 23 15:45:20 2024 +0200 Commit: Heiko Tietze CommitDate: Tue Apr 23 17:22:12 2024 +0200 Resolves tdf#160050 - Overlapping controls in 'add themes' dialog Change-Id: I196ef4b445dcae5d6fc9891c8f9c0d0b2976d583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166541 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/svx/uiconfig/ui/themecoloreditdialog.ui b/svx/uiconfig/ui/themecoloreditdialog.ui index 96276093a75a..ac0114ab4be1 100644 --- a/svx/uiconfig/ui/themecoloreditdialog.ui +++ b/svx/uiconfig/ui/themecoloreditdialog.ui @@ -3,13 +3,12 @@ -400 -300 False True True 6 Theme Color Edit +False True dialog
core.git: sw/source
sw/source/core/text/inftxt.cxx| 90 +++---
sw/source/uibase/uiview/view0.cxx |6 --
2 files changed, 47 insertions(+), 49 deletions(-)
New commits:
commit b79e0dd7fc8bc620420ed65edbc105eec3648b34
Author: Heiko Tietze
AuthorDate: Fri Apr 12 15:26:41 2024 +0200
Commit: Heiko Tietze
CommitDate: Sun Apr 21 12:40:23 2024 +0200
Resolves tdf#58434 - Show formatting marks independently from fields
Field Shading / .uno:Marks toggles now only fields, footnotes, tox etc.
and Tab, SoftHyphen, Blank, as well as ControlChar depends now on
Formatting Marks / .uno:ControlCodes. Field Shading also does not
toggle HardBlank and SoftHyphen, and what control character is shown
respect the options under Formatting Aids
Change-Id: I63c826e7fdc09ec95f17aee9735d4f5de9a1b897
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166033
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index 18ad3d1144e0..b293f18f824a 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -1407,54 +1407,56 @@ void SwTextPaintInfo::DrawViewOpt( const SwLinePortion
,
return;
bool bDraw = false;
-switch( nWhich )
-{
-case PortionType::Footnote:
-case PortionType::QuoVadis:
-case PortionType::Number:
-case PortionType::Field:
-case PortionType::Hidden:
-case PortionType::Tox:
-case PortionType::Ref:
-case PortionType::Meta:
-case PortionType::ContentControl:
-case PortionType::ControlChar:
-if ( !GetOpt().IsPagePreview()
- && !GetOpt().IsReadonly()
- && GetOpt().IsFieldShadings()
- && ( PortionType::Number != nWhich
- || m_pFrame->GetTextNodeForParaProps()->HasMarkedLabel()))
// #i27615#
-{
-bDraw = PortionType::Footnote != nWhich ||
m_pFrame->IsFootnoteAllowed();
-bDraw &= GetOpt().IsHardBlank();
-}
-break;
-case PortionType::Bookmark:
-// no shading
-break;
-case PortionType::InputField:
-// input field shading also in read-only mode
-if ( !GetOpt().IsPagePreview()
- && GetOpt().IsFieldShadings() )
-{
-bDraw = true;
-}
-break;
-case PortionType::Tab:
-if ( GetOpt().IsTab() ) bDraw = true;
-break;
-case PortionType::SoftHyphen:
-if ( GetOpt().IsSoftHyph() )bDraw = true;
-break;
-case PortionType::Blank:
-if ( GetOpt().IsHardBlank())bDraw = true;
-break;
-default:
+if ( !GetOpt().IsPagePreview()
+ && !GetOpt().IsReadonly() )
+{
+switch( nWhich )
{
-OSL_ENSURE( false, "SwTextPaintInfo::DrawViewOpt: don't know how
to draw this" );
+case PortionType::Tab:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = GetOpt().IsTab();
+break;
+case PortionType::SoftHyphen:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = GetOpt().IsSoftHyph();
break;
+case PortionType::Blank:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = GetOpt().IsHardBlank();
+break;
+case PortionType::ControlChar:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = true;
+break;
+case PortionType::Bookmark:
+// no shading
+break;
+case PortionType::Footnote:
+case PortionType::QuoVadis:
+case PortionType::Number:
+case PortionType::Hidden:
+case PortionType::Tox:
+case PortionType::Ref:
+case PortionType::Meta:
+case PortionType::ContentControl:
+case PortionType::Field:
+case PortionType::InputField:
+// input field shading also in read-only mode
+if (GetOpt().IsFieldShadings()
+&& ( PortionType::Number != nWhich
+|| m_pFrame->GetTextNodeForParaProps()->HasMarkedLabel()))
// #i27615#
+{
+bDraw = PortionType::Footnote != nWhich ||
m_pFrame->IsFootnoteAllowed();
+}
+break;
+default:
+{
+OSL_ENSURE( false, "SwTextPaintInfo::DrawViewOpt: don't know
how to draw this" );
+break;
+}
}
}
+
if ( bDraw )
DrawBackground( rPor, pColor );
}
diff --git a/sw/source/uibase/uiview/view0.cxx
b/sw/source/uibase/uiview/view0.cxx
index 70c9882e0d2e..488b32cc5fee 100644
--- a/sw/source/uibase/uiview/view0.cxx
+++ b/sw/source/uibase/uiview/view0.cxx
@@ -128,14 +128,10 @@ std::shared_ptr const &
SwView::GetMailMergeConfigItem()
static bool lcl_IsViewMarks( co
Minutes from the UX/design meeting 2023-Apr-18
Present: Hossein, Sahil, ring, Heiko Comments: Ady, Brian, Cor, Eyal, Rafael, Jeff, Stephane Tickets/Topics * Calc: default anchor everything to CELL + https://bugs.documentfoundation.org/show_bug.cgi?id=160452 + change default needs to have good reasons (Heiko) + add option to define the default is over-engineering (Heiko) + behavior my have changed in the past (Hossein) => resolve WF; suggest to change the topic into "remember last setting" * When opening Advanced filter dialog the "From" field should be filled with the address of current selection + https://bugs.documentfoundation.org/show_bug.cgi?id=150937 + reasonable request (Ady) + confusing label "Read Filter Criteria From" (Ady) + more common label is possible, eg. "Select Range" but unlikely to be more clear (Heiko) + prefilling data does not harm (Hossein, Heiko) => go for it * Using clone formatting enables scrolling with the mouse -- but it shouldn't + https://bugs.documentfoundation.org/show_bug.cgi?id=99608 + "issue" happens only when moving slowly from top, where moving the cursor on top makes sense + smooth scrolling rather than to jump to a certain position could be a solution (Hossein) => suggest to duplicate with 46988 * Turn on "Range contains column labels" by default + https://bugs.documentfoundation.org/show_bug.cgi?id=150027 + different scenarios, requires more intelligent function (Brian) + remember last user choice for this option (Eyal) + controls got moved to the same tab for bug 131155 (Heiko) + option is checked if header-like data is detected (Cor) + apparently only on Windows, on Linux the last settings are remembered + the dialog has always stored the last settings, unclear report (Cor) => keep the smart functionality, resolve invalid * Add timer/clock to single-screen presentation + https://bugs.documentfoundation.org/show_bug.cgi?id=160227 + makes sense (Rafael) + unclear why the timer needs to be shown for the audience + presenter console uses own class/control + neither available in Excel, feature would lack compatibility => resolve WF in favor of 3rd party extension/macro * Right-clicking to select an always-shown comment in Calc "clicks through" and selects the cell behind it + https://bugs.documentfoundation.org/show_bug.cgi?id=160290 + to hide the object first requires additional clicks (Ady) + it's not necessary to hide the comment, one can move it easily (Sahil) + right click to select is not common interaction (Heiko) + respect the z-order (Jeff, Stephane, Heiko, Hossein) => do as requested OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Apr-18
Present: Hossein, Sahil, ring, Heiko Comments: Ady, Brian, Cor, Eyal, Rafael, Jeff, Stephane Tickets/Topics * Calc: default anchor everything to CELL + https://bugs.documentfoundation.org/show_bug.cgi?id=160452 + change default needs to have good reasons (Heiko) + add option to define the default is over-engineering (Heiko) + behavior my have changed in the past (Hossein) => resolve WF; suggest to change the topic into "remember last setting" * When opening Advanced filter dialog the "From" field should be filled with the address of current selection + https://bugs.documentfoundation.org/show_bug.cgi?id=150937 + reasonable request (Ady) + confusing label "Read Filter Criteria From" (Ady) + more common label is possible, eg. "Select Range" but unlikely to be more clear (Heiko) + prefilling data does not harm (Hossein, Heiko) => go for it * Using clone formatting enables scrolling with the mouse -- but it shouldn't + https://bugs.documentfoundation.org/show_bug.cgi?id=99608 + "issue" happens only when moving slowly from top, where moving the cursor on top makes sense + smooth scrolling rather than to jump to a certain position could be a solution (Hossein) => suggest to duplicate with 46988 * Turn on "Range contains column labels" by default + https://bugs.documentfoundation.org/show_bug.cgi?id=150027 + different scenarios, requires more intelligent function (Brian) + remember last user choice for this option (Eyal) + controls got moved to the same tab for bug 131155 (Heiko) + option is checked if header-like data is detected (Cor) + apparently only on Windows, on Linux the last settings are remembered + the dialog has always stored the last settings, unclear report (Cor) => keep the smart functionality, resolve invalid * Add timer/clock to single-screen presentation + https://bugs.documentfoundation.org/show_bug.cgi?id=160227 + makes sense (Rafael) + unclear why the timer needs to be shown for the audience + presenter console uses own class/control + neither available in Excel, feature would lack compatibility => resolve WF in favor of 3rd party extension/macro * Right-clicking to select an always-shown comment in Calc "clicks through" and selects the cell behind it + https://bugs.documentfoundation.org/show_bug.cgi?id=160290 + to hide the object first requires additional clicks (Ady) + it's not necessary to hide the comment, one can move it easily (Sahil) + right click to select is not common interaction (Heiko) + respect the z-order (Jeff, Stephane, Heiko, Hossein) => do as requested OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: Branch 'libreoffice-7-6' - sw/source
sw/source/ui/index/swuiidxmrk.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 1bc57f8d02f7b9a2b4e5d16018ac06edce162688 Author: Heiko Tietze AuthorDate: Thu Apr 4 12:09:33 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Fri Apr 5 16:08:15 2024 +0200 Resolves tdf#154209 - Fixes resize issue in Index Entry dialog Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165724 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 140b4e48d0a0..3cca2d4011d2 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -440,6 +440,7 @@ IMPL_LINK_NOARG(SwIndexMarkPane, SyncSelectionHdl, weld::Button&, void) m_xApplyToAllCB->show(); m_xSearchCaseSensitiveCB->show(); m_xSearchCaseWordOnlyCB->show(); +m_xDialog->resize_to_request(); m_xApplyToAllCB->set_sensitive(!m_aOrgStr.isEmpty() && !(nFrameType & ( FrameTypeFlags::HEADER | FrameTypeFlags::FOOTER | FrameTypeFlags::FLY_ANY ))); SearchTypeHdl(*m_xApplyToAllCB);
core.git: Branch 'libreoffice-24-2' - sw/source
sw/source/ui/index/swuiidxmrk.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit d3871c6ac05bb9553aed1cc951ba18efcb06082a Author: Heiko Tietze AuthorDate: Thu Apr 4 12:09:33 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Fri Apr 5 08:02:19 2024 +0200 Resolves tdf#154209 - Fixes resize issue in Index Entry dialog Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165722 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 8a6f74b86ee8..03d5733a87ad 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -441,6 +441,7 @@ IMPL_LINK_NOARG(SwIndexMarkPane, SyncSelectionHdl, weld::Button&, void) m_xApplyToAllCB->show(); m_xSearchCaseSensitiveCB->show(); m_xSearchCaseWordOnlyCB->show(); +m_xDialog->resize_to_request(); m_xApplyToAllCB->set_sensitive(!m_aOrgStr.isEmpty() && !(nFrameType & ( FrameTypeFlags::HEADER | FrameTypeFlags::FOOTER | FrameTypeFlags::FLY_ANY ))); SearchTypeHdl(*m_xApplyToAllCB);
Minutes from the UX/design meeting 2023-Apr-04
Present: Felix, Cor, Hossein, Rafael, Heiko
Comments: Mike, Regina, Bogdan, Timur, Cor, Stephane
Tickets/Topics
* "Page number" automatic field stops counting before last page if offset >0
+ https://bugs.documentfoundation.org/show_bug.cgi?id=35694
+ help is clear on the function (Regina)
+ just a wording issue but rather introduce another field "page reference",
which would have the offset attribute (Mike, Regina)
+ comment 70 and 78 are wisdom; missing a good proposal (Cor)
+ compatibility is prime (Hossein)
+ neither prev/next nor offset are stored with docx
+ MSO offsets per field code like "{={PAGE}-10} of {={NUMPAGES}*20}"
showing "-9 of 80" (not stored as a field on saving as ODT)
+ offset for pagee count is via set variable > page + x (Heiko)
=> comment on ticket
* Replies to comment are in reverse order
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160350
+ chat-like order D, C, B, A (latest on top) vs. book style
A, B, C, D (latest at bottom) (Bogdan)
+ latest on top makes sense (Heiko)
+ current implementation shows comments on the place where they
are made, i.e. below the comment where one chooses: reply,
which makes sense to me (Cor)
+ all other applications do it book-like (Timur, Bogdan, Felix)
=> do it (consider an expert option)
* Add toolbar icons to change UI and scheme to switch Light/Dark
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160349
+ useful for tester and user (Rafael)
+ switching only tools > application colors via the new control (Rafael)
+ fixes fallout from bug 160445
+ strongly against adding rarely used functions to the primary UI,
options would also be hard-coded and not easy to remove later (Heiko)
+ MS has a "Switch Modes" option in the View ribbon (Hossein, Felix)
=> majority are for the option
* Pressing Tab with partially selected numbered paragraphs deletes content
instead of changing level
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160317
+ agree on the expectation (Stephane, Felix)
+ inconsistent with inserting a literal tab (Heiko)
+ compatibility is prime (Hossein)
+ tab overwrites in MSO; but tab on the first list item indents
the whole list anyway (only second increases the level we do)
+ literal tab is inserted on any position >0, ie. inside the text
+ otherwise the level for the whole selection is increased
+ always indent for selection over multiple paragraphs (Rafael, Felix)
+ current behavior depends on selection mode, ie. adding selection inserts
at the beginning while extend does on the end (Heiko)
=> majority agrees with the request
OpenPGP_signature.asc
Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Apr-04
Present: Felix, Cor, Hossein, Rafael, Heiko
Comments: Mike, Regina, Bogdan, Timur, Cor, Stephane
Tickets/Topics
* "Page number" automatic field stops counting before last page if offset >0
+ https://bugs.documentfoundation.org/show_bug.cgi?id=35694
+ help is clear on the function (Regina)
+ just a wording issue but rather introduce another field "page reference",
which would have the offset attribute (Mike, Regina)
+ comment 70 and 78 are wisdom; missing a good proposal (Cor)
+ compatibility is prime (Hossein)
+ neither prev/next nor offset are stored with docx
+ MSO offsets per field code like "{={PAGE}-10} of {={NUMPAGES}*20}"
showing "-9 of 80" (not stored as a field on saving as ODT)
+ offset for pagee count is via set variable > page + x (Heiko)
=> comment on ticket
* Replies to comment are in reverse order
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160350
+ chat-like order D, C, B, A (latest on top) vs. book style
A, B, C, D (latest at bottom) (Bogdan)
+ latest on top makes sense (Heiko)
+ current implementation shows comments on the place where they
are made, i.e. below the comment where one chooses: reply,
which makes sense to me (Cor)
+ all other applications do it book-like (Timur, Bogdan, Felix)
=> do it (consider an expert option)
* Add toolbar icons to change UI and scheme to switch Light/Dark
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160349
+ useful for tester and user (Rafael)
+ switching only tools > application colors via the new control (Rafael)
+ fixes fallout from bug 160445
+ strongly against adding rarely used functions to the primary UI,
options would also be hard-coded and not easy to remove later (Heiko)
+ MS has a "Switch Modes" option in the View ribbon (Hossein, Felix)
=> majority are for the option
* Pressing Tab with partially selected numbered paragraphs deletes content
instead of changing level
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160317
+ agree on the expectation (Stephane, Felix)
+ inconsistent with inserting a literal tab (Heiko)
+ compatibility is prime (Hossein)
+ tab overwrites in MSO; but tab on the first list item indents
the whole list anyway (only second increases the level we do)
+ literal tab is inserted on any position >0, ie. inside the text
+ otherwise the level for the whole selection is increased
+ always indent for selection over multiple paragraphs (Rafael, Felix)
+ current behavior depends on selection mode, ie. adding selection inserts
at the beginning while extend does on the end (Heiko)
=> majority agrees with the request
OpenPGP_signature.asc
Description: OpenPGP digital signature
core.git: sw/source
sw/source/ui/index/swuiidxmrk.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc Author: Heiko Tietze AuthorDate: Thu Apr 4 12:09:33 2024 +0200 Commit: Heiko Tietze CommitDate: Thu Apr 4 15:30:30 2024 +0200 Resolves tdf#154209 - Fixes resize issue in Index Entry dialog Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 6b6e9f10536f..2ca5d673712b 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -441,6 +441,7 @@ IMPL_LINK_NOARG(SwIndexMarkPane, SyncSelectionHdl, weld::Button&, void) m_xApplyToAllCB->show(); m_xSearchCaseSensitiveCB->show(); m_xSearchCaseWordOnlyCB->show(); +m_xDialog->resize_to_request(); m_xApplyToAllCB->set_sensitive(!m_aOrgStr.isEmpty() && !(nFrameType & ( FrameTypeFlags::HEADER | FrameTypeFlags::FOOTER | FrameTypeFlags::FLY_ANY ))); SearchTypeHdl(*m_xApplyToAllCB);
Re: error: this member function can be declared static [loplugin:staticmethods] when adding a event function in a dialog
On 28.03.24 6:09 PM, Caolán McNamara wrote: On Fri, 2024-03-29 at 00:16 +0800, Sakura286 wrote: https://gerrit.libreoffice.org/c/core/+/165391 You might want DECL_STATIC_LINK instead of DECL_LINK. The matching IMPL_LINK then needs to be IMPL_STATIC_LINK etc. Curious to learn why this needs to be static. What makes the one button different from the other? OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-27
Present: Sahil, Antonio, Cor, Bogdan, John, Eyal, Heiko Comments: Stephane, Stuart, Timur Tickets/Topics * A11Y sidebar: Too many issue reports about direct character formatting + https://bugs.documentfoundation.org/show_bug.cgi?id=159906 + group by paragraph (+ 0.5 Stephane) + maybe list per paragraph under one root node (Heiko, Antonio) + offer an action button (+1 Stephane, Heiko, -1 Stuart) + action is not necessarily to remove DF; could also be "Dismiss" (Cor) + could be a more complex UI with more interactions, filters, batch operations etc. (Sahil, Antonio) + could be done in a later patch (Cor) => let's go with the extra tree node per paragraph and maybe page too and no action button for now * Add all 3 Spotlight commands (PS, CS, DF) to Style Inspector + https://bugs.documentfoundation.org/show_bug.cgi?id=160194 + maybe per icon-only toggle button (Stephane) + agree with the proposal as it matches the workflow (Stuart) + clutters the UI and is not in scope of the workflow (Heiko) + it's not uncommon to have those buttons in the UIs (Cor, John) + neither a big improvement nor a huge impact on UX (John) + customization is sufficient (Antonio) => let's do it * Use "Delete unused master slides" independently from "Minimize Presentation" tool + https://bugs.documentfoundation.org/show_bug.cgi?id=159860 + warn in case of an excessive number of master slides + rather fix bug 158773 than alert user on some high number (Heiko) + MSO is loading quickly but still warns (Timur) + warning could offer to delete unused master slides (Antonio) + warning should happen on load; covers also issues with import from other applications (Antonio) + realize per infobar to not block the workflow (user may click away the confirmation box), OTOH depending on severity it should interrupt + label could be "You have an unreasonable number of unused slide master. [Clean Up] [x]" (Heiko) + hesitate to delete a lot of content with just a click, so - suggest a confirmation dialog when pressing cleanup (Eyal) + add a button "Inspect" to the infobar (Cor) + strongly disagree with different actions on the infobar (Heiko) + add Help button to educate the user (Antonio) => do so * MRU Recent files list entries numbered, no need to be + https://bugs.documentfoundation.org/show_bug.cgi?id=160230 + number seems to be useless (Bogdan) + actual date/time like MSO makes more sense (John) + handy for a11y resp. keyboard only access (Stuart,Antonio) + Alt+F + U + 1 opens the latest pinned item, for example + numbers above 10 take the first character from the filename + number indicates the recency (Eyal) + mnemonics inside the filename are hard to spot (Cor) + alternatively we could go with alphanumeric characters A..Z (Sahil) + this would require using different alphabeta in different localized UIs (Eyal) => no good argument to remove the numbers -> WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-27
Present: Sahil, Antonio, Cor, Bogdan, John, Eyal, Heiko Comments: Stephane, Stuart, Timur Tickets/Topics * A11Y sidebar: Too many issue reports about direct character formatting + https://bugs.documentfoundation.org/show_bug.cgi?id=159906 + group by paragraph (+ 0.5 Stephane) + maybe list per paragraph under one root node (Heiko, Antonio) + offer an action button (+1 Stephane, Heiko, -1 Stuart) + action is not necessarily to remove DF; could also be "Dismiss" (Cor) + could be a more complex UI with more interactions, filters, batch operations etc. (Sahil, Antonio) + could be done in a later patch (Cor) => let's go with the extra tree node per paragraph and maybe page too and no action button for now * Add all 3 Spotlight commands (PS, CS, DF) to Style Inspector + https://bugs.documentfoundation.org/show_bug.cgi?id=160194 + maybe per icon-only toggle button (Stephane) + agree with the proposal as it matches the workflow (Stuart) + clutters the UI and is not in scope of the workflow (Heiko) + it's not uncommon to have those buttons in the UIs (Cor, John) + neither a big improvement nor a huge impact on UX (John) + customization is sufficient (Antonio) => let's do it * Use "Delete unused master slides" independently from "Minimize Presentation" tool + https://bugs.documentfoundation.org/show_bug.cgi?id=159860 + warn in case of an excessive number of master slides + rather fix bug 158773 than alert user on some high number (Heiko) + MSO is loading quickly but still warns (Timur) + warning could offer to delete unused master slides (Antonio) + warning should happen on load; covers also issues with import from other applications (Antonio) + realize per infobar to not block the workflow (user may click away the confirmation box), OTOH depending on severity it should interrupt + label could be "You have an unreasonable number of unused slide master. [Clean Up] [x]" (Heiko) + hesitate to delete a lot of content with just a click, so - suggest a confirmation dialog when pressing cleanup (Eyal) + add a button "Inspect" to the infobar (Cor) + strongly disagree with different actions on the infobar (Heiko) + add Help button to educate the user (Antonio) => do so * MRU Recent files list entries numbered, no need to be + https://bugs.documentfoundation.org/show_bug.cgi?id=160230 + number seems to be useless (Bogdan) + actual date/time like MSO makes more sense (John) + handy for a11y resp. keyboard only access (Stuart,Antonio) + Alt+F + U + 1 opens the latest pinned item, for example + numbers above 10 take the first character from the filename + number indicates the recency (Eyal) + mnemonics inside the filename are hard to spot (Cor) + alternatively we could go with alphanumeric characters A..Z (Sahil) + this would require using different alphabeta in different localized UIs (Eyal) => no good argument to remove the numbers -> WF OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: cui/inc cui/Library_cui.mk cui/source cui/uiconfig cui/UIConfig_cui.mk desktop/source extras/source include/sfx2 include/unotools officecfg/registry Repository.mk sfx2/sdi sfx2/source vcl/Mo
Repository.mk |1 cui/Library_cui.mk |1 cui/UIConfig_cui.mk|1 cui/inc/whatsnew.hrc | 42 ++ cui/source/dialogs/whatsnew.cxx| 172 ++ cui/source/factory/dlgfact.cxx | 13 cui/source/factory/dlgfact.hxx |2 cui/source/inc/whatsnew.hxx| 75 cui/uiconfig/ui/whatsnewdialog.ui | 131 +++ desktop/source/app/app.cxx |2 extras/source/whatsnew/Community.png |binary extras/source/whatsnew/Configurability.png |binary extras/source/whatsnew/LibreOffice.gif |binary extras/source/whatsnew/ODF.png |binary extras/source/whatsnew/whatsnew1.png |binary include/sfx2/sfxdlg.hxx|2 include/sfx2/sfxsids.hrc |5 include/sfx2/strings.hrc |2 include/sfx2/viewfrm.hxx |1 include/unotools/VersionConfig.hxx | 24 - officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs |6 officecfg/registry/schema/org/openoffice/Setup.xcs |8 sfx2/sdi/appslots.sdi |4 sfx2/sdi/sfx.sdi | 16 sfx2/source/appl/appserv.cxx | 10 sfx2/source/dialog/infobar.cxx |2 sfx2/source/view/viewfrm.cxx | 43 +- vcl/Module_vcl.mk |1 vcl/Package_whatsnew.mk| 20 + 29 files changed, 533 insertions(+), 51 deletions(-) New commits: commit dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1 Author: Heiko Tietze AuthorDate: Thu Feb 22 12:56:01 2024 +0100 Commit: Heiko Tietze CommitDate: Wed Mar 27 09:41:44 2024 +0100 Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog To test the new dialog, change org.openoffice.Setup > Product > ooSetupLastVersion to some lesser value for the WhatsNew dialog or clear the entry for the Welcome version. Change-Id: Iec6de50edba0e5430e82f1db85e61d1e4501771d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163739 Reviewed-by: Michael Weghorn Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/Repository.mk b/Repository.mk index 5b60bd66cfcc..9317a29975df 100644 --- a/Repository.mk +++ b/Repository.mk @@ -925,6 +925,7 @@ $(eval $(call gb_Helper_register_packages_for_install,sdk,\ ifneq ($(ENABLE_WASM_STRIP_PINGUSER),TRUE) $(eval $(call gb_Helper_register_packages_for_install,ooo,\ tipoftheday_images \ + whatsnew_images \ )) endif diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk index e01e33ecb4ec..3ee744e32d0f 100644 --- a/cui/Library_cui.mk +++ b/cui/Library_cui.mk @@ -114,6 +114,7 @@ $(eval $(call gb_Library_add_exception_objects,cui,\ cui/source/customize/SvxNotebookbarConfigPage \ cui/source/customize/CustomNotebookbarGenerator \ cui/source/dialogs/about \ +cui/source/dialogs/whatsnew \ $(call gb_Helper_optional,EXTENSIONS, \ cui/source/dialogs/AdditionsDialog) \ cui/source/dialogs/colorpicker \ diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk index 10acd83c8c39..79ff7696a93a 100644 --- a/cui/UIConfig_cui.mk +++ b/cui/UIConfig_cui.mk @@ -18,6 +18,7 @@ endif ifneq ($(ENABLE_WASM_STRIP_PINGUSER),TRUE) $(eval $(call gb_UIConfig_add_uifiles,cui,\ cui/uiconfig/ui/tipofthedaydialog \ + cui/uiconfig/ui/whatsnewdialog \ )) endif diff --git a/cui/inc/whatsnew.hrc b/cui/inc/whatsnew.hrc new file mode 100644 index ..e155a597bcf2 --- /dev/null +++ b/cui/inc/whatsnew.hrc @@ -0,0 +1,42 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#pragma once + +#define NC_(Context, String) TranslateId(Context, u8##String) + +#include +#include +#include +#include + +/* + * std:tuple consists of + * image: + * place new images at extra/source/whatsnew + * do not forget to add the files to vcl/Package_whatsnew.mk + * images are cut-off at 600x400px +*/ + +const std::tuple WELCOME_STRIN
Re: Adding support for the Common Print Dialog Backends (CPDB)
On 26.03.24 6:26 PM, Till Kamppeter wrote: This requires changes on the print dialog: - List IPP print destinations, independent whether there is a CUPS queue for them or not (if not, CUPS would create a temporary queue) - Obtain printer capabilities and options via IPP, do not try to download the PPD file via CUPS or even try to directly access it in the file system. Our users are quite picky with the print dialog. Most of the redesign was done by Daniel Silva for GSoC 2019 with numerous follow-up, see https://bugs.documentfoundation.org/show_bug.cgi?id=103309. One of the discussion was whether the option to print odd/even pages from a range is important enough to be on the primary view (bug 127680). The CPDB does not have this option, as far I can see. OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: include/vcl sfx2/source vcl/source vcl/unx
include/vcl/settings.hxx |9 +
sfx2/source/dialog/infobar.cxx| 12 +++
vcl/source/app/salvtables.cxx |8 +++--
vcl/source/app/settings.cxx | 53 +-
vcl/unx/gtk3/gtkinst.cxx |4 +-
vcl/unx/gtk3/salnativewidgets-gtk.cxx |5 ---
6 files changed, 75 insertions(+), 16 deletions(-)
New commits:
commit d7fd378b533c42f51d1d363f5da30b1fa1281f67
Author: Heiko Tietze
AuthorDate: Fri Mar 22 12:58:07 2024 +0100
Commit: Heiko Tietze
CommitDate: Sat Mar 23 08:02:18 2024 +0100
Harmonization of warning and error colors
* hard-coded colors from infobar moved to settings
* weld::LabelType::Warning and ::Error uses these colors
* gtk3 native configuration removed
Change-Id: Ia80584e9267b8385f7f6b25322f5a85a2570af68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165161
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/include/vcl/settings.hxx b/include/vcl/settings.hxx
index 0787fe98b6cc..e21091385bc7 100644
--- a/include/vcl/settings.hxx
+++ b/include/vcl/settings.hxx
@@ -353,6 +353,15 @@ public:
voidSetWarningColor( const Color& rColor );
const Color&GetWarningColor() const;
+voidSetWarningTextColor( const Color& rColor );
+const Color&GetWarningTextColor() const;
+
+voidSetErrorColor( const Color& rColor );
+const Color&GetErrorColor() const;
+
+voidSetErrorTextColor( const Color& rColor );
+const Color&GetErrorTextColor() const;
+
voidSetHelpColor( const Color& rColor );
const Color&GetHelpColor() const;
diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx
index 38a510a2589c..26dfc0af26c0 100644
--- a/sfx2/source/dialog/infobar.cxx
+++ b/sfx2/source/dialog/infobar.cxx
@@ -44,6 +44,8 @@ void GetInfoBarColors(InfobarType ibType, BColor&
rBackgroundColor, BColor& rFor
{
rMessageColor = basegfx::BColor(0.0, 0.0, 0.0);
+const StyleSettings& rSettings =
Application::GetSettings().GetStyleSettings();
+
switch (ibType)
{
case InfobarType::INFO: // blue; #004785/0,71,133; #BDE5F8/189,229,248
@@ -55,17 +57,15 @@ void GetInfoBarColors(InfobarType ibType, BColor&
rBackgroundColor, BColor& rFor
rForegroundColor = basegfx::BColor(0.196, 0.333, 0.047);
break;
case InfobarType::WARNING: // orange; #704300/112,67,0;
#FEEFB3/254,239,179
-rBackgroundColor = basegfx::BColor(0.996, 0.937, 0.702);
-rForegroundColor = basegfx::BColor(0.439, 0.263, 0.0);
+rBackgroundColor = rSettings.GetWarningColor().getBColor();
+rForegroundColor = rSettings.GetWarningTextColor().getBColor();
break;
case InfobarType::DANGER: // red; #7A0006/122,0,6; #FFBABA/255,186,186
-rBackgroundColor = basegfx::BColor(1.0, 0.729, 0.729);
-rForegroundColor = basegfx::BColor(0.478, 0.0, 0.024);
+rBackgroundColor = rSettings.GetErrorColor().getBColor();
+rForegroundColor = rSettings.GetErrorTextColor().getBColor();
break;
}
-//remove this?
-const StyleSettings& rSettings =
Application::GetSettings().GetStyleSettings();
if (rSettings.GetHighContrastMode())
{
rBackgroundColor = rSettings.GetLightColor().getBColor();
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 4469978be626..3f007783498d 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -5949,14 +5949,16 @@ void SalInstanceLabel::set_label_type(weld::LabelType
eType)
m_xLabel->SetControlBackground();
break;
case weld::LabelType::Warning:
-m_xLabel->SetControlForeground();
+m_xLabel->SetControlForeground(
+
m_xLabel->GetSettings().GetStyleSettings().GetWarningTextColor());
m_xLabel->SetControlBackground(
m_xLabel->GetSettings().GetStyleSettings().GetWarningColor());
break;
case weld::LabelType::Error:
-m_xLabel->SetControlForeground();
+m_xLabel->SetControlForeground(
+
m_xLabel->GetSettings().GetStyleSettings().GetErrorTextColor());
m_xLabel->SetControlBackground(
-
m_xLabel->GetSettings().GetStyleSettings().GetHighlightColor());
+m_xLabel->GetSettings().GetStyleSettings().GetErrorColor());
break;
case weld::LabelType::Title:
m_xLabel->SetControlForeground(
diff --git a/vcl/source/app/settings.cxx
core.git: sc/source
sc/source/ui/app/rfindlst.cxx | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 9c8b240e7cad6ef74e16ad83d45957737389aa90
Author: Heiko Tietze
AuthorDate: Thu Mar 21 11:50:40 2024 +0100
Commit: Heiko Tietze
CommitDate: Fri Mar 22 13:06:37 2024 +0100
Resolves tdf#160282 - Ranges references text colors for dark backgrounds
Change-Id: I3d3bb22302ad5016c962d606e80c2e9942301fbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165095
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sc/source/ui/app/rfindlst.cxx b/sc/source/ui/app/rfindlst.cxx
index ba17bf006ea1..be521f65dea8 100644
--- a/sc/source/ui/app/rfindlst.cxx
+++ b/sc/source/ui/app/rfindlst.cxx
@@ -20,18 +20,25 @@
#include
#include
#include
+#include
+#include
#define SC_RANGECOLORS 8
const Color aColNames[SC_RANGECOLORS] =
{ COL_LIGHTBLUE, COL_LIGHTRED, COL_LIGHTMAGENTA, COL_GREEN,
COL_BLUE, COL_RED, COL_MAGENTA, COL_BROWN };
+const Color aDarkColNames[SC_RANGECOLORS] =
+{ COL_LIGHTBLUE, COL_LIGHTRED, COL_LIGHTMAGENTA, COL_GREEN,
+Color(0xb4c7dc), Color(0xffa6a6), Color(0xffb66c), Color(0xafd095) };
//light blue/red/orange/green 3
+static bool bIsDark;
ScRangeFindList::ScRangeFindList(OUString aName) :
aDocName(std::move( aName )),
bHidden( false ),
nIndexColor( 0 )
{
+bIsDark =
SC_MOD()->GetColorConfig().GetColorValue(svtools::DOCCOLOR).nColor.IsDark();
}
Color ScRangeFindList::Insert( const ScRangeFindData )
@@ -48,7 +55,8 @@ Color ScRangeFindList::Insert( const ScRangeFindData )
Color ScRangeFindList::GetColorName( const size_t nIndex )
{
-return aColNames[nIndex % SC_RANGECOLORS];
+return bIsDark ? aDarkColNames[nIndex % SC_RANGECOLORS]
+ : aColNames[nIndex % SC_RANGECOLORS];
}
Color ScRangeFindList::FindColor( const ScRange& rRef, const size_t nIndex )
Minutes from the UX/design meeting 2023-Mar-21
Present: Sahil, Andres, Rhesa, Heiko Comments: Miguel, Ady, Eyal, Cor, Csongor, Eike, Laszlo Tickets/Topics * Hidden columns should not prevent text from preceding columns from overflowing over their cells + https://bugs.documentfoundation.org/show_bug.cgi?id=160011 + potentially breaks current workflow (Miguel) + could be done as (compatibility) flag (Ady) + afraid of performance issues (Ady) + support the request (Eyal, Cor, Sahil) + make it the default, and revert optionally (Sahil) + might be not so easy to find as compatibility flag but clutters the lengthy list of options under view on the other hand (Heiko) => do it * FORMATTING create a means to represent an integer as an IP Address + https://bugs.documentfoundation.org/show_bug.cgi?id=148184 + implement per function (Csongor) + solutions are spread over the Internet, https://superuser.com/questions/1764387/how-do-i-convert-an-ip-address-to-binary-representation-in-excel + https://www.browserling.com/tools/ip-to-dec + already have some number formatting types and another one would fit well (Eyal) + not simply one for all option considering IPv4/v6 (Heiko) + has a solution, if needed we should invest in the user-defined formatting (Sahil, Heiko) => resolve WF * AutoCorrect: Many symbol replacements should be defined for [All], not language-by-language, and work in [None] + https://bugs.documentfoundation.org/show_bug.cgi?id=153979 + extras/source/autocorr/*/DocumentList.xml entirely controlled by the local community (Heiko) + [None] means _no language tool processing at all_, [All] should be processed in all languages except [None] (Eike) + [All] would be useful, but only for a dozen of the replacements, but by moving we can lose educating the users (Laszlo) + adding a button to show only the items added by the user optionally (Laszlo) + adding some replacement to the [ALL] category makes it effective for paragraphs with language = None but not en_US, for example; apparently it's working for empty lists but not if the lang list has some content + if [All] items would be effective, users wont see those in their language depending list (Heiko) + if [All] has the same content as the actual language list it's unclear which one is used (eg. [All] --> = -> vs. [Hebrew] --> = <-) (Sahil) => remove [All] from the dropdown menu (at this tab), and make [None] none (Heiko) * personal / custom dictionaries should be easily portable + https://bugs.documentfoundation.org/show_bug.cgi?id=157981 + allow a dictionary to be saved as /.dic (Cor) + placing a dictionary (*.dic/aff) in some folder which is added via options > path to the dictionary locations does not make it available as writing aid; apparently it needs some registration + export/import could be a nice task for a macro (Heiko) + it's a generic use case for the majority of users and adding this to the core makes sense (Sahil) + if so, we could add export/import buttons to the options dialog (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-21
Present: Sahil, Andres, Rhesa, Heiko Comments: Miguel, Ady, Eyal, Cor, Csongor, Eike, Laszlo Tickets/Topics * Hidden columns should not prevent text from preceding columns from overflowing over their cells + https://bugs.documentfoundation.org/show_bug.cgi?id=160011 + potentially breaks current workflow (Miguel) + could be done as (compatibility) flag (Ady) + afraid of performance issues (Ady) + support the request (Eyal, Cor, Sahil) + make it the default, and revert optionally (Sahil) + might be not so easy to find as compatibility flag but clutters the lengthy list of options under view on the other hand (Heiko) => do it * FORMATTING create a means to represent an integer as an IP Address + https://bugs.documentfoundation.org/show_bug.cgi?id=148184 + implement per function (Csongor) + solutions are spread over the Internet, https://superuser.com/questions/1764387/how-do-i-convert-an-ip-address-to-binary-representation-in-excel + https://www.browserling.com/tools/ip-to-dec + already have some number formatting types and another one would fit well (Eyal) + not simply one for all option considering IPv4/v6 (Heiko) + has a solution, if needed we should invest in the user-defined formatting (Sahil, Heiko) => resolve WF * AutoCorrect: Many symbol replacements should be defined for [All], not language-by-language, and work in [None] + https://bugs.documentfoundation.org/show_bug.cgi?id=153979 + extras/source/autocorr/*/DocumentList.xml entirely controlled by the local community (Heiko) + [None] means _no language tool processing at all_, [All] should be processed in all languages except [None] (Eike) + [All] would be useful, but only for a dozen of the replacements, but by moving we can lose educating the users (Laszlo) + adding a button to show only the items added by the user optionally (Laszlo) + adding some replacement to the [ALL] category makes it effective for paragraphs with language = None but not en_US, for example; apparently it's working for empty lists but not if the lang list has some content + if [All] items would be effective, users wont see those in their language depending list (Heiko) + if [All] has the same content as the actual language list it's unclear which one is used (eg. [All] --> = -> vs. [Hebrew] --> = <-) (Sahil) => remove [All] from the dropdown menu (at this tab), and make [None] none (Heiko) * personal / custom dictionaries should be easily portable + https://bugs.documentfoundation.org/show_bug.cgi?id=157981 + allow a dictionary to be saved as /.dic (Cor) + placing a dictionary (*.dic/aff) in some folder which is added via options > path to the dictionary locations does not make it available as writing aid; apparently it needs some registration + export/import could be a nice task for a macro (Heiko) + it's a generic use case for the majority of users and adding this to the core makes sense (Sahil) + if so, we could add export/import buttons to the options dialog (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Re: [GSoC] Expressing interest in contributing to LibreOffice projects
Hi Mohit, thanks a lot for your interest in LibreOffice and in particular in topics around UI/UX. You should start with the requested easyhacks to prove your skills, see https://wiki.documentfoundation.org/Development/GSoC In case of questions don't hesitate to ask on IRC or this mailinglist. Looking forward your contributions, Heiko On 20.03.24 14:16, Mohit Marathe wrote: Dear LibreOffice community, Myself Mohit Marathe, a 3rd year undergraduate at Indian Institute of Technology (BHU), Varanasi and I want to express my interest in contributing to LibreOffice as a part of Google Summer of Code 2024. I have been a GSoC last year for the project: https://summerofcode.withgoogle.com/archive/2023/projects/z26bcE5j. I can see there are multiple projects in C++ in the Ideas page. Personally, I found **Improvement to the functions deck** and **Comments in sidebar** projects to be interesting. In case, if these two projects have already gotten a lot of response from other contributors, I would really appreciate it if you could recommend some other projects which didn't get much attention and which is at a high priority for the LibreOffice community. I have already build LibreOffice and read all the relevant documentation that will help me get started in contributing. Currently, I am working on some easy hacks, for which I'll be submitting patches soon. Best Regards, Mohit Marathe -- Dr. Heiko Tietze, UX-Designer and UX-Mentor Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: https://www.documentfoundation.org/imprint OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: cui/uiconfig
cui/uiconfig/ui/pickbulletpage.ui| 59 +--
cui/uiconfig/ui/pickgraphicpage.ui | 135 +++
cui/uiconfig/ui/picknumberingpage.ui | 59 +--
cui/uiconfig/ui/pickoutlinepage.ui | 59 +--
4 files changed, 118 insertions(+), 194 deletions(-)
New commits:
commit aacce8abe239ad679f5e9f9ce9bf2d27fb046d5d
Author: Heiko Tietze
AuthorDate: Wed Mar 13 09:40:51 2024 +0100
Commit: Heiko Tietze
CommitDate: Fri Mar 15 16:12:42 2024 +0100
Resolves tdf#160167 - Remove pointless frames in bullet & numbering dialog
Solves the issue that the "Selection" label is inappropriate
Change-Id: I1bdaa6922796fcdceec0aac6902011aa21cd9aa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164758
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/cui/uiconfig/ui/pickbulletpage.ui
b/cui/uiconfig/ui/pickbulletpage.ui
index b9749dda540e..589874506853 100644
--- a/cui/uiconfig/ui/pickbulletpage.ui
+++ b/cui/uiconfig/ui/pickbulletpage.ui
@@ -1,58 +1,39 @@
-
+
-
+
True
-False
+True
+6
+6
+6
+6
True
True
-6
-0
-none
+never
+never
+in
-
+
True
-True
-True
-True
-never
-never
-in
-12
-6
+False
-
+
True
-False
-
-
-True
-True
-GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
-True
-True
-
-
-Click the
bullet style that you want to use.
-
-
+True
+GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
+True
+True
+
+
+Click the
bullet style that you want to use.
-
-
-True
-False
-Selection
-
-
-
-
-
Displays the different
bullet styles that you can apply.
diff --git a/cui/uiconfig/ui/pickgraphicpage.ui
b/cui/uiconfig/ui/pickgraphicpage.ui
index fd7b9922e950..ea7342844a14 100644
--- a/cui/uiconfig/ui/pickgraphicpage.ui
+++ b/cui/uiconfig/ui/pickgraphicpage.ui
@@ -1,104 +1,85 @@
-
+
-
+
+
True
-False
+False
+6
+6
+6
+6
True
True
-6
-0
-none
+6
-
-
+
True
-False
+True
True
True
-6
-12
-6
+never
+in
-
+
True
-True
-True
-True
-never
-in
+False
-
+
True
-False
-
-
-True
-True
-GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
-True
-True
-
-
-Click the
graphics that you want to use as bullets.
-
-
+True
+GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
+True
+True
+
+
+Click the
graphics that you want to use as bullets.
-
-1
-0
-
-
-
-
-False
-True
-The Gallery theme 'Bullets' is empty (no
images).
-True
-
-
-0
-0
-
-
-
-
-Add and Resize
-True
-True
-False
-end
-
-
-1
-2
-
-
-
-
-
-
-
-
-
-
+
+1
+0
+
+
+
+
+False
+True
+The Gallery theme 'Bullets' is empty (no
images).
+True
+
+
+0
+0
+
-
-
+
+
+Add and Resize
True
-False
-Selection
-
-
-
+True
+False
+end
+
+
Minutes from the UX/design meeting 2023-Mar-13
Present: Sahil, Rafel, (John), Nameless, Heiko Comments: Bob, Cor, Mike, Eyal Tickets/Topics * Cannot resize graphical objects that overlap header/footer + https://bugs.documentfoundation.org/show_bug.cgi?id=159543 + change drag handles (Bob, Cor) + UI should give proper feedback (Sahil) + could be done by disabling the vertical and diagonal resize capability (which hides the size cursor then) + people may complain handles disappear; suggest NAB/WF (Rafael) + rather than hiding the handles we should block resizing before drag happens so the lower edge remains at the bottom (Rafael) + looks like a bug to me; suggest to show an infobar when the mouse is released but resize not accepted (Sahil) + infobar is disruptive here (Rafael) + change the drag frame color if the new size is not accepted/possible (Rafael) => do this * Changing Macro Security level should warn about the need to reload the file to apply the settings + https://bugs.documentfoundation.org/show_bug.cgi?id=159985 + Reload in the background for all documents is not possible since changes may have been made (Mike) + show infobar requesting the user to reload (Eyal) + show a label in the macros security option dialog (Rafael, Sahil) + could also be the restart now confirmation box (Heiko) => majority votes for the label * close all (documents / windows) Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=159380 + add new command but just for customization (Eyal, Rafael) + quit and restart (Cor) + close documents from all modules (Heiko) + alternatively show the start center while modules are open + closing all documents becomes more important if we have a tabbed UI (Sahil) => comment * Add max shrink and space width customization options to upcoming smart justification feature + https://bugs.documentfoundation.org/show_bug.cgi?id=159923 + as a compatibility feature any customization would deviate from DOCX (Heiko, Rafael, Nameless) + control on the paragraph level makes sense (Mike) + over-engineering is seldom good usability; no use case and no user request (yet) (Heiko) => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-13
Present: Sahil, Rafel, (John), Nameless, Heiko Comments: Bob, Cor, Mike, Eyal Tickets/Topics * Cannot resize graphical objects that overlap header/footer + https://bugs.documentfoundation.org/show_bug.cgi?id=159543 + change drag handles (Bob, Cor) + UI should give proper feedback (Sahil) + could be done by disabling the vertical and diagonal resize capability (which hides the size cursor then) + people may complain handles disappear; suggest NAB/WF (Rafael) + rather than hiding the handles we should block resizing before drag happens so the lower edge remains at the bottom (Rafael) + looks like a bug to me; suggest to show an infobar when the mouse is released but resize not accepted (Sahil) + infobar is disruptive here (Rafael) + change the drag frame color if the new size is not accepted/possible (Rafael) => do this * Changing Macro Security level should warn about the need to reload the file to apply the settings + https://bugs.documentfoundation.org/show_bug.cgi?id=159985 + Reload in the background for all documents is not possible since changes may have been made (Mike) + show infobar requesting the user to reload (Eyal) + show a label in the macros security option dialog (Rafael, Sahil) + could also be the restart now confirmation box (Heiko) => majority votes for the label * close all (documents / windows) Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=159380 + add new command but just for customization (Eyal, Rafael) + quit and restart (Cor) + close documents from all modules (Heiko) + alternatively show the start center while modules are open + closing all documents becomes more important if we have a tabbed UI (Sahil) => comment * Add max shrink and space width customization options to upcoming smart justification feature + https://bugs.documentfoundation.org/show_bug.cgi?id=159923 + as a compatibility feature any customization would deviate from DOCX (Heiko, Rafael, Nameless) + control on the paragraph level makes sense (Mike) + over-engineering is seldom good usability; no use case and no user request (yet) (Heiko) => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
Re: Digression from [libreoffice-design] Minutes from the UX/design meeting 2023-Mar-07
On 08.03.24 17:08, paul hofseth wrote: I repeat my resultless calling for concentration on overall function without crashing, rather than on small improvements to appearance and efficiency of use. We are many volunteers and not everyone is able to fix bugs. And I miss links to your bugreports where you have added the test documents. please do create a "life vest"- rescue button mode: which will enable users to copy existing text while waiting to shut it down...Ticket or nothing happened :-). But your idea sounds not like a solution but rather a and-aid. Besides, OpenOffice is ancient software with a lot of security holes. Perhaps you find something appropriate in our archive at https://downloadarchive.documentfoundation.org/libreoffice/old/ Cross-posting to mailing lists is not recommended. Just the QA list would have been enough - but Bugzilla is the better place to share issues and ideas anyway. OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-07
Present: Cor, Sahil, Felix, Rafael, Hossein, Heiko Comments: Stephane, Ady, Stuart Tickets/Topics * Auto-size the "Search Results" dialog (after a find & replace across multiple sheets) to avoid scrolling + https://bugs.documentfoundation.org/show_bug.cgi?id=157207 + use ellipsis too (Stephane) + emphasizing the text that is explicitly being searched (Ady) + bug 157227 + agree with the request to use more of the display (Stuart) + wrapping might be another idea (Rafael) + rather not because makes reading more difficult (Sahil) + ellipsis at start and end to bring the search term into the view (Felix) + simple solution covers most cases (and can be done as easyhack) (Cor) + ellipsis hinders reading the text, eg. if the search term is near end (Cor) + dialog is good as it, width should be adjusted carefully (Hossein) + With various scaling factors (2x, 3x, etc.) and different DPIs (HiDPI) these days, the issue of too big / too small dialogs and the need to add scrolling can also be seen elsewhere (Hossein) => resize the dialog if the content takes more space but only up to a reasonable width * CALC UI: Menu item "View headers" in menu "View" named wrong + https://bugs.documentfoundation.org/show_bug.cgi?id=159738 + changed because of the Notebookbar a) have a dedicated NotebookbarLabel b) change back and accept the longer label + or hide the View Header command in the NB variant c) change the UI label to "View Headers" d) accept the situation, ie. NAB/WF + a) sounds good but c) could be a quick solution here (Rafael) + probably with some tooltip (Heiko) + a) is okay but prefer d) rather than c) (Cor) + nitpicking anyway; tooltip is good (Rafael) + icon on the command would be nice (Felix) => add a tooltip "Toggle row/column header on/off" to command and the tools > options dialog * UI: A button to expand the animation picker dialog to dedicated dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=145038 + icons may help, even in the current form, in sidebar (Hossein) + icon view like at the transition deck sounds good (Rafael) + dedicated dialog needed for notebookbar-only variants (Sahil) + on the long run we should add some styles-like widget for animations as known from MSO (Hossein) => comment * Reworking of dialogues Organize macros (make from 5 existing only one) + https://bugs.documentfoundation.org/show_bug.cgi?id=120658 + Issue is worse than that considering Python, and APSO (Hossein) + Most things (editing, etc.) are not usable for Python, even with 5 dialogs (Hossein) + Every change should have in mind that it is about macro programming in general, and not only BASIC scripting (Hossein) + unified dialogs are not always easier to use (Cor) + suggested proposal is difficult to implement and suspect a lot of side effects (Rafael) + APSO is the way to go for Python at least (Rafael, Hossein) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-07
Present: Cor, Sahil, Felix, Rafael, Hossein, Heiko Comments: Stephane, Ady, Stuart Tickets/Topics * Auto-size the "Search Results" dialog (after a find & replace across multiple sheets) to avoid scrolling + https://bugs.documentfoundation.org/show_bug.cgi?id=157207 + use ellipsis too (Stephane) + emphasizing the text that is explicitly being searched (Ady) + bug 157227 + agree with the request to use more of the display (Stuart) + wrapping might be another idea (Rafael) + rather not because makes reading more difficult (Sahil) + ellipsis at start and end to bring the search term into the view (Felix) + simple solution covers most cases (and can be done as easyhack) (Cor) + ellipsis hinders reading the text, eg. if the search term is near end (Cor) + dialog is good as it, width should be adjusted carefully (Hossein) + With various scaling factors (2x, 3x, etc.) and different DPIs (HiDPI) these days, the issue of too big / too small dialogs and the need to add scrolling can also be seen elsewhere (Hossein) => resize the dialog if the content takes more space but only up to a reasonable width * CALC UI: Menu item "View headers" in menu "View" named wrong + https://bugs.documentfoundation.org/show_bug.cgi?id=159738 + changed because of the Notebookbar a) have a dedicated NotebookbarLabel b) change back and accept the longer label + or hide the View Header command in the NB variant c) change the UI label to "View Headers" d) accept the situation, ie. NAB/WF + a) sounds good but c) could be a quick solution here (Rafael) + probably with some tooltip (Heiko) + a) is okay but prefer d) rather than c) (Cor) + nitpicking anyway; tooltip is good (Rafael) + icon on the command would be nice (Felix) => add a tooltip "Toggle row/column header on/off" to command and the tools > options dialog * UI: A button to expand the animation picker dialog to dedicated dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=145038 + icons may help, even in the current form, in sidebar (Hossein) + icon view like at the transition deck sounds good (Rafael) + dedicated dialog needed for notebookbar-only variants (Sahil) + on the long run we should add some styles-like widget for animations as known from MSO (Hossein) => comment * Reworking of dialogues Organize macros (make from 5 existing only one) + https://bugs.documentfoundation.org/show_bug.cgi?id=120658 + Issue is worse than that considering Python, and APSO (Hossein) + Most things (editing, etc.) are not usable for Python, even with 5 dialogs (Hossein) + Every change should have in mind that it is about macro programming in general, and not only BASIC scripting (Hossein) + unified dialogs are not always easier to use (Cor) + suggested proposal is difficult to implement and suspect a lot of side effects (Rafael) + APSO is the way to go for Python at least (Rafael, Hossein) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sfx2/source
sfx2/source/dialog/infobar.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 06d8c1e9d8ba1d04914d1c48c94732cdb5c68846 Author: Heiko Tietze AuthorDate: Wed Mar 6 10:35:53 2024 +0100 Commit: Heiko Tietze CommitDate: Wed Mar 6 11:58:07 2024 +0100 Resolves tdf#159486 - Larger hitbox for close button on infobar Change-Id: I83582c0c1ec7dd5e8f82bdf327e68ce88122ad03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164450 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx index ca848813f09e..38a510a2589c 100644 --- a/sfx2/source/dialog/infobar.cxx +++ b/sfx2/source/dialog/infobar.cxx @@ -103,9 +103,12 @@ void SfxInfoBarWindow::SetCloseButtonImage() aSize = Size(aSize.Width() * 1.5, aSize.Height() * 1.5); ScopedVclPtr xDevice(m_xCloseBtn->create_virtual_device()); -xDevice->SetOutputSizePixel(aSize); +xDevice->SetOutputSizePixel(Size(24, 24)); +xDevice->SetBackground(Color(m_aBackgroundColor)); +xDevice->Erase(); -Point aBtnPos(0, 0); +const int nPos = (24 - aSize.getWidth()) / 2; +Point aBtnPos(nPos, nPos); const ViewInformation2D aNewViewInfos; const std::unique_ptr pProcessor(
core.git: Branch 'libreoffice-7-6' - sfx2/source
sfx2/source/view/viewfrm.cxx | 173 ++-
1 file changed, 92 insertions(+), 81 deletions(-)
New commits:
commit 8f3fb27880d6374f531cb012fe3b53179ecd4313
Author: Heiko Tietze
AuthorDate: Wed Feb 28 10:30:48 2024 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 28 22:49:55 2024 +0100
Resolves tdf#131550 - Suppress Donate/Involve infobar if another is visible
Change-Id: I013f0a1f0aa020f10d6beb21940959508eba4547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164082
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit 607740654f2264e13469e4da1d020448217d7222)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164115
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 4bfb58a724ec..e6f81d53e873 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1450,88 +1450,8 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/,
const SfxHint& rHint )
rBind.Invalidate( SID_RELOAD );
rBind.Invalidate( SID_EDITDOC );
-#if !ENABLE_WASM_STRIP_PINGUSER
-bool bIsHeadlessOrUITest =
SfxApplication::IsHeadlessOrUITest(); //uitest.uicheck fails when the dialog is
open
-
-//what's new infobar
-if (utl::isProductVersionUpgraded(true) &&
!bIsHeadlessOrUITest)
-{
-VclPtr pInfoBar =
AppendInfoBar("whatsnew", "", SfxResId(STR_WHATSNEW_TEXT), InfobarType::INFO);
-if (pInfoBar)
-{
-weld::Button& rWhatsNewButton = pInfoBar->addButton();
-
rWhatsNewButton.set_label(SfxResId(STR_WHATSNEW_BUTTON));
-rWhatsNewButton.connect_clicked(LINK(this,
SfxViewFrame, WhatsNewHandler));
-}
-}
-
-// show tip-of-the-day dialog if it due, but not if there is
the impress modal template dialog
-// open where SdModule::ExecuteNewDocument will launch it
instead when that dialog is dismissed
-if (SfxApplication::IsTipOfTheDayDue() && !bIsHeadlessOrUITest
&& !IsInModalMode())
-{
-// tdf#127946 pass in argument for dialog parent
-SfxUnoFrameItem aDocFrame(SID_FILLFRAME,
GetFrame().GetFrameInterface());
-GetDispatcher()->ExecuteList(SID_TIPOFTHEDAY,
SfxCallMode::SLOT, {}, { });
-}
-
-// inform about the community involvement
-const auto t0 =
std::chrono::system_clock::now().time_since_epoch();
-const sal_Int64 nLastGetInvolvedShown =
officecfg::Setup::Product::LastTimeGetInvolvedShown::get();
-const sal_Int64 nNow =
std::chrono::duration_cast(t0).count();
-const sal_Int64 nPeriodSec(60 * 60 * 24 * 180); // 180 days in
seconds
-bool bUpdateLastTimeGetInvolvedShown = false;
-
-if (nLastGetInvolvedShown == 0)
-bUpdateLastTimeGetInvolvedShown = true;
-else if (nPeriodSec < nNow && nLastGetInvolvedShown < (nNow +
nPeriodSec/2) - nPeriodSec) // 90d alternating with donation
-{
-bUpdateLastTimeGetInvolvedShown = true;
-
-VclPtr pInfoBar =
AppendInfoBar("getinvolved", "", SfxResId(STR_GET_INVOLVED_TEXT),
InfobarType::INFO);
-
-if (pInfoBar)
-{
-weld::Button& rGetInvolvedButton =
pInfoBar->addButton();
-
rGetInvolvedButton.set_label(SfxResId(STR_GET_INVOLVED_BUTTON));
-rGetInvolvedButton.connect_clicked(LINK(this,
SfxViewFrame, GetInvolvedHandler));
-}
-}
-
-if (bUpdateLastTimeGetInvolvedShown
-&&
!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
-{
-std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
-
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(nNow, batch);
-batch->commit();
-}
-
-// inform about donations
-const sal_Int64 nLastDonateShown =
officecfg::Setup::Product::LastTimeDonateShown::get();
-bool bUpdateLastTimeDonateShown = false;
-
-if (nLastDonateShown == 0)
-bUpdateLastTimeDonateShown = true;
-else if (nPeriodSec < nNow && nLastDonateShown < nNow -
nPeriodSec) // 90d alternating with getinvolved
-{
-bUpdateLastTimeDonate
core.git: Branch 'libreoffice-24-2' - sfx2/source
sfx2/source/view/viewfrm.cxx | 173 ++-
1 file changed, 92 insertions(+), 81 deletions(-)
New commits:
commit 9b0ec6639e7218b93551fc680b0929a73ac1fd90
Author: Heiko Tietze
AuthorDate: Wed Feb 28 10:30:48 2024 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 28 22:27:07 2024 +0100
Resolves tdf#131550 - Suppress Donate/Involve infobar if another is visible
Change-Id: I013f0a1f0aa020f10d6beb21940959508eba4547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164082
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit 607740654f2264e13469e4da1d020448217d7222)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164114
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index c6b25637ccf3..b14ff206fa96 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1496,88 +1496,8 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/,
const SfxHint& rHint )
rBind.Invalidate( SID_RELOAD );
rBind.Invalidate( SID_EDITDOC );
-#if !ENABLE_WASM_STRIP_PINGUSER
-bool bIsHeadlessOrUITest =
SfxApplication::IsHeadlessOrUITest(); //uitest.uicheck fails when the dialog is
open
-
-//what's new infobar
-if (utl::isProductVersionUpgraded(true) &&
!bIsHeadlessOrUITest)
-{
-VclPtr pInfoBar =
AppendInfoBar("whatsnew", "", SfxResId(STR_WHATSNEW_TEXT), InfobarType::INFO);
-if (pInfoBar)
-{
-weld::Button& rWhatsNewButton = pInfoBar->addButton();
-
rWhatsNewButton.set_label(SfxResId(STR_WHATSNEW_BUTTON));
-rWhatsNewButton.connect_clicked(LINK(this,
SfxViewFrame, WhatsNewHandler));
-}
-}
-
-// show tip-of-the-day dialog if it due, but not if there is
the impress modal template dialog
-// open where SdModule::ExecuteNewDocument will launch it
instead when that dialog is dismissed
-if (SfxApplication::IsTipOfTheDayDue() && !bIsHeadlessOrUITest
&& !IsInModalMode())
-{
-// tdf#127946 pass in argument for dialog parent
-SfxUnoFrameItem aDocFrame(SID_FILLFRAME,
GetFrame().GetFrameInterface());
-GetDispatcher()->ExecuteList(SID_TIPOFTHEDAY,
SfxCallMode::SLOT, {}, { });
-}
-
-// inform about the community involvement
-const auto t0 =
std::chrono::system_clock::now().time_since_epoch();
-const sal_Int64 nLastGetInvolvedShown =
officecfg::Setup::Product::LastTimeGetInvolvedShown::get();
-const sal_Int64 nNow =
std::chrono::duration_cast(t0).count();
-const sal_Int64 nPeriodSec(60 * 60 * 24 * 180); // 180 days in
seconds
-bool bUpdateLastTimeGetInvolvedShown = false;
-
-if (nLastGetInvolvedShown == 0)
-bUpdateLastTimeGetInvolvedShown = true;
-else if (nPeriodSec < nNow && nLastGetInvolvedShown < (nNow +
nPeriodSec/2) - nPeriodSec) // 90d alternating with donation
-{
-bUpdateLastTimeGetInvolvedShown = true;
-
-VclPtr pInfoBar =
AppendInfoBar("getinvolved", "", SfxResId(STR_GET_INVOLVED_TEXT),
InfobarType::INFO);
-
-if (pInfoBar)
-{
-weld::Button& rGetInvolvedButton =
pInfoBar->addButton();
-
rGetInvolvedButton.set_label(SfxResId(STR_GET_INVOLVED_BUTTON));
-rGetInvolvedButton.connect_clicked(LINK(this,
SfxViewFrame, GetInvolvedHandler));
-}
-}
-
-if (bUpdateLastTimeGetInvolvedShown
-&&
!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
-{
-std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
-
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(nNow, batch);
-batch->commit();
-}
-
-// inform about donations
-const sal_Int64 nLastDonateShown =
officecfg::Setup::Product::LastTimeDonateShown::get();
-bool bUpdateLastTimeDonateShown = false;
-
-if (nLastDonateShown == 0)
-bUpdateLastTimeDonateShown = true;
-else if (nPeriodSec < nNow && nLastDonateShown < nNow -
nPeriodSec) // 90d alternating with getinvolved
-{
-bUpdateLastTimeDonate
Minutes from the UX/design meeting 2023-Feb-28
Present: Sahil, John, Eyal, Heiko Comments: Ady, Mike, Rainer, Timur, Stuart, Tomaz Tickets/Topics * Lowercase "a" and uppercase "A" wrongly shows as one "a" in Autofilter dropdown + https://bugs.documentfoundation.org/show_bug.cgi?id=159737 + AutoFilter follows the setting in the Standard Filter (Ady) + a) WF/NAB, b) description, c) configuration (Mike) + not so clear whether case-sensitivity works (Rainer) + would expect case-sensitivity (John) + users might be not aware of uppercase character/word if we hide it; rather let the user uncheck (Heiko) + all options better go to the full filter dialog (Sahil) + Excel shows items case-sensitive (John) + make it independent from standard filter option (Heiko) => comment * UI: Cell protection dialog reference menu that don't exist + https://bugs.documentfoundation.org/show_bug.cgi?id=159748 + remove this part from the string (Heiko, Timur) + menu does exists; against changing the string (Ady, Stuart) + point to the help page (Tomaz) + against this hint to "use the help content" (Ady) + link to the appropriate help pages is reasonable (Stuart) + idea was probably to have a hyperlink in the string + alternatively change the label depending on the UI mode, or amend the existing text with the Notebookbar solution (Eyal) + sheet/cell protection is not for beginners and we can expect users to learn the function (Sahil) => preferably use a more generic description * Manage changes dialog should allow action on all filtered changes + https://bugs.documentfoundation.org/show_bug.cgi?id=115515 + WFM/INV, at least from the sidebar (Heiko) => resolve ticket * Consistent polygon tool behavior in Draw + https://bugs.documentfoundation.org/show_bug.cgi?id=131758 + (1) how to finish the input: easy to miss and hard to undo (Eyal) + perhaps have some interaction to undo the last point + edit points allow to remove unwanted + (2) finishing methods: MSO ends polygon as well per double-click but also on escape + (3) close a polyline: by ctrl+click? in any case up to documentation + (4) how to enter PolyPoly-mode: same answer as above + (5) Is it really intended... obviously no user has joined the discussion + users tend to accept shortcomings and we might do better (Eyal) + would rather think of a list that takes all points and allows to edit independently from the interaction method (Heiko) + giving a hint on the interaction at the command label? not so good (John) + any change needs to be a convincing improvement (Eyal) + Inkscape behavior is similar to our workflow => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Feb-28
Present: Sahil, John, Eyal, Heiko Comments: Ady, Mike, Rainer, Timur, Stuart, Tomaz Tickets/Topics * Lowercase "a" and uppercase "A" wrongly shows as one "a" in Autofilter dropdown + https://bugs.documentfoundation.org/show_bug.cgi?id=159737 + AutoFilter follows the setting in the Standard Filter (Ady) + a) WF/NAB, b) description, c) configuration (Mike) + not so clear whether case-sensitivity works (Rainer) + would expect case-sensitivity (John) + users might be not aware of uppercase character/word if we hide it; rather let the user uncheck (Heiko) + all options better go to the full filter dialog (Sahil) + Excel shows items case-sensitive (John) + make it independent from standard filter option (Heiko) => comment * UI: Cell protection dialog reference menu that don't exist + https://bugs.documentfoundation.org/show_bug.cgi?id=159748 + remove this part from the string (Heiko, Timur) + menu does exists; against changing the string (Ady, Stuart) + point to the help page (Tomaz) + against this hint to "use the help content" (Ady) + link to the appropriate help pages is reasonable (Stuart) + idea was probably to have a hyperlink in the string + alternatively change the label depending on the UI mode, or amend the existing text with the Notebookbar solution (Eyal) + sheet/cell protection is not for beginners and we can expect users to learn the function (Sahil) => preferably use a more generic description * Manage changes dialog should allow action on all filtered changes + https://bugs.documentfoundation.org/show_bug.cgi?id=115515 + WFM/INV, at least from the sidebar (Heiko) => resolve ticket * Consistent polygon tool behavior in Draw + https://bugs.documentfoundation.org/show_bug.cgi?id=131758 + (1) how to finish the input: easy to miss and hard to undo (Eyal) + perhaps have some interaction to undo the last point + edit points allow to remove unwanted + (2) finishing methods: MSO ends polygon as well per double-click but also on escape + (3) close a polyline: by ctrl+click? in any case up to documentation + (4) how to enter PolyPoly-mode: same answer as above + (5) Is it really intended... obviously no user has joined the discussion + users tend to accept shortcomings and we might do better (Eyal) + would rather think of a list that takes all points and allows to edit independently from the interaction method (Heiko) + giving a hint on the interaction at the command label? not so good (John) + any change needs to be a convincing improvement (Eyal) + Inkscape behavior is similar to our workflow => comment OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: 2 commits - officecfg/registry static/StaticLibrary_unoembind.mk udkapi/org udkapi/UnoApi_udkapi.mk unotest/InternalUnoApi_embindtest.mk unotest/Library_embindtest.mk unotest/Module_unotest.
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu |6 +++ static/StaticLibrary_unoembind.mk |6 --- udkapi/UnoApi_udkapi.mk| 10 + udkapi/org/libreoffice/embindtest/Struct.idl | 20 ++ udkapi/org/libreoffice/embindtest/Test.idl | 16 udkapi/org/libreoffice/embindtest/XTest.idl|8 unotest/InternalUnoApi_embindtest.mk | 16 unotest/Library_embindtest.mk |4 -- unotest/Module_unotest.mk |1 9 files changed, 52 insertions(+), 35 deletions(-) New commits: commit 6158928209bd0f6bd532df9092f3a81ff615cdcc Author: Heiko Tietze AuthorDate: Tue Feb 27 08:32:06 2024 +0100 Commit: Heiko Tietze CommitDate: Wed Feb 28 07:52:23 2024 +0100 Resolves tdf#159863 - Default shortcut to access foot-/endnote area Change-Id: Ie95e94602a0dfd0c899f70d30d2c78e7063a4818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164001 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu index 43b6523c7616..56eb20da6bd3 100644 --- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu @@ -6196,6 +6196,12 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some emoji thing .uno:ParaRightToLeft + + +L10N SHORTCUTS - NO TRANSLATE +.uno:JumpToFootnoteOrAnchor + + L10N SHORTCUTS - NO TRANSLATE commit 80e2c4e5b9ef1d299c6caa271c9f177a4d011937 Author: Stephan Bergmann AuthorDate: Tue Feb 27 16:29:18 2024 +0100 Commit: Stephan Bergmann CommitDate: Wed Feb 28 07:52:11 2024 +0100 Fold InternalUnoApi_embindtest into UnoApi_udkapi 80d3f33876a2ad4ce32d3c6183131984e8c6b5da "Library_embindtest should use comprehensive InternalUnoApi_embindtest" was an attempt at making type information about that library available at runtime. Which worked for cases where code directly called one of the types' cppu_detail_getUnoType function. But it would still fail for cases where code indirectly wants to obtain one of the types' information by type name---which is what upcoming code will do that changes the Embind'ing of UNO sequences. So InternalUnoApi_embindtest would need to become a UnoApi_embindtest whose instdir/program/types/embindtest.rdb would be available at runtime. But I'm too dumb to convince gbuild to create that new UnoApi_embindtest. So instead just tack the embindtest UNOIDL entities onto the existing UnoApi_udkapi for the EMSCRIPTEN-ENABLE_DBGUTIL case. (Which requires that the single embindtest.idl is split into individual per-entity files, sigh.) Change-Id: Ie189b17213ac5b2de7a61ac5f97a143fa097337f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/static/StaticLibrary_unoembind.mk b/static/StaticLibrary_unoembind.mk index 5d4438ef2f85..e2a2bfacd892 100644 --- a/static/StaticLibrary_unoembind.mk +++ b/static/StaticLibrary_unoembind.mk @@ -22,12 +22,6 @@ $(eval $(call gb_StaticLibrary_use_api,unoembind,\ udkapi \ )) -ifneq ($(ENABLE_DBGUTIL),) -$(eval $(call gb_StaticLibrary_use_internal_api,unoembind, \ -embindtest \ -)) -endif - $(call gb_StaticLibrary_get_target,unoembind): $(call gb_CustomTarget_get_target,static/unoembind) # vim: set noet sw=4 ts=4: diff --git a/udkapi/UnoApi_udkapi.mk b/udkapi/UnoApi_udkapi.mk index f18b9f758ddc..5f22026027ee 100644 --- a/udkapi/UnoApi_udkapi.mk +++ b/udkapi/UnoApi_udkapi.mk @@ -520,6 +520,16 @@ $(eval $(call gb_UnoApi_add_idlfiles,udkapi,com/sun/star/util,\ XVeto \ )) +ifeq ($(OS)-$(ENABLE_DBGUTIL),EMSCRIPTEN-TRUE) +$(eval $(call gb_UnoApi_add_idlfiles,udkapi,org/libreoffice/embindtest, \ +Struct \ +XTest \ +)) +$(eval $(call gb_UnoApi_add_idlfiles_nohdl,udkapi,org/libreoffice/embindtest, \ +Test \ +)) +endif + $(eval $(call gb_UnoApi_set_reference_rdbfile,udkapi,$(SRCDIR)/udkapi/type_reference/udkapi.idl)) # vim: set noet sw=4 ts=4: diff --git a/udkapi/org/libreoffice/embindtest/Struct.idl b/udkapi/org/libreoffice/embindtest/Struct.idl new file mode 100644 index ..6b9d36e40a1b --- /dev/null +++ b/udkapi/org/libreoffice/embindtest/Struct.idl @@ -0,0 +1,20 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + *
Minutes from the UX/design meeting 2023-Feb-22
Present: Sahil, Hossein, Heiko Tickets/Topics * STATUSBAR: Making the statusbar configurable in Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=92406 + tools > customize sounds like over-engineering, we should rather do something like toolbar > visible button on/off (Heiko) + would be cool to have the priority available, perhaps more fine-grained (Sahil) + statusbar should be available for extensions (Sahil) + if it is possible to add commands to the statusbar such enhancement (if not possible out of the box) would be granted (Heiko) => comment * Simplified options dialogs + https://bugs.documentfoundation.org/show_bug.cgi?id=90989 + name, icons, interface, colors, ui lang, locale, and recovery should be sufficient (Heiko) + RTL/CTL/CJK is important (Hossein) but should follow the locale (Heiko), and if a more complex setup is needed the advanced mode is a click away + could be done conditionally depending on locale setting (Sahil) + more tabs might be required in future (Hossein); possibly easier to use than a scrolling window (Sahil) + as long the options fit on one page, which should be the goal for a simple dialog, no need to discuss this (Heiko) => waiting for volunteers OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Feb-22
Present: Sahil, Hossein, Heiko Tickets/Topics * STATUSBAR: Making the statusbar configurable in Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=92406 + tools > customize sounds like over-engineering, we should rather do something like toolbar > visible button on/off (Heiko) + would be cool to have the priority available, perhaps more fine-grained (Sahil) + statusbar should be available for extensions (Sahil) + if it is possible to add commands to the statusbar such enhancement (if not possible out of the box) would be granted (Heiko) => comment * Simplified options dialogs + https://bugs.documentfoundation.org/show_bug.cgi?id=90989 + name, icons, interface, colors, ui lang, locale, and recovery should be sufficient (Heiko) + RTL/CTL/CJK is important (Hossein) but should follow the locale (Heiko), and if a more complex setup is needed the advanced mode is a click away + could be done conditionally depending on locale setting (Sahil) + more tabs might be required in future (Hossein); possibly easier to use than a scrolling window (Sahil) + as long the options fit on one page, which should be the goal for a simple dialog, no need to discuss this (Heiko) => waiting for volunteers OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sw/source
sw/source/uibase/docvw/ShadowOverlayObject.cxx | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
New commits:
commit 215a7afd6042c35a45509cea3eae69254d676429
Author: Heiko Tietze
AuthorDate: Wed Feb 21 16:10:40 2024 +0100
Commit: Heiko Tietze
CommitDate: Wed Feb 21 20:03:19 2024 +0100
Resolves tdf#159535 - Less obtrusive shadow for comments
Change-Id: Ic4b55ebb52aaf03738184dcc0d3b8d57c9ee57a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163699
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/uibase/docvw/ShadowOverlayObject.cxx
b/sw/source/uibase/docvw/ShadowOverlayObject.cxx
index fa905b97567b..ef2ed5dd8b6d 100644
--- a/sw/source/uibase/docvw/ShadowOverlayObject.cxx
+++ b/sw/source/uibase/docvw/ShadowOverlayObject.cxx
@@ -73,6 +73,8 @@ public:
drawinglayer::primitive2d::Primitive2DReference
ShadowPrimitive::create2DDecomposition(
const drawinglayer::geometry::ViewInformation2D& /*rViewInformation*/)
const
{
+const Color aBgCol =
svtools::ColorConfig().GetColorValue(svtools::WRITERSECTIONBOUNDARIES).nColor;
+const Color aBgColInv = aBgCol.IsDark() ? COL_WHITE : COL_BLACK;
// get logic sizes in object coordinate system
basegfx::B2DRange aRange(maBasePosition);
drawinglayer::primitive2d::Primitive2DReference xRet;
@@ -80,7 +82,7 @@ drawinglayer::primitive2d::Primitive2DReference
ShadowPrimitive::create2DDecompo
{
case SS_NORMAL:
{
-aRange.expand(basegfx::B2DTuple(getSecondPosition().getX(),
getSecondPosition().getY() + (2.0 * getDiscreteUnit(;
+aRange.expand(basegfx::B2DTuple(getSecondPosition().getX(),
getSecondPosition().getY() + (1.0 * getDiscreteUnit(;
::drawinglayer::attribute::FillGradientAttribute
aFillGradientAttribute(
css::awt::GradientStyle_LINEAR,
@@ -88,10 +90,7 @@ drawinglayer::primitive2d::Primitive2DReference
ShadowPrimitive::create2DDecompo
0.5,
0.5,
M_PI,
-basegfx::BColorStops(
-basegfx::BColor(230.0/255.0,230.0/255.0,230.0/255.0),
-basegfx::BColor(180.0/255.0,180.0/255.0,180.0/255.0)));
-
+basegfx::BColorStops(aBgCol.getBColor(),
aBgColInv.getBColor()));
xRet =
new drawinglayer::primitive2d::FillGradientPrimitive2D(
aRange,
@@ -100,17 +99,14 @@ drawinglayer::primitive2d::Primitive2DReference
ShadowPrimitive::create2DDecompo
}
case SS_VIEW:
{
-aRange.expand(basegfx::B2DTuple(getSecondPosition().getX(),
getSecondPosition().getY() + (4.0 * getDiscreteUnit(;
+aRange.expand(basegfx::B2DTuple(getSecondPosition().getX(),
getSecondPosition().getY() + (2.0 * getDiscreteUnit(;
drawinglayer::attribute::FillGradientAttribute
aFillGradientAttribute(
css::awt::GradientStyle_LINEAR,
0.0,
0.5,
0.5,
M_PI,
-basegfx::BColorStops(
-basegfx::BColor(230.0/255.0,230.0/255.0,230.0/255.0),
-basegfx::BColor(180.0/255.0,180.0/255.0,180.0/255.0)));
-
+basegfx::BColorStops(aBgCol.getBColor(),
aBgColInv.getBColor()));
xRet =
new drawinglayer::primitive2d::FillGradientPrimitive2D(
aRange,
@@ -126,10 +122,7 @@ drawinglayer::primitive2d::Primitive2DReference
ShadowPrimitive::create2DDecompo
0.5,
0.5,
M_PI,
-basegfx::BColorStops(
-basegfx::BColor(230.0/255.0,230.0/255.0,230.0/255.0),
-basegfx::BColor(83.0/255.0,83.0/255.0,83.0/255.0)));
-
+basegfx::BColorStops(aBgCol.getBColor(),
aBgColInv.getBColor()));
xRet =
new drawinglayer::primitive2d::FillGradientPrimitive2D(
aRange,
Minutes from the UX/design meeting 2023-Feb-14
Present: Sahil, Rafael, Hossein, Heiko Comments: Stuart, Jean-Francois, Eyal, Stephané, Ady Tickets/Topics * Freeze Zoom as a global LibreOffice preference + https://bugs.documentfoundation.org/show_bug.cgi?id=159156 + assigning +0 to .uno:Zoom100Percent as fixed shortcut (Stuart) + though must not touch Ctrl+0 in Writer (Jean-Francois) + ignore zoom-in/-out via keyboard or lock zoom (Eyal) + could be an option "[ ] No zoom per touch pad" (Rafael) => add the option (perhaps macOS only) * Comment commands in Calc's menus need to be rearranged + https://bugs.documentfoundation.org/show_bug.cgi?id=158653 + split of comment-related commands is not ideal (Stephané) + yet done intentionally for bug 91820 + not convinced that changing the menus is the best path forward, it's basically grouping by action vs object (Ady) + other applications go with action-focused menus too (Hossein) + no better place for comments than under Sheet (Heiko) + when coming from the Notebookbar it feels wrong (Rafael) => resolve NAB/WF * Dialog Properties bigger then screen + https://bugs.documentfoundation.org/show_bug.cgi?id=159409 + not confirmed, dialog is ~637px in height on win (Stuart) + but there is a duplicate report; and report is from gtk3 + reduce the number of lines for the comments textbox (Hossein) + turning the wall of inputs into two columns (Rafael) + has the challenge to cover long labels (Heiko) + long term solution: add some mechanism to VCL/weld that restricts oversized dialogs and automatically adds scrolling (Hossein) => do it * Page direction not the same as sheet direction + https://bugs.documentfoundation.org/show_bug.cgi?id=158601 + recent bug reports have proven that users do not agree (Ady) + if the request is to bind the UI-only setting Sheet > RTL to Page Style > Text Direction (the superordinate setting of the text direction in cells) the recommendation is to rather not do + Excel knows a "context" option for the cell direction meaning if the entered text is RTL the cell becomes RTL (Hossein) + The context option will handle the use case automatically, and also handles the situation with bilingual cells (Hossein) + problem accepted, solution rejected = WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Feb-14
Present: Sahil, Rafael, Hossein, Heiko Comments: Stuart, Jean-Francois, Eyal, Stephané, Ady Tickets/Topics * Freeze Zoom as a global LibreOffice preference + https://bugs.documentfoundation.org/show_bug.cgi?id=159156 + assigning +0 to .uno:Zoom100Percent as fixed shortcut (Stuart) + though must not touch Ctrl+0 in Writer (Jean-Francois) + ignore zoom-in/-out via keyboard or lock zoom (Eyal) + could be an option "[ ] No zoom per touch pad" (Rafael) => add the option (perhaps macOS only) * Comment commands in Calc's menus need to be rearranged + https://bugs.documentfoundation.org/show_bug.cgi?id=158653 + split of comment-related commands is not ideal (Stephané) + yet done intentionally for bug 91820 + not convinced that changing the menus is the best path forward, it's basically grouping by action vs object (Ady) + other applications go with action-focused menus too (Hossein) + no better place for comments than under Sheet (Heiko) + when coming from the Notebookbar it feels wrong (Rafael) => resolve NAB/WF * Dialog Properties bigger then screen + https://bugs.documentfoundation.org/show_bug.cgi?id=159409 + not confirmed, dialog is ~637px in height on win (Stuart) + but there is a duplicate report; and report is from gtk3 + reduce the number of lines for the comments textbox (Hossein) + turning the wall of inputs into two columns (Rafael) + has the challenge to cover long labels (Heiko) + long term solution: add some mechanism to VCL/weld that restricts oversized dialogs and automatically adds scrolling (Hossein) => do it * Page direction not the same as sheet direction + https://bugs.documentfoundation.org/show_bug.cgi?id=158601 + recent bug reports have proven that users do not agree (Ady) + if the request is to bind the UI-only setting Sheet > RTL to Page Style > Text Direction (the superordinate setting of the text direction in cells) the recommendation is to rather not do + Excel knows a "context" option for the cell direction meaning if the entered text is RTL the cell becomes RTL (Hossein) + The context option will handle the use case automatically, and also handles the situation with bilingual cells (Hossein) + problem accepted, solution rejected = WF OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: cui/inc cui/source cui/uiconfig icon-themes/breeze_dark icon-themes/colibre icon-themes/colibre_dark icon-themes/colibre_dark_svg icon-themes/colibre_svg icon-themes/sifr_dark icon-themes/su
cui/inc/bitmaps.hlst|2 cui/source/inc/numpages.hxx |6 cui/source/inc/swpossizetabpage.hxx |7 cui/source/inc/transfrm.hxx |7 cui/source/tabpages/numpages.cxx| 23 cui/source/tabpages/swpossizetabpage.cxx| 26 cui/source/tabpages/transfrm.cxx| 26 cui/uiconfig/ui/bulletandposition.ui| 100 ++- cui/uiconfig/ui/numberingoptionspage.ui | 606 +++- cui/uiconfig/ui/possizetabpage.ui | 110 ++- cui/uiconfig/ui/swpossizepage.ui| 368 ++-- icon-themes/breeze_dark/res/locked.png |binary icon-themes/breeze_dark/res/unlocked.png|binary icon-themes/colibre/res/locked.png |binary icon-themes/colibre/res/unlocked.png|binary icon-themes/colibre_dark/res/locked.png |binary icon-themes/colibre_dark/res/unlocked.png |binary icon-themes/colibre_dark_svg/res/unlocked.svg | 43 + icon-themes/colibre_svg/res/unlocked.svg|4 icon-themes/sifr_dark/res/locked.png|binary icon-themes/sifr_dark/res/unlocked.png |binary icon-themes/sukapura_dark/res/locked.png|binary icon-themes/sukapura_dark/res/unlocked.png |binary include/svx/dlgutil.hxx | 19 sd/inc/bitmaps.hlst |3 sd/source/ui/dlg/BulletAndPositionDlg.cxx | 25 sd/source/ui/inc/BulletAndPositionDlg.hxx |6 svx/inc/bitmaps.hlst|3 svx/source/dialog/dlgutil.cxx | 24 svx/source/sidebar/possize/PosSizePropertyPanel.cxx | 29 svx/source/sidebar/possize/PosSizePropertyPanel.hxx |7 svx/uiconfig/ui/sidebarpossize.ui | 128 +++- sw/inc/bitmaps.hlst |3 sw/source/ui/frmdlg/frmpage.cxx | 20 sw/source/uibase/inc/frmpage.hxx|9 sw/uiconfig/swriter/ui/frmtypepage.ui | 127 +++- 36 files changed, 1201 insertions(+), 530 deletions(-) New commits: commit fe4e750d32cb88a9ce7a7539af6c6883d4194220 Author: Heiko Tietze AuthorDate: Fri Dec 8 12:18:47 2023 +0100 Commit: Heiko Tietze CommitDate: Mon Feb 12 12:56:05 2024 +0100 Resolves tdf#158531 - Connector lines for Keep Ratio setting Icons taken from https://thenounproject.com/icon/lock-89649/ and https://thenounproject.com/icon/unlock-89647/ (licensed PD) Change-Id: I7efd25e83726ced7dee4f876cf4bb4c8f54408df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160460 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/cui/inc/bitmaps.hlst b/cui/inc/bitmaps.hlst index 6e0a1877588e..aab916827507 100644 --- a/cui/inc/bitmaps.hlst +++ b/cui/inc/bitmaps.hlst @@ -53,6 +53,8 @@ inline constexpr OUString RID_SVXBMP_TOPLOCK = u"svx/res/lo02.png"_ustr; inline constexpr OUString RID_SVXBMP_CELLLOCK = u"svx/res/lo03.png"_ustr; inline constexpr OUString RID_SVXBMP_LOCK = u"res/lock.png"_ustr; +inline constexpr OUString RID_SVXBMP_LOCKED = u"res/locked.png"_ustr; +inline constexpr OUString RID_SVXBMP_UNLOCKED = u"res/unlocked.png"_ustr; inline constexpr OUString RID_SVXBMP_THEME_NORMAL_BIG = u"svx/res/galnorl.png"_ustr; inline constexpr OUString RID_SVXBMP_THEME_READONLY_BIG = u"svx/res/galrdol.png"_ustr; diff --git a/cui/source/inc/numpages.hxx b/cui/source/inc/numpages.hxx index ec7b72ac71fb..7c34d49fcc62 100644 --- a/cui/source/inc/numpages.hxx +++ b/cui/source/inc/numpages.hxx @@ -28,6 +28,7 @@ #include #include #include +#include #define MN_GALLERY_ENTRY 100 @@ -218,6 +219,8 @@ class SvxNumOptionsTabPage : public SfxTabPage TypedWhichId nNumItemId; MapUnit eCoreUnit; +SvxRatioConnector m_aRatioTop; +SvxRatioConnector m_aRatioBottom; SvxNumberingPreview m_aPreviewWIN; std::unique_ptr m_xGrid; std::unique_ptr m_xLevelLB; @@ -247,6 +250,9 @@ class SvxNumOptionsTabPage : public SfxTabPage std::unique_ptr m_xHeightFT; std::unique_ptr m_xHeightMF; std::unique_ptr m_xRatioCB; +std::unique_ptr m_xCbxScaleImg; +std::unique_ptr m_xImgRatioTop; +std::unique_ptr m_xImgRatioBottom; std::unique_ptr m_xOrientFT; std::unique_ptr m_xOrientLB; std::unique_ptr m_xAllLevelsFrame; diff --git a/cui/source/inc/swpossizetabpage.hxx b/cui/source/inc/swpossizetabpage.hxx index eb73196986bf..2e5a15fbebbb 100644 --- a/cui/source/inc/swpossizetabpage.hxx +++ b/cui/source/inc/swpossizetabpage.hxx @@ -21,6 +21,7 @@ #include #include #include +#include // SvxSwPosSizeTabPage - position and size page for Writer drawing objects
core.git: sw/source
sw/source/core/doc/DocumentStylePoolManager.cxx | 10 ++
1 file changed, 10 insertions(+)
New commits:
commit 1dc0c8c8304ebbce0a2e05e89a3b5458d88f3630
Author: Heiko Tietze
AuthorDate: Tue Feb 6 16:09:32 2024 +0100
Commit: Heiko Tietze
CommitDate: Wed Feb 7 13:45:07 2024 +0100
Resolves tdf#159531 - Indentation and spacing for comments
Change-Id: I3ce9dd5d399ce9ff1427de0c97a1227dab996d9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163059
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/core/doc/DocumentStylePoolManager.cxx
b/sw/source/core/doc/DocumentStylePoolManager.cxx
index 68d4e5c11855..96392c94b1c9 100644
--- a/sw/source/core/doc/DocumentStylePoolManager.cxx
+++ b/sw/source/core/doc/DocumentStylePoolManager.cxx
@@ -1014,6 +1014,16 @@ SwTextFormatColl*
DocumentStylePoolManager::GetTextCollFromPool( sal_uInt16 nId,
case RES_POOLCOLL_COMMENT: // Comment
{
SetAllScriptItem(aSet, SvxFontHeightItem(PT_10, 100,
RES_CHRATR_FONTSIZE));
+
+auto const aIndent(o3tl::convert(0.1, o3tl::Length::cm,
o3tl::Length::twip));
+SvxTextLeftMarginItem const leftMargin(aIndent,
RES_MARGIN_TEXTLEFT);
+SvxRightMarginItem const rightMargin(aIndent,
RES_MARGIN_RIGHT);
+aSet.Put(leftMargin);
+aSet.Put(rightMargin);
+
+auto const aSpacing(o3tl::convert(0.1, o3tl::Length::cm,
o3tl::Length::twip));
+SvxULSpaceItem topSpacing( aSpacing, 0, RES_UL_SPACE );
+aSet.Put(topSpacing);
}
break;
Minutes from the UX/design meeting 2023-Jan-31
Present: Sahil, JJ, John, Eyal, Rafael, Heiko Comments: Jan, Stuart Tickets/Topics * Autocorrect options are very confusing and difficult to use + https://bugs.documentfoundation.org/show_bug.cgi?id=158876 + renaming some options might be beneficial (Jan) + Separate the list into two lists, textual replacements/corrections, and formatting/structural element (Eyal) + everything is formatting and replacement (Heiko) + splitting should support the perception (Eyal) + Change phrasing, eg "Replace dashes" could become "Replace dash sequence with En-Dash or Em-Dash" (Eyal) + sure but the function is more complex and requires the documentation + distinction would be artificial and orthogonal to the M/T option; rather than renaming we could add tooltips (Heiko) + tooltips could be a help (Heiko) + sounds good (Eyal) + requires coding though => comment and recommend to not change the list => renaming is good; AI Eyal: provide a complete list of better labels * Non-corrective Autoformat settings can't just be placed under AutoCorrect + https://bugs.documentfoundation.org/show_bug.cgi?id=158877 + unclear request (John, Heiko) + formatting such as *bold* or apply styles is not really a correction (Eyal) + no good alternative, maybe "auto correction/formatting" + wonder if changing the semantics improve usability (John) + camel case label is bad; but familiar to users (Heiko) + no apparent issue; all auto-corrections are also formatting too (Heiko) => resolve NAB without better alternative * Use Noto family fonts as default fonts for all the LibreOffice tools + https://bugs.documentfoundation.org/show_bug.cgi?id=159261 + Noto Sans is being used for Impress templates (Stuart) + smalls like personal preference; against Google fonts in principle (Eyal) + rather add metric compatible fonts for latest MSO (John) + to open legacy document with the same layout after years is our self-identity; which is not the discussion here since we would change the fonts for new documents (Heiko) + Liberation fonts is our trademark; and it's easy to change; not worth the effort (Rafael) + a lot of effort to make the QA tests happy (Heiko) + such a change should have much more backup (Eyal) => WF * provide easy UI to automatically apply digital signature when storing documents + https://bugs.documentfoundation.org/show_bug.cgi?id=159040 + checkbox "[ ] Sign document" at the Save/As dialog; clumsy solution but maybe easy to use (Heiko) + similar workflow but signing comes before saving (Eyal) + alternative is to have a default signature defined in tools > options > security and just the option to apply or not; needs some interaction to change the default, maybe via the current workflow (Eyal) => comment * It would be nice to have an exclude file type option from Recent Files + https://bugs.documentfoundation.org/show_bug.cgi?id=159277 + exclude per module using a string like "csv;xml;tab" (similar solution available in IDEs, for example) + MRU is a simple and established paradigm; WF (Jan) + very specific workflow (Eyal) + use CSV a lot and want to see it (Rafael) + solve per extension that clears the MRU list on startup (Heiko) + better keep the ticket, maybe as easyhack, with low priority (Eyal, Rafael) => go for it OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jan-31
Present: Sahil, JJ, John, Eyal, Rafael, Heiko Comments: Jan, Stuart Tickets/Topics * Autocorrect options are very confusing and difficult to use + https://bugs.documentfoundation.org/show_bug.cgi?id=158876 + renaming some options might be beneficial (Jan) + Separate the list into two lists, textual replacements/corrections, and formatting/structural element (Eyal) + everything is formatting and replacement (Heiko) + splitting should support the perception (Eyal) + Change phrasing, eg "Replace dashes" could become "Replace dash sequence with En-Dash or Em-Dash" (Eyal) + sure but the function is more complex and requires the documentation + distinction would be artificial and orthogonal to the M/T option; rather than renaming we could add tooltips (Heiko) + tooltips could be a help (Heiko) + sounds good (Eyal) + requires coding though => comment and recommend to not change the list => renaming is good; AI Eyal: provide a complete list of better labels * Non-corrective Autoformat settings can't just be placed under AutoCorrect + https://bugs.documentfoundation.org/show_bug.cgi?id=158877 + unclear request (John, Heiko) + formatting such as *bold* or apply styles is not really a correction (Eyal) + no good alternative, maybe "auto correction/formatting" + wonder if changing the semantics improve usability (John) + camel case label is bad; but familiar to users (Heiko) + no apparent issue; all auto-corrections are also formatting too (Heiko) => resolve NAB without better alternative * Use Noto family fonts as default fonts for all the LibreOffice tools + https://bugs.documentfoundation.org/show_bug.cgi?id=159261 + Noto Sans is being used for Impress templates (Stuart) + smalls like personal preference; against Google fonts in principle (Eyal) + rather add metric compatible fonts for latest MSO (John) + to open legacy document with the same layout after years is our self-identity; which is not the discussion here since we would change the fonts for new documents (Heiko) + Liberation fonts is our trademark; and it's easy to change; not worth the effort (Rafael) + a lot of effort to make the QA tests happy (Heiko) + such a change should have much more backup (Eyal) => WF * provide easy UI to automatically apply digital signature when storing documents + https://bugs.documentfoundation.org/show_bug.cgi?id=159040 + checkbox "[ ] Sign document" at the Save/As dialog; clumsy solution but maybe easy to use (Heiko) + similar workflow but signing comes before saving (Eyal) + alternative is to have a default signature defined in tools > options > security and just the option to apply or not; needs some interaction to change the default, maybe via the current workflow (Eyal) => comment * It would be nice to have an exclude file type option from Recent Files + https://bugs.documentfoundation.org/show_bug.cgi?id=159277 + exclude per module using a string like "csv;xml;tab" (similar solution available in IDEs, for example) + MRU is a simple and established paradigm; WF (Jan) + very specific workflow (Eyal) + use CSV a lot and want to see it (Rafael) + solve per extension that clears the MRU list on startup (Heiko) + better keep the ticket, maybe as easyhack, with low priority (Eyal, Rafael) => go for it OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: Branch 'libreoffice-24-2' - sw/source
sw/source/core/text/inftxt.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2920c56159320965e81de99b11fb1ca5dd42c8d5
Author: Heiko Tietze
AuthorDate: Wed Jan 31 11:29:14 2024 +0100
Commit: Xisco Fauli
CommitDate: Wed Jan 31 21:00:44 2024 +0100
Resolves tdf#159328 - Fix field shading regression
Introduced by 4d7a98b582dc70bbffc78e6622969e218f108433
Change-Id: Ibcc057e47c62d53dfa9e6410230c4b231df8551c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162799
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit 788ebd183b095ffb7369c4d518acd14bad72ae82)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162820
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index 3d9121ef1ec2..8eced32e8990 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -1426,8 +1426,8 @@ void SwTextPaintInfo::DrawViewOpt( const SwLinePortion
,
|| m_pFrame->GetTextNodeForParaProps()->HasMarkedLabel()))
// #i27615#
{
bDraw = PortionType::Footnote != nWhich ||
m_pFrame->IsFootnoteAllowed();
+bDraw &= GetOpt().IsHardBlank();
}
-bDraw &= GetOpt().IsHardBlank();
break;
case PortionType::Bookmark:
// no shading
core.git: sw/source
sw/source/core/text/inftxt.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 788ebd183b095ffb7369c4d518acd14bad72ae82
Author: Heiko Tietze
AuthorDate: Wed Jan 31 11:29:14 2024 +0100
Commit: Heiko Tietze
CommitDate: Wed Jan 31 15:25:13 2024 +0100
Resolves tdf#159328 - Fix field shading regression
Introduced by 4d7a98b582dc70bbffc78e6622969e218f108433
Change-Id: Ibcc057e47c62d53dfa9e6410230c4b231df8551c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162799
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index 3d9121ef1ec2..8eced32e8990 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -1426,8 +1426,8 @@ void SwTextPaintInfo::DrawViewOpt( const SwLinePortion
,
|| m_pFrame->GetTextNodeForParaProps()->HasMarkedLabel()))
// #i27615#
{
bDraw = PortionType::Footnote != nWhich ||
m_pFrame->IsFootnoteAllowed();
+bDraw &= GetOpt().IsHardBlank();
}
-bDraw &= GetOpt().IsHardBlank();
break;
case PortionType::Bookmark:
// no shading
core.git: svtools/source
svtools/source/config/colorcfg.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 381ab9a1a38e4ea9238599e62acd430782a80547
Author: Heiko Tietze
AuthorDate: Fri Jan 26 09:05:12 2024 +0100
Commit: Heiko Tietze
CommitDate: Fri Jan 26 11:11:40 2024 +0100
Resolves tdf#159096 - Change color of comment indicators in Calc
COL_LIGHTMAGENT was preceived as too glossy and "Light Purple 3"
should also be closer to the Excel prototype
Change-Id: I451c0ba0628dbd3b1794e46de3ff1fef763a6f46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162593
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/svtools/source/config/colorcfg.cxx
b/svtools/source/config/colorcfg.cxx
index dea9ca97db2f..4a4e94370bef 100644
--- a/svtools/source/config/colorcfg.cxx
+++ b/svtools/source/config/colorcfg.cxx
@@ -422,7 +422,7 @@ Color ColorConfig::GetDefaultColor(ColorConfigEntry eEntry)
{ COL_GRAY7,COL_GRAY7 }, // CALCPAGEBREAKAUTOMATIC
{ Color(0x2300dc), Color(0x2300DC) }, // CALCHIDDENCOLROW
{ COL_LIGHTRED, COL_LIGHTRED}, // CALCTEXTOVERFLOW
-{ COL_LIGHTMAGENTA, COL_LIGHTMAGENTA}, // CALCCOMMENT
+{ Color(0xbf819e), Color(0xbf819e) }, // CALCCOMMENT
{ COL_LIGHTBLUE,Color(0x355269) }, // CALCDETECTIVE
{ COL_LIGHTRED, Color(0xC9211E) }, // CALCDETECTIVEERROR
{ Color(0xef0fff), Color(0x0D23D5) }, // CALCREFERENCE
Minutes from the UX/design meeting 2023-Jan-25
Present: Sahil, Eyal, Heiko Comments: Mike, Ady, Rafael Tickets/Topics * Remove status bar 'document modified' indicator + https://bugs.documentfoundation.org/show_bug.cgi?id=159073 + status not shown in title for new documents (Eyal) + title does not show the status (anymore?) but the save icon + redundant information is not bad per se, the toolbar button is primarily meant to run an action but not to give feedback (users may not expect it there) + with the Notebookbar UI it's not guaranteed to see the toolbar info + and the statusbar icon looks pretty nice => WF * Comment indicator in Calc should be red, not magenta + https://bugs.documentfoundation.org/show_bug.cgi?id=159096 + border uses now the grid line color (Heiko) + red would be a bad choice as it typically indicates errors (Mike) + yellow and red might be used for cell background (Ady) + orange (Rafael) + invert the cell background color (Ryal) + looses the customizability and becomes difficult on mid-bright colors + do it just when the picked color is close to the cell background + algorithm is tricky, and variable colors make the display busy + Magenta (a bit less glossy) is used on Excel + Light Magenta 3 is a bit too close with "Bad" cell style, Light Magenta 2 is fine (Eyal, Sahil) + works also well in dark mode => change the color * Double click on a comment in Navigator should open the cell for editing + https://bugs.documentfoundation.org/show_bug.cgi?id=158707 + in 7.4 double click goes to cell + in 7.6 single click selects, double executes the default action- in this case go-to plus editing the comment + a) edit comment, cursor at the end?, b) edit cell, cursor at the end?, c) just go-to and toggle the comment visibility, d) just go-to cell + in most cases the comment text should be readable in the Navigator and double-click is likely intended to edit the comment (all) + expect double-click to toggle show/hide; directly going into edit mode feels dangerous but just showing makes editing difficult (ctrl+alt+c) and my muscle memory is F2 to edit; so ideally we select the comment frame in order to use F2 (all) + single click does not change the view but shows this comment temporarily (until clicking somewhere else), double-click navigates to the cell, make the comment permanently visible, and double-click again hides it; when showing the comment per double-click also selects the comment for easy accessed to edit (Eyal) + double-click surely should not edit the cell content (Eyal) + comments disappear unreliably (Sahil) + having comments in a dedicated sidebar allows more flexible solutions (Sahil) => comment in ticket * When search key is not found, search text seems to be selected but is not + https://bugs.documentfoundation.org/show_bug.cgi?id=158742 + behavior has changed but still no selection is being made + changing the search term partially is more likely, ie. selection in order to overwrite completely is not intended (Heiko) + ctrl+f selects the search text in any case (Heiko) + clearly NAB/WF (Eyal) => resolve ticket OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jan-25
Present: Sahil, Eyal, Heiko Comments: Mike, Ady, Rafael Tickets/Topics * Remove status bar 'document modified' indicator + https://bugs.documentfoundation.org/show_bug.cgi?id=159073 + status not shown in title for new documents (Eyal) + title does not show the status (anymore?) but the save icon + redundant information is not bad per se, the toolbar button is primarily meant to run an action but not to give feedback (users may not expect it there) + with the Notebookbar UI it's not guaranteed to see the toolbar info + and the statusbar icon looks pretty nice => WF * Comment indicator in Calc should be red, not magenta + https://bugs.documentfoundation.org/show_bug.cgi?id=159096 + border uses now the grid line color (Heiko) + red would be a bad choice as it typically indicates errors (Mike) + yellow and red might be used for cell background (Ady) + orange (Rafael) + invert the cell background color (Ryal) + looses the customizability and becomes difficult on mid-bright colors + do it just when the picked color is close to the cell background + algorithm is tricky, and variable colors make the display busy + Magenta (a bit less glossy) is used on Excel + Light Magenta 3 is a bit too close with "Bad" cell style, Light Magenta 2 is fine (Eyal, Sahil) + works also well in dark mode => change the color * Double click on a comment in Navigator should open the cell for editing + https://bugs.documentfoundation.org/show_bug.cgi?id=158707 + in 7.4 double click goes to cell + in 7.6 single click selects, double executes the default action- in this case go-to plus editing the comment + a) edit comment, cursor at the end?, b) edit cell, cursor at the end?, c) just go-to and toggle the comment visibility, d) just go-to cell + in most cases the comment text should be readable in the Navigator and double-click is likely intended to edit the comment (all) + expect double-click to toggle show/hide; directly going into edit mode feels dangerous but just showing makes editing difficult (ctrl+alt+c) and my muscle memory is F2 to edit; so ideally we select the comment frame in order to use F2 (all) + single click does not change the view but shows this comment temporarily (until clicking somewhere else), double-click navigates to the cell, make the comment permanently visible, and double-click again hides it; when showing the comment per double-click also selects the comment for easy accessed to edit (Eyal) + double-click surely should not edit the cell content (Eyal) + comments disappear unreliably (Sahil) + having comments in a dedicated sidebar allows more flexible solutions (Sahil) => comment in ticket * When search key is not found, search text seems to be selected but is not + https://bugs.documentfoundation.org/show_bug.cgi?id=158742 + behavior has changed but still no selection is being made + changing the search term partially is more likely, ie. selection in order to overwrite completely is not intended (Heiko) + ctrl+f selects the search text in any case (Heiko) + clearly NAB/WF (Eyal) => resolve ticket OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jan-17
Present: Sahil, Cor, Hossein, John, Heiko Comments: Eike, Mike, Stephané Tickets/Topics * Styles deck: actually hide hidden leaf styles in Hierarchical view + https://bugs.documentfoundation.org/show_bug.cgi?id=158791 + only do the greyed-out thing when the style has children but hide the style completely when it’s a leaf + alternatively clean-up the styles list + some styles are used for wizards, high levels could be hidden, but in the end not much benefit (Cor, Heiko) + wouldn't hide conditionally (Heiko) + users might be not aware of hidden styles (Cor) + Stylist has plenty of filters to adjust the view (Heiko) + don't make it even more harder to use (Hossein) => WF * Let users select multiple toolbars at once to view or hide + https://bugs.documentfoundation.org/show_bug.cgi?id=158880 + integrate the toolbars list in the "User Interface" dialog (Heiko) + View > Toolbars is familiar to most users; advanced prototype could be Mozilla's (eg Firefox) edit mode (Hossein) + agree if the dialog would be additional to the menu, otherwise against (Cor) + accelerator keys are a quick way to access the menu items (Cor) + integrating into a dialog might be beneficial, a bit unclear if toolbars belong to the User Interface dialog (John) => copy the toolbar options to the UI dialog * Conditional Formatting gets overwritten + https://bugs.documentfoundation.org/show_bug.cgi?id=158724 + allow fine-tuning of protection with "[ ] Edit values" and "[ ] Format cells" so one can protect the sheet more specifically (Heiko) + unclear option, difficult to implement; rather add an extra function that blocks formatting independently from protection (Eike) + another idea: allow customization of paste per document so paste behaves like paste special > values only, or else (Heiko) + Excel shows a small widget to give a clue on alternative options, but behaves like LibreOffice (Hossein) + Warn (with option to not show again) if formatting is being overwritten (Cor) => comment * "Macros disabled" show a button "Show macros" which does not make sense + https://bugs.documentfoundation.org/show_bug.cgi?id=158600 + reasonable for "High"+ security (Mike) + keep the ability to quickly take a peek in the macro; and rather add some button [Execute anyway] (Heiko) + most users don't understand Basic and allowing the see/edit lowers the security (Hossein) + keep the Show Macro button, ie. WF (Cor) + not a big deal to have a shortcut to see/edit the button (John) + users may miss an action if the infobar does not provide any button (Hossein) => comment, in favor of WF * text file format dialogue on save -- ODF file format? + https://bugs.documentfoundation.org/show_bug.cgi?id=158624 + some benefit in using the term that users will be more familiar with, eg "Save as ODF" for Writer or "Save as ODS" for Calc (Stephané) + all are ODF anyway and most users are not familiar with file extensions either (Heiko) + change sounds good to me (John, Hossein, Sahil) + might have been changed a while again, will check (Hossein) + could be better to add the extension in the text like "This document may ... file format “Rich Text (*.rtf)”. Use the default ODF file format (*.odt) to be sure that the document is saved correctly."; with *.odt/ *.ods/*.odp etc. depending on the module (Hossein) => ask dev mentor to make it an easyhack OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jan-17
Present: Sahil, Cor, Hossein, John, Heiko Comments: Eike, Mike, Stephané Tickets/Topics * Styles deck: actually hide hidden leaf styles in Hierarchical view + https://bugs.documentfoundation.org/show_bug.cgi?id=158791 + only do the greyed-out thing when the style has children but hide the style completely when it’s a leaf + alternatively clean-up the styles list + some styles are used for wizards, high levels could be hidden, but in the end not much benefit (Cor, Heiko) + wouldn't hide conditionally (Heiko) + users might be not aware of hidden styles (Cor) + Stylist has plenty of filters to adjust the view (Heiko) + don't make it even more harder to use (Hossein) => WF * Let users select multiple toolbars at once to view or hide + https://bugs.documentfoundation.org/show_bug.cgi?id=158880 + integrate the toolbars list in the "User Interface" dialog (Heiko) + View > Toolbars is familiar to most users; advanced prototype could be Mozilla's (eg Firefox) edit mode (Hossein) + agree if the dialog would be additional to the menu, otherwise against (Cor) + accelerator keys are a quick way to access the menu items (Cor) + integrating into a dialog might be beneficial, a bit unclear if toolbars belong to the User Interface dialog (John) => copy the toolbar options to the UI dialog * Conditional Formatting gets overwritten + https://bugs.documentfoundation.org/show_bug.cgi?id=158724 + allow fine-tuning of protection with "[ ] Edit values" and "[ ] Format cells" so one can protect the sheet more specifically (Heiko) + unclear option, difficult to implement; rather add an extra function that blocks formatting independently from protection (Eike) + another idea: allow customization of paste per document so paste behaves like paste special > values only, or else (Heiko) + Excel shows a small widget to give a clue on alternative options, but behaves like LibreOffice (Hossein) + Warn (with option to not show again) if formatting is being overwritten (Cor) => comment * "Macros disabled" show a button "Show macros" which does not make sense + https://bugs.documentfoundation.org/show_bug.cgi?id=158600 + reasonable for "High"+ security (Mike) + keep the ability to quickly take a peek in the macro; and rather add some button [Execute anyway] (Heiko) + most users don't understand Basic and allowing the see/edit lowers the security (Hossein) + keep the Show Macro button, ie. WF (Cor) + not a big deal to have a shortcut to see/edit the button (John) + users may miss an action if the infobar does not provide any button (Hossein) => comment, in favor of WF * text file format dialogue on save -- ODF file format? + https://bugs.documentfoundation.org/show_bug.cgi?id=158624 + some benefit in using the term that users will be more familiar with, eg "Save as ODF" for Writer or "Save as ODS" for Calc (Stephané) + all are ODF anyway and most users are not familiar with file extensions either (Heiko) + change sounds good to me (John, Hossein, Sahil) + might have been changed a while again, will check (Hossein) + could be better to add the extension in the text like "This document may ... file format “Rich Text (*.rtf)”. Use the default ODF file format (*.odt) to be sure that the document is saved correctly."; with *.odt/ *.ods/*.odp etc. depending on the module (Hossein) => ask dev mentor to make it an easyhack OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: officecfg/registry sc/source
officecfg/registry/schema/org/openoffice/Office/Calc.xcs |8
sc/source/ui/view/output.cxx | 26 ++-
2 files changed, 20 insertions(+), 14 deletions(-)
New commits:
commit bddae0d0dc4f64757100e00432ca40a6470d2c31
Author: Heiko Tietze
AuthorDate: Tue Jan 16 13:11:06 2024 +0100
Commit: Heiko Tietze
CommitDate: Wed Jan 17 08:50:24 2024 +0100
Resolves tdf#158958 and tdf#159124 - Improvements to Comments indicator
* Option to control the indicator size added
* Border color adopts the grid color
* Indicator moved to the very edge of the cell
* Default dynamic size reduced
Change-Id: Ia298edfa30061910344a1afa42b42840b9cdab77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162175
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
index d54b092eca66..de97c822c7c1 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
@@ -105,6 +105,14 @@
true
+
+
+
+If less than 1, the size of comment indicator is calculated
dynamically; otherwise this value will be used.
+Comment indicator size
+
+ 0
+
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index 58b6db5107d3..e650c6faf774 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -31,6 +31,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -2467,7 +2468,7 @@ void ScOutputData::DrawNoteMarks(vcl::RenderContext&
rRenderContext)
nInitPosX += nMirrorW - 1; // always in pixels
tools::Long nLayoutSign = bLayoutRTL ? -1 : 1;
-tools::Long nPosY = nScrY;
+tools::Long nPosY = nScrY - 1;
for (SCSIZE nArrY=1; nArrY+1ColHidden(nX, nTab) && mpDoc->GetNote(nX,
pRowInfo[nArrY].nRowNo, nTab)
&& (bIsMerged || (!pInfo->bHOverlapped &&
!pInfo->bVOverlapped)))
{
-
-const bool bIsDarkBackground =
SC_MOD()->GetColorConfig().GetColorValue(svtools::DOCCOLOR).nColor.IsDark();
-const Color aColor(static_cast(pInfo->maBackground.getItem())->GetColor());
-if ( aColor == COL_AUTO ? bIsDarkBackground :
aColor.IsDark() )
-rRenderContext.SetLineColor(COL_WHITE);
-else
-rRenderContext.SetLineColor(COL_BLACK);
+
rRenderContext.SetLineColor(SC_MOD()->GetColorConfig().GetColorValue(svtools::CALCGRID).nColor);
const StyleSettings& rStyleSettings =
Application::GetSettings().GetStyleSettings();
if ( mbUseStyleColor &&
rStyleSettings.GetHighContrastMode() )
@@ -2506,7 +2501,7 @@ void ScOutputData::DrawNoteMarks(vcl::RenderContext&
rRenderContext)
else
rRenderContext.SetFillColor(
SC_MOD()->GetColorConfig().GetColorValue(svtools::CALCCOMMENTS).nColor );
-tools::Long nMarkX = nPosX + (
pRowInfo[0].basicCellInfo(nX).nWidth - 2 ) * nLayoutSign;
+tools::Long nMarkX = nPosX + (
pRowInfo[0].basicCellInfo(nX).nWidth - 1) * nLayoutSign;
if ( bIsMerged || pInfo->bMerged )
{
// if merged, add widths of all cells
@@ -2517,11 +2512,14 @@ void ScOutputData::DrawNoteMarks(vcl::RenderContext&
rRenderContext)
++nNextX;
}
}
-// DPI/ZOOM 100/100 => 10, 100/50 => 7, 100/150 => 13
-// DPI/ZOOM 150/100 => 13, 150/50 => 8.5, 150/150 => 17.5
-const double fSize(rRenderContext.GetDPIScaleFactor() *
aZoomX * 6 + 4);
-// Make sure we have an integer size to draw a proper
triangle
-sal_Int16 nSize = static_cast(fSize);
+// DPI/ZOOM 100/100 => 6, 100/50 => 4.5, 100/150 => 7.5
+// DPI/ZOOM 150/100 => 7.5, 150/50 => 6, 150/150 => 9
+sal_Int16 nSize =
officecfg::Office::Calc::Content::Display::NoteIndicator::get();
+if (nSize < 1)
+{
+ const double fSize(rRenderContext.GetDPIScaleFactor() *
aZoomX * 3 + 3);
+ nSize = static_cast(fSize);
+}
Point aPoints[3];
aPoints[0] = Point(nMarkX, nPosY);
aPoints[0].setX( bLayoutRTL ? aPoints[0].X() + nSize :
aPoints[0].X() - nSize );
Minutes from the UX/design meeting 2023-Jan-11
Present: Sahil, Hossein, Rafael, Heiko Comments: Stuart, Cor, Stephané, Miklos, Cor, Ady, Stephane Tickets/Topics * Implement a simple calculation of values to input size and position of draw objects + https://bugs.documentfoundation.org/show_bug.cgi?id=158685 + eg. "3+3,2" => "6,2" + Kind of a stretch for *needing* to do the simple calculations (Stuart) + could be useful for more complex stuff like "pi()/4 * 1.2345" or "sqr(sin(2)/cos(3)); similar to bug 72662 about the unit conversion (Heiko) + doubt if it is wise to start walking this path (Cor) + sounds useful (Sahil) + slash might be used as a number separator in some locales and one cannot be sure it is a divider (Hossein) + many tools provide the functionality anyway (eg. KRunner on Linux/KDE but also the search bar on Windows start a calculator) (Hossein) + very simple calculation wouldn't be enough anyway (Hossein) => WF * Move rows with protected cells does not give warning + https://bugs.documentfoundation.org/show_bug.cgi?id=158682 + agree that a message is needed (Stephané), but depending on the case + "Source contents not removed because cells are protected." + "Contents were copied but not removed because cells are protected" + "Protected cells can not be modified." (the stock message) + dragging of protected cells is not possible anyway + message box interrupts the workflow and we could also just block the drag feedback + however, paste is not available via menu/toolbar and the keyboard allows to quickly confirm (Heiko) + Agree, a similar message is useful (Hossein) + one message should be fine (Hossein) + "Protected cells cannot be dragged" + stock message is fine (Hossein) + don't change the cursor if DnD is not possible (Sahil) + could also be a blocking cursor symbol (Hossein) => show the stock message and consider the drag cursor * Original size button in image properties -> position and size tab doesn't restore original size for paper size exceeding images in Writer (and breaks image ratio) + https://bugs.documentfoundation.org/show_bug.cgi?id=158545 + rename to "Reset dimensions" (Telesto) + Word uses just "Reset" + Reason for restricting object size to page size is consistency; Writer defaults to capturing drawing objects inside the page frame (Miklos) + MSO365 allows scaling beyond the page and cuts off the extra part + seldom need for sizing beyond the page (Cor) + sizing the image beyond the page is desirable (Rafael, Hossein) + Word allows this but not to move the image out of the page + simply "Reset" and a tooltip with "Resets width and height to the original size, unless limited by the page size) + show original size as static text like in the compress dialog before the Reset button to make the function more clear (Hossein) + also keep the ratio in all cases => rename, add static size info, and fix the ratio bug * Better design for the Keep Ratio setting + https://bugs.documentfoundation.org/show_bug.cgi?id=158531 + not much benefit (Heiko) + go with a small button like in the sidebar (Rafael) + would be a toolbutton taking a lot of vertical space and + we cannot draw the connector arrows (Heiko) + what was the inspiration (Hossein) + GIMP has these buttons, for example + consistency is prime and we use typically checkboxes (Sahil) => go ahead (+2/0/-1); easy to revert * Comemnt marker makes it difficult to see the data in a cell + https://bugs.documentfoundation.org/show_bug.cgi?id=158958 + UNO command to toggle indicator on/off quickly (Stuart) + against a user-defined symbol, to revert the patch, and some default margin to make space for the symbol (Heiko) + open to UNO command to toggle the indicator on/off, a less obtrusive default color, different position for the indicator (Heiko) + suggest to add an expert options to control the dynamic size and another to disable the dynamic size (Heiko, Rafael) + use a different default color (Rafael) + is being discussed on bug 159096; maybe orange (Rafael) + make the default a bit smaller (Rafael, Heiko) + ideally do the best per code without option but if needed make it as simple as possible; option is good for now (Hossein) + good default make configuration unnecessary (at least the UI), use grid color and move the indicator to the edge (Rafael) + propose an expert value and use <=0 for dynamic size and everything else as static value (Heiko) + change is needed (Ady), expert option sounds good (Cor, Stephane) => go with the expert options OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jan-11
Present: Sahil, Hossein, Rafael, Heiko Comments: Stuart, Cor, Stephané, Miklos, Cor, Ady, Stephane Tickets/Topics * Implement a simple calculation of values to input size and position of draw objects + https://bugs.documentfoundation.org/show_bug.cgi?id=158685 + eg. "3+3,2" => "6,2" + Kind of a stretch for *needing* to do the simple calculations (Stuart) + could be useful for more complex stuff like "pi()/4 * 1.2345" or "sqr(sin(2)/cos(3)); similar to bug 72662 about the unit conversion (Heiko) + doubt if it is wise to start walking this path (Cor) + sounds useful (Sahil) + slash might be used as a number separator in some locales and one cannot be sure it is a divider (Hossein) + many tools provide the functionality anyway (eg. KRunner on Linux/KDE but also the search bar on Windows start a calculator) (Hossein) + very simple calculation wouldn't be enough anyway (Hossein) => WF * Move rows with protected cells does not give warning + https://bugs.documentfoundation.org/show_bug.cgi?id=158682 + agree that a message is needed (Stephané), but depending on the case + "Source contents not removed because cells are protected." + "Contents were copied but not removed because cells are protected" + "Protected cells can not be modified." (the stock message) + dragging of protected cells is not possible anyway + message box interrupts the workflow and we could also just block the drag feedback + however, paste is not available via menu/toolbar and the keyboard allows to quickly confirm (Heiko) + Agree, a similar message is useful (Hossein) + one message should be fine (Hossein) + "Protected cells cannot be dragged" + stock message is fine (Hossein) + don't change the cursor if DnD is not possible (Sahil) + could also be a blocking cursor symbol (Hossein) => show the stock message and consider the drag cursor * Original size button in image properties -> position and size tab doesn't restore original size for paper size exceeding images in Writer (and breaks image ratio) + https://bugs.documentfoundation.org/show_bug.cgi?id=158545 + rename to "Reset dimensions" (Telesto) + Word uses just "Reset" + Reason for restricting object size to page size is consistency; Writer defaults to capturing drawing objects inside the page frame (Miklos) + MSO365 allows scaling beyond the page and cuts off the extra part + seldom need for sizing beyond the page (Cor) + sizing the image beyond the page is desirable (Rafael, Hossein) + Word allows this but not to move the image out of the page + simply "Reset" and a tooltip with "Resets width and height to the original size, unless limited by the page size) + show original size as static text like in the compress dialog before the Reset button to make the function more clear (Hossein) + also keep the ratio in all cases => rename, add static size info, and fix the ratio bug * Better design for the Keep Ratio setting + https://bugs.documentfoundation.org/show_bug.cgi?id=158531 + not much benefit (Heiko) + go with a small button like in the sidebar (Rafael) + would be a toolbutton taking a lot of vertical space and + we cannot draw the connector arrows (Heiko) + what was the inspiration (Hossein) + GIMP has these buttons, for example + consistency is prime and we use typically checkboxes (Sahil) => go ahead (+2/0/-1); easy to revert * Comemnt marker makes it difficult to see the data in a cell + https://bugs.documentfoundation.org/show_bug.cgi?id=158958 + UNO command to toggle indicator on/off quickly (Stuart) + against a user-defined symbol, to revert the patch, and some default margin to make space for the symbol (Heiko) + open to UNO command to toggle the indicator on/off, a less obtrusive default color, different position for the indicator (Heiko) + suggest to add an expert options to control the dynamic size and another to disable the dynamic size (Heiko, Rafael) + use a different default color (Rafael) + is being discussed on bug 159096; maybe orange (Rafael) + make the default a bit smaller (Rafael, Heiko) + ideally do the best per code without option but if needed make it as simple as possible; option is good for now (Hossein) + good default make configuration unnecessary (at least the UI), use grid color and move the indicator to the edge (Rafael) + propose an expert value and use <=0 for dynamic size and everything else as static value (Heiko) + change is needed (Ady), expert option sounds good (Cor, Stephane) => go with the expert options OpenPGP_signature.asc Description: OpenPGP digital signature
Re: How to remove a file containing CR/LF from source
On 07.01.24 10:26, Andras Timar wrote: 1. git rm extras/source/templates/presnt/Growing_Liberty/readme.txt I wonder if there is a difference between rm + git add and git rm. OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: Branch 'libreoffice-24-2' - sfx2/source
sfx2/source/dialog/backingwindow.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit a19137e28c86b9ff118f3cfdd52554e7c326357c
Author: Heiko Tietze
AuthorDate: Wed Jan 3 15:48:13 2024 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Jan 5 13:38:22 2024 +0100
Resolves tdf#158810 - Hide recent actions while in template mode
Change-Id: I7291cc7a634a0507bb240bf417d346e7a50f3c6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161587
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit fc03109024041ea00bb62e90975e9a20a3668101)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161635
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/dialog/backingwindow.cxx
b/sfx2/source/dialog/backingwindow.cxx
index 846fa2ffb70e..9e30572d12d3 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -593,7 +593,7 @@ IMPL_LINK( BackingWindow, ToggleHdl, weld::Toggleable&,
rButton, void )
mxAllRecentThumbnails->GrabFocus();
mxRecentButton->set_active(true);
mxTemplateButton->set_active(false);
-mxActions->set_sensitive(true);
+mxActions->show();
}
else
{
@@ -604,7 +604,7 @@ IMPL_LINK( BackingWindow, ToggleHdl, weld::Toggleable&,
rButton, void )
mxLocalView->GrabFocus();
mxRecentButton->set_active(false);
mxTemplateButton->set_active(true);
-mxActions->set_sensitive(false);
+mxActions->hide();
}
applyFilter();
}
core.git: include/svx svx/source
include/svx/compressgraphicdialog.hxx |1 +
svx/source/dialog/compressgraphicdialog.cxx | 16 +++-
2 files changed, 12 insertions(+), 5 deletions(-)
New commits:
commit 79018bac2ed73fbfaacf661ae1272086e3ddd342
Author: Heiko Tietze
AuthorDate: Thu Jan 4 14:45:13 2024 +0100
Commit: Heiko Tietze
CommitDate: Fri Jan 5 07:36:33 2024 +0100
Resolves tdf#158780 - Disable resolution controls initially
Change-Id: I80e620085868925643d4b7561cd7aeff2d9c930f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161620
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/include/svx/compressgraphicdialog.hxx
b/include/svx/compressgraphicdialog.hxx
index 088d0b6fd45e..d46220d17a1f 100644
--- a/include/svx/compressgraphicdialog.hxx
+++ b/include/svx/compressgraphicdialog.hxx
@@ -79,6 +79,7 @@ private:
DECL_DLLPRIVATE_LINK( OkayClickHdl, weld::Button&, void );
void Update();
+void UpdateSensitivity(const bool bSensitive);
void UpdateNewWidthMF();
void UpdateNewHeightMF();
void UpdateResolutionLB();
diff --git a/svx/source/dialog/compressgraphicdialog.cxx
b/svx/source/dialog/compressgraphicdialog.cxx
index 35899bec2f5f..df1d3a8c3db6 100644
--- a/svx/source/dialog/compressgraphicdialog.cxx
+++ b/svx/source/dialog/compressgraphicdialog.cxx
@@ -108,6 +108,8 @@ void CompressGraphicsDialog::recallParameter()
m_xQualitySlider->set_value( memp.QualityMF );
m_xInterpolationCombo->set_active( memp.InterpolationCombo );
+
+UpdateSensitivity(m_xReduceResolutionCB->get_active());
}
void CompressGraphicsDialog::Initialize()
@@ -207,6 +209,14 @@ void CompressGraphicsDialog::Update()
m_xFixedText6->set_label("??");
}
+void CompressGraphicsDialog::UpdateSensitivity(const bool bSensitive)
+{
+m_xMFNewWidth->set_sensitive(bSensitive);
+m_xMFNewHeight->set_sensitive(bSensitive);
+m_xResolutionLB->set_sensitive(bSensitive);
+m_xInterpolationCombo->set_sensitive(bSensitive);
+}
+
void CompressGraphicsDialog::UpdateNewWidthMF()
{
int nPixelX = static_cast( GetViewWidthInch() * m_dResolution );
@@ -353,11 +363,7 @@ IMPL_LINK_NOARG( CompressGraphicsDialog,
ToggleCompressionRB, weld::Toggleable&,
IMPL_LINK_NOARG( CompressGraphicsDialog, ToggleReduceResolutionRB,
weld::Toggleable&, void )
{
-bool choice = m_xReduceResolutionCB->get_active();
-m_xMFNewWidth->set_sensitive(choice);
-m_xMFNewHeight->set_sensitive(choice);
-m_xResolutionLB->set_sensitive(choice);
-m_xInterpolationCombo->set_sensitive(choice);
+UpdateSensitivity(m_xReduceResolutionCB->get_active());
Update();
}
core.git: svx/source
svx/source/dialog/compressgraphicdialog.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit a5a0bb0c6577c82f5e31f1a81e31381fdf6c0c2e
Author: Heiko Tietze
AuthorDate: Thu Jan 4 12:13:44 2024 +0100
Commit: Heiko Tietze
CommitDate: Thu Jan 4 14:00:21 2024 +0100
Resolves tdf#158780 - Enable "Reduce Resolution" by default
Change-Id: Ib60f8484ebf6b140c52c7d2b6f190eac9dd3ade1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161612
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/svx/source/dialog/compressgraphicdialog.cxx
b/svx/source/dialog/compressgraphicdialog.cxx
index 8fcf479d889d..35899bec2f5f 100644
--- a/svx/source/dialog/compressgraphicdialog.cxx
+++ b/svx/source/dialog/compressgraphicdialog.cxx
@@ -45,7 +45,7 @@
namespace
{
struct memParam {
-bool ReduceResolutionCB = false;
+bool ReduceResolutionCB = true;
int MFNewWidth = 1;
int MFNewHeight = 1;
bool LosslessRB = true;
core.git: sfx2/source
sfx2/source/dialog/backingwindow.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit fc03109024041ea00bb62e90975e9a20a3668101
Author: Heiko Tietze
AuthorDate: Wed Jan 3 15:48:13 2024 +0100
Commit: Heiko Tietze
CommitDate: Thu Jan 4 11:22:50 2024 +0100
Resolves tdf#158810 - Hide recent actions while in template mode
Change-Id: I7291cc7a634a0507bb240bf417d346e7a50f3c6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161587
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sfx2/source/dialog/backingwindow.cxx
b/sfx2/source/dialog/backingwindow.cxx
index 846fa2ffb70e..9e30572d12d3 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -593,7 +593,7 @@ IMPL_LINK( BackingWindow, ToggleHdl, weld::Toggleable&,
rButton, void )
mxAllRecentThumbnails->GrabFocus();
mxRecentButton->set_active(true);
mxTemplateButton->set_active(false);
-mxActions->set_sensitive(true);
+mxActions->show();
}
else
{
@@ -604,7 +604,7 @@ IMPL_LINK( BackingWindow, ToggleHdl, weld::Toggleable&,
rButton, void )
mxLocalView->GrabFocus();
mxRecentButton->set_active(false);
mxTemplateButton->set_active(true);
-mxActions->set_sensitive(false);
+mxActions->hide();
}
applyFilter();
}
Re: [libreoffice-design] Re: Minutes from the UX/design meeting 2023-Dec-20
On 21.12.23 20:05, Eyal Rozenberg wrote: "LibreOffice unexpectedly and strangely modifies an ODT file without they user having done anything, and embedding unnecessary fonts nobody asked it to." Sounds like another facet of the font embedding. I would treat bug 158588 about what fonts are embedded (CTL/CJK/Lat and used) and handle the situation of shared documents on another. I haven't tested what happens when one checks the embed fonts option and shares this document with another person. Assuming her fonts would also be included, silently, this is at least a privacy issue. OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Dec-20
Present: Sahil, Rafael, John, Heiko Comments: Dieter, Stuart Tickets/Topics * Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui + https://bugs.documentfoundation.org/show_bug.cgi?id=158588 + improve help (Dieter, bug 130185) + dummy text with no embedded font = 28k, with all options on = 22000k with "only used" 927k, with all but limited to latin = 1800k + disable CTL & CJK depending on options and + check by default and disable the "Only used fonts" unless the first option "Embed fonts" is activated (Heiko) + if the document contains and CTL/CJK font it would be pointless to exclude them when saving used fonts only; and the other option makes not much sense alone (Rafael) + font scripts options needs a dev check => do it * FORMCONTROLS Enhancement: Fill Cell with Text Box in Calc + https://bugs.documentfoundation.org/show_bug.cgi?id=158273 + check/enable anchor to cell (resize with cell) and fit to cell size by default (Heiko) + changing this makes users needy and they may ask for better chart positioning, for example; how about a dedicated command to achieve the goal (Rafael) + could also be done per macro (Sahil) + goal was here to insert/manipulate many form controls; the workflow with copy/paste is tedious as cursor down or enter does not behave like at normal cells; which could be changed (Heiko) => comment * Incorrectly export number 0 form calc to PDF + https://bugs.documentfoundation.org/show_bug.cgi?id=158533 + option to show/include zero is on by default and one has to disable it intentionally + same behavior on Excel + dependency to some archived PDF format is unclear => ask the ESC * New sidebar deck for comments + https://bugs.documentfoundation.org/show_bug.cgi?id=106316 + splitter to expand the comments margin (Jim) + comments in margin is sufficient for ordinary users (John) + vertical space in margin is not enough for academia; management is missing, eg. to find unresolved comments (Rafael) + sidebar has limited vertical space + but allows the list being unsynchronized ie. many comments on one single page overlapping each other + requirements: add filter by status, eg. resolved no urgent need for the procrastination option "hide temporarily" + mockup design: take the Onlyoffice example https://bug-attachments.documentfoundation.org/attachment.cgi?id=191371; sort is missing; referenced text should be visible in the sidebar pane + enhancements: predefined responses? might be useful for some (Rafael), but should be done resp. the list filled by users (Sahil) + replace the comments in margin or amends it (John) => improve the mockup and ask the community in a blog post OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Dec-20
Present: Sahil, Rafael, John, Heiko Comments: Dieter, Stuart Tickets/Topics * Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui + https://bugs.documentfoundation.org/show_bug.cgi?id=158588 + improve help (Dieter, bug 130185) + dummy text with no embedded font = 28k, with all options on = 22000k with "only used" 927k, with all but limited to latin = 1800k + disable CTL & CJK depending on options and + check by default and disable the "Only used fonts" unless the first option "Embed fonts" is activated (Heiko) + if the document contains and CTL/CJK font it would be pointless to exclude them when saving used fonts only; and the other option makes not much sense alone (Rafael) + font scripts options needs a dev check => do it * FORMCONTROLS Enhancement: Fill Cell with Text Box in Calc + https://bugs.documentfoundation.org/show_bug.cgi?id=158273 + check/enable anchor to cell (resize with cell) and fit to cell size by default (Heiko) + changing this makes users needy and they may ask for better chart positioning, for example; how about a dedicated command to achieve the goal (Rafael) + could also be done per macro (Sahil) + goal was here to insert/manipulate many form controls; the workflow with copy/paste is tedious as cursor down or enter does not behave like at normal cells; which could be changed (Heiko) => comment * Incorrectly export number 0 form calc to PDF + https://bugs.documentfoundation.org/show_bug.cgi?id=158533 + option to show/include zero is on by default and one has to disable it intentionally + same behavior on Excel + dependency to some archived PDF format is unclear => ask the ESC * New sidebar deck for comments + https://bugs.documentfoundation.org/show_bug.cgi?id=106316 + splitter to expand the comments margin (Jim) + comments in margin is sufficient for ordinary users (John) + vertical space in margin is not enough for academia; management is missing, eg. to find unresolved comments (Rafael) + sidebar has limited vertical space + but allows the list being unsynchronized ie. many comments on one single page overlapping each other + requirements: add filter by status, eg. resolved no urgent need for the procrastination option "hide temporarily" + mockup design: take the Onlyoffice example https://bug-attachments.documentfoundation.org/attachment.cgi?id=191371; sort is missing; referenced text should be visible in the sidebar pane + enhancements: predefined responses? might be useful for some (Rafael), but should be done resp. the list filled by users (Sahil) + replace the comments in margin or amends it (John) => improve the mockup and ask the community in a blog post OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Dec-14
Present: Sahil, Heiko Comments: Mike, Ady, RGB Tickets/Topics * copy rules from Manage < Conditional Formatting (to apply it to a different range instead of extending it) + https://bugs.documentfoundation.org/show_bug.cgi?id=158187 + proposal is to copy the previous CF line + guess we could just always insert the same content (Heiko) + not all in all cases the CF should auto merge (Mike) + would prefer the MSO solution of paste special with adjustment of the range (Heiko) + rather add some advanced merge functionality (Ady) => comment * UI Can't trust Font feedback field + https://bugs.documentfoundation.org/show_bug.cgi?id=158261 + selecting all on Windows with Georgia being available does not lead to the same issue as on Linux without the font + we should treat this as a bug; the replacement must not mess up with the font family (Sahil) + Installing Georgia didn't change anything (Sahil) => fix it * Cross-reference dialogue in Sidebar + https://bugs.documentfoundation.org/show_bug.cgi?id=87078 + drag'n drop as recommended in bug 36310 (RGB) + drag items from the Navigator yet do not insert a hyperlink as of today but show a menu with "Page number | Chapter | Reference text || Hyperlink" => do it OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Dec-14
Present: Sahil, Heiko Comments: Mike, Ady, RGB Tickets/Topics * copy rules from Manage < Conditional Formatting (to apply it to a different range instead of extending it) + https://bugs.documentfoundation.org/show_bug.cgi?id=158187 + proposal is to copy the previous CF line + guess we could just always insert the same content (Heiko) + not all in all cases the CF should auto merge (Mike) + would prefer the MSO solution of paste special with adjustment of the range (Heiko) + rather add some advanced merge functionality (Ady) => comment * UI Can't trust Font feedback field + https://bugs.documentfoundation.org/show_bug.cgi?id=158261 + selecting all on Windows with Georgia being available does not lead to the same issue as on Linux without the font + we should treat this as a bug; the replacement must not mess up with the font family (Sahil) + Installing Georgia didn't change anything (Sahil) => fix it * Cross-reference dialogue in Sidebar + https://bugs.documentfoundation.org/show_bug.cgi?id=87078 + drag'n drop as recommended in bug 36310 (RGB) + drag items from the Navigator yet do not insert a hyperlink as of today but show a menu with "Page number | Chapter | Reference text || Hyperlink" => do it OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Dec-06
Present: Cor, Sahil, Kushi, John, Heiko Comments: Stuart, Sophie, Roman, Regina Tickets/Topics * The term "Field Shadings" is confusing + https://bugs.documentfoundation.org/show_bug.cgi?id=158291 + rename to "Spotlight Fields" (Tomas) or "Field Indicators" (Adolfo) + shading is used on some other places too such as ToC, and no good alternative anyway (Cor) + "Field Highlighting" - but not necessary (Sahil) + MS Word knows the term "Character Shading" (Heiko) + no native speaker joined the discussion (Heiko) => resolve NAB/WF * "Formattings" should be used instead of "Formats" in some cases + https://bugs.documentfoundation.org/show_bug.cgi?id=158290 + eg. "Conditional Formattings"? + distinction is rather technical, against the effort (Stuart) + up for translators to find the right term (Sophie) + term is used as such in MS Excel (Heiko) => resolve WF/NAB * Automatic scaling of icons for navigation bar + https://bugs.documentfoundation.org/show_bug.cgi?id=158394 + possible and likely workflow is to start in window mode and maximize this window; requires to adjust dynamically (Cor) + low importance (Roman) => ideally implement option 2) * No way to use correct left/right page style automatically depending on the first page number + https://bugs.documentfoundation.org/show_bug.cgi?id=148245 + use case unclear (Heiko), rather very unlikely (Cor) + page number can have any offset + proposal for solution submitted (Regina) => AI Heiko: read the comments carefully => NEEDINFO ... as in: what does Mike think about how often the scenario happens.. OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Dec-06
Present: Cor, Sahil, Kushi, John, Heiko Comments: Stuart, Sophie, Roman, Regina Tickets/Topics * The term "Field Shadings" is confusing + https://bugs.documentfoundation.org/show_bug.cgi?id=158291 + rename to "Spotlight Fields" (Tomas) or "Field Indicators" (Adolfo) + shading is used on some other places too such as ToC, and no good alternative anyway (Cor) + "Field Highlighting" - but not necessary (Sahil) + MS Word knows the term "Character Shading" (Heiko) + no native speaker joined the discussion (Heiko) => resolve NAB/WF * "Formattings" should be used instead of "Formats" in some cases + https://bugs.documentfoundation.org/show_bug.cgi?id=158290 + eg. "Conditional Formattings"? + distinction is rather technical, against the effort (Stuart) + up for translators to find the right term (Sophie) + term is used as such in MS Excel (Heiko) => resolve WF/NAB * Automatic scaling of icons for navigation bar + https://bugs.documentfoundation.org/show_bug.cgi?id=158394 + possible and likely workflow is to start in window mode and maximize this window; requires to adjust dynamically (Cor) + low importance (Roman) => ideally implement option 2) * No way to use correct left/right page style automatically depending on the first page number + https://bugs.documentfoundation.org/show_bug.cgi?id=148245 + use case unclear (Heiko), rather very unlikely (Cor) + page number can have any offset + proposal for solution submitted (Regina) => AI Heiko: read the comments carefully => NEEDINFO ... as in: what does Mike think about how often the scenario happens.. OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Nov-30
Present: Sahil, Hossein, Bogdan, Heiko Comments: Charles, John, Stuart, Miklos, Samuel Tickets/Topics * Autofilter enables deselect items automatically when typing a search + https://bugs.documentfoundation.org/show_bug.cgi?id=133836 + Patch https://gerrit.libreoffice.org/c/core/+/159737 + change All into All Selected (downside is an additional click) + add checkbox "[x] Auto Select" (downside is a more heavy UI) + consider experienced users who expect current behavior (Ady) + check other tools too (Hossein) + combining searches is only possible with the new functionality (Bogdan) => comment on BZ * The term "Track changes" is being used ungrammatically + https://bugs.documentfoundation.org/show_bug.cgi?id=158289 + "Record Track Changes" vs "Record Tracked Changes" or "Record Change Tracking" + "Change Tracking", and better under tools (Charles, John) + term is used by MSO, not worth the effort (Stuart, Heiko) + MS Word uses "Track changes" Google Docs: "review suggested edits" (Miklos) + "Track Changes" sounds good to me, "Manage Change Tracking" for example, or "Previous Change Tracking" (Sahil) + some effort to implement => WF * Forced to pick from the existing Impress templates - need to ad a Light and a Dark template + https://bugs.documentfoundation.org/show_bug.cgi?id=155609 + possible if background is transparent via Tools > Color > Light/Dark (Bogdan, Heiko) + still some ambiguity since probably light background is expected on export (Hossein) + and we ship some dark templates such as Portfolio => WFM * Copy SVG Code Directly into LibreOffice to Render Pictures + https://bugs.documentfoundation.org/show_bug.cgi?id=41119 + Insert > From Clipboard or Paste Special > As Text + why copy/paste the code when you can have the full image; better suited for an extension (Samuel) + add function similar to "Import MathML from Clipboard" (Regina) + allows to tweak and inspect the SVG code (Stuart) + wonder what happens when one pastes just a part on top of an existing image, -1/WF (Heiko, Hossein) + if editing when pasting complex content is the natural next step, would we also allow to modify ODF or HTML data (Hossein) + Pasting without editing would be meaningless, and those together requires big effort (Hossein) + not much interest in this feature over the years => resolve WF * Shapes-via-Gallery is problematic & partially redundant with the Shapes sub-toolbars and sidebar + https://bugs.documentfoundation.org/show_bug.cgi?id=158253 + no point in changing the Gallery (Stuart) + the Gallery is a place for various content being sorted currently by tasks mostly; if we remove the line drawings, for example, it might become more polished but we loose functionality; nevertheless some items might be worth to challenge (Heiko) + categorization is in fact not perfect but providing improvements to the Gallery is beyond one ticket (Hossein) + not a fan of removing content rather better categorization (Hossein) => ticket not actionable => WF OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Nov-30
Present: Sahil, Hossein, Bogdan, Heiko Comments: Charles, John, Stuart, Miklos, Samuel Tickets/Topics * Autofilter enables deselect items automatically when typing a search + https://bugs.documentfoundation.org/show_bug.cgi?id=133836 + Patch https://gerrit.libreoffice.org/c/core/+/159737 + change All into All Selected (downside is an additional click) + add checkbox "[x] Auto Select" (downside is a more heavy UI) + consider experienced users who expect current behavior (Ady) + check other tools too (Hossein) + combining searches is only possible with the new functionality (Bogdan) => comment on BZ * The term "Track changes" is being used ungrammatically + https://bugs.documentfoundation.org/show_bug.cgi?id=158289 + "Record Track Changes" vs "Record Tracked Changes" or "Record Change Tracking" + "Change Tracking", and better under tools (Charles, John) + term is used by MSO, not worth the effort (Stuart, Heiko) + MS Word uses "Track changes" Google Docs: "review suggested edits" (Miklos) + "Track Changes" sounds good to me, "Manage Change Tracking" for example, or "Previous Change Tracking" (Sahil) + some effort to implement => WF * Forced to pick from the existing Impress templates - need to ad a Light and a Dark template + https://bugs.documentfoundation.org/show_bug.cgi?id=155609 + possible if background is transparent via Tools > Color > Light/Dark (Bogdan, Heiko) + still some ambiguity since probably light background is expected on export (Hossein) + and we ship some dark templates such as Portfolio => WFM * Copy SVG Code Directly into LibreOffice to Render Pictures + https://bugs.documentfoundation.org/show_bug.cgi?id=41119 + Insert > From Clipboard or Paste Special > As Text + why copy/paste the code when you can have the full image; better suited for an extension (Samuel) + add function similar to "Import MathML from Clipboard" (Regina) + allows to tweak and inspect the SVG code (Stuart) + wonder what happens when one pastes just a part on top of an existing image, -1/WF (Heiko, Hossein) + if editing when pasting complex content is the natural next step, would we also allow to modify ODF or HTML data (Hossein) + Pasting without editing would be meaningless, and those together requires big effort (Hossein) + not much interest in this feature over the years => resolve WF * Shapes-via-Gallery is problematic & partially redundant with the Shapes sub-toolbars and sidebar + https://bugs.documentfoundation.org/show_bug.cgi?id=158253 + no point in changing the Gallery (Stuart) + the Gallery is a place for various content being sorted currently by tasks mostly; if we remove the line drawings, for example, it might become more polished but we loose functionality; nevertheless some items might be worth to challenge (Heiko) + categorization is in fact not perfect but providing improvements to the Gallery is beyond one ticket (Hossein) + not a fan of removing content rather better categorization (Hossein) => ticket not actionable => WF OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-commits] core.git: svx/source
svx/source/form/labelitemwindow.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 48ba98a51f029cd14b5d982dab36eb581d40fef3
Author: Heiko Tietze
AuthorDate: Wed Nov 29 14:29:57 2023 +0100
Commit: Heiko Tietze
CommitDate: Thu Nov 30 11:41:38 2023 +0100
Resolves tdf#158412 - Don't show chevron in quick find bar
Change-Id: I50f0bb7d8a406b77baccc626ca99b656d170ecf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160093
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/svx/source/form/labelitemwindow.cxx
b/svx/source/form/labelitemwindow.cxx
index 1ccbe6c5d156..c9afd1534acc 100644
--- a/svx/source/form/labelitemwindow.cxx
+++ b/svx/source/form/labelitemwindow.cxx
@@ -50,7 +50,8 @@ void LabelItemWindow::set_label(const OUString& rLabel, const
LabelItemWindowTyp
m_xLabel->set_font_color(Color(0x00, 0x47, 0x85));
m_xBox->set_background(Color(0xBD, 0xE5, 0xF8)); // same as
InfobarType::INFO
}
-m_xLabel->set_visible(!rLabel.isEmpty());
+m_xLabel->set_visible(
+true); // always show and not just if !rLabel.isEmpty() to not make
the chevron appear
}
OUString LabelItemWindow::get_label() const { return m_xLabel->get_label(); }
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/linetabpage.ui| 460 ++ cui/uiconfig/ui/possizetabpage.ui | 260 ++--- 2 files changed, 355 insertions(+), 365 deletions(-) New commits: commit fe946f86ad6586fa810cae5c0f246389a285e172 Author: Heiko Tietze AuthorDate: Wed Nov 29 15:25:06 2023 +0100 Commit: Heiko Tietze CommitDate: Thu Nov 30 11:40:59 2023 +0100 Bump Glade version Change-Id: If440010790e170fa1c88b8cbdef5f7eaa3efd686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160108 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/cui/uiconfig/ui/linetabpage.ui b/cui/uiconfig/ui/linetabpage.ui index a7138e2ebd9b..2a2c1b2e15f5 100644 --- a/cui/uiconfig/ui/linetabpage.ui +++ b/cui/uiconfig/ui/linetabpage.ui @@ -1,36 +1,36 @@ - + 20 -0.05 -1 +0.05 +1 100 -5 -10 +5 +10 5 -0.1 -1 +0.10 +1 5 -0.1 -1 +0.10 +1 5 -0.1 -1 +0.10 +1 20 -0.05 -1 +0.05 +1 @@ -70,41 +70,41 @@ True -False +False True -False +False _No Symbol -True +True True -False +False _Automatic -True +True True -False +False _From file... -True +True True -False +False _Gallery -True +True True -False +False @@ -112,13 +112,13 @@ True -False +False _Symbols -True +True True -False +False @@ -126,45 +126,45 @@ True -False +False True True -6 +6 vertical 12 - + True -False -12 -24 +False +12 +24 True -False -0 -none +False +0 +none True -False -vertical -3 +False 12 6 +vertical +3 True -False +False 6 True -False +False _Style: -True -LB_LINE_STYLE +True +LB_LINE_STYLE 0 @@ -176,10 +176,10 @@ True -False +False liststore5 -0 -1 +0 +1 @@ -188,9 +188,6 @@ - -3 - @@ -209,15 +206,15 @@ True -False +False 6 True -False +False Colo_r: -True -LB_COLOR +True +LB_COLOR 0 @@ -229,11 +226,10 @@ True -True -False +True +False 0 -True - +True @@ -254,15 +250,15 @@ True -False +False 6 True -False
[Libreoffice-commits] core.git: svx/source svx/uiconfig
svx/source/dialog/srchdlg.cxx|1 +
svx/source/form/labelitemwindow.cxx |1 +
svx/uiconfig/ui/findreplacedialog.ui | 11 ++-
svx/uiconfig/ui/labelbox.ui |2 +-
4 files changed, 9 insertions(+), 6 deletions(-)
New commits:
commit 5a622f1a29d249a512cc24f99d189f748623c678
Author: Heiko Tietze
AuthorDate: Tue Nov 28 11:10:58 2023 +0100
Commit: Heiko Tietze
CommitDate: Tue Nov 28 14:33:18 2023 +0100
Related tdf#156227 - Find/quickfind design
Themed icons look bad when drawn white on light blue;
using the same icon as on the infobar makes more sense
Change-Id: I6b4fd2bac7dce41b8196c702e0f0dc87712e2b8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160017
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/svx/source/dialog/srchdlg.cxx b/svx/source/dialog/srchdlg.cxx
index b5cf7bcf34fd..b1c87a6db7c8 100644
--- a/svx/source/dialog/srchdlg.cxx
+++ b/svx/source/dialog/srchdlg.cxx
@@ -344,6 +344,7 @@ SvxSearchDialog::SvxSearchDialog(weld::Window* pParent,
SfxChildWindow* pChildWi
m_xSearchLabel->set_font_color(Color(0x00, 0x47, 0x85));
this->SetSearchLabel(""); // hide the message but keep the box height
+m_xSearchIcon->set_size_request(24, 24); // vcl/res/infobar.png is 32x32 -
too large here
m_xReplaceTmplLB->make_sorted();
m_xReplaceAttrText->hide();
diff --git a/svx/source/form/labelitemwindow.cxx
b/svx/source/form/labelitemwindow.cxx
index bdff03e060f2..1ccbe6c5d156 100644
--- a/svx/source/form/labelitemwindow.cxx
+++ b/svx/source/form/labelitemwindow.cxx
@@ -19,6 +19,7 @@ LabelItemWindow::LabelItemWindow(vcl::Window* pParent, const
OUString& rLabel)
m_xLabel->set_label(rLabel);
m_xImage->hide();
+m_xImage->set_size_request(24, 24); // vcl/res/infobar.png is 32x32 - too
large here
SetOptimalSize();
diff --git a/svx/uiconfig/ui/findreplacedialog.ui
b/svx/uiconfig/ui/findreplacedialog.ui
index 57a16e666a2f..e915a647f710 100644
--- a/svx/uiconfig/ui/findreplacedialog.ui
+++ b/svx/uiconfig/ui/findreplacedialog.ui
@@ -290,15 +290,16 @@
True
False
+center
6
3
3
3
-res/info.png
+vcl/res/infobox.png
-
-Search icon
-
+
+Search icon
+
@@ -323,7 +324,7 @@
0
- notification
+notification
diff --git a/svx/uiconfig/ui/labelbox.ui b/svx/uiconfig/ui/labelbox.ui
index f77cd5da7f4e..29210661b91c 100644
--- a/svx/uiconfig/ui/labelbox.ui
+++ b/svx/uiconfig/ui/labelbox.ui
@@ -15,7 +15,7 @@
6
3
3
-res/info.png
+vcl/res/infobox.png
False
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/swpossizepage.ui | 424 +++ 1 file changed, 212 insertions(+), 212 deletions(-) New commits: commit cb70626ccb63e09f3a4130fd115a29ac79d823f2 Author: Heiko Tietze AuthorDate: Thu Nov 23 17:21:50 2023 +0100 Commit: Heiko Tietze CommitDate: Fri Nov 24 17:06:31 2023 +0100 Bump Glade version Change-Id: Icea5b88e0e8281803a5deb09619476cccff3b39c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159866 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/cui/uiconfig/ui/swpossizepage.ui b/cui/uiconfig/ui/swpossizepage.ui index 17ab225bf276..399dc211c02d 100644 --- a/cui/uiconfig/ui/swpossizepage.ui +++ b/cui/uiconfig/ui/swpossizepage.ui @@ -1,78 +1,78 @@ - + 0.05 -99.99 -1 -10 +99.98 +1 +10 --99.99 -99.99 -1 -10 +-99.98 +99.98 +1 +10 --99.99 -99.99 -1 -10 +-99.98 +99.98 +1 +10 0.05 -99.99 -1 -10 +99.98 +1 +10 - + True -False +False True -6 -12 +6 +12 - + True -False +False True True -6 -12 +6 +12 True -False +False start True -0 -none +0 +none - + True -False -True -6 +False 12 6 +True +6 - + True -False -12 +False +12 True -True -True +True +True +True adjustment1 2 -True Enter the width that you want for the selected object. @@ -80,44 +80,44 @@ -1 -0 +1 +0 True -False +False _Width: -True -width +True +width 0 -0 -0 +0 +0 -0 -0 +0 +0 - + True -False -12 +False +12 True -True -True +True +True +True adjustment4 2 -True Enter the height that you want for the selected object. @@ -125,38 +125,38 @@ -1 -0 +1 +0 True -False +False H_eight: -True -height +True +height 0 -0 -0 +0 +0 -0 -1 +0 +1
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Nov-22
Present: Maija, Sahil, Julia, Eyal, John, Cor, Heiko Comments: LeroyG, Mike, Ady, Rafael, Werner, Tomaz, Csongor Tickets/Topics * Conducting a survey around LibreOffice + How often would you accept a nag screen? + Would you appreciate a welcome screen with some initial questions? + ... + to bring the results into something actionable is challenging but expected by the participants (Cor) * Inconsistent behavior of "New style from selection" in Styles list and Styles menu + https://bugs.documentfoundation.org/show_bug.cgi?id=151563 + works as expected in the Stylist but not anywhere else + add the "paragraph" to the string, at least (LeroyG) + alternative commands for every individual style (Mike) + not obvious that the command uno:StyleNewByExample is needed in menu/toolbar/shortcut (Eyal) + not so important (Cor, John) + drop customizability and access in the UI except the Stylist (Heiko) + drawback is that one needs to activate the Stylist + extra UNO commands would be needed for the Notebookbars too (John) + change just the title for now (Cor, Eyal) + PS can be added by directly adding the name to the styles toolbar control and we could provide an analogue control for CS (Cor) => change command title * add UNO command for Hidden font effect of characters in Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=158168 + easy to customize via user-defined character style (Heiko) + disagree since it means to multiply CS (Eyal) + suggest to add it as DF (Eyal, John) + depending on the use case it be necessary to add the attribute on top of any format; example workflow is to have words in different language next to each other and hide one or the other (Cor) + but tend to agree with WF/NAB (Cor) => add UNO command (but dont show on the UI by default) * Sidebar pane shortcuts conflict with Alt+NumPad input + https://bugs.documentfoundation.org/show_bug.cgi?id=158112 + alt+num code is used to insert characters not on the keyboard (Ady) + make it depending on the OS/DE (Eyal) + use alt+shift+ (Heiko) + Acceptable (Eyal) + remove shortcuts, or make it so users can customize it + no so good (Eyal) + involve a11y into the discussion (Eyal) + ctrl+alt+ is available for customization! => comment * Add 'shuffle' or 'random' option to 'Sort' dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=158196 + functionality not available in Excel too + agree to the need for UNO command to shuffling cell range, rows, columns (Rafael) + better suited for Sheet > Fill Cells (Werner) + definitely not (Tomaz) + frequently needed; best suited for the sort dialog as another option after ascending/descending (Csongor) + wonder if randomization needs to have a start value to get the same result repeatedly (Eyal) + should not (Cor) + expect it as extra command under Data among Sort (John) + bloats the dialog (Cor) + would rather like to see it in the dialog; would be more visible (Eyal) + hard to wrap the mind around sort first by col A, the by random B, and finally by C (Heiko) => UNO command might be the best choice OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Nov-22
Present: Maija, Sahil, Julia, Eyal, John, Cor, Heiko Comments: LeroyG, Mike, Ady, Rafael, Werner, Tomaz, Csongor Tickets/Topics * Conducting a survey around LibreOffice + How often would you accept a nag screen? + Would you appreciate a welcome screen with some initial questions? + ... + to bring the results into something actionable is challenging but expected by the participants (Cor) * Inconsistent behavior of "New style from selection" in Styles list and Styles menu + https://bugs.documentfoundation.org/show_bug.cgi?id=151563 + works as expected in the Stylist but not anywhere else + add the "paragraph" to the string, at least (LeroyG) + alternative commands for every individual style (Mike) + not obvious that the command uno:StyleNewByExample is needed in menu/toolbar/shortcut (Eyal) + not so important (Cor, John) + drop customizability and access in the UI except the Stylist (Heiko) + drawback is that one needs to activate the Stylist + extra UNO commands would be needed for the Notebookbars too (John) + change just the title for now (Cor, Eyal) + PS can be added by directly adding the name to the styles toolbar control and we could provide an analogue control for CS (Cor) => change command title * add UNO command for Hidden font effect of characters in Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=158168 + easy to customize via user-defined character style (Heiko) + disagree since it means to multiply CS (Eyal) + suggest to add it as DF (Eyal, John) + depending on the use case it be necessary to add the attribute on top of any format; example workflow is to have words in different language next to each other and hide one or the other (Cor) + but tend to agree with WF/NAB (Cor) => add UNO command (but dont show on the UI by default) * Sidebar pane shortcuts conflict with Alt+NumPad input + https://bugs.documentfoundation.org/show_bug.cgi?id=158112 + alt+num code is used to insert characters not on the keyboard (Ady) + make it depending on the OS/DE (Eyal) + use alt+shift+ (Heiko) + Acceptable (Eyal) + remove shortcuts, or make it so users can customize it + no so good (Eyal) + involve a11y into the discussion (Eyal) + ctrl+alt+ is available for customization! => comment * Add 'shuffle' or 'random' option to 'Sort' dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=158196 + functionality not available in Excel too + agree to the need for UNO command to shuffling cell range, rows, columns (Rafael) + better suited for Sheet > Fill Cells (Werner) + definitely not (Tomaz) + frequently needed; best suited for the sort dialog as another option after ascending/descending (Csongor) + wonder if randomization needs to have a start value to get the same result repeatedly (Eyal) + should not (Cor) + expect it as extra command under Data among Sort (John) + bloats the dialog (Cor) + would rather like to see it in the dialog; would be more visible (Eyal) + hard to wrap the mind around sort first by col A, the by random B, and finally by C (Heiko) => UNO command might be the best choice OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Nov-16
Present: Hossein, Sahil, Heiko Comments: Miguel, Regina, Cor Tickets/Topics * No hotkey to apply cloned formatting + https://bugs.documentfoundation.org/show_bug.cgi?id=156404 + ticket was set to fixed by removing the customizability for the UNO command + Clone formatting is a complex interaction with single click to apply once and double to apply until escaped; this complexity cannot put into a command (but could be done in a simple way) + we do have Repeat (shift+ctrl+Y), which applies the formatting, if this was the last operation, to the current selection (Heiko) + no strong opinion, suggest to be compatible with other programs (Hossein) + in fact MSO allows to copy per ctrl+shift+C and paste from this buffer at any time later per ctrl+shift+V => introduce the UNO command * Setting language for Selection/Paragraph/All text can't be shortcut + https://bugs.documentfoundation.org/show_bug.cgi?id=157648 + it's a bug, if pasting w/o format does not work (Cor) + possible solution is to define a character style with the preferred language, use tools > customize > keyboard: styles > character styles to assign a shortcut to this style (ideally you do this in a template); select text and apply the style per shortcut then (Hossein) => no further shortcut needed, WF * UI: Resizing of a selection of columns/rows should correspond to the mouse position + https://bugs.documentfoundation.org/show_bug.cgi?id=157945 + do not resize (all columns) to the width of the currently dragged column but divide the sum by the number of columns so the mouse position remains after releasing it (Cor) + sounds reasonable to me, rather with a modifier key such as ctrl to keep the old behavior too (Heiko) + same in Excel and suggest to not break the current behavior (Hossein) => do it * Feature request: Editing, Formatting, UI. Option to add linebreaks when merging cells into one + https://bugs.documentfoundation.org/show_bug.cgi?id=158034 + agree to use cr/lf (for rows) and tab (for columns) when merging cells (and split later with this information) (Miguel, Cor, Heiko) + doubt it can be considered generally (Hossein) + undo needs to be considered, tab/linefeed have special meaning => comment * Need a rectangular-brace-pair callout shape + https://bugs.documentfoundation.org/show_bug.cgi?id=157879 + good for an extension; attached to the ticket (Regina) + the Gallery > Shapes has some good callout examples (Hossein) + adding such shape leads to compatibility issues + possible to get square brackets from round (Heiko) + but this wont be a callout (Eyal) + compatibility bug should be filed (Hossein) + having the default shapes from other shapes in LibreOffice makes sense (Hossein) + adding too many shapes make access difficult and we should do it only for absolutely necessary content, WF (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Nov-16
Present: Hossein, Sahil, Heiko Comments: Miguel, Regina, Cor Tickets/Topics * No hotkey to apply cloned formatting + https://bugs.documentfoundation.org/show_bug.cgi?id=156404 + ticket was set to fixed by removing the customizability for the UNO command + Clone formatting is a complex interaction with single click to apply once and double to apply until escaped; this complexity cannot put into a command (but could be done in a simple way) + we do have Repeat (shift+ctrl+Y), which applies the formatting, if this was the last operation, to the current selection (Heiko) + no strong opinion, suggest to be compatible with other programs (Hossein) + in fact MSO allows to copy per ctrl+shift+C and paste from this buffer at any time later per ctrl+shift+V => introduce the UNO command * Setting language for Selection/Paragraph/All text can't be shortcut + https://bugs.documentfoundation.org/show_bug.cgi?id=157648 + it's a bug, if pasting w/o format does not work (Cor) + possible solution is to define a character style with the preferred language, use tools > customize > keyboard: styles > character styles to assign a shortcut to this style (ideally you do this in a template); select text and apply the style per shortcut then (Hossein) => no further shortcut needed, WF * UI: Resizing of a selection of columns/rows should correspond to the mouse position + https://bugs.documentfoundation.org/show_bug.cgi?id=157945 + do not resize (all columns) to the width of the currently dragged column but divide the sum by the number of columns so the mouse position remains after releasing it (Cor) + sounds reasonable to me, rather with a modifier key such as ctrl to keep the old behavior too (Heiko) + same in Excel and suggest to not break the current behavior (Hossein) => do it * Feature request: Editing, Formatting, UI. Option to add linebreaks when merging cells into one + https://bugs.documentfoundation.org/show_bug.cgi?id=158034 + agree to use cr/lf (for rows) and tab (for columns) when merging cells (and split later with this information) (Miguel, Cor, Heiko) + doubt it can be considered generally (Hossein) + undo needs to be considered, tab/linefeed have special meaning => comment * Need a rectangular-brace-pair callout shape + https://bugs.documentfoundation.org/show_bug.cgi?id=157879 + good for an extension; attached to the ticket (Regina) + the Gallery > Shapes has some good callout examples (Hossein) + adding such shape leads to compatibility issues + possible to get square brackets from round (Heiko) + but this wont be a callout (Eyal) + compatibility bug should be filed (Hossein) + having the default shapes from other shapes in LibreOffice makes sense (Hossein) + adding too many shapes make access difficult and we should do it only for absolutely necessary content, WF (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/thumbnailview.hxx |2 --
include/sfx2/thumbnailviewitem.hxx |2 --
sfx2/source/control/recentdocsview.cxx |4 +---
sfx2/source/control/templatedefaultview.cxx |4 +---
sfx2/source/control/templateviewitem.cxx|2 +-
sfx2/source/control/thumbnailview.cxx |4
sfx2/source/control/thumbnailviewitem.cxx |7 ++-
7 files changed, 5 insertions(+), 20 deletions(-)
New commits:
commit adfb0a34af196befc46527418f6e870d1f8f1889
Author: Heiko Tietze
AuthorDate: Tue Nov 14 11:35:43 2023 +0100
Commit: Heiko Tietze
CommitDate: Tue Nov 14 13:26:53 2023 +0100
Resolves tdf#158084 - Start Center hover color
Selected colors removed since hovering leads to selection
(or execution) and does not need a special color
Transparency for reccent documents and templates in start center
increased to make the difference to selected more clear
Change-Id: Iab52150cd5a93e2f6ff716921b2aa7d093018b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159407
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx
index a51db9df048b..655aa3ba13e5 100644
--- a/include/sfx2/thumbnailview.hxx
+++ b/include/sfx2/thumbnailview.hxx
@@ -313,8 +313,6 @@ protected:
Color maTextColor; ///< Text color.
Color maHighlightColor; ///< Color of the highlight (background)
of the hovered item.
Color maHighlightTextColor; ///< Color of the text for the highlighted
item.
-Color maSelectHighlightColor; ///< Color of the highlight (background)
of the selected and hovered item.
-Color maSelectHighlightTextColor; ///< Color of the text of the selected
and hovered item.
double mfHighlightTransparence; ///< Transparence of the highlight.
Link maItemStateHdl;
diff --git a/include/sfx2/thumbnailviewitem.hxx
b/include/sfx2/thumbnailviewitem.hxx
index 9495b08054e3..22020c47728d 100644
--- a/include/sfx2/thumbnailviewitem.hxx
+++ b/include/sfx2/thumbnailviewitem.hxx
@@ -56,8 +56,6 @@ struct ThumbnailItemAttributes
basegfx::BColor aTextColor;
basegfx::BColor aHighlightColor;
basegfx::BColor aHighlightTextColor;
-basegfx::BColor aSelectHighlightColor;
-basegfx::BColor aSelectHighlightTextColor;
double fHighlightTransparence;
basegfx::B2DVector aFontSize;
drawinglayer::attribute::FontAttribute aFontAttr;
diff --git a/sfx2/source/control/recentdocsview.cxx
b/sfx2/source/control/recentdocsview.cxx
index 055dc6962423..6df534788a32 100644
--- a/sfx2/source/control/recentdocsview.cxx
+++ b/sfx2/source/control/recentdocsview.cxx
@@ -80,10 +80,8 @@
RecentDocsView::RecentDocsView(std::unique_ptr xWindow, st
const StyleSettings& rSettings =
Application::GetSettings().GetStyleSettings();
maHighlightColor = rSettings.GetHighlightColor();
maHighlightTextColor = rSettings.GetHighlightTextColor();
-maSelectHighlightColor = rSettings.GetActiveColor();
-maSelectHighlightTextColor = rSettings.GetActiveTextColor();
-mfHighlightTransparence = 0.25;
+mfHighlightTransparence = 0.75;
UpdateColors();
}
diff --git a/sfx2/source/control/templatedefaultview.cxx
b/sfx2/source/control/templatedefaultview.cxx
index 34d40875d23c..909545e423ce 100644
--- a/sfx2/source/control/templatedefaultview.cxx
+++ b/sfx2/source/control/templatedefaultview.cxx
@@ -37,10 +37,8 @@
TemplateDefaultView::TemplateDefaultView(std::unique_ptr x
const StyleSettings& rSettings =
Application::GetSettings().GetStyleSettings();
maHighlightColor = rSettings.GetHighlightColor();
maHighlightTextColor = rSettings.GetHighlightTextColor();
-maSelectHighlightColor = rSettings.GetActiveColor();
-maSelectHighlightTextColor = rSettings.GetActiveTextColor();
-mfHighlightTransparence = 0.25;
+mfHighlightTransparence = 0.75;
UpdateColors();
}
diff --git a/sfx2/source/control/templateviewitem.cxx
b/sfx2/source/control/templateviewitem.cxx
index 28ff1f43133c..d28ad50f74cd 100644
--- a/sfx2/source/control/templateviewitem.cxx
+++ b/sfx2/source/control/templateviewitem.cxx
@@ -61,7 +61,7 @@ void
TemplateViewItem::Paint(drawinglayer::processor2d::BaseProcessor2D *pProces
// Draw background
if( mbSelected && mbHover)
-aFillColor = pAttrs->aSelectHighlightColor;
+aFillColor = pAttrs->aHighlightColor;
else if (mbSelected || mbHover)
{
aFillColor = pAttrs->aHighlightColor;
diff --git a/sfx2/source/control/thumbnailview.cxx
b/sfx2/source/control/thumbnailview.cxx
index 2d4e8bb57611..abb9f9799e34 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -253,8 +253,6 @@ void ThumbnailView::ImplInit()
maTextColor = rSettings.GetWindowTextColor();
maHighlightColor = rSettings.Get
[Libreoffice-commits] core.git: officecfg/registry sfx2/source
officecfg/registry/schema/org/openoffice/Office/Common.xcs | 14 - sfx2/source/control/recentdocsview.cxx |9 ++-- sfx2/source/control/templatedefaultview.cxx|9 ++-- 3 files changed, 14 insertions(+), 18 deletions(-) New commits: commit 285a3e8d8b77b44da3dcc767877f878fe0e0493e Author: Heiko Tietze AuthorDate: Fri Nov 10 10:12:39 2023 +0100 Commit: Heiko Tietze CommitDate: Mon Nov 13 10:40:30 2023 +0100 Resolves tdf#158084 - Use system colors in start center StartCenterThumbnailsHighlightColor and StartCenterThumbnailsHighlightTextColor removed in favor of StyleSettings.GetHighlightColor and .GetActiveColor Change-Id: I7005b17f6c48525c791f23ea99b7b68e7a67531b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159286 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index 76aa4e6c02d9..c551044a350d 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -3400,20 +3400,6 @@ 15658734 - - - -Specifies the background color of the highlight of a thumbnail in the start center. - - 14540253 - - - - -Specifies the text color of the highlight of a thumbnail in the start center. - - 3355443 - diff --git a/sfx2/source/control/recentdocsview.cxx b/sfx2/source/control/recentdocsview.cxx index cc2e80de17e9..055dc6962423 100644 --- a/sfx2/source/control/recentdocsview.cxx +++ b/sfx2/source/control/recentdocsview.cxx @@ -76,8 +76,13 @@ RecentDocsView::RecentDocsView(std::unique_ptr xWindow, st maFillColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsBackgroundColor::get()); maTextColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsTextColor::get()); -maHighlightColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsHighlightColor::get()); -maHighlightTextColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsHighlightTextColor::get()); + +const StyleSettings& rSettings = Application::GetSettings().GetStyleSettings(); +maHighlightColor = rSettings.GetHighlightColor(); +maHighlightTextColor = rSettings.GetHighlightTextColor(); +maSelectHighlightColor = rSettings.GetActiveColor(); +maSelectHighlightTextColor = rSettings.GetActiveTextColor(); + mfHighlightTransparence = 0.25; UpdateColors(); diff --git a/sfx2/source/control/templatedefaultview.cxx b/sfx2/source/control/templatedefaultview.cxx index 17ad2ba7cbda..34d40875d23c 100644 --- a/sfx2/source/control/templatedefaultview.cxx +++ b/sfx2/source/control/templatedefaultview.cxx @@ -33,8 +33,13 @@ TemplateDefaultView::TemplateDefaultView(std::unique_ptr x // startcenter specific settings maFillColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsBackgroundColor::get()); maTextColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsTextColor::get()); -maHighlightColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsHighlightColor::get()); -maHighlightTextColor = Color(ColorTransparency, officecfg::Office::Common::Help::StartCenter::StartCenterThumbnailsHighlightTextColor::get()); + +const StyleSettings& rSettings = Application::GetSettings().GetStyleSettings(); +maHighlightColor = rSettings.GetHighlightColor(); +maHighlightTextColor = rSettings.GetHighlightTextColor(); +maSelectHighlightColor = rSettings.GetActiveColor(); +maSelectHighlightTextColor = rSettings.GetActiveTextColor(); + mfHighlightTransparence = 0.25; UpdateColors();
Minutes from the UX/design meeting 2023-Nov-08
Present: Eyal, Cor, Sahil, John, Hossein, Heiko Comments: Stephane, Regina, Eike, Timur, Jean-Baptiste Tickets/Topics * Add the possibility to save and load custom predefined settings for Text Import in Calc + https://bugs.documentfoundation.org/show_bug.cgi?id=156879 + Data Provider could be a solution, though it's experimental (Heiko) + can follow the use case (Eyal, Cor) + possible solution is to remember the last settings (Eyal) + in a first solution we could just remember the checkboxes + previous column types could be used if the number matches + does not clutter the UI (Heiko) + to load presets could be done too but would be a heavy interaction and kind of over-engineering + multi-selection of columns to batch apply a type is helpful too - which is possible in the current version (Cor) => remember the last settings, if multi-selection is not sufficient * UI Feature Request: Possibility to hide a page like in Impress + https://bugs.documentfoundation.org/show_bug.cgi?id=156802 + can follow the use case (Stephane) + always possible to exclude pages on printing/exporting to PDF (Regina, Cor, John) + against "hide" because of the semantics but agree with means to remember a print range (Eyal) => resolve WF and suggest to file a new ticket for print range * AUTOFILTER : Doesn't work with 2 words like "CP" and "Mi-CP" or "MiCP" + https://bugs.documentfoundation.org/show_bug.cgi?id=157878 + Tools/Options/Calc/Calculate:Apply to whole cells should do the trick (Miguel) + AutoFilter should be independent of that option (Eike) + always compare the autofilter against the entire cell; the fuzzy search/filter could be done by multi-selecting *CP* per search for CP => change the behavior to always apply the autofilter to the entire cell * PDF restrictions in signed PDF documents + https://bugs.documentfoundation.org/show_bug.cgi?id=143134 + it's normal that you cannot add comments in signed file (Timur) + non example for the opposite; signed document should stay unchanged (Heiko) + some environments exist where the signed document has an attached commenting workflow; will ask on the ticket (Cor) + it might be a flag to allow comments in signed PDFs (Hossein) + possible with Adobe software (Cor) => not a topic for UX * Ability to navigate via viewing area on charts + https://bugs.documentfoundation.org/show_bug.cgi?id=138509 + good for an extension (Jean-Baptiste) + 1. Ability to Zoom in + good idea (Eyal, John, Cor) + over-engineering; advanced chart functions are better suited for specialized tools (Heiko) + 2. Ability to Select data range + same as above (Heiko) + support this too (Eyal, John, Cor) + if we want to improve on this area we should include R with some libraries * Ability to hover on charts to quickly visualize details + https://bugs.documentfoundation.org/show_bug.cgi?id=138510 + we do show tooltips, but chart needs to be in edit mode (Heiko) + good idea, maybe worth a META ticket (Eyal) => comment * Tabbed interface: Overflow the tabbed interface to scroll/flip instead of a popup + https://bugs.documentfoundation.org/show_bug.cgi?id=158123 + Importance of making tabbed feature usable on different screen size (Hossein) + alternative overflow mechanism has pro and cons (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Nov-08
Present: Eyal, Cor, Sahil, John, Hossein, Heiko Comments: Stephane, Regina, Eike, Timur, Jean-Baptiste Tickets/Topics * Add the possibility to save and load custom predefined settings for Text Import in Calc + https://bugs.documentfoundation.org/show_bug.cgi?id=156879 + Data Provider could be a solution, though it's experimental (Heiko) + can follow the use case (Eyal, Cor) + possible solution is to remember the last settings (Eyal) + in a first solution we could just remember the checkboxes + previous column types could be used if the number matches + does not clutter the UI (Heiko) + to load presets could be done too but would be a heavy interaction and kind of over-engineering + multi-selection of columns to batch apply a type is helpful too - which is possible in the current version (Cor) => remember the last settings, if multi-selection is not sufficient * UI Feature Request: Possibility to hide a page like in Impress + https://bugs.documentfoundation.org/show_bug.cgi?id=156802 + can follow the use case (Stephane) + always possible to exclude pages on printing/exporting to PDF (Regina, Cor, John) + against "hide" because of the semantics but agree with means to remember a print range (Eyal) => resolve WF and suggest to file a new ticket for print range * AUTOFILTER : Doesn't work with 2 words like "CP" and "Mi-CP" or "MiCP" + https://bugs.documentfoundation.org/show_bug.cgi?id=157878 + Tools/Options/Calc/Calculate:Apply to whole cells should do the trick (Miguel) + AutoFilter should be independent of that option (Eike) + always compare the autofilter against the entire cell; the fuzzy search/filter could be done by multi-selecting *CP* per search for CP => change the behavior to always apply the autofilter to the entire cell * PDF restrictions in signed PDF documents + https://bugs.documentfoundation.org/show_bug.cgi?id=143134 + it's normal that you cannot add comments in signed file (Timur) + non example for the opposite; signed document should stay unchanged (Heiko) + some environments exist where the signed document has an attached commenting workflow; will ask on the ticket (Cor) + it might be a flag to allow comments in signed PDFs (Hossein) + possible with Adobe software (Cor) => not a topic for UX * Ability to navigate via viewing area on charts + https://bugs.documentfoundation.org/show_bug.cgi?id=138509 + good for an extension (Jean-Baptiste) + 1. Ability to Zoom in + good idea (Eyal, John, Cor) + over-engineering; advanced chart functions are better suited for specialized tools (Heiko) + 2. Ability to Select data range + same as above (Heiko) + support this too (Eyal, John, Cor) + if we want to improve on this area we should include R with some libraries * Ability to hover on charts to quickly visualize details + https://bugs.documentfoundation.org/show_bug.cgi?id=138510 + we do show tooltips, but chart needs to be in edit mode (Heiko) + good idea, maybe worth a META ticket (Eyal) => comment * Tabbed interface: Overflow the tabbed interface to scroll/flip instead of a popup + https://bugs.documentfoundation.org/show_bug.cgi?id=158123 + Importance of making tabbed feature usable on different screen size (Hossein) + alternative overflow mechanism has pro and cons (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Re: URL links in bundled template
The original page from the Indonesian contest https://lumbung.libreoffice.id/ is
down too. And ultimately it is a general question whether or not to included
credits for artwork contributions (the link could be removed; and Unsplash, or
similar pages, are not needed at all). It's not uncommon to show names (KDE does
on several places) but feels a bit weird since code contributions are never
personalized ("this feature was brought to you by..."). I tend to vote for removal.
CC: design mailing list
On 04.11.23 16:18, Laurent Balland wrote:
Hello,
While I was updating "Grey Elegant" Impress template for bug 158022 [1], I
noticed that
- on master page "Table of content", there are two URL links ([2] and [3]) for
the credits of the illustration
- on last slide, there are two URL links ([4] and [5]) for the credits of the
photo
[2] seems empty and [4] is a broken link. [3] and [5] look like commercial links
Shall we preserve them? "Vintage" Impress template uses meta.xml [6] to take
care of such information.
Any opinion how we could deal with the credits used in bundled templates?
Best regards
Laurent
[1] https://bugs.documentfoundation.org/show_bug.cgi?id=158022
[2] https://icons8.com/illustrations/author/5ec7b0e101d0360016f3d1b3
[3] https://icons8.com/
[4]
https://unsplash.com/@johnwestrock?utm_source=unsplash_medium=referral_content=creditCopyText
[5]
https://unsplash.com/s/photos/landscape?utm_source=unsplash_medium=referral_content=creditCopyText
[6]
https://opengrok.libreoffice.org/xref/core/extras/source/templates/presnt/Vintage/meta.xml?r=659acfbb#8
--
Dr. Heiko Tietze, UX-Designer and UX-Mentor
Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org
The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: https://www.documentfoundation.org/imprint
OpenPGP_signature.asc
Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Nov-02
Present: Cor, Eyal, Heiko Comments: Stephane Tickets/Topics * in automatic filter, add the number of the first row where the value appears + https://bugs.documentfoundation.org/show_bug.cgi?id=157331 + proposal is to show the first occurrence in addition/alternatively to the total number the first occurrence (tdf#149984) + suggest to ask in a forum/ask-libreoffice for good solutions - and request a change if none is found (Cor) + computational effort sounds to be low; real estate on dialog seems to be possible though somewhat cluttered; wouldn't reject the request but recommend to not start work unless more users are interested (Eyal) + would WF the request; searching is easy and showing the total number more relevant (Heiko) => keep ticket and comment * Cell / font formatting lost when data linked from external data + https://bugs.documentfoundation.org/show_bug.cgi?id=150414 + if external source has formatting it should be taken into the reference, if not it must not clear the internal format (Eyal) + make the two feature behave in exactly the same way and provide an option to use the source formatting (Stephane) + better documentation needed (Heiko) + topic is very difficult to understand and probably needs more investigation (Cor) => follow Stephane's suggestion * The arrowhead control in the sidebar line section is difficult to notice + https://bugs.documentfoundation.org/show_bug.cgi?id=157882 + sidebar is crowded anyway, suggest to not have every single attribute there (Heiko) + cap style / corner style are even less likely changed by users (Eyal) + control is difficult to notice but tooltip makes the functionality obvious (Cor) => improve by moving the current control into a new line, drop cap/corner style, and keep splitting the control for later OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Nov-02
Present: Cor, Eyal, Heiko Comments: Stephane Tickets/Topics * in automatic filter, add the number of the first row where the value appears + https://bugs.documentfoundation.org/show_bug.cgi?id=157331 + proposal is to show the first occurrence in addition/alternatively to the total number the first occurrence (tdf#149984) + suggest to ask in a forum/ask-libreoffice for good solutions - and request a change if none is found (Cor) + computational effort sounds to be low; real estate on dialog seems to be possible though somewhat cluttered; wouldn't reject the request but recommend to not start work unless more users are interested (Eyal) + would WF the request; searching is easy and showing the total number more relevant (Heiko) => keep ticket and comment * Cell / font formatting lost when data linked from external data + https://bugs.documentfoundation.org/show_bug.cgi?id=150414 + if external source has formatting it should be taken into the reference, if not it must not clear the internal format (Eyal) + make the two feature behave in exactly the same way and provide an option to use the source formatting (Stephane) + better documentation needed (Heiko) + topic is very difficult to understand and probably needs more investigation (Cor) => follow Stephane's suggestion * The arrowhead control in the sidebar line section is difficult to notice + https://bugs.documentfoundation.org/show_bug.cgi?id=157882 + sidebar is crowded anyway, suggest to not have every single attribute there (Heiko) + cap style / corner style are even less likely changed by users (Eyal) + control is difficult to notice but tooltip makes the functionality obvious (Cor) => improve by moving the current control into a new line, drop cap/corner style, and keep splitting the control for later OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-commits] core.git: include/svx svx/source svx/uiconfig
include/svx/labelitemwindow.hxx | 11
include/svx/srchdlg.hxx |2
svx/source/dialog/srchdlg.cxx| 40 +++--
svx/source/form/labelitemwindow.cxx | 24 +-
svx/uiconfig/ui/findreplacedialog.ui | 80 +--
svx/uiconfig/ui/labelbox.ui | 29 ++--
6 files changed, 135 insertions(+), 51 deletions(-)
New commits:
commit 97d3d4f371f82704dba907975e6cfdaac456fe4d
Author: Heiko Tietze
AuthorDate: Fri Sep 15 14:23:50 2023 +0200
Commit: Heiko Tietze
CommitDate: Sat Oct 28 11:23:12 2023 +0200
Resolves tdf#156227 - More appealing feedback for find/quickfind
ErrorMessageType removed in favor of an infobar-like label
Accessibility notification added for the quickfind bar
Change-Id: Iec2498d04152392b3e181146005bdb0c9db8ec50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156943
Reviewed-by: Michael Weghorn
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/include/svx/labelitemwindow.hxx b/include/svx/labelitemwindow.hxx
index 5271482b11ad..d9aeccbb7bfd 100644
--- a/include/svx/labelitemwindow.hxx
+++ b/include/svx/labelitemwindow.hxx
@@ -12,14 +12,23 @@
#include
#include
+enum class LabelItemWindowType
+{
+Text,
+Info,
+};
+
class SVXCORE_DLLPUBLIC LabelItemWindow final : public InterimItemWindow
{
private:
+std::unique_ptr m_xBox;
std::unique_ptr m_xLabel;
+std::unique_ptr m_xImage;
public:
LabelItemWindow(vcl::Window* pParent, const OUString& rLabel);
-void set_label(const OUString& rLabel);
+void set_label(const OUString& rLabel,
+ const LabelItemWindowType eType =
LabelItemWindowType::Text);
OUString get_label() const;
void SetOptimalSize();
diff --git a/include/svx/srchdlg.hxx b/include/svx/srchdlg.hxx
index f069af48c539..7223a51cd324 100644
--- a/include/svx/srchdlg.hxx
+++ b/include/svx/srchdlg.hxx
@@ -177,6 +177,8 @@ private:
std::unique_ptr m_xSearchTmplLB;
std::unique_ptr m_xSearchAttrText;
std::unique_ptr m_xSearchLabel;
+std::unique_ptr m_xSearchIcon;
+std::unique_ptr m_xSearchBox;
std::unique_ptr m_xReplaceFrame;
std::unique_ptr m_xReplaceLB;
diff --git a/svx/source/dialog/srchdlg.cxx b/svx/source/dialog/srchdlg.cxx
index a17711bc46fb..b5cf7bcf34fd 100644
--- a/svx/source/dialog/srchdlg.cxx
+++ b/svx/source/dialog/srchdlg.cxx
@@ -285,6 +285,8 @@ SvxSearchDialog::SvxSearchDialog(weld::Window* pParent,
SfxChildWindow* pChildWi
, m_xSearchTmplLB(m_xBuilder->weld_combo_box("searchlist"))
, m_xSearchAttrText(m_xBuilder->weld_label("searchdesc"))
, m_xSearchLabel(m_xBuilder->weld_label("searchlabel"))
+, m_xSearchIcon(m_xBuilder->weld_image("searchicon"))
+, m_xSearchBox(m_xBuilder->weld_box("searchbox"))
, m_xReplaceFrame(m_xBuilder->weld_frame("replaceframe"))
, m_xReplaceLB(m_xBuilder->weld_combo_box("replaceterm"))
, m_xReplaceTmplLB(m_xBuilder->weld_combo_box("replacelist"))
@@ -340,6 +342,9 @@ SvxSearchDialog::SvxSearchDialog(weld::Window* pParent,
SfxChildWindow* pChildWi
m_xSearchTmplLB->make_sorted();
m_xSearchAttrText->hide();
+m_xSearchLabel->set_font_color(Color(0x00, 0x47, 0x85));
+this->SetSearchLabel(""); // hide the message but keep the box height
+
m_xReplaceTmplLB->make_sorted();
m_xReplaceAttrText->hide();
@@ -581,14 +586,18 @@ void SvxSearchDialog::SetSearchLabel(const OUString& rStr)
m_xSearchLabel->set_label(rStr);
if (!rStr.isEmpty())
{
-// hide/show to fire SHOWING state change event so search label text
-// is announced by screen reader
-m_xSearchLabel->hide();
m_xSearchLabel->show();
+m_xSearchIcon->show();
+m_xSearchBox->set_background(Color(0xBD, 0xE5, 0xF8)); // same as
InfobarType::INFO
+}
+else
+{
+const Size aSize = m_xSearchBox->get_preferred_size();
+m_xSearchLabel->hide();
+m_xSearchIcon->hide();
+m_xSearchBox->set_size_request(-1, aSize.Height());
+m_xSearchBox->set_background(COL_TRANSPARENT);
}
-
-if (rStr == SvxResId(RID_SVXSTR_SEARCH_NOT_FOUND))
-m_xSearchLB->set_entry_message_type(weld::EntryMessageType::Error);
}
void SvxSearchDialog::ApplyTransliterationFlags_Impl( TransliterationFlags
nSettings )
@@ -2360,8 +2369,6 @@ SfxChildWinInfo SvxSearchDialogWrapper::GetInfo() const
static void lcl_SetSearchLabelWindow(const OUString& rStr, SfxViewFrame&
rViewFrame)
{
-bool bNotFound = rStr == SvxResId(RID_SVXSTR_SEARCH_NOT_FOUND);
-
css::uno::Reference< css::beans::XPropertySet > xPropSet(
rViewFrame.GetFrame().GetFrameInterface(),
css::uno
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Oct-25
Present: John, Bogdan, Heiko Comments: Eike, Eyal Tickets/Topics * feature [Draw] Color option to identify the layer + https://bugs.documentfoundation.org/show_bug.cgi?id=157255 + currently we show italic for locked, underline for non-printing and blue font color for invisible, and a bold bar for the active layer + a) just use bold for the active layer and icons for states + drawback is a jumping UI and larger tabs + b) use a thin bar to indicate the object's layer + hard to distinguish from the active layer + c) colorize the layer of the object with highlight color + could use the system highlight color (and invert the blue font of disabled) + like option a) (John) + competitors? draw.io uses kind of a Navigator and draws a tiny dot for the object's layer + ideally improve the Navigator => comment * Re-initialize autofill rather than overwriting content + https://bugs.documentfoundation.org/show_bug.cgi?id=157731 + re-initialize autofill rather than overwriting content when pressing ctrl (Heiko) + take care of shift being pressed (just copies the content) + no harm in adding this function (John) => do it * Paste number format only + https://bugs.documentfoundation.org/show_bug.cgi?id=157627 + paste special without format should not alter the target format (Eike) + would be a random choice of attributes and bloats the dialog (John, Heiko) + workflow is unclear and sounds very specific + using proper cell style might be a good alternative + Excel provides an option to paste "Formulas and number formats" or alternatively "Values and number formats"; we should consider adding this (John) + just adding the number format could be a checkbox under Options labeled "Number format" disabled if "[x] Format" is checked (and otherwise allowing to overwrite the target number format) => do it * Print or export to PDF by chapters/sections + https://bugs.documentfoundation.org/show_bug.cgi?id=157346 + nice shortcut (Heiko) + should be called heading; and agree with the request (Eyal) + makes the print dialog more complicated and is quite unusual; reading first/last page from the document is simple enough (John) => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Oct-25
Present: John, Bogdan, Heiko Comments: Eike, Eyal Tickets/Topics * feature [Draw] Color option to identify the layer + https://bugs.documentfoundation.org/show_bug.cgi?id=157255 + currently we show italic for locked, underline for non-printing and blue font color for invisible, and a bold bar for the active layer + a) just use bold for the active layer and icons for states + drawback is a jumping UI and larger tabs + b) use a thin bar to indicate the object's layer + hard to distinguish from the active layer + c) colorize the layer of the object with highlight color + could use the system highlight color (and invert the blue font of disabled) + like option a) (John) + competitors? draw.io uses kind of a Navigator and draws a tiny dot for the object's layer + ideally improve the Navigator => comment * Re-initialize autofill rather than overwriting content + https://bugs.documentfoundation.org/show_bug.cgi?id=157731 + re-initialize autofill rather than overwriting content when pressing ctrl (Heiko) + take care of shift being pressed (just copies the content) + no harm in adding this function (John) => do it * Paste number format only + https://bugs.documentfoundation.org/show_bug.cgi?id=157627 + paste special without format should not alter the target format (Eike) + would be a random choice of attributes and bloats the dialog (John, Heiko) + workflow is unclear and sounds very specific + using proper cell style might be a good alternative + Excel provides an option to paste "Formulas and number formats" or alternatively "Values and number formats"; we should consider adding this (John) + just adding the number format could be a checkbox under Options labeled "Number format" disabled if "[x] Format" is checked (and otherwise allowing to overwrite the target number format) => do it * Print or export to PDF by chapters/sections + https://bugs.documentfoundation.org/show_bug.cgi?id=157346 + nice shortcut (Heiko) + should be called heading; and agree with the request (Eyal) + makes the print dialog more complicated and is quite unusual; reading first/last page from the document is simple enough (John) => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/inc sw/qa sw/source
sw/inc/flddat.hxx |2 +-
sw/qa/uibase/shells/shells.cxx|6 --
sw/source/ui/fldui/flddok.cxx |4 ++--
sw/source/uibase/fldui/fldmgr.cxx |6 +++---
4 files changed, 10 insertions(+), 8 deletions(-)
New commits:
commit d6347033f95a4c3d4837f954a6560b83ec2a421d
Author: Heiko Tietze
AuthorDate: Tue Oct 17 11:15:58 2023 +0200
Commit: Heiko Tietze
CommitDate: Tue Oct 24 09:18:00 2023 +0200
Revert "Resolves tdf#139141 - Make variable date/time field the default"
This reverts commit e37f06f534ac864f9fe8cd20b07a85c36e697d41.
and ui test from Ia1a2387e137f8a672a24056b13234d4275a77ca4
Reason for revert: tdf#157337; macros rely on fix field values
Change-Id: I7a638330aac9b71432556454c0104479fcd05b4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158041
Tested-by: Heiko Tietze
Reviewed-by: Heiko Tietze
(cherry picked from commit fa569930a0968cdeba4441e19a68e7d78aa25cb4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158282
Tested-by: Jenkins
diff --git a/sw/inc/flddat.hxx b/sw/inc/flddat.hxx
index 6c452072e926..39c00f68a235 100644
--- a/sw/inc/flddat.hxx
+++ b/sw/inc/flddat.hxx
@@ -30,8 +30,8 @@ namespace tools { class Time; }
enum SwDateSubFormat
{
-DATE_VAR,
DATE_FIX,
+DATE_VAR
};
class SAL_DLLPUBLIC_RTTI SwDateTimeFieldType final : public SwValueFieldType
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index c962f4a5d65e..6543f8f4fcb7 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -1049,7 +1049,9 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testInsertTextFormFieldEndnote)
// Then this was empty: the fieldmark was inserted before the note anchor,
not in the note body.
CPPUNIT_ASSERT_EQUAL(OUString("result"), aActual);
}
-
+/*
+// Disabled because tdf#139141 was reverted and the default time field inserts
a fix value again
+// Should be reactivated once a new UNO command is added for variable time
fields
CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testUpdateSelectedField)
{
// Given an empty doc:
@@ -1077,7 +1079,7 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testUpdateSelectedField)
// Check that the selected field has changed:
CPPUNIT_ASSERT(aTimeFieldAfter != aTimeFieldBefore);
}
-
+*/
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/ui/fldui/flddok.cxx b/sw/source/ui/fldui/flddok.cxx
index f669fa7b92b2..a195ed026ec0 100644
--- a/sw/source/ui/fldui/flddok.cxx
+++ b/sw/source/ui/fldui/flddok.cxx
@@ -241,9 +241,9 @@ IMPL_LINK_NOARG(SwFieldDokPage, TypeHdl, weld::TreeView&,
void)
case SwFieldTypesEnum::Date:
case SwFieldTypesEnum::Time:
m_xSelectionLB->append(sId, aLst[i]);
-if
(static_cast(GetCurField())->IsFixed() && i)
+if
(static_cast(GetCurField())->IsFixed() && !i)
m_xSelectionLB->select_id(sId);
-if
(!static_cast(GetCurField())->IsFixed() && !i)
+if
(!static_cast(GetCurField())->IsFixed() && i)
m_xSelectionLB->select_id(sId);
break;
case SwFieldTypesEnum::ExtendedUser:
diff --git a/sw/source/uibase/fldui/fldmgr.cxx
b/sw/source/uibase/fldui/fldmgr.cxx
index 143c981a6131..636e2b99058a 100644
--- a/sw/source/uibase/fldui/fldmgr.cxx
+++ b/sw/source/uibase/fldui/fldmgr.cxx
@@ -159,14 +159,14 @@ const TranslateId FMT_AUTHOR_ARY[] =
const TranslateId FLD_DATE_ARY[] =
{
+FLD_DATE_FIX,
FLD_DATE_STD,
-FLD_DATE_FIX
};
const TranslateId FLD_TIME_ARY[] =
{
-FLD_TIME_STD,
-FLD_TIME_FIX
+FLD_TIME_FIX,
+FLD_TIME_STD
};
const TranslateId FMT_NUM_ARY[] =
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/flddat.hxx |2 +-
sw/qa/uibase/shells/shells.cxx|6 --
sw/source/ui/fldui/flddok.cxx |4 ++--
sw/source/uibase/fldui/fldmgr.cxx |6 +++---
4 files changed, 10 insertions(+), 8 deletions(-)
New commits:
commit fa569930a0968cdeba4441e19a68e7d78aa25cb4
Author: Heiko Tietze
AuthorDate: Tue Oct 17 11:15:58 2023 +0200
Commit: Heiko Tietze
CommitDate: Mon Oct 23 15:42:38 2023 +0200
Revert "Resolves tdf#139141 - Make variable date/time field the default"
This reverts commit e37f06f534ac864f9fe8cd20b07a85c36e697d41.
and ui test from Ia1a2387e137f8a672a24056b13234d4275a77ca4
Reason for revert: tdf#157337; macros rely on fix field values
Change-Id: I7a638330aac9b71432556454c0104479fcd05b4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158041
Tested-by: Heiko Tietze
Reviewed-by: Heiko Tietze
diff --git a/sw/inc/flddat.hxx b/sw/inc/flddat.hxx
index 6c452072e926..39c00f68a235 100644
--- a/sw/inc/flddat.hxx
+++ b/sw/inc/flddat.hxx
@@ -30,8 +30,8 @@ namespace tools { class Time; }
enum SwDateSubFormat
{
-DATE_VAR,
DATE_FIX,
+DATE_VAR
};
class SAL_DLLPUBLIC_RTTI SwDateTimeFieldType final : public SwValueFieldType
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index f8d7f99de023..88f90e909698 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -1049,7 +1049,9 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testInsertTextFormFieldEndnote)
// Then this was empty: the fieldmark was inserted before the note anchor,
not in the note body.
CPPUNIT_ASSERT_EQUAL(OUString("result"), aActual);
}
-
+/*
+// Disabled because tdf#139141 was reverted and the default time field inserts
a fix value again
+// Should be reactivated once a new UNO command is added for variable time
fields
CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testUpdateSelectedField)
{
// Given an empty doc:
@@ -1077,7 +1079,7 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testUpdateSelectedField)
// Check that the selected field has changed:
CPPUNIT_ASSERT(aTimeFieldAfter != aTimeFieldBefore);
}
-
+*/
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/ui/fldui/flddok.cxx b/sw/source/ui/fldui/flddok.cxx
index f669fa7b92b2..a195ed026ec0 100644
--- a/sw/source/ui/fldui/flddok.cxx
+++ b/sw/source/ui/fldui/flddok.cxx
@@ -241,9 +241,9 @@ IMPL_LINK_NOARG(SwFieldDokPage, TypeHdl, weld::TreeView&,
void)
case SwFieldTypesEnum::Date:
case SwFieldTypesEnum::Time:
m_xSelectionLB->append(sId, aLst[i]);
-if
(static_cast(GetCurField())->IsFixed() && i)
+if
(static_cast(GetCurField())->IsFixed() && !i)
m_xSelectionLB->select_id(sId);
-if
(!static_cast(GetCurField())->IsFixed() && !i)
+if
(!static_cast(GetCurField())->IsFixed() && i)
m_xSelectionLB->select_id(sId);
break;
case SwFieldTypesEnum::ExtendedUser:
diff --git a/sw/source/uibase/fldui/fldmgr.cxx
b/sw/source/uibase/fldui/fldmgr.cxx
index c61c9c26cba5..3b69fb63739d 100644
--- a/sw/source/uibase/fldui/fldmgr.cxx
+++ b/sw/source/uibase/fldui/fldmgr.cxx
@@ -161,14 +161,14 @@ const TranslateId FMT_AUTHOR_ARY[] =
const TranslateId FLD_DATE_ARY[] =
{
+FLD_DATE_FIX,
FLD_DATE_STD,
-FLD_DATE_FIX
};
const TranslateId FLD_TIME_ARY[] =
{
-FLD_TIME_STD,
-FLD_TIME_FIX
+FLD_TIME_FIX,
+FLD_TIME_STD
};
const TranslateId FMT_NUM_ARY[] =
Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"
With alias I had TargetURL in mind (sorry for the confusion). For example, the command .uno:ViewTrackChanges runs actually .uno:ShowTrackedChanges. OpenPGP_signature.asc Description: OpenPGP digital signature
Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"
The typo is there for more than twenty years and macros may depend on it. Can we change the label but add an alias to the new "unchain" command, flag this alias as deprecated, and remove it with the next release? On 22.10.23 22:49, Julien Nabet wrote: Hello, Olivier spotted a typo in UNO command ".uno:UnhainFrame", can it be fixed or is this another thing to add in https://wiki.documentfoundation.org/Development/stuck_stuff ? Here's the patch https://gerrit.libreoffice.org/c/core/+/158328 waiting for review so you'll see what it impacts (if I haven't forgotten anything). Julien -- Dr. Heiko Tietze, UX-Designer and UX-Mentor Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: https://www.documentfoundation.org/imprint OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Oct-19
Present: Cor, Eyal, Heiko Comments: Stephane, RGB, Eyal, Jan, Robert Tickets/Topics * As we now have a Comment style, remove/redirect "Format all comments..." + https://bugs.documentfoundation.org/show_bug.cgi?id=157522 + direct formatting might still be needed, eg. to increase the font size for all comments (Stephane) + rename to "Direct format all comments" and perhaps hide it from the menu but keep it; add Edit Style to the menu (Heiko) + turn "Format all comments" into "Edit default paragraph style for comments" (RGB) + rather open the Paragraph Style dialog for the current Comment PS (Eyal) + remove the command, and offer "Select All" (Cor, Eyal) => comment * Improve password security UX + https://bugs.documentfoundation.org/show_bug.cgi?id=157518 + implement strength meter based on existing code, do not use rules, consider further improvements (Jan) + https://keepass.info/help/kb/pw_quality_est.html + have an "unmask password" icon (Jan) + have a policy to provide companies a way to not allow simple passwords (Cor, Gabor) + show strength meter with tooltips what do to (Eyal, Heiko) + perhaps split the bug (Eyal) => comment * Method to clear search text drop down list in Base form + https://bugs.documentfoundation.org/show_bug.cgi?id=157039 + remember search during the session (Heiko) + store it in the database (Robert) => fix depending on effort * Writer: repeat first column of a table on subsequent pages + https://bugs.documentfoundation.org/show_bug.cgi?id=157301 + table don't flow left/right to the next page (Cor) + OP is not a CTL user but wants to split a wide table across multiple pages + theoretically it might be possible "If a table does not fit on a single page, a set of adjacent table columns can be automatically repeated on every page..." + Calc provide means to achieve this via Print Range > Row/Columns to repeat (Cor) + don't worth the effort, unless the OP can explain why implementing this in Writer in necessary (Eyal) => WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Oct-19
Present: Cor, Eyal, Heiko Comments: Stephane, RGB, Eyal, Jan, Robert Tickets/Topics * As we now have a Comment style, remove/redirect "Format all comments..." + https://bugs.documentfoundation.org/show_bug.cgi?id=157522 + direct formatting might still be needed, eg. to increase the font size for all comments (Stephane) + rename to "Direct format all comments" and perhaps hide it from the menu but keep it; add Edit Style to the menu (Heiko) + turn "Format all comments" into "Edit default paragraph style for comments" (RGB) + rather open the Paragraph Style dialog for the current Comment PS (Eyal) + remove the command, and offer "Select All" (Cor, Eyal) => comment * Improve password security UX + https://bugs.documentfoundation.org/show_bug.cgi?id=157518 + implement strength meter based on existing code, do not use rules, consider further improvements (Jan) + https://keepass.info/help/kb/pw_quality_est.html + have an "unmask password" icon (Jan) + have a policy to provide companies a way to not allow simple passwords (Cor, Gabor) + show strength meter with tooltips what do to (Eyal, Heiko) + perhaps split the bug (Eyal) => comment * Method to clear search text drop down list in Base form + https://bugs.documentfoundation.org/show_bug.cgi?id=157039 + remember search during the session (Heiko) + store it in the database (Robert) => fix depending on effort * Writer: repeat first column of a table on subsequent pages + https://bugs.documentfoundation.org/show_bug.cgi?id=157301 + table don't flow left/right to the next page (Cor) + OP is not a CTL user but wants to split a wide table across multiple pages + theoretically it might be possible "If a table does not fit on a single page, a set of adjacent table columns can be automatically repeated on every page..." + Calc provide means to achieve this via Print Range > Row/Columns to repeat (Cor) + don't worth the effort, unless the OP can explain why implementing this in Writer in necessary (Eyal) => WF OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-commits] core.git: 2 commits - include/tools sd/qa sd/source
include/tools/color.hxx |7 +--
sd/qa/unit/data/xml/tdf92001_0.xml |2 +-
sd/source/ui/table/tablefunction.cxx |8 +---
3 files changed, 7 insertions(+), 10 deletions(-)
New commits:
commit 8ff7d75c1929876743b01d9651ea30928673433f
Author: Heiko Tietze
AuthorDate: Mon Oct 16 12:37:00 2023 +0200
Commit: Heiko Tietze
CommitDate: Mon Oct 16 15:35:23 2023 +0200
Revert "Resolves tdf#156685 - "Object without fill" style for tables"
This reverts commit 86eb7ad2b4488dcd29c21ae3fc525056b681e199.
Reason for revert: More generic solution in
I1ca8cfe539a662100f6c581fd633ab1ebd5c6bfb
Change-Id: Ie2769a90f776602e38fc2795e08d591f9ae8d618
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158035
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sd/source/ui/table/tablefunction.cxx
b/sd/source/ui/table/tablefunction.cxx
index b28f89c896e2..67196e864b39 100644
--- a/sd/source/ui/table/tablefunction.cxx
+++ b/sd/source/ui/table/tablefunction.cxx
@@ -44,8 +44,6 @@
#include
#include
#include
-#include
-#include
#include
@@ -149,11 +147,7 @@ static void InsertTableImpl(const DrawViewShell* pShell,
aRect,
nColumns,
nRows);
-//tables must not use default background tango sky blue tdf#156685
-SfxStyleSheet* pStyleSheet = static_cast(
-pShell->GetDoc()->GetStyleSheetPool()->Find(
-SdResId(STR_POOLSHEET_OBJWITHOUTFILL), SfxStyleFamily::Para));
-pObj->NbcSetStyleSheet( pStyleSheet, true );
+pObj->NbcSetStyleSheet( pShell->GetDoc()->GetDefaultStyleSheet(), true );
apply_table_style( pObj.get(), pShell->GetDoc(), sTableStyle );
SdrPageView* pPV = pView->GetSdrPageView();
commit f07d47fff571c4446988715f3c21362b9eed4265
Author: Heiko Tietze
AuthorDate: Mon Oct 16 11:34:56 2023 +0200
Commit: Heiko Tietze
CommitDate: Mon Oct 16 15:35:10 2023 +0200
Related tdf#156182 - Keep legacy contrast for default background
Band aid for follow-up issues, eg. tdf#157706, tdf#157706...
Change-Id: I1ca8cfe539a662100f6c581fd633ab1ebd5c6bfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158024
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/include/tools/color.hxx b/include/tools/color.hxx
index c3bbb5bf0e2b..8ab35445893f 100644
--- a/include/tools/color.hxx
+++ b/include/tools/color.hxx
@@ -311,8 +311,11 @@ public:
*/
bool IsDark() const
{
-// tdf#156182
-return GetLuminance() <= 156;
+// tdf#156182, and band aid for follow-up issues
+if (mValue == 0x729fcf) // COL_DEFAULT_SHAPE_FILLING
+return GetLuminance() <= 62;
+else
+return GetLuminance() <= 156;
}
/** Comparison with luminance thresholds.
diff --git a/sd/qa/unit/data/xml/tdf92001_0.xml
b/sd/qa/unit/data/xml/tdf92001_0.xml
index 234f751a9c23..d67952eb1fe5 100644
--- a/sd/qa/unit/data/xml/tdf92001_0.xml
+++ b/sd/qa/unit/data/xml/tdf92001_0.xml
@@ -1,6 +1,6 @@
-
+
Re: LO 24.2 C++20 baseline
On 05.10.23 16:49, Stephan Bergmann wrote: As we just found out on IRC when Heiko ran into the above failures when compiling cli_ure/source/climaker/climaker_app.cxx, this apparently also affects old versions of VS 2022, not just VS 2019: No issue building master with VS Build Tools 17.7.4 which updated MSVC22 to 14.36.32532 yesterday. -- Dr. Heiko Tietze, UX-Designer and UX-Mentor Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: https://www.documentfoundation.org/imprint OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Oct-05
Present: Heiko Comments: Gabor, Jean-Francois, Stephane, Ilmari, Telesto, Attila, William, Khaled, Stuart Tickets/Topics * Writer allows to insert comments in footnotes in DOCX, but loses them + https://bugs.documentfoundation.org/show_bug.cgi?id=157406 + have UI settings for all similar MSO-compat options (Gabor) + add AllowCommentsInFootnotes and ClockwisePieChartDirection but not ReverseSeriesOrderAreaAndNetChart, and ReverseXAxisOrientationDoughnutChart (Heiko) => easy hack * Import & Export mechanism for the font substitution table + https://bugs.documentfoundation.org/show_bug.cgi?id=157415 + realize per extension (Jean-Francois, Heiko) => WF * Formula help still displayed when editing cell formatted as text + https://bugs.documentfoundation.org/show_bug.cgi?id=156674 + show tip anyway (Stephane) + cell reference highlighting might be misleading (Ilmari) + formula might be shown anyway (Heiko) + and the tooltip shows up only while editing; possible workflow is to write formulas in text mode and switch finally to number for execution- which makes the tooltip valuable => resolve WF/NAB * Cursor goes beyond margins when typing spaces at the end of a line + https://bugs.documentfoundation.org/show_bug.cgi?id=155494 + mimic MS Word that allows spaces beyond margin and off page (Telesto) + controversial situation; allow space, don't wrap line, give feedback... and the use case is very dubious (Attila) + not being able to add pointless spaces at the end or breaking into the next line was the reason for the report (William) + TextEdit and Pages keep the cursor at line end regardless spaces (Khaled) + MS Word had in the past '"Wrap trailing spaces to the next line" (for compatibility with WordPerfect)'; suggest to break line (Stuart) + make this optional (William, Heiko) => add optionally OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-qa] Minutes from the UX/design meeting 2023-Oct-05
Present: Heiko Comments: Gabor, Jean-Francois, Stephane, Ilmari, Telesto, Attila, William, Khaled, Stuart Tickets/Topics * Writer allows to insert comments in footnotes in DOCX, but loses them + https://bugs.documentfoundation.org/show_bug.cgi?id=157406 + have UI settings for all similar MSO-compat options (Gabor) + add AllowCommentsInFootnotes and ClockwisePieChartDirection but not ReverseSeriesOrderAreaAndNetChart, and ReverseXAxisOrientationDoughnutChart (Heiko) => easy hack * Import & Export mechanism for the font substitution table + https://bugs.documentfoundation.org/show_bug.cgi?id=157415 + realize per extension (Jean-Francois, Heiko) => WF * Formula help still displayed when editing cell formatted as text + https://bugs.documentfoundation.org/show_bug.cgi?id=156674 + show tip anyway (Stephane) + cell reference highlighting might be misleading (Ilmari) + formula might be shown anyway (Heiko) + and the tooltip shows up only while editing; possible workflow is to write formulas in text mode and switch finally to number for execution- which makes the tooltip valuable => resolve WF/NAB * Cursor goes beyond margins when typing spaces at the end of a line + https://bugs.documentfoundation.org/show_bug.cgi?id=155494 + mimic MS Word that allows spaces beyond margin and off page (Telesto) + controversial situation; allow space, don't wrap line, give feedback... and the use case is very dubious (Attila) + not being able to add pointless spaces at the end or breaking into the next line was the reason for the report (William) + TextEdit and Pages keep the cursor at line end regardless spaces (Khaled) + MS Word had in the past '"Wrap trailing spaces to the next line" (for compatibility with WordPerfect)'; suggest to break line (Stuart) + make this optional (William, Heiko) => add optionally OpenPGP_signature.asc Description: OpenPGP digital signature
[Libreoffice-commits] core.git: filter/source
filter/source/pdf/impdialog.cxx | 10 ++
filter/source/pdf/impdialog.hxx |3 ++-
2 files changed, 8 insertions(+), 5 deletions(-)
New commits:
commit 07a06e40400f3713619cb456d62d4bb952e85436
Author: Heiko Tietze
AuthorDate: Fri Jul 21 11:47:45 2023 +0200
Commit: Heiko Tietze
CommitDate: Thu Oct 5 13:10:15 2023 +0200
Resolves tdf#156337 - Keep warning label enabled on PDF security tab
Change-Id: Ifea77294825b987e4277e146cc34af120e38c8c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154712
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index a036d432e3c3..c7149b0ca534 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -936,7 +936,7 @@ IMPL_LINK_NOARG(ImpPDFTabGeneralPage,
TogglePDFVersionOrUniversalAccessibilityHa
// set the security page status (and its controls as well)
ImpPDFTabSecurityPage* pSecPage = mpParent ? mpParent->getSecurityPage() :
nullptr;
if (pSecPage)
-pSecPage->ImplPDFASecurityControl(!bIsPDFA);
+pSecPage->ImplPDFASecurityControl();
mxCbTaggedPDF->set_sensitive(
!bIsPDFA && !bIsPDFUA && !IsReadOnlyProperty("UseTaggedPDF"));
@@ -1315,6 +1315,7 @@
ImpPDFTabSecurityPage::ImpPDFTabSecurityPage(weld::Container* pPage, weld::Dialo
, mxCbEnableCopy(m_xBuilder->weld_check_button("enablecopy"))
, mxCbEnableAccessibility(m_xBuilder->weld_check_button("enablea11y"))
, mxPasswordTitle(m_xBuilder->weld_label("setpasswordstitle"))
+, mxPermissionTitle(m_xBuilder->weld_label("label2"))
{
msStrSetPwd = mxPasswordTitle->get_label();
mxPbSetPwd->connect_clicked(LINK(this, ImpPDFTabSecurityPage,
ClickmaPbSetPwdHdl));
@@ -1411,7 +1412,7 @@ void ImpPDFTabSecurityPage::SetFilterConfigItem( const
ImpPDFTabDialog* pParent
ImpPDFTabGeneralPage* pGeneralPage = pParent->getGeneralPage();
if (pGeneralPage)
-ImplPDFASecurityControl(!pGeneralPage->IsPdfaSelected());
+ImplPDFASecurityControl();
}
IMPL_LINK_NOARG(ImpPDFTabSecurityPage, ClickmaPbSetPwdHdl, weld::Button&, void)
@@ -1479,6 +1480,8 @@ void ImpPDFTabSecurityPage::enablePermissionControls()
{
mxCbEnableAccessibility->set_active(true);
}
+mxPermissionTitle->set_sensitive(!bIsPDFASel);
+mxPbSetPwd->set_sensitive(!bIsPDFASel);
mxCbEnableAccessibility->set_sensitive(!bIsPDFUASel);
if (bIsPDFASel)
{
@@ -1532,9 +1535,8 @@ void ImpPDFTabSecurityPage::enablePermissionControls()
// This tab page is under control of the PDF/A-1a checkbox:
// TODO: implement a method to do it.
-void ImpPDFTabSecurityPage::ImplPDFASecurityControl( bool bEnableSecurity )
+void ImpPDFTabSecurityPage::ImplPDFASecurityControl()
{
-m_xContainer->set_sensitive(bEnableSecurity);
// after enable, check the status of control as if the dialog was
initialized
enablePermissionControls();
}
diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx
index 7a8985ebc807..8cbfc0af987f 100644
--- a/filter/source/pdf/impdialog.hxx
+++ b/filter/source/pdf/impdialog.hxx
@@ -355,6 +355,7 @@ class ImpPDFTabSecurityPage : public SfxTabPage
std::unique_ptr mxCbEnableCopy;
std::unique_ptr mxCbEnableAccessibility;
std::unique_ptr mxPasswordTitle;
+std::unique_ptr mxPermissionTitle;
std::shared_ptr< SfxPasswordDialog > mpPasswordDialog;
std::shared_ptr< weld::MessageDialog > mpUnsupportedMsgDialog;
@@ -371,7 +372,7 @@ public:
voidGetFilterConfigItem( ImpPDFTabDialog*
paParent);
voidSetFilterConfigItem( const ImpPDFTabDialog*
paParent );
-voidImplPDFASecurityControl( bool bEnableSecurity
);
+voidImplPDFASecurityControl();
boolhasPassword() const { return
mbHaveOwnerPassword || mbHaveUserPassword; }
};
[Libreoffice-commits] core.git: sd/source
sd/source/ui/table/tablefunction.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 86eb7ad2b4488dcd29c21ae3fc525056b681e199 Author: Heiko Tietze AuthorDate: Wed Oct 4 18:51:21 2023 +0200 Commit: Heiko Tietze CommitDate: Thu Oct 5 09:36:13 2023 +0200 Resolves tdf#156685 - "Object without fill" style for tables The "Default Drawing Style" uses Tango Sky Blue for the background, which is treated as dark since commit Ia5e405fc05613726b5011174c8d00ca204eb31b2. This ends up in unreadable white font color on white backgrounds for tables. The new style "Object without fill" has a clear background. Change-Id: I6b2f701e4a8cce6200fd2a5e86037e9a36b32833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157568 Tested-by: Heiko Tietze Reviewed-by: Heiko Tietze diff --git a/sd/source/ui/table/tablefunction.cxx b/sd/source/ui/table/tablefunction.cxx index 67196e864b39..b28f89c896e2 100644 --- a/sd/source/ui/table/tablefunction.cxx +++ b/sd/source/ui/table/tablefunction.cxx @@ -44,6 +44,8 @@ #include #include #include +#include +#include #include @@ -147,7 +149,11 @@ static void InsertTableImpl(const DrawViewShell* pShell, aRect, nColumns, nRows); -pObj->NbcSetStyleSheet( pShell->GetDoc()->GetDefaultStyleSheet(), true ); +//tables must not use default background tango sky blue tdf#156685 +SfxStyleSheet* pStyleSheet = static_cast( +pShell->GetDoc()->GetStyleSheetPool()->Find( +SdResId(STR_POOLSHEET_OBJWITHOUTFILL), SfxStyleFamily::Para)); +pObj->NbcSetStyleSheet( pStyleSheet, true ); apply_table_style( pObj.get(), pShell->GetDoc(), sTableStyle ); SdrPageView* pPV = pView->GetSdrPageView();
