Re:unique wall lamp & art sign
Dear boss, Wish you best business today! This is Jack from China. We are the pioneer of Abyss Multi layers Cool patent unique wall lamp & art sign, who comitted to support our clients with unique competitiveness. Tuya Wifi smart control Cool Magic addressable color science-fiction excellent lighting effect support agent with very good discount or commission. Widely application : gaming wall / projects / Bars / custom sign art . Exclusive competitiveness , interested ? Please call us anytime. Thanks ! Jack Exclusive lighting factory.
Re: Assertion Failed!: MSVCP140D.dll , Expression: ploc->_Mbcurmax == 1 || ploc->_Mbcurmax == 2
I don't use Visual Studio and haven't investigated this at all, but I did recently see a Mozilla dev-builds post about Visual Studio 2017 15.7.0 and wonder if it's in any way related: https://groups.google.com/d/msg/mozilla.dev.builds/SNaRs1f6Ai4/0J8h6CSXBAAJ On 2018-05-08 02:30 PM, Kaganski Mike wrote: On 5/6/2018 9:49 PM, himajin10 wrote: I've updated my Visual Studio 2017 Preview to 15.7.0 Preview 6.0 and then started to fail to make my own LibreOffice build with the following error. ... I see quite a few changes in the 15.7.0 changelog [1] that might affect us; so - did you make clean to begin with? [1] https://docs.microsoft.com/en-us/visualstudio/releasenotes/vs2017-relnotes ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Workbook.SendMail
Would a patch to implement Workbook.SendMail [1] be worth working on? Is there a chance it would be accepted? First, I assume it's not already implemented: When I run a macro that contains ActiveWorkbook.SendMail I get: BASIC runtime error. '423' SendMail and if I'm looking in the right places [2][3][4] then the source code looks like it's not implemented, also? [1] https://msdn.microsoft.com/en-us/vba/excel-vba/articles/workbook-sendmail-method-excel [2] https://github.com/LibreOffice/core/blob/master/oovbaapi/ooo/vba/excel/XWorkbook.idl [3] https://github.com/LibreOffice/core/blob/master/sc/source/ui/vba/vbaworkbook.hxx [4] https://github.com/LibreOffice/core/blob/master/sc/source/ui/vba/vbaworkbook.cxx ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Fw: My work
Hello. Due my slow internet connection, I am unable to upload my patches the regular way, so i am sending you my work in the attachment and in the following google drive folder(https://drive.google.com/file/d/0Bw9dWoxQQ7gNMUttaGctTm83Z00/view?usp=sharing). These are only small patches, I have changed two functions in writerfilter/source/dmapper/PropertyMap.cxx The file "fix.cxx" contains only the two functions, the file "PropertyMap.cxx" contains the whole patched file. The docx-files are my test cases, they look different in LibreOffice than in Word. Failure_2 should be fixed with my patch. These files may be used under any licence. Thanks, Jack___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
My work
Due my slow internet connection, I am unable to upload my patches the regular way, so i am sending you my work in the attachment. These are only small patches, I have changed two functions in writerfilter/source/dmapper/PropertyMap.cxx The file fix.cxx contains only the two functions, the file PropertyMap.cxx contains the whole patched file. The docx-files are my test cases, they look different in LibreOffice than in Word. Failure_2 should be fixed with my patch. These files may be used under any licence. Thanks, Jack___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Jack license statement
All of my past and future contributions to LibreOffice may be licensed under any license, but not under the GPL or any similar copyleft license. The right to license my contributions under the LGPLv3+ is hereby also granted. /jack___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Build LibreOffice without unit tests
Hi, Can somebody help me building LibreOffice(Ubuntu) without running any tests? Thanks, jack___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Section Break Code
Hello, I am new to LibreOffice development, can somebody tell my where to find the code for the following elements: - section breaks - formatting Regards, jack___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
new to LibreOffice: LibreOffice Writer bug(#64372) fixing
Hello, I am new to LibreOffice development, and I want to fix a bug(https://bugs.documentfoundation.org/show_bug.cgi?id=64372) found in LibreOffice Writer. I am pretty sure that it is either a formatting issue or a error while reading/parsing the OOXML. Can sombody can give me some pointers on where I should start my search(I already know the trigger for that issue, look at the issue and the duplicate of it: https://bugs.documentfoundation.org/show_bug.cgi?id=92724) Regards, jack___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - android/Bootstrap android/experimental
android/Bootstrap/Makefile.shared |2 +- android/Bootstrap/project.properties |2 +- android/experimental/DocumentLoader/project.properties |2 +- android/experimental/desktop/project.properties|2 +- 4 files changed, 4 insertions(+), 4 deletions(-) New commits: commit b450d77a30df80861a56f81801f508df0945c543 Author: Jack Leigh jack.le...@collabora.com Date: Wed Mar 18 17:45:19 2015 + android: Bump to android-21 Change-Id: Ifbe9a316795fc0519119aa9420152118f3926653 Reviewed-on: https://gerrit.libreoffice.org/14946 Reviewed-by: Tomaž Vajngerl qui...@gmail.com Tested-by: Tomaž Vajngerl qui...@gmail.com diff --git a/android/Bootstrap/Makefile.shared b/android/Bootstrap/Makefile.shared index 5020773..c85e321 100644 --- a/android/Bootstrap/Makefile.shared +++ b/android/Bootstrap/Makefile.shared @@ -62,7 +62,7 @@ properties: echo sdk.dir=$(ANDROID_SDK_HOME) ../../Bootstrap/local.properties echo # File needed by ndk-gdb jni/Application.mk echo APP_ABI := $(ANDROID_APP_ABI) jni/Application.mk - echo APP_PLATFORM := android-15 jni/Application.mk + echo APP_PLATFORM := android-21 jni/Application.mk install: unset JAVA_HOME $(ANT) $(if $(VERBOSE)$(verbose),,-quiet) debug install diff --git a/android/Bootstrap/project.properties b/android/Bootstrap/project.properties index f28bc83..ca81324 100644 --- a/android/Bootstrap/project.properties +++ b/android/Bootstrap/project.properties @@ -9,4 +9,4 @@ android.library=true # Project target. -target=android-15 +target=android-21 diff --git a/android/experimental/DocumentLoader/project.properties b/android/experimental/DocumentLoader/project.properties index 772d3c5..3b68618 100644 --- a/android/experimental/DocumentLoader/project.properties +++ b/android/experimental/DocumentLoader/project.properties @@ -8,7 +8,7 @@ # project structure. # Project target. -target=android-15 +target=android-21 # Use the Bootstrap class android.library.reference.1=../../Bootstrap diff --git a/android/experimental/desktop/project.properties b/android/experimental/desktop/project.properties index 56b38d2..e25a76a 100644 --- a/android/experimental/desktop/project.properties +++ b/android/experimental/desktop/project.properties @@ -8,6 +8,6 @@ # project structure. # Project target. -target=android-15 +target=android-21 android.library.reference.1=../../Bootstrap ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - android/experimental
android/experimental/LOAndroid3/res/menu/view_menu.xml |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 45f9c8465a110edf8cd94a6ef2ce89fdfe660121 Author: Jack Leigh jack.le...@collabora.com Date: Sun Mar 22 16:49:39 2015 + android: Get search button to show again Even though it doesn't work... Change-Id: Ia84da613fd1e5cb3b2c9c5fa3d0458056b9cb728 Reviewed-on: https://gerrit.libreoffice.org/14950 Reviewed-by: Tomaž Vajngerl qui...@gmail.com Tested-by: Tomaž Vajngerl qui...@gmail.com diff --git a/android/experimental/LOAndroid3/res/menu/view_menu.xml b/android/experimental/LOAndroid3/res/menu/view_menu.xml index f316f5a..81a3aa5 100644 --- a/android/experimental/LOAndroid3/res/menu/view_menu.xml +++ b/android/experimental/LOAndroid3/res/menu/view_menu.xml @@ -1,8 +1,11 @@ ?xml version=1.0 encoding=utf-8? -menu xmlns:android=http://schemas.android.com/apk/res/android; +menu xmlns:android=http://schemas.android.com/apk/res/android; +xmlns:app=http://schemas.android.com/apk/res-auto; + item android:id=@+id/menu_search - android:icon=@drawable/action_search_light - android:showAsAction=always / + android:icon=@drawable/action_search + app:showAsAction=always / + item android:id=@+id/menu_view_toggle android:title=@string/grid_view/ item android:id=@+id/menu_sort_size ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - android/experimental
android/experimental/LOAndroid3/res/layout/activity_document_browser.xml | 36 ++ android/experimental/LOAndroid3/res/layout/file_grid.xml | 20 + android/experimental/LOAndroid3/res/layout/file_list.xml | 20 + android/experimental/LOAndroid3/res/values-v21/themes.xml | 10 ++ android/experimental/LOAndroid3/res/values/themes.xml |2 android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java | 12 ++- 6 files changed, 64 insertions(+), 36 deletions(-) New commits: commit 291f766d1ab276d4ae8146e666b45bf3e3e8035d Author: Jack Leigh jack.le...@collabora.com Date: Fri Mar 20 16:14:19 2015 + android: Migrate to Toolbar in file browser Change-Id: Ib5e3d0d39268437c179973ba4e785a719cdc351a Reviewed-on: https://gerrit.libreoffice.org/14949 Reviewed-by: Tomaž Vajngerl qui...@gmail.com Tested-by: Tomaž Vajngerl qui...@gmail.com diff --git a/android/experimental/LOAndroid3/res/layout/activity_document_browser.xml b/android/experimental/LOAndroid3/res/layout/activity_document_browser.xml new file mode 100644 index 000..f54591b --- /dev/null +++ b/android/experimental/LOAndroid3/res/layout/activity_document_browser.xml @@ -0,0 +1,36 @@ +?xml version=1.0 encoding=utf-8? +!-- + This file is part of the LibreOffice project. + + This Source Code Form is subject to the terms of the Mozilla Public + License, v. 2.0. If a copy of the MPL was not distributed with this + file, You can obtain one at http://mozilla.org/MPL/2.0/. + -- +android.support.v4.widget.DrawerLayout +xmlns:android=http://schemas.android.com/apk/res/android; +android:id=@+id/drawer_layout +android:layout_width=match_parent +android:layout_height=match_parent + +!-- The content -- +LinearLayout xmlns:android=http://schemas.android.com/apk/res/android; +android:id=@+id/browser_main_content +android:layout_width=match_parent +android:layout_height=match_parent +android:orientation=vertical + +include layout=@layout/toolbar/ + +/LinearLayout + +!-- The navigation drawer -- +ListView android:id=@+id/left_drawer +android:layout_width=240dp +android:layout_height=match_parent +android:layout_gravity=start +android:choiceMode=singleChoice +android:divider=@android:color/transparent +android:dividerHeight=0dp +android:background=#111/ + +/android.support.v4.widget.DrawerLayout diff --git a/android/experimental/LOAndroid3/res/layout/file_grid.xml b/android/experimental/LOAndroid3/res/layout/file_grid.xml index ec7fdd0..1885bd3 100644 --- a/android/experimental/LOAndroid3/res/layout/file_grid.xml +++ b/android/experimental/LOAndroid3/res/layout/file_grid.xml @@ -5,13 +5,11 @@ License, v. 2.0. If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/. -- -android.support.v4.widget.DrawerLayout -xmlns:android=http://schemas.android.com/apk/res/android; -android:id=@+id/drawer_layout +LinearLayout xmlns:android=http://schemas.android.com/apk/res/android; android:layout_width=match_parent -android:layout_height=match_parent +android:layout_height=match_parent +android:orientation=vertical -!-- The main content view -- GridView android:id=@+id/file_explorer_grid_view android:layout_width=fill_parent @@ -24,14 +22,4 @@ android:gravity=center /GridView -!-- The navigation drawer -- -ListView android:id=@+id/left_drawer -android:layout_width=240dp -android:layout_height=match_parent -android:layout_gravity=start -android:choiceMode=singleChoice -android:divider=@android:color/transparent -android:dividerHeight=0dp -android:background=#111/ - -/android.support.v4.widget.DrawerLayout +/LinearLayout diff --git a/android/experimental/LOAndroid3/res/layout/file_list.xml b/android/experimental/LOAndroid3/res/layout/file_list.xml index dd5346f..48dfb1e 100644 --- a/android/experimental/LOAndroid3/res/layout/file_list.xml +++ b/android/experimental/LOAndroid3/res/layout/file_list.xml @@ -6,27 +6,15 @@ License, v. 2.0. If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/. -- -android.support.v4.widget.DrawerLayout -xmlns:android=http://schemas.android.com/apk/res/android; -android:id=@+id/drawer_layout +LinearLayout xmlns:android=http://schemas.android.com/apk/res/android; android:layout_width=match_parent -android:layout_height=match_parent +android:layout_height=match_parent +android:orientation=vertical -!-- The main content view -- ListView android:id=@+id/file_explorer_list_view android:layout_width
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 2 commits - android/experimental
android/experimental/LOAndroid3/res/values/themes.xml
|2 -
android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
| 20 +++---
2 files changed, 7 insertions(+), 15 deletions(-)
New commits:
commit 046cd6a03adb6f9c0d6519e068c2244cafcc9b2d
Author: Jack Leigh jack.le...@collabora.com
Date: Thu Mar 19 14:43:14 2015 +
android: Change to v7 support ActionBar and new theme
Change-Id: I39d273e397a3bcbfc1d7140dca4af89858f2c06a
Reviewed-on: https://gerrit.libreoffice.org/14948
Reviewed-by: Tomaž Vajngerl qui...@gmail.com
Tested-by: Tomaž Vajngerl qui...@gmail.com
diff --git a/android/experimental/LOAndroid3/res/values/themes.xml
b/android/experimental/LOAndroid3/res/values/themes.xml
index 2d8f593..1468013 100644
--- a/android/experimental/LOAndroid3/res/values/themes.xml
+++ b/android/experimental/LOAndroid3/res/values/themes.xml
@@ -7,6 +7,6 @@
item name=windowActionBarfalse/item
/style
-style name=BrowserTheme parent=android:Theme.Holo.Light.DarkActionBar
+style name=BrowserTheme parent=Theme.AppCompat.Light
/style
/resources
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index 6c3d0d17..fe96cc6 100644
---
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -9,7 +9,6 @@
package org.libreoffice.ui;
-import android.app.ActionBar;
import android.app.Activity;
import android.content.ComponentName;
import android.content.Context;
@@ -23,6 +22,8 @@ import android.os.AsyncTask;
import android.os.Bundle;
import android.preference.PreferenceManager;
import android.support.v4.widget.DrawerLayout;
+import android.support.v7.app.ActionBar;
+import android.support.v7.app.ActionBarActivity;
import android.util.Log;
import android.view.ContextMenu;
import android.view.ContextMenu.ContextMenuInfo;
@@ -61,7 +62,7 @@ import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.List;
-public class LibreOfficeUIActivity extends Activity implements
ActionBar.OnNavigationListener {
+public class LibreOfficeUIActivity extends ActionBarActivity implements
ActionBar.OnNavigationListener {
private String LOGTAG = LibreOfficeUIActivity.class.getSimpleName();
private SharedPreferences prefs;
private int filterMode = FileUtilities.ALL;
@@ -111,7 +112,7 @@ public class LibreOfficeUIActivity extends Activity
implements ActionBar.OnNavig
public void createUI() {
-ActionBar actionBar = getActionBar();
+ActionBar actionBar = getSupportActionBar();
actionBar.setDisplayShowTitleEnabled(false); //This should show
current directory if anything
//make the navigation spinner
@@ -165,9 +166,9 @@ public class LibreOfficeUIActivity extends Activity
implements ActionBar.OnNavig
private void refreshView() {
// enable home icon as up if required
if (!currentDirectory.equals(homeDirectory)) {
-getActionBar().setDisplayHomeAsUpEnabled(true);
+getSupportActionBar().setDisplayHomeAsUpEnabled(true);
} else {
-getActionBar().setDisplayHomeAsUpEnabled(false);
+getSupportActionBar().setDisplayHomeAsUpEnabled(false);
}
// refresh view
if (viewMode == GRID_VIEW) {
commit b802a6ffc0c5006d5f64b637432c7d095af53d74
Author: Jack Leigh jack.le...@collabora.com
Date: Thu Mar 19 14:42:36 2015 +
android: Remove striping on ActionBar
Change-Id: I7b675e7cf5b28558be57e293547531a9369c3462
Reviewed-on: https://gerrit.libreoffice.org/14947
Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com
Reviewed-by: Tomaž Vajngerl qui...@gmail.com
Tested-by: Tomaž Vajngerl qui...@gmail.com
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index fee06b8..6c3d0d17 100644
---
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -122,15 +122,6 @@ public class LibreOfficeUIActivity extends Activity
implements ActionBar.OnNavig
actionBar.setNavigationMode(ActionBar.NAVIGATION_MODE_LIST);
actionBar.setListNavigationCallbacks(list, this);
-//make striped actionbar
-BitmapDrawable bg =
(BitmapDrawable)getResources().getDrawable(R.drawable.bg_striped);
-bg.setTileModeXY(Shader.TileMode.REPEAT, Shader.TileMode.REPEAT);
-actionBar.setBackgroundDrawable(bg);
-
-BitmapDrawable bgSplit =
(BitmapDrawable)getResources
[Libreoffice-commits] core.git: Changes to 'refs/changes/92/1192/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/72/1472/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/72/1472/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/58/1458/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/99/1199/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/99/1199/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/66/1266/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/23/1323/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/30/1230/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/66/1266/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/65/1265/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/52/1152/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/62/2762/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/12/1312/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/93/1193/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/93/1193/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/62/2762/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/50/850/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/98/1298/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/29/1429/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/63/2763/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/63/2763/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Please just tell people to do './logerrit setup' to get started, also: gerrit draft changes
On 26/03/13 14:52, Bjoern Michaelsen wrote: with: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=646b992ee306f83fa7175cc957cba9dc2277155a There's a typo of $GERRIUSER for $GERRITUSER in there by the look of it. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] various .ui fixes caught by linter tool
On 16/03/13 17:51, Michael Meeks wrote: Hi Jack, On Fri, 2013-03-15 at 18:32 +, Jack Leigh (via Code Review) wrote: various .ui fixes caught by linter tool Sounds really interesting :-) can we make the tool part of our build process somehow ? That was my aim at some point. It's in bin/lint-ui.py at the mo. Don't know enough about git commit hooks and whether if it was there it could prevent legitimate commits that need to be a bit hacky at this stage (there are a few). Maybe a make uicheck? Again, don't know enough about such things :D Cheers, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] first crack at writing a linter for .ui files
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2762
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/2762/1
first crack at writing a linter for .ui files
Change-Id: I51fd2b426e3292647ca618bf867d22275d7ed4fd
---
A bin/lint-ui.py
1 file changed, 89 insertions(+), 0 deletions(-)
diff --git a/bin/lint-ui.py b/bin/lint-ui.py
new file mode 100755
index 000..0c8a9ac
--- /dev/null
+++ b/bin/lint-ui.py
@@ -0,0 +1,89 @@
+#!/usr/bin/env python3
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, you can obtain one at http://mozilla.org/MPL/2.0/.
+#
+# Takes a LibreOffice .ui file and provides linting tips for maintaining
+# a consistent look for dialogs
+
+import sys
+import xml.etree.ElementTree as ET
+
+DEFAULT_WARNING_STR = 'Lint assertion failed'
+
+POSSIBLE_TOP_LEVEL_WIDGETS = ['GtkDialog', 'GtkBox', 'GtkFrame', 'GtkGrid']
+IGNORED_TOP_LEVEL_WIDGETS = ['GtkAdjustment', 'GtkImage', 'GtkListStore',
'GtkSizeGroup', 'GtkMenu', 'GtkTextBuffer']
+BORDER_WIDTH = '6'
+BUTTON_BOX_SPACING = '12'
+ALIGNMENT_TOP_PADDING = '6'
+
+def lint_assert(predicate, warning=DEFAULT_WARNING_STR):
+if not predicate:
+print(* + warning)
+
+def check_top_level_widget(element):
+# check widget type
+widget_type = element.attrib['class']
+lint_assert(widget_type in POSSIBLE_TOP_LEVEL_WIDGETS,
+Top level widget should be 'GtkDialog', 'GtkFrame', 'GtkBox',
or 'GtkGrid')
+
+# check border_width property
+border_width_properties = element.findall(property[@name='border_width'])
+if len(border_width_properties) 1:
+lint_assert(False, No border_width set on top level widget. Should
probably be + BORDER_WIDTH)
+if len(border_width_properties) == 1:
+border_width = border_width_properties[0]
+lint_assert(border_width.text == BORDER_WIDTH,
+Top level 'border_width' property should be +
BORDER_WIDTH)
+
+def check_button_box_spacing(element):
+spacing = element.findall(property[@name='spacing'])[0]
+lint_assert(spacing.text == BUTTON_BOX_SPACING,
+Button box 'spacing' should be + BUTTON_BOX_SPACING)
+
+def check_frames(root):
+frames = [element for element in root.findall('.//object') if
element.attrib['class'] == 'GtkFrame']
+for frame in frames:
+frame_alignments =
frame.findall(./child/object[@class='GtkAlignment'])
+assert len(frame_alignments) = 1
+if len(frame_alignments) 1:
+lint_assert(False, No GtkAlignment in GtkFrame with id = ' +
frame.attrib['id'] + ')
+if len(frame_alignments) == 1:
+alignment = frame_alignments[0]
+check_alignment_top_padding(alignment)
+
+def check_alignment_top_padding(alignment):
+top_padding_properties =
alignment.findall(./property[@name='top_padding'])
+assert len(top_padding_properties) = 1
+if len(top_padding_properties) 1:
+lint_assert(False, No GtkAlignment 'top_padding' set. Should probably
be + ALIGNMENT_TOP_PADDING)
+if len(top_padding_properties) == 1:
+top_padding = top_padding_properties[0]
+lint_assert(top_padding.text == ALIGNMENT_TOP_PADDING,
+GtkAlignment 'top_padding' should be +
ALIGNMENT_TOP_PADDING)
+
+def main():
+print( == + sys.argv[1] + ==)
+tree = ET.parse(sys.argv[1])
+root = tree.getroot()
+
+top_level_widgets = [element for element in root.findall('object') if
element.attrib['class'] not in IGNORED_TOP_LEVEL_WIDGETS]
+assert len(top_level_widgets) == 1
+
+top_level_widget = top_level_widgets[0]
+check_top_level_widget(top_level_widget)
+
+# TODO - only do this if we have a GtkDialog?
+# check button box spacing
+button_box = top_level_widget.findall(child[@id='dialog-vbox1'])
+if len(button_box) 0:
+element = button_box[0]
+check_button_box_spacing(element)
+
+check_frames(root)
+
+if __name__ == __main__:
+main()
--
To view, visit https://gerrit.libreoffice.org/2762
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51fd2b426e3292647ca618bf867d22275d7ed4fd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jack Leigh leigh...@gmx.se
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] various .ui fixes caught by linter tool
@@ property name=can_focusFalse/property property name=hexpandTrue/property property name=vexpandTrue/property +property name=border_width6/property property name=row_spacing6/property property name=column_spacing6/property child @@ -42,6 +43,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property +property name=top_padding6/property property name=bottom_padding6/property property name=left_padding12/property child diff --git a/sw/uiconfig/swriter/ui/outlinenumberingpage.ui b/sw/uiconfig/swriter/ui/outlinenumberingpage.ui index 550aa26..d16f8f7 100644 --- a/sw/uiconfig/swriter/ui/outlinenumberingpage.ui +++ b/sw/uiconfig/swriter/ui/outlinenumberingpage.ui @@ -18,6 +18,7 @@ property name=can_focusFalse/property property name=margin_left10/property property name=margin_right10/property +property name=border_width6/property child object class=GtkFrame id=frame1 property name=visibleTrue/property @@ -28,6 +29,7 @@ object class=GtkAlignment id=alignment1 property name=visibleTrue/property property name=can_focusFalse/property +property name=top_padding6/property property name=left_padding12/property child object class=GtkTreeView id=level @@ -69,6 +71,7 @@ object class=GtkAlignment id=alignment2 property name=visibleTrue/property property name=can_focusFalse/property +property name=top_padding6/property property name=left_padding12/property child object class=GtkBox id=box2 diff --git a/sw/uiconfig/swriter/ui/outlinepositionpage.ui b/sw/uiconfig/swriter/ui/outlinepositionpage.ui index 08e19f1..de97b4b 100644 --- a/sw/uiconfig/swriter/ui/outlinepositionpage.ui +++ b/sw/uiconfig/swriter/ui/outlinepositionpage.ui @@ -19,6 +19,7 @@ property name=margin_right10/property property name=hexpandTrue/property property name=vexpandTrue/property +property name=border_width6/property child object class=GtkFrame id=frame3 property name=visibleTrue/property @@ -29,6 +30,7 @@ object class=GtkAlignment id=alignment5 property name=visibleTrue/property property name=can_focusFalse/property +property name=top_padding6/property property name=left_padding12/property child object class=GtkTreeView id=levellb @@ -76,6 +78,7 @@ property name=can_focusFalse/property property name=hexpandTrue/property property name=vexpandTrue/property +property name=top_padding6/property property name=left_padding12/property child object class=GtkGrid id=grid1 diff --git a/sw/uiconfig/swriter/ui/statisticsinfopage.ui b/sw/uiconfig/swriter/ui/statisticsinfopage.ui index 0fbae92..7034eae 100644 --- a/sw/uiconfig/swriter/ui/statisticsinfopage.ui +++ b/sw/uiconfig/swriter/ui/statisticsinfopage.ui @@ -4,6 +4,7 @@ object class=GtkGrid id=StatisticsInfoPage property name=visibleTrue/property property name=can_focusFalse/property +property name=border_width6/property property name=row_spacing12/property property name=column_spacing18/property child diff --git a/sw/uiconfig/swriter/ui/tablecolumnpage.ui b/sw/uiconfig/swriter/ui/tablecolumnpage.ui index 25da9f2..ee22c3e 100644 --- a/sw/uiconfig/swriter/ui/tablecolumnpage.ui +++ b/sw/uiconfig/swriter/ui/tablecolumnpage.ui @@ -28,6 +28,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property +property name=border_width6/property property name=row_spacing12/property child object class=GtkCheckButton id=adaptwidth diff --git a/sw/uiconfig/swriter/ui/tabletextflowpage.ui b/sw/uiconfig/swriter/ui/tabletextflowpage.ui index b31c36a..9af0800 100644 --- a/sw/uiconfig/swriter/ui/tabletextflowpage.ui +++ b/sw/uiconfig/swriter/ui/tabletextflowpage.ui @@ -59,6 +59,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property +property name=border_width6/property property name=row_spacing5/property property name=column_spacing5/property child -- To view, visit https://gerrit.libreoffice.org/2763 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic92ddc9550b33358a3bb0458b31a23f2c32fd46f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http
[Libreoffice-commits] core.git: bin/lint-ui.py
bin/lint-ui.py | 89 +
1 file changed, 89 insertions(+)
New commits:
commit 1b5898a3151097e85c768144e69ebb5601d5babb
Author: Jack Leigh leigh...@gmx.se
Date: Fri Mar 15 17:07:02 2013 +
first crack at writing a linter for .ui files
Change-Id: I51fd2b426e3292647ca618bf867d22275d7ed4fd
Reviewed-on: https://gerrit.libreoffice.org/2762
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
diff --git a/bin/lint-ui.py b/bin/lint-ui.py
new file mode 100755
index 000..0c8a9ac
--- /dev/null
+++ b/bin/lint-ui.py
@@ -0,0 +1,89 @@
+#!/usr/bin/env python3
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, you can obtain one at http://mozilla.org/MPL/2.0/.
+#
+# Takes a LibreOffice .ui file and provides linting tips for maintaining
+# a consistent look for dialogs
+
+import sys
+import xml.etree.ElementTree as ET
+
+DEFAULT_WARNING_STR = 'Lint assertion failed'
+
+POSSIBLE_TOP_LEVEL_WIDGETS = ['GtkDialog', 'GtkBox', 'GtkFrame', 'GtkGrid']
+IGNORED_TOP_LEVEL_WIDGETS = ['GtkAdjustment', 'GtkImage', 'GtkListStore',
'GtkSizeGroup', 'GtkMenu', 'GtkTextBuffer']
+BORDER_WIDTH = '6'
+BUTTON_BOX_SPACING = '12'
+ALIGNMENT_TOP_PADDING = '6'
+
+def lint_assert(predicate, warning=DEFAULT_WARNING_STR):
+if not predicate:
+print(* + warning)
+
+def check_top_level_widget(element):
+# check widget type
+widget_type = element.attrib['class']
+lint_assert(widget_type in POSSIBLE_TOP_LEVEL_WIDGETS,
+Top level widget should be 'GtkDialog', 'GtkFrame', 'GtkBox',
or 'GtkGrid')
+
+# check border_width property
+border_width_properties = element.findall(property[@name='border_width'])
+if len(border_width_properties) 1:
+lint_assert(False, No border_width set on top level widget. Should
probably be + BORDER_WIDTH)
+if len(border_width_properties) == 1:
+border_width = border_width_properties[0]
+lint_assert(border_width.text == BORDER_WIDTH,
+Top level 'border_width' property should be +
BORDER_WIDTH)
+
+def check_button_box_spacing(element):
+spacing = element.findall(property[@name='spacing'])[0]
+lint_assert(spacing.text == BUTTON_BOX_SPACING,
+Button box 'spacing' should be + BUTTON_BOX_SPACING)
+
+def check_frames(root):
+frames = [element for element in root.findall('.//object') if
element.attrib['class'] == 'GtkFrame']
+for frame in frames:
+frame_alignments =
frame.findall(./child/object[@class='GtkAlignment'])
+assert len(frame_alignments) = 1
+if len(frame_alignments) 1:
+lint_assert(False, No GtkAlignment in GtkFrame with id = ' +
frame.attrib['id'] + ')
+if len(frame_alignments) == 1:
+alignment = frame_alignments[0]
+check_alignment_top_padding(alignment)
+
+def check_alignment_top_padding(alignment):
+top_padding_properties =
alignment.findall(./property[@name='top_padding'])
+assert len(top_padding_properties) = 1
+if len(top_padding_properties) 1:
+lint_assert(False, No GtkAlignment 'top_padding' set. Should probably
be + ALIGNMENT_TOP_PADDING)
+if len(top_padding_properties) == 1:
+top_padding = top_padding_properties[0]
+lint_assert(top_padding.text == ALIGNMENT_TOP_PADDING,
+GtkAlignment 'top_padding' should be +
ALIGNMENT_TOP_PADDING)
+
+def main():
+print( == + sys.argv[1] + ==)
+tree = ET.parse(sys.argv[1])
+root = tree.getroot()
+
+top_level_widgets = [element for element in root.findall('object') if
element.attrib['class'] not in IGNORED_TOP_LEVEL_WIDGETS]
+assert len(top_level_widgets) == 1
+
+top_level_widget = top_level_widgets[0]
+check_top_level_widget(top_level_widget)
+
+# TODO - only do this if we have a GtkDialog?
+# check button box spacing
+button_box = top_level_widget.findall(child[@id='dialog-vbox1'])
+if len(button_box) 0:
+element = button_box[0]
+check_button_box_spacing(element)
+
+check_frames(root)
+
+if __name__ == __main__:
+main()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/uiconfig desktop/uiconfig padmin/uiconfig sw/uiconfig
cui/uiconfig/ui/gradientpage.ui| 33 + cui/uiconfig/ui/insertfloatingframe.ui | 25 ++ desktop/uiconfig/ui/cmdlinehelp.ui |5 +-- padmin/uiconfig/ui/printerdevicepage.ui|1 padmin/uiconfig/ui/printerpaperpage.ui |1 sw/uiconfig/swriter/ui/columnwidth.ui |2 - sw/uiconfig/swriter/ui/documentfontspage.ui|3 -- sw/uiconfig/swriter/ui/endnotepage.ui |4 +++ sw/uiconfig/swriter/ui/footnotepage.ui |5 +++ sw/uiconfig/swriter/ui/formattablepage.ui |2 + sw/uiconfig/swriter/ui/outlinenumberingpage.ui |3 ++ sw/uiconfig/swriter/ui/outlinepositionpage.ui |3 ++ sw/uiconfig/swriter/ui/statisticsinfopage.ui |1 sw/uiconfig/swriter/ui/tablecolumnpage.ui |1 sw/uiconfig/swriter/ui/tabletextflowpage.ui|1 15 files changed, 41 insertions(+), 49 deletions(-) New commits: commit 26b05cb792bde1052d1a85926e902e3b3dafdc89 Author: Jack Leigh leigh...@gmx.se Date: Fri Mar 15 18:15:18 2013 + various .ui fixes caught by linter tool Change-Id: Ic92ddc9550b33358a3bb0458b31a23f2c32fd46f Reviewed-on: https://gerrit.libreoffice.org/2763 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/cui/uiconfig/ui/gradientpage.ui b/cui/uiconfig/ui/gradientpage.ui index bea9f2e..1978aa7 100644 --- a/cui/uiconfig/ui/gradientpage.ui +++ b/cui/uiconfig/ui/gradientpage.ui @@ -10,6 +10,7 @@ property name=can_focusFalse/property property name=hexpandTrue/property property name=vexpandTrue/property +property name=border_width6/property property name=orientationvertical/property child object class=GtkFrame id=frame1 @@ -283,7 +284,16 @@ /packing /child child - placeholder/ + object class=GtkLabel id=anglemtrdegrees +property name=can_focusFalse/property +property name=label translatable=yes degrees/property + /object + packing +property name=left_attach2/property +property name=top_attach3/property +property name=width1/property +property name=height1/property + /packing /child child placeholder/ @@ -313,16 +323,7 @@ placeholder/ /child child - object class=GtkLabel id=anglemtrdegrees -property name=can_focusFalse/property -property name=label translatable=yes degrees/property - /object - packing -property name=left_attach2/property -property name=top_attach3/property -property name=width1/property -property name=height1/property - /packing + placeholder/ /child /object packing @@ -385,11 +386,9 @@ child object class=GtkButton id=add property name=labelgtk-add/property -property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property -property name=use_action_appearanceFalse/property property name=use_stockTrue/property /object packing @@ -401,11 +400,9 @@ child object class=GtkButton id=modify property name=label translatable=yes_Modify/property -property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property property name=receives_defaultTrue/property -property name=use_action_appearanceFalse/property property name=use_underlineTrue/property /object packing @@ -417,11 +414,9 @@ child object class=GtkButton id=delete property name=labelgtk-delete/property -property name=use_action_appearanceFalse/property property name=visibleTrue/property property name=can_focusTrue/property
[Libreoffice-commits] core.git: Branch 'feature/liblibo' - desktop/inc desktop/Library_libreoffice.mk desktop/source smoketest/libtest.cxx
desktop/Library_libreoffice.mk |6 ++
desktop/inc/liblibreoffice.h | 38 --
desktop/source/lib/init.cxx| 32 +---
desktop/source/lib/shim.cxx| 12
smoketest/libtest.cxx |6 --
5 files changed, 31 insertions(+), 63 deletions(-)
New commits:
commit 18b1da0d34f5712c78c4616a570a3a9114f5061c
Author: Jack Leigh leigh...@gmx.se
Date: Tue Mar 5 16:19:58 2013 +
liblibo: move to C++ interface.
Change-Id: Ie14a9446abd9524604feddf811d5373a26a30cbd
diff --git a/desktop/Library_libreoffice.mk b/desktop/Library_libreoffice.mk
index a40bbd7..96b18a1 100644
--- a/desktop/Library_libreoffice.mk
+++ b/desktop/Library_libreoffice.mk
@@ -14,6 +14,12 @@ $(eval $(call gb_Library_set_include,libreoffice,\
-I$(SRCDIR)/desktop/inc \
))
+$(eval $(call gb_Library_add_libs,libreoffice,\
+ $(if $(filter $(OS),LINUX), \
+ -ldl \
+ ) \
+))
+
$(eval $(call gb_Library_use_libraries,libreoffice,\
$(gb_UWINAPI) \
))
diff --git a/desktop/inc/liblibreoffice.h b/desktop/inc/liblibreoffice.h
deleted file mode 100644
index dde50ce..000
--- a/desktop/inc/liblibreoffice.h
+++ /dev/null
@@ -1,38 +0,0 @@
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-/*
- * A simple C API to setup and use libreoffice
- */
-#ifdef __cplusplus
-extern C {
-#endif
-
-typedef struct {
- int errno;
- char *message;
-} LOError;
-
-typedef int loboolean;
-typedef struct _LODocument LODocument;
-
-loboolean lo_initialize (const char *install_path);
-
-void lo_error_free (LOError *error);
-LOError *lo_error_new (int errno, const char *message);
-
-LODocument *lo_document_load (const char *url, LOError **opt_error);
-loboolean lo_document_save (const char *url, LOError **opt_error);
-
-#ifdef __cplusplus
-} /* extern C */
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
-
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 5aab66b..4b47ac6 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -7,9 +7,10 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#include liblibreoffice_impl.hxx
+
#include stdio.h
-#include liblibreoffice.h
#include tools/errinf.hxx
#include osl/file.hxx
#include rtl/strbuf.hxx
@@ -35,25 +36,14 @@ static uno::Referencecss::uno::XComponentContext xContext;
static uno::Referencecss::lang::XMultiServiceFactory xSFactory;
static uno::Referencecss::lang::XMultiComponentFactory xFactory;
-SAL_DLLPUBLIC_EXPORT void
-lo_error_free( LOError * )
-{
-}
-
-SAL_DLLPUBLIC_EXPORT LOError *
-lo_error_new( int, const char * )
+LODocument *
+LibLibreOffice_Impl::documentLoad( const char *docUrl )
{
return NULL;
}
-SAL_DLLPUBLIC_EXPORT LODocument *
-lo_document_load( const char *, LOError ** )
-{
-return NULL;
-}
-
-SAL_DLLPUBLIC_EXPORT loboolean
-lo_document_save( const char *, LOError ** )
+loboolean
+LibLibreOffice_Impl::documentSave( const char * )
{
return 1;
}
@@ -92,8 +82,8 @@ initialize_uno( const rtl::OUString aUserProfileURL )
xSFactory = uno::Referencelang::XMultiServiceFactory(xFactory,
uno::UNO_QUERY_THROW);
}
-SAL_DLLPUBLIC_EXPORT loboolean
-lo_initialize( const char *app_path )
+loboolean
+LibLibreOffice_Impl::initialize( const char *app_path )
{
static bool bInitialized = false;
if( bInitialized )
@@ -132,7 +122,11 @@ extern C {
LibLibreOffice *liblibreoffice_hook(void)
{
-return new LibLibreOffice();
+return new LibLibreOffice_Impl();
+}
+
+LibLibreOffice_Impl::~LibLibreOffice_Impl ()
+{
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/desktop/source/lib/shim.cxx b/desktop/source/lib/shim.cxx
index c57803e..4c8e61d 100644
--- a/desktop/source/lib/shim.cxx
+++ b/desktop/source/lib/shim.cxx
@@ -9,8 +9,12 @@
#ifdef LINUX
+#include stdio.h
+#include string.h
+
+#include osl/module.h
#include sal/types.h
-#include liblibreoffice.h
+#include liblibreoffice.hxx
#include dlfcn.h
#ifdef AIX
@@ -23,11 +27,11 @@ extern C {
typedef LibLibreOffice *(HookFunction)(void);
};
-extern LibLibreOffice *lo_init( const char *install_path )
+SAL_DLLPUBLIC_EXPORT LibLibreOffice *lo_init( const char *install_path )
{
if( !install_path )
return NULL;
-char *impl_lib = malloc( strlen (install_path) + sizeof( TARGET_LIB ) + 2
);
+char *imp_lib = (char *) malloc( strlen (install_path) + sizeof(
TARGET_LIB ) + 2 );
strcpy( imp_lib, install_path );
strcat( imp_lib, / );
strcat( imp_lib, TARGET_LIB );
@@ -39,7 +43,7 @@ extern LibLibreOffice *lo_init( const char
[Libreoffice-commits] core.git: Branch 'feature/liblibo' - desktop/inc
desktop/inc/liblibreoffice.hxx | 30 ++
desktop/inc/liblibreoffice_impl.hxx | 30 ++
2 files changed, 60 insertions(+)
New commits:
commit 6b5abcd2a2157276acb8416b4daab21fb4a76952
Author: Jack Leigh leigh...@gmx.se
Date: Tue Mar 5 16:26:27 2013 +
liblibo: add forgotten headers.
Change-Id: I9478e3f1fb603da078484e6f4e662ccfe0b01fe9
diff --git a/desktop/inc/liblibreoffice.hxx b/desktop/inc/liblibreoffice.hxx
new file mode 100644
index 000..74f6769
--- /dev/null
+++ b/desktop/inc/liblibreoffice.hxx
@@ -0,0 +1,30 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef _LIBLIBREOFFICE_HXX
+#define _LIBLIBREOFFICE_HXX
+
+typedef int loboolean;
+typedef struct _LODocument LODocument;
+
+class LibLibreOffice
+{
+public:
+virtual loboolean initialize (const char *installPath) = 0;
+
+virtual LODocument *documentLoad (const char *url) = 0;
+virtual loboolean documentSave (const char *url) = 0;
+
+virtual ~LibLibreOffice () {};
+};
+
+LibLibreOffice *lo_init (const char *install_path);
+
+#endif
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/desktop/inc/liblibreoffice_impl.hxx
b/desktop/inc/liblibreoffice_impl.hxx
new file mode 100644
index 000..d7686eb
--- /dev/null
+++ b/desktop/inc/liblibreoffice_impl.hxx
@@ -0,0 +1,30 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef _LIBLIBREOFFICE_IMPL_HXX
+#define _LIBLIBREOFFICE_IMPL_HXX
+
+#include liblibreoffice.hxx
+
+typedef int loboolean;
+typedef struct _LODocument LODocument;
+
+class LibLibreOffice_Impl : public LibLibreOffice
+{
+public:
+virtual loboolean initialize (const char *installPath);
+
+virtual LODocument *documentLoad (const char *url);
+virtual loboolean documentSave (const char *url);
+
+virtual ~LibLibreOffice_Impl ();
+};
+
+#endif
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/liblibo' - 2 commits - desktop/inc desktop/source smoketest/CppunitTest_liblibreoffice.mk smoketest/libtest.cxx
desktop/inc/liblibreoffice.hxx |5 ++---
desktop/inc/liblibreoffice_impl.hxx |7 ++-
desktop/source/lib/init.cxx | 22 +++---
desktop/source/lib/shim.cxx |3 ++-
smoketest/CppunitTest_liblibreoffice.mk | 17 ++---
smoketest/libtest.cxx |6 +-
6 files changed, 32 insertions(+), 28 deletions(-)
New commits:
commit 94a2596446bfdd9bddc3590b6e81c0e9052b7325
Author: Jack Leigh leigh...@gmx.se
Date: Tue Mar 5 14:29:26 2013 +
liblibo: create XComponent for doc
Change-Id: Ie07ac4a3e89a9a82a107612b81be18d3826c49e1
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index eb85bcb..ce7632f 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -13,11 +13,14 @@
#include tools/errinf.hxx
#include osl/file.hxx
+#include osl/process.h
#include rtl/strbuf.hxx
#include rtl/bootstrap.hxx
#include cppuhelper/bootstrap.hxx
#include comphelper/processfactory.hxx
+#include com/sun/star/beans/XPropertySet.hpp
+#include com/sun/star/frame/Desktop.hpp
#include com/sun/star/lang/Locale.hpp
#include com/sun/star/lang/XComponent.hpp
#include com/sun/star/lang/XMultiServiceFactory.hpp
@@ -39,6 +42,19 @@ static uno::Referencecss::lang::XMultiComponentFactory
xFactory;
LODocument *
LibLibreOffice_Impl::documentLoad( const char *docUrl )
{
+OUString sUrl = OUString::createFromAscii (docUrl);
+OUString sAbsoluteDocUrl, sWorkingDir, sDocPathUrl;
+
+uno::Reference css::frame::XDesktop2 xComponentLoader =
+css::frame::Desktop::create(xContext);
+
+osl_getProcessWorkingDir(sWorkingDir.pData);
+osl::FileBase::getFileURLFromSystemPath(sUrl, sDocPathUrl);
+osl::FileBase::getAbsoluteFileURL(sWorkingDir, sDocPathUrl,
sAbsoluteDocUrl);
+
+uno::Reference css::lang::XComponent xComponent =
xComponentLoader-loadComponentFromURL(
+sAbsoluteDocUrl, OUString(_blank), 0,
+uno::Sequence css::beans::PropertyValue ());
return NULL;
}
@@ -131,4 +147,3 @@ LibLibreOffice_Impl::~LibLibreOffice_Impl ()
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
-
commit 0dce100c3b4255a959dc3ad957b86956a5bf22ce
Author: Michael Meeks michael.me...@suse.com
Date: Tue Mar 5 16:40:01 2013 +
liblibo: misc. cleanup
Change-Id: I40fc77f2a7a0fd01d3cec94a8b630dddc4637baf
diff --git a/desktop/inc/liblibreoffice.hxx b/desktop/inc/liblibreoffice.hxx
index 74f6769..48c0a24 100644
--- a/desktop/inc/liblibreoffice.hxx
+++ b/desktop/inc/liblibreoffice.hxx
@@ -10,16 +10,15 @@
#ifndef _LIBLIBREOFFICE_HXX
#define _LIBLIBREOFFICE_HXX
-typedef int loboolean;
typedef struct _LODocument LODocument;
class LibLibreOffice
{
public:
-virtual loboolean initialize (const char *installPath) = 0;
+virtual bool initialize (const char *installPath) = 0;
virtual LODocument *documentLoad (const char *url) = 0;
-virtual loboolean documentSave (const char *url) = 0;
+virtual bool documentSave (const char *url) = 0;
virtual ~LibLibreOffice () {};
};
diff --git a/desktop/inc/liblibreoffice_impl.hxx
b/desktop/inc/liblibreoffice_impl.hxx
index d7686eb..3f7783e 100644
--- a/desktop/inc/liblibreoffice_impl.hxx
+++ b/desktop/inc/liblibreoffice_impl.hxx
@@ -12,16 +12,13 @@
#include liblibreoffice.hxx
-typedef int loboolean;
-typedef struct _LODocument LODocument;
-
class LibLibreOffice_Impl : public LibLibreOffice
{
public:
-virtual loboolean initialize (const char *installPath);
+virtual boolinitialize (const char *installPath);
virtual LODocument *documentLoad (const char *url);
-virtual loboolean documentSave (const char *url);
+virtual booldocumentSave (const char *url);
virtual ~LibLibreOffice_Impl ();
};
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 4b47ac6..eb85bcb 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -42,7 +42,7 @@ LibLibreOffice_Impl::documentLoad( const char *docUrl )
return NULL;
}
-loboolean
+bool
LibLibreOffice_Impl::documentSave( const char * )
{
return 1;
@@ -82,7 +82,7 @@ initialize_uno( const rtl::OUString aUserProfileURL )
xSFactory = uno::Referencelang::XMultiServiceFactory(xFactory,
uno::UNO_QUERY_THROW);
}
-loboolean
+bool
LibLibreOffice_Impl::initialize( const char *app_path )
{
static bool bInitialized = false;
@@ -122,6 +122,7 @@ extern C {
LibLibreOffice *liblibreoffice_hook(void)
{
+fprintf( stderr, create libreoffice object\n );
return new LibLibreOffice_Impl();
}
diff --git a/desktop/source/lib/shim.cxx b/desktop/source/lib/shim.cxx
index 4c8e61d..546d0da 100644
--- a/desktop/source/lib/shim.cxx
+++ b/desktop/source/lib/shim.cxx
@@ -41,13 +41,14 @@ SAL_DLLPUBLIC_EXPORT LibLibreOffice *lo_init( const char
*install_path )
fprintf( stderr, failed to open library '%s'\n
[Libreoffice-commits] core.git: Branch 'feature/liblibo' - smoketest/CppunitTest_liblibreoffice.mk smoketest/libtest.cxx
smoketest/CppunitTest_liblibreoffice.mk |1 + smoketest/libtest.cxx |6 ++ 2 files changed, 7 insertions(+) New commits: commit 62be87c650483ce30556505c493ca5047cfd7c27 Author: Jack Leigh leigh...@gmx.se Date: Tue Mar 5 16:47:03 2013 + liblibo: test documentLoad method Change-Id: I7827a9b96e5a18b7f0b8b374a49ab96625d22d0a diff --git a/smoketest/CppunitTest_liblibreoffice.mk b/smoketest/CppunitTest_liblibreoffice.mk index 8755fe8..e784a3a 100644 --- a/smoketest/CppunitTest_liblibreoffice.mk +++ b/smoketest/CppunitTest_liblibreoffice.mk @@ -27,6 +27,7 @@ endif $(eval $(call gb_CppunitTest_add_arguments,liblibreoffice,\ -env:arg-soffice=$(liblibreoffice_SOFFICE_INST) \ + -env:arg-testarg.smoketest.doc=$(OUTDIR)/bin/smoketestdoc.sxw \ )) # vim: set noet sw=4 ts=4: diff --git a/smoketest/libtest.cxx b/smoketest/libtest.cxx index cc71d08..4e452a7 100644 --- a/smoketest/libtest.cxx +++ b/smoketest/libtest.cxx @@ -51,6 +51,12 @@ void Test::test() bool bInited = pOffice-initialize( aInstall.getStr() ); CPPUNIT_ASSERT( bInited ); + +rtl::OUString aArgDoc; +rtl::Bootstrap::get( rtl::OUString( arg-testarg.smoketest.doc ), aArgDoc ); +OString aDoc = OUStringToOString ( aArgDoc, RTL_TEXTENCODING_UTF8 ); +fprintf ( stderr, liblibreoffice doc arg: '%s'\n, aDoc.getStr() ); +pOffice-documentLoad ( aDoc.getStr() ); } CPPUNIT_TEST_SUITE_REGISTRATION(Test); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Unable to build due to libwpd-stream.h missing
I saw that there was a commit yesterday by Bjoern Michaelsen to attempt to fix the issue and can confirm after pulling the latest git I was able to successfully compile. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call ...
On 21/02/13 18:13, Jean-Noël Rouvignac wrote: 2013/2/21 Lubos Lunak l.lu...@suse.cz On Thursday 21 of February 2013, Michael Meeks wrote: Hi Lubos, On Mon, 2013-02-18 at 15:01 +0100, Lubos Lunak wrote: All I'm saying is that 'do not merge' is vague enough to not say what it in fact does or where the line between -1 and -2 is, and 'I disagree with the change, needs discussion first' or similar is clearer there and still reasonably short. So can you propose a better string ? how about this one: block merging for now Which is brief, open-ended, uses merge not submit and describes the function of -2 perhaps better to both reviewer and reviewee. This is again vague enough to apply to -1 as well (-1 is also block merging for now). I did propose already one string I think is better, but if you want to put it this way, then it should be e.g. block merging until objections are cleared or so. How about Do not merge, let's discuss the approach or Do not merge, let's discuss the design? This is inviting and explains that the code won't be merge as without discussing the design. In this vein -1 is currently 'This need' and it should surely be 'This needs'. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Unable to build due to libwpd-stream.h missing
Hello, I'm unable to build the latest LibreOffice git on ArchLinux due to the following error: VSDInternalStream.h:37:41: fatal error: libwpd-stream/libwpd-stream.h: No such file or directory libwpd-stream/libwpd-stream.h does in fact exist in /usr/include/libwpd-0.9/ on my machine. Running autogen.sh also output: checking which libwpd to use... internal config_host.mk - http://pastebin.ca/2315767 Thanks, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: GTK equivalence to VCL Tristatebox
On 04/02/13 10:21, Olivier Hallot wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am converting the cell protection tab page of calc to the new widgets. On testing, vcl complains that GTK checkbox must be mapped to VCL Tristatebox. How do I fix that? Thanks. They are listed as Tristatebox in the header file. I don't know enough about how tristate buttons are mapped but it may just be a case of changing them to CheckBox * which corresponds to GtkCheckButton. Cheers, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Stagnant NEEDINFO bugs
c) a reminder + automated closing of bug after some period of time +1 Something like automated closing after 3 months in NEEDINFO ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: Addin exceptions in SvStream
On 30/12/12 15:41, Marc-André Laverdière wrote: @Lubos. I started writing a plug-in. I have a problem with compiling, however. It somehow doesn't find the headers on my system. This is the autogen.sh I use (I tried with and without --includedir, and --includedir=/usr/) ./autogen.sh CC=clang CXX=clang++ --includedir=/usr/include/ --enable-compiler-plugins I get this in the output: checking clang/AST/RecursiveASTVisitor.h usability... no checking clang/AST/RecursiveASTVisitor.h presence... no checking for clang/AST/RecursiveASTVisitor.h... no configure: error: Cannot find Clang headers to build compiler plugins. Yet... $ ls /usr/include/clang/AST/RecursiveASTVisitor.h /usr/include/clang/AST/RecursiveASTVisitor.h I am on Linux Mint 14. Any clue what is going on? IIRC it needs llvm headers that *buntu puts in /usr/lib eg. /usr/lib/llvm-3.0/include Didn't know how I should patch the configure file tho ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Addin exceptions in SvStream
On 30/12/12 15:41, Marc-André Laverdière wrote: @Lubos. I started writing a plug-in. I have a problem with compiling, however. It somehow doesn't find the headers on my system. This is the autogen.sh I use (I tried with and without --includedir, and --includedir=/usr/) ./autogen.sh CC=clang CXX=clang++ --includedir=/usr/include/ --enable-compiler-plugins I get this in the output: checking clang/AST/RecursiveASTVisitor.h usability... no checking clang/AST/RecursiveASTVisitor.h presence... no checking for clang/AST/RecursiveASTVisitor.h... no configure: error: Cannot find Clang headers to build compiler plugins. Yet... $ ls /usr/include/clang/AST/RecursiveASTVisitor.h /usr/include/clang/AST/RecursiveASTVisitor.h I am on Linux Mint 14. Any clue what is going on? IIRC it needs llvm headers that *buntu puts in /usr/lib eg. /usr/lib/llvm-3.0/include Didn't know how I should patch the configure file tho ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice ...... Libraries VCL
On 28/12/12 17:00, Enrico Weigelt wrote: However - we're moving towards a new way of drawing, and laying out dialogs - which uses a true 'layout' approach - this makes it much easier to draw them (using the 'glade' tool), it also simplifies the code. You can read about that here: https://wiki.documentfoundation.org/Development/WidgetLayout The examples links are broken :( Fixed. Some sort of git log --grep=' ui' will find plenty of others. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Bugs.freedesktop.org text/plain problem
There's an open fdo bug about it at https://bugs.freedesktop.org/show_bug.cgi?id=55270 but nothing has happened lately. Needs someone with a bit of influence to do some exerting since it's a real PITA. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[PATCH] fdo#58651 improve layout/spacing of positionpage.ui
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1472 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/1472/1 fdo#58651 improve layout/spacing of positionpage.ui Change-Id: I17dde604a94989e0f3fb0c8a6c0e3e6e1f362574 --- M cui/uiconfig/ui/positionpage.ui 1 file changed, 165 insertions(+), 135 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1472 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I17dde604a94989e0f3fb0c8a6c0e3e6e1f362574 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] tabs to spaces
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1458 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/1458/1 tabs to spaces Change-Id: I4f1c834f28cb49ec0dcb824280d348226ad7e514 --- M sfx2/inc/sfx2/sfxsids.hrc 1 file changed, 1 insertion(+), 1 deletion(-) -- To view, visit https://gerrit.libreoffice.org/1458 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4f1c834f28cb49ec0dcb824280d348226ad7e514 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] improve padding on character dialog pages
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1429 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/1429/1 improve padding on character dialog pages Change-Id: I778dd8e427618a9761cc90683e7d8ac986e27c94 --- M cui/uiconfig/ui/charnamepage.ui M cui/uiconfig/ui/effectspage.ui M cui/uiconfig/ui/positionpage.ui M sw/uiconfig/swriter/ui/charurlpage.ui 4 files changed, 15 insertions(+), 0 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1429 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I778dd8e427618a9761cc90683e7d8ac986e27c94 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fix alphebetization
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1323 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1323/1 fix alphebetization Change-Id: Iabf4d1e4d02c81cab580c07b65bb17da1877c6b1 --- M cui/UI_cui.mk 1 file changed, 2 insertions(+), 2 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1323 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iabf4d1e4d02c81cab580c07b65bb17da1877c6b1 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] migrate 'Caption options' dialog to .ui file
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1312 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1312/1 migrate 'Caption options' dialog to .ui file Change-Id: I58dbb70faf22c5958b65e5192664b7d12d62f04c --- M sw/AllLangResTarget_sw.mk M sw/UI_swriter.mk M sw/inc/globals.hrc M sw/inc/helpid.h M sw/source/ui/app/app.src M sw/source/ui/frmdlg/cption.cxx D sw/source/ui/frmdlg/cption.hrc D sw/source/ui/frmdlg/cption.src A sw/uiconfig/swriter/ui/captionoptions.ui 9 files changed, 395 insertions(+), 255 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1312 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I58dbb70faf22c5958b65e5192664b7d12d62f04c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fix variable naming
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1298 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1298/1 fix variable naming Changed to pointers by fdb7fe63db5ba17036a71fe4f7f25f834bef8f95 but names not updated Change-Id: I45d04c209842a26fb731ad495e969c9477a6984d --- M svx/inc/svx/compressgraphicdialog.hxx M svx/source/dialog/compressgraphicdialog.cxx 2 files changed, 70 insertions(+), 70 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1298 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45d04c209842a26fb731ad495e969c9477a6984d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#38895 fix toggling of numbering separator on Autocaption...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1272 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/1272/1 fdo#38895 fix toggling of numbering separator on Autocaption page Only enable the Edit box if the overall option is enabled Change-Id: Ica0f973d22b89a37bd690c285d7cc0ae5204b7a8 --- M sw/source/ui/config/optload.cxx 1 file changed, 10 insertions(+), 2 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1272 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ica0f973d22b89a37bd690c285d7cc0ae5204b7a8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] don't display caption number separator on category 'None'
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1265 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/1265/1 don't display caption number separator on category 'None' Change-Id: Id01fb900a3e558d5f9d4613e18f3761cf6a670bf --- M sw/source/ui/frmdlg/cption.cxx 1 file changed, 6 insertions(+), 1 deletion(-) -- To view, visit https://gerrit.libreoffice.org/1265 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id01fb900a3e558d5f9d4613e18f3761cf6a670bf Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] migrate 'Insert Caption' dialog to .ui file
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1266 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/1266/1 migrate 'Insert Caption' dialog to .ui file Change-Id: I490c8057f1263f12f50b59c97ca9807138daab5d --- M sw/UI_swriter.mk M sw/inc/globals.hrc M sw/source/ui/app/app.src M sw/source/ui/config/optload.cxx M sw/source/ui/frmdlg/cption.cxx M sw/source/ui/frmdlg/cption.hrc M sw/source/ui/frmdlg/cption.src M sw/source/ui/inc/cption.hxx M sw/source/ui/inc/optload.hxx A sw/uiconfig/swriter/ui/insertcaption.ui 10 files changed, 560 insertions(+), 376 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1266 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I490c8057f1263f12f50b59c97ca9807138daab5d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: String... and dots
I wonder - could we not provide some compile-time lint tool for this to catch warn/fail on bad strings ? presumably that would solve the problem permanently in a way that doens't require lots of ongoing care ? :-) Also are they 3 stops or unicode ellipsis? This would also catch that. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] clarify ui warnings in builder
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1230 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/1230/1 clarify ui warnings in builder Change-Id: I3d55ba0e8d284a69d6ce7d3d7ec49d4ab5d9b682 --- M vcl/inc/vcl/builder.hxx 1 file changed, 3 insertions(+), 3 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1230 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d55ba0e8d284a69d6ce7d3d7ec49d4ab5d9b682 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
migrate 'Insert Footnote' dialog to .ui file
Jack Leigh has abandoned this change. Change subject: migrate 'Insert Footnote' dialog to .ui file .. Patch Set 1: Abandoned Doesn't depend on Ifed2349d -- To view, visit https://gerrit.libreoffice.org/1193 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If16285d85bca187b2e929f0327b15f103b5d786f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
migrate 'Insert Footnote' dialog to .ui file
Jack Leigh has restored this change. Change subject: migrate 'Insert Footnote' dialog to .ui file .. Patch Set 1: Restored Try to push rebased version -- To view, visit https://gerrit.libreoffice.org/1193 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: If16285d85bca187b2e929f0327b15f103b5d786f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
migrate 'Insert Bookmark' dialog to .ui file
Jack Leigh has abandoned this change. Change subject: migrate 'Insert Bookmark' dialog to .ui file .. Patch Set 1: Abandoned Uploaded as 1199 -- To view, visit https://gerrit.libreoffice.org/1192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifed2394dcfb7eefa4ab259b5e197081206249fee Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se Gerrit-Reviewer: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] migrate 'Insert Bookmark' dialog to .ui file
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1199 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/1199/1 migrate 'Insert Bookmark' dialog to .ui file STR_REMOVE_WARNING moved to globals.hrc so also misc.hrc no longer required in swrenamexnameddlg.cxx Change-Id: I5c34c14df36a78133ff08c0f2f0ce1a01292067f --- M sw/AllLangResTarget_sw.mk M sw/UI_swriter.mk M sw/inc/globals.hrc M sw/source/ui/app/app.src M sw/source/ui/cctrl/swlbox.cxx M sw/source/ui/inc/bookmark.hxx M sw/source/ui/inc/misc.hrc M sw/source/ui/inc/swlbox.hxx M sw/source/ui/misc/bookmark.cxx D sw/source/ui/misc/bookmark.hrc D sw/source/ui/misc/bookmark.src M sw/source/ui/utlui/swrenamexnameddlg.cxx A sw/uiconfig/swriter/ui/insertbookmark.ui 13 files changed, 159 insertions(+), 152 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1199 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5c34c14df36a78133ff08c0f2f0ce1a01292067f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] migrate 'Insert Bookmark' dialog to .ui file
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1192 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/1192/1 migrate 'Insert Bookmark' dialog to .ui file Change-Id: Ifed2394dcfb7eefa4ab259b5e197081206249fee --- M sw/UI_swriter.mk M sw/source/ui/cctrl/swlbox.cxx M sw/source/ui/inc/bookmark.hxx M sw/source/ui/inc/swlbox.hxx M sw/source/ui/misc/bookmark.cxx A sw/uiconfig/swriter/ui/insertbookmark.ui 6 files changed, 159 insertions(+), 38 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifed2394dcfb7eefa4ab259b5e197081206249fee Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] migrate 'Insert Footnote' dialog to .ui file
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1193 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/1193/1 migrate 'Insert Footnote' dialog to .ui file Change-Id: If16285d85bca187b2e929f0327b15f103b5d786f --- M sw/AllLangResTarget_sw.mk M sw/UI_swriter.mk M sw/inc/globals.hrc M sw/source/ui/app/app.src M sw/source/ui/inc/insfnote.hxx M sw/source/ui/misc/insfnote.cxx D sw/source/ui/misc/insfnote.hrc D sw/source/ui/misc/insfnote.src A sw/uiconfig/swriter/ui/insertfootnote.ui 9 files changed, 420 insertions(+), 260 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1193 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If16285d85bca187b2e929f0327b15f103b5d786f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Migrate 'Insert Script' dialog to .ui file
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1152 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/1152/1 Migrate 'Insert Script' dialog to .ui file Change-Id: Icd3cd8579e9fa8fa4d01fc234317b3b0b03525aa --- M sw/UI_swriter.mk M sw/source/ui/fldui/javaedit.cxx M sw/source/ui/fldui/javaedit.hrc M sw/source/ui/fldui/javaedit.src M sw/source/ui/inc/javaedit.hxx A sw/uiconfig/swriter/ui/insertscript.ui 6 files changed, 339 insertions(+), 203 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1152 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd3cd8579e9fa8fa4d01fc234317b3b0b03525aa Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jack Leigh leigh...@gmx.se ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ATTENTION] the merge of the submodules feature has been done... now on master
On 18/10/12 01:44, Norbert Thiebaud wrote: Yes, that was a mistake... this should be fixed now Still get: $ ./g pull -r remote: Counting objects: 40, done. remote: Compressing objects: 100% (24/24), done. remote: Total 24 (delta 16), reused 0 (delta 0) Unpacking objects: 100% (24/24), done. From git://anongit.freedesktop.org/libreoffice/core 1db74c1..72dacbb master - origin/master First, rewinding head to replay your work on top of it... Fast-forwarded master to 72dacbb9d0b28140b805aec7d28a6e085609161c. fatal: reference is not a tree: 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5 Unable to checkout '6b8392485c4b81d0a398a8c88a0e1f7ab53365f5' in submodule path 'helpcontent2' Cheers ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ATTENTION] the merge of the submodules feature has been done... now on master
On 18/10/12 11:37, Norbert Thiebaud wrote: On Thu, Oct 18, 2012 at 4:08 AM, Jack Leigh leigh...@gmx.se wrote: Still get: fatal: reference is not a tree: 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5 Unable to checkout '6b8392485c4b81d0a398a8c88a0e1f7ab53365f5' in submodule path 'helpcontent2' OK.. so do: rm -fr helpcontent2 rm src.downloaded make fetch That works. Thanks. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ATTENTION] the merge of the submodules feature has been done... now on master
On 18/10/12 11:37, Norbert Thiebaud wrote: On Thu, Oct 18, 2012 at 4:08 AM, Jack Leigh leigh...@gmx.se wrote: Still get: fatal: reference is not a tree: 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5 Unable to checkout '6b8392485c4b81d0a398a8c88a0e1f7ab53365f5' in submodule path 'helpcontent2' OK.. so do: rm -fr helpcontent2 rm src.downloaded make fetch Was also getting 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5-dirty in git diff. Looks like a cd helpcontent2/ git reset --hard HEAD might have fixed that? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ATTENTION] the merge of the submodules feature has been done... now on master
Hi, Just now getting: $ ./g pull -r remote: Counting objects: 1134, done. remote: Compressing objects: 100% (486/486), done. remote: Total 695 (delta 483), reused 322 (delta 175) Receiving objects: 100% (695/695), 716.75 KiB | 295 KiB/s, done. Resolving deltas: 100% (483/483), completed with 188 local objects. From git://anongit.freedesktop.org/libreoffice/core 42e9659..1db74c1 master - origin/master 358c53f..1bc1530 libreoffice-3-6 - origin/libreoffice-3-6 Fetching submodule dictionaries remote: Counting objects: 7, done. remote: Compressing objects: 100% (5/5), done. remote: Total 5 (delta 3), reused 0 (delta 0) Unpacking objects: 100% (5/5), done. From git://anongit.freedesktop.org/libreoffice/dictionaries 0493c1b..a70847f master - origin/master Fetching submodule helpcontent2 remote: Counting objects: 7, done. remote: Compressing objects: 100% (5/5), done. remote: Total 5 (delta 3), reused 0 (delta 0) Unpacking objects: 100% (5/5), done. From git://anongit.freedesktop.org/libreoffice/dictionaries 0493c1b..a70847f master - origin/master First, rewinding head to replay your work on top of it... Fast-forwarded master to 1db74c175056148865020db5e23e265e85909914. Submodule path 'dictionaries': checked out 'a70847fe89812a53297f06e5c8c5ef9a22146a7f' fatal: reference is not a tree: 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5 Unable to checkout '6b8392485c4b81d0a398a8c88a0e1f7ab53365f5' in submodule path 'helpcontent2' Cheers, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: New Easy Hack Tracking System -- Developer Input Required
Joel, I have just been adding ProposedEasyHack whiteboard status which I think is easier that having to add it to a wiki page too. A query on bugzilla for NEW bugs with that status gives 48 results. I think we just need a/some developer(s) to commit to checking that list every so often and making the transition. Cheers, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Bibisect Question
In the table there is a column, 'bugs need bisecting'. Not admittedly very clear. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] New Easy Hack Tracking System -- Developer Input Required
Joel, I have just been adding ProposedEasyHack whiteboard status which I think is easier that having to add it to a wiki page too. A query on bugzilla for NEW bugs with that status gives 48 results. I think we just need a/some developer(s) to commit to checking that list every so often and making the transition. Cheers, Jack ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: sal/config.g sal/types.h and sal/osl/rtl includes in general
On 20/09/12 11:12, Norbert Thiebaud wrote: On Thu, Sep 20, 2012 at 4:00 AM, Lubos Lunak l.lu...@suse.cz wrote: On Wednesday 19 of September 2012, Norbert Thiebaud wrote: So there is no automatic way to verify that an include set is 'minimal', but there isn't even a way to do that with eyeballing... Actually, there possibly is an automatic way to do that: http://code.google.com/p/include-what-you-use/ . I haven't tried it though. thanks... looks like exactly what we need... /me will have to build a clang and build that plugin to try it :-) norbert https://bugs.freedesktop.org/show_bug.cgi?id=42949 accelerating compile times ... is the bug Michael mentioned. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Esc Call Notes
Thanks Joel, nice job. Currently finishing up my Masters project so don't have a lot of time but should be able to get involved for a blitz after Sept. Maybe will try and get my 5 a day until then :P Cheers, Jack ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
License statement
Dear all, All of my contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Thanks, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License statement
Dear all, All of my contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Thanks, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build problem on Linux 3.0; plea for workflow
In nss, security/coreconf they reference e.g. Linux2.6.mk. Building on 3.0.0 this fails because there is no Linux3.0.mk. All that would be needed to fix this is copy Linux2.6.mk to Linux3.0.mk. The workflow for your builds is unusual in that it unpacks the subsidiary tarballs and charges right into building things. In a normal build workflow, you would have untar, possible patch, configure, possible patch, make. In your workflow, there is no opportunity to get control back for even the simplest of workarounds. If there is a way to do site-local patches in your workflow between the unpacking and the building steps, I haven't found it documented. I beg you to think this over and decide to do something about it. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
