Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source

2011-10-27 Thread Terrence Enger
On Tue, 2011-10-25 at 09:16 +0200, Stephan Bergmann wrote: In general, and if the expression's value is not used, prefix increment/decrement is preferable to postfix, as the former conceptually avoids creation of a temporary that makes the old, unmodified value available as the

Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source

2011-10-25 Thread Stephan Bergmann
On 10/25/2011 04:04 AM, Kevin Hunter wrote: At 9:48pm -0400 Mon, 24 Oct 2011, Kevin Hunter wrote: At 7:24pm -0400 Mon, 24 Oct 2011, Fridrich Štrba wrote: for (std::mapWPXString, FontStyle *, ltstr::const_iterator iter = mHash.begin(); - iter != mHash.end(); ++iter) + iter != mHash.end();

Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source

2011-10-25 Thread Fridrich Strba
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Actually, the post/preincrement change was an accidental one. The problem I have is that the writeperfect source code lives in two different places. The original code lives in sourceforge.new/projects/libwpd as writerperfect module. That one produces

Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source

2011-10-24 Thread Kevin Hunter
At 7:24pm -0400 Mon, 24 Oct 2011, Fridrich Štrba wrote: New commits: commit 38cf494f90d19d1673773437cd52e8f0cfbf4eb5 Author: Fridrich Štrba fridrich.st...@bluewin.ch Date: Tue Oct 25 01:11:49 2011 +0200 White-space change to fix messy mix of different coding styles [...] diff --git

Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source

2011-10-24 Thread Kevin Hunter
At 9:48pm -0400 Mon, 24 Oct 2011, Kevin Hunter wrote: At 7:24pm -0400 Mon, 24 Oct 2011, Fridrich Štrba wrote: for (std::mapWPXString, FontStyle *, ltstr::const_iterator iter = mHash.begin(); - iter != mHash.end(); ++iter) + iter != mHash.end(); iter++) Err, in terms of coding style, is a pre